id stringlengths 29 30 | content stringlengths 152 2.6k |
|---|---|
codereview_new_java_data_6585 | public class SsoAccessToken implements SdkToken {
private final Instant expiresAt;
private SsoAccessToken(BuilderImpl builder) {
- Validate.paramNotNull(builder.accessToken, "accessToken");
- Validate.paramNotNull(builder.expiresAt, "expiresAt");
- this.accessToken = builder.accessToke... |
codereview_new_java_data_6586 | public Builder profile(Profile profile) {
/**
* *
- * @param profileFile : ProfileFile that has the profile which is used to create the credential provider.
- * This is required to fetch the titles like sso-session defined in profile property*
- * ... |
codereview_new_java_data_6587 |
package software.amazon.awssdk.services.cloudfront.internal.auth;
import java.util.Arrays;
public enum PemObjectType {
PRIVATE_KEY_PKCS1("-----BEGIN RSA PRIVATE KEY-----"),
PRIVATE_KEY_PKCS8("-----BEGIN PRIVATE KEY-----"),
Internal Sdk annotation missing
package software.amazon.awssdk.services.clo... |
codereview_new_java_data_6588 |
import software.amazon.awssdk.utils.builder.CopyableBuilder;
import software.amazon.awssdk.utils.builder.ToCopyableBuilder;
@SdkPublicApi
public interface CookiesForCannedPolicy extends SignedCookie,
ToCopyableBuilder<CookiesForCannedPolicy.Builder, CookiesForCann... |
codereview_new_java_data_6589 |
import software.amazon.awssdk.utils.Validate;
/**
- * The class is used for Response Handling and Parsing the metadata fetched by the get call in the {@link Ec2MetadataClient}
* interface.
* The class provides convenience methods to the users to parse the metadata as a String, List and Document.
*/
Nit: Can... |
codereview_new_java_data_6590 | static Ec2MetadataAsyncClient.Builder builder() {
}
/**
- * The builder definition for a {@link Ec2MetadataClient}.
*/
interface Builder {
Can we describe in the javadocs if the parameter is optional and if so what the default value is??
Maybe something along the lines of
_Define th... |
codereview_new_java_data_6591 | private Ec2MetadataEndpointProvider(Builder builder) {
/**
* Resolve the endpoint to be used for the {@link DefaultEc2MetadataClient} client. Users may manually provide an endpoint
- * through the {@code AWS_EC2_METADATA_SERVICE_ENDPOINT} environment variable or th {@code ec2_metadata_service_endpoint... |
codereview_new_java_data_6592 |
import software.amazon.awssdk.utils.Validate;
/**
- * The class is used for Response Handling and Parsing the metadata fetched by the get call in the {@link Ec2MetadataClient}
* interface.
* The class provides convenience methods to the users to parse the metadata as a String, List and Document.
*/
Nit: cha... |
codereview_new_java_data_6593 |
@SdkPublicApi
public enum EndpointMode {
- IPV4("http://169.254.169.254"),
- IPV6("http://[fd00:ec2::254]");
-
- public final String serviceEndpoint;
-
- EndpointMode(String serviceEndpoint) {
- this.serviceEndpoint = serviceEndpoint;
- }
-
- // public String getServiceEndpoint() {
- //... |
codereview_new_java_data_6594 | public CompletableFuture<Void> execute(AsyncExecuteRequest asyncRequest) {
paramNotNull(asyncRequest.requestContentPublisher(), "RequestContentPublisher");
paramNotNull(asyncRequest.responseHandler(), "ResponseHandler");
- MetricCollector metricCollector = asyncRequest.metricCollector().orEl... |
codereview_new_java_data_6595 | private CrtRequestContext(Builder builder) {
this.request = builder.request;
this.readBufferSize = builder.readBufferSize;
this.crtConnPool = builder.crtConnPool;
-
- if (this.request.metricCollector().isPresent()) {
- this.metricCollector = this.request.metricCollector().g... |
codereview_new_java_data_6596 |
* small parts from a single object. The Transfer Manager is built on top of the Java bindings of the AWS Common Runtime S3 client
* and leverages Amazon S3 multipart upload and byte-range fetches for parallel transfers.
*
- * <h1>Instantiate a Transfer Manager</h1>
- * <b>Create a transfer manager with SDK defau... |
codereview_new_java_data_6597 | private Function<String, Instant> safeParseDate(Function<String, Instant> dateUn
@Override
public Map<String, Object> unmarshall(JsonNode jsonContent, SdkField<?> field) {
- if (jsonContent == null || jsonContent.isNull()) {
return null;
}
Query : jsonCon... |
codereview_new_java_data_6598 | private void attemptExecute(CompletableFuture<Response<OutputT>> future) {
if (exception instanceof Error) {
future.completeExceptionally(exception);
} else {
- maybeRetryExecute(future, (Exception) exception);
... |
codereview_new_java_data_6599 | private URI endpointFromConfig(SdkClientConfiguration config) {
.withRegion(config.option(AwsClientOption.AWS_REGION))
.withProfileFile(() -> config.option(SdkClientOption.PROFILE_FILE))
.withProfileName(config.option(SdkClientOption.PROFILE_NAME))
// .putAdvancedOpt... |
codereview_new_java_data_6600 | default B serviceConfiguration(Consumer<ServiceConfiguration.Builder> serviceCon
return serviceConfiguration(ServiceConfiguration.builder().applyMutation(serviceConfiguration).build());
}
B endpointProvider(JsonEndpointProvider endpointProvider);
}
Should we add Javadoc?
default B serviceConfi... |
codereview_new_java_data_6601 | public enum ProxySystemSetting implements SystemSetting {
HTTPS_PROXY_HOST("https.proxyHost"),
HTTPS_PROXY_PORT("https.proxyPort"),
- HTTPS_NON_PROXY_HOSTS("https.nonProxyHosts"),
HTTPS_PROXY_USERNAME("https.proxyUser"),
HTTPS_PROXY_PASSWORD("https.proxyPassword")
;
I don't think we nee... |
codereview_new_java_data_6602 | private static String getMessageForTooManyAcquireOperationsError() {
+ "Consider taking any of the following actions to mitigate the issue: increase max connections, "
+ "increase max pending acquire count, decrease connection acquisition timeout, or "
- + "slowing the r... |
codereview_new_java_data_6603 | public static long calculateStreamContentLength(long originalLength, long defaul
long allChunks = maxSizeChunks * calculateChunkLength(defaultChunkSize);
long remainingInChunk = remainingBytes > 0 ? calculateChunkLength(remainingBytes) : 0;
- long lastByteSize = (long) "0".length() + (long) ... |
codereview_new_java_data_6604 |
public class ParameterModel {
private String type;
public String getType() {
return type;
}
Can we have a java doc since its not clear what does Type signifies here.
public class ParameterModel {
private String type;
+ /**
+ * The type of this parameter. Currently, only "bo... |
codereview_new_java_data_6605 | public static Endpoint fromNode(JsonNode node) {
headersNode.asObject()
.forEach((k, v) -> v.asArray().forEach(e -> b.addHeader(k, e.asString())));
}
- // ObjectNode on = node.expectObjectNode("endpoints are object nodes");
- // on.expectNoAdditi... |
codereview_new_java_data_6606 | public void stringBufferAttributeConverterBehaves() {
public void localeAttributeConverterBehaves() {
LocaleAttributeConverter converter = LocaleAttributeConverter.create();
- assertThat(transformFrom(converter, Locale.US).s()).isEqualTo(Locale.US);
assertThat(transformTo(converter, f... |
codereview_new_java_data_6607 |
import software.amazon.awssdk.protocols.jsoncore.JsonNodeVisitor;
@SdkInternalApi
-public class DocumentUnmarshaller implements JsonNodeVisitor<Document> {
@Override
public Document visitNull() {
return Document.fromNull();
Should be `final`. We should also have tests for this.
import softwa... |
codereview_new_java_data_6608 | private int statusCode(SdkHttpFullResponse response, Optional<ExceptionMetadata>
return response.statusCode();
}
- if (modeledExceptionMetadata.isPresent()) {
- ExceptionMetadata md = modeledExceptionMetadata.get();
-
- if (md.httpStatusCode() != null) {
- ... |
codereview_new_java_data_6609 |
/**
* Interface for specifying a retry policy to use when evaluating whether or not a request should be retried , and the gap
* between each retry. The {@link #builder()} can be used to construct a retry policy with numRetries and backoffStrategy.
* When using the {@link #builder()} the SDK will use default val... |
codereview_new_java_data_6610 | private void acceptNewConnection() {
LOGGER.warn("Failed to accept incoming connection.", e);
}
} else {
- // TODO fix with try-with-resource for the return value of .channel
LOGGER.error("Not acceptable selection: " + selected.channel());
}
}
TODOs... |
codereview_new_java_data_6657 | protected List<String> normalizeRelatorStringList(List<String> stringList)
*/
protected String normalizeRelatorString(String string)
{
for (String prefix : relatorPrefixesToStrip) {
if (string.startsWith(prefix)) {
string = string.substring(prefix.length());
... |
codereview_new_java_data_6671 | protected List<String> getFormatsAsList(Record record) {
result.add("ConferenceProceeding");
}
- // check the 33x fields; these may give us clear information in newer records
- // and if we find something here, it currently indicates non-book content.
List formatsFrom33x ... |
codereview_new_java_data_6702 | protected List<LinkedHashMap<String, String>> getRows() {
}
private void defaultVal(LinkedHashMap<String, String> rows) {
String delayDatabase = rows.get(DELAY_DATABASE);
rows.put(DELAY_DATABASE, String.valueOf(delayDatabase));
}
don't understand here
protected List<LinkedHashMap<... |
codereview_new_java_data_6703 | private static void backLog(List<ErrorInfo> list) {
Collection<PhysicalDbInstance> values = allDbInstanceMap.values();
for (PhysicalDbInstance instance : values) {
int minCon = instance.getConfig().getMinCon() / 3;
int backLog = minCon;
key... |
codereview_new_java_data_6704 | void handleEndPacket(MySQLPacket curPacket, AutoTxOperation txOperation, boolean
if (txOperation == AutoTxOperation.COMMIT) {
session.checkBackupStatus();
session.setBeginCommitTime();
- handler.commit(null);
} else {
service.g... |
codereview_new_java_data_6705 | public SqlDumpLog() {
}
public void verify() {
if (!sqlDumpLogSizeBasedRotate.equals("-1")) {
sqlDumpLogSizeBasedRotate = FileSize.parse(sqlDumpLogSizeBasedRotate, 52428800L) + "";
}
Add comments for magic number
public SqlDumpLog() {
}
public void verify() {
+... |
codereview_new_java_data_6706 | public static void updateSharedContent(SharedContentArray values, boolean save)
if (wasFolderUpdate) {
// Rescan to add/remove Media Library content
- if (CONFIGURATION.getUseCache() && !LibraryScanner.isScanLibraryRunning()) {
LibraryScanner.scanLibrary();
}
}
Shouldn't the current... |
codereview_new_java_data_6707 |
package net.pms.configuration;
import static org.apache.commons.lang3.StringUtils.isBlank;
-
import java.nio.file.Files;
import java.nio.file.InvalidPathException;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.concurrent.locks.ReentrantReadWriteLock;
-
import javax.annotation.Nonnul... |
codereview_new_java_data_6708 | protected String[] getDefaultArgs() {
defaultArgsList.add("format=mpegts");
}
- if (isTranscodeToH264) {
defaultArgsList.add("-mpegopts");
defaultArgsList.add("format=mpeg2:muxrate=500000:vbuf_size=1194:abuf_size=64");
}
```suggestion
if (!isTranscodeToH264) {
```
protected String[] getDefa... |
codereview_new_java_data_6709 | public static JsonObject getTvSeriesMetadataAsJsonObject(final Connection connec
VideoMetadataLocalized loc = MediaTableVideoMetadataLocalized.getVideoMetadataLocalized(connection, id, true, lang, imdbID, "tv", tmdbId, null, null);
if (loc != null) {
loc.localizeJsonObject(result);
- //... |
codereview_new_java_data_6710 | public static final void parseFileForDatabase(File file) {
try (RandomAccessFile srcFile = new RandomAccessFile(file, "rw")) {
// no exception happened, so we can continue
} catch (Exception e) {
- /**
- * This will happen a lot (every 500ms) for files that are being
- * copied/moved. Eventually the ... |
codereview_new_java_data_6711 | public void addChild(DLNAResource child, boolean isNew, boolean isAddGlobally) {
* given renderer, and return the relevant engine or null as appropriate.
*
* @param renderer The target renderer
- * @return A engine if transcoding or null if streaming
*/
public Engine resolveEngine(RendererConfiguration ... |
codereview_new_java_data_6712 | public static void deleteSubs() {
* } and any ASS tags <code>
* {\*}
* </code> from subtitles file for renderers not capable of showing SubRip
- * tags correctly.* is used as a wildcard in the definition above.
*
* @param file the source subtitles
* @return InputStream with converted subtitles.
```... |
codereview_new_java_data_6760 |
*/
public interface Saml2AuthenticationRequestResolver {
<T extends AbstractSaml2AuthenticationRequest> T resolve(HttpServletRequest request);
}
Please call this `DEFAULT_AUTHENTICATION_REQUEST_URI`, removing `SAML` and changing `URL` to `URI`. This follows more closely the same name found in `OAuth2Authori... |
codereview_new_java_data_6833 | private void scanAvailableControllerAddresses() {
for (String address : controllerAddresses) {
scanExecutor.submit(new Runnable() {
- @Override public void run() {
if (brokerOuterAPI.checkAddressCanConnect(address)) {
availableControl... |
codereview_new_java_data_6834 | public static void sleep(long timeOut, TimeUnit timeUnit) {
}
try {
timeUnit.sleep(timeOut);
- } catch (InterruptedException ignored) {
}
}
The new version is not equivalent to current version. IMO more relevant analysis is necessary to confirm this modification w... |
codereview_new_java_data_6835 |
import org.apache.rocketmq.store.tiered.common.TieredMessageStoreConfig;
import org.apache.rocketmq.store.tiered.common.TieredStoreExecutor;
import org.apache.rocketmq.store.tiered.container.TieredContainerManager;
-import org.apache.rocketmq.store.tiered.container.TieredFileSegment;
import org.apache.rocketmq.sto... |
codereview_new_java_data_6836 | public AppendResult appendIndexFile(DispatchRequest request) {
if (closed) {
return AppendResult.FILE_CLOSED;
}
// AppendResult result = indexFile.append(messageQueue, request.getOffsetId(), request.getCommitLogOffset(), request.getMsgSize(), request.getStoreTimestamp());
// ... |
codereview_new_java_data_6837 | private void pollBatchDispatchRequest() {
batchDispatchRequestQueue.poll();
}
} catch (Exception e) {
- LOGGER.warn(e.getMessage());
}
}
like DefaultMessageStore.LOGGER.warn(this.getServiceName() + " service has exception. ", e... |
codereview_new_java_data_6838 | public void shutdown() {
super.shutdown();
}
- @Override
- public void run() {
- super.run();
- }
-
@Override
public String getServiceName() {
if (DefaultMessageStore.this.getBrokerConfig().isInBrokerContainer()) {
Remove this meth... |
codereview_new_java_data_6839 | private RemotingCommand processRequest(final Channel channel, RemotingCommand re
int queueId = requestHeader.getQueueId();
hasMsg = hasMsgFromQueue(false, requestHeader, queueId);
}
- // if it has message, fetch retry again
if (!needRetry && !hasMsg) {
To... |
codereview_new_java_data_6840 | public long estimateMessageCount(String topic, int queueId, long from, long to,
return 0;
}
long minOffset = consumeQueue.getMinOffsetInQueue();
- from = Math.max(from, minOffset);
- if (to < minOffset) {
- to = Math.min(minOffset + messageStoreConfig.getMaxCon... |
codereview_new_java_data_6841 | public class BrokerConfig extends BrokerIdentity {
private long syncControllerMetadataPeriod = 10 * 1000;
- // It is an important basis for the controller to choose the broker master. Under the same conditions,
- // the broker with higher priority will be selected as master. You can set a higher priorit... |
codereview_new_java_data_6842 | protected void shutdownScheduledExecutorService(ScheduledExecutorService schedul
scheduledExecutorService.awaitTermination(5000, TimeUnit.MILLISECONDS);
} catch (InterruptedException ignore) {
BrokerController.LOG.warn("shutdown ScheduledExecutorService was Interrupted! ", ignore);
... |
codereview_new_java_data_6843 | public class ProxyMetricsManager implements StartAndShutdown {
public static ObservableLongGauge proxyUp = null;
public static void initLocalMode(BrokerMetricsManager brokerMetricsManager, ProxyConfig proxyConfig) {
ProxyMetricsManager.proxyConfig = proxyConfig;
LABEL_MAP.put(LABEL_NODE_T... |
codereview_new_java_data_6844 | public class ProxyMetricsManager implements StartAndShutdown {
public static ObservableLongGauge proxyUp = null;
public static void initLocalMode(BrokerMetricsManager brokerMetricsManager, ProxyConfig proxyConfig) {
- if (proxyConfig.getMetricsExporterType() != BrokerConfig.MetricsExporterType.DISAB... |
codereview_new_java_data_6845 | private TopicConfig selectTopicConfig(String topic) {
}
public boolean writeOp(Integer queueId,Message message) {
- MessageQueue opQueue;
- if ((opQueue = opQueueMap.get(queueId)) == null) {
opQueue = getOpQueueByHalf(queueId, this.brokerController.getBrokerConfig().getBrokerName... |
codereview_new_java_data_6846 | private RemotingCommand getConsumeStats(ChannelHandlerContext ctx,
offsetWrapper.setBrokerOffset(brokerOffset);
offsetWrapper.setConsumerOffset(consumerOffset);
- offsetWrapper.setPullOffset(pullOffset >= 0 ? pullOffset : 0);
long timeOffset = consu... |
codereview_new_java_data_6847 | public class NamesrvConfig {
*/
private boolean enableControllerInNamesrv = false;
- private volatile boolean needWaitForService = true;
private int waitSecondsForService = 45;
Hard-coded value is not optimal, because users might adjust the interval of broker registration... Would it be bette... |
codereview_new_java_data_6848 | public TopicRouteService(MQClientAPIFactory mqClientAPIFactory) {
try {
return load(key);
} catch (Exception e) {
return oldValue;
}
}
Add a log here is better
public TopicRouteService(M... |
codereview_new_java_data_6849 | public class FileRegionEncoder extends MessageToByteEncoder<FileRegion> {
protected void encode(ChannelHandlerContext ctx, FileRegion msg, final ByteBuf out) throws Exception {
WritableByteChannel writableByteChannel = new WritableByteChannel() {
@Override
- public int write(ByteB... |
codereview_new_java_data_6850 | protected static void createTopicTo(BrokerController masterBroker, String topicN
try {
TopicConfig topicConfig = new TopicConfig(topicName, rqn, wqn, 6, 0);
defaultMQAdminExt.createAndUpdateTopicConfig(masterBroker.getBrokerAddr(), topicConfig);
- System.out.println("Creat... |
codereview_new_java_data_6851 | public BrokerController getBrokerController() {
public boolean escapeMessage(MessageExtBrokerInner messageInner) {
PutMessageResult putMessageResult = this.brokerController.getEscapeBridge().putMessage(messageInner);
- if (putMessageResult != null
- && putMessageResult.getPutMessageSt... |
codereview_new_java_data_6852 | private void sendHeartbeatToAllBroker() {
if (addr == null) {
continue;
}
- if (consumerEmpty) {
- if (id != MixAll.MASTER_ID)
- continue;
}
try {
```suggestion
... |
codereview_new_java_data_6853 | public ControllerResult<GetReplicaInfoResponseHeader> getReplicaInfo(final GetRe
result.setBody(new SyncStateSet(syncStateInfo.getSyncStateSet(), syncStateInfo.getSyncStateSetEpoch()).encode());
return result;
}
- result.setCodeAndRemark(ResponseCode.CONTROLLER_INVALID_REQUEST... |
codereview_new_java_data_6854 | public void assign(Collection<MessageQueue> messageQueues) {
@Override
public void setSubExpression4Assgin(final String topic, final String subExpresion) {
- defaultLitePullConsumerImpl.setSubExpression4Assgin(topic, subExpresion);
}
@Override
need to consider name space.
public void ... |
codereview_new_java_data_6855 | public void assign(Collection<MessageQueue> messageQueues) {
}
@Override
- public void setSubExpression4Assign(final String topic, final String subExpresion) {
- defaultLitePullConsumerImpl.setSubExpression4Assign(withNamespace(topic), subExpresion);
}
@Override
Naming is inconsisten... |
codereview_new_java_data_6856 | protected <T> RunnableFuture<T> newTaskFor(final Runnable runnable, final T valu
}
};
this.heartbeatManager = new DefaultBrokerHeartbeatManager(this.controllerConfig);
this.controller = new DLedgerController(this.controllerConfig, (cluster, brokerAddr) -> this.heartbeatManager.i... |
codereview_new_java_data_6857 | public class PlainPermissionManagerTest {
PlainAccessConfig plainAccessConfig = new PlainAccessConfig();
Set<Integer> adminCode = new HashSet<>();
- private static final String PATH = PlainPermissionManagerTest.class.getResource("/").getFile();
private static final String DEFAULT_TOPIC = "topic-a... |
codereview_new_java_data_6858 | public void setGroupPerms(List<String> groupPerms) {
public String toString() {
return "PlainAccessConfig{" +
"accessKey='" + accessKey + '\'' +
- ", secretKey='" + secretKey + '\'' +
", whiteRemoteAddress='" + whiteRemoteAddress + '\'' +
", admin=" + adm... |
codereview_new_java_data_6859 | public class DefaultMQProducer extends ClientConfig implements MQProducer {
/**
* on BackpressureForAsyncMode, limit maximum message size of on-going sending async messages
*/
- private Semaphore semaphoreAsyncSize = new Semaphore(512 * 1024 * 1024, true);
/**
* Default constructor.
... |
codereview_new_java_data_6860 | public class DefaultMQProducer extends ClientConfig implements MQProducer {
/**
* on BackpressureForAsyncMode, limit maximum message size of on-going sending async messages
*/
- private Semaphore semaphoreAsyncSize = new Semaphore(512 * 1024 * 1024, true);
/**
* Default constructor.
... |
codereview_new_java_data_6861 | private String generateKey(StringBuilder keyBuilder, MessageExt messageExt) {
public void updateMaxMessageSize(PutMessageThreadLocal putMessageThreadLocal) {
// dynamically adjust maxMessageSize, but not support DLedger mode temporarily
int newMaxMessageSize = this.defaultMessageStore.getMessage... |
codereview_new_java_data_6862 | public RemotingClient getRemotingClient() {
public String fetchNameServerAddr() {
try {
String addrs = this.topAddressing.fetchNSAddr();
- if (addrs != null && !UtilAll.isBlank(addrs)) {
if (!addrs.equals(this.nameSrvAddr)) {
log.info("name se... |
codereview_new_java_data_6863 | public void shutdown() {
public String fetchNameServerAddr() {
try {
String addrs = this.topAddressing.fetchNSAddr();
- if (addrs != null && !UtilAll.isBlank(addrs)) {
if (!addrs.equals(this.nameSrvAddr)) {
log.info("name server address change... |
codereview_new_java_data_6864 | public void shutdown() {
public String fetchNameServerAddr() {
try {
String addrs = this.topAddressing.fetchNSAddr();
- if (addrs != null && !UtilAll.isBlank(addrs)) {
if (!addrs.equals(this.nameSrvAddr)) {
log.info("name server address change... |
codereview_new_java_data_6865 | public RemotingCommand getRouteInfoByTopic(ChannelHandlerContext ctx,
byte[] content;
Boolean standardJsonOly = requestHeader.getAcceptStandardJsonOnly();
- if (request.getVersion() >= Version.V4_9_3.ordinal() || (null != standardJsonOly && standardJsonOly)) {
co... |
codereview_new_java_data_6866 | public class MixAll {
public static final long FIRST_SLAVE_ID = 1L;
public static final long CURRENT_JVM_PID = getPID();
public final static int UNIT_PRE_SIZE_FOR_MSG = 28;
- public final static int ALL_ACK_IN_SYNC_STATE_SET_NUM = -1;
public static final String RETRY_GROUP_TOPIC_PREFIX = "%RET... |
codereview_new_java_data_6867 | public void correctMinOffset(long phyMinOffset) {
}
@Override
- public void dispatch(DispatchRequest request) {
final int maxRetries = 30;
boolean canWrite = this.messageStore.getRunningFlags().isCQWriteable();
if (request.getMsgBaseOffset() < 0 || request.getBatchSize() < 0) ... |
codereview_new_java_data_6868 | public void accept(Backend.Holder h) {
llvmType = options.llvmKompileType;
break;
default:
- throw KEMException.criticalError("Non-valid argument for --llvm-kompile-type: " + options.llvmKompileType + ". Expected [main|search|library|static|python]");
... |
codereview_new_java_data_6870 | public K prettyRead(Module mod, Sort sort, CompiledDefinition def, Source source
case PROGRAM:
return def.parseSingleTerm(mod, sort, kem, files, stringToParse, source);
case RULE:
- throw KEMException.criticalError("Should have been handled directly by the kast... |
codereview_new_java_data_6877 | public void proverChecksX(Module specModule, Module mainDefModule) {
ModuleTransformer mt = ModuleTransformer.fromSentenceTransformer((m, s) -> {
if (s instanceof Rule && (s.att().contains(Att.SIMPLIFICATION()))) {
KLabel kl = m.matchKLabel((Rule) s);
- scala.colle... |
codereview_new_java_data_6887 | public CompiledDefinition run(File definitionFile, String mainModuleName, String
m.checkSorts();
if (kompileOptions.postProcess != null) {
kompiledDefinition = postProcessJSON(kompiledDefinition, kompileOptions.postProcess);
- files.saveToKompiled("jsoned.txt", kompiledDef... |
codereview_new_java_data_7088 | public XMPPPacketReader(DocumentFactory factory) {
/**
* Retrieves a collection of namespaces declared in the current element that the parser is on, that are not defined
- * in {@link #IGNORED_NAMESPACE_ON_STANZA}
*
* @param xpp the parser
* @return A collection of namespaces
- *... |
codereview_new_java_data_7089 | public void onConnect(Session session)
public void onClose(int statusCode, String reason)
{
// Handle asynchronously, to prevent deadlocks. See OF-2473.
- HttpBindManager.getInstance().getSessionManager().execute(this::closeSession);
}
@OnWebSocketMessage
You'll need to wrap this... |
codereview_new_java_data_7090 | public String getPageFunctions() {
sb.append("\tfunction toggleColumnOrder(sortColumnNumber) {\n")
// Orders based on a particular column, reversing the order if that column was already ordered on.
.append(String.format("\t\tvar formObject = document.getElementById('%s');\n", PAGINAT... |
codereview_new_java_data_7094 | private static List<Region> internalParse(
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
factory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
factory.setXIncludeAware(false);
DocumentBuilder documentBuilder = fact... |
codereview_new_java_data_7095 | public class PinpointNotificationActivityTests {
@Before
public void setup() {
- PinpointNotificationActivity.setNotificationClient((NotificationClient) null);
notificationClient = Mockito.mock(NotificationClient.class);
activityController = Robolectric.buildActivity(PinpointNotifi... |
codereview_new_java_data_7096 | private void openURL(final String url, final boolean noSchemeValidation) {
try {
pinpointContext.getApplicationContext().startActivity(intent);
} catch (ActivityNotFoundException e) {
- log.error("Couldn't find an app to open ACTION_VIEW Intent.");
}
}
Can we ... |
codereview_new_java_data_7098 | cdpSession, getDomains().target().detachFromTarget(Optional.of(id), Optional.emp
// Exceptions should not prevent closing the connection and the web driver
log.warning("Exception while detaching from target: " + e.getMessage());
}
- cdpSession = null;
}
}
This is the only bit I... |
codereview_new_java_data_7103 | public Either<WebDriverException, ActiveSession> apply(CreateSessionRequest sess
}
try {
- Capabilities mergedCapabilities =
- sessionRequest.getDesiredCapabilities().merge(this.getStereotype());
- CreateSessionRequest mergedSessionRequest = new CreateSessionRequest(
- sessionReques... |
codereview_new_java_data_7109 | public static BrowsingContextInfo fromJson(JsonInput input) {
children = input.read(LIST_OF_BROWSING_CONTEXT_INFO);
break;
- case "parent]":
parentBrowsingContext = input.read(String.class);
break;
Is the extraneous `]` intentional here?
public static BrowsingC... |
codereview_new_java_data_7110 | protected Node(Tracer tracer, NodeId id, URI uri, Secret registrationSecret) {
post("/session/{sessionId}/se/file")
.to(params -> new UploadFile(this, sessionIdFrom(params)))
.with(spanDecorator("node.upload_file")),
- get("/session/{sessionId}/file")
- .to(params -> new DownloadFi... |
codereview_new_java_data_7111 | public class NodeFlags implements HasRoles {
private String nodeImplementation = DEFAULT_NODE_IMPLEMENTATION;
@Parameter(
- names = {"--downloads-dir"},
description = "The default location wherein all browser triggered file downloads would be "
+ "available to be retrieved from. This is usually ... |
codereview_new_java_data_7112 | public class NodeFlags implements HasRoles {
private String nodeImplementation = DEFAULT_NODE_IMPLEMENTATION;
@Parameter(
- names = {"--downloads-dir"},
description = "The default location wherein all browser triggered file downloads would be "
+ "available to be retrieved from. This is usually ... |
codereview_new_java_data_7113 | public Optional<URI> getPublicGridUri() {
}
public Optional<String> getDownloadsDirectory() {
- return config.get(NODE_SECTION, "downloads-dir");
}
public Node getNode() {
```suggestion
return config.get(NODE_SECTION, "downloads-path");
```
public Optional<URI> getPublicGridUri() {
}
... |
codereview_new_java_data_7114 | public HttpResponse uploadFile(HttpRequest req, SessionId id) {
@Override
public HttpResponse downloadFile(HttpRequest req, SessionId id) {
- throw new UnsupportedOperationException("uploadFile");
}
@Override
```suggestion
throw new UnsupportedOperationException("downloadFile");
`... |
codereview_new_java_data_7115 | public Optional<URI> getPublicGridUri() {
}
}
- public Optional<String> getDownloadsDirectory() {
return config.get(NODE_SECTION, "downloads-path");
}
This code is not invoked anywhere. I believe it should be called from the `create` method in `LocalNodeFactory`.
public Optional<URI> getPublicG... |
codereview_new_java_data_7292 | public ServiceUnitStateData(ServiceUnitState state, String broker, boolean force
public static ServiceUnitState state(ServiceUnitStateData data) {
return data == null ? ServiceUnitState.Init : data.state();
}
-
- public static long versionId(ServiceUnitStateData data) {
- return data == nu... |
codereview_new_java_data_7293 | public void testClearDelayedMessagesWhenClearBacklog() throws PulsarClientExcept
Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
.topic(topic).create();
- final int messages = 10;
for (int i = 0; i < messages; i++) {
producer.newMessage().del... |
codereview_new_java_data_7294 | public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws E
// At default info level, suppress all subsequent exceptions that are thrown when the connection has already
// failed
if (log.isDebugEnabled()) {
- log.debug("[{}] Got exception: {}",... |
codereview_new_java_data_7295 | private void closeConsumerTasks() {
stats.getStatTimeout().ifPresent(Timeout::cancel);
// Execute "clearIncomingMessages" regardless of whether "internalPinnedExecutor" has shutdown or not.
// Call "clearIncomingMessages" in "internalPinnedExecutor" is used to clear messages in flight.
- ... |
codereview_new_java_data_7296 | private void closeConsumerTasks() {
stats.getStatTimeout().ifPresent(Timeout::cancel);
// Execute "clearIncomingMessages" regardless of whether "internalPinnedExecutor" has shutdown or not.
// Call "clearIncomingMessages" in "internalPinnedExecutor" is used to clear messages in flight.
... |
codereview_new_java_data_7297 | public String toString() {
* by {@param itemAfterTerminatedHandler}.
*/
public void terminate(@Nullable Consumer<T> itemAfterTerminatedHandler) {
- terminated = true;
- if (itemAfterTerminatedHandler != null) {
- this.itemAfterTerminatedHandler = itemAfterTerminatedHandler;
- ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.