diff stringlengths 136 4.7k | msg stringlengths 9 207 | vccs_msg stringlengths 0 6.14k | pdg_diff stringlengths 54 30.7k | type int64 0 4 | diff_seq stringlengths 71 2.45k |
|---|---|---|---|---|---|
--- tools/tpm2_hmac.c
+++ tools/tpm2_hmac.c
@@ -208,7 +208,7 @@ static bool init(int argc, char *argv[], tpm_hmac_ctx *ctx) {
}
/*
- * Options g, i, o must be specified and k or c must be specified.
+ * Options g, I, o must be specified and k or c must be specified.
*/
if (!((flags.k || f... | tpm2_hmac: fix option comment | --- tools/tpm2_hmac.c
+++ tools/tpm2_hmac.c
@@ -208,7 +208,7 @@ static bool init(int argc, char *argv[], tpm_hmac_ctx *ctx) {
- * Options g, i, o must be specified and k or c must be specified.
+ * Options g, I, o must be specified and k or c must be specified.
| 4 | --- tools/tpm2_hmac.c
+++ tools/tpm2_hmac.c
@@ -208,7 +208,7 @@ static bool init(int argc, char *argv[], tpm_hmac_ctx *ctx) {
- * Options g, i, o must be specified and k or c must be specified.
+ * Options g, I, o must be specified and k or c must be specified.
| |
--- tools/tpm2_getmanufec.c
+++ tools/tpm2_getmanufec.c
@@ -235,6 +235,12 @@ int createEKHandle(TSS2_SYS_CONTEXT *sapi_context)
LOG_INFO("EK create succ.. Handle: 0x%8.8x", handle2048ek);
if (!ctx.non_persistent_read) {
+
+ if (!ctx.persistent_handle) {
+ LOG_ERR("Persistent handle for EK ... | tpm2_getmanufec: only attempt to persist the EK if a handle was provided | tpm2_getmanufec: fix NULL pointer dereference due missing password options
option fixing: move to single getopt
port tpm2_getmanufec to use common infrastructure #151
Add -X option to enable Hex format password | --- tools/tpm2_getmanufec.c
+++ tools/tpm2_getmanufec.c
int createEKHandle(TSS2_SYS_CONTEXT *sapi_context)
sessionData.sessionHandle = ctx.auth_session_handle;
if (ctx.endorse_passwd && strlen(ctx.endorse_passwd) > 0) {
if (!ctx.hex_passwd) {
memcpy(&sessionData.hmac.t.buffer[0], ctx.end... | 0 | --- tools/tpm2_getmanufec.c
+++ tools/tpm2_getmanufec.c
@@ -235,6 +235,12 @@ int createEKHandle(TSS2_SYS_CONTEXT *sapi_context)
+
+ if (!ctx.persistent_handle) {
+ LOG_ERR("Persistent handle for EK was not provided");
+ return 1;
+ }
+
|
--- tools/tpm2_import.c
+++ tools/tpm2_import.c
@@ -161,6 +161,7 @@ static bool encrypt_seed_with_tpm2_rsa_public_key(void) {
return false;
}
return_code = RSA_generate_key_ex(rsa, 2048, bne, NULL);
+ BN_free(bne);
if (return_code != 1) {
LOG_ERR("RSA_generate_key_ex failed\n");
... | tpm2_import: free exponent BIGNUM after RSA_generate_key_ex() call | tpm2_import: check if BIGNUM and RSA allocations failed
[WIP] tpm2_import: new tool that uses tpm2_import to import a key | --- tools/tpm2_import.c
+++ tools/tpm2_import.c
static bool encrypt_seed_with_tpm2_rsa_public_key(void) {
if (!rsa) {
return_code = RSA_generate_key_ex(rsa, 2048, bne, NULL);
+ BN_free(bne);
if (n == NULL) {
- BN_free(bne);
| 0 | --- tools/tpm2_import.c
+++ tools/tpm2_import.c
@@ -161,6 +161,7 @@ static bool encrypt_seed_with_tpm2_rsa_public_key(void) {
+ BN_free(bne);
@@ -178,7 +179,6 @@ static bool encrypt_seed_with_tpm2_rsa_public_key(void) {
- BN_free(bne);
|
--- tools/tpm2_verifysignature.c
+++ tools/tpm2_verifysignature.c
@@ -194,6 +194,14 @@ static bool init(tpm2_verifysig_ctx *ctx) {
/* If no digest is specified, compute it */
if (!ctx->flags.digest) {
+ if (!ctx->flags.msg) {
+ /*
+ * This is a redundant check since main() chec... | tpm2_verifysignature: ensure msg is not null | tpm2_verifysignature: port to use new common infrastructure | --- tools/tpm2_verifysignature.c
+++ tools/tpm2_verifysignature.c
static bool init(tpm2_verifysig_ctx *ctx) {
bool res = generate_signature(ctx);
if (!ctx->flags.digest) {
+ if (!ctx->flags.msg) {
+ /*
+ * This is a redundant check since main() checks this case, but we'll ad... | 0 | --- tools/tpm2_verifysignature.c
+++ tools/tpm2_verifysignature.c
@@ -194,6 +194,14 @@ static bool init(tpm2_verifysig_ctx *ctx) {
+ if (!ctx->flags.msg) {
+ /*
+ * This is a redundant check since main() checks this case, but we'll add it here to silence any
+ * complainers.
+ ... |
--- lib/tpm2_tcti_ldr.c
+++ lib/tpm2_tcti_ldr.c
@@ -55,7 +55,7 @@ const TSS2_TCTI_INFO *tpm2_tcti_ldr_getinfo(void) {
bool tpm2_tcti_ldr_is_tcti_present(const char *name) {
char path[PATH_MAX];
- snprintf(path, sizeof(path), "libtss2-tcti-%s.so", name);
+ snprintf(path, sizeof(path), "libtss2-tcti-%s.so.0... | tcti_ldr: load a specific so version | tools: version show default TCTI | --- lib/tpm2_tcti_ldr.c
+++ lib/tpm2_tcti_ldr.c
bool tpm2_tcti_ldr_is_tcti_present(const char *name) {
- snprintf(path, sizeof(path), "libtss2-tcti-%s.so", name);
+ snprintf(path, sizeof(path), "libtss2-tcti-%s.so.0", name);
void *handle = dlopen (path, RTLD_LAZY);
| 0 | --- lib/tpm2_tcti_ldr.c
+++ lib/tpm2_tcti_ldr.c
@@ -55,7 +55,7 @@ const TSS2_TCTI_INFO *tpm2_tcti_ldr_getinfo(void) {
- snprintf(path, sizeof(path), "libtss2-tcti-%s.so", name);
+ snprintf(path, sizeof(path), "libtss2-tcti-%s.so.0", name);
|
--- ldap/servers/slapd/back-ldbm/ldbm_bind.c
+++ ldap/servers/slapd/back-ldbm/ldbm_bind.c
@@ -76,8 +76,8 @@ ldbm_back_bind(Slapi_PBlock *pb)
case LDAP_AUTH_SIMPLE: {
Slapi_Value cv;
if (slapi_entry_attr_find(e->ep_entry, "userpassword", &attr) != 0) {
- slapi_send_ldap_result(pb, LDAP_... | Issue 4609 - CVE - info disclosure when authenticating | Ticket 49328 - Cleanup source code
Bug 1347760 - CVE-2016-4992 389-ds-base: Information disclosure via repeated use of LDAP ADD operation, etc.
Reduce the number of DN normalization
Moving NSCP Directory Server from DirectoryBranch to TRUNK, initial drop. (foxworth) | --- ldap/servers/slapd/dse.c
+++ ldap/servers/slapd/dse.c
int
if (slapi_pblock_get(pb, SLAPI_PLUGIN_PRIVATE, &pdse) < 0 ||
slapi_pblock_get(pb, SLAPI_BIND_TARGET_SDN, &sdn) < 0 ||
slapi_pblock_get(pb, SLAPI_BIND_METHOD, &method) < 0 ||
slapi_pblock_get(pb, SLAPI_BIND_CREDENTIALS, &cred) < 0)... | 0 | --- ldap/servers/slapd/back-ldbm/ldbm_bind.c
+++ ldap/servers/slapd/back-ldbm/ldbm_bind.c
@@ -76,8 +76,8 @@ ldbm_back_bind(Slapi_PBlock *pb)
- slapi_send_ldap_result(pb, LDAP_INAPPROPRIATE_AUTH, NULL,
- NULL, 0, NULL);
+ slapi_pblock_set(pb, SLAPI_PB_RESULT_TEXT, ... |
--- ldap/servers/slapd/back-ldbm/ldbm_config.c
+++ ldap/servers/slapd/back-ldbm/ldbm_config.c
@@ -1243,7 +1243,7 @@ ldbm_config_search_entry_callback(Slapi_PBlock *pb __attribute__((unused)),
if (attrs) {
for (size_t i = 0; attrs[i]; i++) {
if (ldbm_config_moved_attr(a... | Issue 4480 - Unexpected info returned to ldap request (#4491) | Ticket 49476 - refactor ldbm backend to allow replacement of BDB | --- ldap/servers/slapd/back-ldbm/ldbm_config.c
+++ ldap/servers/slapd/back-ldbm/ldbm_config.c
int
ldbm_config_search_entry_callback(Slapi_PBlock *pb __attribute__((unused)),
slapi_pblock_get(pb, SLAPI_SEARCH_ATTRS, &attrs);
if (ldbm_config_moved_attr(attrs[i])) {
- ... | 0 | --- ldap/servers/slapd/back-ldbm/ldbm_config.c
+++ ldap/servers/slapd/back-ldbm/ldbm_config.c
@@ -1243,7 +1243,7 @@ ldbm_config_search_entry_callback(Slapi_PBlock *pb __attribute__((unused)),
- slapi_pblock_set(pb, SLAPI_PB_RESULT_TEXT, "at least one required attribute has been moved to the BDB s... |
--- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
@@ -295,14 +295,17 @@ void CAnalyzerCCpp::GetIndependentBuldIdPC(const std::string& pBuildIdPC, std::s
line += pBuildIdPC[ii];
ii++;
}
- while (!isspace(line[jj]) && jj < line.length())
+ while (line[jj] != '+' && jj < li... | fixed local UUID | renamed MW library | --- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
void CAnalyzerCCpp::GetIndependentBuldIdPC(const std::string& pBuildIdPC, std::string& pIndependentBuildIdPC)
while (ii < pBuildIdPC.length())
std::string line = "";
int jj = 0;
line += pBuildIdPC[ii];
- while (!isspace(line[jj]) ... | 0 | --- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
@@ -295,14 +295,17 @@ void CAnalyzerCCpp::GetIndependentBuldIdPC(const std::string& pBuildIdPC, std::s
- while (!isspace(line[jj]) && jj < line.length())
+ while (line[jj] != '+' && jj < line.length())
- while (!isspace(line[jj]) && jj < line.length... |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -721,6 +721,14 @@ int main(int argc, char** argv)
dd_save_text(dd, FILENAME_ENVIRON, environ ? : "");
free(environ);
+ char *fips_enabled = xmalloc_fopen_fgetline_fclose("/proc/sys/crypto/fips_enabled");
+ if (fips_enable... | abrt-hook-ccpp: save /proc/sys/crypto/fips_enabled value if it isn't "0". Closes rhbz#747870 | use FILENAME_ABRT_VERSION instead of string literal
abrt-hook-ccpp: add saving of environ, disable saving of smaps. closes #91
change dd_create API to return dd pointer (no need to dd_init it separately)
Initial git commit | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
int main(int argc, char** argv)
if (dd)
dd_save_text(dd, FILENAME_ENVIRON, environ ? : "");
+ char *fips_enabled = xmalloc_fopen_fgetline_fclose("/proc/sys/crypto/fips_enabled");
+ if (fips_enabled)
+ {
+ if (s... | 0 | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -721,6 +721,14 @@ int main(int argc, char** argv)
+ char *fips_enabled = xmalloc_fopen_fgetline_fclose("/proc/sys/crypto/fips_enabled");
+ if (fips_enabled)
+ {
+ if (strcmp(fips_enabled, "0") != 0)
+ dd_save... |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -795,6 +795,8 @@ int main(int argc, char** argv)
unlink(core_basename);
}
+/* Because of #1211835 and #1126850 */
+#if 0
/* Save JVM crash log if it exists. (JVM's coredump per se
* is nearly useless for JVM deve... | ccpp: stop reading hs_error.log from /tmp | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -795,6 +795,8 @@ int main(int argc, char** argv)
+/* Because of #1211835 and #1126850 */
+#if 0
@@ -827,6 +829,7 @@ int main(int argc, char** argv)
+#endif
| 0 | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -795,6 +795,8 @@ int main(int argc, char** argv)
+/* Because of #1211835 and #1126850 */
+#if 0
@@ -827,6 +829,7 @@ int main(int argc, char** argv)
+#endif
| |
--- src/Hooks/abrt-hook-ccpp.cpp
+++ src/Hooks/abrt-hook-ccpp.cpp
@@ -137,7 +137,15 @@ static char* get_executable(pid_t pid)
char buf[sizeof("/proc/%lu/exe") + sizeof(long)*3];
sprintf(buf, "/proc/%lu/exe", (long)pid);
- return malloc_readlink(buf);
+ char *executable = malloc_readlink(buf);
+ /* ... | remove "(deleted)" from executable path rhbz#593037 | *: cast pids and uigs to long, not int
Hooks/CCpp.cpp: add MakeCompatCore = yes/no directive. Fixes rhbz#541707 | --- src/Hooks/abrt-hook-ccpp.cpp
+++ src/Hooks/abrt-hook-ccpp.cpp
static char* get_executable(pid_t pid)
sprintf(buf, "/proc/%lu/exe", (long)pid);
- return malloc_readlink(buf);
+ char *executable = malloc_readlink(buf);
+ /* find and cut off " (deleted)" from the path */
+ char *deleted = executabl... | 0 | --- src/Hooks/abrt-hook-ccpp.cpp
+++ src/Hooks/abrt-hook-ccpp.cpp
@@ -137,7 +137,15 @@ static char* get_executable(pid_t pid)
- return malloc_readlink(buf);
+ char *executable = malloc_readlink(buf);
+ /* find and cut off " (deleted)" from the path */
+ char *deleted = executable + strlen(executable) - strl... |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -116,6 +116,8 @@ static off_t copyfd_sparse(int src_fd, int dst_fd1, int dst_fd2, off_t size2)
size2 -= rd;
if (size2 < 0)
dst_fd2 = -1;
+//TODO: truncate to 0 or even delete the second file
+//(currently we delete the file later)
}
out:
| abrt-hook-ccpp: added a TODO comment. No code changes | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -116,6 +116,8 @@ static off_t copyfd_sparse(int src_fd, int dst_fd1, int dst_fd2, off_t size2)
+//TODO: truncate to 0 or even delete the second file
+//(currently we delete the file later)
| 0 | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -116,6 +116,8 @@ static off_t copyfd_sparse(int src_fd, int dst_fd1, int dst_fd2, off_t size2)
+//TODO: truncate to 0 or even delete the second file
+//(currently we delete the file later)
| |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -718,7 +718,8 @@ int main(int argc, char** argv)
if (snprintf(path, sizeof(path), "%s/%s-coredump", g_settings_dump_location, last_slash) >= sizeof(path))
error_msg_and_die("Error saving '%s': truncated long file path", path);
- ... | ccpp: save abrt core files only to new files | ccpp: ignore crashes of ABRT binaries if DebugLevel == 0
ccpp: check for overflow in abrt coredump path creation
handle crashes in suided apps as kernel does, partially fixes rhbz#783450 rhbz#785163
Initial git commit | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
int main(int argc, char** argv)
g_user_core_flags = O_EXCL;
if (g_settings_debug_level == 0)
if (snprintf(path, sizeof(path), "%s/%s-coredump", g_settings_dump_location, last_slash) >= sizeof(path))
error_msg_and_die("... | 0 | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -718,7 +718,8 @@ int main(int argc, char** argv)
- int abrt_core_fd = xopen3(path, O_WRONLY | O_CREAT | O_TRUNC, 0600);
+ unlink(path);
+ int abrt_core_fd = xopen3(path, O_WRONLY | O_CREAT | O_EXCL, 0600);
|
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -678,7 +678,7 @@ int main(int argc, char** argv)
{
char *rootdir = get_rootdir(pid);
- dd_create_basic_files(dd, fsuid, (rootdir && strcmp(rootdir, "/") != 0) ? rootdir : NULL);
+ dd_create_basic_files(dd, fsuid, NULL);
... | ccpp: do not read data from root directories | ccpp: fix symlink race conditions
synchronize default dump dir mode with libreport
ccpp-hook: fixed one nasty segfault
rhbz#671354 - [RFE] Configurable core dump location
change dd_create API to return dd pointer (no need to dd_init it separately)
DebugDump.cpp: lowercase and rename functions
Initial git commit | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
int main(int argc, char** argv)
g_settings_dump_location, iso_date_string(NULL), (long)pid);
dd = dd_create(path, fsuid, DEFAULT_DUMP_DIR_MODE);
if (dd)
char *rootdir = get_rootdir(pid);
- dd_create_basic_files(dd, fsuid, ... | 0 | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -678,7 +678,7 @@ int main(int argc, char** argv)
- dd_create_basic_files(dd, fsuid, (rootdir && strcmp(rootdir, "/") != 0) ? rootdir : NULL);
+ dd_create_basic_files(dd, fsuid, NULL);
|
--- src/Daemon/Daemon.cpp
+++ src/Daemon/Daemon.cpp
@@ -810,6 +810,7 @@ int main(int argc, char** argv)
int inotify_fd = inotify_init();
if (inotify_fd == -1)
perror_msg_and_die("inotify_init failed");
+ close_on_exec_on(inotify_fd);
if (inotify_add_watch(inotify_fd, DEBUG... | trivial: close inotify_fd on exec | use .new suffix on new crashdumps; strip it when crashdump is ready
make some variables local; rename a few typedefs
final touch on commlayer, minor fixes in exceptions (zprikryl) | --- src/Daemon/Daemon.cpp
+++ src/Daemon/Daemon.cpp
int main(int argc, char** argv)
if (inotify_fd == -1)
+ close_on_exec_on(inotify_fd);
if (inotify_add_watch(inotify_fd, DEBUG_DUMPS_DIR, IN_CREATE | IN_MOVED_TO) == -1)
| 0 | --- src/Daemon/Daemon.cpp
+++ src/Daemon/Daemon.cpp
@@ -810,6 +810,7 @@ int main(int argc, char** argv)
+ close_on_exec_on(inotify_fd);
|
--- src/applet/applet.c
+++ src/applet/applet.c
@@ -195,7 +195,7 @@ static bool problem_info_ensure_writable(problem_info_t *pi)
static problem_info_t *problem_info_new(const char *dir)
{
- problem_info_t *pi = xzalloc(sizeof(*pi));
+ problem_info_t *pi = g_new0(problem_info_t, 1);
pi->problem_data = pro... | applet: Use g_new0() instead of xzalloc() | applet: use problem_data_t in ignored problems
introduce Desktop Session Autoreporting
hopefully fixed ugly applet icon rhbz#797078 | --- src/applet/applet.c
+++ src/applet/applet.c
static problem_info_t *problem_info_new(const char *dir)
- problem_info_t *pi = xzalloc(sizeof(*pi));
+ problem_info_t *pi = g_new0(problem_info_t, 1);
pi->problem_data = problem_data_new();
problem_info_set_dir(pi, dir);
return pi;
static void problem... | 0 | --- src/applet/applet.c
+++ src/applet/applet.c
@@ -195,7 +195,7 @@ static bool problem_info_ensure_writable(problem_info_t *pi)
- problem_info_t *pi = xzalloc(sizeof(*pi));
+ problem_info_t *pi = g_new0(problem_info_t, 1);
@@ -207,7 +207,7 @@ static void problem_info_free(problem_info_t *pi)
- free(pi);
+ ... |
--- src/plugins/abrt-action-analyze-oops.c
+++ src/plugins/abrt-action-analyze-oops.c
@@ -48,10 +48,15 @@ static void hash_oops_str(char hash_str[SHA1_RESULT_LEN*2 + 1], char *oops_buf,
end_mem_block = skip_whitespace(end_mem_block);
- /* +1 for '?' and +1 for space after '?' == +2*/
+ ... | rhbz#789526 - abrt hashing on kernel backtraces needs improving | rhzb#707074 abrt dupe detection needs to ignore some parts of kernel traces
switch python and oops hashing to sha1 | --- src/plugins/abrt-action-analyze-oops.c
+++ src/plugins/abrt-action-analyze-oops.c
static void hash_oops_str(char hash_str[SHA1_RESULT_LEN*2 + 1], char *oops_buf, const char *oops_ptr)
char *line = xstrndup(call_trace, end_line - call_trace);
char *p = skip_whitespace(line);
- /* ... | 0 | --- src/plugins/abrt-action-analyze-oops.c
+++ src/plugins/abrt-action-analyze-oops.c
@@ -48,10 +48,15 @@ static void hash_oops_str(char hash_str[SHA1_RESULT_LEN*2 + 1], char *oops_buf,
- /* +1 for '?' and +1 for space after '?' == +2*/
+ /* skip symbols prefixed with ? */
- end_mem... |
--- lib/plugins/FileTransfer.cpp
+++ lib/plugins/FileTransfer.cpp
@@ -232,6 +232,10 @@ void CFileTransfer::Run(const char *pActionDir, const char *pArgs, int force)
{
/* Remember pActiveDir for later sending */
FILE *dirlist = fopen(FILETRANSFER_DIRLIST, "a");
+ if (!dirlist)
+ {
+ ... | FileTransfer.cpp: add forgotten open error test | SOSreport: make it avoid double runs; add forced regeneration; upd PLUGINS-HOWTO
TicketUploader and FileTransfer plugins: fixes after a round of testing | --- lib/plugins/FileTransfer.cpp
+++ lib/plugins/FileTransfer.cpp
void CFileTransfer::Run(const char *pActionDir, const char *pArgs, int force)
if (strcmp(pArgs, "store") == 0)
+ if (!dirlist)
+ {
+ throw CABRTException(EXCEP_PLUGIN, "Can't open "FILETRANSFER_DIRLIST);
+ }
... | 1 | --- lib/plugins/FileTransfer.cpp
+++ lib/plugins/FileTransfer.cpp
@@ -232,6 +232,10 @@ void CFileTransfer::Run(const char *pActionDir, const char *pArgs, int force)
+ if (!dirlist)
+ {
+ throw CABRTException(EXCEP_PLUGIN, "Can't open "FILETRANSFER_DIRLIST);
+ }
|
--- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
@@ -183,8 +183,8 @@ void CAnalyzerCCpp::InstallDebugInfos(const std::string& pPackage)
}
if (strstr(buff, "Total download size") != NULL)
{
- int r = write(pipein[1], "y\n", sizeof("y\n"));
- if (r != sizeof("y\n"))
+ ... | two trivial fixlets in lib/Plugins/CCpp.cpp | renamed MW library
new approach for getting debuginfos and backtraces | --- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
void CAnalyzerCCpp::InstallDebugInfos(const std::string& pPackage)
pipe(pipein); /* error check? */
close(pipein[1]); close(pipeout[1]);
close(pipein[0]);
close(pipein[1]);
if (strstr(buff, "Total download size") != NULL)
- ... | 0 | --- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
@@ -183,8 +183,8 @@ void CAnalyzerCCpp::InstallDebugInfos(const std::string& pPackage)
- int r = write(pipein[1], "y\n", sizeof("y\n"));
- if (r != sizeof("y\n"))
+ int r = write(pipein[1], "y\n", sizeof("y\n")-1);
+ if (r != ... |
--- src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
+++ src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
@@ -182,6 +182,9 @@ int main(int argc, char **argv)
if (u != 0)
strcpy(path_env, "PATH=/usr/bin:/bin:"BIN_DIR);
putenv(path_env);
+
+ /* Use safe umask */
+ ... | a-a-i-d-t-a-cache: sanitize umask | abrt-action-install-debuginfo: set real uid/gid to euid/gid
run abrt-action-install-debuginfo.py using trivial sgid wrapper | --- src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
+++ src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
int main(int argc, char **argv)
if (u != getuid())
+ /* Use safe umask */
+ umask(0022);
| 0 | --- src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
+++ src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
@@ -182,6 +182,9 @@ int main(int argc, char **argv)
+
+ /* Use safe umask */
+ umask(0022);
|
--- src/gui-gtk/abrt-gtk.c
+++ src/gui-gtk/abrt-gtk.c
@@ -390,7 +390,7 @@ GtkWidget *create_main_window(void)
gtk_container_add(GTK_CONTAINER(halign), hbox_report_delete);
GtkWidget *hbox_help_close = gtk_hbutton_box_new();
- GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("_Online Help"));
+... | abrt-gui: change the help accelerator to alt-H | accelerators for 'Report' and 'Online help' buttons | --- src/gui-gtk/abrt-gtk.c
+++ src/gui-gtk/abrt-gtk.c
GtkWidget *create_main_window(void)
- GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("_Online Help"));
+ GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("Online _Help"));
gtk_box_pack_end(GTK_BOX(hbox_help_close), btn_online_help... | 0 | --- src/gui-gtk/abrt-gtk.c
+++ src/gui-gtk/abrt-gtk.c
@@ -390,7 +390,7 @@ GtkWidget *create_main_window(void)
- GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("_Online Help"));
+ GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("Online _Help"));
|
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -399,7 +399,7 @@ static int open_user_core(uid_t uid, uid_t fsuid, pid_t pid, char **percent_valu
static bool dump_fd_info(const char *dest_filename, char *source_filename, int source_base_ofs, uid_t uid, gid_t gid)
{
- FILE *fp = fopen(dest_filena... | ccpp: open file for dump_fd_info with O_EXCL | abrt-hook-ccpp: save limits, fd/N and fdinfo/N as "limits" and "open_fds" elements | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
static bool dump_fd_info(const char *dest_filename, char *source_filename, int source_base_ofs, uid_t uid, gid_t gid)
- FILE *fp = fopen(dest_filename, "w");
+ FILE *fp = fopen(dest_filename, "wx");
if (!fp)
perror_msg("Can't change '%s' ... | 0 | --- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -399,7 +399,7 @@ static int open_user_core(uid_t uid, uid_t fsuid, pid_t pid, char **percent_valu
- FILE *fp = fopen(dest_filename, "w");
+ FILE *fp = fopen(dest_filename, "wx");
|
--- src/dbus/abrt-dbus.c
+++ src/dbus/abrt-dbus.c
@@ -599,7 +599,7 @@ static void handle_method_call(GDBusConnection *connection,
g_variant_get(parameters, "(&s&s&s)", &problem_id, &element, &value);
- if (element == NULL || element[0] == '\0' || strlen(element) > 64)
+ if (!str_is_correct_fi... | dbus: report invalid element names | Use log_ family instead of VERBn log calls
introduce DeleteElement D-Bus method
introduce SetElement D-Bus method
initial abrt-dbus API rewrite using glib | --- src/dbus/abrt-dbus.c
+++ src/dbus/abrt-dbus.c
static void handle_method_call(GDBusConnection *connection,
caller_uid = get_caller_uid(connection, invocation, caller);
if (g_strcmp0(method_name, "SetElement") == 0)
g_variant_get(parameters, "(&s&s&s)", &problem_id, &element, &value);
- if (el... | 0 | --- src/dbus/abrt-dbus.c
+++ src/dbus/abrt-dbus.c
@@ -599,7 +599,7 @@ static void handle_method_call(GDBusConnection *connection,
- if (element == NULL || element[0] == '\0' || strlen(element) > 64)
+ if (!str_is_correct_filename(element))
@@ -658,6 +658,18 @@ static void handle_method_call(GDBusConnectio... |
--- src/daemon/Daemon.cpp
+++ src/daemon/Daemon.cpp
@@ -142,8 +142,8 @@ static gboolean server_socket_cb(GIOChannel *source, GIOCondition condition, gpo
pid_t pid = fork();
if (pid < 0)
{
- close(socket);
perror_msg("fork");
+ close(socket);
return TRUE;
}
if (pi... | perror has to be used immediately after failed syscall | This patch makes abrtd spawn a new process, abrt-server, | --- src/daemon/Daemon.cpp
+++ src/daemon/Daemon.cpp
static gboolean server_socket_cb(GIOChannel *source, GIOCondition condition, gpointer ptr_unused)
if (socket == -1)
if (pid < 0)
- close(socket);
+ close(socket);
| 0 | --- src/daemon/Daemon.cpp
+++ src/daemon/Daemon.cpp
@@ -142,8 +142,8 @@ static gboolean server_socket_cb(GIOChannel *source, GIOCondition condition, gpo
- close(socket);
+ close(socket);
|
--- src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
+++ src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
@@ -238,6 +238,20 @@ CompositeDeepScanLine::setFrameBuffer(const FrameBuffer& fr)
for(FrameBuffer::ConstIterator q=fr.begin();q!=fr.end();q++)
{
+
+ //
+ // Frame buffer must have xSampling an... | enforce xSampling/ySampling==1 in CompositeDeepScanLine (#1209) | First import of the OpenEXR v2 files. | --- src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
+++ src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
void
for(FrameBuffer::ConstIterator q=fr.begin();q!=fr.end();q++)
+ //
+ // Frame buffer must have xSampling and ySampling set to 1
+ // (Sampling in FrameBuffers must match sampling in file,
+ ... | 0 | --- src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
+++ src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
@@ -238,6 +238,20 @@ CompositeDeepScanLine::setFrameBuffer(const FrameBuffer& fr)
+
+ //
+ // Frame buffer must have xSampling and ySampling set to 1
+ // (Sampling in FrameBuffers must match sampling ... |
--- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
@@ -340,6 +340,11 @@ MultiPartInputFile::initialize()
// Perform usual check on headers.
//
+ if ( _data->_headers.size() == 0)
+ {
+ throw IEX_NAMESPACE::ArgExc ("Files must contain at least one header");... | add sanity check for reading multipart files with no parts (#840) | First import of the OpenEXR v2 files. | --- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
void
+ if ( _data->_headers.size() == 0)
+ {
+ throw IEX_NAMESPACE::ArgExc ("Files must contain at least one header");
+ }
| 1 | --- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
@@ -340,6 +340,11 @@ MultiPartInputFile::initialize()
+ if ( _data->_headers.size() == 0)
+ {
+ throw IEX_NAMESPACE::ArgExc ("Files must contain at least one header");
+ }
+
|
--- OpenEXR/IlmImf/ImfTiledInputFile.cpp
+++ OpenEXR/IlmImf/ImfTiledInputFile.cpp
@@ -1313,6 +1313,13 @@ TiledInputFile::rawTileData (int &dx, int &dy,
throw IEX_NAMESPACE::ArgExc ("rawTileData read the wrong tile");
}
}
+ else
+ {
+ if(!isValidTile (dx, ... | Fix for #494: validate tile coordinates when doing copyPixels | Updated files to use IMATH_NAMESPACE, ILMTHREAD_NAMESPACE and IEX_NAMESPACE explicitly rather then by aliasing approach initially checked in.
First import of the OpenEXR v2 files.
* Bug fix: exceptions caused by reading incomplete files were not
* Massive checkin.... | --- OpenEXR/IlmImf/ImfTiledInputFile.cpp
+++ OpenEXR/IlmImf/ImfTiledInputFile.cpp
@@ -1313,6 +1313,13 @@ TiledInputFile::rawTileData (int &dx, int &dy,
+ else
+ {
+ if(!isValidTile (dx, dy, lx, ly) )
+ {
+ throw IEX_NAMESPACE::IoExc ("rawTileData read an invalid til... | 4 | --- OpenEXR/IlmImf/ImfTiledInputFile.cpp
+++ OpenEXR/IlmImf/ImfTiledInputFile.cpp
@@ -1313,6 +1313,13 @@ TiledInputFile::rawTileData (int &dx, int &dy,
+ else
+ {
+ if(!isValidTile (dx, dy, lx, ly) )
+ {
+ throw IEX_NAMESPACE::IoExc ("rawTileData read an invalid til... |
--- OpenEXR/exrmakepreview/makePreview.cpp
+++ OpenEXR/exrmakepreview/makePreview.cpp
@@ -120,8 +120,8 @@ generatePreview (const char inFileName[],
previewHeight = max (int (h / (w * a) * previewWidth + .5f), 1);
previewPixels.resizeErase (previewHeight, previewWidth);
- float fx = (previewWidth > 0)? (... | Fix logic for 1 pixel high/wide preview images (Fixes #493) | * A utility for making preview images. (Florian Kainz) | --- OpenEXR/exrmakepreview/makePreview.cpp
+++ OpenEXR/exrmakepreview/makePreview.cpp
void
int previewWidth,
previewHeight = max (int (h / (w * a) * previewWidth + .5f), 1);
previewPixels.resizeErase (previewHeight, previewWidth);
- float fx = (previewWidth > 0)? (float (w - 1) / (previewWidth - 1)): 1... | 4 | --- OpenEXR/exrmakepreview/makePreview.cpp
+++ OpenEXR/exrmakepreview/makePreview.cpp
@@ -120,8 +120,8 @@ generatePreview (const char inFileName[],
- float fx = (previewWidth > 0)? (float (w - 1) / (previewWidth - 1)): 1;
- float fy = (previewHeight > 0)? (float (h - 1) / (previewHeight - 1)): 1;
+ float fx ... |
--- OpenEXR/IlmImf/ImfB44Compressor.cpp
+++ OpenEXR/IlmImf/ImfB44Compressor.cpp
@@ -494,7 +494,7 @@ B44Compressor::B44Compressor
//
_tmpBuffer = new unsigned short
- [checkArraySize (uiMult (maxScanLineSize, numScanLines),
+ [checkArraySize (uiMult (maxScanLineSize / sizeof(unsigned short), nu... | reduce B44 _tmpBufferSize (was allocating two bytes per byte) (#843) | Bug fix: crashes when reading damaged images, caused by buffer | --- OpenEXR/IlmImf/ImfB44Compressor.cpp
+++ OpenEXR/IlmImf/ImfB44Compressor.cpp
@@ -494,7 +494,7 @@ B44Compressor::B44Compressor
- [checkArraySize (uiMult (maxScanLineSize, numScanLines),
+ [checkArraySize (uiMult (maxScanLineSize / sizeof(unsigned short), numScanLines),
| 0 | --- OpenEXR/IlmImf/ImfB44Compressor.cpp
+++ OpenEXR/IlmImf/ImfB44Compressor.cpp
@@ -494,7 +494,7 @@ B44Compressor::B44Compressor
- [checkArraySize (uiMult (maxScanLineSize, numScanLines),
+ [checkArraySize (uiMult (maxScanLineSize / sizeof(unsigned short), numScanLines),
|
--- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
@@ -571,7 +571,7 @@ MultiPartInputFile::Data::chunkOffsetReconstruction(OPENEXR_IMF_INTERNAL_NAMESPA
- if(partNumber<0 || partNumber> static_cast<int>(parts.size()))
+ ... | Fix #491, issue with part number range check reconstructing chunk offset table | use static_cast in error test | --- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
@@ -571,7 +571,7 @@ MultiPartInputFile::Data::chunkOffsetReconstruction(OPENEXR_IMF_INTERNAL_NAMESPA
- if(partNumber<0 || partNumber> static_cast<int>(parts.size()))
+ if(partNumber<0 || partNumber>= static_c... | 3 | --- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
@@ -571,7 +571,7 @@ MultiPartInputFile::Data::chunkOffsetReconstruction(OPENEXR_IMF_INTERNAL_NAMESPA
- if(partNumber<0 || partNumber> static_cast<int>(parts.size()))
+ if(partNumber<0 || partNumber>= static_c... |
--- keepalived/core/main.c
+++ keepalived/core/main.c
@@ -882,7 +882,7 @@ set_umask(const char *optarg)
if (*endptr || umask_long < 0 || umask_long & ~0777L) {
fprintf(stderr, "Invalid --umask option %s", optarg);
- return;
+ return 0;
}
umask_val = umask_long & 0777;
| Fix compile warning introduced in commit c6247a9 | Add command line and configuration option to set umask | --- keepalived/core/main.c
+++ keepalived/core/main.c
static mode_t
if (*endptr || umask_long < 0 || umask_long & ~0777L) {
- return;
+ return 0;
| 4 | --- keepalived/core/main.c
+++ keepalived/core/main.c
@@ -882,7 +882,7 @@ set_umask(const char *optarg)
- return;
+ return 0;
|
--- accel-pppd/radius/packet.c
+++ accel-pppd/radius/packet.c
@@ -206,6 +206,14 @@ int rad_packet_recv(int fd, struct rad_packet_t **p, struct sockaddr_in *addr)
len -= vendor->tag + vendor->len;
n -= 4 + vendor->tag + vendor->len;
+ if (len < 0) {
+ log_ppp_warn("radius:packet invalid vendor attribu... | radius: sanity check for vendor attribute length | radius: extended support for freeradius dictionaries
Update packet.c
various bug fixed and improvements
radius: implemnted mschap-v2 authorization
working on radius module | --- accel-pppd/radius/packet.c
+++ accel-pppd/radius/packet.c
int rad_packet_recv(int fd, struct rad_packet_t **p, struct sockaddr_in *addr)
if (vendor) {
id = (uint16_t)ntohs(*(uint16_t *)ptr);
id = *ptr;
len -= vendor->tag + vendor->len;
n -= 4 + vendor->tag + vendor->len;
+ if (len < 0) {
+ ... | 3 | --- accel-pppd/radius/packet.c
+++ accel-pppd/radius/packet.c
@@ -206,6 +206,14 @@ int rad_packet_recv(int fd, struct rad_packet_t **p, struct sockaddr_in *addr)
+ if (len < 0) {
+ log_ppp_warn("radius:packet invalid vendor attribute len received\n");
+ goto out_err;
+ }
+ if (2 + len > n) {
+ log_... |
--- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exmisc - ACPI AML (p-code) execution - specific opcodes
- * $Revision: 1.127 $
+ * $Revision: 1.... | Allow RefOf on the Debug object | Support for Buffers and Strings in certain Logical operators, as per | --- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
- * $Revision: 1.127 $
+ * $Revision: 1.129 $
@@ -10,7 +10,7 @@
- * Some or all of this work - Copyright (c) 1999 - 2004, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2005, Intel ... | 0 | --- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
- * $Revision: 1.127 $
+ * $Revision: 1.129 $
@@ -10,7 +10,7 @@
- * Some or all of this work - Copyright (c) 1999 - 2004, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2005, Intel ... |
--- source/common/adisasm.c
+++ source/common/adisasm.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: adisasm - Application-level disassembler routines
- * $Revision: 1.67 $
+ * $Revision: 1.68 $
*
********************... | Special handling for FACS table "name" | Change to unsigned output
Fixed table signature strings (especially the FADT sig which is "FACP"
Improved filename handling. All output created in local directory
Automated cleanup | --- source/common/adisasm.c
+++ source/common/adisasm.c
- * $Revision: 1.67 $
+ * $Revision: 1.68 $
ACPI_STATUS
+ char *FacsSuffix = "";
if (NewTable)
AcpiGbl_FADT = (void *) NewTable;
+ FacsSuffix = &AcpiGbl_FADT->OemTableId;
AC... | 0 | --- source/common/adisasm.c
+++ source/common/adisasm.c
@@ -1,7 +1,7 @@
- * $Revision: 1.67 $
+ * $Revision: 1.68 $
@@ -880,6 +880,7 @@ AdGetLocalTables (
+ char *FacsSuffix = "";
@@ -923,6 +924,8 @@ AdGetLocalTables (
+
+ FacsSuffix = &AcpiGbl_FADT->OemTableId... |
--- source/components/disassembler/dmresrc.c
+++ source/components/disassembler/dmresrc.c
@@ -544,6 +544,15 @@ AcpiDmIsResourceTemplate (
* intialization byte list. Because the resource macros will create
* a buffer of the exact required length (buffer length will be equal
* to the actual length).
+ ... | Add new comment, no functional change | --- source/components/disassembler/dmresrc.c
+++ source/components/disassembler/dmresrc.c
@@ -544,6 +544,15 @@ AcpiDmIsResourceTemplate (
+ *
+ * NOTE (April 2017): Resource templates with this issue have been
+ * seen in the field. We still don't want to attempt to disassemble
+ * a buffer like this to... | 1 | --- source/components/disassembler/dmresrc.c
+++ source/components/disassembler/dmresrc.c
@@ -544,6 +544,15 @@ AcpiDmIsResourceTemplate (
+ *
+ * NOTE (April 2017): Resource templates with this issue have been
+ * seen in the field. We still don't want to attempt to disassemble
+ * a buffer like this to... | |
--- source/components/namespace/nsxfname.c
+++ source/components/namespace/nsxfname.c
@@ -239,7 +239,7 @@ AcpiGetHandle (
{
ACPI_STATUS Status;
NAME_TABLE_ENTRY *ThisEntry;
- ACPI_HANDLE Scope = NULL;
+ NAME_TABLE_ENTRY *Scope = NULL;
if (!RetHandle || !Path... | Fixed bug in AcpiGetHandle(): searching for a relative path always | date 2000.01.07.00.31.00; author psdiefen; state Exp;
New name/handle interfaces
"Scope" parameter changed to "Parent"
Eliminated "Name Tables" and replaced with "Named Objects" | --- source/components/namespace/nsxfname.c
+++ source/components/namespace/nsxfname.c
ACPI_STATUS
ACPI_HANDLE Parent,
- ACPI_HANDLE Scope = NULL;
+ NAME_TABLE_ENTRY *Scope = NULL;
if (Parent)
- Scope = Parent->Scope;
+ Scope = ((NAME_TABLE_ENTRY*) Parent)... | 0 | --- source/components/namespace/nsxfname.c
+++ source/components/namespace/nsxfname.c
@@ -239,7 +239,7 @@ AcpiGetHandle (
- ACPI_HANDLE Scope = NULL;
+ NAME_TABLE_ENTRY *Scope = NULL;
@@ -247,7 +247,7 @@ AcpiGetHandle (
- Scope = Parent->Scope;
+ Scope = ((NAME_TABLE_ENTRY*) Paren... |
--- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: evregion - ACPI AddressSpace / OpRegion handler dispatch
- * $Revision: 1.79 $
+ * $Revision: 1.... | Ran acpisrc source cleanup | --- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
- * $Revision: 1.79 $
+ * $Revision: 1.80 $
@@ -148,7 +148,7 @@ AcpiEvInstallDefaultAddressSpaceHandlers (
- /*
+ /*
| 0 | --- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
- * $Revision: 1.79 $
+ * $Revision: 1.80 $
@@ -148,7 +148,7 @@ AcpiEvInstallDefaultAddressSpaceHandlers (
- /*
+ /*
| |
--- source/compiler/aslerror.c
+++ source/compiler/aslerror.c
@@ -247,6 +247,11 @@ AePrintException (
FILE *SourceFile;
+ if (Gbl_NoErrors)
+ {
+ return;
+ }
+
/*
* Only listing files have a header, and remarks/optimizations
* are always output
--- source/co... | iASL: Add option to display summary only. | Support for iASL - multiple files and wildcards.
Implemented several new compiler warnings
Changes to track resource header changes
strupr not POSIX, always use local AcpiUtStrupr
Changed ASM include file extension to .INC
Added -g switch to get all acpi tables
Even more option fussing
Overhaul of options, using new Ac... | --- source/compiler/aslmain.c
+++ source/compiler/aslmain.c
static void
+ printf (" -va Disable all errors and warnings (summary only)\n");
static int
Gbl_Acpi2 = TRUE;
BadCommandLine = TRUE;
Gbl_DebugFlag = TRUE;
Gbl_ParseOnlyFlag = TRUE;
BadCommandLine =... | 1 | --- source/compiler/aslerror.c
+++ source/compiler/aslerror.c
@@ -247,6 +247,11 @@ AePrintException (
+ if (Gbl_NoErrors)
+ {
+ return;
+ }
+
--- source/compiler/aslglobal.h
+++ source/compiler/aslglobal.h
@@ -188,6 +188,7 @@ ASL_EXTERN BOOLEAN ASL_INIT_GLOBAL (Gbl_ParseOnlyFlag, FALSE)... |
--- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -795,11 +795,14 @@ CmInitStaticObject (
* 1) This is an ACPI_OBJECT_INTERNAL descriptor
* 2) The size is the full object (worst case)
* 3) The flags field indicates static allocation
+ * 4) Reference count star... | Init static object reference count | Renamed Clib functions to uppercase macros
Added CmInitStaticObject | --- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
void
MEMSET ((void *) ObjDesc, 0, sizeof (ACPI_OBJECT_INTERNAL));
- ObjDesc->Common.DataType = DESC_TYPE_ACPI_OBJ;
- ObjDesc->Common.Size = sizeof (ACPI_OBJECT_INTERNAL);
- ObjDesc->Common.Flags = AO_STATIC_ALLOCATION;
+... | 0 | --- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -795,11 +795,14 @@ CmInitStaticObject (
+ * 4) Reference count starts at one (not really necessary since the
+ * object can't be deleted, but keeps everything sane)
- ObjDesc->Common.DataType = DESC_TYPE_ACPI_OBJ;
- ... |
--- source/include/acpixf.h
+++ source/include/acpixf.h
@@ -270,7 +270,6 @@ INT32
AcpiModeCapabilities (
void);
-
/*
* Event / System interfaces
*/
| Modified various APIs to match our intent. | --- source/include/acpixf.h
+++ source/include/acpixf.h
@@ -270,7 +270,6 @@ INT32
-
| 0 | --- source/include/acpixf.h
+++ source/include/acpixf.h
@@ -270,7 +270,6 @@ INT32
-
| |
--- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: evgpe - General Purpose Event handling and dispatch
- * $Revision: 1.32 $
+ * $Revision: 1.34 $
*
... | Check for the case where there are no GPEs | Renamed 2 defines
Additional mutex and locking for GPE data structures
First definition and deployment of spin lock interfaces
Split out the GPE Block support to a new file
Added 2003 copyright to the legal header | --- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
- * $Revision: 1.32 $
+ * $Revision: 1.34 $
UINT32
- * Some or all of this work - Copyright (c) 1999 - 2003, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2004, Intel Corp.
ACPI_GPE_XRUPT_INFO ... | 3 | --- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
@@ -1,7 +1,7 @@
- * $Revision: 1.32 $
+ * $Revision: 1.34 $
@@ -9,7 +9,7 @@
- * Some or all of this work - Copyright (c) 1999 - 2003, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2004, Intel Corp.
@@ -... |
--- source/components/hardware/hwsleep.c
+++ source/components/hardware/hwsleep.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Name: hwsleep.c - ACPI Hardware Sleep/Wake Interface
- * $Revision: 1.14 $
+ * $Revision: 1.15 $
*
****... | don't try secondary PM_EN write if doing S1 | another change to get poweroff working. sigh
date 2001.06.14.18.25.00; author psdiefen; state Exp;
added entersleepstate
Update for static functions, cleanup | --- source/components/hardware/hwsleep.c
+++ source/components/hardware/hwsleep.c
- * $Revision: 1.14 $
+ * $Revision: 1.15 $
ACPI_STATUS
if (!ACPI_SUCCESS (Status))
PM1AControl = (UINT16) AcpiHwRegisterRead(ACPI_MTX_LOCK, PM1_CONTROL);
DEBUG_PRINT(ACPI_OK, ("Entering S%d\n", Sle... | 0 | --- source/components/hardware/hwsleep.c
+++ source/components/hardware/hwsleep.c
@@ -2,7 +2,7 @@
- * $Revision: 1.14 $
+ * $Revision: 1.15 $
@@ -298,8 +298,11 @@ AcpiEnterSleepState (
- AcpiHwRegisterWrite(ACPI_MTX_LOCK, PM1_CONTROL,
- (1 << AcpiHwGetBitShift (SLP_EN_MASK)));
+ i... |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: psparse - Parser top level AML parse routines
- * $Revision: 1.75 $
+ * $Revision: 1.76 $
*
**... | Code cleanup (acpisrc -c) | --- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -1,7 +1,7 @@
- * $Revision: 1.75 $
+ * $Revision: 1.76 $
@@ -1439,7 +1439,6 @@ AcpiPsParseAml (
-
| 0 | --- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -1,7 +1,7 @@
- * $Revision: 1.75 $
+ * $Revision: 1.76 $
@@ -1439,7 +1439,6 @@ AcpiPsParseAml (
-
| |
--- source/compiler/cvcompiler.c
+++ source/compiler/cvcompiler.c
@@ -198,18 +198,15 @@ CvProcessComment (
CvDbgPrint ("CommentString: %s\n", CommentString);
/*
- * Determine whether if this comment spans multiple lines.
- * If so, break apart the comment by line so that it can be
- ... | iasl: fix ASL/ASL+ converter comment. | --- source/compiler/cvcompiler.c
+++ source/compiler/cvcompiler.c
@@ -198,18 +198,15 @@ CvProcessComment (
- * Determine whether if this comment spans multiple lines.
- * If so, break apart the comment by line so that it can be
- * properly indented.
+ * Determine whether if this comment... | 4 | --- source/compiler/cvcompiler.c
+++ source/compiler/cvcompiler.c
@@ -198,18 +198,15 @@ CvProcessComment (
- * Determine whether if this comment spans multiple lines.
- * If so, break apart the comment by line so that it can be
- * properly indented.
+ * Determine whether if this comment... | |
--- source/compiler/aslglobal.h
+++ source/compiler/aslglobal.h
@@ -3,7 +3,7 @@
/******************************************************************************
*
* Module Name: aslglobal.h - Global variable definitions
- * $Revision: 1.15 $
+ * $Revision: 1.17 $
*
********************... | Support for Switch/Case added | --- source/compiler/aslglobal.h
+++ source/compiler/aslglobal.h
- * $Revision: 1.15 $
+ * $Revision: 1.17 $
+ EXTERN UINT32 INIT_GLOBAL (Gbl_TempCount, 0);
+ EXTERN ASL_PARSE_NODE *Gbl_FirstLevelInsertionNode;
+ EXTERN ASL_EVENT_INFO AslGbl_Events[20];
| 0 | --- source/compiler/aslglobal.h
+++ source/compiler/aslglobal.h
@@ -3,7 +3,7 @@
- * $Revision: 1.15 $
+ * $Revision: 1.17 $
@@ -216,7 +216,8 @@ EXTERN ASL_PARSE_NODE INIT_GLOBAL (*Gbl_NodeCacheNext, NULL);
-
+EXTERN UINT32 INIT_GLOBAL (Gbl_TempCount, 0);
+EXTERN ASL... | |
--- source/components/hardware/hwgpe.c
+++ source/components/hardware/hwgpe.c
@@ -222,7 +222,7 @@ AcpiHwLowSetGpe (
break;
default:
- ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u\n", Action));
+ ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u", Action));
return (AE_BAD_PARAMETER);
... | Remove some extraneous newlines in ACPI_ERROR type calls.. | Split large dsopcode.c and dsload.c files.
Update for GPE enabling/disabling.
Standardize integer output for ACPICA warnings/errors. | --- source/components/hardware/hwgpe.c
+++ source/components/hardware/hwgpe.c
ACPI_STATUS
UINT32 Action)
switch (Action)
- ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u\n", Action));
+ ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u", Action));
--- source/components/dispatcher/dso... | 0 | --- source/components/hardware/hwgpe.c
+++ source/components/hardware/hwgpe.c
@@ -222,7 +222,7 @@ AcpiHwLowSetGpe (
- ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u\n", Action));
+ ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u", Action));
--- source/components/dispatcher/dswload2.c
+++ source/components/di... |
--- source/components/events/evxface.c
+++ source/components/events/evxface.c
@@ -714,7 +714,7 @@ AcpiRemoveNotifyHandler (
ACPI_STATUS
AcpiInstallAddressSpaceHandler (
ACPI_HANDLE Device,
- UINT32 SpaceId,
+ ACPI_ADDRESS_SPACE_TYPE SpaceId,
ADDRESS_SPACE_HANDLER Hand... | date 2000.01.24.22.09.00; author psdiefen; state Exp; | Added ACPI_DEFAULT_HANDLE feature to AcpiInstallAddressSpaceHandler.
At least rudementary OpRegion support working after restructure of
Added notify and address space handler objects. Added system and
Implemented opregion interfaces
Moved more external interfaces here
Changed event handling process for installable GPE... | --- source/components/events/evxface.c
+++ source/components/events/evxface.c
ACPI_STATUS
- UINT32 SpaceId,
+ ACPI_ADDRESS_SPACE_TYPE SpaceId,
(SpaceId > ACPI_MAX_ADDRESS_SPACE))
switch (SpaceId)
- case REGION_SystemMemory:
+ case ADDRESS_SPACE_SYSTEM_MEMORY:
... | 0 | --- source/components/events/evxface.c
+++ source/components/events/evxface.c
@@ -714,7 +714,7 @@ AcpiRemoveNotifyHandler (
- UINT32 SpaceId,
+ ACPI_ADDRESS_SPACE_TYPE SpaceId,
@@ -763,15 +763,15 @@ AcpiInstallAddressSpaceHandler (
- case REGION_SystemMemory:
+ case ADDRESS_SPACE_... |
--- source/components/namespace/nseval.c
+++ source/components/namespace/nseval.c
@@ -428,6 +428,16 @@ AcpiNsEvaluate (
Status = AE_OK;
}
+ else if (ACPI_FAILURE(Status))
+ {
+ /* If ReturnObject exists, delete it */
+
+ if (Info->ReturnObject)
+ {
+ AcpiUtRemoveR... | acpi: acpica: fix acpi operand cache leak in nseval.c | Add argument typechecking for all predefined ACPI names.
Consolidate method arg count validation code.
Additional restructuring and cleanup of namespace evaluation functions
Cleanup
Deadlock fix - must unlock namespace before entering interpreter
Broke up ExecuteMethod into two procedures | --- source/components/namespace/nseval.c
+++ source/components/namespace/nseval.c
ACPI_STATUS
Info->ReturnObject = NULL;
ACPI_NAMESPACE_NODE, &Info->ReturnObject), NULL);
Info->ReturnObject,
(void) AcpiNsCheckReturnValue (Info->Node, Info, Info->ParamCount,
Status, &Info->ReturnO... | 4 | --- source/components/namespace/nseval.c
+++ source/components/namespace/nseval.c
@@ -428,6 +428,16 @@ AcpiNsEvaluate (
+ else if (ACPI_FAILURE(Status))
+ {
+ /* If ReturnObject exists, delete it */
+
+ if (Info->ReturnObject)
+ {
+ AcpiUtRemoveReference (Info->ReturnObject);
+ ... |
--- source/tools/acpiexec/aeexec.c
+++ source/tools/acpiexec/aeexec.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: aeexec - Support routines for AcpiExec utility
- * $Revision: 1.107 $
+ * $Revision: 1.108 $
*
*******... | ACPICA: test timeout on global lock interface | ACPICA: Add test for global lock interfaces
Support for AcpiGetVendorResource | --- source/tools/acpiexec/aeexec.c
+++ source/tools/acpiexec/aeexec.c
- * $Revision: 1.107 $
+ * $Revision: 1.108 $
void
Status = AcpiAcquireGlobalLock (0xFFFF, &LockHandle);
+ Status = AcpiAcquireGlobalLock (0x5, &LockHandle); /* Should fail */
if (ACPI_FAILURE (Status))
| 0 | --- source/tools/acpiexec/aeexec.c
+++ source/tools/acpiexec/aeexec.c
@@ -1,7 +1,7 @@
- * $Revision: 1.107 $
+ * $Revision: 1.108 $
@@ -1120,6 +1120,8 @@ AeMiscellaneousTests (
+ Status = AcpiAcquireGlobalLock (0x5, &LockHandle); /* Should fail */
+
|
--- source/components/tables/tbinstal.c
+++ source/components/tables/tbinstal.c
@@ -236,7 +236,7 @@ AcpiTbInstallTableWithOverride (
* DESCRIPTION: This function is called to verify and install an ACPI table.
* When this function is called by "Load" or "LoadTable" opcodes,
* or by AcpiLo... | Tables: Fix spelling mistake in comment | --- source/components/tables/tbinstal.c
+++ source/components/tables/tbinstal.c
@@ -236,7 +236,7 @@ AcpiTbInstallTableWithOverride (
- * After sucessfully returning from this function, table is
+ * After successfully returning from this function, table is
| 4 | --- source/components/tables/tbinstal.c
+++ source/components/tables/tbinstal.c
@@ -236,7 +236,7 @@ AcpiTbInstallTableWithOverride (
- * After sucessfully returning from this function, table is
+ * After successfully returning from this function, table is
| |
--- source/components/namespace/nsnames.c
+++ source/components/namespace/nsnames.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: nsnames - Name manipulation and search
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
*
**... | Fix for RefOf/DeRefOf issue. RefOf now returns an object of type | Fixed and merged pathname code | --- source/components/namespace/nsnames.c
+++ source/components/namespace/nsnames.c
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
ACPI_SIZE
NextNode = Node;
- while (NextNode != AcpiGbl_RootNode)
+ while (NextNode && (NextNode != AcpiGbl_RootNode))
Size += PATH_SEGMENT_LENG... | 4 | --- source/components/namespace/nsnames.c
+++ source/components/namespace/nsnames.c
@@ -1,7 +1,7 @@
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
@@ -275,7 +275,7 @@ AcpiNsGetPathnameLength (
- while (NextNode != AcpiGbl_RootNode)
+ while (NextNode && (NextNode != AcpiGbl_RootNode))
|
--- source/components/executer/exdump.c
+++ source/components/executer/exdump.c
@@ -358,6 +358,11 @@ AmlDumpOperand (
break;
+ case AML_NAMEPATH_OP:
+ DEBUG_PRINT_RAW (ACPI_INFO, ("Lvalue.Nte->Name %x\n",
+ EntryDesc->Lvalue.Nte->Name));
+ break;
+ ... | Added AML_NAMEPATH_OP to AmlDumpOperand case statement. | --- source/components/executer/exdump.c
+++ source/components/executer/exdump.c
@@ -358,6 +358,11 @@ AmlDumpOperand (
+ case AML_NAMEPATH_OP:
+ DEBUG_PRINT_RAW (ACPI_INFO, ("Lvalue.Nte->Name %x\n",
+ EntryDesc->Lvalue.Nte->Name));
+ break;
+
| 0 | --- source/components/executer/exdump.c
+++ source/components/executer/exdump.c
@@ -358,6 +358,11 @@ AmlDumpOperand (
+ case AML_NAMEPATH_OP:
+ DEBUG_PRINT_RAW (ACPI_INFO, ("Lvalue.Nte->Name %x\n",
+ EntryDesc->Lvalue.Nte->Name));
+ break;
+
| |
--- source/components/events/evxfregn.c
+++ source/components/events/evxfregn.c
@@ -139,6 +139,12 @@
*
* DESCRIPTION: Install a handler for all OpRegions of a given SpaceId.
*
+ * NOTE: This function should only be called after AcpiEnableSubsystem has
+ * been called. This is because any _REG methods associated w... | Comment update; no functional change. | --- source/components/events/evxfregn.c
+++ source/components/events/evxfregn.c
@@ -139,6 +139,12 @@
+ * NOTE: This function should only be called after AcpiEnableSubsystem has
+ * been called. This is because any _REG methods associated with the Space ID
+ * are executed here, and these methods can only be safely exec... | 0 | --- source/components/events/evxfregn.c
+++ source/components/events/evxfregn.c
@@ -139,6 +139,12 @@
+ * NOTE: This function should only be called after AcpiEnableSubsystem has
+ * been called. This is because any _REG methods associated with the Space ID
+ * are executed here, and these methods can only be safely exec... | |
--- source/include/platform/acwin.h
+++ source/include/platform/acwin.h
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Name: acwin.h - OS specific defines, etc.
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
*
***************************************... | ACPICA: Fix for Linux source translation | --- source/include/platform/acwin.h
+++ source/include/platform/acwin.h
* $Revision: 1.27 $
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
/*
+ /*! [End] no source code translation !*/
| 4 | --- source/include/platform/acwin.h
+++ source/include/platform/acwin.h
@@ -1,7 +1,7 @@
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
@@ -173,6 +173,8 @@ typedef COMPILER_DEPENDENT_UINT64 u64;
+/*! [End] no source code translation !*/
+
| |
--- source/compiler/asllisting.c
+++ source/compiler/asllisting.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: asllisting - Listing file generation
- * $Revision: 1.24 $
+ * $Revision: 1.25 $
*
***********************... | Split opcode flags into separate class/type/flags fields | Update to new opcode class/type names
Update to opcode names and typenames for fields
date 2000.11.09.21.37.00; author rmoore1; state Exp;
Labels in C and ASM files use the table sig and ID. | --- source/compiler/asllisting.c
+++ source/compiler/asllisting.c
- * $Revision: 1.24 $
+ * $Revision: 1.25 $
void
switch (Node->ParseOpcode)
OpInfo = AcpiPsGetOpcodeInfo (Node->AmlOpcode);
- OpClass = ACPI_GET_OP_CLASS (OpInfo);
+ OpClass = OpInfo->Class;
| 0 | --- source/compiler/asllisting.c
+++ source/compiler/asllisting.c
@@ -2,7 +2,7 @@
- * $Revision: 1.24 $
+ * $Revision: 1.25 $
@@ -621,7 +621,7 @@ LsWriteNodeToListing (
- OpClass = ACPI_GET_OP_CLASS (OpInfo);
+ OpClass = OpInfo->Class;
|
--- source/components/executer/exstore.c
+++ source/components/executer/exstore.c
@@ -206,12 +206,13 @@ AmlExecute (
* the execution of an numeric operator. It is not clear who should delete the result
* object if it is not to be returned. Needs more investigation.
*/
-
+/*
if (... | Fixes for ESG. | --- source/components/executer/exstore.c
+++ source/components/executer/exstore.c
@@ -206,12 +206,13 @@ AmlExecute (
-
+/*
+*/
| 0 | --- source/components/executer/exstore.c
+++ source/components/executer/exstore.c
@@ -206,12 +206,13 @@ AmlExecute (
-
+/*
+*/
| |
--- source/components/executer/exfldio.c
+++ source/components/executer/exfldio.c
@@ -613,13 +613,13 @@ AcpiExFieldDatumIo (
return_ACPI_STATUS (Status);
}
- ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
- "I/O to Data Register: ValuePtr %p\n", Value));
-
if (ReadWrite == ACPI_RE... | Update debug output for IndexField I/O. | Cleanup/formatting
Add 2006 copyright
Restructured field read code (again) to fix region overrun if
Fix for Index Fields; Fix for write beyond end-of-field
Removed ACPI_READ_ADR_SPACE (and WRITE). Uses common ACPI_READ and
Implemented 64-bit field support for ACPI 2.0
Fix to zero upper unused bits for fields that span... | --- source/components/executer/exfldio.c
+++ source/components/executer/exfldio.c
static ACPI_STATUS
ACPI_INTEGER *Value,
if (!Value)
Value = &LocalValue;
*Value = 0;
switch (ACPI_GET_OBJECT_TYPE (ObjDesc))
ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
- ACPI_DEBUG_PR... | 0 | --- source/components/executer/exfldio.c
+++ source/components/executer/exfldio.c
@@ -613,13 +613,13 @@ AcpiExFieldDatumIo (
- ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
- "I/O to Data Register: ValuePtr %p\n", Value));
-
+ ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
+ "Read from Data Registe... |
--- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: dbstats - Generation and display of ACPI table statistics
- * $Revision: 1.89 $
+ * $Revision... | Added additional object to SIZES command. | --- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
* $Revision: 1.89 $
- * $Revision: 1.89 $
+ * $Revision: 1.90 $
+ AcpiOsPrintf ("AcpiObject %3d\n", sizeof (ACPI_OBJECT));
| 0 | --- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
@@ -1,7 +1,7 @@
- * $Revision: 1.89 $
+ * $Revision: 1.90 $
@@ -592,6 +592,7 @@ AcpiDbDisplayStatistics (
+ AcpiOsPrintf ("AcpiObject %3d\n", sizeof (ACPI_OBJECT));
| |
--- source/tools/acpiexec/aehandlers.c
+++ source/tools/acpiexec/aehandlers.c
@@ -1127,11 +1127,21 @@ AeInstallEarlyHandlers (
Status = AcpiDetachData (Handle, AeAttachedDataHandler);
AE_CHECK_OK (AcpiDetachData, Status);
- Status = AcpiAttachData (Handle, AeAttachedDataHandler, Handle);
+ ... | AcpiExec: Add support to test attach/delete root node objects. | Revert "AcpiExec: Add support to test attach/delete root node objects."
AcpiExec: Add test for multiple attach data and node deletion.
AcpiExec: Use ACPI_ROOT_OBJECT where appropriate.
iASL/tools: Lint changes.
Fix several AcpiAttachData problems.
acpiexec: split large source file. | --- source/tools/acpiexec/aehandlers.c
+++ source/tools/acpiexec/aehandlers.c
ACPI_STATUS
Status = AcpiInstallNotifyHandler (ACPI_ROOT_OBJECT, ACPI_DEVICE_NOTIFY,
Status = AcpiGetHandle (NULL, "\\_SB", &Handle);
if (ACPI_SUCCESS (Status))
AE_CHECK_OK (AcpiAttachData, Status);
Status = AcpiDe... | 1 | --- source/tools/acpiexec/aehandlers.c
+++ source/tools/acpiexec/aehandlers.c
@@ -1127,11 +1127,21 @@ AeInstallEarlyHandlers (
- Status = AcpiAttachData (Handle, AeAttachedDataHandler, Handle);
+ /* Test attach data at the root object */
+
+ Status = AcpiAttachData (ACPI_ROOT_OBJECT, AeAttachedData... |
--- source/components/utilities/utdecode.c
+++ source/components/utilities/utdecode.c
@@ -629,9 +629,9 @@ static const char *AcpiGbl_GenericNotify[ACPI_GENERIC_NOTIFY_MAX + 1]
/* 09 */ "Device PLD Check",
/* 0A */ "Reserved",
/* 0B */ "System Locality Update",
- /* 0C */ "Shutdown Request", ... | Utilities: Make a notify value reserved | --- source/components/utilities/utdecode.c
+++ source/components/utilities/utdecode.c
@@ -629,9 +629,9 @@ static const char *AcpiGbl_GenericNotify[ACPI_GENERIC_NOTIFY_MAX + 1]
- /* 0C */ "Shutdown Request", /* Reserved in ACPI 6.0 */
+ /* 0C */ "Reserved (was previously Shutdown Request)", /* Reserved ... | 0 | --- source/components/utilities/utdecode.c
+++ source/components/utilities/utdecode.c
@@ -629,9 +629,9 @@ static const char *AcpiGbl_GenericNotify[ACPI_GENERIC_NOTIFY_MAX + 1]
- /* 0C */ "Shutdown Request", /* Reserved in ACPI 6.0 */
+ /* 0C */ "Reserved (was previously Shutdown Request)", /* Reserved ... | |
--- source/compiler/aslcodegen.c
+++ source/compiler/aslcodegen.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: aslcodegen - AML code generation
- * $Revision: 1.60 $
+ * $Revision: 1.61 $
*
***************************... | Fix fault if package length too long to be encoded (BZ 432) | Support to emit AML immediately after resource desc in listing
gcc prefers casting an address instead of taking the address of a cast
New errors for dependent resource macros; Now can get DSDT from the
Removed input/output file globals
Added 2003 copyright to the legal header | --- source/compiler/aslcodegen.c
+++ source/compiler/aslcodegen.c
- * $Revision: 1.60 $
+ * $Revision: 1.61 $
static void
ACPI_PARSE_OBJECT *Op)
if (Op->Asl.ParseOpcode == PARSEOP_DEFAULT_ARG)
Aml.Opcode = Op->Asl.AmlOpcode;
CgLocalWriteAmlData (Op, &Aml.OpcodeB... | 4 | --- source/compiler/aslcodegen.c
+++ source/compiler/aslcodegen.c
@@ -2,7 +2,7 @@
- * $Revision: 1.60 $
+ * $Revision: 1.61 $
@@ -396,7 +396,7 @@ CgWriteAmlOpcode (
- else
+ else if (Op->Asl.AmlPkgLenBytes != 0)
|
--- source/include/platform/acenv.h
+++ source/include/platform/acenv.h
@@ -224,8 +224,8 @@ typedef char *va_list;
#endif /* va_arg */
-#define STRSTR(s1,s2) __strstr((char *) (s1), (char *) (s2))
-#define STRUPR(s) _strupr((char *) (s))
+#define STRSTR(s1,s2) _strstr((char *) (s1... | Changed _strupr to __strupr (two __) unable to link on WDM because | --- source/include/platform/acenv.h
+++ source/include/platform/acenv.h
@@ -224,8 +224,8 @@ typedef char *va_list;
-#define STRSTR(s1,s2) __strstr((char *) (s1), (char *) (s2))
-#define STRUPR(s) _strupr((char *) (s))
+#define STRSTR(s1,s2) _strstr((char *) (s1), (char *) (s2))
+#defin... | 0 | --- source/include/platform/acenv.h
+++ source/include/platform/acenv.h
@@ -224,8 +224,8 @@ typedef char *va_list;
-#define STRSTR(s1,s2) __strstr((char *) (s1), (char *) (s2))
-#define STRUPR(s) _strupr((char *) (s))
+#define STRSTR(s1,s2) _strstr((char *) (s1), (char *) (s2))
+#defin... | |
--- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exmisc - ACPI AML (p-code) execution - specific opcodes
- * $Revision: 1.84 $
+ * $Revision: 1.8... | Added NATIVE_UINT for switch statements, prevents switch on a 64-bit | Renamed "OpCode" to "Opcode" | --- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
- * $Revision: 1.84 $
+ * $Revision: 1.85 $
ACPI_STATUS
ACPI_OPERAND_OBJECT **Operand = &WalkState->Operands[0];
if ((Op1Desc->Integer.Value > MAX_MATCH_OPERATOR) ||
(Op2Desc->Integer.... | 0 | --- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
- * $Revision: 1.84 $
+ * $Revision: 1.85 $
@@ -408,9 +408,8 @@ AcpiExHexadic (
- switch (Op1Desc->Integer.Value)
+ switch ((NATIVE_UINT) Op1Desc->Integer.Value)
-
@@ -472,9 +4... |
--- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
@@ -494,6 +494,16 @@ AcpiEvGpeDetect (
GpeRegisterInfo = &GpeBlock->RegisterInfo[i];
+ /*
+ * Optimization: If there are no GPEs enabled within this
+ * register, we can safely ignore the entire... | GPE detect optimization - ignore unused GPE registers. | Add 64-bit support to AcpiRead and AcpiWrite.
Split out the GPE Block support to a new file
Added 2003 copyright to the legal header | --- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
UINT32
for (i = 0; i < GpeBlock->RegisterCount; i++)
GpeRegisterInfo = &GpeBlock->RegisterInfo[i];
+ /*
+ * Optimization: If there are no GPEs enabled within this
+ * register, we can safe... | 0 | --- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
@@ -494,6 +494,16 @@ AcpiEvGpeDetect (
+ /*
+ * Optimization: If there are no GPEs enabled within this
+ * register, we can safely ignore the entire register.
+ */
+ if (!(GpeRegisterInfo-... |
--- source/components/events/evevent.c
+++ source/components/events/evevent.c
@@ -2,7 +2,7 @@
*
* Module Name: evevent - Fixed and General Purpose AcpiEvent
* handling and dispatch
- * $Revision: 1.52 $
+ * $Revision: 1.53 $
*
********************************... | Cleanup - extraneous spaces and tab removal | --- source/components/events/evevent.c
+++ source/components/events/evevent.c
@@ -2,7 +2,7 @@
- * $Revision: 1.52 $
+ * $Revision: 1.53 $
@@ -124,7 +124,6 @@
-
| 0 | --- source/components/events/evevent.c
+++ source/components/events/evevent.c
@@ -2,7 +2,7 @@
- * $Revision: 1.52 $
+ * $Revision: 1.53 $
@@ -124,7 +124,6 @@
-
| |
--- source/include/actypes.h
+++ source/include/actypes.h
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Name: actypes.h - Common data types for the entire ACPI subsystem
- * $Revision: 1.134 $
+ * $Revision: 1.135 $
*
***************************... | Ran acpisrc source cleanup | --- source/include/actypes.h
+++ source/include/actypes.h
@@ -1,7 +1,7 @@
- * $Revision: 1.134 $
+ * $Revision: 1.135 $
@@ -355,7 +355,7 @@ typedef UINT8 OBJECT_TYPE_INTERNAL;
- * Also, values exceeding the largest official ACPI ObjectType must not overlap with
+ * Also, values ex... | 0 | --- source/include/actypes.h
+++ source/include/actypes.h
@@ -1,7 +1,7 @@
- * $Revision: 1.134 $
+ * $Revision: 1.135 $
@@ -355,7 +355,7 @@ typedef UINT8 OBJECT_TYPE_INTERNAL;
- * Also, values exceeding the largest official ACPI ObjectType must not overlap with
+ * Also, values ex... | |
--- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exutils - interpreter/scanner utilities
- * $Revision: 1.116 $
+ * $Revision: 1.117 $
*
**... | typo in comment | --- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
- * $Revision: 1.116 $
+ * $Revision: 1.117 $
@@ -454,7 +454,7 @@ AcpiExEisaIdToString (
- * DESCRIPTOIN: Convert a number to string representation. Assumes string
+ * DESCRIPTION: Convert a numbe... | 0 | --- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
- * $Revision: 1.116 $
+ * $Revision: 1.117 $
@@ -454,7 +454,7 @@ AcpiExEisaIdToString (
- * DESCRIPTOIN: Convert a number to string representation. Assumes string
+ * DESCRIPTION: Convert a numbe... | |
--- source/components/namespace/nsdump.c
+++ source/components/namespace/nsdump.c
@@ -287,6 +287,13 @@ AcpiNsDumpOneObject (
}
ThisNode = AcpiNsMapHandleToNode (ObjHandle);
+ if (!ThisNode)
+ {
+ ACPI_DEBUG_PRINT ((ACPI_DB_INFO, "Invalid object handle %p\n",
+ ObjHandle));
+ r... | Add error check to debug object dump routine. | --- source/components/namespace/nsdump.c
+++ source/components/namespace/nsdump.c
@@ -287,6 +287,13 @@ AcpiNsDumpOneObject (
+ if (!ThisNode)
+ {
+ ACPI_DEBUG_PRINT ((ACPI_DB_INFO, "Invalid object handle %p\n",
+ ObjHandle));
+ return (AE_OK);
+ }
+
| 1 | --- source/components/namespace/nsdump.c
+++ source/components/namespace/nsdump.c
@@ -287,6 +287,13 @@ AcpiNsDumpOneObject (
+ if (!ThisNode)
+ {
+ ACPI_DEBUG_PRINT ((ACPI_DB_INFO, "Invalid object handle %p\n",
+ ObjHandle));
+ return (AE_OK);
+ }
+
| |
--- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: aslopcode - AML opcode generation
- * $Revision: 1.68 $
+ * $Revision: 1.69 $
*
**************************... | warning and truncation for large integers in 32-bit tables | cast fix
Fix for Ones/One/Zero opcodes
Implemented error checking for EISAID string format
change all functions of type ASL_WALK_CALLBACK to return ACPI_STATUS | --- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
- * $Revision: 1.68 $
+ * $Revision: 1.69 $
UINT32
ACPI_PARSE_OBJECT *Op)
if (AcpiGbl_IntegerByteWidth == 4)
if (AcpiGbl_IntegerByteWidth == 8)
if (Op->Asl.Value.Integer <= ACPI_UINT32_MAX... | 0 | --- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
@@ -2,7 +2,7 @@
- * $Revision: 1.68 $
+ * $Revision: 1.69 $
@@ -320,6 +320,19 @@ OpcSetOptimalIntegerSize (
+ if (AcpiGbl_IntegerByteWidth == 4)
+ {
+ AslError (ASL_WARNING, ASL_MSG_INTEGER_LENGTH,
+ ... |
--- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
@@ -213,13 +213,13 @@ DbDisplayStatistics (void)
OsdPrintf ("Control Method Parse Trees:.% 7ld\n", SizeOfMethodTrees);
OsdPrintf ("Named Object NTEs:..........% 7ld\n", SizeOfNTEs);
OsdPrintf ("Named Internal Objects......%... | date 2000.05.03.23.17.00; author rmoore1; state Exp; | --- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
OsdPrintf ("Global State Cache.requests.% 7ld\n", Gbl_StateCacheRequests);
- OsdPrintf ("Global State Cache.requests.% 7ld\n", Gbl_StateCacheRequests);
+ OsdPrintf ("Global State Cache.size.....% 7ld\n", Gbl_GenericStateCacheD... | 0 | --- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
@@ -213,13 +213,13 @@ DbDisplayStatistics (void)
- OsdPrintf ("Global State Cache.requests.% 7ld\n", Gbl_StateCacheRequests);
- OsdPrintf ("Global State Cache depth....% 7ld\n", Gbl_GenericStateCacheDepth);
- OsdPrintf ("Global S... | |
--- source/components/namespace/nsaccess.c
+++ source/components/namespace/nsaccess.c
@@ -188,8 +188,8 @@ AcpiNsRootInitialize (
continue;
}
- Status = AcpiNsLookup (NULL, (char *) InitVal->Name, InitVal->Type,
- ACPI_IMODE_LOAD_PASS2, ACPI_NS_NO_UPSEARCH,
+ Status = Acp... | Fix deconstification warnings (-Wcast-qual) with AcpiNsRootInitialize(). | All: const keyword changes across the ACPICA source
Support for _OSI "internal" method | --- source/components/namespace/nsaccess.c
+++ source/components/namespace/nsaccess.c
@@ -188,8 +188,8 @@ AcpiNsRootInitialize (
- Status = AcpiNsLookup (NULL, (char *) InitVal->Name, InitVal->Type,
- ACPI_IMODE_LOAD_PASS2, ACPI_NS_NO_UPSEARCH,
+ Status = AcpiNsLookup (NULL, ACPI_CAST_PTR (char... | 4 | --- source/components/namespace/nsaccess.c
+++ source/components/namespace/nsaccess.c
@@ -188,8 +188,8 @@ AcpiNsRootInitialize (
- Status = AcpiNsLookup (NULL, (char *) InitVal->Name, InitVal->Type,
- ACPI_IMODE_LOAD_PASS2, ACPI_NS_NO_UPSEARCH,
+ Status = AcpiNsLookup (NULL, ACPI_CAST_PTR (char... |
--- source/components/debugger/dbdisply.c
+++ source/components/debugger/dbdisply.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: dbdisply - debug display commands
- * $Revision: 1.81 $
+ * $Revision: 1.82 $
*
*******... | Display all Args - they can be used as locals | --- source/components/debugger/dbdisply.c
+++ source/components/debugger/dbdisply.c
* $Revision: 1.81 $
- * $Revision: 1.81 $
+ * $Revision: 1.82 $
for (i = 0; i < NumArgs; i++)
- for (i = 0; i < NumArgs; i++)
+ for (i = 0; i < MTH_NUM_ARGS; i++)
| 0 | --- source/components/debugger/dbdisply.c
+++ source/components/debugger/dbdisply.c
@@ -1,7 +1,7 @@
- * $Revision: 1.81 $
+ * $Revision: 1.82 $
@@ -843,7 +843,7 @@ AcpiDbDisplayArguments (void)
- for (i = 0; i < NumArgs; i++)
+ for (i = 0; i < MTH_NUM_ARGS; i++)
| |
--- source/components/resources/rsutils.c
+++ source/components/resources/rsutils.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: rsutils - Utilities for the resource manager
- * $Revision: 1.22 $
+ * $Revision: 1.23 $
... | double deleting ByteStream - remove non-refcounted version | Added memory allocation macros | --- source/components/resources/rsutils.c
+++ source/components/resources/rsutils.c
- * $Revision: 1.22 $
+ * $Revision: 1.23 $
ACPI_STATUS
Status = AcpiRsCreateByteStream (InBuffer->Pointer, ByteStream,
Params[0]->Buffer.Pointer = ByteStream;
- ACPI_MEM_FREE (ByteStream);
| 0 | --- source/components/resources/rsutils.c
+++ source/components/resources/rsutils.c
@@ -1,7 +1,7 @@
- * $Revision: 1.22 $
+ * $Revision: 1.23 $
@@ -490,7 +490,6 @@ AcpiRsSetSrsMethodData (
- ACPI_MEM_FREE (ByteStream);
|
--- source/components/executer/excreate.c
+++ source/components/executer/excreate.c
@@ -322,7 +322,7 @@ AmlExecCreateField (
FieldDesc->FieldUnit.UpdateRule = (UINT8) UPDATE_Preserve;
FieldDesc->FieldUnit.Length = BitCount;
FieldDesc->FieldUnit.BitOffset = (UINT8) (BitOffset % 8);
... | Added alignment and math macros | ExecCreate* procedures | --- source/components/executer/excreate.c
+++ source/components/executer/excreate.c
ACPI_STATUS
if (!FieldDesc)
FieldDesc->FieldUnit.Access = (UINT8) ACCESS_AnyAcc;
FieldDesc->FieldUnit.LockRule = (UINT8) GLOCK_NeverLock;
FieldDesc->FieldUnit.UpdateRule = (UINT8) UPDATE_Prese... | 0 | --- source/components/executer/excreate.c
+++ source/components/executer/excreate.c
@@ -322,7 +322,7 @@ AmlExecCreateField (
- FieldDesc->FieldUnit.Offset = BitOffset / 8;
+ FieldDesc->FieldUnit.Offset = DIV_8 (BitOffset);
|
--- tests/aapits/athardware.c
+++ tests/aapits/athardware.c
@@ -1095,7 +1095,7 @@ AtHardwTest0010(void)
return (Status);
}
- Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress);
+ Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress, 0);
if (ACPI_FAILURE(Status))
{
... | aapts: Update for ACPICA interface change. | Casting changes for MSVC and FreeBSD support. | --- tests/aapits/athardware.c
+++ tests/aapits/athardware.c
ACPI_STATUS
ACPI_PHYSICAL_ADDRESS PhysicalAddress =
if (ACPI_FAILURE(Status))
- Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress);
+ Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress, 0);
if (ACPI_FAILURE(Status... | 0 | --- tests/aapits/athardware.c
+++ tests/aapits/athardware.c
@@ -1095,7 +1095,7 @@ AtHardwTest0010(void)
- Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress);
+ Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress, 0);
@@ -1143,7 +1143,7 @@ AtHardwTest0011(void)
- Status = AcpiSetFirmware... |
--- source/tools/acpidump/apdump.c
+++ source/tools/acpidump/apdump.c
@@ -154,7 +154,7 @@ ApIsValidHeader (
/* Check for minimum table length */
- if (Table->Length <= sizeof (ACPI_TABLE_HEADER))
+ if (Table->Length < sizeof (ACPI_TABLE_HEADER))
{
fprintf (stderr, "Table... | AcpiDump: Allow tables that contain only an ACPI table header. | New: Portable acpidump utility (get system ACPI tables). | --- source/tools/acpidump/apdump.c
+++ source/tools/acpidump/apdump.c
BOOLEAN
ACPI_TABLE_HEADER *Table)
if (!AcpiUtValidAcpiName (Table->Signature))
- if (Table->Length <= sizeof (ACPI_TABLE_HEADER))
+ if (Table->Length < sizeof (ACPI_TABLE_HEADER))
fprintf (stderr, "Table ... | 0 | --- source/tools/acpidump/apdump.c
+++ source/tools/acpidump/apdump.c
@@ -154,7 +154,7 @@ ApIsValidHeader (
- if (Table->Length <= sizeof (ACPI_TABLE_HEADER))
+ if (Table->Length < sizeof (ACPI_TABLE_HEADER))
|
--- source/compiler/aslcompile.c
+++ source/compiler/aslcompile.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: aslcompile - top level compile module
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
*
**********************... | Exit with non-zero on error | --- source/compiler/aslcompile.c
+++ source/compiler/aslcompile.c
@@ -2,7 +2,7 @@
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
@@ -684,7 +684,6 @@ CmCleanupAndExit (void)
-
| 0 | --- source/compiler/aslcompile.c
+++ source/compiler/aslcompile.c
@@ -2,7 +2,7 @@
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
@@ -684,7 +684,6 @@ CmCleanupAndExit (void)
-
| |
--- source/components/hardware/hwregs.c
+++ source/components/hardware/hwregs.c
@@ -382,17 +382,19 @@ AcpiHwClearAcpiStatus (
Status = AcpiHwRegisterWrite (ACPI_REGISTER_PM1_STATUS,
ACPI_BITMASK_ALL_FIXED_STATUS);
+
+ AcpiOsReleaseLock (AcpiGbl_HardwareLock, LockFlags);
+
if (ACPI_FAILUR... | Hardware: Fix possible recursive locking in hwregs.c | Convert hardware mutex to a spinlock, since code is used at xrupt level
Fourth pass to include lint changes/comments/cleanup (64-bit) | --- source/components/hardware/hwregs.c
+++ source/components/hardware/hwregs.c
ACPI_STATUS
LockFlags = AcpiOsAcquireLock (AcpiGbl_HardwareLock);
if (ACPI_FAILURE (Status))
- goto UnlockAndExit;
+ AcpiOsReleaseLock (AcpiGbl_HardwareLock, LockFlags);
}
- UnlockAndExit:
- AcpiOsReleaseLock (Ac... | 4 | --- source/components/hardware/hwregs.c
+++ source/components/hardware/hwregs.c
@@ -382,17 +382,19 @@ AcpiHwClearAcpiStatus (
+
+ AcpiOsReleaseLock (AcpiGbl_HardwareLock, LockFlags);
+
- goto UnlockAndExit;
+ goto Exit;
-UnlockAndExit:
- AcpiOsReleaseLock (AcpiGbl_HardwareLock, LockFlags);
+Exit:
|
--- source/compiler/asltransform.c
+++ source/compiler/asltransform.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: asltransform - Parse tree transforms
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
*
*******************... | update a comment | --- source/compiler/asltransform.c
+++ source/compiler/asltransform.c
@@ -2,7 +2,7 @@
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
@@ -540,7 +540,10 @@ TrDoSwitch (
- * Change CaseOp() to: If (PredicateValue == CaseValue) {...}
+ * Change CaseOp() to: If (LEqua... | 0 | --- source/compiler/asltransform.c
+++ source/compiler/asltransform.c
@@ -2,7 +2,7 @@
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
@@ -540,7 +540,10 @@ TrDoSwitch (
- * Change CaseOp() to: If (PredicateValue == CaseValue) {...}
+ * Change CaseOp() to: If (LEqua... | |
--- source/components/namespace/nsload.c
+++ source/components/namespace/nsload.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: nsload - namespace loading/expanding/contracting procedures
- * $Revision: 1.49 $
+ * $Revisio... | Added support for FADT, FACS in AcpiInstallTable. | Namespace load utilities | --- source/components/namespace/nsload.c
+++ source/components/namespace/nsload.c
- * $Revision: 1.49 $
+ * $Revision: 1.51 $
ACPI_STATUS
- * Some or all of this work - Copyright (c) 1999, 2000, 2001, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2002, Intel Corp.
ACP... | 0 | --- source/components/namespace/nsload.c
+++ source/components/namespace/nsload.c
@@ -1,7 +1,7 @@
- * $Revision: 1.49 $
+ * $Revision: 1.51 $
@@ -9,7 +9,7 @@
- * Some or all of this work - Copyright (c) 1999, 2000, 2001, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2002, Int... |
--- source/components/parser/psargs.c
+++ source/components/parser/psargs.c
@@ -1051,6 +1051,9 @@ AcpiPsGetNextArg (
if (Arg->Common.AmlOpcode == AML_INT_METHODCALL_OP)
{
+ /* Free method call op and corresponding namestring sub-ob */
+
+ AcpiPsFreeOp (Arg->Comm... | Fix memory leak on unusual memory leak | Fix a problem with recent extra support for control method invocations
Parser: Allow method invocations as target operands
Enhanced error checking for namepath arguments | --- source/components/parser/psargs.c
+++ source/components/parser/psargs.c
ACPI_STATUS
Arg, ACPI_POSSIBLE_METHOD_CALL);
if (Arg->Common.AmlOpcode == AML_INT_METHODCALL_OP)
+ /* Free method call op and corresponding namestring sub-ob */
+ AcpiPsFreeOp (Arg->Co... | 2 | --- source/components/parser/psargs.c
+++ source/components/parser/psargs.c
@@ -1051,6 +1051,9 @@ AcpiPsGetNextArg (
+ /* Free method call op and corresponding namestring sub-ob */
+
+ AcpiPsFreeOp (Arg->Common.Value.Arg);
|
--- source/components/events/evgpeblk.c
+++ source/components/events/evgpeblk.c
@@ -613,6 +613,19 @@ AcpiEvInitializeGpeBlock (
GpeIndex = (i * ACPI_GPE_REGISTER_WIDTH) + j;
GpeEventInfo = &GpeBlock->EventInfo[GpeIndex];
+ GpeNumber = GpeIndex + GpeBlock->BlockBaseNumber;
+
+ ... | Ensure GPEs are not enabled twice. | Add GPE support for dynamically loaded ACPI tables.
Major update for GPE support code for shared GPEs.
Split GPE block init to allow deferred execution of _PRW methods
Support for WAKE vs RUNTIME GPEs | --- source/components/events/evgpeblk.c
+++ source/components/events/evgpeblk.c
ACPI_STATUS
ACPI_NAMESPACE_NODE *GpeDevice,
if (!GpeBlock)
WalkInfo.GpeBlock = GpeBlock;
GpeEnabledCount = 0;
if (GpeDevice == AcpiGbl_FadtGpeDevice)
GpeDevice = NULL;
for (j = 0; j < ACPI_GPE_REG... | 0 | --- source/components/events/evgpeblk.c
+++ source/components/events/evgpeblk.c
@@ -613,6 +613,19 @@ AcpiEvInitializeGpeBlock (
+ GpeNumber = GpeIndex + GpeBlock->BlockBaseNumber;
+
+ /*
+ * If the GPE has already been enabled for runtime
+ * signalling, make sure that it r... |
--- source/compiler/aslwalks.c
+++ source/compiler/aslwalks.c
@@ -176,9 +176,12 @@ AnMethodTypingWalkEnd (
* The called method is untyped at this time (typically a
* forward reference).
*
- * Check for a recursive method call first.
+ ... | iASL: Fix a possible fault in a Return statement | Improve typechecking, both compile-time and runtime
iASL: Cleanup use of TrWalkParseTree, eliminate null callbacks.
iASL: Split large file aslanalyze.c into three files. | --- source/compiler/aslwalks.c
+++ source/compiler/aslwalks.c
ACPI_STATUS
ACPI_PARSE_OBJECT *Op,
ThisOpBtype = AnGetBtype (Op->Asl.Child);
if ((Op->Asl.Child->Asl.ParseOpcode == PARSEOP_METHODCALL) &&
- * Check for a recursive method call first.
+ * Ch... | 4 | --- source/compiler/aslwalks.c
+++ source/compiler/aslwalks.c
@@ -176,9 +176,12 @@ AnMethodTypingWalkEnd (
- * Check for a recursive method call first.
+ * Check for a recursive method call first. Note: the
+ * Child->Node will be null if the method has not been
+ ... |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -524,19 +524,19 @@ PsParseLoop (
switch (Op->Opcode)
{
- case AML_ByteOp: /* AML_BYTEDATA_ARG */
- case AML_WordOp: /* AML_WORDDATA_ARG */
- case AML_DWordOp: /* AML_DWORDATA_A... | Fix to support method references without mistaking them for method | Re-implementation of DeleteTree | --- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
ACPI_STATUS
if (PsHasCompletedScope (ParserState))
PsPopScope (ParserState, &Op, &Args);
if (!Op)
Opcode = PsPeekOpcode (ParserState);
PsGetNextArg (ParserState, *Args, &ArgCount);
... | 4 | --- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -524,19 +524,19 @@ PsParseLoop (
- case AML_ByteOp: /* AML_BYTEDATA_ARG */
- case AML_WordOp: /* AML_WORDDATA_ARG */
- case AML_DWordOp: /* AML_DWORDATA_ARG */
- case AML_StringOp: /* AML_A... |
--- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: evregion - ACPI AddressSpace (OpRegion) handler dispatch
- * $Revision: 1.120 $
+ * $Revision: 1... | Macro rename and cleanup | Optimized the ACPI_OPERAND_OBJECT size
Global rename of identifiers and constants
EvWalkNamespace now obsolete by new AcpiWalkNamespace
At least rudementary OpRegion support working after restructure of
Prefixed all globals with "Gbl_" for clarity. | --- source/components/events/evregion.c
+++ source/components/events/evregion.c
- * $Revision: 1.120 $
+ * $Revision: 1.121 $
ACPI_STATUS
if ((Node->Type != ACPI_TYPE_DEVICE) &&
if (!ObjDesc)
- if (IS_THIS_OBJECT_TYPE (ObjDesc, ACPI_TYPE_DEVICE))
+ if (ObjDesc->Common.Type ==... | 0 | --- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
- * $Revision: 1.120 $
+ * $Revision: 1.121 $
@@ -713,7 +713,7 @@ AcpiEvAddrHandlerHelper (
- if (IS_THIS_OBJECT_TYPE (ObjDesc, ACPI_TYPE_DEVICE))
+ if (ObjDesc->Common.Type == ACPI_TYPE_DEVIC... |
--- source/os_specific/service_layers/osunixxf.c
+++ source/os_specific/service_layers/osunixxf.c
@@ -879,10 +879,17 @@ AcpiOsDeleteSemaphore (
return (AE_BAD_PARAMETER);
}
+#ifdef __APPLE__
+ if (sem_close (Sem) == -1)
+ {
+ return (AE_BAD_PARAMETER);
+ }
+#else
if (sem_destroy (Se... | MacOSX: Fix wrong sem_destroy definition | Support Mac OS X in Makefile | --- source/include/platform/acmacosx.h
+++ source/include/platform/acmacosx.h
#define sem_destroy sem_close
- #define sem_destroy sem_close
--- source/os_specific/service_layers/osunixxf.c
+++ source/os_specific/service_layers/osunixxf.c
@@ -879,10 +879,17 @@ AcpiOsDeleteSemaphore (
+#ifdef __APPLE__
+ ... | 4 | --- source/os_specific/service_layers/osunixxf.c
+++ source/os_specific/service_layers/osunixxf.c
@@ -879,10 +879,17 @@ AcpiOsDeleteSemaphore (
+#ifdef __APPLE__
+ if (sem_close (Sem) == -1)
+ {
+ return (AE_BAD_PARAMETER);
+ }
+#else
+#endif
--- source/include/platform/acmacosx.h
+++ source/include/pla... |
--- source/include/acglobal.h
+++ source/include/acglobal.h
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Name: acglobal.h - Declarations for global variables
- * $Revision: 1.153 $
+ * $Revision: 1.154 $
*
**************************************... | automated code cleanup | --- source/include/acglobal.h
+++ source/include/acglobal.h
@@ -1,7 +1,7 @@
- * $Revision: 1.153 $
+ * $Revision: 1.154 $
@@ -132,7 +132,7 @@
-/*
+/*
| 0 | --- source/include/acglobal.h
+++ source/include/acglobal.h
@@ -1,7 +1,7 @@
- * $Revision: 1.153 $
+ * $Revision: 1.154 $
@@ -132,7 +132,7 @@
-/*
+/*
| |
--- source/include/amlresrc.h
+++ source/include/amlresrc.h
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: amlresrc.h - AML resource descriptors
- * $Revision: 1.25 $
+ * $Revision: 1.26 $
*
****************************... | Support for ACPI 3.0 Register macro, new parameter | Added 2000 to the copyright in the legal header | --- source/include/amlresrc.h
+++ source/include/amlresrc.h
@@ -2,7 +2,7 @@
- * $Revision: 1.25 $
+ * $Revision: 1.26 $
@@ -123,6 +123,7 @@
+#define ASL_RESNAME_ACCESSSIZE "_ASZ"
@@ -381,7 +382,7 @@ typedef struct asl_general_register_desc
- UINT8 Rese... | 0 | --- source/include/amlresrc.h
+++ source/include/amlresrc.h
@@ -2,7 +2,7 @@
- * $Revision: 1.25 $
+ * $Revision: 1.26 $
@@ -123,6 +123,7 @@
+#define ASL_RESNAME_ACCESSSIZE "_ASZ"
@@ -381,7 +382,7 @@ typedef struct asl_general_register_desc
- UINT8 Rese... |
--- source/components/utilities/utdelete.c
+++ source/components/utilities/utdelete.c
@@ -388,6 +388,11 @@ CmDeleteInternalObj (
FUNCTION_TRACE_PTR ("CmDeleteInternalObj", Object);
+ if (!Object)
+ {
+ return_VOID;
+ }
+
/* Only delete the object when the reference count reaches zero */
... | date 99.09.24.23.01.00; author grsmith1; state Exp; | Attempt at getting new object reference counts to work
Support for new object types
Check for null values when traversing package list.
Now supports package deletion with reference counts
Added reference count deletion mechanism to all objects.
Object deletion routines
Renamed Osd interfaces, renamed header files | --- source/components/utilities/utdelete.c
+++ source/components/utilities/utdelete.c
void
FUNCTION_TRACE_PTR ("CmDeleteInternalObj", Object);
+ if (!Object)
+ {
+ return_VOID;
+ }
{
{
{
{
}
break;
break;
CmDeleteInternalObj (Obj... | 0 | --- source/components/utilities/utdelete.c
+++ source/components/utilities/utdelete.c
@@ -388,6 +388,11 @@ CmDeleteInternalObj (
+ if (!Object)
+ {
+ return_VOID;
+ }
+
|
--- source/tools/acpisrc/astable.c
+++ source/tools/acpisrc/astable.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: astable - Tables used for source conversion
- * $Revision: 1.18 $
+ * $Revision: 1.19 $
*
************... | 2008 Copyright support added. | Update copyright to 2007.
Split from asmain.c | --- source/tools/acpisrc/astable.c
+++ source/tools/acpisrc/astable.c
- * $Revision: 1.18 $
+ * $Revision: 1.19 $
{"INT8", "s8", REPLACE_WHOLE_WORD},
- " * Copyright (C) 2000 - 2007, R. Byron Moore\n"
+ " * Copyright (C) 2000 - 2008, Intel Corp.... | 0 | --- source/tools/acpisrc/astable.c
+++ source/tools/acpisrc/astable.c
@@ -2,7 +2,7 @@
- * $Revision: 1.18 $
+ * $Revision: 1.19 $
@@ -164,7 +164,7 @@ ACPI_STRING_TABLE StandardDataTypes[] = {
-" * Copyright (C) 2000 - 2007, R. Byron Moore\n"
+" * Copyright (C) 2000 - 2008, Intel Corp... |
--- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exutils - interpreter/scanner utilities
- * $Revision: 1.107 $
+ * $Revision: 1.109 $
*
**... | fix DigitsNeeded for 0 (Takayoshi Kochi) | DigitsNeeded was out of date and broken
Use NATIVE_CHAR for strings, changed INTx to UINTx | --- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
- * $Revision: 1.107 $
+ * $Revision: 1.109 $
UINT32
- * Some or all of this work - Copyright (c) 1999 - 2002, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2003, Intel Corp.
ACPI_INTEGE... | 4 | --- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
- * $Revision: 1.107 $
+ * $Revision: 1.109 $
@@ -10,7 +10,7 @@
- * Some or all of this work - Copyright (c) 1999 - 2002, Intel Corp.
+ * Some or all of this work - Copyright (c) 1999 - 2003, Inte... |
--- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -121,8 +121,9 @@
#include <namespace.h>
#include <globals.h>
-#define _THIS_MODULE "cmalloc.c"
#define _COMPONENT MISCELLANEOUS
+ MODULE_NAME ("cmalloc");
+
/*
* Most of this code is for track... | Macro support to eliminate excessive debug string duplication | Split from cmdebug.c | --- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -121,8 +121,9 @@
-#define _THIS_MODULE "cmalloc.c"
+ MODULE_NAME ("cmalloc");
+
| 0 | --- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -121,8 +121,9 @@
-#define _THIS_MODULE "cmalloc.c"
+ MODULE_NAME ("cmalloc");
+
|
--- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
@@ -956,7 +956,7 @@ OpcDoPld (
{
UINT8 *Buffer;
ACPI_PARSE_OBJECT *Node;
- ACPI_PLD_INFO PldInfo = {0};
+ ACPI_PLD_INFO PldInfo;
ACPI_PARSE_OBJECT *NewOp;
@@ -979,6 +979,8 @@ Opc... | iASL: Update for ToPLD macro. | iASL: Add support for ToPLD macro. | --- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
static void
- ACPI_PLD_INFO PldInfo = {0};
+ ACPI_PLD_INFO PldInfo;
if (!Buffer)
+ ACPI_MEMSET (&PldInfo, 0, sizeof (ACPI_PLD_INFO));
PldInfo.Revision = (UINT8) Node->Asl.Child->Asl.Value.Integer;
... | 0 | --- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
@@ -956,7 +956,7 @@ OpcDoPld (
- ACPI_PLD_INFO PldInfo = {0};
+ ACPI_PLD_INFO PldInfo;
@@ -979,6 +979,8 @@ OpcDoPld (
+ ACPI_MEMSET (&PldInfo, 0, sizeof (ACPI_PLD_INFO));
+
|
--- source/components/executer/exsystem.c
+++ source/components/executer/exsystem.c
@@ -382,7 +382,7 @@ ACPI_STATUS
OsGetGlobalLock(void)
{
UINT32 GlobalLockReg;
- ACPI_STATUS Status;
+ ACPI_STATUS Status = AE_OK;
if (FACS)
| Initialized Status, line 386. | New exception codes | --- source/components/executer/exsystem.c
+++ source/components/executer/exsystem.c
ACPI_STATUS
- ACPI_STATUS Status;
+ ACPI_STATUS Status = AE_OK;
Status = AE_OK;
return (Status);
| 0 | --- source/components/executer/exsystem.c
+++ source/components/executer/exsystem.c
@@ -382,7 +382,7 @@ ACPI_STATUS
- ACPI_STATUS Status;
+ ACPI_STATUS Status = AE_OK;
|
End of preview. Expand in Data Studio
No dataset card yet
- Downloads last month
- 11