Integrate with Sentence Transformers v5.4

#13

by tomaarsen HF Staff - opened Apr 8

base: refs/heads/main

←

from: refs/pr/13

Discussion Files changed

-3

Integrate with Sentence Transformers v5.4cb0b4fd5

tomaarsen

Apr 8

•

edited Apr 8

Hello!

Pull Request overview

Ensure compatibility with the upcoming Sentence Transformers version

Details

Sentence Transformers v5.4 will release soon, and it will distribute the cache_dir parameter in the model_kwargs, config_kwargs, etc. This breaks with your custom Sentence Transformers module, as cache_dir=cache_dir, **model_kwargs results in 2 parameters being passed for cache_dir:

TypeError: __init__() got multiple values for keyword argument 'cache_dir'

This PR prevents this issue, while also preserving functionality for older versions. Feel free to merge this PR already, so it works immediately on day-0 when the new Sentence Transformers version releases.

Tom Aarsen

tomaarsen changed pull request status to open Apr 8

Upload images, audio, and videos by dragging in the text input, pasting, or clicking here.

Tap or paste here to upload images

Ready to merge

This branch is ready to get merged automatically.

· Sign up or log in to comment