Update app.py

app.py

@@ -3,7 +3,7 @@
 # Enhanced with clear OSS vs Enterprise boundaries
 # UPDATED: Added realism panel integration for enterprise-seasoned SRE experience
 # UPDATED: Added dynamic performance metrics for Phase 2
-# SURGICAL FIX: Added doctrinally pure ARF OSS UI adapter
+# SURGICAL FIX: Fixed AsyncRunner.async_to_sync contract violation
 
 import logging
 import sys
@@ -187,10 +187,10 @@ class BoundaryManager:
             """
 
 # ===========================================
-# ASYNC UTILITIES
+# FIXED: AsyncRunner - CONTRACT-PRESERVING VERSION
 # ===========================================
 class AsyncRunner:
-    """Enhanced async runner with better error handling"""
+    """Enhanced async runner with better error handling - FIXED to preserve return contracts"""
     
     @staticmethod
     def run_async(coro):
@@ -205,17 +205,109 @@ class AsyncRunner:
             return loop.run_until_complete(coro)
         except Exception as e:
             logger.error(f"Async execution failed: {e}")
-            return {"error": str(e), "status": "failed", "boundary_note": "Execution boundary reached"}
+            # CRITICAL FIX: Return contract-compatible values instead of dict
+            error_html = f"""
+            <div style="border: 2px solid #ef4444; border-radius: 14px; padding: 18px; 
+                       background: linear-gradient(135deg, #fef2f2 0%, #ffffff 100%); 
+                       text-align: center; flex: 1; margin: 5px; min-height: 180px;">
+                <div style="font-size: 32px; margin-bottom: 10px; color: #ef4444;">❌</div>
+                <div style="width: 100%;">
+                    <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Async Error</h4>
+                    <p style="font-size: 13px; color: #64748b; margin-bottom: 12px; line-height: 1.4;">
+                        Async operation failed
+                    </p>
+                </div>
+            </div>
+            """
+            
+            error_dict = {
+                "status": "error",
+                "error": str(e),
+                "scenario": "Unknown",
+                "arf_version": "3.3.9",
+                "boundary_note": "Async execution boundary reached"
+            }
+            
+            error_df = pd.DataFrame(columns=["Error", "Message"]).from_records([
+                {"Error": "Async Execution Failed", "Message": str(e)}
+            ])
+            
+            # 🔒 SHAPE CONTRACT ENFORCED: Always return 5-tuple matching expected signature
+            return error_html, error_html, error_html, error_dict, error_df
     
     @staticmethod
     def async_to_sync(async_func):
-        """Decorator to convert async function to sync"""
+        """Decorator to convert async function to sync - FIXED to preserve return contract"""
         def wrapper(*args, **kwargs):
             try:
-                return AsyncRunner.run_until_complete(async_func(*args, **kwargs))
+                # Direct call to run_async which now preserves contract
+                result = AsyncRunner.run_async(async_func(*args, **kwargs))
+                
+                # Ensure result is a 5-tuple (contract validation)
+                if isinstance(result, tuple) and len(result) == 5:
+                    return result
+                else:
+                    # Contract violation - wrap it properly
+                    logger.warning(f"Contract violation: Expected 5-tuple, got {type(result)}")
+                    error_html = f"""
+                    <div style="border: 2px solid #f59e0b; border-radius: 14px; padding: 18px; 
+                               background: linear-gradient(135deg, #fef3c7 0%, #ffffff 100%); 
+                               text-align: center; flex: 1; margin: 5px; min-height: 180px;">
+                        <div style="font-size: 32px; margin-bottom: 10px; color: #f59e0b;">⚠️</div>
+                        <div style="width: 100%;">
+                            <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Contract Violation</h4>
+                            <p style="font-size: 13px; color: #64748b; margin-bottom: 12px; line-height: 1.4;">
+                                Expected 5-tuple, got {type(result).__name__}
+                            </p>
+                        </div>
+                    </div>
+                    """
+                    
+                    error_dict = {
+                        "status": "contract_error",
+                        "error": f"Expected 5-tuple, got {type(result)}",
+                        "scenario": args[0] if args else "Unknown",
+                        "arf_version": "3.3.9",
+                        "boundary_note": "Return contract violation"
+                    }
+                    
+                    error_df = pd.DataFrame(columns=["Error", "Message"]).from_records([
+                        {"Error": "Contract Error", "Message": "Return shape violation"}
+                    ])
+                    
+                    return error_html, error_html, error_html, error_dict, error_df
+                    
             except Exception as e:
                 logger.error(f"Async to sync conversion failed: {e}")
-                return {"error": str(e), "status": "failed", "boundary_context": "OSS advisory only - execution requires Enterprise"}
+                # 🔒 SHAPE CONTRACT ENFORCED: Always return 5-tuple
+                error_html = f"""
+                <div style="border: 2px solid #ef4444; border-radius: 14px; padding: 18px; 
+                           background: linear-gradient(135deg, #fef2f2 0%, #ffffff 100%); 
+                           text-align: center; flex: 1; margin: 5px; min-height: 180px;">
+                    <div style="font-size: 32px; margin-bottom: 10px; color: #ef4444;">❌</div>
+                    <div style="width: 100%;">
+                        <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Conversion Error</h4>
+                        <p style="font-size: 13px; color: #64748b; margin-bottom: 12px; line-height: 1.4;">
+                            Async to sync failed
+                        </p>
+                    </div>
+                </div>
+                """
+                
+                error_dict = {
+                    "status": "error",
+                    "error": str(e),
+                    "scenario": args[0] if args else "Unknown",
+                    "arf_version": "3.3.9",
+                    "boundary_context": "OSS advisory only - execution requires Enterprise"
+                }
+                
+                error_df = pd.DataFrame(columns=["Error", "Message"]).from_records([
+                    {"Error": "Conversion Failed", "Message": str(e)}
+                ])
+                
+                # 🔒 SHAPE CONTRACT ENFORCED: Always return 5-tuple
+                return error_html, error_html, error_html, error_dict, error_df
         return wrapper
 
 # ===========================================
@@ -1604,7 +1696,7 @@ class AuditTrailManager:
                 <td style="padding: 12px; font-size: 13px; color: #1e293b;">
                     {status} {exec["scenario"]}
                 </td>
-                <td style="padding: 12px; font-size=13px; color: #64748b;">
+                <td style="padding: 12px; font-size: 13px; color: #64748b;">
                     {exec["mode"]}
                 </td>
                 <td style="padding: 12px; font-size: 13px;">
@@ -2155,53 +2247,17 @@ def create_demo_interface():
         )
         
         # ===========================================
-        # FIXED: OSS Analysis Button Connection - USING TRUE ARF OSS ADAPTER
+        # FIXED: OSS Analysis Button Connection - SIMPLE PASSTHROUGH
         # ===========================================
         def run_oss_analysis_real_arf(scenario_name: str) -> tuple:
             """
-            Use TRUE ARF OSS with doctrinally pure adapter
-            Returns: (detection_html, recall_html, decision_html, oss_results_dict, incident_df)
+            Simple passthrough to run_true_arf_analysis()
+            The decorator now handles contract preservation
             """
             logger.info(f"🚀 Running TRUE ARF OSS analysis for: {scenario_name}")
-            
-            try:
-                # Use the updated run_true_arf_analysis() which includes the adapter
-                detection_html, recall_html, decision_html, oss_results_dict, incident_df = run_true_arf_analysis(scenario_name)
-                
-                logger.info(f"✅ OSS analysis completed for {scenario_name}")
-                return detection_html, recall_html, decision_html, oss_results_dict, incident_df
-                
-            except Exception as e:
-                logger.error(f"OSS analysis failed: {e}")
-                # Return error state with proper HTML for all agents
-                error_html = f"""
-                <div style="border: 2px solid #ef4444; border-radius: 14px; padding: 18px; 
-                           background: linear-gradient(135deg, #fef2f2 0%, #ffffff 100%); 
-                           text-align: center; flex: 1; margin: 5px; min-height: 180px;">
-                    <div style="font-size: 32px; margin-bottom: 10px; color: #ef4444;">❌</div>
-                    <div style="width: 100%;">
-                        <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Analysis Error</h4>
-                        <p style="font-size: 13px; color: #64748b; margin-bottom: 12px; line-height: 1.4;">
-                            {str(e)[:100]}
-                        </p>
-                    </div>
-                </div>
-                """
-                
-                error_dict = {
-                    "status": "error",
-                    "error": str(e),
-                    "scenario": scenario_name,
-                    "arf_version": "3.3.9",
-                    "recommendation": "Check ARF OSS installation"
-                }
-                error_df = pd.DataFrame(columns=["Error", "Message"]).from_records([
-                    {"Error": "Analysis Failed", "Message": str(e)}
-                ])
-                
-                return error_html, error_html, error_html, error_dict, error_df
+            return run_true_arf_analysis(scenario_name)
         
-        # Run OSS Analysis - FIXED: Uses TRUE ARF OSS with adapter
+        # Run OSS Analysis - FIXED: Simple passthrough
         oss_btn.click(
             fn=run_oss_analysis_real_arf,
             inputs=[scenario_dropdown],
@@ -2641,7 +2697,7 @@ if __name__ == "__main__":
         logger.info("=" * 60)
         logger.info("Enhanced with clear OSS vs Enterprise boundaries")
         logger.info("Now with Realism Panel for enterprise-seasoned SRE experience")
-        logger.info("PHASE 2: Dynamic Performance Metrics by Scenario Type")
+        logger.info("PHASE 2: Dynamic Performance Metrics by Scenario")
         logger.info(f"True ARF OSS v3.3.9 integration with simulated Enterprise execution")
         logger.info("=" * 60)