Update infrastructure/azure/azure_simulator.py

infrastructure/azure/azure_simulator.py

@@ -1,93 +1,54 @@
-# agentic_reliability_framework/infrastructure/azure/azure_simulator.py
 """
 Azure Infrastructure Simulator – Main orchestration engine.
-
-This module ties together intents, policies, cost estimation, and risk scoring
-to produce a HealingIntent. It is the primary entry point for the OSS advisory layer.
-
-The simulator is designed to be deterministic, side-effect-free, and easily
-extendable by the enterprise layer (which will replace simulation with actual
-Azure API calls while preserving the same interface).
 """
 
 from typing import List, Optional, Dict, Any
 
-from agentic_reliability_framework.infrastructure.intents import (
+from ..intents import (
     InfrastructureIntent,
     ProvisionResourceIntent,
 )
-from agentic_reliability_framework.infrastructure.policies import (
+from ..policies import (
     Policy,
     PolicyEvaluator,
     CostThresholdPolicy,
 )
-from agentic_reliability_framework.infrastructure.cost_estimator import CostEstimator
-from agentic_reliability_framework.infrastructure.risk_engine import RiskEngine
-from agentic_reliability_framework.infrastructure.healing_intent import (
+from ..cost_estimator import CostEstimator
+from ..risk_engine import RiskEngine
+from ..healing_intent import (
     HealingIntent,
     RecommendedAction,
     IntentSource,
 )
-from agentic_reliability_framework.constants import MAX_POLICY_VIOLATIONS
+from ..constants import MAX_POLICY_VIOLATIONS
 
 
 class AzureInfrastructureSimulator:
-    """
-    Orchestrates the evaluation of an infrastructure intent.
-
-    The simulator uses:
-        - A policy evaluator (with a policy tree)
-        - A cost estimator
-        - A risk engine
-
-    It returns a HealingIntent with a recommendation, already marked as OSS advisory.
-    """
-
     def __init__(
         self,
         policy: Policy,
         pricing_file: Optional[str] = None,
         risk_factors: Optional[List] = None,
     ):
-        """
-        Initialize the simulator.
-
-        Args:
-            policy: The root policy (a Policy object, possibly composite).
-            pricing_file: Optional path to custom pricing YAML.
-            risk_factors: Optional list of custom risk factors.
-        """
         self._policy_evaluator = PolicyEvaluator(policy)
         self._cost_estimator = CostEstimator(pricing_file)
         self._risk_engine = RiskEngine(risk_factors if risk_factors else RiskEngine.DEFAULT_FACTORS)
 
     def evaluate(self, intent: InfrastructureIntent) -> HealingIntent:
-        """
-        Evaluate the intent and produce a HealingIntent.
-
-        This method is pure and deterministic (same inputs → same output).
-        The returned HealingIntent is already marked as OSS advisory.
-        """
-        # 1. Estimate cost (if applicable)
         cost = None
         if isinstance(intent, ProvisionResourceIntent):
             cost = self._cost_estimator.estimate_monthly_cost(intent)
 
-        # 2. Evaluate policies with context (cost)
         context = {"cost_estimate": cost} if cost is not None else {}
         violations = self._policy_evaluator.evaluate(intent, context)
 
-        # Enforce OSS limit on policy violations
         if len(violations) > MAX_POLICY_VIOLATIONS:
             violations = violations[:MAX_POLICY_VIOLATIONS]
 
-        # 3. Compute risk
         risk_score, explanation, contributions = self._risk_engine.calculate_risk(
             intent, cost, violations
         )
 
-        # 4. Determine recommended action
-        #    This is a decision rule; can be made configurable.
         if risk_score > 0.8 or violations:
             recommended_action = RecommendedAction.DENY
         elif risk_score > 0.4:
@@ -95,7 +56,6 @@ class AzureInfrastructureSimulator:
         else:
             recommended_action = RecommendedAction.APPROVE
 
-        # 5. Build justification
         justification_parts = [f"Risk score: {risk_score:.2f}."]
         if cost is not None:
             justification_parts.append(f"Estimated monthly cost: ${cost:.2f}.")
@@ -104,10 +64,8 @@ class AzureInfrastructureSimulator:
         justification_parts.append(explanation)
         justification = " ".join(justification_parts)
 
-        # 6. Create summary
         intent_summary = f"{intent.intent_type} requested by {intent.requester}"
 
-        # 7. Package evaluation details
         details = {
             "cost_estimate": cost,
             "violations": violations,
@@ -115,7 +73,6 @@ class AzureInfrastructureSimulator:
             "factor_contributions": contributions,
         }
 
-        # 8. Create the HealingIntent with proper source and then mark as OSS advisory
         healing_intent = HealingIntent(
             intent_id=intent.intent_id,
             intent_summary=intent_summary,
@@ -124,10 +81,9 @@ class AzureInfrastructureSimulator:
             policy_violations=violations,
             recommended_action=recommended_action,
             justification=justification,
-            confidence_score=0.9,  # could be derived from factor uncertainties
+            confidence_score=0.9,
             evaluation_details=details,
             source=IntentSource.INFRASTRUCTURE_ANALYSIS,
         )
 
-        # Mark as OSS advisory (sets status=OSS_ADVISORY_ONLY and execution_allowed=False)
         return healing_intent.mark_as_oss_advisory()