Update app.py

app.py

@@ -2,6 +2,7 @@
 # 🚀 ARF Ultimate Investor Demo v3.3.9 - ENTERPRISE EDITION
 # Enhanced with clear OSS vs Enterprise boundaries
 # UPDATED: Added realism panel integration for enterprise-seasoned SRE experience
+# UPDATED: Added dynamic performance metrics for Phase 2
 
 import logging
 import sys
@@ -210,7 +211,7 @@ class AsyncRunner:
         """Decorator to convert async function to sync"""
         def wrapper(*args, **kwargs):
             try:
-                return AsyncRunner.run_async(async_func(*args, **kwargs))
+                return AsyncRunner.run_until_complete(async_func(*args, **kwargs))
             except Exception as e:
                 logger.error(f"Async to sync conversion failed: {e}")
                 return {"error": str(e), "status": "failed", "boundary_context": "OSS advisory only - execution requires Enterprise"}
@@ -840,12 +841,12 @@ def import_components() -> Dict[str, Any]:
         from ui.styles import get_styles
         components["get_styles"] = get_styles
         
-        # Import UI components - IMPORTANT: Now includes create_realism_panel
+        # Import UI components - IMPORTANT: Now includes create_realism_panel AND update_performance_metrics
         from ui.components import (
             create_header, create_status_bar, create_tab1_incident_demo,
             create_tab2_business_roi, create_tab3_enterprise_features,
             create_tab4_audit_trail, create_tab5_learning_engine,
-            create_footer, create_realism_panel
+            create_footer, create_realism_panel, update_performance_metrics  # Added update_performance_metrics
         )
         
         components.update({
@@ -857,7 +858,8 @@ def import_components() -> Dict[str, Any]:
             "create_tab4_audit_trail": create_tab4_audit_trail,
             "create_tab5_learning_engine": create_tab5_learning_engine,
             "create_footer": create_footer,
-            "create_realism_panel": create_realism_panel  # Added for realism panel
+            "create_realism_panel": create_realism_panel,
+            "update_performance_metrics": update_performance_metrics  # Added for dynamic metrics
         })
         
         # Import scenarios
@@ -997,7 +999,7 @@ def import_components() -> Dict[str, Any]:
         
         components["all_available"] = True
         components["error"] = None
-        logger.info("✅ Successfully imported all modular components")
+        logger.info("✅ Successfully imported all modular components including update_performance_metrics")
         
     except Exception as e:
         logger.error(f"❌ IMPORT ERROR: {e}")
@@ -1028,6 +1030,47 @@ def import_components() -> Dict[str, Any]:
                         "summary": {"roi_multiplier": "5.2×"}
                     }
             components["EnhancedROICalculator"] = MinimalROICalculator()
+        
+        # Ensure update_performance_metrics exists
+        if "update_performance_metrics" not in components:
+            def fallback_performance_metrics(scenario_name: str):
+                """Fallback function if the real one fails"""
+                logger.warning(f"Using fallback performance metrics for {scenario_name}")
+                return (
+                    """<div style="border: 1px solid #e2e8f0; border-radius: 12px; padding: 18px; background: white; margin: 8px; text-align: center; flex: 1; min-width: 140px; border-left: 4px solid #3b82f6;">
+                        <div style="font-size: 28px; margin-bottom: 10px;">⏱️</div>
+                        <div>
+                            <h4 style="margin: 0 0 8px 0; font-size: 14px; color: #64748b; font-weight: 600;">Detection Time</h4>
+                            <p style="font-size: 28px; font-weight: bold; color: #1e40af; margin: 8px 0;">42s</p>
+                            <p style="font-size: 12px; color: #64748b; margin: 0;">↓ 90% faster than average</p>
+                        </div>
+                    </div>""",
+                    """<div style="border: 1px solid #e2e8f0; border-radius: 12px; padding: 18px; background: white; margin: 8px; text-align: center; flex: 1; min-width: 140px; border-left: 4px solid #10b981;">
+                        <div style="font-size: 28px; margin-bottom: 10px;">⚡</div>
+                        <div>
+                            <h4 style="margin: 0 0 8px 0; font-size: 14px; color: #64748b; font-weight: 600;">Mean Time to Resolve</h4>
+                            <p style="font-size: 28px; font-weight: bold; color: #10b981; margin: 8px 0;">14m</p>
+                            <p style="font-size: 12px; color: #64748b; margin: 0;">↓ 70% faster than manual</p>
+                        </div>
+                    </div>""",
+                    """<div style="border: 1px solid #e2e8f0; border-radius: 12px; padding: 18px; background: white; margin: 8px; text-align: center; flex: 1; min-width: 140px; border-left: 4px solid #8b5cf6;">
+                        <div style="font-size: 28px; margin-bottom: 10px;">🤖</div>
+                        <div>
+                            <h4 style="margin: 0 0 8px 0; font-size: 14px; color: #64748b; font-weight: 600;">Auto-Heal Rate</h4>
+                            <p style="font-size: 28px; font-weight: bold; color: #8b5cf6; margin: 8px 0;">78.9%</p>
+                            <p style="font-size: 12px; color: #64748b; margin: 0;">↑ 5.0× industry average</p>
+                        </div>
+                    </div>""",
+                    """<div style="border: 1px solid #e2e8f0; border-radius: 12px; padding: 18px; background: white; margin: 8px; text-align: center; flex: 1; min-width: 140px; border-left: 4px solid #f59e0b;">
+                        <div style="font-size: 28px; margin-bottom: 10px;">💰</div>
+                        <div>
+                            <h4 style="margin: 0 0 8px 0; font-size: 14px; color: #64748b; font-weight: 600;">Cost Saved</h4>
+                            <p style="font-size: 28px; font-weight: bold; color: #f59e0b; margin: 8px 0;">$7.2K</p>
+                            <p style="font-size: 12px; color: #64748b; margin: 0;">Per incident avoided</p>
+                        </div>
+                    </div>"""
+                )
+            components["update_performance_metrics"] = fallback_performance_metrics
     
     return components
 
@@ -1475,7 +1518,7 @@ class AuditTrailManager:
                         <th style="padding: 15px; text-align: left; font-size: 13px; color: #475569; font-weight: 600;">Scenario</th>
                         <th style="padding: 15px; text-align: left; font-size: 13px; color: #475569; font-weight: 600;">Status</th>
                         <th style="padding: 15px; text-align: left; font-size: 13px; color: #475569; font-weight: 600;">Boundary</th>
-                        <th style="padding: 15px; text-align: left; font-size: 13px; color: #475569; font-weight: 600;">Time</th>
+                        <th style="padding: 15px; text-align: left; font-size: 13px; color: #475569; font-weight=600;">Time</th>
                     </tr>
                 </thead>
                 <tbody>
@@ -1653,6 +1696,25 @@ def update_scenario_display(scenario_name: str) -> tuple:
     # ============ CHANGE HERE: Add realism_html to return tuple ============
     return scenario_card_html, telemetry_fig, impact_fig, timeline_fig, realism_html
 
+# ===========================================
+# ENHANCED: Combined update function for scenario display + performance metrics
+# ===========================================
+def update_scenario_display_with_metrics(scenario_name: str) -> tuple:
+    """
+    Combined update function that returns both scenario display AND performance metrics.
+    Returns 9 values: (scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,
+                      detection_time_html, mttr_html, auto_heal_html, savings_html)
+    """
+    # Get the scenario display components (5 outputs)
+    scenario_card, telemetry_fig, impact_fig, timeline_fig, realism_html = update_scenario_display(scenario_name)
+    
+    # Get performance metrics (4 outputs)
+    components = get_components()
+    detection_time_html, mttr_html, auto_heal_html, savings_html = components["update_performance_metrics"](scenario_name)
+    
+    return (scenario_card, telemetry_fig, impact_fig, timeline_fig, realism_html,
+            detection_time_html, mttr_html, auto_heal_html, savings_html)
+
 # ===========================================
 # SURGICAL FIX: run_true_arf_analysis() - FIXED to return DataFrames
 # ===========================================
@@ -2122,11 +2184,14 @@ def create_demo_interface():
         
         # ============ EVENT HANDLERS ============
         
-        # Update scenario display when dropdown changes - ADD realism_panel output
+        # Update scenario display when dropdown changes - NOW INCLUDES PERFORMANCE METRICS
         scenario_dropdown.change(
-            fn=update_scenario_display,  # ← This now returns 5 values
+            fn=update_scenario_display_with_metrics,  # ← Changed to combined function
             inputs=[scenario_dropdown],
-            outputs=[scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel]  # ← Added realism_panel
+            outputs=[
+                scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,
+                detection_time, mttr, auto_heal, savings  # 4 new outputs for metrics
+            ]
         )
         
         # Run OSS Analysis - FIXED: Now returns DataFrame for incident_table
@@ -2150,8 +2215,8 @@ def create_demo_interface():
         @AsyncRunner.async_to_sync
         async def run_complete_demo_async(scenario_name):
             """Run a complete demo walkthrough with true ARF and boundary awareness"""
-            # Step 1: Update scenario
-            update_result = update_scenario_display(scenario_name)
+            # Step 1: Update scenario with metrics
+            update_result = update_scenario_display_with_metrics(scenario_name)
             
             # Step 2: Run true ARF analysis
             oss_result = await run_true_arf_analysis(scenario_name)
@@ -2162,7 +2227,7 @@ def create_demo_interface():
             scenario = components["INCIDENT_SCENARIOS"].get(scenario_name, {})
             impact = scenario.get("business_impact", {})
             revenue_loss = impact.get("revenue_loss_per_hour", get_scenario_impact(scenario_name))
-            savings = int(revenue_loss * 0.85)
+            savings_amount = int(revenue_loss * 0.85)
             
             # Get boundary context
             boundaries = BoundaryManager.get_system_boundaries()
@@ -2189,7 +2254,7 @@ def create_demo_interface():
                 "outcome": {
                     "recovery_time": "12 minutes",
                     "manual_comparison": "45 minutes",
-                    "cost_saved": f"${savings:,}",
+                    "cost_saved": f"${savings_amount:,}",
                     "users_protected": "45,000",
                     "learning": "Pattern added to RAG memory"
                 },
@@ -2249,7 +2314,7 @@ def create_demo_interface():
                             • Autonomous execution simulated<br>
                             • Rollback guarantee: 100%<br>
                             • 12min vs 45min recovery<br>
-                            • ${savings:,} saved
+                            • ${savings_amount:,} saved
                         </div>
                     </div>
                 </div>
@@ -2298,7 +2363,7 @@ def create_demo_interface():
                         </div>
                         <div>
                             <div style="font-size: 11px; color: #64748b; margin-bottom: 5px;">Cost Saved</div>
-                            <div style="font-size: 18px; font-weight: 700; color: #10b981;">${savings:,}</div>
+                            <div style="font-size: 18px; font-weight: 700; color: #10b981;">${savings_amount:,}</div>
                         </div>
                         <div>
                             <div style="font-size: 11px; color: #64748b; margin-bottom: 5px;">ROI Multiplier</div>
@@ -2340,7 +2405,7 @@ def create_demo_interface():
             
             # Combine all results
             return (
-                *update_result,  # 5 outputs: scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel
+                *update_result,  # 9 outputs: scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel, detection_time, mttr, auto_heal, savings
                 *oss_result[:3],  # 3 outputs: detection_agent, recall_agent, decision_agent
                 oss_result[3],    # 1 output: oss_results_display
                 enterprise_results,  # 1 output: enterprise_results_display  
@@ -2354,7 +2419,8 @@ def create_demo_interface():
             fn=run_complete_demo_async,
             inputs=[scenario_dropdown],
             outputs=[
-                scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,  # 5
+                scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,
+                detection_time, mttr, auto_heal, savings,  # 9
                 detection_agent, recall_agent, decision_agent,  # 3
                 oss_results_display,  # 1
                 enterprise_results_display,  # 1
@@ -2468,11 +2534,14 @@ def create_demo_interface():
             outputs=[license_display]
         )
         
-        # Load default scenario - UPDATE outputs with realism_panel
+        # Load default scenario - UPDATE outputs with realism_panel AND performance metrics
         demo.load(
-            fn=lambda: update_scenario_display(settings.default_scenario),
+            fn=lambda: update_scenario_display_with_metrics(settings.default_scenario),
             inputs=[],
-            outputs=[scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel]
+            outputs=[
+                scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,
+                detection_time, mttr, auto_heal, savings
+            ]
         )
         
         # Load ROI data
@@ -2482,7 +2551,7 @@ def create_demo_interface():
             outputs=[roi_output, roi_chart]
         )
         
-        logger.info("✅ Demo interface created successfully with boundary awareness and realism panel")
+        logger.info("✅ Demo interface created successfully with boundary awareness, realism panel, and dynamic performance metrics")
     
     return demo
 
@@ -2566,6 +2635,7 @@ if __name__ == "__main__":
         logger.info("=" * 60)
         logger.info("Enhanced with clear OSS vs Enterprise boundaries")
         logger.info("Now with Realism Panel for enterprise-seasoned SRE experience")
+        logger.info("PHASE 2: Dynamic Performance Metrics by Scenario Type")
         logger.info(f"True ARF OSS v3.3.9 integration with simulated Enterprise execution")
         logger.info("=" * 60)
         
@@ -2575,7 +2645,7 @@ if __name__ == "__main__":
         print("\n" + "="*60)
         print("🚀 ARF Ultimate Investor Demo v3.3.9 - ENTERPRISE EDITION")
         print("📊 Architecture: OSS advises → Enterprise executes")
-        print("🎭 New: Realism Panel with ranked actions & uncertainty")
+        print("🎭 Phase 2: Dynamic Performance Metrics by Scenario")
         print("🌐 Starting on http://localhost:7860")
         print("="*60 + "\n")