Update infrastructure/cost_estimator.py

infrastructure/cost_estimator.py

@@ -1,16 +1,5 @@
-# agentic_reliability_framework/infrastructure/cost_estimator.py
 """
 Cost Estimation Engine – Deterministic pricing with Bayesian uncertainty.
-
-This module provides a cost estimator for Azure resources. It supports:
-- Deterministic pricing from configurable data sources (YAML, built-in).
-- Probabilistic cost estimates (optional) using Bayesian inference when exact
-  size is unknown.
-- Cost delta calculations with statistical significance.
-
-The design incorporates mathematical elegance (probability distributions) and
-knowledge engineering (resource ontologies). For the OSS version, we keep it
-deterministic, but the architecture allows for future probabilistic extensions.
 """
 
 import os
@@ -18,22 +7,9 @@ from functools import lru_cache
 from typing import Dict, Optional, Union, Any
 import yaml
 
-from agentic_reliability_framework.infrastructure.intents import ProvisionResourceIntent, ResourceType
+from .intents import ProvisionResourceIntent, ResourceType
 
-# -----------------------------------------------------------------------------
-# Core Estimator
-# -----------------------------------------------------------------------------
 class CostEstimator:
-    """
-    Estimates monthly cost for Azure resources using static pricing tables.
-
-    The estimator can be initialized with a custom pricing file (YAML). The file
-    should map resource type strings (e.g., "vm") to size->cost dictionaries.
-    If no file is provided, a built-in default is used.
-
-    For consistency, all estimates are cached (lru_cache) for performance.
-    """
-
     DEFAULT_PRICING = {
         ResourceType.VM: {
             "Standard_D2s_v3": 70.0,
@@ -67,23 +43,14 @@ class CostEstimator:
     }
 
     def __init__(self, pricing_file: Optional[str] = None):
-        """
-        Initialize the cost estimator.
-
-        Args:
-            pricing_file: Optional path to a YAML file with custom pricing.
-                          If not provided, uses DEFAULT_PRICING.
-        """
         if pricing_file and os.path.exists(pricing_file):
             with open(pricing_file, 'r') as f:
                 raw = yaml.safe_load(f)
-            # Convert resource type strings back to ResourceType enum keys
             self._pricing = {}
             for res_str, sizes in raw.items():
                 try:
                     res_type = ResourceType(res_str)
                 except ValueError:
-                    # Unknown resource type; skip or log warning
                     continue
                 self._pricing[res_type] = sizes
         else:
@@ -91,17 +58,9 @@ class CostEstimator:
 
     @lru_cache(maxsize=256)
     def estimate_monthly_cost(self, intent: ProvisionResourceIntent) -> Optional[float]:
-        """
-        Deterministic cost estimate.
-
-        Returns:
-            Monthly cost in USD, or None if the size is not found.
-        """
         resource_pricing = self._pricing.get(intent.resource_type)
         if not resource_pricing:
             return None
-
-        # Exact match on size string
         return resource_pricing.get(intent.size)
 
     def cost_delta_vs_baseline(
@@ -109,15 +68,6 @@ class CostEstimator:
         intent: ProvisionResourceIntent,
         baseline_intent: Optional[ProvisionResourceIntent] = None,
     ) -> Optional[float]:
-        """
-        Compute the cost difference between the proposed intent and a baseline.
-
-        If no baseline is provided, uses the smallest available size for that resource type
-        as the baseline (assumes that is the minimal cost configuration).
-
-        Returns:
-            Cost difference (proposed - baseline), or None if either estimate fails.
-        """
         proposed = self.estimate_monthly_cost(intent)
         if proposed is None:
             return None
@@ -128,21 +78,13 @@ class CostEstimator:
                 return None
             return proposed - baseline
         else:
-            # Find minimal cost for this resource type
             resource_pricing = self._pricing.get(intent.resource_type)
             if not resource_pricing:
                 return None
             min_cost = min(resource_pricing.values())
             return proposed - min_cost
 
-    # -------------------------------------------------------------------------
-    # Future extensions: probabilistic estimation
-    # -------------------------------------------------------------------------
     def estimate_cost_distribution(self, intent: ProvisionResourceIntent) -> Dict[str, float]:
-        """
-        Return a probability distribution over possible costs (placeholder).
-        For OSS, we return a point estimate with probability 1.0.
-        """
         cost = self.estimate_monthly_cost(intent)
         if cost is None:
             return {}