Update app.py

app.py

@@ -1,6 +1,7 @@
 """
 🚀 ARF Ultimate Investor Demo v3.8.0 - ENTERPRISE EDITION
 With Audit Trail, Incident History, Memory Graph, and Enterprise Features
+FIXED VERSION - No Plot Errors
 """
 
 import logging
@@ -346,7 +347,7 @@ class AuditTrailManager:
         }, indent=2, default=str)
 
 # ===========================================
-# ENHANCED VISUALIZATION ENGINE
+# ENHANCED VISUALIZATION ENGINE (FIXED)
 # ===========================================
 
 class EnhancedVisualizationEngine:
@@ -375,40 +376,67 @@ class EnhancedVisualizationEngine:
             "stable": "darkgreen"
         }
         
-        for event in events:
+        symbol_map = {
+            "problem": "circle", "alert": "circle", "detection": "diamond",
+            "analysis": "diamond", "action": "square", "recovery": "star",
+            "stable": "cross"
+        }
+        
+        # Convert datetime objects to strings for Plotly
+        times = [event["time"] for event in events]
+        events_text = [event["event"] for event in events]
+        event_types = [event["type"] for event in events]
+        colors = [color_map[event_type] for event_type in event_types]
+        symbols = [symbol_map[event_type] for event_type in event_types]
+        
+        fig.add_trace(go.Scatter(
+            x=times,
+            y=[1] * len(events),  # Fixed y-position
+            mode='markers+text',
+            marker=dict(
+                size=20,
+                color=colors,
+                symbol=symbols,
+                line=dict(width=2, color='white')
+            ),
+            text=events_text,
+            textposition="top center",
+            hoverinfo="text",
+            hovertemplate="<b>%{text}</b><br>%{x|%H:%M:%S}<extra></extra>",
+            name="Timeline Events"
+        ))
+        
+        # Add connecting lines
+        for i in range(len(times) - 1):
             fig.add_trace(go.Scatter(
-                x=[event["time"]],
-                y=[1],
-                mode='markers+text',
-                marker=dict(
-                    size=15,
-                    color=color_map[event["type"]],
-                    symbol='circle' if event["type"] in ['problem', 'alert'] else 'diamond',
-                    line=dict(width=2, color='white')
-                ),
-                text=[event["event"]],
-                textposition="top center",
-                name=event["type"].capitalize(),
-                hovertemplate="<b>%{text}</b><br>%{x|%H:%M:%S}<extra></extra>"
+                x=[times[i], times[i + 1]],
+                y=[1, 1],
+                mode='lines',
+                line=dict(color='gray', width=1, dash='dash'),
+                showlegend=False,
+                hoverinfo='none'
             ))
         
         fig.update_layout(
             title="<b>Incident Timeline - Cache Miss Storm Resolution</b>",
             xaxis_title="Time →",
-            yaxis_title="Event Type",
+            yaxis=dict(
+                title="Event Type",
+                showticklabels=False,
+                range=[0.5, 1.5]  # Fixed range for better display
+            ),
             height=450,
-            showlegend=True,
-            paper_bgcolor='rgba(0,0,0,0)',
-            plot_bgcolor='rgba(0,0,0,0)',
+            showlegend=False,
+            paper_bgcolor='white',
+            plot_bgcolor='white',
             hovermode='closest',
             xaxis=dict(
                 tickformat='%H:%M',
-                gridcolor='rgba(200,200,200,0.2)'
+                gridcolor='rgba(200,200,200,0.2)',
+                showgrid=True
             ),
-            yaxis=dict(
-                showticklabels=False,
-                gridcolor='rgba(200,200,200,0.1)'
-            )
+            yaxis_showgrid=False,
+            margin=dict(l=50, r=50, t=80, b=50)
         )
         
         return fig
@@ -510,12 +538,21 @@ class EnhancedVisualizationEngine:
         fig.update_layout(
             height=700,
             showlegend=True,
-            paper_bgcolor='rgba(0,0,0,0)',
-            plot_bgcolor='rgba(0,0,0,0)',
+            paper_bgcolor='white',
+            plot_bgcolor='white',
             title_text="<b>Executive Business Dashboard</b>",
-            barmode='group'
+            barmode='group',
+            margin=dict(l=50, r=50, t=100, b=50)
         )
         
+        # Update axes
+        fig.update_xaxes(title_text="Scenario", row=1, col=1)
+        fig.update_yaxes(title_text="Cost ($)", row=1, col=1)
+        fig.update_xaxes(title_text="Activity", row=1, col=2)
+        fig.update_yaxes(title_text="Percentage (%)", row=1, col=2)
+        fig.update_xaxes(title_text="Approach", row=2, col=1)
+        fig.update_yaxes(title_text="MTTR (minutes)", row=2, col=1)
+        
         return fig
     
     @staticmethod
@@ -526,10 +563,12 @@ class EnhancedVisualizationEngine:
         if not executions:
             fig = go.Figure()
             fig.update_layout(
-                title="No execution history yet",
+                title="<b>No execution history yet</b>",
                 height=400,
-                paper_bgcolor='rgba(0,0,0,0)',
-                plot_bgcolor='rgba(0,0,0,0)'
+                paper_bgcolor='white',
+                plot_bgcolor='white',
+                xaxis_showgrid=True,
+                yaxis_showgrid=True
             )
             return fig
         
@@ -559,11 +598,18 @@ class EnhancedVisualizationEngine:
             xaxis_title="Scenario",
             yaxis_title="Cost Saved ($)",
             height=500,
-            paper_bgcolor='rgba(0,0,0,0)',
-            plot_bgcolor='rgba(0,0,0,0)',
-            showlegend=False
+            paper_bgcolor='white',
+            plot_bgcolor='white',
+            showlegend=False,
+            xaxis_showgrid=True,
+            yaxis_showgrid=True,
+            margin=dict(l=50, r=50, t=80, b=100)
         )
         
+        # Rotate x-axis labels if needed
+        if len(scenarios) > 5:
+            fig.update_xaxes(tickangle=45)
+        
         return fig
     
     @staticmethod
@@ -576,43 +622,63 @@ class EnhancedVisualizationEngine:
         incidents = list(audit_manager.incident_history)[:20]  # Last 20 incidents
         
         if not incidents:
-            # Create sample graph
-            nodes = [
-                {"id": "Incident_1", "label": "Cache Miss", "type": "incident", "size": 20},
-                {"id": "Action_1", "label": "Scale Cache", "type": "action", "size": 15},
-                {"id": "Outcome_1", "label": "Resolved", "type": "outcome", "size": 15},
-                {"id": "Component_1", "label": "Redis", "type": "component", "size": 18},
-            ]
+            # Create a simple placeholder graph
+            fig.add_trace(go.Scatter(
+                x=[0, 1, 0.5],
+                y=[0, 0, 0.866],
+                mode='markers+text',
+                marker=dict(
+                    size=[30, 20, 20],
+                    color=['#FF6B6B', '#4ECDC4', '#45B7D1']
+                ),
+                text=['Incident', 'Action', 'Outcome'],
+                textposition="top center"
+            ))
             
-            edges = [
-                {"source": "Incident_1", "target": "Action_1", "weight": 0.9, "label": "resolved_by"},
-                {"source": "Action_1", "target": "Outcome_1", "weight": 1.0, "label": "leads_to"},
-                {"source": "Incident_1", "target": "Component_1", "weight": 0.8, "label": "affects"},
-            ]
-        else:
-            # Create nodes from actual incidents
-            nodes = []
-            edges = []
+            # Add edges
+            fig.add_trace(go.Scatter(
+                x=[0, 0.5, 1],
+                y=[0, 0.866, 0],
+                mode='lines',
+                line=dict(color='gray', width=2),
+                hoverinfo='none'
+            ))
             
-            for i, incident in enumerate(incidents):
-                node_id = f"Incident_{i}"
-                nodes.append({
-                    "id": node_id,
-                    "label": incident["type"][:20],
-                    "type": "incident",
-                    "size": 15 + (incident.get("severity", 2) * 5),
-                    "severity": incident.get("severity", 2)
+            fig.update_layout(
+                title="<b>Incident Memory Graph (Sample)</b>",
+                showlegend=False,
+                height=600,
+                paper_bgcolor='white',
+                plot_bgcolor='white',
+                xaxis=dict(showgrid=False, zeroline=False, showticklabels=False, range=[-0.2, 1.2]),
+                yaxis=dict(showgrid=False, zeroline=False, showticklabels=False, range=[-0.2, 1.2]),
+                margin=dict(l=20, r=20, t=60, b=20)
+            )
+            return fig
+        
+        # Create nodes from actual incidents
+        nodes = []
+        edges = []
+        
+        for i, incident in enumerate(incidents):
+            node_id = f"Incident_{i}"
+            nodes.append({
+                "id": node_id,
+                "label": incident["type"][:20],
+                "type": "incident",
+                "size": 15 + (incident.get("severity", 2) * 5),
+                "severity": incident.get("severity", 2)
+            })
+            
+            # Create edges to previous incidents
+            if i > 0 and i % 3 == 0:  # Connect every 3rd incident
+                prev_id = f"Incident_{i-1}"
+                edges.append({
+                    "source": prev_id,
+                    "target": node_id,
+                    "weight": 0.7,
+                    "label": "related_to"
                 })
-                
-                # Create edges to previous incidents
-                if i > 0:
-                    prev_id = f"Incident_{i-1}"
-                    edges.append({
-                        "source": prev_id,
-                        "target": node_id,
-                        "weight": 0.7,
-                        "label": "related_to"
-                    })
         
         # Color mapping
         color_map = {
@@ -622,70 +688,73 @@ class EnhancedVisualizationEngine:
             "component": "#96CEB4"
         }
         
-        # Add nodes
-        node_x = []
-        node_y = []
-        node_text = []
-        node_color = []
-        node_size = []
-        
-        for i, node in enumerate(nodes):
-            # Simple layout - could be enhanced with networkx
-            angle = 2 * np.pi * i / len(nodes)
+        # Calculate positions (circular layout)
+        num_nodes = len(nodes)
+        if num_nodes > 0:
+            angles = np.linspace(0, 2 * np.pi, num_nodes, endpoint=False)
             radius = 1.0
+            node_x = radius * np.cos(angles)
+            node_y = radius * np.sin(angles)
             
-            node_x.append(radius * np.cos(angle))
-            node_y.append(radius * np.sin(angle))
-            node_text.append(f"{node['label']}<br>Type: {node['type']}")
-            node_color.append(color_map.get(node["type"], "#999999"))
-            node_size.append(node.get("size", 15))
-        
-        fig.add_trace(go.Scatter(
-            x=node_x,
-            y=node_y,
-            mode='markers+text',
-            marker=dict(
-                size=node_size,
-                color=node_color,
-                line=dict(width=2, color='white')
-            ),
-            text=[node["label"] for node in nodes],
-            textposition="top center",
-            hovertext=node_text,
-            hoverinfo="text",
-            name="Nodes"
-        ))
-        
-        # Add edges
-        for edge in edges:
-            try:
-                source_idx = next(i for i, n in enumerate(nodes) if n["id"] == edge["source"])
-                target_idx = next(i for i, n in enumerate(nodes) if n["id"] == edge["target"])
-                
-                fig.add_trace(go.Scatter(
-                    x=[node_x[source_idx], node_x[target_idx], None],
-                    y=[node_y[source_idx], node_y[target_idx], None],
-                    mode='lines',
-                    line=dict(
-                        width=2 * edge.get("weight", 1.0),
-                        color='rgba(100, 100, 100, 0.5)'
-                    ),
-                    hoverinfo='none',
-                    showlegend=False
-                ))
-            except StopIteration:
-                continue
+            # Add nodes
+            fig.add_trace(go.Scatter(
+                x=node_x,
+                y=node_y,
+                mode='markers+text',
+                marker=dict(
+                    size=[node.get("size", 15) for node in nodes],
+                    color=[color_map.get(node.get("type", "incident"), "#999999") for node in nodes],
+                    line=dict(width=2, color='white')
+                ),
+                text=[node["label"] for node in nodes],
+                textposition="top center",
+                hovertext=[f"Type: {node['type']}<br>Severity: {node.get('severity', 'N/A')}" for node in nodes],
+                hoverinfo="text",
+                name="Nodes"
+            ))
+            
+            # Add edges if we have them
+            if edges:
+                for edge in edges:
+                    try:
+                        source_idx = int(edge["source"].split("_")[1])
+                        target_idx = int(edge["target"].split("_")[1])
+                        
+                        if source_idx < num_nodes and target_idx < num_nodes:
+                            fig.add_trace(go.Scatter(
+                                x=[node_x[source_idx], node_x[target_idx], None],
+                                y=[node_y[source_idx], node_y[target_idx], None],
+                                mode='lines',
+                                line=dict(
+                                    width=2 * edge.get("weight", 1.0),
+                                    color='rgba(100, 100, 100, 0.5)'
+                                ),
+                                hoverinfo='none',
+                                showlegend=False
+                            ))
+                    except (ValueError, IndexError):
+                        continue
         
         fig.update_layout(
-            title="<b>Incident Memory Graph</b>",
-            showlegend=True,
+            title=f"<b>Incident Memory Graph ({len(nodes)} nodes)</b>",
+            showlegend=False,
             height=600,
-            paper_bgcolor='rgba(0,0,0,0)',
-            plot_bgcolor='rgba(0,0,0,0)',
+            paper_bgcolor='white',
+            plot_bgcolor='white',
             hovermode='closest',
-            xaxis=dict(showgrid=False, zeroline=False, showticklabels=False),
-            yaxis=dict(showgrid=False, zeroline=False, showticklabels=False),
-            margin=dict(l=20, r=20, t=40, b=20)
+            xaxis=dict(
+                showgrid=False, 
+                zeroline=False, 
+                showticklabels=False,
+                range=[-1.5, 1.5]
+            ),
+            yaxis=dict(
+                showgrid=False, 
+                zeroline=False, 
+                showticklabels=False,
+                range=[-1.5, 1.5]
+            ),
+            margin=dict(l=50, r=50, t=80, b=50)
         )
         
         return fig
@@ -697,7 +766,8 @@ class EnhancedVisualizationEngine:
             rows=2, cols=2,
             subplot_titles=('Incident Frequency', 'Resolution Times', 
                           'Success Rates', 'Pattern Correlation'),
-            vertical_spacing=0.15
+            vertical_spacing=0.15,
+            horizontal_spacing=0.15
         )
         
         # Sample data - in real app this would come from analysis
@@ -708,19 +778,34 @@ class EnhancedVisualizationEngine:
         
         # Incident Frequency
         fig.add_trace(
-            go.Bar(x=patterns, y=frequencies, name='Frequency'),
+            go.Bar(
+                x=patterns, 
+                y=frequencies, 
+                name='Frequency',
+                marker_color='#4ECDC4'
+            ),
             row=1, col=1
         )
         
         # Resolution Times
         fig.add_trace(
-            go.Bar(x=patterns, y=resolution_times, name='Resolution Time (min)'),
+            go.Bar(
+                x=patterns, 
+                y=resolution_times, 
+                name='Resolution Time (min)',
+                marker_color='#45B7D1'
+            ),
             row=1, col=2
         )
         
         # Success Rates
         fig.add_trace(
-            go.Bar(x=patterns, y=success_rates, name='Success Rate %'),
+            go.Bar(
+                x=patterns, 
+                y=success_rates, 
+                name='Success Rate %',
+                marker_color='#96CEB4'
+            ),
             row=2, col=1
         )
         
@@ -734,16 +819,32 @@ class EnhancedVisualizationEngine:
         ])
         
         fig.add_trace(
-            go.Heatmap(z=corr_matrix, x=patterns, y=patterns),
+            go.Heatmap(
+                z=corr_matrix, 
+                x=patterns, 
+                y=patterns,
+                colorscale='Blues',
+                showscale=True
+            ),
             row=2, col=2
         )
         
         fig.update_layout(
             height=700,
             showlegend=False,
-            title_text="<b>Pattern Analysis Dashboard</b>"
+            title_text="<b>Pattern Analysis Dashboard</b>",
+            paper_bgcolor='white',
+            plot_bgcolor='white'
         )
         
+        # Update axes
+        fig.update_xaxes(title_text="Pattern Type", row=1, col=1)
+        fig.update_yaxes(title_text="Frequency", row=1, col=1)
+        fig.update_xaxes(title_text="Pattern Type", row=1, col=2)
+        fig.update_yaxes(title_text="Time (minutes)", row=1, col=2)
+        fig.update_xaxes(title_text="Pattern Type", row=2, col=1)
+        fig.update_yaxes(title_text="Success Rate (%)", row=2, col=1)
+        
         return fig
 
 # ===========================================
@@ -1106,7 +1207,7 @@ class EnhancedBusinessLogic:
         return temp_file.name
 
 # ===========================================
-# MAIN INTERFACE
+# MAIN INTERFACE (FIXED)
 # ===========================================
 
 def create_interface() -> gr.Blocks:
@@ -1122,11 +1223,12 @@ def create_interface() -> gr.Blocks:
     h1, h2, h3 { color: #1a365d !important; }
     .critical { color: #FF6B6B !important; font-weight: bold; }
     .success { color: #4ECDC4 !important; font-weight: bold; }
+    .plot-container { background: white !important; border-radius: 10px; padding: 10px; }
     """
     
     with gr.Blocks(
         title="🚀 ARF Investor Demo v3.8.0",
-        theme=gr.themes.Soft(),
+        theme=gr.themes.Soft(primary_hue="blue", secondary_hue="teal"),
         css=custom_css
     ) as demo:
         
@@ -1178,7 +1280,10 @@ def create_interface() -> gr.Blocks:
                     with gr.Column(scale=2):
                         # Visualization
                         gr.Markdown("### 📈 Incident Timeline")
-                        timeline_output = gr.Plot()
+                        timeline_output = gr.Plot(
+                            value=viz_engine.create_incident_timeline(),
+                            label="Timeline Visualization"
+                        )
                         
                         # Action Section
                         gr.Markdown("### ⚡ Take Action")
@@ -1217,7 +1322,10 @@ def create_interface() -> gr.Blocks:
                 with gr.Column():
                     # Business Dashboard
                     gr.Markdown("### 📊 Executive Business Dashboard")
-                    dashboard_output = gr.Plot()
+                    dashboard_output = gr.Plot(
+                        value=viz_engine.create_business_dashboard(),
+                        label="Business Dashboard"
+                    )
                     
                     # ROI Calculator
                     gr.Markdown("### 🧮 Interactive ROI Calculator")
@@ -1289,7 +1397,10 @@ def create_interface() -> gr.Blocks:
                         )
                         
                         gr.Markdown("### 📈 Visual History")
-                        execution_chart = gr.Plot()
+                        execution_chart = gr.Plot(
+                            value=viz_engine.create_execution_history_chart(audit_manager),
+                            label="Cost Savings Chart"
+                        )
                         
                         # AI Analysis Results
                         gr.Markdown("### 🧠 AI Pattern Analysis")
@@ -1312,7 +1423,10 @@ def create_interface() -> gr.Blocks:
                         
                         # Memory Graph Visualization
                         gr.Markdown("### 🧠 Memory Graph")
-                        memory_graph = gr.Plot()
+                        memory_graph = gr.Plot(
+                            value=viz_engine.create_memory_graph(audit_manager),
+                            label="Memory Graph"
+                        )
                         
                         # Export Area
                         gr.Markdown("### 📤 Export & Analytics")
@@ -1444,7 +1558,10 @@ def create_interface() -> gr.Blocks:
                             auto_layout = gr.Checkbox(label="Auto-Layout", value=True)
                         
                         # Graph Visualization
-                        memory_graph_plot = gr.Plot()
+                        memory_graph_plot = gr.Plot(
+                            value=viz_engine.create_memory_graph(audit_manager),
+                            label="Memory Graph Visualization"
+                        )
                         
                         # Node Details
                         gr.Markdown("### 🔍 Selected Node Details")
@@ -1711,12 +1828,24 @@ def create_interface() -> gr.Blocks:
                 auto_layout=auto_layout
             )
         
-        for control in [graph_type, show_weights, auto_layout]:
-            control.change(
-                fn=update_graph_view,
-                inputs=[graph_type, show_weights, auto_layout],
-                outputs=[memory_graph_plot]
-            )
+        # Connect all graph controls
+        graph_type.change(
+            fn=update_graph_view,
+            inputs=[graph_type, show_weights, auto_layout],
+            outputs=[memory_graph_plot]
+        )
+        
+        show_weights.change(
+            fn=update_graph_view,
+            inputs=[graph_type, show_weights, auto_layout],
+            outputs=[memory_graph_plot]
+        )
+        
+        auto_layout.change(
+            fn=update_graph_view,
+            inputs=[graph_type, show_weights, auto_layout],
+            outputs=[memory_graph_plot]
+        )
         
         def search_memory(query: str) -> Tuple[List[List[str]], str]:
             """Search memory"""
@@ -1762,9 +1891,10 @@ def create_interface() -> gr.Blocks:
         )
         
         # ===========================================
-        # INITIALIZATION
+        # INITIALIZATION - FIXED
         # ===========================================
         
+        # Initialize with default visualizations
         demo.load(
             fn=lambda: (
                 viz_engine.create_business_dashboard(),