Update app.py

app.py

@@ -1976,32 +1976,6 @@ def update_scenario_display_with_metrics(scenario_name: str) -> tuple:
     return (scenario_card, telemetry_fig, impact_fig, timeline_fig,
             detection_time, recall_quality, confidence_score, sequencing_stage)  # Changed
 
-# In the create_demo_interface function, update outputs:
-demo_btn.click(
-    fn=run_complete_demo_async,
-    inputs=[scenario_dropdown],
-    outputs=[
-        scenario_card, telemetry_viz, impact_viz, timeline_viz,
-        detection_time, recall_quality, confidence_score, sequencing_stage,  # Changed
-        detection_process, recall_process, decision_process,
-        oss_results_display,
-        enterprise_results_display,
-        approval_display,
-        incident_table,
-        execution_table
-    ]
-)
-
-# In the scenario_dropdown.change handler:
-scenario_dropdown.change(
-    fn=update_scenario_display_with_metrics,
-    inputs=[scenario_dropdown],
-    outputs=[
-        scenario_card, telemetry_viz, impact_viz, timeline_viz,
-        detection_time, recall_quality, confidence_score, sequencing_stage  # Changed
-    ]
-)
-
 # ===========================================
 # FIXED EXECUTION FUNCTION - Returns DataFrames
 # ===========================================
@@ -2213,9 +2187,6 @@ def create_demo_interface():
     global _demo_css
     _demo_css = css_styles
     
-    # Get boundary badges for the interface
-    boundary_badges = BoundaryManager.get_boundary_badges()
-    
     # Create interface without css parameter (will be added in launch)
     with gr.Blocks(
         title=f"🚀 ARF Investor Demo v3.3.9 - TRUE ARF OSS Integration"
@@ -2233,23 +2204,88 @@ def create_demo_interface():
             
             # TAB 1: Live Incident Demo - NOW WITH DOCTRINAL COMPONENTS
             with gr.TabItem("🔥 Live Incident Demo", id="tab1"):
-                # ===== SURGICAL FIX: LINE 2739 UNPACKING CONTRACT UPDATE =====
-                # OLD (incorrect - expecting 24 values):
-                # (scenario_dropdown, scenario_card, telemetry_viz, impact_viz,
-                #  workflow_header, detection_agent, recall_agent, decision_agent,
-                #  oss_section, enterprise_section, oss_btn, enterprise_btn, 
-                #  approval_toggle, mcp_mode, timeline_viz, realism_panel,
-                #  detection_time, mttr, auto_heal, savings,
-                #  oss_results_display, enterprise_results_display, approval_display, demo_btn) = components["create_tab1_incident_demo"]()
-                
-                # NEW (correct - expecting 26 doctrinal values):
-                (scenario_dropdown, historical_panel, scenario_card, telemetry_viz, impact_viz,
-                 observation_gate_placeholder, sequencing_panel, workflow_header, 
-                 detection_process, recall_process, decision_process,
-                 oss_section, enterprise_section, oss_btn, enterprise_btn, 
-                 approval_toggle, mcp_mode, timeline_viz,
-                 detection_time, mttr, auto_heal, savings,
-                 oss_results_display, enterprise_results_display, approval_display, demo_btn) = components["create_tab1_incident_demo"]()
+                # ===== SURGICAL FIX: SAFE UNPACKING WITH ERROR HANDLING =====
+                try:
+                    logger.info("🔧 Extracting Tab1 components with safe unpacking...")
+                    
+                    # Get the raw result tuple
+                    tab1_result = components["create_tab1_incident_demo"]()
+                    
+                    # Debug logging for contract verification
+                    logger.info(f"📊 Tab1 result type: {type(tab1_result)}")
+                    if hasattr(tab1_result, '__len__'):
+                        logger.info(f"📊 Tab1 result length: {len(tab1_result)}")
+                        for i, item in enumerate(tab1_result):
+                            item_type = type(item).__name__ if hasattr(item, '__name__') else type(item)
+                            logger.debug(f"  Index {i}: {item_type}")
+                    
+                    # MANUAL INDEX-BASED UNPACKING (CONTRACT ENFORCEMENT)
+                    # Indices verified against components.py return statement
+                    scenario_dropdown = tab1_result[0]
+                    historical_panel = tab1_result[1]
+                    scenario_card = tab1_result[2]
+                    telemetry_viz = tab1_result[3]
+                    impact_viz = tab1_result[4]
+                    observation_gate_placeholder = tab1_result[5]
+                    sequencing_panel = tab1_result[6]
+                    workflow_header = tab1_result[7]
+                    detection_process = tab1_result[8]
+                    recall_process = tab1_result[9]
+                    decision_process = tab1_result[10]
+                    oss_section = tab1_result[11]
+                    enterprise_section = tab1_result[12]
+                    oss_btn = tab1_result[13]
+                    enterprise_btn = tab1_result[14]
+                    approval_toggle = tab1_result[15]
+                    mcp_mode = tab1_result[16]
+                    timeline_viz = tab1_result[17]
+                    detection_time = tab1_result[18]
+                    recall_quality = tab1_result[19]      # ← CRITICAL: WAS mttr
+                    confidence_score = tab1_result[20]    # ← CRITICAL: WAS auto_heal
+                    sequencing_stage = tab1_result[21]    # ← CRITICAL: WAS savings
+                    oss_results_display = tab1_result[22]
+                    enterprise_results_display = tab1_result[23]
+                    approval_display = tab1_result[24]
+                    demo_btn = tab1_result[25]            # ← CRITICAL: Index 25 MUST be demo_btn
+                    
+                    logger.info("✅ Tab1 components successfully extracted with correct contract")
+                    
+                except Exception as e:
+                    logger.error(f"❌ Tab1 component extraction failed: {e}")
+                    logger.error("🔄 Creating fallback components to maintain system integrity...")
+                    
+                    # FALLBACK CREATION (Minimal viable components)
+                    import gradio as gr
+                    
+                    # Create minimal placeholder components
+                    scenario_dropdown = gr.Dropdown(choices=["Error Mode"], value="Error Mode")
+                    historical_panel = gr.DataFrame(value=[["System in recovery mode"]])
+                    scenario_card = gr.Markdown("### System Initialization Issue")
+                    telemetry_viz = gr.Plot()
+                    impact_viz = gr.Plot()
+                    observation_gate_placeholder = gr.Markdown("**Observation Gate:** System integrity check")
+                    sequencing_panel = gr.Markdown("**Sequencing:** Initializing...")
+                    workflow_header = gr.Markdown("### Policy Recovery Mode")
+                    detection_process = gr.Textbox(value="DETECTION: ERROR")
+                    recall_process = gr.Textbox(value="RECALL: ERROR")
+                    decision_process = gr.Textbox(value="DECISION: ERROR")
+                    oss_section = gr.Markdown("#### OSS: Unavailable")
+                    enterprise_section = gr.Markdown("#### Enterprise: Unavailable")
+                    oss_btn = gr.Button("Unavailable", variant="secondary")
+                    enterprise_btn = gr.Button("Unavailable", variant="secondary")
+                    approval_toggle = gr.Checkbox(label="Approval: Error", value=False)
+                    mcp_mode = gr.Radio(choices=["Error"], value="Error")
+                    timeline_viz = gr.Plot()
+                    detection_time = gr.Number(value=0)
+                    recall_quality = gr.Number(value=0)      # ← CORRECT VARIABLE NAME
+                    confidence_score = gr.Number(value=0)    # ← CORRECT VARIABLE NAME
+                    sequencing_stage = gr.Textbox(value="Error")  # ← CORRECT VARIABLE NAME
+                    oss_results_display = gr.Markdown("### Results: Unavailable")
+                    enterprise_results_display = gr.Markdown("### Results: Unavailable")
+                    approval_display = gr.Markdown("**Status:** System recovery in progress")
+                    demo_btn = gr.Button("🔄 System Recovery Required", variant="secondary", size="lg")
+                    
+                    logger.warning("⚠️ Using fallback components - full functionality limited")
                 # ===== END SURGICAL FIX =====
             
             # TAB 2: Business ROI
@@ -2280,12 +2316,11 @@ def create_demo_interface():
         
         # Update scenario display when dropdown changes - NOW INCLUDES PERFORMANCE METRICS
         scenario_dropdown.change(
-            fn=update_scenario_display_with_metrics,  # ← Changed to combined function
+            fn=update_scenario_display_with_metrics,
             inputs=[scenario_dropdown],
             outputs=[
                 scenario_card, telemetry_viz, impact_viz, timeline_viz,
-                detection_time, mttr, auto_heal, savings  # 4 new outputs for metrics
-                # Note: realism_panel removed as it's now replaced by doctrinal components
+                detection_time, recall_quality, confidence_score, sequencing_stage  # ← CHANGED FROM mttr, auto_heal, savings
             ]
         )
         
@@ -2511,7 +2546,7 @@ def create_demo_interface():
             
             # Combine all results
             return (
-                *update_result,  # 8 outputs: scenario_card, telemetry_viz, impact_viz, timeline_viz, detection_time, mttr, auto_heal, savings
+                *update_result,  # 8 outputs: scenario_card, telemetry_viz, impact_viz, timeline_viz, detection_time, recall_quality, confidence_score, sequencing_stage
                 *oss_result[:3],  # 3 outputs: detection_process, recall_process, decision_process
                 oss_result[3],    # 1 output: oss_results_display
                 enterprise_results,  # 1 output: enterprise_results_display  
@@ -2526,7 +2561,7 @@ def create_demo_interface():
             inputs=[scenario_dropdown],
             outputs=[
                 scenario_card, telemetry_viz, impact_viz, timeline_viz,
-                detection_time, mttr, auto_heal, savings,  # 8
+                detection_time, recall_quality, confidence_score, sequencing_stage,  # 8
                 detection_process, recall_process, decision_process,  # 3
                 oss_results_display,  # 1
                 enterprise_results_display,  # 1
@@ -2646,7 +2681,7 @@ def create_demo_interface():
             inputs=[],
             outputs=[
                 scenario_card, telemetry_viz, impact_viz, timeline_viz,
-                detection_time, mttr, auto_heal, savings
+                detection_time, recall_quality, confidence_score, sequencing_stage
             ]
         )