Update app.py

app.py

@@ -4,6 +4,7 @@
 # UPDATED: Added realism panel integration for enterprise-seasoned SRE experience
 # UPDATED: Added dynamic performance metrics for Phase 2
 # SURGICAL FIX: Fixed AsyncRunner.async_to_sync contract violation
+# DOCTRINAL FIX: Updated unpacking contract from 24 to 26 values
 
 import logging
 import sys
@@ -918,7 +919,7 @@ async def run_true_arf_analysis(scenario_name: str) -> tuple:
                    text-align: center; flex: 1; margin: 5px; min-height: 180px;">
             <div style="font-size: 32px; margin-bottom: 10px; color: {boundary_color};">🕵️‍♂️</div>
             <div style="width: 100%;">
-                <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Detection Agent</h4>
+                <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Detection Process</h4>
                 <p style="font-size: 13px; color: #64748b; margin-bottom: 12px; line-height: 1.4;">
                     {confidence_text}
                 </p>
@@ -958,7 +959,7 @@ async def run_true_arf_analysis(scenario_name: str) -> tuple:
                    text-align: center; flex: 1; margin: 5px; min-height: 180px;">
             <div style="font-size: 32px; margin-bottom: 10px; color: {boundary_color};">🧠</div>
             <div style="width: 100%;">
-                <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Recall Agent</h4>
+                <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Recall Process</h4>
                 <p style="font-size: 13px; color: #64748b; margin-bottom: 12px; line-height: 1.4;">
                     {recall_text}
                 </p>
@@ -998,7 +999,7 @@ async def run_true_arf_analysis(scenario_name: str) -> tuple:
                    text-align: center; flex: 1; margin: 5px; min-height: 180px;">
             <div style="font-size: 32px; margin-bottom: 10px; color: {boundary_color};">🎯</div>
             <div style="width: 100%;">
-                <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Decision Agent</h4>
+                <h4 style="margin: 0 0 8px 0; font-size: 16px; color: #1e293b;">Decision Process</h4>
                 <p style="font-size: 13px; color: #64748b; margin-bottom: 12px; line-height: 1.4;">
                     {decision_text}
                 </p>
@@ -2207,14 +2208,26 @@ def create_demo_interface():
         # ============ 5 TABS ============
         with gr.Tabs(elem_classes="tab-nav"):
             
-            # TAB 1: Live Incident Demo - NOW WITH REALISM PANEL
+            # TAB 1: Live Incident Demo - NOW WITH DOCTRINAL COMPONENTS
             with gr.TabItem("🔥 Live Incident Demo", id="tab1"):
-                (scenario_dropdown, scenario_card, telemetry_viz, impact_viz,
-                 workflow_header, detection_agent, recall_agent, decision_agent,
+                # ===== SURGICAL FIX: LINE 2739 UNPACKING CONTRACT UPDATE =====
+                # OLD (incorrect - expecting 24 values):
+                # (scenario_dropdown, scenario_card, telemetry_viz, impact_viz,
+                #  workflow_header, detection_agent, recall_agent, decision_agent,
+                #  oss_section, enterprise_section, oss_btn, enterprise_btn, 
+                #  approval_toggle, mcp_mode, timeline_viz, realism_panel,
+                #  detection_time, mttr, auto_heal, savings,
+                #  oss_results_display, enterprise_results_display, approval_display, demo_btn) = components["create_tab1_incident_demo"]()
+                
+                # NEW (correct - expecting 26 doctrinal values):
+                (scenario_dropdown, historical_panel, scenario_card, telemetry_viz, impact_viz,
+                 observation_gate_placeholder, sequencing_panel, workflow_header, 
+                 detection_process, recall_process, decision_process,
                  oss_section, enterprise_section, oss_btn, enterprise_btn, 
-                 approval_toggle, mcp_mode, timeline_viz, realism_panel,
+                 approval_toggle, mcp_mode, timeline_viz,
                  detection_time, mttr, auto_heal, savings,
                  oss_results_display, enterprise_results_display, approval_display, demo_btn) = components["create_tab1_incident_demo"]()
+                # ===== END SURGICAL FIX =====
             
             # TAB 2: Business ROI
             with gr.TabItem("💰 Business Impact & ROI", id="tab2"):
@@ -2247,8 +2260,9 @@ def create_demo_interface():
             fn=update_scenario_display_with_metrics,  # ← Changed to combined function
             inputs=[scenario_dropdown],
             outputs=[
-                scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,
+                scenario_card, telemetry_viz, impact_viz, timeline_viz,
                 detection_time, mttr, auto_heal, savings  # 4 new outputs for metrics
+                # Note: realism_panel removed as it's now replaced by doctrinal components
             ]
         )
         
@@ -2268,7 +2282,7 @@ def create_demo_interface():
             fn=run_oss_analysis_real_arf,
             inputs=[scenario_dropdown],
             outputs=[
-                detection_agent, recall_agent, decision_agent,
+                detection_process, recall_process, decision_process,
                 oss_results_display, incident_table
             ]
         )
@@ -2474,8 +2488,8 @@ def create_demo_interface():
             
             # Combine all results
             return (
-                *update_result,  # 9 outputs: scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel, detection_time, mttr, auto_heal, savings
-                *oss_result[:3],  # 3 outputs: detection_agent, recall_agent, decision_agent
+                *update_result,  # 8 outputs: scenario_card, telemetry_viz, impact_viz, timeline_viz, detection_time, mttr, auto_heal, savings
+                *oss_result[:3],  # 3 outputs: detection_process, recall_process, decision_process
                 oss_result[3],    # 1 output: oss_results_display
                 enterprise_results,  # 1 output: enterprise_results_display  
                 demo_message,  # 1 output: approval_display
@@ -2488,9 +2502,9 @@ def create_demo_interface():
             fn=run_complete_demo_async,
             inputs=[scenario_dropdown],
             outputs=[
-                scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,
-                detection_time, mttr, auto_heal, savings,  # 9
-                detection_agent, recall_agent, decision_agent,  # 3
+                scenario_card, telemetry_viz, impact_viz, timeline_viz,
+                detection_time, mttr, auto_heal, savings,  # 8
+                detection_process, recall_process, decision_process,  # 3
                 oss_results_display,  # 1
                 enterprise_results_display,  # 1
                 approval_display,  # 1
@@ -2603,12 +2617,12 @@ def create_demo_interface():
             outputs=[license_display]
         )
         
-        # Load default scenario - UPDATE outputs with realism_panel AND performance metrics
+        # Load default scenario - UPDATE outputs without realism_panel
         demo.load(
             fn=lambda: update_scenario_display_with_metrics(settings.default_scenario),
             inputs=[],
             outputs=[
-                scenario_card, telemetry_viz, impact_viz, timeline_viz, realism_panel,
+                scenario_card, telemetry_viz, impact_viz, timeline_viz,
                 detection_time, mttr, auto_heal, savings
             ]
         )
@@ -2620,7 +2634,7 @@ def create_demo_interface():
             outputs=[roi_output, roi_chart]
         )
         
-        logger.info("✅ Demo interface created successfully with boundary awareness, realism panel, and dynamic performance metrics")
+        logger.info("✅ Demo interface created successfully with boundary awareness, doctrinal components, and dynamic performance metrics")
     
     return demo
 # ===========================================
@@ -2702,7 +2716,7 @@ if __name__ == "__main__":
         logger.info("🚀 ARF Ultimate Investor Demo v3.3.9 - ENTERPRISE EDITION")
         logger.info("=" * 60)
         logger.info("Enhanced with clear OSS vs Enterprise boundaries")
-        logger.info("Now with Realism Panel for enterprise-seasoned SRE experience")
+        logger.info("DOCTRINAL COMPLIANCE: Historical Evidence, Observation Gate, Sequencing")
         logger.info("PHASE 2: Dynamic Performance Metrics by Scenario")
         logger.info(f"True ARF OSS v3.3.9 integration with simulated Enterprise execution")
         logger.info("=" * 60)
@@ -2713,7 +2727,7 @@ if __name__ == "__main__":
         print("\n" + "="*60)
         print("🚀 ARF Ultimate Investor Demo v3.3.9 - ENTERPRISE EDITION")
         print("📊 Architecture: OSS advises → Enterprise executes")
-        print("🎭 Phase 2: Dynamic Performance Metrics by Scenario")
+        print("🎭 DOCTRINAL: Historical Evidence + Observation Gate + Sequencing")
         print("🌐 Starting on http://localhost:7860")
         print("="*60 + "\n")