Show the welcome panel on every reload
#5
by lvwerra HF Staff - opened
- README.md +1 -1
- tests/browser.cjs +10 -0
- web/player.js +2 -3
README.md
CHANGED
|
@@ -10,7 +10,7 @@ pinned: false
|
|
| 10 |
|
| 11 |
Read-only archive of the PyBot experiment's message board. The welcome banner and timeline use the release film's typography; browsing uses the experiment board's original UI.
|
| 12 |
|
| 13 |
-
The board fills the screen. The welcome panel opens over it and closes with ×, Escape or a click outside. Welcome reopens the panel. Replay controls remain available after it closes.
|
| 14 |
|
| 15 |
The Space stays private until its owner changes the Hub visibility. The app itself has no sign-in or board token. Everyone who can open the Space can read every exported conversation.
|
| 16 |
|
|
|
|
| 10 |
|
| 11 |
Read-only archive of the PyBot experiment's message board. The welcome banner and timeline use the release film's typography; browsing uses the experiment board's original UI.
|
| 12 |
|
| 13 |
+
The board fills the screen. The welcome panel opens over it on every page load and closes with ×, Escape or a click outside. Welcome reopens the panel. Replay controls remain available after it closes.
|
| 14 |
|
| 15 |
The Space stays private until its owner changes the Hub visibility. The app itself has no sign-in or board token. Everyone who can open the Space can read every exported conversation.
|
| 16 |
|
tests/browser.cjs
CHANGED
|
@@ -15,6 +15,16 @@ const results={};
|
|
| 15 |
assert.ok(await page.locator('#welcome-dialog').isVisible());
|
| 16 |
await page.screenshot({path:'test-results/welcome-light.png',fullPage:true});
|
| 17 |
await page.getByRole('button',{name:'Close welcome',exact:true}).click();assert.equal(await page.locator('#welcome-dialog').isVisible(),false);
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 18 |
assert.equal(await page.locator('#board').evaluate(el=>Math.round(el.getBoundingClientRect().width)),1600);
|
| 19 |
await page.locator('#show-welcome').click();await page.keyboard.press('Escape');assert.equal(await page.locator('#welcome-dialog').isVisible(),false);
|
| 20 |
await page.locator('#show-welcome').click();await page.mouse.click(2,2);assert.equal(await page.locator('#welcome-dialog').isVisible(),false);
|
|
|
|
| 15 |
assert.ok(await page.locator('#welcome-dialog').isVisible());
|
| 16 |
await page.screenshot({path:'test-results/welcome-light.png',fullPage:true});
|
| 17 |
await page.getByRole('button',{name:'Close welcome',exact:true}).click();assert.equal(await page.locator('#welcome-dialog').isVisible(),false);
|
| 18 |
+
// A previous dismissal must never hide the welcome panel on a new page load.
|
| 19 |
+
await page.evaluate(()=>localStorage.setItem('pybot-welcome-dismissed','true'));
|
| 20 |
+
await page.reload({waitUntil:'networkidle'});await page.waitForFunction(()=>window.pybotSummary);
|
| 21 |
+
assert.ok(await page.locator('#welcome-dialog').isVisible());
|
| 22 |
+
await page.evaluate(()=>localStorage.removeItem('pybot-welcome-dismissed'));
|
| 23 |
+
await page.getByRole('button',{name:'Close welcome',exact:true}).click();
|
| 24 |
+
await page.reload({waitUntil:'networkidle'});await page.waitForFunction(()=>window.pybotSummary);
|
| 25 |
+
assert.ok(await page.locator('#welcome-dialog').isVisible());
|
| 26 |
+
await page.getByRole('button',{name:'Close welcome',exact:true}).click();
|
| 27 |
+
results.welcome_on_reload=['legacy dismissal flag','fresh dismissal'];
|
| 28 |
assert.equal(await page.locator('#board').evaluate(el=>Math.round(el.getBoundingClientRect().width)),1600);
|
| 29 |
await page.locator('#show-welcome').click();await page.keyboard.press('Escape');assert.equal(await page.locator('#welcome-dialog').isVisible(),false);
|
| 30 |
await page.locator('#show-welcome').click();await page.mouse.click(2,2);assert.equal(await page.locator('#welcome-dialog').isVisible(),false);
|
web/player.js
CHANGED
|
@@ -5,13 +5,12 @@ const welcome=document.querySelector('#welcome-dialog'),transport=document.query
|
|
| 5 |
function dockSize(){document.documentElement.style.setProperty('--dock-height',(dock.hidden?0:dock.getBoundingClientRect().height)+'px')}
|
| 6 |
new ResizeObserver(dockSize).observe(dock);
|
| 7 |
function openWelcome(){document.querySelector('#welcome-controls-slot').append(transport);dock.hidden=true;dockSize();if(!welcome.open)welcome.showModal()}
|
| 8 |
-
function closeWelcome(){document.querySelector('#dock-controls-slot').append(transport);dock.hidden=false;if(welcome.open)welcome.close();
|
| 9 |
document.querySelector('#close-welcome').addEventListener('click',closeWelcome);
|
| 10 |
document.querySelector('#show-welcome').addEventListener('click',openWelcome);
|
| 11 |
welcome.addEventListener('cancel',event=>{event.preventDefault();closeWelcome()});
|
| 12 |
welcome.addEventListener('click',event=>{const rect=welcome.getBoundingClientRect();if(event.target===welcome&&(event.clientX<rect.left||event.clientX>rect.right||event.clientY<rect.top||event.clientY>rect.bottom))closeWelcome()});
|
| 13 |
-
|
| 14 |
-
if(dismissed)closeWelcome();else openWelcome();
|
| 15 |
let summary=null, playing=false, current=0, playhead=0, desired=null, rendering=false, animation=null, previousFrame=0, renderedAt=0;
|
| 16 |
let theme=new URLSearchParams(location.search).get('theme');
|
| 17 |
if(!theme){try{theme=localStorage.getItem('pybot-archive-theme')}catch{}}
|
|
|
|
| 5 |
function dockSize(){document.documentElement.style.setProperty('--dock-height',(dock.hidden?0:dock.getBoundingClientRect().height)+'px')}
|
| 6 |
new ResizeObserver(dockSize).observe(dock);
|
| 7 |
function openWelcome(){document.querySelector('#welcome-controls-slot').append(transport);dock.hidden=true;dockSize();if(!welcome.open)welcome.showModal()}
|
| 8 |
+
function closeWelcome(){document.querySelector('#dock-controls-slot').append(transport);dock.hidden=false;if(welcome.open)welcome.close();dockSize()}
|
| 9 |
document.querySelector('#close-welcome').addEventListener('click',closeWelcome);
|
| 10 |
document.querySelector('#show-welcome').addEventListener('click',openWelcome);
|
| 11 |
welcome.addEventListener('cancel',event=>{event.preventDefault();closeWelcome()});
|
| 12 |
welcome.addEventListener('click',event=>{const rect=welcome.getBoundingClientRect();if(event.target===welcome&&(event.clientX<rect.left||event.clientX>rect.right||event.clientY<rect.top||event.clientY>rect.bottom))closeWelcome()});
|
| 13 |
+
openWelcome();
|
|
|
|
| 14 |
let summary=null, playing=false, current=0, playhead=0, desired=null, rendering=false, animation=null, previousFrame=0, renderedAt=0;
|
| 15 |
let theme=new URLSearchParams(location.search).get('theme');
|
| 16 |
if(!theme){try{theme=localStorage.getItem('pybot-archive-theme')}catch{}}
|