Fix undefined variable error and ensure user-provided budget_amount is used for OpenAI recommendations

app/smart_recommendation.py

@@ -383,42 +383,48 @@ class SmartBudgetRecommender:
                             if budget_amount and budget_amount > 0:
                                 # Generate recommendation using the provided budget_amount (user's input)
                                 avg_expense = budget_amount
-                            monthly_values = [avg_expense]
-                            std_dev = avg_expense * 0.05
-                            months_analyzed = 1
-                            
-                            data = {
-                                "average_monthly": avg_expense,
-                                "total": avg_expense,
-                                "count": 1,
-                                "months_analyzed": months_analyzed,
-                                "std_dev": std_dev,
-                                "monthly_values": monthly_values,
-                            }
-                            
-                            confidence = self._calculate_confidence(data)
-                            
-                            # Get AI recommendation
-                            ai_result = self._get_ai_recommendation(category_name, data, avg_expense)
-                            if ai_result and ai_result.get("recommended_budget"):
-                                recommended_budget = ai_result.get("recommended_budget")
-                                reason = ai_result.get("reason", f"AI recommendation for {category_name}")
-                                action = ai_result.get("action")
-                            else:
-                                recommended_budget = avg_expense * 1.10
-                                reason = f"Based on your budget of {budget_amount:,.0f}, I recommend {recommended_budget:,.0f} to account for variability and inflation."
-                                action = "increase"
-                            
-                            return [BudgetRecommendation(
-                                category=category_name,
-                                category_id=actual_category_id,
-                                average_expense=round(avg_expense, 2),
-                                recommended_budget=round(recommended_budget or 0, 2),
-                                reason=reason,
-                                confidence=confidence,
-                                action=action
-                            )]
-                        elif budget_amount_from_budget > 0:
+                                monthly_values = [avg_expense]
+                                std_dev = avg_expense * 0.05
+                                months_analyzed = 1
+                                
+                                data = {
+                                    "average_monthly": avg_expense,
+                                    "total": avg_expense,
+                                    "count": 1,
+                                    "months_analyzed": months_analyzed,
+                                    "std_dev": std_dev,
+                                    "monthly_values": monthly_values,
+                                }
+                                
+                                confidence = self._calculate_confidence(data)
+                                
+                                # Get AI recommendation - pass the user's budget_amount so OpenAI knows what they set
+                                ai_result = self._get_ai_recommendation(category_name, data, avg_expense)
+                                if ai_result and ai_result.get("recommended_budget"):
+                                    recommended_budget = ai_result.get("recommended_budget")
+                                    reason = ai_result.get("reason", f"AI recommendation for {category_name}")
+                                    action = ai_result.get("action")
+                                else:
+                                    recommended_budget = avg_expense * 1.10
+                                    reason = f"Based on your budget of {budget_amount:,.0f}, I recommend {recommended_budget:,.0f} to account for variability and inflation."
+                                    action = "increase"
+                                
+                                return [BudgetRecommendation(
+                                    category=category_name,
+                                    category_id=actual_category_id,
+                                    average_expense=round(avg_expense, 2),
+                                    recommended_budget=round(recommended_budget or 0, 2),
+                                    reason=reason,
+                                    confidence=confidence,
+                                    action=action
+                                )]
+                        
+                        # Budget exists but no categories - use budget name and amount
+                        budget_max_amount = float(budget_by_id.get("maxAmount", 0) or 0)
+                        budget_spend_amount = float(budget_by_id.get("spendAmount", 0) or 0)
+                        budget_amount_from_budget = budget_spend_amount if budget_spend_amount > 0 else budget_max_amount
+                        
+                        if budget_amount_from_budget > 0:
                             # Budget exists but no categories - use budget name and amount
                             budget_name = budget_by_id.get("name", "Budget")
                             if budget_amount is None: