Prioritize user-provided budget_amount over budget's maxAmount when category_id is a budget _id

app/smart_recommendation.py

@@ -352,11 +352,6 @@ class SmartBudgetRecommender:
                             budget_user_match = (str(budget_created_by) == str(user_id))
                     
                     if budget_user_match:
-                        # Extract budget amount and categories
-                        budget_max_amount = float(budget_by_id.get("maxAmount", 0) or 0)
-                        budget_spend_amount = float(budget_by_id.get("spendAmount", 0) or 0)
-                        budget_amount_from_budget = budget_spend_amount if budget_spend_amount > 0 else budget_max_amount
-                        
                         # Extract categories from headCategories
                         head_categories = budget_by_id.get("headCategories", [])
                         category_ids_in_budget = []
@@ -372,18 +367,22 @@ class SmartBudgetRecommender:
                                         if nc_id:
                                             category_ids_in_budget.append(str(nc_id))
                         
-                        # If budget has categories and amount, generate recommendation
-                        if category_ids_in_budget and budget_amount_from_budget > 0:
+                        # If budget has categories, generate recommendation
+                        if category_ids_in_budget:
                             # Use the first category ID found in the budget
                             actual_category_id = category_ids_in_budget[0]
                             category_name = self._get_category_name(actual_category_id)
                             
-                            # Use budget amount if no budget_amount provided
-                            if budget_amount is None:
-                                budget_amount = budget_amount_from_budget
+                            # PRIORITY: Use provided budget_amount if available, otherwise use budget's maxAmount
+                            if budget_amount is None or budget_amount <= 0:
+                                budget_max_amount = float(budget_by_id.get("maxAmount", 0) or 0)
+                                budget_spend_amount = float(budget_by_id.get("spendAmount", 0) or 0)
+                                budget_amount = budget_spend_amount if budget_spend_amount > 0 else budget_max_amount
                             
-                            # Generate recommendation using the budget's data
-                            avg_expense = budget_amount
+                            # If we have a valid budget amount, generate recommendation
+                            if budget_amount and budget_amount > 0:
+                                # Generate recommendation using the provided budget_amount (user's input)
+                                avg_expense = budget_amount
                             monthly_values = [avg_expense]
                             std_dev = avg_expense * 0.05
                             months_analyzed = 1