Remove all excessive debug logs from check_user_has_category_data

app/smart_recommendation.py

@@ -267,7 +267,7 @@ class SmartBudgetRecommender:
                 except Exception:
                     continue
         
-        # THIRD: Also try a more comprehensive query using $and and $or
+        # THIRD: Try comprehensive query using $and and $or
         try:
             comprehensive_query = {
                 "$and": [
@@ -275,167 +275,49 @@ class SmartBudgetRecommender:
                     {"$or": category_conditions}
                 ]
             }
-            budget_count = self.db.budgets.count_documents(comprehensive_query)
-            if budget_count > 0:
-                print(f"✅ Found {budget_count} budget(s) using comprehensive query for user {user_id} with category_id {category_id}")
+            if self.db.budgets.count_documents(comprehensive_query) > 0:
                 return True
-        except Exception as e:
-            print(f"⚠️ Error with comprehensive query: {e}")
-        
-        # Debug: Check if user has ANY budgets at all and what categories they have
-        try:
-            user_objid = ObjectId(user_id)
-            total_budgets = self.db.budgets.count_documents({"$or": [{"createdBy": user_objid}, {"createdBy": user_id}, {"user_id": user_objid}, {"user_id": user_id}]})
-            print(f"🔍 Debug: User {user_id} has {total_budgets} total budgets")
-            
-            # Get all budgets and check their category structure
-            all_budgets = list(self.db.budgets.find({"$or": [{"createdBy": user_objid}, {"createdBy": user_id}]}).limit(10))
-            if all_budgets:
-                print(f"🔍 Debug: Analyzing {len(all_budgets)} budgets to find category structure:")
-                category_ids_found = set()
-                for i, budget in enumerate(all_budgets[:5], 1):  # Show first 5
-                    cat_id = budget.get('category') or budget.get('categoryId') or budget.get('headCategory')
-                    head_cats = budget.get('headCategories', [])
-                    print(f"   Budget {i}:")
-                    print(f"     - category: {budget.get('category')}")
-                    print(f"     - categoryId: {budget.get('categoryId')}")
-                    print(f"     - headCategory: {budget.get('headCategory')}")
-                    print(f"     - headCategories: {head_cats}")
-                    
-                    # Check if requested category_id is in headCategories
-                    if head_cats and isinstance(head_cats, list):
-                        for hc in head_cats:
-                            if isinstance(hc, dict):
-                                hc_id = hc.get('headCategory')
-                                if hc_id:
-                                    cat_id_str = str(hc_id)
-                                    category_ids_found.add(cat_id_str)
-                                    if cat_id_str == str(category_id):
-                                        print(f"     ✅ MATCH FOUND: category_id {category_id} found in headCategories.headCategory!")
-                                
-                                # Check nested categories
-                                nested_cats = hc.get('categories', [])
-                                if nested_cats:
-                                    for nc in nested_cats:
-                                        if isinstance(nc, dict):
-                                            nc_id = nc.get('category')
-                                            if nc_id:
-                                                nc_id_str = str(nc_id)
-                                                category_ids_found.add(nc_id_str)
-                                                if nc_id_str == str(category_id):
-                                                    print(f"     ✅ MATCH FOUND: category_id {category_id} found in headCategories.categories.category!")
-                    
-                    if cat_id:
-                        cat_id_str = str(cat_id)
-                        category_ids_found.add(cat_id_str)
-                        if cat_id_str == str(category_id):
-                            print(f"     ✅ MATCH FOUND: category_id {category_id} found in direct category field!")
-                
-                print(f"🔍 Debug: Unique category_ids found in user's budgets: {list(category_ids_found)}")
-                print(f"🔍 Debug: Looking for category_id: {category_id}")
-                if str(category_id) not in category_ids_found:
-                    print(f"   ❌ Requested category_id {category_id} NOT found in any of the user's budgets")
-                else:
-                    print(f"   ✅ Requested category_id {category_id} IS in user's budgets but query didn't match!")
-        except Exception as e:
-            print(f"⚠️ Error in debug check: {e}")
-            import traceback
-            traceback.print_exc()
+        except Exception:
+            pass
         
-        # Check expenses collection as fallback - more comprehensive search
-        print(f"🔍 Checking expenses collection for user {user_id} with category_id {category_id}")
+        # FOURTH: Check expenses collection as fallback
         try:
             try:
                 category_objid = ObjectId(category_id)
-                # Try multiple expense query patterns
-                expense_queries = [
-                    {"user_id": ObjectId(user_id), "category": category_objid},
-                    {"user_id": ObjectId(user_id), "category": category_id},
-                    {"user_id": ObjectId(user_id), "categoryId": category_objid},
-                    {"user_id": ObjectId(user_id), "categoryId": category_id},
-                    {"user_id": ObjectId(user_id), "headCategory": category_objid},
-                    {"user_id": ObjectId(user_id), "headCategory": category_id},
-                    {"user_id": user_id, "category": category_objid},
-                    {"user_id": user_id, "category": category_id},
-                    {"user_id": user_id, "categoryId": category_objid},
-                    {"user_id": user_id, "categoryId": category_id},
-                    {"user_id": user_id, "headCategory": category_objid},
-                    {"user_id": user_id, "headCategory": category_id},
+                expense_user_conditions = [
+                    {"user_id": ObjectId(user_id)},
+                    {"user_id": user_id},
+                    {"createdBy": ObjectId(user_id)},
+                    {"createdBy": user_id}
+                ]
+                expense_category_conditions = [
+                    {"category": category_objid},
+                    {"category": category_id},
+                    {"categoryId": category_objid},
+                    {"categoryId": category_id},
+                    {"headCategory": category_objid},
+                    {"headCategory": category_id}
                 ]
             except (ValueError, TypeError):
-                expense_queries = [
-                    {"user_id": ObjectId(user_id), "category": category_id},
-                    {"user_id": ObjectId(user_id), "categoryId": category_id},
-                    {"user_id": ObjectId(user_id), "headCategory": category_id},
-                    {"user_id": user_id, "category": category_id},
-                    {"user_id": user_id, "categoryId": category_id},
-                    {"user_id": user_id, "headCategory": category_id},
+                expense_user_conditions = [
+                    {"user_id": user_id},
+                    {"createdBy": user_id}
+                ]
+                expense_category_conditions = [
+                    {"category": category_id},
+                    {"categoryId": category_id},
+                    {"headCategory": category_id}
                 ]
             
-            # Try each query pattern
-            for i, expense_query in enumerate(expense_queries, 1):
-                try:
-                    expense_count = self.db.expenses.count_documents(expense_query)
-                    if expense_count > 0:
-                        print(f"✅ Found {expense_count} expense(s) for user {user_id} with category_id {category_id}")
-                        print(f"   Expense query that matched (pattern {i}): {expense_query}")
-                        return True
-                except Exception as e:
-                    print(f"⚠️ Error with expense query pattern {i}: {e}")
-            
-            # Also try comprehensive query
-            try:
-                comprehensive_expense_query = {
-                    "$and": [
-                        {"$or": [
-                            {"user_id": ObjectId(user_id)},
-                            {"user_id": user_id}
-                        ]},
-                        {"$or": [
-                            {"category": category_objid if 'category_objid' in locals() else category_id},
-                            {"category": category_id},
-                            {"categoryId": category_objid if 'category_objid' in locals() else category_id},
-                            {"categoryId": category_id},
-                            {"headCategory": category_objid if 'category_objid' in locals() else category_id},
-                            {"headCategory": category_id},
-                        ]}
-                    ]
-                }
-                expense_count = self.db.expenses.count_documents(comprehensive_expense_query)
-                if expense_count > 0:
-                    print(f"✅ Found {expense_count} expense(s) using comprehensive query for user {user_id} with category_id {category_id}")
-                    return True
-            except Exception as e:
-                print(f"⚠️ Error with comprehensive expense query: {e}")
-            
-            # Debug: Check total expenses for this user
-            try:
-                total_user_expenses = self.db.expenses.count_documents({
-                    "$or": [
-                        {"user_id": ObjectId(user_id)},
-                        {"user_id": user_id}
-                    ]
-                })
-                print(f"🔍 Debug: User {user_id} has {total_user_expenses} total expenses")
-                
-                # Check if category exists in any expense (sample check)
-                sample_expenses = list(self.db.expenses.find({
-                    "$or": [
-                        {"user_id": ObjectId(user_id)},
-                        {"user_id": user_id}
-                    ]
-                }).limit(5))
-                if sample_expenses:
-                    print(f"🔍 Debug: Sample expense category fields:")
-                    for exp in sample_expenses:
-                        print(f"   - category: {exp.get('category')}, categoryId: {exp.get('categoryId')}, headCategory: {exp.get('headCategory')}")
-            except Exception as e:
-                print(f"⚠️ Error in expense debug check: {e}")
-                
-        except Exception as e:
-            print(f"❌ Error checking expenses: {e}")
-            import traceback
-            traceback.print_exc()
+            for user_cond in expense_user_conditions:
+                for cat_cond in expense_category_conditions:
+                    try:
+                        if self.db.expenses.count_documents({**user_cond, **cat_cond}) > 0:
+                            return True
+                    except Exception:
+                        continue
+        except Exception:
+            pass
         
         return False