@mikonvergence

changes -

  • switched from py 3.9 to 3.11
  • added official stable support for faiss-gpu-cu12 for CUDA 12
  • switched TextSearch.py to FP32 by dropping useFloat16LookupTables, which cause cuBLAS kernel crash on L4 GPU
harshinde changed pull request status to open
Major TOM org

Thanks for looking into this, and for the PR! The Space was crashing at start-up with ImportError: libgomp.so.1: cannot open shared object file. The image was rebuilt on 30 Oct (the first rebuild in months). The conda solve then pulled a newer libgcc (15.2.0), and conda-forge now ships the OpenMP runtime (libgomp) as a separate package. faiss 1.7.4 links against libgomp but doesn't declare it, so it was no longer installed. Adding libgomp to the conda install line fixes it: I built the image locally and the app starts, finds samples and loads the text-search index.

The Space's code is deployed from GitHub (ESA-PhiLab/Major-TOM, folder apps/viewer, branch refactor/v1 for now). Every push there re-uploads the folder to the Space, so changes merged directly on the Space get overwritten. Could you send future changes as a PR to that folder on GitHub?

On the other points in this PR:

Python 3.11 and the PyPI faiss-gpu-cu12 wheel: a reasonable upgrade, but it does not seem to be necessary at the moment, so I'd rather keep it separate and test it on its own.
Dropping useFloat16LookupTables: if you saw the cuBLAS crash on the L4, please send that one-line change as a GitHub PR with the error you got. Once the Space runs again we can check whether it happens there.
I'll close this PR for now.

mikonvergence changed pull request status to closed

Sign up or log in to comment