avoigt1121 Claude Opus 5 commited on
Commit
23d37b6
Β·
2 Parent(s): d956d9124a066f

Merge: record the click-through verification and the dev-lane visibility finding

Browse files
Files changed (2) hide show
  1. TODO.md +14 -0
  2. memory.md +23 -0
TODO.md CHANGED
@@ -130,6 +130,20 @@ the design doc's M0–M4 is the intent behind it β€” see that doc's Β§0).
130
  Numbers reflect the profiled-subset denominator fix. The whole path (orchestrator β†’ this
131
  Space β†’ machine-auth gate β†’ curated artifact) is now proven in production.
132
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
133
  ## Open β€” found in the 2026-08-05 signed-in click-through
134
 
135
  First click-through since 2026-07-27, against deployed `40ab3dd`. **Every payload was correct**;
 
130
  Numbers reflect the profiled-subset denominator fix. The whole path (orchestrator β†’ this
131
  Space β†’ machine-auth gate β†’ curated artifact) is now proven in production.
132
 
133
+ ## Open β€” the dev lane cannot be click-through verified while private
134
+
135
+ - [ ] **Decide: make `pdac-genomics-agent-dev` public, or accept that UI verification happens on prod
136
+ only.** Found 2026-08-05 trying to verify the display fixes on dev. The Space **builds and runs
137
+ fine** β€” it is *reaching* the UI that fails. Private β‡’ `anne-voigt-pdac-genomics-agent-dev.hf.space`
138
+ is a **404** (the session cookie is on `huggingface.co`, not the `hf.space` origin); through the
139
+ embed the app renders but sits in a cross-origin iframe that synthetic clicks do not reach; and
140
+ the iframe's signed `__sign=` URL, promoted to top level, serves a **username/password form**
141
+ ("Could not get API info. Connection errored out."). So the dev lane currently verifies *that it
142
+ boots*, not *that it answers*. That is most of what a staging Space is for.
143
+ The 2026-08-05 fixes were verified against the merged branch **running locally** on the pinned
144
+ gradio 6.18.0 β€” sound for client-side rendering bugs, and NOT sound for anything server-shaped
145
+ (auth, secrets, artifact loading in the Space image).
146
+
147
  ## Open β€” found in the 2026-08-05 signed-in click-through
148
 
149
  First click-through since 2026-07-27, against deployed `40ab3dd`. **Every payload was correct**;
memory.md CHANGED
@@ -90,6 +90,29 @@ still wins where both make a claim β€” annotation is a fallback, not an override
90
  CCLE still reports `uncharacterized`, so its caveat is untouched; that was checked deliberately,
91
  since the caveat rests entirely on bare labels never being promoted.
92
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
93
  **Two habits earned their keep and should be kept:** re-curating with `--check` first (all seven
94
  `up_to_date`, so this was a re-derivation and not a data refresh hiding behind a code change), and
95
  reading the re-curation diff **cell by cell** instead of trusting the summary line β€” which was
 
90
  CCLE still reports `uncharacterized`, so its caveat is untouched; that was checked deliberately,
91
  since the caveat rests entirely on bare labels never being promoted.
92
 
93
+ **All three fixes verified by clicking through the merged build** (`d956d91`), 2026-08-05:
94
+ - `ccle_broad_2019` now renders the caveat in full β€” "…this cohort can never return
95
+ `fusion_in_frame`. Read an absence of in-frame fusions here as a fact about the annotation, NOT
96
+ about the biology" β€” **alongside** the Broad licence line, not instead of it.
97
+ - The chart regression is gone: NRG1-alone (single red `sv` bar, y-axis 0–0.30, `sv`-only legend)
98
+ followed immediately by the full panel now draws KRAS ~94%, TP53 ~78%, CDKN2A ~40% across all 33
99
+ genes with the full mutation/cnv/sv legend. That is the exact sequence that used to draw empty.
100
+ - `sv` renders **red** in both the narrow and wide charts β€” the colour no longer depends on how many
101
+ modalities happen to be present.
102
+ - NRG1 on `pdac_msk_2024`: `assayed: false` + its note (the ADR-0008 gate is intact), 6/2336 =
103
+ 0.257%, and all six now `fusion_in_frame` rather than bare `rearrangement`.
104
+
105
+ ⚠️ **The dev Space could NOT be used for this, and this is structural, not a one-off.** It is
106
+ **private**, so `anne-voigt-pdac-genomics-agent-dev.hf.space` returns **404** β€” the session cookie
107
+ lives on `huggingface.co`, not on the `hf.space` origin. Through the embed on the Space page the app
108
+ renders but is a cross-origin iframe, and synthetic clicks do not reach it. Promoting the iframe's
109
+ signed `__sign=` URL to top level lands on a **username/password form** with "Could not get API
110
+ info. Connection errored out." So: **while the dev Space is private, it can be built and booted but
111
+ not clicked through.** The verification above was done against the merged branch running locally on
112
+ the pinned gradio 6.18.0 β€” legitimate here because both display bugs are purely client-side, but it
113
+ is NOT a substitute for a real click-through of anything server-shaped. Make the dev Space public
114
+ (or accept prod-only click-through) before relying on the dev lane for UI verification.
115
+
116
  **Two habits earned their keep and should be kept:** re-curating with `--check` first (all seven
117
  `up_to_date`, so this was a re-derivation and not a data refresh hiding behind a code change), and
118
  reading the re-curation diff **cell by cell** instead of trusting the summary line β€” which was