fix: never disguise intake model failures as answers

src/compliment_forest/orchestrator.py

@@ -12,7 +12,6 @@ from pydantic import ValidationError
 from .backends.image import ImageBackend, resolve_style
 from .backends.music import MusicBackend, build_music_prompt
 from .backends.text import TextBackend
-from .prompts import RECOVERY_INTAKE_QUESTIONS
 from .quality import (
     content_quality_issues,
     distinct_indices,
@@ -430,38 +429,18 @@ class ForestOrchestrator:
                 ):
                     rejected_questions.append(candidate_question)
 
-        recovery = self._recovery_intake_question(history)
         self._trace(
             "intake_turn_failed",
             turn_index=len(history),
             history=history_payload,
             attempts=attempts,
             error=str(last_error) if last_error else "",
-            recovered=True,
             model=self._text_model_name(),
         )
-        self._trace(
-            "intake_turn",
-            turn_index=len(history),
-            history=history_payload,
-            output=recovery.model_dump(),
-            attempts=attempts,
-            fallback=True,
-            error=str(last_error) if last_error else "",
-            model=self._text_model_name(),
-        )
-        return recovery
-
-    @staticmethod
-    def _recovery_intake_question(history: list[IntakeTurn]) -> IntakeQuestion:
-        previous_questions = [turn.question for turn in history]
-        start = min(len(history), len(RECOVERY_INTAKE_QUESTIONS) - 1)
-        for offset in range(len(RECOVERY_INTAKE_QUESTIONS)):
-            index = (start + offset) % len(RECOVERY_INTAKE_QUESTIONS)
-            question = IntakeQuestion.model_validate(RECOVERY_INTAKE_QUESTIONS[index])
-            if not _question_repeats(question.question, previous_questions):
-                return question
-        raise ValueError("no distinct recovery intake question is available")
+        raise ValueError(
+            f"intake question could not be generated after {attempts} attempts: "
+            f"{last_error}"
+        ) from last_error
 
     def _plan(
         self,

src/compliment_forest/prompts.py

@@ -138,54 +138,6 @@ INTAKE_FOCUS_DIMENSIONS = (
     "what better or a small win would look like",
 )
 
-RECOVERY_INTAKE_QUESTIONS: tuple[dict[str, object], ...] = (
-    {
-        "question": "Which part of this feels loudest right now?",
-        "options": [
-            "What might go wrong",
-            "What other people will think",
-            "The unknown right after this",
-        ],
-        "rationale": "",
-    },
-    {
-        "question": "What feels most at stake for you here?",
-        "options": [
-            "How I see myself",
-            "How other people see me",
-            "A chance I do not want to lose",
-        ],
-        "rationale": "",
-    },
-    {
-        "question": "When does this feel hardest?",
-        "options": [
-            "When I have time alone with it",
-            "When I am around the people involved",
-            "Right before I have to act",
-        ],
-        "rationale": "",
-    },
-    {
-        "question": "What kind of support would help most right now?",
-        "options": [
-            "Someone listening without fixing it",
-            "A clearer next step",
-            "More time and room to think",
-        ],
-        "rationale": "",
-    },
-    {
-        "question": "What would a small win here look like?",
-        "options": [
-            "Just getting through it",
-            "Doing one part well",
-            "Feeling more honest about what I need",
-        ],
-        "rationale": "",
-    },
-)
-
 
 def intake_messages(
     name: str,