Extract shared post-processing into _process_completed_trace

Citation processing, trace upload, stats formatting, and trace
rendering consolidated into one function used by both chat()
and stream_question(). Eliminates ~20 lines of duplication.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

app.py

@@ -209,7 +209,39 @@ def format_stats(trace) -> str:
 
 
 # ---------------------------------------------------------------------------
-# Chat
+# Post-processing (shared between chat and stream_question)
+# ---------------------------------------------------------------------------
+
+
+def _process_completed_trace(question: str, trace, start_time: float) -> dict:
+    """Process a completed agent trace: citations, upload, render.
+
+    Returns a dict with answer, sources, stats, trace_html, and remaining.
+    """
+    trace.wall_time_s = round(time.monotonic() - start_time, 2)
+    clean_answer, sources = process_citations(trace.answer or "", WORKSPACE_DIR)
+
+    result = {
+        "question": question,
+        "source": SOURCE,
+        "passed": True,
+        "assertions": {},
+        "trace": asdict(trace),
+        "citations": sources,
+    }
+    upload_trace(result)
+
+    return {
+        "answer": clean_answer,
+        "sources": sources,
+        "stats": format_stats(trace),
+        "trace_html": render_trace(result, max_chars=2000),
+        "remaining": _daily_questions_remaining(),
+    }
+
+
+# ---------------------------------------------------------------------------
+# Chat (Gradio chatbot interface)
 # ---------------------------------------------------------------------------
 
 
@@ -280,36 +312,22 @@ def chat(message: str, scratch_path: str, session_cost: float):
         yield f"Error: {exc}", "", scratch_path, session_cost
         return
 
-    trace = agent_run.trace
-    trace.wall_time_s = round(time.monotonic() - start, 2)
-    raw_answer = trace.answer or accumulated_answer or "(no answer)"
-    clean_answer, sources = process_citations(raw_answer, WORKSPACE_DIR)
+    processed = _process_completed_trace(message, agent_run.trace, start)
 
-    if sources:
+    answer = processed["answer"]
+    if processed["sources"]:
         source_lines = "\n".join(
             f"{superscript(s['id'])} {s['doc']}: \"{s['quote']}\""
-            for s in sources
+            for s in processed["sources"]
         )
-        clean_answer += f"\n\n---\n{source_lines}"
+        answer += f"\n\n---\n{source_lines}"
 
-    stats = format_stats(trace)
-    result = {
-        "question": message,
-        "source": SOURCE,
-        "passed": True,
-        "assertions": {},
-        "trace": asdict(trace),
-        "citations": sources,
-    }
-    upload_trace(result)
-    trace_html = render_trace(result, max_chars=2000)
-
-    remaining = _daily_questions_remaining()
-    remaining_msg = f"\n\n---\n*{stats}*\n\n*{remaining} question{'s' if remaining != 1 else ''} remaining today*"
+    remaining = processed["remaining"]
+    answer += f"\n\n---\n*{processed['stats']}*\n\n*{remaining} question{'s' if remaining != 1 else ''} remaining today*"
 
     yield (
-        f"{clean_answer}{remaining_msg}",
-        trace_html,
+        answer,
+        processed["trace_html"],
         scratch_path,
         session_cost,
     )
@@ -661,29 +679,15 @@ def stream_question(question: str) -> Generator[str, None, None]:
         yield json.dumps({"type": "error", "error": "An error occurred during processing."})
         return
 
-    trace = agent_run.trace
-    trace.wall_time_s = round(time.monotonic() - start, 2)
-
-    clean_answer, sources = process_citations(trace.answer or "", WORKSPACE_DIR)
-
-    result = {
-        "question": question,
-        "source": SOURCE,
-        "passed": True,
-        "assertions": {},
-        "trace": asdict(trace),
-        "citations": sources,
-    }
-    upload_trace(result)
-    trace_html = render_trace(result, max_chars=2000)
+    processed = _process_completed_trace(question, agent_run.trace, start)
 
     yield json.dumps({
         "type": "done",
-        "answer": clean_answer,
-        "sources": sources,
-        "stats": format_stats(trace),
-        "trace_html": trace_html,
-        "remaining": _daily_questions_remaining(),
+        "answer": processed["answer"],
+        "sources": processed["sources"],
+        "stats": processed["stats"],
+        "trace_html": processed["trace_html"],
+        "remaining": processed["remaining"],
     })