| edge_kind,source_item_type,source_number,target_item_type,target_number,confidence,evidence_source,evidence_excerpt,evidence_url,evidence_hash
|
| references,issue,13419,pr,13398,medium,issue.body,Fix is to tokenise the inter-keyword whitespace with disjoint classes so a space only ever belongs to a separator and never to a token. PR #13398.,https:
|
| references,issue,13357,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [x] The api is not in a module listed in [#6810](https:
|
| references,issue,13227,issue,12168,medium,issue.body,dation introduced in commit [95ad9fe](https:
|
| references,issue,13212,issue,4384,medium,issue.comments[5].body,it's #4384,https:
|
| competes with,issue,13210,issue,13193,medium,issue.body,"namespace."") > print("" Use ap.meta (base-class direct) instead of ap.Dog.meta."") > print(""="" * 70) > ``` _Originally posted by @CaselIT in [#13193](https://github.com/sqlalchemy/sqlalchemy/issues/13193#issuecomment-4145377493)_",https:
|
| references,issue,13204,issue,13193,medium,issue.body,There are a couple of cases where immediateload fails when using inheritance on relationships: - loading using immediateload a relationship on an inheritance chain that's being loaded via eager loading: `select(Meta).option(anyloader(Meta.parent_cls).immediateload(ParentCls.re...,https://github.com/sqlalchemy/sqlalchemy/issues/13204,d6af10a01c4ee0b2ddd96c96d6dd926659a632a831f4840c75ab65e66fc64d2e
|
| references,issue,13204,issue,13202,medium,issue.body,There are a couple of cases where immediateload fails when using inheritance on relationships: - loading using immediateload a relationship on an inheritance chain that's being loaded via eager loading: `select(Meta).option(anyloader(Meta.parent_cls).immediateload(ParentCls.re...,https:
|
| references,issue,13157,pr,13188,medium,issue.comments[8].body,Fix submitted in #13188.,https:
|
| references,issue,13007,issue,13006,medium,issue.body,Follow up of #13006 Set to False the default value and remove the warning,https:
|
| references,issue,12398,issue,10668,medium,issue.body,### Describe the use case I just received the following error of in my project and have an improvement request similar to #10668 : ``` sqlalchemy.exc.InvalidRequestError: Loader strategies for ORM Path[Mapper[Cable(cable)] -> Cable.cablesides -> Mapper[CadCableSide(ca,https://github.com/sqlalchemy/sqlalchemy/issues/12398,07ceea06d0f1bb244249ac24902ba1dd7392e1e6bc595e75652f640133c4aefd
|
| references,issue,12101,issue,5583,medium,issue.body,### Describe the use case The [Postgres docs](https://www.postgresql.org/docs/17/sql-select.html) specifically say that you should be able to have both a FOR UPDATE and a FOR SHARE in the same query: > Multiple locking clauses can be written if it is necessary to specify diffe...,https://github.com/sqlalchemy/sqlalchemy/issues/12101,bf6e8cce81a4e4ad031c254f2be259769d213b550fd5865ff2541cf9300ffea9
|
| references,issue,12101,issue,5583,medium,issue.comments[0].body,"eems like contains_eager() + join() is more appropriate here. 3. you're asking something about the very open ended warnings/error ticket in #5583 , I guess saying that the warning we have about FOR UPDATE doesnt apply to joinedload() if one is using ""of"". I'm not really sure i...",https://github.com/sqlalchemy/sqlalchemy/issues/12101,17c075eae174372b9d516a0535f376d64013cfe63319a93676e646945ce4e8d2
|
| references,issue,12097,issue,6515,medium,issue.body,### Describe the bug I can't use an enum type as part of a `case()` without casting. Looks very similar to https://github.com/sqlalchemy/sqlalchemy/issues/6515 ### Optional link from https://docs.sqlalchemy.org which documents the behavior that is expected _No response_ ### SQ...,https://github.com/sqlalchemy/sqlalchemy/issues/12097,d6e79d43b2f87411acce577b2cf3ca68a1757872a452446adf58cfc92d854ce0
|
| references,issue,11686,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https:
|
| references,issue,11677,pr,11678,medium,issue.comments[1].body,I openend a PR to fix this issue https:
|
| references,issue,11620,pr,12297,medium,issue.comments[6].body,"I've posted an alternative strategy that I'd like to use, detailed on the gerrit and also on the PR at https://github.com/sqlalchemy/sqlalchemy/pull/12297#issuecomment-2733436569",https:
|
| references,issue,10936,issue,1063,medium,issue.comments[0].body,"I thought this was related to #1063 but i dont think it is, unfortunately, meaning we have *two* post_update quagmire kinds of issues.",https:
|
| references,issue,10888,issue,6810,medium,issue.comments[1].body,checked it off from this list https:
|
| references,issue,10859,issue,4641,medium,issue.body,"this can come in alongside #4641 this would make a change to `relationship` such that it does not set up `strategy_key` until mapper config stage, where it gets a look at i",https:
|
| references,issue,10675,issue,8626,medium,issue.comments[0].body,ted SQL is valid; migrating the from_select case off the deprecated form (e.g. via the documented derived-table alias) seems to belong with #8626. Perhaps this one can be closed as fixed?,https:
|
| references,issue,10544,pr,10545,medium,issue.comments[0].body,try this pr to fix https:
|
| references,issue,10527,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue Seems that `wi...,https:
|
| references,issue,10351,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue Return type `c...,https:
|
| references,issue,10351,issue,6120,medium,issue.comments[7].body,"> though column_property() does not accept calalbles or lambdas, so still need to reduce that there was an issue for it in https://github.com/sqlalchemy/sqlalchemy/issues/6120",https:
|
| references,issue,10094,issue,5811,medium,issue.comments[0].body,"I've been missing a documentation regarding testing with async, I eventually got it to what I wanted but I don't entirely understand how it works. I've read through [this discussion](https://github.com/sqlalchemy/sqlalchemy/issues/5811) and arrived at this slightly shorter ver...",https:
|
| references,issue,9839,issue,9603,medium,issue.body,### Describe the bug We upgraded our sql alchemy version and observed a massive spike in execution time on the database. We are bulk uploading several 100k rows. We are using sql server on azure and pyodbc. We believe it relates to changes made in https:
|
| references,issue,9839,issue,9618,medium,issue.body,### Describe the bug We upgraded our sql alchemy version and observed a massive spike in execution time on the database. We are bulk uploading several 100k rows. We are using sql server on azure and pyodbc. We believe it relates to changes made in https:
|
| references,issue,9839,issue,9603,medium,issue.comments[0].body,he database. We are bulk uploading several 100k rows. We are using sql server on azure and pyodbc. We believe it relates to changes made in #9603 <https:
|
| references,issue,9839,issue,9618,medium,issue.comments[0].body,"ng sql server on azure and pyodbc. We believe it relates to changes made in #9603 <https://github.com/sqlalchemy/sqlalchemy/issues/9603> or #9618 <https://github.com/sqlalchemy/sqlalchemy/issues/9618> which were implemented in 2.0.10. We are no using the ORM, but execute direc...",https:
|
| references,issue,9839,issue,9586,medium,issue.comments[4].body,"faster than plain executemany, but still order of magnitude worse than fast executemany** performance. We can see this using the test from #9586, using the dataset at https://github.com/sqlalchemy/sqlalchemy/files/11130278/test_data.zip and the script below, which I've improve...",https:
|
| references,issue,9839,issue,9603,medium,issue.comments[4].body,"0 rows in 0.1 seconds (17273.9 rows/s). SQLA: 2.0.15; imv=False; fast_em=True: Finished in 2.4 seconds. ``` When using 2.0.9 exactly, issue #9603 was released which **universally disabled insertmanyvalues** for SQL Server. Based on everything we know, **this means default perf...",https:
|
| references,issue,9839,issue,9603,medium,issue.comments[8].body,"nsertmanyvalues"" completely in version 2.0.9 of SQL Server alone. it was turned on in 2.0.8 as well as 2.0.10. the 2.0.9 shutoff was due to #9603. im not really sure how if cloud DBs have expensive round trips that plain executemany() is better, there must be some driver level...",https:
|
| references,issue,9690,issue,8285,medium,issue.comments[14].body,"for the column slice thing, super huge omission from #8285. needs an extra isinstance",https:
|
| references,issue,9587,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Confirm this is not Mypy dataclasses iss...,https://github.com/sqlalchemy/sqlalchemy/issues/9587,8f0ab012bcaefbb9dcc8fde82aebd9ec9c8df0924510f8c708fbb24da29daaf5
|
| references,issue,9493,issue,9350,medium,issue.body,"We also seem to make inherit dataclasses attributes, while we probably should not. Not sure if it's connected to this other issue #9350 ```py from dataclasses import dataclass import sqlalchemy as sa import sqlalchemy.orm as sao import inspect class Base(sao.MappedAsDataclas",https:
|
| references,issue,9493,issue,9410,medium,issue.body,"We also seem to make inherit dataclasses attributes, while we probably should not. Not sure if it's connected to this other issue #9350 ```py from dataclasses import dataclass import sqlalchemy as sa import sqlalchemy.orm as sao import inspect class Base(sao.MappedAsDataclass,...",https:
|
| references,issue,9410,issue,9563,medium,issue.body,"nit generated. this all comes from dataclasses, but it may be worth reiterate that 4. mention that all the dataclass limitations apply. see #9563 also 5. #9785 , back_populates / recursion issue 6. when using mixins, it is likely a good idea to use kw_only on those fields so t...",https:
|
| references,issue,9410,issue,9785,medium,issue.body,"this all comes from dataclasses, but it may be worth reiterate that 4. mention that all the dataclass limitations apply. see #9563 also 5. #9785 , back_populates / recursion issue 6. when using mixins, it is likely a good idea to use kw_only on those fields so that they are no...",https:
|
| references,issue,9410,issue,12168,medium,issue.body,"1. relationship = None issue : #9383 , #9856 - issue created: https://github.com/sqlalchemy/sqlalchemy/issues/12168 2. declared_attr on a mixin w/ dataclasses: #9408 3. order matters regarding the default value and init generated. this all comes from dataclasses, but it may be...",https:
|
| references,issue,9410,issue,9350,medium,issue.comments[3].body,"We also seem to make inherit dataclasses attributes, while we probably should not. Not sure if it's connected to this other issue #9350 ```py from dataclasses import dataclass import sqlalchemy as sa import sqlalchemy.orm as sao import inspect class Base(sao.MappedAsDataclas",https:
|
| references,issue,9410,issue,9785,medium,issue.comments[8].body,Maybe also: - #9785,https:
|
| references,issue,9410,issue,9785,medium,issue.comments[9].body,> Maybe also: > > * [Using back_populates with MappedAsDataclass and asdict causing RecursionError #9785](https:
|
| references,issue,9410,issue,9785,medium,issue.comments[11].body,> Maybe also: > > * [Using back_populates with MappedAsDataclass and asdict causing RecursionError #9785](https:
|
| references,issue,9410,issue,9927,medium,issue.comments[13].body,#9927 I encountered this one. I am trying to use dataclass-only fields for some state things (i.e not mapped). The state variable should always b,https:
|
| references,issue,9410,issue,9927,medium,issue.comments[14].body,> #9927 > > I encountered this one. I am trying to use dataclass-only fields for some state things (i.e not mapped). The state variable should alwa,https:
|
| references,issue,9410,issue,9930,medium,issue.comments[14].body,"> #9927 > > I encountered this one. I am trying to use dataclass-only fields for some state things (i.e not mapped). The state variable should always be created on object creation using the `default_factory` option. This works when creating the object and persisting, but if yo...",https:
|
| references,issue,9301,issue,6120,medium,issue.comments[4].body,I guess https:
|
| references,issue,9301,issue,6120,medium,issue.comments[5].body,"OK, column_property() is not mapped_column(), yeah I think let's document for now. i dont know what will happen with #6120 , added some notes there.",https:
|
| references,issue,9212,issue,9213,medium,issue.comments[1].body,"in the narrative docs at https://docs.sqlalchemy.org/en/20/orm/declarative_mixins.html . it just needs the `@classmethod` part discussed at #9213. I think we have actionable items on #9213 but for this one i dont see the action to take, other than maybe some more supplementary...",https:
|
| references,issue,9212,issue,9213,medium,issue.comments[3].body,"in the narrative docs at https://docs.sqlalchemy.org/en/20/orm/declarative_mixins.html . it just needs the `@classmethod` part discussed at #9213. Yes, retrying with those changes, I've got it working. It's still not clear to me what generic type I should be using for an annot...",https:
|
| references,issue,9154,issue,8762,medium,issue.comments[2].body,"r pypy? at some point we had to take pypy out of the testing pipeline Yes. I have two marked as failing in 1.4.46. One of them is linked to #8762, so might have been fixed already. The other was an exception message mismatch that I probably didn't report. Unfortunately, the te...",https:
|
| references,issue,9147,issue,9832,medium,issue.body,"the event hook here: https://github.com/sqlalchemy/sqlalchemy/blob/689ebc30dcd6b9cedf01d729f748b31826720b5c/lib/sqlalchemy/orm/decl_base.py#L567-L582 that's making a global event against Mapper. Declarative should make at most just *one* event hook against Mapper, then use its...",https:
|
| references,issue,9147,issue,9832,medium,issue.comments[0].body,not sure we really need this but in any case depends on #9832,https:
|
| references,issue,9082,issue,8889,medium,issue.comments[0].body,"""auto"" was added in #8889. i see this issue refers to ""auto"". nobody anywhere is going to put ""eager_defaults=False"" so this is a really non-impactful issue",https:
|
| references,issue,8992,issue,8989,medium,issue.body,"discovered during #8989, this is simply not implemented at all and the bind expression is ignored when it's an element of a tuple. Also, the impl of a TupleType()",https:
|
| references,issue,8431,issue,4340,medium,issue.body,"in #4340 21fbb5e38f04affb8ac4502428672b3a629c we implemented ""omit_join"" behavior for the selectinload loader strategy. We currently don't have this",https:
|
| references,issue,7718,issue,4379,medium,issue.body,scussed in https:
|
| references,issue,7475,issue,8574,medium,issue.comments[1].body,isables the key generation. > > I guess support for this could also be something could be added while updating this issue this was fixed in #8574,https:
|
| references,issue,7366,issue,3861,medium,issue.body,### Describe the bug I'm getting duplicated index objects in the `MetaData` when using `DeferredReflection`. I think a similar issue might've been fixed in https:
|
| references,issue,7366,issue,8925,medium,issue.comments[8].body,"what this issue is about, this issue is about constraints which are a totally different story. the extend_existing not deduping on name is #8925.",https:
|
| references,issue,7223,issue,7212,medium,issue.body,"Interval is an emulated type, that also subclasses `TypeDecorator`: https://github.com/sqlalchemy/sqlalchemy/blob/7f8bf038b753d3f250e0e974102c16037d1aea5d/lib/sqlalchemy/sql/sqltypes.py#L2026 This is different from the other emulated types, like Boolean and Enum, so for v2 it...",https:
|
| references,issue,7113,issue,4797,medium,issue.body,"i mean also, ""with_hint()"" is badly named. ""with_table_criteria()"" is a better name _Originally posted by @zzzeek in https://github.com/sqlalchemy/sqlalchemy/issues/4797#issuecomment-930432024_ perhaps we can generalize with_hint() into with_table_criteria() and then introduce...",https:
|
| references,issue,7113,issue,4797,medium,issue.comments[1].body,"""hints"" like indexing hints. other kinds of per-table constructs are placed differently, such as the for_system_time() we are looking at in #4797. So where with_hint() sends these three indicators of intent: * subject table * text that is to be treated like an indexing hint or...",https:
|
| references,issue,7113,issue,6040,medium,issue.comments[1].body,"this is related to #6040 as well and this could supersede it (that is, we wouldnt' have to do #6040 as written, with_hint would stay the same). i dont necessarily w",https:
|
| references,issue,7035,pr,7009,medium,issue.comments[0].body,Follow up from the discussion is https:
|
| references,issue,6997,issue,6550,medium,issue.comments[3].body,"yeah it's #6550 and the line that makes this test case ""work"" is to reintroduce a clear bug: ```py diff --git a/lib/sqlalchemy/sql/elements.py b/lib/sqlalc",https:
|
| references,issue,6810,issue,7519,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https:
|
| references,issue,6810,issue,7535,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https:
|
| references,issue,6810,issue,7555,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https:
|
| references,issue,6810,issue,7562,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https:
|
| references,issue,6810,issue,7774,medium,issue.comments[16].body,"ensure assocaition proxy collection implement typing.List/Set/Dict, see #7774",https:
|
| references,issue,6810,pr,12384,medium,issue.comments[39].body,"I started to work on the `postgresql` dialect, first PR https://github.com/sqlalchemy/sqlalchemy/pull/12384 about the `array` module.",https:
|
| references,issue,6810,pr,12707,medium,issue.comments[42].body,"Hi @CaselIT, When you have a moment, could you please review my [PR for `sqlalchemy.sql.base`](https://github.com/sqlalchemy/sqlalchemy/pull/12707)? Once it's acknowledged, I’d like to plan follow-up typing contributions for another untyped module( [`sqlalchemy.sql.crud`](http...",https:
|
| references,issue,6810,pr,12759,medium,issue.comments[49].body,"Hi @zzzeek, @CaselIT Sorry to interrupt, but I’ve run into a typing-related question while working on the compiler module. I’ve opened a **temporary PR** to explain the issue and provide context: **Temp PR:** https://github.com/sqlalchemy/sqlalchemy/pull/12759 Would appreciate...",https:
|
| references,issue,6612,issue,5256,medium,issue.comments[0].body,"Hi, I remembered asking a similar question. Here it is: https://github.com/sqlalchemy/sqlalchemy/issues/5256 tldr: you can use `.self_group()`",https:
|
| references,issue,6612,issue,3566,medium,issue.comments[1].body,"nks, I did not find the existing issue via search, but maybe my search terms were inadequate. Since your issue was closed to be tracked in, #3566, which in turn is marked resolved, should we keep one open as use case? Other than that, feel free to close.",https:
|
| references,issue,6612,issue,3566,medium,issue.comments[2].body,"s, I did not find the existing issue via search, but maybe my search terms were inadequate. > Since your issue was closed to be tracked in, #3566, which in turn is marked resolved, should we keep one open as use case? Other than that, feel free to close. Don't worry, searching...",https:
|
| references,issue,6612,issue,3566,medium,issue.comments[3].body,in #3566 it wasn't that clear to me what was going on but in this case I'd want to see if row valued types can signal to the compiler and/or express,https:
|
| references,issue,6612,issue,5256,medium,issue.comments[4].body,this is an example: https:
|
| references,issue,6511,pr,12510,medium,issue.comments[4].body,"In https://github.com/sqlalchemy/sqlalchemy/pull/12510, I am proposing to an implementation for PostgreSQL. On SQLite, AFAICT, this does not seem possible as the `table_info` or `table_xinfo` pragmas apparently do not return the collation information. (On other backends, I don...",https:
|
| references,issue,6489,issue,3357,medium,issue.body,"as discussed at #3357, an additional execution option `dbapi_autocommit=True` that sets autocommit independently of setting an explicit isolation level would be",https:
|
| references,issue,6120,issue,3050,medium,issue.comments[0].body,"I originally wanted to do this in #3050, which got marked as a dupe of #3150, which allowed column_property to work with declared_attr, however, never added the lambda part of it.",https:
|
| references,issue,6120,issue,3150,medium,issue.comments[0].body,"I originally wanted to do this in #3050, which got marked as a dupe of #3150, which allowed column_property to work with declared_attr, however, never added the lambda part of it. there was some reason that using lam",https:
|
| references,issue,5583,issue,5578,medium,issue.body,"From Mike: this is not a v2 thing, this is all a right now thing. 1. all backends should be raising an error when a user behavioral intent that cannot be fulfilled is received by a dialect, so first off, the for_update_clause() in compiler.py should be looking at all of these...",https:
|
| references,issue,5352,issue,4250,medium,issue.body,` operator is supported in SQLAlchemy. So the statement `SELECT ~a.flag AS anon_1 FROM a` works and gives correct results. I've come across #4250 which seems related. ```py from sqlalchemy import * from sqlalchemy.orm import * from sqlalchemy.ext.declarative import declarative...,https:
|
| references,issue,5352,issue,4250,medium,issue.comments[0].body,hi there - how interesting that the exact test case from #4250 is still failing though I would assume in a different way from what was fixed there. this limitation has more to do with SQL Server not bei,https:
|
| references,issue,5350,issue,3989,medium,issue.body,"I've read https://github.com/sqlalchemy/sqlalchemy/issues/3989 but this seems unrelated. When defining a `ForeignKey` on a SQLAlchemy model, if the referenced column is given as a string (`{table_name}.{column_name}`) and the `Base.metadata` has been setup with a naming conven...",https:
|
| references,issue,5350,issue,7706,medium,issue.comments[4].body,"the `ForeignKeyConstraint` separately via `__table_args__` works like a charm. I'd note that, when I saw this, I though that it could solve #7706. But, I still get `NoReferencedTableError`, so I assume there is in fact no way to use `referred_column`, unless you construct all...",https:
|
| references,issue,5123,issue,3692,medium,issue.body,"I have a `Session` model with a `hash` column of the `Binary` type, and a `User` model with a relationship of `sessions`. If I get attributes through `inspect(user).attrs`, calling `attr.load_history()` on the `sessions` attribute will cause this [string argument without an en...",https:
|
| references,issue,5005,issue,5068,medium,issue.comments[10].body,"suspect #5068 is seeing the same thing, although in that issue the warning call is being emitted incorrectly as this warning has failed to be part of tes",https:
|
| references,issue,4790,issue,4784,medium,issue.body,There are a handful of messages that could be improved. 1. `sqlalchemy.exc.InvalidRequestError: Naming convention including %(constraint_name)s token requires that constraint is explicitly named.` This doesn't give much of a context. Suggestion for improvement: Extend message...,https:
|
| references,issue,4790,issue,4784,medium,issue.comments[4].body,"ok, here we go again... > for 2, when does it raise that error? This was an edge-case you discovered in this comment- https://github.com/sqlalchemy/sqlalchemy/issues/4784#issuecomment-516582228 > I don't understand the extra context you are adding in 1. wouldn't they want to k...",https:
|
| closes,issue,4790,issue,4784,high,issue.comments[6].body,**jonathan vanasco** has proposed a fix for this issue in the **master** branch: **Fixes #4784 regarding constraints:** https:
|
| references,issue,4784,issue,5151,medium,issue.comments[22].body,Note: perhaps use the enum listener example in #5151,https:
|
| references,issue,4652,issue,3155,medium,issue.body,"for [Column](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. The only solution I have come to so far was s...",https:
|
| references,issue,4652,issue,3444,medium,issue.body,"olumn](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. The only solution I have come to so far was specifi...",https:
|
| references,issue,4652,issue,3155,medium,issue.comments[0].body,"for [Column](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. > > The only solution I have come to so far w...",https:
|
| references,issue,4652,issue,3444,medium,issue.comments[0].body,"olumn](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. > > The only solution I have come to so far was spe...",https:
|
| references,issue,4641,issue,4640,medium,issue.body,with #4640 we are going to start adding mapper flags that folks will want to be able to apply across the board. so to make this easier without the nee,https:
|
| references,issue,4567,issue,4360,medium,issue.body,"to be ignored on the table slippy_tiles but nothing seems to take when creating the schema from ORM, even though it is supposedly fixed in #4360 I've tried renaming the kwarg in the column definitions to sqlite_on_conflict_primary_key, sqlite_on_conflict, on_conflict, editing...",https:
|
| references,issue,4289,issue,3989,medium,issue.comments[23].body,**Michael Bayer ([@zzzeek](https:
|
| references,issue,1063,issue,3990,medium,issue.comments[0].body,**Michael Bayer ([@zzzeek](https:
|
| references,issue,1063,issue,3496,medium,issue.comments[2].body,"**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** as tihs would also fix #3496 I'm motivated to work on this, but I'm struggling. https://gerrit.sqlalchemy.org/427",https:
|
| references,issue,12730,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [x] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue When passing m...,https://github.com/sqlalchemy/sqlalchemy/issues/12730,3842d0eec177fae874259fa4e9ea3e33a879e328b11d034e013224deadda18ad
|
| references,issue,9618,issue,9603,medium,issue.body,"ne in https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4548. Among other things this will be a real solution to the problem faced at #9603 and will also be a hedge against any other database where we can't guarantee INSERT ordering. for use_insertmanyvalues, it then bec...",https://github.com/sqlalchemy/sqlalchemy/issues/9618,275bc98ada6d49989345e61ebf9f2d01d61290bb1a826bbaaad6ec6f9492c7ec
|
| references,issue,9618,issue,9603,medium,issue.comments[7].body,"ning(table)"", something like that 4. limit the use of insertmanyvalues **just in the unit of work**. after all that was the issue we had in #9603",https://github.com/sqlalchemy/sqlalchemy/issues/9618,09c040e81bdeaca0358effa59681e4df6040d3c0b8da7be8a8736504a8ccbb45
|
| references,issue,9618,issue,9603,medium,issue.comments[20].body,"y, meaning if that order is off, any situation where those objects have further collections on them we'd be seeing the issue like we see in #9603. That's tens of millions of downloads per month where we would assume applications have tolerated concurrent VACUUMs and things lik...",https://github.com/sqlalchemy/sqlalchemy/issues/9618,b283236773c64ef1bd5167c56f142f85e7a8327de35e52c6b99be54049ade30d
|
| references,issue,9603,issue,9618,medium,issue.comments[65].body,"doing a lot of thinking over at #9618. I think we can definitely restore MS-SQLs ""insertmanyvalues"" feature as long as we dont use it in the unit of work to match up primary key",https://github.com/sqlalchemy/sqlalchemy/issues/9603,8f2b5ac1afb6546a0cb8a56a1face423d713f2570269c2c95a9e327b810240ba
|
| references,issue,9563,issue,9410,medium,issue.comments[7].body,"s or similar dataclass limitations gets reported, so maybe people are not that familiar with them? In any case i've mentioned this issue in #9410 regarding re-raise we can decide later, since it's easy to add, not that easy to remove",https://github.com/sqlalchemy/sqlalchemy/issues/9563,a87dfd77e9c7ebeb1cbccc83ff4fdbf9ea394e9b70f9e682effbc302a3ff2f44
|
| references,issue,7774,issue,6810,medium,issue.comments[0].body,"otation to an association proxy in all cases. whether or not associationproxy accommodates `Mapped[]` right now will be resolved as part of #6810, you can use a cast() in the interim: ```py from sqlalchemy.orm import Mapped class Parent(Base): __tablename__ = ""parent"" id = Col...",https:
|
| references,issue,7774,issue,6810,medium,issue.comments[3].body,erialization. Here you're looking for AssocaitionList/set/dict to implement the appropriate typing collection. This will be done as part of #6810 in 2.0.,https:
|
| references,issue,7774,issue,6810,medium,issue.comments[5].body,"Hey, i'm not if this is the correct ticket to place this, so please tell me if not. According to https://github.com/sqlalchemy/sqlalchemy/issues/6810, the association_proxy (so probably also the AssociationList) is already fully typed. But in this case, shouldn't `tags` be suc...",https:
|
| references,issue,7706,issue,5350,medium,issue.comments[0].body,"Ah sorry, I guess this may be a duplicate of #5350",https:
|
| references,issue,7659,pr,8136,medium,issue.comments[18].body,"Alright, started a draft PR here for discussion https://github.com/sqlalchemy/sqlalchemy/pull/8136",https:
|
| references,issue,5578,issue,5583,medium,issue.comments[16].body,Thanks for the great explanation mike. I've taken the liberty of creating a new issue to track this. See https:
|
| references,issue,5256,issue,3566,medium,issue.comments[0].body,"-comparison.html after the tip note. just FYI there's a ton of PG stuff that we don't have built in right now that are along this line, see #3566 . if you want to work on this stuff it's definitely leveling up but 1.4 should be getting very good at this stuff by now :) > > Als...",https:
|
| references,issue,5256,issue,3566,medium,issue.comments[2].body,"I want to ultiamtely do everything here and in #3566. this comes up all the time. it's just if it is done quickly without consdiering PG's syntactical concepts in total, we can paint ourselves",https:
|
| references,issue,5256,issue,3566,medium,issue.comments[3].body,"Added a comment in #3566. This can be closed, so we can track all the missing pg behaviors from a single place",https:
|
| references,issue,5068,issue,5005,medium,issue.comments[4].body,"hen UPDATE if ""supports_sane_rowcount"" is set to **True** Hi can you define ""failed"" please? Are you getting the same error as described in #5005 ? > In fact, it is common to disable ""supports_sane_rowcount"" as a workaround for `pyodbc` and `Microsoft ODBC Driver` does not sup...",https:
|
| references,issue,4797,issue,6040,medium,issue.comments[16].body,"ere, which would be pretty weird. The ""hint text"" should be possible that it is a compiled object, not just a string and that is missing os #6040 is added.",https:
|
| references,issue,3990,issue,1063,medium,issue.comments[0].body,**Michael Bayer ([@zzzeek](https:
|
| references,issue,3990,issue,1063,medium,issue.comments[1].body,wrote:** post_update is currently required for any mutually-dependent FKs relationship. having it not be necessary for UPDATE only is what #1063 addresses.,https:
|
| references,issue,3989,issue,4289,medium,issue.comments[6].body,"**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** we *do* truncate specifically for indexes, see #4289.",https:
|
| references,issue,3566,issue,5256,medium,issue.comments[38].body,"where at least a column is not null, while `some_table is not null` returns all the rows where all columns are not null. Consolidating from #5256",https:
|
| references,issue,3496,issue,1063,medium,issue.comments[13].body,"OK, that's a lot of code and a lot of repetition. Why do we need to emit post_update when this is only an UPDATE? This should be a dupe of #1063 which would solve the whole problem.",https:
|
| references,issue,3496,issue,1063,medium,issue.comments[14].body,**Michael Bayer ([@zzzeek](https:
|
| references,issue,3444,issue,3155,medium,issue.body,"**Migrated issue, originally created by Charles-Axel Dein ([@charlax](https://github.com/charlax))** This seems similar to #3155 and #2631. I have this simple script to reproduce the problem: ``` from sqlalchemy import create_engine from sqlalchemy import func from sq",https:
|
| references,issue,3444,issue,3155,medium,issue.comments[4].body,"asically getting a model with database-level `created_at` and `updated_at` behavior requires some shenanigans that you recommend against in #3155. Sadly, wasn't able to find another way to achieve this. ``` from sqlalchemy import create_engine from sqlalchemy import func, text...",https:
|
| references,issue,3150,issue,3050,medium,issue.body,"issue, originally created by Michael Bayer ([@zzzeek](https://github.com/zzzeek))** poc should allow us to consolidate #2670, #2952, #3149, #3050. the new descriptors include the ability to cache the result per class, or to do ""cascade"", guarantees that the callable fn is call...",https:
|
| references,issue,3150,issue,3050,medium,issue.comments[0].body,**Michael Bayer ([@zzzeek](https:
|
| references,issue,3050,issue,3150,medium,issue.comments[3].body,**Michael Bayer ([@zzzeek](https:
|
| closes,pr,13421,issue,13420,high,pr.closingIssuesReferences,pr #13421 declares a closing reference to issue #13420.,https:
|
| closes,pr,13421,issue,13420,high,pr.body,"db's AsyncCursor in version 2.0.1, the async dialect's minimum supported oracledb version is raised from 2.0.0 to 2.0.1 accordingly. Fixes: #13420 <!-- Provide a general summary of your proposed changes in the Title field above --> ### Description <!-- Describe your changes in...",https:
|
| review guidance,pr,13421,issue,13420,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision 20582e2eaf1cdf9cd8af94ecf216f5d5d9fb3d62 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,13421,issue,13420,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision 20582e2eaf1cdf9cd8af94ecf216f5d5d9fb3d62 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| closes,pr,13418,issue,9693,high,pr.closingIssuesReferences,pr #13418 declares a closing reference to issue #9693.,https:
|
| closes,pr,13418,issue,9693,high,pr.body,"### Description Fixes #9693. String type collation rendering currently hardcodes quoted collation names, so a PostgreSQL schema-qualified collation such as `schema.col",https:
|
| follows smaller direction from,pr,13418,pr,12697,high,pr.body,"and allowing `quoted_name(""schema.collation"", quote=False)` for qualified names. This follows the smaller direction discussed in #9693 and #12697 rather than adding a new `collation_schema` attribute or reflection machinery. ### Tests - `python -m pytest test/sql/test_types.py...",https:
|
| review guidance,pr,13417,pr,13417,high,pr.reviews[0].body,"Sprinkling `Any` to bypass complex signatures is essentially disabling static analysis for this path. If we are going to type this, let's design proper generics/protocols instead of resorting to type erasure.",https:
|
| review guidance,pr,13417,pr,13417,high,pr.reviews[1].body,"Sprinkling `Any` to bypass complex signatures is essentially disabling static analysis for this path. If we are going to type this, let's design proper generics/protocols instead of resorting to type erasure.",https:
|
| review guidance,pr,13416,pr,13416,high,pr.reviews[0].body,"**1. `_sa_trivial` bypass via `functools.wraps`** The `getattr(appender, ""_sa_trivial"", None)` check is fooled if a custom override uses `@functools.wraps(InstrumentedList.append)`: wraps copies the wrapped function's `__dict__`, leaking both `_sa_instrumented` and `_sa_trivial` into the subclass...",https:
|
| review guidance,pr,13416,pr,13416,high,pr.reviews[1].body,"**1. `_sa_trivial` bypass via `functools.wraps`** The `getattr(appender, ""_sa_trivial"", None)` check is fooled if a custom override uses `@functools.wraps(InstrumentedList.append)`: wraps copies the wrapped function's `__dict__`, leaking both `_sa_instrumented` and `_sa_trivial` into the subclass...",https:
|
| closes,pr,13405,issue,13407,high,pr.closingIssuesReferences,pr #13405 declares a closing reference to issue #13407.,https:
|
| closes,pr,13405,issue,13407,high,pr.body,"(it wins uncompiled too); `-O3` compilation adds a smaller further gain (~2–6%), to weigh against the cost of a new compiled module. Fixes: #13407 ## Benchmarks `min` ms, vs `main`. Python 3.14, in-memory SQLite, 50 repeats, extension compiled at `-O3`. | case | before | after...",https:
|
| closes,pr,13405,issue,13407,high,pr.comments[0].body,"Thanks for looking into this. I've created an issue, it's #13407",https:
|
| closes,pr,13404,issue,13406,high,pr.closingIssuesReferences,pr #13404 declares a closing reference to issue #13406.,https:
|
| closes,pr,13404,issue,13406,high,pr.body,")` semantics; the requires_uniquing fallback covers nested-eager cases. `test_subquery_relations` and `test_recursive_loaders` pass. Fixes: #13406 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once th...",https:
|
| closes,pr,13404,issue,13406,high,pr.comments[0].body,"Hey @ollz272 thanks for continuing work on this! I've created #13406 from the discussion, so we have something to add to the fixes etc. > Still having trouble with gerrit.. sorry! no problem, feel free to kee",https:
|
| closes,pr,13402,issue,10748,high,pr.closingIssuesReferences,pr #13402 declares a closing reference to issue #10748.,https:
|
| closes,pr,13402,issue,10748,high,pr.body,gistration assertion for conflicting registrars - add regression coverage for module reload style registration and a changelog entry Closes #10748. ### Validation - `/tmp/sqlalchemy-pr-venv/bin/python -m pytest test/base/test_inspect.py -q` - `/tmp/sqlalchemy-pr-venv/bin/pytho...,https://github.com/sqlalchemy/sqlalchemy/pull/13402,c150169126683f2b1a5088f586356dac00a154712c353f36519b216309168dfa
|
| closes,pr,13402,issue,10748,high,pr.review_comments[0].body,let's add a comment similar to the shared by mike here https://github.com/sqlalchemy/sqlalchemy/issues/10748#issuecomment-1852787222 to clarify why it's done this way,https://github.com/sqlalchemy/sqlalchemy/pull/13402,a6c68e602a88c876863c56c4cc76309bbe60cf2d2c6eccaf0415c33e7d7dba7f
|
| review guidance,pr,13402,issue,10748,high,pr.reviews[0].body,"thanks, just a nitpick comment. otherwise it looks fine @zzzeek I think 2.1 only for this is fine",https://github.com/sqlalchemy/sqlalchemy/pull/13402,317501913ea3833a0f52017aece56f00a5964f4d16e269ab23bc92f9cc85d4e2
|
| review guidance,pr,13402,issue,10748,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision e54815ef0092da05277efab79b90b77e44734cb9 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/13402,c2cecc1f3588b02651b4c91caebdef4cfe14f66fa65d5756883901839621ae9d
|
| review guidance,pr,13402,issue,10748,high,pr.reviews[2].body,"thanks, just a nitpick comment. otherwise it looks fine @zzzeek I think 2.1 only for this is fine",https://github.com/sqlalchemy/sqlalchemy/pull/13402#pullrequestreview-4590614148,788250012b0125e304886586bcd8d8f88a085429a2f4d5fc15a5cba222b2a0af
|
| review guidance,pr,13402,issue,10748,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision e54815ef0092da05277efab79b90b77e44734cb9 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/13402#pullrequestreview-4590995010,8b7a19c1abf1d46bdf74ab347e2b6a5580f42341e7f25f5882798fb27a7bb34c
|
| closes,pr,13399,issue,13048,high,pr.closingIssuesReferences,pr #13399 declares a closing reference to issue #13048.,https://github.com/sqlalchemy/sqlalchemy/pull/13399,3cc30e8644c0575daf316f555c3cc702e33be56a7baf9238db54f2ff2ecc9bf7
|
| closes,pr,13399,issue,13048,high,pr.body,"attach_to_table, using `Table.append_constraint(index)` allows for execution of `table.indexes.add(self)` in `Index._set_parent()`. Fixes: #13048 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the...",https://github.com/sqlalchemy/sqlalchemy/pull/13399,1a42aa2d1aa76cff59c51a944ec4956d6836271d09c18987274c277d11e5a339
|
| closes,pr,13398,issue,13419,high,pr.closingIssuesReferences,pr #13398 declares a closing reference to issue #13419.,https://github.com/sqlalchemy/sqlalchemy/pull/13398,84e54b42e50f97e6babf610048871a2144a6a2cb42f230b35846acad8d18b0d7
|
| closes,pr,13398,issue,13419,high,pr.body,"Fixes: #13419 ### Description While reflecting a SQLite table, `get_unique_constraints` scans the stored `CREATE TABLE` text (taken verbatim from `sqlite",https:
|
| closes,pr,13398,issue,13419,high,pr.comments[1].body,"opened #13419 with the description, a runnable reproducer and the comparative timings. i've linked it here (Fixes: #13419) and renamed the changelog to 1",https:
|
| review guidance,pr,13398,issue,13419,high,pr.reviews[0].body,LGTM. Removing the space from `[a-z0-9_ ]` successfully eliminates the ReDOS vulnerability. Thanks!,https:
|
| review guidance,pr,13398,issue,13419,high,pr.reviews[1].body,LGTM. Removing the space from `[a-z0-9_ ]` successfully eliminates the ReDOS vulnerability. Thanks!,https:
|
| closes,pr,13368,issue,11132,high,pr.closingIssuesReferences,pr #13368 declares a closing reference to issue #11132.,https:
|
| closes,pr,13368,issue,11132,high,pr.body,"### Description Fixes #11132. Per maintainer guidance in the issue, this PR does two things: 1. **Documents the caveat**: adds a `.. warning::` to the MySQL dialect's `",https:
|
| closes,pr,13323,issue,8992,high,pr.closingIssuesReferences,pr #13323 declares a closing reference to issue #8992.,https:
|
| closes,pr,13323,issue,8992,high,pr.body,dering expanded tuples. This matches scalar `IN` behavior for custom types and covers both `render_postcompile` and `literal_binds`. Fixes: #8992 ### Checklist This pull request is: - [ ] A documentation / typographical / small typing error fix - [x] A short code fix - Fixes:...,https:
|
| closes,pr,13303,issue,13157,high,pr.closingIssuesReferences,pr #13303 declares a closing reference to issue #13157.,https:
|
| closes,pr,13303,issue,13157,high,pr.body,"Fixes #13157. The second pass over the CHECK constraint body in `get_multi_check_constraints` used a naive ```python re.sub(r""^[\s\n]*\((.+)\)[\s\n]*$"",",https:
|
| references,pr,13303,pr,13200,medium,pr.reviews[0].body,"Hi, If you want to work on this please try at least to address the comment in the last attempt: https://github.com/sqlalchemy/sqlalchemy/pull/13200#pullrequestreview-4022937474 thanks",https:
|
| review guidance,pr,13303,issue,13157,high,pr.reviews[0].body,"Hi, If you want to work on this please try at least to address the comment in the last attempt: https://github.com/sqlalchemy/sqlalchemy/pull/13200#pullrequestreview-4022937474 thanks",https:
|
| review guidance,pr,13303,issue,13157,high,pr.reviews[1].body,"Hi, If you want to work on this please try at least to address the comment in the last attempt: https://github.com/sqlalchemy/sqlalchemy/pull/13200#pullrequestreview-4022937474 thanks",https:
|
| closes,pr,13289,issue,13227,high,pr.closingIssuesReferences,pr #13289 declares a closing reference to issue #13227.,https:
|
| closes,pr,13289,issue,13227,high,pr.body,"### Description Fixes: #13227 When `default_factory=list` or `default` is passed to a `WriteOnlyMapped` or `DynamicMapped` relationship, it previously caused cryptic cra",https:
|
| review guidance,pr,13289,issue,13227,high,pr.reviews[0].body,"thanks, left a few suggestions. let's also wait mike input on whatever we should include also dynamic here",https:
|
| review guidance,pr,13289,issue,13227,high,pr.reviews[2].body,"thanks, left a few suggestions. let's also wait mike input on whatever we should include also dynamic here",https:
|
| closes,pr,13288,issue,13169,high,pr.closingIssuesReferences,pr #13288 declares a closing reference to issue #13169.,https:
|
| closes,pr,13288,issue,13169,high,pr.body,"timeout), so switching to `time.monotonic()` preserves existing behavior while fixing the precision issue. - [x] A short code fix - Fixes: #13169 - Existing pool invalidation tests cover the comparison logic",https:
|
| closes,pr,13288,issue,13169,high,pr.reviews[0].body,I want to do what I propose [here](https:
|
| review guidance,pr,13288,issue,13169,high,pr.reviews[0].body,I want to do what I propose [here](https:
|
| review guidance,pr,13288,issue,13169,high,pr.reviews[1].body,I want to do what I propose [here](https:
|
| closes,pr,13051,issue,13049,high,pr.closingIssuesReferences,pr #13051 declares a closing reference to issue #13049.,https:
|
| closes,pr,13051,issue,13049,high,pr.body,"y of your proposed changes in the Title field above --> ### Description Added the implementations for `func.avg()` and `func.abs()`. Fixes: #13049 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once th...",https:
|
| review guidance,pr,13051,issue,13049,high,pr.reviews[0].body,thanks for this PR! left a comment,https:
|
| review guidance,pr,13051,issue,13049,high,pr.reviews[2].body,"as mentioned, typing should use _N which is what we already use.",https:
|
| review guidance,pr,13051,issue,13049,high,pr.reviews[3].body,thanks for this PR! left a comment,https:
|
| review guidance,pr,13051,issue,13049,high,pr.reviews[5].body,"as mentioned, typing should use _N which is what we already use.",https:
|
| closes,pr,12731,issue,12730,high,pr.closingIssuesReferences,pr #12731 declares a closing reference to issue #12730.,https:
|
| closes,pr,12731,issue,12730,high,pr.body,"ic type checkers like mypy and pyright currently report type errors when `DeclarativeBase` subclasses are passed. This patch resolves issue #12730 by expanding `_ForUpdateOfArgument` to include `Type[DeclarativeBase]` (and sequences containing them), aligning type hints with a...",https:
|
| review guidance,pr,12731,issue,12730,high,pr.reviews[0].body,hey there- thanks for this! I've tested locally and this just needs `_FromClauseArgument`: ```diff diff --git a/lib/sqlalchemy/sql/selectable.py b/lib/sqlalchemy/sql/selectable.py index 349f18930..f1959db43 100644 --- a/lib/sqlalchemy/sql/selectable.py +++ b/lib/sqlalchemy/sql/selectable.py @@ -1...,https://github.com/sqlalchemy/sqlalchemy/pull/12731,56c8ec85735ed23467d565f5d613ad24aab1cfa7e7f520a300da83d0884d4f23
|
| review guidance,pr,12731,issue,12730,high,pr.reviews[1].body,hey there- thanks for this! I've tested locally and this just needs `_FromClauseArgument`: ```diff diff --git a/lib/sqlalchemy/sql/selectable.py b/lib/sqlalchemy/sql/selectable.py index 349f18930..f1959db43 100644 --- a/lib/sqlalchemy/sql/selectable.py +++ b/lib/sqlalchemy/sql/selectable.py @@ -1...,https:
|
| references,pr,12698,pr,12510,medium,pr.body,based on #12697 (and #12510).,https:
|
| references,pr,12698,pr,12697,medium,pr.body,based on #12697 (and #12510).,https:
|
| closes,pr,12697,issue,9693,high,pr.closingIssuesReferences,pr #12697 declares a closing reference to issue #9693.,https:
|
| closes,pr,12697,issue,9693,high,pr.body,", allowing to create respective elements with a schema-qualified collation name. Reflection is also handled for both types and domains. Fix #9693.",https:
|
| references,pr,12697,pr,12510,medium,pr.comments[0].body,notes: - this is based on #12510 (first 4 commits) - ~~5th commit (related to reflection caching to avoid `JOIN`s) might be worth considering apart from this PR~~,https:
|
| references,pr,12697,pr,12510,medium,pr.comments[1].body,Rebased (and changed according to the rework of https:
|
| review guidance,pr,12697,issue,9693,high,pr.reviews[0].body,hi - I'm rethinking this change as this is way too much complexity dug into compiler.py for a feature that's postgresql specific. to keep things simple for this odd use case why dont we do just this patch: ```diff diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index...,https://github.com/sqlalchemy/sqlalchemy/pull/12697,106281129c4db320594bf973ba79a495c07cf8ca5c359742292f6e42b286b098
|
| review guidance,pr,12697,issue,9693,high,pr.reviews[1].body,hi - I'm rethinking this change as this is way too much complexity dug into compiler.py for a feature that's postgresql specific. to keep things simple for this odd use case why dont we do just this patch: ```diff diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index...,https:
|
| references,pr,12433,issue,6274,medium,pr.body,"Fixes issue #6274 ### Description When `aliased()` is used on a select statement or compound select statement, it currently throws an error. The proposed sol",https:
|
| references,pr,12433,issue,10236,medium,pr.reviews[5].body,"OK we changed from coercion + warning to raise in #10236. So this PR needs to have a separate version for main vs. 2.0. in main, these test should expect a raise. in 2.0, we need to use expect_dep",https:
|
| references,pr,12433,issue,6274,medium,pr.review_comments[4].body,"the coercion itself does the subquery() call. I tested the above patch with the original case at #6274, and if it is not working for an additional case here then I'd want to add that support to coercions, I can do that if you show me the fail",https:
|
| review guidance,pr,12433,issue,6274,high,pr.reviews[0].body,"great job. I think we can simplify the fix and also add some more test support, see inline comments",https:
|
| review guidance,pr,12433,issue,6274,high,pr.reviews[2].body,"I would prefer just go to the ""raise informative error"" step without passing to the deprecation step, since we had an uninformative error already",https:
|
| review guidance,pr,12433,issue,6274,high,pr.reviews[5].body,"OK we changed from coercion + warning to raise in #10236. So this PR needs to have a separate version for main vs. 2.0. in main, these test should expect a raise. in 2.0, we need to use expect_deprecated. the tests themselves should be in test/orm/test_deprecated.py. @CaselIT this is getting comp...",https:
|
| review guidance,pr,12433,issue,6274,high,pr.reviews[6].body,"great job. I think we can simplify the fix and also add some more test support, see inline comments",https:
|
| review guidance,pr,12433,issue,6274,high,pr.reviews[8].body,"I would prefer just go to the ""raise informative error"" step without passing to the deprecation step, since we had an uninformative error already",https:
|
| review guidance,pr,12433,issue,6274,high,pr.reviews[11].body,"OK we changed from coercion + warning to raise in #10236. So this PR needs to have a separate version for main vs. 2.0. in main, these test should expect a raise. in 2.0, we need to use expect_deprecated. the tests themselves should be in test/orm/test_deprecated.py. @CaselIT this is getting comp...",https:
|
| closes,pr,12401,issue,12398,high,pr.closingIssuesReferences,pr #12401 declares a closing reference to issue #12398.,https:
|
| closes,pr,12401,issue,12398,high,pr.body,Fixes: #12398 This PR makes the error message on conflicting loader strategies more verbose to help with debugging <!-- Provide a general summary of your,https:
|
| closes,pr,12297,issue,11620,high,pr.closingIssuesReferences,pr #12297 declares a closing reference to issue #11620.,https:
|
| closes,pr,12297,issue,11620,high,pr.body,Fixes: #11620 ### Description - Refactored method in to improve readability and maintainability: - Extracted identity insert logic into helper methods: -,https:
|
| review guidance,pr,12297,issue,11620,high,pr.reviews[0].body,"Thanks for the PR, I've left a few comments. Could you also add a changelog file, see https://github.com/sqlalchemy/sqlalchemy/tree/main/doc/build/changelog/unreleased_21 for examples. the number refer to the issue. Also it would be nice to have some tests. the existing ones are here https://gith...",https:
|
| review guidance,pr,12297,issue,11620,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d25b6e47f76dc837a049b4de53871b939ef9578c of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12297,issue,11620,high,pr.reviews[2].body,"Thanks for the PR, I've left a few comments. Could you also add a changelog file, see https://github.com/sqlalchemy/sqlalchemy/tree/main/doc/build/changelog/unreleased_21 for examples. the number refer to the issue. Also it would be nice to have some tests. the existing ones are here https://gith...",https:
|
| review guidance,pr,12297,issue,11620,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d25b6e47f76dc837a049b4de53871b939ef9578c of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,11437,pr,11437,high,pr.reviews[0].body,"thanks for this! unfortunately I'm -1 on the automation steps being added here, these detract from the clarity of the examples and I'd rather keep the amount of source code presented to the user at an absolute minimum",https:
|
| review guidance,pr,11437,pr,11437,high,pr.reviews[6].body,"thanks for this! unfortunately I'm -1 on the automation steps being added here, these detract from the clarity of the examples and I'd rather keep the amount of source code presented to the user at an absolute minimum",https:
|
| closes,pr,11296,issue,11122,high,pr.closingIssuesReferences,pr #11296 declares a closing reference to issue #11122.,https:
|
| closes,pr,11296,issue,11122,high,pr.body,"y to specify storage parameters via with + fix for specifying index storage parameters (should it be split into two different PRs?). Fixes: #11122 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once th...",https:
|
| review guidance,pr,11296,issue,11122,high,pr.reviews[0].body,"Thanks for the change, I'm not sure about changing how the values are compiled since that's potentially a breaking change",https:
|
| review guidance,pr,11296,issue,11122,high,pr.reviews[5].body,"We are looking to support lots more keywords here, with different kinds of expectations, we either have to look at the type of value and format exactly as would be seen in the examples at https://www.postgresql.org/docs/current/sql-createindex.html or we need to (and I might prefer this) build up...",https:
|
| review guidance,pr,11296,issue,11122,high,pr.reviews[7].body,"Thanks for the change, I'm not sure about changing how the values are compiled since that's potentially a breaking change",https:
|
| review guidance,pr,11296,issue,11122,high,pr.reviews[12].body,"We are looking to support lots more keywords here, with different kinds of expectations, we either have to look at the type of value and format exactly as would be seen in the examples at https://www.postgresql.org/docs/current/sql-createindex.html or we need to (and I might prefer this) build up...",https:
|
| review guidance,pr,11107,pr,11107,high,pr.reviews[0].body,the migration to 2.0 is still using `session.query()` so is not fully migrated,https:
|
| review guidance,pr,11107,pr,11107,high,pr.reviews[3].body,the migration to 2.0 is still using `session.query()` so is not fully migrated,https:
|
| references,pr,10574,issue,2943,medium,pr.body,"Applied the patch mentioned in #2943, to allow overriding the validates method of a given Model, Added tests for same in test_validators. If a Child class overrides the parent",https:
|
| review guidance,pr,10574,issue,2943,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d310bef35b0ac3e5b840842b62807fc4008fd086 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,10574,issue,2943,high,pr.reviews[1].body,**Federico Caselli** (CaselIT) wrote: left some style suggestions View this in Gerrit at https:
|
| review guidance,pr,10574,issue,2943,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d310bef35b0ac3e5b840842b62807fc4008fd086 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,10574,issue,2943,high,pr.reviews[4].body,**Federico Caselli** (CaselIT) wrote: left some style suggestions View this in Gerrit at https:
|
| references,pr,8136,issue,7659,medium,pr.body,"### Description The goal of this PR is to add tools that help with contributing to documentation, from discussion started on #7659. Goals include: - Automatic formatting of code blocks in .rst documents and in docstrings (blacken-docs) - Flake8 validation of these code",https:
|
| closes,pr,13200,issue,13157,high,pr.closingIssuesReferences,pr #13200 declares a closing reference to issue #13157.,https:
|
| closes,pr,13200,issue,13157,high,pr.body,"verified: - `((a > 1) AND (a < 5))` → `(a > 1) AND (a < 5)` ✅ - `(a > 1)` → `a > 1` ✅ - `a > 1` → `a > 1` (no parens, unchanged) ✅ Closes: #13157",https:
|
| review guidance,pr,13200,issue,13157,high,pr.reviews[0].body,"Hi, This does not take into consideration string literals and has no tests. I've looked around and there is already some piece of code that does this: https://github.com/sqlalchemy/sqlalchemy/blob/a49a4f021ad9c9ff69f5482881b00f831d523a22/lib/sqlalchemy/dialects/sqlite/base.py#L2880-L2902 So the p...",https:
|
| review guidance,pr,13200,issue,13157,high,pr.reviews[1].body,"Hi, This does not take into consideration string literals and has no tests. I've looked around and there is already some piece of code that does this: https://github.com/sqlalchemy/sqlalchemy/blob/a49a4f021ad9c9ff69f5482881b00f831d523a22/lib/sqlalchemy/dialects/sqlite/base.py#L2880-L2902 So the p...",https:
|
| closes,pr,13188,issue,13157,high,pr.closingIssuesReferences,pr #13188 declares a closing reference to issue #13157.,https:
|
| closes,pr,13188,issue,13157,high,pr.body,"## Summary Fixes #13157. **Root cause:** Check constraint reflection naively stripped one pair of outer parentheses, corrupting compound expressions where the firs",https:
|
| references,pr,12707,issue,6810,medium,pr.body,"<html><head></head><body> <hr> <h2>✅ typing: improve type coverage in <code inline="""">sqlalchemy.sql.base</code> for issue #6810</h2> <h3>Overview</h3> <p>This pull request enhances the type coverage of the <code inline="""">sqlalchemy.sql.base</code> module as part of",https:
|
| review guidance,pr,12707,issue,6810,high,pr.reviews[0].body,"great work. I've left some comments but the general code is great, thanks",https:
|
| review guidance,pr,12707,issue,6810,high,pr.reviews[14].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 7374212dfc88a43f381f8380d9b4ac193f5ed10b of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12707,issue,6810,high,pr.reviews[15].body,"great work. I've left some comments but the general code is great, thanks",https:
|
| review guidance,pr,12707,issue,6810,high,pr.reviews[29].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 7374212dfc88a43f381f8380d9b4ac193f5ed10b of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| references,pr,12510,issue,6511,medium,pr.body,"hand, if the column collation matches the one of the database but is explicitly set at column creation, the value is reflected. Related to #6511.",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision baf48b55ee59874836c97607abfdfbf4f79fce4b of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[1].body,**Federico Caselli** (CaselIT) wrote: code review left on gerrit View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[2].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 62d03e71db4c459d49043a2e45e88f6489a02e77 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c6ba75fe4ceb67a2636ffc2c432c7ce366ac0e9a of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[5].body,**Denis Laxalde** (dlax) wrote: code review left on gerrit View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[6].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4735f0ef65b4070abaab4f0632f691535803b7fd of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[10].body,"Hi, this is **sqla-tester** and I see you've pinged me for review. However, user **dlax** is not authorized to initiate CI jobs. Please wait for a project member to do this!",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[12].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 896aa73356c7f5fb02d63f83c52ea1f45e7d3bd0 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[13].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4c2ba7349824fdacc26c35d36f8b95cf3a35c99a of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[14].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c0a390314eb8ff2a4f729babf25cb052b6268d0a of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[15].body,"**Federico Caselli** (CaselIT) wrote: gonna finish this one, thanks for the effort and sorry for the delay in getting to this View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/testing/requirements.py (line 695): should be closed",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[16].body,**Federico Caselli** (CaselIT) wrote: In the end using a case on a scalar subquery seem to have adequate performance without requiring a separate query View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[17].body,**Michael Bayer** (zzzeek) wrote: the new requirement was added to the publicly exported requirements so we should probably add a test to testing/suite/test_reflection.py also View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[20].body,**Michael Bayer** (zzzeek) wrote: code review left on gerrit View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[21].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision baf48b55ee59874836c97607abfdfbf4f79fce4b of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[22].body,**Federico Caselli** (CaselIT) wrote: code review left on gerrit View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[23].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 62d03e71db4c459d49043a2e45e88f6489a02e77 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[24].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c6ba75fe4ceb67a2636ffc2c432c7ce366ac0e9a of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[26].body,**Denis Laxalde** (dlax) wrote: code review left on gerrit View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[27].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4735f0ef65b4070abaab4f0632f691535803b7fd of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[31].body,"Hi, this is **sqla-tester** and I see you've pinged me for review. However, user **dlax** is not authorized to initiate CI jobs. Please wait for a project member to do this!",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[33].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 896aa73356c7f5fb02d63f83c52ea1f45e7d3bd0 of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[34].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4c2ba7349824fdacc26c35d36f8b95cf3a35c99a of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[35].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c0a390314eb8ff2a4f729babf25cb052b6268d0a of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[36].body,"**Federico Caselli** (CaselIT) wrote: gonna finish this one, thanks for the effort and sorry for the delay in getting to this View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/testing/requirements.py (line 695): should be closed",https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[37].body,**Federico Caselli** (CaselIT) wrote: In the end using a case on a scalar subquery seem to have adequate performance without requiring a separate query View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[38].body,**Michael Bayer** (zzzeek) wrote: the new requirement was added to the publicly exported requirements so we should probably add a test to testing/suite/test_reflection.py also View this in Gerrit at https:
|
| review guidance,pr,12510,issue,6511,high,pr.reviews[41].body,**Michael Bayer** (zzzeek) wrote: code review left on gerrit View this in Gerrit at https:
|
| references,pr,12384,issue,6810,medium,pr.body,.Any` by the `Any()` function through aliasing as `typing_Any` and removed unused `_type_tuple` attribute of `postgresql.array`. Related to #6810,https://github.com/sqlalchemy/sqlalchemy/pull/12384,fdca1fce9ef0fc97d5bd7c6d78b3a49fa03bf93e2eaec38c80da654f76b4a179
|
| review guidance,pr,12384,issue,6810,high,pr.reviews[2].body,"Thanks, left a few suggestion. I think to do a better job the base array type should also be typed. let us know if you want to do this or if you prefer we take this over",https://github.com/sqlalchemy/sqlalchemy/pull/12384,ade517d45111d30465c69b4c2559ab5746681d13d467311c9b1f26f2827ba94b
|
| review guidance,pr,12384,issue,6810,high,pr.reviews[9].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 78eea29f1de850afda036502974521969629de7e of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12384,f9621add2fec6c11c5652c760eef1e23526efdc9dd4be2369d79d06ed732311d
|
| review guidance,pr,12384,issue,6810,high,pr.reviews[12].body,"Thanks, left a few suggestion. I think to do a better job the base array type should also be typed. let us know if you want to do this or if you prefer we take this over",https://github.com/sqlalchemy/sqlalchemy/pull/12384#pullrequestreview-2652402346,0f9e175574c0446b14716e36f977dc7749d4cfd2ceb535fb3de2d287c8fb2df6
|
| review guidance,pr,12384,issue,6810,high,pr.reviews[19].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 78eea29f1de850afda036502974521969629de7e of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12384#pullrequestreview-2686824383,0d25dc8667389cf90ec838862ea68a5e1e31d5670953e62765459c52b90e0844
|
| closes,pr,11678,issue,11677,high,pr.closingIssuesReferences,pr #11678 declares a closing reference to issue #11677.,https://github.com/sqlalchemy/sqlalchemy/pull/11678,2bf3fe6bd7f135a857af3bb505ec075ef532c3cb21b0fb515215ec6f52863473
|
| closes,pr,11678,issue,11677,high,pr.body,"vide a general summary of your proposed changes in the Title field above --> ### Description <!-- Describe your changes in detail --> Fixes #11677 Changed Constraint matching regex to lazily match any character including newlines, and adding a stricter ending to the regex to e...",https://github.com/sqlalchemy/sqlalchemy/pull/11678,66b134b7d42d5cb62b98c78a5901608a6f2a354a22557f18f5193e66501f3840
|
| review guidance,pr,11678,issue,11677,high,pr.reviews[0].body,Thanks for the great start. Tests are defined in this test class: https://github.com/sqlalchemy/sqlalchemy/blob/3ba2d1c7caba6a2df0445bb7e00366ff43961f6d/test/dialect/test_sqlite.py#L1724,https://github.com/sqlalchemy/sqlalchemy/pull/11678,931ff275ee3bfaf49ad5060c0981e793ffdd2a2d0e76563717d441b53c214ea1
|
| review guidance,pr,11678,issue,11677,high,pr.reviews[1].body,Thanks for the great start. Tests are defined in this test class: https://github.com/sqlalchemy/sqlalchemy/blob/3ba2d1c7caba6a2df0445bb7e00366ff43961f6d/test/dialect/test_sqlite.py#L1724,https://github.com/sqlalchemy/sqlalchemy/pull/11678#pullrequestreview-2213211046,f8d7a69e5dd25a695871b411c9170ec685a1770f735b19803b19a68b645df9e3
|
| closes,pr,10545,issue,10544,high,pr.closingIssuesReferences,pr #10545 declares a closing reference to issue #10544.,https://github.com/sqlalchemy/sqlalchemy/pull/10545,ba87e31fe032ad5dc2b054c66139dbc041b9c6242e7e49f1b1a19c00160751da
|
| closes,pr,10545,issue,10544,high,pr.body,<!-- Provide a general summary of your proposed changes in the Title field above --> to fix the pysqlcipher broken usage in 2.0.22 with pysqlcipher3 new master ### Description issue fix : https://github.com/sqlalchemy/sqlalchemy/issues/10544 ### Checklist <!-- go over followin...,https://github.com/sqlalchemy/sqlalchemy/pull/10545,129ebef129f1272e57fd2e5c69107012e1b7ad54cef06fbd86dc068bdcc339e2
|
| review guidance,pr,10545,issue,10544,high,pr.reviews[0].body,hi - we cant hardcode arbitrary driver names here. please use this patch ```diff diff --git a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py b/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py index 28b900ea53..3b31400ef8 100644 --- a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py +++ b/lib/sqlalchemy/...,https:
|
| review guidance,pr,10545,issue,10544,high,pr.reviews[1].body,hi - we cant hardcode arbitrary driver names here. please use this patch ```diff diff --git a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py b/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py index 28b900ea53..3b31400ef8 100644 --- a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py +++ b/lib/sqlalchemy/...,https:
|
| review guidance,pr,7009,pr,7009,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 8af63436b704389f777b78e69e8ae9ba2204241f of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,7009,pr,7009,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4fa750e3d34638be7e9583d849216f6d90ca88fc of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,7009,pr,7009,high,pr.reviews[2].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 8af63436b704389f777b78e69e8ae9ba2204241f of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| review guidance,pr,7009,pr,7009,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4fa750e3d34638be7e9583d849216f6d90ca88fc of this pull request into gerrit so we can run tests and reviews and stuff",https:
|
| blocked by checks,pr,13421,pr,13421,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): code_review,https:
|
| waiting on owner test approval,pr,13418,pr,13418,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13417,pr,13417,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13416,pr,13416,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13415,pr,13415,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13405,pr,13405,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13404,pr,13404,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| blocked by checks,pr,13402,pr,13402,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): code_review,https:
|
| waiting on owner test approval,pr,13399,pr,13399,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13398,pr,13398,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13368,pr,13368,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13323,pr,13323,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13312,pr,13312,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| waiting on owner test approval,pr,13137,pr,13137,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| blocked by checks,pr,12698,pr,12698,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): gerrit_review,https:
|
| blocked by checks,pr,12645,pr,12645,medium,pr.statusCheckRollup,"Blocked or unstable check/merge state. Check signal(s): pep484-3.12, gerrit_review",https:
|
| blocked by checks,pr,12401,pr,12401,medium,pr.statusCheckRollup,"Blocked or unstable check/merge state. Check signal(s): pep484-3.14, pep8-3.14, gerrit_review",https:
|
| blocked by checks,pr,10574,pr,10574,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): DIRTY,https:
|
| blocked by checks,pr,8136,pr,8136,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): DIRTY,https:
|
| waiting on owner test approval,pr,13188,pr,13188,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https:
|
| blocked by checks,pr,12759,pr,12759,medium,pr.statusCheckRollup,"Blocked or unstable check/merge state. Check signal(s): test-amd64-3.13-cext-x64-ubuntu-22.04, test-amd64-3.13-nocext-x64-ubuntu-22.04, mypy-3.12, lint-3.12",https:
|
| blocked by checks,pr,7009,pr,7009,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): DIRTY,https:
|
| duplicate candidate,issue,10094,issue,9410,low,title_label_similarity,"Possible related issues #10094 and #9410 shared tokens: document, far, gotchas",,a1fd3ce187e9261468f2892e639e2a61942b279f476f6b7930e63dd41f8d4762
|
| duplicate candidate,issue,12585,issue,8795,low,title_label_similarity,"Possible related issues #12585 and #8795 shared tokens: autocommit, sqlite, support",,80339b4d46653012705cb65c6dd1b2a6b3818b01553c22b04f42443aefbd797c
|
|
|
