feat(service-professional): Remove staff_id/staff_code from OTP login response

- Replace staff_id and staff_code fields with partner_id in professional info response
- Update error logging to use partner_id instead of staff_id
- Update login event logging to use partner_id as the standard identifier
- Remove duplicate partner_id entry in JWT token payload
- Consolidate identifier usage across OTP verification flow for consistency

app/auth/controllers/service_professional_router.py

@@ -165,7 +165,7 @@ async def verify_service_professional_otp(
             access_token_expires = timedelta(hours=settings.TOKEN_EXPIRATION_HOURS)
         except Exception as token_error:
             logger.error(
-                f"Error creating access token for service professional {professional_data['staff_id']}: {token_error}",
+                f"Error creating access token for service professional {professional_data['partner_id']}: {token_error}",
                 exc_info=True
             )
             raise HTTPException(
@@ -175,8 +175,7 @@ async def verify_service_professional_otp(
         
         # Prepare professional info response
         professional_info = {
-            "staff_id": professional_data["staff_id"],
-            "staff_code": professional_data["staff_code"],
+            "partner_id": professional_data["partner_id"],
             "name": professional_data["name"],
             "phone": professional_data["phone"],
             "email": professional_data.get("email"),
@@ -186,11 +185,10 @@ async def verify_service_professional_otp(
         }
         
         logger.info(
-            f"Service professional logged in via mobile OTP: {professional_data['staff_code']}",
+            f"Service professional logged in via mobile OTP: {professional_data['partner_id']}",
             extra={
                 "event": "service_professional_mobile_otp_login",
-                "staff_id": professional_data["staff_id"],
-                "staff_code": professional_data["staff_code"],
+                "partner_id": professional_data["partner_id"],
                 "phone": verify_request.phone
             }
         )

app/auth/services/service_professional_auth_service.py

@@ -274,8 +274,7 @@ class ServiceProfessionalAuthService:
             # Token payload - use partner_id as the standard identifier
             token_data = {
                 "sub": professional_data["partner_id"],
-                "partner_id": professional_data["partner_id"],  # Standard identifier for SPA-MS
-                "partner_id": professional_data["partner_id"],  # Keep for backward compatibility
+                "partner_id": professional_data["partner_id"],
                 "user_type": "service_professional",
                 "exp": expire,
                 "iat": datetime.utcnow()