Update app.py

app.py

@@ -1,11 +1,11 @@
 from fastapi import FastAPI, APIRouter, UploadFile, File, HTTPException, Query, Form
 from fastapi.responses import FileResponse
 from typing import Optional
+from contextlib import asynccontextmanager
 import os
 import shutil
 import logging
 import json
-from dotenv import load_dotenv
 from agents.simple_tools import generate_notes_full_pipeline_from_path
 from agents.generator_validator import create_notes_pipeline, InteractiveFeedbackManager
 from agents.langgraph import run_workflow
@@ -13,16 +13,23 @@ from agents.rlhf_workflows import run_rlhf_workflow
 from agents.rlhf_routes import rlhf_router
 from fastapi.middleware.cors import CORSMiddleware
 
-load_dotenv()
-
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger("financial_notes_api")
 
+@asynccontextmanager
+async def lifespan(app: FastAPI):
+    # Startup
+    logger.info("Financial Notes Generator API has started.")
+    yield
+    # Shutdown
+    logger.info("Financial Notes Generator API is shutting down.")
+
 # Initialize FastAPI app first
 app = FastAPI(
     title="Financial Notes Generator API",
     description="API for generating financial notes, balance sheets, cash flow statements, and P&L reports with RLHF capabilities and Interactive Feedback.",
-    version="1.0.0"
+    version="1.0.0",
+    lifespan=lifespan
 )
 
 # Add CORS middleware immediately after app initialization
@@ -42,14 +49,6 @@ feedback_manager = InteractiveFeedbackManager()
 # Include RLHF router
 app.include_router(rlhf_router)
 
-@app.on_event("startup")
-async def startup_event():
-    logger.info("Financial Notes Generator API has started.")
-
-@app.on_event("shutdown")
-async def shutdown_event():
-    logger.info("Financial Notes Generator API is shutting down.")
-
 # Initialize router for main endpoints
 router = APIRouter()
 
@@ -128,7 +127,7 @@ async def notes_llm_route(
 async def submit_feedback(
     session_id: str = Form(...),
     feedback_text: str = Form(...),
-    feedback_type: str = Form(..., regex="^(text|numeric|formula|suggestion)$")
+    feedback_type: str = Form(..., pattern="^(text|numeric|formula|suggestion)$")
 ):
     try:
         udf_version = feedback_manager.add_feedback(session_id, feedback_text, feedback_type)
@@ -212,6 +211,12 @@ async def generate_with_feedback(
     file: UploadFile = File(...),
     user_api_key: Optional[str] = Form(None)
 ):
+    if not user_api_key or user_api_key.strip() == "":
+        raise HTTPException(
+            status_code=400, 
+            detail="Missing required parameter: 'user_api_key'. Please provide your OpenRouter API key as a form parameter (not in JSON body)."
+        )
+    
     try:
         session = feedback_manager.get_session(session_id)