Try again

backend/runner/app.py

@@ -72,10 +72,22 @@ if STUB_MODE or tasks is None:
 #  Flask application & thread pool setup                                      #
 # --------------------------------------------------------------------------- #
 app = Flask(__name__)
-CORS(app, resources={r"/*": {"origins": "*"}})  # allow SPA on :5173
+# Configure CORS for HF Spaces
+CORS(app, resources={
+    r"/*": {
+        "origins": [
+            "https://huggingface.co",
+            "https://*.hf.space",
+            "http://localhost:5173",  # Local development
+            "http://localhost:3000"   # Local development
+        ]
+    }
+})
 
 # Thread pool to handle background inference tasks
-executor = ThreadPoolExecutor(max_workers=4)
+# Reduce workers for HF Spaces memory constraints
+max_workers = int(os.getenv("MAX_WORKERS", "2"))  # Default to 2 for HF Spaces
+executor = ThreadPoolExecutor(max_workers=max_workers)
 
 # Use the Space data volume, not the repo folder
 from .config import (
@@ -136,11 +148,17 @@ def serve_css(filename):
     css_dir = Path(__file__).parent.parent.parent / "frontend" / "css"
     return send_from_directory(css_dir, filename)
 
+# Serve static frontend files with proper error handling
 @app.route("/js/<path:filename>")
 def serve_js(filename):
-    """Serve JavaScript files."""
-    js_dir = Path(__file__).parent.parent.parent / "frontend" / "js"
-    return send_from_directory(js_dir, filename)
+    try:
+        js_dir = Path(__file__).parent.parent.parent / "frontend" / "js"
+        if not js_dir.exists():
+            return "JavaScript directory not found", 404
+        return send_from_directory(js_dir, filename)
+    except Exception as e:
+        print(f"Error serving JS file {filename}: {e}")
+        return "Internal server error", 500
 
 @app.route("/images/<path:filename>")
 def serve_images(filename):
@@ -151,37 +169,25 @@ def serve_images(filename):
 
 @app.route("/presign", methods=["POST"])
 def presign_upload():
-    """
-    Body:     { "fileName": "myfile.jpg" }
-    Response: {
-        "runId": "...",
-        "imageKey": "artifacts/<id>.jpg",
-        "upload": { "url": "...", "fields": { } }
-    }
-    """
     run_id = uuid.uuid4().hex
     image_key = f"artifacts/{run_id}.jpg"
     
-    # Fix: Use the correct Hugging Face Space URL
-    # In Hugging Face Spaces, we need to construct the URL properly
-    if os.getenv("HF_SPACE_URL"):
-        # Use environment variable if set
-        base_url = os.getenv("HF_SPACE_URL")
+    # Use HF Spaces environment variables
+    if os.getenv("SPACE_URL"):
+        base_url = os.getenv("SPACE_URL")
+    elif os.getenv("SPACE_HOST"):
+        base_url = f"https://{os.getenv('SPACE_HOST')}"
     else:
-        # Fallback: try to get from request headers or use default
-        base_url = request.headers.get('X-Forwarded-Proto', 'https') + "://" + request.headers.get('X-Forwarded-Host', request.host)
+        # Fallback for local development
+        base_url = request.host_url.rstrip("/")
     
     upload_url = f"{base_url}/upload/{run_id}"
     
-    response = jsonify({
+    return jsonify({
         "runId": run_id,
         "imageKey": image_key,
-        "upload": {
-            "url": upload_url,
-            "fields": {},
-        },
+        "upload": {"url": upload_url, "fields": {}},
     })
-    return response
 
 
 @app.route("/upload/<run_id>", methods=["POST"])
@@ -557,5 +563,13 @@ def serve_marker_image(work_id: str, filename: str):
 # --------------------------------------------------------------------------- #
 if __name__ == "__main__":  # invoked via  python -m …
     # Use PORT environment variable for Hugging Face Spaces
-    port = int(os.getenv("PORT", 8000))
+    port = int(os.getenv("PORT", 7860))  # Default to 7860 for HF Spaces
     app.run(host="0.0.0.0", port=port, debug=False)
+
+@app.errorhandler(413)  # Payload too large
+def too_large(e):
+    return jsonify({"error": "File too large for HF Spaces"}), 413
+
+@app.errorhandler(500)
+def internal_error(e):
+    return jsonify({"error": "Internal server error"}), 500

backend/runner/config.py

@@ -10,11 +10,14 @@ from pathlib import Path
 PROJECT_ROOT = Path(__file__).resolve().parents[2]
 DATA_READ_ROOT = PROJECT_ROOT / "data"
 
-# WRITE root (Space volume or tmp - writable)
-WRITE_ROOT = Path(os.getenv("WRITE_ROOT", os.getenv("DATA_ROOT", "/data")))
+# WRITE root (Space volume - writable)
+WRITE_ROOT = Path(os.getenv("HF_HOME", "/data"))
 if not WRITE_ROOT.exists() or not os.access(WRITE_ROOT, os.W_OK):
-    print(f"⚠️  WRITE_ROOT {WRITE_ROOT} not writable, falling back to /tmp")
+    print(f"⚠️  WRITE_ROOT {WRITE_ROOT} not writable, trying /tmp")
     WRITE_ROOT = Path("/tmp")
+    if not os.access(WRITE_ROOT, os.W_OK):
+        print(f"❌ Neither /data nor /tmp are writable")
+        raise RuntimeError("No writable directory available")
 else:
     print(f"✅ Using WRITE_ROOT: {WRITE_ROOT}")