improve the activity logs controller

src/controllers/invoice/invoice.controller.ts

@@ -445,28 +445,17 @@ const updateInvoiceDetails = async (invoiceId: number, billSplit: any[], userId:
     const newDetail: any = newInvoiceDetails[i];
     const existingDetail: any = existingInvoiceDetails[i] || {};
 
-    const oldPortfolioName = existingDetail.pw_portfolio_id
-      ? (await fetchPortfolioById(existingDetail.pw_portfolio_id))?.name || 'Unknown Portfolio'
-      : 'null';
-    const newPortfolioName = newDetail.pw_portfolio_id
-      ? (await fetchPortfolioById(newDetail.pw_portfolio_id))?.name || ''
-      : 'null';
-
-    const oldBuildingName = existingDetail.pw_building_id
-      ? (await fetchBuildingsById(existingDetail.pw_building_id))?.name || 'Unknown Building'
-      : 'null';
-    const newBuildingName = newDetail.pw_building_id
-      ? (await fetchBuildingsById(newDetail.pw_building_id))?.name || ''
-      : 'null';
-
-    const oldUnitName = existingDetail.pw_unit_id
-      ? (await fetchUnitsById(existingDetail.pw_unit_id))?.name || 'Unknown Unit'
-      : 'null';
-    const newUnitName = newDetail.pw_unit_id
-      ? (await fetchUnitsById(newDetail.pw_unit_id))?.name || ''
-      : 'null';
-
     if (!existingDetail.id) {
+      const newPortfolioName = newDetail.pw_portfolio_id
+          ? (await fetchPortfolioById(newDetail.pw_portfolio_id))?.name || ''
+        : 'null';
+      const newBuildingName = newDetail.pw_building_id
+          ? (await fetchBuildingsById(newDetail.pw_building_id))?.name || ''
+        : 'null';
+      const newUnitName = newDetail.pw_unit_id
+          ? (await fetchUnitsById(newDetail.pw_unit_id))?.name || ''
+        : 'null';
+      
       const newValue = `${newPortfolioName}, ${newBuildingName}, ${newUnitName}`;
       await logInvoiceAction({
         invoice_id: invoiceId,
@@ -477,44 +466,69 @@ const updateInvoiceDetails = async (invoiceId: number, billSplit: any[], userId:
         new_value: newValue,
       });
     } else {
-      if (oldPortfolioName !== newPortfolioName) {
-        await logInvoiceAction({
-          invoice_id: invoiceId,
-          user_id: userId,
-          activity_type: 'update',
-          field_name: 'portfolio',
-          old_value: oldPortfolioName,
-          new_value: newPortfolioName,
-        });
+      if (existingDetail.pw_portfolio_id !== newDetail.pw_portfolio_id)
+      {
+        const oldPortfolioName = existingDetail.pw_portfolio_id
+          ? (await fetchPortfolioById(existingDetail.pw_portfolio_id))?.name || 'Unknown Portfolio'
+          : 'null';
+        const newPortfolioName = newDetail.pw_portfolio_id
+          ? (await fetchPortfolioById(newDetail.pw_portfolio_id))?.name || ''
+          : 'null';
+        if (oldPortfolioName !== newPortfolioName) {
+          await logInvoiceAction({
+            invoice_id: invoiceId,
+            user_id: userId,
+            activity_type: 'update bill split',
+            field_name: 'portfolio',
+            old_value: oldPortfolioName,
+            new_value: newPortfolioName,
+          });
+        }
       }
-
-      if (oldBuildingName !== newBuildingName) {
-        await logInvoiceAction({
-          invoice_id: invoiceId,
-          user_id: userId,
-          activity_type: 'update',
-          field_name: 'building',
-          old_value: oldBuildingName,
-          new_value: newBuildingName,
-        });
+      if (existingDetail.pw_building_id !== newDetail.pw_building_id) {
+        const oldBuildingName = existingDetail.pw_building_id
+          ? (await fetchBuildingsById(existingDetail.pw_building_id))?.name || 'Unknown Building'
+          : 'null';
+        const newBuildingName = newDetail.pw_building_id
+          ? (await fetchBuildingsById(newDetail.pw_building_id))?.name || ''
+          : 'null';
+        if (oldBuildingName !== newBuildingName) {
+          await logInvoiceAction({
+            invoice_id: invoiceId,
+            user_id: userId,
+            activity_type: 'update bill split',
+            field_name: 'building',
+            old_value: oldBuildingName,
+            new_value: newBuildingName,
+          });
+        }
       }
-
-      if (oldUnitName !== newUnitName) {
-        await logInvoiceAction({
-          invoice_id: invoiceId,
-          user_id: userId,
-          activity_type: 'update',
-          field_name: 'unit',
-          old_value: oldUnitName,
-          new_value: newUnitName,
-        });
+      if (existingDetail.pw_unit_id !== newDetail.pw_unit_id) { 
+
+        const oldUnitName = existingDetail.pw_unit_id
+          ? (await fetchUnitsById(existingDetail.pw_unit_id))?.name || 'Unknown Unit'
+          : 'null';
+        const newUnitName = newDetail.pw_unit_id
+          ? (await fetchUnitsById(newDetail.pw_unit_id))?.name || ''
+          : 'null';
+        
+        if (oldUnitName !== newUnitName) {
+          await logInvoiceAction({
+            invoice_id: invoiceId,
+            user_id: userId,
+            activity_type: 'update bill split',
+            field_name: 'unit',
+            old_value: oldUnitName,
+            new_value: newUnitName,
+          });
+        }
       }
 
       if (newDetail.amount !== existingDetail.amount) {
         await logInvoiceAction({
           invoice_id: invoiceId,
           user_id: userId,
-          activity_type: 'update',
+          activity_type: 'update bill split',
           field_name: 'amount',
           old_value: String(existingDetail.amount || 0),
           new_value: String(newDetail.amount || 0),
@@ -525,7 +539,7 @@ const updateInvoiceDetails = async (invoiceId: number, billSplit: any[], userId:
         await logInvoiceAction({
           invoice_id: invoiceId,
           user_id: userId,
-          activity_type: 'update',
+          activity_type: 'update bill split',
           field_name: 'description',
           old_value: existingDetail.description || '',
           new_value: newDetail.description || '',