Update src/app.py

src/app.py

@@ -235,8 +235,16 @@ if 'last_detection' not in st.session_state:
     st.session_state.last_detection = None
 if 'feedback_given' not in st.session_state:
     st.session_state.feedback_given = False
+if 'pending_toast' not in st.session_state:
+    st.session_state.pending_toast = None
 # ========================================
 
+# Show any pending toast (set by feedback buttons before st.rerun())
+if st.session_state.pending_toast:
+    _msg, _icon = st.session_state.pending_toast
+    st.toast(_msg, icon=_icon)
+    st.session_state.pending_toast = None
+
 # ----- Visit Counter -----
 # session_state resets on F5 / new tab, so this runs exactly once per browser session
 if 'visit_counted' not in st.session_state:
@@ -386,74 +394,6 @@ if detect_clicked:
                     """
                 )
 
-            # ========== Feedback UI ==========
-            _fb_key = f'feedback_given_{hash(text_input[:50])}'
-            if _fb_key not in st.session_state:
-                st.session_state[_fb_key] = False
-
-            st.markdown(
-                """
-                <style>
-                .fb-header { display: flex; align-items: center; gap: 0.4rem; margin-bottom: 0.3rem; }
-                .privacy-tip {
-                    position: relative; display: inline-block;
-                    cursor: help; color: #9ca3af; font-size: 0.9rem;
-                }
-                .privacy-tip .tip-text {
-                    visibility: hidden; opacity: 0;
-                    width: 240px; background-color: #374151; color: #f9fafb;
-                    text-align: left; border-radius: 6px;
-                    padding: 0.5rem 0.7rem; font-size: 0.78rem; line-height: 1.4;
-                    position: absolute; z-index: 100;
-                    bottom: 130%; left: 50%; transform: translateX(-50%);
-                    transition: opacity 0.25s ease; pointer-events: none;
-                }
-                .privacy-tip:hover .tip-text { visibility: visible; opacity: 1; }
-                </style>
-                <div class="fb-header">
-                  <strong>📝 Result Feedback</strong>: Does this detection result meet your expectations?
-                  <span class="privacy-tip">🔒
-                    <span class="tip-text">🔒 Your feedback is stored privately and will never be shared with third parties. It is used solely to improve detection accuracy.</span>
-                  </span>
-                </div>
-                """,
-                unsafe_allow_html=True
-            )
-
-            if not st.session_state[_fb_key]:
-                feedback_col1, feedback_col2 = st.columns(2)
-                with feedback_col1:
-                    if st.button("✅ Expected", use_container_width=True, type="secondary",
-                                 key=f"expected_btn_{hash(text_input[:50])}"):
-                        try:
-                            fb_success, fb_message = feedback_manager.save_feedback(
-                                text_input, selected_domain, crit, p_value, 'expected'
-                            )
-                            if fb_success:
-                                st.session_state[_fb_key] = True
-                                st.toast("Thank you for your feedback!", icon="✅")
-                            else:
-                                st.error(f"Failed to save feedback: {fb_message}")
-                        except Exception as e:
-                            st.error(f"Failed to save feedback: {str(e)}")
-
-                with feedback_col2:
-                    if st.button("❌ Unexpected", use_container_width=True, type="secondary",
-                                 key=f"unexpected_btn_{hash(text_input[:50])}"):
-                        try:
-                            fb_success, fb_message = feedback_manager.save_feedback(
-                                text_input, selected_domain, crit, p_value, 'unexpected'
-                            )
-                            if fb_success:
-                                st.session_state[_fb_key] = True
-                                st.toast("Feedback recorded! This will help us improve.", icon="📝")
-                            else:
-                                st.error(f"Failed to save feedback: {fb_message}")
-                        except Exception as e:
-                            st.error(f"Failed to save feedback: {str(e)}")
-            else:
-                st.caption("✅ Feedback submitted — thank you!")
-            # =============================================
 
             # Show detailed results
             with result_placeholder:
@@ -464,6 +404,71 @@ if detect_clicked:
             st.error(f"❌ Error during detection: {str(e)}")
             st.exception(e)
 
+# -----------------
+# Feedback UI (outside if detect_clicked — persists across all reruns via session_state)
+# -----------------
+if st.session_state.last_detection is not None and not st.session_state.feedback_given:
+    _ld = st.session_state.last_detection
+    st.markdown(
+        """
+        <style>
+        .fb-header { display: flex; align-items: center; gap: 0.4rem; margin-bottom: 0.3rem; }
+        .privacy-tip {
+            position: relative; display: inline-block;
+            cursor: help; color: #9ca3af; font-size: 0.9rem;
+        }
+        .privacy-tip .tip-text {
+            visibility: hidden; opacity: 0;
+            width: 240px; background-color: #374151; color: #f9fafb;
+            text-align: left; border-radius: 6px;
+            padding: 0.5rem 0.7rem; font-size: 0.78rem; line-height: 1.4;
+            position: absolute; z-index: 100;
+            bottom: 130%; left: 50%; transform: translateX(-50%);
+            transition: opacity 0.25s ease; pointer-events: none;
+        }
+        .privacy-tip:hover .tip-text { visibility: visible; opacity: 1; }
+        </style>
+        <div class="fb-header">
+          <strong>📝 Result Feedback</strong>: Does this detection result meet your expectations?
+          <span class="privacy-tip">🔒
+            <span class="tip-text">🔒 Your feedback is stored privately and will never be shared with third parties. It is used solely to improve detection accuracy.</span>
+          </span>
+        </div>
+        """,
+        unsafe_allow_html=True
+    )
+    feedback_col1, feedback_col2 = st.columns(2)
+    with feedback_col1:
+        if st.button("✅ Expected", use_container_width=True, type="secondary",
+                     key="expected_btn"):
+            try:
+                fb_success, fb_message = feedback_manager.save_feedback(
+                    _ld['text'], _ld['domain'], _ld['statistics'], _ld['p_value'], 'expected'
+                )
+                if fb_success:
+                    st.session_state.feedback_given = True
+                    st.session_state.pending_toast = ("Thank you for your feedback!", "✅")
+                    st.rerun()
+                else:
+                    st.error(f"Failed to save feedback: {fb_message}")
+            except Exception as e:
+                st.error(f"Failed to save feedback: {str(e)}")
+    with feedback_col2:
+        if st.button("❌ Unexpected", use_container_width=True, type="secondary",
+                     key="unexpected_btn"):
+            try:
+                fb_success, fb_message = feedback_manager.save_feedback(
+                    _ld['text'], _ld['domain'], _ld['statistics'], _ld['p_value'], 'unexpected'
+                )
+                if fb_success:
+                    st.session_state.feedback_given = True
+                    st.session_state.pending_toast = ("Feedback recorded! This will help us improve.", "📝")
+                    st.rerun()
+                else:
+                    st.error(f"Failed to save feedback: {fb_message}")
+            except Exception as e:
+                st.error(f"Failed to save feedback: {str(e)}")
+
 # with st.expander("📋 Citation"):
 #     st.markdown(
 #         """