Updates

modules/number_system/grouping_techniques.py

@@ -9,7 +9,6 @@ def generate_question():
     # Choose a random base to convert from, either 2, 8, or 16
     from_base = random.choice([2, 8, 16])
     to_base = 8 if from_base == 2 else 2 if from_base == 8 else 2
-    number = ''
 
     if from_base == 2:
         # Generate a random binary number, optionally with a fractional part
@@ -64,9 +63,16 @@ def generate_question():
     correct_answer = group_conversion(number, from_base, to_base)
     options = {correct_answer}
 
-    # Generate incorrect answers ensuring they are unique
+    # Generate incorrect answers ensuring they are unique and valid
     while len(options) < 4:
-        invalid_number = group_conversion(''.join(random.choice('0123456789ABCDEF') for _ in range(len(correct_answer))), from_base, to_base)
+        if to_base == 8:
+            invalid_number = ''.join(random.choice('01234567') for _ in range(len(correct_answer.replace('.', ''))))
+        elif to_base == 16:
+            invalid_number = ''.join(random.choice('0123456789ABCDEF') for _ in range(len(correct_answer.replace('.', ''))))
+        else:
+            invalid_number = ''.join(random.choice('01') for _ in range(len(correct_answer.replace('.', ''))))
+        
+        invalid_number = group_conversion(invalid_number, from_base, to_base)
         options.add(invalid_number)
 
     options = list(options)

modules/number_system/negative_binary.py

@@ -1,3 +1,5 @@
+# modules/number_system/negative_binary.py
+
 import random
 
 title = "Negative Binary Numbers"
@@ -33,14 +35,15 @@ def generate_question():
     correct_decimal = calculate_negative_binary(number)
     correct_binary = decimal_to_binary(correct_decimal, num_bits)
     
-    options = [correct_decimal]
+    options = {correct_decimal}  # Using a set to ensure unique options
     
     # Generate incorrect answers
     while len(options) < 4:
         random_decimal = random.randint(-2**(num_bits-1), 2**(num_bits-1)-1)
         if random_decimal != correct_decimal:
-            options.append(random_decimal)
+            options.add(random_decimal)  # Add to the set to avoid duplicates
     
+    options = list(options)  # Convert the set to a list
     random.shuffle(options)
     
     question = f"What is the decimal value of the signed {num_bits}-bit binary number {number}?"