repo stringclasses 21
values | pull_number float64 45 194k | instance_id stringlengths 16 34 | issue_numbers stringlengths 6 27 | base_commit stringlengths 40 40 | patch stringlengths 263 270k | test_patch stringlengths 312 408k | problem_statement stringlengths 38 47.6k | hints_text stringlengths 1 257k ⌀ | created_at stringdate 2016-01-11 17:37:29 2024-10-18 14:52:41 | language stringclasses 4
values | Dockerfile stringclasses 279
values | P2P stringlengths 2 10.2M | F2P stringlengths 11 38.9k | F2F stringclasses 86
values | test_command stringlengths 27 11.4k | task_category stringclasses 5
values | is_no_nodes bool 2
classes | is_func_only bool 2
classes | is_class_only bool 2
classes | is_mixed bool 2
classes | num_func_changes int64 0 238 | num_class_changes int64 0 70 | num_nodes int64 0 264 | is_single_func bool 2
classes | is_single_class bool 2
classes | modified_nodes stringlengths 2 42.2k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
serverless/serverless | 5,865 | serverless__serverless-5865 | ['5858'] | 9538caf08946e576142e24be9706d385a83b51f4 | diff --git a/lib/plugins/aws/lib/naming.js b/lib/plugins/aws/lib/naming.js
index 21631aa63d8..31f1efd772c 100644
--- a/lib/plugins/aws/lib/naming.js
+++ b/lib/plugins/aws/lib/naming.js
@@ -181,7 +181,12 @@ module.exports = {
},
getNormalizedWebsocketsRouteKey(route) {
- return route.replace('$', 'S');
+ r... | diff --git a/lib/plugins/aws/lib/naming.test.js b/lib/plugins/aws/lib/naming.test.js
index 643981306a9..8395f8a1773 100644
--- a/lib/plugins/aws/lib/naming.test.js
+++ b/lib/plugins/aws/lib/naming.test.js
@@ -259,6 +259,18 @@ describe('#naming()', () => {
it('should return a normalized version of the route key', (... | Allow non-alphanumeric characters for websocket routes
# Allow non-alphanumeric characters for websocket routes
## Description
When deploying a websocket route, you will get an error, if you use a non-alphanumeric name for the route. This is more restrictive than what APIGateway allows.
I couldn't find a docum... | null | 2019-02-25 13:27:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#naming() #getScheduleId() should add the standard suffix', '#naming() #getNormalizedFunctionName() should normalize the given functionName with a dash', '#naming() #getWebsocketsIntegrationLogicalId() should return the integrations logical id', '#naming() #getPolicyName() should use the stage and service name', '#na... | ['#naming() #getNormalizedWebsocketsRouteKey() should return a normalized version of the route key'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/naming.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/lib/naming.js->program->method_definition:getNormalizedWebsocketsRouteKey"] |
serverless/serverless | 5,860 | serverless__serverless-5860 | ['3495'] | a4b87a1c50599151a28c0286ede775ecbe1673ae | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 9a3ae2266e3..ecdfe09ed48 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -28,6 +28,8 @@ provider:
memorySize: 512 # optional, in MB, default is 1024
timeout: 10 # opti... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index 389204db18d..722285ba24e 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -1286,6 +1286,267 @@ describ... | Add support for AWS x-ray on AWS Lambda
AWS has added support for `X-ray` on `Lambda`: https://aws.amazon.com/blogs/aws/aws-x-ray-update-general-availability-including-lambda-integration/
would be a nice feature the enable that support from within the `serverless.yml` file by allowing to set the required `enable act... | Not sure if it can be set via CloudFormation. But using the api/cli the option is called `tracingConfig` and has two options `Active` or `PassThrough`
http://docs.aws.amazon.com/lambda/latest/dg/API_TracingConfig.html
Unfortunately,CloudFormation not support X-ray on Lambda for now yet...
http://docs.aws.amazon.com/A... | 2019-02-21 14:00:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() when using onError config should reject if config is provided as a number', 'AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', 'AwsCompileFunctions #compileFunctions() should add an ARN function role', '... | ['AwsCompileFunctions #compileFunctions() when using tracing config should prefer a function tracing config over a provider config', 'AwsCompileFunctions #compileFunctions() when using tracing config should use a the provider wide tracing config if provided', 'AwsCompileFunctions #compileFunctions() when using tracing ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 5,842 | serverless__serverless-5842 | ['5838'] | 838ab11c16cba1689eff32448cb40bb81582af20 | diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md
index 677e6c68144..71a846240b9 100644
--- a/docs/providers/aws/guide/variables.md
+++ b/docs/providers/aws/guide/variables.md
@@ -274,6 +274,37 @@ custom:
In this example, the serverless variable will contain the decrypted val... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index f49356cc1b5..e0df9382ef1 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -1956,7 +1956,51 @@ module.exports = {
})
.finally(() => ssmStub.restore());
});
-
+ describe('Referencing... | Secrets manager JSON not accessible
The documentation does not show how to access secrets from aws secrets manager stored in JSON. Is there an ETA to add this ability? If you have many secrets its very cost prohibitive to have 1 secret to 1 plain text value.
| @claygorman
[${ssm} is a syntax to refer AWS Systems Manager Parameter Store](https://serverless.com/framework/docs/providers/aws/guide/variables/#reference-variables-using-the-ssm-parameter-store).
Parameter Store supports [String, StringList and SecureString](https://docs.aws.amazon.com/ja_jp/systems-manager/lates... | 2019-02-17 08:18:30+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #prepopulateService dependent service rejections should reject CloudFormation variables in profile values', 'Variables #prepopulateService basic population tests should populate variables in profile values', 'Variables fallback should fallback if ${opt} syntax fail to populate but fallback is provided', 'Va... | ['Variables #getValueFromSsm() Referencing to AWS SecretsManager should parse value as json if returned value is json-like'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromSsm"] |
serverless/serverless | 5,840 | serverless__serverless-5840 | ['5772'] | 838ab11c16cba1689eff32448cb40bb81582af20 | diff --git a/docs/providers/aws/guide/packaging.md b/docs/providers/aws/guide/packaging.md
index 62ff61611ef..46bb8955651 100644
--- a/docs/providers/aws/guide/packaging.md
+++ b/docs/providers/aws/guide/packaging.md
@@ -43,6 +43,17 @@ Serverless will run the glob patterns in order.
At first it will apply the globs de... | diff --git a/lib/plugins/package/lib/packageService.test.js b/lib/plugins/package/lib/packageService.test.js
index c483d1b0342..9747566c7ef 100644
--- a/lib/plugins/package/lib/packageService.test.js
+++ b/lib/plugins/package/lib/packageService.test.js
@@ -7,6 +7,7 @@ const chai = require('chai');
const sinon = requir... | serverless.js files not packaged even if it isn't the config file being used
# This is a Bug Report
## Description
* What went wrong?
If I have a folder named `serverless` and a js file named `serverless.js`. The JS file won't be packed and there is no warnings.
* What did you expect should have happened?
The ... | This isn't because the files are of the same name (after ignoring extensions). It's that `serverless.js` is a valid configuraiton file for serverless, and as such, is [ignored by the default ignore patterns](https://github.com/serverless/serverless/blob/master/lib/plugins/package/lib/packageService.js#L18) (just as `se... | 2019-02-16 20:06:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#packageService() #getIncludes() should merge package and func includes', '#packageService() #getIncludes() should return an empty array if no includes are provided', '#packageService() #getIncludes() should merge package includes'] | ['#getServerlessConfigFile() should throw an error, if serverless.js export not a plain object', '#getServerlessConfigFile() should look in the current working directory if servicePath is undefined', '#getServerlessConfigFile() should return the resolved value if a promise-using serverless.js file found', '#getServerle... | ['#packageService() #packageService() should package single functions individually if package artifact specified', '#packageService() #packageService() should not package functions if package artifact specified', '#packageService() #packageService() should package functions individually', '#packageService() #packageSer... | . /usr/local/nvm/nvm.sh && npx mocha lib/utils/getServerlessConfigFile.test.js lib/plugins/package/lib/packageService.test.js --reporter json | Bug Fix | false | true | false | false | 5 | 0 | 5 | false | false | ["lib/plugins/package/lib/packageService.js->program->method_definition:getExcludes", "lib/plugins/package/lib/packageService.js->program->method_definition:resolveFilePathsLayer", "lib/plugins/package/lib/packageService.js->program->method_definition:resolveFilePathsFunction", "lib/classes/PluginManager.js->program->c... |
serverless/serverless | 5,835 | serverless__serverless-5835 | ['5834'] | 0688c4f248af7f8e306994af9da80f2a099b14fc | diff --git a/lib/plugins/aws/invokeLocal/index.js b/lib/plugins/aws/invokeLocal/index.js
index 91332030deb..bf32955ca42 100644
--- a/lib/plugins/aws/invokeLocal/index.js
+++ b/lib/plugins/aws/invokeLocal/index.js
@@ -329,6 +329,7 @@ class AwsInvokeLocal {
errorResult = {
errorMessage: err.message,
... | diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js
index 4bd83d751b1..c8bba83f4bf 100644
--- a/lib/plugins/aws/invokeLocal/index.test.js
+++ b/lib/plugins/aws/invokeLocal/index.test.js
@@ -582,8 +582,11 @@ describe('AwsInvokeLocal', () => {
awsInvokeLocal.invokeL... | AWS Invoke Local handleError function does not return stack trace, just errorMessage and errorType
# This is a Bug Report
## Description
When using the `invoke local` command with an AWS Serverless project, when you get an error there is no stack trace.
**What does happen:**
```
$ node_modules/.bin/serverl... | null | 2019-02-14 12:43:14+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ["AwsInvokeLocal #invokeLocalNodeJs promise by callback method even if callback isn't called syncronously should succeed once if succeed if by callback", 'AwsInvokeLocal #constructor() should set an empty options object if no options are given', 'AwsInvokeLocal #invokeLocalNodeJs promise should exit with error exit cod... | ['AwsInvokeLocal #invokeLocalNodeJs should log Error instance when called back'] | ['AwsInvokeLocal #extendedValidate() should skip parsing context if "raw" requested', 'AwsInvokeLocal #extendedValidate() it should parse file if relative file path is provided', 'AwsInvokeLocal #extendedValidate() should resolve if path is not given', 'AwsInvokeLocal #extendedValidate() should parse context if it is a... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:invokeLocalNodeJs->function_declaration:handleError"] |
serverless/serverless | 5,809 | serverless__serverless-5809 | ['5807'] | 6a4dc2b68ed7b892a7cd7cac2bec73386fef31fe | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 6d81ab4bfdc..ef1b4f829b6 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -785,7 +785,7 @@ class Variables {
index = this.deep.push(variable) - 1;
}
const variableContainer = variable.match(this.variableSyntax... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index e6e3dfdb1d4..f49356cc1b5 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -945,6 +945,23 @@ module.exports = {
return serverless.variables.populateObject(service.custom)
.should.beco... | Default values don't work in variables within ${file}
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/serverless/serverl... | null | 2019-02-07 22:58:45+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #prepopulateService dependent service rejections should reject CloudFormation variables in profile values', 'Variables #prepopulateService basic population tests should populate variables in profile values', 'Variables fallback should fallback if ${opt} syntax fail to populate but fallback is provided', 'Va... | ['Variables #populateObject() significant variable usage corner cases file reading cases should still work with a default file name in double or single quotes'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:makeDeepVariable"] |
serverless/serverless | 5,799 | serverless__serverless-5799 | ['5769'] | 3b9957f0725ac7ebf48d60e1c14d0cba096aa57c | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index aa52ac7a246..6d81ab4bfdc 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -791,7 +791,8 @@ class Variables {
.replace(variableString, `deep:${index}`);
}
appendDeepVariable(variable, subProperty) {
- return `${... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 97f8a527b13..e6e3dfdb1d4 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -835,6 +835,23 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shou... | Custom variableSyntax with file variable resolution fails (${{deep:0})
# This is a Bug Report
## Description
* What went wrong?
Custom variable syntax and file variable resolutions results in faulty variables containing ${{deep:0...}
* What did you expect should have happened?
I expected the template using a cus... | Thanks for the CC, sorry you're experiencing this issue!
Happening for me as well.
```
custom:
bucket: "content-storage-${self:provider.stage}"
```
The issue seems to be with the stage variable I am using.
Actually, I just removed the variable syntax key and my problem vanished. This key was part of the te... | 2019-02-06 01:15:49+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #prepopulateService dependent service rejections should reject CloudFormation variables in profile values', 'Variables #prepopulateService basic population tests should populate variables in profile values', 'Variables fallback should fallback if ${opt} syntax fail to populate but fallback is provided', 'Va... | ['Variables #populateObject() significant variable usage corner cases should handle deep variable continuations regardless of custom variableSyntax'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:appendDeepVariable"] |
serverless/serverless | 5,785 | serverless__serverless-5785 | ['5780'] | 398a92afb5edf60f7c8e0f4cf33ab1be13db0263 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js
index 5e90313a4ec..147f91f9b6e 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js
@@ -18,... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
index 2c04595b17e..a51eac76d46 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/... | Access-Control-Allow-Origin set to undefined when using single origin
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/se... | null | 2019-02-04 10:27:55+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() should process request parameters for HTTP_PROXY integration', '#validate() throw error if authorizer property is not a string or object',... | ['#validate() should merge all preflight cors options for a path', '#compileCors() should create preflight method for CORS enabled resource'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate", "lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js->program->method_definition:compileCors", "lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js->program->method_definition:generateCorsInteg... |
serverless/serverless | 5,775 | serverless__serverless-5775 | ['5398'] | 8c53de83bf62a4e1f66821e0321abb996880b5bd | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index b5f6f406f37..aa52ac7a246 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -294,7 +294,7 @@ class Variables {
this.variableSyntax,
(context, contents) => contents.trim()
);
- if (!cleaned.match(/".*"/)) {
... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index a90b7c2bf56..97f8a527b13 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -786,7 +786,7 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shoul... | Fallback value for unset variable is removing spaces
# This is a Bug Report
## Description
For bug reports:
* What went wrong?
Given the following variable fallback:
```yaml
events:
- schedule: ${env:SCHEDULE, 'rate(2 hours)'}
```
If env `SCHEDULE` is not set I got this error when I run `sls depl... | The culprit:
https://github.com/serverless/serverless/blob/33b7784bad10347767d447dd1c650e0d90931d49/lib/classes/Variables.js#L267-L271
If I just remove `.replace(/\s/g, '')` at line 71 and run tests nothing is broken but I'm afraid that this could have some side effect that tests are not covering?
Can I open a P... | 2019-02-02 13:51:45+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #prepopulateService dependent service rejections should reject CloudFormation variables in profile values', 'Variables #prepopulateService basic population tests should populate variables in profile values', 'Variables fallback should fallback if ${opt} syntax fail to populate but fallback is provided', 'Va... | ['Variables #populateObject() significant variable usage corner cases should preserve whitespace in single-quote literal fallback'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:cleanVariable"] |
serverless/serverless | 5,758 | serverless__serverless-5758 | ['5756'] | eef96aaede1cf929ae5f30d368f42eab64717fcb | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index c65866f3bdc..0d34e0f8884 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -451,14 +451,19 @@ class Variables {
* in the given variable strings string.
*/
overwrite(variableStrings, variableMatch, propertyString) {
... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index f8af35f59b2..46c3ffa3b01 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -124,6 +124,137 @@ describe('Variables', () => {
});
});
});
+
+ describe('fallback', () => {
+ it('should ... | AWS: Default value is not supported in ${s3}
# This is a Bug Report
## Description
* What went wrong
* Serverless throws error instead of using fallback if `${s3}` variables syntax can not retrieve value from AWS.
* What did you expect should have happened?
* Fallback value should be used as same as ... | null | 2019-01-27 08:15:39+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables fallback should fallback if ${opt} syntax fail to populate but fallback is provided', 'Variables fallback file syntax should fallback if file exists but given key not found and fallback is provided', 'Variables #populateObject() significant variable usage corner cases should handle deep variables regardless... | ['Variables fallback aws-specific syntax should fallback if ${s3} syntax fail to populate but fallback is provided', 'Variables fallback aws-specific syntax should fallback if ${cf} syntax fail to populate but fallback is provided'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:overwrite"] |
serverless/serverless | 5,739 | serverless__serverless-5739 | ['5673'] | 8502433b9b44afba66f9f0b40cbbec9709889ca7 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index 0db9baf44dd..a5ff03a0220 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -212,7 +212,7 @@ class AwsProvider {
*/
request(service, method, params, options) {
... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index 48fc28b2d32..fa297e435a7 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -362,6 +362,7 @@ describe('AwsProvider', () => {
expect(awsPr... | Setting --profile or --aws-profile keeps stack from getting deployed from version 1.36.0
# This is a Bug Report
## Description
* What went wrong?
Using `serverless deploy --aws-profile xyz` or `serverless deploy --profile xyz` keeps stack from getting deployed in version **1.36.0**. (works in version 1.35.1)
... | Just want to add I'm having the same issue in **1.36.1**
Want to add I am having the same issue with 1.36.1
I am having the same issue, spending the whole day yesterday thinking there was something wrong in my code | 2019-01-23 07:05:21+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload', 'AwsProvider #getProfile() should use provider in lieu of options and config', 'AwsProvider #getCredentials() should ... | ['AwsProvider #request() using the request cache STS tokens should retain reference to STS tokens when updated via SDK'] | ['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv... | . /usr/local/nvm/nvm.sh && npx mocha tests/utils/index.js lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"] |
serverless/serverless | 5,728 | serverless__serverless-5728 | ['5676'] | 253b651539bb979b880bd12b3c0d0a43a0c58b30 | diff --git a/lib/Serverless.js b/lib/Serverless.js
index b501a8fa733..3fbd527fd4b 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -81,6 +81,7 @@ class Serverless {
if (this.cli.displayHelp(this.processedInput)) {
return BbPromise.resolve();
}
+ this.cli.suppressLogIfPrintCommand(this.proce... | diff --git a/lib/classes/CLI.test.js b/lib/classes/CLI.test.js
index ac966027964..f99ea3228da 100644
--- a/lib/classes/CLI.test.js
+++ b/lib/classes/CLI.test.js
@@ -72,6 +72,86 @@ describe('CLI', () => {
});
});
+ describe('#suppressLogIfPrintCommand()', () => {
+ let logStub;
+ let consoleLogStub;
+
+... | 'sls print' contains Warnings.
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIB... | null | 2019-01-20 07:17:33+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['CLI #processedInput() should not parse numeric string as number, but as string', 'CLI #displayHelp() should return true when the "--version" parameter is given', 'CLI #displayHelp() should return true when no command is given', 'CLI #processInput() should not pass base64 values as options', 'CLI Integration tests sho... | ['CLI #suppressLogIfPrintCommand() should do nothing when "print" is given with "-h"', 'CLI #suppressLogIfPrintCommand() should do nothing when "print" is combined with other command.', 'CLI #suppressLogIfPrintCommand() should do nothing when no command is given', 'CLI #suppressLogIfPrintCommand() should suppress log w... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/CLI.test.js --reporter json | Bug Fix | false | false | false | true | 2 | 1 | 3 | false | false | ["lib/classes/CLI.js->program->class_declaration:CLI", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:suppressLogIfPrintCommand", "lib/Serverless.js->program->class_declaration:Serverless->method_definition:run"] |
serverless/serverless | 5,723 | serverless__serverless-5723 | ['5717'] | d817ce08d41c8a2554da8c819cfeaef04a886df6 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 940b44b4f1c..c65866f3bdc 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -815,8 +815,10 @@ class Variables {
} else if (variableString.match(this.ssmRefSyntax)) {
varType = 'SSM parameter';
}
- log... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 456d6187d48..f8af35f59b2 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -1854,6 +1854,21 @@ module.exports = {
varProxy.warnIfNotFound('self:service', 'a-valid-value');
expect(logWarningSpy)... | A valid undefined to satisfy the declaration
Serverless allows for default variable references, e.g.
${self:custom.site.FOO, self:custom.common.FOO}
But SLS complains "A valid undefined to satisfy the declaration" when variables don't appear in the first dict, even though they are correctly resolved by the s... | https://github.com/serverless/serverless/blob/d817ce08d41c8a2554da8c819cfeaef04a886df6/lib/classes/Variables.js#L818-L819
In severless 1.36.1, The message is shown when right-side default value (`self:custom.common.FOO` for this time) is null, undefined or empty plain object.
`${varType}` in the message is the in... | 2019-01-18 22:15:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in the... | ['Variables #warnIfNotFound() when variable string does not match any of syntax should do nothing if variable has undefined value.', 'Variables #warnIfNotFound() when variable string does not match any of syntax should do nothing if variable has empty object value.', 'Variables #warnIfNotFound() when variable string do... | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:warnIfNotFound"] |
serverless/serverless | 5,694 | serverless__serverless-5694 | ['5685'] | 3bfcd0ae206434879720c603a2b5d0066ad50993 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index cb68ddcd898..099007f004b 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -223,6 +223,7 @@ class AwsProvider {
* @param {Object} params - Parameters
* @param ... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index d3ce0ee9227..b39f46119fd 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -565,6 +565,50 @@ describe('AwsProvider', () => {
});
... | AWS Cross Region Request incorrectly cached during variables
# This is a Bug Report
## Description
* What went wrong?
Cross Region requests for cloudformation output values are not retrieved when stackNames are identical. Both variables are ending up with the same values.
* What did you expect should have hap... | null | 2019-01-13 13:28:48+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #constructor() certificate authority - file should set AWS ca and cafile', 'AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'AwsProvider #constructor() deploymentBucket configuration should do nothing if not defined', 'AwsProvider #getStage() shou... | ['AwsProvider #request() using the request cache should request if same service, method and params but different region in option'] | ['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | false | false | true | 1 | 1 | 2 | false | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider"] |
serverless/serverless | 5,688 | serverless__serverless-5688 | ['5681'] | 07154d772f14da7e7e3c985f412099670a53b0a7 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 8e5d72d8a55..13a17d99880 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -6,6 +6,8 @@ const _ = require('lodash');
const BbPromise = require('bluebird');
const semver = require('semver');
+const validAPIGatewayStageNamePattern = ... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 22b9069201f..29b36566891 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -763,6 +763,141 @@ describe('Service', () => {
expect(consoleLogStub.callCount).to.equal(2);
});
});
+
+ describe('s... | Issue with awsProvider.js : "Cannot use 'in' operator to search for '0'"
# This is a Bug Report
## Description
* What went wrong?
I'm deploying a package with the command "serverless deploy -v --stage cicd" with CodeBuild and I'm getting the error message below. I don't have much more information to give since... | same here, also occurs if the functions are in the same file but in a _different object_ like:
```
service: foo
...
functions: ${self:custom.lambdaFunctions}
custom:
lambdaFunctions:
bar:
handler: ...
```
edit: only occurs in `v1.36.0` @dschep, downgrading to `v1.35.1` fixes this issue.
> edit... | 2019-01-12 11:27:11+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #validate() stage name validation should not throw an error after variable population if http event is present and\n the populated stage contains only alphanumeric, underscore and hyphen', 'Service #update() should update service instance data', 'Variables #populateObject() significant variable usa... | ['Service #validate() stage name validation should throw an error after variable population\n if http event is present and stage contains hyphen', 'Service #validate() stage name validation should throw an error if http event is present and stage contains invalid chars'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:prepopulateService", "lib/classes/Service.js->program->class_declaration:Service->method_definition:validate"] |
serverless/serverless | 5,686 | serverless__serverless-5686 | ['5655'] | 3bfcd0ae206434879720c603a2b5d0066ad50993 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 764ed2a006e..ad13e3c422d 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -10,6 +10,8 @@ const fse = require('../utils/fs/fse');
const logWarning = require('./Error').logWarning;
const PromiseTracker = require('./PromiseTrac... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index e486855ed64..eb69f8a624f 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -207,6 +207,113 @@ describe('Variables', () => {
});
});
});
+ describe('stage name validation', () => {
+ ... | If stage name is a variable then you can not create an http binding
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/serv... | Hmm. That's odd. I'm not able to reproduce this issue. Could you share a full `serverless.yml` that causes the issue for me to try?
Here's the `serverless.yml` I used:
```yaml
service: sls-5655 # NOTE: update this with your service name
custom:
stage: custom-stage
provider:
name: aws
runtime: nodejs8.10... | 2019-01-11 23:17:11+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload', 'AwsProvider #getCredentials() should not set credentials if credentials has empty string values', 'Variables #popula... | ['Variables #prepopulateService stage name validation should throw an error after variable population\n if http event is present and stage contains hyphen', "AwsProvider #constructor() stage name validation should not throw an error before variable population \n even if http event is present and s... | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:prepopulateService", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:constructor"] |
serverless/serverless | 5,662 | serverless__serverless-5662 | ['5661'] | 223ccb1e22c9147c94979a275907830d7b267a6d | diff --git a/lib/plugins/aws/invokeLocal/index.js b/lib/plugins/aws/invokeLocal/index.js
index 51547b2a8ea..1d5adaf2305 100644
--- a/lib/plugins/aws/invokeLocal/index.js
+++ b/lib/plugins/aws/invokeLocal/index.js
@@ -111,6 +111,12 @@ class AwsInvokeLocal {
NODE_PATH: '/var/runtime:/var/task:/var/runtime/node_mod... | diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js
index df39eb7faed..4bd83d751b1 100644
--- a/lib/plugins/aws/invokeLocal/index.test.js
+++ b/lib/plugins/aws/invokeLocal/index.test.js
@@ -24,6 +24,7 @@ describe('AwsInvokeLocal', () => {
let serverless;
let provider... | AWS_PROFILE not exported to environment for invoke local
# This is a Feature Proposal (Arguably a bug report)
## Description
I would very much like it if `AWS_PROFILE` behaved like `AWS_REGION` for `invoke local`. The fact that region is supplied from my configuration is nice and expected, and it is surprising an... | null | 2019-01-08 11:51:04+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ["AwsInvokeLocal #invokeLocalNodeJs promise by callback method even if callback isn't called syncronously should succeed once if succeed if by callback", 'AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option... | ['AwsProvider #getProfile() should prefer options over config or provider', 'AwsProvider #getProfile() should use provider in lieu of options and config', 'AwsProvider #getProfile() should prefer config over provider in lieu of options', 'AwsInvokeLocal #loadEnvVars() it should load provider profile env'] | ['AwsInvokeLocal #extendedValidate() should skip parsing context if "raw" requested', 'AwsProvider #constructor() should have no AWS logger', 'AwsInvokeLocal #extendedValidate() it should parse file if relative file path is provided', 'AwsInvokeLocal #extendedValidate() should resolve if path is not given', 'AwsProvide... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json | Feature | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:getProfileSourceValue", "lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:loadEnvVars"... |
serverless/serverless | 5,650 | serverless__serverless-5650 | ['5606'] | cfd6c621ccf491b3a4a4202719cfc9a02f4d0741 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index 1b4cc8655e1..cb68ddcd898 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -226,7 +226,7 @@ class AwsProvider {
*/
request(service, method, params, options) {
... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index c2952fe88e4..d3ce0ee9227 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -324,6 +324,7 @@ describe('AwsProvider', () => {
},
... | AWS: Extend ${cf} syntax to get output from another region broken
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/server... | Hey, @smartinspereira any news about it? The same thing happens to me as well.
Sorry, been overwhelmed without time to check this out. @exoego, any chance you have any input since you implemented this feature?
@efimk-lu unfortunately nothing new, but i also did not test this using 1.35.1 again.
We've been testing it wi... | 2019-01-04 12:14:53+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #constructor() certificate authority - file should set AWS ca and cafile', 'AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'AwsProvider #constructor() deploymentBucket configuration should do nothing if not defined', 'AwsProvider #getStage() shou... | ['AwsProvider #request() should request to the specified region if region in options set'] | ['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"] |
serverless/serverless | 5,640 | serverless__serverless-5640 | ['4959'] | 660804d4a6e471825e291a26413bbbf2cb365dc9 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index f508aa038b8..7bd1a2ed99a 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -21,7 +21,7 @@ class Service {
this.provider = {
stage: 'dev',
region: 'us-east-1',
- variableSyntax: '\\${([ ~:a-zA-Z0-9._@\'",\\-\\/\\... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 877e266ffd8..4358494e138 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -31,7 +31,7 @@ describe('Service', () => {
expect(serviceInstance.provider).to.deep.equal({
stage: 'dev',
region: '... | Asterisk in default variable value leads to value interpreted as string and not interpolated
```allowedOrigin: ${opt:allowedOrigin, 'beta.blabla.net'}```
works fine
```allowedOrigin: ${opt:allowedOrigin, '*.blabla.net'}```
doesnt work
in second case allowedOrigin will be interpreted as a string e.g. its value w... | It looks like the regex's used to match on the `${opt: this.that, 'def'}` pattern are not allowing the character `*`.
Are there any considerations in allowing/not allowing `*` in variable syntax?
I can take this issue if no one else has begun work. | 2018-12-31 15:53:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #validate() stage name validation should not throw an error after variable population if http event is present and\n the populated stage contains only alphanumeric, underscore and hyphen', 'Service #update() should update service instance data', 'Variables #prepopulateService basic population tests... | ['Service #constructor() should construct with defaults'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/print/print.test.js lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/print/print.js->program->class_declaration:Print->method_definition:adorn", "lib/classes/Service.js->program->class_declaration:Service->method_definition:constructor"] |
serverless/serverless | 5,639 | serverless__serverless-5639 | ['4737'] | 6c861055af46e95f0232a2eabf7d5d9d8e535fa3 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index 149828fc74b..1b4cc8655e1 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -19,6 +19,8 @@ const constants = {
providerName: 'aws',
};
+const validAPIGatewayStage... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index 8fe4e5958ff..c2952fe88e4 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -90,6 +90,54 @@ describe('AwsProvider', () => {
delete process.en... | Confusing error messages when creating stages with special characters
# This is a Bug Report
## Description
* What went wrong?
Confusing error messages when creating stages
sls deploy --stage local-bot
...
Serverless Error ---------------------------------------
An error occurred: Api... | Hi @benswinburne , thanks for bringing this up. It is indeed confusing.
The correct solution here would be to disallow hyphens `-` and underscores `_` from Serverless stage names or transform the underscore in the CF stack name to a hyphen, because
(1) CF stack names cannot contain underscores
(2) APIG stage nam... | 2018-12-30 13:56:28+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #constructor() certificate authority - file should set AWS ca and cafile', 'AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'AwsProvider #constructor() deploymentBucket configuration should do nothing if not defined', 'AwsProvider #getStage() shou... | ['AwsProvider #constructor() validation on construction should throw an error if stage contains hyphen and http events are present'] | ['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:constructor"] |
serverless/serverless | 5,638 | serverless__serverless-5638 | ['4414'] | 6c861055af46e95f0232a2eabf7d5d9d8e535fa3 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 293b4295447..4a16da7e303 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -208,6 +208,28 @@ class Service {
}
});
+ const warnOnDuplicateHandlers = () => {
+ const functionObjs = this.getAllFunctions()
+ .... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 57372ec8d1a..7f71031ce4d 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -9,6 +9,7 @@ const Service = require('../../lib/classes/Service');
const Utils = require('../../lib/classes/Utils');
const Serverless = re... | Print warning when 2 functions have same handler
# This is a Feature Proposal
## Description
Whenever I add a new ƛ I copy-paste last lines of code in `serverless.yml` file. Most of the time they are similar, so I just write a new handler and rename it (in `.yml`).
But omg, it's too damn often when I forget t... | True story! :+1:
Waiting for this feature!
Hey, @vladgolubev! Thank you for reporting this issue :+1:
I think that's a valid feature request :100:
Could you share the `serverless.yml` when you face the bizarre situation so that we can take a look into it?
The validation should be done when importing the serverl... | 2018-12-30 12:27:42+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #update() should update service instance data', 'Service #load() should resolve if no servicePath is found', 'Service #load() should support Serverless file with a .yml extension', 'Service #load() should load YAML in favor of JSON', 'Service #mergeArrays should merge resources given as an array', 'Service #c... | ['Service #validate() should warn if multiple functions have same handler'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Service.js->program->class_declaration:Service->method_definition:validate"] |
serverless/serverless | 5,635 | serverless__serverless-5635 | ['3306'] | 6c861055af46e95f0232a2eabf7d5d9d8e535fa3 | diff --git a/lib/plugins/aws/package/compile/events/schedule/index.js b/lib/plugins/aws/package/compile/events/schedule/index.js
index 42cd9f9978d..2639509ae02 100644
--- a/lib/plugins/aws/package/compile/events/schedule/index.js
+++ b/lib/plugins/aws/package/compile/events/schedule/index.js
@@ -2,6 +2,11 @@
const _... | diff --git a/lib/plugins/aws/package/compile/events/schedule/index.test.js b/lib/plugins/aws/package/compile/events/schedule/index.test.js
index af6a7d0befd..09745ef20fe 100644
--- a/lib/plugins/aws/package/compile/events/schedule/index.test.js
+++ b/lib/plugins/aws/package/compile/events/schedule/index.test.js
@@ -53,... | DX: Validate Cron Syntax Before Deploy & Improve Error Message
Cron is weird and not human friendly.
I'd love for the framework to validate my stupid human mistakes before I have to wait for the deploy to fail with a vague error message.
 should throw an error if schedule event type is not a string or an object', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect enabled variable, defaulting to true', 'AwsCompileScheduledEvents #compileScheduledEvents() should not create correspondin... | ['AwsCompileScheduledEvents #compileScheduledEvents() cron syntax validation: cron(* * * * * 2018) schedule string should throw an error if number of fields is greater than 6', 'AwsCompileScheduledEvents #compileScheduledEvents() cron syntax validation: cron(* * * * * 2018) schedule object should throw an error if numb... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/schedule/index.test.js --reporter json | Feature | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/plugins/aws/package/compile/events/schedule/index.js->program->class_declaration:AwsCompileScheduledEvents->method_definition:compileScheduledEvents", "lib/plugins/aws/package/compile/events/schedule/index.js->program->class_declaration:AwsCompileScheduledEvents", "lib/plugins/aws/package/compile/events/schedule/... |
serverless/serverless | 5,602 | serverless__serverless-5602 | ['5600'] | e53455a7433ec79843886eee1eacb9a8f67c84ce | diff --git a/lib/plugins/package/lib/packageService.js b/lib/plugins/package/lib/packageService.js
index 9f7bda935ec..47fc525c7a3 100644
--- a/lib/plugins/package/lib/packageService.js
+++ b/lib/plugins/package/lib/packageService.js
@@ -188,7 +188,7 @@ module.exports = {
params.include.forEach((pattern) => {
... | diff --git a/lib/plugins/package/lib/zipService.test.js b/lib/plugins/package/lib/zipService.test.js
index 39cedf31ff2..562663229aa 100644
--- a/lib/plugins/package/lib/zipService.test.js
+++ b/lib/plugins/package/lib/zipService.test.js
@@ -1012,6 +1012,30 @@ describe('zipService', () => {
});
});
+ it... | Parent paths no longer working for package inclusions/exclusions
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/serverl... | That's likely a regression caused by #5574. Any chance you could take a look at this @MacMcIrish? Would it be possible to have all the includes on [this line](https://github.com/MacMcIrish/serverless/blob/23c37b7543238e4a98ab605c2cf8146a3095bcce/lib/plugins/package/lib/packageService.js#L191) with out causing the perfo... | 2018-12-16 02:03:16+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['zipService #zip() should keep file permissions', 'zipService #zip() should zip a whole service (without include / exclude usage)', 'zipService #zip() should re-include files using include config', 'zipService #excludeDevDependencies() should resolve when opted out of dev dependency exclusion', 'zipService #zip() shou... | ['zipService #zip() should include files even if outside working dir'] | ['zipService #excludeDevDependencies() when dealing with Node.js runtimes should return excludes and includes if a exec Promise is rejected', 'zipService #excludeDevDependencies() when dealing with Node.js runtimes should fail silently and continue if "npm ls" call throws an error', 'zipService #excludeDevDependencies(... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/package/lib/zipService.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/package/lib/packageService.js->program->method_definition:resolveFilePathsFromPatterns"] |
serverless/serverless | 5,579 | serverless__serverless-5579 | ['5154'] | 8e79ada47b9d9d685d7395e31b427f4b0cc059db | diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md
index 88ab0f39f58..125887922bf 100644
--- a/docs/providers/aws/guide/variables.md
+++ b/docs/providers/aws/guide/variables.md
@@ -155,6 +155,45 @@ functions:
```
In that case, the framework will fetch the values of those `funct... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 2c65f39a4db..7a3f27cf91f 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -1521,6 +1521,37 @@ module.exports = {
.finally(() => cfStub.restore());
});
+ it('should get variable from Cloud... | ${cf} for another region
I have a serverless.yml that needs to reference the cloudformation output of another stack in another region. How can I solve this? This useful when using lambda@edge (which is only supported in us-east-1)
| null | 2018-12-08 11:56:09+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload', 'AwsProvider #getCredentials() should not set credentials if credentials has empty string values', 'Variables #popula... | ['AwsProvider #request() should request to the specified region if region in options set', 'Variables #getValueFromCf() should get variable from CloudFormation of different region'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json | Feature | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromCf", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:constructor"] |
serverless/serverless | 5,571 | serverless__serverless-5571 | ['5558'] | fa4ef1159a36355799bba0ace606d3625dd1c24e | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 6411f043f70..084f275a5bb 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -268,7 +268,7 @@ class Variables {
return match.replace(
this.variableSyntax,
(context, contents) => contents.trim()
- ).replace(/... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 19c68a8e324..2c65f39a4db 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -634,6 +634,16 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shou... | schedule from file with default value removes space
# This is a Bug Report
## Description
* What went wrong?
I ran `serverless deploy --stage custom`. The serverless.yml refers to files like `serverless.prod.config.json` depending on the stage name.
I have a variable schedule, it's running faster on acceptance ... | Confirmed in [dschep-bug-repos/sls-5558](https://github.com/dschep-bug-repos/sls-5558). Seems spaces are stripped from any literal defaults. That's not good 😢
See the workaround branch of that repo for a fix. The change for your service would be:
```yaml
custom:
defaultAppleReciptsToUpdateSchedule: rate(3 hours)... | 2018-12-06 12:38:58+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in the... | ['Variables #populateObject() significant variable usage corner cases should preserve whitespace in literal fallback'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:cleanVariable"] |
serverless/serverless | 5,566 | serverless__serverless-5566 | ['5402'] | a0e0b6652014cb18b2f4865221c397c17dd78d2e | diff --git a/lib/plugins/aws/package/compile/functions/index.js b/lib/plugins/aws/package/compile/functions/index.js
index 3d662abb740..25f2ba72b64 100644
--- a/lib/plugins/aws/package/compile/functions/index.js
+++ b/lib/plugins/aws/package/compile/functions/index.js
@@ -298,7 +298,7 @@ class AwsCompileFunctions {
... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index 82bc858f202..4569c0195b7 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -1929,6 +1929,47 @@ describe... | reservedConcurrency configuration is not persisting to the stack
# This is a Bug Report
## Description
A function's `reservedConcurrency` property is not being persisted to the CloudFormation template and therefore stack. See my function configuration below:
```yaml
functions:
functionName:
handler: b... | This just screwed up my production deploy... Where are the serverless maintainers... Is serverless being abandoned? | 2018-12-05 16:07:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() when using onError config should reject if config is provided as a number', 'AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', 'AwsCompileFunctions #compileFunctions() should add a "Fn::ImportValue" Obje... | ['AwsCompileFunctions #compileFunctions() should set function declared reserved concurrency limit even if it is zero'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 5,562 | serverless__serverless-5562 | ['5534'] | 510a01f3cd2a6c80c6cf8b8f839300cc977ff274 | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.js b/lib/plugins/aws/package/lib/mergeIamTemplates.js
index 0f28c782619..cb74e820d85 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.js
@@ -32,12 +32,13 @@ module.exports = {
};
i... | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
index 1a236a74311..49e6ea18ef6 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
@@ -296,20 +296,22 @@ describe('#mergeI... | Regression: Serverless 1.33 does not properly support integers as external values
# This is a Bug Report
## Description
* What went wrong?
A `logRetentionInDays should be an integer over 0` error interrupts deployment when the logRetentionInDays value is provided externally (in my case via a shell command)
* W... | Could you provide the relevant parts of your `serverless.yml` please?
```yml
service: "issue"
provider:
name: "aws"
stage: "dev"
logRetentionInDays: "${opt:logRetentionInDays, self:custom.defaultLogRetentionInDays}"
runtime: "nodejs8.10"
functions:
hello:
handler: "handler.hello"
events: []
... | 2018-12-05 11:06:38+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should not add the default role if all functions have an ARN role', '#mergeIamTemplates() should add managed policy arns', '#mergeIamTemplates() should add default role if one of the functions h... | ['#mergeIamTemplates() should add RetentionInDays to a CloudWatch LogGroup resource if logRetentionInDays is given'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/mergeIamTemplates.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:merge"] |
serverless/serverless | 5,531 | serverless__serverless-5531 | ['5357'] | 6c861055af46e95f0232a2eabf7d5d9d8e535fa3 | diff --git a/lib/plugins/aws/lib/naming.js b/lib/plugins/aws/lib/naming.js
index a343ca56637..e9ad3294bbe 100644
--- a/lib/plugins/aws/lib/naming.js
+++ b/lib/plugins/aws/lib/naming.js
@@ -321,9 +321,9 @@ module.exports = {
return `${this.getNormalizedFunctionName(functionName)}LambdaPermissionAlexaSmartHome${
... | diff --git a/lib/plugins/aws/lib/naming.test.js b/lib/plugins/aws/lib/naming.test.js
index 5c76568b3bd..3a67858c575 100644
--- a/lib/plugins/aws/lib/naming.test.js
+++ b/lib/plugins/aws/lib/naming.test.js
@@ -508,8 +508,8 @@ describe('#naming()', () => {
describe('#getLambdaCloudWatchLogPermissionLogicalId()', () =>... | The final policy size is bigger than the limit (20480)
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/... | I think being able to replace the auto-generated Lambda::Permission objects with a custom one that uses a wildcard would solve this issue. | 2018-11-28 13:09:05+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#naming() #getScheduleId() should add the standard suffix', '#naming() #getNormalizedFunctionName() should normalize the given functionName with a dash', '#naming() #getPolicyName() should use the stage and service name', '#naming() #normalizeName() should have no effect on the rest of the name', '#naming() #getNorma... | ['AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should create corresponding resources when cloudwatchLog events are given', 'AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should create a longest-common suffix of logGroup to minimize scope', 'AwsCompileCloudWatchLogEvents #compileCloudWatchLo... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/naming.test.js lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js --reporter json | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/plugins/aws/lib/naming.js->program->method_definition:getLambdaCloudWatchLogPermissionLogicalId", "lib/plugins/aws/package/compile/events/cloudWatchLog/index.js->program->class_declaration:AwsCompileCloudWatchLogEvents->method_definition:longestCommonSuffix", "lib/plugins/aws/package/compile/events/cloudWatchLog/... |
serverless/serverless | 5,525 | serverless__serverless-5525 | ['5522'] | dab98891d5b1c4390c8512577995459833392b72 | diff --git a/lib/plugins/aws/invokeLocal/fixture/asyncHandlerWithSuccess.js b/lib/plugins/aws/invokeLocal/fixture/asyncHandlerWithSuccess.js
index 188e7dd99e4..cc77b245772 100644
--- a/lib/plugins/aws/invokeLocal/fixture/asyncHandlerWithSuccess.js
+++ b/lib/plugins/aws/invokeLocal/fixture/asyncHandlerWithSuccess.js
@@ ... | diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js
index 74c2cdda5d6..40cacc1648a 100644
--- a/lib/plugins/aws/invokeLocal/index.test.js
+++ b/lib/plugins/aws/invokeLocal/index.test.js
@@ -433,6 +433,15 @@ describe('AwsInvokeLocal', () => {
serverless.cli.consoleLo... | SLS Invoke Local Exiting Too Soon
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONT... | null | 2018-11-27 14:54:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsInvokeLocal #invokeLocalNodeJs promise should exit with error exit code', 'AwsInvokeLocal #constructor() should set an empty options object if no options are given', 'AwsInvokeLocal #extendedValidate() it should parse file if absolute file path is provided', 'AwsInvokeLocal #constructor() should have hooks', 'AwsI... | ['AwsInvokeLocal #invokeLocalNodeJs with sync return value should succeed if succeed', "AwsInvokeLocal #invokeLocalNodeJs promise by callback method even if callback isn't called syncronously should succeed once if succeed if by callback"] | ['AwsInvokeLocal #extendedValidate() should skip parsing context if "raw" requested', 'AwsInvokeLocal #extendedValidate() it should parse file if relative file path is provided', 'AwsInvokeLocal #extendedValidate() should resolve if path is not given', 'AwsInvokeLocal #extendedValidate() should parse context if it is a... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js --reporter json | Bug Fix | false | true | false | false | 5 | 0 | 5 | false | false | ["lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:invokeLocalNodeJs->method_definition:fail", "lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:invokeLocalNodeJs->method_definition:succeed", "lib/plugins/aws/invokeLocal... |
serverless/serverless | 5,516 | serverless__serverless-5516 | ['5515'] | c6e02d8bd8f5aa6ad69d7d62e5c94f4c4597ad16 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index 536c8541206..9f1a919c1cb 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -315,7 +315,7 @@ class AwsProvider {
// add specified credentials, overriding with mo... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index cc31e3be66c..988b0a06a2c 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -743,6 +743,25 @@ describe('AwsProvider', () => {
expect(credenti... | CLI option aws-profile overriden by profile defined in serverless.yml
# This is a Bug Report
## Description
When a profile is defined in serverless, the `--aws-profile` option doesn't override it.
Let says I've that config:
```yml
provider:
name: aws
runtime: nodejs8.10
profile: default
r... | null | 2018-11-22 16:32:51+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #constructor() certificate authority - file should set AWS ca and cafile', 'AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'AwsProvider #constructor() deploymentBucket configuration should do nothing if not defined', 'AwsProvider #getStage() shou... | ['AwsProvider #getCredentials() should get credentials when profile is provied via --aws-profile option even if profile is defined in serverless.yml'] | ['AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProvider #getServerlessDeploymentBucketName() should return ... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:getCredentials"] |
serverless/serverless | 5,509 | serverless__serverless-5509 | ['5400'] | fbd9b46ef913d270f062b1c89d62ef3367342984 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 3449c6a836c..62f2f50e0ea 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -981,6 +981,7 @@ provider:
apiGateway:
restApiId: xxxxxxxxxx # REST API resource ID.... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js
index 98be9ee278e..a3354e05d09 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js
+++ b/lib/plugins/aws/package/compile/even... | Support API Gateway stage deployment description
# This is a Feature Proposal
## Description
Currently, [API Gateway deployment](https://github.com/serverless/serverless/blob/master/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.js#L14) only support **RestApiId** and **StageName** property.
I... | null | 2018-11-20 14:59:20+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileDeployment() should add service endpoint output'] | ['#compileDeployment() should create a deployment resource', '#compileDeployment() should create a deployment resource with description'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js --reporter json | Feature | false | false | false | true | 2 | 1 | 3 | false | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:getApiGatewayDescription", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider", "lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.js->program->method_definition:compileDeplo... |
serverless/serverless | 5,492 | serverless__serverless-5492 | ['5491'] | 319e3e5467c3dc3835c5ea5a605b6f20d99d72ff | diff --git a/lib/classes/CLI.js b/lib/classes/CLI.js
index f4db3010393..cf5972afce8 100644
--- a/lib/classes/CLI.js
+++ b/lib/classes/CLI.js
@@ -34,32 +34,43 @@ class CLI {
inputArray = process.argv.slice(2);
}
- const toBase64Helper = (value, index) => {
- if ((index % 2) !== 0) {
- return... | diff --git a/lib/classes/CLI.test.js b/lib/classes/CLI.test.js
index 112b8befaba..30237c50826 100644
--- a/lib/classes/CLI.test.js
+++ b/lib/classes/CLI.test.js
@@ -371,6 +371,29 @@ describe('CLI', () => {
expect(inputToBeProcessed).to.deep.equal(expectedObject);
});
+ it('should not pass base64 values... | base64 encoding: Serverless command "LS12ZXJib3Nl" not found
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our Guidelines: https://github.com/serverless/... | null | 2018-11-15 16:35:07+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['CLI #displayHelp() should return true when the "--version" parameter is given', 'CLI #displayHelp() should return true when no command is given', 'CLI Integration tests should print help --verbose to stdout', 'CLI #generateCommandsHelp() should gather and generate the commands help info if the command can be found', ... | ['CLI #processInput() should not pass base64 values as options'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/CLI.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/CLI.js->program->class_declaration:CLI->method_definition:processInput"] |
serverless/serverless | 5,361 | serverless__serverless-5361 | ['5050'] | 00daa75956df7876dc48f4a7fe5c1ce8658d0361 | diff --git a/lib/classes/CLI.js b/lib/classes/CLI.js
index 3d7f4b5ab78..f4db3010393 100644
--- a/lib/classes/CLI.js
+++ b/lib/classes/CLI.js
@@ -34,7 +34,33 @@ class CLI {
inputArray = process.argv.slice(2);
}
- const argv = minimist(inputArray);
+ const toBase64Helper = (value, index) => {
+ i... | diff --git a/lib/classes/CLI.test.js b/lib/classes/CLI.test.js
index 9925a75a1ec..112b8befaba 100644
--- a/lib/classes/CLI.test.js
+++ b/lib/classes/CLI.test.js
@@ -362,6 +362,15 @@ describe('CLI', () => {
expect(inputToBeProcessed).to.deep.equal(expectedObject);
});
+ it('should only return numbers li... | CLI argument being converted to number and rounded up
# This is a Bug Report
## Description
Command line argument '2060451113271393738' is being converted to a number and then rounded up to 2060451113271393800 in options array.
* What went wrong?
Calling KMS Secrets plugin, the string value '2060451113271... | Hi, can I work on this? Or is anyone working on it currently?
Thanks!
Hi @RafalWilinski it is still this issue relevant?
@JmeG I play around with the code and I think that I have a workaround.
Do you still need it? Pass all tests so, I can push into my fork for your testing. | 2018-10-06 02:32:06+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['CLI #displayHelp() should return true when the "--version" parameter is given', 'CLI #displayHelp() should return true when no command is given', 'CLI Integration tests should print help --verbose to stdout', 'CLI #generateCommandsHelp() should gather and generate the commands help info if the command can be found', ... | ['CLI #processInput() should only return numbers like strings when numbers are given on options'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/CLI.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/CLI.js->program->class_declaration:CLI->method_definition:processInput"] |
serverless/serverless | 5,351 | serverless__serverless-5351 | ['5345'] | a4b87a1c50599151a28c0286ede775ecbe1673ae | diff --git a/docs/providers/aws/events/sqs.md b/docs/providers/aws/events/sqs.md
index 8ebb23f9c08..77c5041f98c 100644
--- a/docs/providers/aws/events/sqs.md
+++ b/docs/providers/aws/events/sqs.md
@@ -34,6 +34,16 @@ functions:
- sqs:
arn:
Fn::ImportValue: MyExportedQueueArnId
+ - sqs... | diff --git a/lib/plugins/aws/package/compile/events/sqs/index.test.js b/lib/plugins/aws/package/compile/events/sqs/index.test.js
index a251c9d8723..2e21dfa15e0 100644
--- a/lib/plugins/aws/package/compile/events/sqs/index.test.js
+++ b/lib/plugins/aws/package/compile/events/sqs/index.test.js
@@ -391,18 +391,29 @@ descr... | Bad dynamic ARN property on sqs event
# This is a Bug Report
## Description
I'm trying to set an sqs event using a dynamic arn:
```yaml
service: myservice
custom:
region: eu-central-1
mySQSQueue:
Fn::Join:
- ":"
- - arn
- aws
- sqs
- Ref: AWS::Region
... | Hey @AndreaAdvanon, sorry you're having this issue. I'll state the problem and then a few solutions.
**Problem:** If you're dynamically building an ARN with CloudFormation intrinsic functions, the [code expects you to use `Fn::GetAtt` or `Fn::ImportValue` only](https://github.com/serverless/serverless/blob/cbc5e3c4e... | 2018-10-03 16:41:57+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileSQSEvents #compileSQSEvents() when a queue ARN is given should add the necessary IAM role statements', 'AwsCompileSQSEvents #compileSQSEvents() should throw an error if sqs event type is not a string or an object', 'AwsCompileSQSEvents #compileSQSEvents() should not throw error if custom IAM role name refer... | ['AwsCompileSQSEvents #compileSQSEvents() when a queue ARN is given should allow specifying SQS Queues as CFN reference types'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/sqs/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/sqs/index.js->program->class_declaration:AwsCompileSQSEvents->method_definition:compileSQSEvents"] |
serverless/serverless | 5,328 | serverless__serverless-5328 | ['5326'] | 373efc4f9fea599a5246b9f7ec9aaef239272e60 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index a85408fe84e..5ab14febf6a 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -246,6 +246,31 @@ functions:
maxAge: 86400
```
+If you are using CloudFront ... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
index 128b0375eea..6b45f83ffe5 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/... | Feature: Add CacheControl to cors configuration to allow for OPTIONS caching in CloudFront
# This is a Feature Proposal
## Description
There is support for the maxAge header which is used by the browser to cache OPTIONS request. In addition to this, I would like to cache my OPTIONS response in CloudFront to remo... | null | 2018-09-25 13:43:31+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileCors() should throw error if maxAge is not an integer greater than 0', '#compileCors() should throw error if maxAge is not an integer', '#compileCors() should add the methods resource logical id to the array of method logical ids'] | ['#compileCors() should create preflight method for CORS enabled resource'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js->program->method_definition:compileCors"] |
serverless/serverless | 5,314 | serverless__serverless-5314 | ['5242'] | 373efc4f9fea599a5246b9f7ec9aaef239272e60 | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index 2e10cf0b080..ac97772e436 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -475,13 +475,12 @@ class PluginManager {
.concat(Object.keys(command.commands));
});
- const servicePath = this.serve... | diff --git a/lib/plugins/lib/validate.test.js b/lib/plugins/lib/validate.test.js
index a88fb15f7c6..baad28f55db 100644
--- a/lib/plugins/lib/validate.test.js
+++ b/lib/plugins/lib/validate.test.js
@@ -39,7 +39,8 @@ describe('#validate()', () => {
return expect(serverlessPlugin.validate()).to.be.fulfilled.then(()... | Consistent determination of servicePath
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBU... | @eahefnawy you introduced the `|| 'x'` logic in https://github.com/serverless/serverless/commit/e2cc1451a5da76d79236014ae413140e901928bc ; was there a specific importance to `'x'` or would `'.'` potentially be a valid replacement? What requirements (if any) drove that code decision? Thanks!
Perhaps even removing that... | 2018-09-20 00:09:42+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#getServerlessConfigFile() should throw an error, if serverless.js export not a plain object', '#getServerlessConfigFile() should return the file content if a serverless.yaml file is found', '#getServerlessConfigFile() should return the file content if a serverless.yml file is found', '#getServerlessConfigFile() shou... | ['#getServerlessConfigFile() should look in the current working directory if servicePath is undefined'] | ['#validate() should resolve when current dir is service directory', '#validate() should throw an error when current dir is not service directory'] | . /usr/local/nvm/nvm.sh && npx mocha lib/utils/getServerlessConfigFile.test.js lib/plugins/lib/validate.test.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/lib/validate.js->program->method_definition:validate", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:updateAutocompleteCacheFile", "lib/plugins/print/print.js->program->class_declaration:Print->method_definition:print"] |
serverless/serverless | 5,312 | serverless__serverless-5312 | ['4494'] | 5b9faca66a37ac5df829ff317fe4562601fb3447 | diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md
index 5cb29d33777..627dbd042b4 100644
--- a/docs/providers/aws/guide/variables.md
+++ b/docs/providers/aws/guide/variables.md
@@ -18,7 +18,7 @@ They are especially useful when providing secrets for your service to use and wh
#... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 446208a2f5b..9c124447b2d 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -31,7 +31,7 @@ describe('Service', () => {
expect(serviceInstance.provider).to.deep.equal({
stage: 'dev',
region: '... | Variable file() path isn't parsed if it contains `@`
# This is a Bug Report
## Description
I'm trying to load variables from a scoped npm module in `serverless.yml`:
```yml
custom:
variableFromFile: ${file(node_modules/@scope/module-name/variables.json):variableName}
```
But when I try to deploy the serv... | Thank you for reporting @adambiggs :+1: that's a bug exactly since it has been reproduced on my end too.
I put `@test.yml` file on my test project and set up the following serverless.yml, then ran `sls print`.
However the `${file(./@test.yml):variableName}` did not be parsed properly. When removing `@`, it works fine... | 2018-09-19 16:12:27+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #update() should update service instance data', 'Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service ... | ['Service #constructor() should construct with defaults', "Variables #populateObject() significant variable usage corner cases file reading cases should populate variables from filesnames including '@', e.g scoped npm packages"] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/print/print.test.js lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 4 | 0 | 4 | false | false | ["lib/plugins/print/print.js->program->class_declaration:Print->method_definition:adorn", "lib/classes/Service.js->program->class_declaration:Service->method_definition:constructor", "lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat", "lib/classes/Variables.js->program->class_declaratio... |
serverless/serverless | 5,299 | serverless__serverless-5299 | ['5293'] | cfc2ac81f50427e343673e9ed2e2be6cafa99097 | diff --git a/docs/providers/aws/guide/deploying.md b/docs/providers/aws/guide/deploying.md
index fa05211eb00..53b94e23cf0 100644
--- a/docs/providers/aws/guide/deploying.md
+++ b/docs/providers/aws/guide/deploying.md
@@ -68,6 +68,9 @@ The Serverless Framework translates all syntax in `serverless.yml` to a single A
* Y... | diff --git a/lib/plugins/aws/deploy/lib/cleanupS3Bucket.test.js b/lib/plugins/aws/deploy/lib/cleanupS3Bucket.test.js
index d15d6cd7ab4..84447eedce2 100644
--- a/lib/plugins/aws/deploy/lib/cleanupS3Bucket.test.js
+++ b/lib/plugins/aws/deploy/lib/cleanupS3Bucket.test.js
@@ -29,7 +29,8 @@ describe('cleanupS3Bucket', () =>... | Allow specifying a custom prefix under which the artifacts will be deployed to S3
# This is a Feature Proposal
## Description
Currently, the prefix under which artifacts are deployed is hardcoded to `serverless`, which might not be a perfect fit for every setup. E.g. when using fine grained access control based o... | null | 2018-09-16 08:09:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #constructor() certificate authority - file should set AWS ca and cafile', 'AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'emptyS3Bucket #deleteObjects() should resolve if objectsInBucket is empty', 'AwsProvider #constructor() deploymentBucket c... | ['AwsProvider #getDeploymentPrefix() should return custom deployment prefix if defined', 'AwsProvider #getDeploymentPrefix() should use the default serverless if not defined', '#getS3ObjectsFromStacks() should return an empty result in case no stacks are provided', '#findAndGroupDeployments() should group stacks'] | ['emptyS3Bucket #listObjects() should push objects to the array if present', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'emptyS3Bucket #deleteObjects() should delete all objects in the S3 bucket', 'emptyS3Bucket #listObjects() should resolve if no objects are present', 'emptyS3Bucke... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deployList/index.test.js lib/plugins/aws/utils/getS3ObjectsFromStacks.test.js lib/plugins/aws/utils/findAndGroupDeployments.test.js lib/plugins/aws/rollback/index.test.js lib/plugins/aws/deploy/lib/cleanupS3Bucket.test.js lib/plugins/aws/remove/lib/bucket.test.js lib... | Feature | false | false | false | true | 8 | 1 | 9 | false | false | ["lib/plugins/aws/package/lib/generateArtifactDirectoryName.js->program->method_definition:generateArtifactDirectoryName", "lib/plugins/aws/remove/lib/bucket.js->program->method_definition:listObjects", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider", "lib/plugins/aws/deployList/index.... |
serverless/serverless | 5,268 | serverless__serverless-5268 | ['3069'] | 9986ac7ee91c84d91d43cfa671c96e5a63e5ab32 | diff --git a/lib/plugins/aws/package/compile/events/schedule/index.js b/lib/plugins/aws/package/compile/events/schedule/index.js
index 5ec91bd4646..42cd9f9978d 100644
--- a/lib/plugins/aws/package/compile/events/schedule/index.js
+++ b/lib/plugins/aws/package/compile/events/schedule/index.js
@@ -61,6 +61,20 @@ class Aw... | diff --git a/lib/plugins/aws/package/compile/events/schedule/index.test.js b/lib/plugins/aws/package/compile/events/schedule/index.test.js
index bb3eb72a0c6..af6a7d0befd 100644
--- a/lib/plugins/aws/package/compile/events/schedule/index.test.js
+++ b/lib/plugins/aws/package/compile/events/schedule/index.test.js
@@ -287... | Cannot use " in body for scheduling
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING... | null | 2018-09-01 18:17:44+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileScheduledEvents #compileScheduledEvents() should throw an error if schedule event type is not a string or an object', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect enabled variable, defaulting to true', 'AwsCompileScheduledEvents #compileScheduledEvents() should not create correspondin... | ['AwsCompileScheduledEvents #compileScheduledEvents() should throw an error when Input body is an invalid JSON string', 'AwsCompileScheduledEvents #compileScheduledEvents() should not throw an error when Input body is a valid JSON string'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/schedule/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/schedule/index.js->program->class_declaration:AwsCompileScheduledEvents->method_definition:compileScheduledEvents"] |
serverless/serverless | 5,256 | serverless__serverless-5256 | ['5100'] | b2a0b232af725745e9b71b9b3c031cc3fa40de14 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/index.js b/lib/plugins/aws/package/compile/events/apiGateway/index.js
index 3fe07915678..12dd5a692e1 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/index.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/index.js
@@ -23,6 +23,9 @@ c... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/index.test.js
index 571e0b5e111..ee08997f45c 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/index.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/index.test.js... | An error occurred: ApiGatewayDeploymentxxxxx - No integration defined for method - when v1.28 was used
# This is a (Bug Report)
This error started July 4 and coincidentally 1.28.0 was released.
our CodeBuild is failing since then.
In our CodeBuild spec...
------------------------ code build spec ---------------... | @densbozz the output references that you're still using v1.27.3. That rules out the newer version as a probable cause.
@densbozz @drexler I was experiencing the same issue, the exact same error output and resources missing the OPTIONS method. It appears to be related to a change in 1.28.0, because when deploying after ... | 2018-08-28 16:40:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileMethods() should add multiple response templates for a custom response codes', '#compileMethods() should add method responses for different status codes', '#compileMethods() should set api key as not required if private property is not specified', '#compileMethods() when dealing with request configuration sho... | ['#compileCors() should add the methods resource logical id to the array of method logical ids'] | ['AwsCompileApigEvents #constructor() "before each" hook for "should have hooks"', 'AwsCompileApigEvents #constructor() "after each" hook for "should have hooks"'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/index.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.js->program->method_definition:compileMethods", "lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js->program->method_definition:compileCors", "lib/plugins/aws/package/compile/events/apiGateway/index.js->program->class_declaration:AwsCompile... |
serverless/serverless | 5,229 | serverless__serverless-5229 | ['5221'] | bee4e25a3b21feed5c42705f083f589e6c7940d0 | diff --git a/docs/providers/aws/events/sns.md b/docs/providers/aws/events/sns.md
index 2dd1b2d091c..ccaf019cc00 100644
--- a/docs/providers/aws/events/sns.md
+++ b/docs/providers/aws/events/sns.md
@@ -95,3 +95,20 @@ functions:
topicName: aggregate
displayName: Data aggregation pipeline
```
+
+## ... | diff --git a/lib/plugins/aws/package/compile/events/sns/index.test.js b/lib/plugins/aws/package/compile/events/sns/index.test.js
index edcbe67d0a8..504d34a961c 100644
--- a/lib/plugins/aws/package/compile/events/sns/index.test.js
+++ b/lib/plugins/aws/package/compile/events/sns/index.test.js
@@ -44,6 +44,9 @@ describe(... | Feature Request: SNS Filter Policies
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTIN... | They also released a [blog post](https://aws.amazon.com/blogs/compute/managing-amazon-sns-subscription-attributes-with-aws-cloudformation/) about the new CloudFormation features. | 2018-08-19 22:31:37+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileSNSEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileSNSEvents #compileSNSEvents() should create SNS topic when only arn is given as an object property', 'AwsCompileSNSEvents #compileSNSEvents() should not create corresponding resources when SNS events are not... | ['AwsCompileSNSEvents #compileSNSEvents() should create corresponding resources when SNS events are given', 'AwsCompileSNSEvents #compileSNSEvents() should create corresponding resources when topic is defined in resources', 'AwsCompileSNSEvents #compileSNSEvents() should create SNS topic when arn, topicName, and filter... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/sns/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:compileSNSEvents"] |
serverless/serverless | 5,224 | serverless__serverless-5224 | ['5216', '5205'] | bee4e25a3b21feed5c42705f083f589e6c7940d0 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 8baa423b699..6411f043f70 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -301,7 +301,7 @@ class Variables {
* @returns {Promise[]} Promises for the eventual populated values of the given matches
*/
populateMatches(... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 3d6cce0ba7d..19c68a8e324 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -600,6 +600,40 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shou... | Variable resolution broken in 1.30.0
# This is a Bug Report
## Description
For bug reports:
* What went wrong?
Variable are being replaced several times in CFN generation.
`Resource: "arn:aws:dynamodb:${opt:region, self:provider.region}:*:table/${self:provider.environment.SURFACES_TABLE}"`
is becomin... | We're experiencing the same issue after upgrading to Serverless 1.30.
We avoided this problem replacing `${opt:region, self:provider.region}` with `${self:provider.region}` since we deploy only in one region.
We also experienced the same problem using `${opt:stage, self:provider.stage}`, replaced again with `${self:p... | 2018-08-17 01:44:48+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in the... | ['Variables #populateObject() significant variable usage corner cases should handle embedded deep variable replacements in overrides', 'Variables #populateObject() significant variable usage corner cases should deal with overwites that reference embedded deep references'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:splitAndGet", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:overwrite", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:populateMatches", "lib/classes/Variables.js-... |
serverless/serverless | 5,166 | serverless__serverless-5166 | ['5094'] | bb54c3bd39392f2e5f07bb9269be4b8390226aac | diff --git a/lib/plugins/aws/deployFunction/index.js b/lib/plugins/aws/deployFunction/index.js
index 2106b2b9e6a..daef82b2e0e 100644
--- a/lib/plugins/aws/deployFunction/index.js
+++ b/lib/plugins/aws/deployFunction/index.js
@@ -164,9 +164,9 @@ class AwsDeployFunction {
const errorMessage = 'Invalid charac... | diff --git a/lib/plugins/aws/deployFunction/index.test.js b/lib/plugins/aws/deployFunction/index.test.js
index 526607c92d1..6b61d129b18 100644
--- a/lib/plugins/aws/deployFunction/index.test.js
+++ b/lib/plugins/aws/deployFunction/index.test.js
@@ -353,19 +353,35 @@ describe('AwsDeployFunction', () => {
expect((... | Breaking change in 1.28.0: Environment variable ... must contain string
# This is a Bug Report
## Description
After updating today to 1.28.0, Serverless (or a dependency) now expects all environment variables to be strings. This sounds reasonable, but it's a breaking change so I'm making people aware.
In YAML,... | Seconded.
this obviously applies to empty vars too. we use SSM to populate envars and sometimes want that var to be empty +1
Thirded.
Same here... fourthed?
+1 , locked my sls install to previous version for now
+1, Thanks!
+1 had to downgrade to 1.27.3, serious breaking bug.
+1 (also thumbed up 👍 the initial commen... | 2018-07-26 20:02:03+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() when using onError config should reject if config is provided as a number', 'AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', 'AwsCompileFunctions #compileFunctions() should add a "Fn::ImportValue" Obje... | ['AwsCompileFunctions #compileFunctions() should accept an environment variable with a not-string value'] | ['AwsDeployFunction #normalizeArnRole "before each" hook for "should return unmodified ARN if ARN was provided"', 'AwsDeployFunction #normalizeArnRole "after each" hook for "should return unmodified ARN if ARN was provided"', 'AwsDeployFunction #checkIfFunctionExists() "before each" hook for "it should throw error if f... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deployFunction/index.test.js lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/deployFunction/index.js->program->class_declaration:AwsDeployFunction->method_definition:updateFunctionConfiguration", "lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 5,161 | serverless__serverless-5161 | ['5160'] | 734f7668e8057772ded57e6e6a89053d45a1b630 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index fde827ffcb6..64a090d3027 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -271,10 +271,10 @@ class AwsProvider {
// TODO: Add listeners, put Debug statments he... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index d736f83141d..914f110b845 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -98,7 +98,7 @@ describe('AwsProvider', () => {
'${opt:stage, \'... | ServerlessError: req.send is not a function
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONT... | null | 2018-07-25 16:29:23+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload', 'AwsProvider #getProfile() should use provider in lieu of options and config', 'AwsProvider #getCredentials() should ... | ['AwsProvider #request() should call correct aws method with a promise'] | ['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"] |
serverless/serverless | 5,156 | serverless__serverless-5156 | ['5027'] | 84ff4a070b072775fd7b2c778c7e6b69dbed5b19 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 7cebde7aa7c..5de79cc82bc 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -453,8 +453,21 @@ class Variables {
!(typeof value === 'object' && _.isEmpty(value))
);
return BbPromise.all(variableValues)
- .th... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 1c8ec69eb24..08481b9d1a4 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -586,6 +586,20 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shou... | Nested variable expansion failure in 1.27.1
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONT... | Having the same issue. This is related:
https://github.com/serverless/serverless/issues/4953
Hi @byarr. I can't reproduce the problem using the latest master https://github.com/serverless/serverless/commit/47816be84ae736f4827b860baa9689890d9bc133.
If the problem is fixed I think these issues can be closed:
https://g... | 2018-07-24 21:55:47+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in the... | ['Variables #populateObject() significant variable usage corner cases should handle overrides that are populated by unresolvable deep variables'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:overwrite"] |
serverless/serverless | 5,082 | serverless__serverless-5082 | ['5070'] | 6da3a9d9e4e2923fa81cf0c385ba1a9c27ddc072 | diff --git a/lib/plugins/create/create.js b/lib/plugins/create/create.js
index d1aeb1cbe2d..1a3f152db72 100644
--- a/lib/plugins/create/create.js
+++ b/lib/plugins/create/create.js
@@ -224,16 +224,8 @@ class Create {
// rename the service if the user has provided a path via options and is creating a service
i... | diff --git a/lib/plugins/create/create.test.js b/lib/plugins/create/create.test.js
index a6e10f2a1ca..00db1ce7228 100644
--- a/lib/plugins/create/create.test.js
+++ b/lib/plugins/create/create.test.js
@@ -115,6 +115,28 @@ describe('Create', () => {
expect(dirContent).to.include('.gitignore');
});
}... | Create command didn't use service name given as -n option.
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/b... | null | 2018-06-27 14:19:23+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Create #constructor() should have commands', 'renameService should set new service in serverless.yml and name in package.json', 'renameService should set new service in commented serverless.yml without existing package.json', 'renameService should fail to set new service name in serverless.yml', 'renameService should... | ['renameService should set new name of service in commented serverless.yml and name in package.json', 'renameService should set new name of service in serverless.yml and name in package.json'] | ['Create #create() should generate scaffolding for "aws-python3" template', 'Create #create() should set servicePath based on cwd', 'Create #create() should generate scaffolding for "aws-kotlin-jvm-maven" template', 'Create #create() should generate scaffolding for "aws-groovy-gradle" template', 'Create #create() shoul... | . /usr/local/nvm/nvm.sh && npx mocha lib/utils/renameService.test.js lib/plugins/create/create.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/utils/renameService.js->program->function_declaration:renameService", "lib/plugins/create/create.js->program->class_declaration:Create->method_definition:createFromTemplate"] |
serverless/serverless | 5,080 | serverless__serverless-5080 | ['5063'] | 6da3a9d9e4e2923fa81cf0c385ba1a9c27ddc072 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 60d3b3d7b16..26de011f911 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -472,7 +472,7 @@ Clients connecting to this Rest API will then need to set any of these API ... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js
index bca554cd1e6..7e65341d777 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGat... | Support for new Endpoint type " PRIVATE"
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIB... | Is this feature relevant? If so I like to contribute
@chamathsilva
>Is this feature relevant?
Yes! However, a status of this issue may be wait-for-cloudformation. To start implementation, CloudFormation will be supported for this feature. | 2018-06-27 09:28:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileRestApi() throw error if endpointType property is not a string', '#compileRestApi() should create a REST API resource', '#compileRestApi() throw error if endpointType property is not EDGE or REGIONAL', '#compileRestApi() should compile if endpointType property is REGIONAL', '#compileRestApi() should ignore RE... | ['#compileRestApi() should compile if endpointType property is PRIVATE'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.js->program->method_definition:compileRestApi"] |
serverless/serverless | 5,071 | serverless__serverless-5071 | ['4926'] | 47816be84ae736f4827b860baa9689890d9bc133 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 60d3b3d7b16..f561e4cf58b 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -43,6 +43,7 @@ layout: Doc
- [Manually Configuring shared API Gateway](#manually-config... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js
index bca554cd1e6..98f665df6ae 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGat... | API Gateway Resource Policy Support Feature
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONT... | @ptrivedi9400
Sounds good to introduce this functionality :smile:
I just added `wait-cf-support` tag so that someone can get started to implement it after support. | 2018-06-25 11:03:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileRestApi() should create a REST API resource', '#compileRestApi() throw error if endpointType property is not a string', '#compileRestApi() throw error if endpointType property is not EDGE or REGIONAL', '#compileRestApi() should ignore REST API resource creation if there is predefined restApi config'] | ['#compileRestApi() should create a REST API resource with resource policy'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.js->program->method_definition:compileRestApi"] |
serverless/serverless | 5,029 | serverless__serverless-5029 | ['5014'] | 543bed3cbd2f67fcd587d7c4712f23af36c10f63 | diff --git a/lib/classes/Utils.js b/lib/classes/Utils.js
index 8010d88b304..c0b7bb4545c 100644
--- a/lib/classes/Utils.js
+++ b/lib/classes/Utils.js
@@ -39,15 +39,15 @@ class Utils {
return fse.mkdirsSync(path.dirname(filePath));
}
- writeFileSync(filePath, contents) {
- return writeFileSync(filePath, con... | diff --git a/lib/plugins/aws/package/lib/saveServiceState.test.js b/lib/plugins/aws/package/lib/saveServiceState.test.js
index db9b02bd1f0..064fb861c0f 100644
--- a/lib/plugins/aws/package/lib/saveServiceState.test.js
+++ b/lib/plugins/aws/package/lib/saveServiceState.test.js
@@ -63,7 +63,7 @@ describe('#saveServiceSta... | json-cycle is causing problems with $ref in CF template
# This is a Bug Report
## Description
If a serverless plugin reads some configuration from the .yml file and writes it in to the template multiple times (for example, for each function, create a resource) _and_ it has a property that is a complex type (such ... | This issue is preventing deployments without hard coding a string literal value for properties we're using `join`, `sub`, or `ref`, etc for.
I've been manually deploying outside our pipelines, which obviously is an absolute last resort workaround.
Just to reiterate, hopefully in brief:
- If you have a cycle, `jso... | 2018-06-06 19:10:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#writeFileSync() should write a .yml file synchronously', '#writeFileSync() should be able to write an object with circular references', '#writeFile() should write a .yaml file synchronously', '#writeFile() should write a .yml file synchronously', '#writeFile() should write a .json file asynchronously', '#writeFile()... | ['#saveServiceState() should remove self references correctly', '#saveServiceState() should write the service state file template to disk'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/saveServiceState.test.js lib/utils/fs/writeFile.test.js lib/utils/fs/writeFileSync.test.js --reporter json | Bug Fix | false | true | false | false | 5 | 0 | 5 | false | false | ["lib/utils/fs/writeFileSync.js->program->function_declaration:writeFileSync", "lib/classes/Utils.js->program->class_declaration:Utils->method_definition:writeFile", "lib/plugins/aws/package/lib/saveServiceState.js->program->method_definition:saveServiceState", "lib/classes/Utils.js->program->class_declaration:Utils->m... |
serverless/serverless | 4,989 | serverless__serverless-4989 | ['4973', '4973', '4973'] | c34dc2d04eed12295024f26e37e39d0b713f1364 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 28f62386ae7..7cebde7aa7c 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -729,12 +729,8 @@ class Variables {
if (index < 0) {
index = this.deep.push(variable) - 1;
}
- let variableContainer = variable;
- ... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index c03bceeef19..1c8ec69eb24 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -624,6 +624,27 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shou... | Custom deep variables (still) appear not to be correctly resolved
This is a Bug Report
====================
Description
-----------
A follow up to #4946
(and https://github.com/amplify-education/serverless-domain-manager/issues/124)
For bug reports:
- What went wrong?\
My deep custom serverless v... | Just tried another plugin
```
plugins:
- serverless-scriptable-plugin
provider:
...
environment:
MYTEST: ${self:custom.apiFQDN}
custom:
scriptHooks:
'package:createDeploymentArtifacts': myscript.js
```
and
```
// myscript.js
// gets passed serverless object
console.log(ser... | 2018-05-18 07:11:01+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in the... | ['Variables #populateObject() significant variable usage corner cases should handle deep variables in complex recursions of custom variableSyntax'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:makeDeepVariable"] |
serverless/serverless | 4,986 | serverless__serverless-4986 | ['4976'] | c34dc2d04eed12295024f26e37e39d0b713f1364 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index ee21dfd8b35..6d8aa97c962 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -199,22 +199,27 @@ class AwsProvider {
const requestOptions = _.isObject(options) ? opt... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index 9039455e501..b518cc28dc7 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -1,5 +1,7 @@
'use strict';
+/* eslint-disable no-unused-expressions *... | sls deploy: endless loop on credential error in CI
# This is a Bug Report
## Description
I set up a `sls deploy` in CicleCI. As there are currently no credentials configured the build is supposed to fail.
Instead goes into an endless loop: `Serverless: Recoverable error occured (AWS provider credentials not fo... | null | 2018-05-17 09:32:47+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #constructor() certificate authority - file should set AWS ca and cafile', 'AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'AwsProvider #constructor() deploymentBucket configuration should do nothing if not defined', 'AwsProvider #getStage() shou... | ['AwsProvider #request() should retry if error code is 429 and retryable is set to false'] | ['AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProvider #getServerlessDeploymentBucketName() should return ... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"] |
serverless/serverless | 4,951 | serverless__serverless-4951 | ['2638'] | a2ae70b97381c3595b3888598ba6a36535593854 | diff --git a/docs/providers/aws/guide/serverless.yml.md b/docs/providers/aws/guide/serverless.yml.md
index 3660e307ca7..e092089091c 100644
--- a/docs/providers/aws/guide/serverless.yml.md
+++ b/docs/providers/aws/guide/serverless.yml.md
@@ -28,6 +28,8 @@ provider:
runtime: nodejs6.10
stage: dev # Set the default ... | diff --git a/lib/plugins/aws/lib/naming.test.js b/lib/plugins/aws/lib/naming.test.js
index 530d0621e56..1ed4b095420 100644
--- a/lib/plugins/aws/lib/naming.test.js
+++ b/lib/plugins/aws/lib/naming.test.js
@@ -94,11 +94,18 @@ describe('#naming()', () => {
});
describe('#getStackName()', () => {
- it('should u... | Add option to overwrite stack name
# This is a Feature Proposal
## Description
We have option to overwrite function name, APIG name etc. however there is no option to overwrite stack name. As we have already options for `stackTags`, `stackPolicy` in the `provider` we could add `stackName` option that would overwr... | This would be useful to maintain consistent naming conventions throughout a stack. The project I am working on adheres to a convention that roughly equates to: `${stage}-${service}-${resource}`.
Being able to customize the stack name (e.g. `stackName: ${opt:stage}-${self:service}`) allows us to view stacks in the co... | 2018-05-04 02:49:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#naming() #getLambdaAlexaSkillPermissionLogicalId() should normalize the function name and append the standard suffix', '#naming() #getDeploymentBucketLogicalId() should return "ServerlessDeploymentBucket"', '#naming() #getServiceEndpointRegex() should match the prefix', '#naming() #getLogGroupName() should add the f... | ['#naming() #getApiGatewayName() should return the custom api name if provided', '#naming() #getStackName() should use the custom stack name if provided'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/naming.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/lib/naming.js->program->method_definition:getStackName", "lib/plugins/aws/lib/naming.js->program->method_definition:getApiGatewayName"] |
serverless/serverless | 4,947 | serverless__serverless-4947 | ['4946', '4946'] | 524d04a76458f1dac7c414d921d831fd2644a807 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 77b48e4a5d2..28f62386ae7 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -729,7 +729,15 @@ class Variables {
if (index < 0) {
index = this.deep.push(variable) - 1;
}
- return `\${deep:${index}}`;
+ let ... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 55ae8f45e0a..c03bceeef19 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -586,6 +586,44 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shou... | Variables resolution broken with custom variableSyntax (${deep:0})
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serv... | Attached milestone 1.27.1 to get it out as hotfix as soon as it's released. Thanks @erikerikson for getting onto the problem 👍
Attached milestone 1.27.1 to get it out as hotfix as soon as it's released. Thanks @erikerikson for getting onto the problem 👍 | 2018-05-02 18:57:39+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in their original state', 'Variables #populateObject() significant variable usage corner cases should handle referenced deep variables that reference overrid... | ['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of custom variableSyntax', 'Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:makeDeepVariable"] |
serverless/serverless | 4,925 | serverless__serverless-4925 | ['4923'] | c0ba3b34fa7871996f33973676095e8c96214572 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.js
index cbb137d1ff7..61641b53505 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.js
+++ b/lib/plugins/aws/package/compile/events/apiGatewa... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.test.js
index cc89148cf2a..a0ff32a6749 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.test.js
+++ b/lib/plugins/aws/package/compile/e... | Shared API functionality has been broken on top of master
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/bl... | null | 2018-04-20 11:16:58+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#awsCompilePermissions() should create limited permission resource scope to REST API', '#awsCompilePermissions() should not create permission resources when http events are not given', '#awsCompilePermissions() should create permission resources for authorizers', '#compileUsagePlan() should compile default usage plan... | ['#awsCompilePermissions() should create limited permission resource scope to REST API with restApiId provided', '#compileUsagePlan() should compile custom usage plan resource with restApiId provided'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.js->program->method_definition:compileUsagePlan", "lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.js->program->method_definition:compilePermissions"] |
serverless/serverless | 4,892 | serverless__serverless-4892 | ['4839', '4839'] | 9e01283f94a8cf7410f6e9a67d2aa45f35e1d44e | diff --git a/docs/providers/aws/guide/plugins.md b/docs/providers/aws/guide/plugins.md
index f7a57a76a72..3cea0015727 100644
--- a/docs/providers/aws/guide/plugins.md
+++ b/docs/providers/aws/guide/plugins.md
@@ -33,9 +33,25 @@ We need to tell Serverless that we want to use the plugin inside our service. We
plugins:
... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index 437a515ffd0..7a19f227d28 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -779,6 +779,64 @@ describe('PluginManager', () => {
});
});
+ describe('#parsePluginsObject()', () => {
+... | Configure local plugins folder
# This is a Feature Proposal
## Description
Right now, when creating small local plugins, the only current option is to create a folder named `.serverless_plugins` to store it.
It would be nice to be able to configure the local plugins folder. This is good for projects with a wel... | Hi @nolde , thanks for the feature request 👍 . This is indeed a valuable improvement.
I would prefer something like the second alternative with a fallback to the old declaration instead of adding a new root key and make sure that plugins that manage the list do not break. Maybe we can use a different name than `imp... | 2018-04-08 20:47:20+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#yamlAstParser #removeExistingArrayItem() should do nothing when you can not find the object which you specify', 'PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #validateOptions() should throw an error if a customValidation is... | ['#packageService() #getExcludes() should merge defaults with plugin localPath and excludes', '#packageService() #getExcludes() should merge defaults with plugin localPath package and func excludes', 'PluginInstall #addPluginToServerlessFile() if plugins object is not array should add the plugin to the service file', '... | ['#packageService() #packageService() should package single functions individually if package artifact specified', '#packageService() #packageService() should not package functions if package artifact specified', '#packageService() #packageService() should package functions individually', '#packageService() #packageSer... | . /usr/local/nvm/nvm.sh && npx mocha lib/utils/yamlAstParser.test.js lib/classes/PluginManager.test.js lib/plugins/package/lib/packageService.test.js lib/plugins/plugin/install/install.test.js lib/plugins/plugin/uninstall/uninstall.test.js --reporter json | Feature | false | false | false | true | 7 | 1 | 8 | false | false | ["lib/plugins/plugin/install/install.js->program->class_declaration:PluginInstall->method_definition:addPluginToServerlessFile", "lib/plugins/package/lib/packageService.js->program->method_definition:getExcludes", "lib/classes/PluginManager.js->program->class_declaration:PluginManager", "lib/plugins/plugin/uninstall/un... |
serverless/serverless | 4,890 | serverless__serverless-4890 | ['4884'] | 25e99e8b81311ebd005b3c965602e32414c954cd | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 08de22e0e44..691b88e6f03 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -254,7 +254,7 @@ In order for other services such as Kinesis streams to be made available, a NAT
... | diff --git a/lib/plugins/aws/deployFunction/index.test.js b/lib/plugins/aws/deployFunction/index.test.js
index 3a2bf18583e..526607c92d1 100644
--- a/lib/plugins/aws/deployFunction/index.test.js
+++ b/lib/plugins/aws/deployFunction/index.test.js
@@ -353,6 +353,20 @@ describe('AwsDeployFunction', () => {
expect(()... | Different validation behavior between `serverless deploy` & `serverless deploy function`
# This is a `Bug Report`
## Description
* What went wrong?
I'm facing the validation issue when running `serverless deploy function --function facebook-events`
**BUT** everything is working as expected when I'm running `ser... | @ddimitrioglo Thanks for opening the issue.
This shows that the validation in `serverless deploy` is broken. Per AWS definition the environment variables have to contain strings only (or CF refernces in the CF template which resolve to strings on CF deployment time). So your validation error here is correct, but in ... | 2018-04-07 13:27:14+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() when using onError config should reject if config is provided as a number', 'AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', 'PluginInstall #installPeerDependencies() should not install peerDependencie... | ['AwsCompileFunctions #compileFunctions() should throw an error if environment variable is not a string', 'AwsCompileFunctions #compileFunctions() should accept an environment variable with CF ref and functions'] | ['AwsDeployFunction #normalizeArnRole "before each" hook for "should return unmodified ARN if ARN was provided"', 'AwsDeployFunction #normalizeArnRole "after each" hook for "should return unmodified ARN if ARN was provided"', 'AwsDeployFunction #checkIfFunctionExists() "before each" hook for "it should throw error if f... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deployFunction/index.test.js lib/plugins/aws/package/compile/functions/index.test.js lib/plugins/plugin/install/install.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/deployFunction/index.js->program->class_declaration:AwsDeployFunction->method_definition:updateFunctionConfiguration", "lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 4,879 | serverless__serverless-4879 | ['4876', '4876'] | c73b47b6c150a2ac593a4a734a70ae358e389379 | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.js b/lib/plugins/aws/package/lib/mergeIamTemplates.js
index f6db9ab09f7..0f28c782619 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.js
@@ -128,14 +128,8 @@ module.exports = {
if (this.serve... | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
index 479efa3b24b..1a236a74311 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
@@ -171,6 +171,40 @@ describe('#mergeIa... | Iam Managed Policies not merging when VPC Config selected
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/bl... | 2018-04-05 19:34:48+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should not add the default role if all functions have an ARN role', '#mergeIamTemplates() should add managed policy arns', '#mergeIamTemplates() should add default role if one of the functions h... | ['#mergeIamTemplates() should merge managed policy arns when vpc config supplied'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/mergeIamTemplates.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:mergeManagedPolicies", "lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:merge"] | |
serverless/serverless | 4,854 | serverless__serverless-4854 | ['4517'] | d1993815ffe63a8fe02d92755ba2ac645c9d016d | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index c5a6f0dac51..c6b8f80418a 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -224,6 +224,21 @@ functions:
Configuring the `cors` property sets [Access-Control-Allow-... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
index db2d06c876b..64f65624b4c 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/... | Add maxAge option for CORS preflight requests in API Gateway
# This is a Feature Proposal
## Description
As a developer using CORS for cross-origin usage of my API, I don't want the extra latency that results from CORS preflight requests happening all the time. I'd like to be able to configure Serverless to set t... | @pshendry Good catch 👍 . I agree that SLS should support the `max-age` header on CORS preflight calls.
| 2018-03-27 03:26:55+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() should process request parameters for HTTP_PROXY integration', '#validate() throw error if authorizer property is not a string or object',... | ['#validate() should merge all preflight cors options for a path', '#compileCors() should throw error if maxAge is not an integer', '#validate() should throw an error if the maxAge is not a positive integer', '#compileCors() should throw error if maxAge is not an integer greater than 0', '#compileCors() should create p... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js --reporter json | Feature | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js->program->method_definition:compileCors", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getCors"] |
serverless/serverless | 4,794 | serverless__serverless-4794 | ['4752'] | dfb36b8503f4d60de413dffc660ff1b4e31ec80c | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index 64a090d3027..0db9baf44dd 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -275,7 +275,7 @@ class AwsProvider {
req.send(cb);
});
return promise... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index 914f110b845..48fc28b2d32 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -452,6 +452,82 @@ describe('AwsProvider', () => {
.catch(() => ... | AWS deploy fails with empty error message if S3.headObject responds with 403
# This is a (minor) Bug Report
## Description
Deployment to AWS fails without any error message if the used IAM role is not allowed to upload to the existing S3 Bucket defined in `serverless.yml`, i.e. the AWS CLI responds with 403 for `... | Hi @jpbackman . I tagged the "minor bug report" as enhancement 😄 as it does not disable existing functionality. However, emitting `null` as error message is not a really good behavior. | 2018-03-02 17:40:44+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload', 'AwsProvider #getProfile() should use provider in lieu of options and config', 'AwsProvider #getCredentials() should ... | ['AwsProvider #request() should default to error code if error message is non-existent'] | ['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"] |
serverless/serverless | 4,793 | serverless__serverless-4793 | ['3751', '3751'] | f44429d7a959e27fca37ee9237649f63a62dc0ca | diff --git a/docs/providers/aws/guide/iam.md b/docs/providers/aws/guide/iam.md
index 19aacd6f389..9a0164cce21 100644
--- a/docs/providers/aws/guide/iam.md
+++ b/docs/providers/aws/guide/iam.md
@@ -45,7 +45,17 @@ provider:
- "/*"
```
+Alongside `provider.iamRoleStatements` managed policies can also be a... | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
index 1407989251f..373f0aa32cb 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
@@ -155,6 +155,22 @@ describe('#mergeIa... | Add support for AWS managed policies
# This is a Feature Proposal
## Description
Currently, I write lambda functions to create AWS accounts, aws roles, policies, .... To be able to do this, the lambda functions needs almost all IAM actions. I would like to attach AWS managed policies (e.g. IAMFullAccess) instead... | I believe this is already implemented and can be closed. E.g.
```
myDefaultRole:
Type: AWS::IAM::Role
Properties:
...
ManagedPolicyArns:
- arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole
```
Please refer to documentation from [Serverless](https://serverless.com/frame... | 2018-03-02 11:04:57+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should not add the default role if all functions have an ARN role', '#mergeIamTemplates() should add default role if one of the functions has an ARN role', '#mergeIamTemplates() should add Reten... | ['#mergeIamTemplates() should add managed policy arns', '#mergeIamTemplates() should throw error if managed policies is not an array'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/mergeIamTemplates.test.js --reporter json | Feature | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:validateManagedPolicies", "lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:merge", "lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:mergeIamTemplates"] |
serverless/serverless | 4,775 | serverless__serverless-4775 | ['4705'] | f1f298884248d00c0c5691da35baf50d4de7d2b9 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js
index bbafbb75163..936931cdbe8 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/val... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
index a2132f048e0..4e481c9d8b5 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
+++ b/lib/plugins/aws/package/compile/events/api... | Serverless 1.26 doesn't set default API Gateway response template
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serve... | I had this problem as well.
I faced this problem too.
This issue may not caused by serverless. I tried to downgrade serverless to 1.25.0, 1.24.1, 1.23.0. both not working.
Below is the deploy logs:
``` log
Serverless: Load command run
Serverless: Load command config
Serverless: Load command config:credentials
Se... | 2018-02-26 16:54:06+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() should process request parameters for HTTP_PROXY integration', '#validate() throw error if authorizer property is not a string or object',... | ['#validate() should set default statusCodes to response for lambda by default'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate"] |
serverless/serverless | 4,768 | serverless__serverless-4768 | ['4459'] | 8e6582dfa96f68247497644b02c913ba708e67b6 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.js
index 7bc199bb34e..e877b2aed09 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.test.js
index 370a8c59471..d43e8fe4746 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.test.js
+++ b/lib/plugins/aws/package/compile/events/... | UsagePlan is not created unless apiKeys are defined
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/mas... | The change to make this work is trivial, please see attached one liner diff that I'm using.
[usagePlan.js.diff.txt](https://github.com/serverless/serverless/files/1454615/usagePlan.js.diff.txt)
Thank you for reporting and putting the code for resolving it @bsdkurt :+1:
I have tried your code and great to see wor... | 2018-02-24 17:23:28+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileUsagePlan() should compile default usage plan resource'] | ['#compileUsagePlan() should compile custom usage plan resource'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlan.js->program->method_definition:compileUsagePlan"] |
serverless/serverless | 4,763 | serverless__serverless-4763 | ['4762'] | 897961d47573c572ba09143ebf2c8b49d30a1700 | diff --git a/docs/providers/aws/events/cloudwatch-event.md b/docs/providers/aws/events/cloudwatch-event.md
index 3d75da37476..7e40bbab444 100644
--- a/docs/providers/aws/events/cloudwatch-event.md
+++ b/docs/providers/aws/events/cloudwatch-event.md
@@ -111,3 +111,24 @@ functions:
state:
... | diff --git a/lib/plugins/aws/package/compile/events/cloudWatchEvent/index.test.js b/lib/plugins/aws/package/compile/events/cloudWatchEvent/index.test.js
index 081bc08c7d3..0dd5123a2d7 100644
--- a/lib/plugins/aws/package/compile/events/cloudWatchEvent/index.test.js
+++ b/lib/plugins/aws/package/compile/events/cloudWatc... | Name property not available for cloudwatchEvent
# Add name property to cloudwatchEvent
## Description
Currently if you specify a name property for a cloudwatchEvent, it does not get populated in the CF template. Name is an accepted property for schedule, but not cloudwatchEvent
So this works:
```yaml
- s... | null | 2018-02-22 18:58:39+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['awsCompileCloudWatchEventEvents #compileCloudWatchEventEvents() should respect description variable', 'awsCompileCloudWatchEventEvents #compileCloudWatchEventEvents() should not create corresponding resources when cloudwatch events are not given', 'awsCompileCloudWatchEventEvents #compileCloudWatchEventEvents() shoul... | ['awsCompileCloudWatchEventEvents #compileCloudWatchEventEvents() should respect name variable'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/cloudWatchEvent/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/cloudWatchEvent/index.js->program->class_declaration:AwsCompileCloudWatchEventEvents->method_definition:compileCloudWatchEventEvents"] |
serverless/serverless | 4,754 | serverless__serverless-4754 | ['4744'] | 39caddc404ecabf40ea3fb2aa51d31cbe8db7acd | diff --git a/lib/classes/PromiseTracker.js b/lib/classes/PromiseTracker.js
index f7638535518..ea710720bbc 100644
--- a/lib/classes/PromiseTracker.js
+++ b/lib/classes/PromiseTracker.js
@@ -4,11 +4,15 @@ const logWarning = require('./Error').logWarning;
class PromiseTracker {
constructor() {
+ this.reset();
+ ... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 6520f7c2bf0..8962814e371 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -21,11 +21,11 @@ const Variables = require('../../lib/classes/Variables');
BbPromise.longStackTraces(true);
-chai.should();
-
... | A valid service attribute to satisfy the declaration 'self:service.name' could not be found
# This is a (Bug Report)
## Description
For bug reports:
* What went wrong?
I'm trying to use dynamic variables in `serverless.yml` and it fails.
Basically, I have the following in my `provider`:
```
environment... | Additional information: This seems to be related to the `env` and particular `self:service` mostly, for instance:
- ✅ `Resource: "arn:aws:dynamodb:${self:provider.region}:035907498810:table/simulator-feedback-${self:provider.stage}"`
- ❗️ `Resource: "arn:aws:dynamodb:${self:provider.region}:035907498810:table/${sel... | 2018-02-20 20:29:27+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #splitByComma should return a undelimited string', 'Variables #getValueFromFile() should populate an entire variable exported by a javascript file', 'Variables #getValueFromCf() should reject CloudFormation variables that do not exist', 'Variables #getValueFromFile() should throw if property exported by a j... | ['Variables #populateObject() significant variable usage corner cases should handle deep variables that reference overrides', 'Variables #populateObject() significant variable usage corner cases should handle referenced deep variables that reference overrides', 'Variables #populateService() should clear caches and rema... | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/print/print.test.js lib/classes/Variables.test.js --reporter json | Bug Fix | false | false | false | true | 28 | 1 | 29 | false | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromSelf", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:populateMatches", "lib/plugins/print/print.js->program->class_declaration:Print->method_definition:adorn", "lib/plugins/print/print.js... |
serverless/serverless | 4,701 | serverless__serverless-4701 | ['4700'] | 2a3d57e3907ecce537bcf8d1b73074ed6a38a1b4 | diff --git a/docs/providers/aws/events/alexa-skill.md b/docs/providers/aws/events/alexa-skill.md
index 915464bcf1b..3ade42de377 100644
--- a/docs/providers/aws/events/alexa-skill.md
+++ b/docs/providers/aws/events/alexa-skill.md
@@ -14,14 +14,41 @@ layout: Doc
## Event definition
-This will enable your Lambda func... | diff --git a/lib/plugins/aws/deploy/lib/createStack.test.js b/lib/plugins/aws/deploy/lib/createStack.test.js
index 28d5820e99b..370422d73d3 100644
--- a/lib/plugins/aws/deploy/lib/createStack.test.js
+++ b/lib/plugins/aws/deploy/lib/createStack.test.js
@@ -6,7 +6,6 @@ const path = require('path');
const AwsProvider = ... | Feature Proposal: Restricting alexaSkill function invocations by skill id
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverle... | @kobim Nice catch 👍
any comments on my thoughts? I was going to create a pull request with that implementation, just wanted to verify there are no modifications required.
Great to hear that you'll engage with this issue 🙌
The only caveat is, that the implementation must make sure that the old syntax continues to... | 2018-01-31 15:44:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#naming() #getScheduleId() should add the standard suffix', '#naming() #getNormalizedFunctionName() should normalize the given functionName with a dash', '#naming() #getPolicyName() should use the stage and service name', '#naming() #normalizeName() should have no effect on the rest of the name', '#naming() #getNorma... | ['#naming() #getLambdaAlexaSkillPermissionLogicalId() should normalize the function name and append the standard suffix', 'AwsCompileAlexaSkillEvents #compileAlexaSkillEvents() should create corresponding resources when multiple alexaSkill events are provided', '#naming() #getLambdaAlexaSkillPermissionLogicalId() shoul... | ['uploadArtifacts #uploadFunctions() should upload the function .zip files to the S3 bucket', 'createStack #createStack() should run promise chain in order', 'uploadArtifacts #uploadCloudFormationFile() "before each" hook for "should upload the CloudFormation file to the S3 bucket"', 'uploadArtifacts #uploadArtifacts()... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/uploadArtifacts.test.js lib/plugins/aws/deploy/lib/extendedValidate.test.js lib/plugins/aws/lib/naming.test.js lib/plugins/aws/package/compile/events/alexaSkill/index.test.js lib/plugins/aws/deploy/lib/createStack.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/lib/naming.js->program->method_definition:getLambdaAlexaSkillPermissionLogicalId", "lib/plugins/aws/package/compile/events/alexaSkill/index.js->program->class_declaration:AwsCompileAlexaSkillEvents->method_definition:compileAlexaSkillEvents"] |
serverless/serverless | 4,694 | serverless__serverless-4694 | ['4555'] | 87c2e0123f19b872cd8d0e023ef5ae2be7cf31da | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 2d6a970ed68..468701dce7f 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -37,6 +37,7 @@ functions:
runtime: python2.7 # optional overwrite, default is provider runtime
... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index b5e18c68424..d170bdeb217 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -25,6 +25,7 @@ describe('Aws... | Feature Request: Set Concurrency Limits on Individual AWS Lambda
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serve... | Hi @itzaliza , great catch!
However, we have to check if CloudFormation already offers support for the new feature. Only if it is supported, we can make use of it.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-function.html
CloudFormation has not supported the feature yet. So cu... | 2018-01-30 08:29:01+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() when using onError config should reject if config is provided as a number', 'AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', 'AwsCompileFunctions #compileFunctions() should add a "Fn::ImportValue" Obje... | ['AwsCompileFunctions #compileFunctions() should throw an informative error message if non-integer reserved concurrency limit set on function', 'AwsCompileFunctions #compileFunctions() should set function declared reserved concurrency limit'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 4,650 | serverless__serverless-4650 | ['4648'] | b576abc2951bccb7712619f5c944f63541584bf7 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js
index 03dcbcfb259..bbafbb75163 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/val... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
index 6338005f271..a2132f048e0 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
+++ b/lib/plugins/aws/package/compile/events/api... | Allow explicit name for authorisers specified by arn.
# This is a Bug
## Description
Serverless (v1.25.0) does not respect the 'name' property if 'arn' is specified for an authorizer.
This is unexpected- but is especially problematic because it stops you using the same authorizer function with different config... | null | 2018-01-12 14:03:06+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() should process request parameters for HTTP_PROXY integration', '#validate() throw error if authorizer property is not a string or object',... | ['#validate() should handle an authorizer.arn with an explicit authorizer.name object'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer"] |
serverless/serverless | 4,636 | serverless__serverless-4636 | ['4625'] | 13bda4bf1e4771e6d52f1d07bb3ed0645f32c93c | diff --git a/docs/providers/aws/cli-reference/deploy.md b/docs/providers/aws/cli-reference/deploy.md
index 66204c690a9..8bdeced0998 100644
--- a/docs/providers/aws/cli-reference/deploy.md
+++ b/docs/providers/aws/cli-reference/deploy.md
@@ -25,7 +25,8 @@ serverless deploy
- `--verbose` or `-v` Shows all stack events d... | diff --git a/lib/plugins/aws/package/lib/generateCoreTemplate.test.js b/lib/plugins/aws/package/lib/generateCoreTemplate.test.js
index a089d536950..e4cb5eba22f 100644
--- a/lib/plugins/aws/package/lib/generateCoreTemplate.test.js
+++ b/lib/plugins/aws/package/lib/generateCoreTemplate.test.js
@@ -61,14 +61,45 @@ describ... | ServerlessError: An error occurred: ServerlessDeploymentBucket - API: s3:setBucketAccelerateConfiguration Access Denied.
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and fol... | Hi @dperszyk, thank you for repoting :+1: :smile:
>I'm guessing this has something to do with the new feature added for bucketAcceleration.
I think so.
Which commands did you run when facing the error? `sls deploy`?
Additionally, could you tell us policies list that the IAM user is attached so that we can repr... | 2018-01-07 16:35:47+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#generateCoreTemplate() should use a custom bucket if specified, even with S3 transfer acceleration', '#generateCoreTemplate() should use a custom bucket if specified'] | ['#generateCoreTemplate() should use a auto generated bucket if you does not specify deploymentBucket'] | ['#generateCoreTemplate() should explicitly disable S3 Transfer Acceleration, if requested', '#generateCoreTemplate() should add a deployment bucket to the CF template, if not provided', '#generateCoreTemplate() should add a custom output if S3 Transfer Acceleration is enabled', '#generateCoreTemplate() should explode ... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/generateCoreTemplate.test.js --reporter json | Bug Fix | false | false | false | true | 2 | 1 | 3 | false | false | ["lib/plugins/aws/package/lib/generateCoreTemplate.js->program->method_definition:generateCoreTemplate", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:isS3TransferAccelerationDisabled", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider... |
serverless/serverless | 4,601 | serverless__serverless-4601 | ['4569'] | c639e30b180008888436b81000ce12d701776c0d | diff --git a/lib/plugins/aws/package/compile/events/cloudWatchLog/index.js b/lib/plugins/aws/package/compile/events/cloudWatchLog/index.js
index 400a6fae0a4..697d9736d09 100644
--- a/lib/plugins/aws/package/compile/events/cloudWatchLog/index.js
+++ b/lib/plugins/aws/package/compile/events/cloudWatchLog/index.js
@@ -78,... | diff --git a/lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js b/lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js
index 7777188d239..bfc3263cd35 100644
--- a/lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js
+++ b/lib/plugins/aws/package/compile/events/cloudWatchLog/i... | Filter pattern improvement for cloudwatchLog events (aws)
# This is a Feature Proposal (Improvement)
## Description
For feature proposals:
* When adding a cloudwatchLog event, as mentioned by AWS document `Metric filter terms that include characters other than alphanumeric or underscore must be placed inside dou... | Hi, @willwhy thanks for opening up this issue :+1:
Fully agreed. Your proposal makes sense.
>I can try to implement the improvement if you agree to make this change
Awesome :100:
it would be great if you will implement it and send PR!
Let us know if you need our helps!
Cool. Thanks @horike37 | 2017-12-22 01:03:42+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should respect "filter" variable', 'AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should set an empty string for FilterPattern statement when "filter" variable is not given', 'AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should r... | ['AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should respect "filter" variable of plain text'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/cloudWatchLog/index.js->program->class_declaration:AwsCompileCloudWatchLogEvents->method_definition:compileCloudWatchLogEvents"] |
serverless/serverless | 4,596 | serverless__serverless-4596 | ['4526'] | 44d66a7919cfa0b8d9dca8b408d2aa595391293d | diff --git a/lib/plugins/aws/invokeLocal/index.js b/lib/plugins/aws/invokeLocal/index.js
index f73c5cb10fe..49cd79b349f 100644
--- a/lib/plugins/aws/invokeLocal/index.js
+++ b/lib/plugins/aws/invokeLocal/index.js
@@ -118,10 +118,10 @@ class AwsInvokeLocal {
|| this.serverless.service.provider.runtime
|| '... | diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js
index d2542acaeb6..c2e83743507 100644
--- a/lib/plugins/aws/invokeLocal/index.test.js
+++ b/lib/plugins/aws/invokeLocal/index.test.js
@@ -379,6 +379,7 @@ describe('AwsInvokeLocal', () => {
expect(invokeLocalJav... | can't invoke scala locally
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
4. F... | Thank you for reporting this bug @zydeco! 💯
Glad that you're willing to fix it. Shoot me questions if anything is unclear. I'm not Java pro but I might help with SLS internals. | 2017-12-20 15:37:03+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsInvokeLocal #constructor() should set an empty options object if no options are given', 'AwsInvokeLocal #loadEnvVars() it should load default lambda env vars', 'AwsInvokeLocal #extendedValidate() it should parse file if absolute file path is provided', 'AwsInvokeLocal #constructor() should have hooks', 'AwsInvokeL... | ['AwsInvokeLocal #callJavaBridge() spawns java process with correct arguments'] | ['AwsInvokeLocal #extendedValidate() it should parse file if relative file path is provided', 'AwsInvokeLocal #extendedValidate() should resolve if path is not given', 'AwsInvokeLocal #invokeLocalJava() "before each" hook for "should invoke callJavaBridge when bridge is built"', 'AwsInvokeLocal #invokeLocal() "before e... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js --reporter json | Bug Fix | false | false | false | true | 5 | 2 | 7 | false | false | ["lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:invokeLocalJava", "lib/plugins/aws/invokeLocal/java/src/main/java/com/serverless/InvokeBridge.java->program->class_declaration:InvokeBridge->constructor_declaration:InvokeBridge", "lib/plugins/aws/invokeLocal/java/src/m... |
serverless/serverless | 4,591 | serverless__serverless-4591 | ['4564'] | 95f678955fe69309907fdac478b8a6e2df4c43dd | diff --git a/docs/providers/aws/guide/serverless.yml.md b/docs/providers/aws/guide/serverless.yml.md
index 2bb376af946..30f1c137446 100644
--- a/docs/providers/aws/guide/serverless.yml.md
+++ b/docs/providers/aws/guide/serverless.yml.md
@@ -31,6 +31,7 @@ provider:
profile: production # The default profile to use wit... | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
index f5c9c6be7a9..1407989251f 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
@@ -238,6 +238,41 @@ describe('#mergeIa... | Add a new property which specify RetentionInDays with CloudWathcLogs to serverless.yml
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github... | Wonderful idea. However, I would name it
```
provider
logRetentionInDays: 5
```
with a prepended "log" to make clear that it is for the log streams.
Thanks @HyperBrain for the feedback.
>with a prepended "log" to make clear that it is for the log streams.
Yup. that’s better :+1:
| 2017-12-19 15:17:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should not add the default role if all functions have an ARN role', '#mergeIamTemplates() should add default role if one of the functions has an ARN role', '#mergeIamTemplates() should throw err... | ['#mergeIamTemplates() should throw error if RetentionInDays is 0 or not an integer', '#mergeIamTemplates() should add RetentionInDays to a CloudWatch LogGroup resource if logRetentionInDays is given'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/mergeIamTemplates.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:merge"] |
serverless/serverless | 4,590 | serverless__serverless-4590 | ['3269'] | 95f678955fe69309907fdac478b8a6e2df4c43dd | diff --git a/docs/providers/aws/guide/intro.md b/docs/providers/aws/guide/intro.md
index 8f042645434..e4ea181a567 100644
--- a/docs/providers/aws/guide/intro.md
+++ b/docs/providers/aws/guide/intro.md
@@ -58,7 +58,7 @@ The Serverless Framework not only deploys your Functions and the Events that tri
### Services
-A... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 5ea2eb39a98..96bf7529fad 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -287,6 +287,75 @@ describe('Service', () => {
});
});
+ it('should load serverless.js from filesystem', () => {
+ cons... | Support JS configuration to make configuration more flexible
# This is a Feature Proposal
## Description
I would like to see support for Javascript files as an additional configuration format. The current YAML format works fine, but a JS file could give the following advantages:
* For large services, you can e... | This would be really awesome! For those of us that despise YAML, json is the only option but JSON doesn't support comments so its a huge drag. I make a lot of use of the node-config package and its ability to use js config files has been great. In one of my serverless projects I've even gone as far as to wrap all m... | 2017-12-19 10:25:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #update() should update service instance data', 'PluginInstall #installPeerDependencies() should not install peerDependencies if an installed plugin does not have ones', 'Utils #appendFileSync() should append a line to a text file', 'Utils #readFileSync() should throw YAMLException with filename if yml file i... | ['Service #load() should throw error if serverless.js exports invalid config', 'PluginInstall #addPluginToServerlessFile() should not modify serverless .js file', '#getServerlessConfigFile() should throw an error, if serverless.js export not a plain object', 'PluginUtils #getServerlessFilePath() should reject if no con... | ['#packageService() #packageService() should package single functions individually if package artifact specified', '#packageService() #packageService() should not package functions if package artifact specified', '#packageService() #packageService() should package functions individually', '#packageService() #packageSer... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/plugin/lib/utils.test.js lib/plugins/package/lib/packageService.test.js lib/plugins/plugin/install/install.test.js lib/utils/getServerlessConfigFile.test.js lib/classes/Utils.test.js lib/classes/Service.test.js lib/plugins/plugin/uninstall/uninstall.test.js --reporter js... | Feature | false | true | false | false | 6 | 0 | 6 | false | false | ["lib/plugins/plugin/lib/utils.js->program->method_definition:getServerlessFilePath", "lib/plugins/plugin/install/install.js->program->class_declaration:PluginInstall->method_definition:addPluginToServerlessFile", "lib/classes/Service.js->program->class_declaration:Service->method_definition:load", "lib/plugins/plugin/... |
serverless/serverless | 4,576 | serverless__serverless-4576 | ['4566'] | b3b5cba3b938d25c2332e814236045787ad700fb | diff --git a/docs/providers/aws/cli-reference/create.md b/docs/providers/aws/cli-reference/create.md
index fc38bf9cd8d..73421f72533 100644
--- a/docs/providers/aws/cli-reference/create.md
+++ b/docs/providers/aws/cli-reference/create.md
@@ -33,8 +33,9 @@ serverless create --template-url https://github.com/serverless/se... | diff --git a/lib/plugins/create/create.test.js b/lib/plugins/create/create.test.js
index df578b49347..531d4fd7159 100644
--- a/lib/plugins/create/create.test.js
+++ b/lib/plugins/create/create.test.js
@@ -666,5 +666,48 @@ describe('Create', () => {
return create.create().catch(() => download.downloadTemplateFr... | Unable to download template from a private repo or an internal path
# This is a Feature Proposal
## Description
* When doing a `serverless create`, we can specify a `template-url` to fetch the template from a git repo. However this does not works with private repositories because it only use HTTPS and not SSH. Th... | Hi @ChristopheBougere ,
thanks for the feature request. So you have the original use case where you wanted to fetch a template via a git ssh url (`ssh://git@....`) and the follow up use case where you want to read a template source from a local directory?
For me both use cases make sense (the first one in general... | 2017-12-14 15:24:29+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Create #constructor() should have commands', 'Create #constructor() should have hooks', '#walkDirSync() should return an array with corresponding paths to the found files'] | ['#walkDirSync() should check noLinks option'] | ['Create #create() should generate scaffolding for "aws-python3" template', 'Create #create() should set servicePath based on cwd', 'Create #create() should generate scaffolding for "aws-kotlin-jvm-maven" template', 'Create #create() should generate scaffolding for "aws-groovy-gradle" template', 'Create #create() shoul... | . /usr/local/nvm/nvm.sh && npx mocha lib/utils/fs/walkDirSync.test.js lib/plugins/create/create.test.js --reporter json | Feature | false | true | false | false | 4 | 0 | 4 | false | false | ["lib/plugins/create/create.js->program->class_declaration:Create->method_definition:constructor", "lib/utils/fs/copyDirContentsSync.js->program->function_declaration:fileExists", "lib/plugins/create/create.js->program->class_declaration:Create->method_definition:create", "lib/utils/fs/walkDirSync.js->program->function... |
serverless/serverless | 4,559 | serverless__serverless-4559 | ['4259'] | 1fb90f6dc14bc2140224d82edc1e30bf39f7ac37 | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index 7cf4f75da27..b2714300fc1 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -90,6 +90,9 @@ class PluginManager {
this.addPlugin(Plugin);
} catch (error) {
+ if (this.cliCommands[0] === 'p... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index 95864844cef..437a515ffd0 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -665,6 +665,16 @@ describe('PluginManager', () => {
});
});
+ it('should not throw error when runni... | `sls plugin search` fails if a plugin is uninstalled
# This is a Bug Report
## Description
In a given directory that has a plugin listed in the `serverless.yml` which is not installed, a call to `sls plugin search --query webpack` fails with the message:
`Serverless plugin "serverless-spotinst-functions" not f... | Thanks for reporting @ryanmurakami 👍
Nice catch! /cc @horike37
All plugin commands(list, search, install, uninstall) might want not to catch the error in the above situation. Otherwise, users who set plugins manually within the yaml file would face the same error.
What do you think?
@horike37 I agree. Just to add ... | 2017-12-11 20:18:35+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #validateOptions() should throw an error if a customValidation is not met', 'PluginManager #run() should run commands with internal lifecycles', 'PluginManager #getCommands() shou... | ['PluginManager #loadPlugins() should not throw error when running the plugin commands and given plugins does not exist'] | ['PluginManager #loadCommands() should log the alias when SLS_DEBUG is set'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadPlugins", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadServicePlugins"] |
serverless/serverless | 4,531 | serverless__serverless-4531 | ['4440'] | c53b0b2807b43fbba6d13b35b65004a066788a8a | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 1852db3d28e..2a229b0e07f 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -421,6 +421,27 @@ Please note that those are the API keys names, not the actual values. Once... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js
index 2ebf517fc1d..d1a066fd330 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGat... | Amazon API Gateway Endpoint type
# This is a Feature Proposal
## Description
AWS just added endpoint types in API Gateway. Currently, there are two endpoint types you can choose from. Edge-optimized and regional. With Regional you can attach your own CloudFront distribution. I'm not sure if this is supported in Clo... | @whyvez Can you please use the issue template, shown when creating a new issue, and fill out the resp. sections instead of just using a one-sentence description for an issue? This makes it a lot easier for us to organize incoming requests - may it be bugs or features. Thank you.
@HyperBrain Sorry about that. How does t... | 2017-12-06 18:45:38+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | [] | ['#compileRestApi() throw error if endpointType property is not a string', '#compileRestApi() throw error if endpointType property is not EDGE or REGIONAL', '#compileRestApi() should create a REST API resource'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.js->program->method_definition:compileRestApi"] |
serverless/serverless | 4,448 | serverless__serverless-4448 | ['4435'] | aaabb92005d5dfe9ac1018af2b2e0396ebd954ff | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index a3fb07a7e22..3c69a151692 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -235,8 +235,10 @@ class Variables {
referencedFileRelativePath :
path.join(this.serverless.config.servicePath, referencedFileRelativeP... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index d6c5e2b762f..203ace06c1d 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -638,19 +638,19 @@ describe('Variables', () => {
it('should get undefined if non existing file and the second argument is true'... | Error when file referenced in serverless.yml does not exist
# Bug Report
## Description
When deploying and referencing an `env` file variable in `serverless.yml` that doesn't exist, the build fails.
* What went wrong?
I get the error:
`ENOENT: no such file or directory, realpath '/foo/bar/repo/.env.yml'`... | Thanks @antpuleo2586 for reporting :+1:
That would be a bug, so we should add a test which reproduces it ,then fix it.
+1 ran into this with my CI/CD pipeline after upgrading to 1.24 with numerous stacks with default overridable params. This is urgent IMHO, please fix ASAP.
I also wonder what "feature" actually... | 2017-11-06 11:57:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #warnIfNotFound() should log if variable has empty object value.', 'Variables #getValueFromSource() should throw error if referencing an invalid source', 'Variables #populateVariable() should populate string variables as sub string', 'Variables #populateVariable() should populate number variables as sub str... | ['Variables #getValueFromFile() should get undefined if non existing file and the second argument is true'] | ['Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #populateService() should call populateProperty method', 'Variables #getValueFromSsm() should get variable from Ssm using regular-st... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromFile"] |
serverless/serverless | 4,382 | serverless__serverless-4382 | ['4156'] | 643c4fdd7e9c7bfd7a81c4be81a23cffd4be3113 | diff --git a/docs/providers/aws/cli-reference/deploy.md b/docs/providers/aws/cli-reference/deploy.md
index 90c23eb440e..a7ad350e0f9 100644
--- a/docs/providers/aws/cli-reference/deploy.md
+++ b/docs/providers/aws/cli-reference/deploy.md
@@ -24,6 +24,7 @@ serverless deploy
- `--package` or `-p` path to a pre-packaged d... | diff --git a/lib/plugins/aws/info/display.test.js b/lib/plugins/aws/info/display.test.js
index 22b955c9e0a..9924ccc2ff2 100644
--- a/lib/plugins/aws/info/display.test.js
+++ b/lib/plugins/aws/info/display.test.js
@@ -74,6 +74,20 @@ describe('#display()', () => {
expect(missingMessage).to.equal(expectedMessage);
... | Hide api key generated by sls from the serverless console output
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/server... | I have started to work on this feature 🎉. The api key names will still be displayed in the output however the values will blank.
```console
$ serverless deploy --obfuscate-api-keys
Service Information
service: helloworld
stage: production
region: us-west-1
api keys:
production-helloworld-user1-key
endpo... | 2017-10-15 14:01:24+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#display() should display general service info', '#display() should display CloudFormation outputs when verbose output is requested', '#display() should display API keys if given', '#display() should display endpoints if given', '#display() should display functions if given'] | ['#display() should hide API keys values when `--conceal` is given'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/info/display.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/info/display.js->program->method_definition:displayApiKeys", "lib/plugins/deploy/deploy.js->program->class_declaration:Deploy->method_definition:constructor"] |
serverless/serverless | 4,372 | serverless__serverless-4372 | ['4325'] | b8e4089e396fe6b595d5116d381fb2fcb5a03eb5 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index ff68cfbc3cc..aa593e44713 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -277,6 +277,7 @@ functions:
resultTtlInSeconds: 0
identitySource: ... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/authorizers.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/authorizers.test.js
index aa32f062c91..ee84ad8a24b 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/authorizers.test.js
+++ b/lib/plugins/aws/package/compile/e... | Change Authorizer type to "REQUEST" (instead of "TOKEN")
# This is a Feature Proposal
## Description
Change Authorizer type to "REQUEST" (instead of "TOKEN") so that the Authorizer function receives all of the parameters passed to the main function (through lamba-proxy).
As-is, it is not possible to use any parame... | Thank you for the suggestion @craigdrayton 😁 That's a nice idea 👍
Only one concern is that it would be a breaking change. We need to confirm that.
To avoid the breaking change, could leave TOKEN as the default with REQUEST available as an option. Cheers :-)
Thank @craigdrayton for getting back 🙌
How do the param... | 2017-10-10 18:50:14+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() throw error if authorizer property is not a string or object', '#validate() should throw if request is malformed', '#validate() should han... | ['#compileAuthorizers() should apply optional provided type value to Authorizer Type', '#validate() should accept authorizer config with a type'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/authorizers.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer", "lib/plugins/aws/package/compile/events/apiGateway/lib/authorizers.js->program->method_definition:compileAuthorizers"] |
serverless/serverless | 4,293 | serverless__serverless-4293 | ['4252'] | e251dc7e21204a7617a10f6c1847ed76ace25d5b | diff --git a/docs/providers/aws/cli-reference/deploy.md b/docs/providers/aws/cli-reference/deploy.md
index a7ad350e0f9..66204c690a9 100644
--- a/docs/providers/aws/cli-reference/deploy.md
+++ b/docs/providers/aws/cli-reference/deploy.md
@@ -25,6 +25,7 @@ serverless deploy
- `--verbose` or `-v` Shows all stack events d... | diff --git a/lib/plugins/aws/deploy/lib/createStack.test.js b/lib/plugins/aws/deploy/lib/createStack.test.js
index 235726b5ea4..a75e8e8f6e2 100644
--- a/lib/plugins/aws/deploy/lib/createStack.test.js
+++ b/lib/plugins/aws/deploy/lib/createStack.test.js
@@ -28,7 +28,7 @@ describe('createStack', () => {
beforeEach(() ... | Add Amazon S3 Transfer Acceleration support
# This is a Feature Proposal
## Description
The framework could optionally enable S3 Transfer Acceleration and use the s3-accelerate endpoint to upload heavy deployment packages.
* **Use case**: heavy deployment packages or "remote" regions
## Additional Data
F... | P.s. You can also run a multi-region test, wherever you are in the world :)
http://s3-accelerate-speedtest.s3-accelerate.amazonaws.com/en/accelerate-speed-comparsion.html
(I got a +9000% improvement for the Sydney region!)
Great proposal! I agree.
If it is possible, it would be better to use a deploymentbucket w... | 2017-09-21 05:25:46+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #getStage() should use the default dev in lieu of options, config, and provider', 'AwsProvider #constructor() when checking for the deploymentBucket config should save the object and use the name for the deploymentBucket if provided', 'AwsProvider #getCredentials() should load async profiles properly', 'A... | ['AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'AwsProvider #isS3TransferAccelerationEnabled() should return true when CLI option is provided', 'AwsProvider #canUseS3TransferAcceleration() should return false by default with S3.putObject too', 'AwsProvider #... | ['#generateCoreTemplate() should add a custom output if S3 Transfer Acceleration is enabled', 'createStack #createStack() should throw error if describeStackResources fails for other reason than not found', 'AwsProvider #getAccountId() should return the AWS account id', 'createStack #create() should include custom stac... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js lib/plugins/aws/package/lib/generateCoreTemplate.test.js lib/plugins/aws/deploy/lib/uploadArtifacts.test.js lib/plugins/aws/deploy/lib/createStack.test.js --reporter json | Feature | false | false | false | true | 8 | 1 | 9 | false | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:enableS3TransferAcceleration", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:isS3T... |
serverless/serverless | 4,279 | serverless__serverless-4279 | ['4272', '4272'] | 7893bc95e6fb3a6ba36fa6a4803c98c896c81196 | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index 5e0b3f7d41f..75fd3d89e15 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -67,8 +67,10 @@ class PluginManager {
}
// don't load plugins twice
- const loadedPlugins = this.plugins.map(plugin => pl... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index 9fec8833b45..95864844cef 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -546,6 +546,28 @@ describe('PluginManager', () => {
expect(pluginManager.plugins.length).to.equal(1);
})... | Deduplication during plugins loading may cause plugin to be excluded unintentionally (without any warning)
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidel... | 2017-09-18 18:51:06+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #validateOptions() should throw an error if a customValidation is not met', 'PluginManager #run() should run commands with internal lifecycles', 'PluginManager #getCommands() shou... | ['PluginManager #addPlugin() should load two plugins that happen to have the same class name'] | ['PluginManager #loadCommands() should log the alias when SLS_DEBUG is set'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:addPlugin"] | |
serverless/serverless | 4,198 | serverless__serverless-4198 | ['4172'] | 9826d40a6ba9134c22d0fd55e00927309413ee61 | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index 2b306946120..5e0b3f7d41f 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -34,6 +34,7 @@ class PluginManager {
this.plugins = [];
this.commands = {};
+ this.aliases = {};
this.hooks = {};
... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index b784c58ddf6..9fec8833b45 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -1,5 +1,7 @@
'use strict';
+/* eslint-disable no-unused-expressions */
+
const chai = require('chai');
let Plug... | Add alias support for plugin commands to the PluginManager
# This is a Feature Proposal
## Description
The plugin manager should support `alias` so that the CLI usage can be expressed through different commands (e.g. `serverless deploy function` or `serverless function deploy`).
@HyperBrain has already done so... | null | 2017-09-03 16:20:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #spawn() when invoking an entrypoint should succeed', 'PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #run() should throw an error when the given command is an entrypoint', 'PluginManager #validateOptions() shoul... | ['PluginManager command aliases #getAliasCommandTarget should return undefined if alias does not exist', 'PluginManager #loadCommands() should fail if there is already an alias for a command', 'PluginManager command aliases #createCommandAlias should create an alias for a command', 'PluginManager command aliases #creat... | ['PluginManager #loadCommands() should log the alias when SLS_DEBUG is set'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js --reporter json | Feature | false | false | false | true | 6 | 1 | 7 | false | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadCommand", "lib/classes/PluginManager.js->program->class_declaration:PluginManager", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:getCommands", "lib/classes/PluginManager.js->prog... |
serverless/serverless | 4,197 | serverless__serverless-4197 | ['4711'] | 0001b7e5fe0bc6f2a9e0684e147d183163a05c80 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/authorization.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/authorization.js
index 62e0acfa61d..d295b11efff 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/authorization.js
+++ b/lib/plugins/aws/packa... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index c81ed7edb3a..e24dc8719c0 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | Cannot reference an authorizer already created within services that shares the same API GW
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://gi... | null | 2017-09-02 15:48:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileMethods() should add multiple response templates for a custom response codes', '#compileMethods() should add method responses for different status codes', '#compileMethods() should set api key as not required if private property is not specified', '#compileMethods() when dealing with request configuration sho... | ['#compileMethods() should set custom authorizer config with authorizeId'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer", "lib/plugins/aws/package/compile/events/apiGateway/lib/method/authorization.js->program->method_definition:getMethodAuthorization"] |
serverless/serverless | 4,192 | serverless__serverless-4192 | ['3204'] | a43ffcb4de11f56637b3e85683d78ea5d53d0c4d | diff --git a/docs/providers/aws/cli-reference/deploy.md b/docs/providers/aws/cli-reference/deploy.md
index bf05e94d060..e00d262cadc 100644
--- a/docs/providers/aws/cli-reference/deploy.md
+++ b/docs/providers/aws/cli-reference/deploy.md
@@ -23,6 +23,7 @@ serverless deploy
- `--region` or `-r` The region in that stage ... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index bab03ad6698..b784c58ddf6 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -1,6 +1,6 @@
'use strict';
-const expect = require('chai').expect;
+const chai = require('chai');
let PluginMana... | UX Improvement: Make deploy function easier
Can't tell you how many times I type `sls deploy -f functionName` and forget the word function... and then have to wait for the whole stack to update.
Can we alias `sls deploy -f functionName` to `sls deploy function -f functionName` as a quick UX win?
So if a user typ... | I always mistake the same too..
+1
This could be an interesting UX win. I will say I've retrained my muscle memory around some bash aliases... `alias sdf="serverless deploy --function $1"` then I can just `sdf functionName`. Saved me some time here and there.
Nice idea! 👍
IMHO nested commands (more than one level... | 2017-09-01 10:26:23+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #spawn() when invoking an entrypoint should succeed', 'PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #run() should throw an error when the given command is an entrypoint', 'PluginManager #spawn() should spawn en... | ['PluginManager #spawn() when invoking a command should terminate the hook chain if requested'] | ['Deploy "before:deploy:deploy" hook "before each" hook for "should run the validation"', 'PluginManager #updateAutocompleteCacheFile() "after each" hook for "should update autocomplete cache file"', 'PluginManager Plugin / CLI integration "before each" hook for "should expose a working integration between the CLI and ... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js lib/plugins/aws/info/index.test.js lib/plugins/deploy/deploy.test.js --reporter json | Feature | false | false | false | true | 4 | 1 | 6 | false | false | ["lib/plugins/deploy/deploy.js->program->class_declaration:Deploy->method_definition:constructor->pair:[]", "lib/classes/PluginManager.js->program->class_declaration:TerminateHookChain->method_definition:constructor", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:spawn", "li... |
serverless/serverless | 4,120 | serverless__serverless-4120 | ['4094'] | f52a09095c128355316b9e0e3a8d5e7c69b57cb0 | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index d0d3e425160..fc259198db3 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -325,7 +325,7 @@ provider:
functions:
hello:
handler: handler.hello
- onError: arn:aws:s... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index 7dc8c70f3e1..b113af97046 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -55,6 +55,16 @@ describe('Aw... | Lambda onError can't use CloudFormation "Ref", requires ARN string
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serv... | null | 2017-08-18 01:30:18+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', 'AwsCompileFunctions #compileFunctions() should add an ARN function role', 'AwsCompileFunctions #compileFunctions() should add a "Fn::ImportValue" Object function role', 'AwsCompileFunctions #c... | ['AwsCompileFunctions #isArnRefOrImportValue() should accept a Fn::ImportValue', 'AwsCompileFunctions #isArnRefOrImportValue() should reject other objects', 'AwsCompileFunctions #isArnRefOrImportValue() should accept a Ref', 'AwsCompileFunctions #compileFunctions() when using onError config when IamRoleLambdaExecution ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Bug Fix | false | false | false | true | 2 | 1 | 3 | false | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions", "lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:isArnRefOrImportValue", "lib/plugins/aws/package/compile/functions/index.js->program->class_declar... |
serverless/serverless | 4,097 | serverless__serverless-4097 | ['4072'] | f52a09095c128355316b9e0e3a8d5e7c69b57cb0 | diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md
index 81fb191168c..37d263411d6 100644
--- a/docs/providers/aws/guide/variables.md
+++ b/docs/providers/aws/guide/variables.md
@@ -273,6 +273,7 @@ provider:
stage: dev
custom:
myStage: ${opt:stage, self:provider.stage}
+ m... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index df73074f367..44981dca100 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -31,7 +31,7 @@ describe('Service', () => {
expect(serviceInstance.provider).to.deep.equal({
stage: 'dev',
region: '... | Variable system improvement: Add ability to use strings as default value
If you set the default value of a variable as a string, an error is thrown. This should be perfectly value though. (unless there is something I am missing)
```yml
service:
name: getting-started
provider:
name: aws
environment:
... | I literally tried to do this yesterday! Big :thumbsup:! | 2017-08-16 01:49:24+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #update() should update service instance data', 'Variables #getValueFromFile() should populate an entire variable exported by a javascript file', 'Variables #getValueFromFile() should throw if property exported by a javascript file is not a function', 'Service #getAllEventsInFunction() should return an array ... | ['Service #constructor() should construct with defaults'] | ['Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #populateService() should call populateProperty method', 'Variables #getValueFromSource() should call getValueFromFile if referencin... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json | Feature | false | false | false | true | 5 | 1 | 6 | false | false | ["lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat", "lib/classes/Service.js->program->class_declaration:Service->method_definition:constructor", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:constructor", "lib/classes/Variables.js->program->class_de... |
serverless/serverless | 4,091 | serverless__serverless-4091 | ['4090'] | 1dfd1ee6030e34fec2261dda430fa2583e93b45c | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index d32efc31c79..7001cc9c77a 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -71,6 +71,11 @@ class PluginManager {
this.addPlugin(Plugin);
} catch (error) {
+ // Rethrow the original error... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index 5211df188e7..bab03ad6698 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -6,6 +6,7 @@ const Serverless = require('../../lib/Serverless');
const CLI = require('../../lib/classes/CLI');
con... | Development of Local Plugins No Longer Works
# This is a Bug Report
Can no longer test a serverless plugin.
## Description
Put the plugin test-plugin in folder .serverless_plugins/test-plugin
and included it in plugins section of serverless.yml
Yet it is not recognized by serverless, says
Serve... | Hey @kornatzky ,
I had the same issue yesterday.
I guess that you have some error in your test-plugin. npm install maybe?
If the plugin throws an exception when "required", the framework will print the "not found" error.
@pmuens as I said in the previous comment,
If the plugin throws an exception when "required",... | 2017-08-15 09:42:50+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #spawn() when invoking an entrypoint should succeed', 'PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #run() should throw an error when the given command is an entrypoint', 'PluginManager #spawn() should spawn en... | ['PluginManager #loadPlugins() should forward any errors when trying to load a broken plugin (with SLS_DEBUG)'] | ['PluginManager Plugin / CLI integration "before each" hook for "should expose a working integration between the CLI and the plugin system"', 'PluginManager #updateAutocompleteCacheFile() "before each" hook for "should update autocomplete cache file"', 'PluginManager #updateAutocompleteCacheFile() "after each" hook for... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadPlugins"] |
serverless/serverless | 4,088 | serverless__serverless-4088 | ['4078'] | 1dfd1ee6030e34fec2261dda430fa2583e93b45c | diff --git a/lib/plugins/aws/info/display.js b/lib/plugins/aws/info/display.js
index 0ba36cbf407..10cf9a6b372 100644
--- a/lib/plugins/aws/info/display.js
+++ b/lib/plugins/aws/info/display.js
@@ -11,7 +11,8 @@ module.exports = {
message += `${chalk.yellow.underline('Service Information')}\n`;
message += `${c... | diff --git a/lib/plugins/aws/info/display.test.js b/lib/plugins/aws/info/display.test.js
index 84f64f58649..22b955c9e0a 100644
--- a/lib/plugins/aws/info/display.test.js
+++ b/lib/plugins/aws/info/display.test.js
@@ -28,6 +28,7 @@ describe('#display()', () => {
service: 'my-first',
stage: 'dev',
... | Display Stack Name with `sls info -v`
# This is a Feature Proposal
## Description
It's difficult to configure variables using the [CloudFormation output syntax](https://serverless.com/framework/docs/providers/aws/guide/variables/#reference-cloudformation-outputs) (`${cf:stackName.outputKey}`) as it's unclear wher... | How about something like this?
Fits in quite nicely with the current output:
<img width="538" alt="screenshot 2017-08-14 16 58 25" src="https://user-images.githubusercontent.com/28390/29261277-09dcfce6-8112-11e7-89ff-0abeec1c7159.png">
| 2017-08-14 23:17:58+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#display() should display API keys if given', '#display() should display functions if given', '#display() should display CloudFormation outputs when verbose output is requested', '#display() should display endpoints if given'] | ['#display() should display general service info'] | ['#getStackInfo() should resolve if result is empty', '#getStackInfo() attach info from describeStack call to this.gatheredData if result is available'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/info/display.test.js lib/plugins/aws/info/getStackInfo.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/info/display.js->program->method_definition:displayServiceInfo", "lib/plugins/aws/info/getStackInfo.js->program->method_definition:getStackInfo"] |
serverless/serverless | 4,084 | serverless__serverless-4084 | ['4083', '4083'] | 0ff7b8463f127d3f321c1aedc2c00ed2be552049 | diff --git a/lib/plugins/aws/package/compile/events/stream/index.js b/lib/plugins/aws/package/compile/events/stream/index.js
index 695d88f18f8..61820a09445 100644
--- a/lib/plugins/aws/package/compile/events/stream/index.js
+++ b/lib/plugins/aws/package/compile/events/stream/index.js
@@ -136,6 +136,11 @@ class AwsCompi... | diff --git a/lib/plugins/aws/package/compile/events/stream/index.test.js b/lib/plugins/aws/package/compile/events/stream/index.test.js
index d3b455df06c..1571bab4ed8 100644
--- a/lib/plugins/aws/package/compile/events/stream/index.test.js
+++ b/lib/plugins/aws/package/compile/events/stream/index.test.js
@@ -217,6 +217,... | Unresolved resource dependencies when using Fn::ImportValue for role in function with kinesis event handler
# This is a Bug Report
## Description
When I have a AWS service with a function that defines both a kinesis stream endpoint and a role a cloudformation import (using Fn::ImportValue) I receive the followin... | 2017-08-14 06:02:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role is set in provider', 'AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role reference is set in provider', 'AwsCompileStreamEvents #compileStreamEvents() should throw an error if stream event type... | ['AwsCompileStreamEvents #compileStreamEvents() should not throw error if IAM role is imported'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/stream/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/stream/index.js->program->class_declaration:AwsCompileStreamEvents->method_definition:compileStreamEvents"] | |
serverless/serverless | 4,050 | serverless__serverless-4050 | ['2970'] | 0530627b33072a4c65321ec7b62425a5cad02502 | diff --git a/lib/plugins/aws/configCredentials/awsConfigCredentials.js b/lib/plugins/aws/configCredentials/awsConfigCredentials.js
index 03b960a99fd..ea53216e836 100644
--- a/lib/plugins/aws/configCredentials/awsConfigCredentials.js
+++ b/lib/plugins/aws/configCredentials/awsConfigCredentials.js
@@ -1,7 +1,9 @@
'use s... | diff --git a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
index 21838e17881..8a9561158d7 100644
--- a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
+++ b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
@@ ... | AWS credentials file created with serverless config credentials should have more strict permissions!
The AWS credentials files in `~/.aws/credentials` is created by `serverless config credentials` with world-readable permissions, more exactly with `rw-rw-r--` (0664). In a shared environment this is a security issue. Th... | null | 2017-08-06 22:44:38+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsConfigCredentials #constructor() should have the sub-command "credentials"', 'AwsConfigCredentials #getProfileBoundaries() should return the start and end numbers of the profile', 'AwsConfigCredentials #configureCredentials() should add the missing credentials to the updated profile', 'AwsConfigCredentials #config... | ['AwsConfigCredentials #configureCredentials() should set the permissions of the credentials file to be owner-only read/write'] | ['AwsConfigCredentials #constructor() should run promise chain in order for "config:credentials:config" hook'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/configCredentials/awsConfigCredentials.test.js --reporter json | Security | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/configCredentials/awsConfigCredentials.js->program->class_declaration:AwsConfigCredentials->method_definition:saveCredentialsFile"] |
serverless/serverless | 3,996 | serverless__serverless-3996 | ['3965'] | 5fac1498865334e8e719fc281824f42b0ec48d27 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index fe0c9444de0..567974abdfd 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -252,7 +252,7 @@ class Variables {
' Check if your javascript is exporting a function that returns a value.',
].join(''));
... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 8ce01fdc9d5..e4b9db61a33 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -683,7 +683,7 @@ describe('Variables', () => {
});
});
- it('should thow if property exported by a javascript fil... | 1.18.0 breaks referencing variables in Javascript Files
# This is a Bug Report
## Description
This might be considered an edge case based upon how I make use of a JavaScript configuration file but thought I would share this issue nonetheless as it tripped me up when I went to do a deploy this evening after updati... | @indieisaconcept thanks for reporting! thats a pretty creative edge case! have you been able to reproduce it with a simpler config? just wondering if it's a bigger issue than we think.
a PR with the fix would be great! 😊
We're seeing this too. Libraries like `request` rely on it somehow, and are breaking. Revertin... | 2017-07-26 03:57:37+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #warnIfNotFound() should log if variable has empty object value.', 'Variables #getValueFromSource() should throw error if referencing an invalid source', 'Variables #populateVariable() should populate string variables as sub string', 'Variables #populateVariable() should populate number variables as sub str... | ['Variables #getValueFromFile() should preserve the exported function context when executing'] | ['Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #populateService() should call populateProperty method', 'Variables #getValueFromSource() should call getValueFromFile if referencin... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromFile"] |
serverless/serverless | 3,903 | serverless__serverless-3903 | ['3862'] | bf1d07663e6963ed36b346915bcf79078fa4e223 | diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js
index c7354fb43bc..2bea7448aeb 100644
--- a/lib/plugins/aws/provider/awsProvider.js
+++ b/lib/plugins/aws/provider/awsProvider.js
@@ -146,11 +146,22 @@ class AwsProvider {
f()
.then(resolve)
.ca... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index f4b8e7705c4..d796dd19ee1 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -3,6 +3,7 @@
const expect = require('chai').expect;
const proxyquire =... | DX: Improve invalid aws credentials message
After running `serverless invoke -f hello` with invalid creds on my machine (for testing). I see this:
The current error message "The security token included in ... | This is super annoying.
I always face this because of MFA. It's returned bey the `aws-sdk` if the MFA token expired. So nothing credentials related.
Re-authenticating via `assume-role` fixes the problem for me.
Hello,
I wanted to update the error message, but also could not find it in the project's code. Has t... | 2017-07-05 19:16:30+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #getCredentials() should get credentials when profile is provied via --aws-profile option', 'AwsProvider #constructor() when checking for the deploymentBucket config should save the object and use the name for the deploymentBucket if provided', 'AwsProvider #getCredentials() should not set credentials if ... | ['AwsProvider #request() should ask to re-authenticate MFA or check if AWS credentials are valid'] | ['AwsProvider #getServerlessDeploymentBucketName() should return the name of the custom deployment bucket', 'AwsProvider #getServerlessDeploymentBucketName() #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"] |
serverless/serverless | 3,888 | serverless__serverless-3888 | ['3629'] | fadb11f9ac9f21d9a290014ba5f314809300dfa5 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 02c3364e3b0..9a5636e60bf 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -16,7 +16,7 @@ class Service {
this.provider = {
stage: 'dev',
region: 'us-east-1',
- variableSyntax: '\\${([ :a-zA-Z0-9._,\\-\\/\\(\\)]... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 22041857deb..4cca7dfa903 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -31,7 +31,7 @@ describe('Service', () => {
expect(serviceInstance.provider).to.deep.equal({
stage: 'dev',
region: '... | Variable file() fails with absolute path
# This is a Bug Report
## Description
### What went wrong?
Could not load `file()` when path given was absolute
### What did you expect should have happened?
`file()` should handle absolute paths
### What was the config you used?
```yaml
...
provider:
environ... | null | 2017-07-03 12:46:15+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #getValueFromFile() should populate non json/yml files', 'Service #load() should reject if provider property is invalid', 'Variables #getValueFromSelf() should handle self-references to the root of the serverless.yml file', "Service #validate() should throw if a function's event is not an array or a variabl... | ['Variables #getValueFromFile() should work for absolute paths with ~ ', 'Service #constructor() should construct with defaults'] | ['Variables #overwrite() should overwrite undefined and null values', 'Variables #getValueFromSource() should call getValueFromS3 if referencing variable in S3', 'Variables #overwrite() should not overwrite false values', 'Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #po... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 4 | 0 | 4 | false | false | ["lib/classes/Service.js->program->class_declaration:Service->method_definition:constructor", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromFile", "lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat", "lib/classes/Variables.js->program->cla... |
serverless/serverless | 3,866 | serverless__serverless-3866 | ['3809'] | a58c8e1c1ab36306a7a719084915573bdad3ebb8 | diff --git a/docs/providers/aws/cli-reference/config-credentials.md b/docs/providers/aws/cli-reference/config-credentials.md
index 79d8751b385..e43f2a49865 100644
--- a/docs/providers/aws/cli-reference/config-credentials.md
+++ b/docs/providers/aws/cli-reference/config-credentials.md
@@ -22,6 +22,7 @@ serverless config... | diff --git a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
index 6daad7908ae..21838e17881 100644
--- a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
+++ b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
@@ ... | Serverless config should allow override of profiles
# This is a Feature Proposal
## Description
When trying to setup an existing profile I get an error
```
serverless config credentials --provider aws --key XXX --secret YYY --profile serverless-admin
Serverless: Setting up AWS...
Serverless: Saving your AWS p... | Hey @simplesteph thanks for opening 👍
The main purpose for the error message is that we don't want to manipulate existing configurations due to potential loss / corruption of data.
Allowing only the creation of non-existent profiles enables us a way to streamline the onboarding process while still maintaining a... | 2017-06-27 11:38:29+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsConfigCredentials #constructor() should have the command "config"', 'AwsConfigCredentials #configureCredentials() should lowercase the provider option', 'AwsConfigCredentials #constructor() should have the lifecycle event "config" for the "credentials" sub-command', 'AwsConfigCredentials #configureCredentials() sh... | ['AwsConfigCredentials #getCredentials() should load credentials file and return the credentials lines', 'AwsConfigCredentials #getCredentials() should return an empty array if the file is empty', 'AwsConfigCredentials #constructor() should create the .aws/credentials file if not yet present', 'AwsConfigCredentials #co... | ['AwsConfigCredentials #constructor() should run promise chain in order for "config:credentials:config" hook'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/configCredentials/awsConfigCredentials.test.js --reporter json | Feature | false | false | false | true | 7 | 1 | 8 | false | false | ["lib/plugins/aws/configCredentials/awsConfigCredentials.js->program->class_declaration:AwsConfigCredentials->method_definition:updateProfile", "lib/plugins/aws/configCredentials/awsConfigCredentials.js->program->class_declaration:AwsConfigCredentials->method_definition:constructor", "lib/plugins/aws/configCredentials/... |
serverless/serverless | 3,856 | serverless__serverless-3856 | ['3580'] | 9f7e740b09ac571ecadf6c3d0a7d0a87c5c15132 | diff --git a/lib/plugins/aws/deploy/lib/extendedValidate.js b/lib/plugins/aws/deploy/lib/extendedValidate.js
index 595e7ca6b5d..965d91b3197 100644
--- a/lib/plugins/aws/deploy/lib/extendedValidate.js
+++ b/lib/plugins/aws/deploy/lib/extendedValidate.js
@@ -33,8 +33,16 @@ module.exports = {
this.serverless.serv... | diff --git a/lib/plugins/aws/deploy/lib/extendedValidate.test.js b/lib/plugins/aws/deploy/lib/extendedValidate.test.js
index 5015fb12a76..f253259950d 100644
--- a/lib/plugins/aws/deploy/lib/extendedValidate.test.js
+++ b/lib/plugins/aws/deploy/lib/extendedValidate.test.js
@@ -46,57 +46,85 @@ describe('extendedValidate'... | serverless deploy function ignores package artifact
# This is a Bug Report
## Description
### What went wrong?
Consider the below serverless.yml file
```
service: test-service
provider:
name: aws
runtime: python2.7
functions:
hello:
handler: handler.hello
package:
artifact: upload... | @ubaniabalogun `package.artifact` is a property for `sls deploy` only, mainly because you can generate a package with `sls package`, but since there's no `sls package function` command, `sls deploy function` is an independent command that packages and deploys the function.
I understand the confusion though 😊 , I th... | 2017-06-26 15:10:51+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#packageService() #getIncludes() should merge package includes', '#packageService() #getIncludes() should return an empty array if no includes are provided', 'AwsDeployFunction #constructor() should set an empty options object if no options are given', 'extendedValidate extendedValidate() should throw error if servic... | ['extendedValidate extendedValidate() should use function package level artifact when provided'] | ['#packageService() #packageFunction() "before each" hook for "should call zipService with settings"', 'AwsDeployFunction #deployFunction() "after each" hook for "should deploy the function if the hashes are different"', '#packageService() #packageAll() "before each" hook for "should call zipService with settings"', 'A... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/extendedValidate.test.js lib/plugins/aws/deployFunction/index.test.js lib/plugins/package/lib/packageService.test.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/deployFunction/index.js->program->class_declaration:AwsDeployFunction->method_definition:deployFunction", "lib/plugins/package/lib/packageService.js->program->method_definition:packageFunction", "lib/plugins/aws/deploy/lib/extendedValidate.js->program->method_definition:extendedValidate"] |
serverless/serverless | 3,848 | serverless__serverless-3848 | ['3847'] | 771e212437c19bf2761b7f7d0d58543ada816540 | diff --git a/lib/classes/CLI.js b/lib/classes/CLI.js
index 05698c36da2..28f61d851a2 100644
--- a/lib/classes/CLI.js
+++ b/lib/classes/CLI.js
@@ -146,9 +146,27 @@ class CLI {
}
generateCommandsHelp(commandsArray) {
- const command = this.serverless.pluginManager.getCommand(commandsArray);
const commandNa... | diff --git a/lib/classes/CLI.test.js b/lib/classes/CLI.test.js
index 3a1d6b326ab..fd7daceeda5 100644
--- a/lib/classes/CLI.test.js
+++ b/lib/classes/CLI.test.js
@@ -5,6 +5,7 @@
*/
const expect = require('chai').expect;
+const sinon = require('sinon');
const CLI = require('../../lib/classes/CLI');
const os = requ... | Commands Help prints entrypoint subcommands too
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/... | null | 2017-06-24 11:48:33+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['CLI #displayHelp() should return true when the "-h" parameter is given', 'CLI Integration tests should print command --help to stdout', 'CLI #displayHelp() should return true when the "--version" parameter is given', 'CLI #setLoadedPlugins() should set the loadedPlugins array with the given plugin instances', 'CLI #c... | ['CLI #generateCommandsHelp() should gather and generate the commands help info if the command can be found', 'CLI #generateCommandsHelp() should throw an error if the command could not be found'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/CLI.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/CLI.js->program->class_declaration:CLI->method_definition:generateCommandsHelp"] |
serverless/serverless | 3,846 | serverless__serverless-3846 | ['3845'] | aa7823a9dc860d76d629258abf598568a6dc6a54 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js
index 97f99637f2c..fa7f7924366 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/val... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
index 7ead5365f74..6206c757b5a 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
+++ b/lib/plugins/aws/package/compile/events/api... | When http indenting in yml isn't correct error message doesn't mention function name that has the issue
# This is a Bug Report
## Description
When a function is improperly indented like so (note path & method are not properly indented under http):
```
pingfunction:
handler: handler.ping
events:
... | null | 2017-06-23 23:56:59+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should handle expicit methods', '#validate() should throw an error when an invalid integration type was provided', '#validate() should support HTTP integration', '#validate() should throw if no uri is set in HTTP integration', '#validate() should validate the http events "method" property', '#validate() s... | ["#validate() should throw a helpful error if http event type object doesn't have a path property"] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getHttpPath"] |
serverless/serverless | 3,842 | serverless__serverless-3842 | ['3841'] | aa7823a9dc860d76d629258abf598568a6dc6a54 | diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md
index 9a406dd8077..b0e070abdbf 100644
--- a/docs/providers/aws/guide/variables.md
+++ b/docs/providers/aws/guide/variables.md
@@ -150,25 +150,43 @@ functions:
In the above example, you're referencing the entire `myCustomFile.yml... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index e06bea7ab75..217d03c06fb 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -639,6 +639,36 @@ describe('Variables', () => {
});
});
+ it('should populate an entire variable exported by a ja... | Allow whole file javascript variable exports and check for typeof function
# This is a Feature Proposal
Allow whole file javascript variable exports.
## Description
1. Currently entire yml and json files can be referenced in the serverless.yml file like so:
`custom: ${file(../myCustomFile.yml)} # You can refe... | null | 2017-06-23 18:09:42+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #getValueFromFile() should populate non json/yml files', 'Variables #getValueFromSelf() should handle self-references to the root of the serverless.yml file', 'Variables #warnIfNotFound() should detect the "service attribute" variable type', 'Variables #getValueFromOptions() should allow top-level reference... | ['Variables #getValueFromFile() should populate an entire variable exported by a javascript file'] | ['Variables #overwrite() should overwrite undefined and null values', 'Variables #getValueFromSource() should call getValueFromS3 if referencing variable in S3', 'Variables #overwrite() should not overwrite false values', 'Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #po... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromFile"] |
serverless/serverless | 3,825 | serverless__serverless-3825 | ['3784'] | 84ca99869f6ac320d5eea008bf66548da09f4b0b | diff --git a/lib/classes/CLI.js b/lib/classes/CLI.js
index 05698c36da2..b23d1559947 100644
--- a/lib/classes/CLI.js
+++ b/lib/classes/CLI.js
@@ -56,7 +56,11 @@ class CLI {
if ((commands.length === 0) ||
(commands.length === 0 && (options.help || options.h)) ||
(commands.length === 1 && (commands.... | diff --git a/lib/classes/CLI.test.js b/lib/classes/CLI.test.js
index 3a1d6b326ab..1e5022bdbe4 100644
--- a/lib/classes/CLI.test.js
+++ b/lib/classes/CLI.test.js
@@ -1,9 +1,5 @@
'use strict';
-/**
- * Test: CLI Class
- */
-
const expect = require('chai').expect;
const CLI = require('../../lib/classes/CLI');
const ... | DX: Commands should be listed alphabetically in help
# This is a Bug Report
## Description
Commands should be listed alphabetically when running `sls --help`
* What went wrong?
Not all commands are listed in alphabetical order.
<img width="695" alt="hyper" src="https://user-images.githubusercontent.com/14719... | Currently the commands are listed by the order of their definition. This leads to the commands being grouped by their defining plugins implicitly. IMO neither an alphabetic nor a plugin based order is right or wrong as both are discussable.
What if we'd add a sort option to the help command, with alphabetic being the ... | 2017-06-21 13:36:27+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['CLI #displayHelp() should return true when the "-h" parameter is given', 'CLI Integration tests should print command --help to stdout', 'CLI #displayHelp() should return true when the "--version" parameter is given', 'CLI #setLoadedPlugins() should set the loadedPlugins array with the given plugin instances', 'CLI #c... | ['CLI Integration tests should print help --verbose to stdout'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/CLI.test.js --reporter json | Bug Fix | false | false | false | true | 4 | 1 | 5 | false | false | ["lib/classes/CLI.js->program->class_declaration:CLI", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:displayHelp", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:displayCommandUsage", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:generateVerboseH... |
serverless/serverless | 3,812 | serverless__serverless-3812 | ['3731'] | 6a9e99656d3288fc797cbf9dcf7003b7b23e4413 | diff --git a/lib/Serverless.js b/lib/Serverless.js
index b8434173baf..b0a805ed59c 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -4,6 +4,7 @@ require('shelljs/global');
const path = require('path');
const BbPromise = require('bluebird');
+const uuid = require('uuid');
const os = require('os');
const CL... | diff --git a/lib/Serverless.test.js b/lib/Serverless.test.js
index b33836407b0..7095984a325 100644
--- a/lib/Serverless.test.js
+++ b/lib/Serverless.test.js
@@ -24,6 +24,10 @@ describe('Serverless', () => {
});
describe('#constructor()', () => {
+ it('should set an invocationId', () => {
+ expect(server... | Generate a unique uuid for each command invocation
# This is a Feature Proposal
## Description
In order to help us connect error tracking to specific commands we need a way of tying together the lifespan of a command invocation with the actual logs/errors of what has occurred. A simple way of doing this is to gener... | null | 2017-06-19 07:06:07+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Serverless #constructor() should have a classes object', 'Utils #findServicePath() should detect if the CWD is not a service directory', 'Utils #readFileSync() should read a file synchronously', 'Utils #appendFileSync() should append a line to a text file', 'Utils #appendFileSync() should throw error if invalid path ... | ['Serverless #constructor() should set an invocationId', 'Utils #logStat() should send the gathered information'] | ['Serverless #run() "after each" hook for "should resolve if the stats logging call throws an error / is rejected"', 'Serverless #run() "before each" hook for "should resolve if the stats logging call throws an error / is rejected"', 'Utils #writeFileDir() should create a directory for the path of the given file'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Utils.test.js lib/Serverless.test.js --reporter json | Feature | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/Serverless.js->program->class_declaration:Serverless->method_definition:constructor", "lib/utils/sentry.js->program->function_declaration:initializeErrorReporter", "lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat"] |
serverless/serverless | 3,808 | serverless__serverless-3808 | ['2242'] | 6a9e99656d3288fc797cbf9dcf7003b7b23e4413 | diff --git a/docs/providers/aws/guide/plugins.md b/docs/providers/aws/guide/plugins.md
index ce15147aeee..bf02dd37373 100644
--- a/docs/providers/aws/guide/plugins.md
+++ b/docs/providers/aws/guide/plugins.md
@@ -195,7 +195,7 @@ Option Shortcuts are passed in with a single dash (`-`) like this: `serverless f
The `op... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index d3ebcfc01fc..c74bf3aff6a 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -888,6 +888,45 @@ describe('PluginManager', () => {
});
});
+ describe('#assignDefaultOptions()', () => {... | Allow to provide a default value for plugin options
I believe it would be useful to allow a default value for plugin options.
``` js
options: {
mode: {
// eslint-disable-next-line max-len
usage: 'Specifies the mode: "local", "remote", "both"',
shortcut: 'm',
default: 'remote'
},
},
```
This has tw... | null | 2017-06-18 01:53:33+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #loadAllPlugins() should load only core plugins when no service plugins are given', 'PluginManager #spawn() when invoking an entrypoint should spawn nested entrypoints', 'PluginManager #addPlugin() should skip service related plugins which not match the services provider', 'PluginManager #run() should r... | ['PluginManager #assignDefaultOptions() should not assign default values to non-empty options', 'PluginManager #assignDefaultOptions() should assign default values to empty options'] | ['PluginManager #updateAutocompleteCacheFile() "after each" hook for "should update autocomplete cache file"', 'PluginManager #updateAutocompleteCacheFile() "before each" hook for "should update autocomplete cache file"', 'PluginManager Plugin / CLI integration "before each" hook for "should expose a working integratio... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:assignDefaultOptions", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:invoke"] |
Subsets and Splits
Top Repos by Test Count
Lists the top 1000 repositories by the number of entries, providing a basic count of entries per repository.
Unique Repo Selection
Lists unique repository names from the dataset, providing a basic overview of the repositories present.