repo stringclasses 21
values | pull_number float64 45 194k | instance_id stringlengths 16 34 | issue_numbers stringlengths 6 27 | base_commit stringlengths 40 40 | patch stringlengths 263 270k | test_patch stringlengths 312 408k | problem_statement stringlengths 38 47.6k | hints_text stringlengths 1 257k ⌀ | created_at stringdate 2016-01-11 17:37:29 2024-10-18 14:52:41 | language stringclasses 4
values | Dockerfile stringclasses 279
values | P2P stringlengths 2 10.2M | F2P stringlengths 11 38.9k | F2F stringclasses 86
values | test_command stringlengths 27 11.4k | task_category stringclasses 5
values | is_no_nodes bool 2
classes | is_func_only bool 2
classes | is_class_only bool 2
classes | is_mixed bool 2
classes | num_func_changes int64 0 238 | num_class_changes int64 0 70 | num_nodes int64 0 264 | is_single_func bool 2
classes | is_single_class bool 2
classes | modified_nodes stringlengths 2 42.2k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
serverless/serverless | 3,804 | serverless__serverless-3804 | ['2888'] | 6a9e99656d3288fc797cbf9dcf7003b7b23e4413 | diff --git a/docs/providers/aws/guide/deploying.md b/docs/providers/aws/guide/deploying.md
index 2550bd36282..e412ccc1ad8 100644
--- a/docs/providers/aws/guide/deploying.md
+++ b/docs/providers/aws/guide/deploying.md
@@ -61,6 +61,9 @@ The Serverless Framework translates all syntax in `serverless.yml` to a single A
s... | diff --git a/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js b/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js
index dedac9f6c1e..9f6d0180990 100644
--- a/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js
+++ b/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js
@@ -59,6 +59,37 @@ describe('uploadArtifacts', () =... | Deploy fails when using deploymentBucket / SSE support
I'm trying to use `serverless deploy` with a pre-existing bucket for the deployment package. When I add the `deploymentBucket` value in the provider I get the following error: **self signed certificate in certificate chain**
If I remove `deploymentBucket` the ... | I think this might be caused by the requirement on our buckets for server side encryption. I'll try and test later with a bucket without this policy.
```
{
"Sid": "DenyNoEncryption",
"Effect": "Deny",
"Principal": {
"AWS": "*"
},
... | 2017-06-16 07:21:01+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #getCredentials() should get credentials when profile is provied via --aws-profile option', 'AwsProvider #getCredentials() should not set credentials if profile is not set', 'AwsProvider #constructor() when checking for the deploymentBucket config should do nothing if the deploymentBucket config is not us... | ['AwsProvider #constructor() when checking for the deploymentBucket config should save the object and use the name for the deploymentBucket if provided', 'AwsProvider #constructor() when checking for the deploymentBucket config should save the object and nullify the name if it is not provided', 'AwsProvider #getCredent... | ['uploadArtifacts #uploadZipFile() should upload to a bucket with server side encryption bucket policy', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'uploadArtifacts #uploadArtifacts() should run promise chain in order', 'uploadArtifacts #uploadFunction... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/uploadArtifacts.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json | Feature | false | false | false | true | 6 | 1 | 7 | false | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:constructor", "lib/plugins/aws/deploy/lib/uploadArtifacts.js->program->function_declaration:setServersideEncryptionOptions", "lib/classes/Service.js->program->class_declaration:Service", "lib/classes/Service.js->program... |
serverless/serverless | 3,799 | serverless__serverless-3799 | ['3773', '3773'] | fa6b32ce5e1258b656c6729ad024cd85d4a006d0 | diff --git a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js b/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js
index d94063701c0..76f0a4c054c 100644
--- a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js
+++ b/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js... | diff --git a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js b/lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js
index 6ec9a6c2805..a67e80bb712 100644
--- a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js
+++ b/lib/plugins/aws/package/compile/events/cognitoUs... | Support for Cognito User Pool Triggers isn't working.
# This is a Bug Report
## Description
Support for Cognito User Pool Triggers isn't working.
For bug reports:
* What went wrong?
Cannot link lamda to cognito user pool triggers
* What did you expect should have happened?
Cognito user pool triggers should hav... | Thanks for opening @keshavkaul 👍
The `<pool id>` you're describing here should be the resource logical id for your Cognito user pool. Serverless will create this one for you.
Do you try to re-use an existing one here? What have you put in there (what's your `<pool id>`)?
Additionally could you maybe share th... | 2017-06-14 23:28:53+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileCognitoUserPoolEvents #compileCognitoUserPoolEvents() should throw an error if the "trigger" property is invalid', 'AwsCompileCognitoUserPoolEvents #compileCognitoUserPoolEvents() should not create resources when CUP events are not given', 'AwsCompileCognitoUserPoolEvents #compileCognitoUserPoolEvents() sho... | ['AwsCompileCognitoUserPoolEvents #mergeWithCustomResources() should merge custom resources found in Resources', 'AwsCompileCognitoUserPoolEvents #mergeWithCustomResources() should merge `DependsOn` clauses correctly if being overridden from Resources', 'AwsCompileCognitoUserPoolEvents #mergeWithCustomResources() does ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js --reporter json | Bug Fix | false | false | false | true | 5 | 1 | 6 | false | false | ["lib/plugins/aws/package/compile/events/cognitoUserPool/index.js->program->class_declaration:AwsCompileCognitoUserPoolEvents", "lib/plugins/aws/package/compile/events/cognitoUserPool/index.js->program->class_declaration:AwsCompileCognitoUserPoolEvents->method_definition:constructor", "lib/plugins/aws/package/compile/e... |
serverless/serverless | 3,746 | serverless__serverless-3746 | ['3501'] | 7e65a22a8ba2a27b7e700846b186390d05338252 | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index 5bae71ec90f..8e7d7b2acc0 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -173,9 +173,26 @@ class PluginManager {
}
getCommands() {
- // Return filtered list of visible commands
- const cmds = _.o... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index 7ee6e6fa283..3ea06eefd0a 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -240,6 +240,13 @@ describe('PluginManager', () => {
'event2',
],
},
+ ... | Nested internal entry point commands are shown in the help screen
# This is a Bug Report
## Description
Commands of type "entrypoint" can be nested. The help screen (invoke "serverless") hides
entry points that are declared at the top level, but still shows entrypoints that are nested below
visible commands.
... | null | 2017-06-07 15:23:00+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #loadAllPlugins() should load only core plugins when no service plugins are given', 'PluginManager #spawn() when invoking an entrypoint should spawn nested entrypoints', 'PluginManager #addPlugin() should skip service related plugins which not match the services provider', 'PluginManager #run() should r... | ['PluginManager #getCommands() should hide entrypoints on any level and only return commands'] | ['PluginManager Plugin / CLI integration "before each" hook for "should expose a working integration between the CLI and the plugin system"'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:getCommands"] |
serverless/serverless | 3,737 | serverless__serverless-3737 | ['2709'] | 6a9e99656d3288fc797cbf9dcf7003b7b23e4413 | diff --git a/docs/providers/aws/guide/packaging.md b/docs/providers/aws/guide/packaging.md
index 1dabdf63430..fa9878c209b 100644
--- a/docs/providers/aws/guide/packaging.md
+++ b/docs/providers/aws/guide/packaging.md
@@ -130,3 +130,9 @@ functions:
package:
individually: true
```
+
+### Development dependen... | diff --git a/lib/plugins/package/lib/packageService.test.js b/lib/plugins/package/lib/packageService.test.js
index 00c4a592f96..4fae5d2cecf 100644
--- a/lib/plugins/package/lib/packageService.test.js
+++ b/lib/plugins/package/lib/packageService.test.js
@@ -168,21 +168,21 @@ describe('#packageService()', () => {
co... | DX: Zip only production relevant node_modules to decrease bundle size
# This is a Feature Proposal
## Description
At the moment everything inside `node_modules` is being zipped and uploaded to s3.
If we would create a plugin for zipping the service (to not only be dependent on node.js), we could leverage npm (or a... | I wrote a plugin for this, called serverless-plugin-include-dependencies - give it a try?
Awesome @dougmoscrop! 🎉
Thanks for sharing!
BTW here's the link https://github.com/dougmoscrop/serverless-plugin-include-dependencies
@dougmoscrop cool, I guess you'll want to add it to the [list of plugins](https://github.c... | 2017-06-06 11:26:11+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#packageService() #getIncludes() should merge package includes', '#packageService() #getIncludes() should return an empty array if no includes are provided', '#packageService() #getExcludes() should exclude defaults', '#packageService() #getExcludes() should merge defaults with excludes', '#packageService() #getInclu... | ['zipService #excludeDevDependencies() when dealing with Node.js runtimes should exclude dev dependencies in the services root directory', 'zipService #zip() should throw an error if no files are matched', 'zipService #zip() should keep file permissions', 'zipService #excludeDevDependencies() when dealing with Node.js ... | ['#packageService() #packageFunction() "before each" hook for "should call zipService with settings"', '#packageService() #packageAll() "before each" hook for "should call zipService with settings"', '#packageService() #packageService() should package single function individually', 'zipService #zipService() "after each... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/package/lib/zipService.test.js lib/plugins/package/lib/packageService.test.js --reporter json | Feature | false | true | false | false | 7 | 0 | 7 | false | false | ["lib/plugins/package/lib/packageService.js->program->method_definition:packageAll", "lib/plugins/package/lib/zipService.js->program->method_definition:zip", "lib/plugins/package/lib/zipService.js->program->method_definition:zipService", "lib/plugins/package/lib/zipService.js->program->function_declaration:excludeNodeD... |
serverless/serverless | 3,722 | serverless__serverless-3722 | ['2882'] | 341198420c56f765430c5556397a83e5dfdfaaf9 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 79f7a7c0f22..3f7022f9964 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -332,10 +332,6 @@ Please note that those are the API keys names, not the actual values. Once... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
index 6206c757b5a..6e9c6a12b1b 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
+++ b/lib/plugins/aws/package/compile/events/api... | Return error when lambda-proxy and req/res config user
# This is a Feature Proposal
Follow up of https://github.com/serverless/serverless/pull/2799#issuecomment-265400880. We should return error if both lambda-proxy and req/res config is used to reduce confusion.
| Counterpoint: https://github.com/serverless/serverless/issues/2990 | 2017-06-01 15:27:52+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should handle expicit methods', '#validate() should throw an error when an invalid integration type was provided', '#validate() should support HTTP integration', '#validate() should throw if no uri is set in HTTP integration', '#validate() should validate the http events "method" property', '#validate() s... | ['#validate() should remove non-parameter request/response config with LAMBDA-PROXY', '#validate() should process request parameters for lambda-proxy integration', '#validate() should show a warning message when using request / response config with LAMBDA-PROXY', '#validate() should not show a warning message when usin... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate"] |
serverless/serverless | 3,705 | serverless__serverless-3705 | ['3038'] | 17ceac5a6b171065ad0444c21f18d3daa4824ec5 | diff --git a/lib/plugins/aws/package/compile/events/s3/index.js b/lib/plugins/aws/package/compile/events/s3/index.js
index 6ad7b7c3619..707d84aaeb9 100644
--- a/lib/plugins/aws/package/compile/events/s3/index.js
+++ b/lib/plugins/aws/package/compile/events/s3/index.js
@@ -137,8 +137,21 @@ class AwsCompileS3Events {
... | diff --git a/lib/plugins/aws/package/compile/events/s3/index.test.js b/lib/plugins/aws/package/compile/events/s3/index.test.js
index ebb8568f402..00c085d83b1 100644
--- a/lib/plugins/aws/package/compile/events/s3/index.test.js
+++ b/lib/plugins/aws/package/compile/events/s3/index.test.js
@@ -163,6 +163,44 @@ describe('... | S3 implementation fails sometimes due a CloudFormation race condition
# This is a Bug Report
## Description
In our integration tests we sometimes see errors. One of them is caused by the S3 integration test suite examples. This problem didn't occur earlier, but that only might have been by luck, because everythin... | I am running into this issue I believe, trying serverless out with 2 functions, 2 buckets, 3 events (2 on one bucket, 1 on another). Any update on fixing this?
We run into the same situation from time to time too. I believe it is because we have an S3 event on one function but resulting CF script creates the bucket wi... | 2017-05-30 08:13:56+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileS3Events #compileS3Events() should throw an error if the "bucket" property is not given', 'AwsCompileS3Events #compileS3Events() should throw an error if the "rules" property is not an array', 'AwsCompileS3Events #compileS3Events() should create corresponding resources when S3 events are given', 'AwsCompile... | ['AwsCompileS3Events #compileS3Events() should add the permission resource logical id to the buckets DependsOn array'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/s3/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/s3/index.js->program->class_declaration:AwsCompileS3Events->method_definition:compileS3Events"] |
serverless/serverless | 3,701 | serverless__serverless-3701 | ['1787'] | 0736dc0a5d479cb6cb98459c433027829582b0d7 | diff --git a/docs/providers/aws/guide/credentials.md b/docs/providers/aws/guide/credentials.md
index 2530c7a07c8..9df7ca11f06 100644
--- a/docs/providers/aws/guide/credentials.md
+++ b/docs/providers/aws/guide/credentials.md
@@ -128,6 +128,14 @@ Now you can switch per project (/ API) by executing once when you start yo... | diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js
index d183db68ce3..53d38858df4 100644
--- a/lib/plugins/aws/provider/awsProvider.test.js
+++ b/lib/plugins/aws/provider/awsProvider.test.js
@@ -251,6 +251,7 @@ describe('AwsProvider', () => {
let originalProvid... | Support for --profile argument when deploying to AWS
##### Feature Request:
it should be possible to run `serverless deploy --profile production` to use the production AWS profile. At the moment this has to be set through environment variables
##### Benefits:
- being able to easily switch profiles to deploy with
| Just to clarify, could the argument after the --profile option be any named profile that is configured on the AWS cli?
@kevinaud exactly.
okay, I'd like to work on this
Awesome, thanks. I set the labels for it. Its probably best to add it somewhere here: https://github.com/serverless/serverless/blob/990d7c5a089c204... | 2017-05-29 11:54:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #getCredentials() should not set credentials if profile is not set', 'AwsProvider #constructor() should set the provider property', 'AwsProvider #request() should call correct aws method', 'AwsProvider #getRegion() should prefer config over provider in lieu of options', 'AwsProvider #getCredentials() shou... | ['AwsProvider #getCredentials() should get credentials when profile is provied via --aws-profile option'] | ['AwsProvider #getServerlessDeploymentBucketName() should return the name of the custom deployment bucket', 'AwsProvider #getServerlessDeploymentBucketName() #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:getCredentials"] |
serverless/serverless | 3,700 | serverless__serverless-3700 | ['3652'] | 0736dc0a5d479cb6cb98459c433027829582b0d7 | diff --git a/lib/plugins/aws/invokeLocal/index.js b/lib/plugins/aws/invokeLocal/index.js
index fcaf7339de6..29a59a28130 100644
--- a/lib/plugins/aws/invokeLocal/index.js
+++ b/lib/plugins/aws/invokeLocal/index.js
@@ -92,7 +92,6 @@ class AwsInvokeLocal {
AWS_LAMBDA_FUNCTION_MEMORY_SIZE: memorySize,
AWS_LAM... | diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js
index 63001f2102f..c0e5d51726c 100644
--- a/lib/plugins/aws/invokeLocal/index.test.js
+++ b/lib/plugins/aws/invokeLocal/index.test.js
@@ -241,7 +241,6 @@ describe('AwsInvokeLocal', () => {
expect(process.env.AWS_... | Provide partial local environment across providers
# This is a Feature Proposal
## Description
https://github.com/serverless/serverless/pull/3642 Adds support for the `IS_LOCAL` environment variable during local invocations. However due to the nature of the invoke local implementation it's currently only availabl... | @pmuens You can assign this one to me - I will implement it in the next days then.
@HyperBrain great! 🎉 Thanks for jumping into that!
I'll assign you. Looking forward to the PR! | 2017-05-29 09:20:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsInvokeLocal #constructor() should set an empty options object if no options are given', 'AwsInvokeLocal #constructor() should have hooks', 'AwsInvokeLocal #loadEnvVars() it should load provider env vars', 'Invoke #constructor() should have commands', 'AwsInvokeLocal #loadEnvVars() it should overwrite provider env ... | ['Invoke #loadEnvVarsForLocal() should set IS_LOCAL', 'Invoke hooks invoke:local:loadEnvVars should be an event', 'Invoke hooks invoke:local:loadEnvVars should set IS_LOCAL', 'Invoke #constructor() should have hooks'] | ['AwsInvokeLocal #extendedValidate() it should parse a yaml file if file path is provided', 'AwsInvokeLocal #extendedValidate() should keep data if it is a simple string', 'AwsInvokeLocal #constructor() should run promise chain in order', 'AwsInvokeLocal #extendedValidate() it should parse file if relative file path is... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js lib/plugins/invoke/invoke.test.js --reporter json | Feature | false | false | false | true | 3 | 1 | 5 | false | false | ["lib/plugins/invoke/invoke.js->program->class_declaration:Invoke->method_definition:constructor->pair:[]", "lib/plugins/invoke/invoke.js->program->class_declaration:Invoke->method_definition:loadEnvVarsForLocal", "lib/plugins/invoke/invoke.js->program->class_declaration:Invoke->method_definition:constructor", "lib/plu... |
serverless/serverless | 3,692 | serverless__serverless-3692 | ['2476'] | 0736dc0a5d479cb6cb98459c433027829582b0d7 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index e4e5385b1aa..da85ecf369f 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -115,8 +115,7 @@ functions:
path: hello
method: get
cors:
-... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
index 6f06b721860..1b77b46a936 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js
+++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/... | setting multiple allowed-origins in CORS results in AWS APIG that defies W3C
# This is a Bug Report
- What went wrong?
TL;DR: Access-Control-Allow-Origin header contains multiple origins, which violates the W3C specification and makes Chrome cranky
There's a combination of things here...
The documentation and YAML s... | @mymattcarroll
Thank you very much for reporting @jokeyrhyme 👍
That makes sense! I'm only concerned that this might break existing deployments when renaming `origins` to `origin` and only supporting a string config variable.
@brianneisler @eahefnawy do you guys have any idea how we can make this change in a no... | 2017-05-26 13:38:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should throw an error when an invalid integration type was provided', '#validate() should validate the http events "method" property', '#compileMethods() when dealing with request configuration should be possible to overwrite default request templates', '#compileMethods() should add fall back headers and ... | ['#compileMethods() should add CORS origins to method only when CORS is enabled', '#validate() should throw an error if "origin" and "origins" CORS config is used', '#validate() should process cors defaults', '#compileCors() should create preflight method for CORS enabled resource'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/cors.test.js --reporter json | Bug Fix | false | true | false | false | 5 | 0 | 5 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getCors", "lib/plugins/aws/package/compile/events/apiGateway/lib/cors.js->program->method_definition:compileCors", "li... |
serverless/serverless | 3,680 | serverless__serverless-3680 | ['3683'] | 7f7a1b6c0be73ad920c865444ad1cfca0cd5d67b | diff --git a/lib/plugins/aws/package/lib/generateCoreTemplate.js b/lib/plugins/aws/package/lib/generateCoreTemplate.js
index 7d61fa7f824..ef15492bef8 100644
--- a/lib/plugins/aws/package/lib/generateCoreTemplate.js
+++ b/lib/plugins/aws/package/lib/generateCoreTemplate.js
@@ -36,6 +36,11 @@ module.exports = {
... | diff --git a/lib/plugins/aws/package/lib/generateCoreTemplate.test.js b/lib/plugins/aws/package/lib/generateCoreTemplate.test.js
index 51732129d7e..b8a0e4264c8 100644
--- a/lib/plugins/aws/package/lib/generateCoreTemplate.test.js
+++ b/lib/plugins/aws/package/lib/generateCoreTemplate.test.js
@@ -40,6 +40,25 @@ describe... | DX: Improve the error message when deploymentBucket returns statuscode 403
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverl... | null | 2017-05-24 21:35:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | [] | ['#generateCoreTemplate() should reject an S3 bucket that does not exist'] | ['#generateCoreTemplate() should handle inconsistent getBucketLocation responses for eu-west-1 region', '#generateCoreTemplate() should reject an S3 bucket in the wrong region', '#generateCoreTemplate() should validate the region for the given S3 bucket', '#generateCoreTemplate() should use a custom bucket if specified... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/generateCoreTemplate.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/lib/generateCoreTemplate.js->program->method_definition:generateCoreTemplate"] |
serverless/serverless | 3,672 | serverless__serverless-3672 | ['2996'] | 97116b2b9606d16ba51001b277a558a4a37186f3 | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 06f6d4a8ba2..bc07ab2ba41 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -329,3 +329,33 @@ functions:
The `onError` config currently only supports SNS topic arns due to a r... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index dd5cbbab8a3..7dc8c70f3e1 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -724,6 +724,282 @@ describe(... | Add KMS key selection to AWS provider
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTI... | Any news on this? It would be an amazing feature.
@aasmoura we had the PR #2998 from @DonMcNamara which needed some additional updates but was almost there. Maybe it's worth to look into it and build a plugin based on it.
There are currently no direct plans to add this feature into core, but some more feedback on th... | 2017-05-24 08:52:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment co... | ['AwsCompileFunctions #compileFunctions() when using awsKmsKeyArn config when IamRoleLambdaExecution is used should create necessary resources if a KMS key arn is provided', 'AwsCompileFunctions #compileFunctions() when using awsKmsKeyArn config should throw an error if config is provided as an object', 'AwsCompileFunc... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 3,660 | serverless__serverless-3660 | ['3658'] | dd7909d055bc6cc8333cbfc93f9cee5f204e9454 | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js
index a9100bbdd5d..fa67bb8ba1a 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js
+++ b/lib/plugins/aws/package/com... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index 8116320acad..da991486d0e 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | New HTTP/HTTP_PROXY integrations should not set default mapping templates
# This is a Bug Report
## Description
### Overview
The newly introduced APIG integration types HTTP and HTTP_PROXY are used, to forward requests
to HTTP endpoints, with or **without** APIG mapping.
The latter (which is the most common ... | CC @eahefnawy
Yes, that was an oversight in my previous PR which added `http` and `mock`. Once a mapping template is set (in this case the `x-form-urlencoded`) its transformation will be applied and cannot be disabled via Serverless. The only way seems to _not_ set any default mappings as @HyperBrain suggests. | 2017-05-22 16:38:53+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should throw an error when an invalid integration type was provided', '#validate() should validate the http events "method" property', '#compileMethods() when dealing with request configuration should be possible to overwrite default request templates', '#compileMethods() should add fall back headers and ... | ['#compileMethods() should support HTTP integration type'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js->program->method_definition:getMethodIntegration", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getRequestPassThrough", "lib/plugins/aws/package/compile/events/apiGateway/lib/method/integratio... |
serverless/serverless | 3,647 | serverless__serverless-3647 | ['3566'] | 953f8ac1a0bf69524e96c47673d265fcc449acda | diff --git a/docs/providers/aws/guide/intro.md b/docs/providers/aws/guide/intro.md
index dfb190472a1..2bcb2833d76 100644
--- a/docs/providers/aws/guide/intro.md
+++ b/docs/providers/aws/guide/intro.md
@@ -58,7 +58,7 @@ The Serverless Framework not only deploys your Functions and the Events that tri
### Services
-A... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 49ab96f100a..a03d7dc885c 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -122,7 +122,7 @@ describe('Service', () => {
return expect(noService.load()).to.eventually.resolve;
});
- it('should load f... | Support for Serverless.JSON
# This is a Feature Proposal
JSON support as Serverless config file (Serverless.json instead of Serverless.YML)
## Description
* Using YML feels awkard , most of the usage of lambda are done with NodeJS and Node mostly uses JSON file for configuration (Webpack, Grunt , package.json etc... | AWS currently changes its CF documentation to contain both JSON and YAML snippets, e.g. http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-method.html
YAML has a lot of advantages over JSON, e.g. using comments, assigning multiline strings to a property in a readable way.
Accord... | 2017-05-18 19:35:38+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #load() should reject if provider property is invalid', "Service #validate() should throw if a function's event is not an array or a variable", 'Service #load() should fulfill if functions property is missing', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getAllFunctionsN... | ['Service #load() should load serverless.json from filesystem', '#packageService() #getExcludes() should merge defaults with package and func excludes', '#packageService() #getExcludes() should merge defaults with excludes'] | ['#packageService() #packageFunction() "before each" hook for "should call zipService with settings"', '#packageService() #packageAll() "before each" hook for "should call zipService with settings"', '#packageService() #packageService() should package single function individually', '#packageService() #packageService() ... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Utils.test.js lib/classes/Service.test.js lib/plugins/package/lib/packageService.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/classes/Utils.js->program->class_declaration:Utils->method_definition:findServicePath", "lib/classes/Service.js->program->class_declaration:Service->method_definition:load"] |
serverless/serverless | 3,642 | serverless__serverless-3642 | ['3639'] | f4f2cf99af27098bd0444bc7b918e0d468a65ec6 | diff --git a/docs/providers/aws/cli-reference/invoke-local.md b/docs/providers/aws/cli-reference/invoke-local.md
index 56a6ee99a26..53fb5526c43 100644
--- a/docs/providers/aws/cli-reference/invoke-local.md
+++ b/docs/providers/aws/cli-reference/invoke-local.md
@@ -24,6 +24,13 @@ serverless invoke local --function funct... | diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js
index c0e5d51726c..63001f2102f 100644
--- a/lib/plugins/aws/invokeLocal/index.test.js
+++ b/lib/plugins/aws/invokeLocal/index.test.js
@@ -241,6 +241,7 @@ describe('AwsInvokeLocal', () => {
expect(process.env.AWS_... | Expose a `IS_LOCAL` environment variable if running via `sls invoke local`
# This is a Feature Proposal
## Description
When testing code locally it is sometimes important to know whether the code is ran locally or in the AWS Lambda environment. The three main reasons for us are:
* Typically we enable long stack ... | I like this!
Are there any potential downsides/clashes this can run into?
Also, eventually we will need to support this in multiple runtimes (Python, Java etc). Any thoughts on how we can achieve this? | 2017-05-18 09:00:48+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsInvokeLocal #constructor() should set an empty options object if no options are given', 'AwsInvokeLocal #constructor() should have hooks', 'AwsInvokeLocal #loadEnvVars() it should load provider env vars', 'AwsInvokeLocal #loadEnvVars() it should overwrite provider env vars', 'AwsInvokeLocal #constructor() should s... | ['AwsInvokeLocal #loadEnvVars() it should load default lambda env vars'] | ['AwsInvokeLocal #extendedValidate() it should parse a yaml file if file path is provided', 'AwsInvokeLocal #extendedValidate() should keep data if it is a simple string', 'AwsInvokeLocal #constructor() should run promise chain in order', 'AwsInvokeLocal #extendedValidate() it should parse file if relative file path is... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:loadEnvVars"] |
serverless/serverless | 3,622 | serverless__serverless-3622 | ['3511'] | 6140af1e081e8f89a950a39136073514ff0e18ef | diff --git a/lib/Serverless.js b/lib/Serverless.js
index cf893bd8f66..2bd0c6f5b92 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -89,6 +89,10 @@ class Serverless {
// (https://github.com/serverless/serverless/issues/2997)
this.service.setFunctionNames(this.processedInput.options);
+ // m... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 0493cbf7824..5c580931af0 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -170,37 +170,6 @@ describe('Service', () => {
});
});
- it('should merge resources given as an array', () => {
- const... | Referencing external config files using ${file()} fails and breaks Cloudformation template
# This is a Bug Report
## Description
#### What Went Wrong
PR #2842 indicates that it is possible to configure a service by referencing external resource files in `serverless.yml` as such
```
service: service-name
pro... | Hey, @pmuens
I'd like to take a swing at fixing this bug. Can you point me in the right direction? Any idea what code is causing it?
Hey @ubaniabalogun thanks for jumping into this!
I believe it must be somewhere here in the `Variables` class: https://github.com/serverless/serverless/blob/6cca16764df1b9d43c9981642... | 2017-05-15 15:45:22+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ["Service #load() should throw error if a function's event is not an array or a variable", 'Service #load() should throw error if frameworkVersion is not satisfied', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getAllFunctionsNames should return an empty array if there are no funct... | ['Service #mergeResourceArrays should merge resources given as an array', 'Service #mergeResourceArrays should tolerate an empty string', 'Service #mergeResourceArrays should ignore an object'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/classes/Service.js->program->class_declaration:Service", "lib/classes/Service.js->program->class_declaration:Service->method_definition:mergeResourceArrays", "lib/classes/Service.js->program->class_declaration:Service->method_definition:load", "lib/Serverless.js->program->class_declaration:Serverless->method_defi... |
serverless/serverless | 3,614 | serverless__serverless-3614 | ['3586'] | 16100d6325480adad4681edb2f1bdfa498e3d4ad | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 255f5466f99..e4e5385b1aa 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -123,6 +123,7 @@ functions:
- Authorization
- X-Api-Key
... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
index d175bcdd4b6..433126e1fa3 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js
+++ b/lib/plugins/aws/package/compile/events/api... | CORS: Add `X-Amz-User-Agent` to list of allowed headers
# This is a Feature Request
## Description
I'm using the default CORS options in our backend Lambda to allow our frontend to access it via JavaScript. In order to make this work properly I needed to add `X-Amz-User-Agent` to the list of `Access-Control-Allow... | null | 2017-05-12 14:27:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should handle expicit methods', '#validate() should throw an error when an invalid integration type was provided', '#validate() should support HTTP integration', '#validate() should throw if no uri is set in HTTP integration', '#validate() should validate the http events "method" property', '#validate() s... | ['#validate() should process cors defaults'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getCors"] |
serverless/serverless | 3,609 | serverless__serverless-3609 | ['2982'] | dd7909d055bc6cc8333cbfc93f9cee5f204e9454 | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 24c470008bc..ce8c4ea862b 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -300,3 +300,32 @@ provider:
```
These versions are not cleaned up by serverless, so make sure yo... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index f4e88847b4f..dd5cbbab8a3 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -534,6 +534,196 @@ describe(... | Support for Lambda Function DeadLetterConfig (SQS|SNS)
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/... | We need to wait for CF support for DLQ.
FYI I've created a plugin for this that will work until CF supports `DeadLetterConfig`
https://github.com/gmetzker/serverless-plugin-lambda-dead-letter
https://www.npmjs.com/package/serverless-plugin-lambda-dead-letter
#### DeadLetter Queue
Use the `deadLetter.sqs` to cr... | 2017-05-12 12:41:26+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment co... | ['AwsCompileFunctions #compileFunctions() when using onError config when IamRoleLambdaExecution is used should throw an informative error message if a SQS arn is provided', 'AwsCompileFunctions #compileFunctions() when using onError config should throw an error if config is provided as an object', 'AwsCompileFunctions ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 3,548 | serverless__serverless-3548 | ['3490'] | cc941f8171cfd9d27c4df759b9e5e15e96ef0d24 | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 818be4bb781..24c470008bc 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -263,6 +263,26 @@ functions:
TABLE_NAME: tableName2
```
+## Tags
+
+Using the `tags` confi... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index 0b60b03e084..f4e88847b4f 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -487,6 +487,53 @@ describe('... | Add support for Lambda tagging
# This is a Feature Proposal
## Description
AWS has recently introduced Lambda tagging support which makes it possible to group Lambda functions and e.g. search by groups in the console.
The framework should support Lambda tagging. Here are the corresponding docs: http://docs.aws... | One thing to keep in mind is that it's AWS specific, although one could argument that lots of function properties are currently AWS specific too.
Personally, I don't see much value there
> One thing to keep in mind is that it's AWS specific
We could prefix the parameter with `aws-tag` (which is proposed strategy ... | 2017-05-03 07:37:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment co... | ['AwsCompileFunctions #compileFunctions() should create a function resource with tags'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 3,534 | serverless__serverless-3534 | ['3362'] | c868e63d76fc5e2d74ad1a77364ba1025a5c5837 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index a903d6d2ec5..255f5466f99 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -14,11 +14,16 @@ layout: Doc
To create HTTP endpoints as Event sources for your AWS Lambd... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index 5123e7813ed..8116320acad 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | Support HTTP Proxy Api Gateway Integration Type
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/... | +
Is there any update on this?
@Alex-Mann thanks for your comment.
We're currently waiting for some more feedback on this issue. Best is to always leave a 👍 as a reaction so that we can see which issues are highly appreciated. | 2017-04-27 23:42:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should throw an error when an invalid integration type was provided', '#validate() should validate the http events "method" property', '#compileMethods() when dealing with request configuration should be possible to overwrite default request templates', '#compileMethods() should add fall back headers and ... | ['#validate() should support LAMBDA integration', '#validate() should support HTTP_PROXY integration', '#validate() should accept AWS_IAM as authorizer', '#validate() should support MOCK integration', '#compileMethods() should support HTTP integration type with custom request options', '#validate() should support HTTP ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js --reporter json | Feature | false | true | false | false | 8 | 0 | 8 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate", "lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.js->program->method_definition:compilePermissions", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition... |
serverless/serverless | 3,521 | serverless__serverless-3521 | ['3513'] | 07f837ddb67a40cee3e0c6b238e165023b4b7725 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 6d9d7d11615..eeba0a5b6bb 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -13,6 +13,7 @@ class Service {
// Default properties
this.service = null;
+ this.serviceObject = null;
this.provider = {
stage: 'dev'... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 94163ef5021..0493cbf7824 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -2,6 +2,7 @@
const path = require('path');
const YAML = require('js-yaml');
+const _ = require('lodash');
const expect = require('chai'... | Allow for service property to be an object
# This is a Feature Proposal
## Description
Allow for the the `service` property in `serverless.yml` to be an object instead of just a string. This way we can add additional service specific properties such as `version`, `license`, `description`, `email`, `repository`, e... | This could be a breaking change as all provider plugins have to implement a fallback mechanism to set the service name from "service" in case it is a string type.
Currently the service name is referenced directly in the implementation. Here's an example from provider.aws.naming:
```
getStackName() {
return `${t... | 2017-04-26 13:49:42+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ["Service #load() should throw error if a function's event is not an array or a variable", 'Service #load() should merge resources given as an array', 'Service #load() should throw error if frameworkVersion is not satisfied', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getAllFunct... | ['Service #load() should support service objects', 'Service #getServiceName() should return the service name', 'Service #load() should fail when the service name is missing', 'Service #constructor() should construct with defaults', 'Service #getServiceObject() should return the service object with all properties'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Feature | false | false | false | true | 4 | 1 | 5 | false | false | ["lib/classes/Service.js->program->class_declaration:Service->method_definition:getServiceObject", "lib/classes/Service.js->program->class_declaration:Service->method_definition:getServiceName", "lib/classes/Service.js->program->class_declaration:Service", "lib/classes/Service.js->program->class_declaration:Service->me... |
serverless/serverless | 3,507 | serverless__serverless-3507 | ['3502', '3502'] | 15fe9ec8728700421b5d8404b5eaffdd2025cf3f | diff --git a/docs/providers/aws/guide/plugins.md b/docs/providers/aws/guide/plugins.md
index 464dd49e5f6..ce15147aeee 100644
--- a/docs/providers/aws/guide/plugins.md
+++ b/docs/providers/aws/guide/plugins.md
@@ -319,3 +319,24 @@ module.exports = MyPlugin;
### Command Naming
Command names need to be unique. If we l... | diff --git a/lib/plugins/aws/info/display.test.js b/lib/plugins/aws/info/display.test.js
index 273290d4779..84f64f58649 100644
--- a/lib/plugins/aws/info/display.test.js
+++ b/lib/plugins/aws/info/display.test.js
@@ -47,14 +47,8 @@ describe('#display()', () => {
expectedMessage += `${chalk.yellow('service:')} my-f... | Add additional hooks/entry points to the info plugin
# This is a Feature Proposal
## Description
Currently the info plugin writes its output en bloc.
```
Service Information
service: auth
stage: dev
region: us-east-1
api keys:
None
endpoints:
None
functions:
postauth: auth-dev-postauth
auth... | 2017-04-24 11:33:48+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | [] | ['#display() should display CloudFormation outputs when verbose output is requested', '#display() should display endpoints if given', '#display() should display general service info', '#display() should display API keys if given', '#display() should display functions if given'] | ['AwsInfo "after each" hook for "should have hooks"', 'AwsInfo "before each" hook for "should have hooks"'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/info/index.test.js lib/plugins/aws/info/display.test.js --reporter json | Feature | false | false | false | true | 7 | 0 | 8 | false | false | ["lib/plugins/aws/info/display.js->program->method_definition:displayStackOutputs", "lib/plugins/aws/info/index.js->program->class_declaration:AwsInfo->method_definition:constructor", "lib/plugins/aws/info/index.js->program->class_declaration:AwsInfo->method_definition:constructor->pair:[]", "lib/plugins/aws/info/displ... | |
serverless/serverless | 3,505 | serverless__serverless-3505 | ['3473'] | 73cdeb96cbe9ab96c6e1042e25325647c9adb986 | diff --git a/docs/providers/aws/events/sns.md b/docs/providers/aws/events/sns.md
index 3481150fa95..2dd1b2d091c 100644
--- a/docs/providers/aws/events/sns.md
+++ b/docs/providers/aws/events/sns.md
@@ -50,6 +50,15 @@ functions:
- sns: arn:xxx
```
+```yml
+functions:
+ dispatcher:
+ handler: dispatcher.disp... | diff --git a/lib/plugins/aws/package/compile/events/sns/index.test.js b/lib/plugins/aws/package/compile/events/sns/index.test.js
index d59af889eef..edcbe67d0a8 100644
--- a/lib/plugins/aws/package/compile/events/sns/index.test.js
+++ b/lib/plugins/aws/package/compile/events/sns/index.test.js
@@ -134,7 +134,7 @@ describ... | Update SNS event to support arn config parameter
# This is a Feature Proposal
## Description
#3443 recently added the functionality to use intrinsic functions for `arn` definitions. The `sns` event also supports the usage of `arn` like this:
```yml
functions:
hello:
handler: handler.hello
events:... | I have been working on this.
Awesome! Thanks @horike37 🥇
Excited about the PR! 💯 Let us know if you need any help here. | 2017-04-23 14:03:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileSNSEvents #compileSNSEvents() should create SNS topic when arn and topicName are given as object properties', 'AwsCompileSNSEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileSNSEvents #compileSNSEvents() should create SNS topic when arn is given as a string', ... | ['AwsCompileSNSEvents #compileSNSEvents() should create SNS topic when only arn is given as an object property'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/sns/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:compileSNSEvents"] |
serverless/serverless | 3,457 | serverless__serverless-3457 | ['3142'] | fea269947104889165e3ebb0f64638921caf2052 | diff --git a/lib/plugins/aws/package/compile/events/stream/index.js b/lib/plugins/aws/package/compile/events/stream/index.js
index a0bb4ab366b..695d88f18f8 100644
--- a/lib/plugins/aws/package/compile/events/stream/index.js
+++ b/lib/plugins/aws/package/compile/events/stream/index.js
@@ -136,6 +136,8 @@ class AwsCompil... | diff --git a/lib/plugins/aws/package/compile/events/stream/index.test.js b/lib/plugins/aws/package/compile/events/stream/index.test.js
index 0ebc32de75e..d3b455df06c 100644
--- a/lib/plugins/aws/package/compile/events/stream/index.test.js
+++ b/lib/plugins/aws/package/compile/events/stream/index.test.js
@@ -136,6 +136,... | Serverless fails to deploy service with a kinesis stream event: Unresolved resource dependencies [IamPolicyLambdaExecution] in the Resources block of the template
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so the... | Hey @aashish004 thanks for reporting.
We're currently working on fixes for the stream support in those PRs here:
- https://github.com/serverless/serverless/pull/3111
- https://github.com/serverless/serverless/pull/3083
- https://github.com/serverless/serverless/pull/3141
Those will be merged the upcoming day... | 2017-04-12 03:56:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role reference is set in provider', 'AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB stream ARN is given should allow specifying DynamoDB and Kinesis streams as CFN reference types', 'AwsCompileStreamEvents #compileStream... | ['AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role name reference is set in function', 'AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role name reference is set in provider'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/stream/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/stream/index.js->program->class_declaration:AwsCompileStreamEvents->method_definition:compileStreamEvents"] |
serverless/serverless | 3,443 | serverless__serverless-3443 | ['3295'] | b1a880c30d9c92c2bd0c14d7bb98b8ff38baa5cc | diff --git a/docs/providers/aws/events/sns.md b/docs/providers/aws/events/sns.md
index a2b8689b391..3481150fa95 100644
--- a/docs/providers/aws/events/sns.md
+++ b/docs/providers/aws/events/sns.md
@@ -50,6 +50,27 @@ functions:
- sns: arn:xxx
```
+Or with intrinsic CloudFormation function like `Fn::Join` or `F... | diff --git a/lib/plugins/aws/package/compile/events/sns/index.test.js b/lib/plugins/aws/package/compile/events/sns/index.test.js
index ec0c50e2e04..d59af889eef 100644
--- a/lib/plugins/aws/package/compile/events/sns/index.test.js
+++ b/lib/plugins/aws/package/compile/events/sns/index.test.js
@@ -157,5 +157,48 @@ descri... | Support cloudformation intrinsic function reference for SNS event
# This is a Feature Proposal
## Description
Allow aws sns event definitions to use [cloudformation intrinsic function references](http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference.html) to refer to an existing... | +1 for this
This is blocking me in a specific context. I have a SNS that I did build in the `resources` section with some specific cloud formation parameters that I want to reuse in the function's events (trigger) but I cannot use any intrinsic cloud formation functions like `Fn::GetAtt`, `Fn::Join` nor any intrinsic f... | 2017-04-04 21:04:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileSNSEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileSNSEvents #compileSNSEvents() should throw an error when the event an object and the displayName is not given', 'AwsCompileSNSEvents #compileSNSEvents() should raise an error when only arn is present', 'AwsC... | ['AwsCompileSNSEvents #compileSNSEvents() should not create SNS topic when arn is provided'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/sns/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:compileSNSEvents"] |
serverless/serverless | 3,429 | serverless__serverless-3429 | ['3428'] | 2d6ff1ad69d7b87425b10e2381aca8266fef35d1 | diff --git a/lib/plugins/aws/deploy/compile/functions/index.js b/lib/plugins/aws/deploy/compile/functions/index.js
index 3df59a6a67d..7f9c21bfcfa 100644
--- a/lib/plugins/aws/deploy/compile/functions/index.js
+++ b/lib/plugins/aws/deploy/compile/functions/index.js
@@ -177,6 +177,9 @@ class AwsCompileFunctions {
... | diff --git a/lib/plugins/aws/deploy/compile/functions/index.test.js b/lib/plugins/aws/deploy/compile/functions/index.test.js
index ebe49c047e7..f243931543b 100644
--- a/lib/plugins/aws/deploy/compile/functions/index.test.js
+++ b/lib/plugins/aws/deploy/compile/functions/index.test.js
@@ -924,6 +924,23 @@ describe('AwsC... | Missing description for Lambda Version
# This is a Feature Proposal
## Description
Version of Lambda function is supported to add the properties of "Description" on [publish version](http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Lambda.html#publishVersion-property). Append the function description into v... | null | 2017-03-31 05:43:43+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment co... | ['AwsCompileFunctions #compileFunctions() should include description under version too if function is specified'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 3,217 | serverless__serverless-3217 | ['3211'] | d98dfa3e07089a8242ea4a0f3a3726e6834581ec | diff --git a/RELEASE_CHECKLIST.md b/RELEASE_CHECKLIST.md
index b7bb9bffe45..1badec74e36 100644
--- a/RELEASE_CHECKLIST.md
+++ b/RELEASE_CHECKLIST.md
@@ -6,8 +6,6 @@ This checklist should be worked through when releasing a new Serverless version.
- [ ] Look through all open issues and PRs (if any) of that milestone and... | diff --git a/lib/classes/CLI.test.js b/lib/classes/CLI.test.js
index 3a1d6b326ab..92a65b98fb5 100644
--- a/lib/classes/CLI.test.js
+++ b/lib/classes/CLI.test.js
@@ -9,7 +9,10 @@ const CLI = require('../../lib/classes/CLI');
const os = require('os');
const fse = require('fs-extra');
const exec = require('child_proces... | Deprecation Notices
To keep everyone aware of the upcoming breaking changes, we're going to focus on providing accurate deprecation notices in the CLI for any upcoming breaking change. The goal of those warnings is to just give a quick heads up for what's coming, but not how to migrate, which fits more in a migration g... | Looks good!
How do we deal with the list of deprecation warnings? E.g. if I run Serverless v1.2 (assuming that deprecation warnings were around then) do I see the list with deprecation warnings from 1.3 to the upcoming release? Or just the latest one?
Furthermore we might want to display what version the user is ... | 2017-02-09 10:09:22+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['CLI #displayHelp() should return true when the "-h" parameter is given', 'CLI Integration tests should print command --help to stdout', 'CLI #displayHelp() should return true when the "--version" parameter is given', 'CLI #setLoadedPlugins() should set the loadedPlugins array with the given plugin instances', 'CLI #c... | ['CLI #logBreakingChanges() should not log breaking changes when the "disable environment variable" is set', 'CLI #logBreakingChanges() should log breaking changes when they are provided', 'CLI #logBreakingChanges() should not log breaking changes when they are not provided'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/CLI.test.js --reporter json | Feature | false | false | false | true | 2 | 1 | 3 | false | false | ["lib/classes/CLI.js->program->class_declaration:CLI", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:constructor", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:logBreakingChanges"] |
serverless/serverless | 3,213 | serverless__serverless-3213 | ['3174'] | 78092ca194e9b3bac715f4e49c68bebb14d063a9 | diff --git a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
index 69c0886240b..ec158b4f766 100644
--- a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
@@ -11,6 +11,22 @@ module.exports = {
},
merge() {
+ ... | diff --git a/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js b/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
index b0061354c4a..4c599c166f4 100644
--- a/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
@@ -208,6 +208,29 @@ describe('#mergeIamTem... | CloudWatch logs are not created in 1.6
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUT... | @JakubMatejka thanks for reporting. You're right, I think this is a bug. This is a legacy line from when we were handling logging implicitly before. But should be changed. I'll look into it asap | 2017-02-08 14:53:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Action field', '#mergeIamTemplates() should not merge there are no functions', '#mergeIamTemplates() should add a CloudWatch ... | ['#mergeIamTemplates() should add a CloudWatch LogGroup resource if all functions use custom roles'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:merge"] |
serverless/serverless | 3,187 | serverless__serverless-3187 | ['3088'] | 53c96088a2f15c72173536ab94428c8ea5f4b7d2 | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js
index aa5cbe4bd0e..e8e040b2bf0 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js
index 95e0630871c..5123e7813ed 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/deploy/compile/ev... | Multiple claims for authorizer break body mapping template
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/b... | Temporary Fix: when the second claim is removed (```- name```) it works fine.
It's not a fix if you have to remove something you need :wink:. The temporary fix is to update the body mapping template after a deploy (which would then enable access to all claim fields).
I guess you're right, but since for my solution I d... | 2017-02-03 18:33:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileMethods() when dealing with request configuration should setup a default "application/x-www-form-urlencoded" template', '#compileMethods() should add CORS origins to method only when CORS is enabled', '#compileMethods() should add integration responses for different status codes', '#compileMethods() when deal... | ['#compileMethods() should set multiple claims for a cognito user pool', '#compileMethods() should properly set claims for custom properties inside the cognito user pool'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js->program->method_definition:compileMethods"] |
serverless/serverless | 3,186 | serverless__serverless-3186 | ['2997', '2997'] | 53c96088a2f15c72173536ab94428c8ea5f4b7d2 | diff --git a/lib/Serverless.js b/lib/Serverless.js
index fd25eab2088..4b61b125a7a 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -84,6 +84,10 @@ class Serverless {
// (https://github.com/serverless/serverless/issues/2041)
this.variables.populateService(this.pluginManager.cliOptions);
+ // popu... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 67d044e7e10..74e56f7418e 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -199,47 +199,6 @@ describe('Service', () => {
});
});
- it('should make sure function name contains the default stage', () ... | ${file(filename)} Syntax does not work for functions
# This is a Bug Report
## Attempting to include another YML or JSON file from within the "functions" declaration fails to load with the error:
`Cannot assign to read only property 'events' of $`
This traces back to the following section of the "load" routine... | I don't know why my searching didn't pull this up, but this is definitely related to Issue #2418 .
Pull request #2434 from a while back should fix this
@securityvoid @fruffin #2418 and #2434 didn't fix this issue. That fixed the ability to externalize just the events. This issue is that you cant externalize functions a... | 2017-02-03 04:17:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ["Service #load() should throw error if a function's event is not an array or a variable", 'Service #load() should merge resources given as an array', 'Service #load() should throw error if frameworkVersion is not satisfied', 'Service #getFunction() should return function object', 'Service #getAllFunctions() should ret... | ['Service #load() should support Serverless file with a non-aws provider', 'Service #load() should support Serverless file with a .yaml extension', 'Service #setFunctionNames() should make sure function name contains the default stage', 'Service #load() should support Serverless file with a .yml extension'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/classes/Service.js->program->class_declaration:Service", "lib/classes/Service.js->program->class_declaration:Service->method_definition:setFunctionNames", "lib/classes/Service.js->program->class_declaration:Service->method_definition:load", "lib/Serverless.js->program->class_declaration:Serverless->method_definit... |
serverless/serverless | 3,180 | serverless__serverless-3180 | ['2619'] | 3d3821c38518535ac89cc28ff3701c0f4ebf6ce5 | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index 4eda68d8f43..96f60ea9051 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -1,6 +1,7 @@
'use strict';
const path = require('path');
+const Module = require('module');
const BbPromise = require('bluebird');
... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index b4155d3064e..9bb3a3dd8ef 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -6,6 +6,7 @@ const Serverless = require('../../lib/Serverless');
const Create = require('../../lib/plugins/create/c... | Allow plugins to be loaded from parent node_modules folder
# This is a Feature Proposal
## Description
V.1 conflates dev dependencies and regular dependencies but gives you no easy way to exclude the dev dependencies, causing Lambdas to be larger than necessary.
V.0 resolved this issue by having dev dependen... | What folder layout are you expecting with this @ac360? Eg below.
- Root folder
- Service Folder
- serverless.yml
- node_modules
@ac360 wouldn't this be a problem for loading devDependencies like mocha as npm expects them to be in a local node_modules folder? So when I want to execute the mocha binary will it b... | 2017-02-01 21:21:14+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #loadAllPlugins() should load only core plugins when no service plugins are given', 'PluginManager #addPlugin() should skip service related plugins which not match the services provider', 'PluginManager #constructor() should create an empty cliOptions object', 'PluginManager #constructor() should create... | ['PluginManager Plugin / CLI integration should load plugins relatively to the working directory'] | [] | . /usr/local/nvm/nvm.sh && npx mocha tests/utils/index.js lib/classes/PluginManager.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadServicePlugins"] |
serverless/serverless | 3,130 | serverless__serverless-3130 | ['2740'] | 4d63ddbbf36c30cf99c63f69e83788208b2fce29 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 9d721cde7c2..02d408e2024 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -13,8 +13,7 @@ class Service {
// Default properties
this.service = null;
- this.provider = {};
- this.defaults = {
+ this.provider = {
... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 3f167655932..67d044e7e10 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -22,8 +22,7 @@ describe('Service', () => {
const serviceInstance = new Service(serverless);
expect(serviceInstance.service).... | Remove defaults property and deprecation note
# This is a Feature Proposal
## Description
The `defaults` property in the `serverless.yml` file should be removed alongside the deprecation notice.
| null | 2017-01-24 12:44:21+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Utils #readFileSync() should read a file synchronously', 'Utils #appendFileSync() should throw error if invalid path is provided', 'Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Utils #logStat() should re-use an existing file which contains the stats id if found', 'Variables #ove... | ['Variables #getValueFromSelf() should get variable from self serverless.yml file', 'Variables #getDeepValue() should get deep values with variable references', 'Service #constructor() should construct with defaults', '#validate #validate() should use the service.provider stage if present', '#validate #validate() shoul... | ['Utils "before each" hook'] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/validate.test.js lib/classes/Utils.test.js lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json | Feature | false | true | false | false | 6 | 0 | 6 | false | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:loadVariableSyntax", "lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat", "lib/classes/Service.js->program->class_declaration:Service->method_definition:constructor", "lib/classes/Service.js->program->cla... |
serverless/serverless | 3,125 | serverless__serverless-3125 | ['1825'] | 1f7ee353215435fe56d3fab3852dc3d4deb57d0e | diff --git a/lib/plugins/aws/deploy/compile/functions/index.js b/lib/plugins/aws/deploy/compile/functions/index.js
index 3c1fe204f02..af68e37d211 100644
--- a/lib/plugins/aws/deploy/compile/functions/index.js
+++ b/lib/plugins/aws/deploy/compile/functions/index.js
@@ -158,8 +158,6 @@ class AwsCompileFunctions {
... | diff --git a/lib/plugins/aws/deploy/compile/functions/index.test.js b/lib/plugins/aws/deploy/compile/functions/index.test.js
index 267f61f0d9a..cb38684b667 100644
--- a/lib/plugins/aws/deploy/compile/functions/index.test.js
+++ b/lib/plugins/aws/deploy/compile/functions/index.test.js
@@ -887,18 +887,10 @@ describe('Aws... | Refactor for the CLI function arns outputs
We should refactor the CLI function ARN outputs like @nicka has done with the endpoints in #1794.
This way we can reduce the number of outputs in the CloudFormation template.
| null | 2017-01-20 13:38:51+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsProvider #getCredentials() should not set credentials if profile is not set', 'AwsProvider #getRegion() should prefer config over provider in lieu of options', '#naming() #normalizePath() should normalize each part of the resource path and remove non-alpha-numeric characters', 'AwsCompileFunctions #compileRole() a... | ['AwsProvider #getServerlessDeploymentBucketName() #getAccountId() should return the AWS account id', 'AwsCompileFunctions #compileFunctions() should create corresponding function output and version objects', 'AwsCompileFunctions #compileFunctions() should not create function output objects when "versionFunctions" is f... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/index.test.js lib/plugins/aws/lib/naming.test.js lib/plugins/aws/info/getStackInfo.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json | Refactoring | false | false | false | true | 6 | 2 | 8 | false | false | ["lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:cfOutputDescriptionTemplate", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider", "lib/plugins/aws/lib/naming.js->program->method_definition:getLambdaOutputLogicalIdRegex... |
serverless/serverless | 3,111 | serverless__serverless-3111 | ['2365'] | 7a71a5ba298664e556213524c2d49989244ab43c | diff --git a/docs/providers/aws/events/streams.md b/docs/providers/aws/events/streams.md
index 9e506e3de45..eaf9013cd01 100644
--- a/docs/providers/aws/events/streams.md
+++ b/docs/providers/aws/events/streams.md
@@ -12,7 +12,11 @@ layout: Doc
# DynamoDB / Kinesis Streams
-This setup specifies that the `compute` f... | diff --git a/lib/plugins/aws/deploy/compile/events/stream/index.test.js b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
index d6a6f38ef91..0ebc32de75e 100644
--- a/lib/plugins/aws/deploy/compile/events/stream/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
@@ -340,6 +340,102 ... | New kinesis syntax not working
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
4. F... | Hey @yeehaa123 thanks for reaching out!
This is definitely a bug.
The solution right now is to only use ARNs instead of using `Fn::GetAtt`.
We'll look into this!
Hi Philipp,
Thanks for the quick reply.
yes, I already went back to that. Let me know, if you need help with solving this. I could attempt to make the PR... | 2017-01-17 16:26:57+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role reference is set in provider', 'AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB stream ARN is given fails if keys other than Fn::GetAtt/ImportValue are used for dynamic stream ARN', 'AwsCompileStreamEvents #compileSt... | ['AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB stream ARN is given should allow specifying DynamoDB and Kinesis streams as CFN reference types'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/stream/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/stream/index.js->program->class_declaration:AwsCompileStreamEvents->method_definition:compileStreamEvents"] |
serverless/serverless | 3,107 | serverless__serverless-3107 | ['2404', '2404'] | 6ab2040672d88d4900e05dedaa0d8448f49dd117 | diff --git a/lib/plugins/aws/deploy/lib/configureStack.js b/lib/plugins/aws/deploy/lib/configureStack.js
index 48d024c0f56..393c3d9e204 100644
--- a/lib/plugins/aws/deploy/lib/configureStack.js
+++ b/lib/plugins/aws/deploy/lib/configureStack.js
@@ -31,6 +31,7 @@ module.exports = {
.then(resultParam => {
... | diff --git a/lib/plugins/aws/deploy/lib/configureStack.test.js b/lib/plugins/aws/deploy/lib/configureStack.test.js
index be7b5e2fcbe..2a0cd50602a 100644
--- a/lib/plugins/aws/deploy/lib/configureStack.test.js
+++ b/lib/plugins/aws/deploy/lib/configureStack.test.js
@@ -110,4 +110,30 @@ describe('#configureStack', () => ... | Receive "Deployment bucket is not in the same region as the lambda function" when using us-east-1
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https:... | Thanks for reporting and investigating @briguy202 😊 .... I've pushed a fix along with [this PR](https://github.com/serverless/serverless/pull/2385) and will be merged very soon. It's a high priority!
Cheers 👼
Is there a workaround for this one? I was hoping that omitting `provider.region` would get around it but n... | 2017-01-16 10:46:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#configureStack should use a custom bucket if specified', '#configureStack should reject an S3 bucket in the wrong region', '#configureStack should validate the region for the given S3 bucket', '#configureStack should handle inconsistent getBucketLocation responses for us-east-1 region'] | ['#configureStack should handle inconsistent getBucketLocation responses for eu-west-1 region'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/configureStack.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/lib/configureStack.js->program->method_definition:configureStack"] |
serverless/serverless | 3,095 | serverless__serverless-3095 | ['3094'] | 356a3d596653e3a37bbc81f054e899961b38bd58 | diff --git a/lib/plugins/aws/deploy/compile/events/iot/index.js b/lib/plugins/aws/deploy/compile/events/iot/index.js
index 0d6b01f0740..2c56cedd06b 100644
--- a/lib/plugins/aws/deploy/compile/events/iot/index.js
+++ b/lib/plugins/aws/deploy/compile/events/iot/index.js
@@ -55,12 +55,13 @@ class AwsCompileIoTEvents {
... | diff --git a/lib/plugins/aws/deploy/compile/events/iot/index.test.js b/lib/plugins/aws/deploy/compile/events/iot/index.test.js
index aa345a7944e..44e9c756139 100644
--- a/lib/plugins/aws/deploy/compile/events/iot/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/iot/index.test.js
@@ -95,7 +95,7 @@ describe('Aws... | Multi-line values in IoT event
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
... | it's reproducible on my machine, will fix and send PR. | 2017-01-14 06:44:52+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileIoTEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileIoTEvents #awsCompileIoTEvents() should respect "sqlVersion" variable', 'AwsCompileIoTEvents #awsCompileIoTEvents() should throw an error if iot event type is not an object', 'AwsCompileIoTEvents #awsCompile... | ['AwsCompileIoTEvents #awsCompileIoTEvents() should respect variables if multi-line variables is given'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/iot/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/iot/index.js->program->class_declaration:AwsCompileIoTEvents->method_definition:compileIoTEvents"] |
serverless/serverless | 3,067 | serverless__serverless-3067 | ['3066'] | 86d2b1049364247522bf6371c221fc23880df75e | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index fe5550d1e50..5b2545e4048 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -144,6 +144,10 @@ class Service {
return Object.keys(this.functions);
}
+ getAllFunctionsNames() {
+ return this.getAllFunctions().map((func) => t... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 67d044e7e10..9daa2a73c94 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -536,7 +536,43 @@ describe('Service', () => {
});
});
+ describe('#getAllFunctionsNames', () => {
+ it('should return an empty... | Serverless metrics outputs incorrect average function duration
<!--
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
4. Fill out the whole template so we have a good overview on the issue... | null | 2017-01-06 21:21:07+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ["Service #load() should throw error if a function's event is not an array or a variable", 'AwsMetrics #constructor() should set the passed in options to this.options', 'AwsMetrics #extendedValidate() should translate human friendly syntax (e.g. 24h) for startTime', 'Service #load() should merge resources given as an a... | ['AwsMetrics #showMetrics() should display correct average of service wide average function duration', 'Service #getAllFunctionsNames should return an empty array if there are no functions in Service', 'Service #getAllFunctionsNames should return array of lambda function names in Service'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/metrics/awsMetrics.test.js lib/classes/Service.test.js --reporter json | Bug Fix | false | false | false | true | 7 | 1 | 8 | false | false | ["lib/plugins/aws/metrics/awsMetrics.js->program->class_declaration:AwsMetrics->method_definition:getMetrics", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:getRegion", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definiti... |
serverless/serverless | 3,064 | serverless__serverless-3064 | ['3063', '3063'] | 0d8910ec4b254ce4e5e2ba07ee6cd1921c237724 | diff --git a/lib/plugins/create/create.js b/lib/plugins/create/create.js
index 8da0f8a306c..1bc0991e625 100644
--- a/lib/plugins/create/create.js
+++ b/lib/plugins/create/create.js
@@ -3,6 +3,7 @@
const BbPromise = require('bluebird');
const path = require('path');
const fse = require('fs-extra');
+const _ = require... | diff --git a/lib/plugins/create/create.test.js b/lib/plugins/create/create.test.js
index d35e8f4c526..5597ec35765 100644
--- a/lib/plugins/create/create.test.js
+++ b/lib/plugins/create/create.test.js
@@ -311,6 +311,30 @@ describe('Create', () => {
});
});
+ it('should create a service in the directory... | Serverless ignores path argument which starts with a digit
# This is a Bug Report
## Description
For bug reports:
* What went wrong?
When I create a new project from template it ignores my `--path` param if it starts with a digit.
```bash
$ serverless create --template aws-nodejs --path 123
```
```bas... | 2017-01-06 14:36:56+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Create #create() should generate scaffolding for "aws-java-gradle" template', 'Create #create() should create a renamed service in the directory if using the "path" option', 'Create #constructor() should have commands', 'Create #create() should generate scaffolding for "aws-java-maven" template', 'Create #create() sh... | ['Create #create() should create a service in the directory if using the "path" option with digits'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/create/create.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/create/create.js->program->class_declaration:Create->method_definition:create"] | |
serverless/serverless | 3,047 | serverless__serverless-3047 | ['2981'] | 8a67eef09d18bc58ee80fe99f6fc431848a9ba0e | diff --git a/lib/plugins/aws/lib/updateStack.js b/lib/plugins/aws/lib/updateStack.js
index 3cb58be8fd2..b7d230778c3 100644
--- a/lib/plugins/aws/lib/updateStack.js
+++ b/lib/plugins/aws/lib/updateStack.js
@@ -4,6 +4,8 @@ const _ = require('lodash');
const path = require('path');
const BbPromise = require('bluebird');... | diff --git a/lib/plugins/aws/lib/updateStack.test.js b/lib/plugins/aws/lib/updateStack.test.js
index 4ed0e324307..3af2169d197 100644
--- a/lib/plugins/aws/lib/updateStack.test.js
+++ b/lib/plugins/aws/lib/updateStack.test.js
@@ -90,6 +90,11 @@ describe('updateStack', () => {
sinon.stub(awsDeploy, 'monitorStack')... | No updates are to be performed - exit code 1
# This is a Feature Proposal
## Description
```
Serverless: Updating Stack...
Serverless Error ---------------------------------------
No updates are to be performed.
Get Support --------------------------------------------
Docs: do... | Same here, an error code 1 in codebuild returns build failed in our code pipeline. I don't think it should be an error that the stack already exists. Maybe a warning | 2017-01-03 11:15:56+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['updateStack #update() should include custom stack tags and policy', 'updateStack #createFallback() should create a stack with the CF template URL', 'updateStack #updateStack() should fallback to createStack if createLater flag exists', 'updateStack #updateStack() should resolve if no deploy', 'updateStack #updateStac... | ['updateStack #update() should success if no changes to stack happened'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/updateStack.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/lib/updateStack.js->program->method_definition:update"] |
serverless/serverless | 2,983 | serverless__serverless-2983 | ['2830'] | 08dc8864b77827fcf2ed95c32cdcdf2fc50c5669 | diff --git a/.gitignore b/.gitignore
index 266ff9083b4..132ba192e31 100755
--- a/.gitignore
+++ b/.gitignore
@@ -40,6 +40,7 @@ admin.env
tmp
.coveralls.yml
tmpdirs-serverless
+*.zip
# ESLint cache
.eslintcache
diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 6c4003... | diff --git a/lib/plugins/aws/deploy/compile/events/stream/index.test.js b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
index de378c0f464..d6a6f38ef91 100644
--- a/lib/plugins/aws/deploy/compile/events/stream/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
@@ -13,11 +13,15 @@... | report error when we cannot delete a network interface
So I found out about this from our AWS account manager when I exceeded quota.
Running serverless deploy with the VPC, SecurityGroupIds, and SubnetIds defined seems to create a new network interface on each deploy, but doesn't clean up old, unused network interfa... | Hi @brianbegygr, does your execution role have `ec2:DetachNetworkInterface` and `ec2:DeleteNetworkInterface` permissions?
Good catch, it did not. Once it has permissions, it seems to clean up after itself.
However, I would have expected it to report an error when it couldn't do so.
Is it appropriate to put a f... | 2016-12-19 21:05:11+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileStreamEvents #compileStreamEvents() should not create event source mapping when stream events are not given', '#mergeIamTemplates() should throw error if custom IAM policy statements is not an array', '#naming() #normalizePath() should normalize each part of the resource path and remove non-alpha-numeric ch... | ['#mergeIamTemplates() ManagedPolicyArns property should be added if vpc config is defined on function level', 'AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/index.test.js lib/plugins/aws/deploy/compile/events/stream/index.test.js lib/plugins/aws/lib/naming.test.js lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js --reporter json | Bug Fix | false | true | false | false | 4 | 0 | 4 | false | false | ["lib/plugins/aws/lib/naming.js->program->method_definition:getPolicyLogicalId", "lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileRole", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:merge", "lib/plugins/aws/deplo... |
serverless/serverless | 2,952 | serverless__serverless-2952 | ['2508', '2508'] | f78fee916ddc48a69277f0940d4d89e219cbdaee | diff --git a/lib/plugins/aws/deploy/compile/events/stream/index.js b/lib/plugins/aws/deploy/compile/events/stream/index.js
index 41dab7cc4e0..d18b53fc1b5 100644
--- a/lib/plugins/aws/deploy/compile/events/stream/index.js
+++ b/lib/plugins/aws/deploy/compile/events/stream/index.js
@@ -17,6 +17,27 @@ class AwsCompileStre... | diff --git a/lib/plugins/aws/deploy/compile/events/stream/index.test.js b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
index a07c1600049..8e4d61f1388 100644
--- a/lib/plugins/aws/deploy/compile/events/stream/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
@@ -275,6 +275,9 @@... | Maximum policy size of 10240 bytes exceeded for role
# This is a Bug Report
## Description
### What went wrong?
I tried to deploy a function that listens to 50+ DynamoDB streams. The deploy hung for around 5-10min before eventually failing.
### What did you expect should have happened?
The function should have deploy... | I tried to get around the issue by manually creating a new IAM role [as described in the docs](https://serverless.com/framework/docs/providers/aws/iam/#using-existing-iam-role), but now I get a different error:
```
Stack Trace --------------------------------------------
TypeError: Cannot read property 'Properties'... | 2016-12-15 00:09:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileStreamEvents #compileStreamEvents() should not create event source mapping when stream events are not given', 'AwsCompileStreamEvents #compileStreamEvents() should not throw error or merge role statements if default policy is not present', 'AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB strea... | ['AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB stream ARN is given should add the necessary IAM role statements', 'AwsCompileStreamEvents #compileStreamEvents() when a Kinesis stream ARN is given should add the necessary IAM role statements'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/stream/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/stream/index.js->program->class_declaration:AwsCompileStreamEvents->method_definition:compileStreamEvents"] |
serverless/serverless | 2,945 | serverless__serverless-2945 | ['2132'] | 5a3e0c2bcaff15d77c925995693379967da42d80 | diff --git a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
index a85c8518ba9..ff4844bed3c 100644
--- a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
@@ -6,6 +6,11 @@ const path = require('path');
module.export... | diff --git a/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js b/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
index 3dadf19a7f2..982380095e7 100644
--- a/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
@@ -114,7 +114,6 @@ describe('#mergeIamTemp... | Warn when incorrect format for additional IAM Role Statements causes them not to be included
# Bug Report
## Description
When using a `$ref` to include additional IAM Role Statements for a service, if the `$ref`'d file is not in the correct format (i.e. an array including more role statements), the role statements you... | Thanks for reporting, sorry for the delay on answering, this should definitely be fixed through some validation.
| 2016-12-14 12:14:57+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should not merge there are no functions', '#mergeIamTemplates() should add a CloudWatch LogGroup resource', '#mergeIamTemplates() should merge IamPolicyLambdaExecution template into the CloudFormation template', "#mergeIamTemplates() should update IamPolicyLambdaExecution with each function's log... | ['#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Action field', '#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Effect field', '#me... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:validateStatements", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:merge", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:mergeIamTemplates"] |
serverless/serverless | 2,940 | serverless__serverless-2940 | ['2936', '2936'] | ed591ffd3fbe37d813c79fb7493031f1548b2ae0 | diff --git a/docs/providers/aws/events/schedule.md b/docs/providers/aws/events/schedule.md
index b5e32a024d9..d1e12f40402 100644
--- a/docs/providers/aws/events/schedule.md
+++ b/docs/providers/aws/events/schedule.md
@@ -25,6 +25,8 @@ functions:
## Enabling/Disabling functions
+Schedule events are enabled by defau... | diff --git a/lib/plugins/aws/deploy/compile/events/schedule/index.test.js b/lib/plugins/aws/deploy/compile/events/schedule/index.test.js
index de02c20f895..bb3eb72a0c6 100644
--- a/lib/plugins/aws/deploy/compile/events/schedule/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/schedule/index.test.js
@@ -101,6 +... | Schedule events not always working
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.... | The problem is that when "schedule" is string, the event enabled by default but when it's an object it's disabled by default. So to make it work you need to always add "enabled: true" to your schedule event. I believe that's a bug, at least from documentation it seems like that's not the expected behavior.
If you c... | 2016-12-14 07:56:30+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileScheduledEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect name variable', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect description variable', 'AwsCompileScheduledEvents #compileSc... | ['AwsCompileScheduledEvents #compileScheduledEvents() should respect enabled variable, defaulting to true'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/schedule/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/schedule/index.js->program->class_declaration:AwsCompileScheduledEvents->method_definition:compileScheduledEvents"] |
serverless/serverless | 2,922 | serverless__serverless-2922 | ['2846'] | cee63f183a47680c35e782834aad02b227255c61 | diff --git a/docs/providers/aws/cli-reference/metrics.md b/docs/providers/aws/cli-reference/metrics.md
index d407d06a4dc..64a3c98bf2d 100644
--- a/docs/providers/aws/cli-reference/metrics.md
+++ b/docs/providers/aws/cli-reference/metrics.md
@@ -15,12 +15,12 @@ layout: Doc
Lets you watch the metrics of a specific funct... | diff --git a/lib/plugins/aws/metrics/awsMetrics.test.js b/lib/plugins/aws/metrics/awsMetrics.test.js
index d6a30f08458..cb6df66bfff 100644
--- a/lib/plugins/aws/metrics/awsMetrics.test.js
+++ b/lib/plugins/aws/metrics/awsMetrics.test.js
@@ -175,7 +175,14 @@ describe('AwsMetrics', () => {
let requestStub;
be... | metrics command returning metrics for service
# This is a Feature Proposal
## Description
`serverless metrics` (without `-f`) should return aggregated metrics for whole service (all functions in service).
```
$ serverless metrics
December 1, 2016 10:34 AM - December 2, 2016 10:34 AM
Invocations: 19
Throt... | This looks like a good improvement! Maybe we should add an `All functions combined` or something like that where usually the function name appears if you run this command with a `--function` option.
I like it. Since we gathering all the data for all the functions I would propose we show data for functions separately. I... | 2016-12-12 15:07:33+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsMetrics #constructor() should have a "metrics:metrics" hook', 'AwsMetrics #extendedValidate() should set the endTime to today as the default value if not provided', 'Metrics #constructor() should have the command "metrics"', 'AwsMetrics #extendedValidate() should set the endTime to the provided value', 'AwsMetrics... | ['AwsMetrics #getMetrics() should gather service wide function metrics if no function option is specified', 'AwsMetrics #showMetrics() should display service wide metrics if no function option is specified', 'AwsMetrics #showMetrics() should display function metrics if function option is specified', 'AwsMetrics #getMet... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/metrics/awsMetrics.test.js lib/plugins/metrics/metrics.test.js --reporter json | Feature | false | true | false | false | 4 | 0 | 4 | false | false | ["lib/plugins/aws/metrics/awsMetrics.js->program->class_declaration:AwsMetrics->method_definition:getMetrics", "lib/plugins/metrics/metrics.js->program->class_declaration:Metrics->method_definition:constructor", "lib/plugins/aws/metrics/awsMetrics.js->program->class_declaration:AwsMetrics->method_definition:showMetrics... |
serverless/serverless | 2,910 | serverless__serverless-2910 | ['2832'] | ca1c6de6d86fc4258387de5790e097993728f59e | diff --git a/docs/providers/aws/events/schedule.md b/docs/providers/aws/events/schedule.md
index 4dc7e6d0303..b5e32a024d9 100644
--- a/docs/providers/aws/events/schedule.md
+++ b/docs/providers/aws/events/schedule.md
@@ -46,3 +46,15 @@ functions:
enabled: false
inputPath: '$.stageVariables'
```
+... | diff --git a/lib/plugins/aws/deploy/compile/events/schedule/index.test.js b/lib/plugins/aws/deploy/compile/events/schedule/index.test.js
index 91eea1e7376..de02c20f895 100644
--- a/lib/plugins/aws/deploy/compile/events/schedule/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/schedule/index.test.js
@@ -101,6 +... | CloudWatchEvent rule name and description fields
```
functions:
run:
handler: handler.run
events:
- schedule:
rate: rate(10 minutes)
enabled: false
name: "I want my own name prefix here"
description: "I want my own description here"
```
When deploying l... | Currently it's not supported.
Any immediate plans on this? It makes hard to read the rules/metadata, especially in cases with 1000s of rules. | 2016-12-10 04:52:23+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileScheduledEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileScheduledEvents #compileScheduledEvents() should not create corresponding resources when scheduled events are not given', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect input varia... | ['AwsCompileScheduledEvents #compileScheduledEvents() should respect name variable', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect description variable'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/schedule/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/schedule/index.js->program->class_declaration:AwsCompileScheduledEvents->method_definition:compileScheduledEvents"] |
serverless/serverless | 2,906 | serverless__serverless-2906 | ['2898'] | 0acaaa0c49cfafd0232170dfa85619455ce1a291 | diff --git a/lib/plugins/aws/lib/monitorStack.js b/lib/plugins/aws/lib/monitorStack.js
index 2e636e3c14a..a85813ffc5a 100644
--- a/lib/plugins/aws/lib/monitorStack.js
+++ b/lib/plugins/aws/lib/monitorStack.js
@@ -48,7 +48,8 @@ module.exports = {
let eventStatus = event.ResourceStatus || null;
... | diff --git a/lib/plugins/aws/lib/monitorStack.test.js b/lib/plugins/aws/lib/monitorStack.test.js
index 4e1ce49cd67..3f18b0086fb 100644
--- a/lib/plugins/aws/lib/monitorStack.test.js
+++ b/lib/plugins/aws/lib/monitorStack.test.js
@@ -56,7 +56,8 @@ describe('monitorStack', () => {
StackEvents: [
{
... | Serverless doesn't properly wait for deployment to finish in case there is a nested stack
# This is a Bug Report
## Description
* What went wrong?
I used resources part of serverless.yml to include a nested stack from a cloudformation file located on s3. I also set the usual serverless resources to be dependent ... | It seems changing line 51 of monitorStack.js from:
~~~~
if (event.ResourceType === 'AWS::CloudFormation::Stack' ) {
~~~~
to:
~~~~
if (event.ResourceType === 'AWS::CloudFormation::Stack'
&& event.StackId === event.PhysicalResourceId) {
~~~~
fixes it as only in the case of the nested stack those are dif... | 2016-12-09 14:27:59+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['monitorStack #monitorStack() should keep monitoring until DELETE_COMPLETE or stack not found catch', 'monitorStack #monitorStack() should keep monitoring until DELETE_COMPLETE stack status', 'monitorStack #monitorStack() should catch describeStackEvents error if stack was not in deleting state', 'monitorStack #monito... | ['monitorStack #monitorStack() should not stop monitoring on DELETE_COMPLETE nested stack status', 'monitorStack #monitorStack() should not stop monitoring on CREATE_COMPLETE nested stack status', 'monitorStack #monitorStack() should not stop monitoring on UPDATE_COMPLETE nested stack status'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/monitorStack.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/lib/monitorStack.js->program->method_definition:monitorStack"] |
serverless/serverless | 2,893 | serverless__serverless-2893 | ['2878'] | cb9f8187e14c333d6a521b8f05ea3e07de126f3e | diff --git a/lib/plugins/aws/configCredentials/awsConfigCredentials.js b/lib/plugins/aws/configCredentials/awsConfigCredentials.js
index cab236ccdd0..b2f9417cb62 100644
--- a/lib/plugins/aws/configCredentials/awsConfigCredentials.js
+++ b/lib/plugins/aws/configCredentials/awsConfigCredentials.js
@@ -2,6 +2,7 @@
cons... | diff --git a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
index ae118d48b6f..73dd379af0c 100644
--- a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
+++ b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
@@ ... | Serverless does not create ~/.aws/credentials file when using config credentials CLI on OS X El Capitan 10.11.3
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our G... | @alexbielen what is your home directory?
@pmuens Looks like it's failing if the directory doesn't exist. https://github.com/serverless/serverless/blob/master/lib/plugins/aws/configCredentials/awsConfigCredentials.js#L94
We should probably use `outputFileSync ` https://github.com/jprichardson/node-fs-extra#outputfile... | 2016-12-08 09:23:43+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsConfigCredentials #constructor() should have the command "config"', 'AwsConfigCredentials #configureCredentials() should lowercase the provider option', 'AwsConfigCredentials #constructor() should have the lifecycle event "config" for the "credentials" sub-command', 'AwsConfigCredentials #configureCredentials() sh... | ['AwsConfigCredentials #configureCredentials() should create the .aws/credentials file if not yet present'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/configCredentials/awsConfigCredentials.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/configCredentials/awsConfigCredentials.js->program->class_declaration:AwsConfigCredentials->method_definition:configureCredentials"] |
serverless/serverless | 2,891 | serverless__serverless-2891 | ['2890'] | cb9f8187e14c333d6a521b8f05ea3e07de126f3e | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 5c18e6aff1f..1e95bf03e9a 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -32,6 +32,7 @@ class Variables {
// temporally remove variable syntax from service otherwise it'll match
this.service.defaults.variableSynta... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index a5cd3215da4..6d929008291 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -56,6 +56,7 @@ describe('Variables', () => {
const barValue = 'test';
serverless.service.defaults.variableSyntax = v... | Variable Syntax matches itself in serverless.yml
# This is a Bug Report
## Description
I tried to use the `variableSyntax` property to enable me to use cross-stack references in CloudFormation. I set it to `'\${{([\s\S]+?)}}'` to allow me to use `${blah}` in CF and `${{opt:stage}}`
The custom variable syntax I ... | null | 2016-12-08 07:44:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #overwrite() should overwrite undefined and null values', 'Variables #overwrite() should not overwrite false values', 'Variables #getValueFromFile() should populate non json/yml files', 'Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #populateVariable() should ... | ['Variables #populateService() should use variableSyntax'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:populateService"] |
serverless/serverless | 2,865 | serverless__serverless-2865 | ['2700'] | 6743df480cddb963e7ab09a1aabb50e99df822a9 | diff --git a/lib/plugins/aws/invokeLocal/index.js b/lib/plugins/aws/invokeLocal/index.js
index 6247e899d6f..e56105023f1 100644
--- a/lib/plugins/aws/invokeLocal/index.js
+++ b/lib/plugins/aws/invokeLocal/index.js
@@ -52,10 +52,31 @@ class AwsInvokeLocal {
}
loadEnvVars() {
+ const lambdaName = this.options.f... | diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js
index a407cc6c9f0..cfa68c0e26a 100644
--- a/lib/plugins/aws/invokeLocal/index.test.js
+++ b/lib/plugins/aws/invokeLocal/index.test.js
@@ -185,7 +185,9 @@ describe('AwsInvokeLocal', () => {
};
awsInvokeLoca... | Improve "Invoke Local"
# Problem
We've added `invoke local` with the goal of emulating Lambda as best as it can, so that developers can use it to speed up their workflow.
We tried to get an MVP of local support in ASAP, and succeeded. However, it missed a few critical pieces:
**1 - `invoke local` behaves diff... | Question, in the next release will be possible to invoke other runtimes? like java/scala?
I'm trying **invoke local** right now: I noticed it ignores the specified AWS profile in _serverless.yaml_ (`profile: bbb-dev`) and uses the default one `test-cli` (which, in my case, doesn't have access to a SNS topic, hence the ... | 2016-12-05 13:29:59+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsInvokeLocal #extendedValidate() it should parse a yaml file if file path is provided', 'AwsInvokeLocal #extendedValidate() should keep data if it is a simple string', 'AwsInvokeLocal #invokeLocal() throw error when using runtime other than Node.js', 'AwsInvokeLocal #constructor() should have hooks', 'AwsInvokeLoca... | ['AwsInvokeLocal #loadEnvVars() it should load default lambda env vars'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:loadEnvVars"] |
serverless/serverless | 2,847 | serverless__serverless-2847 | ['2839'] | b708f66f4eb208eb20b1ec722cc7054259e4f0bf | diff --git a/lib/plugins/aws/configCredentials/awsConfigCredentials.js b/lib/plugins/aws/configCredentials/awsConfigCredentials.js
index f459727fef1..cab236ccdd0 100644
--- a/lib/plugins/aws/configCredentials/awsConfigCredentials.js
+++ b/lib/plugins/aws/configCredentials/awsConfigCredentials.js
@@ -13,9 +13,6 @@ class... | diff --git a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
index 350d3e5098a..ae118d48b6f 100644
--- a/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
+++ b/lib/plugins/aws/configCredentials/awsConfigCredentials.test.js
@@ ... | Make sure the `config` command is not displayed in the command list
# This is a (Bug Report / Feature Proposal)
## Description
The config command does nothing since we only support config credentials for now.
## Additional Data
* ***Serverless Framework Version you're using***: latest master
* ***Operating... | I would propose to rename this to `commands w/o implementation shouldn't show up in help`.
We should update the `PluginManager` so that commands without an implementation are not displayed.
I can work on this tomorrow so you can focus on the metrics plugin.
@mthenw @eahefnawy any objections doing this?
Shouldn't ... | 2016-12-02 09:57:41+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Config #constructor() should have the command "config"', 'Config #constructor() should run promise chain in order for "before:config:credentials:config" hook', 'AwsConfigCredentials #configureCredentials() should resolve if profile is already given in credentials file', 'AwsConfigCredentials #configureCredentials() s... | ['AwsConfigCredentials #constructor() should have no lifecycle event', 'Config #constructor() should have no lifecycle event'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/configCredentials/awsConfigCredentials.test.js lib/plugins/config/config.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/configCredentials/awsConfigCredentials.js->program->class_declaration:AwsConfigCredentials->method_definition:constructor", "lib/plugins/config/config.js->program->class_declaration:Config->method_definition:constructor"] |
serverless/serverless | 2,842 | serverless__serverless-2842 | ['2828'] | a949cd95c437a2de612a0b74b0074cd712e6d84b | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 871ab8822e8..eca7aa75713 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -86,6 +86,12 @@ class Service {
throw new SError(errorMessage);
}
+ if (Array.isArray(serverlessFile.resources)) {
+ serve... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 91b0baf049a..3c833624acc 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -169,6 +169,37 @@ describe('Service', () => {
});
});
+ it('should merge resources given as an array', () => {
+ const... | Include Multiple Resource Files
# This is a Feature Proposal
## Description
This feature enables multiple resource files to be included in the 'Resources' section. This enables larger services to include sub resource files independantly. One resource file can be broken up a number to enable better independant man... | null | 2016-12-02 00:40:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #load() should throw error if frameworkVersion is not satisfied', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getFunction() should return function object', 'Service #getAllFunctions() should return an array of function names in Service', 'Service #constructor() should at... | ['Service #load() should merge resources given as an array'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Service.js->program->class_declaration:Service->method_definition:load"] |
serverless/serverless | 2,816 | serverless__serverless-2816 | ['2721'] | c929f41b29e1a85dce537d9a1896f15e965e4e52 | diff --git a/docs/providers/aws/cli-reference/install.md b/docs/providers/aws/cli-reference/install.md
index aa2046c7b41..8edaa36bb39 100644
--- a/docs/providers/aws/cli-reference/install.md
+++ b/docs/providers/aws/cli-reference/install.md
@@ -29,7 +29,15 @@ serverless install --url https://github.com/some/service
##... | diff --git a/lib/plugins/install/install.test.js b/lib/plugins/install/install.test.js
index 362a811aed0..09bc56f2bb8 100644
--- a/lib/plugins/install/install.test.js
+++ b/lib/plugins/install/install.test.js
@@ -9,16 +9,17 @@ const fse = require('fs-extra');
const path = require('path');
const proxyquire = require('... | Add support for directories in url of install command
# This is a Feature Proposal
## Description
It would be great to have the possibility to point to a directory when installing a service through the `install` command (rather than only supporting the URL to the whole git repository).
/cc @ac360
| If you upload Serverless project files to a http endpoint, you can install as follow
```
serverless install <http endpoint>
```
Does this sound good?
Sounds good. The idea is that something like this would work:
```
serverless install https://github.com/serverless/examples/tree/master/rest-api-with-dynamodb
```
@h... | 2016-11-28 15:36:57+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Install #constructor() should have commands', 'Install #install() should download the service based on the GitHub URL', 'Install #install() should throw an error if a directory with the same service name is already present', 'Install #constructor() should run promise chain in order for "install:install" hook', 'Insta... | ['Install #install() should throw an error if the same service name exists as directory in Github', 'Install #install() should download the service based on directories in the GitHub URL'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/install/install.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/install/install.js->program->class_declaration:Install->method_definition:install"] |
serverless/serverless | 2,809 | serverless__serverless-2809 | ['2784', '2784', '2784'] | c929f41b29e1a85dce537d9a1896f15e965e4e52 | diff --git a/lib/plugins/slstats/slstats.js b/lib/plugins/slstats/slstats.js
index 5eff6ca017e..5301826d02c 100644
--- a/lib/plugins/slstats/slstats.js
+++ b/lib/plugins/slstats/slstats.js
@@ -33,22 +33,30 @@ class SlStats {
};
}
- toggleStats() {
- const serverlessDirPath = path.join(os.homedir(), '.serv... | diff --git a/lib/plugins/slstats/slstats.test.js b/lib/plugins/slstats/slstats.test.js
index 77ca1dddebc..8a7d7f30f81 100644
--- a/lib/plugins/slstats/slstats.test.js
+++ b/lib/plugins/slstats/slstats.test.js
@@ -4,6 +4,7 @@ const expect = require('chai').expect;
const path = require('path');
const fse = require('fs-... | 'serverless slstats --disable' doesn't run on v1.2
# This is a Bug Report
## Description
For bug reports:
* What went wrong? Running 'serverless slstats --disable' doesn't disable the slstats and causes serverless deployment to fail.
This change caused the issue: https://github.com/serverless/serverless/com... | 2016-11-27 21:16:56+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['SlStats #constructor() should have access to the serverless instance', 'SlStats #toogleStats() should rename the stats file to stats-disabled if disabled', 'SlStats #constructor() should have commands', 'SlStats #toogleStats() should rename the stats file to stats-enabled if enabled', 'SlStats #constructor() should h... | ['SlStats #toogleStats() should do nothing if the stats-enabled file already exists', 'SlStats #toogleStats() should create the stats-enabled file if no stats-enabled file exists', 'SlStats #toogleStats() should throw an error if unable to create the stats file'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/slstats/slstats.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/slstats/slstats.js->program->class_declaration:SlStats->method_definition:createStatsFile", "lib/plugins/slstats/slstats.js->program->class_declaration:SlStats->method_definition:toggleStats"] | |
serverless/serverless | 2,799 | serverless__serverless-2799 | ['2798'] | c929f41b29e1a85dce537d9a1896f15e965e4e52 | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js
index 9c974f3da65..033bdce1410 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validat... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.test.js
index 5d67839bb01..8a21ad4008d 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.test.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGate... | v1.2.1 introduces a bug with HTTP event Request Parameters
# This is a Bug Report
## Description
For bug reports:
* What went wrong?
When doing a `sls deploy`, the following error occurs:
```
............................Serverless: Deployment failed!
Serverless Error ---------------------------------... | I've found the cause.
When you do an `sls deploy --noDeploy` I expect you should see:
```
Serverless: Warning! You're using the LAMBDA-PROXY in combination with request / response configuration in your function "http". This configuration will be ignored during deployment.
```
It's not actually 'ignoring' the... | 2016-11-26 00:55:58+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should handle expicit methods', '#validate() should throw an error when an invalid integration type was provided', '#validate() should validate the http events "method" property', '#validate() should ignore non-http events', '#validate() should throw if request.template is malformed', '#validate() should ... | ['#validate() should remove request/response config with LAMBDA-PROXY'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js->program->method_definition:getIntegration", "lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js->program->method_definition:validate"] |
serverless/serverless | 2,774 | serverless__serverless-2774 | ['2771'] | 64374e2f3077ac9de929bc235c6a172d12b0cec5 | diff --git a/lib/plugins/aws/lib/naming.js b/lib/plugins/aws/lib/naming.js
index 2fd5020ede6..de9b501794f 100644
--- a/lib/plugins/aws/lib/naming.js
+++ b/lib/plugins/aws/lib/naming.js
@@ -12,9 +12,12 @@ module.exports = {
return this.normalizeName(name.replace(/[^0-9A-Za-z]/g, ''));
},
normalizePathPart(pat... | diff --git a/lib/plugins/aws/lib/naming.test.js b/lib/plugins/aws/lib/naming.test.js
index 7a106f9d1b7..6051fa5853a 100644
--- a/lib/plugins/aws/lib/naming.test.js
+++ b/lib/plugins/aws/lib/naming.test.js
@@ -44,7 +44,7 @@ describe('#naming()', () => {
});
});
- describe('#normalizeNameToCapitalAlphaNumberic... | Api Gateway Deployment Failure
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
... | I am also getting this exact failure after upgrading to 1.2 from 1.1 with a near identical template.
Oh snap! Thanks for reporting! 👍
We've refactored the API Gateway code recently. Removing the API Gateway and redeploying should resolve this issue.
Any ideas what caused this error @eahefnawy?
Use the sls diff ... | 2016-11-22 19:45:18+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#naming() #getDeploymentBucketOutputLogicalId() should return "ServerlessDeploymentBucketName"', '#naming() #normalizeNameToAlphaNumericOnly() should apply normalizeName to the remaining characters', '#naming() #normalizeNameToAlphaNumericOnly() should strip non-alpha-numeric characters', '#naming() #getLambdaOutputL... | ['#naming() #normalizePathPart() converts variable declarations prefixes to `VariableVarpath`', '#naming() #normalizePathPart() converts variable declarations in center to `PathvariableVardir`'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/naming.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/lib/naming.js->program->method_definition:normalizePathPart"] |
serverless/serverless | 2,748 | serverless__serverless-2748 | ['2673'] | ffadf3da18475179aa622b5df6391b17e66e4f1a | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 6ead0c38da8..81166a2054b 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -220,19 +220,38 @@ Then, when you run `serverless deploy`, VPC configuration will be deployed along
... | diff --git a/lib/plugins/aws/deploy/compile/functions/tests/index.js b/lib/plugins/aws/deploy/compile/functions/tests/index.js
index 7bb65192602..10792eca604 100644
--- a/lib/plugins/aws/deploy/compile/functions/tests/index.js
+++ b/lib/plugins/aws/deploy/compile/functions/tests/index.js
@@ -360,6 +360,170 @@ describe(... | Design Environment Variable Support
# This is a Feature Proposal
## Description
As environment variables are an often requested feature for Serverless and AWS I want to start the design process, so we can start with implementing support for Environment Variables when they become ready at AWS at some point in the ... | Great, if you need some help let me know. Cheers
It would be great if there was an easy way to add a reference to a function for when you are invoking them.
@flomotlik that looks great. How will this support external secrets? i.e. database password, JWT secret
Right now they're built into the code package. But idea... | 2016-11-20 00:16:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should throw if no individual artifact', 'AwsCompileF... | ['AwsCompileFunctions #compileFunctions() should create a function resource with provider level environment config', 'AwsCompileFunctions #compileFunctions() should throw an error if environment variable has invalid name', 'AwsCompileFunctions #compileFunctions() should create a function resource with function level en... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/tests/index.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 2,743 | serverless__serverless-2743 | ['2697'] | c929f41b29e1a85dce537d9a1896f15e965e4e52 | diff --git a/lib/plugins/aws/deploy/compile/functions/index.js b/lib/plugins/aws/deploy/compile/functions/index.js
index 9c869f20570..acc8512aa2b 100644
--- a/lib/plugins/aws/deploy/compile/functions/index.js
+++ b/lib/plugins/aws/deploy/compile/functions/index.js
@@ -19,15 +19,44 @@ class AwsCompileFunctions {
};... | diff --git a/lib/plugins/aws/deploy/compile/functions/index.test.js b/lib/plugins/aws/deploy/compile/functions/index.test.js
index 80e4df9c2c6..0266baa0ebe 100644
--- a/lib/plugins/aws/deploy/compile/functions/index.test.js
+++ b/lib/plugins/aws/deploy/compile/functions/index.test.js
@@ -91,7 +91,7 @@ describe('AwsComp... | Cloud Formation Resource Dependencies: Function, Role and Policy
There is a problem when we deploy function that shall run on AWS VPC (subnets and security groups specified). In most of the cases deployment fails because of missing permission required for creating EC2 network interfaces. However, _ec2:DescribeNetworkIn... | null | 2016-11-18 17:03:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should create corresponding function output objects', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should add function declared role and fill in with provider role', 'AwsComp... | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment config', 'AwsCompileFunctions #compileRole() adds a role based on a logical name with DependsOn values', 'AwsC... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/index.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileRole", "lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 2,736 | serverless__serverless-2736 | ['2182', '2182'] | 158b1bf6cc164e40c94ec7f0171c53bf6024f583 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index da0b225110c..12651e12e8e 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -99,7 +99,31 @@ functions:
cors: true
```
-If you want to use CORS with the la... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/cors.test.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/cors.test.js
index 584a1b1e876..be451a6dba9 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/cors.test.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/cors... | Add Access-Control-Allow-Credentials for CORS settings
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/mas... | +
+1, is there a fix for this anywhere?
I needed that as well and now have an experimental version working for me.
I'll polish it a bit, write the tests and start the PR
ha, I also have a rough and ready version too. need to polish it a lot, so you might beat me to it. Will be good to compare approaches
Ready for r... | 2016-11-17 19:04:05+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should handle expicit methods', '#validate() should throw an error when an invalid integration type was provided', '#validate() should validate the http events "method" property', '#validate() should ignore non-http events', '#validate() should throw if request.template is malformed', '#validate() should ... | ['#validate() should process cors defaults', '#validate() should process cors options', '#compileCors() should create preflight method for CORS enabled resource', '#validate() should merge all preflight origins, method, headers and allowCredentials for a path'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.test.js lib/plugins/aws/deploy/compile/events/apiGateway/lib/cors.test.js --reporter json | Feature | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/cors.js->program->method_definition:compileCors", "lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js->program->method_definition:validate", "lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js->program->method_definition:getCors"] |
serverless/serverless | 2,732 | serverless__serverless-2732 | ['2023'] | fbb22ef1177af29ab3b53239100e0ec75e19bc8b | diff --git a/docs/providers/aws/guide/resources.md b/docs/providers/aws/guide/resources.md
index 2e2a7f67367..e5909d19b88 100644
--- a/docs/providers/aws/guide/resources.md
+++ b/docs/providers/aws/guide/resources.md
@@ -70,7 +70,7 @@ We're also using the term `normalizedName` or similar terms in this guide. This
|IAM... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/permissions.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/permissions.js
index 6df28f26487..3602cab8f5f 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/permissions.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGate... | Limit Lambda Permissions to created event source
<!--
1. Please check if an issue already exists so there are no duplicates
2. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
3. Fill out the whole template so we have a good overview on the issue
4. Do not remove... | null | 2016-11-17 12:08:32+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#naming() #normalizeNameToCapitalAlphaNumbericOnly() converts variable declarations (`${var}`) to `VariableVar`', '#naming() #getDeploymentBucketOutputLogicalId() should return "ServerlessDeploymentBucketName"', '#naming() #normalizeNameToAlphaNumericOnly() should apply normalizeName to the remaining characters', '#n... | ['#naming() #getLambdaSnsPermissionLogicalId() should normalize the function and topic names and add them as prefix and suffix to the standard permission center', 'AwsCompileS3Events #compileS3Events() should create corresponding resources when S3 events are given', 'AwsCompileS3Events #compileS3Events() should create ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/s3/tests/index.js lib/plugins/aws/deploy/compile/events/sns/tests/index.js lib/plugins/aws/tests/naming.js lib/plugins/aws/deploy/compile/events/apiGateway/tests/permissions.js --reporter json | Security | false | true | false | false | 7 | 0 | 7 | false | false | ["lib/plugins/aws/deploy/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:compileSNSEvents", "lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js->program->method_definition:compileMethods", "lib/plugins/aws/lib/naming.js->program->method_definition:getLamb... |
serverless/serverless | 2,729 | serverless__serverless-2729 | ['2132'] | fbb22ef1177af29ab3b53239100e0ec75e19bc8b | diff --git a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
index 3df6998b59a..89ceb947a90 100644
--- a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
@@ -6,6 +6,11 @@ const path = require('path');
module.export... | diff --git a/lib/plugins/aws/deploy/tests/mergeIamTemplates.js b/lib/plugins/aws/deploy/tests/mergeIamTemplates.js
index 3336614a9e4..5e1594ff5b5 100644
--- a/lib/plugins/aws/deploy/tests/mergeIamTemplates.js
+++ b/lib/plugins/aws/deploy/tests/mergeIamTemplates.js
@@ -105,7 +105,6 @@ describe('#mergeIamTemplates()', ()... | Warn when incorrect format for additional IAM Role Statements causes them not to be included
# Bug Report
## Description
When using a `$ref` to include additional IAM Role Statements for a service, if the `$ref`'d file is not in the correct format (i.e. an array including more role statements), the role statements you... | Thanks for reporting, sorry for the delay on answering, this should definitely be fixed through some validation.
| 2016-11-17 06:23:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should not merge there are no functions', '#mergeIamTemplates() should add a CloudWatch LogGroup resource', '#mergeIamTemplates() should merge IamPolicyLambdaExecution template into the CloudFormation template', "#mergeIamTemplates() should update IamPolicyLambdaExecution with each function's log... | ['#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Action field', '#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Effect field', '#me... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/tests/mergeIamTemplates.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:validateStatements", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:merge", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:mergeIamTemplates"] |
serverless/serverless | 2,714 | serverless__serverless-2714 | ['2713'] | 700eb2ea861dcd9a69a1e76e2f64d89a31b4cbe7 | diff --git a/docs/providers/aws/cli-reference/rollback.md b/docs/providers/aws/cli-reference/rollback.md
index a0ffa605fb7..33a5e7a041d 100644
--- a/docs/providers/aws/cli-reference/rollback.md
+++ b/docs/providers/aws/cli-reference/rollback.md
@@ -70,8 +70,8 @@ Serverless: - compiled-cloudformation-template.json
Serv... | diff --git a/lib/plugins/aws/deploy/tests/uploadArtifacts.js b/lib/plugins/aws/deploy/tests/uploadArtifacts.js
index 6fabf3dd8cb..33fa54de73b 100644
--- a/lib/plugins/aws/deploy/tests/uploadArtifacts.js
+++ b/lib/plugins/aws/deploy/tests/uploadArtifacts.js
@@ -143,7 +143,7 @@ describe('uploadArtifacts', () => {
... | Move back from ellipsis character to 3 dots
# This is a Feature Proposal
## Description
Some users use consoles which lack unicode support. We should switch back to 3 dots (instead of the ellipsis character) in our whole codebase.
See https://github.com/serverless/serverless/pull/2561#discussion_r87743346 for ... | null | 2016-11-15 13:02:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsDeployFunction #constructor() should set an empty options object if no options are given', 'AwsDeployFunction #constructor() should set the provider variable to an instance of AwsProvider', 'AwsDeployFunction hooks should run "deploy:function:packageFunction" promise chain in order', 'AwsDeployFunction hooks shoul... | ['AwsDeployFunction #deployFunction() should log artifact size', 'uploadArtifacts #uploadFunctions() should upload the service artifact file to the S3 bucket', 'uploadArtifacts #uploadFunctions() should log artifact size'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/tests/uploadArtifacts.js lib/plugins/aws/deployFunction/tests/index.js --reporter json | Feature | false | true | false | false | 13 | 0 | 13 | false | false | ["lib/plugins/aws/deployFunction/index.js->program->class_declaration:AwsDeployFunction->method_definition:deployFunction", "lib/plugins/aws/remove/lib/bucket.js->program->method_definition:listObjects", "lib/plugins/package/lib/packageService.js->program->method_definition:packageService", "lib/plugins/aws/deploy/lib/... |
serverless/serverless | 2,701 | serverless__serverless-2701 | ['2685'] | f6cf176b5259cb718b1f811d7d808729a43705c3 | diff --git a/lib/plugins/aws/invoke/index.js b/lib/plugins/aws/invoke/index.js
index 2a34b60984b..8e938994fd3 100644
--- a/lib/plugins/aws/invoke/index.js
+++ b/lib/plugins/aws/invoke/index.js
@@ -28,6 +28,16 @@ class AwsInvoke {
// validate function exists in service
this.options.functionObj = this.serverles... | diff --git a/lib/plugins/aws/invoke/index.test.js b/lib/plugins/aws/invoke/index.test.js
index b25653c2117..80026db4a8b 100644
--- a/lib/plugins/aws/invoke/index.test.js
+++ b/lib/plugins/aws/invoke/index.test.js
@@ -79,6 +79,26 @@ describe('AwsInvoke', () => {
expect(() => awsInvoke.extendedValidate()).to.throw... | invoke --data '{ json }' does not parse for Java Lambdas
# This is a (Bug Report / Feature Proposal)
Bug
## Description
The --data argument to 'serverless invoke' is not deserializable in Java lambdas.
For bug reports:
* What went wrong?
Create the sample java lamba
Run
serverless invoke -f hello --data '{... | null | 2016-11-14 02:35:11+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsInvokeLocal #extendedValidate() it should parse a yaml file if file path is provided', 'AwsInvokeLocal #extendedValidate() should keep data if it is a simple string', 'AwsInvokeLocal #invokeLocal() throw error when using runtime other than Node.js', 'AwsInvokeLocal #constructor() should have hooks', 'AwsInvoke #ex... | ['AwsInvokeLocal #extendedValidate() should parse JSON data if it is provided via CLI', 'AwsInvoke #extendedValidate() should parse JSON data if it is provided via CLI'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js lib/plugins/aws/invoke/index.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/invoke/index.js->program->class_declaration:AwsInvoke->method_definition:extendedValidate", "lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:extendedValidate"] |
serverless/serverless | 2,624 | serverless__serverless-2624 | ['2610'] | 56c6c105e0dbf388307a74f6c9dd310f36ef2191 | diff --git a/lib/classes/Utils.js b/lib/classes/Utils.js
index 13e6fe3e187..420a33b5d20 100644
--- a/lib/classes/Utils.js
+++ b/lib/classes/Utils.js
@@ -184,6 +184,20 @@ class Utils {
userId = this.readFileSync(statsEnabledFilePath).toString();
}
+ // filter out the whitelisted options
+ con... | diff --git a/lib/classes/Utils.test.js b/lib/classes/Utils.test.js
index 4fc73b85d89..5e3f57e48ee 100644
--- a/lib/classes/Utils.test.js
+++ b/lib/classes/Utils.test.js
@@ -12,16 +12,17 @@ const Serverless = require('../../lib/Serverless');
const testUtils = require('../../tests/utils');
const serverlessVersion = req... | Whitelist and store options for slstats command
# This is a Feature Proposal
## Description
Some options such as `--help`, `--disable` or `--enable` should be whitelisted and stored alongside the corresponding command. This way we can e.g. see when the `--help` option is used for a specific command.
/cc @world... | null | 2016-11-04 09:31:14+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Utils #findServicePath() should detect if the CWD is not a service directory', 'Utils #readFileSync() should read a file synchronously', 'Utils #fileExistsSync() When reading a file should detect if a file exists', 'Utils #generateShortId() should generate a shortId for the given length', 'Utils #logStat() should re-... | ['Utils #logStat() should filter out whitelisted options', 'Utils #logStat() should send the gathered information'] | ['Utils #writeFileDir() should create a directory for the path of the given file'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Utils.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat"] |
serverless/serverless | 2,588 | serverless__serverless-2588 | ['2587'] | 5b8aacf4d8caf3dc35063c28c269d8a09645cb1a | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js
index 9dc087e83b0..99a99502c4e 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validat... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js
index 39a7b479a61..f7fa2860679 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/tests... | resultTtlInSeconds defaults to 300 when set to 0
# This is a Bug Report
## Description
* What went wrong?
`resultTtlInSeconds` defaults to 300 when set to 0.
This is oviously due to [this line](https://github.com/serverless/serverless/blob/f817933909cb524dcde729348bf229ae355e15ac/lib/plugins/aws/deploy/comp... | Yup thats a bug that needs to be resolved. Thanks
| 2016-11-01 23:58:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#validate() should throw if an authorizer is an empty object', '#validate() should validate the http events object syntax method is case insensitive', '#validate() should accept an authorizer as a string', '#validate() should validate the http events string syntax method is case insensitive', '#validate() should acce... | ['#validate() should accept authorizer config when resultTtlInSeconds is 0'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer"] |
serverless/serverless | 2,584 | serverless__serverless-2584 | ['1807'] | 823cd6847446cd5b9fcc0e57329d28be57753108 | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index f7de8396a77..0d7e732ca93 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -160,7 +160,7 @@ functions:
memorySize: 512
```
-You can also use an existing IAM role by ad... | diff --git a/lib/plugins/aws/deploy/compile/events/stream/tests/index.js b/lib/plugins/aws/deploy/compile/events/stream/tests/index.js
index 9b1f03ac926..53fd4138330 100644
--- a/lib/plugins/aws/deploy/compile/events/stream/tests/index.js
+++ b/lib/plugins/aws/deploy/compile/events/stream/tests/index.js
@@ -63,6 +63,30... | Feature Request: Per Function Custom IAM roles
##### Feature Request: Per Function Custom IAM Roles
At present, custom roles can only be defined at the service level (#1749), which I don't believe is granular enough. Individual functions should allow for individual roles.
##### Benefits:
- Improved security
##### Draw... | Hey @danhumphrey thanks for this one! Good idea.
I would propose to implement the same fallback we're about to implement with the `package` per function functionality (see here: https://github.com/serverless/serverless/issues/1777). So you can basically implement it on a per-service level or per-function level.
What ... | 2016-11-01 13:46:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'updateStack #update() should include custom stack tags and policy', 'AwsCompileStreamEvents #compileStreamEvents() should not create event source mapping when stream events are not given', 'AwsCompileS... | ['AwsCompileFunctions #compileRole() compiles a logical role name into an reference object', 'AwsCompileFunctions #compileRole() returns a reference object when given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() sh... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/stream/tests/index.js lib/plugins/aws/deploy/tests/createStack.js lib/plugins/aws/tests/updateStack.js lib/plugins/aws/deploy/tests/mergeIamTemplates.js lib/plugins/aws/deploy/compile/functions/tests/index.js --reporter json | Feature | false | false | false | true | 6 | 1 | 7 | false | false | ["lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions", "lib/plugins/aws/deploy/lib/createStack.js->program->method_definition:create", "lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction", "l... |
serverless/serverless | 2,576 | serverless__serverless-2576 | ['2383'] | 5d4003dbad6f3bd07d98ff5d835ddbaa6b093724 | diff --git a/lib/plugins/aws/lib/monitorStack.js b/lib/plugins/aws/lib/monitorStack.js
index 3c3e49e8c53..5abe556460f 100644
--- a/lib/plugins/aws/lib/monitorStack.js
+++ b/lib/plugins/aws/lib/monitorStack.js
@@ -45,23 +45,24 @@ module.exports = {
data.StackEvents.reverse().forEach((event) => {
... | diff --git a/lib/plugins/aws/tests/monitorStack.js b/lib/plugins/aws/tests/monitorStack.js
index c820f27a9b9..4e1ce49cd67 100644
--- a/lib/plugins/aws/tests/monitorStack.js
+++ b/lib/plugins/aws/tests/monitorStack.js
@@ -302,6 +302,63 @@ describe('monitorStack', () => {
});
});
+ it('should keep monito... | Can't deploy with master branch: "Cannot read property 'endsWith' of null"
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless... | @bobby-brennan thanks for reporting!
It think I know what introduced the bug (a recent update to the `monitorStack` method). Will work on a fix!
BTW. Stack deployment should still work if you omit the `--verbose`/ `-v` flag.
@bobby-brennan could you provide your `serverless.yml` and a step-by-step list on how to rep... | 2016-10-31 09:32:59+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['monitorStack #monitorStack() should keep monitoring until DELETE_COMPLETE or stack not found catch', 'monitorStack #monitorStack() should keep monitoring until DELETE_COMPLETE stack status', 'monitorStack #monitorStack() should catch describeStackEvents error if stack was not in deleting state', 'monitorStack #monito... | ['monitorStack #monitorStack() should keep monitoring when 1st ResourceType is not "AWS::CloudFormation::Stack"'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/tests/monitorStack.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/lib/monitorStack.js->program->method_definition:monitorStack"] |
serverless/serverless | 2,567 | serverless__serverless-2567 | ['2543', '2543'] | 9421809ee9929e29a8bc72332ecd39395c39944e | diff --git a/docs/providers/aws/events/schedule.md b/docs/providers/aws/events/schedule.md
index 6c7a1704c65..4dc7e6d0303 100644
--- a/docs/providers/aws/events/schedule.md
+++ b/docs/providers/aws/events/schedule.md
@@ -36,7 +36,13 @@ functions:
- schedule:
rate: rate(10 minutes)
enabled: ... | diff --git a/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js b/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js
index 63343565081..8bfd21a5da6 100644
--- a/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js
+++ b/lib/plugins/aws/deploy/compile/events/schedule/tests/index.js
@@ -101... | Support Input and inputPath options in AWS::Events::Rule for schedule events
# This is a Feature Proposal
## Description
At the moment there is no way to pass a predefined input (or an input path) to a schedule event (`AWS::Events::Rule`).
For this purposes Amazon Cloud Formation offers the options `Input` and `Input... | 2016-10-28 15:47:28+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileScheduledEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileScheduledEvents #compileScheduledEvents() should not create corresponding resources when scheduled events are not given', 'AwsCompileScheduledEvents #compileScheduledEvents() should throw an error if s... | ['AwsCompileScheduledEvents #compileScheduledEvents() should respect inputPath variable', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect input variable as an object', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect input variable', 'AwsCompileScheduledEvents #compileScheduledEve... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/schedule/tests/index.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/schedule/index.js->program->class_declaration:AwsCompileScheduledEvents->method_definition:compileScheduledEvents"] | |
serverless/serverless | 2,565 | serverless__serverless-2565 | ['2490'] | 5e6940e87b424c6c4812d86da5c1073aae1122c3 | diff --git a/docs/providers/aws/examples/cron/node/handler.js b/docs/providers/aws/examples/cron/node/handler.js
index 5fb4857889b..980b35d2886 100644
--- a/docs/providers/aws/examples/cron/node/handler.js
+++ b/docs/providers/aws/examples/cron/node/handler.js
@@ -2,5 +2,5 @@
module.exports.run = () => {
const ti... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 7fab9dc7809..2caec549a26 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -385,6 +385,16 @@ describe('Variables', () => {
expect(valueToPopulate).to.deep.equal(configYml);
});
+ it('should ... | File variable fallback option fails
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md... | Thanks for reporting. This is definitely a bug as it should use the fallback (and potentially show a warning message)
| 2016-10-28 09:44:45+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #overwrite() should overwrite undefined and null values', 'Variables #overwrite() should not overwrite false values', 'Variables #getValueFromFile() should populate non json/yml files', 'Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #populateVariable() should ... | ['Variables #getValueFromFile() should get undefined if non existing file and the second argument is true'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromFile"] |
serverless/serverless | 2,541 | serverless__serverless-2541 | ['2081'] | 433030918e04c5b0d82690d0e22f816c95c298cc | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 0ff2b4b82b6..e0c6977c989 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -98,7 +98,8 @@ class Variables {
const variableStringsArray = variableStringsString.split(',');
variableStringsArray.find(variableString => {
... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index bfef5ecd2d8..5a18b00edb6 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -194,6 +194,21 @@ describe('Variables', () => {
serverless.variables.getValueFromSource.restore();
});
+ it('should... | Self referenced variables don't allow for fallback
# This is a Bug Report
## Description
For bug reports:
- What went wrong?
When referencing a `self:` variable the `getDeepValue` function returns an empty object that means it doesn't fallback to the other option.
- What did you expect should have happened?
It loa... | @andymac4182 thanks for reporting this. This is an issue, but I think the solution is in the overwrite method to also overwrite if object is empty, something like this:
``` js
return (typeof finalValue !== 'undefined' && finalValue !== null) && !_.isEmpty(finalValue);
```
could you try something like that in your PR ... | 2016-10-25 17:07:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #overwrite() should overwrite undefined and null values', 'Variables #overwrite() should not overwrite false values', 'Variables #getValueFromFile() should populate non json/yml files', 'Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #populateVariable() should ... | ['Variables #overwrite() should overwrite empty object values'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:overwrite"] |
serverless/serverless | 2,520 | serverless__serverless-2520 | ['2126'] | 3dddad7e1affe65d1d984d3d4b6df7fe5a52f508 | diff --git a/docs/02-providers/aws/02-iam.md b/docs/02-providers/aws/02-iam.md
index 5d671cac56d..918694e12f5 100644
--- a/docs/02-providers/aws/02-iam.md
+++ b/docs/02-providers/aws/02-iam.md
@@ -41,3 +41,15 @@ provider:
name: aws
iamRoleARN: arn:aws:iam::YourAccountNumber:role/YourIamRole
```
+
+# Explicitly c... | diff --git a/lib/plugins/aws/deploy/compile/functions/tests/index.js b/lib/plugins/aws/deploy/compile/functions/tests/index.js
index 2f5b4c921ca..36f98972955 100644
--- a/lib/plugins/aws/deploy/compile/functions/tests/index.js
+++ b/lib/plugins/aws/deploy/compile/functions/tests/index.js
@@ -13,11 +13,11 @@ describe('A... | Feature Proposal: Create Log Groups for lambda functions as part of Cloudformation
# This is a Feature Proposal
## Description
When creating the functions in the cloudformation template it would be ideal if the relevant log groups were created as well.
For feature proposals:
- What is the use case that should be sol... | null | 2016-10-24 10:36:29+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', '#mergeIamTemplates() should not add IamRole if arn is provided', 'AwsCompileFunctions #compileFunctions() should throw if no individual artifact', 'AwsCompileFunctions #compileFunctions() should use fu... | ['#mergeIamTemplates() should update IamPolicyLambdaExecution with a logging resource for the function', '#mergeIamTemplates() should add custom IAM policy statements', '#mergeIamTemplates() should add a CloudWatch LogGroup resource', "#mergeIamTemplates() should update IamPolicyLambdaExecution with each function's log... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/tests/index.js lib/plugins/aws/deploy/tests/configureStack.js lib/plugins/aws/deploy/tests/mergeIamTemplates.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/deploy/lib/configureStack.js->program->method_definition:configureStack", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:mergeIamTemplates"] |
serverless/serverless | 2,511 | serverless__serverless-2511 | ['2500'] | 866ae8d01d1e49ad9092972f30231e474afbcbf0 | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 0ff2b4b82b6..22ff36e3c61 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -75,18 +75,22 @@ class Variables {
populateVariable(propertyParam, matchedString, valueToPopulate) {
let property = propertyParam;
-
if (... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index bfef5ecd2d8..ba6b1332ccb 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -155,6 +155,17 @@ describe('Variables', () => {
expect(newProperty).to.equal('my stage is dev');
});
+ it('should p... | passing a number as a cli option errors
# This is a Bug Report
## Description
If I pass a number as a cli option like this:
`sls deploy --account 999123456`
or this:
`sls deploy --account '999123456'`
or this:
`sls deploy --account "999123456"`
I get this error:
```
Trying to populate non string value into a st... | For anyone experiencing the same issue, my workaround is to double quote the number in some way. eg. `sls deploy --account "'999123456'"`
thanks for reporting. Yup this looks like we should allow strings or numbers to populate into a place where a string can be accepted.
| 2016-10-23 10:32:52+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Variables #overwrite() should overwrite undefined and null values', 'Variables #overwrite() should not overwrite false values', 'Variables #getValueFromFile() should populate non json/yml files', 'Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #populateVariable() should ... | ['Variables #populateVariable() should populate number variables as sub string'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:populateVariable"] |
serverless/serverless | 2,499 | serverless__serverless-2499 | ['2267'] | dffd13acf468c6377f0e0b22f09017d1dc74b34e | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 69136a9bf5b..952d3a345c9 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -58,9 +58,6 @@ class Service {
if (!serverlessFile.provider) {
throw new SError('"provider" property is missing in serverless.yml');
... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 0c3d9fc203c..088aad7ef48 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -334,7 +334,7 @@ describe('Service', () => {
});
});
- it('should throw error if functions property is missing', () => {
+ ... | Support Resource only Services
# Feature Proposal
## Description
There are use cases where developers might want to deploy a service that only contains Cloud Formation (CF) resources. Use cases for this include:
- A VPC service to be used by multiple services
- Many-Many SNS topics that cannot be owned by one particul... | This is an interesting take on the idea, because you could then have an 'infrastructure' service. You could even go as far as to have one service depend on another, which would maybe make the outputs of the one service available to the dependent service... I like it.
I like it too
In first instance before I tried ser... | 2016-10-21 06:32:53+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#mergeIamTemplates() should not add IamRole if arn is provided', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getFunction() should return function object', 'Service #getAllFunctions() should return an array of function names in Service', 'Service #constructor() should attach serv... | ['#mergeIamTemplates() should not merge there are no functions', 'Service #load() should not throw error if functions property is missing'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/tests/mergeIamTemplates.js lib/classes/Service.test.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/classes/Service.js->program->class_declaration:Service->method_definition:load", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:mergeIamTemplates"] |
serverless/serverless | 2,434 | serverless__serverless-2434 | ['2418'] | cf927bf8a68496f762a55e5222415c808aa6087b | diff --git a/lib/Serverless.js b/lib/Serverless.js
index 61675bad987..376cd871965 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -84,6 +84,9 @@ class Serverless {
// (https://github.com/serverless/serverless/issues/2041)
this.variables.populateService(this.pluginManager.cliOptions);
+ // valid... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 2a9ce568d60..a5844275313 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -392,21 +392,32 @@ describe('Service', () => {
YAML.dump(serverlessYml));
const serverless = new Serverless({ servicePath:... | Function event configuration can't be moved to a separate file anymore
# This is a Bug Report
## Description
We used to be able to specify a "file variable" for function event configuration, which was quite useful for a service with multiple handlers. This allowed each handler to be in their own directory, along with ... | Actually, on second thought, I could just change the check to look for an array OR a string using the variable syntax. That should be relatively easy given the variable syntax pattern is available in Service.js
I'll give that a crack when I get back from work
| 2016-10-18 11:05:31+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #load() should throw error if frameworkVersion is not satisfied', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getFunction() should return function object', 'Service #getAllFunctions() should return an array of function names in Service', 'Service #constructor() should at... | ["Service #load() should throw error if a function's event is not an array or a variable"] | ['Service #load() should not throw error if functions property is missing'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/classes/Service.js->program->class_declaration:Service", "lib/Serverless.js->program->class_declaration:Serverless->method_definition:run", "lib/classes/Service.js->program->class_declaration:Service->method_definition:load", "lib/classes/Service.js->program->class_declaration:Service->method_definition:validate"... |
serverless/serverless | 2,227 | serverless__serverless-2227 | ['2226'] | 55e84b2f236285842b949ff3073ecb022b3eaaf0 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 24b50630373..32fd3d62020 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -69,7 +69,7 @@ class Service {
};
}
- if (['aws', 'azure', 'google', 'ibm'].indexOf(serverlessFile.provider.name)) {
+ if ([... | diff --git a/tests/classes/Service.js b/tests/classes/Service.js
index e39a8079911..520361f7498 100644
--- a/tests/classes/Service.js
+++ b/tests/classes/Service.js
@@ -207,6 +207,37 @@ describe('Service', () => {
});
});
+ it('should support Serverless file with a non-aws provider', () => {
+ con... | Other provider values (than aws) are not supported
# This is a Bug Report
## Description
If I switch the provider property in my `serverless.yml` file from e.g. `aws` to `ibm` or `google` I get the error message that this provider is not supported and I should chosse from a list with supported providers (supported pro... | null | 2016-09-27 15:53:16+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Service #load() should support Serverless file with a .yaml extension', 'Service #getFunction() should return function object', 'Service #getAllFunctions() should return an array of function names in Service', 'Service #constructor() should attach serverless instance', 'Service #constructor() should construct with de... | ['Service #load() should support Serverless file with a non-aws provider'] | [] | . /usr/local/nvm/nvm.sh && npx mocha tests/classes/Service.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Service.js->program->class_declaration:Service->method_definition:load"] |
serverless/serverless | 2,133 | serverless__serverless-2133 | ['2041'] | e1adf6e921aba5588ba85f3d5cd0ba4158cd4a35 | diff --git a/lib/Serverless.js b/lib/Serverless.js
index 6b31a26444e..0877af0aecb 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -62,12 +62,10 @@ class Serverless {
// load all plugins
this.pluginManager.loadAllPlugins(this.service.plugins);
- // give the CLI the plugins so that it... | diff --git a/tests/classes/CLI.js b/tests/classes/CLI.js
index 6695353f7a9..e21325848c5 100644
--- a/tests/classes/CLI.js
+++ b/tests/classes/CLI.js
@@ -116,10 +116,11 @@ describe('CLI', () => {
};
}
}
- const pluginMock = new PluginMock();
- const plugins = [pluginMock];
+ ser... | Show help without validating opts
# This is a Bug Report
## Description
I get error about populating values when `serverless help`
For bug reports:
- What went wrong?
```
> serverless help
Serverless Error ---------------------------------------
Trying to populate non string value into a string for
var... | null | 2016-09-14 15:27:11+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #loadAllPlugins() should load only core plugins when no service plugins are given', 'PluginManager #run() when using provider specific plugins should run only the providers plugins (if the provider is specified)', 'PluginManager #constructor() should create an empty cliOptions object', 'PluginManager #c... | ['PluginManager #loadCommands() should merge plugin commands', 'CLI #displayHelp() should return true when the "--help" parameter is given', 'PluginManager #getEvents() should get all the matching events for a root level command in the correct order', 'PluginManager #getEvents() should get all the matching events for a... | ['CLI integration tests "before all" hook', 'PluginManager Plugin/CLI integration'] | . /usr/local/nvm/nvm.sh && npx mocha tests/classes/PluginManager.js tests/classes/CLI.js --reporter json | Bug Fix | false | false | false | true | 25 | 2 | 27 | false | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:getCommands", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:displayCommandOptions", "lib/classes/PluginManager.js->program->class... |
serverless/serverless | 2,050 | serverless__serverless-2050 | ['2049'] | f9c23ad573e3e07fde49e3955004bcfde1d96a93 | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js
index 521925868de..e150d834ef9 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js
index 563eb505342..ab169a668bc 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/me... | API Gateway returns 200 when function times out
# This is a Bug Report
## Description
- What went wrong?
When a lambda function times out, API Gateway still returns a 200 OK status code
- What should have happened?
API Gateway should return a 500 or 504 status code when a lambda function times out
- What was the co... | null | 2016-09-07 05:54:29+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileMethods() when dealing with request configuration should setup a default "application/x-www-form-urlencoded" template', '#compileMethods() when dealing with request configuration should throw an error if the provided config is not an object', '#compileMethods() should add CORS origins to method only when CORS... | ['#compileMethods() should add integration responses for different status codes'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js->program->method_definition:compileMethods"] |
serverless/serverless | 2,014 | serverless__serverless-2014 | ['2024'] | dcb30fb1395d37fb0580bc287bfd21959c532144 | diff --git a/docs/02-providers/aws/events/01-apigateway.md b/docs/02-providers/aws/events/01-apigateway.md
index 3f777ee870d..c1551a3f9fd 100644
--- a/docs/02-providers/aws/events/01-apigateway.md
+++ b/docs/02-providers/aws/events/01-apigateway.md
@@ -324,6 +324,62 @@ module.exports.hello = (event, context, cb) => {
... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js
index fe62ba805f0..948a68d0e24 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/me... | Setting up cors for same endpoint only merges Methods, but not headers and origins
<!--
1. Please check if an issue already exists so there are no duplicates
2. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
3. Fill out the whole template so we have a good over... | null | 2016-09-04 22:35:18+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileMethods() when dealing with request configuration should setup a default "application/x-www-form-urlencoded" template', '#compileMethods() when dealing with request configuration should throw an error if the provided config is not an object', '#compileMethods() when dealing with request configuration should b... | ['#compileMethods() should add multiple response templates for a custom response codes', '#compileMethods() should merge all preflight origins, method, and headers for a path', '#compileMethods() should add custom response codes', '#compileMethods() should add integration responses for different status codes'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js->program->method_definition:compileMethods"] |
serverless/serverless | 1,985 | serverless__serverless-1985 | ['1983'] | f39f54c6089780c68dd325e73f742d0b64802fb5 | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/README.md b/lib/plugins/aws/deploy/compile/events/apiGateway/README.md
index 649e0d89660..3e426103cfa 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/README.md
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/README.md
@@ -85,7 +85,7 @@ f... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js
index d921e934927..d1faafb2ebf 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGate... | Custom Authorizer default header should be Authorization instead of Auth
# This is a Bug Report
## Description
The default header for custom authorizers seems to be "Auth":
https://github.com/serverless/serverless/blob/7715c014fd34fc9b48401231c16ffe6c2467eed3/lib/plugins/aws/deploy/compile/events/apiGateway/lib/autho... | Yup that sounds good, added it to the next milestone and a help-wanted-easy label if somebody picks it up for a PR before us.
| 2016-08-30 21:06:46+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileAuthorizers() should create default authorizer resource if string ARN is provided', '#compileAuthorizers() should create authorizer with the given config object', '#compileAuthorizers() throw error if authorizer property is an object but no name or arn provided', '#compileAuthorizers() should create authorize... | ['#compileAuthorizers() should create default authorizer resource if string is provided'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/authorizers.js->program->method_definition:compileAuthorizers"] |
serverless/serverless | 1,970 | serverless__serverless-1970 | ['1948'] | 39c330569e4231a909c74e3c4a7374327a5667b2 | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/authorizers.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/authorizers.js
index 19e14424139..b2c2f0a4bf4 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/authorizers.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/li... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js
index 42066dd60d9..d921e934927 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGate... | Unable to create Authorizer using Object notation in serverless.yml
Serverless Framework Version: 1.0.0-beta.2
Operating System: Mac OS X 10.11.4
Expected Behavior: API Gateway Authorizer created
Actual Behavior: API Gateway Authorizer fails to create, with the following message:
```
Serverless Error ------------... | null | 2016-08-26 10:31:49+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileAuthorizers() throw error if authorizer property is an object but no name or arn provided', '#compileAuthorizers() should create default authorizer resource if string ARN is provided', '#compileAuthorizers() throw error if authorizer property is not a string or object'] | ['#compileAuthorizers() should create default authorizer resource if string is provided', '#compileAuthorizers() should create authorizer with the given config object', '#compileAuthorizers() should create authorizer with the given config object with ARN'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/authorizers.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/authorizers.js->program->method_definition:compileAuthorizers"] |
serverless/serverless | 1,910 | serverless__serverless-1910 | ['1902'] | 67644f72843e558d5d407a40480e3ca011a3a6ce | diff --git a/lib/plugins/create/create.js b/lib/plugins/create/create.js
index 4d77a7c3c70..84e8d0212e7 100644
--- a/lib/plugins/create/create.js
+++ b/lib/plugins/create/create.js
@@ -36,6 +36,10 @@ class Create {
usage: 'The path where the service should be created (e.g. --path my-service)',
... | diff --git a/lib/plugins/create/tests/create.js b/lib/plugins/create/tests/create.js
index 9082070676f..11775a50301 100644
--- a/lib/plugins/create/tests/create.js
+++ b/lib/plugins/create/tests/create.js
@@ -48,6 +48,23 @@ describe('Create', () => {
expect(() => create.create()).to.throw(Error);
});
+ ... | Add --name option to create plugin
##### Feature Request:
With `serverless create -t aws-nodejs --name my_service` you should be able to automatically overwrite the name of the created service
##### Benefits:
- Make it easier for users to set the name and not run into an issue when the name is set to the default name
... | null | 2016-08-20 07:52:07+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['Create #create() should generate scaffolding for "aws-java-gradle" template', 'Create #create() should create a renamed service in the directory if using the "path" option', 'Create #constructor() should have commands', 'Create #create() should generate scaffolding for "aws-java-maven" template', 'Create #create() sh... | ['Create #create() should create a custom renamed service in the directory if using the "path" and "name" option', 'Create #create() should overwrite the name for the service if user passed name'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/create/tests/create.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/create/create.js->program->class_declaration:Create->method_definition:constructor", "lib/plugins/create/create.js->program->class_declaration:Create->method_definition:create"] |
serverless/serverless | 1,702 | serverless__serverless-1702 | ['1683'] | b00517062f824c92776d06e6a7868a2ec4b89b99 | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js
index 1c934cfd349..4437face8ce 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/resources.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/resources.js
index 30ad2e2881b..5459bcf3798 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/resources.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/te... | Service will not redeploy correctly if new functions are added above old ones
##### Serverless Framework Version: v1.0.0-alpha.2
##### Operating System: OSX
##### Expected Behavior:
When I add a new function to the serverless.yaml file. The service is redeployed correctly
##### Actual Behavior:
If the new function ... | Intersting!!!! Nice catch! So if I understood this correctly, the order of the functions defined in `serverless.yml` matters?
Hmmm yeah I guess that makes sense because we currently map the endpoints/resources according to index.
Yea basically you always need to add to the bottom. Yup, should look at mapping them to ... | 2016-07-28 21:23:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['#compileResources() should construct the correct resourcePaths array', '#compileResources() should not create resource resources when http events are not given'] | ['#compileResources() should create resource resources when http events are given', '#compileResources() should construct the correct resourceLogicalIds object'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/resources.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js->program->method_definition:compileMethods", "lib/plugins/aws/deploy/compile/events/apiGateway/lib/resources.js->program->method_definition:compileResources"] |
serverless/serverless | 1,670 | serverless__serverless-1670 | ['1521'] | 11fcea1331b4393e152cd81c4458d493f147f34a | diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index 8bd9d73ea10..714fdab3365 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -129,13 +129,15 @@ class PluginManager {
}
addPlugin(Plugin) {
- this.loadCommands(Plugin);
+ const pluginInstance = new P... | diff --git a/tests/classes/PluginManager.js b/tests/classes/PluginManager.js
index 7dc65d6f4f7..79bfa8008b3 100644
--- a/tests/classes/PluginManager.js
+++ b/tests/classes/PluginManager.js
@@ -410,7 +410,8 @@ describe('PluginManager', () => {
describe('#loadCommands()', () => {
it('should load the plugin comm... | Plugins Are Being Loaded Twice
##### Serverless Framework Version: V.1 Alpha 1
##### Operating System: OSX 10.11.2
##### Expected Behavior:
- Plugins should be loaded once, causing hooks and all else to be set only once.
##### Actual Behavior:
- Plugins are loaded twice
- This is because they are each instantiated twi... | Thanks for reporting! This is really not intended behavior. Will look into it ASAP.
| 2016-07-26 09:05:02+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #loadAllPlugins() should load only core plugins when no service plugins are given', 'PluginManager #run() when using provider specific plugins should run only the providers plugins (if the provider is specified)', 'PluginManager #setCliCOmmands() should set the cliCommands array', 'PluginManager #constr... | ['PluginManager #loadCommands() should load the plugin commands'] | [] | . /usr/local/nvm/nvm.sh && npx mocha tests/classes/PluginManager.js --reporter json | Refactoring | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:addPlugin", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadCommands"] |
serverless/serverless | 1,378 | serverless__serverless-1378 | ['1379'] | 0a5cab72362a2d20e403ddfa88aab121daecc901 | diff --git a/.travis.yml b/.travis.yml
index 9bcbcf59aff..a95ccea4ce2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,7 +14,7 @@ script:
- npm test
# Only Run Integration Tests and ESLINT for the first job in the whole build to make the build faster
- if [[ "$TRAVIS_JOB_NUMBER" =~ [0-9]+\.1 ]]; then npm run ... | diff --git a/lib/plugins/aws/deploy/tests/deployFunctions.js b/lib/plugins/aws/deploy/tests/deployFunctions.js
index 4cd92de472a..1cb539494a7 100644
--- a/lib/plugins/aws/deploy/tests/deployFunctions.js
+++ b/lib/plugins/aws/deploy/tests/deployFunctions.js
@@ -164,7 +164,7 @@ describe('deployFunctions', () => {
... | attempting to run a non existing command is not handled
```
Eslams-MacBook-Pro:test-projects eslam$ sldev whate
_______ __
| _ .-----.----.--.--.-----.----| .-----.-----.-----.
| |___| -__| _| | | -__| _| | -__|__ --|__ --|
|____ |_____|__| \___/|_____|__| |__|_____|____... | null | 2016-06-22 17:10:28+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force | ['PluginManager #loadAllPlugins() should load only core plugins when no service plugins are given', 'PluginManager #setOptions() should set the options object', 'AWS SDK #getCredentials() should get stage credentials', 'AWS SDK #constructor() should set AWS timeout', '#validate() should throw an error if not inside a s... | ['CLI #displayHelp() should return true when the "--v" parameter is given', 'CLI #displayHelp() should return true when the "--help" parameter is given', 'CLI #displayHelp() should return true when the "version" parameter is given', 'CLI #processInput() should only return the options when only options are given', 'CLI ... | ['Service Lifecyle Integration Test should deploy service to aws', 'Service Lifecyle Integration Test should create service in tmp directory', 'Service Lifecyle Integration Test should remove service from aws', 'Service Lifecyle Integration Test should invoke updated function from aws', 'Service Lifecyle Integration Te... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/tests/index.js tests/classes/CLI.js lib/plugins/aws/remove/tests/validate.js lib/plugins/create/tests/create.js tests/integration_test.js tests/classes/PluginManager.js lib/plugins/aws/deploy/tests/deployFunctions.js --reporter json | Bug Fix | false | false | false | true | 19 | 3 | 22 | false | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager", "lib/plugins/create/create.js->program->class_declaration:Create->method_definition:validate", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:validateOptions", "lib/classes/PluginManager.js->program->c... |
microsoft/vscode | 97,440 | microsoft__vscode-97440 | ['96522'] | 50f78a6609b09db0b2de16f6634b73b15fcdf939 | diff --git a/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts b/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
--- a/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
+++ b/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
@@ -699,8 +699,17 @@ ... | diff --git a/src/vs/workbench/services/configurationResolver/test/electron-browser/configurationResolverService.test.ts b/src/vs/workbench/services/configurationResolver/test/electron-browser/configurationResolverService.test.ts
--- a/src/vs/workbench/services/configurationResolver/test/electron-browser/configurationRe... | User input variables not working for launch configuration in multi-root workspace
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please... | I am seeing the same issue. On mac error-message looks a bit different: "Variable 'VARIABLE_NAME' must be defined in an 'input' section of the debug or task configuration.".
Adding "inputs" section in launch.json solves the problem but introduces the need to check in launch.json under version control to share with t... | 2020-05-11 04:03:27+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['Configuration Resolver Service workspace folder with invalid argument', 'Configuration Resolver Service mixed types of configuration variables', 'Configuration Resolver Service substitute one', 'Configuration Resolver Service relative file with invalid argument', 'Configuration Resolver Service contributed variable',... | ['Configuration Resolver Service input variable with undefined workspace folder'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/configurationResolver/test/electron-browser/configurationResolverService.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts->program->method_definition:getConfiguration", "src/vs/workbench/contrib/debug/common/debugger.ts->program->class_declaration:Debugger->method_definition:substituteVariables", "src/vs/workbench/services/configurationResolver/browser/configurationReso... |
microsoft/vscode | 106,767 | microsoft__vscode-106767 | ['106573'] | 8ce35fa28dedbb1b0e78c1bff26ab53d1e702868 | diff --git a/src/vs/editor/contrib/suggest/completionModel.ts b/src/vs/editor/contrib/suggest/completionModel.ts
--- a/src/vs/editor/contrib/suggest/completionModel.ts
+++ b/src/vs/editor/contrib/suggest/completionModel.ts
@@ -56,6 +56,7 @@ export class CompletionModel {
private _refilterKind: Refilter;
private _fi... | diff --git a/src/vs/editor/contrib/suggest/test/suggestModel.test.ts b/src/vs/editor/contrib/suggest/test/suggestModel.test.ts
--- a/src/vs/editor/contrib/suggest/test/suggestModel.test.ts
+++ b/src/vs/editor/contrib/suggest/test/suggestModel.test.ts
@@ -815,6 +815,9 @@ suite('SuggestModel - TriggerAndCancelOracle', fu... | Completions which use spaces are broken after updating from July to August version
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also pleas... | I am a maintainer of LaTeX-Workshop. I confirm that the same version of the extension is used with vscode `1.49` and `1.48.2`.
The list of suggestions are `completionItem`s with undefined `filterText ` and `range` attributes. In both version, invoking `document.getWordRangeAtPosition(vscode.window.activeTextEditor.s... | 2020-09-15 13:59:29+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['SuggestModel - Context Context - shouldAutoTrigger', 'SuggestModel - TriggerAndCancelOracle trigger - on type', 'SuggestModel - TriggerAndCancelOracle #17400: Keep filtering suggestModel.ts after space', "SuggestModel - TriggerAndCancelOracle Intellisense Completion doesn't respect space after equal sign (.html file)... | ['SuggestModel - TriggerAndCancelOracle Trigger (full) completions when (incomplete) completions are already active #99504'] | ['ID getMac', 'Unexpected Errors & Loader Errors should not have unexpected errors'] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/suggest/test/suggestModel.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | false | false | true | 4 | 1 | 5 | false | false | ["src/vs/editor/contrib/suggest/suggestModel.ts->program->class_declaration:SuggestModel->method_definition:_onNewContext", "src/vs/editor/contrib/suggest/completionModel.ts->program->class_declaration:CompletionModel->method_definition:_createCachedState", "src/vs/editor/contrib/suggest/completionModel.ts->program->cl... |
microsoft/vscode | 108,634 | microsoft__vscode-108634 | ['85498'] | 8fbd08709bf969ff92fa3ad5e98c5b2a326b277a | diff --git a/src/vs/workbench/contrib/url/browser/trustedDomains.ts b/src/vs/workbench/contrib/url/browser/trustedDomains.ts
--- a/src/vs/workbench/contrib/url/browser/trustedDomains.ts
+++ b/src/vs/workbench/contrib/url/browser/trustedDomains.ts
@@ -36,10 +36,8 @@ export const manageTrustedDomainSettingsCommand = {
... | diff --git a/src/vs/workbench/contrib/url/test/browser/trustedDomains.test.ts b/src/vs/workbench/contrib/url/test/browser/trustedDomains.test.ts
--- a/src/vs/workbench/contrib/url/test/browser/trustedDomains.test.ts
+++ b/src/vs/workbench/contrib/url/test/browser/trustedDomains.test.ts
@@ -10,10 +10,10 @@ import { URI ... | Trusted Domains link protection parses IP addresses as having subdomains
Issue Type: <b>Bug</b>
Write http://192.168.1.7:3000/ into a text file. Command-click it to try to open the link.
You will get an alert asking whether you want to open the external website. Click “Configure Trusted Domains”.
<img width="1... | null | 2020-10-14 01:44:19+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['Link protection domain matching localhost', 'Link protection domain matching case normalization', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'Link protection domain matching simple', 'Link protection domain matching * star', 'GitHub remote extraction All known formats', 'Link protection do... | ['Link protection domain matching ip addresses', 'Link protection domain matching ports'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/url/test/browser/trustedDomains.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["src/vs/workbench/contrib/url/browser/trustedDomainsValidator.ts->program->function_declaration:isURLDomainTrusted", "src/vs/workbench/contrib/url/browser/trustedDomainsValidator.ts->program->function_declaration:pathMatches", "src/vs/workbench/contrib/url/browser/trustedDomains.ts->program->function_declaration:confi... |
microsoft/vscode | 108,964 | microsoft__vscode-108964 | ['96545', '96545', '96545'] | 13b3c937dc5e3816c79bdd2cdf2cdf6f9c727b75 | diff --git a/src/vs/editor/contrib/snippet/snippetSession.ts b/src/vs/editor/contrib/snippet/snippetSession.ts
--- a/src/vs/editor/contrib/snippet/snippetSession.ts
+++ b/src/vs/editor/contrib/snippet/snippetSession.ts
@@ -114,7 +114,7 @@ export class OneSnippet {
const range = this._editor.getModel().getDecorati... | diff --git a/src/vs/editor/contrib/snippet/test/snippetSession.test.ts b/src/vs/editor/contrib/snippet/test/snippetSession.test.ts
--- a/src/vs/editor/contrib/snippet/test/snippetSession.test.ts
+++ b/src/vs/editor/contrib/snippet/test/snippetSession.test.ts
@@ -561,6 +561,26 @@ suite('SnippetSession', function () {
... | Snippet tab stop selection issue
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sur... | Took a look at this but don't know how to fix it.
I think the error is in the decoration range calculation inside intervalTree.
This line :arrow_down: is being executed with `insertingCnt` being the length of the transformed text (`}`)
changing the decorarion range from `fff` to `fff}`
https://github.com/microsoft/... | 2020-10-20 03:55:34+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['SnippetSession adjust selection (overwrite[Before|After])', 'SnippetSession snippets, insert shorter snippet into non-empty selection', 'SnippetSession snippets, selections & typing', 'SnippetSession snippets, just text', 'SnippetSession snippets, merge', 'SnippetSession snippets, transform example', 'SnippetSession ... | ['SnippetSession snippets, transform adjacent to previous placeholder'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/snippet/test/snippetSession.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/contrib/snippet/snippetSession.ts->program->class_declaration:OneSnippet->method_definition:move"] |
microsoft/vscode | 109,271 | microsoft__vscode-109271 | ['108566'] | 50ada457c5519c69b5d7a937ed3879e1cf06eec7 | diff --git a/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts b/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts
--- a/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts
+++ b/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts
@@ -8,14 +8,24 @@ import { IFileSystemProviderWit... | diff --git a/src/vs/platform/files/test/browser/indexedDBFileService.test.ts b/src/vs/platform/files/test/browser/indexedDBFileService.test.ts
--- a/src/vs/platform/files/test/browser/indexedDBFileService.test.ts
+++ b/src/vs/platform/files/test/browser/indexedDBFileService.test.ts
@@ -6,17 +6,14 @@
import * as assert... | IndexDB file system provider needs a good test suite
Our IndexDB based file system provider is very important for web but currently seems to lack a good test suite. I suggest to look at `src/vs/platform/files/test/electron-browser/diskFileService.test.ts` and see if some of the tests can run against IndexDB to make su... | Looked into this a bit, as far as I can tell we don't have any serverless tests at all yet, is this correct?
@JacksonKearl not sure I understand, we run our unit tests in both [electron](https://github.com/microsoft/vscode/blob/87847325a66f098621f6650a16d665c9cd07f15a/test/unit/electron/index.js#L6-L6) and [browsers](h... | 2020-10-23 23:25:39+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['IndexedDB File Service root is always present', 'IndexedDB File Service exists', 'IndexedDB File Service resolve - file', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'IndexedDB File Service createFile', 'IndexedDB File Service createFolder: creating multiple folders at once'] | ['IndexedDB File Service deleteFolder (recursive)', 'IndexedDB File Service deleteFile', 'IndexedDB File Service createFolder', 'IndexedDB File Service createFile (stream)', 'IndexedDB File Service resolve - directory', 'IndexedDB File Service createFile (batched)', 'IndexedDB File Service createFile (readable)', 'Inde... | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/platform/files/test/browser/indexedDBFileService.test.ts --reporter json --no-sandbox --exit | Testing | false | false | false | true | 25 | 3 | 28 | false | false | ["src/vs/platform/files/browser/indexedDBFileSystemProvider.ts->program->class_declaration:IndexedDBFileSystemProvider->method_definition:rename", "src/vs/platform/files/browser/indexedDBFileSystemProvider.ts->program->class_declaration:IndexedDBFileSystemProvider->method_definition:writeMany", "src/vs/platform/files/b... |
microsoft/vscode | 109,608 | microsoft__vscode-109608 | ['100940'] | e8d3a7b8dc7064c4743ef70cb9ef38c5fca558bc | diff --git a/build/hygiene.js b/build/hygiene.js
--- a/build/hygiene.js
+++ b/build/hygiene.js
@@ -53,6 +53,7 @@ const indentationFilter = [
'!src/vs/base/node/terminateProcess.sh',
'!src/vs/base/node/cpuUsage.sh',
'!test/unit/assert.js',
+ '!resources/linux/snap/electron-launch',
// except specific folders
... | diff --git a/src/vs/base/test/common/processes.test.ts b/src/vs/base/test/common/processes.test.ts
--- a/src/vs/base/test/common/processes.test.ts
+++ b/src/vs/base/test/common/processes.test.ts
@@ -24,7 +24,9 @@ suite('Processes', () => {
VSCODE_PORTABLE: 'x',
VSCODE_PID: 'x',
VSCODE_NODE_CACHED_DATA_DIR: ... | Snap crashes when native dialogs open
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to mak... | Can you show me any crash output, maybe when running `code --verbose`?
@joaomoreno Sure! Here are the logs when I try to open About.
```
[main 2020-06-24T12:53:44.680Z] menubar#runActionInRenderer { type: 'commandId', commandId: 'workbench.action.showAboutDialog' }
[33368:0624/095344.681821:INFO:CONSOLE(1665)] "%c... | 2020-10-28 15:12:05+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['Unexpected Errors & Loader Errors should not have unexpected errors'] | ['Processes sanitizeProcessEnvironment'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/common/processes.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | false | false | true | 13 | 2 | 15 | false | false | ["src/vs/code/electron-main/app.ts->program->class_declaration:CodeApplication->method_definition:registerListeners", "src/vs/platform/native/electron-main/nativeHostMainService.ts->program->class_declaration:NativeHostMainService", "src/vs/platform/native/electron-main/nativeHostMainService.ts->program->class_declarat... |
microsoft/vscode | 109,750 | microsoft__vscode-109750 | ['109709'] | cf4b5a703f581944f308b9a6f1e8b386059caef1 | diff --git a/src/vs/platform/configuration/common/configurationRegistry.ts b/src/vs/platform/configuration/common/configurationRegistry.ts
--- a/src/vs/platform/configuration/common/configurationRegistry.ts
+++ b/src/vs/platform/configuration/common/configurationRegistry.ts
@@ -227,9 +227,9 @@ class ConfigurationRegist... | diff --git a/src/vs/platform/configuration/test/common/configurationRegistry.test.ts b/src/vs/platform/configuration/test/common/configurationRegistry.test.ts
new file mode 100644
--- /dev/null
+++ b/src/vs/platform/configuration/test/common/configurationRegistry.test.ts
@@ -0,0 +1,53 @@
+/*----------------------------... | configurationDefaults contribution changes JSON auto-complete behavior
Reported originally by @JacksonKearl where GitLens seemed to be breaking JSON auto-complete behavior -- causing an extra `"` being added at the end.
![recording (16)](https://user-images.githubusercontent.com/641685/97644218-2495ba00-1a20-11eb-94... |
That JSON extension has `[json]` configurationDefault for the `editor.suggest.insertMode` setting:
https://github.com/microsoft/vscode/blob/master/extensions/json-language-features/package.json#L109
That configurationDefault is lost when the gitlens extension also makes a `[json]` configurationDefault
The bu... | 2020-10-30 16:37:02+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['ConfigurationRegistry configuration defaults - overrides defaults', 'ConfigurationRegistry configuration override', 'Unexpected Errors & Loader Errors should not have unexpected errors'] | ['ConfigurationRegistry configuration override defaults - merges defaults'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/platform/configuration/test/common/configurationRegistry.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/platform/configuration/common/configurationRegistry.ts->program->class_declaration:ConfigurationRegistry->method_definition:registerDefaultConfigurations"] |
microsoft/vscode | 109,829 | microsoft__vscode-109829 | ['109709'] | 49696e87c64f478f97909a91d41ff2913df9bf71 | diff --git a/src/vs/platform/configuration/common/configurationRegistry.ts b/src/vs/platform/configuration/common/configurationRegistry.ts
--- a/src/vs/platform/configuration/common/configurationRegistry.ts
+++ b/src/vs/platform/configuration/common/configurationRegistry.ts
@@ -227,9 +227,9 @@ class ConfigurationRegist... | diff --git a/src/vs/platform/configuration/test/common/configurationRegistry.test.ts b/src/vs/platform/configuration/test/common/configurationRegistry.test.ts
new file mode 100644
--- /dev/null
+++ b/src/vs/platform/configuration/test/common/configurationRegistry.test.ts
@@ -0,0 +1,53 @@
+/*----------------------------... | configurationDefaults contribution changes JSON auto-complete behavior
Reported originally by @JacksonKearl where GitLens seemed to be breaking JSON auto-complete behavior -- causing an extra `"` being added at the end.
![recording (16)](https://user-images.githubusercontent.com/641685/97644218-2495ba00-1a20-11eb-94... |
That JSON extension has `[json]` configurationDefault for the `editor.suggest.insertMode` setting:
https://github.com/microsoft/vscode/blob/master/extensions/json-language-features/package.json#L109
That configurationDefault is lost when the gitlens extension also makes a `[json]` configurationDefault
The bu... | 2020-11-02 06:59:38+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['ConfigurationRegistry configuration defaults - overrides defaults', 'ConfigurationRegistry configuration override', 'Unexpected Errors & Loader Errors should not have unexpected errors'] | ['ConfigurationRegistry configuration override defaults - merges defaults'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/platform/configuration/test/common/configurationRegistry.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/platform/configuration/common/configurationRegistry.ts->program->class_declaration:ConfigurationRegistry->method_definition:registerDefaultConfigurations"] |
microsoft/vscode | 110,094 | microsoft__vscode-110094 | ['72177'] | 8c76afad6ccf861d1ea08df4bb9f83839e0e0cd0 | diff --git a/src/vs/editor/common/controller/cursor.ts b/src/vs/editor/common/controller/cursor.ts
--- a/src/vs/editor/common/controller/cursor.ts
+++ b/src/vs/editor/common/controller/cursor.ts
@@ -531,7 +531,7 @@ export class Cursor extends Disposable {
}
const closeChar = m[1];
- const autoClosingPairsCa... | diff --git a/src/vs/editor/test/browser/controller/cursor.test.ts b/src/vs/editor/test/browser/controller/cursor.test.ts
--- a/src/vs/editor/test/browser/controller/cursor.test.ts
+++ b/src/vs/editor/test/browser/controller/cursor.test.ts
@@ -4660,7 +4660,7 @@ suite('autoClosingPairs', () => {
'v|ar |c = \'|asd\';... | auto closing pairs with conflicting patterns problems
```
Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
```
Steps to Reproduce:
1. Create two a... | Another example is `[<SomeAttribute>]` in F#, where typing `[<` produces `>]]` where the closing bracket is doubled up because `[]` is also a bracket.
As you can see, the first `[` crea... | 2020-11-06 16:35:03+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ["Editor Controller - Regression tests Bug #18293:[regression][editor] Can't outdent whitespace line", "Editor Controller - Cursor issue #17011: Shift+home/end now go to the end of the selection start's line, not the selection's end", 'Editor Controller - Cursor move up', 'Editor Controller - Cursor Configuration remov... | ['autoClosingPairs issue #27937: Trying to add an item to the front of a list is cumbersome', 'autoClosingPairs issue #53357: Over typing ignores characters after backslash', 'autoClosingPairs quote', 'autoClosingPairs configurable open parens', 'autoClosingPairs issue #72177: multi-character autoclose with conflicting... | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/controller/cursor.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | false | false | true | 15 | 3 | 18 | false | false | ["src/vs/editor/common/controller/cursorTypeOperations.ts->program->class_declaration:TypeOperations", "src/vs/editor/common/controller/cursorTypeOperations.ts->program->class_declaration:TypeOperations->method_definition:compositionEndWithInterceptors", "src/vs/editor/common/controller/cursorTypeOperations.ts->program... |
microsoft/vscode | 110,255 | microsoft__vscode-110255 | ['88703', '88703'] | 5ce31a6e8b4feeb1079985aff2d1dce34dcd6876 | diff --git a/src/vs/workbench/services/preferences/common/preferencesValidation.ts b/src/vs/workbench/services/preferences/common/preferencesValidation.ts
--- a/src/vs/workbench/services/preferences/common/preferencesValidation.ts
+++ b/src/vs/workbench/services/preferences/common/preferencesValidation.ts
@@ -92,10 +92... | diff --git a/src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts b/src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts
--- a/src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts
+++ b/src/vs/workbench/services/preferences/test/common/pre... | Errors on fields with URI format not reported in Settings UI
Found this issue while trying to set java.format.settings.url's format to uri (or uri-reference), in order to fix https://github.com/redhat-developer/vscode-java/issues/1237
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.42.0-ins... | I guess we are missing that validation, also, the type of that setting should be `["string", "null"]` if the default is "null".
```
"type": "string",
"description": "Specifies the url or file path to the [Eclipse formatter xml settings](https://github.com/redhat-developer/vscode-java/wiki/Forma... | 2020-11-09 19:30:17+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['Preferences Validation array of enums', 'Preferences Validation getInvalidTypeError', 'Preferences Validation pattern with error message', 'Preferences Validation integer type correctly adds a validation', 'Preferences Validation string max min length work', 'Preferences Validation min-max items array', 'Preferences ... | ['Preferences Validation uri checks work'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/workbench/services/preferences/common/preferencesValidation.ts->program->function_declaration:getStringValidators"] |
microsoft/vscode | 111,897 | microsoft__vscode-111897 | ['111128'] | 528ca4c9ea884058308eb477572d52b7283b6218 | diff --git a/src/vs/editor/common/controller/cursorTypeOperations.ts b/src/vs/editor/common/controller/cursorTypeOperations.ts
--- a/src/vs/editor/common/controller/cursorTypeOperations.ts
+++ b/src/vs/editor/common/controller/cursorTypeOperations.ts
@@ -351,13 +351,6 @@ export class TypeOperations {
if (ir) {
... | diff --git a/src/vs/editor/test/browser/controller/cursor.test.ts b/src/vs/editor/test/browser/controller/cursor.test.ts
--- a/src/vs/editor/test/browser/controller/cursor.test.ts
+++ b/src/vs/editor/test/browser/controller/cursor.test.ts
@@ -4169,6 +4169,18 @@ suite('Editor Controller - Indentation Rules', () => {
... | Multicursor `Enter` issue with indentation (gif attached)
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest i... | @stagefright5 I think this might be caused by one of your installed extensions. Here it is on my machine:
To validate this, could you please [try the following](https://github.com/microsoft/vscode/wi... | 2020-12-04 15:46:34+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ["Editor Controller - Regression tests Bug #18293:[regression][editor] Can't outdent whitespace line", "Editor Controller - Cursor issue #17011: Shift+home/end now go to the end of the selection start's line, not the selection's end", 'Editor Controller - Cursor move up', 'autoClosingPairs issue #27937: Trying to add a... | ['Editor Controller - Indentation Rules issue #111128: Multicursor `Enter` issue with indentation'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/controller/cursor.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/common/controller/cursorTypeOperations.ts->program->class_declaration:TypeOperations->method_definition:_enter"] |
microsoft/vscode | 113,618 | microsoft__vscode-113618 | ['113318'] | 48742bd3a108e30af42d46d1cf2488559b4364dd | diff --git a/src/vs/editor/common/diff/diffComputer.ts b/src/vs/editor/common/diff/diffComputer.ts
--- a/src/vs/editor/common/diff/diffComputer.ts
+++ b/src/vs/editor/common/diff/diffComputer.ts
@@ -313,6 +313,13 @@ export class DiffComputer {
if (this.original.lines.length === 1 && this.original.lines[0].length =... | diff --git a/src/vs/editor/test/common/diff/diffComputer.test.ts b/src/vs/editor/test/common/diff/diffComputer.test.ts
--- a/src/vs/editor/test/common/diff/diffComputer.test.ts
+++ b/src/vs/editor/test/common/diff/diffComputer.test.ts
@@ -462,6 +462,13 @@ suite('Editor Diff - DiffComputer', () => {
assertDiff(origin... | Diffing two empty files shows them as having changes
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest inside... | null | 2020-12-31 06:39:42+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['Editor Diff - DiffComputer two inserted lines in middle interrupted', 'Editor Diff - DiffComputer one inserted line in middle', 'Editor Diff - DiffComputer one deleted lines above', 'Editor Diff - DiffComputer two deleted lines above', 'Editor Diff - DiffComputer char change postprocessing merges', 'Editor Diff - Dif... | ['Editor Diff - DiffComputer empty diff 5'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/diff/diffComputer.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/common/diff/diffComputer.ts->program->class_declaration:DiffComputer->method_definition:computeDiff"] |
microsoft/vscode | 113,837 | microsoft__vscode-113837 | ['113404', '113404'] | bd5c20448c598534e94e741c31e03775380db98a | diff --git a/src/vs/base/common/filters.ts b/src/vs/base/common/filters.ts
--- a/src/vs/base/common/filters.ts
+++ b/src/vs/base/common/filters.ts
@@ -467,7 +467,7 @@ function isSeparatorAtPos(value: string, index: number): boolean {
if (index < 0 || index >= value.length) {
return false;
}
- const code = value.... | diff --git a/src/vs/base/test/common/filters.test.ts b/src/vs/base/test/common/filters.test.ts
--- a/src/vs/base/test/common/filters.test.ts
+++ b/src/vs/base/test/common/filters.test.ts
@@ -534,6 +534,11 @@ suite('Filters', () => {
assert.ok(Boolean(match));
});
+ test('Wrong highlight after emoji #113404', fun... | Wrong highlight if there are duplicate strings in completion item
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the ... | (Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
- [Onclick div it will show outer div boundary instead of current div (#70316)](https://www.github.com/microsoft/vscode/issues/70316) <!-- score: 0.544 -->
- [Emmet expression with a... | 2021-01-05 16:42:16+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ["Filters Vscode 1.12 no longer obeys 'sortText' in completion items (from language server), #26096", 'Filters Unexpected suggestion scoring, #28791', 'Filters HTML closing tag proposal filtered out #38880', 'Filters PrefixFilter - ignore case', 'Filters matchesSubString', 'Filters fuzzyScore', 'Filters fuzzyScore, man... | ['Filters Wrong highlight after emoji #113404'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/common/filters.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/base/common/filters.ts->program->function_declaration:isSeparatorAtPos"] |
microsoft/vscode | 113,842 | microsoft__vscode-113842 | ['113809'] | 45f79f85735868fd7644e811b67f26d0b1633b90 | diff --git a/src/vs/workbench/contrib/files/browser/fileActions.ts b/src/vs/workbench/contrib/files/browser/fileActions.ts
--- a/src/vs/workbench/contrib/files/browser/fileActions.ts
+++ b/src/vs/workbench/contrib/files/browser/fileActions.ts
@@ -379,6 +379,32 @@ export function incrementFileName(name: string, isFolder... | diff --git a/src/vs/workbench/contrib/files/test/browser/fileActions.test.ts b/src/vs/workbench/contrib/files/test/browser/fileActions.test.ts
--- a/src/vs/workbench/contrib/files/test/browser/fileActions.test.ts
+++ b/src/vs/workbench/contrib/files/test/browser/fileActions.test.ts
@@ -258,7 +258,7 @@ suite('Files - In... | increment file name does not work with zero prefixed file name when using smart incremental naming
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
... | (Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
- [The extension cannot be used after the update (#113219)](https://www.github.com/microsoft/vscode/issues/113219) <!-- score: 0.485 -->
- ["file copy + rename" scenario explorer bug... | 2021-01-05 18:26:16+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['Files - Increment file name smart Increment file name with suffix version with `_` as separator', 'Files - Increment file name simple Increment folder name with suffix version, leading zeros', 'Files - Increment file name smart Increment file name with prefix version with `_` as separator', 'Files - Increment file na... | ['Files - Increment file name smart Increment file name with no extension', 'Files - Increment file name smart Increment file name with just version and no extension', 'Files - Increment file name smart Increment file name with no extension and no version'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/files/test/browser/fileActions.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/workbench/contrib/files/browser/fileActions.ts->program->function_declaration:incrementFileName"] |
microsoft/vscode | 114,129 | microsoft__vscode-114129 | ['114125', '114125'] | 2fd00ba9feff480d3ff6dde51201dc1e53fbe7e1 | diff --git a/src/vs/platform/files/common/fileService.ts b/src/vs/platform/files/common/fileService.ts
--- a/src/vs/platform/files/common/fileService.ts
+++ b/src/vs/platform/files/common/fileService.ts
@@ -901,7 +901,7 @@ export class FileService extends Disposable implements IFileService {
watch(resource: URI, op... | diff --git a/src/vs/workbench/services/configuration/test/electron-browser/configurationEditingService.test.ts b/src/vs/workbench/services/configuration/test/electron-browser/configurationEditingService.test.ts
--- a/src/vs/workbench/services/configuration/test/electron-browser/configurationEditingService.test.ts
+++ b... | Flaky test: ConfigurationEditingService
Noticed failure on Windows: https://dev.azure.com/vscode/VSCode/_build/results?buildId=61555&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=d494b5db-eef8-5766-984e-01186010c86f
```
6402 passing (2m)
52 pending
1 failing
1) ConfigurationEditingService
... | 2021-01-11 08:18:52+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['ConfigurationEditingService write user standalone setting - existing file', 'ConfigurationEditingService remove non existing setting - existing file', 'ConfigurationEditingService write one setting - empty file', 'ConfigurationEditingService write workspace standalone setting - existing file - full JSON', 'Configurat... | ['Unexpected Errors & Loader Errors should not have unexpected errors'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/configuration/test/electron-browser/configurationEditingService.test.ts src/vs/workbench/test/browser/workbenchTestServices.ts --reporter json --no-sandbox --exit | Bug Fix | false | false | false | true | 7 | 5 | 12 | false | false | ["src/vs/workbench/services/configuration/browser/configuration.ts->program->class_declaration:FileServiceBasedWorkspaceConfiguration", "src/vs/workbench/services/configuration/browser/configuration.ts->program->class_declaration:FolderConfiguration->method_definition:constructor", "src/vs/workbench/services/configurat... | |
microsoft/vscode | 114,208 | microsoft__vscode-114208 | ['37570', '37570'] | 67f9988bdc476e99eedd50ae083ec3d90eb38604 | diff --git a/src/vs/editor/contrib/snippet/snippetVariables.ts b/src/vs/editor/contrib/snippet/snippetVariables.ts
--- a/src/vs/editor/contrib/snippet/snippetVariables.ts
+++ b/src/vs/editor/contrib/snippet/snippetVariables.ts
@@ -43,6 +43,7 @@ export const KnownSnippetVariableNames: { [key: string]: true } = Object.fr... | diff --git a/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts b/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts
--- a/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts
+++ b/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts
@@ -15,6 +15,7 @@ import { mock } from 'vs/base/test/... | Add relative directory/filepath support to snippets
- VSCode Version: Code 1.17.1 (1e9d36539b0ae51ac09b9d4673ebea4e447e5353, 2017-10-10T14:24:41.632Z)
- OS Version: Windows_NT ia32 6.3.9600
Currently, snippets allow you to resolve the current directory or filepath with `TM_DIRECTORY` and `TM_FILEPATH` respectively.... | We have added [*Variable Transformations*](https://code.visualstudio.com/docs/editor/userdefinedsnippets#_variable-transforms) for thing like this. Please give it a try
I'm not sure how that would help in this case. If `TM_DIRECTORY` resolves to `C:\dev\projects\my_projects\secret_projects\secret_project1\features\secr... | 2021-01-12 13:56:19+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['Snippet Variables Resolver Snippet transforms do not handle regex with alternatives or optional matches, #36089', 'Snippet Variables Resolver editor variables, selection', 'Snippet Variables Resolver TextmateSnippet, resolve variable', 'Snippet Variables Resolver TextmateSnippet, resolve variable with default', 'Snip... | ['Snippet Variables Resolver Add RELATIVE_FILEPATH snippet variable #114208'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/snippet/test/snippetVariables.test.ts --reporter json --no-sandbox --exit | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/contrib/snippet/snippetVariables.ts->program->class_declaration:ModelBasedVariableResolver->method_definition:resolve"] |
microsoft/vscode | 114,235 | microsoft__vscode-114235 | ['104952'] | 145bcd3a732e76e50c0e5f2d140145311a0257b3 | diff --git a/src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts b/src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts
--- a/src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts
+++ b/src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts
@@ -16,6 ... | diff --git a/src/vs/workbench/contrib/snippets/test/browser/snippetsService.test.ts b/src/vs/workbench/contrib/snippets/test/browser/snippetsService.test.ts
--- a/src/vs/workbench/contrib/snippets/test/browser/snippetsService.test.ts
+++ b/src/vs/workbench/contrib/snippets/test/browser/snippetsService.test.ts
@@ -13,6 ... | Snippets + Auto-closing pairs don't compliment each other
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest i... | Here's a javascript example for array destructuring:
```json
"arraydestructuring": {
"prefix": "[a",
"body": [
"[a, b, ...next] = ${1:array}"
],
"description": "arraydestructuring"
}
```
which gets you:
```
[a, b, ...next] = array]
```
when you type:... | 2021-01-12 23:58:19+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['SnippetsService No user snippets in suggestions, when inside the code, #30508', 'SnippetsService Dash in snippets prefix broken #53945', 'SnippetsService No snippets suggestion beyond character 100 if not at end of line #60247', 'SnippetsService Snippet prefix with special chars and numbers does not work #62906', 'Sn... | ['SnippetsService Snippet will replace auto-closing pair if specified in prefix'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/snippets/test/browser/snippetsService.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts->program->class_declaration:SnippetCompletionProvider->method_definition:provideCompletionItems"] |
microsoft/vscode | 114,419 | microsoft__vscode-114419 | ['114416', '114416'] | 62bb9b3d3fd94f4a63a9b145b9fa1b5ed4b11207 | diff --git a/src/vs/workbench/services/label/common/labelService.ts b/src/vs/workbench/services/label/common/labelService.ts
--- a/src/vs/workbench/services/label/common/labelService.ts
+++ b/src/vs/workbench/services/label/common/labelService.ts
@@ -152,6 +152,8 @@ export class LabelService extends Disposable implemen... | diff --git a/src/vs/workbench/services/label/test/browser/label.test.ts b/src/vs/workbench/services/label/test/browser/label.test.ts
--- a/src/vs/workbench/services/label/test/browser/label.test.ts
+++ b/src/vs/workbench/services/label/test/browser/label.test.ts
@@ -160,7 +160,7 @@ suite('URI Label', () => {
});
-... | LabelService.getUriLabel misreports relative path when workspace folder is at root of filesystem
Issue Type: <b>Bug</b>
This showed up when trying to use the new `RELATIVE_FILEPATH` snippet variable (see #114208) with a resource served by a FileSystemProvider in which it is common to have a workspace path of `/`
... | 2021-01-15 13:46:13+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['URI Label mulitple authority', 'URI Label custom scheme', 'URI Label custom query without value', 'URI Label custom query without query json', 'URI Label custom authority', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'multi-root workspace labels of files in multiroot workspaces are the fold... | ['workspace at FSP root relative label'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/label/test/browser/label.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/workbench/services/label/common/labelService.ts->program->class_declaration:LabelService->method_definition:doGetUriLabel"] |
Subsets and Splits
Top Repos by Test Count
Lists the top 1000 repositories by the number of entries, providing a basic count of entries per repository.
Unique Repo Selection
Lists unique repository names from the dataset, providing a basic overview of the repositories present.