author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 26.05.2017 15:22:02 | 14,400 | 8839d92aac472ce5394ec241362f2c7d93c76edc | Fixing Android header height right corrected some jittering bugs and explains the 75 number I had to previously adjust by | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -269,18 +269,18 @@ class InnerCalendar extends React.PureComponent {\n}\n}\n- componentDidUpdate(prevProps: Props, prevState: State) {\n+ componentWillUpdate(nextP... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fixing Android header height right corrected some jittering bugs and explains the 75 number I had to previously adjust by |
129,187 | 26.05.2017 17:08:01 | 14,400 | d0d823ebeb7e3675f43122df262b1ad49cf46e70 | When an entry is clicked, scroll to a position where it's viewable even with the keyboard being shown | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -10,6 +10,7 @@ import type { Dispatch } from 'lib/types/redux-types';\nimport type { Action } from '../navigation-setup';\nimport type { PingStarting... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | When an entry is clicked, scroll to a position where it's viewable even with the keyboard being shown |
129,187 | 26.05.2017 19:11:33 | 14,400 | fcee6dfb8b822065d1a4e5bcc5b7a72a90311df6 | LayoutAnimation! Wow this rocks
Also, keyboardShouldPersistTaps="handled"
Also, handle keyboard/focus events regardless of order
And guard against all unmounted setStates in Entry
And some other stuff too! | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -165,6 +165,7 @@ class InnerCalendar extends React.PureComponent {\n// once the keyboard event happens, we know where to move the scrollPos to\nlastEntryKeyFocused... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | LayoutAnimation! Wow this rocks
Also, keyboardShouldPersistTaps="handled"
Also, handle keyboard/focus events regardless of order
And guard against all unmounted setStates in Entry
And some other stuff too! |
129,187 | 26.05.2017 20:05:08 | 14,400 | 5fbf4fe00ad1bbaf08f51b65d196213fcb613910 | Faster response and move of LayoutAnimation call to a more precise place | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -20,6 +20,7 @@ import {\nPlatform,\nActivityIndicator,\nKeyboard,\n+ LayoutAnimation,\n} from 'react-native';\nimport Icon from 'react-native-vector-icons/FontAwes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Faster response and move of LayoutAnimation call to a more precise place |
129,187 | 26.05.2017 20:11:52 | 14,400 | 7f4805a0c2874bab99d890e43e8aeb5cd8898d37 | Android improvements on entry behavior on select and text change | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -226,18 +226,13 @@ class Entry extends React.Component {\nconst entryStyle = { backgroundColor: `#${this.state.color}` };\nconst textStyle: Object = {\ncolor: darkColor ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Android improvements on entry behavior on select and text change |
129,187 | 26.05.2017 20:44:58 | 14,400 | e285ee521808ff026058679e0603910df1a78e9b | Display thread name on the right side of the entry in the action links | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -204,6 +204,7 @@ class Entry extends React.Component {\nconst actionLinksUnderlayColor = darkColor ? \"#AAAAAA88\" : \"#CCCCCCDD\";\nactionLinks = (\n<View style={styles... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Display thread name on the right side of the entry in the action links |
129,187 | 27.05.2017 13:52:22 | 14,400 | 7629754891a3690a3f9bab0dac4c3010e568124a | expectedEntriesOnScreen: a shared way to handle listShrinkingloadingNewEntriesFromScroll, and readyToShowList without timers!
Basically, we just determine which entries we expect to see on screen, and wait for onViewableItemsChanged to tell us they are there | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -154,7 +154,6 @@ class InnerCalendar extends React.PureComponent {\ntextHeights: ?{ [text: string]: number } = null;\ncurrentState: ?string = NativeAppState.curren... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | expectedEntriesOnScreen: a shared way to handle listShrinkingloadingNewEntriesFromScroll, and readyToShowList without timers!
Basically, we just determine which entries we expect to see on screen, and wait for onViewableItemsChanged to tell us they are there |
129,187 | 27.05.2017 16:25:27 | 14,400 | d06473fcd1c33c02d7281f70f130d5b384858d98 | Get rid of unused prop initialNumToRender on Calendar | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -98,7 +98,6 @@ type State = {\ntextToMeasure: string[],\nlistDataWithHeights: ?$ReadOnlyArray<CalendarItemWithHeight>,\nreadyToShowList: bool,\n- initialNumToRende... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of unused prop initialNumToRender on Calendar |
129,187 | 27.05.2017 16:29:14 | 14,400 | af5ecea4833235c81127536effeda726104c5346 | minHeight on TextHeightMeasurer (20 for calendar entries) | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -590,6 +590,7 @@ class InnerCalendar extends React.PureComponent {\n<TextHeightMeasurer\ntextToMeasure={this.state.textToMeasure}\nallHeightsMeasuredCallback={this... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | minHeight on TextHeightMeasurer (20 for calendar entries) |
129,187 | 27.05.2017 17:26:47 | 14,400 | 616ea24dd9fbaf49679eedb8bf7b10210729c3aa | Way less jerkiness! Used secret ScrollView callbacks onMomentumScrollEnd and onScrollEndDrag to detect when scrolling stops, and only focus Entries at that point to minimize off-screen TextInput renders, which are the primary cause of the jerkiness | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -99,12 +99,6 @@ type State = {\nlistDataWithHeights: ?$ReadOnlyArray<CalendarItemWithHeight>,\nreadyToShowList: bool,\npickerOpenForDateString: ?string,\n- // We a... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Way less jerkiness! Used secret ScrollView callbacks onMomentumScrollEnd and onScrollEndDrag to detect when scrolling stops, and only focus Entries at that point to minimize off-screen TextInput renders, which are the primary cause of the jerkiness |
129,187 | 27.05.2017 19:50:51 | 14,400 | 7e9a6cfff3a55105b54133d07f84626a23c8c7d3 | Numerous refinements to the Calendar FlatList, primarily around scroll behavior. It's finally starting to actually sorta look good! | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -33,9 +33,9 @@ import _find from 'lodash/fp/find';\nimport _difference from 'lodash/fp/difference';\nimport _filter from 'lodash/fp/filter';\nimport _sum from 'lod... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Numerous refinements to the Calendar FlatList, primarily around scroll behavior. It's finally starting to actually sorta look good! |
129,187 | 27.05.2017 20:48:59 | 14,400 | 99ad80a7646bc04a7858b170e224790d31769152 | Much better detect-new-items-added method - just make sure the loader items aren't on-screen anymore. Way simpler, and works better. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -35,7 +35,6 @@ import _filter from 'lodash/fp/filter';\nimport _sum from 'lodash/fp/sum';\nimport _pickBy from 'lodash/fp/pickBy';\nimport _size from 'lodash/fp/si... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Much better detect-new-items-added method - just make sure the loader items aren't on-screen anymore. Way simpler, and works better. |
129,187 | 28.05.2017 12:33:52 | 14,400 | 3c6512f3b17d992e219a412b19be09a8d7c65ce9 | More refinements! Here's a list
Avoid assumption of keyboardShow/onEntryFocus events in pairs for scrollToKey,
No more minHeight
Make sure onBlur always fires when focus lost
Ese autoFocus prop in Entry
Avoid double-deletes and double-saves in Entry
Detect presses on Entry View in lieu of TextInput onFocus | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -603,7 +603,6 @@ class InnerCalendar extends React.PureComponent {\n<TextHeightMeasurer\ntextToMeasure={this.state.textToMeasure}\nallHeightsMeasuredCallback={this... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | More refinements! Here's a list
- Avoid assumption of keyboardShow/onEntryFocus events in pairs for scrollToKey,
- No more minHeight
- Make sure onBlur always fires when focus lost
- Ese autoFocus prop in Entry
- Avoid double-deletes and double-saves in Entry
- Detect presses on Entry View in lieu of TextInput onFocus |
129,187 | 28.05.2017 13:20:20 | 14,400 | d9fb58016ad17af6ee60c65ec70048d1e0c97b1f | Make sure info.viewableItems.length > 0 for readyToShowList gets set, since Android will render nothing first for some reason | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -770,7 +770,8 @@ class InnerCalendar extends React.PureComponent {\nif (\n!this.state.readyToShowList &&\n!this.topLoaderWaitingToLeaveView &&\n- !this.bottomLoade... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure info.viewableItems.length > 0 for readyToShowList gets set, since Android will render nothing first for some reason |
129,187 | 28.05.2017 14:55:34 | 14,400 | 0d17fde013e9a4b6215fce33278ca14d5831d551 | On iOS have the network spinner spin when networking requests are active | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -48,6 +48,7 @@ import {\nbindServerCalls,\n} from 'lib/utils/action-utils';\nimport { simpleNavID } from 'lib/selectors/nav-selectors';\n+import { registerFetchKey... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | On iOS have the network spinner spin when networking requests are active |
129,187 | 28.05.2017 20:38:35 | 14,400 | ac86c4b6ad0e2259daf61154ac82bba42793b231 | Update versions of stuff | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"dependencies\": {\n\"invariant\": \"^2.2.2\",\n\"react\": \"^16.0.0-alpha.12\",\n- \"react-native\": \"^0.45.0-rc.0\",\n- \"react-native-cookies\": \"^3.0.0\",\n+ \"react-native\": \"^0.45.0-r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update versions of stuff |
129,187 | 30.05.2017 16:47:17 | 14,400 | 57a90a7f94861b1216292ae371890f611029efec | fetch_messages.php & message_lib.php | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/fetch_messages.php",
"diff": "+<?php\n+\n+require_once('async_lib.php');\n+require_once('message_lib.php');\n+\n+async_start();\n+\n+$input = isset($_GET['input']) ? $_GET['input'] : null;\n+$number_per_thread = isset($_GET['number_per_th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | fetch_messages.php & message_lib.php |
129,187 | 03.06.2017 17:46:51 | 14,400 | 789299b510bf207155175dc4ea8e70b1aa51c25f | Piping in the thread info to the chat screen | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "import type { EntryInfo } from 'lib/types/entry-types';\nimport { entryInfoPropType } from 'lib/types/entry-types';\nimport type { AppState } from '../redux-setup';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Piping in the thread info to the chat screen |
129,187 | 04.06.2017 16:36:13 | 14,400 | e6f7c391b54bc68017e72a0d4c4436d6191383ce | Add 5-height ListHeaderComponent to ChatThreadList | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -67,6 +67,10 @@ class InnerChatThreadList extends React.PureComponent {\nreturn _sum(data.map(InnerChatThreadList.itemHeight));\n}\n+ static ListHeaderComp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add 5-height ListHeaderComponent to ChatThreadList |
129,187 | 04.06.2017 17:35:06 | 14,400 | 6fb463d5839e799d0c10156cb760a97b9429c31d | Add last activity time to ChatThreadListItem | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/date-utils.js",
"new_path": "lib/utils/date-utils.js",
"diff": "@@ -77,6 +77,22 @@ function dateFromString(dayString: string): Date {\n);\n}\n+const millisecondsInDay = 24 * 60 * 60 * 1000;\n+const millisecondsInWeek = millisecondsInDay * 7;\n+\n+// ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add last activity time to ChatThreadListItem |
129,187 | 05.06.2017 09:20:42 | 14,400 | 57e40a113616077bb212af926e4391eab80aa31c | onPressItem in ChatThreadList and some styling fixes after testing on Android | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -9,15 +9,19 @@ import React from 'react';\nimport { View, StyleSheet, Text } from 'react-native';\nimport PropTypes from 'prop-types';\n+import {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | onPressItem in ChatThreadList and some styling fixes after testing on Android |
129,187 | 05.06.2017 12:12:34 | 14,400 | 95abbf5317e04b2477344bb65bda8ec7a3204e0c | Typesystem stuff done for now... action-utils has fewer "any"s now | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -369,12 +369,16 @@ export type BaseAction =\nloadingInfo: LoadingInfo,\n};\n-type ThunkedAction<A> = (dispatch: Dispatch<A>) => void;\n-type PromisedAction<A> = (dispatch: Dispatch<... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Typesystem stuff done for now... action-utils has fewer "any"s now |
129,187 | 05.06.2017 16:12:56 | 14,400 | e4cdb74fc2a289335a591f836eafa6ba5da20b00 | Basic chat view that just lists messages as Text | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "// @flow\n-import type { NavigationScreenProp } from 'react-navigation';\n+import type {\n+ NavigationScreenProp,\n+ NavigationRoute,\n+ NavigationActio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Basic chat view that just lists messages as Text |
129,187 | 05.06.2017 19:15:35 | 14,400 | 8e391fdf34beff1bc484a167f671c0b42185e01f | Create Message React component and give it some style yo | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/package-lock.json",
"diff": "+{\n+ \"name\": \"lib\",\n+ \"version\": \"0.0.1\",\n+ \"lockfileVersion\": 1,\n+ \"dependencies\": {\n+ \"asap\": {\n+ \"version\": \"2.0.5\",\n+ \"resolved\": \"https://registry.npmjs.org/asap/-/asap-2.0.5.tgz\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Create Message React component and give it some style yo |
129,187 | 06.06.2017 09:26:46 | 14,400 | ecef8d8a3a004b8b8601558f0f6efe8e9af1f25d | Set up MessageList to use TextHeightMeasurer | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -143,7 +143,6 @@ class InnerCalendar extends React.PureComponent {\n/>\n),\n};\n- textHeightMeasurer: ?TextHeightMeasurer = null;\nflatList: ?FlatList<CalendarItem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Set up MessageList to use TextHeightMeasurer |
129,187 | 06.06.2017 17:06:32 | 14,400 | 7cc411390949ddf68abc874a9d255af4bf19280d | Auto-grow the chat TextInput on iOS and Android and make it look pretty | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/input-bar.react.js",
"diff": "+// @flow\n+\n+import React from 'react';\n+import {\n+ View,\n+ StyleSheet,\n+ TextInput,\n+ TouchableOpacity,\n+ LayoutAnimation,\n+ Platform,\n+} from 'react-native';\n+import Icon from 'react-native-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Auto-grow the chat TextInput on iOS and Android and make it look pretty |
129,187 | 07.06.2017 11:27:13 | 14,400 | 7f115ba182874e726467ecdb5a5b819b5cc0e29f | Error handling for failed message sends (delete them) | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -315,6 +315,25 @@ function reduceMessageStore(\n},\ncurrentAsOf: messageStore.currentAsOf,\n};\n+ } else if (action.type === \"SEND_MESSAGE_FAILED\") {\n+ const payloa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Error handling for failed message sends (delete them) |
129,187 | 07.06.2017 12:07:02 | 14,400 | 1df30b9a8dcf7787b17fdee84401fc78e8e63066 | Wrap MessageInfo passed to MessageList/Message in ChatMessageItem that can support additional fields | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -7,8 +7,8 @@ import type {\nNavigationAction,\n} from 'react-navigation';\nimport { threadInfoPropType } from 'lib/types/thread-types';\n-import type { MessageInfo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Wrap MessageInfo passed to MessageList/Message in ChatMessageItem that can support additional fields |
129,187 | 07.06.2017 14:02:53 | 14,400 | 5f5bf8add3badd3c748309af78f147b08de49122 | Set messageListData to actually compute secondary info correctly, and a bugfix | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -150,6 +150,10 @@ class InnerMessageList extends React.PureComponent {\nreturn <Message item={row.item} />;\n}\n+ static keyExtractor(item: ChatMessageItemWithHeig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Set messageListData to actually compute secondary info correctly, and a bugfix |
129,187 | 07.06.2017 15:30:25 | 14,400 | 616731b8159b0d1472234c306e8a759728ed5724 | Set up groupings by cluster and a time bar! | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/date-utils.js",
"new_path": "lib/utils/date-utils.js",
"diff": "@@ -93,6 +93,19 @@ function shortAbsoluteDate(timestamp: number) {\n}\n}\n+// Same as above, but longer\n+function longAbsoluteDate(timestamp: number) {\n+ const now = Date.now();\n+ con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Set up groupings by cluster and a time bar! |
129,187 | 07.06.2017 16:43:10 | 14,400 | 7790d5168879cb232f1f85de66037c571c18fed9 | Update Message.itemHeight to be accurate with recent changes in Message rendering behavior | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message.react.js",
"new_path": "native/chat/message.react.js",
"diff": "@@ -72,11 +72,17 @@ class Message extends React.PureComponent {\n}\nstatic itemHeight(item: ChatMessageItemWithHeight, userID: ?string) {\n- if (item.messageInfo.creatorID === ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update Message.itemHeight to be accurate with recent changes in Message rendering behavior |
129,187 | 07.06.2017 16:53:45 | 14,400 | b0918a383d70523a4786cde27ffd19542ed4f92b | Chat items that go off screen lose focus, and add some spacing at the top of the chat | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -9,6 +9,7 @@ import type {\nimport { threadInfoPropType } from 'lib/types/thread-types';\nimport type { ChatMessageItem } from '../selectors/chat-selectors';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Chat items that go off screen lose focus, and add some spacing at the top of the chat |
129,187 | 24.06.2017 18:43:51 | 14,400 | 1a7cf34f5b2db2786f9895a4d46c3c68893a36fe | Minor bugfix for when loading pretty old state | [
{
"change_type": "MODIFY",
"old_path": "native/selectors/calendar-selectors.js",
"new_path": "native/selectors/calendar-selectors.js",
"diff": "@@ -33,13 +33,9 @@ const calendarListData = createSelector(\nloggedIn: bool,\ndaysToEntries: {[dayString: string]: EntryInfo[]},\n) => {\n- if (!loggedIn) {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Minor bugfix for when loading pretty old state |
129,187 | 24.06.2017 22:06:01 | 14,400 | 4c384fd6121996929517ecf3c186f170937401ae | Uhh somehow I am able to get working now? | [
{
"change_type": "MODIFY",
"old_path": "lib/package-lock.json",
"new_path": "lib/package-lock.json",
"diff": "\"version\": \"0.0.1\",\n\"lockfileVersion\": 1,\n\"dependencies\": {\n- \"asap\": {\n- \"version\": \"2.0.5\",\n- \"resolved\": \"https://registry.npmjs.org/asap/-/asap-2.0.5.tgz\",\n- \"in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Uhh somehow I am able to get RN@0.45.1 working now? |
129,187 | 26.06.2017 11:43:14 | 14,400 | 597235bed9a2fb592dd93b379ff7d33a5ee1c6ef | AddThreadButton on native | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/add-thread-button.react.js",
"diff": "+// @flow\n+\n+import React from 'react';\n+import { Platform, StyleSheet, TouchableOpacity } from 'react-native';\n+import Icon from 'react-native-vector-icons/Ionicons';\n+\n+class AddThreadBut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | AddThreadButton on native |
129,187 | 26.06.2017 17:21:49 | 14,400 | c03abf10e19c6fe6b7f4225192f0bfb40202bdcf | Forgot this one from the last commit... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/message-preview.react.js",
"diff": "+// @flow\n+\n+import type { AppState } from '../redux-setup';\n+import type { MessageInfo } from 'lib/types/message-types';\n+import { messageInfoPropType } from 'lib/types/message-types';\n+\n+im... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Forgot this one from the last commit... |
129,187 | 26.06.2017 17:39:51 | 14,400 | c40153696204b1a5925ee14bee5c97a564d76a22 | Relinked things | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/assets/fonts/MaterialCommunityIcons.ttf",
"new_path": "native/android/app/src/main/assets/fonts/MaterialCommunityIcons.ttf",
"diff": "Binary files a/native/android/app/src/main/assets/fonts/MaterialCommunityIcons.ttf and b/native/an... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Relinked things |
129,187 | 28.06.2017 10:43:32 | 14,400 | 7ad00658eb5e0c9d5eb1e734ae78f72e261bccd5 | Return $users from every endpoint that returns messages | [
{
"change_type": "MODIFY",
"old_path": "server/auth_thread.php",
"new_path": "server/auth_thread.php",
"diff": "@@ -54,7 +54,7 @@ $conn->query(\n\"role = GREATEST(VALUES(role), role)\"\n);\n-list($message_infos, $truncation_status) =\n+list($message_infos, $truncation_status, $users) =\nget_message_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Return $users from every endpoint that returns messages |
129,187 | 07.07.2017 16:09:11 | 14,400 | 1c191060c0d120aaedf8ffb0c9d527b451e059ca | RN -> 0.46.1 | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "@@ -28,8 +28,6 @@ emoji=true\nmodule.system=haste\n-experimental.strict_type_args=true\n-\nmunge_underscores=true\nmodule.name_mapper='^[./a-zA-Z0-9$_-]+\\.\\(bmp\\|gif\\|jpg\\|jpeg\\|png\\|psd\\|... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN -> 0.46.1 |
129,187 | 07.07.2017 16:19:20 | 14,400 | f4bc5b7a0b5b606a8256fdc080cee4643cc385bb | onContentSizeChange is finally fixed on Android, and consequently the hack in onChange where it included contentSize is no longer present | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -327,16 +327,6 @@ class Entry extends React.Component {\nthis.guardedSetState({ height });\n}\n- // On Android, onContentSizeChange only gets called once when the TextIn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | onContentSizeChange is finally fixed on Android, and consequently the hack in onChange where it included contentSize is no longer present |
129,187 | 07.07.2017 16:20:45 | 14,400 | 531c39b78dfd18c2cb111cb7c5a1b209eb0c42cf | Forgot to remove the props... | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -251,7 +251,6 @@ class Entry extends React.Component {\nonBlur={this.onBlur}\nonFocus={this.onFocus}\nonContentSizeChange={this.onContentSizeChange}\n- onChange={this.on... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Forgot to remove the props... |
129,187 | 10.07.2017 13:54:28 | 14,400 | 51f972d906d735de28367e8c6f67ce662df32df5 | Source all EntryInfo creator names from userInfos | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "// @flow\nimport type { BaseAppState } from '../types/redux-types';\n-import type { EntryInfo } from '../types/entry-types';\n+import type { RawEntryInfo } from '../types/entry... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Source all EntryInfo creator names from userInfos |
129,187 | 10.07.2017 14:08:37 | 14,400 | ae82b2836647826222ab4bc61789b1f822affb7e | Update actions and reducers to keep userInfos in sync in parallel with entryInfos | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -5,10 +5,15 @@ import type { RawEntryInfo } from '../types/entry-types';\nimport type { FetchJSON } from '../utils/fetch-json';\nimport type { HistoryRevisionInfo } from '..... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update actions and reducers to keep userInfos in sync in parallel with entryInfos |
129,187 | 11.07.2017 10:35:36 | 14,400 | 119178fb34e2220148f3b7463d245a171aa10066 | Fix three bugs on native | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -74,11 +74,6 @@ registerConfig({\ncalendarRangeInactivityLimit: sessionInactivityLimit,\n});\n-if (Platform.OS === \"android\") {\n- UIManager.setLayoutAnimationEnabledExperimental &&\n- UIMa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix three bugs on native |
129,187 | 11.07.2017 11:34:19 | 14,400 | d6183ab88271dd2ce7a65e7d1c264d9678bc2c66 | Fix some bugs regarding how the Calendar is scrolled to avoid the keyboard on Android | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -101,6 +101,7 @@ type State = {\nreadyToShowList: bool,\npickerOpenForDateString: ?string,\nextraData: ExtraData,\n+ scrollToOffsetAfterSuppressingKeyboardDismissa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix some bugs regarding how the Calendar is scrolled to avoid the keyboard on Android |
129,187 | 12.07.2017 22:18:59 | 14,400 | 31adadd66e2f722f1e251a2378f027a45b576aa1 | Handle new message types in MessagePreview | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -4,6 +4,8 @@ import type { MessageInfo, RawMessageInfo } from '../types/message-types';\nimport invariant from 'invariant';\n+import { messageType } from '../types/message-typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Handle new message types in MessagePreview |
129,187 | 13.07.2017 12:01:28 | 14,400 | 9e5e27720ceb36217b25506c182cbca7b4d09d84 | Extend TextHeightMeasurer to be able to handle different styles for individual entries | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -9,6 +9,7 @@ import type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport type { CalendarResult } from 'lib/actions/entry-actions';\nimport type { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extend TextHeightMeasurer to be able to handle different styles for individual entries |
129,187 | 13.07.2017 15:26:52 | 14,400 | 2cf50145121344ff35be3920c027f13ebcbd131d | Add support for robotext to MessageList | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -35,7 +35,7 @@ import _differenceWith from 'lodash/fp/differenceWith';\nimport _find from 'lodash/fp/find';\nimport _isEqual from 'lodash/fp/isEqual';\n-import { m... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add support for robotext to MessageList |
129,187 | 13.07.2017 19:20:18 | 14,400 | 6d1e727f23782b27a45d76dd49abc9d355bdab93 | Only calculate robotext once (in selector) | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -57,8 +57,7 @@ export type TextMessageInfo = {|\ntext: string,\n|};\n-export type MessageInfo = TextMessageInfo |\n-{|\n+export type RobotextMessageInfo = {|\ntype: 1,\nid: stri... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only calculate robotext once (in selector) |
129,187 | 14.07.2017 14:55:35 | 14,400 | d9cfedce879a85daef40685865d9fc58809ab566 | Pass parentThreadID into AddThreadButton | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread-button.react.js",
"new_path": "native/chat/add-thread-button.react.js",
"diff": "import React from 'react';\nimport { Platform, StyleSheet, TouchableOpacity } from 'react-native';\nimport Icon from 'react-native-vector-icons/Ionicons';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Pass parentThreadID into AddThreadButton |
129,187 | 14.07.2017 15:12:17 | 14,400 | df254e4f6b3a209ce7bbe6eee44af7bd448331cd | Create search_users.php endpoint for user typeahead | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/search_users.php",
"diff": "+<?php\n+\n+require_once('async_lib.php');\n+require_once('config.php');\n+\n+async_start();\n+\n+$prefix_fragment = \"\";\n+if (isset($_POST['prefix'])) {\n+ $prefix_fragment = \"WHERE username LIKE '\"\n+ . $... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Create search_users.php endpoint for user typeahead |
129,187 | 14.07.2017 16:40:58 | 14,400 | 95d746855995e957a88b680e91e90ef9ab6aebbf | Basic AddThread screen | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread-button.react.js",
"new_path": "native/chat/add-thread-button.react.js",
"diff": "// @flow\n+import type { NavigationParams } from 'react-navigation';\n+\nimport React from 'react';\nimport { Platform, StyleSheet, TouchableOpacity } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Basic AddThread screen |
129,187 | 18.07.2017 14:32:22 | 14,400 | 17d60bad7d95f739fdd90d119fb38c11694033e9 | AddThread basic UI | [
{
"change_type": "MODIFY",
"old_path": "native/account/forgot-password-panel.react.js",
"new_path": "native/account/forgot-password-panel.react.js",
"diff": "@@ -81,7 +81,7 @@ class ForgotPasswordPanel extends React.PureComponent {\nautoCorrect={false}\nautoCapitalize=\"none\"\nkeyboardType=\"ascii-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | AddThread basic UI |
129,187 | 18.07.2017 14:33:09 | 14,400 | b60c3cdfc86105e61183bbd96a8dcce68e68f89b | otherUserInfos (for use by AddThread) | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/selectors/user-selectors.js",
"diff": "+// @flow\n+\n+import type { BaseAppState } from '../types/redux-types';\n+import type { UserInfo } from '../types/user-types';\n+\n+import { createSelector } from 'reselect';\n+\n+// other than the log... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | otherUserInfos (for use by AddThread) |
129,187 | 18.07.2017 18:10:46 | 14,400 | e8948fbe1ad3c903f818de5e49201239bfa7fbec | Privacy -> Visibility, only show if has a parent thread (otherwise Secret) | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -29,7 +29,7 @@ import {\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\ntype NavProp = NavigationScreenProp<NavigationRoute, Navigatio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Privacy -> Visibility, only show if has a parent thread (otherwise Secret) |
129,187 | 18.07.2017 19:04:27 | 14,400 | dc489fb53389b796c70b3e6f3fd1e7011ed7024a | Create userSearchIndex selector | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "@@ -8,6 +8,7 @@ import type { CurrentUserInfo, UserInfo } from '../types/user-types';\nimport invariant from 'invariant';\nimport _keyBy from 'lodash/fp/keyBy';\n+import _isEqu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Create userSearchIndex selector |
129,187 | 18.07.2017 19:50:42 | 14,400 | 0d23483f93a4125009642425445d4594de6f7a85 | Lift username input state from TagInput to AddThread and make sure when last Tag is deleted, new last Tag calls onLayoutLastTag | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -43,10 +43,12 @@ class InnerAddThread extends React.PureComponent {\n};\nstate: {\nnameInputText: string,\n+ usernameInputText: string,\nusernameInputArray: $ReadOnlyA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Lift username input state from TagInput to AddThread and make sure when last Tag is deleted, new last Tag calls onLayoutLastTag |
129,187 | 18.07.2017 19:57:32 | 14,400 | 6dd3a2625b12d871623192f8a5115effb7e2e719 | Get rid of logic to push new tags into the TagInput from the TagInput | [
{
"change_type": "MODIFY",
"old_path": "native/components/tag-input.react.js",
"new_path": "native/components/tag-input.react.js",
"diff": "@@ -36,10 +36,6 @@ type Props = {\nonChange: (items: $ReadOnlyArray<TagData>) => void,\n// An array of tags\nvalue: $ReadOnlyArray<TagData>,\n- // An array os c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of logic to push new tags into the TagInput from the TagInput |
129,187 | 18.07.2017 20:39:00 | 14,400 | e4a983c3e7fe50fd01b324af6ef64c3439bfb9c2 | Maintain userSearchResults in AddThread state | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/search-index.js",
"new_path": "lib/shared/search-index.js",
"diff": "@@ -69,9 +69,7 @@ class SearchIndex {\nif (!fullMatches) {\nreturn [];\n}\n- possibleMatches = possibleMatches.filter(\n- (navID) => fullMatches.has(navID)\n- );\n+ possibleMatches... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Maintain userSearchResults in AddThread state |
129,187 | 19.07.2017 15:13:48 | 14,400 | eefbf66422fb5c69a1bcc524162eb9b14be97fa5 | Really primitive user autocomplete for creating new threads | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -32,6 +32,7 @@ import { otherUserInfos, userSearchIndex } from 'lib/selectors/user-selectors';\nimport SearchIndex from 'lib/shared/search-index';\nimport TagInput fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Really primitive user autocomplete for creating new threads |
129,187 | 21.07.2017 15:43:04 | 14,400 | 1c893a869920a62cc4520e6b70dae79e738c8072 | Upgrade react-native to 0.46.4 | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "\"integrity\": \"sha1-HtkZnanL/i7y96MbL96LDRI2iXI=\",\n\"requires\": {\n\"iconv-lite\": \"0.4.18\",\n- \"jschardet\": \"1.4.2\",\n+ \"jschardet\": \"1.5.0\",\n\"tmp\": \"0.0.31\"\n}\n}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Upgrade react-native to 0.46.4 |
129,187 | 01.08.2017 21:18:12 | 14,400 | 3ec7558589ba0c71c9d50d02e711f0845f6ecfc6 | Only add cookie to POST on native (getConfig().setCookieOnRequest) | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/config.js",
"new_path": "lib/utils/config.js",
"diff": "@@ -11,6 +11,7 @@ export type Config = {\ndispatchRecoveryAttempt: DispatchRecoveryAttempt,\n) => Promise<void>),\ngetNewCookie: ?((response: Object) => Promise<?string>),\n+ setCookieOnRequest:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only add cookie to POST on native (getConfig().setCookieOnRequest) |
129,187 | 01.08.2017 21:18:31 | 14,400 | 20ab9e5fcffbd3cc318c08c635cdbb0a807dc2d5 | Prefer $_POST['cookie'] to $_COOKIE | [
{
"change_type": "MODIFY",
"old_path": "server/auth.php",
"new_path": "server/auth.php",
"diff": "@@ -62,11 +62,8 @@ function cookie_has_changed() {\n}\nfunction get_input_user_cookie() {\n- if (isset($_COOKIE['user'])) {\n- return $_COOKIE['user'];\n- }\nif (!isset($_POST['cookie'])) {\n- return nu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Prefer $_POST['cookie'] to $_COOKIE |
129,187 | 01.08.2017 21:52:31 | 14,400 | 0f57c2f3fe5414609feb9f9c233851a2febe8a40 | Parse .native.js files in native/.flowconfig for react-navigation | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "@@ -33,6 +33,11 @@ munge_underscores=true\nmodule.name_mapper='^[./a-zA-Z0-9$_-]+\\.\\(bmp\\|gif\\|jpg\\|jpeg\\|png\\|psd\\|svg\\|webp\\|m4v\\|mov\\|mp4\\|mpeg\\|mpg\\|webm\\|aac\\|aiff\\|caf\\|m4... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Parse .native.js files in native/.flowconfig for react-navigation |
129,187 | 02.08.2017 15:19:46 | 14,400 | 31b14728ad4e34c4b52da4a6bfca033f508ced82 | `babel-plugin-transform-remove-strict-mode` so we can run on Android | [
{
"change_type": "MODIFY",
"old_path": "native/.babelrc",
"new_path": "native/.babelrc",
"diff": "{\npresets: ['react-native'],\n+ plugins: ['transform-remove-strict-mode'],\nenv: {\nproduction: {\nplugins: ['transform-remove-console'],\n"
},
{
"change_type": "MODIFY",
"old_path": "nativ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | `babel-plugin-transform-remove-strict-mode` so we can run on Android |
129,187 | 03.08.2017 15:22:43 | 14,400 | 157f680f13ca2b18170887b4c7bc7da44bfc432c | Stabilize TagInput | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -73,6 +73,7 @@ class InnerAddThread extends React.PureComponent {\nusernameInputArray: $ReadOnlyArray<string>,\nuserSearchResults: $ReadOnlyArray<UserInfo>,\nselectedP... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Stabilize TagInput |
129,187 | 03.08.2017 16:07:46 | 14,400 | ee597035f988a2bc5969f4b388faf1200da767e1 | Avoid calling setState in LoggedOutModal when it's unmounted | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -115,6 +115,7 @@ class InnerLoggedOutModal extends React.PureComponent {\nkeyboardShowListener: ?Object;\nkeyboardHideListener: ?Object;\n+ mounted =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Avoid calling setState in LoggedOutModal when it's unmounted |
129,187 | 03.08.2017 16:47:36 | 14,400 | 1147efeac881e8d90a4ffca8131eb70c6f8f9007 | CreateThreadButton and several refinements | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/create-thread-button.react.js",
"diff": "+// @flow\n+\n+import React from 'react';\n+import { Text, StyleSheet, Platform } from 'react-native';\n+import PropTypes from 'prop-types';\n+\n+import Button from '../components/button.react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | CreateThreadButton and several refinements |
129,187 | 08.08.2017 10:54:52 | 14,400 | f61521e088e9e4eac2864ae84baea5a0926caa58 | Update entry_lib and message_lib to use new thread permissions SQL logic | [
{
"change_type": "MODIFY",
"old_path": "server/entry_lib.php",
"new_path": "server/entry_lib.php",
"diff": "@@ -38,10 +38,11 @@ function get_entry_infos($input) {\n$thread = intval($input['nav']);\n}\n- $additional_condition = $home ? \"r.subscribed = 1\" : \"d.thread = $thread\";\n+ $additional_con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update entry_lib and message_lib to use new thread permissions SQL logic |
129,187 | 08.08.2017 14:37:27 | 14,400 | 4e27bb9321894d56cf642d89c0297acfc155053c | create_user_roles / delete_user_roles functions | [
{
"change_type": "MODIFY",
"old_path": "server/auth.php",
"new_path": "server/auth.php",
"diff": "@@ -214,32 +214,21 @@ function create_user_cookie($user_id) {\n\"SELECT thread, creation_time, last_view, role, subscribed FROM roles \".\n\"WHERE user = $anonymous_cookie_id\"\n);\n- $new_rows = array(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | create_user_roles / delete_user_roles functions |
129,187 | 08.08.2017 14:47:41 | 14,400 | e80756a9d399bcd717711be2f06b74d9e0a06584 | Fix up subscribe.php | [
{
"change_type": "MODIFY",
"old_path": "server/subscribe.php",
"new_path": "server/subscribe.php",
"diff": "@@ -13,7 +13,7 @@ if (!isset($_POST['thread']) || !isset($_POST['subscribe'])) {\n));\n}\n$thread = (int)$_POST['thread'];\n-$subscribe = $_POST['subscribe'] ? 1 : 0;\n+$new_subscribed = !!$_P... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix up subscribe.php |
129,187 | 09.08.2017 15:40:07 | 14,400 | 3e2f26a7f405b35e1b5388872dae63b38ac2c428 | Actually verify the thread ID we get passed in is a thread ID before setting rows with it... | [
{
"change_type": "MODIFY",
"old_path": "server/entry_lib.php",
"new_path": "server/entry_lib.php",
"diff": "@@ -4,6 +4,26 @@ require_once('config.php');\nrequire_once('auth.php');\nrequire_once('thread_lib.php');\n+// Doesn't verify $input['nav'] is actually a thread, if not \"home\"\n+// Use verify... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Actually verify the thread ID we get passed in is a thread ID before setting rows with it... |
129,187 | 09.08.2017 15:48:37 | 14,400 | bc44a1cfc339241460d3a260f7db0ecd70392e61 | Minor server fixes | [
{
"change_type": "MODIFY",
"old_path": "server/delete_thread.php",
"new_path": "server/delete_thread.php",
"diff": "@@ -21,16 +21,20 @@ $user = get_viewer_id();\n$thread = (int)$_POST['thread'];\n$password = $_POST['password'];\n-$result = $conn->query(\n- \"SELECT hash \".\n- \"FROM roles r LEFT JO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Minor server fixes |
129,187 | 09.08.2017 16:13:11 | 14,400 | 9770fca332caa57f0fd0a4a9bf328ec783cc02b1 | Allow member IDs to be specified in edit_thread.php/new_thread.php | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -4,6 +4,7 @@ require_once('async_lib.php');\nrequire_once('config.php');\nrequire_once('auth.php');\nrequire_once('thread_lib.php');\n+require_once('user_lib.php');\nasync_start();\n@@ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Allow member IDs to be specified in edit_thread.php/new_thread.php |
129,187 | 13.08.2017 17:08:29 | 14,400 | 501f7f21e6cd338da4a29e0c7ee94984268e3068 | Make sure that if subscribe leads to joining a NESTED_OPEN thread whose ancestors are not joined, those ancestors are joined as well | [
{
"change_type": "MODIFY",
"old_path": "server/join_thread.php",
"new_path": "server/join_thread.php",
"diff": "@@ -17,7 +17,7 @@ if (!isset($_POST['thread'])) {\n$thread = intval($_POST['thread']);\n$thread_query = <<<SQL\n-SELECT visibility_rules, hash, parent_thread_id FROM threads WHERE id={$thr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure that if subscribe leads to joining a NESTED_OPEN thread whose ancestors are not joined, those ancestors are joined as well |
129,187 | 13.08.2017 17:22:27 | 14,400 | a504f9d850f1024e8df281123d59dccd96c9c46c | Separate authorized and viewerIsMember properties of ThreadInfo | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -78,6 +78,7 @@ async function newThread(\nid: newThreadID,\nname,\ndescription,\n+ authorized: true,\nviewerIsMember: true,\nsubscribed: true,\ncanChangeSettings: true,\n"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Separate authorized and viewerIsMember properties of ThreadInfo |
129,187 | 13.08.2017 17:58:07 | 14,400 | 803b1dfcfd2e087a96ef849b55186fe10a91f8c1 | Fixes on server side | [
{
"change_type": "MODIFY",
"old_path": "server/index.php",
"new_path": "server/index.php",
"diff": "@@ -132,9 +132,14 @@ list($message_infos, $truncation_status, $message_users) =\n$users = array_merge(\n$message_users,\n$entry_users,\n- $thread_users,\n+ $thread_users\n);\n+if (!$thread_infos) {\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fixes on server side |
129,187 | 14.08.2017 12:17:48 | 25,200 | e352e95e7519b3614fee12d397ff7cfdcb5eb782 | Move createEntryInfo and colorIsDark out of thread-selectors.js | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "@@ -6,7 +6,6 @@ import type { RawEntryInfo, EntryInfo } from '../types/entry-types';\nimport type { UserInfo } from '../types/user-types';\nimport { createSelector } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move createEntryInfo and colorIsDark out of thread-selectors.js |
129,187 | 15.08.2017 10:39:06 | 25,200 | 3ff1ee5e8fc5a750af5f266271d35e87c9582b00 | Client actually sends verify_user_ids an array of strings, not an imploded string | [
{
"change_type": "MODIFY",
"old_path": "server/user_lib.php",
"new_path": "server/user_lib.php",
"diff": "require_once('auth.php');\n-// $user_ids is a string of implode'd user IDs\n+// $user_ids is an array of user IDs as strings\n// returns an array of validated user IDs\nfunction verify_user_ids(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Client actually sends verify_user_ids an array of strings, not an imploded string |
129,187 | 15.08.2017 10:40:07 | 25,200 | 67d9c6a15c80ca1e4c00b08bcd1cdbbfb39e9427 | Fix bug in user-loading code in get_thread_infos, and make sure to skip anonymous users | [
{
"change_type": "MODIFY",
"old_path": "server/thread_lib.php",
"new_path": "server/thread_lib.php",
"diff": "@@ -76,18 +76,19 @@ SQL;\nSELECT r.thread, r.user, u.username\nFROM roles r\nLEFT JOIN users u ON r.user = u.id\n-WHERE r.thread IN ({$thread_id_sql_string})\n+WHERE r.thread IN ({$thread_id... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix bug in user-loading code in get_thread_infos, and make sure to skip anonymous users |
129,187 | 15.08.2017 10:57:27 | 25,200 | 6dc715dc2964318f6879aafa4079e43cbe2108b8 | Make sure get_messages_since returns TRUNCATION_EXHAUSTIVE for a thread's $truncation_status if it sees a CREATE_THREAD message | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -185,6 +185,10 @@ SQL;\n$num_for_thread++;\n}\nif ($num_for_thread <= $max_number_per_thread) {\n+ if ((int)$row['type'] === 1) {\n+ // If a CREATE_THREAD message is here, then we have ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure get_messages_since returns TRUNCATION_EXHAUSTIVE for a thread's $truncation_status if it sees a CREATE_THREAD message |
129,187 | 15.08.2017 14:08:47 | 25,200 | a0d7d5447b7e1c0c02afba3cce85c6763b57fe95 | Make sure that when people are added to a NESTED_OPEN thread whose ancestors they are not members of, they are added to their ancestors as well | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -266,6 +266,15 @@ foreach ($add_member_ids as $add_member_id) {\n\"role\" => ROLE_SUCCESSFUL_AUTH,\n);\n}\n+if ($add_member_ids && $next_vis_rules === VISIBILITY_NESTED_OPEN) {\n+ $role... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure that when people are added to a NESTED_OPEN thread whose ancestors they are not members of, they are added to their ancestors as well |
129,187 | 11.09.2017 00:30:08 | 14,400 | 63b1269a841aaf0186530641554dcfd51b8e484d | Update to work with (which I will now deprecate) | [
{
"change_type": "MODIFY",
"old_path": "native/account/native-credentials.js",
"new_path": "native/account/native-credentials.js",
"diff": "@@ -234,23 +234,18 @@ async function resolveInvalidatedCookie(\n}\n}\n-function getNativeCookie() {\n- return new Promise((resolve, reject) => {\n- CookieManage... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to work with react-native-cookies@3.2.0 (which I will now deprecate) |
129,187 | 11.09.2017 00:47:10 | 14,400 | 3309ecba8fec4cac1900e08cac7d80b6a1fe5557 | Get rid of react-native-cookies in favor of storing cookie in Redux | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -135,7 +135,7 @@ function reduceEntryInfos(\ndaysToEntries: newDaysToEntries,\nlastUserInteractionCalendar: Date.now(),\n};\n- } else if (action.type === \"SET_COOKIE\" &&... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of react-native-cookies in favor of storing cookie in Redux |
129,187 | 11.09.2017 01:03:46 | 14,400 | aa5aab9e111dcd1c01e4d3b781e9695df3fc0bbc | I'm going to upgrade to the latest react-navigation version, and just suppress the Flow errors | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": ".*/Libraries/react-native/React.js\n.*/Libraries/react-native/ReactNative.js\n+.*/node_modules/react-navigation/.*\n+\n[include]\n../lib\n"
},
{
"change_type": "MODIFY",
"old_path": "n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | I'm going to upgrade to the latest react-navigation version, and just suppress the Flow errors |
129,187 | 13.09.2017 11:58:24 | 14,400 | b06b1d2fe3523ff1fbe7252ce3181ed07f49d2a5 | When creating a subthread only shows the users in the superthread | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/user-selectors.js",
"new_path": "lib/selectors/user-selectors.js",
"diff": "@@ -4,39 +4,60 @@ import type { BaseAppState } from '../types/redux-types';\nimport type { UserInfo } from '../types/user-types';\nimport { createSelector } from 'reselec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | When creating a subthread only shows the users in the superthread |
129,187 | 15.09.2017 16:43:32 | 14,400 | 4d294d45c789e6c80b856e239b26d4df27f599c6 | Working color selection logic! | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -17,10 +17,19 @@ import type { NewThreadResult } from 'lib/actions/thread-actions';\nimport React from 'react';\nimport PropTypes from 'prop-types';\n-import { View, T... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Working color selection logic! |
129,187 | 18.09.2017 20:54:33 | 14,400 | 7f79c7601ce306872d10504f49f4fab70d3eeedf | In TagInput, make sure to update this.state.wrapperHeight when this.props.maxHeight changes | [
{
"change_type": "MODIFY",
"old_path": "native/components/tag-input.react.js",
"new_path": "native/components/tag-input.react.js",
"diff": "@@ -128,6 +128,13 @@ class TagInput<TagData> extends React.PureComponent<\nif (inputWidth !== this.state.inputWidth) {\nthis.setState({ inputWidth });\n}\n+ con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | In TagInput, make sure to update this.state.wrapperHeight when this.props.maxHeight changes |
129,187 | 19.09.2017 22:51:58 | 14,400 | 4ceb2d6928537f3d1cda6f414d0c02810a65823c | Fix react-navigation Flow types | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": ".*/Libraries/react-native/React.js\n.*/Libraries/react-native/ReactNative.js\n-.*/node_modules/react-navigation/.*\n-\n[include]\n../lib\n"
},
{
"change_type": "MODIFY",
"old_path": "n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix react-navigation Flow types |
129,187 | 20.09.2017 15:10:31 | 14,400 | c7136910d8e02187e0487fb4d3da0719607c049e | Fix types with my newly typed React Navigation PR! | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -405,4 +405,4 @@ export type PromisedAction = (dispatch: Dispatch) => Promise<void>;\nexport type Dispatch =\n((promisedAction: PromisedAction) => Promise<void>) &\n((thunkedAction:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix types with my newly typed React Navigation PR! |
129,187 | 20.09.2017 19:08:28 | 14,400 | 20006e34db903b3fa6dba4ae55981c50799f4b4e | Forgot that zero is falsey... ugh... | [
{
"change_type": "MODIFY",
"old_path": "native/navigation-setup.js",
"new_path": "native/navigation-setup.js",
"diff": "@@ -127,7 +127,9 @@ const isForegroundSelector = createIsForegroundSelector(AppRouteName);\nconst ReduxWrappedAppNavigator = connect((state: AppState) => {\nconst appNavState = sta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Forgot that zero is falsey... ugh... |
129,187 | 20.09.2017 19:32:24 | 14,400 | cae003d1270b45eafe6d2f12643768d861da6726 | Some bugfixes and refinements for the thread creation message payload | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -29,6 +29,19 @@ function messageID(messageInfo: MessageInfo | RawMessageInfo): string {\nreturn messageInfo.localID;\n}\n+function usernameString(usernames: string[]): string ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Some bugfixes and refinements for the thread creation message payload |
129,187 | 20.09.2017 20:20:06 | 14,400 | 2d32aaa4e0336e896c67f62f53db51fb2b4d7cd3 | Wrap AddThread in KeyboardAvoidingView on iOS | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -25,6 +25,8 @@ import {\nAlert,\nTouchableWithoutFeedback,\nTouchableHighlight,\n+ KeyboardAvoidingView,\n+ Platform,\n} from 'react-native';\nimport { connect } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Wrap AddThread in KeyboardAvoidingView on iOS |
129,187 | 20.09.2017 20:47:33 | 14,400 | ec8363961c3266264741eb93f971552d820d2303 | Make sure message preview and thread name don't overflow over the color splotch and the last message time in ChatThreadListItem | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -78,6 +78,7 @@ const styles = StyleSheet.create({\njustifyContent: 'space-between',\n},\nthreadName: {\n+ flex: 1,\npaddingLeft: 10,\nfontSize: 2... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure message preview and thread name don't overflow over the color splotch and the last message time in ChatThreadListItem |
129,187 | 21.09.2017 12:43:49 | 14,400 | d8faaad5fa9a396721093805f128b2194246e9d0 | Only show subthread messages if the viewer can see the subthread | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -105,7 +105,10 @@ SQL;\n'id' => $row['creatorID'],\n'username' => $row['creator'],\n);\n- $messages[] = message_from_row($row);\n+ $message = message_from_row($row);\n+ if ($message) {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only show subthread messages if the viewer can see the subthread |
129,187 | 21.09.2017 12:47:47 | 14,400 | d7868bc31d1b5acccf2caf5bc0f948a6f9117954 | Include userInfos for initialThreadState.memberIDs in MESSAGE_TYPE_CREATE_THREAD | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -241,10 +241,13 @@ function get_all_users($messages, $users) {\n$all_added_user_ids = array();\nforeach ($messages as $message) {\n- if ($message['type'] !== MESSAGE_TYPE_ADD_USERS) {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include userInfos for initialThreadState.memberIDs in MESSAGE_TYPE_CREATE_THREAD |
129,187 | 26.09.2017 20:15:27 | 14,400 | 9b975afa853b309a9ca43de6b46a6ae65be915c1 | Use react-navigation master now that my Flow PR has been accepted | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "}\n},\n\"react-navigation\": {\n- \"version\": \"git+https://git@github.com/ashoat/react-navigation.git#d1c9528d2ae669979f156d28aaeae3f1d5476796\",\n+ \"version\": \"git+https://git@gi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use react-navigation master now that my Flow PR has been accepted |
129,187 | 26.09.2017 20:24:39 | 14,400 | 8ab92447913cb3db069b95e13324e175d05d707b | Use associative array version of json_decode | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -223,9 +223,9 @@ function message_from_row($row) {\nif ($type === MESSAGE_TYPE_TEXT) {\n$message['text'] = $row['content'];\n} else if ($type === MESSAGE_TYPE_CREATE_THREAD) {\n- $messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use associative array version of json_decode |
129,187 | 27.09.2017 11:48:55 | 14,400 | 9d0e3601907c72987b45bcdf9327119a50f21076 | Refactor props on Button | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -207,8 +207,11 @@ class Entry extends React.Component {\n<View style={styles.actionLinks}>\n<View style={styles.leftLinks}>\n<Button\n- onSubmit={this.onPressDelete}\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Refactor props on Button |
129,187 | 27.09.2017 14:00:39 | 14,400 | 190431cc4bcf5d7deb75b197171164bb22ee1ed9 | Custom MessageListHeaderTitle that is clickable | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread-button.react.js",
"new_path": "native/chat/add-thread-button.react.js",
"diff": "@@ -46,11 +46,7 @@ class AddThreadButton extends React.PureComponent {\n);\n}\nreturn (\n- <Button\n- onPress={this.onPress}\n- androidBorderlessRipple={tru... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Custom MessageListHeaderTitle that is clickable |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.