author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 02.12.2017 18:46:38 | -28,800 | 660bdeeb8e087a424dcd5ec73305711f902a04f6 | Update tabBarOnPress callbacks to conform to new react-navigation spec | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -157,10 +157,10 @@ class InnerCalendar extends React.PureComponent<Props, State> {\nstyle={[styles.icon, { color: tintColor }]}\n/>\n),\n- tabBarOnPress: (\n+ tabB... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update tabBarOnPress callbacks to conform to new react-navigation spec |
129,187 | 05.12.2017 17:15:11 | -28,800 | 91764c632b8c24582618ace4d5f1f86d20739e51 | Make sure we always use updateFocusedThreads that has the new cookie bound | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -133,9 +133,10 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nthis.handleInitialURL().then();\nLinking.addEventListener('url', this.handleURLChange);\nthis.activePingSu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure we always use updateFocusedThreads that has the new cookie bound |
129,187 | 05.12.2017 21:11:42 | -28,800 | 5fd617457b862fa5ecc1c21d377f88caa51f69a1 | Have ping.php keep focused time updated | [
{
"change_type": "MODIFY",
"old_path": "server/ping.php",
"new_path": "server/ping.php",
"diff": "@@ -60,6 +60,8 @@ $message_users = $result['user_infos'];\nlist($thread_infos, $thread_users) = get_thread_infos();\n+update_focused_thread_time($current_as_of);\n+\n$return = array(\n'success' => true,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Have ping.php keep focused time updated |
129,187 | 05.12.2017 21:18:28 | -28,800 | beb16a410f02037e2e261d1c10a03507f7860278 | Memoize native nav selectors | [
{
"change_type": "MODIFY",
"old_path": "native/selectors/nav-selectors.js",
"new_path": "native/selectors/nav-selectors.js",
"diff": "@@ -5,6 +5,7 @@ import type { NavigationState } from 'react-navigation';\nimport { createSelector } from 'reselect';\nimport invariant from 'invariant';\n+import _mem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Memoize native nav selectors |
129,187 | 06.12.2017 13:09:51 | 28,800 | 2f5bdf73d4d603605fb9f6340a488731a98efb38 | unread field on memberships table | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -271,6 +271,9 @@ if ($add_member_ids) {\n));\n}\nforeach ($role_results['to_save'] as $row_to_save) {\n+ if ($row_to_save['role'] !== 0) {\n+ $row_to_save['unread'] = true;\n+ }\nif ($r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | unread field on memberships table |
129,187 | 06.12.2017 14:06:28 | 28,800 | 4b892c955e48c27edade5dfa5907b1fe2bf53efd | update_focused_threads.php updates unread column now | [
{
"change_type": "MODIFY",
"old_path": "server/thread_lib.php",
"new_path": "server/thread_lib.php",
"diff": "@@ -12,6 +12,8 @@ define(\"VISIBILITY_THREAD_SECRET\", 4);\ndefine(\"EDIT_ANYBODY\", 0);\ndefine(\"EDIT_LOGGED_IN\", 1);\n+define(\"PING_INTERVAL\", 3000); // in milliseconds\n+\nfunction vi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | update_focused_threads.php updates unread column now |
129,187 | 19.12.2017 10:18:24 | 18,000 | 74266408183ef7b99308aa2d02f0aa0bab24c3d1 | Fix small SQL bug
`update_focused_threads` with no focused threads would cause a bug since `verify_thread_ids` did not support empty array | [
{
"change_type": "MODIFY",
"old_path": "server/index.php",
"new_path": "server/index.php",
"diff": "@@ -35,7 +35,7 @@ $thread_rewrite_matched = preg_match(\n$home_rewrite_matched = preg_match('#/home(/|$)#i', $_SERVER['REQUEST_URI']);\nif (!$home_rewrite_matched && $thread_rewrite_matched) {\n$home ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix small SQL bug
`update_focused_threads` with no focused threads would cause a bug since `verify_thread_ids` did not support empty array |
129,187 | 19.12.2017 11:40:56 | 18,000 | 6a7181002cfcaf2613f7108bc1fb8e3701982d6b | Get rid of visible column in memberships table
Now that we have MySQL 5.7 we can do JSON extraction within the query! | [
{
"change_type": "MODIFY",
"old_path": "server/entry_lib.php",
"new_path": "server/entry_lib.php",
"diff": "require_once('config.php');\nrequire_once('auth.php');\nrequire_once('thread_lib.php');\n+require_once('permissions.php');\n// Doesn't verify $input['nav'] is actually a thread, if not \"home\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of visible column in memberships table
Now that we have MySQL 5.7 we can do JSON extraction within the query! |
129,187 | 19.12.2017 22:33:53 | 18,000 | 4aff4e00e23555344bc859d6d2ef6653f1281f7f | Mark threads as unread when new messages are created
Exceptions are when a user is the creator of the message and when a user is currently viewing the thread | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -362,6 +362,7 @@ function create_message_infos($new_message_infos) {\n}\n$content_by_index = array();\n+ $thread_creator_pairs = array();\nforeach ($new_message_infos as $index => $new_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Mark threads as unread when new messages are created
Exceptions are when a user is the creator of the message and when a user is currently viewing the thread |
129,187 | 20.12.2017 14:37:32 | 18,000 | 57a73460ca9d1fa254d94e02c5ba7fea37cbf04c | Nav changes as a result of thread creation done in NEW_THREAD_SUCCESS action
Doing this in separate actions caused nav changes to propagate before Redux actually had the new thread which caused errors. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -57,7 +57,6 @@ import LinkButton from '../components/link-button.react';\nimport { MessageListRouteName } from './message-list.react';\nimport { registerChatScreen } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Nav changes as a result of thread creation done in NEW_THREAD_SUCCESS action
Doing this in separate actions caused nav changes to propagate before Redux actually had the new thread which caused errors. |
129,187 | 20.12.2017 17:17:03 | 18,000 | a777e6c2b4c956192f3b76b7700bfe853b7491d8 | Make sure new thread messages get assigned to the right threads when a new thread is created
Right now all of them are attributed to the new thread, but if a child thread is created then a new message for its parent thread is created. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -4,8 +4,6 @@ import type { ThreadInfo, ThreadCurrentUserInfo } from '../types/thread-types';\nimport type { VisibilityRules } from '../types/thread-types';\nimport type { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure new thread messages get assigned to the right threads when a new thread is created
Right now all of them are attributed to the new thread, but if a child thread is created then a new message for its parent thread is created. |
129,187 | 20.12.2017 19:15:01 | 18,000 | bed0da3e2f3e15059635974c2e40e667103dd857 | Stop doing individual permission checks for each subthread creation message we get
Instead, we're embedding the information we need in the results of the message query. | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -119,17 +119,24 @@ function get_message_infos($thread_selection_criteria, $number_per_thread) {\n$visibility_nested_open = VISIBILITY_NESTED_OPEN;\n$vis_permission_extract_string = \"$.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Stop doing individual permission checks for each subthread creation message we get
Instead, we're embedding the information we need in the results of the message query. |
129,187 | 20.12.2017 21:54:16 | 18,000 | c464d453fef4aee2c00bc4a3942612c765e59021 | Make sure possibly_reset_thread_to_unread compares latest visible message
We shouldn't consider messages the client can't see when verifying that their most recent message is correct. | [
{
"change_type": "MODIFY",
"old_path": "server/thread_lib.php",
"new_path": "server/thread_lib.php",
"diff": "require_once('config.php');\nrequire_once('auth.php');\nrequire_once('permissions.php');\n+require_once('message_lib.php');\ndefine(\"VISIBILITY_OPEN\", 0);\ndefine(\"VISIBILITY_CLOSED\", 1)... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure possibly_reset_thread_to_unread compares latest visible message
We shouldn't consider messages the client can't see when verifying that their most recent message is correct. |
129,187 | 20.12.2017 22:25:59 | 18,000 | e54232bbb6beca7c848c95234b62d09943a21929 | Forgot to import a type | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "// @flow\n-import type { ThreadInfo, ThreadPermission } from '../types/thread-types';\n+import type {\n+ ThreadInfo,\n+ ThreadPermission,\n+ MemberInfo,\n+} from '../types/thread-t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Forgot to import a type |
129,187 | 20.12.2017 22:37:52 | 18,000 | f37169cf11ce8309e2f1bd76d1001b15536017ac | Upgrade react-native to 0.51.0
Easiest upgrade ever. Should I be concerned? | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "@@ -45,12 +45,12 @@ suppress_type=$FlowFixMeProps\nsuppress_type=$FlowFixMeState\nsuppress_type=$FixMe\n-suppress_comment=\\\\(.\\\\|\\n\\\\)*\\\\$FlowFixMe\\\\($\\\\|[^(]\\\\|(\\\\(>=0\\\\.\\\\(5... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Upgrade react-native to 0.51.0
Easiest upgrade ever. Should I be concerned? |
129,187 | 20.12.2017 23:40:50 | 18,000 | 0631995e26d64bb840094e10ebb07c81b8d7bc05 | Don't set unread status on non-members | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -476,7 +476,7 @@ UPDATE memberships m\nLEFT JOIN focused f ON f.user = m.user AND f.thread = m.thread\nAND f.time > {$time}\nSET m.unread = 1\n-WHERE f.user IS NULL AND {$thread_creator... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't set unread status on non-members |
129,187 | 21.12.2017 14:37:42 | 18,000 | a8ef928e436a87db1a171b8dfde7699e764b028c | Actually show unread status in thread list on native | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -44,6 +44,9 @@ class ChatThreadListItem extends React.PureComponent<Props> {\nrender() {\nconst lastActivity = shortAbsoluteDate(this.props.data.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Actually show unread status in thread list on native |
129,187 | 21.12.2017 14:38:02 | 18,000 | e3ea44c5bccefd6e1ef7a08149bd6016f19a9505 | Make sure a currently focused thread is never unread on native | [
{
"change_type": "MODIFY",
"old_path": "native/redux-setup.js",
"new_path": "native/redux-setup.js",
"diff": "@@ -20,9 +20,10 @@ import { NavigationActions } from 'react-navigation';\nimport baseReducer from 'lib/reducers/master-reducer';\nimport { newSessionID } from 'lib/selectors/session-selector... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure a currently focused thread is never unread on native |
129,187 | 21.12.2017 14:38:30 | 18,000 | e65c3f2d2cff21c5b5fd164f8a6a96eb1b8fa9e6 | Fix typo in unread SQL queries | [
{
"change_type": "MODIFY",
"old_path": "server/thread_lib.php",
"new_path": "server/thread_lib.php",
"diff": "@@ -220,7 +220,7 @@ SQL;\n$query = <<<SQL\nUPDATE memberships\nSET unread = 0\n-WHERE m.role IS NOT NULL\n+WHERE role IS NOT NULL\nAND thread IN ({$thread_ids_sql_string})\nAND user = {$view... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix typo in unread SQL queries |
129,187 | 21.12.2017 15:39:44 | 18,000 | 6ad6a514142a491897b737bf602e818e5cb99cdc | Hit update_focused_threads.php on backgrounding and foregrounding
Also don't hit it if there is no change. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -207,6 +207,12 @@ class AppWithNavigationState extends React.PureComponent<Props> {\n!this.activePingSubscription\n) {\nthis.activePingSubscription = setInterval(this.ping, pingFrequency);\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Hit update_focused_threads.php on backgrounding and foregrounding
Also don't hit it if there is no change. |
129,187 | 25.12.2017 15:24:16 | 18,000 | b079391519041c40bc16a3421a46b672891a5675 | Fix issue with order of get_message_infos SQL query
MySQL 5.7 seems to have changed things such that the `SELECT` in the inner query gets executed before the `ORDER BY`. I think the `ORDER BY` is being lifted into the parent query or something?
Anyways, this should fix it. | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -121,14 +121,16 @@ function get_message_infos($thread_selection_criteria, $number_per_thread) {\n$int_number_per_thread = (int)$number_per_thread;\n$create_sub_thread = MESSAGE_TYPE_CRE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix issue with order of get_message_infos SQL query
MySQL 5.7 seems to have changed things such that the `SELECT` in the inner query gets executed before the `ORDER BY`. I think the `ORDER BY` is being lifted into the parent query or something?
Anyways, this should fix it. |
129,187 | 25.12.2017 16:06:19 | 18,000 | e0759726fb53c0c4bd6542ec6fce3c26a76f1e49 | Further iPhone X fixes | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -23,8 +23,8 @@ import {\nActivityIndicator,\nKeyboard,\nLayoutAnimation,\n- SafeAreaView,\n} from 'react-native';\n+import { SafeAreaView } from 'react-navigation'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Further iPhone X fixes |
129,187 | 25.12.2017 16:47:53 | 18,000 | 88db89b184ec2d5e091811db73560383766b4bc4 | Entry padding is 21 on iOS, not 20 | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -614,7 +614,8 @@ class InnerCalendar extends React.PureComponent<Props, State> {\n} else if (item.itemType === \"header\") {\nreturn 31;\n} else if (item.itemType ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Entry padding is 21 on iOS, not 20 |
129,187 | 25.12.2017 23:12:28 | 18,000 | fed01c2357f9802fd9649429adc68003377bd433 | SQL typo in last commit | [
{
"change_type": "MODIFY",
"old_path": "server/set_device_token.php",
"new_path": "server/set_device_token.php",
"diff": "@@ -16,7 +16,7 @@ $device_token = $conn->real_escape_string($_POST['device_token']);\nlist($viewer_id, $is_user, $cookie_id) = get_viewer_info();\n$query = <<<SQL\n-UPDATE cookie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | SQL typo in last commit |
129,187 | 26.12.2017 14:32:07 | 18,000 | 9d3ed2390fad2e0555aca5123c7a83863cd2685d | role is not a nullable field
Check whether it's 0, not whether it's null | [
{
"change_type": "MODIFY",
"old_path": "native/redux-setup.js",
"new_path": "native/redux-setup.js",
"diff": "@@ -172,7 +172,7 @@ function validateState(oldState: AppState, state: AppState): AppState {\n};\n}\nif (activeThread && oldActiveThread !== activeThread) {\n- // Update messageStore.threads.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | role is not a nullable field
Check whether it's 0, not whether it's null |
129,187 | 27.12.2017 02:03:24 | 18,000 | d3f4efa7f6846d751abb89a128b4af1e716d45c8 | Call node.js from PHP | [
{
"change_type": "MODIFY",
"old_path": "jserver/package.json",
"new_path": "jserver/package.json",
"diff": "\"nodemon\": \"^1.14.3\"\n},\n\"dependencies\": {\n- \"lib\": \"file:../lib\",\n- \"express\": \"^4.16.2\"\n+ \"body-parser\": \"^1.18.2\",\n+ \"express\": \"^4.16.2\",\n+ \"lib\": \"file:../l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Call node.js from PHP |
129,187 | 27.12.2017 03:17:21 | 18,000 | 82cb11151ce96c72274de5326d1f2e59c66d810d | Push notifs from node.js! | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "@@ -8,3 +8,4 @@ web/node_modules\nweb/dist/dev.build.js\njserver/dist\njserver/node_modules\n+jserver/keys\n"
},
{
"change_type": "MODIFY",
"old_path": "jserver/loader.mjs",
"new_path": "jserver/l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Push notifs from node.js! |
129,187 | 27.12.2017 14:15:37 | 18,000 | 412e68d5bad9c7d73fd7ba52343a8371dc5710c9 | Fetch unread counts from MySQL in node.js notifs logic | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "@@ -8,4 +8,4 @@ web/node_modules\nweb/dist/dev.build.js\njserver/dist\njserver/node_modules\n-jserver/keys\n+jserver/secrets\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "jserver/fl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fetch unread counts from MySQL in node.js notifs logic |
129,187 | 27.12.2017 23:10:07 | 18,000 | 08ec76d1692d964cc1482084f00a08ce2a3f2100 | Don't wait for push notifs to response to send message request | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/error_handler.js",
"new_path": "jserver/src/error_handler.js",
"diff": "@@ -8,10 +8,13 @@ export default function errorHandler(handler: OurHandler) {\nreturn async (req: $Request, res: $Response) => {\ntry {\nconst result = await handler(req, res);... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't wait for push notifs to response to send message request |
129,187 | 27.12.2017 23:10:39 | 18,000 | ef01602d98345f8bf673103596a4441bea055a51 | Race condition where ping returns before send message completes leads to duplicate messageIDs | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -23,9 +23,10 @@ import _pick from 'lodash/fp/pick';\nimport _pickBy from 'lodash/fp/pickBy';\nimport _omitBy from 'lodash/fp/omitBy';\nimport _mapKeys from 'lodash/fp/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Race condition where ping returns before send message completes leads to duplicate messageIDs |
129,187 | 27.12.2017 23:11:13 | 18,000 | 8c20ed41d0f2aab65b41557429a1c9df64340f6e | Keep text state local to InputBar
Only use `draft` from Redux when constructing | [
{
"change_type": "MODIFY",
"old_path": "native/chat/input-bar.react.js",
"new_path": "native/chat/input-bar.react.js",
"diff": "@@ -71,13 +71,11 @@ type Props = {\n) => Promise<JoinThreadResult>,\n};\ntype State = {\n+ text: string,\nheight: number,\n};\nclass InputBar extends React.PureComponent<Pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Keep text state local to InputBar
Only use `draft` from Redux when constructing |
129,187 | 28.12.2017 00:38:19 | 18,000 | b0260f006acbbca34b85a66b02db3b879afa610d | server config for node.js | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "jserver/.nvmrc",
"diff": "+default\n"
},
{
"change_type": "MODIFY",
"old_path": "jserver/package-lock.json",
"new_path": "jserver/package-lock.json",
"diff": "}\n},\n\"ansi-regex\": {\n- \"version\": \"3.0.0\",\n- \"resolved\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | server config for node.js |
129,187 | 28.12.2017 00:45:15 | 18,000 | 5661f4638f7c34e7703874fc3ec709200ece5ecf | Commit jserver/node_modules/lib symlink | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "@@ -3,10 +3,10 @@ server/config.php\nserver/.htaccess\nserver/fonts\nlib/node_modules\n-web/node_modules\n+web/node_modules/*\n!web/node_modules/lib\nweb/dist/dev.build.js\njserver/dist\n-jserver/node_modules\n+j... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Commit jserver/node_modules/lib symlink |
129,187 | 28.12.2017 18:20:10 | 18,000 | d3fdbef32156fceb73f553b016df187bbd4ae389 | Stop crashing native on log out | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -23,17 +23,20 @@ function generateRandomColor() {\n}\nfunction threadHasPermission(\n- threadInfo: ThreadInfo,\n+ threadInfo: ?ThreadInfo,\npermission: ThreadPermission,\n) {\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Stop crashing native on log out |
129,187 | 28.12.2017 18:23:19 | 18,000 | e3e623b477d9b56dffed1c247bdc4e73e180e4c4 | Stop calling .then() on Promises as it's a no-op | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "@@ -246,7 +246,7 @@ class LogInPanelContainer extends React.PureComponent<Props, State> {\n},\n).start();\n- this.inCoupleSecondsNavigateToL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Stop calling .then() on Promises as it's a no-op |
129,187 | 05.01.2018 12:34:35 | 18,000 | e571bd4635d53857c4b71a8c167e91b5888843b5 | Require visibility for unread status and notifs
(And a bugfix of an earlier commit) | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/ios_notifs.js",
"new_path": "jserver/src/push/ios_notifs.js",
"diff": "@@ -28,7 +28,7 @@ async function sendIOSPushNotifs(req: $Request, res: $Response) {\nres.json({ success: true });\nconst pushInfo: IOSPushInfo = req.body;\n- if (Object.key... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Require visibility for unread status and notifs
(And a bugfix of an earlier commit) |
129,187 | 05.01.2018 23:29:28 | 18,000 | cf8401ea5f51bb0c4d38932a7528e4fe66329eda | Try sending remote notifs even when app foregrounded | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -497,12 +497,13 @@ SQL;\n$conn->next_result();\n$notif_query = <<<SQL\n-SELECT m.user, m.thread, c2.ios_device_token\n+SELECT m.user, m.thread, c.ios_device_token\nFROM memberships m\nL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Try sending remote notifs even when app foregrounded |
129,187 | 06.01.2018 12:25:54 | 18,000 | 29d9a8ee09da66cbb8c819de89e9a33d40225690 | Make sure all notif text explicitly mentions threads | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -59,6 +59,10 @@ function robotextForUsers(users: RelativeUserInfo[]): string {\n}\n}\n+function encodedThreadEntity(threadID: string, text: string): string {\n+ return `<${tex... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure all notif text explicitly mentions threads |
129,187 | 06.01.2018 12:39:53 | 18,000 | cdf6088b45c6b1b2b8a5a9dd9d4e940a1bc1482b | Don't send notifs about CREATE_SUB_THREAD
Since these would be duplicate with `CREATE_THREAD`. Also, we're now only sending notifs to actual members where `subscribed` in the DB is 1 (soon to be changed). | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -372,6 +372,10 @@ SQL;\nreturn $users;\n}\n+function message_type_gets_notif($message_type) {\n+ return $message_type !== MESSAGE_TYPE_CREATE_SUB_THREAD;\n+}\n+\n// returns message info... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't send notifs about CREATE_SUB_THREAD
Since these would be duplicate with `CREATE_THREAD`. Also, we're now only sending notifs to actual members where `subscribed` in the DB is 1 (soon to be changed). |
129,187 | 06.01.2018 19:47:52 | 18,000 | 7741e13d2b05adc0ea9d32cd7ad76d6dd4a09bf8 | Implement in-app notifications and make external notif presses navigate you to the correct thread | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/notif-utils.js",
"new_path": "lib/shared/notif-utils.js",
"diff": "@@ -15,6 +15,13 @@ import { threadIsTwoPersonChat, threadIsNamed } from './thread-utils';\nimport { stringForUser } from './user-utils';\nimport { prettyDate } from '../utils/date-ut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Implement in-app notifications and make external notif presses navigate you to the correct thread |
129,187 | 06.01.2018 23:03:40 | 18,000 | 00f7f79049b7defc1008186ad849b83bf3b08a03 | Locally clear notifs once the corresponding thread is viewed | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -198,6 +198,31 @@ class AppWithNavigationState extends React.PureComponent<Props> {\n}\n}\n+ static clearIOSNotifsOfThread(threadID: string) {\n+ NotificationsIOS.getDeliveredNotifications(\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Locally clear notifs once the corresponding thread is viewed |
129,187 | 07.01.2018 16:31:52 | 18,000 | 0ea3d6dffbd457dabbcc3edcb87ac1000437ab12 | Support notification IDs so we can rescind them later | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/database.js",
"new_path": "jserver/src/database.js",
"diff": "@@ -6,7 +6,7 @@ import SQL from 'sql-template-strings';\nimport dbConfig from '../secrets/db_config';\nexport type QueryResult = [\n- any[],\n+ any[] & { insertId?: number },\nany[],\n];... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Support notification IDs so we can rescind them later |
129,187 | 07.01.2018 16:59:19 | 18,000 | cea3adcbfd8b28bf4f4308d6436bbca1d58cc0f3 | Use specific kind of remote notification that wix's react-native-notifications can rescind | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/ios_notifs.js",
"new_path": "jserver/src/push/ios_notifs.js",
"diff": "@@ -216,10 +216,19 @@ function prepareNotification(\n): apn.Notification {\nconst notifText = notifTextForMessageInfo(messageInfo, threadInfo);\nconst notification = new ap... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use specific kind of remote notification that wix's react-native-notifications can rescind |
129,187 | 07.01.2018 18:19:10 | 18,000 | caad8ed7847e445373e6deffe1cf7ece63fa592b | Add support for rescinding iOS notifications to the server | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/app.js",
"new_path": "jserver/src/app.js",
"diff": "@@ -5,8 +5,10 @@ import bodyParser from 'body-parser';\nimport errorHandler from './error_handler';\nimport { sendIOSPushNotifs } from './push/ios_notifs';\n+import { rescindPushNotifs } from './p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add support for rescinding iOS notifications to the server |
129,187 | 07.01.2018 18:29:32 | 18,000 | 93a4fce7b9b8d1a6d372a381d0614ca9d29388ba | Fix some Android stuff with the new wix notification package | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/java/org/squadcal/MainApplication.java",
"new_path": "native/android/app/src/main/java/org/squadcal/MainApplication.java",
"diff": "@@ -26,7 +26,7 @@ public class MainApplication extends Application implements ReactApplication {\npr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix some Android stuff with the new wix notification package |
129,187 | 07.01.2018 18:32:08 | 18,000 | 89e101933253545a7bc651bf8ce2c01d6f5eebb1 | Minor typo in last commit ugh | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -258,6 +258,7 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nthis.iosNotificationOpened,\n);\n}\n+ }\nhandleURLChange = (event: { url: string }) => {\nthis.dispatchActi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Minor typo in last commit ugh |
129,187 | 08.01.2018 16:11:38 | 18,000 | 52bb7c14c57dac8c6bc387f6ac7ed98082e1944e | Move message creation to after thread creation/editing
In particular, creating a thread's permission rows only after message creation breaks the permission checks that occur in the notification code. | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -230,29 +230,6 @@ if ($changed_sql_fields) {\n$conn->query(\"UPDATE threads SET {$sql_set_string} WHERE id = {$thread}\");\n}\n-$time = round(microtime(true) * 1000); // in milliseconds... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move message creation to after thread creation/editing
In particular, creating a thread's permission rows only after message creation breaks the permission checks that occur in the notification code. |
129,187 | 08.01.2018 17:31:22 | 18,000 | 3696cdbdcafc37ed694ec3128554e987ab2e90ec | Make sure all role rows are populated on thread creation
We weren't checking any rows on the parent that might translate to the child. | [
{
"change_type": "MODIFY",
"old_path": "server/new_thread.php",
"new_path": "server/new_thread.php",
"diff": "@@ -103,10 +103,15 @@ $conn->query($thread_insert_sql);\n$initial_member_ids = isset($_POST['initial_member_ids'])\n? verify_user_ids($_POST['initial_member_ids'])\n: array();\n+$creator_mem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure all role rows are populated on thread creation
We weren't checking any rows on the parent that might translate to the child. |
129,187 | 08.01.2018 18:10:02 | 18,000 | 38e0716b2a2017ab9cf423b0f3397e04b3e0208c | Generate notif text for CREATE_SUB_THREAD notifs
Used when corresponding CREATE_THREAD notif isn't sent | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/ios_notifs.js",
"new_path": "jserver/src/push/ios_notifs.js",
"diff": "@@ -111,6 +111,8 @@ async function fetchInfos(\nrawMessageInfo.initialThreadState.parentThreadID\n) {\nthreadIDs.add(rawMessageInfo.initialThreadState.parentThreadID);\n+ }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Generate notif text for CREATE_SUB_THREAD notifs
Used when corresponding CREATE_THREAD notif isn't sent |
129,187 | 08.01.2018 23:33:21 | 18,000 | 837a0c5e7b67202003bc6767a4a502e9c3f44477 | Use remote notifs for initial ping and remote notifs to rescind
Using my custom worked version of `react-native-notifications` now. | [
{
"change_type": "MODIFY",
"old_path": "jserver/package-lock.json",
"new_path": "jserver/package-lock.json",
"diff": "\"uuid\": {\n\"version\": \"3.1.0\",\n\"resolved\": \"https://registry.npmjs.org/uuid/-/uuid-3.1.0.tgz\",\n- \"integrity\": \"sha512-DIWtzUkw04M4k3bf1IcpS2tngXEL26YUD2M0tMDUpnUrz2hgz... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use remote notifs for initial ping and remote notifs to rescind
Using my custom worked version of `react-native-notifications` now. |
129,187 | 08.01.2018 23:46:36 | 18,000 | 09165134e35bb8e469273cbcd0fa0c5094e7fc21 | Set notifications to rescinded after rescinding them | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/ios_notifs.js",
"new_path": "jserver/src/push/ios_notifs.js",
"diff": "@@ -81,12 +81,13 @@ async function sendIOSPushNotifs(req: $Request, res: $Response) {\niosDeviceTokens: pushInfo[userID].deviceTokens,\niosIdentifier: notification.id,\n}),... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Set notifications to rescinded after rescinding them |
129,187 | 09.01.2018 00:35:23 | 18,000 | 83898d7dc6eee04ee5cc4164808a24e78501212a | Save errors on initial push to database | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/ios_notifs.js",
"new_path": "jserver/src/push/ios_notifs.js",
"diff": "@@ -40,15 +40,15 @@ async function sendIOSPushNotifs(req: $Request, res: $Response) {\nconst [\nunreadCounts,\n{ threadInfos, userInfos },\n- uniqueIDs,\n+ dbIDs,\n] = awai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Save errors on initial push to database |
129,187 | 09.01.2018 23:20:04 | 18,000 | e5cd2e6b666c709b79125c82b9743672ff6ff6ec | Update to call completionHandler after processing remote notification
Also a bugfix where iOS notifs weren't being saved to the database and adding the uniqueID to the payload of the remote notification. | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/ios_notifs.js",
"new_path": "jserver/src/push/ios_notifs.js",
"diff": "@@ -110,7 +110,7 @@ async function sendIOSPushNotifs(req: $Request, res: $Response) {\njsonConverted[4] = JSON.stringify(jsonConverted[4]);\nflattenedNotifications.push(jso... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to call completionHandler after processing remote notification
Also a bugfix where iOS notifs weren't being saved to the database and adding the uniqueID to the payload of the remote notification. |
129,187 | 10.01.2018 00:28:36 | 18,000 | ad76def7e7691ae24e338aa35a19e4febc309518 | Use newer way of asking for permissions | [
{
"change_type": "MODIFY",
"old_path": "native/ios/SquadCal/AppDelegate.m",
"new_path": "native/ios/SquadCal/AppDelegate.m",
"diff": "restorationHandler:restorationHandler];\n}\n-// Required to register for notifications\n-- (void)application:(UIApplication *)application didRegisterUserNotificationS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use newer way of asking for permissions |
129,187 | 10.01.2018 14:15:30 | 18,000 | d56e7968ef433178a5c180f6fa84190a294fae88 | Install react-native-fcm for Android notifications | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "apply plugin: \"com.android.application\"\n+apply plugin: 'com.google.gms.google-services'\nimport com.android.build.OutputFile\n@@ -133,7 +134,8 @@ android {\n}\ndepende... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Install react-native-fcm for Android notifications |
129,187 | 12.01.2018 18:10:16 | 18,000 | 174bf6f6c3988ed315dc070d48fe0115bcb23fd5 | Use local notifs for Android and rescind notifs and update badge count correctly | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/rescind.js",
"new_path": "jserver/src/push/rescind.js",
"diff": "@@ -5,7 +5,7 @@ import type { $Response, $Request } from 'express';\nimport apn from 'apn';\nimport { connect, SQL } from '../database';\n-import { apnPush, getUnreadCounts } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use local notifs for Android and rescind notifs and update badge count correctly |
129,187 | 15.01.2018 14:20:33 | 18,000 | 2febebdccde82a7f47d67ff0970385c5783e18dd | Get SectionFooter working on Dan's Android
Note sure why `position: 'absolute'` works differently on his phone. Might have to do with the ancient version of Android (KitKat). | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/section-footer.react.js",
"new_path": "native/calendar/section-footer.react.js",
"diff": "@@ -51,9 +51,9 @@ const styles = StyleSheet.create({\nsectionFooter: {\nbackgroundColor: 'white',\nheight: 40,\n+ alignItems: 'flex-start',\n},\naddButton... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get SectionFooter working on Dan's Android
Note sure why `position: 'absolute'` works differently on his phone. Might have to do with the ancient version of Android (KitKat). |
129,187 | 15.01.2018 15:37:50 | 18,000 | a15109f5f92d491582bc500a01bee5cb7bfc70e4 | Make log-in case insensitive
... and also fix a SQL injection vulnerability I somehow missed. Ouch. | [
{
"change_type": "MODIFY",
"old_path": "server/forgot_password.php",
"new_path": "server/forgot_password.php",
"diff": "@@ -12,12 +12,14 @@ if (!isset($_POST['username'])) {\n'error' => 'invalid_parameters',\n));\n}\n-$username = $_POST['username'];\n+$username = $conn->real_escape_string($_POST['us... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make log-in case insensitive
... and also fix a SQL injection vulnerability I somehow missed. Ouch. |
129,187 | 16.01.2018 14:24:46 | 18,000 | 54a9776496446c5653d1d5978de82a199f025c90 | Fix another weird MySQL sync error bug | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"scripts\": {\n\"start\": \"node node_modules/react-native/local-cli/cli.js start\",\n\"test\": \"jest\",\n- \"devtools\": \"react-devtools\"\n+ \"devtools\": \"react-devtools\",\n+ \"logfireba... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix another weird MySQL sync error bug |
129,187 | 16.01.2018 16:00:14 | 18,000 | ad3739c3e79cdd2bf36fddbae48590b338b040cf | Allow emojis in thread names on native | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -240,7 +240,6 @@ class InnerAddThread extends React.PureComponent<Props, State> {\nautoFocus={true}\nautoCorrect={false}\nautoCapitalize=\"none\"\n- keyboardType=\"asc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Allow emojis in thread names on native |
129,187 | 17.01.2018 17:37:35 | 18,000 | 96280034dbd7ac6e38dd04e1dd7f8f46e24156ba | Collapsing notifications | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/database.js",
"new_path": "jserver/src/database.js",
"diff": "// @flow\n-import mysql from 'mysql2/promise';\n+import mysqlPromise from 'mysql2/promise';\n+import mysql from 'mysql2';\nimport SQL from 'sql-template-strings';\nimport dbConfig from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Collapsing notifications |
129,187 | 18.01.2018 11:34:43 | 18,000 | 5c775aab9fa8a3e6e76376b2b4f77fb0bb67aca8 | Clean up invalid FCM tokens on the server side | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/send.js",
"new_path": "jserver/src/push/send.js",
"diff": "@@ -23,7 +23,7 @@ import {\n} from 'lib/shared/message-utils';\nimport { rawThreadInfosToThreadInfos } from 'lib/selectors/thread-selectors';\n-import { connect, SQL } from '../databas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Clean up invalid FCM tokens on the server side |
129,187 | 18.01.2018 12:09:10 | 18,000 | 85c8da471a950170bdd98021c0c1ae0d9d729d2f | Collapsing notification on Android | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/rescind.js",
"new_path": "jserver/src/push/rescind.js",
"diff": "@@ -19,7 +19,7 @@ async function rescindPushNotifs(req: $Request, res: $Response) {\nconst conn = await connect();\nconst fetchQuery = SQL`\n- SELECT id, delivery\n+ SELECT id, d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Collapsing notification on Android |
129,187 | 18.01.2018 19:41:43 | 18,000 | 9dcff53cec683c2f4e5c353430323068bd3877b3 | Clean up invalid APN tokens on the server side | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/push/send.js",
"new_path": "jserver/src/push/send.js",
"diff": "@@ -170,11 +170,17 @@ async function sendPushNotifs(req: $Request, res: $Response) {\nfcmTokens: deliveryResult.invalidFCMTokens,\n});\n}\n+ if (deliveryResult.invalidAPNTokens) {\n+ i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Clean up invalid APN tokens on the server side |
129,187 | 18.01.2018 21:22:14 | 18,000 | c959fc44fe44895bb131cef30cef8b087c2a0ccf | Upgrade to redux-persist@5 | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "; Ignore polyfills\n.*/Libraries/polyfills/.*\n+.*/node_modules/redux-persist/lib/index.js\n+\n[include]\n../lib\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "native... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Upgrade to redux-persist@5 |
129,187 | 18.01.2018 21:39:25 | 18,000 | eb1ac67d777cc46302185b9d86104b9ac5ad8934 | Call redux-persist REHYDRATE ourselves in __DEV__ on Android
For some reason it doesn't fire when I refresh the app source in the Android emulator, so we need to manually fire it. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -41,6 +41,7 @@ import PropTypes from 'prop-types';\nimport NotificationsIOS from 'react-native-notifications';\nimport InAppNotification from 'react-native-in-app-notification';\nimport FCM, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Call redux-persist REHYDRATE ourselves in __DEV__ on Android
For some reason it doesn't fire when I refresh the app source in the Android emulator, so we need to manually fire it. |
129,187 | 22.01.2018 12:48:51 | 25,200 | ccdf0039080b7be818b852478aec07272c77c794 | Break down Thread Settings components into individual rows
This is necessary to convert to FlatList | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-category.react.js",
"new_path": "native/chat/settings/thread-settings-category.react.js",
"diff": "import * as React from 'react';\nimport { View, Text, StyleSheet } from 'react-native';\n+import invariant from 'invariant';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Break down Thread Settings components into individual rows
This is necessary to convert to FlatList |
129,187 | 22.01.2018 14:03:35 | 25,200 | 5de77e3b303dc43712336559d5b3c042f9aab3dc | Factor out name row in thread settings | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-name.react.js",
"diff": "+// @flow\n+\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+import { threadInfoPropType } from 'lib/types/thread-types';\n+import type { ChangeThreadSettingsResult } fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out name row in thread settings |
129,187 | 22.01.2018 14:41:04 | 25,200 | 022c261608f4bfdb35e246917fac1c4c3ec8e8cf | Factor out description category in thread settings | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-description.react.js",
"diff": "+// @flow\n+\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+import { threadInfoPropType, threadPermissions } from 'lib/types/thread-types';\n+import type { Chang... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out description category in thread settings |
129,187 | 22.01.2018 16:57:57 | 25,200 | 015694f9e5ed01530761eaae4643b801fc7b9bd1 | Factor out color row in thread settings | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-color.react.js",
"diff": "+// @flow\n+\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+import { threadInfoPropType } from 'lib/types/thread-types';\n+import type { ChangeThreadSettingsResult } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out color row in thread settings |
129,187 | 22.01.2018 17:50:20 | 25,200 | 5e8365fc2acfbb46cce31059509eda0e444f319d | Make sure to include currentUser even when current user isn't a member
Without this we end up filtering these threadInfos from the client. | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/fetchers/thread-fetcher.js",
"new_path": "jserver/src/fetchers/thread-fetcher.js",
"diff": "@@ -86,17 +86,24 @@ async function fetchThreadInfos(\n},\nthreadID,\n);\n+ const member = {\n+ id: userID,\n+ permissions: allPermissions,\n+ role: row.role... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure to include currentUser even when current user isn't a member
Without this we end up filtering these threadInfos from the client. |
129,187 | 22.01.2018 18:05:05 | 25,200 | aa986c4453c547496871e94ee2ed02633973fb0f | Factor out parent thread row in thread settings | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-parent.react.js",
"diff": "+// @flow\n+\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+import { threadInfoPropType } from 'lib/types/thread-types';\n+import type { AppState } from '../../redux-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out parent thread row in thread settings |
129,187 | 22.01.2018 18:11:46 | 25,200 | 34a191a2e414c944f79529fe4e6c438ebf9bfd7d | Factor out visibility row in thread settings | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-visibility.react.js",
"diff": "+// @flow\n+\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+import { threadInfoPropType } from 'lib/types/thread-types';\n+\n+import React from 'react';\n+import ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out visibility row in thread settings |
129,187 | 22.01.2018 22:05:27 | 25,200 | 4e21387476fb53292f5db921003590776180dc93 | Factor our ThreadSettingsListActions into separate rows | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-child-thread.react.js",
"new_path": "native/chat/settings/thread-settings-child-thread.react.js",
"diff": "@@ -4,7 +4,7 @@ import type { ThreadInfo } from 'lib/types/thread-types';\nimport type { NavigationParams } from 're... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor our ThreadSettingsListActions into separate rows |
129,187 | 22.01.2018 23:02:43 | 25,200 | 1be6804698512a0ef2e6e963185a3cb55878e373 | Factor out leave thread row in thread settings and simplify LoadingStatus logic in ThreadSettings
This concludes the work to break down the thread settings `ScrollView` into discrete rows so we can move it to a `FlatList`. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-leave-thread.react.js",
"diff": "+// @flow\n+\n+import type { ThreadInfo, RelativeMemberInfo } from 'lib/types/thread-types';\n+import {\n+ threadInfoPropType,\n+ relativeMemberInfoPropType,\n+} from 'lib/typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out leave thread row in thread settings and simplify LoadingStatus logic in ThreadSettings
This concludes the work to break down the thread settings `ScrollView` into discrete rows so we can move it to a `FlatList`. |
129,187 | 24.01.2018 12:33:04 | 25,200 | 324b7a789f1858423d3ccb8c50ea6de7372ac4f5 | Convert ThreadSettings ScrollView to FlatList | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-category.react.js",
"new_path": "native/chat/settings/thread-settings-category.react.js",
"diff": "@@ -4,8 +4,9 @@ import * as React from 'react';\nimport { View, Text, StyleSheet } from 'react-native';\nimport invariant fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Convert ThreadSettings ScrollView to FlatList |
129,187 | 24.01.2018 14:06:15 | 25,200 | c6dc7411fd5dac9a03a346e746d2f77a61e31adb | Update to React Native 0.52 | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "[libs]\nnode_modules/react-native/Libraries/react-native/react-native-interface.js\nnode_modules/react-native/flow/\n+node_modules/react-native/flow-github/\n[options]\nemoji=true\n@@ -46,14 +47,1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to React Native 0.52 |
129,187 | 30.01.2018 15:20:07 | 18,000 | c8513d0e508887bd53e44f57a4abe4cfa4b8a615 | Import Header components directly from react-navigation to avoid Flow errors | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-header-title.react.js",
"new_path": "native/chat/message-list-header-title.react.js",
"diff": "@@ -8,7 +8,7 @@ import React from 'react';\nimport { View, Text, StyleSheet, Platform } from 'react-native';\nimport PropTypes from 'prop-ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Import Header components directly from react-navigation to avoid Flow errors |
129,187 | 30.01.2018 15:20:19 | 18,000 | 2dc0c72083115f7d30a41b81bf78cfb1b56c5130 | Upgrade react-devtools to avoid security vulnerability in old version of Electron | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "\"babel-template\": \"6.26.0\"\n}\n},\n- \"babel-plugin-transform-define\": {\n- \"version\": \"1.3.0\",\n- \"resolved\": \"https://registry.npmjs.org/babel-plugin-transform-define/-/b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Upgrade react-devtools to avoid security vulnerability in old version of Electron |
129,187 | 30.01.2018 16:02:42 | 18,000 | 52835fa4dce5ee50235da2024c8e032c0d9ecbf0 | Fix bug where entry local IDs weren't being picked up from Redux | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -365,7 +365,7 @@ function reduceEntryInfos(\n};\n}\n} else if (action.type === rehydrateActionType) {\n- if (!action.payload || !action.payload.entryInfos) {\n+ if (!actio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix bug where entry local IDs weren't being picked up from Redux |
129,187 | 30.01.2018 16:03:29 | 18,000 | a0c504a31106e211101d27e90c9ca838cada4565 | Update to react-navigation master
We need to shim an empty `addListener` in our Redux integration root `navigation` prop | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -643,6 +643,9 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nconst navigation: NavigationScreenProp<any> = addNavigationHelpers({\ndispatch: this.props.dispatch,\nstate... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to react-navigation master
We need to shim an empty `addListener` in our Redux integration root `navigation` prop |
129,187 | 31.01.2018 12:13:51 | 18,000 | a9287e43b030cd5d3d3012eab3c132b173ee1d8b | Update react-navigation libdef and remove deprecated "lazy" TabNavigator config param | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/react-navigation.js",
"new_path": "native/flow-typed/react-navigation.js",
"diff": "@@ -262,10 +262,15 @@ declare module 'react-navigation' {\nRoute: NavigationRoute,\nOptions: {},\nProps: {}\n- > = React.ComponentType<NavigationNavigatorProp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update react-navigation libdef and remove deprecated "lazy" TabNavigator config param |
129,187 | 01.02.2018 19:27:28 | 18,000 | dd9ccb061afef71a6c627aa4a257c462687fdb69 | Redux middleware from `react-navigation-redux-helpers` | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -36,6 +36,7 @@ import {\nDeviceInfo,\n} from 'react-native';\nimport { addNavigationHelpers } from 'react-navigation';\n+import { createReduxBoundAddListener } from 'react-navigation-redux-he... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Redux middleware from `react-navigation-redux-helpers` |
129,187 | 05.02.2018 10:36:29 | 18,000 | cb3654049e522edb30ea45148252dbab5a0411c4 | No more edit_rules
(You must be logged in to edit) | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/creators/message-creator.js",
"new_path": "jserver/src/creators/message-creator.js",
"diff": "@@ -10,7 +10,6 @@ import {\nvisibilityRules,\nthreadPermissions,\nassertVisibilityRules,\n- assertEditRules,\n} from 'lib/types/thread-types';\nimport { r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | No more edit_rules
(You must be logged in to edit) |
129,187 | 05.02.2018 15:36:00 | 18,000 | 3b8173422cb82b7b6c2ab782ca08e9eb33fb2eac | Allow removing anonymous members from thread | [
{
"change_type": "MODIFY",
"old_path": "server/remove_members.php",
"new_path": "server/remove_members.php",
"diff": "@@ -16,7 +16,7 @@ if (!isset($_POST['thread']) || !isset($_POST['member_ids'])) {\n));\n}\n$thread = (int)$_POST['thread'];\n-$member_ids = verify_user_ids($_POST['member_ids']);\n+$... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Allow removing anonymous members from thread |
129,187 | 05.02.2018 15:36:39 | 18,000 | 9c25e363ab563eb94cb34508d856bbca23cf69fe | Fix type property of rawMessageInfoFromMessageData result
Not sure how the typechecker missed this... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -368,7 +368,7 @@ function rawMessageInfoFromMessageData(\n};\n} else if (messageData.type === messageType.CREATE_THREAD) {\nreturn {\n- type: messageType.TEXT,\n+ type: messag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix type property of rawMessageInfoFromMessageData result
Not sure how the typechecker missed this... |
129,187 | 06.02.2018 11:21:59 | 18,000 | acad7405f353fbd9945c22b6e1e58dd41be15b38 | Move thread modals into new directory | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-first-modal.react.js",
"new_path": "web/modals/account/log-in-first-modal.react.js",
"diff": "// @flow\n-import type { AppState } from '../../redux-setup';\n-\nimport * as React from 'react';\nimport PropTypes from 'prop-types';\n"
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move thread modals into new directory |
129,187 | 06.02.2018 11:43:02 | 18,000 | 6be8d89ef4afd2b2e6646147186fb3c206a0e1fe | Add linklocal to install step
Unlike `npm`, `yarn` is overwriting any symlinked local deps. We can call `linklocal` after install to fix this. | [
{
"change_type": "MODIFY",
"old_path": "jserver/package.json",
"new_path": "jserver/package.json",
"diff": "\"description\": \"\",\n\"main\": \"dist/app\",\n\"scripts\": {\n+ \"install\": \"linklocal\",\n\"babel\": \"babel src/ --out-dir dist/ --ignore 'lib/flow-typed','lib/node_modules','lib/packag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add linklocal to install step
Unlike `npm`, `yarn` is overwriting any symlinked local deps. We can call `linklocal` after install to fix this. |
129,187 | 06.02.2018 11:47:29 | 18,000 | 178d557c290e756889e0fe92f21db4357e02f2e8 | Save web dev build on change so that if I refresh the page I still get the latest | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "@@ -6,6 +6,7 @@ lib/node_modules\nweb/node_modules/*\n!web/node_modules/lib\nweb/dist/dev.build.js\n+web/dist/hot\njserver/dist\njserver/node_modules/*\n!jserver/node_modules/lib\n"
},
{
"change_type": "M... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Save web dev build on change so that if I refresh the page I still get the latest |
129,187 | 06.02.2018 14:26:55 | 18,000 | b550a321c5f8d03d111dbea48a434607b21aef5f | Refactor TypeaheadPane so an entry actually stays highlighted when it's frozen | [
{
"change_type": "MODIFY",
"old_path": "web/typeahead/typeahead.react.js",
"new_path": "web/typeahead/typeahead.react.js",
"diff": "@@ -38,6 +38,12 @@ import TypeaheadPane from './typeahead-pane.react';\nimport { htmlTargetFromEvent } from '../vector-utils';\nimport { UpCaret, DownCaret, MagnifyingG... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Refactor TypeaheadPane so an entry actually stays highlighted when it's frozen |
129,187 | 06.02.2018 18:51:09 | 18,000 | a5173b0a23f4ba176e86697874f80b5b1b14117a | A couple of missing pieces in the last commits | [
{
"change_type": "MODIFY",
"old_path": "jserver/.flowconfig",
"new_path": "jserver/.flowconfig",
"diff": "[ignore]\n<PROJECT_ROOT>/dist\n<PROJECT_ROOT>/node_modules/google-gax/node_modules/grpc/node_modules/protobufjs/src/bower.json\n-<PROJECT_ROOT>/node_modules/protobufjs/src/bower.json\n+.*/node_m... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | A couple of missing pieces in the last commits |
129,187 | 07.02.2018 00:12:13 | 18,000 | ad9b2f46693631561f163d5a3039aa5b55f94252 | Backend endpoint for updating user subscription for a given thread
Note: no input validation on the JS side yet | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/app.js",
"new_path": "jserver/src/app.js",
"diff": "@@ -7,10 +7,21 @@ import cookieParser from 'cookie-parser';\nimport errorHandler from './error_handler';\nimport { messageCreationResponder } from './responders/message-responders';\nimport { upda... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Backend endpoint for updating user subscription for a given thread
Note: no input validation on the JS side yet |
129,187 | 07.02.2018 22:42:48 | 18,000 | d43bb71ac7ee22bb51d5d3fadd756f3cf955411f | Push notif setting (finally!) | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-push-notifs.react.js",
"diff": "+// @flow\n+\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+import { threadInfoPropType } from 'lib/types/thread-types';\n+import type { AppState } from '../../r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Push notif setting (finally!) |
129,187 | 08.02.2018 11:28:03 | 18,000 | d362e782f5ac42a5b5d0393854936f2c7bc7975c | Create new type ServerThreadInfo and function fetchServerThreadInfos
(Used within node server) | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/creators/message-creator.js",
"new_path": "jserver/src/creators/message-creator.js",
"diff": "@@ -13,6 +13,7 @@ import {\n} from 'lib/types/thread-types';\nimport { rawMessageInfoFromMessageData } from 'lib/shared/message-utils';\nimport { earliest... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Create new type ServerThreadInfo and function fetchServerThreadInfos
(Used within node server) |
129,187 | 08.02.2018 12:46:37 | 18,000 | dbf029f265342ed6ca3d8ae8f467aa761cfa4acf | Update badge count even when user disables push notifs for a thread | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/creators/message-creator.js",
"new_path": "jserver/src/creators/message-creator.js",
"diff": "@@ -274,7 +274,7 @@ async function sendPushNotifsForNewMessages(\nappendSQLArray(query, subthreadJoins, SQL` `);\nquery.append(SQL`\nWHERE m.role != 0 AND... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update badge count even when user disables push notifs for a thread |
129,187 | 08.02.2018 14:56:35 | 18,000 | 2d832a726c3340446d881e7bbf49781e638f80cf | Move node to using connection pooling
Side benefit is we don't need to pass the connection around or end it... | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/creators/id-creator.js",
"new_path": "jserver/src/creators/id-creator.js",
"diff": "// @flow\n-import type { Connection } from '../database';\n-\nimport invariant from 'invariant';\n-import { SQL } from '../database';\n+import { pool, SQL } from '.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move node to using connection pooling
Side benefit is we don't need to pass the connection around or end it... |
129,187 | 08.02.2018 15:01:22 | 18,000 | eb92aa4e02d990efaad31a790a37b86e4ee896ca | Don't block message creation on notification sends | [
{
"change_type": "MODIFY",
"old_path": "jserver/src/creators/message-creator.js",
"new_path": "jserver/src/creators/message-creator.js",
"diff": "@@ -150,15 +150,16 @@ async function createMessages(\nINSERT INTO messages(id, thread, user, type, content, time)\nVALUES ${messageInsertRows}\n`;\n- awai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't block message creation on notification sends |
129,187 | 09.02.2018 12:20:34 | 18,000 | bb458b87e7e83ae8b347718e32b9ae5738881053 | Fix up flow-mono postinstall scripts | [
{
"change_type": "MODIFY",
"old_path": "jserver/package.json",
"new_path": "jserver/package.json",
"diff": "\"description\": \"\",\n\"main\": \"dist/app\",\n\"scripts\": {\n+ \"postinstall\": \"cd ../; npx flow-mono create-symlinks jserver/.flowconfig\",\n\"babel\": \"babel src/ --out-dir dist/ --ig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix up flow-mono postinstall scripts |
129,187 | 11.02.2018 20:25:57 | 18,000 | 964327836c2ff20c856d26c689509f2e11f8cd0f | Get rid of setTimeout hack to avoid RN issue
Also some npm scripts and updating some versions | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-member.react.js",
"new_path": "native/chat/settings/thread-settings-member.react.js",
"diff": "@@ -114,14 +114,14 @@ class ThreadSettingsMember extends React.PureComponent<Props, State> {\n)\n)\n) {\n- result.push({ label: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of setTimeout hack to avoid RN issue #10471
Also some npm scripts and updating some versions |
129,187 | 12.02.2018 13:10:54 | 18,000 | 9566574f50fbf9dc79c50293af1af6058d7cd562 | Fix emailVerified field of CurrentUserInfo | [
{
"change_type": "MODIFY",
"old_path": "server/user_lib.php",
"new_path": "server/user_lib.php",
"diff": "@@ -70,6 +70,6 @@ SQL;\n'id' => (string)$viewer_id,\n'username' => $user_row['username'],\n'email' => $user_row['email'],\n- 'email_verified' => (bool)$user_row['email_verified'],\n+ 'emailVerif... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix emailVerified field of CurrentUserInfo |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.