author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 20.02.2019 15:30:01 | 18,000 | 82fd578c705c8d766feee0eb650b634006e5ca51 | [lib] Reducer support for sendMultimediaMessageActionTypes | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/local-id-reducer.js",
"new_path": "lib/reducers/local-id-reducer.js",
"diff": "@@ -11,6 +11,7 @@ import {\nimport { rehydrateActionType } from '../types/redux-types';\nimport {\nsendTextMessageActionTypes,\n+ sendMultimediaMessageActionTypes,\ncre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Reducer support for sendMultimediaMessageActionTypes |
129,187 | 20.02.2019 15:30:18 | 18,000 | be2adff1131a4d0719e8e041b798e3973a25384e | [lib] Filter out uncommitted messageTypes.MULTIMEDIA on REHYDRATE
(Only applies to native.) | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -11,7 +11,7 @@ import {\nmessageTypes,\ndefaultNumberPerThread,\n} from '../types/message-types';\n-import type { BaseAction } from '../types/redux-types';\n+import { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Filter out uncommitted messageTypes.MULTIMEDIA on REHYDRATE
(Only applies to native.) |
129,187 | 20.02.2019 16:27:57 | 18,000 | 3f7e34470ea9276a81f47891a39bd8ae2656c602 | [lib] Fix accidental entity text in web MessagePreview | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -24,6 +24,7 @@ import _maxBy from 'lodash/fp/maxBy';\nimport { prettyDate } from '../utils/date-utils';\nimport { userIDsToRelativeUserInfos } from '../selectors/user-selector... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix accidental entity text in web MessagePreview |
129,187 | 20.02.2019 16:29:03 | 18,000 | e9959ee997ec10f8cdc1dce63654fe9d89e8e7c9 | [web] Actually call sendMultimediaMessage from MultimediaMessage | [
{
"change_type": "MODIFY",
"old_path": "web/chat/multimedia-message.react.js",
"new_path": "web/chat/multimedia-message.react.js",
"diff": "@@ -4,13 +4,19 @@ import {\ntype ChatMessageInfoItem,\nchatMessageItemPropType,\n} from 'lib/selectors/chat-selectors';\n-import { messageTypes } from 'lib/type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Actually call sendMultimediaMessage from MultimediaMessage |
129,187 | 20.02.2019 17:53:21 | 18,000 | 88de5f57e025d78de624dc8e0ea48134cb99a4c2 | [web] Detect MultimediaMessage failures correctly | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-state-container.react.js",
"new_path": "web/chat/chat-input-state-container.react.js",
"diff": "@@ -97,6 +97,8 @@ class ChatInputStateContainer extends React.PureComponent<Props, State> {\nsetDraft: (draft: string) => this.setDraft(threadID... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Detect MultimediaMessage failures correctly |
129,187 | 20.02.2019 19:26:20 | 18,000 | 248dc627a7186674c744c0f404e60dbb2a0cbaa0 | Support retrying failed multimedia sends on web | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -232,7 +232,7 @@ export type RawMultimediaMessageInfo = {|\n...MultimediaMessageData,\nid?: string, // null if local copy without ID yet\n|};\n-type RawComposableMessageInfo =\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Support retrying failed multimedia sends on web |
129,187 | 20.02.2019 20:10:01 | 18,000 | 66d116b02eaa2a58a4710b80183d07e3367d0cd7 | [web] Add support for displaying MessageTimestampTooltip at the bottom | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -127,6 +127,7 @@ div.messageTimestampTooltip {\npadding: 5px;\nborder-radius: 5px;\nfont-size: 14px;\n+ z-index: 1;\n}\ndiv.messageTimestampTooltip:after {\ncontent: \"\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add support for displaying MessageTimestampTooltip at the bottom |
129,187 | 20.02.2019 20:31:32 | 18,000 | 6f9409023640d1392e57c47ab24cd1b7ec00029f | [lib] Shim multimedia messages to non-web platforms | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/media-utils.js",
"new_path": "lib/shared/media-utils.js",
"diff": "// @flow\nimport type { Media } from '../types/media-types';\n+import type {\n+ MultimediaMessageInfo,\n+ RawMultimediaMessageInfo,\n+} from '../types/message-types';\nimport invaria... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Shim multimedia messages to non-web platforms |
129,187 | 20.02.2019 20:41:41 | 18,000 | 29d86bdf72161406eb462142867597bee9fc2604 | [lib] Get rid of " character in all shimmed robotext
( this means all current native clients will see random " characters at the end of unsupported `MessageInfo`s. Oh well. | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -161,7 +161,7 @@ function robotextForMessageInfo(\nreturn `${creator} restored an event scheduled for ${date}: ` +\n`\"${messageInfo.text}\"`;\n} else if (messageInfo.type ===... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of " character in all shimmed robotext
:( this means all current native clients will see random " characters at the end of unsupported `MessageInfo`s. Oh well. |
129,187 | 20.02.2019 20:45:41 | 18,000 | 42cc9948e1f525787bb4c5a2f3e55a971109d564 | [web] Ungate multimedia support on web | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -47,7 +47,6 @@ import {\n} from 'lib/actions/thread-actions';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport { threadHasPerm... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Ungate multimedia support on web |
129,187 | 22.02.2019 16:44:06 | 18,000 | 1f6c86ba711f34c0b31717f5fddbf4cf671b0446 | [web] MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-state-container.react.js",
"new_path": "web/chat/chat-input-state-container.react.js",
"diff": "@@ -505,7 +505,7 @@ class ChatInputStateContainer extends React.PureComponent<Props, State> {\n}\nrender() {\n- const { activeChatThreadID } = t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] MultimediaModal |
129,187 | 22.02.2019 19:10:03 | 18,000 | 3795a0c6af4ca02f2c50f1865d821bc195914344 | Unshim RawMessageInfos on the client
Any client that includes this commit will unshim `MULTIMEDIA` messages. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -80,6 +80,7 @@ import {\nassignMediaServerIDToMessageActionType,\nassignMediaServerURIToMessageActionType,\n} from '../actions/upload-actions';\n+import { unshimMessag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Unshim RawMessageInfos on the client
Any client that includes this commit will unshim `MULTIMEDIA` messages. |
129,187 | 02.03.2019 22:10:20 | 28,800 | 8482241b5e70896bf6f5e23da9fc6537506f0ae9 | [native] Work around Android 9 cleartext network policy for Metro | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/android/app/src/debug/res/xml/network_security_config.xml",
"diff": "+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<network-security-config>\n+ <!-- allow cleartext traffic for React Native packager ips in debug -->\n+ <domain-config clea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Work around Android 9 cleartext network policy for Metro |
129,187 | 05.03.2019 17:17:51 | 18,000 | caf7fe97feb5234eb5bc6c41b99424810fcb6346 | [native] MessageList textHeight -> contentHeight | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -75,7 +75,7 @@ export type RobotextChatMessageInfoItemWithHeight = {|\nstartsCluster: bool,\nendsCluster: bool,\nrobotext: string,\n- textHeight: number,\n+ conten... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] MessageList textHeight -> contentHeight |
129,187 | 08.03.2019 10:37:01 | 18,000 | dc61c6bc8c7acc712ce338fb49badd0d56e7322c | [native] Avoid using arrow function for canReset
They are slightly less performant | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-screen-registry.js",
"new_path": "native/chat/chat-screen-registry.js",
"diff": "@@ -8,7 +8,7 @@ import React from 'react';\nconst chatSceenRegistry: {[key: string]: ?ChatScreen} = {};\n-export type ChatScreen = React.Component<*, *> & { canRe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid using arrow function for canReset
They are slightly less performant |
129,187 | 08.03.2019 12:19:51 | 18,000 | f53d805f4b3f751edb3c97188cd7a17692c251e0 | [native] MessageListContainer
Separate content height measurement and navigation screen set-up into a separate component. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -11,7 +11,7 @@ import { createStackNavigator } from 'react-navigation';\nimport hoistNonReactStatics from 'hoist-non-react-statics';\nimport ChatThreadList from './chat-thread-lis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] MessageListContainer
Separate content height measurement and navigation screen set-up into a separate component. |
129,187 | 08.03.2019 15:11:18 | 18,000 | 6e14ff9c9cfc0a814c66b96e68303f1eb25c6f3c | [native] Rendering fake shim for MultimediaMessage | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -148,11 +148,7 @@ class MessageListContainer extends React.PureComponent<Props, State> {\ntext: messageInfo.text,\nstyle,\n});\n- } else {\n- i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rendering fake shim for MultimediaMessage |
129,187 | 08.03.2019 15:59:17 | 18,000 | 41e4db85399a47bce03a117fbc8ac9989c198ced | [native] Enable MultimediaMessage to update contentHeight
Still have to write the code to actually calculate it, as well as rendering it.
Also need to make `multimediaMessageLoadingContentHeight` a function that depends on number of multimedia. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -38,6 +38,9 @@ import ThreadSettingsButton from './thread-settings-button.react';\nimport { registerChatScreen } from './chat-screen-registry';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Enable MultimediaMessage to update contentHeight
Still have to write the code to actually calculate it, as well as rendering it.
Also need to make `multimediaMessageLoadingContentHeight` a function that depends on number of multimedia. |
129,187 | 14.03.2019 10:45:57 | 14,400 | 4cafe4f7265bb0cd4fd3a22c1e3927e505930579 | [web] Limit width of chat messages | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -217,12 +217,10 @@ div.messageBox {\ndisplay: flex;\nflex-wrap: wrap;\njustify-content: space-between;\n+ max-width: 68%;\n}\n-div.fullWidthMessageBox {\n- width: 100%;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Limit width of chat messages |
129,187 | 14.03.2019 11:07:05 | 14,400 | c6abeba8d6a72d217b666bd96cb51d335451e685 | [native] Actually render images | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -5,6 +5,7 @@ import type {\n} from './message-list-container.react';\nimport { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\nimport {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Actually render images |
129,187 | 14.03.2019 12:33:22 | 14,400 | 3f68f07ac584e4a84f8b41fe8cc3dc7967f1ac11 | [native] ComposedMessage | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/composed-message.react.js",
"diff": "+// @flow\n+\n+import type {\n+ ChatMessageInfoItemWithHeight,\n+} from './message-list-container.react';\n+import { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\n+import { asser... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] ComposedMessage |
129,187 | 14.03.2019 12:44:55 | 14,400 | 1e614e18d7083b107879cba09516c055e9f1e067 | [native] RoundedMessageContainer
Needs to be recalculated within `TextMessage` so that the corners are preserved in the `Tooltip`. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -14,6 +14,7 @@ import Icon from 'react-native-vector-icons/Feather';\nimport { stringForUser } from 'lib/shared/user-utils';\nimport FailedSend from './fai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] RoundedMessageContainer
Needs to be recalculated within `TextMessage` so that the corners are preserved in the `Tooltip`. |
129,187 | 14.03.2019 13:09:01 | 14,400 | fe5b4a363dcc06481a5690d67b6616c89aa654f0 | [native] Use ComposedMessage from MultimediaMessage | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -5,10 +5,11 @@ import type {\n} from './message-list-container.react';\nimport { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\nimport { a... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use ComposedMessage from MultimediaMessage |
129,187 | 14.03.2019 13:21:34 | 14,400 | 45a1519bb2cd9f7619e191278e7cf90bf954ddef | [native] Add spacing between images | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -6,6 +6,7 @@ import type {\nimport { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\nimport { messageTypes } from 'lib/types/message-ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add spacing between images |
129,187 | 14.03.2019 13:36:56 | 14,400 | 5adc4b75adbedb190018e06de33678d374005629 | [lib] Call unshimMessageInfos from freshMessageStore | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -113,7 +113,8 @@ function freshMessageStore(\ncurrentAsOf: number,\nthreadInfos: {[threadID: string]: RawThreadInfo},\n): MessageStore {\n- const orderedMessageInfos =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Call unshimMessageInfos from freshMessageStore |
129,187 | 14.03.2019 13:47:47 | 14,400 | aa5b1e711e61823904767428730be120ae37c8ba | [lib] Replace upload URIs for Android localhost | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -595,6 +595,8 @@ function combineTruncationStatuses(\n}\n}\n+const localhostRegex = /^http:\\/\\/localhost/;\n+\nfunction shimUnsupportedRawMessageInfos(\nrawMessageInfos: $Re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Replace upload URIs for Android localhost |
129,187 | 14.03.2019 16:53:03 | 14,400 | 4e1e5c28ffa19a79b7855cc7309c59e99c36be7d | [native] Always request iOS device token on first run
This can change without getting updated in Redux, such as if an iOS backup is restored to a new phone. | [
{
"change_type": "MODIFY",
"old_path": "native/push/ios.js",
"new_path": "native/push/ios.js",
"diff": "@@ -5,14 +5,18 @@ import NotificationsIOS from 'react-native-notifications';\ntype PushPermissions = { alert?: bool, badge?: bool, sound?: bool };\nlet currentlyActive = false;\n+let firstRun = tr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Always request iOS device token on first run
This can change without getting updated in Redux, such as if an iOS backup is restored to a new phone. |
129,187 | 14.03.2019 18:42:05 | 14,400 | e477777d1f31577821f1feca7c2674df578e4709 | [native] Store screen dimensions in Redux | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -86,6 +86,7 @@ import { AppRouteName } from './navigation/route-names';\nimport MessageStorePruner from './chat/message-store-pruner.react';\nimport DisconnectedBarVisibilityHandler\nfrom './... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Store screen dimensions in Redux |
129,187 | 14.03.2019 19:13:23 | 14,400 | 6ef25752b36aac5f3c69b2532ac259896b71e768 | [native] Convert business logic to use Redux dimensions | [
{
"change_type": "MODIFY",
"old_path": "native/account/forgot-password-panel.react.js",
"new_path": "native/account/forgot-password-panel.react.js",
"diff": "@@ -28,7 +28,10 @@ import {\nvalidEmailRegex,\n} from 'lib/shared/account-regexes';\n-import { TextInput, usernamePlaceholder } from './modal-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert business logic to use Redux dimensions |
129,187 | 14.03.2019 20:26:42 | 14,400 | 2921306afa45eabf16f9d9121f6506582164caa0 | [native] Fix Tooltip ref mechanism
Broken by Redux `connect` wrapping | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -62,7 +62,7 @@ type Props = {\nsetActiveAlert: (activeAlert: bool) => void,\nopacityValue: Animated.Value,\nonePasswordSupported: bool,\n- innerRef: (logInPa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Tooltip ref mechanism
Broken by Redux `connect` wrapping |
129,187 | 14.03.2019 20:29:11 | 14,400 | 3ba7444dd60ea525f6372b917d65c60bb4680daa | [native] Limit ComposedMessage width to 80% | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/composed-message-width.js",
"diff": "+// @flow\n+\n+import type { Dimensions } from '../types/dimensions';\n+\n+import { createSelector } from 'reselect';\n+\n+import { dimensionsSelector } from '../selectors/dimension-selectors';\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Limit ComposedMessage width to 80% |
129,187 | 14.03.2019 20:58:07 | 14,400 | 8a33f4f81f15c97c2817d4aafb3f7e1b8accd254 | [native] Calculate height of MultimediaMessage | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -7,7 +7,7 @@ import { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\nimport { messageTypes } from 'lib/types/message-types';\nimport t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Calculate height of MultimediaMessage |
129,187 | 14.03.2019 21:16:19 | 14,400 | 125fc76ed46b658122f3d47286cca16bd6ff97ac | [native] Fix layout bugs in MultimediaMessage | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -134,7 +134,7 @@ class MultimediaMessage extends React.PureComponent<Props, State> {\n} else if (messageInfo.media.length === 4) {\ncontentHeight = com... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix layout bugs in MultimediaMessage |
129,187 | 14.03.2019 21:52:44 | 14,400 | 96a11cff7713aeecfc3b490acd8d3d2260f84a10 | [native] Attempt to refetch unfetched MultimediaMessage images after reconnecting | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -8,6 +8,10 @@ import { messageTypes } from 'lib/types/message-types';\nimport type { Media } from 'lib/types/media-types';\nimport type { ImageStyle } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Attempt to refetch unfetched MultimediaMessage images after reconnecting |
129,187 | 15.03.2019 11:13:43 | 14,400 | c355d9b0ab95f06171eedfd4518bb97a3e5a6834 | [server] Add Cache-Control header to uploadDownloadResponder | [
{
"change_type": "MODIFY",
"old_path": "server/src/uploads/uploads.js",
"new_path": "server/src/uploads/uploads.js",
"diff": "@@ -65,7 +65,8 @@ async function uploadDownloadResponder(\nthrow new ServerError('invalid_parameters');\n}\nconst { content, mime } = await fetchUpload(viewer, uploadID, secr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add Cache-Control header to uploadDownloadResponder |
129,187 | 15.03.2019 11:33:09 | 14,400 | 8d7ac42c1707811ca3bd3205288628076f43f4b4 | [server] Use util.promisify instead of denodeify | [
{
"change_type": "DELETE",
"old_path": "server/flow-typed/npm/denodeify_vx.x.x.js",
"new_path": null,
"diff": "-// flow-typed signature: 70f753186153eda65067c154004c031d\n-// flow-typed version: <<STUB>>/denodeify_v^1.2.1/flow_v0.89.0\n-\n-/**\n- * This is an autogenerated libdef stub for:\n- *\n- *... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use util.promisify instead of denodeify |
129,187 | 15.03.2019 12:02:26 | 14,400 | 77aecd8c79a7d308fd7eeadf79fb7326df19304e | [server] Migration to add image size to uploads table | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "},\n\"dependencies\": {\n\"apn\": \"^2.2.0\",\n+ \"buffer-image-size\": \"^0.6.4\",\n\"common-tags\": \"^1.7.2\",\n\"cookie-parser\": \"^1.4.3\",\n\"dateformat\": \"^3.0.3\",\n"
},
{
"ch... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Migration to add image size to uploads table |
129,187 | 15.03.2019 12:06:57 | 14,400 | d3e744f03cdd99200163966ec864fc7a1df22320 | [server] Specify dimensions when uploading new photos | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/flow-typed/npm/buffer-image-size_vx.x.x.js",
"diff": "+// flow-typed signature: 3e61568f51105d10e2ba32525c104d45\n+// flow-typed version: <<STUB>>/buffer-image-size_v0.6.4/flow_v0.89.0\n+\n+/**\n+ * This is an autogenerated libdef stub fo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Specify dimensions when uploading new photos |
129,187 | 15.03.2019 15:46:28 | 14,400 | 0175b78e118f1848ce17449ce4bb87f481bc3085 | Move Dimensions type to lib | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "import PropTypes from 'prop-types';\n+export type Dimensions = {|\n+ height: number,\n+ width: number,\n+|};\n+\n+export const dimensionsPropType = PropTypes.shape({\n+ height: PropTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move Dimensions type to lib |
129,187 | 15.03.2019 16:37:12 | 14,400 | 792089f7169a46001207726cb951895e18c1c894 | Include Dimensions in Media | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -18,6 +18,7 @@ export type Media = {|\nid: string,\nuri: string,\ntype: MediaType,\n+ dimensions: Dimensions,\n|};\nexport const mediaTypePropType = PropTypes.oneOf([ \"photo\", \"v... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include Dimensions in Media |
129,187 | 15.03.2019 17:06:13 | 14,400 | d284de97dcfbd23ea45a40b7ac5aa109a2a7d88a | [lib] Hack to hardcode dimensions of first four photo uploads
This is ugly but it's easy and it works and I can remove it later. | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/unshim-utils.js",
"new_path": "lib/shared/unshim-utils.js",
"diff": "@@ -8,6 +8,16 @@ import {\n} from '../types/message-types';\nimport _mapValues from 'lodash/fp/mapValues';\n+import invariant from 'invariant';\n+\n+// Four photos were uploaded be... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Hack to hardcode dimensions of first four photo uploads
This is ugly but it's easy and it works and I can remove it later. |
129,187 | 15.03.2019 18:10:16 | 14,400 | c53b3527d06ed33df2aeb6e6fd6968bf280ba85b | [server] Include dimensions in fetchMedia
Forgot to add this because the typechecker didn't notice it | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/upload-fetchers.js",
"new_path": "server/src/fetchers/upload-fetchers.js",
"diff": "@@ -42,7 +42,7 @@ async function fetchMedia(\nmediaIDs: $ReadOnlyArray<string>,\n): Promise<$ReadOnlyArray<Media>> {\nconst query = SQL`\n- SELECT id, secre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include dimensions in fetchMedia
Forgot to add this because the typechecker didn't notice it |
129,187 | 15.03.2019 18:22:31 | 14,400 | 4a69ac80563dc208936e0d10c202d06e1755f03b | [native] Use dimensions from MultimediaMessageInfo instead of calculating | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "// @flow\n-import type {\n- ChatMessageInfoItemWithHeight,\n-} from './message-list-container.react';\n+import type { ChatMessageInfoItemWithHeight } from './... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use dimensions from MultimediaMessageInfo instead of calculating |
129,187 | 15.03.2019 19:10:01 | 14,400 | ff1d7027d90c931bd33d0985279eca92e8f87dea | [native] Use FastImage in MultimediaMessage | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": ".*/Libraries/polyfills/.*\n.*/node_modules/redux-persist/lib/index.js\n+.*/node_modules/react-native-fast-image/src/index.js.flow\n; Ignore metro\n.*/node_modules/metro/.*\n"
},
{
"change_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use FastImage in MultimediaMessage |
129,187 | 15.03.2019 19:56:40 | 14,400 | f99a7889ee5c6a0c9e0397ed75d18e6ce332f308 | [native] Fix own short text message alignment bug | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -95,7 +95,7 @@ class ComposedMessage extends React.PureComponent<Props> {\n<View style={containerStyle}>\n{authorName}\n<View style={[ styles.content, alig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix own short text message alignment bug |
129,187 | 15.03.2019 20:18:44 | 14,400 | dd410e62d0bf2d6d3b88aacfa570f097caa7c477 | [native] Show loading indicator on per-Multimedia basis | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -15,7 +15,6 @@ import {\nStyleSheet,\nTouchableWithoutFeedback,\nView,\n- ActivityIndicator,\n} from 'react-native';\nimport PropTypes from 'prop-types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show loading indicator on per-Multimedia basis |
129,187 | 15.03.2019 21:05:14 | 14,400 | 96d9e5608f2732b8bd61bdf4dd3e6ce4360b96c9 | [native] Retry Multimedia load after reconnecting | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia.react.js",
"new_path": "native/chat/multimedia.react.js",
"diff": "import { type Media, mediaPropType } from 'lib/types/media-types';\nimport type { ImageStyle } from '../types/styles';\nimport type { LoadingStatus } from 'lib/types/load... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Retry Multimedia load after reconnecting |
129,187 | 16.03.2019 13:23:08 | 14,400 | e257aedd44f43a937caf4373f96c715360b64e6f | [server] Get rid of file-type
Only needed from `lib` side. | [
{
"change_type": "DELETE",
"old_path": "server/flow-typed/npm/file-type_vx.x.x.js",
"new_path": null,
"diff": "-// flow-typed signature: f49f546a028646c3de3ad98d746dd7ef\n-// flow-typed version: <<STUB>>/file-type_v^10.6.0/flow_v0.78.0\n-\n-/**\n- * This is an autogenerated libdef stub for:\n- *\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Get rid of file-type
Only needed from `lib` side. |
129,187 | 17.03.2019 18:13:51 | 14,400 | 9277badebdb06f586b8da35426081dc1e92e35db | [server] Fix fetchMessageInfos to work with image uploads
The counting mechanism wasn't considering the joined `uploads` rows. | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/message-fetchers.js",
"new_path": "server/src/fetchers/message-fetchers.js",
"diff": "@@ -409,9 +409,14 @@ async function fetchMessageInfos(\nSELECT x.id, x.content, x.time, x.type, x.user AS creatorID,\nx.creation, u.username AS creator, x... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix fetchMessageInfos to work with image uploads
The counting mechanism wasn't considering the joined `uploads` rows. |
129,187 | 19.03.2019 11:52:48 | 14,400 | 8bb2fbe277d0d65de901716f0c9863f388139047 | [native] Don't reload Multimedia if already loaded | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia.react.js",
"new_path": "native/chat/multimedia.react.js",
"diff": "import { type Media, mediaPropType } from 'lib/types/media-types';\nimport type { ImageStyle } from '../types/styles';\n-import type { LoadingStatus } from 'lib/types/loa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't reload Multimedia if already loaded |
129,187 | 19.03.2019 13:43:57 | 14,400 | 83ab8733c726d915f5450a1064470826de748253 | [native] Pass navigate function to MultimediaMessageMultimedia | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-thread-button.react.js",
"new_path": "native/chat/compose-thread-button.react.js",
"diff": "// @flow\n-import type { NavigationParams } from 'react-navigation';\n+import type { Navigate } from '../navigation/route-names';\n-import React fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Pass navigate function to MultimediaMessageMultimedia |
129,187 | 18.03.2019 23:41:40 | 14,400 | cad871d7afa7ddfc5d786d81c05235340b848410 | [native] replaceChatRoute
Simplifies a good bit of navigation logic. | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-setup.js",
"new_path": "native/navigation/navigation-setup.js",
"diff": "@@ -13,6 +13,7 @@ import type {\nNavigationRouter,\nNavigationRoute,\nNavigationTransitionProps,\n+ NavigationStateRoute,\n} from 'react-navigation';\nimport ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] replaceChatRoute
Simplifies a good bit of navigation logic. |
129,187 | 20.03.2019 13:33:32 | 14,400 | e5e5450a4dbce94cb6bb01f2bfec5270b0e4c119 | [native] XCode changed some stuff after linking FastImage | [
{
"change_type": "MODIFY",
"old_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"new_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"diff": "};\nobjectVersion = 46;\nobjects = {\n+\n/* Begin PBXBuildFile section */\n00C302E51ABCBA2D00DB3ED1 /* libRCTActionSheet.a in Frameworks */ = ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] XCode changed some stuff after linking FastImage |
129,187 | 20.03.2019 14:04:41 | 14,400 | 5aed43d5f13df00326f7e6d43454b55603c04b2e | [native] Make horizontal/vertical margin in MultimediaMessage image grid match | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -162,8 +162,8 @@ class MultimediaMessage extends React.PureComponent<Props> {\n{this.renderImage(two, styles.topRightImage)}\n</View>\n<View style={sty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make horizontal/vertical margin in MultimediaMessage image grid match |
129,187 | 20.03.2019 16:45:39 | 14,400 | f33427156256d5d9c69b6ef1924435869cc10e59 | [native] MultimediaModal
I took some time to simplify both the `renderContent` and `multimediaMessageContentHeights` logic. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "import { type Media, mediaPropType } from 'lib/types/media-types';\nimport type { ImageStyle } from '../types/styles';\n-import type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] MultimediaModal
I took some time to simplify both the `renderContent` and `multimediaMessageContentHeights` logic. |
129,187 | 21.03.2019 13:31:50 | 14,400 | 49dedcacfe4155014b1f057b8dbdf70e45e53fe5 | [native] Useful remainders of react-navigation-fluid-transitions exploration | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -5,7 +5,7 @@ import type {\nNavigationStateRoute,\n} from 'react-navigation';\n-import React from 'react';\n+import * as React from 'react';\nimport { Platform, StyleSheet } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Useful remainders of react-navigation-fluid-transitions exploration |
129,187 | 21.03.2019 16:21:33 | 14,400 | 0cbf2bf70a8c988f86c9b0ced3b638239bd7db7b | [native] Add second StackNavigator layer for lightbox
Will convert this into a custom navigator next. | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-setup.js",
"new_path": "native/navigation/navigation-setup.js",
"diff": "@@ -70,6 +70,7 @@ import {\n} from '../utils/navigation-utils';\nimport {\nAppRouteName,\n+ TabNavigatorRouteName,\nComposeThreadRouteName,\nDeleteThreadRoute... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add second StackNavigator layer for lightbox
Will convert this into a custom navigator next. |
129,187 | 26.03.2019 11:57:51 | 14,400 | 2bd39becade8d656a4cfb45548ac6bd17563086c | [native] LightboxNavigator | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/core_v3.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/core_v3.x.x.js",
"diff": "@@ -219,6 +219,7 @@ declare module '@react-navigation/core' {\n*/\nindex: number,\nroutes: Array<NavigationRoute>,\n+ isTran... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] LightboxNavigator |
129,187 | 26.03.2019 15:36:51 | 14,400 | e7e406767869c352923f10fa11d539121ece1348 | Calculate MultimediaModal image dimensions | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "import PropTypes from 'prop-types';\n-export type Dimensions = {|\n+export type Dimensions = $ReadOnly<{|\nheight: number,\nwidth: number,\n-|};\n+|}>;\nexport const dimensionsPropType... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Calculate MultimediaModal image dimensions |
129,187 | 27.03.2019 10:55:54 | 14,400 | 08a334eab7e300faa4a4391405e530b943ce9d12 | [native] Disable MessageList scroll when showing TextMessage Tooltip | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -54,6 +54,7 @@ type Props = {|\n|};\ntype State = {|\nfocusedMessageKey: ?string,\n+ scrollDisabled: bool,\n|};\nclass MessageList extends React.PureComponent<Prop... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Disable MessageList scroll when showing TextMessage Tooltip |
129,187 | 27.03.2019 11:47:08 | 14,400 | d01ebaf5e0395782dfdfab41ebc809150477e75d | [native] Make status bar white in MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -23,6 +23,7 @@ import {\ncontentVerticalOffset,\n} from '../selectors/dimension-selectors';\nimport Multimedia from './multimedia.react';\n+import Connec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make status bar white in MultimediaModal |
129,187 | 27.03.2019 11:48:02 | 14,400 | 4aad4cfd4857026c5bb39732e80048bc8dbc245d | [native] Use absolute positioning for MultimediaModal Multimedia | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -51,13 +51,20 @@ class MultimediaModal extends React.PureComponent<Props> {\nscreenDimensions: dimensionsPropType.isRequired,\n};\n+ get screenDimensions... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use absolute positioning for MultimediaModal Multimedia |
129,187 | 27.03.2019 11:59:15 | 14,400 | 7b455a3ac2792dcedb541e9e828c0c956513377b | [native] Ignore LightboxNavigator in activeTab and activeThread | [
{
"change_type": "MODIFY",
"old_path": "native/selectors/nav-selectors.js",
"new_path": "native/selectors/nav-selectors.js",
"diff": "@@ -60,11 +60,11 @@ const baseCreateActiveTabSelector =\nreturn false;\n}\nconst appRoute = assertNavigationRouteNotLeafNode(currentRootSubroute);\n- const currentApp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Ignore LightboxNavigator in activeTab and activeThread |
129,187 | 27.03.2019 14:59:58 | 14,400 | 999c5414f70dd7772d86263840320834a1028504 | [native] Animate MultimediaModal opacity | [
{
"change_type": "MODIFY",
"old_path": "native/media/lightbox-navigator.react.js",
"new_path": "native/media/lightbox-navigator.react.js",
"diff": "@@ -52,12 +52,12 @@ function createLightboxNavigator(\n);\n}\n-type LightboxProps = {|\n+type Props = {|\nnavigation: NavigationScreenProp<NavigationSta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Animate MultimediaModal opacity |
129,187 | 27.03.2019 16:42:28 | 14,400 | 3b6eb7b19bf5b9809a0c315649d14e91a6c91650 | [native] Interpolate Multimedia position in MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -24,23 +24,35 @@ class MultimediaMessageMultimedia extends React.PureComponent<Props> {\nmedia: mediaPropType.isRequired,\nnaviga... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Interpolate Multimedia position in MultimediaModal |
129,187 | 27.03.2019 17:04:27 | 14,400 | d4467fea51e530ef6ea27df03939aeb742823968 | [native] Drop MultimediaModal's Multimedia's opacity in last 10% of animation | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -113,8 +113,12 @@ class MultimediaModal extends React.PureComponent<Props> {\nconst { position } = this.props.transitionProps;\nconst { index } = this.pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Drop MultimediaModal's Multimedia's opacity in last 10% of animation |
129,187 | 27.03.2019 17:32:07 | 14,400 | 565473464a3967d91de71001920b4da449174b54 | [native] Update Multimedia layout to improve performance | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -31,7 +31,7 @@ class MultimediaMessageMultimedia extends React.PureComponent<Props> {\nreturn (\n<TouchableWithoutFeedback onPres... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update Multimedia layout to improve performance |
129,187 | 27.03.2019 17:48:29 | 14,400 | 053736806ad0cdb7f3273a9834846e9356dc5ff6 | [native] Ignore prevTransitionProps in LightboxNavigator | [
{
"change_type": "MODIFY",
"old_path": "native/media/lightbox-navigator.react.js",
"new_path": "native/media/lightbox-navigator.react.js",
"diff": "@@ -52,11 +52,11 @@ function createLightboxNavigator(\n);\n}\n-type Props = {|\n+type Props = $ReadOnly<{|\nnavigation: NavigationScreenProp<NavigationS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Ignore prevTransitionProps in LightboxNavigator |
129,187 | 27.03.2019 18:45:22 | 14,400 | 8048d79f6fa71cc95ed9a47b8d62935933c59dc4 | [native] Add close button to MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -20,8 +20,10 @@ import {\nStyleSheet,\nTouchableWithoutFeedback,\nAnimated,\n+ TouchableHighlight,\n} from 'react-native';\nimport PropTypes from 'prop-t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add close button to MultimediaModal |
129,187 | 27.03.2019 20:23:25 | 14,400 | 7df3cd245a64fbe38082850a0e69f790c4df63a6 | [native] Clip the transitioning Multimedia to within the MessageList | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -8,6 +8,7 @@ import type { FetchMessageInfosPayload } from 'lib/types/message-types';\nimport type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Clip the transitioning Multimedia to within the MessageList |
129,187 | 27.03.2019 23:17:26 | 14,400 | 95740ae06ede9ad182c29b7863a8ec827ee92fe1 | [native] Make MultimediaModal close button actually usable | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -21,7 +21,7 @@ import {\nStyleSheet,\nTouchableWithoutFeedback,\nAnimated,\n- TouchableHighlight,\n+ TouchableOpacity,\nPlatform,\n} from 'react-native';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make MultimediaModal close button actually usable |
129,187 | 27.03.2019 23:28:00 | 14,400 | 6b107c3bde5795f08acfff473cfadb6f5bc933d7 | [native] Only use light status bar while MultimediaModal is active | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -174,6 +174,11 @@ class MultimediaModal extends React.PureComponent<Props> {\n};\n}\n+ get isActive() {\n+ const { index } = this.props.scene;\n+ return ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Only use light status bar while MultimediaModal is active |
129,187 | 29.03.2019 16:57:23 | 14,400 | 97d37ad0a941a6ea39b7eee19497ae0806831715 | [native] Pinching and panning the MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -26,6 +26,11 @@ import {\n} from 'react-native';\nimport PropTypes from 'prop-types';\nimport Icon from 'react-native-vector-icons/Feather';\n+import {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Pinching and panning the MultimediaModal |
129,187 | 29.03.2019 18:10:33 | 14,400 | 19ea1670e1539636d0f0366e879fc33e4d8aaa4d | [native] Handle variable contentVerticalOffset
Also simplify some logic in MultimediaModal with the now-necessary center variables. | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -47,7 +47,7 @@ import { connect } from 'lib/utils/redux-utils';\nimport {\ndimensionsSelector,\n- contentVerticalOffset,\n+ contentVerticalOffsetSele... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Handle variable contentVerticalOffset
Also simplify some logic in MultimediaModal with the now-necessary center variables. |
129,187 | 29.03.2019 18:54:03 | 14,400 | 3f5910a9e2029048565f54d659a5ebd86022248b | [native] Allow non-portrait orientation in MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -147,6 +147,7 @@ android {\n}\ndependencies {\n+ implementation project(':react-native-orientation-locker')\nimplementation project(':react-native-fast-image')\ncompil... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Allow non-portrait orientation in MultimediaModal |
129,187 | 29.03.2019 19:21:03 | 14,400 | 72af7b9f71f25679ad96ce7545aac16e467178e3 | [native] Fix react-native-gesture-handler on Android | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/java/org/squadcal/MainActivity.java",
"new_path": "native/android/app/src/main/java/org/squadcal/MainActivity.java",
"diff": "@@ -6,6 +6,10 @@ import android.os.Bundle;\nimport android.content.Intent;\nimport android.content.res.Con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix react-native-gesture-handler on Android |
129,187 | 29.03.2019 22:20:25 | 14,400 | c28be5798b9b771fa23650fb2003ca1ad62fbc55 | [native] Recenter MultimediaModal after gestures | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -21,6 +21,7 @@ import {\nStyleSheet,\nTouchableWithoutFeedback,\nAnimated,\n+ Easing,\nTouchableOpacity,\n} from 'react-native';\nimport PropTypes from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Recenter MultimediaModal after gestures |
129,187 | 30.03.2019 01:39:11 | 14,400 | a9bb25593b8ff419522ae74dfa765bffd1663738 | [native] Downgrade to | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"react-native-notifications\": \"git+https://git@github.com/ashoat/react-native-notifications.git\",\n\"react-native-onepassword\": \"^1.0.6\",\n\"react-native-orientation-locker\": \"^1.1.5\",... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Downgrade to react-native-screens@1.0.0-alpha.17
https://github.com/kmagiera/react-native-screens/issues/61 |
129,187 | 30.03.2019 01:56:45 | 14,400 | 81d383cf67a1d35d86d54b6b1378921c173f282c | [native] Fix some ref cases broken by earlier commit
was the culprit | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "@@ -36,6 +36,7 @@ type Props = {|\nopacityValue: Animated.Value,\nforgotPasswordLinkOpacity: Animated.Value,\nlogInState: StateContainer<Log... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix some ref cases broken by earlier commit
6ef25752b36aac5f3c69b2532ac259896b71e768 was the culprit |
129,187 | 30.03.2019 02:07:15 | 14,400 | 8c134c5609d06db2eb4a9afe29dddde95d57a67d | [native] Use this.props in MessageListContainer threadInfo comparison
Otherwise we can get in an infinite loop because prevProps will never have the updated value | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -161,7 +161,7 @@ class MessageListContainer extends React.PureComponent<Props, State> {\n}\ncomponentDidUpdate(prevProps: Props) {\n- const old... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use this.props in MessageListContainer threadInfo comparison
Otherwise we can get in an infinite loop because prevProps will never have the updated value |
129,187 | 01.04.2019 14:27:01 | 14,400 | 56f6215a9e24b5032ed28810b7cbd4b1cc92c63e | [native] Use simultaneousHandlers in MultimediaModal
Enables pan/pinch interplay on Android. | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -95,6 +95,7 @@ class MultimediaModal extends React.PureComponent<Props> {\ncenterX = new Animated.Value(0);\ncenterY = new Animated.Value(0);\n+ pinchHan... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use simultaneousHandlers in MultimediaModal
Enables pan/pinch interplay on Android. |
129,187 | 01.04.2019 14:32:51 | 14,400 | 3c95fd495debfdcbaa2180ae74390f65b6ea0b9b | [native] Hack to get around incorrect focal values on Android | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -23,6 +23,7 @@ import {\nAnimated,\nEasing,\nTouchableOpacity,\n+ Platform,\n} from 'react-native';\nimport PropTypes from 'prop-types';\nimport Icon fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Hack to get around incorrect focal values on Android
https://github.com/kmagiera/react-native-gesture-handler/issues/546 |
129,187 | 01.04.2019 15:19:12 | 14,400 | 7c9445922cc223671892bca62fa11fa6472188a3 | [native] Only reset MultimediaModal's curNum constants after recenter finishes
This allows pan and pinch handlers to call `recenter` at the same time without issue. | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -522,35 +522,39 @@ class MultimediaModal extends React.PureComponent<Props> {\neasing: Easing.out(Easing.ease),\n};\nif (nextScale !== this.curScaleNum) ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Only reset MultimediaModal's curNum constants after recenter finishes
This allows pan and pinch handlers to call `recenter` at the same time without issue. |
129,187 | 01.04.2019 16:25:31 | 14,400 | 9a30f6e1167d6292600a0ac32958a0c39c7b3e70 | [native] Fix MessageListContainer setState recursion loop
Diff Redux with its own old state to avoid infinite nested `setState` calls. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -20,7 +20,6 @@ import type { ChatMessageInfoItemWithHeight } from './message.react';\nimport * as React from 'react';\nimport PropTypes from 'p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix MessageListContainer setState recursion loop
Diff Redux with its own old state to avoid infinite nested `setState` calls. |
129,187 | 01.04.2019 16:26:30 | 14,400 | c3eeedb9bd352f9b9f11ad5859875cf7e70c1a05 | [lib] Avoid changing threadStore in updateActivityActionTypes.success | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -325,15 +325,24 @@ export default function reduceThreadInfos(\n],\n};\n} else if (action.type === updateActivityActionTypes.success) {\n- const newThreadInfos = { ...sta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Avoid changing threadStore in updateActivityActionTypes.success |
129,187 | 01.04.2019 17:25:17 | 14,400 | 7a8c74391884da9a72261c6af29adb27d1e54f77 | [native] Get rid of tap-backdrop-to-close in MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -20,7 +20,6 @@ import {\nView,\nText,\nStyleSheet,\n- TouchableWithoutFeedback,\nAnimated,\nEasing,\nTouchableOpacity,\n@@ -352,9 +351,6 @@ class Multime... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of tap-backdrop-to-close in MultimediaModal |
129,187 | 01.04.2019 18:55:07 | 14,400 | 786484cd7cbb9798e38d97c71c8b0ad8351587c6 | [native] Reset focal coordinates to center in MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -413,8 +413,8 @@ class MultimediaModal extends React.PureComponent<Props> {\n}\nthis.pinchScale.setValue(1);\n- this.pinchFocalX.setValue(0);\n- this.pin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reset focal coordinates to center in MultimediaModal |
129,187 | 02.04.2019 17:32:07 | 14,400 | d1f896213f673a6dc40052f3dd814d6f6942290b | [lib] Use HTTP for CREATE_REPORT
Sockets don't even support customizable timeouts yet, so we definitely shouldn't be using them for error reports. Plus error reports commonly happen in situations where the socket is down... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/endpoints.js",
"new_path": "lib/types/endpoints.js",
"diff": "@@ -9,7 +9,8 @@ export type SocketAPIHandler = (request: APIRequest) => Promise<Object>;\nexport type Endpoint =\n| HTTPOnlyEndpoint\n| SocketOnlyEndpoint\n- | SocketSafeEndpoint;\n+ | HTT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use HTTP for CREATE_REPORT
Sockets don't even support customizable timeouts yet, so we definitely shouldn't be using them for error reports. Plus error reports commonly happen in situations where the socket is down... |
129,187 | 03.04.2019 12:05:47 | 14,400 | c3f25a266a4a582b509cca34a2bf163cec51871f | [native] Move DimensionsUpdater into new redux folder | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -87,7 +87,7 @@ import { AppRouteName } from './navigation/route-names';\nimport MessageStorePruner from './chat/message-store-pruner.react';\nimport DisconnectedBarVisibilityHandler\nfrom './... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move DimensionsUpdater into new redux folder |
129,187 | 03.04.2019 12:13:15 | 14,400 | eb9f11f8f572d83e4938755592861c4b723c5f70 | [native] Move action-types to new redux folder | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -56,7 +56,7 @@ import { createIsForegroundSelector } from '../selectors/nav-selectors';\nimport {\nnavigateToAppActionType,\nresetUserStateActionType... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move action-types to new redux folder |
129,187 | 03.04.2019 12:27:08 | 14,400 | dc1452c1f30dc790e1d98a2f3098018fb93814b2 | [native] Introduce ConnectivityUpdater and store connectivity state in Redux | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -88,6 +88,7 @@ import MessageStorePruner from './chat/message-store-pruner.react';\nimport DisconnectedBarVisibilityHandler\nfrom './navigation/disconnected-bar-visibility-handler.react';\nim... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce ConnectivityUpdater and store connectivity state in Redux |
129,187 | 03.04.2019 21:01:52 | 14,400 | cc9689a5b12ccfb60529226236ea47ff16806460 | [native] Don't pass null onPress to DefaultNotificationBody | [
{
"change_type": "MODIFY",
"old_path": "native/push/notification-body.react.js",
"new_path": "native/push/notification-body.react.js",
"diff": "import type { ImageSource } from 'react-native/Libraries/Image/ImageSource';\n-import React from 'react';\n+import * as React from 'react';\nimport { View, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't pass null onPress to DefaultNotificationBody |
129,187 | 04.04.2019 16:56:23 | 14,400 | 4e36fe0b89e99847fe361bb1829e3e35bc9409c6 | [lib] Make sure socket can close after timeout
Also includes a dumb typo fix in `reduxLogger`. | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -223,6 +223,10 @@ class InflightRequests {\nrejectAll(error: Error) {\nfor (let inflightRequest of this.data) {\n+ // Though the promise rejection below should call cl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Make sure socket can close after timeout
Also includes a dumb typo fix in `reduxLogger`. |
129,187 | 04.04.2019 17:22:46 | 14,400 | 0caada4ec8935c70235ec7aca7673480042c6ba6 | [native] Center Multimedia loading spinner | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia.react.js",
"new_path": "native/media/multimedia.react.js",
"diff": "@@ -93,6 +93,10 @@ const styles = StyleSheet.create({\n},\nspinnerContainer: {\nposition: 'absolute',\n+ top: 0,\n+ bottom: 0,\n+ left: 0,\n+ right: 0,\njustifyContent:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Center Multimedia loading spinner |
129,187 | 05.04.2019 11:01:41 | 14,400 | 28a523a495b755d4f97d5df24419fac0acb569b1 | [native] Leave vertical space for offsets in MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -489,19 +489,20 @@ class MultimediaModal extends React.PureComponent<Props> {\nconst nextScale = Math.max(this.curScaleNum, 1);\nconst { height } = this.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Leave vertical space for offsets in MultimediaModal |
129,187 | 05.04.2019 12:01:01 | 14,400 | 88f7e9899b7f5fbf7b43c97c5e58de2cbb30f1ab | [native] Simplify centerDeltaX/centerDeltaY calculations in MultimediaModal
Also extracts out `horizontalPanSpace`/`verticalPanSpace`, so we can use them elsewhere. | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -452,67 +452,66 @@ class MultimediaModal extends React.PureComponent<Props> {\nthis.recenter();\n}\n- // Figures out what we need to add to this.curX to ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Simplify centerDeltaX/centerDeltaY calculations in MultimediaModal
Also extracts out `horizontalPanSpace`/`verticalPanSpace`, so we can use them elsewhere. |
129,187 | 05.04.2019 15:49:54 | 14,400 | cd54331489ec1b2436feaadb002323598bf568b5 | [native] react-native-reanimated | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -147,6 +147,7 @@ android {\n}\ndependencies {\n+ implementation project(':react-native-reanimated')\nimplementation project(':react-native-orientation-locker')\nimplem... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] react-native-reanimated |
129,187 | 06.04.2019 01:15:32 | 14,400 | 2fa5f56e3f82bbe07716318f274732e1c42eeade | [native] Redo MultimediaModal animations using Reanimated's declarative style
So much smoother! | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -40,6 +40,96 @@ import {\n} from '../selectors/dimension-selectors';\nimport Multimedia from './multimedia.react';\nimport ConnectedStatusBar from '../co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Redo MultimediaModal animations using Reanimated's declarative style
So much smoother! |
129,187 | 06.04.2019 02:58:42 | 14,400 | 16584e82510458a049571dd1e617e2a5ecaf1317 | [native] Fling MultimediaModal | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -64,6 +64,7 @@ const {\nstopClock,\nclockRunning,\ntiming,\n+ decay,\n} = Animated;\nfunction scaleDelta(value: Value, gestureActive: Value) {\n@@ -131,6... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fling MultimediaModal |
129,187 | 07.04.2019 22:55:00 | 14,400 | 73ee646f79dbcbe5260449b80927e30834ddd5e1 | [native] MultimediaModal now supports double-tap-to-zoom | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -26,6 +26,7 @@ import PropTypes from 'prop-types';\nimport {\nPinchGestureHandler,\nPanGestureHandler,\n+ TapGestureHandler,\nState as GestureState,\n} f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] MultimediaModal now supports double-tap-to-zoom |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.