author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 06.11.2018 10:14:18 | 18,000 | 2e96b00700cde7e3ee767e50857368cbd228cf9f | [native] Only update badge count while connected
Otherwise we may be overriding a recently updated badge count (from a notif) with a stale value from Redux. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -19,6 +19,10 @@ import {\nnotifPermissionAlertInfoPropType,\n} from './push/alerts';\nimport type { RawMessageInfo } from 'lib/types/message-types';\n+import {\n+ type ConnectionInfo,\n+ conn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Only update badge count while connected
Otherwise we may be overriding a recently updated badge count (from a notif) with a stale value from Redux. |
129,187 | 06.11.2018 10:46:44 | 18,000 | 1fc6ea6e40c8356bf6b6dfb65995215c77d78e79 | Fix accidental double-state-check behavior
And also set up state check to occur once every three minutes at max. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/session-types.js",
"new_path": "lib/types/session-types.js",
"diff": "@@ -11,10 +11,10 @@ import type { CalendarQuery } from './entry-types';\nimport PropTypes from 'prop-types';\nexport const cookieLifetime = 30*24*60*60*1000; // in milliseconds\n-/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix accidental double-state-check behavior
And also set up state check to occur once every three minutes at max. |
129,187 | 06.11.2018 11:25:45 | 18,000 | 7f008e5864858ad59eab51197d77783e872cd363 | State check mechanism for extraneous threads/entries on client
This provides the server a way to tell the client to delete threads or entries it isn't seeing on its end. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -689,19 +689,34 @@ function reduceEntryInfos(\nconst checkStateRequest = action.payload.serverRequests.find(\ncandidate => candidate.type === serverRequestTypes.CHECK_STAT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | State check mechanism for extraneous threads/entries on client
This provides the server a way to tell the client to delete threads or entries it isn't seeing on its end. |
129,187 | 06.11.2018 14:34:20 | 18,000 | ca36c6b207e2fc57a51cd487a4d86cbaa10df0fb | CalendarQueryHandler
Handles non-user-initiated `UPDATE_CALENDAR_QUERY` calls. | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/nav-selectors.js",
"new_path": "lib/selectors/nav-selectors.js",
"diff": "@@ -23,10 +23,24 @@ import {\nnonThreadCalendarFiltersSelector,\n} from './calendar-filter-selectors';\n+function timeUntilCalendarRangeExpiration(\n+ lastUserInteractionCa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | CalendarQueryHandler
Handles non-user-initiated `UPDATE_CALENDAR_QUERY` calls. |
129,187 | 07.11.2018 10:48:55 | 18,000 | 8895268ec92f48d6203299b087db0054b974ad2d | Get logInExtraInfo directly from store in resolveInvalidatedCookie | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -37,7 +37,7 @@ import type {\nDispatchActionPayload,\nDispatchActionPromise,\n} from '../utils/action-utils';\n-import type { LogInExtraInfo, LogOutResult } from '../types/accou... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get logInExtraInfo directly from store in resolveInvalidatedCookie |
129,187 | 07.11.2018 12:58:24 | 18,000 | d32e1d1d30a7d732dc35f95dfc1327cc92d776c6 | RequestResponseHandler passes currentCalendarQuery to PROCESS_SERVER_REQUESTS | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/request-response-handler.react.js",
"new_path": "lib/socket/request-response-handler.react.js",
"diff": "@@ -17,6 +17,7 @@ import {\ntype ServerRequest,\nclientResponsePropType,\n} from '../types/request-types';\n+import type { CalendarQuery } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RequestResponseHandler passes currentCalendarQuery to PROCESS_SERVER_REQUESTS |
129,187 | 07.11.2018 13:09:10 | 18,000 | 5cd7cfb816c44a5354add5c23fe5a93e4cacc910 | Move defaultCalendarQuery to entry-types
And remove the duplicate. | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/nav-selectors.js",
"new_path": "lib/selectors/nav-selectors.js",
"diff": "@@ -5,10 +5,7 @@ import type { BaseNavInfo } from '../types/nav-types';\nimport type { RawThreadInfo } from '../types/thread-types';\nimport type { CalendarQuery } from '..... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move defaultCalendarQuery to entry-types
And remove the duplicate. |
129,187 | 07.11.2018 13:39:38 | 18,000 | 9a18b8449124d4974d3c89ebfa4956318ff5bfd9 | [lib] Include calendarQuery in REGISTER_SUCCESS | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -77,6 +77,7 @@ async function register(\nrawMessageInfos: response.rawMessageInfos,\nthreadInfos: response.cookieChange.threadInfos,\nuserInfos: response.cookieChange.userInfo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include calendarQuery in REGISTER_SUCCESS |
129,187 | 07.11.2018 13:44:54 | 18,000 | ceaf662d20618ede9c0ca2b9b612c38679cc78f2 | [lib] Always include CalendarQuery in UPDATE_CALENDAR_QUERY_SUCCESS | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -52,11 +52,12 @@ async function updateCalendarQuery(\n): Promise<CalendarQueryUpdateResult> {\nconst response = await fetchJSON('update_calendar_query', calendarQuery);\ncon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Always include CalendarQuery in UPDATE_CALENDAR_QUERY_SUCCESS |
129,187 | 07.11.2018 13:51:52 | 18,000 | 950e09d96d927e55ce14e98469780cac13b6a875 | [lib] Include CalendarQuery in STATE_SYNC payloads | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -532,7 +532,7 @@ class Socket extends React.PureComponent<Props, State> {\nconst { sessionID, type, ...actionPayload } = stateSyncMessage.payload;\nthis.props.dispatchActionPayl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include CalendarQuery in STATE_SYNC payloads |
129,187 | 07.11.2018 14:02:34 | 18,000 | 7ac75b8143ef0e7f7f3333c9218dd91d558c25f1 | Move actualizedCalendarQuery to ConnectionInfo | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/connection-reducer.js",
"new_path": "lib/reducers/connection-reducer.js",
"diff": "@@ -7,13 +7,20 @@ import {\nqueueActivityUpdatesActionType,\nactivityUpdateSuccessActionType,\nactivityUpdateFailedActionType,\n+ fullStateSyncActionType,\n+ increm... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move actualizedCalendarQuery to ConnectionInfo |
129,187 | 07.11.2018 14:32:27 | 18,000 | ebee0bef59a62b8903061b58454c84be20fff383 | Update CalendarQueryHandler logic to use actualizedCalendarQuery | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/calendar-query-handler.react.js",
"new_path": "lib/socket/calendar-query-handler.react.js",
"diff": "@@ -22,16 +22,13 @@ import {\nupdateCalendarQueryActionTypes,\nupdateCalendarQuery,\n} from '../actions/entry-actions';\n-import {\n- currentCalenda... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update CalendarQueryHandler logic to use actualizedCalendarQuery |
129,187 | 07.11.2018 14:41:31 | 18,000 | ecbec4aca86b21fc9c6133f88ff7434ad51643a0 | Move invalidation recovery to its own file to avoid require cycle | [
{
"change_type": "MODIFY",
"old_path": "native/account/native-credentials.js",
"new_path": "native/account/native-credentials.js",
"diff": "// @flow\n-import type { FetchJSON } from 'lib/utils/fetch-json';\n-import type { DispatchRecoveryAttempt } from 'lib/utils/action-utils';\n-\nimport { Platform... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move invalidation recovery to its own file to avoid require cycle |
129,187 | 07.11.2018 17:57:55 | 18,000 | ab369a55e238bddceb521570c3619b1ddb78cbae | [native] Consider calendarActive if ThreadPicker is active | [
{
"change_type": "MODIFY",
"old_path": "native/selectors/account-selectors.js",
"new_path": "native/selectors/account-selectors.js",
"diff": "@@ -7,10 +7,8 @@ import { createSelector } from 'reselect';\nimport { logInExtraInfoSelector } from 'lib/selectors/account-selectors';\n-import { createActive... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Consider calendarActive if ThreadPicker is active |
129,187 | 07.11.2018 18:01:37 | 18,000 | 1e21db0de1bc254d19950a7cc86197886b705d67 | [lib] Different error messages for each place inflightRequests can be falsey | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/activity-handler.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "@@ -102,7 +102,10 @@ class ActivityHandler extends React.PureComponent<Props> {\nactivityUpdates: $ReadOnlyArray<ActivityUpdate>\n): Promise<ActivityUpdateRespo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Different error messages for each place inflightRequests can be falsey |
129,187 | 07.11.2018 18:19:29 | 18,000 | 63f5bc97464dd4f88771525304ad3585580823b9 | [server] Fix comparison guarding sessionUpdate of calendarQuery
Should be an equality check, not a subset check. | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/entry-updaters.js",
"new_path": "server/src/updaters/entry-updaters.js",
"diff": "@@ -12,6 +12,7 @@ import { updateTypes, type CreateUpdatesResponse } from 'lib/types/update-types'\nimport type { SessionUpdate } from './session-updaters';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix comparison guarding sessionUpdate of calendarQuery
Should be an equality check, not a subset check. |
129,187 | 07.11.2018 19:31:19 | 18,000 | 4a6f84f6f391f147eff7927fd7e551ad401ae92e | MESSAGE_STORE_PRUNE action | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -10,6 +10,7 @@ import {\nmessageTypes,\ndefaultNumberPerThread,\nprocessMessagesActionType,\n+ messageStorePruneActionType,\n} from '../types/message-types';\nimport t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | MESSAGE_STORE_PRUNE action |
129,187 | 07.11.2018 20:00:51 | 18,000 | daee700479e7747a643cb42a0ba0d6411b50b5aa | [server] Early exit in updateUnreadStatus if no updates | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -295,6 +295,9 @@ async function postMessageSend(\nasync function updateUnreadStatus(\nsetUnreadPairs: $ReadOnlyArray<{| userID: string, threadID: string ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Early exit in updateUnreadStatus if no updates |
129,187 | 07.11.2018 20:39:58 | 18,000 | 0aed939208f1778b50023b21ae763ffe7a0b7e59 | [lib] Call serverEntryInfosObject before generating entry inconsistencies | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -71,6 +71,7 @@ import {\nentryID,\nrawEntryInfoWithinCalendarQuery,\nfilterRawEntryInfosByCalendarQuery,\n+ serverEntryInfosObject,\n} from '../shared/entry-utils';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Call serverEntryInfosObject before generating entry inconsistencies |
129,187 | 07.11.2018 20:26:29 | 18,000 | b4c48f0152dd224c3f109421ea4248f1f3bfa025 | codeVersion -> 23 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 22\n+ \"currentCodeVersion\": 23\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | codeVersion -> 23 |
129,187 | 08.11.2018 08:16:47 | 18,000 | 25535eab3f85d84cd42807df6b68c7d4167c195a | [lib] Avoid clearing initial platform details ClientResponse
We know this doesn't come from `queuedClientResponses` so there's no point trying to clear it from the queue. | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -115,7 +115,7 @@ class Socket extends React.PureComponent<Props, State> {\nnextClientMessageID = 0;\nlisteners: Set<SocketListener> = new Set();\npingTimeoutID: ?TimeoutID\n- in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Avoid clearing initial platform details ClientResponse
We know this doesn't come from `queuedClientResponses` so there's no point trying to clear it from the queue. |
129,187 | 08.11.2018 10:15:18 | 18,000 | 589066d0c8e79d42b77fd2d28f42c4d03d10feeb | Fix platform-specific use of defaultCalendarQuery and defaultConnectionInfo | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/connection-reducer.js",
"new_path": "lib/reducers/connection-reducer.js",
"diff": "@@ -21,6 +21,7 @@ import {\nregisterActionTypes,\n} from '../actions/user-actions';\nimport { updateCalendarQueryActionTypes } from '../actions/entry-actions';\n+im... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix platform-specific use of defaultCalendarQuery and defaultConnectionInfo |
129,187 | 08.11.2018 10:20:35 | 18,000 | 3ee309c5be35ba2578698764f3471c1f71ad871b | [lib] Add sort to daysToEntriesFromEntryInfos
Otherwise web gets reordered after first incremental state sync, since the server's order doesn't match the browser's for some reason. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -36,6 +36,7 @@ import _mapKeys from 'lodash/fp/mapKeys';\nimport _groupBy from 'lodash/fp/groupBy';\nimport _isEqual from 'lodash/fp/isEqual';\nimport _isEmpty from 'lodas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add sort to daysToEntriesFromEntryInfos
Otherwise web gets reordered after first incremental state sync, since the server's order doesn't match the browser's for some reason. |
129,187 | 09.11.2018 20:34:40 | 18,000 | 1490829a268b3bb298f053a78a37a03280b0f8d2 | [lib] APIRequestHandler | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/socket/api-request-handler.react.js",
"diff": "+// @flow\n+\n+import {\n+ clientSocketMessageTypes,\n+ serverSocketMessageTypes,\n+ type ClientSocketMessageWithoutID,\n+ type ConnectionInfo,\n+ connectionInfoPropType,\n+} from '../types/sock... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] APIRequestHandler |
129,187 | 10.11.2018 12:05:24 | 18,000 | 76bd4b472fcb818987073d64e6b8d470a9cc29d4 | [lib] Hook fetchJSON up to SocketAPIHandler | [
{
"change_type": "MODIFY",
"old_path": "lib/types/endpoints.js",
"new_path": "lib/types/endpoints.js",
"diff": "@@ -6,7 +6,27 @@ export type APIRequest = {|\n|};\nexport type SocketAPIHandler = (request: APIRequest) => Promise<Object>;\n-export const endpoint = Object.freeze({\n+// Endpoints that ca... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Hook fetchJSON up to SocketAPIHandler |
129,187 | 10.11.2018 18:29:41 | 18,000 | b199007f8e853567386989ff71cb925a14fe1073 | Server support for API requests via socket | [
{
"change_type": "MODIFY",
"old_path": "lib/types/socket-types.js",
"new_path": "lib/types/socket-types.js",
"diff": "@@ -227,6 +227,7 @@ export type MessagesServerSocketMessage = {|\n|};\nexport type APIResponseServerSocketMessage = {|\ntype: 8,\n+ responseTo: number,\npayload: Object,\n|};\nexport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Server support for API requests via socket |
129,187 | 12.11.2018 11:27:10 | 18,000 | 6f0bdf5a79bd3943ee28a0b34686f239158b7221 | [lib] endpointIsSocketOnly | [
{
"change_type": "MODIFY",
"old_path": "lib/types/endpoints.js",
"new_path": "lib/types/endpoints.js",
"diff": "@@ -12,6 +12,7 @@ export type SocketAPIHandler = (request: APIRequest) => Promise<Object>;\n// since websockets aren't able to Set-Cookie.\nexport type Endpoint =\n| SessionChangingEndpoin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] endpointIsSocketOnly |
129,187 | 12.11.2018 13:45:22 | 18,000 | e1cf531c371b0d40a455c39ad5005b5fe5a68b4c | [native] Move registerConfig to separate file
And avoid using it in defining default Redux state due to require cycle. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -45,7 +45,6 @@ import InAppNotification from 'react-native-in-app-notification';\nimport FCM, { FCMEvent } from 'react-native-fcm';\nimport SplashScreen from 'react-native-splash-screen';\n-i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move registerConfig to separate file
And avoid using it in defining default Redux state due to require cycle. |
129,187 | 12.11.2018 13:47:35 | 18,000 | 5999c064bf17fd252b875b1a98f54a4e6b0b73fc | [lib] Use DispatchActionPromise for activity updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/actions/activity-actions.js",
"diff": "+// @flow\n+\n+import type { FetchJSON } from '../utils/fetch-json';\n+import type {\n+ ActivityUpdate,\n+ ActivityUpdateSuccessPayload,\n+} from '../types/activity-types';\n+\n+const updateActivityActi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use DispatchActionPromise for activity updates |
129,187 | 12.11.2018 14:20:28 | 18,000 | 4d4cef3d919f7a1764303cc8279b54ec682fe3ae | [lib] Don't rehydrate connection status from redux-persist | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/connection-reducer.js",
"new_path": "lib/reducers/connection-reducer.js",
"diff": "// @flow\n-import type { BaseAction } from '../types/redux-types';\n+import {\n+ type BaseAction,\n+ rehydrateActionType,\n+} from '../types/redux-types';\nimport {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Don't rehydrate connection status from redux-persist |
129,187 | 12.11.2018 14:20:50 | 18,000 | cf8dd8b2f3913844872c6cd85921ad713417b16b | [server] Don't double-save serverRequestTypes.INITIAL_ACTIVITY_UPDATES | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -457,13 +457,6 @@ async function processClientResponses(\n}\n}\n- if (activityUpdates.length > 0) {\n- promises.push(activityUpdater(\n- viewer,\n- {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't double-save serverRequestTypes.INITIAL_ACTIVITY_UPDATES |
129,187 | 12.11.2018 14:22:11 | 18,000 | a4efa630ab664ce9631ad4da8963ae7d1f4472b1 | [lib] Actually instantiate APIRequestHandler in Socket component | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -56,6 +56,7 @@ import { ServerError } from '../utils/errors';\nimport { pingFrequency } from '../shared/timeouts';\nimport { promiseAll } from '../utils/promises';\nimport { Inf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Actually instantiate APIRequestHandler in Socket component |
129,187 | 13.11.2018 11:03:40 | 18,000 | 296d7645a5186bfd551d93d9d8a9368c8b3479c4 | Make createUpdates have an explicit updatesForCurrentSession input
This allow us to prevent activity updates from triggering Redis messages that trigger server socket messages about the activity update that get sent to the client. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redis-types.js",
"new_path": "lib/types/redis-types.js",
"diff": "@@ -19,9 +19,10 @@ type StartSubscriptionRedisMessage = {|\ntype: 0,\ninstanceID: string,\n|};\n-type NewUpdatesRedisMessage = {|\n+export type NewUpdatesRedisMessage = {|\ntype: 1,\nu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make createUpdates have an explicit updatesForCurrentSession input
This allow us to prevent activity updates from triggering Redis messages that trigger server socket messages about the activity update that get sent to the client. |
129,187 | 13.11.2018 15:12:39 | 18,000 | 2ed31450d3b0554d0163c6f094c3dea2cebdd294 | Get rid of clientSocketMessageTypes.ACTIVITY_UPDATES
Note: this breaks client codeVersion v23, but I only ever deployed that version to my phone. | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -25,7 +25,6 @@ import {\ntype ConnectionInfo,\ntype InitialClientSocketMessage,\ntype ResponsesClientSocketMessage,\n- type ActivityUpdatesClientSocketMessage,\ntype PingClientS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of clientSocketMessageTypes.ACTIVITY_UPDATES
Note: this breaks client codeVersion v23, but I only ever deployed that version to my phone. |
129,187 | 14.11.2018 14:47:09 | 18,000 | f91fd3cbf39e54eb1a9a8980104cff0b4ad35f2a | [lib] Increment currentAsOf timestamps while connected
Always increment these when getting a new update or message, except while disconnected. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "import type { BaseAppState, BaseAction } from '../types/redux-types';\nimport type { BaseNavInfo } from '../types/nav-types';\n+import {\n+ fullStateSyncActionType,\n+ incr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Increment currentAsOf timestamps while connected
Always increment these when getting a new update or message, except while disconnected. |
129,187 | 14.11.2018 17:26:59 | 18,000 | f1d442262309ebe21ec83d1149e4ca7ccf786b2a | [lib] Include activityUpdates in UPDATE_ACTIVITY_FAILED
Forgot to include this... | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/activity-handler.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "@@ -90,18 +90,25 @@ class ActivityHandler extends React.PureComponent<Props> {\nreturn null;\n}\n- sendActivityUpdates(\n- activityUpdates: $ReadOnlyArray<Activ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include activityUpdates in UPDATE_ACTIVITY_FAILED
Forgot to include this... |
129,187 | 14.11.2018 17:35:45 | 18,000 | 5f04a3914a63516f2e97b288a42bd4797468aa1a | Pop down a bar when native is disconnected | [
{
"change_type": "MODIFY",
"old_path": "lib/types/socket-types.js",
"new_path": "lib/types/socket-types.js",
"diff": "@@ -246,15 +246,16 @@ export type ConnectionInfo = {|\nqueuedActivityUpdates: $ReadOnlyArray<ActivityUpdate>,\nactualizedCalendarQuery: CalendarQuery,\n|};\n-export const connectionI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Pop down a bar when native is disconnected |
129,187 | 14.11.2018 18:08:56 | 18,000 | 25c7cec07a1e0dc5f87bc3b857c5c7c73eb9ae69 | [native] Flow libdef for | [
{
"change_type": "RENAME",
"old_path": "native/flow-typed/npm/react-navigation_v2.x.x.js",
"new_path": "native/flow-typed/npm/react-navigation_v3.x.x.js",
"diff": "-// flow-typed signature: 5d7fecbdc3f50450fb6a171350f15910\n-// flow-typed version: 40e6366386/react-navigation_v2.x.x/flow_>=v0.60.x\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Flow libdef for react-navigation@3.0 |
129,187 | 14.11.2018 19:32:11 | 18,000 | c5d4e045a944aec0309d90045082c05905a801c2 | Avoid long timers because RN setTimeout on Android doesn't like them | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/calendar-query-handler.react.js",
"new_path": "lib/socket/calendar-query-handler.react.js",
"diff": "@@ -30,6 +30,7 @@ type Props = {|\n// Redux state\nconnection: ConnectionInfo,\nlastUserInteractionCalendar: number,\n+ foreground: bool,\n// Redux ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Avoid long timers because RN setTimeout on Android doesn't like them |
129,187 | 14.11.2018 18:16:11 | 18,000 | 72a1777bd76e1656410c7d0319a51aee742a7319 | codeVersion -> 24 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 23\n+ \"currentCodeVersion\": 24\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | codeVersion -> 24 |
129,187 | 20.11.2018 19:52:28 | 18,000 | afd0d895611979612a279a75ba4e05975eab313d | [lib] Allow mergeNewMessages to match orphaned localIDs
If a `sendMessage` fails for some reason, we currently have no way to match up its serverID when it gets delivered. This allows us to do that. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -148,30 +148,44 @@ function mergeNewMessages(\nthreadInfos: {[threadID: string]: RawThreadInfo},\nactionType: *,\n): MessageStore {\n+ const localIDsToServerIDs: Map<s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Allow mergeNewMessages to match orphaned localIDs
If a `sendMessage` fails for some reason, we currently have no way to match up its serverID when it gets delivered. This allows us to do that. |
129,187 | 20.11.2018 21:15:35 | 18,000 | 56f38ac5f52a712f7f3c823e233e00237b77a108 | Include localID in message creation APIRequest
Message creations should be idempotent now. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/message-actions.js",
"new_path": "lib/actions/message-actions.js",
"diff": "@@ -64,9 +64,13 @@ const sendMessageActionTypes = Object.freeze({\nasync function sendMessage(\nfetchJSON: FetchJSON,\nthreadID: string,\n+ localID: string,\ntext: string,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include localID in message creation APIRequest
Message creations should be idempotent now. |
129,187 | 20.11.2018 21:46:14 | 18,000 | acfc93adc2364dfcd91e057e89c3037701ff2bd3 | [server] Move creationString function to separate file | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -34,10 +34,8 @@ import { handleAsyncPromise } from '../responders/handlers';\nimport { earliestFocusedTimeConsideredCurrent } from '../shared/focused-tim... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Move creationString function to separate file |
129,187 | 20.11.2018 22:19:16 | 18,000 | 16037289002620af86dc8c36718aa012d216e3ef | [server] Don't use reporter Viewer to create squadbot report messages | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -355,7 +355,7 @@ async function redisPublish(\nmessageInfosPerUser: {[userID: string]: $ReadOnlyArray<RawMessageInfo>},\n) {\nfor (let userID in messageI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't use reporter Viewer to create squadbot report messages |
129,187 | 20.11.2018 22:20:58 | 18,000 | 949c549731b56ee529cf102da0e063274e84cac5 | [server] Use updatesForCurrentSession "return" for entry updates
Otherwise we generate inconsistency reports while using sockets. | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/entry-updaters.js",
"new_path": "server/src/updaters/entry-updaters.js",
"diff": "@@ -241,7 +241,7 @@ async function createUpdateDatasForChangedEntryInfo(\n}));\nconst { userInfos, ...updatesResult } = await createUpdates(\nupdateDatas,\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use updatesForCurrentSession "return" for entry updates
Otherwise we generate inconsistency reports while using sockets. |
129,187 | 20.11.2018 20:45:47 | 28,800 | bdc484151a206c8a3589e6dd068c97bde1f912f1 | Include localID in entry creation APIRequest
Entry creations should be idempotent now. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -6,7 +6,7 @@ import type {\nSaveEntryInfo,\nSaveEntryResult,\nCreateEntryInfo,\n- SaveEntryPayload,\n+ CreateEntryPayload,\nDeleteEntryInfo,\nDeleteEntryPayload,\nRestoreEnt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include localID in entry creation APIRequest
Entry creations should be idempotent now. |
129,187 | 20.11.2018 22:31:44 | 28,800 | c7003d98407fb9ae2b51cd676895cf5d4973e5dc | Include localIDs in message fetch for state sync
This allows client to dedup in the case of a missed response. | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -427,70 +427,19 @@ function rawMessageInfoFromMessageData(\nid: string,\n): RawMessageInfo {\nif (messageData.type === messageTypes.TEXT) {\n- return {\n- type: messageTypes.T... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include localIDs in message fetch for state sync
This allows client to dedup in the case of a missed response. |
129,187 | 20.11.2018 23:37:08 | 28,800 | 5cb62e8375a5ba979b31ca218acf7e0a8b21f96a | [server] Make thread deletion idempotent | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -80,7 +80,7 @@ type UpdatesForCurrentSession =\n// communicating the relevant information to the client.\n| \"ignore\";\n-type ViewerInfo =\n+export type V... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make thread deletion idempotent |
129,187 | 21.11.2018 00:06:22 | 28,800 | 434abef584b532a199f239425d8a3e9ed6b90e32 | [server] Make entry deletion and restoration idempotent | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/entry-creator.js",
"new_path": "server/src/creators/entry-creator.js",
"diff": "@@ -23,8 +23,8 @@ import {\ncreateUpdateDatasForChangedEntryInfo,\n} from '../updaters/entry-updaters';\nimport { fetchEntryInfoForLocalID } from '../fetchers/e... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make entry deletion and restoration idempotent |
129,187 | 21.11.2018 16:44:41 | 28,800 | 4f7845b65fb1f31acb91762f86bc502f47c7a1fd | [lib] Don't crash if persisted store nonexistant | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/local-id-selectors.js",
"new_path": "lib/selectors/local-id-selectors.js",
"diff": "@@ -16,6 +16,7 @@ function numberFromLocalID(localID: string) {\nfunction highestLocalIDSelector(state: BaseAppState<*>): number {\nlet highestLocalIDFound = -1;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Don't crash if persisted store nonexistant |
129,187 | 21.11.2018 16:45:28 | 28,800 | c93c14fe4654492f9fcd29a1a1e14bf47b5f4674 | [lib] Fix timeout connection close behavior | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -114,7 +114,7 @@ class Socket extends React.PureComponent<Props, State> {\nsocket: ?WebSocket;\nnextClientMessageID = 0;\nlisteners: Set<SocketListener> = new Set();\n- pingTime... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix timeout connection close behavior |
129,187 | 22.11.2018 17:53:56 | 28,800 | 9ecbc028cc26c8807bd492199424a3a042b8170f | Track late responses in Redux
This is so we can show the "disconnected" bar a bit earlier. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/connection-reducer.js",
"new_path": "lib/reducers/connection-reducer.js",
"diff": "@@ -9,6 +9,7 @@ import {\nupdateConnectionStatusActionType,\nfullStateSyncActionType,\nincrementalStateSyncActionType,\n+ setLateResponseActionType,\n} from '../typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Track late responses in Redux
This is so we can show the "disconnected" bar a bit earlier. |
129,187 | 22.11.2018 23:11:37 | 28,800 | cf5ca8efb65862f017f87dff37f3a6ea956b9ee8 | [native] Use NetInfo to preemptively identify when network is down | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/AndroidManifest.xml",
"new_path": "native/android/app/src/main/AndroidManifest.xml",
"diff": "<uses-permission android:name=\"android.permission.RECEIVE_BOOT_COMPLETED\" />\n<uses-permission android:name=\"android.permission.VIBRATE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use NetInfo to preemptively identify when network is down |
129,187 | 23.11.2018 15:50:44 | 28,800 | 75cab8a73944756b098436e1bcb65b10268f1108 | [server] Fix up server delivery result format
And avoid duplicate notification row writes. | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/rescind.js",
"new_path": "server/src/push/rescind.js",
"diff": "@@ -26,7 +26,12 @@ async function rescindPushNotifs(\nconst promises = [];\nconst rescindedIDs = [];\nfor (let row of fetchResult) {\n- if (row.delivery.iosID) {\n+ const deliverie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix up server delivery result format
And avoid duplicate notification row writes. |
129,187 | 23.11.2018 16:02:04 | 28,800 | f2700b7fcd4f17832131f1ae37b78d907327f1b5 | [native] Fix up DisconnectedBar to use NetInfo.isConnected
And don't count "connecting" as a change in connection status. | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/disconnected-bar.react.js",
"new_path": "native/navigation/disconnected-bar.react.js",
"diff": "@@ -31,35 +31,35 @@ class DisconnectedBar extends React.PureComponent<Props, State> {\nnetworkActive = true;\ncomponentDidMount() {\n- NetInfo.add... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up DisconnectedBar to use NetInfo.isConnected
And don't count "connecting" as a change in connection status. |
129,187 | 23.11.2018 16:40:41 | 28,800 | 99933771315b09c414e3bdc57832844f865280cb | [native] Wrap entire Chat StackNavigator with KeyboardAvoidingView | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -36,7 +36,6 @@ import {\nComposeThreadRouteName,\nMessageListRouteName,\n} from '../navigation/route-names';\n-import KeyboardAvoidingView from '../compone... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Wrap entire Chat StackNavigator with KeyboardAvoidingView |
129,187 | 23.11.2018 16:45:13 | 28,800 | 51b01807ff1ef721d2b320099a89363473113a0b | [native] Get rid of keyboardVerticalOffset prop in KeyboardAvoidingView | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -757,10 +757,7 @@ class InnerCalendar extends React.PureComponent<Props, State> {\nallHeightsMeasuredCallback={this.allHeightsMeasured}\nstyle={[entryStyles.entry,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of keyboardVerticalOffset prop in KeyboardAvoidingView |
129,187 | 23.11.2018 17:15:48 | 28,800 | 73f3cdd4e763a8b7b5843e296824a7837f82e784 | [native] Don't persist foreground status in Redux | [
{
"change_type": "MODIFY",
"old_path": "native/persist.js",
"new_path": "native/persist.js",
"diff": "@@ -16,8 +16,8 @@ import { nativeCalendarQuery } from './selectors/nav-selectors';\nimport { defaultNotifPermissionAlertInfo } from './push/alerts';\nconst blacklist = __DEV__\n- ? [ 'loadingStatuse... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't persist foreground status in Redux |
129,187 | 25.11.2018 17:01:56 | 28,800 | 87898f34738f36538b24018aed25b1b14adb0c19 | [native] Update logic for detecting disconnected status
Make sure a reconnect clears `DisconnectedBar`, since we can't trust `NetInfo` to always report when the network comes back online.
We still have some edge cases that only seem to happen in iOS Simulator, but otherwise hopefully we're done with detecting disconnec... | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/disconnected-bar.react.js",
"new_path": "native/navigation/disconnected-bar.react.js",
"diff": "@@ -56,10 +56,17 @@ class DisconnectedBar extends React.PureComponent<Props, State> {\nconst { connectionStatus: status, someRequestIsLate } = thi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update logic for detecting disconnected status
Make sure a reconnect clears `DisconnectedBar`, since we can't trust `NetInfo` to always report when the network comes back online.
We still have some edge cases that only seem to happen in iOS Simulator, but otherwise hopefully we're done with detecting disconn... |
129,187 | 25.11.2018 17:11:48 | 28,800 | a348856b67e80c39c9db2e1acb829600314866a5 | codeVersion -> 25 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 24\n+ \"currentCodeVersion\": 25\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | codeVersion -> 25 |
129,187 | 26.11.2018 13:23:26 | 28,800 | 652a75262b6b06b39e2c77d0219390aecd3e047a | Extract DisconnectedBar visibility logic so it's shared
Determined in `DisconnectedBarVisibilityHandler`, set in Redux, and consumed by `DisconnectedBar`. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/connection-reducer.js",
"new_path": "lib/reducers/connection-reducer.js",
"diff": "@@ -10,6 +10,7 @@ import {\nfullStateSyncActionType,\nincrementalStateSyncActionType,\nsetLateResponseActionType,\n+ updateDisconnectedBarActionType,\n} from '../ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract DisconnectedBar visibility logic so it's shared
Determined in `DisconnectedBarVisibilityHandler`, set in Redux, and consumed by `DisconnectedBar`. |
129,187 | 26.11.2018 15:00:43 | 28,800 | d7a61e5bce26b0b2f76d6f339fb5ea46f7f3d0a5 | Introducing LocalMessageInfo
Will track messages that failed to send. This commit also makes it so those messages don't just disappear anymore. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "import {\ntype RawMessageInfo,\ntype ThreadMessageInfo,\n+ type LocalMessageInfo,\ntype MessageStore,\ntype MessageTruncationStatus,\ntype MessagesResponse,\n@@ -134,7 +1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introducing LocalMessageInfo
Will track messages that failed to send. This commit also makes it so those messages don't just disappear anymore. |
129,187 | 26.11.2018 20:17:21 | 28,800 | bc67ab52e129c3e2db4802eadc17b4a60539cd94 | Display delivery icon on native | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -7,7 +7,9 @@ import {\ntype MessageStore,\ntype TextMessageInfo,\ntype RobotextMessageInfo,\n+ type LocalMessageInfo,\nmessageInfoPropType,\n+ localMessageInfoPropType... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Display delivery icon on native |
129,187 | 26.11.2018 22:12:15 | 28,800 | 4014d136e2fd4298bdbbca3d981374f051cd67d5 | Allow message send retry on native | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -586,9 +586,27 @@ function reduceMessageStore(\nconst { payload } = action;\nconst { localID, threadID } = payload;\ninvariant(localID, `localID should be set on ${act... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Allow message send retry on native |
129,187 | 26.11.2018 22:56:03 | 28,800 | fabd5c9310d21389e3d93212fc0d5ee9cbe312d8 | [native]
Fixes so we can revert | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -288,7 +288,6 @@ const styles = StyleSheet.create({\n},\ncontainer: {\nflex: 1,\n- backgroundColor: \"#E9E9EF\",\n},\nsearchContainer: {\nbackgroundColor: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] react-navigation@3.0.1
Fixes https://github.com/react-navigation/react-navigation-stack/issues/53, so we can revert c993a9fcf3a816077895aeedfedc97df879dfd08 |
129,187 | 27.11.2018 12:07:50 | 28,800 | 867b5399ebc447378ca492d83e77017c0e51348f | [native] Reenable LayoutAnimation on Android
Removed in for some reason? | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -88,6 +88,11 @@ import DisconnectedBarVisibilityHandler\nfrom './navigation/disconnected-bar-visibility-handler.react';\nimport Socket from './socket.react';\n+if (Platform.OS === \"android\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reenable LayoutAnimation on Android
Removed in 119178fb34e2220148f3b7463d245a171aa10066 for some reason? |
129,187 | 27.11.2018 13:45:05 | 28,800 | fc1e7a7033c5512b2b7f10514876d6481c5011c9 | [native] Extract FailedSend and message retry logic
This avoids Redux-connecting every single message. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/failed-send.react.js",
"diff": "+// @flow\n+\n+import type { ChatMessageInfoItemWithHeight } from './message-list.react';\n+import { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\n+import {\n+ messageTypes,\n+ type S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract FailedSend and message retry logic
This avoids Redux-connecting every single message. |
129,187 | 27.11.2018 16:45:38 | 28,800 | 80e0e1d93c84e66591262b25f7178c73cc678ecf | [web] Display delivery icon and allow message send retry | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -84,7 +84,7 @@ div.conversationHeader {\ntext-transform: uppercase;\ncolor: #777777;\nfont-size: 14px;\n- padding-bottom: 7px;\n+ padding: 7px 0;\ntext-align: center;\n}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display delivery icon and allow message send retry |
129,187 | 28.11.2018 17:26:27 | 28,800 | 6f3d8af16acb23fafa56d7b149dc326bb94685e6 | [web] Visual tweaks to "send failed" div | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -102,7 +102,7 @@ div.robotext {\ndiv.textMessage {\npadding: 6px 12px;\n- margin: 0 7px 0 12px;\n+ margin: 0 4px 0 12px;\ncursor: pointer;\n}\ndiv.normalTextMessage {\n@... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Visual tweaks to "send failed" div |
129,187 | 28.11.2018 17:26:46 | 28,800 | 9682f69bc9739860a8a6e9b66626bd4673770a89 | [lib] Ensure reordering of messageIDs after message send success | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -597,13 +597,10 @@ function reduceMessageStore(\n[threadID]: {\n...messageStore.threads[threadID],\nmessageIDs: _orderBy([\n- (messageID: string) => messages[localID].... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Ensure reordering of messageIDs after message send success |
129,187 | 28.11.2018 17:32:54 | 28,800 | 279d6e963b002624f804c4e327b6d1d11665410f | Make message failed delivery indicator red | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message.react.js",
"new_path": "native/chat/text-message.react.js",
"diff": "@@ -134,6 +134,7 @@ class TextMessage extends React.PureComponent<Props> {\nlet failedSendInfo = null;\nif (isViewer) {\nlet deliveryIconName;\n+ let deliveryIconColo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make message failed delivery indicator red |
129,187 | 30.11.2018 11:15:16 | 18,000 | d95d6d4eec66910942d7cf3e11eb502d8d9202c9 | [lib] Never include deviceToken in crash payloads | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/sanitization.js",
"new_path": "lib/utils/sanitization.js",
"diff": "@@ -6,6 +6,7 @@ import type {\nAppState,\n} from '../types/redux-types';\nimport { setNewSessionActionType } from './action-utils';\n+import { setDeviceTokenActionTypes } from '../ac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Never include deviceToken in crash payloads |
129,187 | 30.11.2018 11:26:51 | 18,000 | 5b047230b894f0ca5bcafb234955b182fa511bf4 | [native] Fix stateVersion upgrade code to set nextLocalID to highest + 1
It was setting it just to the highest, which can be -1, which leads to a crash. | [
{
"change_type": "MODIFY",
"old_path": "native/persist.js",
"new_path": "native/persist.js",
"diff": "@@ -89,7 +89,7 @@ const migrations = {\n}),\n[9]: (state: AppState) => ({\n...state,\n- nextLocalID: highestLocalIDSelector(state),\n+ nextLocalID: highestLocalIDSelector(state) + 1,\nconnection: {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix stateVersion upgrade code to set nextLocalID to highest + 1
It was setting it just to the highest, which can be -1, which leads to a crash. |
129,187 | 30.11.2018 12:23:12 | 18,000 | 4a9b932118e543b54a918260ff8d83793be54159 | [server] Include ServerError payload in serverSocketMessageTypes.ERROR | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/socket.js",
"new_path": "server/src/socket/socket.js",
"diff": "@@ -311,11 +311,20 @@ class Socket {\nthis.ws.close(4101, error.message);\nreturn;\n}\n+ if (error.payload) {\nthis.sendMessage({\ntype: serverSocketMessageTypes.ERROR,\nresponse... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include ServerError payload in serverSocketMessageTypes.ERROR |
129,187 | 30.11.2018 12:36:37 | 18,000 | f48c2906dd07474170439fe75dae8c096643c004 | [server] Sanitize reportTypes.ERROR | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/report-creator.js",
"new_path": "server/src/creators/report-creator.js",
"diff": "@@ -14,6 +14,7 @@ import bots from 'lib/facts/bots';\nimport _isEqual from 'lodash/fp/isEqual';\nimport { filterRawEntryInfosByCalendarQuery } from 'lib/share... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Sanitize reportTypes.ERROR |
129,187 | 30.11.2018 14:03:55 | 18,000 | 8a83b9859ef5f0a010a1cf729c82f3e29d9847da | [native] Add LoadingIndicator to Entry
Several other changes/improvement to `Entry` included. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -954,15 +954,7 @@ class InnerCalendar extends React.PureComponent<Props, State> {\n}\nthis.latestExtraData = {\nactiveEntries: _pickBy(\n- (_, key: string) => {\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add LoadingIndicator to Entry
Several other changes/improvement to `Entry` included. |
129,187 | 30.11.2018 15:27:49 | 18,000 | 2e09820092079e2825df6013a35d91fcb583612d | Retry entry saves after reconnecting
Also some improvements to web `Entry`:
1. Don't re-save the same string twice in a row
2. Allow clicking on `textarea` while it's focused
3. Avoid temporary revert after saving | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -76,7 +76,7 @@ import {\n} from '../selectors/nav-selectors';\nimport LoadingIndicator from './loading-indicator.react';\n-type Props = {\n+type Props = {|\nnavigation: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Retry entry saves after reconnecting
Also some improvements to web `Entry`:
1. Don't re-save the same string twice in a row
2. Allow clicking on `textarea` while it's focused
3. Avoid temporary revert after saving |
129,187 | 30.11.2018 15:30:51 | 18,000 | 08d88542dc8ed73102c7549e06e669572fe99d05 | [lib] Don't consider errors to be late responses | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -124,24 +124,27 @@ class InflightRequests {\n// We create this object so we can pass it by reference to the timeout\n// function below. That function will avoid settin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Don't consider errors to be late responses |
129,187 | 30.11.2018 16:02:57 | 18,000 | 9db83590a60d9d3fd8e873a73988537ebf4ca9ac | codeVersion -> 26 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 25\n+ \"currentCodeVersion\": 26\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | codeVersion -> 26 |
129,187 | 02.12.2018 23:34:20 | 18,000 | 70c8bf94628e2a7bea628219328042ae3ab9d6e8 | [native] Undo Calendar changes in LoadingIndicator commit
Relevant commit:
Basically I forgot this was needed for an edge case. Also I renamed `Calendar`'s `tabActive` prop to `calendarActive`. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -115,7 +115,7 @@ type Props = {\nnavigation: NavigationScreenProp<NavigationRoute>,\n// Redux state\nlistData: ?$ReadOnlyArray<CalendarItem>,\n- tabActive: bool,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Undo Calendar changes in LoadingIndicator commit
Relevant commit: 8a83b9859ef5f0a010a1cf729c82f3e29d9847da
Basically I forgot this was needed for an edge case. Also I renamed `Calendar`'s `tabActive` prop to `calendarActive`. |
129,187 | 03.12.2018 12:52:19 | 18,000 | 9825465b729b902d1a29eb7d292be4113f05bd7d | Rename things to prepare for multimedia messages
1. `sendMessage` -> `sendTextMessage`
2. `SendTextMessageResponse` -> `SendMessageResponse`
3. `SendTextMessageResult` -> `SendMessageResult`
4. `SendTextMessagePayload` -> `SendMessagePayload`
5. Add `messageSentFromRoute` to `redux-persist` blacklist
6. `errorReportDow... | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/message-actions.js",
"new_path": "lib/actions/message-actions.js",
"diff": "@@ -5,7 +5,7 @@ import type {\nRawMessageInfo,\nMessageTruncationStatus,\nFetchMessageInfosPayload,\n- SendTextMessageResult,\n+ SendMessageResult,\n} from '../types/messag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rename things to prepare for multimedia messages
1. `sendMessage` -> `sendTextMessage`
2. `SendTextMessageResponse` -> `SendMessageResponse`
3. `SendTextMessageResult` -> `SendMessageResult`
4. `SendTextMessagePayload` -> `SendMessagePayload`
5. Add `messageSentFromRoute` to `redux-persist` blacklist
6. `errorReportDo... |
129,187 | 03.12.2018 14:51:21 | 18,000 | 35549e4805a597f8a94054f22e6fca7fe6f92457 | [server] Initial support for multimedia upload
Currently just logs the input and returns dummy data. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -606,6 +606,8 @@ export type SendTextMessageRequest = {|\ntext: string,\n|};\n+export type SendMultimediaMessageResponse = SendMessageResult;\n+\n// Used for the message info in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Initial support for multimedia upload
Currently just logs the input and returns dummy data. |
129,187 | 03.12.2018 15:04:49 | 18,000 | 6c1a56713e9ad01b8356e5bbd8c29c6fa9cdf0c8 | [server] Treat empty string sessionID or cookie as null
Necessary since `FormData` doesn't accept `null`, so we need another way to communicate that the `sessionID` or `cookie` ought to be set but isn't. | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/cookies.js",
"new_path": "server/src/session/cookies.js",
"diff": "@@ -309,7 +309,7 @@ async function fetchViewerFromRequestBody(\n};\n}\nconst cookiePair = body.cookie;\n- if (cookiePair === null) {\n+ if (cookiePair === null || cookiePair ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Treat empty string sessionID or cookie as null
Necessary since `FormData` doesn't accept `null`, so we need another way to communicate that the `sessionID` or `cookie` ought to be set but isn't. |
129,187 | 03.12.2018 18:00:38 | 18,000 | 3766c8df2661b133258bef237326f0768b2d8e6b | Basic client support for multimedia upload
This is gonna be different on native vs. web... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/fetch-json.js",
"new_path": "lib/utils/fetch-json.js",
"diff": "@@ -22,6 +22,7 @@ import { ServerError, FetchTimeout } from './errors';\nimport { getConfig } from './config';\nimport sleep from './sleep';\nimport { SocketOffline, SocketTimeout } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Basic client support for multimedia upload
This is gonna be different on native vs. web... |
129,187 | 03.12.2018 18:14:02 | 18,000 | 687cf0fb4bd5fcba1b4bf4fcfd34c7055ad2ae57 | Introduce PreviewableMessageInfo
Soon to be differentiated from `RobotextMessageInfo` | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -4,6 +4,7 @@ import {\ntype MessageInfo,\ntype RawMessageInfo,\ntype RobotextMessageInfo,\n+ type PreviewableMessageInfo,\ntype TextMessageInfo,\ntype MessageData,\ntype Messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce PreviewableMessageInfo
Soon to be differentiated from `RobotextMessageInfo` |
129,187 | 03.12.2018 18:58:55 | 18,000 | ff08087c9904585b81f140daa2c5faec3f7d366d | Introducing messageTypes.MULTIMEDIA
For render, currently just shows dummy robotext | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -5,7 +5,7 @@ import { type ThreadInfo, threadInfoPropType } from '../types/thread-types';\nimport {\ntype MessageInfo,\ntype MessageStore,\n- type TextMessageInfo,\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introducing messageTypes.MULTIMEDIA
For render, currently just shows dummy robotext |
129,187 | 04.12.2018 19:16:29 | 18,000 | e70fc3581bed2a62cfa8db79e7c3d887e855cb1b | Web UI and handlers for uploading multimedia | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/message-actions.js",
"new_path": "lib/actions/message-actions.js",
"diff": "@@ -77,6 +77,25 @@ async function sendTextMessage(\n};\n}\n+const sendMultimediaMessageActionTypes = Object.freeze({\n+ started: \"SEND_MULTIMEDIA_MESSAGE_STARTED\",\n+ suc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Web UI and handlers for uploading multimedia |
129,187 | 05.12.2018 19:52:31 | 18,000 | 21a85dcb28e9565f185e0b1a83456b403b955711 | [web] Add mimetype validation to web client
1. File dialog should filter based on extension
2. Resultant `File` options are validated and their mimetypes and extensions corrected based on magic numbers | [
{
"change_type": "MODIFY",
"old_path": "lib/package.json",
"new_path": "lib/package.json",
"diff": "\"color\": \"^1.0.3\",\n\"dateformat\": \"^2.0.0\",\n\"fast-json-stable-stringify\": \"^2.0.0\",\n+ \"file-type\": \"^10.6.0\",\n\"invariant\": \"^2.2.2\",\n\"lodash\": \"^4.17.5\",\n\"prop-types\": \... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add mimetype validation to web client
1. File dialog should filter based on extension
2. Resultant `File` options are validated and their mimetypes and extensions corrected based on magic numbers |
129,187 | 05.12.2018 21:19:14 | 18,000 | 8c9413f286af74a15d4e0577eec82555068ddf86 | [server] Add mimetype validation to server | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/media-utils.js",
"new_path": "lib/utils/media-utils.js",
"diff": "@@ -14,6 +14,10 @@ function fileInfoFromData(\nreturn null;\n}\nconst { ext, mime } = fileTypeResult;\n+ const mediaType = mimeTypesToMediaTypes[mime];\n+ if (!mediaType) {\n+ return n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add mimetype validation to server |
129,187 | 07.12.2018 11:15:33 | 18,000 | 48fff7d50b1daaf936a495e56240989585c7a657 | [web] Add border in chat view | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -19,6 +19,7 @@ div.messageContainer > div {\ndiv.inputBar {\ndisplay: flex;\nflex-direction: column;\n+ border-top: 2px solid #E4E4E4;\n}\ndiv.inputBarTextInput {\ndispl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add border in chat view |
129,187 | 07.12.2018 12:04:15 | 18,000 | 55367acfc617ed67fdfd318ea28206952a112994 | Move web-specific media-utils to web folder | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/media-utils.js",
"new_path": "lib/utils/media-utils.js",
"diff": "// @flow\n-import type { MediaType } from '../types/media-types';\n-\nimport fileType from 'file-type';\ntype FileInfo = {| name: string, mime: string |};\n@@ -22,51 +20,13 @@ function... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move web-specific media-utils to web folder |
129,187 | 07.12.2018 12:12:37 | 18,000 | 875c6691544c84d018537933f3fc4ea09c6b04e5 | Multimedia preview on web | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -9,7 +9,20 @@ export type Media = {|\ntype: MediaType,\n|};\n+const mediaTypePropType = PropTypes.oneOf([ \"photo\", \"video\" ]);\n+\nexport const mediaPropType = PropTypes.shape({... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Multimedia preview on web |
129,187 | 21.12.2018 14:08:46 | 18,000 | 4731482bda5f0d4158c3193b874eee24398d7799 | [web] Type fix for HTMLInputElement.value reset | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -333,7 +333,7 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nremovePendingUpload = (pendingUpload: PendingMultimediaUpload) => {\nif (this.multim... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Type fix for HTMLInputElement.value reset |
129,187 | 21.12.2018 15:05:49 | 18,000 | 345a13e44b7ed7c078f67f086a870d6a18d9f120 | Isolate drafts state to native
We are about to introduce a different mechanism to cache `ThreadInfo`-local state like drafts on web. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/actions/miscellaneous-action-types.js",
"diff": "+// @flow\n+\n+export const saveDraftActionType = \"SAVE_DRAFT\";\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/maste... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Isolate drafts state to native
We are about to introduce a different mechanism to cache `ThreadInfo`-local state like drafts on web. |
129,187 | 21.12.2018 17:03:00 | 18,000 | 33f86ec4d50ab130f5fa43d5b02a7aff76b0763d | [web] Lift ChatInputState
This allows us to persist drafts of messages on a per-thread basis | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -19,6 +19,10 @@ import {\nmessageTypes,\n} from 'lib/types/message-types';\nimport type { PendingMultimediaUpload } from 'lib/types/media-types';\n+import {\n+ chatI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Lift ChatInputState
This allows us to persist drafts of messages on a per-thread basis |
129,187 | 21.12.2018 17:31:51 | 18,000 | 9d5a7a6f0e913ba029626943ae6f4b2d98d4d0e0 | [web] Define height relative to main content | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "div.container {\nmargin-left: 400px;\n- height: calc(100% - 62px);\n+ height: 100%;\nbackground-color: white;\ndisplay: flex;\nflex-direction: column;\n"
},
{
"chan... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Define height relative to main content |
129,187 | 21.12.2018 17:36:51 | 18,000 | 60a1ae6e515b45197f3cb5e230c3333da5162fe3 | [web] Drag 'n' drop support for multimedia uploads | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -4,6 +4,11 @@ div.container {\nbackground-color: white;\ndisplay: flex;\nflex-direction: column;\n+ box-sizing: border-box;\n+}\n+div.activeContainer {\n+ border: 2px so... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Drag 'n' drop support for multimedia uploads |
129,187 | 02.01.2019 18:07:01 | 18,000 | c153ad884ecf219e914d7d93c5afd83a895248d6 | [lib] Move fetchJSON timeout to timeouts.js | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/timeouts.js",
"new_path": "lib/shared/timeouts.js",
"diff": "@@ -18,6 +18,10 @@ export const clientRequestVisualTimeout = 3000; // in milliseconds\n// likely on the client side.\nexport const clientRequestSocketTimeout = 5000; // in milliseconds\n+/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move fetchJSON timeout to timeouts.js |
129,187 | 02.01.2019 22:21:36 | 18,000 | 30e483e59be0bef8502dd81cb36741435a6d56fe | [lib] Move uploadBlob to use XMLHTTPRequest instead of fetch
We need `onprogress`... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/errors.js",
"new_path": "lib/utils/errors.js",
"diff": "@@ -27,7 +27,7 @@ class ServerError extends ExtendableError {\n// Used for input validators on server-side only\nsanitizedInput: mixed;\n- constructor(error: string, payload?: Object) {\n+ const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move uploadBlob to use XMLHTTPRequest instead of fetch
We need `onprogress`... |
129,187 | 02.01.2019 22:26:55 | 18,000 | a192f15c66bba546de98e98295b488db6a54d67d | [lib] Add FetchJSONOptions.onProgress | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/fetch-json.js",
"new_path": "lib/utils/fetch-json.js",
"diff": "@@ -25,10 +25,11 @@ import { SocketOffline, SocketTimeout } from '../socket/inflight-requests';\nimport { uploadBlob } from './upload-blob';\nimport { fetchJSONTimeout } from '../shared/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add FetchJSONOptions.onProgress |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.