author
int64
658
755k
date
stringlengths
19
19
timezone
int64
-46,800
43.2k
hash
stringlengths
40
40
message
stringlengths
5
490
mods
list
language
stringclasses
20 values
license
stringclasses
3 values
repo
stringlengths
5
68
original_message
stringlengths
12
491
478,630
06.01.2023 20:07:02
28,800
ad4a7f9ac091618dda0c08fae945cb8556ef7100
Add GitProvenance.getOrganizationName() overload which accepts a baseUrl, so as to be able to support gitlab and other git hosts which support hierarchical organization structures
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/marker/GitProvenance.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/marker/GitProvenance.java", "diff": "@Nullable\nEOL eol;\n+ /**\n+ * Extract the organization name, including sub-organizations for g...
Java
Apache License 2.0
openrewrite/rewrite
Add GitProvenance.getOrganizationName() overload which accepts a baseUrl, so as to be able to support gitlab and other git hosts which support hierarchical organization structures
478,630
06.01.2023 20:13:12
28,800
cb9654e670dd0b252304849b29d192854fe2fa1d
Remove ChangePropertyKeyTest.prefixMatchDefaultDisabled as it is failing. Its name implies it should be different from prefixMatch(), but the input and recipe configuration are the same, so it seems that this test is not quite right
[ { "change_type": "MODIFY", "old_path": "rewrite-properties/src/test/java/org/openrewrite/properties/ChangePropertyKeyTest.java", "new_path": "rewrite-properties/src/test/java/org/openrewrite/properties/ChangePropertyKeyTest.java", "diff": "@@ -151,14 +151,4 @@ void prefixMatch() {\n)\n);\n}\n-\n- @T...
Java
Apache License 2.0
openrewrite/rewrite
Remove ChangePropertyKeyTest.prefixMatchDefaultDisabled as it is failing. Its name implies it should be different from prefixMatch(), but the input and recipe configuration are the same, so it seems that this test is not quite right
478,642
09.01.2023 09:28:27
18,000
f54c1a5a6524b3f191a7f990f8b5d00986f015e7
Restored (and fixed) test case in ChangePropertyKeyTest
[ { "change_type": "MODIFY", "old_path": "rewrite-properties/src/test/java/org/openrewrite/properties/ChangePropertyKeyTest.java", "new_path": "rewrite-properties/src/test/java/org/openrewrite/properties/ChangePropertyKeyTest.java", "diff": "@@ -139,7 +139,7 @@ void changeOnlyMatchingFile() {\n}\n@Tes...
Java
Apache License 2.0
openrewrite/rewrite
Restored (and fixed) test case in ChangePropertyKeyTest
478,626
09.01.2023 11:48:31
21,600
bd42f46293f8955da1ee90ae56e7dbdeec73833b
Extend DeleteStatement support to handle Groovy script statements
[ { "change_type": "ADD", "old_path": null, "new_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/DeleteStatement.java", "diff": "+/*\n+ * Copyright 2022 the original author or authors.\n+ * <p>\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this...
Java
Apache License 2.0
openrewrite/rewrite
Extend DeleteStatement support to handle Groovy script statements (#2615)
478,615
09.01.2023 20:17:40
-3,600
f4b348d8d2612fb3fa8f5d52a686e0fc36662e32
Make `IsEmptyCallOnCollections` also support `<` and `>` operators The expressions `c.size() > 0` and `0 < c.size()` can both also be replaced with `!c.isEmpty()`.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/IsEmptyCallOnCollectionsTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/IsEmptyCallOnCollectionsTest.java", "diff": "@@ -76,6 +76,10 @@ static void method(List<S...
Java
Apache License 2.0
openrewrite/rewrite
Make `IsEmptyCallOnCollections` also support `<` and `>` operators (#2612) The expressions `c.size() > 0` and `0 < c.size()` can both also be replaced with `!c.isEmpty()`.
478,619
09.01.2023 16:45:11
28,800
4c6baf199762bb89cf288010740faf8084d4e44e
Fix edge case with property placeholders in repository uri. Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java", "new_path": "rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java", "diff": "@@ -639,6 +639,14 @@ public MavenRepository normalizeRepository(Mave...
Java
Apache License 2.0
openrewrite/rewrite
Fix edge case with property placeholders in repository uri. Fixes #2603
478,619
09.01.2023 17:37:27
28,800
e7f1ad48fe9d192d2aff326c3c469de8e1479814
Add source path names to test assertions. Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-test/src/main/java/org/openrewrite/test/RecipeSchedulerCheckingExpectedCycles.java", "new_path": "rewrite-test/src/main/java/org/openrewrite/test/RecipeSchedulerCheckingExpectedCycles.java", "diff": "assertThat(afterList.get(i).printAllTrimmed())\n.as(...
Java
Apache License 2.0
openrewrite/rewrite
Add source path names to test assertions. Fixes #2600
478,626
09.01.2023 21:09:34
21,600
b019391196a930ef65d68f92c0967d1e10943e01
Refactor gradle support to enable parsing more Gradle files
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/build.gradle.kts", "new_path": "rewrite-gradle/build.gradle.kts", "diff": "@@ -18,6 +18,7 @@ dependencies {\napi(project(\":rewrite-groovy\"))\ncompileOnly(project(\":rewrite-test\"))\nimplementation(project(\":rewrite-properties\"))\n+ implemen...
Java
Apache License 2.0
openrewrite/rewrite
Refactor gradle support to enable parsing more Gradle files (#2613)
478,630
10.01.2023 01:33:09
28,800
6b94d02e542929d75928724126a51e7e3d07c93e
Add GradleProject marker which tracks metadata about gradle projects, in particular dependency resolution information
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/build.gradle.kts", "new_path": "rewrite-gradle/build.gradle.kts", "diff": "@@ -16,6 +16,7 @@ repositories {\ndependencies {\napi(project(\":rewrite-groovy\"))\n+ api(project(\":rewrite-maven\"))\ncompileOnly(project(\":rewrite-test\"))\nimplemen...
Java
Apache License 2.0
openrewrite/rewrite
Add GradleProject marker which tracks metadata about gradle projects, in particular dependency resolution information
478,626
10.01.2023 10:17:32
21,600
6fb9a0cff391126543636e7df733a3bd7b8bba2e
Don't lose the license comment
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/GradleParser.java", "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/GradleParser.java", "diff": "import org.openrewrite.groovy.GroovyIsoVisitor;\nimport org.openrewrite.groovy.GroovyParser;\n...
Java
Apache License 2.0
openrewrite/rewrite
Don't lose the license comment (#2622)
478,626
10.01.2023 11:05:18
21,600
8dc9cb2a5947f69ac998d3aa35797b9780df46e9
Add plugin block after pluginManagement. Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/plugins/AddGradleEnterprise.java", "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/plugins/AddGradleEnterprise.java", "diff": "*/\npackage org.openrewrite.gradle.plugins;\n-import org.openrew...
Java
Apache License 2.0
openrewrite/rewrite
Add plugin block after pluginManagement. (#2623) Fixes gh-2620
478,626
10.01.2023 11:50:01
21,600
26c5a4fcb61fb80e283fdf4ac1acf47c1e4bed6d
Fix broken tests from too eagerly putting the plugins block as the second statement
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/plugins/AddPluginVisitor.java", "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/plugins/AddPluginVisitor.java", "diff": ".getStatements();\nif (FindMethods.find(cu, \"RewriteGradleProject plu...
Java
Apache License 2.0
openrewrite/rewrite
Fix broken tests from too eagerly putting the plugins block as the second statement
478,626
10.01.2023 11:54:23
21,600
57d15ae3ad2cea3fc6f55ddae1ec20c6b4c876db
Prevent dropping existing comments on the next statement when moving comments from the default imports to the that statement
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/GradleParser.java", "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/GradleParser.java", "diff": "@@ -68,7 +68,7 @@ public GradleParser(GroovyParser.Builder groovyParser) {\nG.CompilationUnit ...
Java
Apache License 2.0
openrewrite/rewrite
Prevent dropping existing comments on the next statement when moving comments from the default imports to the that statement
478,619
10.01.2023 14:57:36
28,800
0de2f23c502b70b3baa0fc3effe1625ad00a702f
Handle the case where the property delimiter is null. Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-properties/src/main/java/org/openrewrite/properties/tree/Properties.java", "new_path": "rewrite-properties/src/main/java/org/openrewrite/properties/tree/Properties.java", "diff": "@@ -111,9 +111,16 @@ public SourceFile withCharset(Charset charset) {\nM...
Java
Apache License 2.0
openrewrite/rewrite
Handle the case where the property delimiter is null. Fixes #2607
478,619
10.01.2023 16:12:40
28,800
fc07a714fb2053efcb3959fbd38cdd39dab12ac6
Use visitNonNull in test
[ { "change_type": "MODIFY", "old_path": "rewrite-properties/src/test/java/org/openrewrite/properties/PropertiesParserTest.java", "new_path": "rewrite-properties/src/test/java/org/openrewrite/properties/PropertiesParserTest.java", "diff": "@@ -195,9 +195,8 @@ void printWithNullDelimiter() {\npublic Pr...
Java
Apache License 2.0
openrewrite/rewrite
Use visitNonNull in test
478,630
10.01.2023 17:39:07
28,800
cb9e4dd1db39673b348fca9b4eaaf3d4602dccb0
Fix ChangeTypeTest.renameClassAndFilePath() to work on Windows
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/ChangeTypeTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/ChangeTypeTest.java", "diff": "import org.junit.jupiter.api.Disabled;\nimport org.junit.jupiter.api.Test;\nimport org.o...
Java
Apache License 2.0
openrewrite/rewrite
Fix ChangeTypeTest.renameClassAndFilePath() to work on Windows
478,640
11.01.2023 18:19:10
-3,600
3048a9d528a5f7256cd21805d881682f536b7d27
Allow empty property tags in UpdateMavenModel Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-maven/src/main/java/org/openrewrite/maven/UpdateMavenModel.java", "new_path": "rewrite-maven/src/main/java/org/openrewrite/maven/UpdateMavenModel.java", "diff": "@@ -43,7 +43,7 @@ public Xml visitDocument(Xml.Document document, P p) {\nif (properties.i...
Java
Apache License 2.0
openrewrite/rewrite
Allow empty property tags in UpdateMavenModel (#2629) Fixes #2628
478,640
11.01.2023 18:31:30
-3,600
24ca59730fea0c9a6f3c1cd1e59ebe14bd71c587
Adopt new patch versions of jakarta.activation & spring-jdbc in tests
[ { "change_type": "MODIFY", "old_path": "rewrite-maven/src/test/java/org/openrewrite/maven/ChangeManagedDependencyGroupIdAndArtifactIdTest.java", "new_path": "rewrite-maven/src/test/java/org/openrewrite/maven/ChangeManagedDependencyGroupIdAndArtifactIdTest.java", "diff": "@@ -110,7 +110,7 @@ void cha...
Java
Apache License 2.0
openrewrite/rewrite
Adopt new patch versions of jakarta.activation & spring-jdbc in tests
478,626
11.01.2023 12:11:09
21,600
c0ea0aec992368b3d252fc44f0d3d75a70e454a2
Flesh out tests for DeleteStatement and ensure that statements on G.CompilationUnit can be removed
[ { "change_type": "DELETE", "old_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/DeleteStatement.java", "new_path": null, "diff": "-/*\n- * Copyright 2022 the original author or authors.\n- * <p>\n- * Licensed under the Apache License, Version 2.0 (the \"License\");\n- * you may not use t...
Java
Apache License 2.0
openrewrite/rewrite
Flesh out tests for DeleteStatement and ensure that statements on (#2627) G.CompilationUnit can be removed
478,630
12.01.2023 01:04:22
28,800
8c7b9d945e3a2e15d6aeaf0afb4ca94850c98427
DepndencyInsight recipe for Gradle, making use of the new GradleProject marker
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/AddDependency.java", "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/AddDependency.java", "diff": "@@ -157,6 +157,7 @@ public Validated validate() {\nJ.MethodInvocation m = super.visitMethodI...
Java
Apache License 2.0
openrewrite/rewrite
DepndencyInsight recipe for Gradle, making use of the new GradleProject marker
478,640
12.01.2023 17:25:22
-3,600
69322ca362455bfc792e32429002a527d112255d
Show GAV for null Maven repository Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-maven/src/main/java/org/openrewrite/maven/utilities/MavenArtifactDownloader.java", "new_path": "rewrite-maven/src/main/java/org/openrewrite/maven/utilities/MavenArtifactDownloader.java", "diff": "@@ -90,7 +90,8 @@ public Path downloadArtifact(ResolvedD...
Java
Apache License 2.0
openrewrite/rewrite
Show GAV for null Maven repository (#2637) Fixes #2636
478,626
12.01.2023 17:47:04
21,600
e9960a35533b8edf6e5a4dbed53513dd0e8c0cbb
Keep previously configured classpath from the base builder
[ { "change_type": "MODIFY", "old_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParser.java", "new_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParser.java", "diff": "@@ -226,6 +226,7 @@ public Builder() {\npublic Builder(Builder base) {\nsuper(G.CompilationUni...
Java
Apache License 2.0
openrewrite/rewrite
Keep previously configured classpath from the base builder
478,626
13.01.2023 13:12:29
21,600
bb10d540cd5547b6398a6a386602332d7cc8b993
Rework default import handling slightly to ensure a consistent cursor position
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/GradleParser.java", "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/GradleParser.java", "diff": "import org.openrewrite.ExecutionContext;\nimport org.openrewrite.Parser;\nimport org.openrewri...
Java
Apache License 2.0
openrewrite/rewrite
Rework default import handling slightly to ensure a consistent cursor position (#2642)
478,642
13.01.2023 16:00:02
18,000
64bd3b4bcd3eb23575e5a83f2c29f07a632851e7
Added another test case and bugfix for Maven CI-Friendly versions the immortal)
[ { "change_type": "MODIFY", "old_path": "rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java", "new_path": "rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java", "diff": "@@ -447,7 +447,7 @@ public Pom download(GroupArtifactVersion gav,\nf...
Java
Apache License 2.0
openrewrite/rewrite
Added another test case and bugfix for Maven CI-Friendly versions (#2049 the immortal)
478,642
17.01.2023 15:56:31
18,000
077471055d98e3c96e7d406849ea7b6bfd9c23f4
Adding visited-file details to unexpected exceptions
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/TreeVisitor.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/TreeVisitor.java", "diff": "@@ -321,7 +321,7 @@ public T visit(@Nullable Tree tree, P p) {\nthrow e;\n}\n- throw new RecipeRunException(e, get...
Java
Apache License 2.0
openrewrite/rewrite
Adding visited-file details to unexpected exceptions (#2655) (#2664)
478,624
18.01.2023 19:07:52
28,800
14926f5e8470b596bd863338bf5a222dc2103ce1
Introduce finalize private field recipe
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizeLocalVariablesTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizeLocalVariablesTest.java", "diff": "@@ -488,4 +488,37 @@ void test() {\n)\n);\n}\n+\...
Java
Apache License 2.0
openrewrite/rewrite
Introduce finalize private field recipe (#2663)
478,630
18.01.2023 21:57:02
28,800
8f847c421f2b6fbd488950f79cd4c76bf2502359
Unpin rocksdb as versions without the problem that 7.4.4 had have since been released
[ { "change_type": "MODIFY", "old_path": "rewrite-maven/build.gradle.kts", "new_path": "rewrite-maven/build.gradle.kts", "diff": "@@ -4,8 +4,6 @@ plugins {\nid(\"org.openrewrite.build.language-library\")\n}\n-val rocksDbVersion = \"7.4.3\" // https://github.com/facebook/rocksdb/issues/10448\n-\ndepend...
Java
Apache License 2.0
openrewrite/rewrite
Unpin rocksdb as versions without the problem that 7.4.4 had have since been released
478,642
19.01.2023 09:59:03
18,000
23509cbf4b137c805eac119c6b9738a47b4effee
adding first line of stack trace (which implies recipe name) to RecipeRunException message
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/internal/RecipeRunException.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/internal/RecipeRunException.java", "diff": "@@ -39,6 +39,7 @@ public RecipeRunException(Throwable cause, @Nullable Cursor curs...
Java
Apache License 2.0
openrewrite/rewrite
adding first line of stack trace (which implies recipe name) to RecipeRunException message
478,630
19.01.2023 10:11:01
28,800
2311deca7a4adf95a2f9d7c59c73f1777d3d53d3
Remove RocksDb shutdown hook which I experimentally found to cause problems with using the cache from the maven plugin
[ { "change_type": "MODIFY", "old_path": "rewrite-maven/src/main/java/org/openrewrite/maven/cache/RocksdbMavenPomCache.java", "new_path": "rewrite-maven/src/main/java/org/openrewrite/maven/cache/RocksdbMavenPomCache.java", "diff": "//Init the rockdb native jni library\nRocksDB.loadLibrary();\n-\n- //R...
Java
Apache License 2.0
openrewrite/rewrite
Remove RocksDb shutdown hook which I experimentally found to cause problems with using the cache from the maven plugin
478,615
19.01.2023 22:42:30
-3,600
13d0f9d6504323005f71e721ca0e665f7ac0cba7
Fix handling of unary operator in `FinalizePrivateField` The recipe should distinguish between reading and modifying unary operators, as this may allow a few more fields to be made final.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizePrivateFieldsTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizePrivateFieldsTest.java", "diff": "@@ -304,6 +304,26 @@ void fieldAssignedInConstruct...
Java
Apache License 2.0
openrewrite/rewrite
Fix handling of unary operator in `FinalizePrivateField` (#2679) The recipe should distinguish between reading and modifying unary operators, as this may allow a few more fields to be made final.
478,624
21.01.2023 23:19:16
28,800
2844c2450d52b6cd87bfff1e1f9803fbf1d4747a
fix an uncovered lambda case of FinalizePrivateField recipe
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizePrivateFieldsTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizePrivateFieldsTest.java", "diff": "@@ -663,4 +663,24 @@ void func() {\n)\n);\n}\n+\n+...
Java
Apache License 2.0
openrewrite/rewrite
fix an uncovered lambda case of FinalizePrivateField recipe (#2686)
478,624
23.01.2023 15:23:22
28,800
2a54178cf3c7902ca8c4171beb3844621cb9b8b6
Adds filtering null fieldType to finalizePrivateRecipe to fix error
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/FinalizePrivateFields.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/FinalizePrivateFields.java", "diff": "import org.openrewrite.internal.ListUtils;\nimport org.openrewrite.i...
Java
Apache License 2.0
openrewrite/rewrite
Adds filtering null fieldType to finalizePrivateRecipe to fix error (#2694)
478,624
23.01.2023 16:20:29
28,800
b6a73dfd33df11a104569854658ee4be1c99a485
add estimate duration for recipe FinalizePrivateFields
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/FinalizePrivateFields.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/FinalizePrivateFields.java", "diff": "import org.openrewrite.java.tree.Space;\nimport org.openrewrite.mark...
Java
Apache License 2.0
openrewrite/rewrite
add estimate duration for recipe FinalizePrivateFields
478,624
23.01.2023 16:32:16
28,800
3aeafcbfcd23e1410e583121fe6c8d9aa628a8ce
Adds FinalizeLocalVariables and FinalizeLocalVariables to the and recipe lists
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/resources/META-INF/rewrite/cleanup.yml", "new_path": "rewrite-java/src/main/resources/META-INF/rewrite/cleanup.yml", "diff": "@@ -23,6 +23,8 @@ recipeList:\n- org.openrewrite.java.cleanup.EmptyBlock\n- org.openrewrite.java.format.EmptyNew...
Java
Apache License 2.0
openrewrite/rewrite
Adds FinalizeLocalVariables and FinalizeLocalVariables to the and recipe lists
478,626
24.01.2023 20:04:51
21,600
f15af11d3ba54c8202b269397121dc68d6bbd540
Add remove plugin support and Gradle Enterprise migration recipe
[ { "change_type": "ADD", "old_path": null, "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/plugins/RemoveBuildPlugin.java", "diff": "+/*\n+ * Copyright 2023 the original author or authors.\n+ * <p>\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may no...
Java
Apache License 2.0
openrewrite/rewrite
Add remove plugin support and Gradle Enterprise migration recipe (#2701)
478,634
24.01.2023 18:17:16
28,800
b853f2865882380a1b631d36ecac74d6be856288
fix: use `FileAttributes` to drive `FileMode` on diffs `gradlew` was being changes from `0755` to `0644` because the `InMemoryDiffEntry` was assuming jgit `FileMode.REGULAR_FILE` when the `SourceFile` had been marked as `executable`
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/Result.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/Result.java", "diff": "@@ -205,13 +205,18 @@ private String computeDiff(@Nullable Path relativeTo,\nnew PrintOutputCapture<>(0) :\nnew PrintOutputC...
Java
Apache License 2.0
openrewrite/rewrite
fix: use `FileAttributes` to drive `FileMode` on diffs (#2700) `gradlew` was being changes from `0755` to `0644` because the `InMemoryDiffEntry` was assuming jgit `FileMode.REGULAR_FILE` when the `SourceFile` had been marked as `executable`
478,624
25.01.2023 16:04:40
28,800
2392c5a8e4e97bec50e4eb3ce2614b96a53be7ff
Add one uncovered test case for NoDoubleBraceInitialization
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/NoDoubleBraceInitializationTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/NoDoubleBraceInitializationTest.java", "diff": "*/\npackage org.openrewrite.java.clean...
Java
Apache License 2.0
openrewrite/rewrite
Add one uncovered test case for NoDoubleBraceInitialization
478,630
25.01.2023 17:57:16
28,800
9bb46269fd8145f5891b7f27f9f8f74742b5f020
Add disabled test which reproduces
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/text/ChangeText.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/text/ChangeText.java", "diff": "import java.util.Collections;\nimport java.util.Set;\n-import static org.openrewrite.Validated.required;\n...
Java
Apache License 2.0
openrewrite/rewrite
Add disabled test which reproduces #2711
478,658
27.01.2023 09:32:24
28,800
9599e1b1a71571f4310219fd447ae5c773639279
Fix incorrect JavaDoc in FinalizeLocalVariables
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/FinalizeLocalVariables.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/FinalizeLocalVariables.java", "diff": "@@ -101,7 +101,7 @@ private boolean isField(Cursor cursor) {\n/**\...
Java
Apache License 2.0
openrewrite/rewrite
Fix incorrect JavaDoc in FinalizeLocalVariables (#2730) Co-authored-by: Mike Sol <mike-solomon@users.noreply.github.com>
478,630
27.01.2023 10:36:31
28,800
9e70276a72beb90b7c37dfce484155c2e1274f6c
Fix NamedVariable.isField() throwing an IllegalStateException in some circumstances
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/tree/J.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/tree/J.java", "diff": "@@ -5536,13 +5536,9 @@ public String getSimpleName() {\n}\npublic boolean isField(Cursor cursor) {\n- return curso...
Java
Apache License 2.0
openrewrite/rewrite
Fix NamedVariable.isField() throwing an IllegalStateException in some circumstances
478,615
27.01.2023 22:53:17
-3,600
38819b7cc0e3600878fc72a6f43a28c41a61b5fc
Fix bug in `TabsAndIndentsVisitor` A problem with the logic in `TabsAndIndentsVisitor` which was observed with the `RemoveUnusedImports` recipe could lead to the whole or at least the beginning of compilation units with a copyright header getting indented. This problem may also affect other recipes using the `JavaVisitor#autoFormat()` method. Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-hcl/src/main/java/org/openrewrite/hcl/format/TabsAndIndentsVisitor.java", "new_path": "rewrite-hcl/src/main/java/org/openrewrite/hcl/format/TabsAndIndentsVisitor.java", "diff": "import org.openrewrite.internal.lang.Nullable;\nimport java.util.List;\n-i...
Java
Apache License 2.0
openrewrite/rewrite
Fix bug in `TabsAndIndentsVisitor` (#2733) A problem with the logic in `TabsAndIndentsVisitor` which was observed with the `RemoveUnusedImports` recipe could lead to the whole or at least the beginning of compilation units with a copyright header getting indented. This problem may also affect other recipes using the `JavaVisitor#autoFormat()` method. Fixes #2722
478,630
27.01.2023 14:17:50
28,800
e9b98561ad03f5bb95a0b3feb786243dd45d9847
Try again to get isField() correct. Thanks Knut for pointing out that I wasn't considering initializer blocks
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizeLocalVariablesTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizeLocalVariablesTest.java", "diff": "*/\npackage org.openrewrite.java.cleanup;\n-impo...
Java
Apache License 2.0
openrewrite/rewrite
Try again to get isField() correct. Thanks Knut for pointing out that I wasn't considering initializer blocks
478,624
30.01.2023 00:26:58
28,800
254a727606dc1b8b2f100245e8fc87a5e27887b8
Improve TreeVisitingPrinter. 1. add two methods to help debug easier. 2. no break line output and truncated
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/TreeVisitingPrinter.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/TreeVisitingPrinter.java", "diff": "/*\n- * Copyright 2022 the original author or authors.\n+ * Copyright 2023 the original ...
Java
Apache License 2.0
openrewrite/rewrite
Improve TreeVisitingPrinter. 1. add two methods to help debug easier. 2. no break line output and truncated
478,624
30.01.2023 07:23:05
28,800
1a582ecf8ce472965e789d3963274403e0cfcb70
Fix a bug of recipe when there is any method declared in the anonymous subclass and be invoked.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/NoDoubleBraceInitializationTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/NoDoubleBraceInitializationTest.java", "diff": "*/\npackage org.openrewrite.java.clean...
Java
Apache License 2.0
openrewrite/rewrite
Fix a bug of recipe when there is any method declared in the anonymous subclass and be invoked. (#2740)
478,630
30.01.2023 15:53:54
28,800
49b5046b55b4b644b232a6c76b7578fbc8ad7a58
Use newer build plugin to fix compilation error
[ { "change_type": "MODIFY", "old_path": "settings.gradle.kts", "new_path": "settings.gradle.kts", "diff": "@@ -2,7 +2,7 @@ pluginManagement {\nresolutionStrategy {\neachPlugin {\nif (requested.id.namespace != null && requested.id.namespace!!.startsWith(\"org.openrewrite.build\")) {\n- useVersion(\"1....
Java
Apache License 2.0
openrewrite/rewrite
Use newer build plugin to fix compilation error
478,630
30.01.2023 16:15:41
28,800
95b148be98f0777362c44022983b9b34967292ea
Get gradle tests passing again
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/Assertions.java", "new_path": "rewrite-gradle/src/main/java/org/openrewrite/gradle/Assertions.java", "diff": "import org.intellij.lang.annotations.Language;\nimport org.openrewrite.Parser;\n+import org.openre...
Java
Apache License 2.0
openrewrite/rewrite
Get gradle tests passing again
478,615
31.01.2023 21:21:51
-3,600
de56efa18c92f52b4540b58c48c4d700e66bded3
Add a note regarding JDK 1.8 on new Macs to `README.md`
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -25,6 +25,9 @@ OpenRewrite is built with [Gradle](https://gradle.org/). It is not typically nec\nOpenRewrite requires several JDK versions to be installed on your system. If you are able to access [Adoptium](htt...
Java
Apache License 2.0
openrewrite/rewrite
Add a note regarding JDK 1.8 on new Macs to `README.md`
478,615
31.01.2023 21:33:30
-3,600
6b7f84d78bdf86c59a0a8aff40f9f65f6dd52c04
Move `InstanceOfPatternMatch` to `cleanup` package Related:
[ { "change_type": "RENAME", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "* See the License for the specific language governing pe...
Java
Apache License 2.0
openrewrite/rewrite
Move `InstanceOfPatternMatch` to `cleanup` package Related: #2690
478,605
31.01.2023 12:46:36
28,800
6a0f058353fdac1a8ad8a998feb8ec6663e9691e
Added support for control conditions in DoWhileLoop in BlockStatementTemplateGenerator. fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/JavaTemplateTest7Test.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/JavaTemplateTest7Test.java", "diff": "import org.junit.jupiter.api.Test;\nimport org.openrewrite.ExecutionContex...
Java
Apache License 2.0
openrewrite/rewrite
Added support for control conditions in DoWhileLoop in BlockStatementTemplateGenerator. fixes #2743
478,605
31.01.2023 14:17:29
28,800
0c7402cb8f383cf5b86c79ab66a99695aa6ccf47
Prevent ReplaceLambdaWithMethodReference from changing lambdas to method references on Groovy closures. fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-groovy/src/test/java/org/openrewrite/java/cleanup/MinimumSwitchCasesTest.java", "new_path": "rewrite-groovy/src/test/java/org/openrewrite/java/cleanup/MinimumSwitchCasesTest.java", "diff": "import org.openrewrite.test.RewriteTest;\nimport static org.op...
Java
Apache License 2.0
openrewrite/rewrite
Prevent ReplaceLambdaWithMethodReference from changing lambdas to method references on Groovy closures. fixes #2745
478,605
01.02.2023 17:01:59
28,800
7024d33298de2a347ad4f320a1c81adfdb5bae3e
Fix J.Literal text for numeric values with underscores using NodeMetaMap in GroovyParserVisitor. fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java", "new_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java", "diff": "@@ -1047,18 +1047,23 @@ public void visitConstantExpression(ConstantExpression e...
Java
Apache License 2.0
openrewrite/rewrite
Fix J.Literal text for numeric values with underscores using NodeMetaMap in GroovyParserVisitor. fixes #2752
478,630
01.02.2023 20:29:39
28,800
75dcbae6df49fb76655f527a59019df8288e2371
Move Gradle script snippets to be compiled as part of our build, rather than at parse time. Reduces time needed to run rewrite-gradle tests from ~13 minutes to ~10 minutes
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/build.gradle.kts", "new_path": "rewrite-gradle/build.gradle.kts", "diff": "@@ -3,6 +3,7 @@ import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar\nplugins {\nid(\"org.openrewrite.build.language-library\")\nid(\"org.openrewrite.build.s...
Java
Apache License 2.0
openrewrite/rewrite
Move Gradle script snippets to be compiled as part of our build, rather than at parse time. Reduces time needed to run rewrite-gradle tests from ~13 minutes to ~10 minutes
478,640
02.02.2023 19:54:30
-3,600
0820d445ec65da7fdc43beef383c30c43ee031ad
Print stacktrace on IllegalArgumentException in JGit * Print stacktrace on IllegalArgumentException in JGit Exceptions where hidden, making it tough to debug in Graal where an IllegalArgumentException wraps a NoSuchMethodException. * Silently ignore non git directories
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/marker/GitProvenance.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/marker/GitProvenance.java", "diff": "@@ -184,6 +184,10 @@ public static GitProvenance fromProjectDirectory(Path projectDir) {\n} catc...
Java
Apache License 2.0
openrewrite/rewrite
Print stacktrace on IllegalArgumentException in JGit (#2760) * Print stacktrace on IllegalArgumentException in JGit Exceptions where hidden, making it tough to debug in Graal where an IllegalArgumentException wraps a NoSuchMethodException. * Silently ignore non git directories
478,615
02.02.2023 20:12:20
-3,600
f91d16154a7fe61121bac2a9f4d7f3b3f01399c4
Make `J.ParameterizedType#getType()` return a `JavaType.Parameterized` `J.ParameterizedType` now declares a new `type` field for the `JavaType.Parameterized` reference. All affected recipes are also updated accordingly to use the new `J.ParameterizedType` constructor.
[ { "change_type": "MODIFY", "old_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java", "new_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java", "diff": "@@ -1739,7 +1739,7 @@ public TypeTree visitVariableExpressionType(VariableExpres...
Java
Apache License 2.0
openrewrite/rewrite
Make `J.ParameterizedType#getType()` return a `JavaType.Parameterized` (#2750) `J.ParameterizedType` now declares a new `type` field for the `JavaType.Parameterized` reference. All affected recipes are also updated accordingly to use the new `J.ParameterizedType` constructor.
478,615
02.02.2023 21:46:35
-3,600
99527e62f01bd268f4702dd2a305b88089216f16
Nested classes of utility classes are not always utility classes The nested classes of a utility class should not automatically be considered as utility classes, but should be considered independent of the outer class. Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/HideUtilityClassConstructorTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/HideUtilityClassConstructorTest.java", "diff": "@@ -126,6 +126,48 @@ public static voi...
Java
Apache License 2.0
openrewrite/rewrite
Nested classes of utility classes are not always utility classes The nested classes of a utility class should not automatically be considered as utility classes, but should be considered independent of the outer class. Fixes #2763
478,642
02.02.2023 16:03:51
18,000
7633b1224fb53d376726e52ee6bb177f5b9dab6d
Improved performance of CompositeRecipe::getEstimatedEffortPerOccurrence (https://github.com/openrewrite/rewrite-maven-plugin/issues/486)
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/config/CompositeRecipe.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/config/CompositeRecipe.java", "diff": "package org.openrewrite.config;\nimport org.openrewrite.Recipe;\n+import org.openrewrite.int...
Java
Apache License 2.0
openrewrite/rewrite
Improved performance of CompositeRecipe::getEstimatedEffortPerOccurrence (https://github.com/openrewrite/rewrite-maven-plugin/issues/486)
478,624
02.02.2023 13:08:26
28,800
55ebcc5a077ed06e15bc19a23cc8a160bbb68045
remove FinalizePrivateFields from recipe list of cleanup and static-analysis-cleanup
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/resources/META-INF/rewrite/cleanup.yml", "new_path": "rewrite-java/src/main/resources/META-INF/rewrite/cleanup.yml", "diff": "@@ -23,7 +23,6 @@ recipeList:\n- org.openrewrite.java.cleanup.EmptyBlock\n- org.openrewrite.java.format.EmptyNew...
Java
Apache License 2.0
openrewrite/rewrite
remove FinalizePrivateFields from recipe list of cleanup and static-analysis-cleanup
478,615
02.02.2023 23:03:56
-3,600
599088e327627263a9788aa349c1e8dfe23d55b3
Fix handling of generics in `InstanceOfPatternMatch` Both the types in the `instanceof` and the type cast expression can use generics or not. The recipe must be able to deal with this correctly by checking the type assignability.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "import static org.openrewrite.java.Assertions.ja...
Java
Apache License 2.0
openrewrite/rewrite
Fix handling of generics in `InstanceOfPatternMatch` (#2762) Both the types in the `instanceof` and the type cast expression can use generics or not. The recipe must be able to deal with this correctly by checking the type assignability.
478,630
02.02.2023 17:31:56
28,800
eeb53f03b19968843a3a91bdd5ebbb922cd02ede
Fix Cannot parse Gradle scripts on JDK 8
[ { "change_type": "MODIFY", "old_path": "rewrite-gradle/build.gradle.kts", "new_path": "rewrite-gradle/build.gradle.kts", "diff": "@@ -74,3 +74,11 @@ tasks.withType<ShadowJar> {\ninclude(dependency(\"com.gradle:\"))\n}\n}\n+\n+// This seems to be the only way to get the groovy compiler to emit java-8...
Java
Apache License 2.0
openrewrite/rewrite
Fix #2767 Cannot parse Gradle scripts on JDK 8
478,615
03.02.2023 22:51:59
-3,600
8fe66692ebeb26798ff8d30f731ca75bfe056981
`InstanceOfPatternMatch`: Reuse matching variables When an `if` block's condition is an `instanceof` expression it isn't unusual that the body of the `if` block contains a variable declaration with a corresponding type cast. In that case the recipe will now delete that declaration and reuse the variable name as the pattern variable.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "@@ -34,6 +34,7 @@ public void defaults(RecipeSpe...
Java
Apache License 2.0
openrewrite/rewrite
`InstanceOfPatternMatch`: Reuse matching variables When an `if` block's condition is an `instanceof` expression it isn't unusual that the body of the `if` block contains a variable declaration with a corresponding type cast. In that case the recipe will now delete that declaration and reuse the variable name as the pattern variable.
478,630
03.02.2023 13:56:04
28,800
1c4f0f01a51612237661425d3fdd1876cdba075b
Update build plugin to latest
[ { "change_type": "MODIFY", "old_path": "settings.gradle.kts", "new_path": "settings.gradle.kts", "diff": "@@ -2,7 +2,7 @@ pluginManagement {\nresolutionStrategy {\neachPlugin {\nif (requested.id.namespace != null && requested.id.namespace!!.startsWith(\"org.openrewrite.build\")) {\n- useVersion(\"1....
Java
Apache License 2.0
openrewrite/rewrite
Update build plugin to latest
478,605
03.02.2023 16:50:42
28,800
f374b425fa213a9f635b0c675ccba7aac547d70a
Use GroovyClassLoader in SourceUnit and CompilationUnit of GroovyParser. fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParser.java", "new_path": "rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParser.java", "diff": "}\nErrorCollector errorCollector = new ErrorCollector(configuration);\n+ GroovyClassLoader cla...
Java
Apache License 2.0
openrewrite/rewrite
Use GroovyClassLoader in SourceUnit and CompilationUnit of GroovyParser. (#2774) fixes #2773
478,605
03.02.2023 17:53:12
28,800
4fb86e5e59659525bf68adc26ad9908695836473
Filter out interface class kinds in CovariantEqualsVisitor. fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/CovariantEqualsTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/CovariantEqualsTest.java", "diff": "@@ -287,4 +287,20 @@ public void placeholder(Object t) {}\n)\n...
Java
Apache License 2.0
openrewrite/rewrite
Filter out interface class kinds in CovariantEqualsVisitor. fixes #2775
478,615
05.02.2023 00:55:22
-3,600
53a19f2cbfd5155cf1d09b6b208d31dd6e876c3d
Fix bugs in `InstanceOfPatternMatch` recipe When rewriting an `if` statement with an `instanceof` in the condition, the pattern variable name mustn't conflict with the variables in the body of the `if` statement. This is now handled for variables that precede the type cast but not yet for variable declarations that follow it.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "@@ -166,6 +166,38 @@ void test(Object o) {\n)\n)...
Java
Apache License 2.0
openrewrite/rewrite
Fix bugs in `InstanceOfPatternMatch` recipe When rewriting an `if` statement with an `instanceof` in the condition, the pattern variable name mustn't conflict with the variables in the body of the `if` statement. This is now handled for variables that precede the type cast but not yet for variable declarations that follow it.
478,615
05.02.2023 11:44:33
-3,600
3d9354be99a3cbc08f6b10dc35db20ed70e82536
Fix bug in `TypeUtils#isAssignableTo()` for `GenericTypeVariable` case The type assignability check in `TypeUtils#isAssignableTo()` was wrong with respect to `JavaType.GenericTypeVariable` instances.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "@@ -237,7 +237,7 @@ void noTypeCast() {\npublic ...
Java
Apache License 2.0
openrewrite/rewrite
Fix bug in `TypeUtils#isAssignableTo()` for `GenericTypeVariable` case The type assignability check in `TypeUtils#isAssignableTo()` was wrong with respect to `JavaType.GenericTypeVariable` instances.
478,615
05.02.2023 11:57:37
-3,600
965acb92d48e366a67cb063f4b52921b2cd87709
`InstanceOfPatternMatch`: Also use long names for primitive arrays An `instanceof` which type checks against a primitive array will result in a pattern variable like `ints` or `bytes` when added to an `if` condition. Before it was always short like `is` or `bs`.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "@@ -136,6 +136,34 @@ void test(Object o) {\n);\n...
Java
Apache License 2.0
openrewrite/rewrite
`InstanceOfPatternMatch`: Also use long names for primitive arrays An `instanceof` which type checks against a primitive array will result in a pattern variable like `ints` or `bytes` when added to an `if` condition. Before it was always short like `is` or `bs`.
478,615
05.02.2023 13:50:54
-3,600
1429c52086bc33a4538d6112cb5dccf2a7954892
Minor cleanup in `RemoveUnusedLocalVariables` Check for getters as part of `MethodMatcher` by changing pattern from `java.io.File *(..)` to `java.io.File get*(..)` rather than doing that as a separate check on `J.MethodInvocation#getSimpleName()`.
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/RemoveUnusedLocalVariables.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/RemoveUnusedLocalVariables.java", "diff": "@@ -68,7 +68,7 @@ public Duration getEstimatedEffortPerOcc...
Java
Apache License 2.0
openrewrite/rewrite
Minor cleanup in `RemoveUnusedLocalVariables` Check for getters as part of `MethodMatcher` by changing pattern from `java.io.File *(..)` to `java.io.File get*(..)` rather than doing that as a separate check on `J.MethodInvocation#getSimpleName()`.
478,615
05.02.2023 20:07:51
-3,600
b730b06007e0866463dcf7419f424fbdcb5aba8d
Add `JavaType.FullyQualified.Kind.RECORD` Add a new enum constant `JavaType.FullyQualified.Kind.RECORD` for `JavaType.Class` instances representing records. This is required so that `FindMissingTypes.FindMissingTypesVisitor#visitClassDeclaration()` doesn't report an error (with message `J.ClassDeclaration kind Record does not match the kind in its type information Class`).
[ { "change_type": "MODIFY", "old_path": "rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17TypeMapping.java", "new_path": "rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17TypeMapping.java", "diff": "@@ -245,18 +245,19 @@ private JavaType generic(T...
Java
Apache License 2.0
openrewrite/rewrite
Add `JavaType.FullyQualified.Kind.RECORD` (#2782) Add a new enum constant `JavaType.FullyQualified.Kind.RECORD` for `JavaType.Class` instances representing records. This is required so that `FindMissingTypes.FindMissingTypesVisitor#visitClassDeclaration()` doesn't report an error (with message `J.ClassDeclaration kind Record does not match the kind in its type information Class`).
478,615
05.02.2023 20:11:57
-3,600
63325ed167efd40ff6341b581f75e2544d4a44b8
Minor cleanup in `ReloadableJava17TypeMapping` Remove three no longer required constants.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17TypeMapping.java", "new_path": "rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17TypeMapping.java", "diff": "@RequiredArgsConstructor\nclass ReloadableJava17...
Java
Apache License 2.0
openrewrite/rewrite
Minor cleanup in `ReloadableJava17TypeMapping` Remove three no longer required constants.
478,624
05.02.2023 11:16:52
28,800
41a69d78f9e5fd4f0712e12b9a1384c63fd7dfd6
Enhance the `Space` recipe to support transformation for multiple whitespaces
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/format/SpacesTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/format/SpacesTest.java", "diff": "@@ -68,12 +68,41 @@ void beforeParensMethodDeclarationTrue() {\nclass Test {\nvoid...
Java
Apache License 2.0
openrewrite/rewrite
Enhance the `Space` recipe to support transformation for multiple whitespaces (#2741)
478,615
05.02.2023 22:22:45
-3,600
a4927002236aab7e26ca3016f0959d33ae635333
Support double negation in `BooleanChecksNotInverted` Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/BooleanChecksNotInvertedTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/BooleanChecksNotInvertedTest.java", "diff": "import static org.openrewrite.java.Assertion...
Java
Apache License 2.0
openrewrite/rewrite
Support double negation in `BooleanChecksNotInverted` Fixes #2783
478,615
06.02.2023 00:19:05
-3,600
047224a4f00fa688f3a7da0f76d0bd1ff8c0d311
Check method parameters when finding identical catch blocks When comparing the `catch` blocks in `CombineSemanticallyEqualCatchBlocks` the method invocation parameters must also be compared. Fixes
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/CombineSemanticallyEqualCatchBlocksTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/CombineSemanticallyEqualCatchBlocksTest.java", "diff": "@@ -379,4 +379,25 @@ v...
Java
Apache License 2.0
openrewrite/rewrite
Check method parameters when finding identical catch blocks When comparing the `catch` blocks in `CombineSemanticallyEqualCatchBlocks` the method invocation parameters must also be compared. Fixes #2785
478,615
06.02.2023 01:10:20
-3,600
8f9fb107e7cde2d2b0a044c06f6abe8c6b2fa78d
Fix bug in `SimplifyConsecutiveAssignments` The recipe would fail when an assignment was the last statement in a block, as the visitor would always attempt to inspect the next statement.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/SimplifyConsecutiveAssignmentsTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/SimplifyConsecutiveAssignmentsTest.java", "diff": "import static org.openrewrite.ja...
Java
Apache License 2.0
openrewrite/rewrite
Fix bug in `SimplifyConsecutiveAssignments` The recipe would fail when an assignment was the last statement in a block, as the visitor would always attempt to inspect the next statement.
478,615
06.02.2023 09:04:14
-3,600
2a96bb3ed291e25e0b23d7485d11571d0a59d820
`InstanceOfPatternMatch` should only add variable when necessary
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "*/\npackage org.openrewrite.java.cleanup;\n+impo...
Java
Apache License 2.0
openrewrite/rewrite
`InstanceOfPatternMatch` should only add variable when necessary
478,623
06.02.2023 15:48:50
25,200
8452f204d88e53e844d3ccc1c32d3f38bfb2a4bc
<reka18> fix marker inheritance
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/marker/ci/OperatingSystem.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/marker/ci/OperatingSystem.java", "diff": "* Detection logic from <a href=\"Gradle\">https://github.com/gradle/gradle/blob/master...
Java
Apache License 2.0
openrewrite/rewrite
<reka18> fix marker inheritance (#2795)
478,623
06.02.2023 16:21:22
25,200
3de64a959353887965dfcecb617e78e2e41fb0b0
<reka18> replace UUID with Tree randomId
[ { "change_type": "MODIFY", "old_path": "rewrite-core/src/main/java/org/openrewrite/marker/ci/OperatingSystem.java", "new_path": "rewrite-core/src/main/java/org/openrewrite/marker/ci/OperatingSystem.java", "diff": "import lombok.AllArgsConstructor;\nimport lombok.EqualsAndHashCode;\nimport lombok.Wit...
Java
Apache License 2.0
openrewrite/rewrite
<reka18> replace UUID with Tree randomId (#2797)
478,615
07.02.2023 19:04:52
-3,600
5fcdca73b4e34ebc0184607f8e4e9e34b1106a0d
Fix type errors in a few more tests In preparation to allow us to enable an opt-in for type checking of the before sources in tests.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/NoWhitespaceBeforeTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/NoWhitespaceBeforeTest.java", "diff": "@@ -717,8 +717,8 @@ void doNotStripTryWithResourcesEndParentheses() {\nc...
Java
Apache License 2.0
openrewrite/rewrite
Fix type errors in a few more tests In preparation to allow us to enable an opt-in for type checking of the before sources in tests.
478,615
07.02.2023 23:02:49
-3,600
585dde21d54648f2a6767bf524ab99c240b31f8c
`InstanceOfPatternMatch`: Ignore outer classes in variable naming For the short variable names used in ternary operator expressions ignore the name of outer classes when checking against nested classes.
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "@@ -781,5 +781,30 @@ String test(Object o) {\n)\...
Java
Apache License 2.0
openrewrite/rewrite
`InstanceOfPatternMatch`: Ignore outer classes in variable naming For the short variable names used in ternary operator expressions ignore the name of outer classes when checking against nested classes.
478,624
07.02.2023 14:22:53
28,800
4409a588562a1d6c3cf4e097bae13dcb093828e3
fix issue that private fields that might have been not initialized can not be final
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizePrivateFieldsTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/FinalizePrivateFieldsTest.java", "diff": "import org.junit.jupiter.api.Disabled;\nimport org...
Java
Apache License 2.0
openrewrite/rewrite
fix issue that private fields that might have been not initialized can not be final (#2808)
478,615
07.02.2023 23:29:50
-3,600
ed51d667ee1a80dfba9e691dedd3f3d9e4d7921d
`InstanceOfPatternMatch`: Check variables against Java keywords
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/InstanceOfPatternMatchTest.java", "diff": "@@ -788,17 +788,23 @@ void nestedClasses() {\nja...
Java
Apache License 2.0
openrewrite/rewrite
`InstanceOfPatternMatch`: Check variables against Java keywords
478,643
07.02.2023 17:34:25
18,000
b00c646dc77df593831681bad09382d7b5b921c4
No sys out print statements
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/JavaPrinter.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/JavaPrinter.java", "diff": "protected void visitRightPadded(List<? extends JRightPadded<? extends J>> nodes, JRightPadded.Location l...
Java
Apache License 2.0
openrewrite/rewrite
No sys out print statements (#2804)
478,615
08.02.2023 00:16:17
-3,600
ac56040f93a1ef9e0bc4b96ed474ed28cc17aef3
Adjust default license header for 2023
[ { "change_type": "MODIFY", "old_path": "gradle/licenseHeader.txt", "new_path": "gradle/licenseHeader.txt", "diff": "-Copyright 2022 the original author or authors.\n+Copyright 2023 the original author or authors.\n<p>\nLicensed under the Apache License, Version 2.0 (the \"License\");\nyou may not us...
Java
Apache License 2.0
openrewrite/rewrite
Adjust default license header for 2023
478,615
08.02.2023 00:28:59
-3,600
4646a1d8c3395aea0226ba415800b403c9804de0
Fix file with wrong copyright header
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/SimplifyConstantIfBranchExecutionTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/SimplifyConstantIfBranchExecutionTest.java", "diff": "-package org.openrewrite.j...
Java
Apache License 2.0
openrewrite/rewrite
Fix file with wrong copyright header
478,615
08.02.2023 00:33:20
-3,600
352edec9f192ee39ad03ab977bbf7f7ebb00a81f
Remove spurious license headers after `package` statement
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/ObjectFinalizeCallsSuperTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/cleanup/ObjectFinalizeCallsSuperTest.java", "diff": "* See the License for the specific language ...
Java
Apache License 2.0
openrewrite/rewrite
Remove spurious license headers after `package` statement
478,643
07.02.2023 20:52:59
18,000
7904ce3a7e1fedaa247027791fc5f1159b142455
No sys out print statements (Cont.)
[ { "change_type": "MODIFY", "old_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/ReplaceLambdaWithMethodReference.java", "new_path": "rewrite-java/src/main/java/org/openrewrite/java/cleanup/ReplaceLambdaWithMethodReference.java", "diff": "@@ -108,7 +108,6 @@ public J visitLambda(J.Lam...
Java
Apache License 2.0
openrewrite/rewrite
No sys out print statements (Cont.) (#2812)
478,615
08.02.2023 22:11:03
-3,600
25881a39cccea07da3476e6f59fe3546c6b1cd3e
Also validate constructor calls in `RewriteTest` sources
[ { "change_type": "MODIFY", "old_path": "rewrite-java-test/src/test/java/org/openrewrite/java/AddImportTest.java", "new_path": "rewrite-java-test/src/test/java/org/openrewrite/java/AddImportTest.java", "diff": "@@ -872,7 +872,7 @@ void addImportAndFoldIntoWildcard() {\nMap<String, String> map = new H...
Java
Apache License 2.0
openrewrite/rewrite
Also validate constructor calls in `RewriteTest` sources (#2816)
112,438
13.01.2017 16:14:08
28,800
36f4f3fe0eb6b0e35f838295a89ff6a3b7cf4f09
Added `all` parameter to feature_powershell provider
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -145,7 +145,7 @@ servermanagercmd -query\n#### Properties\n- `feature_name` - name of the feature/role to install. The same feature may have different names depending on the provider used (ie DHCPServer vs DHCP;...
Ruby
Apache License 2.0
chef-boneyard/windows
Added `all` parameter to feature_powershell provider Signed-off-by: Graham Davison <gdavison@paybyphone.com>
112,454
06.03.2017 16:25:52
21,600
e1ef46f7280b7ecf8d73b159593878123c9fb9da
Update appveyor.yml to use `delivery local`
[ { "change_type": "MODIFY", "old_path": "appveyor.yml", "new_path": "appveyor.yml", "diff": "@@ -33,7 +33,7 @@ build_script:\ntest_script:\n- c:\\opscode\\chefdk\\bin\\cookstyle --version\n- c:\\opscode\\chefdk\\bin\\chef.bat exec foodcritic --version\n- - c:\\opscode\\chefdk\\bin\\chef.bat exec rake...
Ruby
Apache License 2.0
chef-boneyard/windows
Update appveyor.yml to use `delivery local` Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
08.03.2017 14:59:56
21,600
62b998b7162116c4fca41d574d50b6236bd536cb
move `windows_feature` to custom resources
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -124,35 +124,49 @@ end\n### windows_feature\n+**BREAKING CHANGE - Version 3.0.0**\n+\n+This resource has been moved from using LWRPs and multiple providers to using Custom Resources. To maintain functionality, y...
Ruby
Apache License 2.0
chef-boneyard/windows
move `windows_feature` to custom resources Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
09.03.2017 11:32:38
21,600
7e3e770d86d66609f43a32f71185f8f7ef752647
change the feature test recipe to deal with the initial appveyor machine configuration.
[ { "change_type": "MODIFY", "old_path": "test/cookbooks/test/recipes/feature.rb", "new_path": "test/cookbooks/test/recipes/feature.rb", "diff": "@@ -7,6 +7,15 @@ windows_feature 'TFTP-Client' do\ninstall_method :windows_feature_powershell\nend\n+# This is for appveyor, which already seems to have FTP...
Ruby
Apache License 2.0
chef-boneyard/windows
change the feature test recipe to deal with the initial appveyor machine configuration. Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
14.03.2017 11:42:29
18,000
752c23c4b71e198d9594253658bc761a91008d4f
move the `windows_share` LWRP to a custom resource and work around the segfaults on 64 bit ruby
[ { "change_type": "MODIFY", "old_path": "resources/share.rb", "new_path": "resources/share.rb", "diff": "# limitations under the License.\n#\n-actions :create, :delete\n-default_action :create\n+property :share_name, String, name_attribute: true\n+property :path, String\n+property :description, Strin...
Ruby
Apache License 2.0
chef-boneyard/windows
move the `windows_share` LWRP to a custom resource and work around the segfaults on 64 bit ruby Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
14.03.2017 15:12:31
18,000
bf5bffa44c4ebeae1f80523858e1bb3d8819e866
move shortcut from LWRP to custom resource
[ { "change_type": "DELETE", "old_path": "providers/shortcut.rb", "new_path": null, "diff": "-#\n-# Author:: Doug MacEachern <dougm@vmware.com>\n-# Cookbook:: windows\n-# Provider:: shortcut\n-#\n-# Copyright:: 2010-2017, VMware, Inc.\n-#\n-# Licensed under the Apache License, Version 2.0 (the \"Licen...
Ruby
Apache License 2.0
chef-boneyard/windows
move shortcut from LWRP to custom resource Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
14.03.2017 13:31:57
18,000
b2cfa20950740935955c9342e9035558b8868bf8
windows_feature matcher updates
[ { "change_type": "MODIFY", "old_path": "libraries/matchers.rb", "new_path": "libraries/matchers.rb", "diff": "@@ -4,6 +4,9 @@ if defined?(ChefSpec)\nChefSpec.define_matcher :windows_certificate\nChefSpec.define_matcher :windows_certificate_binding\nChefSpec.define_matcher :windows_feature\n+ ChefSpe...
Ruby
Apache License 2.0
chef-boneyard/windows
windows_feature matcher updates Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
14.03.2017 16:23:55
18,000
46e70906a2b6e25143e7d3bb29eac0306c3d3f7b
move `windows_printer` and `windows_printer_port` from LWRPs to Custom Resources
[ { "change_type": "DELETE", "old_path": "providers/printer.rb", "new_path": null, "diff": "-#\n-# Author:: Doug Ireton (<doug.ireton@nordstrom.com>)\n-# Cookbook:: windows\n-# Provider:: printer\n-#\n-# Copyright:: 2012-2017, Nordstrom, Inc.\n-#\n-# Licensed under the Apache License, Version 2.0 (the...
Ruby
Apache License 2.0
chef-boneyard/windows
move `windows_printer` and `windows_printer_port` from LWRPs to Custom Resources Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,425
13.03.2017 20:18:16
18,000
348c862b42ca3e580716ed1379d4d5d42adc2cdf
Adds `Source` parameter to feature_powershell provider
[ { "change_type": "MODIFY", "old_path": "resources/feature_powershell.rb", "new_path": "resources/feature_powershell.rb", "diff": "@@ -39,8 +39,13 @@ action :install do\nChef::Log.warn(\"Requested feature #{new_resource.feature_name} is not available on this system.\") unless available?\nunless !avai...
Ruby
Apache License 2.0
chef-boneyard/windows
Adds `Source` parameter to feature_powershell provider Signed-off-by: Jared Kauppila <Jared@Kauppi.la>
112,454
14.03.2017 16:55:09
18,000
53fd0734f8301a21bced66e29bfff10c27db5e41
fix resource cloning issue
[ { "change_type": "MODIFY", "old_path": "test/cookbooks/test/recipes/feature.rb", "new_path": "test/cookbooks/test/recipes/feature.rb", "diff": "@@ -11,7 +11,8 @@ end\n# which causes a short circuit of the \"all\" behavior and breaks the test.\n# TODO: Make :windows_feature_powershell look at all the...
Ruby
Apache License 2.0
chef-boneyard/windows
fix resource cloning issue Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
14.03.2017 17:13:52
18,000
44f5ed68a79904bdbbfe205e980d910e63da1724
Updated README.md with new `windows_feature_*` matchers
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -718,8 +718,16 @@ expect(chef_run).to install_windows_package('Node.js').with(\n- create_windows_certificate_binding\n- delete_windows_certificate_binding\n- install_windows_feature\n+- install_windows_feature_d...
Ruby
Apache License 2.0
chef-boneyard/windows
Updated README.md with new `windows_feature_*` matchers Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
14.03.2017 21:11:29
18,000
d4e2bf1cc2a0d5d2bf144b90363476a1fc3dbcaf
`windows_task` lwrp to a custom resource
[ { "change_type": "DELETE", "old_path": "providers/task.rb", "new_path": null, "diff": "-#\n-# Author:: Paul Mooring (<paul@chef.io>)\n-# Cookbook:: windows\n-# Provider:: task\n-#\n-# Copyright:: 2012-2017, Chef Software, Inc.\n-#\n-# Licensed under the Apache License, Version 2.0 (the \"License\");...
Ruby
Apache License 2.0
chef-boneyard/windows
`windows_task` lwrp to a custom resource Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
15.03.2017 11:28:48
18,000
891d2b2c24dd2a7e4a77bde6a6d894f5465514c1
moving `windows_certificate` and `windows_certificate_binding` to custom resources
[ { "change_type": "DELETE", "old_path": "providers/certificate.rb", "new_path": null, "diff": "-#\n-# Author:: Richard Lavey (richard.lavey@calastone.com)\n-# Cookbook:: windows\n-# Provider:: certificate\n-#\n-# Copyright:: 2015-2017, Calastone Ltd.\n-#\n-# Licensed under the Apache License, Version...
Ruby
Apache License 2.0
chef-boneyard/windows
moving `windows_certificate` and `windows_certificate_binding` to custom resources Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
112,454
15.03.2017 12:55:12
18,000
156250491abf0222c759c811845fb64513fdd42b
move http_acl to a custom resource
[ { "change_type": "DELETE", "old_path": "providers/http_acl.rb", "new_path": null, "diff": "-#\n-# Author:: Richard Lavey (richard.lavey@calastone.com)\n-# Cookbook:: windows\n-# Provider:: http_acl\n-#\n-# Copyright:: 2015-2017, Calastone Ltd.\n-#\n-# Licensed under the Apache License, Version 2.0 (...
Ruby
Apache License 2.0
chef-boneyard/windows
move http_acl to a custom resource Signed-off-by: Steven Murawski <steven.murawski@gmail.com>