author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
89,491 | 24.06.2018 13:19:03 | -7,200 | 747f90db2f1dd2b64b86d1f3c8a0226348c20c99 | unified options for encoding and decoding | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/decoder.go",
"new_path": "protocols/bgp/packet/decoder.go",
"diff": "@@ -9,12 +9,8 @@ import (\n\"github.com/taktv6/tflow2/convert\"\n)\n-type DecodingOptions struct {\n- Supports4OctetASN bool\n-}\n-\n// Decode decodes a BGP message\n-fun... | Go | Apache License 2.0 | bio-routing/bio-rd | unified options for encoding and decoding |
89,500 | 24.06.2018 13:25:05 | -7,200 | fd1ccf16c69f9f5b395df7dd85eac97a60098c4a | remove log for performance reasons and add count function for routes in LocRIB | [
{
"change_type": "MODIFY",
"old_path": "main.go",
"new_path": "main.go",
"diff": "@@ -79,7 +79,7 @@ func main() {\ngo func() {\nfor {\n- fmt.Print(rib.Print())\n+ fmt.Printf(\"LocRIB count: %d\\n\", rib.Count())\ntime.Sleep(time.Second * 10)\n}\n}()\n"
},
{
"change_type": "MODIFY",
"old_... | Go | Apache License 2.0 | bio-routing/bio-rd | remove log for performance reasons and add count function for routes in LocRIB |
89,491 | 24.06.2018 13:36:29 | -7,200 | 927dde83c37b708334d53d87d3631918b1107069 | added missing build files | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/BUILD.bazel",
"new_path": "protocols/bgp/packet/BUILD.bazel",
"diff": "@@ -9,6 +9,7 @@ go_library(\n\"encoder.go\",\n\"large_community.go\",\n\"nlri.go\",\n+ \"options.go\",\n\"parameters.go\",\n\"path_attribute_flags.go\",\n\"path_attribu... | Go | Apache License 2.0 | bio-routing/bio-rd | added missing build files |
89,481 | 24.06.2018 15:23:32 | -7,200 | 7260563cd388ca98eef0b9cf7c7001c62303f6be | Use pointers to contributingASN structs. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/contributing_asn_list.go",
"new_path": "routingtable/contributing_asn_list.go",
"diff": "@@ -11,14 +11,14 @@ type contributingASN struct {\n// ContributingASNs contains a list of contributing ASN to a LocRIB to check ASPaths for possible routing l... | Go | Apache License 2.0 | bio-routing/bio-rd | Use pointers to contributingASN structs.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 15:24:18 | -7,200 | 4703fa547044cd292619048ecda4e6caac3acaf0 | Add test coverage for contributing_asn_list.go | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "routingtable/contributing_asn_list_test.go",
"diff": "+package routingtable\n+\n+import (\n+ \"fmt\"\n+ \"testing\"\n+)\n+\n+func TestFancy(t *testing.T) {\n+ c := NewContributingASNs()\n+\n+ tests := []struct {\n+ runCmd func()\n+ expect func()... | Go | Apache License 2.0 | bio-routing/bio-rd | Add test coverage for contributing_asn_list.go
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 15:57:24 | -7,200 | 9f8494dcc9246d0d5956d8e6a9c03840a37efeae | Remove errornous tests.
ACKed-by: Serge Bazanski | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/server_test.go",
"new_path": "protocols/bgp/server/server_test.go",
"diff": "@@ -11,23 +11,6 @@ import (\n\"github.com/bio-routing/bio-rd/routingtable/locRIB\"\n)\n-func TestBgpServerConfigCheck(t *testing.T) {\n- s := NewBgpServer()\n-\n-... | Go | Apache License 2.0 | bio-routing/bio-rd | Remove errornous tests.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
ACKed-by: Serge Bazanski |
89,481 | 24.06.2018 16:00:05 | -7,200 | 43ce356d7391665ac246a916e797939bd919c09a | Let travis run bazel test. | [
{
"change_type": "MODIFY",
"old_path": ".travis.yml",
"new_path": ".travis.yml",
"diff": "@@ -22,6 +22,7 @@ script:\n- mkdir -p $HOME/gopath/src/github.com/bio-routing/\n- ln -s $TRAVIS_BUILD_DIR $HOME/gopath/src/github.com/bio-routing/bio-rd || true\n- cp .bazelrc.travis .bazelrc\n+- bazel test //.... | Go | Apache License 2.0 | bio-routing/bio-rd | Let travis run bazel test.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 19:23:29 | -7,200 | 68e33f6acea55a067aaa42a9bc350088d2555ed7 | Use RWLock with menaingful name, overflow check, white-sapce fixes. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/server.go",
"new_path": "protocols/bgp/server/server.go",
"diff": "@@ -7,10 +7,9 @@ import (\n\"strings\"\n\"sync\"\n- \"github.com/bio-routing/bio-rd/routingtable/locRIB\"\n-\n\"github.com/bio-routing/bio-rd/config\"\n\"github.com/bio-rou... | Go | Apache License 2.0 | bio-routing/bio-rd | Use RWLock with menaingful name, overflow check, white-sapce fixes.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 19:35:26 | -7,200 | b081574fdb9a3f40b87e0e6d210e79fab090b881 | Damn overlooked a white-space fix. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/peer.go",
"new_path": "protocols/bgp/server/peer.go",
"diff": "@@ -5,12 +5,11 @@ import (\n\"sync\"\n\"time\"\n- \"github.com/bio-routing/bio-rd/routingtable/locRIB\"\n-\n\"github.com/bio-routing/bio-rd/config\"\n\"github.com/bio-routing/b... | Go | Apache License 2.0 | bio-routing/bio-rd | Damn overlooked a white-space fix.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 19:38:40 | -7,200 | 57871c3f5d9a2c9e7c35635896cbb42e3521bdfe | RLock() is enough for IsContributingASN(). | [
{
"change_type": "MODIFY",
"old_path": "routingtable/contributing_asn_list.go",
"new_path": "routingtable/contributing_asn_list.go",
"diff": "@@ -75,8 +75,8 @@ func (c *ContributingASNs) Remove(asn uint32) {\n// IsContributingASN checks if a given ASN is part of the contributing ASNs\nfunc (c *Contr... | Go | Apache License 2.0 | bio-routing/bio-rd | RLock() is enough for IsContributingASN().
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 25.06.2018 00:11:43 | -7,200 | 61c6de9fe533eccef25386e48db30e9a4d482313 | Add more tests for contributing ASNs. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/contributing_asn_list_test.go",
"new_path": "routingtable/contributing_asn_list_test.go",
"diff": "@@ -24,7 +24,7 @@ func TestFancy(t *testing.T) {\n{\nrunCmd: func() { c.Add(41981) },\nexpect: func() bool { return c.IsContributingASN(41981) },\n-... | Go | Apache License 2.0 | bio-routing/bio-rd | Add more tests for contributing ASNs.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 25.06.2018 09:27:07 | -7,200 | f86303caef447d9c8600f3e8d917689ea3476be3 | add notification when ceasing because of bad peer as (resolves | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_open_sent.go",
"new_path": "protocols/bgp/server/fsm_open_sent.go",
"diff": "@@ -134,7 +134,8 @@ func (s *openSentState) handleOpenMessage(openMsg *packet.BGPOpen) (state, strin\ns.processOpenOptions(openMsg.OptParams)\nif s.peerASNRcv... | Go | Apache License 2.0 | bio-routing/bio-rd | add notification when ceasing because of bad peer as (resolves #65) |
89,491 | 25.06.2018 09:46:44 | -7,200 | 9b2f55a098ba49c2a9a79eb4e677afe8ab80a504 | redone helper_test tests | [
{
"change_type": "MODIFY",
"old_path": "routingtable/filter/helper_test.go",
"new_path": "routingtable/filter/helper_test.go",
"diff": "package filter\n-/*func TestNewAcceptAllFilter(t *testing.T) {\n- f := NewAcceptAllFilter()\n+import (\n+ \"testing\"\n- m := &clientMock{}\n- f.Register(m)\n+ \"gi... | Go | Apache License 2.0 | bio-routing/bio-rd | redone helper_test tests |
89,491 | 25.06.2018 09:51:48 | -7,200 | 80ad835f6a7582b6c87fe4b635ddf9a55e9cb90b | resored filter tests | [
{
"change_type": "MODIFY",
"old_path": "routingtable/filter/filter_test.go",
"new_path": "routingtable/filter/filter_test.go",
"diff": "package filter\n-/*func TestAddPath(t *testing.T) {\n- tests := []struct {\n- name string\n- prefix net.Prefix\n- path *route.Path\n- term *Term\n- exptectCalled bo... | Go | Apache License 2.0 | bio-routing/bio-rd | resored filter tests |
89,491 | 25.06.2018 13:45:12 | -7,200 | 826e7afd5e506755fe32b26241f3bcb9ccbf881d | added hash computation for BGPPath | [
{
"change_type": "MODIFY",
"old_path": "route/bgp.go",
"new_path": "route/bgp.go",
"diff": "package route\nimport (\n+ \"crypto/sha256\"\n\"fmt\"\n\"strconv\"\n\"strings\"\n@@ -192,6 +193,28 @@ func (p *BGPPath) Copy() *BGPPath {\nreturn &cp\n}\n+// ComputeHash computes an hash over all attributes o... | Go | Apache License 2.0 | bio-routing/bio-rd | added hash computation for BGPPath |
89,491 | 25.06.2018 18:53:12 | -7,200 | 4df9a4b4e598de38f9e5ea79f19b51f34de1bb07 | bgp communities -> []uint32 | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes.go",
"new_path": "protocols/bgp/packet/path_attributes.go",
"diff": "@@ -690,24 +690,6 @@ func LargeCommunityAttributeForString(s string) (*PathAttribute, error) {\n}, nil\n}\n-func CommunityAttributeForString(s string) (*P... | Go | Apache License 2.0 | bio-routing/bio-rd | bgp communities -> []uint32 |
89,491 | 25.06.2018 18:53:55 | -7,200 | 27c11bad83cbae21b0c3cb8be0d65696cb0f4c56 | removed commentet code | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes.go",
"new_path": "protocols/bgp/packet/path_attributes.go",
"diff": "@@ -587,40 +587,6 @@ func (pa *PathAttribute) serializeLargeCommunities(buf *bytes.Buffer) uint8 {\nreturn length\n}\n-/*func (pa *PathAttribute) PrependA... | Go | Apache License 2.0 | bio-routing/bio-rd | removed commentet code |
89,491 | 25.06.2018 21:21:15 | -7,200 | ef9400a00149855505de10ec218c07e1fb46203b | as path refactoring | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "protocols/bgp/packet/as_path.go",
"diff": "+package packet\n+\n+import \"fmt\"\n+\n+type ASPath []ASPathSegment\n+\n+type ASPathSegment struct {\n+ Type uint8\n+ Count uint8\n+ ASNs []uint32\n+}\n+\n+func (pa ASPath) String() (ret string) {\n+ f... | Go | Apache License 2.0 | bio-routing/bio-rd | as path refactoring |
89,491 | 25.06.2018 23:44:18 | -7,200 | 5e3933b1fee6aa352c42ae475e434867f36361a6 | all tests are passing again | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/large_community.go",
"new_path": "protocols/bgp/packet/large_community.go",
"diff": "@@ -12,7 +12,7 @@ type LargeCommunity struct {\nDataPart2 uint32\n}\n-func (c LargeCommunity) String() string {\n+func (c *LargeCommunity) String() string... | Go | Apache License 2.0 | bio-routing/bio-rd | all tests are passing again |
89,491 | 25.06.2018 23:55:51 | -7,200 | d1c2b53b9b952105a7d50b238a2d1bd94637cb36 | fixed attribute return | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -171,6 +171,7 @@ func (s *establishedState) msgReceived(data []byte) (state, string) {\n}\nswitch msg.Header.Type {\ncase packet.NotificationMsg:\n+ fm... | Go | Apache License 2.0 | bio-routing/bio-rd | fixed attribute return |
89,481 | 25.06.2018 23:45:26 | -7,200 | a05b7f3ac174f94bcd09e13a543ce53a1610d580 | Moved RTMockClient into routingtable package to make it reusable. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBIn/adj_rib_in_test.go",
"new_path": "routingtable/adjRIBIn/adj_rib_in_test.go",
"diff": "package adjRIBIn\nimport (\n- \"fmt\"\n\"testing\"\n- \"github.com/bio-routing/bio-rd/routingtable/filter\"\n-\n\"github.com/stretchr/testify/assert\"\n... | Go | Apache License 2.0 | bio-routing/bio-rd | Moved RTMockClient into routingtable package to make it reusable.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 26.06.2018 01:56:57 | -7,200 | c28dcd0b3f65fc9739fa4399198febcf3ef45465 | Respect and robustness! <3 | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "# bio-rd\n+A re-implementation of BGP, IS-IS and OSPF in go. We value respect and robustness!\n+\n[](https://travis-ci.org/bio-routing/bio-... | Go | Apache License 2.0 | bio-routing/bio-rd | Respect and robustness! <3
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 26.06.2018 14:01:24 | -7,200 | 16c13808a018d16da77e16430a65e17e4387b789 | fixed hash computation | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -232,8 +232,7 @@ func (b *BGPPath) ComputeHash() string {\nb.LargeCommunities,\nb.PathIdentifier)\n- h := sha256.New()\n- return fmt.Sprintf(\"%x\", h.Sum([]byte(s)))\n+ return fmt.Sprintf(\"%x\"... | Go | Apache License 2.0 | bio-routing/bio-rd | fixed hash computation |
89,491 | 26.06.2018 17:32:21 | -7,200 | da182cae57ded157c0f67b8908df9a9eff37e075 | storing unknown attrs in path | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes.go",
"new_path": "protocols/bgp/packet/path_attributes.go",
"diff": "@@ -342,6 +342,18 @@ func (pa *PathAttribute) setLength(buf *bytes.Buffer) (int, error) {\nreturn bytesRead, nil\n}\n+func (pa *PathAttribute) Copy() *Pat... | Go | Apache License 2.0 | bio-routing/bio-rd | storing unknown attrs in path |
89,491 | 26.06.2018 17:44:08 | -7,200 | 4d28b4159a424346a5c5f24f90ec57e04f495280 | added tests for conn mock | [
{
"change_type": "MODIFY",
"old_path": "testing/conn_mock.go",
"new_path": "testing/conn_mock.go",
"diff": "@@ -27,6 +27,6 @@ func (m *MockConn) Read(b []byte) (n int, err error) {\ncount = len(m.Bytes)\n}\n- copy(m.Bytes[0:count], b)\n+ copy(b, m.Bytes[0:count])\nreturn count, nil\n}\n"
},
{
... | Go | Apache License 2.0 | bio-routing/bio-rd | added tests for conn mock |
89,491 | 26.06.2018 18:33:18 | -7,200 | 035b1223bd45c241052d1088134b005985f4ee15 | unknown path serialization | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes.go",
"new_path": "protocols/bgp/packet/path_attributes.go",
"diff": "@@ -390,6 +390,8 @@ func (pa *PathAttribute) serialize(buf *bytes.Buffer, opt *Options) uint8 {\npathAttrLen = pa.serializeCommunities(buf)\ncase LargeCom... | Go | Apache License 2.0 | bio-routing/bio-rd | unknown path serialization |
89,481 | 24.06.2018 11:39:24 | -7,200 | 6dc516784710aa680b32487d8a04b50f994089cd | Save if a route was learned via eBGP or iBGP. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -217,6 +217,7 @@ func (s *establishedState) updates(u *packet.BGPUpdate) {\nType: route.BGPPathType,\nBGPPath: &route.BGPPath{\nSource: bnet.IPv4ToUint... | Go | Apache License 2.0 | bio-routing/bio-rd | Save if a route was learned via eBGP or iBGP.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 11:12:49 | -7,200 | 773253559e914b08465cc4509612c1c8c55a8cf2 | Annotate route selection process and add eBGP vs. iBGP tie breaking. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -40,6 +40,11 @@ func (b *BGPPath) Compare(c *BGPPath) int8 {\nreturn -1\n}\n+ /*\n+ * 9.1.2.2. Breaking Ties (Phase 2)\n+ */\n+\n+ // a)\nif c.ASPathLen > b.ASPathLen {\nreturn 1\n}\n@@ -48,6 +53... | Go | Apache License 2.0 | bio-routing/bio-rd | Annotate route selection process and add eBGP vs. iBGP tie breaking.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 11:58:46 | -7,200 | a25986ac37841fc952fbef5dcce53bd6535bd1ab | Unify two equal branches into one. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out.go",
"diff": "@@ -58,9 +58,6 @@ func (a *AdjRIBOut) AddPath(pfx bnet.Prefix, p *route.Path) error {\np = p.Copy()\nif !a.neighbor.IBGP && !a.neighbor.RouteServerClient {\np... | Go | Apache License 2.0 | bio-routing/bio-rd | Unify two equal branches into one.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 10:55:05 | -7,200 | e715110ce144c1b7527df74d89381f83b4c4aaec | Print if route has been learned via eBGP or iBGP. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -163,6 +163,7 @@ func (b *BGPPath) better(c *BGPPath) bool {\nreturn false\n}\n+// Print all known information about a route in human readable form\nfunc (b *BGPPath) Print() string {\norigin := ... | Go | Apache License 2.0 | bio-routing/bio-rd | Print if route has been learned via eBGP or iBGP.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 13:14:34 | -7,200 | 5c5609e3b58987ce322eb1ed9262f5a406256abf | Annote BGP route types as 'internal' and 'external' | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -175,9 +175,9 @@ func (b *BGPPath) Print() string {\norigin = \"IGP\"\n}\n- bgpType := \"iBGP\"\n+ bgpType := \"internal\"\nif b.EBGP {\n- bgpType = \"eBGP\"\n+ bgpType = \"external\"\n}\nret := ... | Go | Apache License 2.0 | bio-routing/bio-rd | Annote BGP route types as 'internal' and 'external'
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 24.06.2018 13:14:51 | -7,200 | 5ea15b6e2422e0c92aaa9cad3d87c9fa5c4c7d51 | Print route source in dotted format instead of uint32. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -188,7 +188,8 @@ func (b *BGPPath) Print() string {\nret += fmt.Sprintf(\"\\t\\tNEXT HOP: %d.%d.%d.%d\\n\", nh[0], nh[1], nh[2], nh[3])\nret += fmt.Sprintf(\"\\t\\tMED: %d\\n\", b.MED)\nret += fm... | Go | Apache License 2.0 | bio-routing/bio-rd | Print route source in dotted format instead of uint32.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 26.06.2018 21:34:19 | -7,200 | e4fb787beeab82170e448fa2655a95087910380c | no error any more | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/update_helper.go",
"new_path": "protocols/bgp/server/update_helper.go",
"diff": "@@ -34,17 +34,14 @@ func pathAttribues(p *route.Path) (*packet.PathAttribute, error) {\nnextHop.Next = localPref\nif p.BGPPath != nil {\n- err := addOptionalP... | Go | Apache License 2.0 | bio-routing/bio-rd | no error any more |
89,481 | 26.06.2018 21:49:50 | -7,200 | 45f6071e43f8857ea07205a513942eefbc02845b | AddPath capability related code path should only used when capability is present
This code previously failed to remove and therefore withdraw routes from
non AddPathRX capable neighbors as there could no PathID be found for them. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out.go",
"diff": "@@ -111,14 +111,19 @@ func (a *AdjRIBOut) RemovePath(pfx bnet.Prefix, p *route.Path) bool {\n}\na.rt.RemovePath(pfx, p)\n+\n+ // If the neighbar has AddPath c... | Go | Apache License 2.0 | bio-routing/bio-rd | AddPath capability related code path should only used when capability is present
This code previously failed to remove and therefore withdraw routes from
non AddPathRX capable neighbors as there could no PathID be found for them.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 26.06.2018 22:12:16 | -7,200 | cd68c8be9fa9891d16dc282d34e5d36adf1817a7 | optimized complexity of method | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -227,7 +227,6 @@ func (s *establishedState) updates(u *packet.BGPUpdate) {\n}\nfunc (s *establishedState) processAttributes(attrs *packet.PathAttribute... | Go | Apache License 2.0 | bio-routing/bio-rd | optimized complexity of method |
89,481 | 27.06.2018 00:13:04 | -7,200 | 57d9032b95079c9b4b19af072fa4fdc20ef13d99 | BGPPath.insertNewASSequence() should extend the path in place. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -225,16 +225,16 @@ func (b *BGPPath) Prepend(asn uint32, times uint16) {\nb.ASPathLen = b.ASPath.Length()\n}\n-func (b *BGPPath) insertNewASSequence() packet.ASPath {\n+func (b *BGPPath) insertNe... | Go | Apache License 2.0 | bio-routing/bio-rd | BGPPath.insertNewASSequence() should extend the path in place.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 27.06.2018 00:44:08 | -7,200 | 1871cbbfd7ebdf3b006912bdd16374cd171eddda | added support for extended legth on unknown attributes | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "# IDE specific files\n.idea/\n*.iml\n+.vscode\n# 'go build' binary\nbio-rd\n"
},
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes.go",
"new_path": "protocols/bgp/packet... | Go | Apache License 2.0 | bio-routing/bio-rd | added support for extended legth on unknown attributes |
89,481 | 27.06.2018 01:42:46 | -7,200 | c915fc9b77ac1401748f4b829b14e53eb4fb2213 | AdjRIBOut: Don't add PathIdentifier without AddPath capabilities and don't add path twice. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out.go",
"diff": "@@ -69,11 +69,8 @@ func (a *AdjRIBOut) AddPath(pfx bnet.Prefix, p *route.Path) error {\na.mu.Lock()\ndefer a.mu.Unlock()\n- if !a.neighbor.CapAddPathRX {\n- o... | Go | Apache License 2.0 | bio-routing/bio-rd | AdjRIBOut: Don't add PathIdentifier without AddPath capabilities and don't add path twice.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 28.06.2018 19:33:53 | -7,200 | 4c9bd2351cd18bac129d20c54e1ce82df636b5d2 | first successful build with new IP type | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -19,6 +19,11 @@ func IPv4(val uint32) IP {\n}\n}\n+// IPv4FromOctets returns an IPv4 address for the given 4 octets\n+func IPv4FromOctets(o1, o2, o3, o4 uint8) IP {\n+ return IPv4(uint32(o1)<<24 + uint32(o2)<<16... | Go | Apache License 2.0 | bio-routing/bio-rd | first successful build with new IP type |
89,491 | 28.06.2018 20:02:56 | -7,200 | 6c5931578cb6d02de565732044941d67bfb7603e | changed peer and local address to our IP type | [
{
"change_type": "MODIFY",
"old_path": "config/peer.go",
"new_path": "config/peer.go",
"diff": "package config\nimport (\n- \"net\"\n\"time\"\n+ bnet \"github.com/bio-routing/bio-rd/net\"\n\"github.com/bio-routing/bio-rd/routingtable\"\n\"github.com/bio-routing/bio-rd/routingtable/filter\"\n)\n+// P... | Go | Apache License 2.0 | bio-routing/bio-rd | changed peer and local address to our IP type |
89,491 | 28.06.2018 20:14:38 | -7,200 | f88c87e5502ce32af2a81d091f4e6f19bba7c893 | static uses our IP type now | [
{
"change_type": "MODIFY",
"old_path": "route/route_test.go",
"new_path": "route/route_test.go",
"diff": "@@ -5,25 +5,25 @@ import (\n\"github.com/stretchr/testify/assert\"\n- \"github.com/bio-routing/bio-rd/net\"\n+ bnet \"github.com/bio-routing/bio-rd/net\"\n)\nfunc TestNewRoute(t *testing.T) {\nt... | Go | Apache License 2.0 | bio-routing/bio-rd | static uses our IP type now |
89,491 | 28.06.2018 20:17:15 | -7,200 | 6b9cdaffcd3bf84f050de835d6a86bebdbdf4c5b | removed ToUint32 | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -41,11 +41,6 @@ func IPv6FromBlocks(b1, b2, b3, b4, b5, b6, b7, b8 uint16) IP {\nuint64(uint64(b5)<<48+uint64(b6)<<32+uint64(b7)<<16+uint64(b8)))\n}\n-// ToUint32 returns the uint32 representation of an IP addre... | Go | Apache License 2.0 | bio-routing/bio-rd | removed ToUint32 |
89,491 | 28.06.2018 20:59:05 | -7,200 | 2586cdbf0164879d559c397ecdf6ece7747617f3 | net cleanup, prefix uses our IP type now | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -105,7 +105,7 @@ func (ip IP) Bytes() []byte {\n}\nfunc (ip IP) bytesIPv4() []byte {\n- u := uint32(^uint64(0) >> 32 & ip.lower)\n+ u := ip.toUint32()\nreturn []byte{\nbyte(u & 0xFF000000 >> 24),\nbyte(u & 0x00F... | Go | Apache License 2.0 | bio-routing/bio-rd | net cleanup, prefix uses our IP type now |
89,491 | 28.06.2018 21:21:26 | -7,200 | 7c9c9348c1c9d47a07b828b3969688f61232b05f | package server and route migrated | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -105,7 +105,7 @@ func (ip IP) Bytes() []byte {\n}\nfunc (ip IP) bytesIPv4() []byte {\n- u := ip.toUint32()\n+ u := ip.ToUint32()\nreturn []byte{\nbyte(u & 0xFF000000 >> 24),\nbyte(u & 0x00FF0000 >> 16),\n@@ -114... | Go | Apache License 2.0 | bio-routing/bio-rd | package server and route migrated |
89,491 | 28.06.2018 21:51:56 | -7,200 | c29208b3d4da8e9fa04376989c026b71534d738b | applied changes to filter package | [
{
"change_type": "MODIFY",
"old_path": "net/ip_test.go",
"new_path": "net/ip_test.go",
"diff": "@@ -260,3 +260,33 @@ func TestToNetIP(t *testing.T) {\n})\n}\n}\n+\n+func TestBitAtPosition(t *testing.T) {\n+ tests := []struct {\n+ name string\n+ input IP\n+ position uint8\n+ expected bool\n+ }{\n+ {\... | Go | Apache License 2.0 | bio-routing/bio-rd | applied changes to filter package |
89,491 | 28.06.2018 22:06:46 | -7,200 | e993f0b69be4908dd400445e5692b61b03f51bfc | applied changes to routingtable* | [
{
"change_type": "MODIFY",
"old_path": "routingtable/locRIB/loc_rib_test.go",
"new_path": "routingtable/locRIB/loc_rib_test.go",
"diff": "@@ -3,7 +3,6 @@ package locRIB\nimport (\n\"testing\"\n- \"github.com/bio-routing/bio-rd/net\"\nbnet \"github.com/bio-routing/bio-rd/net\"\n\"github.com/bio-routi... | Go | Apache License 2.0 | bio-routing/bio-rd | applied changes to routingtable* |
89,491 | 28.06.2018 22:40:39 | -7,200 | 8bcdcb98d2ce1c575b57213cf5aa3a489c15f075 | fixed expected value in case of none | [
{
"change_type": "MODIFY",
"old_path": "net/prefix_test.go",
"new_path": "net/prefix_test.go",
"diff": "@@ -344,3 +344,12 @@ func TestStrToAddr(t *testing.T) {\nassert.Equal(t, test.expected, res)\n}\n}\n+\n+func TestEqualOperator(t *testing.T) {\n+ p1 := NewPfx(IPv4(100), 4)\n+ p2 := NewPfx(IPv4(10... | Go | Apache License 2.0 | bio-routing/bio-rd | fixed expected value in case of none |
89,491 | 28.06.2018 23:16:14 | -7,200 | 4fc85c30a950dae196caff14308c7398daabbbf4 | fix for unitialized map and nil pointer | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/update_sender.go",
"new_path": "protocols/bgp/server/update_sender.go",
"diff": "@@ -39,6 +39,7 @@ func newUpdateSender(fsm *FSM) *UpdateSender {\nfsm: fsm,\niBGP: fsm.peer.localASN == fsm.peer.peerASN,\ndestroyCh: make(chan struct{}),\n+ ... | Go | Apache License 2.0 | bio-routing/bio-rd | fix for unitialized map and nil pointer |
89,491 | 01.07.2018 13:55:17 | -7,200 | 5ecbc83cc2435faeb002f7a708889118418b9d7f | added MP_UNREACH_NLRI | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "protocols/bgp/packet/helper.go",
"diff": "+package packet\n+\n+import (\n+ \"math\"\n+\n+ bnet \"github.com/bio-routing/bio-rd/net\"\n+)\n+\n+func serializePrefix(pfx bnet.Prefix) []byte {\n+ if pfx.Pfxlen() == 0 {\n+ return []byte{}\n+ }\n+\n+ ... | Go | Apache License 2.0 | bio-routing/bio-rd | added MP_UNREACH_NLRI |
89,491 | 01.07.2018 16:01:42 | -7,200 | 640b089324f2548873c65c01c9cccfcc23cf02cc | added MP_UNREACH and MP_REACH decoding | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -41,6 +41,27 @@ func IPv6FromBlocks(b1, b2, b3, b4, b5, b6, b7, b8 uint16) IP {\nuint64(uint64(b5)<<48+uint64(b6)<<32+uint64(b7)<<16+uint64(b8)))\n}\n+// IPFromBytes returns an IP address for a byte slice\n+func... | Go | Apache License 2.0 | bio-routing/bio-rd | added MP_UNREACH and MP_REACH decoding |
89,491 | 01.07.2018 16:18:38 | -7,200 | 8f513c82ddc9b95788451827080a9f42817d124d | implemented BitAtPosition for IPv6 | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -182,5 +182,13 @@ func (ip IP) bitAtPositionIPv4(pos uint8) bool {\n}\nfunc (ip IP) bitAtPositionIPv6(pos uint8) bool {\n- panic(\"No IPv6 support yet!\")\n+ if pos > 128 {\n+ return false\n+ }\n+\n+ if pos <= 6... | Go | Apache License 2.0 | bio-routing/bio-rd | implemented BitAtPosition for IPv6 |
89,491 | 01.07.2018 19:28:08 | -7,200 | e5d0158e4d2b555e980b5f15856e792376f40494 | added implementation for IPv6 supernet calculation | [
{
"change_type": "MODIFY",
"old_path": "net/ip_test.go",
"new_path": "net/ip_test.go",
"diff": "@@ -312,6 +312,12 @@ func TestBitAtPosition(t *testing.T) {\nposition uint8\nexpected bool\n}{\n+ {\n+ name: \"IPv4: all ones -> 0\",\n+ input: IPv4FromOctets(255, 255, 255, 255),\n+ position: 1,\n+ expec... | Go | Apache License 2.0 | bio-routing/bio-rd | added implementation for IPv6 supernet calculation |
89,491 | 01.07.2018 19:48:56 | -7,200 | 940fb7ac4d24597a841756487edce200209c7e2e | contains IPv6 implementation | [
{
"change_type": "MODIFY",
"old_path": "net/prefix.go",
"new_path": "net/prefix.go",
"diff": "@@ -70,7 +70,7 @@ func (pfx Prefix) Contains(x Prefix) bool {\nreturn pfx.containsIPv4(x)\n}\n- panic(\"No IPv6 support yet!\")\n+ return pfx.containsIPv6(x)\n}\nfunc (pfx Prefix) containsIPv4(x Prefix) boo... | Go | Apache License 2.0 | bio-routing/bio-rd | contains IPv6 implementation |
89,481 | 01.07.2018 22:00:55 | -7,200 | d68014e6349ba9fdce11a2b23b4fc61d460df6b3 | Check if trie node previously was a dummy when deciding if it's new. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/trie.go",
"new_path": "routingtable/trie.go",
"diff": "@@ -118,8 +118,10 @@ func (n *node) addPath(pfx net.Prefix, p *route.Path) (*node, bool) {\ncurrentPfx := n.route.Prefix()\nif currentPfx == pfx {\nn.route.AddPath(p)\n+ // Store previous dumm... | Go | Apache License 2.0 | bio-routing/bio-rd | Check if trie node previously was a dummy when deciding if it's new.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 01.07.2018 22:02:00 | -7,200 | 4afe06804fccb9f1f2b0ddef56abe05b5c04dfb2 | Add checks to verify routingtable calculates number of routes correctly. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/table_test.go",
"new_path": "routingtable/table_test.go",
"diff": "@@ -13,6 +13,7 @@ func TestAddPath(t *testing.T) {\nname string\nroutes []*route.Route\nexpected *node\n+ expectedCount int64\n}{\n{\nname: \"Insert first node\",\n@@ -23,6 +24,7 @... | Go | Apache License 2.0 | bio-routing/bio-rd | Add checks to verify routingtable calculates number of routes correctly.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 01.07.2018 22:53:19 | -7,200 | 54c415719b5d26961dead88c5ddd3094dde25ba0 | bio receives ipv6 routes, tag for ipv6 testbed | [
{
"change_type": "MODIFY",
"old_path": "config/peer.go",
"new_path": "config/peer.go",
"diff": "@@ -25,4 +25,5 @@ type Peer struct {\nImportFilter *filter.Filter\nExportFilter *filter.Filter\nRouteServerClient bool\n+ IPv6 bool\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "main.go",
... | Go | Apache License 2.0 | bio-routing/bio-rd | bio receives ipv6 routes, tag for ipv6 testbed |
89,491 | 01.07.2018 22:57:14 | -7,200 | d4b9ea31e4470644686fe9ece549676dcfc9a5d5 | skipping MP when not aggreed to | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -222,14 +222,7 @@ func (s *establishedState) updates(u *packet.BGPUpdate) {\nfor r := u.NLRI; r != nil; r = r.Next {\npfx := bnet.NewPfx(bnet.IPv4(r.IP... | Go | Apache License 2.0 | bio-routing/bio-rd | skipping MP when not aggreed to |
89,481 | 01.07.2018 23:08:01 | -7,200 | f3f2d1b852e17d6cfb823d08e39d86b6c15ea177 | Remove all path for a prefix from an AddPath capabale neighbor if a path with NO_EXPORT/NO_ADVERTISE shows up. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out.go",
"diff": "@@ -47,6 +47,9 @@ func (a *AdjRIBOut) RouteCount() int64 {\n// AddPath adds path p to prefix `pfx`\nfunc (a *AdjRIBOut) AddPath(pfx bnet.Prefix, p *route.Path... | Go | Apache License 2.0 | bio-routing/bio-rd | Remove all path for a prefix from an AddPath capabale neighbor if a path with NO_EXPORT/NO_ADVERTISE shows up.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 01.07.2018 04:14:43 | -7,200 | 09181e98e8468df4c35c6fc3f01e5fc635604494 | Add Route.NewRouteAddPath(pfx net.Prefix, p []*Path) | [
{
"change_type": "MODIFY",
"old_path": "route/route.go",
"new_path": "route/route.go",
"diff": "@@ -28,7 +28,7 @@ type Route struct {\necmpPaths uint\n}\n-// NewRoute generates a new route with paths p\n+// NewRoute generates a new route with path p\nfunc NewRoute(pfx net.Prefix, p *Path) *Route {\n... | Go | Apache License 2.0 | bio-routing/bio-rd | Add Route.NewRouteAddPath(pfx net.Prefix, p []*Path)
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 01.07.2018 23:15:57 | -7,200 | 4c0e9f303235ba6392a1bca4c685e22bb8c0033e | Add a whole bunch of tests for AdjRIBOut. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/BUILD.bazel",
"new_path": "routingtable/adjRIBOut/BUILD.bazel",
"diff": "@@ -19,10 +19,17 @@ go_library(\ngo_test(\nname = \"go_default_test\",\n- srcs = [\"path_id_manager_test.go\"],\n+ srcs = [\n+ \"adj_rib_out_test.go\",\n+ \"path_id... | Go | Apache License 2.0 | bio-routing/bio-rd | Add a whole bunch of tests for AdjRIBOut.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 01.07.2018 23:19:51 | -7,200 | 42839c120b9817a351b9edbe5c804c60b2d0ef34 | fixed out of bounds | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/mp_reach_nlri.go",
"new_path": "protocols/bgp/packet/mp_reach_nlri.go",
"diff": "@@ -58,12 +58,23 @@ func deserializeMultiProtocolReachNLRI(b []byte) (MultiProtocolReachNLRI, error)\nvariable = variable[1+nextHopLength:]\n- idx := uint8(0)... | Go | Apache License 2.0 | bio-routing/bio-rd | fixed out of bounds |
89,491 | 01.07.2018 23:41:28 | -7,200 | 3161b5f000056d41cc4b846f695307c6d6604b78 | out of bounds index fix | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/mp_reach_nlri.go",
"new_path": "protocols/bgp/packet/mp_reach_nlri.go",
"diff": "@@ -64,23 +64,26 @@ func deserializeMultiProtocolReachNLRI(b []byte) (MultiProtocolReachNLRI, error)\nreturn n, nil\n}\n- idx := uint8(0)\n- for idx < uint8(l... | Go | Apache License 2.0 | bio-routing/bio-rd | out of bounds index fix |
89,491 | 02.07.2018 22:03:26 | -7,200 | 33b162df07fa6883a97265cad8a713511e601b5a | removed unused func, cleanup | [
{
"change_type": "DELETE",
"old_path": "net/helper.go",
"new_path": null,
"diff": "-package net\n-\n-import \"net\"\n-\n-// IPv4ToUint32 converts an `net.IP` to an uint32 interpretation\n-func IPv4ToUint32(ip net.IP) uint32 {\n- ip = ip.To4()\n- return uint32(ip[3]) + uint32(ip[2])<<8 + uint32(ip[1]... | Go | Apache License 2.0 | bio-routing/bio-rd | removed unused func, cleanup |
89,491 | 02.07.2018 22:10:34 | -7,200 | 0995e3d7b2a1a4a359d8e8701fc873f052efb027 | add nexthop to BGPPath | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -257,6 +257,8 @@ func (s *establishedState) newRoutePath() *route.Path {\n}\nfunc (s *establishedState) multiProtocolUpdate(path *route.Path, nlri pack... | Go | Apache License 2.0 | bio-routing/bio-rd | add nexthop to BGPPath |
89,481 | 03.07.2018 16:33:49 | -7,200 | bd2a12113e4e83113919080bf28cc078c36ec23b | Add configuration parameters for route reflection (RFC4456)
Add configuration parameters for route reflection and propagate config
options into peer and FSM. | [
{
"change_type": "MODIFY",
"old_path": "config/peer.go",
"new_path": "config/peer.go",
"diff": "@@ -25,5 +25,7 @@ type Peer struct {\nImportFilter *filter.Filter\nExportFilter *filter.Filter\nRouteServerClient bool\n+ RouteReflectorClient bool\n+ RouteReflectorClusterID uint32\nIPv6 bool\n}\n"
},
... | Go | Apache License 2.0 | bio-routing/bio-rd | Add configuration parameters for route reflection (RFC4456)
Add configuration parameters for route reflection and propagate config
options into peer and FSM.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 16:38:46 | -7,200 | 0b4d858e21d0154f86b7aa8129569076ef870174 | Print OriginatorID and ClusterList in BGPPath, too. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -242,6 +242,14 @@ func (b *BGPPath) Print() string {\nret += fmt.Sprintf(\"\\t\\tCommunities: %v\\n\", b.Communities)\nret += fmt.Sprintf(\"\\t\\tLargeCommunities: %v\\n\", b.LargeCommunities)\n+... | Go | Apache License 2.0 | bio-routing/bio-rd | Print OriginatorID and ClusterList in BGPPath, too.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 00:15:43 | -7,200 | 12c075284a31434bfdbd2acd7804c9b83a1041a3 | Decode and store OriginatorID and ClusterList attributes. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/bgp.go",
"new_path": "protocols/bgp/packet/bgp.go",
"diff": "@@ -14,6 +14,7 @@ const (\nNLRIMaxLen = 5\nCommunityLen = 4\nLargeCommunityLen = 12\n+ ClusterIDLen = 4\nOpenMsg = 1\nUpdateMsg = 2\n@@ -66,6 +67,8 @@ const (\nAtomicAggrAttr = 6... | Go | Apache License 2.0 | bio-routing/bio-rd | Decode and store OriginatorID and ClusterList attributes.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 16:42:32 | -7,200 | ef25b574974606572854aed3d8a33293b3d343e9 | Copy ClusterList when making a deep copy of a BGPPath. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -311,6 +311,11 @@ func (b *BGPPath) Copy() *BGPPath {\ncp.LargeCommunities = make([]types.LargeCommunity, len(cp.LargeCommunities))\ncopy(cp.LargeCommunities, b.LargeCommunities)\n+ if b.ClusterL... | Go | Apache License 2.0 | bio-routing/bio-rd | Copy ClusterList when making a deep copy of a BGPPath.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 16:43:50 | -7,200 | 2218d1bbfc29c0d5b8847af1226c9f96a10c57eb | Include OriginatorID and ClusterList when computing BGPPath hash.
Also update expected hash value (now includes OriginatorID + ClusterList). | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -331,6 +331,8 @@ func (b *BGPPath) ComputeHash() string {\nb.BGPIdentifier,\nb.Source,\nb.Communities,\n+ b.OriginatorID,\n+ b.ClusterList,\nb.LargeCommunities,\nb.PathIdentifier)\n"
},
{
... | Go | Apache License 2.0 | bio-routing/bio-rd | Include OriginatorID and ClusterList when computing BGPPath hash.
Also update expected hash value (now includes OriginatorID + ClusterList).
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 02.07.2018 20:37:30 | -7,200 | 8f9327ff3a20d9e870a7bdfea21cc42c5af922ff | Include OriginatorID and ClusterList in byte length calculation of BGPPath. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -49,12 +49,22 @@ func (b *BGPPath) Length() uint16 {\nlargeCommunitiesLen += 3 + uint16(len(b.LargeCommunities)*12)\n}\n+ clusterListLen := uint16(0)\n+ if len(b.ClusterList) != 0 {\n+ clusterLis... | Go | Apache License 2.0 | bio-routing/bio-rd | Include OriginatorID and ClusterList in byte length calculation of BGPPath.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 02.07.2018 23:27:04 | -7,200 | 76cc87e9b4796837a6930991b012f42d6fccbd7f | Drive-by-fix: Fix Type Code in TestSerializeCommunities(). | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes_test.go",
"new_path": "protocols/bgp/packet/path_attributes_test.go",
"diff": "@@ -1442,7 +1442,7 @@ func TestSerializeCommunities(t *testing.T) {\n{\nname: \"2 communities\",\ninput: &PathAttribute{\n- TypeCode: LargeCommu... | Go | Apache License 2.0 | bio-routing/bio-rd | Drive-by-fix: Fix Type Code in TestSerializeCommunities().
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 16:47:03 | -7,200 | 699ed368e66d3d921b6418921adc4049fbc81644 | Serialize OriginatorID + ClusterList in update if neighbor is a RR client. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes.go",
"new_path": "protocols/bgp/packet/path_attributes.go",
"diff": "@@ -466,6 +466,10 @@ func (pa *PathAttribute) Serialize(buf *bytes.Buffer, opt *types.Options) uint16\npathAttrLen = uint16(pa.serializeCommunities(buf))\... | Go | Apache License 2.0 | bio-routing/bio-rd | Serialize OriginatorID + ClusterList in update if neighbor is a RR client.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 16:47:40 | -7,200 | 7ee75ef7ce61d4c6252443c046207978d90534cc | Add lot's of tests for RR path attribute decoding and serialization. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes_test.go",
"new_path": "protocols/bgp/packet/path_attributes_test.go",
"diff": "@@ -172,6 +172,80 @@ func TestDecodePathAttr(t *testing.T) {\n},\nwantFail: true,\n},\n+ {\n+ name: \"Missing value OriginatorID\",\n+ input: []... | Go | Apache License 2.0 | bio-routing/bio-rd | Add lot's of tests for RR path attribute decoding and serialization.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 00:06:59 | -7,200 | 8522e20cec456b5b15475f6f0778f915db24404e | Set OriginatorID and ClusterList for route reflector clients if required. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out.go",
"diff": "@@ -53,8 +53,8 @@ func (a *AdjRIBOut) AddPath(pfx bnet.Prefix, p *route.Path) error {\nreturn nil\n}\n- // Don't export routes learned via iBGP to an iBGP nei... | Go | Apache License 2.0 | bio-routing/bio-rd | Set OriginatorID and ClusterList for route reflector clients if required.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 03.07.2018 17:09:48 | -7,200 | 9e6f4626e57d4510a93c4afda198b544576e11eb | Set RouterID in neighbor for FSM test.
Without a RouterID (read RouterID 0.0.0.0) test will fail when checking if
the local RouterID is equal to an (unset) OriginatorID. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_test.go",
"new_path": "protocols/bgp/server/fsm_test.go",
"diff": "@@ -20,6 +20,7 @@ func TestFSM100Updates(t *testing.T) {\nrib: locRIB.New(),\nimportFilter: filter.NewAcceptAllFilter(),\nexportFilter: filter.NewAcceptAllFilter(),\n+ ... | Go | Apache License 2.0 | bio-routing/bio-rd | Set RouterID in neighbor for FSM test.
Without a RouterID (read RouterID 0.0.0.0) test will fail when checking if
the local RouterID is equal to an (unset) OriginatorID.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 03.07.2018 22:47:09 | -7,200 | c515202f0cea946c5002f7557219ce2f503b4b78 | added sending of MP_UNREACH_NLRI | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/update_sender.go",
"new_path": "protocols/bgp/server/update_sender.go",
"diff": "@@ -216,12 +216,7 @@ func (u *UpdateSender) copyAttributesWithoutNextHop(pa *packet.PathAttribute) (a\n// RemovePath withdraws prefix `pfx` from a peer\nfunc ... | Go | Apache License 2.0 | bio-routing/bio-rd | added sending of MP_UNREACH_NLRI |
89,481 | 04.07.2018 16:18:45 | -7,200 | 10fbe25d94169678a31f9e6b450e204c45e7994f | Propagate RouterID and ClusterID to AdjRIBIn, verify received routes accordingly and add tests. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -59,7 +59,7 @@ func (s establishedState) run() (state, string) {\nfunc (s *establishedState) init() error {\ncontributingASNs := s.fsm.rib.GetContribut... | Go | Apache License 2.0 | bio-routing/bio-rd | Propagate RouterID and ClusterID to AdjRIBIn, verify received routes accordingly and add tests.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 04.07.2018 16:57:31 | -7,200 | f08419abdf8840f09dbaff0078dfb60a87cb6a14 | Fix counting bug in RoutingTable when removing paths or prefixes. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/table.go",
"new_path": "routingtable/table.go",
"diff": "@@ -71,13 +71,13 @@ func (rt *RoutingTable) RemovePath(pfx net.Prefix, p *route.Path) {\nrt.mu.Lock()\ndefer rt.mu.Unlock()\n- if rt.removePath(pfx, p) {\n- atomic.AddInt64(&rt.routeCount, -... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix counting bug in RoutingTable when removing paths or prefixes.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 04.07.2018 17:05:03 | -7,200 | 1e4407d2d9d15ec533e40360d99e4a53fb81ebcb | Add tests for AdjRIBOut / iBGP RR client scenario. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out_test.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out_test.go",
"diff": "@@ -498,7 +498,7 @@ func TestBestPathOnlyIBGP(t *testing.T) {\nexpected: []*route.Route{},\n},\n{\n- name: \"Try to add route with NO_EXPORT communi... | Go | Apache License 2.0 | bio-routing/bio-rd | Add tests for AdjRIBOut / iBGP RR client scenario.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 04.07.2018 17:12:16 | -7,200 | e482bdd44735e7912002eb4fee6e8a5740bee97a | Add test case for reflecting already reflected route. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out_test.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out_test.go",
"diff": "@@ -776,6 +776,72 @@ func TestBestPathOnlyRRClient(t *testing.T) {\n},\nexpectedCount: 1,\n},\n+ {\n+ name: \"Remove NO_EXPORT route added before\",... | Go | Apache License 2.0 | bio-routing/bio-rd | Add test case for reflecting already reflected route.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 04.07.2018 17:52:23 | -7,200 | ff53390785ad08899e40533d408bfb0c4e34643f | If we are a route reflector and no ClusterID was set, use our RouterID. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/peer.go",
"new_path": "protocols/bgp/server/peer.go",
"diff": "@@ -126,6 +126,12 @@ func newPeer(c config.Peer, rib *locRIB.LocRIB, server *bgpServer) (*peer, error\nrouteReflectorClient: c.RouteReflectorClient,\nclusterID: c.RouteReflecto... | Go | Apache License 2.0 | bio-routing/bio-rd | If we are a route reflector and no ClusterID was set, use our RouterID.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 04.07.2018 23:56:39 | -7,200 | 4afa10ca04c4f761e09876d27cb0a355eeadefba | Make sure only the test currently running fails. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/path_attributes_test.go",
"new_path": "protocols/bgp/packet/path_attributes_test.go",
"diff": "@@ -1573,7 +1573,7 @@ func TestSerializeLargeCommunities(t *testing.T) {\n}\nfor _, test := range tests {\n- t.Run(test.name, func(te *testing.T... | Go | Apache License 2.0 | bio-routing/bio-rd | Make sure only the test currently running fails.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 05.07.2018 00:02:04 | -7,200 | 6068245f97451bf280de39729c7748c3763cdcda | Update comments to be conform to golint (which seem's to not care). | [
{
"change_type": "MODIFY",
"old_path": "routingtable/neighbor.go",
"new_path": "routingtable/neighbor.go",
"diff": "@@ -19,13 +19,13 @@ type Neighbor struct {\n// Local ASN of session\nLocalASN uint32\n- // Peer is a route server client\n+ // RouteServerClient incicates if the peer is a route server... | Go | Apache License 2.0 | bio-routing/bio-rd | Update comments to be conform to golint (which seem's to not care).
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 05.07.2018 00:19:28 | -7,200 | 2f0300ab92870645163c4b3d8c91fa96281fae95 | Remove relict from bug hunting. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBIn/adj_rib_in.go",
"new_path": "routingtable/adjRIBIn/adj_rib_in.go",
"diff": "@@ -69,7 +69,7 @@ func (a *AdjRIBIn) AddPath(pfx net.Prefix, p *route.Path) error {\ndefer a.mu.Unlock()\n// RFC4456 Sect. 8: Ignore route with our RouterID as Or... | Go | Apache License 2.0 | bio-routing/bio-rd | Remove relict from bug hunting.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,491 | 05.07.2018 22:03:13 | -7,200 | 2206c93b90f70da316783475dd4dd409d6760587 | moved ribs for AFI/SAFI in own type | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "protocols/bgp/server/family_routing.go",
"diff": "+package server\n+\n+import (\n+ \"time\"\n+\n+ bnet \"github.com/bio-routing/bio-rd/net\"\n+ \"github.com/bio-routing/bio-rd/protocols/bgp/packet\"\n+ \"github.com/bio-routing/bio-rd/protocols/b... | Go | Apache License 2.0 | bio-routing/bio-rd | moved ribs for AFI/SAFI in own type |
89,491 | 06.07.2018 07:52:06 | -7,200 | 2677986f06b916c4bbcea10bccb25c46a14a9796 | simplified loop | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/update_sender.go",
"new_path": "protocols/bgp/server/update_sender.go",
"diff": "@@ -193,10 +193,8 @@ func (u *UpdateSender) bgpUpdateMultiProtocol(pfxs []bnet.Prefix, pa *packet.Pat\n}\nfunc (u *UpdateSender) copyAttributesWithoutNextHop(... | Go | Apache License 2.0 | bio-routing/bio-rd | simplified loop |
89,491 | 06.07.2018 22:38:58 | -7,200 | a14508657ae6923d22a127aff5045805058b4e2a | allow multiple families per peer | [
{
"change_type": "MODIFY",
"old_path": "config/peer.go",
"new_path": "config/peer.go",
"diff": "@@ -3,6 +3,8 @@ package config\nimport (\n\"time\"\n+ \"github.com/bio-routing/bio-rd/routingtable/locRIB\"\n+\nbnet \"github.com/bio-routing/bio-rd/net\"\n\"github.com/bio-routing/bio-rd/routingtable\"\n... | Go | Apache License 2.0 | bio-routing/bio-rd | allow multiple families per peer |
89,491 | 07.07.2018 10:42:27 | -7,200 | 9594221b3856f63a02b8d1a476d5d693353c8772 | added log for receiving of updates for non configured families | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -9,6 +9,7 @@ import (\n\"github.com/bio-routing/bio-rd/protocols/bgp/packet\"\n\"github.com/bio-routing/bio-rd/route\"\n\"github.com/bio-routing/bio-rd... | Go | Apache License 2.0 | bio-routing/bio-rd | added log for receiving of updates for non configured families |
89,491 | 07.07.2018 13:13:24 | -7,200 | 70893cad135b1830420c1dc187b8005501792dcd | added integration test for ipv6 | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_test.go",
"new_path": "protocols/bgp/server/fsm_test.go",
"diff": "@@ -13,8 +13,8 @@ import (\nbnet \"github.com/bio-routing/bio-rd/net\"\n)\n-// TestFSM100Updates emulates receiving 100 BGP updates and withdraws. Checks route counts.\... | Go | Apache License 2.0 | bio-routing/bio-rd | added integration test for ipv6 |
89,491 | 08.07.2018 21:46:36 | -7,200 | 7f51675dc47ac0a435738015bb572d4cbb77ad3f | prevent go routine managing reconnects to leak on fsm stop | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm.go",
"new_path": "protocols/bgp/server/fsm.go",
"diff": "package server\nimport (\n+ \"context\"\n\"fmt\"\n+ \"io\"\n\"net\"\n\"sync\"\n\"time\"\n@@ -70,6 +72,8 @@ type FSM struct {\nstateMu sync.RWMutex\nreason string\nactive bool\n+\... | Go | Apache License 2.0 | bio-routing/bio-rd | prevent go routine managing reconnects to leak on fsm stop |
89,491 | 13.07.2018 21:50:28 | -7,200 | de6edf54c9ba7ff54929ae6ce41ec3bb82394d95 | added add-path for ipv6 | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/mp_reach_nlri.go",
"new_path": "protocols/bgp/packet/mp_reach_nlri.go",
"diff": "@@ -7,6 +7,7 @@ import (\n\"github.com/taktv6/tflow2/convert\"\nbnet \"github.com/bio-routing/bio-rd/net\"\n+ \"github.com/bio-routing/bio-rd/protocols/bgp/ty... | Go | Apache License 2.0 | bio-routing/bio-rd | added add-path for ipv6 |
89,491 | 16.07.2018 20:55:53 | -7,200 | 896d0330cc3c597f4e74fbaf35c0dc94cf92b9c2 | renamed familyRouting to fsmAddressFamily | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/BUILD.bazel",
"new_path": "protocols/bgp/server/BUILD.bazel",
"diff": "@@ -4,9 +4,9 @@ go_library(\nname = \"go_default_library\",\nsrcs = [\n\"fake_conn.go\",\n- \"family_routing.go\",\n\"fsm.go\",\n\"fsm_active.go\",\n+ \"fsm_address_fam... | Go | Apache License 2.0 | bio-routing/bio-rd | renamed familyRouting to fsmAddressFamily |
89,491 | 16.07.2018 21:56:33 | -7,200 | a0914a38d07a36ef997b7bca3cdb58ba91e0795a | tcpConnector does not return error any more, was not checked any way | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm.go",
"new_path": "protocols/bgp/server/fsm.go",
"diff": "@@ -186,7 +186,7 @@ func (fsm *FSM) cease() {\nfsm.eventCh <- Cease\n}\n-func (fsm *FSM) tcpConnector(ctx context.Context) error {\n+func (fsm *FSM) tcpConnector(ctx context.Cont... | Go | Apache License 2.0 | bio-routing/bio-rd | tcpConnector does not return error any more, was not checked any way |
89,486 | 17.07.2018 08:08:24 | -7,200 | 31a15576dc995ccacca8b50766251aa41d68bf2a | Added a states slice to peer info. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/peer.go",
"new_path": "protocols/bgp/server/peer.go",
"diff": "@@ -16,6 +16,7 @@ type PeerInfo struct {\nPeerAddr bnet.IP\nPeerASN uint32\nLocalASN uint32\n+ States []string\n}\ntype peer struct {\n@@ -50,10 +51,19 @@ type familyParameters... | Go | Apache License 2.0 | bio-routing/bio-rd | Added a states slice to peer info. |
89,491 | 17.07.2018 08:12:02 | -7,200 | 96439443ef3c085d607f03578824472e57c1fc3f | improved method signature | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/update_sender.go",
"new_path": "protocols/bgp/server/update_sender.go",
"diff": "package server\nimport (\n+ \"errors\"\n+ \"io\"\n\"sync\"\n\"time\"\n@@ -245,11 +247,86 @@ func (u *UpdateSender) RemovePath(pfx bnet.Prefix, p *route.Path) ... | Go | Apache License 2.0 | bio-routing/bio-rd | improved method signature |
89,491 | 17.07.2018 08:16:32 | -7,200 | 674799764de1df86b79618accc0098357585ba6b | family dependent add-path config | [
{
"change_type": "MODIFY",
"old_path": "config/peer.go",
"new_path": "config/peer.go",
"diff": "@@ -21,8 +21,6 @@ type Peer struct {\nPeerAS uint32\nPassive bool\nRouterID uint32\n- AddPathSend routingtable.ClientOptions\n- AddPathRecv bool\nRouteServerClient bool\nRouteReflectorClient bool\nRouteRe... | Go | Apache License 2.0 | bio-routing/bio-rd | family dependent add-path config |
89,491 | 17.07.2018 08:20:55 | -7,200 | d1edc53ded7c02d869c790b499643d7f00686747 | peer add-path per family | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/peer.go",
"new_path": "protocols/bgp/server/peer.go",
"diff": "@@ -29,8 +29,6 @@ type peer struct {\nfsmsMu sync.Mutex\nrouterID uint32\n- addPathSend routingtable.ClientOptions\n- addPathRecv bool\nreconnectInterval time.Duration\nkeepali... | Go | Apache License 2.0 | bio-routing/bio-rd | peer add-path per family |
89,491 | 17.07.2018 08:32:42 | -7,200 | d6015a645ff2efd1062a7a9fec82bfcc9b773839 | caps from family config | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/peer.go",
"new_path": "protocols/bgp/server/peer.go",
"diff": "@@ -195,39 +195,44 @@ func multiProtocolCapability(afi uint16) packet.Capability {\nfunc addPathCapabilities(c config.Peer) []packet.Capability {\ncaps := make([]packet.Capabil... | Go | Apache License 2.0 | bio-routing/bio-rd | caps from family config |
89,491 | 17.07.2018 08:37:10 | -7,200 | 6ad74e74d266294f7a3104c4d6956574dd78d34e | fsmAddressFamily now aware of add-path options per family | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -29,6 +29,9 @@ type fsmAddressFamily struct {\nupdateSender *UpdateSender\n+ addPathSend routingtable.ClientOptions\n+ addPathRecv bool\n+\niniti... | Go | Apache License 2.0 | bio-routing/bio-rd | fsmAddressFamily now aware of add-path options per family |
89,491 | 17.07.2018 08:46:40 | -7,200 | 2c04f298888b17808f524f97315475abf673a9ad | preperations to split options | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm.go",
"new_path": "protocols/bgp/server/fsm.go",
"diff": "@@ -113,6 +113,21 @@ func newFSM2(peer *peer) *FSM {\nreturn f\n}\n+func (fsm *FSM) addressFamily(afi uint16, safi uint8) *fsmAddressFamily {\n+ if safi != packet.UnicastSAFI {\n... | Go | Apache License 2.0 | bio-routing/bio-rd | preperations to split options |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.