author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
89,480 | 28.07.2022 11:25:13 | -7,200 | c7cfe37df6f556a1ffcddda2e5d44b8c725ef8ed | Fix BMP server and use adjRIBin factory | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -107,7 +107,7 @@ func (f *fsmAddressFamily) init(n *routingtable.Neighbor) {\n}\nfunc (f *fsmAddressFamily) bmpInit() {\n- f.adjRIBIn = adjRIBIn.... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix BMP server and use adjRIBin factory (#339)
Co-authored-by: Oliver Geiselhardt-Herms <ogeiselhardt-herms@cloudflare.com> |
89,480 | 28.07.2022 11:40:25 | -7,200 | eddc5abafa4d5a119cba210f7362c6a067abc146 | Remove stale syscallwrappers package | [
{
"change_type": "DELETE",
"old_path": "syscallwrappers/syscalls_linux.go",
"new_path": null,
"diff": "-package syscallwrappers\n-\n-/*\n-#cgo CFLAGS: -I/usr/include\n-#cgo LDFLAGS: -L/usr/lib\n-#include <sys/types.h>\n-#include <sys/socket.h>\n-#include <linux/if_packet.h>\n-#include <linux/filter.... | Go | Apache License 2.0 | bio-routing/bio-rd | Remove stale syscallwrappers package (#337) |
89,480 | 28.07.2022 11:38:28 | -7,200 | 225a40b833c43206a97b7c8a0d1b6927bc4c2381 | Fix invalid type assertion in BGP FSM | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -119,7 +119,7 @@ func (f *fsmAddressFamily) bmpInit() {\nfunc (f *fsmAddressFamily) bmpDispose() {\nf.rib.GetContributingASNs().Remove(f.fsm.peer... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix invalid type assertion in BGP FSM |
89,481 | 28.07.2022 18:07:03 | -7,200 | 6ad92e40e16d7b4282a8b7fe572da49071b8d679 | Propagate peer parameters to AdjRIBIn | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bgp_api_test.go",
"new_path": "protocols/bgp/server/bgp_api_test.go",
"diff": "@@ -24,6 +24,12 @@ import (\n)\nfunc TestDumpRIBInOut(t *testing.T) {\n+ peerParams := adjRIBIn.PeerParameters{\n+ RouterID: 0,\n+ ClusterID: 0,\n+ AddPathRX: t... | Go | Apache License 2.0 | bio-routing/bio-rd | Propagate peer parameters to AdjRIBIn (#341)
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 30.07.2022 01:26:04 | -7,200 | a8e61baa2976ce51f0f2a580b439d2934dc328c6 | Clearly indicate that postPolicy parameters are only used for BMP | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -160,30 +160,30 @@ func (f *fsmAddressFamily) dispose() {\nf.initialized = false\n}\n-func (f *fsmAddressFamily) processUpdate(u *packet.BGPUpdat... | Go | Apache License 2.0 | bio-routing/bio-rd | Clearly indicate that postPolicy parameters are only used for BMP (#342) |
89,481 | 30.07.2022 01:26:40 | -7,200 | 16ef92495294a3be23fd198a3ebbb0203b67ac25 | Fixed length calculation for paths with ClusterLists | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -182,6 +182,11 @@ func (b *BGPPath) Length() uint16 {\nclusterListLen += 3 + uint16(len(*b.ClusterList)*4)\n}\n+ originatorID := uint16(0)\n+ if b.BGPPathA.OriginatorID != 0 {\n+ originatorID = 4... | Go | Apache License 2.0 | bio-routing/bio-rd | Fixed length calculation for paths with ClusterLists (#343) |
89,495 | 13.05.2020 03:08:18 | -7,200 | 42505fbb560502ab683c175df48b1d96bb928ba2 | Copy PathIdentifier to path for BGP AddPath
To properly handle BGP AddPath (RFC7911) adjRIBIn needs to know the
PathIdentifier of the path, therefore we need to copy this attribute
onto the path when it is assembled for consumption by adjRIBIn. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -185,6 +185,7 @@ func (f *fsmAddressFamily) updates(u *packet.BGPUpdate, bmpPostPolicy bool) {\npath := f.newRoutePath()\npath.BMPPostPolicy = bm... | Go | Apache License 2.0 | bio-routing/bio-rd | Copy PathIdentifier to path for BGP AddPath
To properly handle BGP AddPath (RFC7911) adjRIBIn needs to know the
PathIdentifier of the path, therefore we need to copy this attribute
onto the path when it is assembled for consumption by adjRIBIn. |
89,481 | 02.08.2022 15:18:00 | -7,200 | ceb42c71658a392ad525640158c89f5b2ec77e66 | Propage Pre/Post policy indicator from BMP Reciver into BGPPath | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -165,7 +165,7 @@ func (f *fsmAddressFamily) processUpdate(u *packet.BGPUpdate, bmpPostPolicy bool\nreturn\n}\n- f.multiProtocolUpdates(u)\n+ f.mu... | Go | Apache License 2.0 | bio-routing/bio-rd | Propage Pre/Post policy indicator from BMP Reciver into BGPPath
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 09.08.2022 11:13:13 | -7,200 | f7e940f119958e06e868dd8c47e9e02f20ca575b | Fix nil pointer dereference in BGPPath.ToProto() | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -65,18 +65,27 @@ func (b *BGPPath) ToProto() *api.BGPPath {\na := &api.BGPPath{\nPathIdentifier: b.PathIdentifier,\n- NextHop: b.BGPPathA.NextHop.ToProto(),\n- LocalPref: b.BGPPathA.LocalPref,\n-... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix nil pointer dereference in BGPPath.ToProto()
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 09.08.2022 11:13:42 | -7,200 | 43396ce79248144561041b744a0f6757fbcf77c3 | Expose AddPath PathID on withdraw() | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -177,6 +177,7 @@ func (f *fsmAddressFamily) withdraws(u *packet.BGPUpdate, bmpPostPolicy bool) {\nf.adjRIBIn.RemovePath(r.Prefix, &route.Path{\nB... | Go | Apache License 2.0 | bio-routing/bio-rd | Expose AddPath PathID on withdraw()
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 10.08.2022 12:05:21 | -7,200 | 06af5c9d5dd4ef0ad46f5c21f5c8bd4771df24ef | Improve BMP peer handling for dynamci peers
Make sure a BMP peer is only added once, and we purge dynamic peers which
went away with sending an init message. | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris/main.go",
"new_path": "cmd/ris/main.go",
"diff": "@@ -58,7 +58,7 @@ func main() {\nlog.Errorf(\"unable to convert %q to net.IP\", r.Address)\nos.Exit(1)\n}\n- b.AddRouter(ip, r.Port, r.Passive)\n+ b.AddRouter(ip, r.Port, r.Passive, false)\n}\ns := riss... | Go | Apache License 2.0 | bio-routing/bio-rd | Improve BMP peer handling for dynamci peers (#352)
Make sure a BMP peer is only added once, and we purge dynamic peers which
went away with sending an init message.
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 09.08.2022 22:05:41 | -7,200 | a1767c32bc95b45077f949a9c006ea2e6a47e4ab | Split export checks for iBGP and eBGP paths | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out.go",
"diff": "@@ -62,7 +62,7 @@ func (a *AdjRIBOut) RouteCount() int64 {\nreturn a.rt.GetRouteCount()\n}\n-func (a *AdjRIBOut) bgpChecks(pfx *bnet.Prefix, p *route.Path) (r... | Go | Apache License 2.0 | bio-routing/bio-rd | Split export checks for iBGP and eBGP paths
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 07.08.2022 01:30:00 | -7,200 | 7ac141a65df238bb6f1d5e219b3fcaa86e29905a | Resolve some nits from go-staticcheck | [
{
"change_type": "MODIFY",
"old_path": "routingtable/adjRIBOut/adj_rib_out.go",
"new_path": "routingtable/adjRIBOut/adj_rib_out.go",
"diff": "@@ -4,7 +4,6 @@ import (\n\"fmt\"\n\"sync\"\n- \"github.com/bio-routing/bio-rd/net\"\nbnet \"github.com/bio-routing/bio-rd/net\"\n\"github.com/bio-routing/bio... | Go | Apache License 2.0 | bio-routing/bio-rd | Resolve some nits from go-staticcheck
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 10.08.2022 14:50:48 | -7,200 | fb8049a4adb4e727b13f6c4f533f8810bda21e27 | Fix nil pointer dereference in BMP server | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_server.go",
"new_path": "protocols/bgp/server/bmp_server.go",
"diff": "@@ -115,6 +115,12 @@ func (b *BMPServer) Listen(addr string) error {\nlog.Errorf(\"failed to add router: %v\", err)\ncontinue\n}\n+\n+ r = b.getRouter(tcpRemoteAddr... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix nil pointer dereference in BMP server
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 18.08.2022 08:49:38 | -7,200 | 2dea464bcadca5f597048a30b67272dfebc94c4c | Fix some more go-staticcheck nits | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path_test.go",
"new_path": "route/bgp_path_test.go",
"diff": "@@ -3,7 +3,6 @@ package route\nimport (\n\"testing\"\n- \"github.com/bio-routing/bio-rd/net\"\nbnet \"github.com/bio-routing/bio-rd/net\"\n\"github.com/bio-routing/bio-rd/protocols/bgp/typ... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix some more go-staticcheck nits (#355)
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,480 | 18.08.2022 11:41:43 | -7,200 | d11e3195a3f31ba9ac6c06a0795738c72e599906 | Fix BGP path tests | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path_test.go",
"new_path": "route/bgp_path_test.go",
"diff": "@@ -586,8 +586,8 @@ func TestLength(t *testing.T) {\n},\nBGPPathA: &BGPPathA{\nOriginatorID: 10,\n- Source: net.IPv4(0).Ptr(),\n- NextHop: net.IPv4(0).Ptr(),\n+ Source: bnet.IPv4(0).Ptr(),... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix BGP path tests (#358)
Co-authored-by: Oliver Geiselhardt-Herms <ogeiselhardt-herms@cloudflare.com> |
89,480 | 18.08.2022 09:43:11 | -7,200 | 9c9d572fcdce9dcdd8deb7222f8cf4d3bdb48cbe | Monitoring: Expose received BGP end of RIB marker | [
{
"change_type": "MODIFY",
"old_path": "metrics/bgp/adapter/prom/bgp_prom_adapter.go",
"new_path": "metrics/bgp/adapter/prom/bgp_prom_adapter.go",
"diff": "@@ -30,10 +30,12 @@ var (\nroutesSentDesc *prometheus.Desc\nroutesRejectedDesc *prometheus.Desc\nroutesAcceptedDesc *prometheus.Desc\n+ endOfRIB... | Go | Apache License 2.0 | bio-routing/bio-rd | Monitoring: Expose received BGP end of RIB marker |
89,480 | 18.08.2022 16:17:10 | -7,200 | 56966a600dcb4e341472b4a75249e6984be7bd30 | RIS: Add flag to allow sessions from anywhere | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris/main.go",
"new_path": "cmd/ris/main.go",
"diff": "@@ -25,22 +25,29 @@ var (\nhttpPort = flag.Uint(\"http_port\", 4320, \"HTTP server port\")\nbmpListenAddr = flag.String(\"bmp_addr\", \"0.0.0.0:30119\", \"BMP listen addr (set empty to disable listening... | Go | Apache License 2.0 | bio-routing/bio-rd | RIS: Add flag to allow sessions from anywhere (#359)
Co-authored-by: Oliver Geiselhardt-Herms <ogeiselhardt-herms@cloudflare.com> |
89,480 | 18.08.2022 16:56:07 | -7,200 | af536bd6532580416fd4730a769b0a3e9fa32623 | BMP: Fix end of rib marker metric | [
{
"change_type": "MODIFY",
"old_path": "metrics/bgp/adapter/prom/bgp_prom_adapter.go",
"new_path": "metrics/bgp/adapter/prom/bgp_prom_adapter.go",
"diff": "@@ -195,5 +195,5 @@ func collectForFamilyRouter(ch chan<- prometheus.Metric, family *metrics.BGPAddr\nif family.EndOfRIBMarkerReceived {\neor = ... | Go | Apache License 2.0 | bio-routing/bio-rd | BMP: Fix end of rib marker metric (#360)
Co-authored-by: Oliver Geiselhardt-Herms <ogeiselhardt-herms@cloudflare.com> |
89,480 | 29.08.2022 11:15:08 | -7,200 | 493375ed0f925ea2fe3b841656948b6fee9173e3 | Rework the IP datatype to be a value by default and change prefix to
Rework the IP data type to be a value by default and change prefix to contain an IP and not a pointer | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -27,8 +27,8 @@ func (ip IP) Ptr() *IP {\n}\n// IPFromProtoIP creates an IP address from a proto IP\n-func IPFromProtoIP(addr *api.IP) *IP {\n- return &IP{\n+func IPFromProtoIP(addr *api.IP) IP {\n+ return IP{\nh... | Go | Apache License 2.0 | bio-routing/bio-rd | Rework the IP datatype to be a value by default and change prefix to (#366)
Rework the IP data type to be a value by default and change prefix to contain an IP and not a pointer |
89,481 | 29.08.2022 11:15:54 | -7,200 | 5ad2bb263ba15b3b7cdb33fa7434984efe7fe7b2 | MP_(UN)REACH_NLRI are BGP Path Attributes | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/packet/bgp.go",
"new_path": "protocols/bgp/packet/bgp.go",
"diff": "@@ -76,6 +76,8 @@ const (\nCommunitiesAttr = 8\nOriginatorIDAttr = 9\nClusterListAttr = 10\n+ MultiProtocolReachNLRIAttr = 14\n+ MultiProtocolUnreachNLRIAttr = 15\nAS4PathAttr = ... | Go | Apache License 2.0 | bio-routing/bio-rd | MP_(UN)REACH_NLRI are BGP Path Attributes (#354) |
89,480 | 29.08.2022 18:25:03 | -7,200 | 3cfb73ad0c8e9ccab8146feefe94cb2555497381 | Implement BGP end of RIB marker and add it to RIS | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris/api/ris.pb.go",
"new_path": "cmd/ris/api/ris.pb.go",
"diff": "@@ -609,6 +609,7 @@ type RIBUpdate struct {\nAdvertisement bool `protobuf:\"varint,1,opt,name=advertisement,proto3\" json:\"advertisement,omitempty\"`\nIsInitialDump bool `protobuf:\"varint,... | Go | Apache License 2.0 | bio-routing/bio-rd | Implement BGP end of RIB marker and add it to RIS (#367)
Co-authored-by: Oliver Geiselhardt-Herms <ogeiselhardt-herms@cloudflare.com>
Co-authored-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,480 | 30.08.2022 10:51:21 | -7,200 | 162a33ffd8c75c1aac56f32ef336e39df982a08e | Signal End-Of-RIB when registering client on LocRIB | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family_test.go",
"new_path": "protocols/bgp/server/fsm_address_family_test.go",
"diff": "package server\nimport (\n+ \"bytes\"\n\"testing\"\n\"github.com/bio-routing/bio-rd/protocols/bgp/packet\"\n@@ -10,6 +11,8 @@ import (\n\"... | Go | Apache License 2.0 | bio-routing/bio-rd | Signal End-Of-RIB when registering client on LocRIB (#368) |
89,481 | 30.08.2022 16:47:18 | -7,200 | c86218229078f9800468481044c37576448c5bd4 | Skip build with fixed Ubuntu version, stick to latest only. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/tests.yml",
"new_path": ".github/workflows/tests.yml",
"diff": "@@ -5,7 +5,7 @@ jobs:\nstrategy:\nmatrix:\ngo-version: [1.19.x]\n- platform: [ubuntu-latest, ubuntu-18.04]\n+ platform: [ubuntu-latest]\nruns-on: ${{ matrix.platform }}\nsteps:\n... | Go | Apache License 2.0 | bio-routing/bio-rd | Skip build with fixed Ubuntu version, stick to latest only. (#371)
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 03.09.2022 19:42:24 | -7,200 | e30fc315568e93b0978bb07dde6843cc77ab8efb | Clean up naming for Prefix.pfxlen (to Prefix.len)
Closes | [
{
"change_type": "MODIFY",
"old_path": "net/api/net.pb.go",
"new_path": "net/api/net.pb.go",
"diff": "@@ -72,7 +72,7 @@ type Prefix struct {\nunknownFields protoimpl.UnknownFields\nAddress *IP `protobuf:\"bytes,1,opt,name=address,proto3\" json:\"address,omitempty\"`\n- Pfxlen uint32 `protobuf:\"vari... | Go | Apache License 2.0 | bio-routing/bio-rd | Clean up naming for Prefix.pfxlen (to Prefix.len) (#374)
Closes #150
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,480 | 05.09.2022 17:56:23 | -7,200 | ea9e89ed428d76bfc15f721924c6003e43cf7d3c | RIS: Catch nil pointer in cli and expose EOR | [
{
"change_type": "MODIFY",
"old_path": "cmd/riscli/observe_rib.go",
"new_path": "cmd/riscli/observe_rib.go",
"diff": "@@ -79,6 +79,12 @@ func observeRIB(c pb.RoutingInformationServiceClient, routerName string, vrfID u\nreturn fmt.Errorf(\"Receive failed: %w\", err)\n}\n+ if r.EndOfRib {\n+ fmt.Print... | Go | Apache License 2.0 | bio-routing/bio-rd | RIS: Catch nil pointer in cli and expose EOR (#375)
Co-authored-by: Oliver Geiselhardt-Herms <ogeiselhardt-herms@cloudflare.com> |
89,480 | 05.09.2022 18:39:15 | -7,200 | d2e8978ba42d54b6bae618a22bde7a26f14f7c50 | BMP: Cover router ready check with tests | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_router_test.go",
"new_path": "protocols/bgp/server/bmp_router_test.go",
"diff": "package server\n+import (\n+ \"sync/atomic\"\n+ \"testing\"\n+\n+ \"github.com/stretchr/testify/assert\"\n+)\n+\n+func TestReady(t *testing.T) {\n+ atomic... | Go | Apache License 2.0 | bio-routing/bio-rd | BMP: Cover router ready check with tests (#376) |
89,480 | 06.09.2022 10:42:56 | -7,200 | 634c76c2540675e185dd6d044b49d55930fe2dc7 | RIS: Accept post-policy messages only | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_router.go",
"new_path": "protocols/bgp/server/bmp_router.go",
"diff": "@@ -210,6 +210,10 @@ func (r *Router) processMsg(msg []byte) {\nfunc (r *Router) processRouteMonitoringMsg(msg *bmppkt.RouteMonitoringMsg) {\natomic.AddUint64(&r.co... | Go | Apache License 2.0 | bio-routing/bio-rd | RIS: Accept post-policy messages only (#378) |
89,480 | 07.09.2022 11:44:34 | -7,200 | bb8b173534913d17b1a75a1e168dab6134e3edf3 | BMP: Allow ignoring BGP sessions based on peer ASN | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris/config/config.go",
"new_path": "cmd/ris/config/config.go",
"diff": "@@ -10,6 +10,7 @@ import (\n// RISConfig is the config of RIS instance\ntype RISConfig struct {\nBMPServers []BMPServer `yaml:\"bmp_servers\"`\n+ IgnorePeerASNs []uint32 `yaml:\"ignore... | Go | Apache License 2.0 | bio-routing/bio-rd | BMP: Allow ignoring BGP sessions based on peer ASN (#379) |
89,481 | 13.09.2022 12:17:18 | -7,200 | e960ddbd063b2a4f35b5cc889910f29421a47502 | Rename some remaining occurances of peerAttr(s) | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -80,25 +80,25 @@ func (f *fsmAddressFamily) dumpRIBIn() []*route.Route {\n}\ntype adjRIBInFactoryI interface {\n- New(exportFilterChain filter.Ch... | Go | Apache License 2.0 | bio-routing/bio-rd | Rename some remaining occurances of peerAttr(s) (#381)
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,480 | 14.09.2022 11:07:57 | -7,200 | 66f4c5b3c62ebe2573ff3ab4e88be1ff4e74fb03 | BMP: Implement serialization of BMP messages | [
{
"change_type": "MODIFY",
"old_path": "protocols/bmp/packet/initiation_message.go",
"new_path": "protocols/bmp/packet/initiation_message.go",
"diff": "@@ -3,6 +3,8 @@ package packet\nimport (\n\"bytes\"\n\"fmt\"\n+\n+ \"github.com/bio-routing/tflow2/convert\"\n)\n// InitiationMessage represents an ... | Go | Apache License 2.0 | bio-routing/bio-rd | BMP: Implement serialization of BMP messages (#380) |
89,481 | 14.09.2022 11:51:19 | -7,200 | ad0bc33ef996bec588de04fed2ee98e760182ddb | Add IP.To16BytesArray() method | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -209,6 +209,16 @@ func (ip IP) Bytes() []byte {\nreturn ip.bytesIPv4()\n}\n+func (ip IP) To16BytesArray() [16]byte {\n+ ret := [16]byte{}\n+\n+ for i, x := range ip.bytesIPv6() {\n+ ret[i] = x\n+ }\n+\n+ return ... | Go | Apache License 2.0 | bio-routing/bio-rd | Add IP.To16BytesArray() method (#384) |
89,481 | 15.09.2022 10:25:22 | -7,200 | df4fc633a3e47556501f980436e700bae23a4d09 | Rename BMP Server to BMP receiver
This is a preparation to implement a BMP sender :) | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris/main.go",
"new_path": "cmd/ris/main.go",
"diff": "@@ -49,7 +49,7 @@ func main() {\ncfg = c\n}\n- b := server.NewServer(server.BMPServerConfig{\n+ b := server.NewBMPReceiver(server.BMPReceiverConfig{\nKeepalivePeriod: time.Duration(*tcpKeepaliveInterval... | Go | Apache License 2.0 | bio-routing/bio-rd | Rename BMP Server to BMP receiver (#385)
This is a preparation to implement a BMP sender :)
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 15.09.2022 10:44:12 | -7,200 | 32000ff8c771ef8e5fc6c1ecdb58668c5905c7d9 | bnet.IP.String() should be called by value | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -174,7 +174,7 @@ func (ip *IP) Compare(other *IP) int8 {\n}\n// String returns string representation of an IP address\n-func (ip *IP) String() string {\n+func (ip IP) String() string {\nif !ip.isLegacy {\nreturn... | Go | Apache License 2.0 | bio-routing/bio-rd | bnet.IP.String() should be called by value (#386)
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,492 | 15.09.2022 16:57:01 | -3,600 | 146520669928d3d5e4470161397df90d01785663 | net/ip: compress ipv6 string | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -183,15 +183,45 @@ func (ip IP) String() string {\n}\nfunc (ip IP) stringIPv6() string {\n- return fmt.Sprintf(\"%X:%X:%X:%X:%X:%X:%X:%X\",\n- ip.higher&0xFFFF000000000000>>48,\n- ip.higher&0x0000FFFF00000000>>3... | Go | Apache License 2.0 | bio-routing/bio-rd | net/ip: compress ipv6 string |
89,481 | 15.09.2022 18:18:46 | -7,200 | 6258a94df14128b10da6c8e13ac8627a90768fa3 | Update tests to reflect IPv6 representation change | [
{
"change_type": "MODIFY",
"old_path": "net/ip_test.go",
"new_path": "net/ip_test.go",
"diff": "@@ -242,15 +242,19 @@ func TestIPString(t *testing.T) {\n},\n{\nip: IPv6(0, 0),\n- expected: \"0:0:0:0:0:0:0:0\",\n+ expected: \"::\",\n+ },\n+ {\n+ ip: IPv6FromBlocks(9026, 2069, 0, 0, 0, 0, 0, 4369),\n+... | Go | Apache License 2.0 | bio-routing/bio-rd | Update tests to reflect IPv6 representation change
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 21.09.2022 15:32:38 | -7,200 | bc75cd4dfb18c15b983836361e0f6f5e0888ca6a | Set LTime for IPv4 withdraws too (needed for BMP) | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -185,14 +185,15 @@ func (f *fsmAddressFamily) processUpdate(u *packet.BGPUpdate, bmpPostPolicy bool\nf.endOfRIBMarkerReceived.Store(true)\n}\n- f... | Go | Apache License 2.0 | bio-routing/bio-rd | Set LTime for IPv4 withdraws too (needed for BMP)
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 21.09.2022 15:47:19 | -7,200 | 19a0bae7b21f9a0eb9106cd964ad1316d036f8a7 | Make sure LTime is set even if the BMP station didn't set it | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_router.go",
"new_path": "protocols/bgp/server/bmp_router.go",
"diff": "@@ -248,7 +248,13 @@ func (r *Router) processRouteMonitoringMsg(msg *bmppkt.RouteMonitoringMsg) {\nopt := s.fsm.decodeOptions()\nopt.Use32BitASN = !msg.PerPeerHeade... | Go | Apache License 2.0 | bio-routing/bio-rd | Make sure LTime is set even if the BMP station didn't set it
Signed-off-by: Maximilian Wilhelm <maximilian@cloudflare.com> |
89,481 | 01.10.2022 22:53:28 | -7,200 | c8cf368304ce3e6f8210aaac2cfa3dfa6beaacc7 | Add String()/Print() for StaticPath and add lots of path tests | [
{
"change_type": "MODIFY",
"old_path": "route/path.go",
"new_path": "route/path.go",
"diff": "@@ -177,7 +177,7 @@ func pathsContains(needle *Path, haystack []*Path) bool {\nfunc (p *Path) String() string {\nswitch p.Type {\ncase StaticPathType:\n- return \"not implemented yet\"\n+ return p.StaticPat... | Go | Apache License 2.0 | bio-routing/bio-rd | Add String()/Print() for StaticPath and add lots of path tests
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 02.10.2022 00:27:14 | -7,200 | 2d974bb609f425908065a32c055c029881fb9d7f | Only create optinal BGP path attributes from proto, when present
Communities, LargeCommunities, ClusterList and UnknownAttributes are optional
attributes of BGPPathA. Only allocate memory for them if a value is present.
Also use copy() instead of manual for loops to copy attributes from/to proto. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -94,16 +94,12 @@ func (b *BGPPath) ToProto() *api.BGPPath {\nif a.ClusterList != nil {\na.ClusterList = make([]uint32, len(*b.ClusterList))\n- for i := range *b.ClusterList {\n- a.ClusterList[i] ... | Go | Apache License 2.0 | bio-routing/bio-rd | Only create optinal BGP path attributes from proto, when present
Communities, LargeCommunities, ClusterList and UnknownAttributes are optional
attributes of BGPPathA. Only allocate memory for them if a value is present.
Also use copy() instead of manual for loops to copy attributes from/to proto.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 02.10.2022 00:30:11 | -7,200 | 0f58f9460b213d41f8037d1f4d48a7db51bbef81 | Add more tests for Route related methods | [
{
"change_type": "MODIFY",
"old_path": "route/route_test.go",
"new_path": "route/route_test.go",
"diff": "package route\nimport (\n+ \"fmt\"\n\"testing\"\n\"github.com/stretchr/testify/assert\"\nbnet \"github.com/bio-routing/bio-rd/net\"\n\"github.com/bio-routing/bio-rd/protocols/bgp/types\"\n+ \"gi... | Go | Apache License 2.0 | bio-routing/bio-rd | Add more tests for Route related methods
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 30.09.2022 19:32:53 | -7,200 | 15324add4b74210c998906a78ea922765afb28ec | Reflect if a BMP Peer Up/Down message has been ignored in the logs | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_router.go",
"new_path": "protocols/bgp/server/bmp_router.go",
"diff": "@@ -226,14 +226,12 @@ func (r *Router) processMsg(msg []byte) {\nfunc (r *Router) processRouteMonitoringMsg(msg *bmppkt.RouteMonitoringMsg) {\natomic.AddUint64(&r.c... | Go | Apache License 2.0 | bio-routing/bio-rd | Reflect if a BMP Peer Up/Down message has been ignored in the logs
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,479 | 24.11.2022 19:08:29 | -3,600 | 045b2a6756dfe41fd976425da302aa1687770863 | fix: example bgp with v6 and cleanup | [
{
"change_type": "RENAME",
"old_path": "examples/bgp/main_ipv4.go",
"new_path": "examples/bgp/ipv4.go",
"diff": "-//go:build !ipv6\n-// +build !ipv6\n-\npackage main\nimport (\n- \"net\"\n\"time\"\n- \"github.com/bio-routing/bio-rd/routingtable/vrf\"\n- \"google.golang.org/grpc\"\n-\nbnet \"github.c... | Go | Apache License 2.0 | bio-routing/bio-rd | fix: example bgp with v6 and cleanup (#393) |
89,479 | 27.11.2022 10:07:51 | -3,600 | 3bb191ba7a478cd6d5958245de96a5a13aed47dc | fix: do not reconnect bgp from passive side | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm.go",
"new_path": "protocols/bgp/server/fsm.go",
"diff": "@@ -95,7 +95,7 @@ func NewPassiveFSM(peer *peer, con *net.TCPConn) *FSM {\nreturn fsm\n}\n-// NewActiveFSM initiates a new passive FSM\n+// NewActiveFSM initiates a new active FS... | Go | Apache License 2.0 | bio-routing/bio-rd | fix: do not reconnect bgp from passive side (#394) |
89,479 | 06.12.2022 13:54:08 | -3,600 | a12b0a4148bee5d4a16a9439a7ac53edc71726be | remove debugging output from bgp fsm | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_established.go",
"new_path": "protocols/bgp/server/fsm_established.go",
"diff": "@@ -152,7 +152,6 @@ func (s *establishedState) msgReceived(data []byte, opt *packet.DecodeOptions, b\nswitch msg.Header.Type {\ncase packet.NotificationMs... | Go | Apache License 2.0 | bio-routing/bio-rd | remove debugging output from bgp fsm |
89,479 | 06.12.2022 21:50:33 | -3,600 | cb1617e10b9e14324cfba17b1fc79063b0586921 | fix: nil pointer for local address with ebgp | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/peer.go",
"new_path": "protocols/bgp/server/peer.go",
"diff": "@@ -269,6 +269,7 @@ func newPeer(c PeerConfig, server *bgpServer) (*peer, error) {\nserver: server,\nconfig: &c,\naddr: c.PeerAddress,\n+ localAddr: c.LocalAddress,\nttl: c.TTL... | Go | Apache License 2.0 | bio-routing/bio-rd | fix: nil pointer for local address with ebgp (#397) |
89,479 | 08.12.2022 14:55:16 | -3,600 | 0b34a7e3d1096b5a0978188bcc6beb5ddc984e15 | fix: metrics for bgp labels cardinality | [
{
"change_type": "MODIFY",
"old_path": "metrics/bgp/adapter/prom/bgp_prom_adapter.go",
"new_path": "metrics/bgp/adapter/prom/bgp_prom_adapter.go",
"diff": "@@ -169,7 +169,7 @@ func collectForFamily(ch chan<- prometheus.Metric, family *metrics.BGPAddressFam\nif family.EndOfRIBMarkerReceived {\neor = ... | Go | Apache License 2.0 | bio-routing/bio-rd | fix: metrics for bgp labels cardinality |
89,481 | 06.01.2023 12:29:44 | -3,600 | 601fe705a747680227989918c3ff03a1c565869c | Index VRFs by name instead of RD
If we only know the RD (because we only get the RD for BMP for example),
we use the human readable version of the RD as VRF name. | [
{
"change_type": "MODIFY",
"old_path": "cmd/bio-rd/main.go",
"new_path": "cmd/bio-rd/main.go",
"diff": "@@ -75,7 +75,7 @@ func main() {\nos.Exit(1)\n}\n- vrfReg.CreateVRFIfNotExists(\"master\", 0)\n+ vrfReg.CreateVRFIfNotExists(vrf.DefaultVRFName, 0)\ngo configReloader()\nsigHUP <- syscall.SIGHUP\n@... | Go | Apache License 2.0 | bio-routing/bio-rd | Index VRFs by name instead of RD (#405)
If we only know the RD (because we only get the RD for BMP for example),
we use the human readable version of the RD as VRF name.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
Signed-off-by: Oliver Herms <oliver.peter.herms@gmail.com> |
89,480 | 06.01.2023 16:04:15 | -3,600 | 8269abc58347726ad5cb5053bd6b346881933222 | BGP: Bind to VRF device on outgoing TCP con | [
{
"change_type": "MODIFY",
"old_path": "net/tcp/tcp.go",
"new_path": "net/tcp/tcp.go",
"diff": "@@ -24,7 +24,7 @@ type Conn struct {\n}\n// Dial established a new TCP connection\n-func Dial(laddr, raddr *net.TCPAddr, ttl uint8, md5Secret string, noRoute bool) (*Conn, error) {\n+func Dial(laddr, radd... | Go | Apache License 2.0 | bio-routing/bio-rd | BGP: Bind to VRF device on outgoing TCP con (#406) |
89,481 | 09.01.2023 19:24:33 | -3,600 | 7621c8af74cc13c53f88b79f72fa037bbb1b8ec2 | Move contributing ASNs into VRF | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bgp_api_test.go",
"new_path": "protocols/bgp/server/bgp_api_test.go",
"diff": "@@ -34,6 +34,8 @@ func TestDumpRIBInOut(t *testing.T) {\nAddPathTX: true,\n}\n+ v, _ := vrf.New(\"vrf0\", 0)\n+\ntests := []struct {\nname string\napisrv *BGPAP... | Go | Apache License 2.0 | bio-routing/bio-rd | Move contributing ASNs into VRF
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 09.01.2023 19:25:27 | -3,600 | d98fea0cea93b516fc86da1754e0379478ecb57f | Track Route Reflection Cluster IDs within the VRF scope
To make sure we don't have any Cluster list loops we need to check all the
Cluster IDs used by all sessions within a VRF as in theory there could be
multiple iBGP sessions with different cluster IDs set. | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -95,6 +95,9 @@ func (f *fsmAddressFamily) init() {\nf.adjRIBIn = f.fsm.peer.adjRIBInFactory.New(f.importFilterChain, f.fsm.peer.vrf, sessionAttrs... | Go | Apache License 2.0 | bio-routing/bio-rd | Track Route Reflection Cluster IDs within the VRF scope
To make sure we don't have any Cluster list loops we need to check all the
Cluster IDs used by all sessions within a VRF as in theory there could be
multiple iBGP sessions with different cluster IDs set.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 14.01.2023 02:07:47 | -3,600 | 15e330c654f77362faced4a56cd10f17f64a6530 | Generalize set nexthop filter action | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -795,3 +795,11 @@ func (b *BGPPath) LargeCommunitiesString() string {\nreturn str.String()\n}\n+\n+func (b *BGPPath) GetNextHop() *bnet.IP {\n+ if b == nil || b.BGPPathA == nil {\n+ return nil\n+... | Go | Apache License 2.0 | bio-routing/bio-rd | Generalize set nexthop filter action
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 15.01.2023 13:01:00 | -3,600 | a442fc7d6c7193d22afdff43a6be9a3423c3947d | Also copy BGP path attrs when copying a BGPPath
BGPPath.Copy() previously did not copy the BGP path attributes associated
with a BGPPath leading to changes made to BGP attributes further down the
propagation chain overwriting path attributes in routing tables higher up
the chain. | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -685,6 +685,7 @@ func (b *BGPPath) Copy() *BGPPath {\n}\ncp := *b\n+ cp.BGPPathA = b.BGPPathA.Copy()\nif cp.ASPath != nil {\nasPath := make(types.ASPath, len(*cp.ASPath))\n@@ -713,6 +714,16 @@ fu... | Go | Apache License 2.0 | bio-routing/bio-rd | Also copy BGP path attrs when copying a BGPPath
BGPPath.Copy() previously did not copy the BGP path attributes associated
with a BGPPath leading to changes made to BGP attributes further down the
propagation chain overwriting path attributes in routing tables higher up
the chain.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 16.01.2023 10:34:39 | -3,600 | 2e2e06bd0a47b4d3a228700cf10eeb545cac6303 | Fix filters when setting/overwriting path attributes
Filters did not work correctly when setting path attributes, and any changes
to the paths were be lost. | [
{
"change_type": "MODIFY",
"old_path": "routingtable/filter/filter.go",
"new_path": "routingtable/filter/filter.go",
"diff": "@@ -36,11 +36,13 @@ func (f *Filter) Process(p *net.Prefix, pa *route.Path) FilterResult {\nres := t.Process(p, pa)\nif res.Terminate {\nreturn FilterResult{\n- Path: pa,\n+ ... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix filters when setting/overwriting path attributes
Filters did not work correctly when setting path attributes, and any changes
to the paths were be lost.
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 16.01.2023 10:35:00 | -3,600 | 1af00100eff689933183e2a66e5aa9242e3a897c | Add support to filter for routing protocols | [
{
"change_type": "MODIFY",
"old_path": "routingtable/filter/term_condition.go",
"new_path": "routingtable/filter/term_condition.go",
"diff": "@@ -10,6 +10,7 @@ type TermCondition struct {\nrouteFilters []*RouteFilter\ncommunityFilters []*CommunityFilter\nlargeCommunityFilters []*LargeCommunityFilter... | Go | Apache License 2.0 | bio-routing/bio-rd | Add support to filter for routing protocols
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 16.01.2023 10:35:11 | -3,600 | e82f805cfb2f8db8d9f97ebb5d876a4ff238ed5e | Fix nil pointer dereference in StaticPath.String() | [
{
"change_type": "MODIFY",
"old_path": "route/static.go",
"new_path": "route/static.go",
"diff": "@@ -56,7 +56,11 @@ func (s *StaticPath) Copy() *StaticPath {\n// Print all known information about a route in logfile friendly format\nfunc (s *StaticPath) String() string {\n- return fmt.Sprintf(\"Next... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix nil pointer dereference in StaticPath.String()
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 16.01.2023 10:35:20 | -3,600 | 606c7371f08d7de2d1cf7a9754e6f7272f1d5e3d | Fix corner case where terminating filter action modifies the path | [
{
"change_type": "MODIFY",
"old_path": "routingtable/filter/term.go",
"new_path": "routingtable/filter/term.go",
"diff": "@@ -50,7 +50,7 @@ func (t *Term) processActions(p *net.Prefix, pa *route.Path) TermResult {\nres := action.Do(p, pa)\nif res.Terminate {\nreturn TermResult{\n- Path: pa,\n+ Path:... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix corner case where terminating filter action modifies the path
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 16.01.2023 10:41:58 | -3,600 | ded920437f015c77138bf710b469a33a78203580 | Add NewASPath() helper to ease testing | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/types/as_path.go",
"new_path": "protocols/bgp/types/as_path.go",
"diff": "@@ -193,3 +193,16 @@ func (pa ASPath) Length() (ret uint16) {\nreturn\n}\n+\n+func NewASPath(asns []uint32) *ASPath {\n+ asp := ASPath{\n+ ASPathSegment{\n+ Type: ASSequenc... | Go | Apache License 2.0 | bio-routing/bio-rd | Add NewASPath() helper to ease testing
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,481 | 16.01.2023 11:05:38 | -3,600 | 83246eb6bc208d06827bf6323d12c65dfd466529 | Add redistribution support (Static -> BGP for now) | [
{
"change_type": "MODIFY",
"old_path": "route/bgp_path.go",
"new_path": "route/bgp_path.go",
"diff": "@@ -40,6 +40,13 @@ type BGPPathA struct {\nOnlyToCustomer uint32\n}\n+func NewBGPPath() *BGPPath {\n+ return &BGPPath{\n+ ASPath: types.NewASPath([]uint32{}),\n+ BGPPathA: NewBGPPathA(),\n+ }\n+}\n+... | Go | Apache License 2.0 | bio-routing/bio-rd | Add redistribution support (Static -> BGP for now)
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> |
89,480 | 10.01.2023 22:31:15 | -3,600 | 7947962ed590124a986bcd4cdb10e8d9d5e2ad12 | BGP: Implement integration test | [
{
"change_type": "MODIFY",
"old_path": "cmd/bio-rd/main.go",
"new_path": "cmd/bio-rd/main.go",
"diff": "@@ -74,12 +74,7 @@ func main() {\nListenAddrsByVRF: listenAddrsByVRF,\n}\nbgpSrv = bgpserver.NewBGPServer(bgpSrvCfg)\n-\n- err = bgpSrv.Start()\n- if err != nil {\n- log.Errorf(\"Unable to start B... | Go | Apache License 2.0 | bio-routing/bio-rd | BGP: Implement integration test |
89,480 | 27.07.2022 00:12:54 | -7,200 | bfa84c4dcfde42fe9cdee6f2b36273645d2da54a | ISIS: Generate local LSPDUs | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -290,7 +290,7 @@ func (ip *IP) SizeBytes() uint8 {\n}\n// ToUint32 return the rightmost 32 bits of an 'IP'\n-func (ip *IP) ToUint32() uint32 {\n+func (ip IP) ToUint32() uint32 {\nreturn uint32(^uint64(0) >> 32 &... | Go | Apache License 2.0 | bio-routing/bio-rd | ISIS: Generate local LSPDUs |
89,487 | 19.01.2023 17:46:36 | -3,600 | e47d5546a1b24054e04fa324f61c00aa91ad37f7 | BMP Receiver: Close Connection Explicitly and with log message | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_receiver.go",
"new_path": "protocols/bgp/server/bmp_receiver.go",
"diff": "@@ -113,11 +113,14 @@ func (b *BMPReceiver) Serve() error {\n}\n// Do we know this router from configuration or have seen it before?\n- r := b.getRouter(c.Remot... | Go | Apache License 2.0 | bio-routing/bio-rd | BMP Receiver: Close Connection Explicitly and with log message (#417)
Co-authored-by: Marvin Gaube <marvin.gaube@exaring.de> |
89,480 | 28.01.2023 22:24:07 | -3,600 | c9e7c0f83455ab1b82e2d28eedae5ad89cf8c60a | ISIS: Extend integration testing | [
{
"change_type": "MODIFY",
"old_path": "cmd/bio-rd/is-is.go",
"new_path": "cmd/bio-rd/is-is.go",
"diff": "@@ -28,10 +28,7 @@ func configureProtocolsISIS(isis *config.ISIS) error {\nreturn fmt.Errorf(\"unable to create ISIS server: %w\", err)\n}\n- err = isisSrv.Start()\n- if err != nil {\n- return f... | Go | Apache License 2.0 | bio-routing/bio-rd | ISIS: Extend integration testing (#418) |
89,480 | 29.01.2023 17:04:05 | -3,600 | 73a864ef687bd2ff4d19d2ef9ff599c75c0176c7 | ISIS: LSP: Add extened IS + IP reachability TLVs | [
{
"change_type": "MODIFY",
"old_path": "net/ethernet/ethernet_mock.go",
"new_path": "net/ethernet/ethernet_mock.go",
"diff": "@@ -74,3 +74,14 @@ func (mei *MockEthernetInterface) ReceiveAtRemote() (MACAddr, []byte) {\np := <-mei.sendCh\nreturn p.mac, p.packet\n}\n+\n+func (mei *MockEthernetInterface... | Go | Apache License 2.0 | bio-routing/bio-rd | ISIS: LSP: Add extened IS + IP reachability TLVs |
89,480 | 01.02.2023 19:01:08 | -3,600 | 0a935e68965ecbe0fcc8820548ec37552ab69ca1 | ISIS: Minor improvements | [
{
"change_type": "MODIFY",
"old_path": "net/ip.go",
"new_path": "net/ip.go",
"diff": "@@ -9,6 +9,10 @@ import (\nbmath \"github.com/bio-routing/bio-rd/util/math\"\n)\n+var (\n+ v4Loopback = NewPfx(IPv4FromOctets(127, 0, 0, 0), 8).Ptr()\n+)\n+\n// IP represents an IPv4 or IPv6 address\ntype IP struct... | Go | Apache License 2.0 | bio-routing/bio-rd | ISIS: Minor improvements (#424) |
89,480 | 02.02.2023 09:00:50 | -3,600 | 2daf2377010be37cfa25409dde7bd9b7a3628221 | ISIS: Refactor integration test | [
{
"change_type": "MODIFY",
"old_path": "tests/isis_integration_test.go",
"new_path": "tests/isis_integration_test.go",
"diff": "package tests\nimport (\n+ \"sort\"\n\"testing\"\n\"time\"\n@@ -23,66 +24,50 @@ type neighbor struct {\ninterfaceIP bnet.IP\n}\n-func TestISISServer(t *testing.T) {\n- host... | Go | Apache License 2.0 | bio-routing/bio-rd | ISIS: Refactor integration test (#425) |
89,487 | 01.02.2023 15:34:12 | -3,600 | 2c624b3e9ce643c443bfc8d3b521b3afa9ef9ced | Improve RIBNotReady call and output | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris/risserver/server.go",
"new_path": "cmd/ris/risserver/server.go",
"diff": "@@ -193,7 +193,7 @@ func (s *Server) ObserveRIB(req *pb.ObserveRIBRequest, stream pb.RoutingInformat\nreturn status.New(codes.Unavailable, wrapGetRIBErr(err, req.Router, vrfID, i... | Go | Apache License 2.0 | bio-routing/bio-rd | Improve RIBNotReady call and output |
89,487 | 01.02.2023 16:13:46 | -3,600 | 93639fcba11468c6d0a6a0536abecac4f56780b7 | end of rib for v6 | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/fsm_address_family.go",
"new_path": "protocols/bgp/server/fsm_address_family.go",
"diff": "@@ -202,6 +202,11 @@ func (f *fsmAddressFamily) processUpdate(u *packet.BGPUpdate, bmpPostPolicy bool\nf.withdraws(u, bmpPostPolicy, timestamp)\nf.u... | Go | Apache License 2.0 | bio-routing/bio-rd | end of rib for v6 |
89,487 | 01.02.2023 16:35:45 | -3,600 | 0da91b719f02d34e16bd5049586b539185dc3d56 | Update Router Ready Interface | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris-mirror/rismirror/router.go",
"new_path": "cmd/ris-mirror/rismirror/router.go",
"diff": "@@ -38,8 +38,8 @@ func (r *Router) Address() net.IP {\nreturn r.address\n}\n-func (r *Router) Ready(vrf uint64, afi uint16) bool {\n- return true\n+func (r *Router)... | Go | Apache License 2.0 | bio-routing/bio-rd | Update Router Ready Interface |
89,487 | 01.02.2023 16:38:21 | -3,600 | 797d5202db09a245a3e80a3d0b4da1c858e56f11 | Test: Ignore error message, only result | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_router_test.go",
"new_path": "protocols/bgp/server/bmp_router_test.go",
"diff": "@@ -131,7 +131,7 @@ func TestReady(t *testing.T) {\n}\nfor _, test := range tests {\n- res := test.r.Ready(test.vrf, test.afi)\n+ res, _ := test.r.Ready(t... | Go | Apache License 2.0 | bio-routing/bio-rd | Test: Ignore error message, only result |
89,487 | 02.02.2023 09:28:33 | -3,600 | e3389ad50b50e33a216a5ff8dc418da6902e5b75 | BMP Router Test: Update TestReady with expected errors | [
{
"change_type": "MODIFY",
"old_path": "protocols/bgp/server/bmp_router_test.go",
"new_path": "protocols/bgp/server/bmp_router_test.go",
"diff": "package server\nimport (\n+ \"fmt\"\n\"sync/atomic\"\n\"testing\"\n@@ -17,6 +18,7 @@ func TestReady(t *testing.T) {\nvrf uint64\nafi uint16\nexpected bool... | Go | Apache License 2.0 | bio-routing/bio-rd | BMP Router Test: Update TestReady with expected errors |
89,487 | 03.02.2023 11:01:59 | -3,600 | 1f99e2d484630e5cda0a1fcae77618a560a02ce7 | riscli: fix logging and allow encrypted grpc | [
{
"change_type": "MODIFY",
"old_path": "cmd/riscli/dump_loc_rib.go",
"new_path": "cmd/riscli/dump_loc_rib.go",
"diff": "@@ -9,7 +9,6 @@ import (\npb \"github.com/bio-routing/bio-rd/cmd/ris/api\"\n\"github.com/bio-routing/bio-rd/util/log\"\n\"github.com/urfave/cli\"\n- \"google.golang.org/grpc\"\n)\n... | Go | Apache License 2.0 | bio-routing/bio-rd | riscli: fix logging and allow encrypted grpc (#426)
Co-authored-by: Marvin Gaube <marvin.gaube@exaring.de> |
89,487 | 06.02.2023 16:03:54 | -3,600 | 456c8d9e0a65d7622966e1f564d68dff41d2ed79 | ObserveRIB: Add Support for observing a not yet ready RIB | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris-mirror/rismirror/router.go",
"new_path": "cmd/ris-mirror/rismirror/router.go",
"diff": "@@ -68,6 +68,7 @@ func (r *Router) connectVRF(rd uint64, src *grpc.ClientConn, afi uint8) {\nRouter: r.name,\nVRFRD: rd,\nAFI: apiAFI(afi),\n+ AllowUnreadyRib: true... | Go | Apache License 2.0 | bio-routing/bio-rd | ObserveRIB: Add Support for observing a not yet ready RIB (#427)
Co-authored-by: Marvin Gaube <marvin.gaube@exaring.de> |
89,487 | 08.02.2023 10:56:22 | -3,600 | 2b2894ba500ab4b379bfe401403060dbb455848e | Fix VRF creation in ris-mirror | [
{
"change_type": "MODIFY",
"old_path": "cmd/ris-mirror/rismirror/router.go",
"new_path": "cmd/ris-mirror/rismirror/router.go",
"diff": "package rismirror\nimport (\n- \"fmt\"\n\"net\"\n\"github.com/bio-routing/bio-rd/risclient\"\n@@ -53,7 +52,7 @@ func (r *Router) GetVRFs() []*vrf.VRF {\n}\nfunc (r ... | Go | Apache License 2.0 | bio-routing/bio-rd | Fix VRF creation in ris-mirror |
20,836 | 02.01.2017 20:48:48 | 0 | b9b49b3eaff7bd1107d4075b0cdd107d7fa3bd7c | Change namespace to AsyncInterop\Loop | [
{
"change_type": "MODIFY",
"old_path": "composer.json",
"new_path": "composer.json",
"diff": "},\n\"autoload\": {\n\"psr-4\": {\n- \"Interop\\\\Async\\\\\": \"src\"\n+ \"AsyncInterop\\\\\": \"src\"\n}\n},\n\"autoload-dev\": {\n\"psr-4\": {\n- \"Interop\\\\Async\\\\Loop\\\\Test\\\\\": \"test\"\n+ \"A... | PHP | MIT License | amphp/amp | Change namespace to AsyncInterop\Loop |
20,836 | 03.01.2017 18:16:50 | 0 | 638700330d8e632b9249957d9d8515aeeb5b540c | Fix typo 'idenfier' | [
{
"change_type": "MODIFY",
"old_path": "src/Loop/InvalidWatcherException.php",
"new_path": "src/Loop/InvalidWatcherException.php",
"diff": "@@ -21,7 +21,7 @@ class InvalidWatcherException extends \\Exception\n$this->watcherId = $watcherId;\nif ($message === null) {\n- $message = \"An invalid watcher... | PHP | MIT License | amphp/amp | Fix typo 'idenfier' |
20,843 | 06.01.2017 17:21:37 | -3,600 | 79355641ed06f959b5e6bddac7c746d44c77e4fc | Add a test ensuring that watchers are enabled in the actual next tick | [
{
"change_type": "MODIFY",
"old_path": "src/Test.php",
"new_path": "src/Test.php",
"diff": "@@ -1214,6 +1214,31 @@ abstract class Test extends \\PHPUnit_Framework_TestCase {\n$this->assertTrue($t + 0.1 > microtime(1));\n}\n+ function testDeferEnabledInNextTick() {\n+ $tick = function() {\n+ $this->l... | PHP | MIT License | amphp/amp | Add a test ensuring that watchers are enabled in the actual next tick |
20,836 | 08.01.2017 15:12:48 | 0 | 4504147b58cf24223b0db495cb672dbd4b69ca48 | Fix async-interop version constraints | [
{
"change_type": "MODIFY",
"old_path": "composer.json",
"new_path": "composer.json",
"diff": "\"homepage\": \"http://amphp.org\",\n\"license\": \"MIT\",\n\"require\": {\n- \"async-interop/event-loop\": \"0.5\"\n+ \"async-interop/event-loop\": \"^0.5\"\n},\n\"require-dev\": {\n\"async-interop/event-l... | PHP | MIT License | amphp/amp | Fix async-interop version constraints |
20,822 | 12.03.2017 17:05:52 | -3,600 | 2db7bed1b6df6876d5890b349b31f46388ac2d1a | Fixed typos an promise -> a promise | [
{
"change_type": "MODIFY",
"old_path": "lib/Internal/PrivatePromise.php",
"new_path": "lib/Internal/PrivatePromise.php",
"diff": "@@ -6,7 +6,7 @@ use Amp\\CallableMaker;\nuse Amp\\Promise;\n/**\n- * An promise that cannot be externally resolved. Used by Deferred in development mode.\n+ * A promise t... | PHP | MIT License | amphp/amp | Fixed typos an promise -> a promise |
20,843 | 07.04.2017 18:09:39 | -7,200 | c52279065ddb3a30bafc2935a8161485202a39ca | Remove unnecessary use of temporary variables | [
{
"change_type": "MODIFY",
"old_path": "lib/functions.php",
"new_path": "lib/functions.php",
"diff": "@@ -270,26 +270,16 @@ namespace Amp\\Promise {\n$result = $deferred->promise();\n$watcher = Loop::delay($timeout, function () use (&$deferred) {\n- if ($deferred === null) {\n- return;\n- }\n-\n- $t... | PHP | MIT License | amphp/amp | Remove unnecessary use of temporary variables |
20,843 | 07.04.2017 18:47:44 | -7,200 | f100d9cd8b45121b53d50f32c1a630cb5f8dbd04 | Fix possible double resolutions | [
{
"change_type": "MODIFY",
"old_path": "lib/functions.php",
"new_path": "lib/functions.php",
"diff": "@@ -270,8 +270,9 @@ namespace Amp\\Promise {\n$result = $deferred->promise();\n$watcher = Loop::delay($timeout, function () use (&$deferred) {\n- $deferred->fail(new TimeoutException);\n+ $temp = $d... | PHP | MIT License | amphp/amp | Fix possible double resolutions |
20,829 | 15.04.2017 23:16:50 | -3,600 | 0e4d4b492e7f9f0b2fe5a7bc30fe887b834cb77d | Add missing namespace declarations | [
{
"change_type": "MODIFY",
"old_path": "lib/Deferred.php",
"new_path": "lib/Deferred.php",
"diff": "@@ -65,7 +65,8 @@ try {\n* An optimized version of Deferred for production environments that is itself the promise. Eval is used to\n* prevent IDEs and other tools from reporting multiple definitions.... | PHP | MIT License | amphp/amp | Add missing namespace declarations |
20,843 | 07.05.2017 13:09:59 | -7,200 | 55de30c53d7b709089cfb7b1a58af1e48b7e3791 | Properly run gc_collect_cycles() between tests
This avoids leaking file descriptors with Uv | [
{
"change_type": "MODIFY",
"old_path": "test/Loop/DriverTest.php",
"new_path": "test/Loop/DriverTest.php",
"diff": "@@ -42,6 +42,11 @@ abstract class DriverTest extends TestCase {\n// Required for error handler to work\nLoop::set($this->loop);\n+ gc_collect_cycles();\n+ }\n+\n+ function tearDown() {... | PHP | MIT License | amphp/amp | Properly run gc_collect_cycles() between tests
This avoids leaking file descriptors with Uv |
20,843 | 07.05.2017 19:02:22 | -7,200 | 6c03950abd47d8a6e9996093e57fe3262c4a3698 | Do not run uv tests separately in its own process | [
{
"change_type": "MODIFY",
"old_path": ".travis.yml",
"new_path": ".travis.yml",
"diff": "@@ -30,8 +30,7 @@ install:\nscript:\n# Run testNoMemoryLeak separately, as those are skipped with enabled coverage\n- php vendor/bin/phpunit --verbose --group memoryleak\n- - phpdbg -qrr vendor/bin/phpunit --ve... | PHP | MIT License | amphp/amp | Do not run uv tests separately in its own process |
20,843 | 16.05.2017 18:17:12 | -7,200 | 6e52f3e211f4c27bf7eef5b38d7b104e8ab66a8c | Fix potential issues when operating on destroyed uv handles in shutdown sequence | [
{
"change_type": "MODIFY",
"old_path": "lib/Loop/UvDriver.php",
"new_path": "lib/Loop/UvDriver.php",
"diff": "@@ -260,34 +260,34 @@ class UvDriver extends Driver {\n}\n$event = $this->events[$id];\n- $eventId = (int) $event;\n+\n+ if (!\\uv_is_active($event)) {\n+ return;\n+ }\nswitch ($watcher->typ... | PHP | MIT License | amphp/amp | Fix potential issues when operating on destroyed uv handles in shutdown sequence |
20,843 | 19.05.2017 15:57:49 | -7,200 | 4fe48c8aecbdabba24e03df0337e41acc141c62b | Fix (TypeError calling Driver::disable()) | [
{
"change_type": "MODIFY",
"old_path": "lib/Loop/UvDriver.php",
"new_path": "lib/Loop/UvDriver.php",
"diff": "@@ -49,7 +49,7 @@ class UvDriver extends Driver {\ndefault: // Disable all related watchers and notify the loop error handler.\nforeach ($watchers as $watcher) {\n- $this->disable($watcher);... | PHP | MIT License | amphp/amp | Fix #132 (TypeError calling Driver::disable()) |
20,843 | 20.05.2017 16:26:56 | -7,200 | 26dfafe00cafeaa638a4a61617cd710049d20d8c | Avoid coroutine callstack explosion upon yielding succeeded Promises | [
{
"change_type": "MODIFY",
"old_path": "lib/Coroutine.php",
"new_path": "lib/Coroutine.php",
"diff": "@@ -14,21 +14,15 @@ use React\\Promise\\PromiseInterface as ReactPromise;\nfinal class Coroutine implements Promise {\nuse Internal\\Placeholder;\n- /**\n- * Maximum number of immediate coroutine co... | PHP | MIT License | amphp/amp | Avoid coroutine callstack explosion upon yielding succeeded Promises |
20,843 | 09.07.2017 09:28:32 | -7,200 | 5e93318d850662526951c905e690a1d28996c186 | Fix issue with the loop not terminating with only unreferenced watchers | [
{
"change_type": "MODIFY",
"old_path": "lib/Loop/Driver.php",
"new_path": "lib/Loop/Driver.php",
"diff": "@@ -127,7 +127,7 @@ abstract class Driver {\n}\n}\n- $this->dispatch(empty($this->nextTickQueue) && empty($this->enableQueue) && $this->running);\n+ $this->dispatch(empty($this->nextTickQueue) &... | PHP | MIT License | amphp/amp | Fix issue with the loop not terminating with only unreferenced watchers |
20,823 | 01.08.2017 15:14:22 | -7,200 | 61b018b11f62bc8352507e3014c0d83ce603baef | updated class spelling | [
{
"change_type": "MODIFY",
"old_path": "docs/utils/struct.md",
"new_path": "docs/utils/struct.md",
"diff": "@@ -3,7 +3,7 @@ layout: docs\ntitle: Struct\npermalink: /utils/struct\n---\n-A struct is a generic computer science term for an object composed of public properties. The `\\Amp\\Stuct` trait\n... | PHP | MIT License | amphp/amp | updated class spelling |
20,839 | 18.09.2017 11:38:53 | -10,800 | 96e23e2246eaa3557553e52a7d9a4be2032ead3a | Change getProtocol => getProtocolVersion
In current("^3.0") amphp/artax version, there is no getProtocol method, instead of getProtocolVersion method exists in artax response. | [
{
"change_type": "MODIFY",
"old_path": "docs/promises/combinators.md",
"new_path": "docs/promises/combinators.md",
"diff": "@@ -43,7 +43,7 @@ Loop::run(function () {\nprintf(\n\"%s | HTTP/%s %d %s\\n\",\n$key,\n- $response->getProtocol(),\n+ $response->getProtocolVersion(),\n$response->getStatus(),\... | PHP | MIT License | amphp/amp | Change getProtocol => getProtocolVersion
In current("^3.0") amphp/artax version, there is no getProtocol method, instead of getProtocolVersion method exists in artax response. |
20,826 | 20.09.2017 14:47:32 | -7,200 | bb34b9fb2d599375b1e34b10d7632ffd50d1fecb | Added exception examples | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "examples/exceptions/caught.php",
"diff": "+#!/usr/bin/env php\n+<?php\n+use Amp\\Deferred;\n+use Amp\\Loop;\n+\n+require_once __DIR__ . \"/../../vendor/autoload.php\";\n+\n+function asyncOperation() {\n+ $def = new Deferred();\n+\n+ Loop::delay(... | PHP | MIT License | amphp/amp | Added exception examples |
20,843 | 10.10.2017 15:37:31 | -7,200 | 7837d8ce08b0edada1fd10dc1b7eaf95d4655141 | Fix - Preserve Promise order within combinator functions | [
{
"change_type": "MODIFY",
"old_path": "CHANGELOG.md",
"new_path": "CHANGELOG.md",
"diff": "### Unreleased\n- `Loop::set()` replaces the current driver with a dummy driver for the time of `gc_collect_cycles()` now. This allows cyclic references to be cleaned up properly before the new driver is set.... | PHP | MIT License | amphp/amp | Fix #172 - Preserve Promise order within combinator functions |
20,826 | 08.11.2017 14:01:26 | -3,600 | abe92a78adf7ad314feb97b32b93dd3187805a01 | Add basic promise examples | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "examples/promises/deferred.php",
"diff": "+#!/usr/bin/env php\n+<?php\n+\n+use Amp\\Deferred;\n+use Amp\\Loop;\n+\n+require_once __DIR__ . \"/../../vendor/autoload.php\";\n+\n+/**\n+ * @return \\Amp\\Promise<string>\n+ */\n+function jobSuccess()... | PHP | MIT License | amphp/amp | Add basic promise examples (#179) |
20,837 | 19.06.2018 02:01:46 | -28,800 | 81e7024e14de625a120b15a8a85d33f6efaea368 | Document yield vs yield from | [
{
"change_type": "MODIFY",
"old_path": "docs/coroutines/README.md",
"new_path": "docs/coroutines/README.md",
"diff": "@@ -44,3 +44,59 @@ All `yield`s in a coroutine must be one of the following three types:\n| `Amp\\Promise` | Any promise instance may be yielded and control will be returned to the c... | PHP | MIT License | amphp/amp | Document yield vs yield from (#226) |
20,837 | 25.11.2018 07:56:42 | 32,400 | 4a98cc4fdecc784cbee78e421a739a2f87f42d3a | Add timeoutWithDefault function | [
{
"change_type": "MODIFY",
"old_path": "lib/functions.php",
"new_path": "lib/functions.php",
"diff": "@@ -96,12 +96,14 @@ namespace Amp\\Promise\n{\nuse Amp\\Deferred;\n+ use Amp\\Failure;\nuse Amp\\Loop;\nuse Amp\\MultiReasonException;\nuse Amp\\Promise;\nuse Amp\\Success;\nuse Amp\\TimeoutExceptio... | PHP | MIT License | amphp/amp | Add timeoutWithDefault function (#245) |
20,837 | 26.11.2018 09:36:46 | 32,400 | 96c2eeaa1f49056fac0b6465cb716720c6972543 | Add Promise\wrap | [
{
"change_type": "MODIFY",
"old_path": "lib/functions.php",
"new_path": "lib/functions.php",
"diff": "@@ -287,7 +287,7 @@ namespace Amp\\Promise\n* This function is the same as some() with the notable exception that it will never fail even\n* if all promises in the array resolve unsuccessfully.\n*\n... | PHP | MIT License | amphp/amp | Add Promise\wrap (#234) |
20,843 | 11.12.2018 11:31:37 | -3,600 | 7075ef7d74dbd32626bfd31c976b23055c3ade6a | Fix - 100% CPU usage in NativeDriver
Also use better bounds for timer - it must not execute before, but may execute a little later (on my system it were up to 7 ms actually) | [
{
"change_type": "MODIFY",
"old_path": "lib/Loop/NativeDriver.php",
"new_path": "lib/Loop/NativeDriver.php",
"diff": "@@ -276,7 +276,7 @@ class NativeDriver extends Driver\ncontinue;\n}\n- $expiration -= getCurrentTime();\n+ $expiration -= $this->now();\nif ($expiration < 0) {\nreturn 0;\n"
},
{... | PHP | MIT License | amphp/amp | Fix #251 - 100% CPU usage in NativeDriver
Also use better bounds for timer - it must not execute before, but may execute a little later (on my system it were up to 7 ms actually) |
20,843 | 21.01.2019 16:41:30 | -3,600 | c3afc5e97723b400fa2999bf18a529c367e1e7d0 | Fix - Ensure nowUpdateNeeded is set to true after a blocking wait in NativeDriver
So that expired timeouts also indeed do trigger immediately instead of in the next tick. | [
{
"change_type": "MODIFY",
"old_path": "lib/Loop/NativeDriver.php",
"new_path": "lib/Loop/NativeDriver.php",
"diff": "@@ -166,10 +166,15 @@ class NativeDriver extends Driver\n$timeout /= self::MILLISEC_PER_SEC;\nif (!empty($read) || !empty($write)) { // Use stream_select() if there are any streams i... | PHP | MIT License | amphp/amp | Fix #256 - Ensure nowUpdateNeeded is set to true after a blocking wait in NativeDriver
So that expired timeouts also indeed do trigger immediately instead of in the next tick. |
20,828 | 05.02.2019 20:32:32 | -10,800 | 0fd6b8c157e78c8a6b8beafbaa99139d85ccb3c4 | Fix phpdoc types for call / asyncCall
Incorrect types were indicated, due to which static analysis led to false positives. | [
{
"change_type": "MODIFY",
"old_path": "lib/functions.php",
"new_path": "lib/functions.php",
"diff": "@@ -49,8 +49,8 @@ namespace Amp\n* Calls the given function, always returning a promise. If the function returns a Generator, it will be run as a\n* coroutine. If the function throws, a failed promi... | PHP | MIT License | amphp/amp | Fix phpdoc types for call / asyncCall (#260)
Incorrect types were indicated, due to which static analysis led to false positives. |
20,827 | 02.08.2019 22:37:42 | -7,200 | c6a775a6c9fdd9ca4c909647a19b02d2d11a0568 | Add delay function | [
{
"change_type": "MODIFY",
"old_path": "lib/functions.php",
"new_path": "lib/functions.php",
"diff": "@@ -90,6 +90,18 @@ namespace Amp\n{\nPromise\\rethrow(call($callback, ...$args));\n}\n+\n+ /**\n+ * Sleeps for the specified number of milliseconds.\n+ *\n+ * @param int $milliseconds\n+ *\n+ * @ret... | PHP | MIT License | amphp/amp | Add delay function (#278) |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.