author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,256 | 23.10.2020 11:33:31 | 21,600 | 8c8078f69339a2fbb15d9bc11f72ea459b18e021 | cleanup: update comment formatting
Put comments on a newline above fields to allow for longer comments in
this file.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/src/gpio.c",
"new_path": "zephyr/shim/src/gpio.c",
"diff": "@@ -16,10 +16,14 @@ LOG_MODULE_REGISTER(gpio_shim, LOG_LEVEL_ERR);\n* device tree node.\n*/\nstruct gpio_config {\n- const char *name; /* GPIO net name */\n- const char *dev_name; /* Set a... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: update comment formatting
Put comments on a newline above fields to allow for longer comments in
this file.
BRANCH=none
BUG=none
TEST=none
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I89740558e7bb508f7a213cd6817ae91ad9b6f5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2495137
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,330 | 15.10.2020 11:27:13 | 21,600 | 8a4a98641799f54ce93ef707288d1fc1a7d35db0 | features: Define AP-driven mode entry
Add EC_FEATURE_TYPEC_REQURE_AP_MODE_ENTRY.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/ec_features.c",
"new_path": "common/ec_features.c",
"diff": "@@ -140,6 +140,9 @@ uint32_t get_feature_flags1(void)\n#endif\n#ifdef CONFIG_USB_PD_TCPMV2\n| EC_FEATURE_MASK_1(EC_FEATURE_TYPEC_CMD)\n+#endif\n+#ifdef CONFIG_USB_PD_REQUIRE_AP_MODE_ENTRY\n+ |... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | features: Define AP-driven mode entry
Add EC_FEATURE_TYPEC_REQURE_AP_MODE_ENTRY.
BUG=b:168030639
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I413abdfb123b3b7119fa1862b018557de81c2cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2411181
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org> |
136,355 | 19.06.2020 11:04:23 | -19,080 | 426024dbcc36608744103aaecce815457a9de8a1 | IO-expander: Add driver support for PCA9675
BRANCH=None
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "driver/build.mk",
"new_path": "driver/build.mk",
"diff": "@@ -78,8 +78,9 @@ include $(_driver_cur_dir)fingerprint/build.mk\n# I/O expander\ndriver-$(CONFIG_IO_EXPANDER_IT8801)+=ioexpander/it8801.o\n-driver-$(CONFIG_IO_EXPANDER_PCA9534)+=ioexpander/pca9534.o\nd... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | IO-expander: Add driver support for PCA9675
BRANCH=None
BUG=b:169551130
TEST=make buildall -j
Change-Id: If565996850c5c75f3d425e2dc7f705b624ad4cc4
Signed-off-by: pandeyan <anshuman.pandey@intel.com>
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2435172
Reviewed-by: caveh jalali <caveh@chromium.org>
Commit-Queue: Poornima Tom <poornima.tom@intel.com> |
136,280 | 23.10.2020 12:35:32 | -28,800 | 3cba51e9e807e7015d81c2891c47ea4c59587a1c | asurada: ps8743: set Rx EQ to 12.8dB
TEST=pass usb compliance test
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "@@ -411,6 +411,15 @@ const struct usb_mux usb_muxes[CONFIG_USB_PD_PORT_MAX_COUNT] = {\n},\n};\n+void board_usb_mux_init(void)\n+{\n+ if (board_get_sub_board() == SUB_BOARD_TYPEC)\n+ ps8743_t... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: ps8743: set Rx EQ to 12.8dB
BUG=b:170703310
TEST=pass usb compliance test
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ieb226da91643b8bebf6eb49241c01be612f714f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493797
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,305 | 16.10.2020 12:58:20 | 21,600 | 3c79b8fbb955f18fc02d1c33449056f0b154d6b5 | COIL: Re-name to TCPCI_I2C_PERIPHERAL
Boards which don't use a TCPM will define TCPCI_I2C_PERIPHERAL.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/i2c-stm32f0.c",
"new_path": "chip/stm32/i2c-stm32f0.c",
"diff": "@@ -288,7 +288,7 @@ static void i2c_process_command(void)\nhost_packet_receive(&i2c_packet);\n}\n-#ifdef TCPCI_I2C_SLAVE\n+#ifdef TCPCI_I2C_PERIPHERAL\nstatic void i2c_send_tcpc_respon... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Re-name to TCPCI_I2C_PERIPHERAL
Boards which don't use a TCPM will define TCPCI_I2C_PERIPHERAL.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: If93e533e059888e8ad5166b29c37bc2243f46947
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2481940
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,205 | 22.10.2020 18:11:11 | -28,800 | 4a9ba76bf50fe343f0665935489d32c4df3f7e26 | woomax: Implement EC fan control table
Implement EC fan control table by thermal request.
BRANCH=firmware-zork-13434.B
TEST=make BOARD=woomax | [
{
"change_type": "MODIFY",
"old_path": "board/woomax/board.c",
"new_path": "board/woomax/board.c",
"diff": "@@ -369,9 +369,9 @@ const struct fan_conf fan_conf_0 = {\n.enable_gpio = -1,\n};\nconst struct fan_rpm fan_rpm_0 = {\n- .rpm_min = 3000,\n- .rpm_start = 3000,\n- .rpm_max = 4900,\n+ .rpm_min =... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | woomax: Implement EC fan control table
Implement EC fan control table by thermal request.
BUG=b:171025573
BRANCH=firmware-zork-13434.B
TEST=make BOARD=woomax
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Iafdea26ecc9f27092df92634f7d89a9b4ce8d7db
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491940
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,282 | 19.10.2020 16:26:27 | -28,800 | be386fb62ef93ecfb0f369867bfe9c193b178f90 | elemi: Add batteries configuration
Add batteries configuration as following:
1. Simplo 996QA193H
2. Cosmx CA407792G
BRANCH=firmware-volteer-13521.B-master
TEST=make sure battery charging, battery cutoff works. | [
{
"change_type": "MODIFY",
"old_path": "board/elemi/battery.c",
"new_path": "board/elemi/battery.c",
"diff": "#include \"util.h\"\n/*\n- * Battery info for all Volteer battery types. Note that the fields\n+ * Battery info for all Elemi battery types. Note that the fields\n* start_charging_min/max an... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | elemi: Add batteries configuration
Add batteries configuration as following:
1. Simplo 996QA193H
2. Cosmx CA407792G
BUG=b:169409487
BRANCH=firmware-volteer-13521.B-master
TEST=make sure battery charging, battery cutoff works.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I637b3bf1ea3faa5a7283de80ab9cffb196264c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2484114
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,282 | 22.10.2020 11:32:13 | -28,800 | 8cd87e78c73a43b6a11919e4b9d9f2a7e063d429 | elemi: Remove unused board rev 0 configuration
BRANCH=firmware-volteer-13521.B-master
TEST=Make sure TCPC C1 port initial passed. | [
{
"change_type": "MODIFY",
"old_path": "board/elemi/board.c",
"new_path": "board/elemi/board.c",
"diff": "@@ -325,16 +325,14 @@ const int usb_port_enable[USB_PORT_COUNT] = {\nGPIO_EN_PP5000_USBA,\n};\n-static enum gpio_signal ps8xxx_rst_odl = GPIO_USB_C1_RT_RST_ODL;\n-\nstatic void ps8815_reset(void... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | elemi: Remove unused board rev 0 configuration
BUG=b:169409487
BRANCH=firmware-volteer-13521.B-master
TEST=Make sure TCPC C1 port initial passed.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ib989947f14feccb0ef4eaad8a2fa5556a4061fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491585
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,282 | 22.10.2020 11:17:25 | -28,800 | b01892bbe5cf36ea8d748cd157764bde51f1c7de | elemi: Enable keyboard backlight
BRANCH=firmware-volteer-13521.B-master
TEST=make sure ec console kblight can adjust keyboard backlight
brightness. | [
{
"change_type": "MODIFY",
"old_path": "board/elemi/board.c",
"new_path": "board/elemi/board.c",
"diff": "@@ -278,6 +278,18 @@ const struct pwm_t pwm_channels[] = {\n};\nBUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);\n+static void kb_backlight_enable(void)\n+{\n+ gpio_set_level(GPIO_EC_KB_B... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | elemi: Enable keyboard backlight
BUG=b:169409487
BRANCH=firmware-volteer-13521.B-master
TEST=make sure ec console kblight can adjust keyboard backlight
brightness.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ifbb31e76dec8b595e13717b382eef229b9dd934c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491582
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,295 | 29.10.2020 18:22:21 | -28,800 | a2d6504d18a04fd19b24955a915dd412b6110d97 | berknip: update thermal setting
This patch update thermal setting.
BRANCH=zork
TEST=verify thermal setting as thermal team request. | [
{
"change_type": "MODIFY",
"old_path": "board/berknip/board.c",
"new_path": "board/berknip/board.c",
"diff": "@@ -426,11 +426,11 @@ BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT);\nconst static struct ec_thermal_config thermal_thermistor_soc = {\n.temp_host = {\n- [EC_TEMP_THRESH_HIGH] ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | berknip: update thermal setting
This patch update thermal setting.
BUG=b:161470415
BRANCH=zork
TEST=verify thermal setting as thermal team request.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Ib913b5959e15b6a7ea19fbab587a9a34ab6bb26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2507189
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,269 | 29.10.2020 15:24:23 | 25,200 | 27797ea91d3eb47e732f4d3d3288129f4ff4b745 | test/fpsensor: Add missing RUN_TEST macro
The RUN_TEST macro is needed to perform the bookeeping on failures for
the tests that are run.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "test/fpsensor.c",
"new_path": "test/fpsensor.c",
"diff": "@@ -27,8 +27,8 @@ test_static int test_validate_fp_buffer_offset_failure_overflow(void)\nvoid run_test(int argc, char **argv)\n{\n- test_validate_fp_buffer_offset_success();\n- test_validate_fp_buffer_o... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test/fpsensor: Add missing RUN_TEST macro
The RUN_TEST macro is needed to perform the bookeeping on failures for
the tests that are run.
BRANCH=none
BUG=b:171370392
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I8b74c8ee39fd95391417267993e186eb2056456d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2508858
Reviewed-by: Bhanu Prakash Maiya <bhanumaiya@google.com> |
136,269 | 28.10.2020 16:52:17 | 25,200 | a6ec60c2f392813f94e44bcceda6ab4c21d49101 | test/fpsensor: Run the fpsensor test on device
BRANCH=none
TEST=Using dragonclaw v0.2 and servo_micro:
./test/run_device_tests.py -t fpsensor | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/build.mk",
"new_path": "board/hatch_fp/build.mk",
"diff": "@@ -17,6 +17,7 @@ test-list-y=\\\ncrc32 \\\nflash_physical \\\nflash_write_protect \\\n+ fpsensor \\\nmpu \\\nmutex \\\npingpong \\\n"
},
{
"change_type": "MODIFY",
"old_path... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test/fpsensor: Run the fpsensor test on device
BRANCH=none
BUG=b:171370392
TEST=Using dragonclaw v0.2 and servo_micro:
./test/run_device_tests.py -t fpsensor
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Idc24d9bdd5574ca7099e97e86e3b49011844380c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2507951
Reviewed-by: Bhanu Prakash Maiya <bhanumaiya@google.com> |
136,287 | 29.10.2020 12:16:36 | 21,600 | c3d8133b6df94981b8f11c289d165344023b2d46 | Zephyr: add support for irq_(un)lock
This change is added when building non-zephyr builds and adds
macros to mock out zephyr's irq_lock and irq_unlock and route
those calls to interrupt_disable and iterrupt_enable.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/task.h",
"new_path": "include/task.h",
"diff": "@@ -79,6 +79,23 @@ void interrupt_disable(void);\n*/\nvoid interrupt_enable(void);\n+/*\n+ * Define irq_lock and irq_unlock that match the function signatures to Zephyr's\n+ * functions. In reality, these... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zephyr: add support for irq_(un)lock
This change is added when building non-zephyr builds and adds
macros to mock out zephyr's irq_lock and irq_unlock and route
those calls to interrupt_disable and iterrupt_enable.
BRANCH=none
BUG=b:171302975
TEST=none
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: I79fcbdc48963fb800781a1a0b77ac261621480a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2508415 |
136,269 | 30.10.2020 09:19:47 | 25,200 | ad1ed0d4d0295ffe45023d0099f264e2fa436bd8 | common/mock: Make sure mocks are only in the test build
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "common/mock/dp_alt_mode_mock.c",
"new_path": "common/mock/dp_alt_mode_mock.c",
"diff": "#include \"usb_dp_alt_mode.h\"\n#include \"mock/dp_alt_mode_mock.h\"\n+#ifndef TEST_BUILD\n+#error \"Mocks should only be in the test build.\"\n+#endif\n+\n#ifdef CONFIG_CO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common/mock: Make sure mocks are only in the test build
BRANCH=none
BUG=b:171370392
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I1517a7080bd4853918ffc7127d44e1955d925789
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2510455
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,249 | 27.10.2020 18:32:43 | 25,200 | 30e1446b0b8ce23c3b35a255c1e6bc5730888267 | SYV682X: Handle CC OVP events
Handle VBAT OVP events by resetting the syv682x and calling the pd
handler.
TEST=On Volteer, check that there is a successful PD re-negotiation
after shorting VCONN to 20V.
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "driver/ppc/syv682x.c",
"new_path": "driver/ppc/syv682x.c",
"diff": "@@ -53,6 +53,10 @@ static timestamp_t oc_timer[CONFIG_USB_PD_PORT_MAX_COUNT];\n#define CPRINTS(format, args...) cprints(CC_USBPD, format, ## args)\n+static int syv682x_init(int port);\n+\n+sta... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SYV682X: Handle CC OVP events
Handle VBAT OVP events by resetting the syv682x and calling the pd
handler.
BUG=b:171156342
TEST=On Volteer, check that there is a successful PD re-negotiation
after shorting VCONN to 20V.
BRANCH=none
Signed-off-by: Eric Herrmann <eherrmann@chromium.org>
Change-Id: Id7b9d3087aa8fcb17b4eda12c644ac3c5cbe3bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2504482
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,305 | 22.10.2020 16:20:27 | 21,600 | f77cdd2feaa04cf55af76994079e42de808fb096 | COIL: Re-name local variables and references in i2c-stm32f0.c
Re-name i2c references to terms controller/peripheral
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/i2c-stm32f0.c",
"new_path": "chip/stm32/i2c-stm32f0.c",
"diff": "#define CPRINTS(format, args...) cprints(CC_I2C, format, ## args)\n/* Transmit timeout in microseconds */\n-#define I2C_TX_TIMEOUT_MASTER (10 * MSEC)\n+#define I2C_TX_TIMEOUT_CONTROLLE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Re-name local variables and references in i2c-stm32f0.c
Re-name i2c references to terms controller/peripheral
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I2afa76596890bd9d7e0c51cced76b0f7cc76257b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493114
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> |
136,305 | 30.10.2020 14:47:16 | 21,600 | 63e4dcbe22f2b987e3040a1a8a39720fb4cd55bf | COIL: Rename CONFIG_HOSTCMD_I2C_ADDR_FLAGS
Rename for CONFIG_HOSTCMD_I2C_ADDR_FLAGS and surrounding comments.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/max32660-eval/board.h",
"new_path": "board/max32660-eval/board.h",
"diff": "#define CONFIG_I2C\n#define CONFIG_I2C_SLAVE\n-#define CONFIG_HOSTCMD_I2C_SLAVE_ADDR_FLAGS (0x51) /* 7 bit right-aligned, bits 6 to 0 */\n+#define CONFIG_HOSTCMD_I2C_ADDR_FLAGS (... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename CONFIG_HOSTCMD_I2C_ADDR_FLAGS
Rename for CONFIG_HOSTCMD_I2C_ADDR_FLAGS and surrounding comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I49dc12753957da7baa1bb387e212d75c75e81d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2511093
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,305 | 30.10.2020 15:08:03 | 21,600 | c52033d763d7b63978e3207a33725a2c9ff2aff3 | COIL: Rename SLEEP_MASK_I2C_PERIPHERAL
Rename SLEEP_MASK_I2C_PERIPHERAL and related comments.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "chip/max32660/i2c_chip.c",
"new_path": "chip/max32660/i2c_chip.c",
"diff": "@@ -582,7 +582,7 @@ static void i2c_slave_handler(mxc_i2c_regs_t *i2c)\ni2c->int_en0 = MXC_F_I2C_INT_EN0_DONE |\nI2C_ERROR | MXC_F_I2C_INT_EN0_ADDR_MATCH;\n/* Inhibit sleep mode when a... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename SLEEP_MASK_I2C_PERIPHERAL
Rename SLEEP_MASK_I2C_PERIPHERAL and related comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Idaeefda102c603a38f128d820ed1f647069eaeea
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2511094
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,418 | 29.10.2020 15:33:18 | 25,200 | 3ccc2b066c302fa301be0408517adf75d2dbe3bc | npcx: Explicitly disable alt-function for unused pins
Make the unused pins as GPIO and disable any alt-function.
BRANCH=None
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "chip/npcx/gpio.c",
"new_path": "chip/npcx/gpio.c",
"diff": "@@ -616,10 +616,13 @@ void gpio_pre_init(void)\n}\n#endif\n- /* Configure unused pins as INPUT with PU to save power. */\n- for (i = 0; i < unused_pin_count; i++, u++)\n+ /* Configure unused pins as G... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | npcx: Explicitly disable alt-function for unused pins
Make the unused pins as GPIO and disable any alt-function.
BRANCH=None
BUG=b:169595541
TEST=make buildall -j
Change-Id: I6b7c16dd68654b38c8a12654207438315fe86c2c
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2508862
Reviewed-by: CH Lin <chlin56@nuvoton.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,418 | 29.10.2020 16:14:21 | 25,200 | 65fcc29f189d5f8b3323ad3cb085dea2fa188991 | Trogdor: Define the NC strap and output it low
Define the NC strap and output it low for power saving.
BRANCH=None
TEST=Built the images and booted fine. | [
{
"change_type": "MODIFY",
"old_path": "board/coachz/gpio.inc",
"new_path": "board/coachz/gpio.inc",
"diff": "@@ -142,6 +142,9 @@ GPIO(SKU_ID2, PIN(D, 4), GPIO_INPUT)\n*/\nGPIO(DA9313_GPIO0, PIN(E, 2), GPIO_INPUT | GPIO_PULL_DOWN) /* Switchcap GPIO0 */\n+/* Special straps */\n+GPIO(ARM_X86, PIN(6, 6... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trogdor: Define the NC strap and output it low
Define the NC strap and output it low for power saving.
BRANCH=None
BUG=b:169595541
TEST=Built the images and booted fine.
Change-Id: Ic2f1a098218403c3bff534b921b385ba893a83cf
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2508863
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,234 | 29.10.2020 11:18:38 | 25,200 | d636d80192d87c5088ad579c57fee93c76fbf0d7 | intelrvp: Keep PPC specific code generic in baseboard
BRANCH=none
TEST=PPC interrupt is invoked on ADL-RVP | [
{
"change_type": "MODIFY",
"old_path": "baseboard/intelrvp/baseboard.h",
"new_path": "baseboard/intelrvp/baseboard.h",
"diff": "@@ -253,6 +253,8 @@ struct tcpc_aic_gpio_config_t {\nenum gpio_signal tcpc_alert;\n/* PPC interrupt */\nenum gpio_signal ppc_alert;\n+ /* PPC interrupt handler */\n+ void (... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | intelrvp: Keep PPC specific code generic in baseboard
BUG=none
BRANCH=none
TEST=PPC interrupt is invoked on ADL-RVP
Change-Id: Ib41be079d0d5731627193d15b66bb9949bd2722f
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2508156
Reviewed-by: Sooraj Govindan <sooraj.govindan@intel.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,443 | 31.10.2020 12:56:26 | 25,200 | 958db1e7c64c23cb6e6a2e8920ddeb658b92f283 | flash_fp_mcu: Add comment about zork pwr enable gpio
No functional change.
BRANCH=none
TEST=Tested manual pwr cycling on a Zork variant. | [
{
"change_type": "MODIFY",
"old_path": "util/flash_fp_mcu",
"new_path": "util/flash_fp_mcu",
"diff": "@@ -379,7 +379,8 @@ config_zork() {\nreadonly GPIO_NRST=331\n# FPMCU BOOT0 is on AGPIO 69 = 320 + 69 = 389\nreadonly GPIO_BOOT0=389\n- # FPMCU PWR_EN is not available on Zork. Set invalid value\n+ #... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flash_fp_mcu: Add comment about zork pwr enable gpio
No functional change.
BRANCH=none
BUG=none
TEST=Tested manual pwr cycling on a Zork variant.
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I3420746d97f169ad252180876fc0b739210b2779
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2513129
Reviewed-by: Bhanu Prakash Maiya <bhanumaiya@google.com> |
136,205 | 22.10.2020 16:27:02 | -28,800 | 0438542f2690e958d47dd28636797acbd29fcd9d | delbin: Configure EC fan control table.
Configure EC fan control table by thermal request.
BRANCH=firmware-volteer-13521.B
TEST=make BOARD=delbin | [
{
"change_type": "MODIFY",
"old_path": "board/delbin/board.c",
"new_path": "board/delbin/board.c",
"diff": "@@ -163,7 +163,7 @@ const static struct ec_thermal_config thermal_cpu = {\n[EC_TEMP_THRESH_HIGH] = C_TO_K(65),\n},\n.temp_fan_off = C_TO_K(35),\n- .temp_fan_max = C_TO_K(50),\n+ .temp_fan_max ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | delbin: Configure EC fan control table.
Configure EC fan control table by thermal request.
BUG=b:168958222
BRANCH=firmware-volteer-13521.B
TEST=make BOARD=delbin
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I7526c8cf4bb05c41d36f9bc7205e38856f14f750
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491576
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,276 | 27.10.2020 17:17:07 | -28,800 | 1172759baa40708ed96de90bc2d541cba1ef3438 | Kukui: initial a new models kakadu of ec.
Copy from krane, which is a model from Kukui.
Modified for building pass.
It will need to be revised later.
BRANCH=master
TEST=make -j BOARD=kakadu | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/battery_max17055.c",
"new_path": "baseboard/kukui/battery_max17055.c",
"diff": "#define TEMP_OUT_OF_RANGE TEMP_ZONE_COUNT\n-#ifdef BOARD_KAKADU\n-#define BATT_ID 1\n-#else\n#define BATT_ID 0\n-#endif\n#define BATTERY_SIMPLO_CHARGE_MIN_TEMP 0\n#... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Kukui: initial a new models kakadu of ec.
Copy from krane, which is a model from Kukui.
Modified for building pass.
It will need to be revised later.
BUG=b:171763111
BRANCH=master
TEST=make -j BOARD=kakadu
Change-Id: I87fcf8c8e3bd4fa669e0bcb7fbb9d125a9926cdb
Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2501801
Reviewed-by: Chen-Tsung Hsieh <chentsung@chromium.org> |
136,330 | 02.11.2020 13:50:49 | 25,200 | 5884a3b37e47b3b9a926963330b5f34e5cde3445 | genvif: Output to .xml path
The currently generated format is XML. The GRL C2 software requires the
the filename end in .xml to successfully use it. Output to a file with
this name.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "Makefile.rules",
"new_path": "Makefile.rules",
"diff": "@@ -463,7 +463,7 @@ $(out)/%.bin: $(out)/%.obj\n$(call quiet,copyrw-y,COPY_RW))\n$(call quiet,mv_from_tmp,MV )\n-$(out)/$(BOARD)_vif.txt: $(out)/util/genvif\n+$(out)/$(BOARD)_vif.xml: $(out)/util/genvif\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Output to .xml path
The currently generated format is XML. The GRL C2 software requires the
the filename end in .xml to successfully use it. Output to a file with
this name.
BUG=b:170646602
TEST=make buildall
BRANCH=none
Change-Id: I54dbfaef1bc76be58a0007039da659562f97e372
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2514902
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,205 | 02.11.2020 10:05:10 | -28,800 | 9c7752544ff0128b63f9ef5067ab2d3fa8c2b418 | drobit: Remove ALS function dependent on schematic.
Remove ALS function dependent on schematic.
BRANCH=firmware-volteer-13521.B
TEST=make BOARD=drobit | [
{
"change_type": "MODIFY",
"old_path": "board/drobit/board.c",
"new_path": "board/drobit/board.c",
"diff": "#include \"cbi_ec_fw_config.h\"\n#include \"driver/accel_bma2x2.h\"\n#include \"driver/accelgyro_bmi260.h\"\n-#include \"driver/als_tcs3400.h\"\n#include \"driver/bc12/pi3usb9201.h\"\n#include... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | drobit: Remove ALS function dependent on schematic.
Remove ALS function dependent on schematic.
BUG=b:172129778
BRANCH=firmware-volteer-13521.B
TEST=make BOARD=drobit
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: If24cb9fdc6583417f23c3451c668979c09cafeb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2513405
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> |
136,355 | 04.09.2020 19:56:51 | -19,080 | 3b96973d29dd794cce7d7a32d16e2f531b97203a | ADLP-RVP: Config to enable TBT
BRANCH=None
TEST=Able to enter TBT mode | [
{
"change_type": "MODIFY",
"old_path": "baseboard/intelrvp/ite_ec.c",
"new_path": "baseboard/intelrvp/ite_ec.c",
"diff": "@@ -105,6 +105,7 @@ BUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);\n#ifdef CONFIG_USBC_VCONN\nvoid board_pd_vconn_ctrl(int port, enum usbpd_cc_pin cc_pin, int enabled)\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ADLP-RVP: Config to enable TBT
BRANCH=None
BUG=b:171409539
TEST=Able to enter TBT mode
Signed-off-by: Poornima Tom <poornima.tom@intel.com>
Change-Id: I81fb01ac9e537ded25cfffc8a9691c173ed41a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2490900
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: caveh jalali <caveh@chromium.org> |
136,256 | 04.11.2020 13:17:47 | 25,200 | 28fd56c3837bbe47f271a3bc3d0dee5b28017278 | cleanup: fix pgio -> gpio typo
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/include/board.h",
"new_path": "zephyr/shim/include/board.h",
"diff": "/* Included shimed version of gpio signal. */\n#include <gpio_signal.h>\n-/* Include board specific gpio mapping/aliases if named_pgios node exists */\n+/* Include board specific... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: fix pgio -> gpio typo
BRANCH=none
BUG=none
TEST=none
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: Ifcf440bd642f89f3c2b6e23f9944dc651e14fdf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519241 |
136,311 | 04.11.2020 12:55:01 | 25,200 | 43ea8f37a3e628d524ec5ed5ffd1fe410cf4b329 | drobit: remove board ID 0 checks
Board ID 0 checks were only used on the volteer reference board.
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/drobit/board.c",
"new_path": "board/drobit/board.c",
"diff": "@@ -357,16 +357,14 @@ const int usb_port_enable[USB_PORT_COUNT] = {\nGPIO_EN_PP5000_USBA,\n};\n-static enum gpio_signal ps8xxx_rst_odl = GPIO_USB_C1_RT_RST_ODL;\n-\nstatic void ps8815_reset(vo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | drobit: remove board ID 0 checks
Board ID 0 checks were only used on the volteer reference board.
BUG=b:149858568
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ib295f480b9645f9149f5ea1aad2fe06e45692219
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519963
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org> |
136,330 | 03.11.2020 10:12:29 | 25,200 | 099d65c7f787b4d6b4914892ce59b6656dd03aa9 | TCPMv2: Correct PE_VDM_Response name string
PE_VDM_RESPONSE isn't a superstate.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "@@ -353,7 +353,6 @@ static const char * const pe_state_names[] = {\n[PE_PRS_FRS_SHARED] = \"SS:PE_PRS_FRS_SHARED\",\n#endif\n[PE_VDM_SEND_REQUEST] = \"SS:PE_VDM_Send_Request\",\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Correct PE_VDM_Response name string
PE_VDM_RESPONSE isn't a superstate.
BUG=none
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I3450f4eb0d12bd71187932b453bbb7ebeade7f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2517780
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Jett Rink <jettrink@chromium.org> |
136,305 | 03.11.2020 14:02:21 | 25,200 | 23150c06baabe8db9796045036cb1f5a99e65647 | COIL: Rename CONFIG_BOARD_I2C_ADDR_FLAGS
Rename CONFIG_BOARD_I2C_ADDR_FLAGS and related comments.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "chip/max32660/i2c_chip.c",
"new_path": "chip/max32660/i2c_chip.c",
"diff": "@@ -184,12 +184,12 @@ static mxc_i2c_regs_t *i2c_bus_ports[] = {MXC_I2C0, MXC_I2C1};\n#ifdef CONFIG_HOSTCMD_I2C_ADDR_FLAGS\n-#ifdef CONFIG_BOARD_I2C_SLAVE_ADDR_FLAGS\n+#ifdef CONFIG_BO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename CONFIG_BOARD_I2C_ADDR_FLAGS
Rename CONFIG_BOARD_I2C_ADDR_FLAGS and related comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I45d4945b5c1fa26c72d233fb9def4d9bdee1c9c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2518657
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,305 | 03.11.2020 14:10:00 | 25,200 | 1044b2dfac75e861f00e03bcfe3231506ca2ae93 | COIL: Rename local i2c variables in stm32f4
Rename local i2c variables and related comments to the new
controller/peripheral naming scheme.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/i2c-stm32f4.c",
"new_path": "chip/stm32/i2c-stm32f4.c",
"diff": "#define I2C_ERROR_FAILED_START EC_ERROR_INTERNAL_FIRST\n/* Transmit timeout in microseconds */\n-#define I2C_TX_TIMEOUT_MASTER (10 * MSEC)\n+#define I2C_TX_TIMEOUT_CONTROLLER (10 * MSE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename local i2c variables in stm32f4
Rename local i2c variables and related comments to the new
controller/peripheral naming scheme.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ibb6a2bdfe47824be6412d999e6c4eb0303e6b421
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2518658
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,305 | 03.11.2020 14:58:57 | 25,200 | e609f07eef8b851b19bf4b59b5263ac702d8b871 | COIL: Rename CONFIG_I2C_PERIPHERAL
Rename CONFIG_I2C_PERIPHERAL and related comments.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/max32660-eval/board.h",
"new_path": "board/max32660-eval/board.h",
"diff": "#undef CONFIG_HOSTCMD_EVENTS\n#define CONFIG_I2C\n-#define CONFIG_I2C_SLAVE\n+#define CONFIG_I2C_PERIPHERAL\n#define CONFIG_HOSTCMD_I2C_ADDR_FLAGS (0x51) /* 7 bit right-aligned *... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename CONFIG_I2C_PERIPHERAL
Rename CONFIG_I2C_PERIPHERAL and related comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I3f148e976f3a4d6a1dc6c58686368c056290d5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2518660
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,330 | 03.11.2020 15:01:01 | 25,200 | 0e4e3d174d406dbb3b12d1f4b35417c3a8c7ac1c | TCPMv2: Remove unnecessary braces
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pd_host.c",
"new_path": "common/usbc/usb_pd_host.c",
"diff": "@@ -111,9 +111,8 @@ static enum ec_status hc_typec_control(struct host_cmd_handler_args *args)\ncase TYPEC_CONTROL_COMMAND_CLEAR_EVENTS:\npd_clear_events(p->port, p->clear_events_mas... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Remove unnecessary braces
BUG=none
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Ia9ae2cf5092530013df1da080c03d1dfc7bf7678
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2518611
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,441 | 19.10.2020 20:19:48 | -19,080 | 89a9b11df0937068c41e38a858821ce20522ab9e | boldar: Modify GPIO assignment as per schematics
BRANCH=none
TEST=make BOARD=boldar
Tested-by: Sooraj Govindan | [
{
"change_type": "MODIFY",
"old_path": "board/boldar/board.c",
"new_path": "board/boldar/board.c",
"diff": "@@ -560,6 +560,12 @@ BUILD_ASSERT(CONFIG_USB_PD_PORT_MAX_COUNT == USBC_PORT_COUNT);\n/******************************************************************************/\n/* USBC mux configuration... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | boldar: Modify GPIO assignment as per schematics
BUG=b:162202257
BRANCH=none
TEST=make BOARD=boldar
Signed-off-by: Sooraj Govindan <sooraj.govindan@intel.com>
Change-Id: I6494aff3c5a5b85263c128d04d9584bc509275c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2488260
Tested-by: Sooraj Govindan <sooraj.govindan@intel.corp-partner.google.com>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: caveh jalali <caveh@chromium.org> |
136,305 | 04.11.2020 14:54:44 | 25,200 | 65f7bd8137a8e8754f26146387a88f400b3f5b31 | Waddledee: Add pull-ups to volume GPIOs
Add internal pull-ups to volume button GPIOs.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/waddledee/gpio.inc",
"new_path": "board/waddledee/gpio.inc",
"diff": "@@ -37,8 +37,8 @@ GPIO_INT(USB_C0_CCSBU_OVP_ODL, PIN(K, 6), GPIO_INT_FALLING | GPIO_PULL_UP, c0_cc\n/* Other interrupts */\nGPIO_INT(LID_OPEN, PIN(F, 3), GPIO_INT_BOTH, lid_interrupt)\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Add pull-ups to volume GPIOs
Add internal pull-ups to volume button GPIOs.
BRANCH=None
BUG=b:172487251
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I884f5180fa09318192b50ec1b7da6d3a8c741cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2520100
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,269 | 05.11.2020 10:23:05 | 28,800 | 1a7aded92c86873f07f5d3c4d29b50808a04f735 | docs/fingerprint: Workaround mdformat and gitiles note syntax
mdformat incorrectly formats "*** note" blocks, so disable mdformat on
those blocks.
BRANCH=none
TEST=View in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/fingerprint/fingerprint-debugging.md",
"new_path": "docs/fingerprint/fingerprint-debugging.md",
"diff": "@@ -36,6 +36,7 @@ used for JTAG and SWD for ARM devices.\nThe connector for SWD is `J4` on Dragonclaw v0.2.\n+<!-- mdformat off(b/139308852) -->\n*** ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/fingerprint: Workaround mdformat and gitiles note syntax
mdformat incorrectly formats "*** note" blocks, so disable mdformat on
those blocks.
BRANCH=none
BUG=none
TEST=View in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I4a7894402373a4c91688263454d33554b324aece
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2521452
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,269 | 05.11.2020 10:30:54 | 28,800 | 947aeb96d81efc41c55a801bf37e58c1c45d06dd | docs/fingerprint: Run mdformat on markdown docs
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/fingerprint/fingerprint-authentication-design-doc.md",
"new_path": "docs/fingerprint/fingerprint-authentication-design-doc.md",
"diff": "@@ -760,10 +760,13 @@ The log file is `/var/log/cros_fp.log`.\nappending \"export/png\" to the Google Drive link. -->\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/fingerprint: Run mdformat on markdown docs
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ib5a0f5e3e910b238139bee690d059362a40622ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2521453
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,269 | 05.11.2020 11:32:30 | 28,800 | 8dfdaa83815669c50f70332932fa35614ef2e4f6 | docs/fingerprint: Add fingerprint template sizes
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/fingerprint/fingerprint.md",
"new_path": "docs/fingerprint/fingerprint.md",
"diff": "@@ -28,10 +28,17 @@ The main source code for fingerprint sensor functionality lives in the\nThe following \"boards\" (specified by the `BOARD` environment variable when\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/fingerprint: Add fingerprint template sizes
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I68d9364c0d02fdf30e00df40f514f68829d2cece
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2521835
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,340 | 21.10.2020 16:11:07 | 25,200 | 851daf728dca124f4bb2b6d27238d3952be5cf2b | motion: orientation: update interface
Enabling orientation sensor would not compile anymore.
Fix interface by replacing macros with functions.
BRANCH=none
TEST=Compile when enabled on grunt and eve. | [
{
"change_type": "MODIFY",
"old_path": "common/build.mk",
"new_path": "common/build.mk",
"diff": "@@ -108,6 +108,7 @@ common-$(CONFIG_MAG_CALIBRATE)+= mag_cal.o math_util.o vec3.o mat33.o mat44.o \\\ncommon-$(CONFIG_MKBP_EVENT)+=mkbp_event.o\ncommon-$(CONFIG_OCPC)+=ocpc.o\ncommon-$(CONFIG_ONEWIRE)+=... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | motion: orientation: update interface
Enabling orientation sensor would not compile anymore.
Fix interface by replacing macros with functions.
BUG=chromium:718919
BRANCH=none
TEST=Compile when enabled on grunt and eve.
Change-Id: Ic5d6992d040cde79ef3f691db494804e160b7650
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491266
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org> |
136,340 | 20.10.2020 22:40:16 | 25,200 | d131be135e9403df05235fb57a91be1fad56326d | common: motion: add IF_ENABLED()
Split some defines when necessary, add IF_ENABLED to
common/motion_sense.c.
Find small setting errors in some boards along the way.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.h",
"new_path": "board/asurada/board.h",
"diff": "#define CONFIG_CMD_ACCELS\n#ifdef BOARD_ASURADA\n+#define CONFIG_ALS\n#define ALS_COUNT 1\n#define CONFIG_ALS_TCS3400\n#define CONFIG_ALS_TCS3400_INT_EVENT \\\n"
},
{
"change_type": ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: motion: add IF_ENABLED()
Split some defines when necessary, add IF_ENABLED to
common/motion_sense.c.
Find small setting errors in some boards along the way.
BUG=chromium:1140877
BRANCH=none
TEST=buildall
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I77ff528a16809088a986a2cc707aff8ae7df3906
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2488939
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org> |
136,340 | 20.10.2020 23:32:52 | 25,200 | bf3190f8ed0eb50473f1c00a2ccd172c12367500 | motion_lid: Add IS_ENABLED()
Add IS_ENABLED() instead of #ifdef when possible.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "common/motion_lid.c",
"new_path": "common/motion_lid.c",
"diff": "@@ -100,6 +100,15 @@ static const struct motion_sensor_t * const accel_base =\nstatic const struct motion_sensor_t * const accel_lid =\n&motion_sensors[CONFIG_LID_ANGLE_SENSOR_LID];\n+STATIC_IF(... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | motion_lid: Add IS_ENABLED()
Add IS_ENABLED() instead of #ifdef when possible.
BUG=chromium:1140877
BRANCH=none
TEST=buildall
Change-Id: I644e8ceb066a83531632709a59b29b257f259929
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2489460
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org> |
136,340 | 20.10.2020 23:45:19 | 25,200 | 2d900dc16b610703296803e438a8728036c06ea4 | driver: bmi260: Use IS_ENABLED()
Add IS_ENABLED() instead of #ifdef when possible in bmi260 and
bmi_common.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/accelgyro_bmi260.c",
"new_path": "driver/accelgyro_bmi260.c",
"diff": "@@ -289,18 +289,17 @@ static int config_interrupt(const struct motion_sensor_t *s)\nret = bmi_write8(s->port, s->i2c_spi_addr_flags,\nBMI260_INT1_IO_CTRL,\nBMI260_INT1_OUTPUT_EN);\n-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: bmi260: Use IS_ENABLED()
Add IS_ENABLED() instead of #ifdef when possible in bmi260 and
bmi_common.
BUG=chromium:1140877
BRANCH=none
TEST=buildall
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: If8e36ed2a527e8a4ac9582a7b30fe7f7ff589a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2489461
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org> |
136,340 | 20.10.2020 23:45:56 | 25,200 | 25588eb6a324d4e9f72b1a25fdcef4fc55bd653f | common: body: Use IS_ENABLED
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "common/body_detection.c",
"new_path": "common/body_detection.c",
"diff": "@@ -92,7 +92,7 @@ static int calculate_motion_confidence(uint64_t var)\n/* Change the motion state and commit the change to AP. */\nvoid body_detect_change_state(enum body_detect_states ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: body: Use IS_ENABLED
BUG=chromium:1140877
BRANCH=none
TEST=buildall
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: Iac63ec83258d1194d2b035c1dd67b6f915d37c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2489462
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org> |
136,340 | 21.10.2020 12:57:22 | 25,200 | 7413dd10826ecb42cc2ee6b0a7919be2b290dd57 | driver: use IS_ENABLED on more accelerometer drivers
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/accel_kionix.c",
"new_path": "driver/accel_kionix.c",
"diff": "#define T(s_) V(s_)\n#endif /* !defined(CONFIG_ACCEL_KXCJ9) || !defined(CONFIG_ACCEL_KX022) */\n+STATIC_IF(CONFIG_KX022_ORIENTATION_SENSOR) int check_orientation_locked(\n+ const struct moti... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: use IS_ENABLED on more accelerometer drivers
BUG=chromium:1140877
BRANCH=none
TEST=buildall
Change-Id: I3c45918b628d4f0999842922680a948cdd4933a2
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491267
Reviewed-by: Ching-Kang Yen <chingkang@chromium.org> |
136,256 | 05.11.2020 14:38:28 | 25,200 | 687c2062e7a50e1e03692e74171b7d960207f31a | zephyr: add zmake.yaml files
Add the zmake config file for test that don't have one
BRANCH=none
TEST=zmake builds both tests
zmake configure -b /tmp/test
~/chromiumos/src/platform/ec/zephyr/test/tasks
zmake build /tmp/test | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "zephyr/test/base32/zmake.yaml",
"diff": "+# Copyright 2020 The Chromium OS Authors. All rights reserved.\n+# Use of this source code is governed by a BSD-style license that can be\n+# found in the LICENSE file.\n+\n+board: native_posix\n+support... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: add zmake.yaml files
Add the zmake config file for test that don't have one
BRANCH=none
BUG=none
TEST=zmake builds both tests
zmake configure -b /tmp/test
~/chromiumos/src/platform/ec/zephyr/test/tasks
zmake build /tmp/test
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: Ibd9fd114e7fff008bb07cb616529d82cdb774a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2521064
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,324 | 04.11.2020 10:24:09 | 25,200 | 0098a59bc33687baccabacf85ed09fc06adad742 | genvif: USB4_Supported
Use CONFIG_USB_PD_USB4 to configure this field
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "#define VIF_APP_VENDOR_VALUE \"Google\"\n#define VIF_APP_NAME_VALUE \"EC GENVIF\"\n-#define VIF_APP_VERSION_VALUE \"3.0.0.4\"\n+#define VIF_APP_VERSION_VALUE \"3.0.0.5\"\n#define VENDOR_NAME_VALUE \"Google\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: USB4_Supported
Use CONFIG_USB_PD_USB4 to configure this field
BUG=b:172417432
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I80c1c21b5b30661973a59cb2b3a982fbf39d7661
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519810
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,324 | 04.11.2020 10:45:38 | 25,200 | 9eccf30feb21c00ff9591c398ecf49489b223275 | genvif: made default missing PID/TID 0xFFFF
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "#define VIF_APP_VERSION_VALUE \"3.0.0.5\"\n#define VENDOR_NAME_VALUE \"Google\"\n+#define DEFAULT_MISSING_TID 0xFFFF\n+#define DEFAULT_MISSING_PID 0xFFFF\nconst uint32_t *src_pdo;\nuint32_t src_pdo_cnt;\n@@... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: made default missing PID/TID 0xFFFF
BUG=b:172419785
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I967597e1070ad87c70c96bd9e2fc1f9e20667cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519811
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 04.11.2020 11:22:37 | 25,200 | b78cfb3fb8ca70659c54957c7f5d38a01d8fffa1 | genvif: BC_1_2_Support and BC_1_2_Charging_Port_Type
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -55,6 +55,15 @@ enum usb_speed {\nUSB_GEN22 = 4\n};\n+/*\n+ * BC_1_2_SUPPORT options\n+ */\n+enum bc_1_2_support {\n+ BC_1_2_SUPPORT_NONE = 0,\n+ BC_1_2_SUPPORT_PORTABLE_DEVICE = 1,\n+ BC_1_2_SUPPORT_CHA... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: BC_1_2_Support and BC_1_2_Charging_Port_Type
BUG=b:172417926,b:172419455
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I241d69d86f631fb6b4cb56136d10e737e8a1fb60
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519953
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 04.11.2020 12:30:18 | 25,200 | 47efb3640fbd043366ac997e5b6f2b61b4459dae | genvif: PID_SOP
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -639,7 +639,6 @@ __maybe_unused static void set_vif_field_itis(struct vif_field_t *vif_field,\n* DFP_VDO_Port_Number numericFieldType\n* Modal_Operation_Supported_SOP booleanFieldType\n* USB_VID_SOP nume... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: PID_SOP
BUG=b:172424889
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I4e66d60265f2cc71d82b54cfb70ceef76004a63e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519402
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,324 | 04.11.2020 12:41:12 | 25,200 | 472ab5ec9d597e089dc0b3e006dc63251c473eca | genvif: Responds_To_Discov_SOP_DFP
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -1337,7 +1337,8 @@ static int gen_vif(const char *name,\nset_vif_field_b(&vif_fields[Responds_To_Discov_SOP_DFP],\n\"Responds_To_Discov_SOP_DFP\",\n- false);\n+ (IS_ENABLED(CONFIG_USB_PD_USB4) ||\n+ IS_E... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Responds_To_Discov_SOP_DFP
BUG=b:172424872
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I8f7f4e074a5dd7549e1613b22843752b07f23273
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519403
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,324 | 04.11.2020 13:49:59 | 25,200 | 1fdb3fb24fb9923ca18d67a5e34a442a2acb1143 | genvif: Certification_Type
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -1078,8 +1078,8 @@ static int gen_vif(const char *name,\nset_vif_field(&vif_fields[Certification_Type],\n\"Certification_Type\",\n- \"1\",\n- \"Reference Platform\");\n+ \"0\",\n+ \"End Product\");\n/***... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Certification_Type
BUG=b:172463173
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I97c393a981796e7257e25a53bfd684cb6dc94593
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519405
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 04.11.2020 14:07:48 | 25,200 | b824f8ca4df75518669f2f6e3e8b6b3b017765df | genvif: Responds_To_Discov_SOP_UFP
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -1333,7 +1333,8 @@ static int gen_vif(const char *name,\nset_vif_field_b(&vif_fields[Responds_To_Discov_SOP_UFP],\n\"Responds_To_Discov_SOP_UFP\",\n- false);\n+ (IS_ENABLED(CONFIG_USB_PD_USB4) ||\n+ IS_E... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Responds_To_Discov_SOP_UFP
BUG=b:172422719
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I836b03206ef80727516cd6f874d2091a0c41a49d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519406
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,190 | 02.11.2020 14:51:47 | 28,800 | 2de0771d670e072e6a60973543f70318c1345d56 | TCPMv2: Update 'pdcable' console command
This patchset adds information about cable's Thunderbolt mode
response.
BRANCH=none
TEST=EC command "pdcable <port>" prints out the information about the
cable. | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_console_cmd.c",
"new_path": "common/usb_pd_console_cmd.c",
"diff": "@@ -114,6 +114,7 @@ static int command_cable(int argc, char **argv)\nstruct pd_discovery *disc;\nenum idh_ptype ptype;\nint cable_rev;\n+ union tbt_mode_resp_cable cable_mode_res... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Update 'pdcable' console command
This patchset adds information about cable's Thunderbolt mode
response.
BUG=b:129990370
BRANCH=none
TEST=EC command "pdcable <port>" prints out the information about the
cable.
Signed-off-by: Ayushee <ayushee.shah@intel.com>
Change-Id: I485fb767009242636332e19ed7d211dbcc837b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2515063
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,311 | 04.11.2020 12:55:25 | 25,200 | 2964489475b13ddd5ffae7023bd07ce3af65cc9e | trondo: remove board ID 0 checks
Board ID 0 checks were only used on the volteer reference board.
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/trondo/gpio.inc",
"new_path": "board/trondo/gpio.inc",
"diff": "@@ -43,13 +43,6 @@ GPIO_INT(USB_C1_MIX_INT_ODL, PIN(0, 3), GPIO_INT_BOTH, bc12_interrupt)\n/* Volume button interrupts */\nGPIO_INT(EC_VOLDN_BTN_ODL, PIN(9, 3), GPIO_INT_BOTH | GPIO_PULL_UP,... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | trondo: remove board ID 0 checks
Board ID 0 checks were only used on the volteer reference board.
BUG=b:149858568
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I91c949c74e455ee620b22c771a2c62341eba46a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519965
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org> |
136,360 | 06.10.2020 23:27:21 | -28,800 | 4d8de47ad47141bbc070725a0a4359a126bbb962 | common: body_detection: modify variance updating formula
Modify the variance formula to speed up body detection.
BRANCH=None
TEST=make buildall;
TEST=make BOARD=ampton, re-flash the DUT, see if the body detection
works | [
{
"change_type": "MODIFY",
"old_path": "common/body_detection.c",
"new_path": "common/body_detection.c",
"diff": "@@ -48,18 +48,18 @@ static struct body_detect_motion_data\n* x_0: oldest value in the window, will be replaced by x_n\n* x_n: new coming value\n*\n- * n^2 * var(x') = n^2 * var(x) + (sum... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: body_detection: modify variance updating formula
Modify the variance formula to speed up body detection.
BRANCH=None
BUG=b:123434029
TEST=make buildall;
TEST=make BOARD=ampton, re-flash the DUT, see if the body detection
works
Signed-off-by: Ching-Kang Yen <chingkang@chromium.org>
Change-Id: Ib444abb6bdfbc637539103d563b515817865acc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2452133
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> |
136,331 | 06.11.2020 14:49:21 | 25,200 | 9af5df80b12b7a4d1462507e23d4b3100f6f371b | zephyr: cleanup unused _ZEPHYR_WARN_UNIMPLEMENTED macro
Tasks are implemented now, so this can go away.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "include/task.h",
"new_path": "include/task.h",
"diff": "#include \"compile_time_macros.h\"\n#include \"task_id.h\"\n-#ifdef CONFIG_ZEPHYR\n-#include <sys/printk.h>\n-#define _ZEPHYR_WARN_UNIMPLEMENTED(func, args...) \\\n- printk(\"WARN: not implemented - %s(%s... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: cleanup unused _ZEPHYR_WARN_UNIMPLEMENTED macro
Tasks are implemented now, so this can go away.
BUG=b:171741620
BRANCH=none
TEST=buildall
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I0ce8d680d80eb2ac1bfa3f9ca31143f7f8924af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2523386
Commit-Queue: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,331 | 06.11.2020 14:25:18 | 25,200 | 8141e8d7eeeb915f2b529de39570e2efc8b86466 | zephyr: add option to shim power button
Add an option to shim the power button module.
BRANCH=none
TEST=volteer: press power button, observe UART output | [
{
"change_type": "MODIFY",
"old_path": "zephyr/CMakeLists.txt",
"new_path": "zephyr/CMakeLists.txt",
"diff": "@@ -43,5 +43,7 @@ zephyr_sources_ifdef(CONFIG_PLATFORM_EC_KEYBOARD_PROTOCOL_8042\n\"${PLATFORM_EC}/common/keyboard_8042.c\")\nzephyr_sources_ifdef(CONFIG_PLATFORM_EC_LID_SWITCH\n\"${PLATFORM... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: add option to shim power button
Add an option to shim the power button module.
BUG=b:172471187
BRANCH=none
TEST=volteer: press power button, observe UART output
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I7dbc705b19bfc312e2707080f22e411ebd7e2c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2523382 |
136,324 | 06.11.2020 09:58:00 | 25,200 | 687ec68c0cfa1f7a1c9dc431c4f5606ad982b8ba | genvif: Unconstrained_Power
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -1314,14 +1314,32 @@ static int gen_vif(const char *name,\nsupports_to_ufp);\n}\n- if (is_src())\n+ if (is_src()) {\n+ /* SRC capable */\n+ if (IS_ENABLED(CONFIG_CHARGER))\n+ /* USB-C UP bit set */\nset_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Unconstrained_Power
BUG=b:172419824
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I465fadb323649fbcace24f81a944595a0751d714
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2522670
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,324 | 06.11.2020 11:17:28 | 25,200 | 70a1969f52d1d2b5d9bb71b68a42312378ed73ce | genvif: split up initialization to spec field groupings
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -552,41 +552,39 @@ __maybe_unused static void set_vif_field_itis(struct vif_field_t *vif_field,\n*\n* Fields that are not currently being initialized\n*\n- * vif_cableSVIDModeList\n- * SVID_Mode_Enter bo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: split up initialization to spec field groupings
BUG=b:172665003
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: Ic356fc0df99e449f90bdb0390e5473c621f717d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2523451
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 06.11.2020 14:07:31 | 25,200 | 191358533747137fc2d05c86bb56375cbc939c32 | genvif: Product_Total_Source_Power_mW
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -100,11 +100,16 @@ static bool can_act_as_host(void)\nstatic void init_src_pdos(void)\n{\n- if (IS_ENABLED(CONFIG_USB_PD_DYNAMIC_SRC_CAP))\n+ if (IS_ENABLED(CONFIG_USB_PD_DYNAMIC_SRC_CAP)) {\nsrc_pdo_cnt... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Product_Total_Source_Power_mW
BUG=b:172439432
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I9440fc55caf33adce3e5b846e3ad9dd68ce44d35
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2523378
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 06.11.2020 14:27:09 | 25,200 | 3b4177ddd41a6f39725b6fe80b0ad01bf1bf7cad | genvif: XID_SOP
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -1888,9 +1888,13 @@ static void init_vif_component_pd_dual_role_fields(\nstatic void init_vif_component_sop_discovery_fields(\nstruct vif_field_t *vif_fields)\n{\n- if (IS_ENABLED(CONFIG_USB_PD_TCPMV2)) ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: XID_SOP
BUG=b:172424930,b:172842768
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: Ib7734fca61b9169f718ce58aa15277251d2bd560
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2523383
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 09.11.2020 12:40:16 | 25,200 | a248d123396d550d13477501f50515963a6579a9 | genvif: Manufacturer_Info_VID_Port not set
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -1363,6 +1363,11 @@ static void init_vif_component_general_pd_fields(\n\"Manufacturer_Info_Supported_Port\",\ntrue);\n+ sprintf(hex_str, \"%04X\", USB_VID_GOOGLE);\n+ set_vif_field_itss(&vif_fields[Manuf... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Manufacturer_Info_VID_Port not set
BUG=b:172842249
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I7fa19424a37c2a295f94351143ed22821968ea3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2527702
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,278 | 09.11.2020 18:30:09 | 28,800 | 2af47a9f36ae41df32ef498f12f82bd7034073c1 | lingcod: enable EFS2
This enables EFS2 on lingcod.
BRANCH=volteer
TEST=buildall succeeds | [
{
"change_type": "MODIFY",
"old_path": "board/lingcod/board.h",
"new_path": "board/lingcod/board.h",
"diff": "/* Optional features */\n#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */\n+#define CONFIG_VBOOT_EFS2\n+\n#define CONFIG_POWER_BUTTON\n#undef CONFIG_UART_TX_BUF_SI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | lingcod: enable EFS2
This enables EFS2 on lingcod.
BRANCH=volteer
BUG=b:172877836
TEST=buildall succeeds
Change-Id: Ic3cc5c508f83d8679f11ec8e268b7f7822150ba4
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2528700
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org> |
136,378 | 10.11.2020 21:11:22 | -28,800 | a3b99150e32f368567eeeba9a2c3a8f65fee4b43 | Coachz: support battery GH02047XL
support battery GH02047XL
BRANCH=master
TEST=make BOARD=coachz -j
flash ec and check battery info | [
{
"change_type": "MODIFY",
"old_path": "board/coachz/battery.c",
"new_path": "board/coachz/battery.c",
"diff": "*/\nconst struct board_batt_params board_battery_info[] = {\n+ /* COSMX GH02047XL 333-1C-DA-A */\n+ [BATTERY_GH02047XL_1C] = {\n+ .fuel_gauge = {\n+ .manuf_name = \"333-1C-DA-A\",\n+ .devi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Coachz: support battery GH02047XL
support battery GH02047XL
BRANCH=master
BUG=b:172613247
TEST=make BOARD=coachz -j
flash ec and check battery info
Change-Id: I6bdb0b18a88272e56b2aba1f82c99620243a70be
Signed-off-by: Simon Zhou <zhouguohui@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2529269
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,208 | 11.11.2020 11:32:35 | -28,800 | 9438922dc9332fed7b4e8cf7dc7d2345b00b7ba1 | asruada: use hayato image as asurada
Deprecate asurada image and use hayato image instead.
Define BOARD_ASURADA_REV0 to get the old asurada image back.
TEST=make buildall -j
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "@@ -620,7 +620,7 @@ static struct mutex g_lid_mutex;\nstatic struct bmi_drv_data_t g_bmi160_data;\nstatic struct stprivate_data g_lis2dwl_data;\n-#ifdef BOARD_ASURADA\n+#ifdef BOARD_ASURADA_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asruada: use hayato image as asurada
Deprecate asurada image and use hayato image instead.
Define BOARD_ASURADA_REV0 to get the old asurada image back.
BUG=none
TEST=make buildall -j
BRANCH=none
Change-Id: I10bc67bf36337158d30918e2b77070328b963f33
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2530816
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,448 | 10.11.2020 09:42:46 | -28,800 | 4f32e20770141ed0d8ab4fab282039abb371abf4 | Metaknight: Reconfig LED GPIO, and modify Led behavior
Config GPIOC3, GPIOC4 to control LED.
Move GPIOC2 to NC pins.
Modify Led behavior.
BRANCH=master
TEST=make BOARD=metaknight PASS
TEST=Led behavior is correct after change. | [
{
"change_type": "MODIFY",
"old_path": "board/metaknight/board.c",
"new_path": "board/metaknight/board.c",
"diff": "@@ -502,18 +502,6 @@ const struct pwm_t pwm_channels[] = {\n.flags = PWM_CONFIG_DSLEEP,\n.freq = 10000,\n},\n-\n- [PWM_CH_LED1_AMBER] = {\n- .channel = 2,\n- .flags = PWM_CONFIG_DSLEEP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Metaknight: Reconfig LED GPIO, and modify Led behavior
Config GPIOC3, GPIOC4 to control LED.
Move GPIOC2 to NC pins.
Modify Led behavior.
BUG=b:172845491
BRANCH=master
TEST=make BOARD=metaknight PASS
TEST=Led behavior is correct after change.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: Icc86b6e6c7e6541c73d70c0903a609be419782ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2528730
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,278 | 09.11.2020 18:31:21 | 28,800 | 09aed466c25320fff53e0e33440ad7c745c22828 | malefor: enable EFS2
This enables EFS2 on malefor.
BRANCH=volteer
TEST=buildall succeeds | [
{
"change_type": "MODIFY",
"old_path": "board/malefor/board.h",
"new_path": "board/malefor/board.h",
"diff": "/* Optional features */\n#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */\n+#define CONFIG_VBOOT_EFS2\n+\n#define CONFIG_POWER_BUTTON\n#undef CONFIG_UART_TX_BUF_SI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | malefor: enable EFS2
This enables EFS2 on malefor.
BRANCH=volteer
BUG=b:172877805
TEST=buildall succeeds
Change-Id: I6ea7f751075b2e540012ec03034568b82ce5ab89
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2528702
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Commit-Queue: Nick Vaccaro <nvaccaro@google.com> |
136,256 | 10.11.2020 16:51:07 | 25,200 | 737d4205a62c4b70ad33a6fbd547f5cb3f2b888c | zephyr/kconfig: put KB protocol because KB option
The PLATFORM_EC_KEYBOARD_PROTOCOL_8042 should be guarded
by the PLATFORM_EC_KEYBOARD option.
BRANCH=none
TEST=build posix-ec with CL stack | [
{
"change_type": "MODIFY",
"old_path": "zephyr/Kconfig",
"new_path": "zephyr/Kconfig",
"diff": "@@ -47,6 +47,8 @@ menuconfig PLATFORM_EC_KEYBOARD\nkeyboard_state_changed() (for i8042) or its client calling\nkeyboard_scan_get_state() (for MKBP).\n+if PLATFORM_EC_KEYBOARD\n+\nchoice \"Protocol select\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr/kconfig: put KB protocol because KB option
The PLATFORM_EC_KEYBOARD_PROTOCOL_8042 should be guarded
by the PLATFORM_EC_KEYBOARD option.
BRANCH=none
BUG=b:172512307
TEST=build posix-ec with CL stack
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: Idd070454a11ed65cab763ff7788dec4b907f610d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2530152
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,418 | 11.11.2020 09:54:35 | 28,800 | f72245e58348d084c7045c6a5304ddf96f8b6e4b | ps8xxx: Fix a typo of product ID, PS8751 vs PS8705
Should be PS8751 instead of PS8705.
BRANCH=None
TEST=Built a Trogdor image successfully. | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/ps8xxx.c",
"new_path": "driver/tcpm/ps8xxx.c",
"diff": "@@ -487,7 +487,7 @@ static int ps8xxx_enter_low_power_mode(int port)\n* its own in ~2 seconds. Other chips don't have it. Stub it out for\n* PS8751.\n*/\n- if (product_id[port] == PS8705_PRODU... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ps8xxx: Fix a typo of product ID, PS8751 vs PS8705
Should be PS8751 instead of PS8705.
BRANCH=None
BUG=b:171446429, b:173004739
TEST=Built a Trogdor image successfully.
Change-Id: Id99f2b424038327346a7b6ef995fa35c7d4723fd
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532680
Commit-Queue: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,257 | 03.11.2020 09:04:43 | -28,800 | 7f0c15e6d2accd3aec28c93ff7add11268e3e6c7 | eldrid: add FW_CONFIG support for different keyboard layout
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
TEST=
ectool cbi get = 0x14902
ectool cbi set 0x114902 4 | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/cbi_ec_fw_config.c",
"new_path": "baseboard/volteer/cbi_ec_fw_config.c",
"diff": "@@ -49,3 +49,7 @@ bool ec_cfg_has_numeric_pad(void)\nreturn (fw_config.num_pad == NUMERIC_PAD_ENABLED);\n}\n+enum ec_cfg_keyboard_layout ec_cfg_keyboard_layout(... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eldrid: add FW_CONFIG support for different keyboard layout
BUG=b:172133632
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
TEST=
ectool cbi get = 0x14902
ectool cbi set 0x114902 4
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: I0decd978bf6c21dddd315857bb1a29ac20dbf276
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2528732
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,280 | 11.11.2020 17:39:31 | -28,800 | e32ef79d5229489e9ed824d9ea164c915587b3cf | asurada: allow vconn swap
TEST=none
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/usb_pd_policy.c",
"new_path": "board/asurada/usb_pd_policy.c",
"diff": "@@ -188,8 +188,8 @@ void pd_power_supply_reset(int port)\nint pd_check_vconn_swap(int port)\n{\n- /* TODO: Only allow vconn swap if PP4200_G rail is enabled , s3/s0 on */\n- ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: allow vconn swap
BUG=b:171539818
TEST=none
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I7606abe8adb3ab3d3a6aee876e47305e7c6a6d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532194
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,256 | 12.11.2020 15:46:53 | 25,200 | a7bc367e9af458ab8c5fa8f091ee451be55ea770 | zephyr: fix issue with set_event hanging before tasks start
Initialize the kernel objects before application code as a chance to run.
This ensures that any event that is set before tasks start will get
delivered (and won't crash the kernel).
BRANCH=none
TEST=included unit test | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/src/tasks.c",
"new_path": "zephyr/shim/src/tasks.c",
"diff": "@@ -177,9 +177,6 @@ static void task_entry(void *task_contex, void *unused1, void *unused2)\n/* Name thread for debugging */\nk_thread_name_set(ctx->zephyr_tid, ctx->name);\n- /* Initial... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: fix issue with set_event hanging before tasks start
Initialize the kernel objects before application code as a chance to run.
This ensures that any event that is set before tasks start will get
delivered (and won't crash the kernel).
BRANCH=none
BUG=none
TEST=included unit test
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I84ecfddbe706e7e1860f310571851ee8dedd07d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2535984 |
136,448 | 29.10.2020 08:33:08 | -28,800 | 37099f548be3c5c8486bee51e724f5153d18a6c8 | Metaknight: Add battery PC-VP-BP144
Support new battery PC-VP-BP144
BRANCH=master
TEST=Make sure battery can cutoff by console "cutoff" or "ectool
batterycutoff" and resume by plug in adapter. | [
{
"change_type": "MODIFY",
"old_path": "board/metaknight/battery.c",
"new_path": "board/metaknight/battery.c",
"diff": "* address, mask, and disconnect value need to be provided.\n*/\nconst struct board_batt_params board_battery_info[] = {\n- /* POW-TECH Battery Information */\n- [BATTERY_POWER_TECH... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Metaknight: Add battery PC-VP-BP144
Support new battery PC-VP-BP144
BUG=b:172390536
BRANCH=master
TEST=Make sure battery can cutoff by console "cutoff" or "ectool
batterycutoff" and resume by plug in adapter.
Signed-off-by: yu-an.chen@quanta.corp-partner.google.com
Change-Id: I11db98f37a27afd513a0f5adf04ff57a5eb2fbfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2526040
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,287 | 11.11.2020 10:40:54 | 25,200 | 7bb5568c04011aecdeda2e55a0ca69443d497e3b | Zephyr: Migrate i2c implementation to chip family specific file
This change simply moves the i2c.c shim to i2c-npcx7.c.
BRANCH=none
TEST=builds with zmake for volteer | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/chip/npcx/CMakeLists.txt",
"new_path": "zephyr/shim/chip/npcx/CMakeLists.txt",
"diff": "# Use of this source code is governed by a BSD-style license that can be\n# found in the LICENSE file.\n-zephyr_sources(i2c.c)\n+string(TOLOWER \"i2c-${CHIP_FAM... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zephyr: Migrate i2c implementation to chip family specific file
This change simply moves the i2c.c shim to i2c-npcx7.c.
BRANCH=none
BUG=none
TEST=builds with zmake for volteer
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: Ic410787dcf2693dda71681f739c0b74cd47770da
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2532964
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org> |
136,269 | 13.11.2020 13:46:05 | 28,800 | 058ee18532371d99300bd6a36d1fdf6ff4ab973e | PRESUBMIT: skip license check for third_party code
Intentionally including the directories separately since it's possible
third party code added in the future could use the standard license.
BRANCH=none
TEST=CQ passes | [
{
"change_type": "MODIFY",
"old_path": "PRESUBMIT.cfg",
"new_path": "PRESUBMIT.cfg",
"diff": "@@ -13,7 +13,13 @@ checkpatch_check: --no-tree --ignore=MSLEEP,VOLATILE,SPDX_LICENSE_TAG\nkerneldoc_check: --include_regex=\\bec_commands\\.h$\ncros_license_check :\n+ --exclude_regex=^third_party/bmi260/\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | PRESUBMIT: skip license check for third_party code
Intentionally including the directories separately since it's possible
third party code added in the future could use the standard license.
BRANCH=none
BUG=b:169276911
TEST=CQ passes
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I238aa216c01a6b7749290e7287d4b9d4745da52b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537011
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,418 | 13.11.2020 14:45:52 | 28,800 | 3d92ea3a2fe46a2099accf18a5544c565cadee9f | Trogdor: Move CONFIG_CMD_AP_RESET_LOG out of bringup list
Move this CONFIG from bringup to production.
BRANCH=None
TEST=Built the image. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/trogdor/baseboard.h",
"new_path": "baseboard/trogdor/baseboard.h",
"diff": "#define CONFIG_POWER_PP5000_CONTROL\n#define CONFIG_POWER_TRACK_HOST_SLEEP_STATE\n#define CONFIG_POWER_SLEEP_FAILURE_DETECTION\n+#define CONFIG_CMD_AP_RESET_LOG\n/*\n* Macros... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trogdor: Move CONFIG_CMD_AP_RESET_LOG out of bringup list
Move this CONFIG from bringup to production.
BRANCH=None
BUG=b:169736149
TEST=Built the image.
Change-Id: I490499f3a85f91c6f07a0e099b8c0738bf0eb787
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538262
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,418 | 13.11.2020 14:33:01 | 28,800 | 955427047a0509a777a32eb0be930eba96620158 | Lazor: Remove the bring-up features
Remove all the bring-up features.
BRANCH=None
TEST=Built the image. | [
{
"change_type": "MODIFY",
"old_path": "board/lazor/board.h",
"new_path": "board/lazor/board.h",
"diff": "#include \"baseboard.h\"\n-/* TODO(waihong): Remove the following bringup features */\n-#define CONFIG_USB_PD_DEBUG_LEVEL 3\n-#define CONFIG_CMD_GPIO_EXTENDED\n-#define CONFIG_CMD_POWERINDEBUG\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Lazor: Remove the bring-up features
Remove all the bring-up features.
BRANCH=None
BUG=b:169736149
TEST=Built the image.
Change-Id: Ic1175c11ffede2e1267c88b1932724b5c34a2424
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538263
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,282 | 13.11.2020 17:04:45 | -28,800 | eb76e68d291648c60b2ff9cde3d071785add90a6 | drawlat: Add CosMX battery
BRANCH=none
TEST=Test on charging/discharging/battery cut off pass. | [
{
"change_type": "MODIFY",
"old_path": "board/drawcia/battery.c",
"new_path": "board/drawcia/battery.c",
"diff": "@@ -263,6 +263,35 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 60,\n},\n},\n+\n+ /* CosMX B00C4473A9D0002 Battery Information */\n+ [BATTERY_COS_2] = ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | drawlat: Add CosMX B00C4473A9D0002 battery
BUG=b:173174333
BRANCH=none
TEST=Test on charging/discharging/battery cut off pass.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ide3560ccbbbc0c65d5c3c72d8ed184d21271b860
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537523
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,282 | 16.11.2020 11:08:59 | -28,800 | 51a619329f31b3efd4f6efb7cc8eb2d8848d11e1 | drawcia: Add Batteries CFET mask & val field
This commit add the charge FET (CFET) field for OCPC.
BRANCH=none
TEST=On Drawcia. Cutoff battery and verify that CFET disable status
is reflected after attached charger. | [
{
"change_type": "MODIFY",
"old_path": "board/drawcia/battery.c",
"new_path": "board/drawcia/battery.c",
"diff": "@@ -45,6 +45,8 @@ const struct board_batt_params board_battery_info[] = {\n.reg_addr = 0x0,\n.reg_mask = 0x0006,\n.disconnect_val = 0x0,\n+ .cfet_mask = 0x0004,\n+ .cfet_off_val = 0x0,\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | drawcia: Add Batteries CFET mask & val field
This commit add the charge FET (CFET) field for OCPC.
BUG=b:173174333
BRANCH=none
TEST=On Drawcia. Cutoff battery and verify that CFET disable status
is reflected after attached charger.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ifcd6fcedd8422e3b7af292c473a17328edf3d5c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2539228
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,256 | 16.11.2020 10:41:43 | 25,200 | dbe78a88d535ebffeeb23660d0606546fb8108d4 | zephyr/tests: add zmake file for crc test
The zmake file allows us to use the zmake program to easily build this
test
BRANCH=none
TEST=use `zmake configure -b -B /tmp/build zephyr/test/crc` | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "zephyr/test/crc/zmake.yaml",
"diff": "+# Copyright 2020 The Chromium OS Authors. All rights reserved.\n+# Use of this source code is governed by a BSD-style license that can be\n+# found in the LICENSE file.\n+\n+board: native_posix\n+supported-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr/tests: add zmake file for crc test
The zmake file allows us to use the zmake program to easily build this
test
BRANCH=none
BUG=none
TEST=use `zmake configure -b -B /tmp/build zephyr/test/crc`
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: If1928c8c6705b4e8905e2f84eee896158a7510e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2540732
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,418 | 16.11.2020 09:41:33 | 28,800 | 69b77671aa40b2bb7b1f2c4f7b11990ea35aefb6 | Lazor: Add a new SKU ID 6 for Limozeen
Add a new SKU ID 6 for Limozeen.
BRANCH=Trogdor
TEST=Built the image. | [
{
"change_type": "MODIFY",
"old_path": "board/lazor/board.c",
"new_path": "board/lazor/board.c",
"diff": "@@ -386,14 +386,14 @@ void lid_angle_peripheral_enable(int enable)\nstatic int board_is_clamshell(void)\n{\n- /* SKU ID of Limozeen: 4, 5 */\n- return sku_id == 4 || sku_id == 5;\n+ /* SKU ID of... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Lazor: Add a new SKU ID 6 for Limozeen
Add a new SKU ID 6 for Limozeen.
BRANCH=Trogdor
BUG=b:172019576, b:173320369
TEST=Built the image.
Change-Id: Ieecf67a8fcbd97d059f8c8b525e3acbd3651963d
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2541142
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Commit-Queue: Douglas Anderson <dianders@chromium.org> |
136,282 | 16.11.2020 15:02:09 | -28,800 | af33a4479d3e42248db4716e7c3a08198e4bd216 | Dorp: Add CosMX battery
BRANCH=firmware-octopus-11297.B
TEST=Test on charging/discharging/battery cut off pass. | [
{
"change_type": "MODIFY",
"old_path": "board/meep/battery.c",
"new_path": "board/meep/battery.c",
"diff": "@@ -234,6 +234,35 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 60,\n},\n},\n+\n+ /* CosMX B00C4473A9D0002 Battery Information */\n+ [BATTERY_COS] = {\n+ .fu... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Dorp: Add CosMX B00C4473A9D0002 battery
BUG=b:173334879
BRANCH=firmware-octopus-11297.B
TEST=Test on charging/discharging/battery cut off pass.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Ib204522d91d53cd82837e1c4a77ddcd1659ff640
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537828
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,324 | 13.11.2020 14:39:25 | 25,200 | 1d2202cd0e5b1d73170cdf4d3e07ddcc73b739d1 | genvif: field output ordering to be like spec
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.h",
"new_path": "util/genvif.h",
"diff": "@@ -150,9 +150,11 @@ enum vif_Component_indexes {\nPort_Label, /* nonEmptyString */\nConnector_Type, /* numericFieldType */\nUSB4_Supported, /* booleanFieldType */\n+ USB4_Router_Index, /* numericFieldType ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: field output ordering to be like spec
BUG=b:172293518
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: Ibf433a6d6472c2c3a4422f4a9d757196be7884ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538258
Tested-by: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,222 | 02.11.2020 17:54:48 | -28,800 | eaaa61604170980a43a583efcfd359520db3176f | chip/mt8192_scp: support RAM cache
Supports RAM cache for:
L2TCM
System DRAM
BRANCH=none
TEST=manually check assembly code | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/build.mk",
"new_path": "chip/mt8192_scp/build.mk",
"diff": "CORE:=riscv-rv32i\n# Required chip modules\n+chip-y+=cache.o\nchip-y+=clock.o\nchip-y+=gpio.o\nchip-y+=intc.o\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: support RAM cache
Supports RAM cache for:
- L2TCM
- System DRAM
BRANCH=none
BUG=b:156222459
BUG=b:156222508
BUG=b:172886808
TEST=manually check assembly code
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I3fd3d8f858a172bf26dfec6a5c6c403d73164039
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2513414
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,222 | 12.11.2020 18:29:44 | -28,800 | 0895e190d9116d4b22e9fadceedbca8f573fe58f | chip/mt8192_scp: remove confusing comments
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/system.c",
"new_path": "chip/mt8192_scp/system.c",
"diff": "@@ -18,8 +18,7 @@ void system_pre_init(void)\n/* enable CPU DCM */\nset_csr(CSR_MCTREN, CSR_MCTREN_CG);\n- /* Disable jump (it has only RW) and enable MPU. */\n- /* TODO: implement MPU... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: remove confusing comments
BRANCH=none
BUG=b:156222508
BUG=b:156222459
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: Icda539485e630c2e14a38e182f3b3c3a2959cec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534435
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,222 | 11.11.2020 13:14:07 | -28,800 | 15b590a0999752abe28584a0c502fe9435ec7e41 | chip/mt8192_scp: update memory map
Updates memory maps.
SCP view 0x1000_0000 maps to AP view 0x5000_0000.
SCP view 0xf000_0000 maps to AP view 0x6000_0000.
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/memmap.c",
"new_path": "chip/mt8192_scp/memmap.c",
"diff": "* SCP address AP address Note\n*\n* 0x0000_0000 SRAM\n- * 0x1000_0000 0x6000_0000 un-cached DRAM\n- * 0x2000_0000 0x7000_0000 un-cached DRAM\n+ * 0x1000_0000 0x5000_0000 CPU DRAM\n+ * ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: update memory map
Updates memory maps.
SCP view 0x1000_0000 maps to AP view 0x5000_0000.
SCP view 0xf000_0000 maps to AP view 0x6000_0000.
BRANCH=none
BUG=b:156222459
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: Ia837af7ee00bd6d4ec21be7533037667f680d29d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2531754
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,324 | 16.11.2020 09:13:56 | 25,200 | 72f06af17e55a5c88d51e8925d26a010297eb820 | genvif: Type_C_Power_Source
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -76,6 +76,11 @@ enum bc_1_2_support {\nBC_1_2_SUPPORT_BOTH = 3\n};\n+enum power_source {\n+ POWER_EXTERNAL = 0,\n+ POWER_UFP = 1,\n+ POWER_BOTH = 2,\n+};\n/*\n* TAG Name Strings\n@@ -2928,25 +2933,29 @@ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: Type_C_Power_Source
BUG=b:172437970
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: Icc7c679aab72b96b2a7e308944be00f1ab3d9029
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2540008
Tested-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,287 | 16.11.2020 11:41:38 | 25,200 | d0b880d61ecc8dfe334bae7dbb440156c56a287f | zephyr: Include i2c_map.h for I2C enabled boards
BRANCH=none
TEST=zmake build for volteer and zmake test for ec and i2c | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/include/board.h",
"new_path": "zephyr/shim/include/board.h",
"diff": "#include \"gpio_map.h\"\n#endif\n+/* Include board specific i2c mapping if I2C is enabled. */\n+#if defined(CONFIG_I2C) && !defined(CONFIG_ZTEST)\n+#include \"i2c_map.h\"\n+#endi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: Include i2c_map.h for I2C enabled boards
BRANCH=none
BUG=b:171302975
TEST=zmake build for volteer and zmake test for ec and i2c
Change-Id: Ic5be445ac7cc2216114379f7fad59de03251c1de
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2541622
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,311 | 16.11.2020 17:52:40 | 25,200 | ef1ebb6ee64a3e070057c50d87046a095971ccc5 | tcpc: Cleanup usage of tcpci_set_role_ctrl()
Cleanup arguments for tcpci_set_role_ctrl().
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/fusb307.c",
"new_path": "driver/tcpm/fusb307.c",
"diff": "@@ -28,7 +28,7 @@ static int fusb307_tcpm_init(int port)\nrv = tcpci_tcpm_init(port);\n- rv = tcpci_set_role_ctrl(port, 1, TYPEC_RP_USB, TYPEC_CC_RD);\n+ rv = tcpci_set_role_ctrl(port, TYPEC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tcpc: Cleanup usage of tcpci_set_role_ctrl()
Cleanup arguments for tcpci_set_role_ctrl().
BUG=b:171430855
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ib58defb5f9bcd3c3fe3d7de4239aa19e5545b778
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2544802
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,305 | 17.11.2020 16:59:52 | 25,200 | e15638c6df92680fa6694ef76c09ee2b71963dc9 | Drawcia: Remove CONFIG_SYSTEM_UNLOCKED
Drawcia has progressed enough in development that we no longer need to
force an unlocked state on the EC.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/drawcia/board.h",
"new_path": "board/drawcia/board.h",
"diff": "#undef GPIO_VOLUME_UP_L\n#define GPIO_VOLUME_UP_L GPIO_VOLUP_BTN_ODL_HDMI_HPD\n-/* System unlocked in early development */\n-#define CONFIG_SYSTEM_UNLOCKED\n-\n/* Battery */\n#define CONFIG_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Drawcia: Remove CONFIG_SYSTEM_UNLOCKED
Drawcia has progressed enough in development that we no longer need to
force an unlocked state on the EC.
BRANCH=None
BUG=b:171741987
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I3d3df9392c52652a17a0bb563990cceed73b7020
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2546027
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> |
136,282 | 16.11.2020 17:22:18 | -28,800 | 7f46efd099ef8c4b7695658ee5bd0136e3d25b74 | mordin: Add CosMX battery
BRANCH=firmware-grunt-11031.B
TEST=Test on charging/discharging/battery cut off pass. | [
{
"change_type": "MODIFY",
"old_path": "board/careena/battery.c",
"new_path": "board/careena/battery.c",
"diff": "@@ -241,6 +241,36 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 60,\n},\n},\n+\n+ /* CosMX B00C4473A9D0002 Battery Information */\n+ [BATTERY_COS] = {\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mordin: Add CosMX B00C4473A9D0002 battery
BUG=b:173343686
BRANCH=firmware-grunt-11031.B
TEST=Test on charging/discharging/battery cut off pass.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I69f50259c25e3fe6774afe2660a65db820cdaead
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2539712
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org> |
136,395 | 13.11.2020 16:11:25 | -28,800 | 8705e537da56c8cd1a55fbd775bf7985e8949e41 | woomax: Fine tune Type-C retimer PI3DPX1207 EQ
Modify strength value of PI3DPX1207C for USB-C0 signal quality.
BRANCH=firmware-zork-13434.B
TEST=make BOARD=woomax | [
{
"change_type": "MODIFY",
"old_path": "board/woomax/board.c",
"new_path": "board/woomax/board.c",
"diff": "@@ -301,6 +301,98 @@ static void setup_mux(void)\n}\n}\n+enum pi3dpx1207_usb_conf {\n+ USB_DP = 0,\n+ USB_DP_INV,\n+ USB,\n+ USB_INV,\n+ DP,\n+ DP_INV\n+};\n+\n+static uint8_t pi3dpx1207_picas... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | woomax: Fine tune Type-C retimer PI3DPX1207 EQ
Modify strength value of PI3DPX1207C for USB-C0 signal quality.
BUG=b:172040000
BRANCH=firmware-zork-13434.B
TEST=make BOARD=woomax
Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com>
Change-Id: I7b0dd80af0bf44fd9256e2d4d0c49d755014661e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2515426
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,217 | 22.10.2020 11:50:08 | -28,800 | 0516b73d8a01243767a0615deffd272a2843bcff | virtual_battery: support reading SpecificationInfo
TEST=check sbs-battery from host side
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "common/virtual_battery.c",
"new_path": "common/virtual_battery.c",
"diff": "@@ -318,6 +318,11 @@ int virtual_battery_operation(const uint8_t *batt_cmd_head,\ncase SB_MANUFACTURER_ACCESS:\n/* No manuf. access reg access allowed over VB interface */\nreturn EC_E... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | virtual_battery: support reading SpecificationInfo
BUG=b:170921599
TEST=check sbs-battery from host side
BRANCH=None
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Change-Id: I0308fda8d34a0920782dd1de8d43ffc90f059a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491588
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,217 | 22.10.2020 15:10:35 | -28,800 | db27b92f6221b02dfd95aa17f06b6b9339352a6e | virtual_battery: support reading DeviceChemistry
TEST=check sbs-battery from host side
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "common/virtual_battery.c",
"new_path": "common/virtual_battery.c",
"diff": "@@ -289,6 +289,9 @@ int virtual_battery_operation(const uint8_t *batt_cmd_head,\ncase SB_DEVICE_NAME:\ncopy_memmap_string(dest, EC_MEMMAP_BATT_MODEL, read_len);\nbreak;\n+ case SB_DEVI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | virtual_battery: support reading DeviceChemistry
BUG=b:170921599
TEST=check sbs-battery from host side
BRANCH=None
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Change-Id: I1cae097f8056569c00a284cfbff56483a7ba4387
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491589
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,305 | 16.11.2020 14:06:35 | 25,200 | 511500d64d7f781c7363b2262bc2783883d26d99 | TCPC: Change SOP' disable interface
Add the ability to enable or disable SOP' traffic through a new
parameter. Name the function for "enable" to match other EC
conventions.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "@@ -5684,7 +5684,7 @@ static void pe_vcs_evaluate_swap_entry(int port)\n* We continue to source VCONN while we wait as required by the\n* spec.\n*/\n- tcpm_sop_prime_disable(port... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPC: Change SOP' disable interface
Add the ability to enable or disable SOP' traffic through a new
parameter. Name the function for "enable" to match other EC
conventions.
BRANCH=None
BUG=b:168560801
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ife52e7d7d098825ab2163c70a4c59510da958876
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2542864
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,200 | 12.11.2020 17:55:37 | -28,800 | 3d684ba979049b1e0020d1eadcf095865559ccff | voema: remove unused gpio pin and add FRS_EN pin.
Remove usused pin and add FRS_EN pin.
BRANCH=master
TEST=make buildall succeed. | [
{
"change_type": "MODIFY",
"old_path": "board/voema/gpio.inc",
"new_path": "board/voema/gpio.inc",
"diff": "@@ -87,8 +87,8 @@ GPIO(USB_A_LOW_PWR_OD, PIN(6, 6), GPIO_ODR_LOW) /* Don't limit USB-A charging b\nGPIO(USB_C1_RT_RST_ODL, PIN(8, 3), GPIO_ODR_LOW)\nGPIO(USB_C0_OC_ODL, PIN(B, 1), GPIO_ODR_HIG... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | voema: remove unused gpio pin and add FRS_EN pin.
Remove usused pin and add FRS_EN pin.
BUG=b:169356808
BRANCH=master
TEST=make buildall succeed.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I3481cd0f729881c4356d3bcfd6af2ef7c8cef022
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537524
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org> |
136,200 | 13.11.2020 11:28:57 | -28,800 | f3c9a58c8c98db5617d632c57deab28d9fc39e76 | voema: Modify LED control to gpio
Change LED control from pwm to gpio.
BRANCH=master
TEST=Check LED status in each state. | [
{
"change_type": "MODIFY",
"old_path": "board/voema/board.c",
"new_path": "board/voema/board.c",
"diff": "@@ -76,9 +76,6 @@ union volteer_cbi_fw_config fw_config_defaults = {\nstatic void board_init(void)\n{\n- /* Illuminate motherboard and daughter board LEDs equally to start. */\n- pwm_enable(PWM_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | voema: Modify LED control to gpio
Change LED control from pwm to gpio.
BUG=none
BRANCH=master
TEST=Check LED status in each state.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: Ic638b23dc0cd0eff0b8d252836f83b76503b192b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537525
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org> |
136,200 | 13.11.2020 14:31:09 | -28,800 | e870022baabead9cd900b24fae8c4cd3685e1bd7 | voema: Remove fan function
Remove fan function.
BRANCH=master
TEST=make buildall succeed. | [
{
"change_type": "MODIFY",
"old_path": "board/voema/board.c",
"new_path": "board/voema/board.c",
"diff": "#include \"driver/tcpm/tcpci.h\"\n#include \"driver/tcpm/tusb422.h\"\n#include \"extpower.h\"\n-#include \"fan.h\"\n-#include \"fan_chip.h\"\n#include \"gpio.h\"\n#include \"hooks.h\"\n#include ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | voema: Remove fan function
Remove fan function.
BUG=b:169356808
BRANCH=master
TEST=make buildall succeed.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: Id3c0f4f638d09bd10afd1de523c0e458a7413936
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537526
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org> |
136,278 | 24.06.2020 17:59:23 | 25,200 | 9cbdba341f293c704ec6ca7bc5c06a7aea7e8692 | isl9241: add missing newline to cprintf calls
this adds missing newlines to the end of format strings in cprintf
calls.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/isl9241.c",
"new_path": "driver/charger/isl9241.c",
"diff": "@@ -327,7 +327,7 @@ int isl9241_set_ac_prochot(int chgnum, int ma)\nrv = isl9241_write(chgnum, ISL9241_REG_AC_PROCHOT, reg);\nif (rv)\n- CPRINTF(\"set_ac_prochot failed (%d)\", rv);\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | isl9241: add missing newline to cprintf calls
this adds missing newlines to the end of format strings in cprintf
calls.
BRANCH=none
BUG=none
TEST=buildall
Change-Id: Ia7603182b79bfec88913355296e1d31599769e49
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2545736
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.