author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,324 | 17.11.2020 15:38:41 | 25,200 | 07f5ec6691d2442498b303ab2c1e2edc588bd29a | genvif: component for all ports with Port_Label
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "test/genvif/src/helper.c",
"new_path": "test/genvif/src/helper.c",
"diff": "@@ -27,3 +27,7 @@ const uint32_t pd_snk_pdo[] = {\nconst int pd_snk_pdo_cnt = ARRAY_SIZE(pd_snk_pdo);\n#endif /* CONFIG_USB_PD_CUSTOM_PDO */\n+uint8_t board_get_usb_pd_port_count(void)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: component for all ports with Port_Label
BUG=b:172450627
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: Idcc65ad2ec7fda48d39a6319e6adf226765e37bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2545141
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org> |
136,306 | 18.11.2020 16:21:57 | 28,800 | 6e0750fda26606378b1c6e3c4ca0457fa93b5a5b | fw_update: fix python3 incompatibility
In py3 bytearrays are real, so we need to use 'encode' to make sure the
right command is being sent
BRANCH=None
TEST=None | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_updater/fw_update.py",
"new_path": "extra/usb_updater/fw_update.py",
"diff": "@@ -257,7 +257,7 @@ class Supdate(object):\noffset += pagesize\n# Validate that the micro thinks it successfully wrote the data.\n- read = self.wr_command(b\"\", read_count... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fw_update: fix python3 incompatibility
In py3 bytearrays are real, so we need to use 'encode' to make sure the
right command is being sent
BRANCH=None
BUG=None
TEST=None
Change-Id: I28e6390d99563731f07e42a161065469aa009b11
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2548685
Reviewed-by: Dossym Nurmukhanov <dossym@chromium.org> |
136,254 | 13.11.2020 20:00:50 | 18,000 | 8c51f8e778f11535c49d2636fd0a768b99a0374c | ambassador: fix LED color.
Ambassador has red/white LEDs instead of red/green. They are open drain.
With this change, amber is actually pink, but there's no constant for
pink.
TEST=On device, control with ec console.
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/ambassador/board.c",
"new_path": "board/ambassador/board.c",
"diff": "@@ -256,11 +256,11 @@ const struct pwm_t pwm_channels[] = {\n.flags = PWM_CONFIG_OPEN_DRAIN,\n.freq = 25000},\n[PWM_CH_LED_RED] = { .channel = 0,\n- .flags = PWM_CONFIG_ACTIVE_LOW |\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ambassador: fix LED color.
Ambassador has red/white LEDs instead of red/green. They are open drain.
With this change, amber is actually pink, but there's no constant for
pink.
BUG=None
TEST=On device, control with ec console.
BRANCH=none
Signed-off-by: Matt Ziegelbaum <ziegs@chromium.org>
Change-Id: Ib9901f3b4c3d088b0990da03411f5b785cc2e096
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2542752
Reviewed-by: Joe Tessler <jrt@chromium.org> |
136,410 | 12.11.2020 21:41:13 | -28,800 | d948513ac0caecfb1a68cec320ed9d71ee4126e3 | Coachz: Modify Battery LED behavior
Modify Battery LED behavior based on spec
BRANCH=master
TEST=make BOARD=coachz -j
flash ec and check Battery LED behavior | [
{
"change_type": "MODIFY",
"old_path": "board/coachz/led.c",
"new_path": "board/coachz/led.c",
"diff": "#include \"led_common.h\"\n#include \"system.h\"\n#include \"util.h\"\n+#include \"extpower.h\"\n#define LED_ONE_SEC (1000 / HOOK_TICK_INTERVAL_MS)\n+/* Battery LED blinks every per 400ms */\n+#de... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Coachz: Modify Battery LED behavior
Modify Battery LED behavior based on spec
BRANCH=master
BUG=b:173095514
TEST=make BOARD=coachz -j
flash ec and check Battery LED behavior
Signed-off-by: gaochao <gaochao@huaqin.corp-partner.google.com>
Change-Id: Iaf149bc37d65048ce68c96ed6758e018c0bb16c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534439
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,222 | 11.11.2020 13:11:20 | -28,800 | 87613f3e9bf22d8d420ea5667b750ea4fb6d5c6b | core/riscv-rv32i: support DRAM cache
Allocates memory space for dram.* sections.
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "core/riscv-rv32i/ec.lds.S",
"new_path": "core/riscv-rv32i/ec.lds.S",
"diff": "@@ -47,6 +47,10 @@ MEMORY\n#else\nIRAM (rw) : ORIGIN = CONFIG_RAM_BASE, LENGTH = CONFIG_RAM_SIZE\n#endif /* CHIP_FAMILY_IT8XXX2 */\n+\n+#ifdef CONFIG_DRAM_BASE\n+ DRAM (rwx) : ORIGIN... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/riscv-rv32i: support DRAM cache
Allocates memory space for dram.* sections.
BRANCH=none
BUG=b:156222459
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I0825c9daf06d88929ef3410a14c176099bfa1ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2531753
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,405 | 13.11.2020 16:24:28 | 28,800 | 10534b57d4a0cd6a794bbe0fbb9cbaa68010fa63 | common: Add EC_SUCCESS_IN_PROGRESS to enum ec_error_list
EC_SUCCESS_IN_PROGRESS can be returned to indicate the operation was
successful but the completion is pending.
BRANCH=Trogdor
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "include/common.h",
"new_path": "include/common.h",
"diff": "@@ -273,6 +273,9 @@ enum ec_error_list {\n/* Sometimes operation is expected to have to be repeated. */\nEC_ERROR_TRY_AGAIN = 26,\n+ /* Operation was successful but completion is pending. */\n+ EC_SUC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: Add EC_SUCCESS_IN_PROGRESS to enum ec_error_list
EC_SUCCESS_IN_PROGRESS can be returned to indicate the operation was
successful but the completion is pending.
BUG=b:173235954
BRANCH=Trogdor
TEST=buildall
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: I6f7816f190938aaefa4e02ed8f36edac7dcf2faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538538
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,305 | 19.11.2020 10:16:09 | 25,200 | 7bd8d8b8e067bceda856902f0dc00c88d837847a | Magolor: Free more flash space
Remove accelspoof and battfake commands to free more flash space on ToT.
BRANCH=None
TEST=build, verify magolor has at least 1k free on ToT | [
{
"change_type": "MODIFY",
"old_path": "board/magolor/board.h",
"new_path": "board/magolor/board.h",
"diff": "*/\n#define CONFIG_SYSTEM_UNLOCKED\n+/* Remove default commands to free flash space */\n+#undef CONFIG_CMD_ACCELSPOOF\n+#undef CONFIG_CMD_BATTFAKE\n+\n/* Battery */\n#define CONFIG_BATTERY_F... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Magolor: Free more flash space
Remove accelspoof and battfake commands to free more flash space on ToT.
BRANCH=None
BUG=b:168608382
TEST=build, verify magolor has at least 1k free on ToT
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I191713a328d1c1a79fc15de83a2490fc035ef78a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2549414
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: Justin TerAvest <teravest@chromium.org> |
136,208 | 20.11.2020 16:19:36 | -28,800 | d0530ca42969435e91627977267c517e26349c97 | asurada: resume from S3 when AC connect/disconnect
This is a new device requirementa.
TEST=ensure AP resume when AC connect and disconnect
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.h",
"new_path": "board/asurada/board.h",
"diff": "/* Define the host events which are allowed to wakeup AP in S3. */\n#define CONFIG_MKBP_HOST_EVENT_WAKEUP_MASK \\\n- (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) | \\\n- EC_HOST_EVENT_MASK(EC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: resume from S3 when AC connect/disconnect
This is a new device requirementa.
BUG=b:172361448
TEST=ensure AP resume when AC connect and disconnect
BRANCH=none
Change-Id: I2da0565fbef43a553346ee497b7791bcbd6a10b4
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2550120
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org> |
136,269 | 17.11.2020 16:22:35 | 28,800 | 813f24ec3414a48253869ba4a88f41b69ba1bcf8 | docs/fingerprint: Add links to Nucleo boards
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/fingerprint/fingerprint.md",
"new_path": "docs/fingerprint/fingerprint.md",
"diff": "@@ -28,10 +28,10 @@ The main source code for fingerprint sensor functionality lives in the\nThe following \"boards\" (specified by the `BOARD` environment variable when\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/fingerprint: Add links to Nucleo boards
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I6d9ca47ee14580092812446992eb785a47874dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2546030
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Yicheng Li <yichengli@chromium.org> |
136,269 | 20.11.2020 08:22:57 | 28,800 | 9fc6748925720bd6db7cb000f58426dd78a9fc04 | docs: Add links in write protection doc
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/write_protection.md",
"new_path": "docs/write_protection.md",
"diff": "@@ -41,7 +41,7 @@ firmware jumps to it.\nOn modern Chrome OS devices, the Cr50 (aka GSC / TPM) provides a \"hardware\nwrite protect\" GPIO that is connected to the AP SPI flash, EC SPI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Add links in write protection doc
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I1542ceef2f14c06faff2d02fe584c88384e36e21
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552601
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,331 | 11.11.2020 13:04:42 | 25,200 | f572254ba8c71aa6a6541c676d01fbeecdb9a6c0 | zephyr: implement gpio_reset and gpio_set_flags
These are required by power sequencing.
Also, handle conversion of more bits while I'm here.
BRANCH=none
TEST=compile with power sequencing code for volteer | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/src/gpio.c",
"new_path": "zephyr/shim/src/gpio.c",
"diff": "@@ -167,21 +167,41 @@ void gpio_set_level(enum gpio_signal signal, int value)\n}\n}\n+/* GPIO flags which are the same in Zephyr and this codebase */\n+#define GPIO_CONVERSION_SAME_BITS \\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: implement gpio_reset and gpio_set_flags
These are required by power sequencing.
Also, handle conversion of more bits while I'm here.
BUG=b:171312361,b:173789980
BRANCH=none
TEST=compile with power sequencing code for volteer
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I3064e6851c64a7f43612524000289ac7d7f04766
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2548305
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,331 | 11.11.2020 14:13:48 | 25,200 | 0be00eec2444f1c40ff0e39c0a35c55d46798885 | zephyr: stub system_hibernate
Needed by power sequencing. Doing nothing will work fine for now.
BRANCH=none
TEST=compile with power sequencing | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/src/system.c",
"new_path": "zephyr/shim/src/system.c",
"diff": "@@ -215,6 +215,14 @@ int system_jumped_to_this_image(void)\nreturn jumped_to_image;\n}\n+void system_hibernate(uint32_t seconds, uint32_t microseconds)\n+{\n+ /*\n+ * TODO(b:173787365)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: stub system_hibernate
Needed by power sequencing. Doing nothing will work fine for now.
BUG=b:173787365
BRANCH=none
TEST=compile with power sequencing
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: Ia4e48d92ebbee7a788e4515f6583095349aea0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2548306
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,331 | 11.11.2020 12:30:51 | 25,200 | 4e1da5433feb066465bf49df13c1ec0995941e3f | zephyr: shim some basic eSPI functionality
Add some basic functionality to get and set virtual wires.
BRANCH=none
TEST=volteer power sequencing to S0 (requires follow-up CLs) | [
{
"change_type": "MODIFY",
"old_path": "zephyr/CMakeLists.txt",
"new_path": "zephyr/CMakeLists.txt",
"diff": "@@ -35,6 +35,7 @@ zephyr_include_directories_ifdef(\nadd_subdirectory_ifdef(CONFIG_PLATFORM_EC \"shim\")\nzephyr_sources_ifdef(CONFIG_PLATFORM_EC \"${PLATFORM_EC}/common/base32.c\")\n+zephyr... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: shim some basic eSPI functionality
Add some basic functionality to get and set virtual wires.
BUG=b:171815541
BRANCH=none
TEST=volteer power sequencing to S0 (requires follow-up CLs)
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I07655fd3a768aca962112a98d6f1f593633eb605
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2548307
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,331 | 11.11.2020 14:15:14 | 25,200 | 24afe7306b8c35439831144bb67ddb3937e2c7f5 | zephyr: shim in power sequencing
Enable shimming of power sequencing code.
BRANCH=none
TEST=With zephyr-chrome CL... | [
{
"change_type": "MODIFY",
"old_path": "power/common.c",
"new_path": "power/common.c",
"diff": "@@ -1005,7 +1005,7 @@ __overridable void board_power_5v_enable(int enable)\n/* 5V enable request bitmask from various tasks. */\nstatic uint32_t pwr_5v_en_req;\n-static struct mutex pwr_5v_ctl_mtx;\n+stat... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: shim in power sequencing
Enable shimming of power sequencing code.
BUG=b:171312361
BRANCH=none
TEST=With zephyr-chrome CL...
https://screenshot.googleplex.com/4m6N6vd2Nx5FpiD.png
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I8fb96019c8c636010d2cd136c0116df41fc9f148
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2548308 |
136,411 | 22.11.2020 01:51:16 | 28,800 | 0dc8b304f1a4857e4897fe40ae0fe7821a9f8c51 | Fix use of int const in size of array.
Compiler complains about this use of a GNU extension now.
Replace by a #define.
BRANCH=None
TEST=to be done | [
{
"change_type": "MODIFY",
"old_path": "fuzz/usb_pd_fuzz.c",
"new_path": "fuzz/usb_pd_fuzz.c",
"diff": "@@ -158,7 +158,7 @@ static pthread_cond_t done_cond;\nstatic pthread_mutex_t lock;\nenum tcpc_cc_voltage_status next_cc1, next_cc2;\n-const int MAX_MESSAGES = 8;\n+#define MAX_MESSAGES 8\nstatic s... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fix use of int const in size of array.
Compiler complains about this use of a GNU extension now.
Replace by a #define.
BUG=chromium:1151317
BRANCH=None
TEST=to be done
Change-Id: Ib7fdd038f761bb4b27e9eeca5de9e3d0ec5f0f79
Signed-off-by: Luis Lozano <llozano@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2553749
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org> |
136,257 | 19.11.2020 09:03:55 | -28,800 | c56cabb55a3c907bae1c400c352b85dc41d15db5 | eldrid: turn off BAT LED when plug out AC
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
TEST=Plug out ac on left port, right port won't turn on | [
{
"change_type": "MODIFY",
"old_path": "board/eldrid/led.c",
"new_path": "board/eldrid/led.c",
"diff": "/* LED_SIDESEL_4_L=1, MB BAT LED open\n* LED_SIDESEL_4_L=0, DB BAT LED open\n*/\n-#define LED_SISESEL_MB_PORT 0\n-#define LED_SISESEL_DB_PORT 1\n+#define LED_SIDESEL_MB_PORT 0\n+#define LED_SIDESE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eldrid: turn off BAT LED when plug out AC
BUG=b:173476755
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
TEST=Plug out ac on left port, right port won't turn on
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: I8b562d02354758e90cb99d99084d4b1c95f1ce18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2547605
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,269 | 20.11.2020 08:28:49 | 28,800 | 8ef91774b4b67e8e91ff15d74faadcd7bb1a06ee | docs: Run mdformat on write protection doc
Command used:
(outside) $ mdformat -in_place --compatibility docs/write_protection.md
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/write_protection.md",
"new_path": "docs/write_protection.md",
"diff": "[TOC]\nThis is a somewhat tricky topic since write protection implementations can\n-differ between chips and the hardware write protection has changed over time,\n-so please edit or op... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Run mdformat on write protection doc
Command used:
(outside) $ mdformat -in_place --compatibility docs/write_protection.md
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I3889b3279165b5897f5489549d4530681b6ac5b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552602
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,324 | 23.11.2020 09:11:38 | 25,200 | 7ba8cc6218a318b13bae281ea7309b7de135746d | genvif: refactor return vif field or default value
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -405,7 +405,7 @@ static bool streq(const char *str1, const char *str2)\n/*****************************************************************************\n* VIF Structure Override Value Retrieve Functions\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: refactor return vif field or default value
BUG=b:174032040
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I8bce3f6625ddb642319bff0c473b34b342df8433
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2555097
Tested-by: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,438 | 20.11.2020 14:12:59 | 28,800 | 50e0e9991ef1904fc6759a7f757510645a0f04c3 | docs/fingerprint: Add instructions to run firmware tests
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "docs/sitemap.md",
"new_path": "docs/sitemap.md",
"diff": "* [Fingerprint MCU (FPMCU)](./fingerprint/fingerprint.md)\n* [FPMCU Development for Partners](./fingerprint/fingerprint-dev-for-partners.md)\n+* [FPMCU Firmware Testing for Partners](./fingerprint/finge... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/fingerprint: Add instructions to run firmware tests
BRANCH=none
BUG=b:171422264
TEST=none
Change-Id: I677b1f17a997a21e906674bb4dc9e02a8e207a1f
Signed-off-by: Yicheng Li <yichengli@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552353
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Tom Hughes <tomhughes@chromium.org> |
136,373 | 14.11.2020 15:44:34 | -28,800 | da74390fe87eb030018d9a8a72bbbe819afeb0fe | lindar: add keyboard backlight function
add keyboard backlight function
BRANCH=firmware-volteer-13521.B
TEST=make -j --board=lindar
Tested-by: jerry2.huang | [
{
"change_type": "MODIFY",
"old_path": "board/lindar/board.c",
"new_path": "board/lindar/board.c",
"diff": "@@ -385,6 +385,20 @@ const struct pwm_t pwm_channels[] = {\n};\nBUILD_ASSERT(ARRAY_SIZE(pwm_channels) == PWM_CH_COUNT);\n+static void kb_backlight_enable(void)\n+{\n+ if (ec_cfg_has_keyboard_b... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | lindar: add keyboard backlight function
add keyboard backlight function
BUG=b:173179867
BRANCH=firmware-volteer-13521.B
TEST=make -j --board=lindar
Signed-off-by: amber.chen <amber.chen@lcfc.corp-partner.google.com>
Change-Id: I5573ef24f39a98bad3c442331255419409ec4335
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2537740
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Tested-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com> |
136,369 | 26.10.2020 09:13:59 | 25,200 | ea6413290f1b4488fa2f2c7dfa303e19ce6f8bfd | amd_r19me4070: Set GPU temp to 0 when read failed
This avoids returning bogus temperature that caused
thermal shutdown.
BRANCH=none
TEST=no more thermal shutdown when suspend | [
{
"change_type": "MODIFY",
"old_path": "driver/temp_sensor/amd_r19me4070.c",
"new_path": "driver/temp_sensor/amd_r19me4070.c",
"diff": "@@ -53,17 +53,21 @@ int get_temp_R19ME4070(int idx, int *temp_ptr)\n* We shouldn't read the GPU temperature when the state\n* is not in S0, because GPU is enabled i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | amd_r19me4070: Set GPU temp to 0 when read failed
This avoids returning bogus temperature that caused
thermal shutdown.
BRANCH=none
BUG=b:171325612
TEST=no more thermal shutdown when suspend
Change-Id: Ie72d7798431636f23ae528ec9fbf8c9125ea32cc
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2544571
Reviewed-by: Shelley Chen <shchen@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org> |
136,405 | 04.11.2020 10:23:14 | 28,800 | 786ee9e804bc0db42318cbf008b6916a8e2a3e98 | PCHG: Add ctn730 driver
CTN730 is a NFC/WLC transmitter (a.k.a. poller), which communicates
with a receiver (a.k.a. listener) to transfer power wirelessly.
BRANCH=Trogdor
TEST=See the description of CL:2538536. | [
{
"change_type": "MODIFY",
"old_path": "driver/build.mk",
"new_path": "driver/build.mk",
"diff": "@@ -83,6 +83,7 @@ driver-$(CONFIG_IO_EXPANDER_PCA9534)+=ioexpander/pca9534.o\ndriver-$(CONFIG_IO_EXPANDER_PCA9675)+=ioexpander/pca9675.o\ndriver-$(CONFIG_IO_EXPANDER_PCAL6408)+=ioexpander/pcal6408.o\n+d... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | PCHG: Add ctn730 driver
CTN730 is a NFC/WLC transmitter (a.k.a. poller), which communicates
with a receiver (a.k.a. listener) to transfer power wirelessly.
BUG=b:173235954
BRANCH=Trogdor
TEST=See the description of CL:2538536.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Icf5df30d2dffe617887ff6a591ea5b4a753cb3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538539
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,405 | 04.11.2020 10:23:14 | 28,800 | 9bfe97924bfd1cefac5a83291b2a5e53d7cba935 | coachz: Enable stylus charging
This patch enables stylus charging.
BRANCH=Trogdor
TEST=See the description of CL:2538536. | [
{
"change_type": "MODIFY",
"old_path": "board/coachz/board.c",
"new_path": "board/coachz/board.c",
"diff": "#include \"button.h\"\n#include \"charge_manager.h\"\n#include \"charge_state.h\"\n+#include \"common.h\"\n#include \"extpower.h\"\n#include \"driver/accel_bma2x2.h\"\n#include \"driver/accelg... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | coachz: Enable stylus charging
This patch enables stylus charging.
BUG=b:173235954
BRANCH=Trogdor
TEST=See the description of CL:2538536.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Ia28214cc963168df7b229a6fbf530fc357e85740
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2538540
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,269 | 24.11.2020 16:41:00 | 28,800 | 559ad51bad0a4204e8735c6a9e0ec7256a8ea0b2 | ec_commands: Add GENMASK macros
GENMASK is used in ec_commands.h, but is not defined if not compiling in
kernel or Chrome OS EC environments.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -56,6 +56,14 @@ extern \"C\" {\n#define BIT_ULL(nr) (1ULL << (nr))\n#endif\n+#ifndef GENMASK\n+#define GENMASK(h, l) (((BIT(h) << 1) - 1) ^ (BIT(l) - 1))\n+#endif\n+\n+#ifndef GENMASK_ULL... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_commands: Add GENMASK macros
GENMASK is used in ec_commands.h, but is not defined if not compiling in
kernel or Chrome OS EC environments.
BRANCH=none
BUG=b:144959033
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I439b0d77c47f3921f7bf2afd04c62cc72d668ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558857
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,229 | 24.11.2020 11:10:27 | -28,800 | 4f4ef79f123f86c5cdc3afc765c970a8f4dd45c7 | gumboz: Reword comments
1.reword battery comments
2.reword all Dirinboz name to gumboz
BRANCH=zork
TEST=make BOARD=gumboz | [
{
"change_type": "MODIFY",
"old_path": "board/gumboz/battery.c",
"new_path": "board/gumboz/battery.c",
"diff": "#include \"util.h\"\n/*\n- * Battery info for all Dirinboz battery types. Note that the fields\n+ * Battery info for all Gumboz battery types. Note that the fields\n* start_charging_min/ma... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gumboz: Reword comments
1.reword battery comments
2.reword all Dirinboz name to gumboz
BUG=none
BRANCH=zork
TEST=make BOARD=gumboz
Signed-off-by: jason.guo@quanta.corp-partner.google.com
Change-Id: Ia7a4b8a65a6a06065da20d0bdfc38b8ad24ccadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2556728
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,324 | 25.11.2020 12:55:30 | 25,200 | b8db14be52239dae79af204fc6679e5895bc5f2f | genvif: DR_Swap_To_UFP_Supported cleanup
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "util/genvif.c",
"new_path": "util/genvif.c",
"diff": "@@ -678,6 +678,13 @@ static bool is_usb_comms_capable(void)\nIS_ENABLED(CONFIG_USB_CTVPD))));\n}\n+static bool is_alt_mode_controller(void)\n+{\n+ return get_vif_bool(&vif.Component[component_index]\n+ .vif... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: DR_Swap_To_UFP_Supported cleanup
BUG=b:172422651
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I5216784a634d89ac1cbb47e4577762d907d8903a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2560612
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org> |
136,317 | 20.11.2020 15:47:56 | 25,200 | 4ae3b09ef84dbea4d5936da07c7633ed7df1a0c2 | guybrush: initial EC board setup
Create guybrush skeleton build. Minimal configuration required
to build.
BRANCH=none
TEST=make -j BOARD=guybrush | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "baseboard/guybrush/baseboard.c",
"diff": "+/* Copyright 2020 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/* Guybrush family-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | guybrush: initial EC board setup
Create guybrush skeleton build. Minimal configuration required
to build.
BUG=b:173820614
BRANCH=none
TEST=make -j BOARD=guybrush
Change-Id: I1e906da42abc565941e6e7e9ca2c79462556ce09
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552855
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,200 | 20.11.2020 14:32:12 | -28,800 | 0c2af622c929ace9b0d0814d475007ab60c791eb | voema: Typec port remove unused config and reconfig tcpc/ppc config.
Remove unused configuration and gpio pin and reconfig tcpc/ppc config for voema typec port.
BRANCH=master
TEST=Check C0/C1 port workable. | [
{
"change_type": "MODIFY",
"old_path": "board/voema/board.c",
"new_path": "board/voema/board.c",
"diff": "*/\n/* Volteer board-specific configuration */\n-#include \"bb_retimer.h\"\n#include \"button.h\"\n#include \"common.h\"\n#include \"accelgyro.h\"\n#include \"driver/accelgyro_bmi260.h\"\n#inclu... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | voema: Typec port remove unused config and reconfig tcpc/ppc config.
Remove unused configuration and gpio pin and reconfig tcpc/ppc config for voema typec port.
BUG=b:169356808
BRANCH=master
TEST=Check C0/C1 port workable.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I0ff2322b1cf19e24f66745c1509b811eeff69161
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2550118
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,305 | 18.11.2020 16:43:08 | 25,200 | a0850cc42ee1b56186440fb03f563fa5f7000710 | COIL: Rename CONFIG_USB_PD_I2C_ADDR_FLAGS
Rename CONFIG_USB_PD_I2C_ADDR_FLAGS and change related comments.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/samus_pd/board.h",
"new_path": "board/samus_pd/board.h",
"diff": "/* peripheral address for host commands */\n#ifdef HAS_TASK_HOSTCMD\n-#define CONFIG_HOSTCMD_I2C_ADDR_FLAGS CONFIG_USB_PD_I2C_SLAVE_ADDR_FLAGS\n+#define CONFIG_HOSTCMD_I2C_ADDR_FLAGS CONFI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename CONFIG_USB_PD_I2C_ADDR_FLAGS
Rename CONFIG_USB_PD_I2C_ADDR_FLAGS and change related comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ia17a1ca26a5c2a16a698e55eac7e8f75b5e87aa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558902
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,305 | 18.11.2020 16:44:58 | 25,200 | 529312de85aa8ec53dc3a4fcf1f6249b8195a1cb | COIL: Rename host_command_controller.c
Rename host_command_controller.c and update build.mk
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/build.mk",
"new_path": "common/build.mk",
"diff": "@@ -80,7 +80,7 @@ common-$(CONFIG_FMAP)+=fmap.o\ncommon-$(CONFIG_GESTURE_SW_DETECTION)+=gesture.o\ncommon-$(CONFIG_HOSTCMD_EVENTS)+=host_event_commands.o\ncommon-$(CONFIG_HOSTCMD_GET_UPTIME_INFO)+=uptim... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename host_command_controller.c
Rename host_command_controller.c and update build.mk
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ib5285b2686ceabca9830bbae40941754d3e13a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558903
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,305 | 24.11.2020 13:59:13 | 25,200 | 171046ab529d027a10475c12a0b6dc1b0d053c33 | COIL: Rename common i2c_peripheral file
Rename i2c_peripheral.c and update related build file.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/build.mk",
"new_path": "common/build.mk",
"diff": "@@ -86,7 +86,7 @@ common-$(CONFIG_HOSTCMD_RTC)+=rtc.o\ncommon-$(CONFIG_I2C_DEBUG)+=i2c_trace.o\ncommon-$(CONFIG_I2C_HID_TOUCHPAD)+=i2c_hid_touchpad.o\ncommon-$(CONFIG_I2C_CONTROLLER)+=i2c_master.o\n-com... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename common i2c_peripheral file
Rename i2c_peripheral.c and update related build file.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ibd72d3b20b0cc1c07d426fbcf4d76cfb2644bc54
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558904
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,371 | 04.11.2020 22:30:39 | 28,800 | 3c068a74639d883dbd7092b43a2efd7edf02b723 | ln9310: Startup sequence update.
Update Startup sequence to fully address SC_OUT over voltage issue.
BRANCH=master
TEST=Build successfully.
Tested-by: Wai-Hong Tam | [
{
"change_type": "MODIFY",
"old_path": "driver/ln9310.c",
"new_path": "driver/ln9310.c",
"diff": "@@ -115,6 +115,53 @@ static int is_battery_gt_10v(void)\nreturn gt_10v;\n}\n+static int ln9310_update_startup_seq(void)\n+{\n+ CPRINTS(\"LN9310 update startup sequence\");\n+\n+ /* Startup sequence inst... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ln9310: Startup sequence update.
Update Startup sequence to fully address SC_OUT over voltage issue.
BRANCH=master
BUG=170591575
TEST=Build successfully.
Change-Id: I31cbd839a7943ee19c19601bf178db6911f3dffd
Signed-off-by: Sean Hou <seanhou@lionsemi.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2520279
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Commit-Queue: Wai-Hong Tam <waihong@google.com>
Tested-by: Wai-Hong Tam <waihong@google.com> |
136,282 | 23.11.2020 10:57:45 | -28,800 | c8a7b8afc1b33fc1f8c3cfd7f2e1d862ff2b3a3f | Elemi: Change EC chip to npcx7m7fc
Chagne EC chip to npcx7m7fc to board version 1.
BRANCH=firmware-volteer-13521.B-master
TEST=Verified boot with npcx7m7fc re-worked board. | [
{
"change_type": "MODIFY",
"old_path": "board/elemi/board.h",
"new_path": "board/elemi/board.h",
"diff": "/* Baseboard features */\n#include \"baseboard.h\"\n+/*\n+ * The RAM and flash size combination on the NPCX797FC dose not leave\n+ * any unused flash space that can be used to store the .init_ro... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Elemi: Change EC chip to npcx7m7fc
Chagne EC chip to npcx7m7fc to board version 1.
BUG=b:169118044, b:174275667
BRANCH=firmware-volteer-13521.B-master
TEST=Verified boot with npcx7m7fc re-worked board.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I334f56b2f47c21ff38aeccc346b6be43fb71b7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2554172
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,282 | 25.11.2020 12:15:11 | -28,800 | 26631f3e43d535a74f21bad5b8f1fef328692b58 | drawcia: Enlarge KEYSCAN task
This commit enlarge keyboard scan task stack to prevent stack
overflow.
BRANCH=firmware-dedede-13606.B-master
TEST=On drawcia. Make sure KEYSCAN is not overflow with volup+H+alt
keys. | [
{
"change_type": "MODIFY",
"old_path": "board/drawcia/ec.tasklist",
"new_path": "board/drawcia/ec.tasklist",
"diff": "TASK_ALWAYS(HOSTCMD, host_command_task, NULL, VENTI_TASK_STACK_SIZE) \\\nTASK_ALWAYS(CONSOLE, console_task, NULL, VENTI_TASK_STACK_SIZE) \\\nTASK_ALWAYS(POWERBTN, power_button_task, ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | drawcia: Enlarge KEYSCAN task
This commit enlarge keyboard scan task stack to prevent stack
overflow.
BUG=b:174190303
BRANCH=firmware-dedede-13606.B-master
TEST=On drawcia. Make sure KEYSCAN is not overflow with volup+H+alt
keys.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I99e180eca8e6665c5ab9f52d8bc7dcd5ec55e678
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2557772
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,282 | 23.11.2020 10:34:54 | -28,800 | 955eef5ec6701fce65733107a08234e5d3b60dd6 | Elemi: Remove sensors
This commit remove sensors and tablet mode, since Elemi doesn't
support that.
BRANCH=firmware-volteer-13521.B-master
TEST=Verified boot without sensors initial. | [
{
"change_type": "MODIFY",
"old_path": "board/elemi/board.c",
"new_path": "board/elemi/board.c",
"diff": "#include \"common.h\"\n#include \"accelgyro.h\"\n#include \"cbi_ec_fw_config.h\"\n-#include \"driver/accel_bma2x2.h\"\n-#include \"driver/accelgyro_bmi260.h\"\n-#include \"driver/als_tcs3400.h\"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Elemi: Remove sensors
This commit remove sensors and tablet mode, since Elemi doesn't
support that.
BUG=b:163012636
BRANCH=firmware-volteer-13521.B-master
TEST=Verified boot without sensors initial.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: Icf23456763699024d934d78ac2cc20fcfcc5b9bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2554171
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,257 | 20.11.2020 15:00:11 | -28,800 | dcdd0522d12ec52790f73963d6845b5da2b49308 | eldrid: add npcx7m7fc support and backward support npcx7m6fc.
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/eldrid/board.h",
"new_path": "board/eldrid/board.h",
"diff": "/* Optional features */\n#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */\n+#ifndef BOARD_ELDRID_NPCX796FC\n+/*\n+ * The RAM and flash size combination on the the NP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eldrid: add npcx7m7fc support and backward support npcx7m6fc.
BUG=b:173754312
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: I7ce77a6813a977612b5c804cb335add419ac80b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2550117
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,331 | 30.11.2020 17:35:06 | 25,200 | b20627a214e2f7786b5545a19eaa088b5596c444 | zephyr: shim the port80 module
Shim in the port80 module.
BRANCH=none
TEST=boot volteer, watch the port80 writes
test port80 command | [
{
"change_type": "MODIFY",
"old_path": "zephyr/CMakeLists.txt",
"new_path": "zephyr/CMakeLists.txt",
"diff": "@@ -50,6 +50,7 @@ zephyr_sources_ifdef(CONFIG_PLATFORM_EC_KEYBOARD\n\"${PLATFORM_EC}/common/keyboard_scan.c\")\nzephyr_sources_ifdef(CONFIG_PLATFORM_EC_LID_SWITCH\n\"${PLATFORM_EC}/common/li... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: shim the port80 module
Shim in the port80 module.
BUG=b:172471337
BRANCH=none
TEST=boot volteer, watch the port80 writes
test port80 command
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I35e3254bb95fec92e4b69ca65f1d8eebbc6d14f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2567033
Commit-Queue: Yuval Peress <peress@chromium.org>
Reviewed-by: Yuval Peress <peress@chromium.org> |
136,305 | 24.11.2020 14:08:30 | 25,200 | c0841278f6052c69a1c0b6efa95d1a4a64209cf6 | COIL: Rename common i2c_controller
Rename i2c_controller.c and update related build file.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/build.mk",
"new_path": "common/build.mk",
"diff": "@@ -85,7 +85,7 @@ common-$(CONFIG_HOSTCMD_REGULATOR)+=regulator.o\ncommon-$(CONFIG_HOSTCMD_RTC)+=rtc.o\ncommon-$(CONFIG_I2C_DEBUG)+=i2c_trace.o\ncommon-$(CONFIG_I2C_HID_TOUCHPAD)+=i2c_hid_touchpad.o\n-c... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename common i2c_controller
Rename i2c_controller.c and update related build file.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I4fc27e494648c4a17e9f3f3d21ece9727ff6636e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558905
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,420 | 24.11.2020 17:35:15 | 0 | 71def4658cb07a00e00f515622500051c2557fde | util: Drop ec_uartd
It is replaced by the hdctools in all current configurations (servod
based development).
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "util/build.mk",
"new_path": "util/build.mk",
"diff": "host-util-bin=ectool lbplay stm32mon ec_sb_firmware_update lbcc \\\nec_parse_panicinfo cbi-util iteflash\n-build-util-bin=ec_uartd\nbuild-util-art+=util/export_taskinfo.so\nifeq ($(CHIP),npcx)\n-build-util-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util: Drop ec_uartd
It is replaced by the hdctools in all current configurations (servod
based development).
BUG=none
TEST=none
Change-Id: I56d97d776a8c2aaf47aa39802cc9831c4f3416a7
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2560631
Reviewed-by: Namyoon Woo <namyoon@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,205 | 01.12.2020 12:25:44 | -28,800 | 57ad295fc22a23991ace7610d502c5ff872c998b | delbin: Config EC chipset
Base on DVT schematic, change EC chip to npcx7m7fc from npcx7m6fc.
BRANCH=firmware-volteer-13521.B
TEST=bring-up | [
{
"change_type": "MODIFY",
"old_path": "board/delbin/board.h",
"new_path": "board/delbin/board.h",
"diff": "/* Baseboard features */\n#include \"baseboard.h\"\n+/*\n+ * The RAM and flash size combination on the NPCX797FC dose not leave\n+ * any unused flash space that can be used to store the .init_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | delbin: Config EC chipset
Base on DVT schematic, change EC chip to npcx7m7fc from npcx7m6fc.
BUG=b:174106425
BRANCH=firmware-volteer-13521.B
TEST=bring-up
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I7c1b7a3a39dc4dd4bacbd23b468a6515c0b04eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2567080
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> |
136,427 | 29.11.2020 16:12:59 | 25,200 | 725de7c47295adf7bc6a770c9867e4d413d1fafd | test: Improve test_send_caps_error in usb_pe_drp
Better mock tx and rx messages, add sop type.
BRANCH=none
TEST=make run-usb_pe_drp | [
{
"change_type": "MODIFY",
"old_path": "common/mock/usb_prl_mock.c",
"new_path": "common/mock/usb_prl_mock.c",
"diff": "* Use of this source code is governed by a BSD-style license that can be\n* found in the LICENSE file.\n*\n- * Fake Protocol Layer module.\n+ * Mock Protocol Layer module.\n*/\n#in... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: Improve test_send_caps_error in usb_pe_drp
Better mock tx and rx messages, add sop type.
BUG=b:161835483 b:173791979
BRANCH=none
TEST=make run-usb_pe_drp
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: If1f91b6385d6841d662a8a6262af6382645da92e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2553343
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,427 | 29.11.2020 17:36:43 | 25,200 | 6f2aa2eeb14edc0266b8a85bdd5769cac40bfbb6 | usbc: Wake PD task on PE TX and RX
Wake the PD task from pe_message_received(), pe_message_sent(), and
pe_report_error() to avoid having to wait USBC_EVENT_TIMEOUT.
BRANCH=none
TEST=make run-usb_pe_drp | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "@@ -915,6 +915,7 @@ void pe_message_received(int port)\nassert(port == TASK_ID_TO_PD_PORT(task_get_current()));\nPE_SET_FLAG(port, PE_FLAGS_MSG_RECEIVED);\n+ task_wake(PD_PORT_TO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usbc: Wake PD task on PE TX and RX
Wake the PD task from pe_message_received(), pe_message_sent(), and
pe_report_error() to avoid having to wait USBC_EVENT_TIMEOUT.
BUG=none
BRANCH=none
TEST=make run-usb_pe_drp
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I2fd1465796224507e1eb64ea20572165918d5bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2564818
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,262 | 24.11.2020 16:34:38 | -28,800 | 418d2e8e40b2a9d1530e18e620dc0a41154f713b | lillipup: fix usb type-a bc1.2 charging
fix usb type-a bc1.2 charging
BRANCH=firmware-volteer-13521.B
TEST=make buildall, test usb type-a charging and usb function work normally | [
{
"change_type": "MODIFY",
"old_path": "board/lindar/board.c",
"new_path": "board/lindar/board.c",
"diff": "@@ -398,6 +398,11 @@ static void kb_backlight_disable(void)\n}\nDECLARE_HOOK(HOOK_CHIPSET_SUSPEND, kb_backlight_disable, HOOK_PRIO_DEFAULT);\n+/* USB-A charging control */\n+const int usb_port... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | lillipup: fix usb type-a bc1.2 charging
fix usb type-a bc1.2 charging
BUG=b:173093980
BRANCH=firmware-volteer-13521.B
TEST=make buildall, test usb type-a charging and usb function work normally
Signed-off-by: jerry2.huang <jerry2.huang@lcfc.corp-partner.google.com>
Change-Id: I60aadcac58ccbfe86d7005db506788a13d6fe4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2557759
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,395 | 26.11.2020 16:50:18 | -28,800 | 8408d21c5cbb85360a76bcfdbbf8d8f89b1a076f | shuboz: Implement LED function
Update LED behavior by Marketing spec.
BRANCH=none
TEST=make BOARD=shuboz | [
{
"change_type": "MODIFY",
"old_path": "board/shuboz/board.h",
"new_path": "board/shuboz/board.h",
"diff": "#define GPIO_USB2_ILIM_SEL IOEX_USB_A1_CHARGE_EN_DB_L\n/* Power LEDs */\n-#define CONFIG_LED_POWER_LED\n+#define CONFIG_LED_ONOFF_STATES_BAT_LOW 10\n/* Motion sensing drivers */\n#define CONFI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | shuboz: Implement LED function
Update LED behavior by Marketing spec.
BUG=b:173341052
BRANCH=none
TEST=make BOARD=shuboz
Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com>
Change-Id: I0e4346d6d83204a20836b3fc94a951309e97b06f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2561908
Reviewed-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,441 | 01.12.2020 20:40:05 | -19,080 | 43422dfde262954c0a85c03aac1c709227b68da8 | boldar: configure fan speed
BRANCH=none
TEST=make BOARD=boldar | [
{
"change_type": "MODIFY",
"old_path": "board/boldar/board.c",
"new_path": "board/boldar/board.c",
"diff": "@@ -133,17 +133,11 @@ const struct fan_conf fan_conf_0 = {\n.enable_gpio = GPIO_EN_PP5000_FAN,\n};\n-/*\n- * Fan specs from datasheet:\n- * Max speed 5900 rpm (+/- 7%), minimum duty cycle 30%.... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | boldar: configure fan speed
BUG=b:162202257
BRANCH=none
TEST=make BOARD=boldar
Signed-off-by: Sooraj Govindan <sooraj.govindan@intel.com>
Change-Id: I675b460c3425d122a9245c753ca64a38258112f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2567200
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,208 | 01.12.2020 15:44:14 | -28,800 | db9651664d93ebda429988898df4ac3bc299f7f1 | isl923x: make get_amon_bmon a function
A pre-processing CL for the charger_get_input_current API.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/isl923x.c",
"new_path": "driver/charger/isl923x.c",
"diff": "#define CPRINTF(format, args...) cprintf(CC_CHARGER, format, ## args)\n#define CPRINTS(format, args...) cprints(CC_CHARGER, format, ## args)\n+enum isl923x_amon_bmon { AMON, BMON };\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | isl923x: make get_amon_bmon a function
A pre-processing CL for the charger_get_input_current API.
BUG=b:169532537
TEST=make buildall
BRANCH=none
Change-Id: Iec7baeb32e0d8f7f6c7260fada8a78d920cc325e
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569081
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,208 | 01.12.2020 15:44:50 | -28,800 | d4944f211943323506f5ddf98418b1bc2fa6095c | asurada: enable AMON/BMON
TEST=amon; ensure the report current is accurate comapres to the
power meter
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "@@ -170,7 +170,9 @@ const struct adc_t adc_channels[] = {\n{\"VBUS\", ADC_MAX_MVOLT * 10, ADC_READ_MAX + 1, 0, CHIP_ADC_CH0},\n{\"BOARD_ID_0\", ADC_MAX_MVOLT, ADC_READ_MAX + 1, 0, CHIP_ADC_C... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: enable AMON/BMON
BUG=b:169532537
TEST=amon; ensure the report current is accurate comapres to the
power meter
BRANCH=none
Change-Id: I43f98db84f362f0331b128475c9cea955c18f163
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569082
Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,365 | 12.11.2020 15:29:48 | -28,800 | 99dba155820737065fc83749bc0e15f79b785546 | eldrid: modify charger configuration
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Tested-by: Scott Chao | [
{
"change_type": "MODIFY",
"old_path": "board/eldrid/board.c",
"new_path": "board/eldrid/board.c",
"diff": "#include \"fan_chip.h\"\n#include \"gpio.h\"\n#include \"hooks.h\"\n+#include \"isl9241.h\"\n#include \"keyboard_8042_sharedlib.h\"\n#include \"keyboard_raw.h\"\n#include \"lid_switch.h\"\n@@ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eldrid: modify charger configuration
BUG=b:166728543
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Terry Chen <terry_chen@wistron.corp-partner.google.com>
Change-Id: I1a918326a625f294fe6cd9a2ec8e2c5b2af43569
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2534231
Tested-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org> |
136,208 | 03.12.2020 14:23:48 | -28,800 | defe99857e24f63ac85d460e3fdfeaa0b5b4dac1 | sm5803: add parenthesis to the input of macros
Inputs have to be guarded with parenthesis.
TEST=make buildall
BRANCH=main | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.h",
"new_path": "driver/charger/sm5803.h",
"diff": "@@ -225,8 +225,8 @@ enum sm5803_charger_modes {\n#define SM5803_REG_CHG_ILIM 0x24\n#define SM5803_CHG_ILIM_RAW GENMASK(4, 0)\n#define SM5803_CURRENT_STEP 100\n-#define SM5803_REG_TO_CURR... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | sm5803: add parenthesis to the input of macros
Inputs have to be guarded with parenthesis.
BUG=none
TEST=make buildall
BRANCH=main
Change-Id: Iedf678e1a2b0f3525aa2b788b0e2c9171d3b4acc
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2570885
Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,305 | 24.11.2020 14:18:04 | 25,200 | 21cc691d17ec60a758934a1239e56afee1fb4ff0 | COIL: Rename local variables in common i2c_controller
Rename local variables and related comments in common i2c_controller
code.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/i2c_controller.c",
"new_path": "common/i2c_controller.c",
"diff": "@@ -107,35 +107,35 @@ const struct i2c_port_t *get_i2c_port(const int port)\n}\n__maybe_unused static int chip_i2c_xfer_with_notify(\n- const int port, const uint16_t slave_addr_flags,\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename local variables in common i2c_controller
Rename local variables and related comments in common i2c_controller
code.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I712217d86f7232f509f1f649b772ec73204ceb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558906
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,305 | 24.11.2020 14:21:09 | 25,200 | 832193295ddfcadeeddae2ef904c6428eacc9f60 | COIL: Rename SLEEP_MASK_I2C_CONTROLLER
Rename SLEEP_MASK_I2C_CONTROLLER and related comments.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/i2c_controller.c",
"new_path": "common/i2c_controller.c",
"diff": "@@ -252,8 +252,8 @@ void i2c_lock(int port, int lock)\nirq_lock_key = irq_lock();\ni2c_port_active_list |= 1 << port;\n- /* Ec cannot enter sleep if there's any i2c port active. */\n- di... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename SLEEP_MASK_I2C_CONTROLLER
Rename SLEEP_MASK_I2C_CONTROLLER and related comments.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ib49a5c6b07a203dc659ed65909292e5f1009d33f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2558907
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,276 | 03.12.2020 22:45:28 | -28,800 | 2c3dd5d148ab7ea3b7c6796e2e4c3069b3347043 | Kakadu: Fix battery is_present status for bq27542
Fix the battery is_present status for gauge bq27542.
BRANCH=master
TEST=1.make -j BOARD=kakadu
2.verified the battery present status and the result is OK. | [
{
"change_type": "MODIFY",
"old_path": "driver/battery/bq27541.c",
"new_path": "driver/battery/bq27541.c",
"diff": "@@ -266,7 +266,7 @@ enum battery_present battery_is_present(void)\n{\nint v;\nif (bq27541_read(REG_TEMPERATURE, &v))\n- return BP_NOT_SURE;\n+ return BP_NO;\nreturn BP_YES;\n}\n@@ -312... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Kakadu: Fix battery is_present status for bq27542
Fix the battery is_present status for gauge bq27542.
BUG=b:174802149
BRANCH=master
TEST=1.make -j BOARD=kakadu
2.verified the battery present status and the result is OK.
Change-Id: Ic8d9d503bc2f7d9648df56c150018f304aacfb18
Signed-off-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2571145
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,208 | 16.11.2020 14:28:07 | -28,800 | 8a03b83e5bc7fcaad8ce018607cf105a8d555486 | asurada: use udelay for HPD pulse
usleep is unstable on asurada, we use udelay instead to prevent from
the pulse width over the spec (1ms).
TEST=ensure the pulse width is reliable.
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/usb_pd_policy.c",
"new_path": "board/asurada/usb_pd_policy.c",
"diff": "@@ -106,7 +106,12 @@ __override int svdm_dp_attention(int port, uint32_t *payload)\n/* generate IRQ_HPD pulse */\nsvdm_set_hpd_gpio(port, 0);\n- usleep(HPD_DSTREAM_DEBOUNCE_I... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: use udelay for HPD pulse
usleep is unstable on asurada, we use udelay instead to prevent from
the pulse width over the spec (1ms).
BUG=b:171172053
TEST=ensure the pulse width is reliable.
BRANCH=none
Change-Id: I8b349b6d09dca3a116e6fc9a2552faa041664674
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2539262
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,295 | 04.12.2020 10:46:59 | -28,800 | 4682423de58757a744176261390bfc3d341c046c | dirinboz: remove unuse config
This patch remove unuse config on dirinboz:
CONFIG_IO_EXPANDER_PCAL6408
CONFIG_USB_MUX_PS8740
BRANCH=zork
TEST=make BOARD=dirinboz | [
{
"change_type": "MODIFY",
"old_path": "board/dirinboz/board.h",
"new_path": "board/dirinboz/board.h",
"diff": "#include <stdbool.h>\n#include \"baseboard.h\"\n-#define CONFIG_IO_EXPANDER_PCAL6408\n#define CONFIG_MKBP_USE_GPIO\n#define CONFIG_USBC_PPC_NX20P3483\n-#define CONFIG_USB_MUX_PS8740\n#defi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dirinboz: remove unuse config
This patch remove unuse config on dirinboz:
CONFIG_IO_EXPANDER_PCAL6408
CONFIG_USB_MUX_PS8740
BUG=none
BRANCH=zork
TEST=make BOARD=dirinboz
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I6cbbb20b4b43c860206828943b9376959b0e1cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2573659
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,256 | 03.12.2020 13:54:09 | 25,200 | b06ad2df42bd9c3c48e06df0645b526a1fc454e7 | zephyr: add CBI module to zephyr options
Shim in CBI module and necessary dependencies.
BRANCH=none
TEST=type `cbi` on volteer | [
{
"change_type": "MODIFY",
"old_path": "zephyr/CMakeLists.txt",
"new_path": "zephyr/CMakeLists.txt",
"diff": "@@ -35,6 +35,7 @@ zephyr_include_directories_ifdef(\nadd_subdirectory_ifdef(CONFIG_PLATFORM_EC \"shim\")\nzephyr_sources_ifdef(CONFIG_PLATFORM_EC \"${PLATFORM_EC}/common/base32.c\")\n+zephyr... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: add CBI module to zephyr options
Shim in CBI module and necessary dependencies.
BRANCH=none
BUG=b:168032342,b:168032589
TEST=type `cbi` on volteer
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: Ic08f472f8d52cd4521b78f819ea22e337cccc6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2572736
Reviewed-by: Simon Glass <sjg@chromium.org>
Commit-Queue: Simon Glass <sjg@chromium.org> |
136,269 | 20.11.2020 08:35:27 | 28,800 | b5f739adf69cf118679f4100813abcd2d6a6892a | docs: Fix headers in write protection doc
gitiles doesn't render backticks in headers.
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/write_protection.md",
"new_path": "docs/write_protection.md",
"diff": "@@ -129,9 +129,9 @@ flashprotect enable/disable`, which sends the `EC_CMD_FLASH_PROTECT` command\ntoggling `EC_FLASH_PROTECT_RO_AT_BOOT` (changing `--name` to target different\nECs).\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Fix headers in write protection doc
gitiles doesn't render backticks in headers.
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I312799ad938d35e8452a90d129baf933ff6639e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552603
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,269 | 20.11.2020 08:39:56 | 28,800 | bc4833e0da5e0422adccdc9eae801c17213ce0ff | docs: Fix typos in write protection doc
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/write_protection.md",
"new_path": "docs/write_protection.md",
"diff": "[TOC]\nThis is a somewhat tricky topic since write protection implementations can\n-differ between chips and the hardware write protection has changed over time, so\n-please edit or op... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Fix typos in write protection doc
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ib512490365a0f20380813bd871f7effbf374a435
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2552604
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,208 | 29.10.2020 15:27:23 | -28,800 | 7ae129c1f3cd76722902da6582825f53e4aff344 | charger: add charger_get_input_current_limit
A pre-processing CL for the later CL which migrate API from
charger_get_input_current.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/charger.c",
"new_path": "common/charger.c",
"diff": "@@ -491,6 +491,23 @@ enum ec_error_list charger_set_input_current_limit(int chgnum,\nreturn rv;\n}\n+enum ec_error_list charger_get_input_current_limit(int chgnum,\n+ int *input_current)\n+{\n+ int rv... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charger: add charger_get_input_current_limit
A pre-processing CL for the later CL which migrate API from
charger_get_input_current.
BUG=b:171853295
TEST=make buildall
BRANCH=none
Change-Id: Ia15ce47ac5d068b7125c58115e368f9dfa87958c
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2569084
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,330 | 07.12.2020 09:54:48 | 25,200 | 9760abbefee06a7ffa214dd477665b8c9476061e | TCPMv2: Fix Soft Reset logic
TEST=Observe Soft Reset after not receiving GoodCRC 3 times
BRANCH=firmware-volteer-13521.B-master | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "@@ -1233,14 +1233,23 @@ void pe_report_error(int port, enum pe_error e, enum tcpm_transmit_type type)\n* See section 8.3.3.4.1.1 PE_SRC_Send_Soft_Reset State:\n*\n* The PE_Send_S... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Fix Soft Reset logic
BUG=b:173025773,b:173025737,b:155181980
TEST=Observe Soft Reset after not receiving GoodCRC 3 times
BRANCH=firmware-volteer-13521.B-master
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Iee7016549a8a83b21d0a7ca168ace7ea2594a594
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2578199
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,229 | 30.11.2020 19:38:49 | -28,800 | 5326411b2c2aacc43359b487137b904a092155c7 | gumboz: Update power led behavior.
This path update power led behavior as following:
system s0 power led on
system s0ix blinking white
system s5 power led off
BRANCH=Zork
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/gumboz/gpio.inc",
"new_path": "board/gumboz/gpio.inc",
"diff": "@@ -53,6 +53,7 @@ UNIMPLEMENTED(PCH_SMI_L)\nGPIO(LED_FULL_L, PIN(6, 0), GPIO_OUT_HIGH)\nGPIO(LED_CHRG_L, PIN(C, 0), GPIO_OUT_HIGH)\n+GPIO(PWR_LED_WHITE_L, PIN(C, 3), GPIO_OUT_HIGH)\n/*\n* Gu... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gumboz: Update power led behavior.
This path update power led behavior as following:
system s0 power led on
system s0ix blinking white
system s5 power led off
BUG=none
BRANCH=Zork
TEST=none
Signed-off-by: jason.guo@quanta.corp-partner.google.com
Change-Id: Ic77e5795494a543405b513878ea643f41028af3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2567862
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,208 | 08.12.2020 14:28:25 | -28,800 | edce6b13a0a0af4cbe27c2cf8de74bc6b788789c | charger: fail fast with EC_ERROR_UMIMPLEMENTED
This CL doesn't change the flow, just fail fast.
need a refactoring.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/charger.c",
"new_path": "common/charger.c",
"diff": "@@ -255,104 +255,95 @@ DECLARE_HOOK(HOOK_INIT, charger_chips_init, HOOK_PRIO_INIT_I2C + 1);\nenum ec_error_list charger_post_init(void)\n{\nint chgnum = 0;\n- int rv = EC_ERROR_UNIMPLEMENTED;\nif ((ch... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charger: fail fast with EC_ERROR_UMIMPLEMENTED
This CL doesn't change the flow, just fail fast.
need a refactoring.
BUG=none
TEST=make buildall
BRANCH=none
Change-Id: I896e46a67722d6e8ffc7db5dffebc60da0b7fc5c
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2578617
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,280 | 09.12.2020 11:49:28 | -28,800 | f3e6858efee0f6075b530f62298bdc6c915078ed | zed: update pid
Update PID to the allocated one in cl/343451328.
TEST=make
BRANCH=main
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/variants.h",
"new_path": "board/hammer/variants.h",
"diff": "#elif defined(BOARD_WHISKERS)\n#define CONFIG_USB_PID 0x5030\n#elif defined(BOARD_ZED)\n-/* TODO: update PID */\n-#define CONFIG_USB_PID 0x5022\n+#define CONFIG_USB_PID 0x504c\n#else\n#e... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zed: update pid
Update PID to the allocated one in cl/343451328.
BUG=b:169651794
TEST=make
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I1135a62dbc3487b56549fe97661ca51ddbe052fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2581030
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,395 | 17.11.2020 11:55:41 | -28,800 | 9b039dc93e156e720a6916cdc804b4e4575bb0c5 | Galtic: Modify Charger and TCPC configurations.
Base on schematics, update charger IC and TCPC setting.
BRANCH=none
TEST=make BOARD=galtic | [
{
"change_type": "MODIFY",
"old_path": "board/galtic/board.c",
"new_path": "board/galtic/board.c",
"diff": "#include \"driver/accel_kionix.h\"\n#include \"driver/accelgyro_lsm6dsm.h\"\n#include \"driver/bc12/pi3usb9201.h\"\n-#include \"driver/charger/sm5803.h\"\n+#include \"driver/charger/isl923x.h\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Galtic: Modify Charger and TCPC configurations.
Base on schematics, update charger IC and TCPC setting.
BUG=b:173343043
BRANCH=none
TEST=make BOARD=galtic
Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com>
Change-Id: Ie47e296d7c653805acc2c14f94c26376a99a718d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2543570
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,287 | 10.12.2020 00:56:10 | 25,200 | e200d3747d694c8137f254ac1000169d541f2822 | zephyr: remove dependency on chip specific code for npcx
BRANCH=none
TEST=zmake testall
Cq-Depend: chromium:2583272 | [
{
"change_type": "MODIFY",
"old_path": "zephyr/shim/chip/CMakeLists.txt",
"new_path": "zephyr/shim/chip/CMakeLists.txt",
"diff": "@@ -18,18 +18,5 @@ zephyr_compile_definitions(\"CHIP_VARIANT_${CHIP_VARIANT}\")\nif (\"${CHIP_FAMILY}\" MATCHES \"^NPCX[0-9]$\")\nadd_subdirectory(npcx)\n- zephyr_include... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: remove dependency on chip specific code for npcx
BRANCH=none
BUG=b:175249000
TEST=zmake testall
Cq-Depend: chromium:2583272
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: Ie50e56df60e060c3741013912ab46d807fc5e417
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2582819
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> |
136,311 | 06.12.2020 13:15:14 | 25,200 | c5cb10fe676d95ecb02867edbc04d9d9e63fd015 | zephyr: Sort file list by config option
Sort the cmake file list by the config option name.
BRANCH=none
TEST=build and boot on volteer
Tested-by: Simon Glass | [
{
"change_type": "MODIFY",
"old_path": "zephyr/CMakeLists.txt",
"new_path": "zephyr/CMakeLists.txt",
"diff": "@@ -34,7 +34,15 @@ zephyr_include_directories_ifdef(\nadd_subdirectory_ifdef(CONFIG_PLATFORM_EC \"shim\")\n-zephyr_sources_ifdef(CONFIG_PLATFORM_EC \"${PLATFORM_EC}/common/base32.c\")\n+# CO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: Sort file list by config option
Sort the cmake file list by the config option name.
BRANCH=none
BUG=none
TEST=build and boot on volteer
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I0c66524b990bcc24ac3d19b260daf7ff070861cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2582279
Commit-Queue: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org> |
136,190 | 08.12.2020 12:15:07 | 28,800 | 37120f23ab24e41cef32b1d4524772ae6ca0c148 | BB retimer: Set USB2.0 bit to 0
Since the TCSS mux ignores the USB2.0, set it to 0
BRANCH=None
TEST=Able to set the USB2.0 bit to 0 in the BB retimer config register | [
{
"change_type": "MODIFY",
"old_path": "driver/retimer/bb_retimer.c",
"new_path": "driver/retimer/bb_retimer.c",
"diff": "@@ -136,22 +136,6 @@ static void retimer_set_state_dfp(int port, mux_state_t mux_state,\nenum idh_ptype cable_type = get_usb_pd_cable_type(port);\nstruct pd_discovery *disc;\n- i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | BB retimer: Set USB2.0 bit to 0
Since the TCSS mux ignores the USB2.0, set it to 0
BUG=b:175119818
BRANCH=None
TEST=Able to set the USB2.0 bit to 0 in the BB retimer config register
Signed-off-by: Ayushee Shah <ayushee.shah@intel.com>
Change-Id: Ia76ede10f9bdbf746a400816017e7d36b0790764
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2580455
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,305 | 07.12.2020 16:17:39 | 25,200 | d7cb4a314bbad10ca3137077de802f547c6d99ac | TCPMv2: Remove redundant TC flags
The TC flags for the fixed PDO data are redundant with the stored PDOs
we have for both sources and sinks. Remove these and their callers.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "@@ -1577,29 +1577,6 @@ static void pe_update_src_pdo_flags(int port, int pdo_cnt, uint32_t *pdos)\nif ((pdos[0] & PDO_TYPE_MASK) != PDO_TYPE_FIXED)\nreturn;\n- if (pdos[0] & PDO_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Remove redundant TC flags
The TC flags for the fixed PDO data are redundant with the stored PDOs
we have for both sources and sinks. Remove these and their callers.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: If242d7f9b9210bccdcafedc97dbf89dd581797d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2576454
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,360 | 09.12.2020 17:28:03 | -28,800 | b5b267fbfe2493c38f920f610de4d79d2c6f50ee | ec_commands: add struct ec_response_activity_data
Add struct ec_response_activity_data to handle activity data in
include/ec_commands.h.
BRANCH=None
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "common/body_detection.c",
"new_path": "common/body_detection.c",
"diff": "@@ -98,8 +98,10 @@ void body_detect_change_state(enum body_detect_states state, bool spoof)\nif (IS_ENABLED(CONFIG_GESTURE_HOST_DETECTION)) {\nstruct ec_response_motion_sensor_data vecto... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_commands: add struct ec_response_activity_data
Add struct ec_response_activity_data to handle activity data in
include/ec_commands.h.
BRANCH=None
BUG=b:169374265
TEST=make buildall
Signed-off-by: Ching-Kang Yen <chingkang@chromium.org>
Change-Id: I5f40d45d656ae91acc6e9364261c548f302383ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2581708
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,219 | 10.12.2020 10:14:02 | 25,200 | 9897bebc5c08effaa8391e9d4167bcb720c794e1 | zephyr: Fix 'edefines' typo
Fix a typo that crept into the Kconfig.
BRANCH=none
TEST=build for volteer | [
{
"change_type": "MODIFY",
"old_path": "zephyr/Kconfig",
"new_path": "zephyr/Kconfig",
"diff": "@@ -32,7 +32,7 @@ config ZEPHYR\nconfig.h not being available in some headers.\n# Define PLATFORM_EC_... options to enable EC features. Each Kconfig should be\n-# matched by a line in zephyr/shim/include/... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: Fix 'edefines' typo
Fix a typo that crept into the Kconfig.
BRANCH=none
BUG=none
TEST=build for volteer
Change-Id: I57634da26ca94aba3b80d5f4c10d75b250a9ea2c
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2585064
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,257 | 20.11.2020 11:20:12 | -28,800 | 5147ef47114825b4f98742c2968f1a1051fdf7c4 | eldrid: ignore PROCHOT when system off
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "common/throttle_ap.c",
"new_path": "common/throttle_ap.c",
"diff": "@@ -95,6 +95,16 @@ static void prochot_input_deferred(void)\nif (prochot_in == debounced_prochot_in)\nreturn;\n+ /*\n+ * b/173180788 Confirmed from Intel internal that SLP_S3# asserts low\n+ *... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eldrid: ignore PROCHOT when system off
BUG=b:173180788
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: I0896dc0e9dcb45a232d7109588b95bf4ee1e6bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2550110
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,317 | 07.12.2020 15:12:43 | 25,200 | 942e7ade3321fb166b7dc3739cafb4f25d41b528 | guybrush: Fill in gpio.inc for guybrush
Fill in guybrush gpio.inc based on schematic. Add minimal implementation
required to get guybrush to build with gpio.inc filled in.
TEST=Build guybrush binary
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "baseboard/guybrush/base_ec.tasklist",
"new_path": "baseboard/guybrush/base_ec.tasklist",
"diff": "#define BASEBOARD_CONFIG_TASK_LIST \\\nTASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \\\nTASK_ALWAYS(HOSTCMD, host_command_task, NULL, LARGER_TASK_S... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | guybrush: Fill in gpio.inc for guybrush
Fill in guybrush gpio.inc based on schematic. Add minimal implementation
required to get guybrush to build with gpio.inc filled in.
BUG=b:175056466
TEST=Build guybrush binary
BRANCH=None
Change-Id: I2f66cebb02e174661950ec277175f63f85896c9c
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2578256
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,438 | 10.12.2020 13:52:45 | 28,800 | e92c7a2a33a5dbc48c9ab8294c2c67a949dc1572 | nucleo-dartmonkey: Build the same tests as dartmonkey
This would enable us to test dartmonkey's on-device tests on
nucleo-h743zi.
BRANCH=none
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/nucleo-dartmonkey/build.mk",
"new_path": "board/nucleo-dartmonkey/build.mk",
"diff": "@@ -14,12 +14,17 @@ test-list-y=\\\naes \\\ncompile_time_macros \\\ncrc \\\n+ flash_physical \\\n+ flash_write_protect \\\nfpsensor \\\n+ mpu \\\nmutex \\\npingpong \\\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nucleo-dartmonkey: Build the same tests as dartmonkey
This would enable us to test dartmonkey's on-device tests on
nucleo-h743zi.
BRANCH=none
BUG=b:157692395
TEST=make -j buildall
Signed-off-by: Yicheng Li <yichengli@chromium.org>
Change-Id: I9251a177a1c9bb5996906aaca6682207b706d9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2585746
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,351 | 11.12.2020 11:07:53 | 28,800 | a86aecb2de50437622e91ee451079175cdef5e1d | COIL: Rename ec_ec_comm* files to inclusive language
Rename the files to server/client instead
TEST=Rebuild and run on volteer
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.c",
"new_path": "board/hammer/board.c",
"diff": "#include \"driver/charger/isl923x.h\"\n#include \"driver/led/lm3630a.h\"\n#include \"ec_version.h\"\n-#include \"ec_ec_comm_slave.h\"\n+#include \"ec_ec_comm_server.h\"\n#include \"gpio.h\"\n#... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename ec_ec_comm* files to inclusive language
Rename the files to server/client instead
BUG=none
TEST=Rebuild and run on volteer
BRANCH=none
Signed-off-by: dossym@chromium.org
Change-Id: Ibcbdcddfab1b878ff48fc4cb76307efe6de4fac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2586037
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,351 | 11.12.2020 11:17:39 | 28,800 | 61022575d3c8b75d07e4f3be3f1616e45767f673 | COIL: Use inclusive language for EC-EC communication code
Replace with server/client nomenclature
TEST=build and run on volteer
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.c",
"new_path": "board/hammer/board.c",
"diff": "@@ -145,15 +145,15 @@ struct keyboard_scan_config keyscan_config = {\nstruct consumer const ec_ec_usart_consumer;\nstatic struct usart_config const ec_ec_usart;\n-struct queue const ec_ec_comm... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Use inclusive language for EC-EC communication code
Replace with server/client nomenclature
BUG=none
TEST=build and run on volteer
BRANCH=none
Signed-off-by: dossym@chromium.org
Change-Id: I23fe7de9228a9611b49eef1362bf15159b25aab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2586038
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,351 | 11.12.2020 13:51:51 | 28,800 | abd894e1c9e01462ce5cf4cc4691a75f4e1378de | COIL: Rename EC-EC comm config to be inclusive
Use server/client nomenclature instead
TEST=build and run on volteer
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.h",
"new_path": "board/hammer/board.h",
"diff": "#define CONFIG_STREAM_USART2\n#define CONFIG_STREAM_USART\n-#define CONFIG_EC_EC_COMM_SLAVE\n+#define CONFIG_EC_EC_COMM_SERVER\n#define CONFIG_EC_EC_COMM_BATTERY\n#define CONFIG_CRC8\n#endif /... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename EC-EC comm config to be inclusive
Use server/client nomenclature instead
BUG=none
TEST=build and run on volteer
BRANCH=none
Signed-off-by: dossym@chromium.org
Change-Id: I2cf4a82291134378ed21bbc068361f1be25e8176
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2587574
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,351 | 12.12.2020 00:28:36 | 0 | c03b3d8174231562369cd51f3fedf82e75655273 | COIL: Rename i2c_peripheral files
TEST=build and run on volteer
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "chip/it83xx/build.mk",
"new_path": "chip/it83xx/build.mk",
"diff": "@@ -37,4 +37,4 @@ ifndef CONFIG_KEYBOARD_NOT_RAW\nchip-$(HAS_TASK_KEYSCAN)+=keyboard_raw.o\nendif\nchip-$(CONFIG_I2C_CONTROLLER)+=i2c.o\n-chip-$(CONFIG_I2C_PERIPHERAL)+=i2c_slave.o\n+chip-$(CO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Rename i2c_peripheral files
BUG=none
TEST=build and run on volteer
BRANCH=none
Signed-off-by: dossym@chromium.org
Change-Id: I11a75e4954e918b2d4ff575dee14dec621a619b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2587226
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,351 | 12.12.2020 02:46:43 | 0 | 52863374ad592b80b24def9689856ecda2d645d0 | COIL: Standardize i2c peripheral language
TEST=validate volteer build (i2c_peripheral.c is not used by any boards)
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "chip/it83xx/i2c.c",
"new_path": "chip/it83xx/i2c.c",
"diff": "@@ -94,7 +94,7 @@ enum enhanced_i2c_ctl {\nE_RX_MODE = 0x80,\n/* State reset and hardware reset */\nE_STS_AND_HW_RST = (E_STS_RST | E_HW_RST),\n- /* Generate start condition and transmit slave addre... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Standardize i2c peripheral language
BUG=none
TEST=validate volteer build (i2c_peripheral.c is not used by any boards)
BRANCH=none
Signed-off-by: dossym@chromium.org
Change-Id: Ib2d78dc3fc9f4f189f84409cf43ab96788c429be
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2587227
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,351 | 12.12.2020 04:41:45 | 0 | 8223f2d538f3d40b1a306661312201118a00dbd5 | COIL: Clean up controller/peripheral language in headers
TEST=verify builds are still working
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "include/i2c.h",
"new_path": "include/i2c.h",
"diff": "#include \"stddef.h\"\n/*\n- * I2C Slave Address encoding\n+ * I2C Peripheral Address encoding\n*\n* EC will favor 7bit I2C/SPI address encoding. The variable/define\n* naming should follow the pattern, if ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COIL: Clean up controller/peripheral language in headers
BUG=none
TEST=verify builds are still working
BRANCH=none
Signed-off-by: dossym@chromium.org
Change-Id: I8925a7ffd3ab4e47dfed213438f601d673188259
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2588008
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,351 | 12.12.2020 18:51:29 | 0 | 3a03483f801c5b21aa662d6a2da97fed042f60ee | EC: Removing an unused i2cm_init function signature
TEST=built several boards
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "include/i2c.h",
"new_path": "include/i2c.h",
"diff": "@@ -506,12 +506,6 @@ int i2c_set_response(int port, uint8_t *buf, int len);\n*/\nvoid i2c_init(void);\n-/**\n- * Initialize i2c controller ports. This function can be called for cases where\n- * i2c ports a... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | EC: Removing an unused i2cm_init function signature
BUG=none
TEST=built several boards
BRANCH=none
Signed-off-by: dossym@chromium.org
Change-Id: I4e9b52fb5c7ef6dab4db30f98cece9b5635f699c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2587805
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,443 | 11.12.2020 11:14:38 | 28,800 | d76cd68529ced5e4271a2a7f4a56424b74a2c896 | docs/ide-support.md: Run mdformat
mdformat -w --compatibility docs/ide-support.md
BRANCH=none
TEST=Check in Gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/ide-support.md",
"new_path": "docs/ide-support.md",
"diff": "@@ -34,18 +34,24 @@ You can use the `ide-config.sh` tool to generate a VSCode configuration that\nincludes selectable sub-configurations for every board/image pair.\n1. From the root `ec` direct... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/ide-support.md: Run mdformat
mdformat -w --compatibility docs/ide-support.md
BRANCH=none
BUG=none
TEST=Check in Gitiles
Change-Id: I5c381679bff894b48a49c7a5a20e8e5268678762
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2586040
Commit-Queue: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,299 | 14.12.2020 21:11:50 | -28,800 | 4309f89db87dfdab365023f67fd7efb2d6867cdb | Coachz: correct g_sensor orientation
Correct the g-sensor oriention to match the latest board.
BRANCH=none
TEST=make BOARD=coachz -j
TEST=check the screen oriention. | [
{
"change_type": "MODIFY",
"old_path": "board/coachz/board.c",
"new_path": "board/coachz/board.c",
"diff": "@@ -319,8 +319,8 @@ static struct bmi_drv_data_t g_bmi160_data;\n/* Matrix to rotate accelerometer into standard reference frame */\nconst mat33_fp_t lid_standard_ref = {\n- { 0, FLOAT_TO_FP(1... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Coachz: correct g_sensor orientation
Correct the g-sensor oriention to match the latest board.
BRANCH=none
BUG=none
TEST=make BOARD=coachz -j
TEST=check the screen oriention.
Signed-off-by: hanwenchao <hanwenchao@huaqin.corp-partner.google.com>
Change-Id: Ia0a62cbf7abd64a6a89c300dcbd6f1b74c4616d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2589693
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Commit-Queue: Bob Moragues <moragues@chromium.org> |
136,317 | 10.12.2020 12:16:50 | 25,200 | 5f0df61bad38377fbaf98b081bd4d88560507aeb | guybrush: power and chipset configuration
Basic power and chipset configuration for guybrush.
Using stoney chipset, which is missing support for S0ix.
S0ix support will be added later (b/175234270).
BRANCH=None
TEST=build | [
{
"change_type": "MODIFY",
"old_path": "baseboard/guybrush/base_ec.tasklist",
"new_path": "baseboard/guybrush/base_ec.tasklist",
"diff": "#define BASEBOARD_CONFIG_TASK_LIST \\\nTASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \\\n+ TASK_NOTEST(CHIPSET, chipset_task, NULL, VENTI_TASK_STACK... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | guybrush: power and chipset configuration
Basic power and chipset configuration for guybrush.
Using stoney chipset, which is missing support for S0ix.
S0ix support will be added later (b/175234270).
BUG=b:175118237
BRANCH=None
TEST=build
Change-Id: I6aaa224b9ef554487a428db069d43922168baceb
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2585924
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,331 | 14.12.2020 17:24:55 | 25,200 | 88530597d9aa9363ccb63a30e97e0bd8243b2d91 | zephyr: clear a few compiler warnings
BRANCH=none
TEST=compile, observe less warnings | [
{
"change_type": "MODIFY",
"old_path": "common/cbi.c",
"new_path": "common/cbi.c",
"diff": "@@ -434,7 +434,7 @@ static void dump_flash(void)\nstatic void print_tag(const char * const tag, int rv, const uint32_t *val)\n{\n- ccprintf(tag);\n+ ccprintf(\"%s\", tag);\nif (rv == EC_SUCCESS && val)\nccpri... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: clear a few compiler warnings
BUG=b:174871569
BRANCH=none
TEST=compile, observe less warnings
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: Id45ebc740344ec9261e28454a966e22a1cd6f629
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2591788
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,257 | 15.12.2020 13:49:17 | -28,800 | 8bdfbe60179cc01f8ca4116993e3f5cb4c9ed46d | eldrid: fix eldrid_npcx796fc name
change eldrid_npcx796fc to eldrid_npcx796 to meet config.star.
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
TEST=Boot up on Eldrid | [
{
"change_type": "MODIFY",
"old_path": "board/eldrid/board.h",
"new_path": "board/eldrid/board.h",
"diff": "/* Optional features */\n#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */\n-#ifndef BOARD_ELDRID_NPCX796FC\n+#ifndef BOARD_ELDRID_NPCX796\n/*\n* The RAM and flash si... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eldrid: fix eldrid_npcx796fc name
change eldrid_npcx796fc to eldrid_npcx796 to meet config.star.
BUG=b:173754312
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
TEST=Boot up on Eldrid
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: If8025ce4e512c00722a269eeb57643218723915b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2592530
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,222 | 23.11.2020 13:19:18 | -28,800 | 7303a75202abb8f0a9a232ce2ab91fe20f12b072 | common: fix IPI buffer vaddr location
There should be an offset: CONFIG_PROGRAM_MEMORY_BASE.
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "common/firmware_image.lds.S",
"new_path": "common/firmware_image.lds.S",
"diff": "@@ -45,7 +45,7 @@ MEMORY\nFLASH (rx) : ORIGIN = CONFIG_PROGRAM_MEMORY_BASE,\nLENGTH = CONFIG_FLASH_SIZE\n#ifdef CONFIG_IPI\n- IPI_BUFFER (rw) : ORIGIN = CONFIG_IPC_SHARED_OBJ_ADD... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: fix IPI buffer vaddr location
There should be an offset: CONFIG_PROGRAM_MEMORY_BASE.
BRANCH=none
BUG=b:173753688
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I6c84b8e12ad6b24ba969b48c7b70aba4684e1572
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2553995
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,222 | 23.11.2020 14:01:17 | -28,800 | ef4294baeaac09835dd1ab914619f74a6dfadddf | chip/mt8192_scp: set CONFIG_PROGRAM_MEMORY_BASE_LOAD
Sets CONFIG_PROGRAM_MEMORY_BASE_LOAD to separate VirtAddr and PhysAddr
in the final ec.obj.
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/config_chip.h",
"new_path": "chip/mt8192_scp/config_chip.h",
"diff": "#define CONFIG_RO_STORAGE_OFF 0\n#define CONFIG_RW_STORAGE_OFF 0\n#define CONFIG_PROGRAM_MEMORY_BASE 0\n+#define CONFIG_PROGRAM_MEMORY_BASE_LOAD 0x10500000\n#define CONFIG_MA... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: set CONFIG_PROGRAM_MEMORY_BASE_LOAD
Sets CONFIG_PROGRAM_MEMORY_BASE_LOAD to separate VirtAddr and PhysAddr
in the final ec.obj.
BRANCH=none
BUG=b:173753688
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: If839ffb5cc63c945492dbc20c12542a93b0ae569
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2553997
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,222 | 15.12.2020 13:54:13 | -28,800 | f7df2b59796fb9239ea390c1f027f47c25d604c9 | chip/mt8192_scp: make all cache operations inline
Makes all cache operations inline.
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/cache.c",
"new_path": "chip/mt8192_scp/cache.c",
"diff": "*/\n#include \"cache.h\"\n-#include \"common.h\"\n-#include \"compile_time_macros.h\"\n#include \"console.h\"\n#include \"csr.h\"\n-#include \"util.h\"\n-\n-/* rs1 0~31 register X0~X31 *... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: make all cache operations inline
Makes all cache operations inline.
BRANCH=none
BUG=b:175512991
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I6d2e8752b4be63257854630a83c74aca21e0d799
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2592298
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,222 | 15.12.2020 14:34:11 | -28,800 | 59797476b4ad70cfe4209e6f9fdd3b78e49c12ed | chip/mt8192_scp: add memory barrier after writing to cache
Writing to AXI is asynchronous. Adds memory barrier to writeback and
flush cache operations to make sure the writing is done.
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/cache.h",
"new_path": "chip/mt8192_scp/cache.h",
"diff": "@@ -78,12 +78,17 @@ static inline void cache_barrier_dcache(void)\nstatic inline void cache_writeback_dcache(void)\n{\ncache_op_all(COP_OP_WRITEBACK_DCACHE);\n+ cache_barrier_icache();\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: add memory barrier after writing to cache
Writing to AXI is asynchronous. Adds memory barrier to writeback and
flush cache operations to make sure the writing is done.
BRANCH=none
BUG=b:175512991
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I6d04a2604f4eddae54aee4ba3ee4600e909e2784
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2592299
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,295 | 16.12.2020 16:47:38 | -28,800 | 638a18af5e898e7b84a3e5c8db62c0e5226a3c3f | berknip: remove unuse thermal setting
berknip not use cpu temperature to control fan,
so we remove the setting.
BRANCH=zork
TEST=make BOARD=berknip | [
{
"change_type": "MODIFY",
"old_path": "board/berknip/board.c",
"new_path": "board/berknip/board.c",
"diff": "@@ -515,8 +515,6 @@ const static struct ec_thermal_config thermal_cpu = {\n.temp_host_release = {\n[EC_TEMP_THRESH_HIGH] = C_TO_K(99),\n},\n- .temp_fan_off = C_TO_K(105),\n- .temp_fan_max = ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | berknip: remove unuse thermal setting
berknip not use cpu temperature to control fan,
so we remove the setting.
BUG=none
BRANCH=zork
TEST=make BOARD=berknip
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I9fbc9ec1116dcd480018c1e348ed124adcfa64f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2594754
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org> |
136,257 | 16.12.2020 16:14:47 | -28,800 | 3a0cce1ab05f1c72ca1c33e4e60dc459844d29f9 | eldrid: add support CONFIG_USB_PD_EXTENDED_MESSAGES
Eldrid support PD 3.0, so remove undef to support related commend.
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/eldrid/board.h",
"new_path": "board/eldrid/board.h",
"diff": "#define PD_MAX_CURRENT_MA 3000\n#define PD_MAX_VOLTAGE_MV 20000\n-/* Disabled PD extended message support to save flash space. */\n-#undef CONFIG_USB_PD_EXTENDED_MESSAGES\n-\n/* USB Type A Fea... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eldrid: add support CONFIG_USB_PD_EXTENDED_MESSAGES
Eldrid support PD 3.0, so remove undef to support related commend.
BUG=b:175519100
BRANCH=firmware-volteer-13521.B-master
TEST=make buildall
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: Ie0121e213a071ed1346c34486911ecb41baa9805
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2594728
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,360 | 03.12.2020 16:53:03 | -28,800 | 3b1f01e3942b0fb8f07e9c113d79522a1f261815 | coachz: config: Add on-body detection config
Add on-body detection configuration on CoachZ devices
BRANCH=None
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/coachz/board.h",
"new_path": "board/coachz/board.h",
"diff": "#include \"baseboard.h\"\n+/* On-body detection */\n+#define CONFIG_BODY_DETECTION\n+#define CONFIG_BODY_DETECTION_SENSOR LID_ACCEL\n+#define CONFIG_BODY_DETECTION_VAR_NOISE_FACTOR 150 /* % */... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | coachz: config: Add on-body detection config
Add on-body detection configuration on CoachZ devices
BRANCH=None
BUG=b:169374265
TEST=make buildall
Signed-off-by: Ching-Kang Yen <chingkang@chromium.org>
Change-Id: I9f3ad1b968ec9a03a49ac3fc4b32efc001599e39
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2570890
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,317 | 14.12.2020 12:49:25 | 25,200 | 87b36903a7906d93f42558ddf9ca5406e7bcfa40 | guybrush: I2C port map
Add i2c port map for guybrush.
TEST=Build
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "baseboard/guybrush/baseboard.c",
"new_path": "baseboard/guybrush/baseboard.c",
"diff": "/* Guybrush family-specific configuration */\n+#include \"chipset.h\"\n#include \"gpio.h\"\n+#include \"i2c.h\"\n#include \"power.h\"\n/* Wake Sources */\n@@ -46,6 +48,82 @... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | guybrush: I2C port map
Add i2c port map for guybrush.
BUG=b:175593988
TEST=Build
BRANCH=None
Signed-off-by: Rob Barnes <robbarnes@google.com>
Change-Id: Ie78b0fa5d79c4add1776ddcb8a0ee14ec8b1618f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2590564
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,190 | 16.12.2020 16:22:53 | 28,800 | 6a6891121c0cda0d5c6b68e30f9ee40d60563f89 | virtual mux:Check pd task before waiting on task event
Booting with a DP/Thunderbolt/USB4 device, causes an assert. Hence,
moving the check just before waiting on task event
BRANCH=None
TEST=Able to enter into tbt on reboot | [
{
"change_type": "MODIFY",
"old_path": "driver/usb_mux/virtual.c",
"new_path": "driver/usb_mux/virtual.c",
"diff": "@@ -40,9 +40,6 @@ static inline void virtual_mux_update_state(int port, mux_state_t mux_state)\nif (!IS_ENABLED(CONFIG_USB_MUX_AP_ACK_REQUEST))\nreturn;\n- /* This should only be calle... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | virtual mux:Check pd task before waiting on task event
Booting with a DP/Thunderbolt/USB4 device, causes an assert. Hence,
moving the check just before waiting on task event
BUG=b:175806234
BRANCH=None
TEST=Able to enter into tbt on reboot
Signed-off-by: Ayushee Shah <ayushee.shah@intel.com>
Change-Id: If7bfcad18a07bb2879da018847c1716a21ba5737
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2596426
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,443 | 25.02.2020 17:35:00 | 0 | 9525e651c45b5e7ea94e742c51239966f71ea36e | gpio: Fix documentation
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/gpio.wrap",
"new_path": "include/gpio.wrap",
"diff": "/**\n* @def GPIO\n- * @brief The GPIO macro is used to define a new GPIO pin name and function.\n+ * @brief The GPIO macro defines a GPIO pin name and function.\n*\n* The name is used to populate th... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gpio: Fix documentation
BRANCH=none
BUG=none
TEST=none
Change-Id: Ibd6581dbc0a8219cfb55848c7b00d564191148ff
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2072447
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,208 | 17.12.2020 10:47:22 | -28,800 | 2cf881abe17a5f927479b9b197e4fbca7b80ae8e | asurada: do not disable AP_EC_WATCHDOG_L irq at boot
To correctly capture the signal.
TEST=ensure EC receiving AP_EC_WATCHDOG_L signal when reboot in AP
BRANCH=main | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "@@ -129,9 +129,7 @@ __override void board_hibernate_late(void)\nconst struct power_signal_info power_signal_list[] = {\n{GPIO_PMIC_EC_PWRGD, POWER_SIGNAL_ACTIVE_HIGH, \"PMIC_PWR_GOOD\"},\n{G... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: do not disable AP_EC_WATCHDOG_L irq at boot
To correctly capture the signal.
BUG=b:174109011
TEST=ensure EC receiving AP_EC_WATCHDOG_L signal when reboot in AP
BRANCH=main
Change-Id: Ibb96149ae8dc4c5c48f1deeb3508b0c50ddea09a
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2596563
Reviewed-by: Dino Li <Dino.Li@ite.com.tw>
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,427 | 17.12.2020 05:55:59 | 25,200 | 10b5f5f06a7574ac0f60d8ff09c8c774d02ed0e7 | TCPMv2: Add debug printing for PRL flags
BRANCH=none
TEST=make run-usb_tcpmv2_compliance | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_prl_sm.c",
"new_path": "common/usbc/usb_prl_sm.c",
"diff": "#define CPRINTS(format, args...)\n#endif\n-#define RCH_SET_FLAG(port, flag) atomic_or(&rch[port].flags, (flag))\n-#define RCH_CLR_FLAG(port, flag) atomic_clear_bits(&rch[port].flags, (... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Add debug printing for PRL flags
BUG=none
BRANCH=none
TEST=make run-usb_tcpmv2_compliance
Change-Id: I82e427d3e84138d9f9341679d21410ee6cd1ba28
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2595544
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,324 | 16.12.2020 17:01:27 | 25,200 | ca428f8a39ebf54a53d33a566d72270f7dc58b3e | genvif: cleanup for Supports_USB_Data
BRANCH=none
TEST=verify XML output
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "test/genvif/vif/exp_test_over_vif.xml",
"new_path": "test/genvif/vif/exp_test_over_vif.xml",
"diff": "<FR_Swap_Type_C_Current_Capability_As_Initial_Sink value=\"0\">FR_Swap not supported</FR_Swap_Type_C_Current_Capability_As_Initial_Sink>\n<Master_Port value=\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | genvif: cleanup for Supports_USB_Data
BUG=b:149852735
BRANCH=none
TEST=verify XML output
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I982dce6ecaa8cd5db7cfb15a70c7e30813dfb190
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2596837
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org> |
136,219 | 14.12.2020 11:59:49 | 25,200 | 53af9d188fb7e714623d4ebd4e78e83090c09e74 | zephyr: Enable isl9241 for Volteer
Add configs and build rules to enable this driver. A few issues are left
to clean up later.
BRANCH=none
TEST=build for volteer | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/isl9241.c",
"new_path": "driver/charger/isl9241.c",
"diff": "* Renesas (Intersil) ISL-9241 battery charger driver.\n*/\n+/* TODO(b/175881324) */\n+#ifndef CONFIG_ZEPHYR\n#include \"adc.h\"\n+#endif\n#include \"battery.h\"\n#include \"battery_sma... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: Enable isl9241 for Volteer
Add configs and build rules to enable this driver. A few issues are left
to clean up later.
BUG=b:175248556
BRANCH=none
TEST=build for volteer
Change-Id: If2c5427d016ae8cddcc25926668011aa11673091
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2589562
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,219 | 17.12.2020 11:53:06 | 25,200 | 2a7ab1df82ff20a22a938947e6bb7bd6f5a92c3f | zephyr: Define an empty adc.h for now
While we wait for an ADC shim, define this enum so that the code at
least compiles.
BRANCH=none
TEST=build zephyr for volteer | [
{
"change_type": "MODIFY",
"old_path": "include/adc.h",
"new_path": "include/adc.h",
"diff": "#define ADC_READ_ERROR -1 /* Value returned by adc_read_channel() on error */\n+#ifdef CONFIG_ZEPHYR\n+/* TODO(b/175881324): Add a shim for ADC */\n+enum adc_channel {\n+ ADC_NONE,\n+};\n+#endif\n+\n/*\n* B... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zephyr: Define an empty adc.h for now
While we wait for an ADC shim, define this enum so that the code at
least compiles.
BUG=b:175881324
BRANCH=none
TEST=build zephyr for volteer
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I688e313afd78a0953c3e03da6a8039ae3112afdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2595219
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,219 | 17.12.2020 12:48:38 | 25,200 | c6592056e0c3cf2288df86be8efb94784986fffa | driver: ppc: Drop paths from driver/ppc files
These paths don't seem to be necessary and don't currently work with
Zephyr. Drop them.
BRANCH=none
TEST=build zephyr for volteer
emerge-volteer -q chromeos-ec | [
{
"change_type": "MODIFY",
"old_path": "driver/ppc/aoz1380.c",
"new_path": "driver/ppc/aoz1380.c",
"diff": "#include \"atomic.h\"\n#include \"common.h\"\n#include \"console.h\"\n-#include \"driver/ppc/aoz1380.h\"\n+#include \"aoz1380.h\"\n#include \"hooks.h\"\n#include \"system.h\"\n#include \"tcpm.... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: ppc: Drop paths from driver/ppc files
These paths don't seem to be necessary and don't currently work with
Zephyr. Drop them.
BUG=b:175434113
BRANCH=none
TEST=build zephyr for volteer
emerge-volteer -q chromeos-ec
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I482a4a701265631439e3302c4a360e4cb5dba051
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2595220
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.