url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/7169
7,169
JSON lines with missing columns raise CastError
JSON lines with missing columns raise CastError: > CastError: Couldn't cast ... to ... because column names don't match Related to: - #7159 - #7161
closed
2024-09-25T04:43:28
https://api.github.com/repos/huggingface/datasets/issues/7169/comments
null
false
JSON lines with missing columns raise CastError JSON lines with missing columns raise CastError: > CastError: Couldn't cast ... to ... because column names don't match Related to: - #7159 - #7161
[]
https://api.github.com/repos/huggingface/datasets/issues/7168
7,168
sd1.5 diffusers controlnet training script gives new error
### Describe the bug This will randomly pop up during training now ``` Traceback (most recent call last): File "/workspace/diffusers/examples/controlnet/train_controlnet.py", line 1192, in <module> main(args) File "/workspace/diffusers/examples/controlnet/train_controlnet.py", line 1041, in main ...
closed
2024-09-25T01:42:49
https://api.github.com/repos/huggingface/datasets/issues/7168/comments
null
false
sd1.5 diffusers controlnet training script gives new error ### Describe the bug This will randomly pop up during training now ``` Traceback (most recent call last): File "/workspace/diffusers/examples/controlnet/train_controlnet.py", line 1192, in <module> main(args) File "/workspace/diffusers/example...
[ "not sure why the issue is formatting oddly", "I guess this is a dupe of\r\n\r\nhttps://github.com/huggingface/datasets/issues/7071", "this turned out to be because of a bad image in dataset", "@Night1099 could you spiecify what exactly was wrong with your image in the dataset? I think im facing the same issu...
https://api.github.com/repos/huggingface/datasets/issues/7167
7,167
Error Mapping on sd3, sdxl and upcoming flux controlnet training scripts in diffusers
### Describe the bug ``` Map: 6%|██████ | 8000/138120 [19:27<5:16:36, 6.85 examples/s] Traceback (most recent call last): File "/workspace/diffusers/examples/controlnet/train_controlnet_sd3.py", line 1416, in <mod...
closed
2024-09-25T01:39:51
https://api.github.com/repos/huggingface/datasets/issues/7167/comments
null
false
Error Mapping on sd3, sdxl and upcoming flux controlnet training scripts in diffusers ### Describe the bug ``` Map: 6%|██████ | 8000/138120 [19:27<5:16:36, 6.85 examples/s] Traceback (most recent call last): File ...
[ "this is happening on large datasets, if anyone happens upon this i was able to fix by changing\r\n\r\n```\r\ntrain_dataset = train_dataset.map(compute_embeddings_fn, batched=True, new_fingerprint=new_fingerprint)\r\n```\r\n\r\nto\r\n\r\n```\r\ntrain_dataset = train_dataset.map(compute_embeddings_fn, batched=True, ...
https://api.github.com/repos/huggingface/datasets/issues/7166
7,166
fix docstring code example for distributed shuffle
close https://github.com/huggingface/datasets/issues/7163
closed
2024-09-24T14:39:54
https://api.github.com/repos/huggingface/datasets/issues/7166/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7166", "html_url": "https://github.com/huggingface/datasets/pull/7166", "diff_url": "https://github.com/huggingface/datasets/pull/7166.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7166.patch", "merged_at": "2024-09-24T14:40...
true
fix docstring code example for distributed shuffle close https://github.com/huggingface/datasets/issues/7163
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7166). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7165
7,165
fix increase_load_count
it was failing since 3.0 and therefore not updating download counts on HF or in our dashboard
closed
2024-09-24T10:14:40
https://api.github.com/repos/huggingface/datasets/issues/7165/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7165", "html_url": "https://github.com/huggingface/datasets/pull/7165", "diff_url": "https://github.com/huggingface/datasets/pull/7165.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7165.patch", "merged_at": "2024-09-24T13:48...
true
fix increase_load_count it was failing since 3.0 and therefore not updating download counts on HF or in our dashboard
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7165). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "I tested a few load_dataset and they do show up in download stats now", "Thanks for h...
https://api.github.com/repos/huggingface/datasets/issues/7164
7,164
fsspec.exceptions.FSTimeoutError when downloading dataset
### Describe the bug I am trying to download the `librispeech_asr` `clean` dataset, which results in a `FSTimeoutError` exception after downloading around 61% of the data. ### Steps to reproduce the bug ``` import datasets datasets.load_dataset("librispeech_asr", "clean") ``` The output is as follows: > Dow...
closed
2024-09-24T08:45:05
https://api.github.com/repos/huggingface/datasets/issues/7164/comments
null
false
fsspec.exceptions.FSTimeoutError when downloading dataset ### Describe the bug I am trying to download the `librispeech_asr` `clean` dataset, which results in a `FSTimeoutError` exception after downloading around 61% of the data. ### Steps to reproduce the bug ``` import datasets datasets.load_dataset("librispeech...
[ "Hi ! If you check the dataset loading script [here](https://huggingface.co/datasets/openslr/librispeech_asr/blob/main/librispeech_asr.py) you'll see that it downloads the data from OpenSLR, and apparently their storage has timeout issues. It would be great to ultimately host the dataset on Hugging Face instead.\r\...
https://api.github.com/repos/huggingface/datasets/issues/7163
7,163
Set explicit seed in iterable dataset ddp shuffling example
### Describe the bug In the examples section of the iterable dataset docs https://huggingface.co/docs/datasets/en/package_reference/main_classes#datasets.IterableDataset the ddp example shuffles without seeding ```python from datasets.distributed import split_dataset_by_node ids = ds.to_iterable_dataset(num_sh...
closed
2024-09-23T11:34:06
https://api.github.com/repos/huggingface/datasets/issues/7163/comments
null
false
Set explicit seed in iterable dataset ddp shuffling example ### Describe the bug In the examples section of the iterable dataset docs https://huggingface.co/docs/datasets/en/package_reference/main_classes#datasets.IterableDataset the ddp example shuffles without seeding ```python from datasets.distributed impo...
[ "thanks for reporting !" ]
https://api.github.com/repos/huggingface/datasets/issues/7162
7,162
Support JSON lines with empty struct
Support JSON lines with empty struct. Fix #7161. Related to: - #7160
closed
2024-09-23T11:16:12
https://api.github.com/repos/huggingface/datasets/issues/7162/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7162", "html_url": "https://github.com/huggingface/datasets/pull/7162", "diff_url": "https://github.com/huggingface/datasets/pull/7162.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7162.patch", "merged_at": "2024-09-23T11:30...
true
Support JSON lines with empty struct Support JSON lines with empty struct. Fix #7161. Related to: - #7160
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7162). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7161
7,161
JSON lines with empty struct raise ArrowTypeError
JSON lines with empty struct raise ArrowTypeError: struct fields don't match or are in the wrong order See example: https://huggingface.co/datasets/wikimedia/structured-wikipedia/discussions/5 > ArrowTypeError: struct fields don't match or are in the wrong order: Input fields: struct<> output fields: struct<pov_c...
closed
2024-09-23T08:48:56
https://api.github.com/repos/huggingface/datasets/issues/7161/comments
null
false
JSON lines with empty struct raise ArrowTypeError JSON lines with empty struct raise ArrowTypeError: struct fields don't match or are in the wrong order See example: https://huggingface.co/datasets/wikimedia/structured-wikipedia/discussions/5 > ArrowTypeError: struct fields don't match or are in the wrong order: ...
[]
https://api.github.com/repos/huggingface/datasets/issues/7160
7,160
Support JSON lines with missing struct fields
Support JSON lines with missing struct fields. Fix #7159. The implemented test raised: ``` TypeError: Couldn't cast array of type struct<age: int64> to {'age': Value(dtype='int32', id=None), 'name': Value(dtype='string', id=None)} ```
closed
2024-09-23T08:04:09
https://api.github.com/repos/huggingface/datasets/issues/7160/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7160", "html_url": "https://github.com/huggingface/datasets/pull/7160", "diff_url": "https://github.com/huggingface/datasets/pull/7160.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7160.patch", "merged_at": "2024-09-23T11:09...
true
Support JSON lines with missing struct fields Support JSON lines with missing struct fields. Fix #7159. The implemented test raised: ``` TypeError: Couldn't cast array of type struct<age: int64> to {'age': Value(dtype='int32', id=None), 'name': Value(dtype='string', id=None)} ```
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7160). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7159
7,159
JSON lines with missing struct fields raise TypeError: Couldn't cast array
JSON lines with missing struct fields raise TypeError: Couldn't cast array of type. See example: https://huggingface.co/datasets/wikimedia/structured-wikipedia/discussions/5 One would expect that the struct missing fields are added with null values.
closed
2024-09-23T07:57:58
https://api.github.com/repos/huggingface/datasets/issues/7159/comments
null
false
JSON lines with missing struct fields raise TypeError: Couldn't cast array JSON lines with missing struct fields raise TypeError: Couldn't cast array of type. See example: https://huggingface.co/datasets/wikimedia/structured-wikipedia/discussions/5 One would expect that the struct missing fields are added with nu...
[ "Hello,\r\n\r\nI have still the same issue when loading the dataset with the new version:\r\n[https://huggingface.co/datasets/wikimedia/structured-wikipedia/discussions/5](https://huggingface.co/datasets/wikimedia/structured-wikipedia/discussions/5)\r\n\r\nI have downloaded and unzipped the wikimedia/structured-wik...
https://api.github.com/repos/huggingface/datasets/issues/7158
7,158
google colab ex
null
closed
2024-09-23T03:29:50
https://api.github.com/repos/huggingface/datasets/issues/7158/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7158", "html_url": "https://github.com/huggingface/datasets/pull/7158", "diff_url": "https://github.com/huggingface/datasets/pull/7158.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7158.patch", "merged_at": null }
true
google colab ex
[]
https://api.github.com/repos/huggingface/datasets/issues/7157
7,157
Fix zero proba interleave datasets
fix https://github.com/huggingface/datasets/issues/7147
closed
2024-09-21T15:19:14
https://api.github.com/repos/huggingface/datasets/issues/7157/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7157", "html_url": "https://github.com/huggingface/datasets/pull/7157", "diff_url": "https://github.com/huggingface/datasets/pull/7157.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7157.patch", "merged_at": null }
true
Fix zero proba interleave datasets fix https://github.com/huggingface/datasets/issues/7147
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7157). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7156
7,156
interleave_datasets resets shuffle state
### Describe the bug ``` import datasets import torch.utils.data def gen(shards): yield {"shards": shards} def main(): dataset = datasets.IterableDataset.from_generator( gen, gen_kwargs={'shards': list(range(25))} ) dataset = dataset.shuffle(buffer_size=1) dataset...
open
2024-09-20T17:57:54
https://api.github.com/repos/huggingface/datasets/issues/7156/comments
null
false
interleave_datasets resets shuffle state ### Describe the bug ``` import datasets import torch.utils.data def gen(shards): yield {"shards": shards} def main(): dataset = datasets.IterableDataset.from_generator( gen, gen_kwargs={'shards': list(range(25))} ) dataset = da...
[ "It also does preserve `split_by_node`, so in the meantime you should call `shuffle` or `split_by_node` AFTER `interleave_datasets` or `concatenate_datasets`" ]
https://api.github.com/repos/huggingface/datasets/issues/7155
7,155
Dataset viewer not working! Failure due to more than 32 splits.
Hello guys, I have a dataset and I didn't know I couldn't upload more than 32 splits. Now, my dataset viewer is not working. I don't have the dataset locally on my node anymore and recreating would take a week. And I have to publish the dataset coming Monday. I read about the practice, how I can resolve it and avoi...
closed
2024-09-18T12:43:21
https://api.github.com/repos/huggingface/datasets/issues/7155/comments
null
false
Dataset viewer not working! Failure due to more than 32 splits. Hello guys, I have a dataset and I didn't know I couldn't upload more than 32 splits. Now, my dataset viewer is not working. I don't have the dataset locally on my node anymore and recreating would take a week. And I have to publish the dataset coming ...
[ "I have fixed it! But I would appreciate a new feature wheere I could iterate over and see what each file looks like. " ]
https://api.github.com/repos/huggingface/datasets/issues/7154
7,154
Support ndjson data files
Support `ndjson` (Newline Delimited JSON) data files. Fix #7153.
closed
2024-09-18T06:10:10
https://api.github.com/repos/huggingface/datasets/issues/7154/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7154", "html_url": "https://github.com/huggingface/datasets/pull/7154", "diff_url": "https://github.com/huggingface/datasets/pull/7154.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7154.patch", "merged_at": "2024-09-19T11:25...
true
Support ndjson data files Support `ndjson` (Newline Delimited JSON) data files. Fix #7153.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7154). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Thanks for your review, @severo.\r\n\r\nYes, I was aware of this. From internal convers...
https://api.github.com/repos/huggingface/datasets/issues/7153
7,153
Support data files with .ndjson extension
### Feature request Support data files with `.ndjson` extension. ### Motivation We already support data files with `.jsonl` extension. ### Your contribution I am opening a PR.
closed
2024-09-18T05:54:45
https://api.github.com/repos/huggingface/datasets/issues/7153/comments
null
false
Support data files with .ndjson extension ### Feature request Support data files with `.ndjson` extension. ### Motivation We already support data files with `.jsonl` extension. ### Your contribution I am opening a PR.
[]
https://api.github.com/repos/huggingface/datasets/issues/7151
7,151
Align filename prefix splitting with WebDataset library
Align filename prefix splitting with WebDataset library. This PR uses the same `base_plus_ext` function as the one used by the `webdataset` library. Fix #7150. Related to #7144.
closed
2024-09-16T06:07:39
https://api.github.com/repos/huggingface/datasets/issues/7151/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7151", "html_url": "https://github.com/huggingface/datasets/pull/7151", "diff_url": "https://github.com/huggingface/datasets/pull/7151.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7151.patch", "merged_at": "2024-09-16T15:26...
true
Align filename prefix splitting with WebDataset library Align filename prefix splitting with WebDataset library. This PR uses the same `base_plus_ext` function as the one used by the `webdataset` library. Fix #7150. Related to #7144.
[]
https://api.github.com/repos/huggingface/datasets/issues/7150
7,150
WebDataset loader splits keys differently than WebDataset library
As reported by @ragavsachdeva (see discussion here: https://github.com/huggingface/datasets/pull/7144#issuecomment-2348307792), our webdataset loader is not aligned with the `webdataset` library when splitting keys from filenames. For example, we get a different key splitting for filename `/some/path/22.0/1.1.png`: ...
closed
2024-09-16T06:02:47
https://api.github.com/repos/huggingface/datasets/issues/7150/comments
null
false
WebDataset loader splits keys differently than WebDataset library As reported by @ragavsachdeva (see discussion here: https://github.com/huggingface/datasets/pull/7144#issuecomment-2348307792), our webdataset loader is not aligned with the `webdataset` library when splitting keys from filenames. For example, we get ...
[]
https://api.github.com/repos/huggingface/datasets/issues/7149
7,149
Datasets Unknown Keyword Argument Error - task_templates
### Describe the bug Issue ```python from datasets import load_dataset examples = load_dataset('facebook/winoground', use_auth_token=<YOUR USER ACCESS TOKEN>) ``` Gives error ``` TypeError: DatasetInfo.__init__() got an unexpected keyword argument 'task_templates' ``` A simple downgrade to lower `data...
closed
2024-09-13T10:30:57
https://api.github.com/repos/huggingface/datasets/issues/7149/comments
null
false
Datasets Unknown Keyword Argument Error - task_templates ### Describe the bug Issue ```python from datasets import load_dataset examples = load_dataset('facebook/winoground', use_auth_token=<YOUR USER ACCESS TOKEN>) ``` Gives error ``` TypeError: DatasetInfo.__init__() got an unexpected keyword argument '...
[ "Thanks, for reporting.\r\n\r\nWe have been fixing most Hub datasets to remove the deprecated (and now non-supported) task templates, but we missed the \"facebook/winoground\".\r\n\r\nIt is fixed now: https://huggingface.co/datasets/facebook/winoground/discussions/8\r\n\r\n", "Hello @albertvillanova \r\n\r\nI got...
https://api.github.com/repos/huggingface/datasets/issues/7148
7,148
Bug: Error when downloading mteb/mtop_domain
### Describe the bug When downloading the dataset "mteb/mtop_domain", ran into the following error: ``` Traceback (most recent call last): File "/share/project/xzy/test/test_download.py", line 3, in <module> data = load_dataset("mteb/mtop_domain", "en", trust_remote_code=True) File "/opt/conda/lib/pytho...
closed
2024-09-13T04:09:39
https://api.github.com/repos/huggingface/datasets/issues/7148/comments
null
false
Bug: Error when downloading mteb/mtop_domain ### Describe the bug When downloading the dataset "mteb/mtop_domain", ran into the following error: ``` Traceback (most recent call last): File "/share/project/xzy/test/test_download.py", line 3, in <module> data = load_dataset("mteb/mtop_domain", "en", trust_re...
[ "Could you please try with `force_redownload` instead?\r\nEDIT:\r\n```python\r\ndata = load_dataset(\"mteb/mtop_domain\", \"en\", download_mode=\"force_redownload\")\r\n```", "Seems the error is still there", "I am not able to reproduce the issue:\r\n```python\r\nIn [1]: from datasets import load_dataset\r\n\r\...
https://api.github.com/repos/huggingface/datasets/issues/7147
7,147
IterableDataset strange deadlock
### Describe the bug ``` import datasets import torch.utils.data num_shards = 1024 def gen(shards): for shard in shards: if shard < 25: yield {"shard": shard} def main(): dataset = datasets.IterableDataset.from_generator( gen, gen_kwargs={"shards": lis...
closed
2024-09-12T18:59:33
https://api.github.com/repos/huggingface/datasets/issues/7147/comments
null
false
IterableDataset strange deadlock ### Describe the bug ``` import datasets import torch.utils.data num_shards = 1024 def gen(shards): for shard in shards: if shard < 25: yield {"shard": shard} def main(): dataset = datasets.IterableDataset.from_generator( gen, ...
[ "Yes `interleave_datasets` seems to have an issue with shuffling, could you open a new issue on this ?\r\n\r\nThen regarding the deadlock, it has to do with interleave_dataset with probabilities=[1, 0] with workers that may contain an empty dataset in first position (it can be empty since you distribute 1024 shard ...
https://api.github.com/repos/huggingface/datasets/issues/7146
7,146
Set dev version
null
closed
2024-09-11T13:53:27
https://api.github.com/repos/huggingface/datasets/issues/7146/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7146", "html_url": "https://github.com/huggingface/datasets/pull/7146", "diff_url": "https://github.com/huggingface/datasets/pull/7146.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7146.patch", "merged_at": "2024-09-12T04:34...
true
Set dev version
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7146). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7145
7,145
Release: 3.0.0
null
closed
2024-09-11T13:41:47
https://api.github.com/repos/huggingface/datasets/issues/7145/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7145", "html_url": "https://github.com/huggingface/datasets/pull/7145", "diff_url": "https://github.com/huggingface/datasets/pull/7145.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7145.patch", "merged_at": "2024-09-11T13:48...
true
Release: 3.0.0
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7145). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7144
7,144
Fix key error in webdataset
I was running into ``` example[field_name] = {"path": example["__key__"] + "." + field_name, "bytes": example[field_name]} KeyError: 'png' ``` The issue is that a filename may have multiple "." e.g. `22.05.png`. Changing `split` to `rsplit` fixes it. Related https://github.com/huggingface/datasets/issues/68...
closed
2024-09-11T10:50:17
https://api.github.com/repos/huggingface/datasets/issues/7144/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7144", "html_url": "https://github.com/huggingface/datasets/pull/7144", "diff_url": "https://github.com/huggingface/datasets/pull/7144.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7144.patch", "merged_at": null }
true
Fix key error in webdataset I was running into ``` example[field_name] = {"path": example["__key__"] + "." + field_name, "bytes": example[field_name]} KeyError: 'png' ``` The issue is that a filename may have multiple "." e.g. `22.05.png`. Changing `split` to `rsplit` fixes it. Related https://github.com/hu...
[ "hi ! What version of `datasets` are you using ? Is this issue also happening with `datasets==3.0.0` ?\r\nAsking because we made sure to replicate the official webdataset logic, which is to use the latest dot as separator between the sample base name and the key", "Hi, yes this is still a problem on `datasets==3....
https://api.github.com/repos/huggingface/datasets/issues/7143
7,143
Modify add_column() to optionally accept a FeatureType as param
Fix #7142. **Before (Add + Cast)**: ``` from datasets import load_dataset, Value ds = load_dataset("rotten_tomatoes", split="test") lst = [i for i in range(len(ds))] ds = ds.add_column("new_col", lst) # Assigns int64 to new_col by default print(ds.features) ds = ds.cast_column("new_col", Value(dtype="u...
closed
2024-09-08T10:56:57
https://api.github.com/repos/huggingface/datasets/issues/7143/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7143", "html_url": "https://github.com/huggingface/datasets/pull/7143", "diff_url": "https://github.com/huggingface/datasets/pull/7143.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7143.patch", "merged_at": "2024-09-16T15:11...
true
Modify add_column() to optionally accept a FeatureType as param Fix #7142. **Before (Add + Cast)**: ``` from datasets import load_dataset, Value ds = load_dataset("rotten_tomatoes", split="test") lst = [i for i in range(len(ds))] ds = ds.add_column("new_col", lst) # Assigns int64 to new_col by default pri...
[ "Requesting review @lhoestq \r\nI will also update the docs if this looks good.", "Cool ! maybe you can rename the argument `feature` and with type `FeatureType` ? This way it would work the same way as `.cast_column()` ?", "@lhoestq Since there is no way to get a `pyarrow.Schema` from a `FeatureType`, I had to...
https://api.github.com/repos/huggingface/datasets/issues/7142
7,142
Specifying datatype when adding a column to a dataset.
### Feature request There should be a way to specify the datatype of a column in `datasets.add_column()`. ### Motivation To specify a custom datatype, we have to use `datasets.add_column()` followed by `datasets.cast_column()` which is slow for large datasets. Another workaround is to pass a `numpy.array()` of desi...
closed
2024-09-08T07:34:24
https://api.github.com/repos/huggingface/datasets/issues/7142/comments
null
false
Specifying datatype when adding a column to a dataset. ### Feature request There should be a way to specify the datatype of a column in `datasets.add_column()`. ### Motivation To specify a custom datatype, we have to use `datasets.add_column()` followed by `datasets.cast_column()` which is slow for large datasets. ...
[ "#self-assign" ]
https://api.github.com/repos/huggingface/datasets/issues/7141
7,141
Older datasets throwing safety errors with 2.21.0
### Describe the bug The dataset loading was throwing some safety errors for this popular dataset `wmt14`. [in]: ``` import datasets # train_data = datasets.load_dataset("wmt14", "de-en", split="train") train_data = datasets.load_dataset("wmt14", "de-en", split="train") val_data = datasets.load_dataset(...
closed
2024-09-06T16:26:30
https://api.github.com/repos/huggingface/datasets/issues/7141/comments
null
false
Older datasets throwing safety errors with 2.21.0 ### Describe the bug The dataset loading was throwing some safety errors for this popular dataset `wmt14`. [in]: ``` import datasets # train_data = datasets.load_dataset("wmt14", "de-en", split="train") train_data = datasets.load_dataset("wmt14", "de-en",...
[ "I am also getting this error with this dataset: https://huggingface.co/datasets/google/IFEval", "Me too, didn't have this issue few hours ago.", "same observation. I even downgraded `datasets==2.20.0` and `huggingface_hub==0.23.5` leading me to believe it's an issue on the server.\r\n\r\nany known workarounds?...
https://api.github.com/repos/huggingface/datasets/issues/7139
7,139
Use load_dataset to load imagenet-1K But find a empty dataset
### Describe the bug ```python def get_dataset(data_path, train_folder="train", val_folder="val"): traindir = os.path.join(data_path, train_folder) valdir = os.path.join(data_path, val_folder) def transform_val_examples(examples): transform = Compose([ Resize(256), ...
open
2024-09-05T15:12:22
https://api.github.com/repos/huggingface/datasets/issues/7139/comments
null
false
Use load_dataset to load imagenet-1K But find a empty dataset ### Describe the bug ```python def get_dataset(data_path, train_folder="train", val_folder="val"): traindir = os.path.join(data_path, train_folder) valdir = os.path.join(data_path, val_folder) def transform_val_examples(examples): ...
[ "Imagenet-1k is a gated dataset which means you’ll have to agree to share your contact info to access it. Have you tried this yet? Once you have, you can sign in with your user token (you can find this in your Hugging Face account settings) when prompted by running.\r\n\r\n```\r\nhuggingface-cli login\r\ntrain_set...
https://api.github.com/repos/huggingface/datasets/issues/7138
7,138
Cache only changed columns?
### Feature request Cache only the actual changes to the dataset i.e. changed columns. ### Motivation I realized that caching actually saves the complete dataset again. This is especially problematic for image datasets if one wants to only change another column e.g. some metadata and then has to save 5 TB again. #...
open
2024-09-05T12:56:47
https://api.github.com/repos/huggingface/datasets/issues/7138/comments
null
false
Cache only changed columns? ### Feature request Cache only the actual changes to the dataset i.e. changed columns. ### Motivation I realized that caching actually saves the complete dataset again. This is especially problematic for image datasets if one wants to only change another column e.g. some metadata and the...
[ "so I guess a workaround to this is to simply remove all columns except the ones to cache and then add them back with `concatenate_datasets(..., axis=1)`.", "yes this is the right workaround. We're keeping the cache like this to make it easier for people to delete intermediate cache files" ]
https://api.github.com/repos/huggingface/datasets/issues/7137
7,137
[BUG] dataset_info sequence unexpected behavior in README.md YAML
### Describe the bug When working on `dataset_info` yaml, I find my data column with format `list[dict[str, str]]` cannot be coded correctly. My data looks like ``` {"answers":[{"text": "ADDRESS", "label": "abc"}]} ``` My `dataset_info` in README.md is: ``` dataset_info: - config_name: default feature...
closed
2024-09-05T06:06:06
https://api.github.com/repos/huggingface/datasets/issues/7137/comments
null
false
[BUG] dataset_info sequence unexpected behavior in README.md YAML ### Describe the bug When working on `dataset_info` yaml, I find my data column with format `list[dict[str, str]]` cannot be coded correctly. My data looks like ``` {"answers":[{"text": "ADDRESS", "label": "abc"}]} ``` My `dataset_info` in RE...
[ "The non-sequence case works well (`dict[str, str]` instead of `list[dict[str, str]]`), which makes me believe it shall be a bug for `sequence` and my proposed behavior shall be expected.\r\n```\r\ndataset_info:\r\n- config_name: default\r\n features:\r\n - name: answers\r\n dtype:\r\n - name: text\r\n ...
https://api.github.com/repos/huggingface/datasets/issues/7136
7,136
Do not consume unnecessary memory during sharding
When sharding `IterableDataset`s, a temporary list is created that is then indexed. There is no need to create a temporary list of a potentially very large step/world size, with standard `islice` functionality, so we avoid it. ```shell pytest tests/test_distributed.py -k iterable ``` Runs successfully.
open
2024-09-04T19:26:06
https://api.github.com/repos/huggingface/datasets/issues/7136/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7136", "html_url": "https://github.com/huggingface/datasets/pull/7136", "diff_url": "https://github.com/huggingface/datasets/pull/7136.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7136.patch", "merged_at": null }
true
Do not consume unnecessary memory during sharding When sharding `IterableDataset`s, a temporary list is created that is then indexed. There is no need to create a temporary list of a potentially very large step/world size, with standard `islice` functionality, so we avoid it. ```shell pytest tests/test_distributed....
[]
https://api.github.com/repos/huggingface/datasets/issues/7135
7,135
Bug: Type Mismatch in Dataset Mapping
# Issue: Type Mismatch in Dataset Mapping ## Description There is an issue with the `map` function in the `datasets` library where the mapped output does not reflect the expected type change. After applying a mapping function to convert an integer label to a string, the resulting type remains an integer instead of ...
open
2024-09-03T16:37:01
https://api.github.com/repos/huggingface/datasets/issues/7135/comments
null
false
Bug: Type Mismatch in Dataset Mapping # Issue: Type Mismatch in Dataset Mapping ## Description There is an issue with the `map` function in the `datasets` library where the mapped output does not reflect the expected type change. After applying a mapping function to convert an integer label to a string, the resulti...
[ "By the way, following code is working. This show the inconsistentcy.\r\n```python\r\nfrom datasets import Dataset\r\n\r\n# Original data\r\ndata = {\r\n 'text': ['Hello', 'world', 'this', 'is', 'a', 'test'],\r\n 'label': [0, 1, 0, 1, 1, 0]\r\n}\r\n\r\n# Creating a Dataset object\r\ndataset = Dataset.from_dic...
https://api.github.com/repos/huggingface/datasets/issues/7134
7,134
Attempting to return a rank 3 grayscale image from dataset.map results in extreme slowdown
### Describe the bug Background: Digital images are often represented as a (Height, Width, Channel) tensor. This is the same for huggingface datasets that contain images. These images are loaded in Pillow containers which offer, for example, the `.convert` method. I can convert an image from a (H,W,3) shape to a...
open
2024-09-01T13:55:41
https://api.github.com/repos/huggingface/datasets/issues/7134/comments
null
false
Attempting to return a rank 3 grayscale image from dataset.map results in extreme slowdown ### Describe the bug Background: Digital images are often represented as a (Height, Width, Channel) tensor. This is the same for huggingface datasets that contain images. These images are loaded in Pillow containers which of...
[]
https://api.github.com/repos/huggingface/datasets/issues/7133
7,133
remove filecheck to enable symlinks
Enables streaming from local symlinks #7083 @lhoestq
closed
2024-08-30T07:36:56
https://api.github.com/repos/huggingface/datasets/issues/7133/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7133", "html_url": "https://github.com/huggingface/datasets/pull/7133", "diff_url": "https://github.com/huggingface/datasets/pull/7133.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7133.patch", "merged_at": "2024-12-24T14:25...
true
remove filecheck to enable symlinks Enables streaming from local symlinks #7083 @lhoestq
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7133). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "The CI is failing, looks like it breaks imagefolder loading.\r\n\r\nI just checked fssp...
https://api.github.com/repos/huggingface/datasets/issues/7132
7,132
Fix data file module inference
I saved a dataset with two splits to disk with `DatasetDict.save_to_disk`. The train is bigger and ended up in 10 shards, whereas the test split only resulted in 1 split. Now when trying to load the dataset, an error is raised that not all splits have the same data format: > ValueError: Couldn't infer the same da...
open
2024-08-29T13:48:16
https://api.github.com/repos/huggingface/datasets/issues/7132/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7132", "html_url": "https://github.com/huggingface/datasets/pull/7132", "diff_url": "https://github.com/huggingface/datasets/pull/7132.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7132.patch", "merged_at": null }
true
Fix data file module inference I saved a dataset with two splits to disk with `DatasetDict.save_to_disk`. The train is bigger and ended up in 10 shards, whereas the test split only resulted in 1 split. Now when trying to load the dataset, an error is raised that not all splits have the same data format: > ValueEr...
[ "Hi ! datasets saved using `save_to_disk` should be loaded with `load_from_disk` ;)", "It is convienient to just pass in a path to a local dataset or one from the hub and use the same function to load it. Is it not possible to get this fix merged in to allow this? ", "We can modify `save_to_disk` to write the d...
https://api.github.com/repos/huggingface/datasets/issues/7129
7,129
Inconsistent output in documentation example: `num_classes` not displayed in `ClassLabel` output
In the documentation for [ClassLabel](https://huggingface.co/docs/datasets/v2.21.0/en/package_reference/main_classes#datasets.ClassLabel), there is an example of usage with the following code: ```` from datasets import Features features = Features({'label': ClassLabel(num_classes=3, names=['bad', 'ok', 'good'])}) ...
closed
2024-08-28T12:27:48
https://api.github.com/repos/huggingface/datasets/issues/7129/comments
null
false
Inconsistent output in documentation example: `num_classes` not displayed in `ClassLabel` output In the documentation for [ClassLabel](https://huggingface.co/docs/datasets/v2.21.0/en/package_reference/main_classes#datasets.ClassLabel), there is an example of usage with the following code: ```` from datasets import ...
[]
https://api.github.com/repos/huggingface/datasets/issues/7128
7,128
Filter Large Dataset Entry by Entry
### Feature request I am not sure if this is a new feature, but I wanted to post this problem here, and hear if others have ways of optimizing and speeding up this process. Let's say I have a really large dataset that I cannot load into memory. At this point, I am only aware of `streaming=True` to load the dataset....
open
2024-08-27T20:31:09
https://api.github.com/repos/huggingface/datasets/issues/7128/comments
null
false
Filter Large Dataset Entry by Entry ### Feature request I am not sure if this is a new feature, but I wanted to post this problem here, and hear if others have ways of optimizing and speeding up this process. Let's say I have a really large dataset that I cannot load into memory. At this point, I am only aware of `...
[ "Hi ! you can do\r\n\r\n```python\r\nfiltered_dataset = dataset.filter(filter_function)\r\n```\r\n\r\non a subset:\r\n\r\n```python\r\nfiltered_subset = dataset.select(range(10_000)).filter(filter_function)\r\n```\r\n", "Jumping on this as it seems relevant - when I use the `filter` method, it often results in an...
https://api.github.com/repos/huggingface/datasets/issues/7127
7,127
Caching shuffles by np.random.Generator results in unintiutive behavior
### Describe the bug Create a dataset. Save it to disk. Load from disk. Shuffle, usning a `np.random.Generator`. Iterate. Shuffle again. Iterate. The iterates are different since the supplied np.random.Generator has progressed between the shuffles. Load dataset from disk again. Shuffle and Iterate. See same result ...
open
2024-08-26T10:29:48
https://api.github.com/repos/huggingface/datasets/issues/7127/comments
null
false
Caching shuffles by np.random.Generator results in unintiutive behavior ### Describe the bug Create a dataset. Save it to disk. Load from disk. Shuffle, usning a `np.random.Generator`. Iterate. Shuffle again. Iterate. The iterates are different since the supplied np.random.Generator has progressed between the shuffles...
[ "I first thought this was a mistake of mine, and also posted on stack overflow. https://stackoverflow.com/questions/78913797/iterating-a-huggingface-dataset-from-disk-using-generator-seems-broken-how-to-d \r\n\r\nIt seems to me the issue is the caching step in \r\n\r\nhttps://github.com/huggingface/datasets/blob/be...
https://api.github.com/repos/huggingface/datasets/issues/7126
7,126
Disable implicit token in CI
Disable implicit token in CI. This PR allows running CI tests locally without implicitly using the local user HF token. For example, run locally the tests in: - #7124
closed
2024-08-26T05:29:46
https://api.github.com/repos/huggingface/datasets/issues/7126/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7126", "html_url": "https://github.com/huggingface/datasets/pull/7126", "diff_url": "https://github.com/huggingface/datasets/pull/7126.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7126.patch", "merged_at": "2024-08-26T05:59...
true
Disable implicit token in CI Disable implicit token in CI. This PR allows running CI tests locally without implicitly using the local user HF token. For example, run locally the tests in: - #7124
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7126). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7125
7,125
Fix wrong SHA in CI tests of HubDatasetModuleFactoryWithParquetExport
Fix wrong SHA in CI tests of HubDatasetModuleFactoryWithParquetExport.
closed
2024-08-26T05:09:35
https://api.github.com/repos/huggingface/datasets/issues/7125/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7125", "html_url": "https://github.com/huggingface/datasets/pull/7125", "diff_url": "https://github.com/huggingface/datasets/pull/7125.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7125.patch", "merged_at": "2024-08-26T05:27...
true
Fix wrong SHA in CI tests of HubDatasetModuleFactoryWithParquetExport Fix wrong SHA in CI tests of HubDatasetModuleFactoryWithParquetExport.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7125). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7124
7,124
Test get_dataset_config_info with non-existing/gated/private dataset
Test get_dataset_config_info with non-existing/gated/private dataset. Related to: - #7109 See also: - https://github.com/huggingface/dataset-viewer/pull/3037: https://github.com/huggingface/dataset-viewer/pull/3037/commits/bb1a7e00c53c242088597cab6572e4fd57797ecb
closed
2024-08-26T04:53:59
https://api.github.com/repos/huggingface/datasets/issues/7124/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7124", "html_url": "https://github.com/huggingface/datasets/pull/7124", "diff_url": "https://github.com/huggingface/datasets/pull/7124.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7124.patch", "merged_at": "2024-08-26T06:09...
true
Test get_dataset_config_info with non-existing/gated/private dataset Test get_dataset_config_info with non-existing/gated/private dataset. Related to: - #7109 See also: - https://github.com/huggingface/dataset-viewer/pull/3037: https://github.com/huggingface/dataset-viewer/pull/3037/commits/bb1a7e00c53c24208859...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7124). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7123
7,123
Make dataset viewer more flexible in displaying metadata alongside images
### Feature request To display images with their associated metadata in the dataset viewer, a `metadata.csv` file is required. In the case of a dataset with multiple subsets, this would require the CSVs to be contained in the same folder as the images since they all need to be named `metadata.csv`. The request is th...
open
2024-08-23T22:56:01
https://api.github.com/repos/huggingface/datasets/issues/7123/comments
null
false
Make dataset viewer more flexible in displaying metadata alongside images ### Feature request To display images with their associated metadata in the dataset viewer, a `metadata.csv` file is required. In the case of a dataset with multiple subsets, this would require the CSVs to be contained in the same folder as th...
[ "Note that you can already have one directory per subset just for the metadata, e.g.\r\n\r\n```\r\nconfigs:\r\n - config_name: subset0\r\n data_files:\r\n - subset0/metadata.csv\r\n - images/*.jpg\r\n - config_name: subset1\r\n data_files:\r\n - subset1/metadata.csv\r\n - images/*.jpg\r\...
https://api.github.com/repos/huggingface/datasets/issues/7122
7,122
[interleave_dataset] sample batches from a single source at a time
### Feature request interleave_dataset and [RandomlyCyclingMultiSourcesExamplesIterable](https://github.com/huggingface/datasets/blob/3813ce846e52824b38e53895810682f0a496a2e3/src/datasets/iterable_dataset.py#L816) enable us to sample data examples from different sources. But can we also sample batches in a similar man...
open
2024-08-23T07:21:15
https://api.github.com/repos/huggingface/datasets/issues/7122/comments
null
false
[interleave_dataset] sample batches from a single source at a time ### Feature request interleave_dataset and [RandomlyCyclingMultiSourcesExamplesIterable](https://github.com/huggingface/datasets/blob/3813ce846e52824b38e53895810682f0a496a2e3/src/datasets/iterable_dataset.py#L816) enable us to sample data examples from...
[]
https://api.github.com/repos/huggingface/datasets/issues/7121
7,121
Fix typed examples iterable state dict
fix https://github.com/huggingface/datasets/issues/7085 as noted by @VeryLazyBoy and reported by @AjayP13
closed
2024-08-22T14:45:03
https://api.github.com/repos/huggingface/datasets/issues/7121/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7121", "html_url": "https://github.com/huggingface/datasets/pull/7121", "diff_url": "https://github.com/huggingface/datasets/pull/7121.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7121.patch", "merged_at": "2024-08-22T14:49...
true
Fix typed examples iterable state dict fix https://github.com/huggingface/datasets/issues/7085 as noted by @VeryLazyBoy and reported by @AjayP13
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7121). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7120
7,120
don't mention the script if trust_remote_code=False
See https://huggingface.co/datasets/Omega02gdfdd/bioclip-demo-zero-shot-mistakes for example. The error is: ``` FileNotFoundError: Couldn't find a dataset script at /src/services/worker/Omega02gdfdd/bioclip-demo-zero-shot-mistakes/bioclip-demo-zero-shot-mistakes.py or any data file in the same directory. Couldn't f...
closed
2024-08-22T12:32:32
https://api.github.com/repos/huggingface/datasets/issues/7120/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7120", "html_url": "https://github.com/huggingface/datasets/pull/7120", "diff_url": "https://github.com/huggingface/datasets/pull/7120.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7120.patch", "merged_at": "2024-08-22T14:33...
true
don't mention the script if trust_remote_code=False See https://huggingface.co/datasets/Omega02gdfdd/bioclip-demo-zero-shot-mistakes for example. The error is: ``` FileNotFoundError: Couldn't find a dataset script at /src/services/worker/Omega02gdfdd/bioclip-demo-zero-shot-mistakes/bioclip-demo-zero-shot-mistakes.p...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7120). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Note that in this case, we could even expect this kind of message:\r\n\r\n```\r\nDataFi...
https://api.github.com/repos/huggingface/datasets/issues/7119
7,119
Install transformers with numpy-2 CI
Install transformers with numpy-2 CI. Note that transformers no longer pins numpy < 2 since transformers-4.43.0: - https://github.com/huggingface/transformers/pull/32018 - https://github.com/huggingface/transformers/releases/tag/v4.43.0
closed
2024-08-21T11:14:59
https://api.github.com/repos/huggingface/datasets/issues/7119/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7119", "html_url": "https://github.com/huggingface/datasets/pull/7119", "diff_url": "https://github.com/huggingface/datasets/pull/7119.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7119.patch", "merged_at": "2024-08-21T11:36...
true
Install transformers with numpy-2 CI Install transformers with numpy-2 CI. Note that transformers no longer pins numpy < 2 since transformers-4.43.0: - https://github.com/huggingface/transformers/pull/32018 - https://github.com/huggingface/transformers/releases/tag/v4.43.0
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7119). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7118
7,118
Allow numpy-2.1 and test it without audio extra
Allow numpy-2.1 and test it without audio extra. This PR reverts: - #7114 Note that audio extra tests can be included again with numpy-2.1 once next numba-0.61.0 version is released.
closed
2024-08-21T10:29:35
https://api.github.com/repos/huggingface/datasets/issues/7118/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7118", "html_url": "https://github.com/huggingface/datasets/pull/7118", "diff_url": "https://github.com/huggingface/datasets/pull/7118.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7118.patch", "merged_at": "2024-08-21T10:58...
true
Allow numpy-2.1 and test it without audio extra Allow numpy-2.1 and test it without audio extra. This PR reverts: - #7114 Note that audio extra tests can be included again with numpy-2.1 once next numba-0.61.0 version is released.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7118). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7117
7,117
Audio dataset load everything in RAM and is very slow
Hello, I'm working with an audio dataset. I want to transcribe the audio that the dataset contain, and for that I use whisper. My issue is that the dataset load everything in the RAM when I map the dataset, obviously, when RAM usage is too high, the program crashes. To fix this issue, I'm using writer_batch_size tha...
open
2024-08-20T21:18:12
https://api.github.com/repos/huggingface/datasets/issues/7117/comments
null
false
Audio dataset load everything in RAM and is very slow Hello, I'm working with an audio dataset. I want to transcribe the audio that the dataset contain, and for that I use whisper. My issue is that the dataset load everything in the RAM when I map the dataset, obviously, when RAM usage is too high, the program crashes....
[ "Hi ! I think the issue comes from the fact that you return `row` entirely, and therefore the dataset has to re-encode the audio data in `row`.\r\n\r\nCan you try this instead ?\r\n\r\n```python\r\n# map the dataset\r\ndef transcribe_audio(row):\r\n audio = row[\"audio\"] # get the audio but do nothing with it\...
https://api.github.com/repos/huggingface/datasets/issues/7116
7,116
datasets cannot handle nested json if features is given.
### Describe the bug I have a json named temp.json. ```json {"ref1": "ABC", "ref2": "DEF", "cuts":[{"cut1": 3, "cut2": 5}]} ``` I want to load it. ```python ds = datasets.load_dataset('json', data_files="./temp.json", features=datasets.Features({ 'ref1': datasets.Value('string'), 'ref2': datasets.Value...
closed
2024-08-20T12:27:49
https://api.github.com/repos/huggingface/datasets/issues/7116/comments
null
false
datasets cannot handle nested json if features is given. ### Describe the bug I have a json named temp.json. ```json {"ref1": "ABC", "ref2": "DEF", "cuts":[{"cut1": 3, "cut2": 5}]} ``` I want to load it. ```python ds = datasets.load_dataset('json', data_files="./temp.json", features=datasets.Features({ 'ref...
[ "Hi ! `Sequence` has a weird behavior for dictionaries (from tensorflow-datasets), use a regular list instead:\r\n\r\n```python\r\nds = datasets.load_dataset('json', data_files=\"./temp.json\", features=datasets.Features({\r\n 'ref1': datasets.Value('string'),\r\n 'ref2': datasets.Value('string'),\r\n 'cut...
https://api.github.com/repos/huggingface/datasets/issues/7115
7,115
module 'pyarrow.lib' has no attribute 'ListViewType'
### Describe the bug Code: `!pipuninstall -y pyarrow !pip install --no-cache-dir pyarrow !pip uninstall -y pyarrow !pip install pyarrow --no-cache-dir !pip install --upgrade datasets transformers pyarrow !pip install pyarrow.parquet ! pip install pyarrow-core libparquet !pip install pyarrow --no-cache-di...
closed
2024-08-20T11:05:44
https://api.github.com/repos/huggingface/datasets/issues/7115/comments
null
false
module 'pyarrow.lib' has no attribute 'ListViewType' ### Describe the bug Code: `!pipuninstall -y pyarrow !pip install --no-cache-dir pyarrow !pip uninstall -y pyarrow !pip install pyarrow --no-cache-dir !pip install --upgrade datasets transformers pyarrow !pip install pyarrow.parquet ! pip install pyarrow-...
[ "https://github.com/neurafusionai/Hugging_Face/blob/main/meta_opt_350m_customer_support_lora_v1.ipynb\r\n\r\ncouldnt train because of GPU\r\nI didnt pip install datasets -U\r\nbut looks like restarting worked" ]
https://api.github.com/repos/huggingface/datasets/issues/7114
7,114
Temporarily pin numpy<2.1 to fix CI
Temporarily pin numpy<2.1 to fix CI. Fix #7111.
closed
2024-08-20T08:42:57
https://api.github.com/repos/huggingface/datasets/issues/7114/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7114", "html_url": "https://github.com/huggingface/datasets/pull/7114", "diff_url": "https://github.com/huggingface/datasets/pull/7114.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7114.patch", "merged_at": "2024-08-20T09:02...
true
Temporarily pin numpy<2.1 to fix CI Temporarily pin numpy<2.1 to fix CI. Fix #7111.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7114). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7113
7,113
Stream dataset does not iterate if the batch size is larger than the dataset size (related to drop_last_batch)
### Describe the bug Hi there, I use streaming and interleaving to combine multiple datasets saved in jsonl files. The size of dataset can vary (from 100ish to 100k-ish). I use dataset.map() and a big batch size to reduce the IO cost. It was working fine with datasets-2.16.1 but this problem shows up after I upgr...
closed
2024-08-20T08:26:40
https://api.github.com/repos/huggingface/datasets/issues/7113/comments
null
false
Stream dataset does not iterate if the batch size is larger than the dataset size (related to drop_last_batch) ### Describe the bug Hi there, I use streaming and interleaving to combine multiple datasets saved in jsonl files. The size of dataset can vary (from 100ish to 100k-ish). I use dataset.map() and a big ba...
[ "That's expected behavior, it's also the same in `torch`:\r\n\r\n```python\r\n>>> list(DataLoader(list(range(5)), batch_size=10, drop_last=True))\r\n[]\r\n```" ]
https://api.github.com/repos/huggingface/datasets/issues/7112
7,112
cudf-cu12 24.4.1, ibis-framework 8.0.0 requires pyarrow<15.0.0a0,>=14.0.1,pyarrow<16,>=2 and datasets 2.21.0 requires pyarrow>=15.0.0
### Describe the bug !pip install accelerate>=0.16.0 torchvision transformers>=4.25.1 datasets>=2.19.1 ftfy tensorboard Jinja2 peft==0.7.0 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. c...
open
2024-08-20T08:13:55
https://api.github.com/repos/huggingface/datasets/issues/7112/comments
null
false
cudf-cu12 24.4.1, ibis-framework 8.0.0 requires pyarrow<15.0.0a0,>=14.0.1,pyarrow<16,>=2 and datasets 2.21.0 requires pyarrow>=15.0.0 ### Describe the bug !pip install accelerate>=0.16.0 torchvision transformers>=4.25.1 datasets>=2.19.1 ftfy tensorboard Jinja2 peft==0.7.0 ERROR: pip's dependency resolver does not c...
[ "@sayakpaul please advice ", "Hits the same dependency conflict" ]
https://api.github.com/repos/huggingface/datasets/issues/7111
7,111
CI is broken for numpy-2: Failed to fetch wheel: llvmlite==0.34.0
Ci is broken with error `Failed to fetch wheel: llvmlite==0.34.0`: https://github.com/huggingface/datasets/actions/runs/10466825281/job/28984414269 ``` Run uv pip install --system "datasets[tests_numpy2] @ ." Resolved 150 packages in 4.42s error: Failed to prepare distributions Caused by: Failed to fetch wheel: ...
closed
2024-08-20T07:27:28
https://api.github.com/repos/huggingface/datasets/issues/7111/comments
null
false
CI is broken for numpy-2: Failed to fetch wheel: llvmlite==0.34.0 Ci is broken with error `Failed to fetch wheel: llvmlite==0.34.0`: https://github.com/huggingface/datasets/actions/runs/10466825281/job/28984414269 ``` Run uv pip install --system "datasets[tests_numpy2] @ ." Resolved 150 packages in 4.42s error: Fai...
[ "Note that the CI before was using:\r\n- llvmlite: 0.43.0\r\n- numba: 0.60.0\r\n\r\nNow it tries to use:\r\n- llvmlite: 0.34.0\r\n- numba: 0.51.2", "The issue is because numba-0.60.0 pins numpy<2.1 and `uv` tries to install latest numpy-2.1.0 with an old numba-0.51.0 version (and llvmlite-0.34.0). See discussion ...
https://api.github.com/repos/huggingface/datasets/issues/7110
7,110
Fix ConnectionError for gated datasets and unauthenticated users
Fix `ConnectionError` for gated datasets and unauthenticated users. See: - https://github.com/huggingface/dataset-viewer/issues/3025 Note that a recent change in the Hub returns dataset info for gated datasets and unauthenticated users, instead of raising a `GatedRepoError` as before. See: - https://github.com/hug...
closed
2024-08-20T05:26:54
https://api.github.com/repos/huggingface/datasets/issues/7110/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7110", "html_url": "https://github.com/huggingface/datasets/pull/7110", "diff_url": "https://github.com/huggingface/datasets/pull/7110.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7110.patch", "merged_at": "2024-08-20T09:14...
true
Fix ConnectionError for gated datasets and unauthenticated users Fix `ConnectionError` for gated datasets and unauthenticated users. See: - https://github.com/huggingface/dataset-viewer/issues/3025 Note that a recent change in the Hub returns dataset info for gated datasets and unauthenticated users, instead of rai...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7110). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Note that the CI error is unrelated to this PR and should be addressed in another PR. S...
https://api.github.com/repos/huggingface/datasets/issues/7109
7,109
ConnectionError for gated datasets and unauthenticated users
Since the Hub returns dataset info for gated datasets and unauthenticated users, there is dead code: https://github.com/huggingface/datasets/blob/98fdc9e78e6d057ca66e58a37f49d6618aab8130/src/datasets/load.py#L1846-L1852 We should remove the dead code and properly handle this case: currently we are raising a `Connect...
closed
2024-08-19T13:27:45
https://api.github.com/repos/huggingface/datasets/issues/7109/comments
null
false
ConnectionError for gated datasets and unauthenticated users Since the Hub returns dataset info for gated datasets and unauthenticated users, there is dead code: https://github.com/huggingface/datasets/blob/98fdc9e78e6d057ca66e58a37f49d6618aab8130/src/datasets/load.py#L1846-L1852 We should remove the dead code and p...
[]
https://api.github.com/repos/huggingface/datasets/issues/7108
7,108
website broken: Create a new dataset repository, doesn't create a new repo in Firefox
### Describe the bug This issue is also reported here: https://discuss.huggingface.co/t/create-a-new-dataset-repository-broken-page/102644 This page is broken. https://huggingface.co/new-dataset I fill in the form with my text, and click `Create Dataset`. ![Screenshot 2024-08-16 at 15 55 37](https://github....
closed
2024-08-16T17:23:00
https://api.github.com/repos/huggingface/datasets/issues/7108/comments
null
false
website broken: Create a new dataset repository, doesn't create a new repo in Firefox ### Describe the bug This issue is also reported here: https://discuss.huggingface.co/t/create-a-new-dataset-repository-broken-page/102644 This page is broken. https://huggingface.co/new-dataset I fill in the form with my t...
[ "I don't reproduce, I was able to create a new repo: https://huggingface.co/datasets/severo/reproduce-datasets-issues-7108. Can you confirm it's still broken?", "I have just tried again.\r\n\r\nFirefox: The `Create dataset` doesn't work. It has worked in the past. It's my preferred browser.\r\n\r\nChrome: The `Cr...
https://api.github.com/repos/huggingface/datasets/issues/7107
7,107
load_dataset broken in 2.21.0
### Describe the bug `eval_set = datasets.load_dataset("tatsu-lab/alpaca_eval", "alpaca_eval_gpt4_baseline", trust_remote_code=True)` used to work till 2.20.0 but doesn't work in 2.21.0 In 2.20.0: ![Screenshot 2024-08-16 at 3 57 10 PM](https://github.com/user-attachments/assets/0516489b-8187-486d-bee8-88af3381de...
closed
2024-08-16T14:59:51
https://api.github.com/repos/huggingface/datasets/issues/7107/comments
null
false
load_dataset broken in 2.21.0 ### Describe the bug `eval_set = datasets.load_dataset("tatsu-lab/alpaca_eval", "alpaca_eval_gpt4_baseline", trust_remote_code=True)` used to work till 2.20.0 but doesn't work in 2.21.0 In 2.20.0: ![Screenshot 2024-08-16 at 3 57 10 PM](https://github.com/user-attachments/assets/0516...
[ "There seems to be a PR related to the load_dataset path that went into 2.21.0 -- https://github.com/huggingface/datasets/pull/6862/files\r\n\r\nTaking a look at it now", "+1\r\n\r\nDowngrading to 2.20.0 fixed my issue, hopefully helpful for others.", "I tried adding a simple test to `test_load.py` with the alp...
https://api.github.com/repos/huggingface/datasets/issues/7106
7,106
Rename LargeList.dtype to LargeList.feature
Rename `LargeList.dtype` to `LargeList.feature`. Note that `dtype` is usually used for NumPy data types ("int64", "float32",...): see `Value.dtype`. However, `LargeList` attribute (like `Sequence.feature`) expects a `FeatureType` instead. With this renaming: - we avoid confusion about the expected type and -...
closed
2024-08-16T09:12:04
https://api.github.com/repos/huggingface/datasets/issues/7106/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7106", "html_url": "https://github.com/huggingface/datasets/pull/7106", "diff_url": "https://github.com/huggingface/datasets/pull/7106.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7106.patch", "merged_at": "2024-08-26T04:26...
true
Rename LargeList.dtype to LargeList.feature Rename `LargeList.dtype` to `LargeList.feature`. Note that `dtype` is usually used for NumPy data types ("int64", "float32",...): see `Value.dtype`. However, `LargeList` attribute (like `Sequence.feature`) expects a `FeatureType` instead. With this renaming: - we av...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7106). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7105
7,105
Use `huggingface_hub` cache
- use `hf_hub_download()` from `huggingface_hub` for HF files - `datasets` cache_dir is still used for: - caching datasets as Arrow files (that back `Dataset` objects) - extracted archives, uncompressed files - files downloaded via http (datasets with scripts) - I removed code that were made for http files (...
closed
2024-08-15T14:45:22
https://api.github.com/repos/huggingface/datasets/issues/7105/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7105", "html_url": "https://github.com/huggingface/datasets/pull/7105", "diff_url": "https://github.com/huggingface/datasets/pull/7105.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7105.patch", "merged_at": "2024-08-21T15:47...
true
Use `huggingface_hub` cache - use `hf_hub_download()` from `huggingface_hub` for HF files - `datasets` cache_dir is still used for: - caching datasets as Arrow files (that back `Dataset` objects) - extracted archives, uncompressed files - files downloaded via http (datasets with scripts) - I removed code tha...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7105). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Nice\r\n\r\n<img width=\"141\" alt=\"Capture d’écran 2024-08-19 à 15 25 00\" src=\"ht...
https://api.github.com/repos/huggingface/datasets/issues/7104
7,104
remove more script docs
null
closed
2024-08-15T10:13:26
https://api.github.com/repos/huggingface/datasets/issues/7104/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7104", "html_url": "https://github.com/huggingface/datasets/pull/7104", "diff_url": "https://github.com/huggingface/datasets/pull/7104.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7104.patch", "merged_at": "2024-08-15T10:18...
true
remove more script docs
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7104). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7103
7,103
Fix args of feature docstrings
Fix Args section of feature docstrings. Currently, some args do not appear in the docs because they are not properly parsed due to the lack of their type (between parentheses).
closed
2024-08-15T08:46:08
https://api.github.com/repos/huggingface/datasets/issues/7103/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7103", "html_url": "https://github.com/huggingface/datasets/pull/7103", "diff_url": "https://github.com/huggingface/datasets/pull/7103.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7103.patch", "merged_at": "2024-08-15T10:33...
true
Fix args of feature docstrings Fix Args section of feature docstrings. Currently, some args do not appear in the docs because they are not properly parsed due to the lack of their type (between parentheses).
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7103). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7102
7,102
Slow iteration speeds when using IterableDataset.shuffle with load_dataset(data_files=..., streaming=True)
### Describe the bug When I load a dataset from a number of arrow files, as in: ``` random_dataset = load_dataset( "arrow", data_files={split: shard_filepaths}, streaming=True, split=split, ) ``` I'm able to get fast iteration speeds when iterating over the dataset without shuffling. ...
open
2024-08-14T21:44:44
https://api.github.com/repos/huggingface/datasets/issues/7102/comments
null
false
Slow iteration speeds when using IterableDataset.shuffle with load_dataset(data_files=..., streaming=True) ### Describe the bug When I load a dataset from a number of arrow files, as in: ``` random_dataset = load_dataset( "arrow", data_files={split: shard_filepaths}, streaming=True, split=spl...
[ "Hi @lajd , I was skeptical about how we are saving the shards each as their own dataset (arrow file) in the script above, and so I updated the script to try out saving the shards in a few different file formats. From the experiments I ran, I saw binary format show significantly the best performance, with arrow a...
https://api.github.com/repos/huggingface/datasets/issues/7101
7,101
`load_dataset` from Hub with `name` to specify `config` using incorrect builder type when multiple data formats are present
Following [documentation](https://huggingface.co/docs/datasets/repository_structure#define-your-splits-and-subsets-in-yaml) I had defined different configs for [`Dataception`](https://huggingface.co/datasets/bigdata-pw/Dataception), a dataset of datasets: ```yaml configs: - config_name: dataception data_files: ...
open
2024-08-14T18:12:25
https://api.github.com/repos/huggingface/datasets/issues/7101/comments
null
false
`load_dataset` from Hub with `name` to specify `config` using incorrect builder type when multiple data formats are present Following [documentation](https://huggingface.co/docs/datasets/repository_structure#define-your-splits-and-subsets-in-yaml) I had defined different configs for [`Dataception`](https://huggingface....
[ "Having looked into this further it seems the core of the issue is with two different formats in the same repo.\r\n\r\nWhen the `parquet` config is first, the `WebDataset`s are loaded as `parquet`, if the `WebDataset` configs are first, the `parquet` is loaded as `WebDataset`.\r\n\r\nA workaround in my case would b...
https://api.github.com/repos/huggingface/datasets/issues/7100
7,100
IterableDataset: cannot resolve features from list of numpy arrays
### Describe the bug when resolve features of `IterableDataset`, got `pyarrow.lib.ArrowInvalid: Can only convert 1-dimensional array values` error. ``` Traceback (most recent call last): File "test.py", line 6 iter_ds = iter_ds._resolve_features() File "lib/python3.10/site-packages/datasets/iterable_dat...
open
2024-08-14T11:01:51
https://api.github.com/repos/huggingface/datasets/issues/7100/comments
null
false
IterableDataset: cannot resolve features from list of numpy arrays ### Describe the bug when resolve features of `IterableDataset`, got `pyarrow.lib.ArrowInvalid: Can only convert 1-dimensional array values` error. ``` Traceback (most recent call last): File "test.py", line 6 iter_ds = iter_ds._resolve_fea...
[ "Assign this issue to me under Hacktoberfest with hacktoberfest label inserted on the issue" ]
https://api.github.com/repos/huggingface/datasets/issues/7099
7,099
Set dev version
null
closed
2024-08-14T08:31:17
https://api.github.com/repos/huggingface/datasets/issues/7099/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7099", "html_url": "https://github.com/huggingface/datasets/pull/7099", "diff_url": "https://github.com/huggingface/datasets/pull/7099.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7099.patch", "merged_at": "2024-08-14T08:39...
true
Set dev version
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7099). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7098
7,098
Release: 2.21.0
null
closed
2024-08-14T06:35:13
https://api.github.com/repos/huggingface/datasets/issues/7098/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7098", "html_url": "https://github.com/huggingface/datasets/pull/7098", "diff_url": "https://github.com/huggingface/datasets/pull/7098.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7098.patch", "merged_at": "2024-08-14T06:41...
true
Release: 2.21.0
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7098). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7097
7,097
Some of DownloadConfig's properties are always being overridden in load.py
### Describe the bug The `extract_compressed_file` and `force_extract` properties of DownloadConfig are always being set to True in the function `dataset_module_factory` in the `load.py` file. This behavior is very annoying because data extracted will just be ignored the next time the dataset is loaded. See this im...
open
2024-08-09T18:26:37
https://api.github.com/repos/huggingface/datasets/issues/7097/comments
null
false
Some of DownloadConfig's properties are always being overridden in load.py ### Describe the bug The `extract_compressed_file` and `force_extract` properties of DownloadConfig are always being set to True in the function `dataset_module_factory` in the `load.py` file. This behavior is very annoying because data extract...
[]
https://api.github.com/repos/huggingface/datasets/issues/7096
7,096
Automatically create `cache_dir` from `cache_file_name`
You get a pretty unhelpful error message when specifying a `cache_file_name` in a directory that doesn't exist, e.g. `cache_file_name="./cache/data.map"` ```python import datasets cache_file_name="./cache/train.map" dataset = datasets.load_dataset("ylecun/mnist") dataset["train"].map(lambda x: x, cache_file_na...
closed
2024-08-09T01:34:06
https://api.github.com/repos/huggingface/datasets/issues/7096/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7096", "html_url": "https://github.com/huggingface/datasets/pull/7096", "diff_url": "https://github.com/huggingface/datasets/pull/7096.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7096.patch", "merged_at": "2024-08-15T10:13...
true
Automatically create `cache_dir` from `cache_file_name` You get a pretty unhelpful error message when specifying a `cache_file_name` in a directory that doesn't exist, e.g. `cache_file_name="./cache/data.map"` ```python import datasets cache_file_name="./cache/train.map" dataset = datasets.load_dataset("ylecun/...
[ "Hi @albertvillanova, is this PR looking okay to you? Anything else you'd like to see?", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7096). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",...
https://api.github.com/repos/huggingface/datasets/issues/7094
7,094
Add Arabic Docs to Datasets
Translate Docs into Arabic issue-number : #7093 [Arabic Docs](https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/ar/index.mdx) [English Docs](https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/en/index.mdx) @stevhliu
open
2024-08-07T21:53:06
https://api.github.com/repos/huggingface/datasets/issues/7094/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7094", "html_url": "https://github.com/huggingface/datasets/pull/7094", "diff_url": "https://github.com/huggingface/datasets/pull/7094.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7094.patch", "merged_at": null }
true
Add Arabic Docs to Datasets Translate Docs into Arabic issue-number : #7093 [Arabic Docs](https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/ar/index.mdx) [English Docs](https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/en/index.mdx) @stevhliu
[]
https://api.github.com/repos/huggingface/datasets/issues/7093
7,093
Add Arabic Docs to datasets
### Feature request Add Arabic Docs to datasets [Datasets Arabic](https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/ar/index.mdx) ### Motivation @AhmedAlmaghz https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/ar/index.mdx ### Your contribution @AhmedAlmaghz https://github.com/AhmedAlma...
open
2024-08-07T21:48:05
https://api.github.com/repos/huggingface/datasets/issues/7093/comments
null
false
Add Arabic Docs to datasets ### Feature request Add Arabic Docs to datasets [Datasets Arabic](https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/ar/index.mdx) ### Motivation @AhmedAlmaghz https://github.com/AhmedAlmaghz/datasets/blob/main/docs/source/ar/index.mdx ### Your contribution @AhmedAlmaghz ...
[]
https://api.github.com/repos/huggingface/datasets/issues/7092
7,092
load_dataset with multiple jsonlines files interprets datastructure too early
### Describe the bug likely related to #6460 using `datasets.load_dataset("json", data_dir= ... )` with multiple `.jsonl` files will error if one of the files (maybe the first file?) contains a full column of empty data. ### Steps to reproduce the bug real world example: data is available in this [PR-bra...
open
2024-08-06T17:42:55
https://api.github.com/repos/huggingface/datasets/issues/7092/comments
null
false
load_dataset with multiple jsonlines files interprets datastructure too early ### Describe the bug likely related to #6460 using `datasets.load_dataset("json", data_dir= ... )` with multiple `.jsonl` files will error if one of the files (maybe the first file?) contains a full column of empty data. ### Steps ...
[ "I’ll take a look", "Possible definitions of done for this issue:\r\n\r\n1. A fix so you can load your dataset specifically\r\n2. A general fix for datasets similar to this in the `datasets` library\r\n\r\nOption 1 is trivial. I think option 2 requires significant changes to the library.\r\n\r\nSince you outlined...
https://api.github.com/repos/huggingface/datasets/issues/7090
7,090
The test test_move_script_doesnt_change_hash fails because it runs the 'python' command while the python executable has a different name
### Describe the bug Tests should use the same pythin path as they are launched with, which in the case of FreeBSD is /usr/local/bin/python3.11 Failure: ``` if err_filename is not None: > raise child_exception_type(errno_num, err_msg, err_filename) E FileNotFo...
open
2024-08-06T00:35:05
https://api.github.com/repos/huggingface/datasets/issues/7090/comments
null
false
The test test_move_script_doesnt_change_hash fails because it runs the 'python' command while the python executable has a different name ### Describe the bug Tests should use the same pythin path as they are launched with, which in the case of FreeBSD is /usr/local/bin/python3.11 Failure: ``` if e...
[]
https://api.github.com/repos/huggingface/datasets/issues/7089
7,089
Missing pyspark dependency causes the testsuite to error out, instead of a few tests to be skipped
### Describe the bug see the subject ### Steps to reproduce the bug regular tests ### Expected behavior n/a ### Environment info version 2.20.0
open
2024-08-05T21:05:11
https://api.github.com/repos/huggingface/datasets/issues/7089/comments
null
false
Missing pyspark dependency causes the testsuite to error out, instead of a few tests to be skipped ### Describe the bug see the subject ### Steps to reproduce the bug regular tests ### Expected behavior n/a ### Environment info version 2.20.0
[]
https://api.github.com/repos/huggingface/datasets/issues/7088
7,088
Disable warning when using with_format format on tensors
### Feature request If we write this code: ```python """Get data and define datasets.""" from enum import StrEnum from datasets import load_dataset from torch.utils.data import DataLoader from torchvision import transforms class Split(StrEnum): """Describes what type of split to use in the dataloa...
open
2024-08-05T00:45:50
https://api.github.com/repos/huggingface/datasets/issues/7088/comments
null
false
Disable warning when using with_format format on tensors ### Feature request If we write this code: ```python """Get data and define datasets.""" from enum import StrEnum from datasets import load_dataset from torch.utils.data import DataLoader from torchvision import transforms class Split(StrEnum): ...
[]
https://api.github.com/repos/huggingface/datasets/issues/7087
7,087
Unable to create dataset card for Lushootseed language
### Feature request While I was creating the dataset which contained all documents from the Lushootseed Wikipedia, the dataset card asked me to enter which language the dataset was in. Since Lushootseed is a critically endangered language, it was not available as one of the options. Is it possible to allow entering la...
closed
2024-08-04T14:27:04
https://api.github.com/repos/huggingface/datasets/issues/7087/comments
null
false
Unable to create dataset card for Lushootseed language ### Feature request While I was creating the dataset which contained all documents from the Lushootseed Wikipedia, the dataset card asked me to enter which language the dataset was in. Since Lushootseed is a critically endangered language, it was not available as ...
[ "Thanks for reporting.\r\n\r\nIt is weird, because the language entry is in the list. See: https://github.com/huggingface/huggingface.js/blob/98e32f0ed4ee057a596f66a1dec738e5db9643d5/packages/languages/src/languages_iso_639_3.ts#L15186-L15189\r\n\r\nI have reported the issue:\r\n- https://github.com/huggingface/hug...
https://api.github.com/repos/huggingface/datasets/issues/7086
7,086
load_dataset ignores cached datasets and tries to hit HF Hub, resulting in API rate limit errors
### Describe the bug I have been running lm-eval-harness a lot which has results in an API rate limit. This seems strange, since all of the data should be cached locally. I have in fact verified this. ### Steps to reproduce the bug 1. Be Me 2. Run `load_dataset("TAUR-Lab/MuSR")` 3. Hit rate limit error 4. Dataset...
open
2024-08-02T18:12:23
https://api.github.com/repos/huggingface/datasets/issues/7086/comments
null
false
load_dataset ignores cached datasets and tries to hit HF Hub, resulting in API rate limit errors ### Describe the bug I have been running lm-eval-harness a lot which has results in an API rate limit. This seems strange, since all of the data should be cached locally. I have in fact verified this. ### Steps to reprodu...
[ "I'm having the same issue - running into rate limits when doing hyperparameter tuning even though the dataset is supposed to be cached. I feel like this behaviour should at the very least be documented, but honestly you should just not be running into rate limits in the first place when the dataset is cached. It e...
https://api.github.com/repos/huggingface/datasets/issues/7085
7,085
[Regression] IterableDataset is broken on 2.20.0
### Describe the bug In the latest version of datasets there is a major regression, after creating an `IterableDataset` from a generator and applying a few operations (`map`, `select`), you can no longer iterate through the dataset multiple times. The issue seems to stem from the recent addition of "resumable Itera...
closed
2024-07-31T13:01:59
https://api.github.com/repos/huggingface/datasets/issues/7085/comments
null
false
[Regression] IterableDataset is broken on 2.20.0 ### Describe the bug In the latest version of datasets there is a major regression, after creating an `IterableDataset` from a generator and applying a few operations (`map`, `select`), you can no longer iterate through the dataset multiple times. The issue seems to ...
[ "@lhoestq I detected this regression over on [DataDreamer](https://github.com/datadreamer-dev/DataDreamer)'s test suite. I put in these [monkey patches](https://github.com/datadreamer-dev/DataDreamer/blob/4cbaf9f39cf7bedde72bbaa68346e169788fbecb/src/_patches/datasets_reset_state_hack.py) in case that fixed it our t...
https://api.github.com/repos/huggingface/datasets/issues/7084
7,084
More easily support streaming local files
### Feature request Simplify downloading and streaming datasets locally. Specifically, perhaps add an option to `load_dataset(..., streaming="download_first")` or add better support for streaming symlinked or arrow files. ### Motivation I have downloaded FineWeb-edu locally and currently trying to stream the d...
open
2024-07-31T09:03:15
https://api.github.com/repos/huggingface/datasets/issues/7084/comments
null
false
More easily support streaming local files ### Feature request Simplify downloading and streaming datasets locally. Specifically, perhaps add an option to `load_dataset(..., streaming="download_first")` or add better support for streaming symlinked or arrow files. ### Motivation I have downloaded FineWeb-edu lo...
[]
https://api.github.com/repos/huggingface/datasets/issues/7083
7,083
fix streaming from arrow files
null
closed
2024-07-31T09:02:42
https://api.github.com/repos/huggingface/datasets/issues/7083/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7083", "html_url": "https://github.com/huggingface/datasets/pull/7083", "diff_url": "https://github.com/huggingface/datasets/pull/7083.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7083.patch", "merged_at": "2024-08-30T15:17...
true
fix streaming from arrow files
[]
https://api.github.com/repos/huggingface/datasets/issues/7082
7,082
Support HTTP authentication in non-streaming mode
Support HTTP authentication in non-streaming mode, by support passing HTTP storage_options in non-streaming mode. - Note that currently, HTTP authentication is supported only in streaming mode. For example, this is necessary if a remote HTTP host requires authentication to download the data.
closed
2024-07-30T09:25:49
https://api.github.com/repos/huggingface/datasets/issues/7082/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7082", "html_url": "https://github.com/huggingface/datasets/pull/7082", "diff_url": "https://github.com/huggingface/datasets/pull/7082.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7082.patch", "merged_at": "2024-08-08T08:24...
true
Support HTTP authentication in non-streaming mode Support HTTP authentication in non-streaming mode, by support passing HTTP storage_options in non-streaming mode. - Note that currently, HTTP authentication is supported only in streaming mode. For example, this is necessary if a remote HTTP host requires authentica...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7082). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7081
7,081
Set load_from_disk path type as PathLike
Set `load_from_disk` path type as `PathLike`. This way it is aligned with `save_to_disk`.
closed
2024-07-30T07:00:38
https://api.github.com/repos/huggingface/datasets/issues/7081/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7081", "html_url": "https://github.com/huggingface/datasets/pull/7081", "diff_url": "https://github.com/huggingface/datasets/pull/7081.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7081.patch", "merged_at": "2024-07-30T08:21...
true
Set load_from_disk path type as PathLike Set `load_from_disk` path type as `PathLike`. This way it is aligned with `save_to_disk`.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7081). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7080
7,080
Generating train split takes a long time
### Describe the bug Loading a simple webdataset takes ~45 minutes. ### Steps to reproduce the bug ``` from datasets import load_dataset dataset = load_dataset("PixArt-alpha/SAM-LLaVA-Captions10M") ``` ### Expected behavior The dataset should load immediately as it does when loaded through a normal indexed WebD...
open
2024-07-29T01:42:43
https://api.github.com/repos/huggingface/datasets/issues/7080/comments
null
false
Generating train split takes a long time ### Describe the bug Loading a simple webdataset takes ~45 minutes. ### Steps to reproduce the bug ``` from datasets import load_dataset dataset = load_dataset("PixArt-alpha/SAM-LLaVA-Captions10M") ``` ### Expected behavior The dataset should load immediately as it does ...
[ "@alexanderswerdlow \r\nWhen no specific split is mentioned, the load_dataset library will load all available splits of the dataset. For example, if a dataset has \"train\" and \"test\" splits, the load_dataset function will load both into the DatasetDict object.\r\n\r\n![image](https://github.com/user-attachments/...
https://api.github.com/repos/huggingface/datasets/issues/7079
7,079
HfHubHTTPError: 500 Server Error: Internal Server Error for url:
### Describe the bug newly uploaded datasets, since yesterday, yields an error. old datasets, works fine. Seems like the datasets api server returns a 500 I'm getting the same error, when I invoke `load_dataset` with my dataset. Long discussion about it here, but I'm not sure anyone from huggingface have s...
closed
2024-07-27T08:21:03
https://api.github.com/repos/huggingface/datasets/issues/7079/comments
null
false
HfHubHTTPError: 500 Server Error: Internal Server Error for url: ### Describe the bug newly uploaded datasets, since yesterday, yields an error. old datasets, works fine. Seems like the datasets api server returns a 500 I'm getting the same error, when I invoke `load_dataset` with my dataset. Long discussi...
[ "same issue here. @albertvillanova @lhoestq ", "Also impacted by this issue in many of my datasets (though not all) - in my case, this also seems to affect datasets that have been updated recently. Git cloning and the web interface still work:\r\n- https://huggingface.co/api/datasets/acmc/cheat_reduced\r\n- https...
https://api.github.com/repos/huggingface/datasets/issues/7078
7,078
Fix CI test_convert_to_parquet
Fix `test_convert_to_parquet` by patching `HfApi.preupload_lfs_files` and revert temporary fix: - #7074
closed
2024-07-27T05:32:40
https://api.github.com/repos/huggingface/datasets/issues/7078/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7078", "html_url": "https://github.com/huggingface/datasets/pull/7078", "diff_url": "https://github.com/huggingface/datasets/pull/7078.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7078.patch", "merged_at": "2024-07-27T05:44...
true
Fix CI test_convert_to_parquet Fix `test_convert_to_parquet` by patching `HfApi.preupload_lfs_files` and revert temporary fix: - #7074
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7078). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7077
7,077
column_names ignored by load_dataset() when loading CSV file
### Describe the bug load_dataset() ignores the column_names kwarg when loading a CSV file. Instead, it uses whatever values are on the first line of the file. ### Steps to reproduce the bug Call `load_dataset` to load data from a CSV file and specify `column_names` kwarg. ### Expected behavior The resulting da...
open
2024-07-26T14:18:04
https://api.github.com/repos/huggingface/datasets/issues/7077/comments
null
false
column_names ignored by load_dataset() when loading CSV file ### Describe the bug load_dataset() ignores the column_names kwarg when loading a CSV file. Instead, it uses whatever values are on the first line of the file. ### Steps to reproduce the bug Call `load_dataset` to load data from a CSV file and specify `...
[ "I confirm that `column_names` values are not copied to `names` variable because in this case `CsvConfig.__post_init__` is not called: `CsvConfig` is instantiated with default values and afterwards the `config_kwargs` are used to overwrite its attributes.\r\n\r\n@luismsgomes in the meantime, you can avoid the bug i...
https://api.github.com/repos/huggingface/datasets/issues/7076
7,076
🧪 Do not mock create_commit
null
closed
2024-07-26T13:44:42
https://api.github.com/repos/huggingface/datasets/issues/7076/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7076", "html_url": "https://github.com/huggingface/datasets/pull/7076", "diff_url": "https://github.com/huggingface/datasets/pull/7076.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7076.patch", "merged_at": null }
true
🧪 Do not mock create_commit
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7076). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7075
7,075
Update required soxr version from pre-release to release
Update required `soxr` version from pre-release to release 0.4.0: https://github.com/dofuuz/python-soxr/releases/tag/v0.4.0
closed
2024-07-26T11:24:35
https://api.github.com/repos/huggingface/datasets/issues/7075/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7075", "html_url": "https://github.com/huggingface/datasets/pull/7075", "diff_url": "https://github.com/huggingface/datasets/pull/7075.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7075.patch", "merged_at": "2024-07-26T11:40...
true
Update required soxr version from pre-release to release Update required `soxr` version from pre-release to release 0.4.0: https://github.com/dofuuz/python-soxr/releases/tag/v0.4.0
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7075). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7074
7,074
Fix CI by temporarily marking test_convert_to_parquet as expected to fail
As a hotfix for CI, temporarily mark test_convert_to_parquet as expected to fail. Fix #7073. Revert once root cause is fixed.
closed
2024-07-26T09:03:33
https://api.github.com/repos/huggingface/datasets/issues/7074/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7074", "html_url": "https://github.com/huggingface/datasets/pull/7074", "diff_url": "https://github.com/huggingface/datasets/pull/7074.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7074.patch", "merged_at": "2024-07-26T09:16...
true
Fix CI by temporarily marking test_convert_to_parquet as expected to fail As a hotfix for CI, temporarily mark test_convert_to_parquet as expected to fail. Fix #7073. Revert once root cause is fixed.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7074). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7073
7,073
CI is broken for convert_to_parquet: Invalid rev id: refs/pr/1 404 error causes RevisionNotFoundError
See: https://github.com/huggingface/datasets/actions/runs/10095313567/job/27915185756 ``` FAILED tests/test_hub.py::test_convert_to_parquet - huggingface_hub.utils._errors.RevisionNotFoundError: 404 Client Error. (Request ID: Root=1-66a25839-31ce7b475e70e7db1e4d44c2;b0c8870f-d5ef-4bf2-a6ff-0191f3df0f64) Revision N...
closed
2024-07-26T08:27:41
https://api.github.com/repos/huggingface/datasets/issues/7073/comments
null
false
CI is broken for convert_to_parquet: Invalid rev id: refs/pr/1 404 error causes RevisionNotFoundError See: https://github.com/huggingface/datasets/actions/runs/10095313567/job/27915185756 ``` FAILED tests/test_hub.py::test_convert_to_parquet - huggingface_hub.utils._errors.RevisionNotFoundError: 404 Client Error. (Re...
[ "Any recent change in the API backend rejecting parameter `revision=\"refs/pr/1\"` to `HfApi.preupload_lfs_files`?\r\n```\r\nf\"{endpoint}/api/{repo_type}s/{repo_id}/preupload/{revision}\"\r\n\r\nhttps://hub-ci.huggingface.co/api/datasets/__DUMMY_TRANSFORMERS_USER__/test-dataset-5188a8-17219154347516/preupload/refs...
https://api.github.com/repos/huggingface/datasets/issues/7072
7,072
nm
null
closed
2024-07-25T17:03:24
https://api.github.com/repos/huggingface/datasets/issues/7072/comments
null
false
nm
[]
https://api.github.com/repos/huggingface/datasets/issues/7071
7,071
Filter hangs
### Describe the bug When trying to filter my custom dataset, the process hangs, regardless of the lambda function used. It appears to be an issue with the way the Images are being handled. The dataset in question is a preprocessed version of https://huggingface.co/datasets/danaaubakirova/patfig where notably, I hav...
open
2024-07-25T15:29:05
https://api.github.com/repos/huggingface/datasets/issues/7071/comments
null
false
Filter hangs ### Describe the bug When trying to filter my custom dataset, the process hangs, regardless of the lambda function used. It appears to be an issue with the way the Images are being handled. The dataset in question is a preprocessed version of https://huggingface.co/datasets/danaaubakirova/patfig where n...
[]
https://api.github.com/repos/huggingface/datasets/issues/7070
7,070
how set_transform affects batch size?
### Describe the bug I am trying to fine-tune w2v-bert for ASR task. Since my dataset is so big, I preferred to use the on-the-fly method with set_transform. So i change the preprocessing function to this: ``` def prepare_dataset(batch): input_features = processor(batch["audio"], sampling_rate=16000).input_feat...
open
2024-07-25T15:19:34
https://api.github.com/repos/huggingface/datasets/issues/7070/comments
null
false
how set_transform affects batch size? ### Describe the bug I am trying to fine-tune w2v-bert for ASR task. Since my dataset is so big, I preferred to use the on-the-fly method with set_transform. So i change the preprocessing function to this: ``` def prepare_dataset(batch): input_features = processor(batch["au...
[]
https://api.github.com/repos/huggingface/datasets/issues/7069
7,069
Fix push_to_hub by not calling create_branch if PR branch
Fix push_to_hub by not calling create_branch if PR branch (e.g. `refs/pr/1`). Note that currently create_branch raises a 400 Bad Request error if the user passes a PR branch (e.g. `refs/pr/1`). EDIT: ~~Fix push_to_hub by not calling create_branch if branch exists.~~ Note that currently create_branch raises a ...
closed
2024-07-25T07:50:04
https://api.github.com/repos/huggingface/datasets/issues/7069/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7069", "html_url": "https://github.com/huggingface/datasets/pull/7069", "diff_url": "https://github.com/huggingface/datasets/pull/7069.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7069.patch", "merged_at": "2024-07-30T10:51...
true
Fix push_to_hub by not calling create_branch if PR branch Fix push_to_hub by not calling create_branch if PR branch (e.g. `refs/pr/1`). Note that currently create_branch raises a 400 Bad Request error if the user passes a PR branch (e.g. `refs/pr/1`). EDIT: ~~Fix push_to_hub by not calling create_branch if branc...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7069). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "cc @Wauplin maybe it's a `huggingface_hub` bug ?\r\n\r\nEDIT: ah actually the issue is ...
https://api.github.com/repos/huggingface/datasets/issues/7068
7,068
Fix prepare_single_hop_path_and_storage_options
Fix `_prepare_single_hop_path_and_storage_options`: - Do not pass HF authentication headers and HF user-agent to non-HF HTTP URLs - Do not overwrite passed `storage_options` nested values: - Before, when passed ```DownloadConfig(storage_options={"https": {"client_kwargs": {"raise_for_status": True}}})```, ...
closed
2024-07-24T05:52:34
https://api.github.com/repos/huggingface/datasets/issues/7068/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7068", "html_url": "https://github.com/huggingface/datasets/pull/7068", "diff_url": "https://github.com/huggingface/datasets/pull/7068.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7068.patch", "merged_at": "2024-07-29T06:56...
true
Fix prepare_single_hop_path_and_storage_options Fix `_prepare_single_hop_path_and_storage_options`: - Do not pass HF authentication headers and HF user-agent to non-HF HTTP URLs - Do not overwrite passed `storage_options` nested values: - Before, when passed ```DownloadConfig(storage_options={"https": {"clie...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7068). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
https://api.github.com/repos/huggingface/datasets/issues/7067
7,067
Convert_to_parquet fails for datasets with multiple configs
If the dataset has multiple configs, when using the `datasets-cli convert_to_parquet` command to avoid issues with the data viewer caused by loading scripts, the conversion process only successfully converts the data corresponding to the first config. When it starts converting the second config, it throws an error: ...
closed
2024-07-23T15:09:33
https://api.github.com/repos/huggingface/datasets/issues/7067/comments
null
false
Convert_to_parquet fails for datasets with multiple configs If the dataset has multiple configs, when using the `datasets-cli convert_to_parquet` command to avoid issues with the data viewer caused by loading scripts, the conversion process only successfully converts the data corresponding to the first config. When it ...
[ "Many users have encountered the same issue, which has caused inconvenience.\r\n\r\nhttps://discuss.huggingface.co/t/convert-to-parquet-fails-for-datasets-with-multiple-configs/86733\r\n", "Thanks for reporting.\r\n\r\nI will make the code more robust.", "I have opened an issue in the huggingface-hub repo:\r\n-...
https://api.github.com/repos/huggingface/datasets/issues/7066
7,066
One subset per file in repo ?
Right now we consider all the files of a dataset to be the same data, e.g. ``` single_subset_dataset/ ├── train0.jsonl ├── train1.jsonl └── train2.jsonl ``` but in cases like this, each file is actually a different subset of the dataset and should be loaded separately ``` many_subsets_dataset/ ├── animals.jso...
open
2024-07-23T12:43:59
https://api.github.com/repos/huggingface/datasets/issues/7066/comments
null
false
One subset per file in repo ? Right now we consider all the files of a dataset to be the same data, e.g. ``` single_subset_dataset/ ├── train0.jsonl ├── train1.jsonl └── train2.jsonl ``` but in cases like this, each file is actually a different subset of the dataset and should be loaded separately ``` many_sub...
[ "Hi @lhoestq! I’ve opened a PR that addresses this issue" ]
https://api.github.com/repos/huggingface/datasets/issues/7065
7,065
Cannot get item after loading from disk and then converting to iterable.
### Describe the bug The dataset generated from local file works fine. ```py root = "/home/data/train" file_list1 = glob(os.path.join(root, "*part1.flac")) file_list2 = glob(os.path.join(root, "*part2.flac")) ds = ( Dataset.from_dict({"part1": file_list1, "part2": file_list2}) .cast_column("part1", Au...
open
2024-07-23T09:37:56
https://api.github.com/repos/huggingface/datasets/issues/7065/comments
null
false
Cannot get item after loading from disk and then converting to iterable. ### Describe the bug The dataset generated from local file works fine. ```py root = "/home/data/train" file_list1 = glob(os.path.join(root, "*part1.flac")) file_list2 = glob(os.path.join(root, "*part2.flac")) ds = ( Dataset.from_dict(...
[]
https://api.github.com/repos/huggingface/datasets/issues/7064
7,064
Add `batch` method to `Dataset` class
This PR introduces a new `batch` method to the `Dataset` class, aligning its functionality with the `IterableDataset.batch()` method (implemented in #7054). The implementation uses as well the existing `map` method for efficient batching of examples. Key changes: - Add `batch` method to `Dataset` class in `arrow_da...
closed
2024-07-23T08:40:43
https://api.github.com/repos/huggingface/datasets/issues/7064/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7064", "html_url": "https://github.com/huggingface/datasets/pull/7064", "diff_url": "https://github.com/huggingface/datasets/pull/7064.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7064.patch", "merged_at": "2024-07-25T13:45...
true
Add `batch` method to `Dataset` class This PR introduces a new `batch` method to the `Dataset` class, aligning its functionality with the `IterableDataset.batch()` method (implemented in #7054). The implementation uses as well the existing `map` method for efficient batching of examples. Key changes: - Add `batch` ...
[ "Looks good to me ! :)\r\n\r\nyou might want to add the `map` num_proc argument as well, for people who want to make it run faster", "Thanks for the feedback @lhoestq! The last commits include:\r\n- Adding the `num_proc` parameter to `batch`\r\n- Adding tests similar to the one done for `IterableDataset.batch()`\...