url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/7275
7,275
load_dataset
### Describe the bug I am performing two operations I see on a hugging face tutorial (Fine-tune a language model), and I am defining every aspect inside the mapped functions, also some imports of the library because it doesnt identify anything not defined outside that function where the dataset elements are being mapp...
open
2024-11-04T03:01:44
https://api.github.com/repos/huggingface/datasets/issues/7275/comments
null
false
load_dataset ### Describe the bug I am performing two operations I see on a hugging face tutorial (Fine-tune a language model), and I am defining every aspect inside the mapped functions, also some imports of the library because it doesnt identify anything not defined outside that function where the dataset elements a...
[]
https://api.github.com/repos/huggingface/datasets/issues/7274
7,274
[MINOR:TYPO] Fix typo in exception text
null
closed
2024-11-01T21:15:29
https://api.github.com/repos/huggingface/datasets/issues/7274/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7274", "html_url": "https://github.com/huggingface/datasets/pull/7274", "diff_url": "https://github.com/huggingface/datasets/pull/7274.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7274.patch", "merged_at": null }
true
[MINOR:TYPO] Fix typo in exception text
[]
https://api.github.com/repos/huggingface/datasets/issues/7273
7,273
Raise error for incorrect JSON serialization
Raise error when `lines = False` and `batch_size < Dataset.num_rows` in `Dataset.to_json()`. Issue: #7037 Related PRs: #7039 #7181
closed
2024-11-01T11:54:35
https://api.github.com/repos/huggingface/datasets/issues/7273/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7273", "html_url": "https://github.com/huggingface/datasets/pull/7273", "diff_url": "https://github.com/huggingface/datasets/pull/7273.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7273.patch", "merged_at": "2024-11-18T11:25...
true
Raise error for incorrect JSON serialization Raise error when `lines = False` and `batch_size < Dataset.num_rows` in `Dataset.to_json()`. Issue: #7037 Related PRs: #7039 #7181
[ "PTAL @lhoestq @albertvillanova ", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7273). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7272
7,272
fix conda release worlflow
null
closed
2024-10-31T15:56:19
https://api.github.com/repos/huggingface/datasets/issues/7272/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7272", "html_url": "https://github.com/huggingface/datasets/pull/7272", "diff_url": "https://github.com/huggingface/datasets/pull/7272.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7272.patch", "merged_at": "2024-10-31T15:57...
true
fix conda release worlflow
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7272). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7271
7,271
Set dev version
null
closed
2024-10-31T15:22:51
https://api.github.com/repos/huggingface/datasets/issues/7271/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7271", "html_url": "https://github.com/huggingface/datasets/pull/7271", "diff_url": "https://github.com/huggingface/datasets/pull/7271.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7271.patch", "merged_at": "2024-10-31T15:22...
true
Set dev version
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7271). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7270
7,270
Release: 3.1.0
null
closed
2024-10-31T15:10:01
https://api.github.com/repos/huggingface/datasets/issues/7270/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7270", "html_url": "https://github.com/huggingface/datasets/pull/7270", "diff_url": "https://github.com/huggingface/datasets/pull/7270.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7270.patch", "merged_at": "2024-10-31T15:14...
true
Release: 3.1.0
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7270). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7269
7,269
Memory leak when streaming
### Describe the bug I try to use a dataset with streaming=True, the issue I have is that the RAM usage becomes higher and higher until it is no longer sustainable. I understand that huggingface store data in ram during the streaming, and more worker in dataloader there are, more a lot of shard will be stored in ...
open
2024-10-31T13:33:52
https://api.github.com/repos/huggingface/datasets/issues/7269/comments
null
false
Memory leak when streaming ### Describe the bug I try to use a dataset with streaming=True, the issue I have is that the RAM usage becomes higher and higher until it is no longer sustainable. I understand that huggingface store data in ram during the streaming, and more worker in dataloader there are, more a lot ...
[ "I seem to have encountered the same problem when loading non streaming datasets. load_from_disk. Causing hundreds of GB of memory, but the dataset actually only has 50GB", "FYI when streaming parquet data, only one row group per worker is loaded in memory at a time.\r\n\r\nBtw for datasets of embeddings you can ...
https://api.github.com/repos/huggingface/datasets/issues/7268
7,268
load_from_disk
### Describe the bug I have data saved with save_to_disk. The data is big (700Gb). When I try loading it, the only option is load_from_disk, and this function copies the data to a tmp directory, causing me to run out of disk space. Is there an alternative solution to that? ### Steps to reproduce the bug when trying ...
open
2024-10-31T11:51:56
https://api.github.com/repos/huggingface/datasets/issues/7268/comments
null
false
load_from_disk ### Describe the bug I have data saved with save_to_disk. The data is big (700Gb). When I try loading it, the only option is load_from_disk, and this function copies the data to a tmp directory, causing me to run out of disk space. Is there an alternative solution to that? ### Steps to reproduce the bu...
[ "Hello, It's an interesting issue here. I have the same problem, I have a local dataset and I want to push the dataset to the hub but huggingface does a copy of it.\r\n\r\n```py\r\nfrom datasets import load_dataset\r\n\r\ndataset = load_dataset(\"webdataset\", data_files=\"/media/works/data/*.tar\") # copy here\r\n...
https://api.github.com/repos/huggingface/datasets/issues/7267
7,267
Source installation fails on Macintosh with python 3.10
### Describe the bug Hi, Decord is a dev dependency not maintained since couple years. It does not have an ARM package available rendering it uninstallable on non-intel based macs Suggestion is to move to eva-decord (https://github.com/georgia-tech-db/eva-decord) which doesnt have this problem. Happy to...
open
2024-10-31T10:18:45
https://api.github.com/repos/huggingface/datasets/issues/7267/comments
null
false
Source installation fails on Macintosh with python 3.10 ### Describe the bug Hi, Decord is a dev dependency not maintained since couple years. It does not have an ARM package available rendering it uninstallable on non-intel based macs Suggestion is to move to eva-decord (https://github.com/georgia-tech-db/e...
[ "I encountered the same problem on M1, a workaround I did was to simply comment out the dependency:\r\n\r\n```python\r\n...\r\n \"zstandard\",\r\n \"polars[timezone]>=0.20.0\",\r\n # \"decord==0.6.0\",\r\n]\r\n```\r\n\r\nThis worked for me as the adjustments I did to the code do not use the dependency, but...
https://api.github.com/repos/huggingface/datasets/issues/7266
7,266
The dataset viewer should be available soon. Please retry later.
### Describe the bug After waiting for 2 hours, it still presents ``The dataset viewer should be available soon. Please retry later.'' ### Steps to reproduce the bug dataset link: https://huggingface.co/datasets/BryanW/HI_EDIT ### Expected behavior Present the dataset viewer. ### Environment info NA
closed
2024-10-30T16:32:00
https://api.github.com/repos/huggingface/datasets/issues/7266/comments
null
false
The dataset viewer should be available soon. Please retry later. ### Describe the bug After waiting for 2 hours, it still presents ``The dataset viewer should be available soon. Please retry later.'' ### Steps to reproduce the bug dataset link: https://huggingface.co/datasets/BryanW/HI_EDIT ### Expected behavior P...
[ "Waiting is all you need. 10 hours later, it works." ]
https://api.github.com/repos/huggingface/datasets/issues/7265
7,265
Disallow video push_to_hub
null
closed
2024-10-30T13:21:55
https://api.github.com/repos/huggingface/datasets/issues/7265/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7265", "html_url": "https://github.com/huggingface/datasets/pull/7265", "diff_url": "https://github.com/huggingface/datasets/pull/7265.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7265.patch", "merged_at": "2024-10-30T13:36...
true
Disallow video push_to_hub
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7265). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7264
7,264
fix docs relative links
null
closed
2024-10-30T13:07:34
https://api.github.com/repos/huggingface/datasets/issues/7264/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7264", "html_url": "https://github.com/huggingface/datasets/pull/7264", "diff_url": "https://github.com/huggingface/datasets/pull/7264.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7264.patch", "merged_at": "2024-10-30T13:09...
true
fix docs relative links
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7264). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7263
7,263
Small addition to video docs
null
closed
2024-10-29T16:58:37
https://api.github.com/repos/huggingface/datasets/issues/7263/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7263", "html_url": "https://github.com/huggingface/datasets/pull/7263", "diff_url": "https://github.com/huggingface/datasets/pull/7263.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7263.patch", "merged_at": "2024-10-29T16:59...
true
Small addition to video docs
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7263). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7262
7,262
Allow video with disabeld decoding without decord
for the viewer, this way it can use Video(decode=False) and doesn't need decord (which causes segfaults)
closed
2024-10-29T10:54:04
https://api.github.com/repos/huggingface/datasets/issues/7262/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7262", "html_url": "https://github.com/huggingface/datasets/pull/7262", "diff_url": "https://github.com/huggingface/datasets/pull/7262.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7262.patch", "merged_at": "2024-10-29T10:55...
true
Allow video with disabeld decoding without decord for the viewer, this way it can use Video(decode=False) and doesn't need decord (which causes segfaults)
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7262). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7261
7,261
Cannot load the cache when mapping the dataset
### Describe the bug I'm training the flux controlnet. The train_dataset.map() takes long time to finish. However, when I killed one training process and want to restart a new training with the same dataset. I can't reuse the mapped result even I defined the cache dir for the dataset. with accelerator.main_process_...
open
2024-10-29T08:29:40
https://api.github.com/repos/huggingface/datasets/issues/7261/comments
null
false
Cannot load the cache when mapping the dataset ### Describe the bug I'm training the flux controlnet. The train_dataset.map() takes long time to finish. However, when I killed one training process and want to restart a new training with the same dataset. I can't reuse the mapped result even I defined the cache dir for...
[ "@zhangn77 Hi ,have you solved this problem? I encountered the same issue during training. Could we discuss it?", "I also encountered the same problem, why is that?" ]
https://api.github.com/repos/huggingface/datasets/issues/7260
7,260
cache can't cleaned or disabled
### Describe the bug I tried following ways, the cache can't be disabled. I got 2T data, but I also got more than 2T cache file. I got pressure on storage. I need to diable cache or cleaned immediately after processed. Following ways are all not working, please give some help! ```python from datasets import ...
open
2024-10-29T03:15:28
https://api.github.com/repos/huggingface/datasets/issues/7260/comments
null
false
cache can't cleaned or disabled ### Describe the bug I tried following ways, the cache can't be disabled. I got 2T data, but I also got more than 2T cache file. I got pressure on storage. I need to diable cache or cleaned immediately after processed. Following ways are all not working, please give some help! ...
[ "Hey I have a similar problem and found a workaround using [temporary directories](https://docs.python.org/3/library/tempfile.html):\r\n\r\n```python\r\nfrom tempfile import TemporaryDirectory\r\n\r\nwith TemporaryDirectory() as cache_dir:\r\n data = load_dataset('json', data_files=save_local_path, split='train'...
https://api.github.com/repos/huggingface/datasets/issues/7259
7,259
Don't embed videos
don't include video bytes when running download_and_prepare(format="parquet") this also affects push_to_hub which will just upload the local paths of the videos though
closed
2024-10-28T16:25:10
https://api.github.com/repos/huggingface/datasets/issues/7259/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7259", "html_url": "https://github.com/huggingface/datasets/pull/7259", "diff_url": "https://github.com/huggingface/datasets/pull/7259.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7259.patch", "merged_at": "2024-10-28T16:26...
true
Don't embed videos don't include video bytes when running download_and_prepare(format="parquet") this also affects push_to_hub which will just upload the local paths of the videos though
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7259). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7258
7,258
Always set non-null writer batch size
bug introduced in #7230, it was preventing the Viewer limit writes to work
closed
2024-10-28T15:26:14
https://api.github.com/repos/huggingface/datasets/issues/7258/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7258", "html_url": "https://github.com/huggingface/datasets/pull/7258", "diff_url": "https://github.com/huggingface/datasets/pull/7258.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7258.patch", "merged_at": "2024-10-28T15:26...
true
Always set non-null writer batch size bug introduced in #7230, it was preventing the Viewer limit writes to work
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7258). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7257
7,257
fix ci for pyarrow 18
null
closed
2024-10-28T14:31:34
https://api.github.com/repos/huggingface/datasets/issues/7257/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7257", "html_url": "https://github.com/huggingface/datasets/pull/7257", "diff_url": "https://github.com/huggingface/datasets/pull/7257.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7257.patch", "merged_at": "2024-10-28T14:31...
true
fix ci for pyarrow 18
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7257). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7256
7,256
Retry all requests timeouts
as reported in https://github.com/huggingface/datasets/issues/6843
closed
2024-10-28T14:23:16
https://api.github.com/repos/huggingface/datasets/issues/7256/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7256", "html_url": "https://github.com/huggingface/datasets/pull/7256", "diff_url": "https://github.com/huggingface/datasets/pull/7256.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7256.patch", "merged_at": "2024-10-28T14:56...
true
Retry all requests timeouts as reported in https://github.com/huggingface/datasets/issues/6843
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7256). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7255
7,255
fix decord import
delay the import until Video() is instantiated + also import duckdb first (otherwise importing duckdb later causes a segfault)
closed
2024-10-28T14:08:19
https://api.github.com/repos/huggingface/datasets/issues/7255/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7255", "html_url": "https://github.com/huggingface/datasets/pull/7255", "diff_url": "https://github.com/huggingface/datasets/pull/7255.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7255.patch", "merged_at": "2024-10-28T14:09...
true
fix decord import delay the import until Video() is instantiated + also import duckdb first (otherwise importing duckdb later causes a segfault)
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7255). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7254
7,254
mismatch for datatypes when providing `Features` with `Array2D` and user specified `dtype` and using with_format("numpy")
### Describe the bug If the user provides a `Features` type value to `datasets.Dataset` with members having `Array2D` with a value for `dtype`, it is not respected during `with_format("numpy")` which should return a `np.array` with `dtype` that the user provided for `Array2D`. It seems for floats, it will be set to `f...
open
2024-10-26T22:06:27
https://api.github.com/repos/huggingface/datasets/issues/7254/comments
null
false
mismatch for datatypes when providing `Features` with `Array2D` and user specified `dtype` and using with_format("numpy") ### Describe the bug If the user provides a `Features` type value to `datasets.Dataset` with members having `Array2D` with a value for `dtype`, it is not respected during `with_format("numpy")` whi...
[ "It seems that https://github.com/huggingface/datasets/issues/5517 is exactly the same issue.\r\n\r\nIt was mentioned there that this would be fixed in version 3.x" ]
https://api.github.com/repos/huggingface/datasets/issues/7253
7,253
Unable to upload a large dataset zip either from command line or UI
### Describe the bug Unable to upload a large dataset zip from command line or UI. UI simply says error. I am trying to a upload a tar.gz file of 17GB. <img width="550" alt="image" src="https://github.com/user-attachments/assets/f9d29024-06c8-49c4-a109-0492cff79d34"> <img width="755" alt="image" src="https://githu...
open
2024-10-26T13:17:06
https://api.github.com/repos/huggingface/datasets/issues/7253/comments
null
false
Unable to upload a large dataset zip either from command line or UI ### Describe the bug Unable to upload a large dataset zip from command line or UI. UI simply says error. I am trying to a upload a tar.gz file of 17GB. <img width="550" alt="image" src="https://github.com/user-attachments/assets/f9d29024-06c8-49c4-...
[]
https://api.github.com/repos/huggingface/datasets/issues/7252
7,252
Add IterableDataset.shard()
Will be useful to distribute a dataset across workers (other than pytorch) like spark I also renamed `.n_shards` -> `.num_shards` for consistency and kept the old name for backward compatibility. And a few changes in internal functions for consistency as well (rank, world_size -> num_shards, index) Breaking chang...
closed
2024-10-25T11:07:12
https://api.github.com/repos/huggingface/datasets/issues/7252/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7252", "html_url": "https://github.com/huggingface/datasets/pull/7252", "diff_url": "https://github.com/huggingface/datasets/pull/7252.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7252.patch", "merged_at": "2024-10-25T15:45...
true
Add IterableDataset.shard() Will be useful to distribute a dataset across workers (other than pytorch) like spark I also renamed `.n_shards` -> `.num_shards` for consistency and kept the old name for backward compatibility. And a few changes in internal functions for consistency as well (rank, world_size -> num_shar...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7252). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Is there some way to get this to work for pytorch dataloader workers?\r\n\r\neg. start ...
https://api.github.com/repos/huggingface/datasets/issues/7251
7,251
Missing video docs
null
closed
2024-10-24T16:45:12
https://api.github.com/repos/huggingface/datasets/issues/7251/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7251", "html_url": "https://github.com/huggingface/datasets/pull/7251", "diff_url": "https://github.com/huggingface/datasets/pull/7251.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7251.patch", "merged_at": "2024-10-24T16:48...
true
Missing video docs
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7251). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7250
7,250
Basic XML support (mostly copy pasted from text)
enable the viewer for datasets like https://huggingface.co/datasets/FrancophonIA/e-calm (there will be more and more apparently)
closed
2024-10-24T16:14:50
https://api.github.com/repos/huggingface/datasets/issues/7250/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7250", "html_url": "https://github.com/huggingface/datasets/pull/7250", "diff_url": "https://github.com/huggingface/datasets/pull/7250.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7250.patch", "merged_at": "2024-10-24T16:19...
true
Basic XML support (mostly copy pasted from text) enable the viewer for datasets like https://huggingface.co/datasets/FrancophonIA/e-calm (there will be more and more apparently)
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7250). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7249
7,249
How to debugging
### Describe the bug I wanted to use my own script to handle the processing, and followed the tutorial documentation by rewriting the MyDatasetConfig and MyDatasetBuilder (which contains the _info,_split_generators and _generate_examples methods) classes. Testing with simple data was able to output the results of the ...
open
2024-10-24T01:03:51
https://api.github.com/repos/huggingface/datasets/issues/7249/comments
null
false
How to debugging ### Describe the bug I wanted to use my own script to handle the processing, and followed the tutorial documentation by rewriting the MyDatasetConfig and MyDatasetBuilder (which contains the _info,_split_generators and _generate_examples methods) classes. Testing with simple data was able to output th...
[]
https://api.github.com/repos/huggingface/datasets/issues/7248
7,248
ModuleNotFoundError: No module named 'datasets.tasks'
### Describe the bug --------------------------------------------------------------------------- ModuleNotFoundError Traceback (most recent call last) [<ipython-input-9-13b5f31bd391>](https://bcb6shpazyu-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab_20241022-060119_R...
open
2024-10-23T21:58:25
https://api.github.com/repos/huggingface/datasets/issues/7248/comments
null
false
ModuleNotFoundError: No module named 'datasets.tasks' ### Describe the bug --------------------------------------------------------------------------- ModuleNotFoundError Traceback (most recent call last) [<ipython-input-9-13b5f31bd391>](https://bcb6shpazyu-496ff2e9c6d22116-0-colab.googleuserco...
[ "tasks was removed in v3: #6999 \r\n\r\nI also don't see why TextClassification is imported, since it's not used after. So the fix is simple: delete this line.", "I opened https://huggingface.co/datasets/knowledgator/events_classification_biotech/discussions/7 to remove the line, hopefully the dataset owner will ...
https://api.github.com/repos/huggingface/datasets/issues/7247
7,247
Adding column with dict struction when mapping lead to wrong order
### Describe the bug in `map()` function, I want to add a new column with a dict structure. ``` def map_fn(example): example['text'] = {'user': ..., 'assistant': ...} return example ``` However this leads to a wrong order `{'assistant':..., 'user':...}` in the dataset. Thus I can't concatenate two datasets ...
open
2024-10-22T18:55:11
https://api.github.com/repos/huggingface/datasets/issues/7247/comments
null
false
Adding column with dict struction when mapping lead to wrong order ### Describe the bug in `map()` function, I want to add a new column with a dict structure. ``` def map_fn(example): example['text'] = {'user': ..., 'assistant': ...} return example ``` However this leads to a wrong order `{'assistant':..., '...
[]
https://api.github.com/repos/huggingface/datasets/issues/7246
7,246
Set dev version
null
closed
2024-10-22T15:04:47
https://api.github.com/repos/huggingface/datasets/issues/7246/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7246", "html_url": "https://github.com/huggingface/datasets/pull/7246", "diff_url": "https://github.com/huggingface/datasets/pull/7246.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7246.patch", "merged_at": "2024-10-22T15:04...
true
Set dev version
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7246). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7245
7,245
Release: 3.0.2
null
closed
2024-10-22T14:53:34
https://api.github.com/repos/huggingface/datasets/issues/7245/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7245", "html_url": "https://github.com/huggingface/datasets/pull/7245", "diff_url": "https://github.com/huggingface/datasets/pull/7245.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7245.patch", "merged_at": "2024-10-22T15:01...
true
Release: 3.0.2
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7245). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7244
7,244
use huggingface_hub offline mode
and better handling of LocalEntryNotfoundError cc @Wauplin follow up to #7234
closed
2024-10-22T13:27:16
https://api.github.com/repos/huggingface/datasets/issues/7244/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7244", "html_url": "https://github.com/huggingface/datasets/pull/7244", "diff_url": "https://github.com/huggingface/datasets/pull/7244.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7244.patch", "merged_at": "2024-10-22T14:10...
true
use huggingface_hub offline mode and better handling of LocalEntryNotfoundError cc @Wauplin follow up to #7234
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7244). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7243
7,243
ArrayXD with None as leading dim incompatible with DatasetCardData
### Describe the bug Creating a dataset with ArrayXD features leads to errors when downloading from hub due to DatasetCardData removing the Nones @lhoestq ### Steps to reproduce the bug ```python import numpy as np from datasets import Array2D, Dataset, Features, load_dataset def examples_generator():...
open
2024-10-21T15:08:13
https://api.github.com/repos/huggingface/datasets/issues/7243/comments
null
false
ArrayXD with None as leading dim incompatible with DatasetCardData ### Describe the bug Creating a dataset with ArrayXD features leads to errors when downloading from hub due to DatasetCardData removing the Nones @lhoestq ### Steps to reproduce the bug ```python import numpy as np from datasets import Ar...
[ "It looks like `CardData` in `huggingface_hub` removes None values where it shouldn't. Indeed it calls `_remove_none` on the return of `to_dict()`:\r\n\r\n```python\r\n def to_dict(self) -> Dict[str, Any]:\r\n \"\"\"Converts CardData to a dict.\r\n\r\n Returns:\r\n `dict`: CardData repre...
https://api.github.com/repos/huggingface/datasets/issues/7241
7,241
`push_to_hub` overwrite argument
### Feature request Add an `overwrite` argument to the `push_to_hub` method. ### Motivation I want to overwrite a repo without deleting it on Hugging Face. Is this possible? I couldn't find anything in the documentation or tutorials. ### Your contribution I can create a PR.
closed
2024-10-20T03:23:26
https://api.github.com/repos/huggingface/datasets/issues/7241/comments
null
false
`push_to_hub` overwrite argument ### Feature request Add an `overwrite` argument to the `push_to_hub` method. ### Motivation I want to overwrite a repo without deleting it on Hugging Face. Is this possible? I couldn't find anything in the documentation or tutorials. ### Your contribution I can create a PR.
[ "Hi ! Do you mean deleting all the files ? or erasing the repository git history before push_to_hub ?", "Hi! I meant the latter.", "I don't think there is a `huggingface_hub` utility to erase the git history, cc @Wauplin maybe ?", "What is the goal exactly of deleting all the git history without deleting the ...
https://api.github.com/repos/huggingface/datasets/issues/7240
7,240
Feature Request: Add functionality to pass split types like train, test in DatasetDict.map
Hello datasets! We often encounter situations where we need to preprocess data differently depending on split types such as train, valid, and test. However, while DatasetDict.map has features to pass rank or index, there's no functionality to pass split types. Therefore, I propose adding a 'with_splits' parame...
closed
2024-10-19T09:59:12
https://api.github.com/repos/huggingface/datasets/issues/7240/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7240", "html_url": "https://github.com/huggingface/datasets/pull/7240", "diff_url": "https://github.com/huggingface/datasets/pull/7240.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7240.patch", "merged_at": null }
true
Feature Request: Add functionality to pass split types like train, test in DatasetDict.map Hello datasets! We often encounter situations where we need to preprocess data differently depending on split types such as train, valid, and test. However, while DatasetDict.map has features to pass rank or index, there's...
[]
https://api.github.com/repos/huggingface/datasets/issues/7238
7,238
incompatibily issue when using load_dataset with datasets==3.0.1
### Describe the bug There is a bug when using load_dataset with dataset version at 3.0.1 . Please see below in the "steps to reproduce the bug". To resolve the bug, I had to downgrade to version 2.21.0 OS: Ubuntu 24 (AWS instance) Python: same bug under 3.12 and 3.10 The error I had was: Traceback (most rec...
open
2024-10-18T21:25:23
https://api.github.com/repos/huggingface/datasets/issues/7238/comments
null
false
incompatibily issue when using load_dataset with datasets==3.0.1 ### Describe the bug There is a bug when using load_dataset with dataset version at 3.0.1 . Please see below in the "steps to reproduce the bug". To resolve the bug, I had to downgrade to version 2.21.0 OS: Ubuntu 24 (AWS instance) Python: same bug u...
[ "Hi! I'm also getting the same issue - have you been able to find a solution to this? ", "From what I remember, I stayed at the \"downgraded\" version of dataset (2.21.0)" ]
https://api.github.com/repos/huggingface/datasets/issues/7236
7,236
[MINOR:TYPO] Update arrow_dataset.py
Fix wrong link. csv kwargs docstring link was pointing to pandas json docs.
closed
2024-10-18T12:10:03
https://api.github.com/repos/huggingface/datasets/issues/7236/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7236", "html_url": "https://github.com/huggingface/datasets/pull/7236", "diff_url": "https://github.com/huggingface/datasets/pull/7236.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7236.patch", "merged_at": "2024-10-24T15:06...
true
[MINOR:TYPO] Update arrow_dataset.py Fix wrong link. csv kwargs docstring link was pointing to pandas json docs.
[]
https://api.github.com/repos/huggingface/datasets/issues/7234
7,234
No need for dataset_info
save a useless call to /api/datasets/repo_id
closed
2024-10-17T09:54:03
https://api.github.com/repos/huggingface/datasets/issues/7234/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7234", "html_url": "https://github.com/huggingface/datasets/pull/7234", "diff_url": "https://github.com/huggingface/datasets/pull/7234.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7234.patch", "merged_at": "2024-10-21T16:44...
true
No need for dataset_info save a useless call to /api/datasets/repo_id
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7234). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "merging this one for now, let me know if you'd like to see additional changes for error...
https://api.github.com/repos/huggingface/datasets/issues/7233
7,233
数据集数量问题
### Describe the bug 这里我进行大模型微调,当数据集数量为718时,模型可以正常微调,但是当我添加一个在前718个数据集中的数据或者新增一个数据就会报错 ### Steps to reproduce the bug 1. 这里我的数据集可以微调的最后两个数据集是: { "messages": [ { "role": "user", "content": "完成校正装置设计后需要进行哪些工作?" }, { "role": "assistant", "content": "一旦完成校正装置设计后,需要进行系统实际调校...
open
2024-10-17T07:41:44
https://api.github.com/repos/huggingface/datasets/issues/7233/comments
null
false
数据集数量问题 ### Describe the bug 这里我进行大模型微调,当数据集数量为718时,模型可以正常微调,但是当我添加一个在前718个数据集中的数据或者新增一个数据就会报错 ### Steps to reproduce the bug 1. 这里我的数据集可以微调的最后两个数据集是: { "messages": [ { "role": "user", "content": "完成校正装置设计后需要进行哪些工作?" }, { "role": "assistant", "content": "一旦完成校正装置设计后,需要...
[]
https://api.github.com/repos/huggingface/datasets/issues/7232
7,232
(Super tiny doc update) Mention to_polars
polars is also quite popular now, thus this tiny update can tell users polars is supported
closed
2024-10-17T06:08:53
https://api.github.com/repos/huggingface/datasets/issues/7232/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7232", "html_url": "https://github.com/huggingface/datasets/pull/7232", "diff_url": "https://github.com/huggingface/datasets/pull/7232.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7232.patch", "merged_at": "2024-10-24T15:06...
true
(Super tiny doc update) Mention to_polars polars is also quite popular now, thus this tiny update can tell users polars is supported
[ "You are welcome!" ]
https://api.github.com/repos/huggingface/datasets/issues/7231
7,231
Fix typo in image dataset docs
Fix typo in image dataset docs. Typo reported by @datavistics.
closed
2024-10-16T14:05:46
https://api.github.com/repos/huggingface/datasets/issues/7231/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7231", "html_url": "https://github.com/huggingface/datasets/pull/7231", "diff_url": "https://github.com/huggingface/datasets/pull/7231.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7231.patch", "merged_at": "2024-10-16T17:06...
true
Fix typo in image dataset docs Fix typo in image dataset docs. Typo reported by @datavistics.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7231). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7230
7,230
Video support
(wip and experimental) adding the `Video` type based on `VideoReader` from `decord` ```python >>>from datasets import load_dataset >>> ds = load_dataset("path/to/videos", split="train").with_format("torch") >>> print(ds[0]["video"]) <decord.video_reader.VideoReader object at 0x337a47910> >>> print(ds[0]["vid...
closed
2024-10-15T18:17:29
https://api.github.com/repos/huggingface/datasets/issues/7230/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7230", "html_url": "https://github.com/huggingface/datasets/pull/7230", "diff_url": "https://github.com/huggingface/datasets/pull/7230.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7230.patch", "merged_at": "2024-10-24T16:39...
true
Video support (wip and experimental) adding the `Video` type based on `VideoReader` from `decord` ```python >>>from datasets import load_dataset >>> ds = load_dataset("path/to/videos", split="train").with_format("torch") >>> print(ds[0]["video"]) <decord.video_reader.VideoReader object at 0x337a47910> >>> pr...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7230). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7229
7,229
handle config_name=None in push_to_hub
This caught me out - thought it might be better to explicitly handle None?
closed
2024-10-15T13:48:57
https://api.github.com/repos/huggingface/datasets/issues/7229/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7229", "html_url": "https://github.com/huggingface/datasets/pull/7229", "diff_url": "https://github.com/huggingface/datasets/pull/7229.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7229.patch", "merged_at": null }
true
handle config_name=None in push_to_hub This caught me out - thought it might be better to explicitly handle None?
[ "not sure it's a good idea, we always need a config name so better have the correct default and not support None (which could lead to think it doesn't have a config name, while it does)" ]
https://api.github.com/repos/huggingface/datasets/issues/7228
7,228
Composite (multi-column) features
### Feature request Structured data types (graphs etc.) might often be most efficiently stored as multiple columns, which then need to be combined during feature decoding Although it is currently possible to nest features as structs, my impression is that in particular when dealing with e.g. a feature composed of...
open
2024-10-14T23:59:19
https://api.github.com/repos/huggingface/datasets/issues/7228/comments
null
false
Composite (multi-column) features ### Feature request Structured data types (graphs etc.) might often be most efficiently stored as multiple columns, which then need to be combined during feature decoding Although it is currently possible to nest features as structs, my impression is that in particular when deali...
[]
https://api.github.com/repos/huggingface/datasets/issues/7227
7,227
fast array extraction
Implements #7210 using method suggested in https://github.com/huggingface/datasets/pull/7207#issuecomment-2411789307 ```python import numpy as np from datasets import Dataset, Features, Array3D features=Features(**{"array0": Array3D((None, 10, 10), dtype="float32"), "array1": Array3D((None,10,10), dtype="float3...
open
2024-10-14T20:51:32
https://api.github.com/repos/huggingface/datasets/issues/7227/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7227", "html_url": "https://github.com/huggingface/datasets/pull/7227", "diff_url": "https://github.com/huggingface/datasets/pull/7227.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7227.patch", "merged_at": null }
true
fast array extraction Implements #7210 using method suggested in https://github.com/huggingface/datasets/pull/7207#issuecomment-2411789307 ```python import numpy as np from datasets import Dataset, Features, Array3D features=Features(**{"array0": Array3D((None, 10, 10), dtype="float32"), "array1": Array3D((None...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7227). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "I've updated the most straightforward failing test cases - lmk if you agree with those....
https://api.github.com/repos/huggingface/datasets/issues/7226
7,226
Add R as a How to use from the Polars (R) Library as an option
### Feature request The boiler plate code to access a dataset via the hugging face file system is very useful. Please addd ## Add Polars (R) option The equivailent code works, because the [Polars-R](https://github.com/pola-rs/r-polars) wrapper has hugging faces funcitonaliy as well. ```r library(polars) ...
open
2024-10-14T19:56:07
https://api.github.com/repos/huggingface/datasets/issues/7226/comments
null
false
Add R as a How to use from the Polars (R) Library as an option ### Feature request The boiler plate code to access a dataset via the hugging face file system is very useful. Please addd ## Add Polars (R) option The equivailent code works, because the [Polars-R](https://github.com/pola-rs/r-polars) wrapper has...
[]
https://api.github.com/repos/huggingface/datasets/issues/7225
7,225
Huggingface GIT returns null as Content-Type instead of application/x-git-receive-pack-result
### Describe the bug We push changes to our datasets programmatically. Our git client jGit reports that the hf git server returns null as Content-Type after a push. ### Steps to reproduce the bug A basic kotlin application: ``` val person = PersonIdent( "padmalcom", "padmalcom@sth.com" ) ...
open
2024-10-14T14:33:06
https://api.github.com/repos/huggingface/datasets/issues/7225/comments
null
false
Huggingface GIT returns null as Content-Type instead of application/x-git-receive-pack-result ### Describe the bug We push changes to our datasets programmatically. Our git client jGit reports that the hf git server returns null as Content-Type after a push. ### Steps to reproduce the bug A basic kotlin application:...
[]
https://api.github.com/repos/huggingface/datasets/issues/7224
7,224
fallback to default feature casting in case custom features not available during dataset loading
a fix for #7223 in case datasets is happy to support this kind of extensibility! seems cool / powerful for allowing sharing of datasets with potentially different feature types
open
2024-10-12T16:13:56
https://api.github.com/repos/huggingface/datasets/issues/7224/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7224", "html_url": "https://github.com/huggingface/datasets/pull/7224", "diff_url": "https://github.com/huggingface/datasets/pull/7224.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7224.patch", "merged_at": null }
true
fallback to default feature casting in case custom features not available during dataset loading a fix for #7223 in case datasets is happy to support this kind of extensibility! seems cool / powerful for allowing sharing of datasets with potentially different feature types
[]
https://api.github.com/repos/huggingface/datasets/issues/7223
7,223
Fallback to arrow defaults when loading dataset with custom features that aren't registered locally
### Describe the bug Datasets allows users to create and register custom features. However if datasets are then pushed to the hub, this means that anyone calling load_dataset without registering the custom Features in the same way as the dataset creator will get an error message. It would be nice to offer a fall...
open
2024-10-12T16:08:20
https://api.github.com/repos/huggingface/datasets/issues/7223/comments
null
false
Fallback to arrow defaults when loading dataset with custom features that aren't registered locally ### Describe the bug Datasets allows users to create and register custom features. However if datasets are then pushed to the hub, this means that anyone calling load_dataset without registering the custom Features i...
[]
https://api.github.com/repos/huggingface/datasets/issues/7222
7,222
TypeError: Couldn't cast array of type string to null in long json
### Describe the bug In general, changing the type from string to null is allowed within a dataset — there are even examples of this in the documentation. However, if the dataset is large and unevenly distributed, this allowance stops working. The schema gets locked in after reading a chunk. Consequently, if al...
open
2024-10-12T08:14:59
https://api.github.com/repos/huggingface/datasets/issues/7222/comments
null
false
TypeError: Couldn't cast array of type string to null in long json ### Describe the bug In general, changing the type from string to null is allowed within a dataset — there are even examples of this in the documentation. However, if the dataset is large and unevenly distributed, this allowance stops working. The s...
[ "I am encountering this same issue. It seems that the library manages to recognise an optional column (but not **exclusively** null) if there is at least one non-null instance within the same file. For example, given a `test_0.jsonl` file:\r\n```json\r\n{\"a\": \"a1\", \"b\": \"b1\", \"c\": null, \"d\": null}\r\n{\...
https://api.github.com/repos/huggingface/datasets/issues/7221
7,221
add CustomFeature base class to support user-defined features with encoding/decoding logic
intended as fix for #7220 if this kind of extensibility is something that datasets is willing to support! ```python from datasets.features.features import CustomFeature class ListOfStrs(CustomFeature): requires_encoding = True def _encode_example(self, value): if isinstance(value, str): ...
closed
2024-10-11T20:10:27
https://api.github.com/repos/huggingface/datasets/issues/7221/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7221", "html_url": "https://github.com/huggingface/datasets/pull/7221", "diff_url": "https://github.com/huggingface/datasets/pull/7221.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7221.patch", "merged_at": null }
true
add CustomFeature base class to support user-defined features with encoding/decoding logic intended as fix for #7220 if this kind of extensibility is something that datasets is willing to support! ```python from datasets.features.features import CustomFeature class ListOfStrs(CustomFeature): requires_en...
[ "@lhoestq would you be open to supporting this kind of extensibility?", "I suggested a fix in https://github.com/huggingface/datasets/issues/7220 that would not necessarily require a parent class for custom features, lmk what you think" ]
https://api.github.com/repos/huggingface/datasets/issues/7220
7,220
Custom features not compatible with special encoding/decoding logic
### Describe the bug It is possible to register custom features using datasets.features.features.register_feature (https://github.com/huggingface/datasets/pull/6727) However such features are not compatible with Features.encode_example/decode_example if they require special encoding / decoding logic because encod...
open
2024-10-11T19:20:11
https://api.github.com/repos/huggingface/datasets/issues/7220/comments
null
false
Custom features not compatible with special encoding/decoding logic ### Describe the bug It is possible to register custom features using datasets.features.features.register_feature (https://github.com/huggingface/datasets/pull/6727) However such features are not compatible with Features.encode_example/decode_exa...
[ "I think you can fix this simply by replacing the line with hardcoded features with `hastattr(schema, \"encode_example\")` actually", "#7284 " ]
https://api.github.com/repos/huggingface/datasets/issues/7219
7,219
bump fsspec
null
closed
2024-10-11T15:56:36
https://api.github.com/repos/huggingface/datasets/issues/7219/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7219", "html_url": "https://github.com/huggingface/datasets/pull/7219", "diff_url": "https://github.com/huggingface/datasets/pull/7219.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7219.patch", "merged_at": "2024-10-14T08:21...
true
bump fsspec
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7219). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7217
7,217
ds.map(f, num_proc=10) is slower than df.apply
### Describe the bug pandas columns: song_id, song_name ds = Dataset.from_pandas(df) def has_cover(song_name): if song_name is None or pd.isna(song_name): return False return 'cover' in song_name.lower() df['has_cover'] = df.song_name.progress_apply(has_cover) ds = ds.map(lambda x: {'has_cov...
open
2024-10-11T11:04:05
https://api.github.com/repos/huggingface/datasets/issues/7217/comments
null
false
ds.map(f, num_proc=10) is slower than df.apply ### Describe the bug pandas columns: song_id, song_name ds = Dataset.from_pandas(df) def has_cover(song_name): if song_name is None or pd.isna(song_name): return False return 'cover' in song_name.lower() df['has_cover'] = df.song_name.progress_ap...
[ "Hi ! `map()` reads all the columns and writes the resulting dataset with all the columns as well, while df.column_name.apply only reads and writes one column and does it in memory. So this is speed difference is actually expected.\r\n\r\nMoreover using multiprocessing on a dataset that lives in memory (from_pandas...
https://api.github.com/repos/huggingface/datasets/issues/7215
7,215
Iterable dataset map with explicit features causes slowdown for Sequence features
### Describe the bug When performing map, it's nice to be able to pass the new feature type, and indeed required by interleave and concatenate datasets. However, this can cause a major slowdown for certain types of array features due to the features being re-encoded. This is separate to the slowdown reported i...
open
2024-10-10T22:08:20
https://api.github.com/repos/huggingface/datasets/issues/7215/comments
null
false
Iterable dataset map with explicit features causes slowdown for Sequence features ### Describe the bug When performing map, it's nice to be able to pass the new feature type, and indeed required by interleave and concatenate datasets. However, this can cause a major slowdown for certain types of array features du...
[]
https://api.github.com/repos/huggingface/datasets/issues/7214
7,214
Formatted map + with_format(None) changes array dtype for iterable datasets
### Describe the bug When applying with_format -> map -> with_format(None), array dtypes seem to change, even if features are passed ### Steps to reproduce the bug ```python features=Features(**{"array0": Array3D((None, 10, 10), dtype="float32")}) dataset = Dataset.from_dict({f"array0": [np.zeros((100,10,10...
open
2024-10-10T12:45:16
https://api.github.com/repos/huggingface/datasets/issues/7214/comments
null
false
Formatted map + with_format(None) changes array dtype for iterable datasets ### Describe the bug When applying with_format -> map -> with_format(None), array dtypes seem to change, even if features are passed ### Steps to reproduce the bug ```python features=Features(**{"array0": Array3D((None, 10, 10), dtyp...
[ "possibly due to this logic:\r\n\r\n```python\r\n def _arrow_array_to_numpy(self, pa_array: pa.Array) -> np.ndarray:\r\n if isinstance(pa_array, pa.ChunkedArray):\r\n if isinstance(pa_array.type, _ArrayXDExtensionType):\r\n # don't call to_pylist() to preserve dtype of the fixed-...
https://api.github.com/repos/huggingface/datasets/issues/7213
7,213
Add with_rank to Dataset.from_generator
### Feature request Add `with_rank` to `Dataset.from_generator` similar to `Dataset.map` and `Dataset.filter`. ### Motivation As for `Dataset.map` and `Dataset.filter`, this is useful when creating cache files using multi-GPU, where the rank can be used to select GPU IDs. For now, rank can be added in the `ge...
open
2024-10-10T12:15:29
https://api.github.com/repos/huggingface/datasets/issues/7213/comments
null
false
Add with_rank to Dataset.from_generator ### Feature request Add `with_rank` to `Dataset.from_generator` similar to `Dataset.map` and `Dataset.filter`. ### Motivation As for `Dataset.map` and `Dataset.filter`, this is useful when creating cache files using multi-GPU, where the rank can be used to select GPU ID...
[]
https://api.github.com/repos/huggingface/datasets/issues/7212
7,212
Windows do not supprot signal.alarm and singal.signal
### Describe the bug signal.alarm and signal.signal are used in the load.py module, but these are not supported by Windows. ### Steps to reproduce the bug lighteval accelerate --model_args "pretrained=gpt2,trust_remote_code=True" --tasks "community|kinit_sts" --custom_tasks "community_tasks/kinit_evals.py" --output...
open
2024-10-10T12:00:19
https://api.github.com/repos/huggingface/datasets/issues/7212/comments
null
false
Windows do not supprot signal.alarm and singal.signal ### Describe the bug signal.alarm and signal.signal are used in the load.py module, but these are not supported by Windows. ### Steps to reproduce the bug lighteval accelerate --model_args "pretrained=gpt2,trust_remote_code=True" --tasks "community|kinit_sts" --...
[]
https://api.github.com/repos/huggingface/datasets/issues/7211
7,211
Describe only selected fields in README
### Feature request Hi Datasets team! Is it possible to add the ability to describe only selected fields of the dataset files in `README.md`? For example, I have this open dataset ([open-llm-leaderboard/results](https://huggingface.co/datasets/open-llm-leaderboard/results?row=0)) and I want to describe only some f...
open
2024-10-09T16:25:47
https://api.github.com/repos/huggingface/datasets/issues/7211/comments
null
false
Describe only selected fields in README ### Feature request Hi Datasets team! Is it possible to add the ability to describe only selected fields of the dataset files in `README.md`? For example, I have this open dataset ([open-llm-leaderboard/results](https://huggingface.co/datasets/open-llm-leaderboard/results?ro...
[]
https://api.github.com/repos/huggingface/datasets/issues/7210
7,210
Convert Array features to numpy arrays rather than lists by default
### Feature request It is currently quite easy to cause massive slowdowns when using datasets and not familiar with the underlying data conversions by e.g. making bad choices of formatting. Would it be more user-friendly to set defaults that avoid this as much as possible? e.g. format Array features as numpy arrays...
open
2024-10-09T13:05:21
https://api.github.com/repos/huggingface/datasets/issues/7210/comments
null
false
Convert Array features to numpy arrays rather than lists by default ### Feature request It is currently quite easy to cause massive slowdowns when using datasets and not familiar with the underlying data conversions by e.g. making bad choices of formatting. Would it be more user-friendly to set defaults that avoid ...
[]
https://api.github.com/repos/huggingface/datasets/issues/7209
7,209
Preserve features in iterable dataset.filter
Fixes example in #7208 - I'm not sure what other checks I should do? @lhoestq I also haven't thought hard about the concatenate / interleaving example iterables but think this might work assuming that features are either all identical or None?
closed
2024-10-09T10:42:05
https://api.github.com/repos/huggingface/datasets/issues/7209/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7209", "html_url": "https://github.com/huggingface/datasets/pull/7209", "diff_url": "https://github.com/huggingface/datasets/pull/7209.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7209.patch", "merged_at": "2024-10-09T16:04...
true
Preserve features in iterable dataset.filter Fixes example in #7208 - I'm not sure what other checks I should do? @lhoestq I also haven't thought hard about the concatenate / interleaving example iterables but think this might work assuming that features are either all identical or None?
[ "Yes your assumption on concatenate/interleave is ok imo.\r\n\r\nIt seems the TypedExamplesIterable can slow down things, it should take formatting into account to not convert numpy arrays to python lists\r\n\r\nright now it's slow (unrelatedly to your PR):\r\n\r\n```python\r\n>>> ds = Dataset.from_dict({\"a\": np....
https://api.github.com/repos/huggingface/datasets/issues/7208
7,208
Iterable dataset.filter should not override features
### Describe the bug When calling filter on an iterable dataset, the features get set to None ### Steps to reproduce the bug import numpy as np import time from datasets import Dataset, Features, Array3D ```python features=Features(**{"array0": Array3D((None, 10, 10), dtype="float32"), "array1": Array3D((None,...
closed
2024-10-09T10:23:45
https://api.github.com/repos/huggingface/datasets/issues/7208/comments
null
false
Iterable dataset.filter should not override features ### Describe the bug When calling filter on an iterable dataset, the features get set to None ### Steps to reproduce the bug import numpy as np import time from datasets import Dataset, Features, Array3D ```python features=Features(**{"array0": Array3D((None...
[ "closed by https://github.com/huggingface/datasets/pull/7209, thanks @alex-hh !" ]
https://api.github.com/repos/huggingface/datasets/issues/7207
7,207
apply formatting after iter_arrow to speed up format -> map, filter for iterable datasets
I got to this by hacking around a bit but it seems to solve #7206 I have no idea if this approach makes sense or would break something else? Could maybe work on a full pr if this looks reasonable @lhoestq ? I imagine the same issue might affect other iterable dataset methods?
closed
2024-10-08T15:44:53
https://api.github.com/repos/huggingface/datasets/issues/7207/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7207", "html_url": "https://github.com/huggingface/datasets/pull/7207", "diff_url": "https://github.com/huggingface/datasets/pull/7207.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7207.patch", "merged_at": "2025-01-14T16:59...
true
apply formatting after iter_arrow to speed up format -> map, filter for iterable datasets I got to this by hacking around a bit but it seems to solve #7206 I have no idea if this approach makes sense or would break something else? Could maybe work on a full pr if this looks reasonable @lhoestq ? I imagine the s...
[ "I think the problem is that the underlying ex_iterable will not use iter_arrow unless the formatting type is arrow, which leads to conversion from arrow -> python -> numpy in this case rather than arrow -> numpy.\r\n\r\nIdea of updated fix is to use the ex_iterable's iter_arrow in any case where it's available and...
https://api.github.com/repos/huggingface/datasets/issues/7206
7,206
Slow iteration for iterable dataset with numpy formatting for array data
### Describe the bug When working with large arrays, setting with_format to e.g. numpy then applying map causes a significant slowdown for iterable datasets. ### Steps to reproduce the bug ```python import numpy as np import time from datasets import Dataset, Features, Array3D features=Features(**{"array...
open
2024-10-08T15:38:11
https://api.github.com/repos/huggingface/datasets/issues/7206/comments
null
false
Slow iteration for iterable dataset with numpy formatting for array data ### Describe the bug When working with large arrays, setting with_format to e.g. numpy then applying map causes a significant slowdown for iterable datasets. ### Steps to reproduce the bug ```python import numpy as np import time from ...
[ "The below easily eats up 32G of RAM. Leaving it for a while bricked the laptop with 16GB.\r\n\r\n```\r\ndataset = load_dataset(\"Voxel51/OxfordFlowers102\", data_dir=\"data\").with_format(\"numpy\")\r\nprocessed_dataset = dataset.map(lambda x: x)\r\n```\r\n\r\n![image](https://github.com/user-attachments/assets/c1...
https://api.github.com/repos/huggingface/datasets/issues/7205
7,205
fix ci benchmark
we're not using the benchmarks anymore + they were not working anyway due to token permissions I keep the code in case we ever want to re-run the benchmark manually
closed
2024-10-08T15:06:18
https://api.github.com/repos/huggingface/datasets/issues/7205/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7205", "html_url": "https://github.com/huggingface/datasets/pull/7205", "diff_url": "https://github.com/huggingface/datasets/pull/7205.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7205.patch", "merged_at": "2024-10-08T15:25...
true
fix ci benchmark we're not using the benchmarks anymore + they were not working anyway due to token permissions I keep the code in case we ever want to re-run the benchmark manually
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7205). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7204
7,204
fix unbatched arrow map for iterable datasets
Fixes the bug when applying map to an arrow-formatted iterable dataset described here: https://github.com/huggingface/datasets/issues/6833#issuecomment-2399903885 ```python from datasets import load_dataset ds = load_dataset("rotten_tomatoes", split="train", streaming=True) ds = ds.with_format("arrow").map(l...
closed
2024-10-08T13:54:09
https://api.github.com/repos/huggingface/datasets/issues/7204/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7204", "html_url": "https://github.com/huggingface/datasets/pull/7204", "diff_url": "https://github.com/huggingface/datasets/pull/7204.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7204.patch", "merged_at": "2024-10-08T14:19...
true
fix unbatched arrow map for iterable datasets Fixes the bug when applying map to an arrow-formatted iterable dataset described here: https://github.com/huggingface/datasets/issues/6833#issuecomment-2399903885 ```python from datasets import load_dataset ds = load_dataset("rotten_tomatoes", split="train", strea...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7204). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7203
7,203
with_format docstring
reported at https://github.com/huggingface/datasets/issues/3444
closed
2024-10-08T13:05:19
https://api.github.com/repos/huggingface/datasets/issues/7203/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7203", "html_url": "https://github.com/huggingface/datasets/pull/7203", "diff_url": "https://github.com/huggingface/datasets/pull/7203.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7203.patch", "merged_at": "2024-10-08T13:13...
true
with_format docstring reported at https://github.com/huggingface/datasets/issues/3444
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7203). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7202
7,202
`from_parquet` return type annotation
### Describe the bug As already posted in https://github.com/microsoft/pylance-release/issues/6534, the correct type hinting fails when building a dataset using the `from_parquet` constructor. Their suggestion is to comprehensively annotate the method's return type to better align with the docstring information. ###...
open
2024-10-08T09:08:10
https://api.github.com/repos/huggingface/datasets/issues/7202/comments
null
false
`from_parquet` return type annotation ### Describe the bug As already posted in https://github.com/microsoft/pylance-release/issues/6534, the correct type hinting fails when building a dataset using the `from_parquet` constructor. Their suggestion is to comprehensively annotate the method's return type to better alig...
[]
https://api.github.com/repos/huggingface/datasets/issues/7201
7,201
`load_dataset()` of images from a single directory where `train.png` image exists
### Describe the bug Hey! Firstly, thanks for maintaining such framework! I had a small issue, where I wanted to load a custom dataset of image+text captioning. I had all of my images in a single directory, and one of the images had the name `train.png`. Then, the loaded dataset had only this image. I guess it'...
open
2024-10-07T09:14:17
https://api.github.com/repos/huggingface/datasets/issues/7201/comments
null
false
`load_dataset()` of images from a single directory where `train.png` image exists ### Describe the bug Hey! Firstly, thanks for maintaining such framework! I had a small issue, where I wanted to load a custom dataset of image+text captioning. I had all of my images in a single directory, and one of the images had ...
[ "#self-assign", "#self-assign" ]
https://api.github.com/repos/huggingface/datasets/issues/7200
7,200
Fix the environment variable for huggingface cache
Resolve #6256. As far as I tested, `HF_DATASETS_CACHE` was ignored and I could not specify the cache directory at all except for the default one by this environment variable. `HF_HOME` has worked. Perhaps the recent change on file downloading by `huggingface_hub` could affect this bug. In my testing, I could not sp...
closed
2024-10-05T11:54:35
https://api.github.com/repos/huggingface/datasets/issues/7200/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7200", "html_url": "https://github.com/huggingface/datasets/pull/7200", "diff_url": "https://github.com/huggingface/datasets/pull/7200.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7200.patch", "merged_at": "2024-10-08T15:45...
true
Fix the environment variable for huggingface cache Resolve #6256. As far as I tested, `HF_DATASETS_CACHE` was ignored and I could not specify the cache directory at all except for the default one by this environment variable. `HF_HOME` has worked. Perhaps the recent change on file downloading by `huggingface_hub` coul...
[ "Hi ! yes now `datasets` uses `huggingface_hub` to download and cache files from the HF Hub so you need to use `HF_HOME` (or manually `HF_HUB_CACHE` and `HF_DATASETS_CACHE` if you want to separate HF Hub cached files and cached datasets Arrow files)\r\n\r\nSo in your change I guess it needs to be `HF_HOME` instead ...
https://api.github.com/repos/huggingface/datasets/issues/7199
7,199
Add with_rank to Dataset.from_generator
Adds `with_rank` to `Dataset.from_generator`. As for `Dataset.map` and `Dataset.filter`, this is useful when creating cache files using multi-GPU.
open
2024-10-04T16:51:53
https://api.github.com/repos/huggingface/datasets/issues/7199/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7199", "html_url": "https://github.com/huggingface/datasets/pull/7199", "diff_url": "https://github.com/huggingface/datasets/pull/7199.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7199.patch", "merged_at": null }
true
Add with_rank to Dataset.from_generator Adds `with_rank` to `Dataset.from_generator`. As for `Dataset.map` and `Dataset.filter`, this is useful when creating cache files using multi-GPU.
[]
https://api.github.com/repos/huggingface/datasets/issues/7198
7,198
Add repeat method to datasets
Following up on discussion in #6623 and #7198 I thought this would be pretty useful for my case so had a go at implementing. My main motivation is to be able to call iterable_dataset.repeat(None).take(samples_per_epoch) to safely avoid timeout issues in a distributed training setting. This would provide a straightfo...
closed
2024-10-04T10:45:16
https://api.github.com/repos/huggingface/datasets/issues/7198/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7198", "html_url": "https://github.com/huggingface/datasets/pull/7198", "diff_url": "https://github.com/huggingface/datasets/pull/7198.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7198.patch", "merged_at": "2025-02-05T16:32...
true
Add repeat method to datasets Following up on discussion in #6623 and #7198 I thought this would be pretty useful for my case so had a go at implementing. My main motivation is to be able to call iterable_dataset.repeat(None).take(samples_per_epoch) to safely avoid timeout issues in a distributed training setting. T...
[ "@lhoestq does this look reasonable?", "updated and added test cases!", "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7198). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "thanks for ...
https://api.github.com/repos/huggingface/datasets/issues/7197
7,197
ConnectionError: Couldn't reach 'allenai/c4' on the Hub (ConnectionError)数据集下不下来,怎么回事
### Describe the bug from datasets import load_dataset print("11") traindata = load_dataset('ptb_text_only', 'penn_treebank', split='train') print("22") valdata = load_dataset('ptb_text_only', 'penn_treebank', split='validation') ### Steps to reproduce the b...
open
2024-10-04T09:33:25
https://api.github.com/repos/huggingface/datasets/issues/7197/comments
null
false
ConnectionError: Couldn't reach 'allenai/c4' on the Hub (ConnectionError)数据集下不下来,怎么回事 ### Describe the bug from datasets import load_dataset print("11") traindata = load_dataset('ptb_text_only', 'penn_treebank', split='train') print("22") valdata = load_dataset('ptb_text_only', 'penn_tr...
[ "Also cant download \"allenai/c4\", but with different error reported:\r\n```\r\nTraceback (most recent call last): ...
https://api.github.com/repos/huggingface/datasets/issues/7196
7,196
concatenate_datasets does not preserve shuffling state
### Describe the bug After concatenate datasets on an iterable dataset, the shuffling state is destroyed, similar to #7156 This means concatenation cant be used for resolving uneven numbers of samples across devices when using iterable datasets in a distributed setting as discussed in #6623 I also noticed th...
closed
2024-10-03T14:30:38
https://api.github.com/repos/huggingface/datasets/issues/7196/comments
null
false
concatenate_datasets does not preserve shuffling state ### Describe the bug After concatenate datasets on an iterable dataset, the shuffling state is destroyed, similar to #7156 This means concatenation cant be used for resolving uneven numbers of samples across devices when using iterable datasets in a distribu...
[ "It also does preserve `split_by_node`, so in the meantime you should call `shuffle` or `split_by_node` AFTER `interleave_datasets` or `concatenate_datasets`" ]
https://api.github.com/repos/huggingface/datasets/issues/7195
7,195
Add support for 3D datasets
See https://huggingface.co/datasets/allenai/objaverse for example
open
2024-10-03T13:27:44
https://api.github.com/repos/huggingface/datasets/issues/7195/comments
null
false
Add support for 3D datasets See https://huggingface.co/datasets/allenai/objaverse for example
[ "maybe related: https://github.com/huggingface/datasets/issues/6388", "Also look at https://github.com/huggingface/dataset-viewer/blob/f5fd117ceded990a7766e705bba1203fa907d6ad/services/worker/src/worker/job_runners/dataset/modalities.py#L241 which lists the 3D file formats that will assign the 3D modality to a da...
https://api.github.com/repos/huggingface/datasets/issues/7194
7,194
datasets.exceptions.DatasetNotFoundError for private dataset
### Describe the bug The following Python code tries to download a private dataset and fails with the error `datasets.exceptions.DatasetNotFoundError: Dataset 'ClimatePolicyRadar/all-document-text-data-weekly' doesn't exist on the Hub or cannot be accessed.`. Downloading a public dataset doesn't work. ``` py fro...
closed
2024-10-03T07:49:36
https://api.github.com/repos/huggingface/datasets/issues/7194/comments
null
false
datasets.exceptions.DatasetNotFoundError for private dataset ### Describe the bug The following Python code tries to download a private dataset and fails with the error `datasets.exceptions.DatasetNotFoundError: Dataset 'ClimatePolicyRadar/all-document-text-data-weekly' doesn't exist on the Hub or cannot be accessed...
[ "Actually there is no such dataset available, that is why you are getting that error.", "Fixed with @kdutia in Slack chat. Generating a new token fixed this issue. " ]
https://api.github.com/repos/huggingface/datasets/issues/7193
7,193
Support of num_workers (multiprocessing) in map for IterableDataset
### Feature request Currently, IterableDataset doesn't support setting num_worker in .map(), which results in slow processing here. Could we add support for it? As .map() can be run in the batch fashion (e.g., batch_size is default to 1000 in datasets), it seems to be doable for IterableDataset as the regular Dataset....
open
2024-10-02T18:34:04
https://api.github.com/repos/huggingface/datasets/issues/7193/comments
null
false
Support of num_workers (multiprocessing) in map for IterableDataset ### Feature request Currently, IterableDataset doesn't support setting num_worker in .map(), which results in slow processing here. Could we add support for it? As .map() can be run in the batch fashion (e.g., batch_size is default to 1000 in datasets...
[ "I was curious about the same - since map is applied on the fly I was assuming that setting num_workers>1 in DataLoader would effectively do the map in parallel, have you tried that?" ]
https://api.github.com/repos/huggingface/datasets/issues/7192
7,192
Add repeat() for iterable datasets
### Feature request It would be useful to be able to straightforwardly repeat iterable datasets indefinitely, to provide complete control over starting and ending of iteration to the user. An IterableDataset.repeat(n) function could do this automatically ### Motivation This feature was discussed in this iss...
closed
2024-10-02T17:48:13
https://api.github.com/repos/huggingface/datasets/issues/7192/comments
null
false
Add repeat() for iterable datasets ### Feature request It would be useful to be able to straightforwardly repeat iterable datasets indefinitely, to provide complete control over starting and ending of iteration to the user. An IterableDataset.repeat(n) function could do this automatically ### Motivation Thi...
[ "perhaps concatenate_datasets can already be used to achieve almost the same effect? ", "`concatenate_datasets` does the job when there is a finite number of repetitions, but in case of `.repeat()` forever we need a new logic in `iterable_dataset.py`", "done in https://github.com/huggingface/datasets/pull/7198"...
https://api.github.com/repos/huggingface/datasets/issues/7191
7,191
Solution to issue: #7080 Modified load_dataset function, so that it prompts the user to select a dataset when subdatasets or splits (train, test) are available
# Feel free to give suggestions please.. ### This PR is raised because of issue: https://github.com/huggingface/datasets/issues/7080 ![image](https://github.com/user-attachments/assets/8fbc604f-f0a5-4a59-a63e-aa4c26442c83) ### This PR gives solution to https://github.com/huggingface/datasets/issues/7080 1. ...
closed
2024-10-02T17:02:45
https://api.github.com/repos/huggingface/datasets/issues/7191/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7191", "html_url": "https://github.com/huggingface/datasets/pull/7191", "diff_url": "https://github.com/huggingface/datasets/pull/7191.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7191.patch", "merged_at": null }
true
Solution to issue: #7080 Modified load_dataset function, so that it prompts the user to select a dataset when subdatasets or splits (train, test) are available # Feel free to give suggestions please.. ### This PR is raised because of issue: https://github.com/huggingface/datasets/issues/7080 ![image](https://gith...
[ "I think the approach presented in https://github.com/huggingface/datasets/pull/6832 is the one we'll be taking.\r\n\r\nAsking user input is not a good idea since `load_dataset` is used a lot in server that don't have someone in front of them to select a split" ]
https://api.github.com/repos/huggingface/datasets/issues/7190
7,190
Datasets conflicts with fsspec 2024.9
### Describe the bug Installing both in latest versions are not possible `pip install "datasets==3.0.1" "fsspec==2024.9.0"` But using older version of datasets is ok `pip install "datasets==1.24.4" "fsspec==2024.9.0"` ### Steps to reproduce the bug `pip install "datasets==3.0.1" "fsspec==2024.9.0"` #...
open
2024-10-02T16:43:46
https://api.github.com/repos/huggingface/datasets/issues/7190/comments
null
false
Datasets conflicts with fsspec 2024.9 ### Describe the bug Installing both in latest versions are not possible `pip install "datasets==3.0.1" "fsspec==2024.9.0"` But using older version of datasets is ok `pip install "datasets==1.24.4" "fsspec==2024.9.0"` ### Steps to reproduce the bug `pip install "dat...
[ "Yes, I need to use the latest version of fsspec and datasets for my usecase. \r\nhttps://github.com/fsspec/s3fs/pull/888#issuecomment-2404204606\r\nhttps://github.com/apache/arrow/issues/34363#issuecomment-2403553473\r\n\r\nlast version where things install without conflict is: 2.14.4\r\n\r\nSo this issue starts f...
https://api.github.com/repos/huggingface/datasets/issues/7189
7,189
Audio preview in dataset viewer for audio array data without a path/filename
### Feature request Huggingface has quite a comprehensive set of guides for [audio datasets](https://huggingface.co/docs/datasets/en/audio_dataset). It seems, however, all these guides assume the audio array data to be decoded/inserted into a HF dataset always originates from individual files. The [Audio-dataclass](...
open
2024-10-02T16:38:38
https://api.github.com/repos/huggingface/datasets/issues/7189/comments
null
false
Audio preview in dataset viewer for audio array data without a path/filename ### Feature request Huggingface has quite a comprehensive set of guides for [audio datasets](https://huggingface.co/docs/datasets/en/audio_dataset). It seems, however, all these guides assume the audio array data to be decoded/inserted into...
[]
https://api.github.com/repos/huggingface/datasets/issues/7188
7,188
Pin multiprocess<0.70.1 to align with dill<0.3.9
Pin multiprocess<0.70.1 to align with dill<0.3.9. Note that multiprocess-0.70.1 requires dill-0.3.9: https://github.com/uqfoundation/multiprocess/releases/tag/0.70.17 Fix #7186.
closed
2024-10-02T05:40:18
https://api.github.com/repos/huggingface/datasets/issues/7188/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7188", "html_url": "https://github.com/huggingface/datasets/pull/7188", "diff_url": "https://github.com/huggingface/datasets/pull/7188.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7188.patch", "merged_at": "2024-10-02T06:08...
true
Pin multiprocess<0.70.1 to align with dill<0.3.9 Pin multiprocess<0.70.1 to align with dill<0.3.9. Note that multiprocess-0.70.1 requires dill-0.3.9: https://github.com/uqfoundation/multiprocess/releases/tag/0.70.17 Fix #7186.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7188). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7187
7,187
shard_data_sources() got an unexpected keyword argument 'worker_id'
### Describe the bug ``` [rank0]: File "/home/qinghao/miniconda3/envs/doremi/lib/python3.10/site-packages/datasets/iterable_dataset.py", line 238, in __iter__ [rank0]: for key_example in islice(self.generate_examples_fn(**gen_kwags), shard_example_idx_start, None): [rank0]: File "/home/qinghao/miniconda3/en...
open
2024-10-02T01:26:35
https://api.github.com/repos/huggingface/datasets/issues/7187/comments
null
false
shard_data_sources() got an unexpected keyword argument 'worker_id' ### Describe the bug ``` [rank0]: File "/home/qinghao/miniconda3/envs/doremi/lib/python3.10/site-packages/datasets/iterable_dataset.py", line 238, in __iter__ [rank0]: for key_example in islice(self.generate_examples_fn(**gen_kwags), shard_exa...
[]
https://api.github.com/repos/huggingface/datasets/issues/7186
7,186
pinning `dill<0.3.9` without pinning `multiprocess`
### Describe the bug The [latest `multiprocess` release](https://github.com/uqfoundation/multiprocess/releases/tag/0.70.17) requires `dill>=0.3.9` which causes issues when installing `datasets` without backtracking during package version resolution. Is it possible to add a pin for multiprocess so something like `multi...
closed
2024-10-01T22:29:32
https://api.github.com/repos/huggingface/datasets/issues/7186/comments
null
false
pinning `dill<0.3.9` without pinning `multiprocess` ### Describe the bug The [latest `multiprocess` release](https://github.com/uqfoundation/multiprocess/releases/tag/0.70.17) requires `dill>=0.3.9` which causes issues when installing `datasets` without backtracking during package version resolution. Is it possible t...
[]
https://api.github.com/repos/huggingface/datasets/issues/7185
7,185
CI benchmarks are broken
Since Aug 30, 2024, CI benchmarks are broken: https://github.com/huggingface/datasets/actions/runs/11108421214/job/30861323975 ``` {"level":"error","message":"Resource not accessible by integration","name":"HttpError","request":{"body":"{\"body\":\"<details>\\n<summary>Show benchmarks</summary>\\n\\nPyArrow==8.0.0\\n...
closed
2024-10-01T08:16:08
https://api.github.com/repos/huggingface/datasets/issues/7185/comments
null
false
CI benchmarks are broken Since Aug 30, 2024, CI benchmarks are broken: https://github.com/huggingface/datasets/actions/runs/11108421214/job/30861323975 ``` {"level":"error","message":"Resource not accessible by integration","name":"HttpError","request":{"body":"{\"body\":\"<details>\\n<summary>Show benchmarks</summar...
[ "Fixed by #7205" ]
https://api.github.com/repos/huggingface/datasets/issues/7184
7,184
Pin dill<0.3.9 to fix CI
Pin dill<0.3.9 to fix CI for deps-latest. Note that dill-0.3.9 was released yesterday Sep 29, 2024: - https://pypi.org/project/dill/0.3.9/ - https://github.com/uqfoundation/dill/releases/tag/0.3.9 Fix #7183.
closed
2024-09-30T14:26:25
https://api.github.com/repos/huggingface/datasets/issues/7184/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7184", "html_url": "https://github.com/huggingface/datasets/pull/7184", "diff_url": "https://github.com/huggingface/datasets/pull/7184.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7184.patch", "merged_at": "2024-09-30T14:38...
true
Pin dill<0.3.9 to fix CI Pin dill<0.3.9 to fix CI for deps-latest. Note that dill-0.3.9 was released yesterday Sep 29, 2024: - https://pypi.org/project/dill/0.3.9/ - https://github.com/uqfoundation/dill/releases/tag/0.3.9 Fix #7183.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7184). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7183
7,183
CI is broken for deps-latest
See: https://github.com/huggingface/datasets/actions/runs/11106149906/job/30853879890 ``` =========================== short test summary info ============================ FAILED tests/test_arrow_dataset.py::BaseDatasetTest::test_filter_caching_on_disk - AssertionError: Lists differ: [{'fi[44 chars] {'filename': '/...
closed
2024-09-30T14:02:07
https://api.github.com/repos/huggingface/datasets/issues/7183/comments
null
false
CI is broken for deps-latest See: https://github.com/huggingface/datasets/actions/runs/11106149906/job/30853879890 ``` =========================== short test summary info ============================ FAILED tests/test_arrow_dataset.py::BaseDatasetTest::test_filter_caching_on_disk - AssertionError: Lists differ: [{...
[]
https://api.github.com/repos/huggingface/datasets/issues/7182
7,182
Support features in metadata configs
Support features in metadata configs, like: ``` configs: - config_name: default features: - name: id dtype: int64 - name: name dtype: string - name: score dtype: float64 ``` This will allow to avoid inference of data types. Currently, we allow passing th...
closed
2024-09-30T11:14:53
https://api.github.com/repos/huggingface/datasets/issues/7182/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7182", "html_url": "https://github.com/huggingface/datasets/pull/7182", "diff_url": "https://github.com/huggingface/datasets/pull/7182.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7182.patch", "merged_at": "2024-10-09T16:03...
true
Support features in metadata configs Support features in metadata configs, like: ``` configs: - config_name: default features: - name: id dtype: int64 - name: name dtype: string - name: score dtype: float64 ``` This will allow to avoid inference of data typ...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7182). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "The CI issue is unrelated:\r\n- #7183" ]
https://api.github.com/repos/huggingface/datasets/issues/7181
7,181
Fix datasets export to JSON
null
closed
2024-09-29T12:45:20
https://api.github.com/repos/huggingface/datasets/issues/7181/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7181", "html_url": "https://github.com/huggingface/datasets/pull/7181", "diff_url": "https://github.com/huggingface/datasets/pull/7181.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7181.patch", "merged_at": null }
true
Fix datasets export to JSON
[ "Linked Issue: #7037\r\nIdeas: #7039 ", "@albertvillanova / @lhoestq any early feedback?\r\n\r\nAFAIK there is no param `orient` in `load_dataset()`. So for orientations other than \"records\", the loading isn't very accurate. Any thoughts?", "`orient = \"split\"` can also be handled. I will add the changes soo...
https://api.github.com/repos/huggingface/datasets/issues/7180
7,180
Memory leak when wrapping datasets into PyTorch Dataset without explicit deletion
### Describe the bug I've encountered a memory leak when wrapping the HuggingFace dataset into a PyTorch Dataset. The RAM usage constantly increases during iteration if items are not explicitly deleted after use. ### Steps to reproduce the bug Steps to reproduce: Create a PyTorch Dataset wrapper f...
closed
2024-09-28T14:00:47
https://api.github.com/repos/huggingface/datasets/issues/7180/comments
null
false
Memory leak when wrapping datasets into PyTorch Dataset without explicit deletion ### Describe the bug I've encountered a memory leak when wrapping the HuggingFace dataset into a PyTorch Dataset. The RAM usage constantly increases during iteration if items are not explicitly deleted after use. ### Steps...
[ "> I've encountered a memory leak when wrapping the HuggingFace dataset into a PyTorch Dataset. The RAM usage constantly increases during iteration if items are not explicitly deleted after use.\r\n\r\nDatasets are memory mapped so they work like SWAP memory. In particular as long as you have RAM available the data...
https://api.github.com/repos/huggingface/datasets/issues/7179
7,179
Support Python 3.11
Support Python 3.11. Fix #7178.
closed
2024-09-27T08:55:44
https://api.github.com/repos/huggingface/datasets/issues/7179/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7179", "html_url": "https://github.com/huggingface/datasets/pull/7179", "diff_url": "https://github.com/huggingface/datasets/pull/7179.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7179.patch", "merged_at": "2024-10-08T16:21...
true
Support Python 3.11 Support Python 3.11. Fix #7178.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7179). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7178
7,178
Support Python 3.11
Support Python 3.11: https://peps.python.org/pep-0664/
closed
2024-09-27T08:50:47
https://api.github.com/repos/huggingface/datasets/issues/7178/comments
null
false
Support Python 3.11 Support Python 3.11: https://peps.python.org/pep-0664/
[]
https://api.github.com/repos/huggingface/datasets/issues/7177
7,177
Fix release instructions
Fix release instructions. During last release, I had to make this additional update.
closed
2024-09-27T08:47:01
https://api.github.com/repos/huggingface/datasets/issues/7177/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7177", "html_url": "https://github.com/huggingface/datasets/pull/7177", "diff_url": "https://github.com/huggingface/datasets/pull/7177.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7177.patch", "merged_at": "2024-09-27T08:57...
true
Fix release instructions Fix release instructions. During last release, I had to make this additional update.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7177). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7176
7,176
fix grammar in fingerprint.py
I see this error all the time and it was starting to get to me.
open
2024-09-26T16:13:42
https://api.github.com/repos/huggingface/datasets/issues/7176/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7176", "html_url": "https://github.com/huggingface/datasets/pull/7176", "diff_url": "https://github.com/huggingface/datasets/pull/7176.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7176.patch", "merged_at": null }
true
fix grammar in fingerprint.py I see this error all the time and it was starting to get to me.
[]
https://api.github.com/repos/huggingface/datasets/issues/7175
7,175
[FSTimeoutError] load_dataset
### Describe the bug When using `load_dataset`to load [HuggingFaceM4/VQAv2](https://huggingface.co/datasets/HuggingFaceM4/VQAv2), I am getting `FSTimeoutError`. ### Error ``` TimeoutError: The above exception was the direct cause of the following exception: FSTimeoutError Trac...
closed
2024-09-26T15:42:29
https://api.github.com/repos/huggingface/datasets/issues/7175/comments
null
false
[FSTimeoutError] load_dataset ### Describe the bug When using `load_dataset`to load [HuggingFaceM4/VQAv2](https://huggingface.co/datasets/HuggingFaceM4/VQAv2), I am getting `FSTimeoutError`. ### Error ``` TimeoutError: The above exception was the direct cause of the following exception: FSTimeoutError ...
[ "Is this `FSTimeoutError` due to download network issue from remote resource (from where it is being accessed)?", "It seems to happen for all datasets, not just a specific one, and especially for versions after 3.0. (3.0.0, 3.0.1 have this problem)\r\n\r\nI had the same error on a different dataset, but after dow...
https://api.github.com/repos/huggingface/datasets/issues/7174
7,174
Set dev version
null
closed
2024-09-26T08:30:11
https://api.github.com/repos/huggingface/datasets/issues/7174/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7174", "html_url": "https://github.com/huggingface/datasets/pull/7174", "diff_url": "https://github.com/huggingface/datasets/pull/7174.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7174.patch", "merged_at": "2024-09-26T08:30...
true
Set dev version
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7174). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7173
7,173
Release: 3.0.1
null
closed
2024-09-26T08:25:54
https://api.github.com/repos/huggingface/datasets/issues/7173/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7173", "html_url": "https://github.com/huggingface/datasets/pull/7173", "diff_url": "https://github.com/huggingface/datasets/pull/7173.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7173.patch", "merged_at": "2024-09-26T08:26...
true
Release: 3.0.1
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7173). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7172
7,172
Add torchdata as a regular test dependency
Add `torchdata` as a regular test dependency. Note that previously, `torchdata` was installed from their repo and current main branch (0.10.0.dev) requires Python>=3.9. Also note they made a recent release: 0.8.0 on Jul 31, 2024. Fix #7171.
closed
2024-09-26T07:45:55
https://api.github.com/repos/huggingface/datasets/issues/7172/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7172", "html_url": "https://github.com/huggingface/datasets/pull/7172", "diff_url": "https://github.com/huggingface/datasets/pull/7172.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7172.patch", "merged_at": "2024-09-26T08:05...
true
Add torchdata as a regular test dependency Add `torchdata` as a regular test dependency. Note that previously, `torchdata` was installed from their repo and current main branch (0.10.0.dev) requires Python>=3.9. Also note they made a recent release: 0.8.0 on Jul 31, 2024. Fix #7171.
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7172). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
https://api.github.com/repos/huggingface/datasets/issues/7171
7,171
CI is broken: No solution found when resolving dependencies
See: https://github.com/huggingface/datasets/actions/runs/11046967444/job/30687294297 ``` Run uv pip install --system -r additional-tests-requirements.txt --no-deps × No solution found when resolving dependencies: ╰─▶ Because the current Python version (3.8.18) does not satisfy Python>=3.9 and torchdata=...
closed
2024-09-26T07:24:58
https://api.github.com/repos/huggingface/datasets/issues/7171/comments
null
false
CI is broken: No solution found when resolving dependencies See: https://github.com/huggingface/datasets/actions/runs/11046967444/job/30687294297 ``` Run uv pip install --system -r additional-tests-requirements.txt --no-deps × No solution found when resolving dependencies: ╰─▶ Because the current Python version...
[]
https://api.github.com/repos/huggingface/datasets/issues/7170
7,170
Support JSON lines with missing columns
Support JSON lines with missing columns. Fix #7169. The implemented test raised: ``` datasets.table.CastError: Couldn't cast age: int64 to {'age': Value(dtype='int32', id=None), 'name': Value(dtype='string', id=None)} because column names don't match ``` Related to: - #7160 - #7162
closed
2024-09-25T05:08:15
https://api.github.com/repos/huggingface/datasets/issues/7170/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/7170", "html_url": "https://github.com/huggingface/datasets/pull/7170", "diff_url": "https://github.com/huggingface/datasets/pull/7170.diff", "patch_url": "https://github.com/huggingface/datasets/pull/7170.patch", "merged_at": "2024-09-26T06:42...
true
Support JSON lines with missing columns Support JSON lines with missing columns. Fix #7169. The implemented test raised: ``` datasets.table.CastError: Couldn't cast age: int64 to {'age': Value(dtype='int32', id=None), 'name': Value(dtype='string', id=None)} because column names don't match ``` Related t...
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7170). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]