url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/2141
2,141
added spans field for the wikiann datasets
Hi @lhoestq I tried to add spans to the wikiann datasets. Thanks a lot for kindly having a look. This addresses https://github.com/huggingface/datasets/issues/2130. Best regards Rabeeh
closed
2021-03-29T23:38:26
https://api.github.com/repos/huggingface/datasets/issues/2141/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2141", "html_url": "https://github.com/huggingface/datasets/pull/2141", "diff_url": "https://github.com/huggingface/datasets/pull/2141.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2141.patch", "merged_at": "2021-03-31T13:27...
true
added spans field for the wikiann datasets Hi @lhoestq I tried to add spans to the wikiann datasets. Thanks a lot for kindly having a look. This addresses https://github.com/huggingface/datasets/issues/2130. Best regards Rabeeh
[ "Hi @lhoestq \r\nThanks a lot for taking time checking it. I update \"dataset_infos.json\", I added description to the function of _generate_samples in wikiann.py but I was not sure about the format to write in README. thanks. ", "Thanks !\r\n\r\nFor the fields description in the dataset card, something like thi...
https://api.github.com/repos/huggingface/datasets/issues/2140
2,140
add banking77 dataset
Intent classification/detection dataset from banking category with 77 unique intents.
closed
2021-03-29T21:32:23
https://api.github.com/repos/huggingface/datasets/issues/2140/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2140", "html_url": "https://github.com/huggingface/datasets/pull/2140", "diff_url": "https://github.com/huggingface/datasets/pull/2140.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2140.patch", "merged_at": "2021-04-09T09:32...
true
add banking77 dataset Intent classification/detection dataset from banking category with 77 unique intents.
[ "@lhoestq I updated files" ]
https://api.github.com/repos/huggingface/datasets/issues/2139
2,139
TypeError when using save_to_disk in a dataset loaded with ReadInstruction split
Hi, Loading a dataset with `load_dataset` using a split defined via `ReadInstruction` and then saving it to disk results in the following error: `TypeError: Object of type ReadInstruction is not JSON serializable`. Here is the minimal reproducible example: ```python from datasets import load_dataset from dat...
closed
2021-03-29T18:23:54
https://api.github.com/repos/huggingface/datasets/issues/2139/comments
null
false
TypeError when using save_to_disk in a dataset loaded with ReadInstruction split Hi, Loading a dataset with `load_dataset` using a split defined via `ReadInstruction` and then saving it to disk results in the following error: `TypeError: Object of type ReadInstruction is not JSON serializable`. Here is the minima...
[ "Hi !\r\nI think this has been fixed recently on `master`.\r\nCan you try again by installing `datasets` from `master` ?\r\n```\r\npip install git+https://github.com/huggingface/datasets.git\r\n```", "Hi!\r\n\r\nUsing that version of the code solves the issue. Thanks!" ]
https://api.github.com/repos/huggingface/datasets/issues/2138
2,138
Add CER metric
Add Character Error Rate (CER) metric that is used in evaluation in ASR. I also have written unittests (hopefully thorough enough) but I'm not sure how to integrate them into the existed codebase. ```python from cer import CER cer = CER() class TestCER(unittest.TestCase): def test_cer_case_senstive(self)...
closed
2021-03-29T15:52:27
https://api.github.com/repos/huggingface/datasets/issues/2138/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2138", "html_url": "https://github.com/huggingface/datasets/pull/2138", "diff_url": "https://github.com/huggingface/datasets/pull/2138.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2138.patch", "merged_at": "2021-04-06T07:14...
true
Add CER metric Add Character Error Rate (CER) metric that is used in evaluation in ASR. I also have written unittests (hopefully thorough enough) but I'm not sure how to integrate them into the existed codebase. ```python from cer import CER cer = CER() class TestCER(unittest.TestCase): def test_cer_case...
[]
https://api.github.com/repos/huggingface/datasets/issues/2137
2,137
Fix missing infos from concurrent dataset loading
This should fix issue #2131 When calling `load_dataset` at the same time from 2 workers, one of the worker could have missing split infos when reloading the dataset from the cache.
closed
2021-03-29T15:46:12
https://api.github.com/repos/huggingface/datasets/issues/2137/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2137", "html_url": "https://github.com/huggingface/datasets/pull/2137", "diff_url": "https://github.com/huggingface/datasets/pull/2137.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2137.patch", "merged_at": "2021-03-31T10:35...
true
Fix missing infos from concurrent dataset loading This should fix issue #2131 When calling `load_dataset` at the same time from 2 workers, one of the worker could have missing split infos when reloading the dataset from the cache.
[]
https://api.github.com/repos/huggingface/datasets/issues/2136
2,136
fix dialogue action slot name and value
fix #2128
closed
2021-03-29T15:34:13
https://api.github.com/repos/huggingface/datasets/issues/2136/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2136", "html_url": "https://github.com/huggingface/datasets/pull/2136", "diff_url": "https://github.com/huggingface/datasets/pull/2136.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2136.patch", "merged_at": "2021-03-31T12:48...
true
fix dialogue action slot name and value fix #2128
[]
https://api.github.com/repos/huggingface/datasets/issues/2135
2,135
en language data from MLQA dataset is missing
Hi I need mlqa-translate-train.en dataset, but it is missing from the MLQA dataset. could you have a look please? @lhoestq thank you for your help to fix this issue.
closed
2021-03-29T10:47:50
https://api.github.com/repos/huggingface/datasets/issues/2135/comments
null
false
en language data from MLQA dataset is missing Hi I need mlqa-translate-train.en dataset, but it is missing from the MLQA dataset. could you have a look please? @lhoestq thank you for your help to fix this issue.
[ "Hi ! Indeed only the languages of the `translate-train` data are included...\r\nI can't find a link to download the english train set on https://github.com/facebookresearch/MLQA though, do you know where we can download it ?", "Hi @lhoestq \r\nthank you very much for coming back to me, now I see, you are right, ...
https://api.github.com/repos/huggingface/datasets/issues/2134
2,134
Saving large in-memory datasets with save_to_disk crashes because of pickling
Using Datasets 1.5.0 on Python 3.7. Recently I've been working on medium to large size datasets (pretokenized raw text sizes from few gigabytes to low tens of gigabytes), and have found out that several preprocessing steps are massively faster when done in memory, and I have the ability to requisition a lot of RAM, so...
closed
2021-03-29T10:43:15
https://api.github.com/repos/huggingface/datasets/issues/2134/comments
null
false
Saving large in-memory datasets with save_to_disk crashes because of pickling Using Datasets 1.5.0 on Python 3.7. Recently I've been working on medium to large size datasets (pretokenized raw text sizes from few gigabytes to low tens of gigabytes), and have found out that several preprocessing steps are massively fast...
[ "Hi !\r\nIndeed `save_to_disk` doesn't call pickle anymore. Though the `OverflowError` can still appear for in-memory datasets bigger than 4GB. This happens when doing this for example:\r\n```python\r\nimport pyarrow as pa\r\nimport pickle\r\n\r\narr = pa.array([0] * ((4 * 8 << 30) // 64))\r\ntable = pa.Table.from_...
https://api.github.com/repos/huggingface/datasets/issues/2133
2,133
bug in mlqa dataset
Hi Looking into MLQA dataset for langauge "ar": ``` "question": [ "\u0645\u062a\u0649 \u0628\u062f\u0627\u062a \u0627\u0644\u0645\u062c\u0644\u0629 \u0627\u0644\u0645\u062f\u0631\u0633\u064a\u0629 \u0641\u064a \u0646\u0648\u062a\u0631\u062f\u0627\u0645 \u0628\u0627\u0644\u0646\u0634\u0631?", "\u0643\u0...
closed
2021-03-29T09:03:09
https://api.github.com/repos/huggingface/datasets/issues/2133/comments
null
false
bug in mlqa dataset Hi Looking into MLQA dataset for langauge "ar": ``` "question": [ "\u0645\u062a\u0649 \u0628\u062f\u0627\u062a \u0627\u0644\u0645\u062c\u0644\u0629 \u0627\u0644\u0645\u062f\u0631\u0633\u064a\u0629 \u0641\u064a \u0646\u0648\u062a\u0631\u062f\u0627\u0645 \u0628\u0627\u0644\u0646\u0634\u06...
[ "If you print those questions, you get readable texts:\r\n```python\r\n>>> questions = [\r\n... \"\\u0645\\u062a\\u0649 \\u0628\\u062f\\u0627\\u062a \\u0627\\u0644\\u0645\\u062c\\u0644\\u0629 \\u0627\\u0644\\u0645\\u062f\\u0631\\u0633\\u064a\\u0629 \\u0641\\u064a \\u0646\\u0648\\u062a\\u0631\\u062f\\u0627\\u064...
https://api.github.com/repos/huggingface/datasets/issues/2132
2,132
TydiQA dataset is mixed and is not split per language
Hi @lhoestq Currently TydiQA is mixed and user can only access the whole training set of all languages: https://www.tensorflow.org/datasets/catalog/tydi_qa for using this dataset, one need to train/evaluate in each separate language, and having them mixed, makes it hard to use this dataset. This is much convenien...
open
2021-03-29T08:56:21
https://api.github.com/repos/huggingface/datasets/issues/2132/comments
null
false
TydiQA dataset is mixed and is not split per language Hi @lhoestq Currently TydiQA is mixed and user can only access the whole training set of all languages: https://www.tensorflow.org/datasets/catalog/tydi_qa for using this dataset, one need to train/evaluate in each separate language, and having them mixed, ma...
[ "You can filter the languages this way:\r\n```python\r\ntydiqa_en = tydiqa_dataset.filter(lambda x: x[\"language\"] == \"english\")\r\n```\r\n\r\nOtherwise maybe we can have one configuration per language ?\r\nWhat do you think of this for example ?\r\n\r\n```python\r\nload_dataset(\"tydiqa\", \"primary_task.en\")\...
https://api.github.com/repos/huggingface/datasets/issues/2131
2,131
When training with Multi-Node Multi-GPU the worker 2 has TypeError: 'NoneType' object
version: 1.5.0 met a very strange error, I am training large scale language model, and need train on 2 machines(workers). And sometimes I will get this error `TypeError: 'NoneType' object is not iterable` This is traceback ``` 71 |   | Traceback (most recent call last): -- | -- | -- 72 |   | File "run_gpt.py"...
closed
2021-03-29T08:45:58
https://api.github.com/repos/huggingface/datasets/issues/2131/comments
null
false
When training with Multi-Node Multi-GPU the worker 2 has TypeError: 'NoneType' object version: 1.5.0 met a very strange error, I am training large scale language model, and need train on 2 machines(workers). And sometimes I will get this error `TypeError: 'NoneType' object is not iterable` This is traceback ``` ...
[ "Hi ! Thanks for reporting\r\nI was able to reproduce this issue. This was caused by missing split infos if a worker reloads the cache of the other worker.\r\n\r\nI just opened https://github.com/huggingface/datasets/pull/2137 to fix this issue", "The PR got merged :)\r\nFeel free to try it out on the `master` br...
https://api.github.com/repos/huggingface/datasets/issues/2130
2,130
wikiann dataset is missing columns
Hi Wikiann dataset needs to have "spans" columns, which is necessary to be able to use this dataset, but this column is missing from huggingface datasets, could you please have a look? thank you @lhoestq
closed
2021-03-29T08:23:00
https://api.github.com/repos/huggingface/datasets/issues/2130/comments
null
false
wikiann dataset is missing columns Hi Wikiann dataset needs to have "spans" columns, which is necessary to be able to use this dataset, but this column is missing from huggingface datasets, could you please have a look? thank you @lhoestq
[ "Here please find TFDS format of this dataset: https://www.tensorflow.org/datasets/catalog/wikiann\r\nwhere there is a span column, this is really necessary to be able to use the data, and I appreciate your help @lhoestq ", "Hi !\r\nApparently you can get the spans from the NER tags using `tags_to_spans` defined ...
https://api.github.com/repos/huggingface/datasets/issues/2129
2,129
How to train BERT model with next sentence prediction?
Hello. I'm trying to pretrain the BERT model with next sentence prediction. Is there any function that supports next sentence prediction like ` TextDatasetForNextSentencePrediction` of `huggingface/transformers` ?
closed
2021-03-29T06:48:03
https://api.github.com/repos/huggingface/datasets/issues/2129/comments
null
false
How to train BERT model with next sentence prediction? Hello. I'm trying to pretrain the BERT model with next sentence prediction. Is there any function that supports next sentence prediction like ` TextDatasetForNextSentencePrediction` of `huggingface/transformers` ?
[ "Hi !\r\nWe're not using `TextDatasetForNextSentencePrediction` in `datasets`.\r\nAlthough you can probably use the `TextDatasetForNextSentencePrediction.create_examples_from_document` on a dataset to prepare it for next sentence prediction.", "Thanks.\r\n\r\nDo you mean that `TextDatasetForNextSentencePrediction...
https://api.github.com/repos/huggingface/datasets/issues/2128
2,128
Dialogue action slot name and value are reversed in MultiWoZ 2.2
Hi @yjernite, thank you for adding MultiWoZ 2.2 in the huggingface datasets platform. It is beneficial! I spot an error that the order of Dialogue action slot names and values are reversed. https://github.com/huggingface/datasets/blob/649b2c469779bc4221e1b6969aa2496d63eb5953/datasets/multi_woz_v22/multi_woz_v22.p...
closed
2021-03-29T06:34:02
https://api.github.com/repos/huggingface/datasets/issues/2128/comments
null
false
Dialogue action slot name and value are reversed in MultiWoZ 2.2 Hi @yjernite, thank you for adding MultiWoZ 2.2 in the huggingface datasets platform. It is beneficial! I spot an error that the order of Dialogue action slot names and values are reversed. https://github.com/huggingface/datasets/blob/649b2c469779bc...
[ "Hi\r\nGood catch ! Thanks for reporting\r\n\r\nIf you are interested in contributing, feel free to open a PR to fix this :) " ]
https://api.github.com/repos/huggingface/datasets/issues/2127
2,127
make documentation more clear to use different cloud storage
This PR extends the cloud storage documentation. To show you can use a different `fsspec` implementation.
closed
2021-03-29T06:24:06
https://api.github.com/repos/huggingface/datasets/issues/2127/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2127", "html_url": "https://github.com/huggingface/datasets/pull/2127", "diff_url": "https://github.com/huggingface/datasets/pull/2127.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2127.patch", "merged_at": "2021-03-29T12:16...
true
make documentation more clear to use different cloud storage This PR extends the cloud storage documentation. To show you can use a different `fsspec` implementation.
[]
https://api.github.com/repos/huggingface/datasets/issues/2126
2,126
Replace legacy torch.Tensor constructor with torch.tensor
The title says it all (motivated by [this issue](https://github.com/pytorch/pytorch/issues/53146) in the pytorch repo).
closed
2021-03-28T16:57:30
https://api.github.com/repos/huggingface/datasets/issues/2126/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2126", "html_url": "https://github.com/huggingface/datasets/pull/2126", "diff_url": "https://github.com/huggingface/datasets/pull/2126.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2126.patch", "merged_at": "2021-03-29T09:27...
true
Replace legacy torch.Tensor constructor with torch.tensor The title says it all (motivated by [this issue](https://github.com/pytorch/pytorch/issues/53146) in the pytorch repo).
[]
https://api.github.com/repos/huggingface/datasets/issues/2125
2,125
Is dataset timit_asr broken?
Using `timit_asr` dataset, I saw all records are the same. ``` python from datasets import load_dataset, load_metric timit = load_dataset("timit_asr") from datasets import ClassLabel import random import pandas as pd from IPython.display import display, HTML def show_random_elements(dataset, num_example...
closed
2021-03-28T08:30:18
https://api.github.com/repos/huggingface/datasets/issues/2125/comments
null
false
Is dataset timit_asr broken? Using `timit_asr` dataset, I saw all records are the same. ``` python from datasets import load_dataset, load_metric timit = load_dataset("timit_asr") from datasets import ClassLabel import random import pandas as pd from IPython.display import display, HTML def show_random_...
[ "Hi,\r\n\r\nthanks for the report, but this is a duplicate of #2052. ", "@mariosasko \r\nThank you for your quick response! Following #2052, I've fixed the problem." ]
https://api.github.com/repos/huggingface/datasets/issues/2124
2,124
Adding ScaNN library to do MIPS?
@lhoestq Hi I am thinking of adding this new google library to do the MIPS similar to **add_faiss_idex**. As the paper suggests, it is really fast when it comes to retrieving the nearest neighbors. https://github.com/google-research/google-research/tree/master/scann ![image](https://user-images.githubusercontent...
open
2021-03-28T00:07:00
https://api.github.com/repos/huggingface/datasets/issues/2124/comments
null
false
Adding ScaNN library to do MIPS? @lhoestq Hi I am thinking of adding this new google library to do the MIPS similar to **add_faiss_idex**. As the paper suggests, it is really fast when it comes to retrieving the nearest neighbors. https://github.com/google-research/google-research/tree/master/scann ![image](http...
[ "I haven't played with it (yet) but it sounds really cool !\r\n" ]
https://api.github.com/repos/huggingface/datasets/issues/2123
2,123
Problem downloading GEM wiki_auto_asset_turk dataset
@yjernite ### Summary I am currently working on the GEM datasets and do not manage to download the wiki_auto_asset_turk data, whereas all other datasets download well with the same code. ### Steps to reproduce Code snippet: from datasets import load_dataset #dataset = load_dataset('gem', 'web_nlg_en') d...
closed
2021-03-27T18:41:28
https://api.github.com/repos/huggingface/datasets/issues/2123/comments
null
false
Problem downloading GEM wiki_auto_asset_turk dataset @yjernite ### Summary I am currently working on the GEM datasets and do not manage to download the wiki_auto_asset_turk data, whereas all other datasets download well with the same code. ### Steps to reproduce Code snippet: from datasets import load_dat...
[ "Hi,\r\n\r\nsadly I can't replicate the problem on my Windows machine. Try to update the library to the newest version with:\r\n```bash\r\npip install git+https://github.com/huggingface/datasets\r\n``` ", "Thanks for the answer! I updated the library but unfortunately it didn't solve the problem.", "Is there an...
https://api.github.com/repos/huggingface/datasets/issues/2122
2,122
Fast table queries with interpolation search
## Intro This should fix issue #1803 Currently querying examples in a dataset is O(n) because of the underlying pyarrow ChunkedArrays implementation. To fix this I implemented interpolation search that is pretty effective since datasets usually verifies the condition of evenly distributed chunks (the default ch...
closed
2021-03-26T18:09:20
https://api.github.com/repos/huggingface/datasets/issues/2122/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2122", "html_url": "https://github.com/huggingface/datasets/pull/2122", "diff_url": "https://github.com/huggingface/datasets/pull/2122.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2122.patch", "merged_at": "2021-04-06T14:33...
true
Fast table queries with interpolation search ## Intro This should fix issue #1803 Currently querying examples in a dataset is O(n) because of the underlying pyarrow ChunkedArrays implementation. To fix this I implemented interpolation search that is pretty effective since datasets usually verifies the condition...
[]
https://api.github.com/repos/huggingface/datasets/issues/2121
2,121
Add Validation For README
Hi @lhoestq, @yjernite This is a simple Readme parser. All classes specific to different sections can inherit `Section` class, and we can define more attributes in each. Let me know if this is going in the right direction :) Currently the output looks like this, for `to_dict()` on `FashionMNIST` `README.md`: ...
closed
2021-03-26T17:02:17
https://api.github.com/repos/huggingface/datasets/issues/2121/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2121", "html_url": "https://github.com/huggingface/datasets/pull/2121", "diff_url": "https://github.com/huggingface/datasets/pull/2121.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2121.patch", "merged_at": "2021-05-10T09:41...
true
Add Validation For README Hi @lhoestq, @yjernite This is a simple Readme parser. All classes specific to different sections can inherit `Section` class, and we can define more attributes in each. Let me know if this is going in the right direction :) Currently the output looks like this, for `to_dict()` on `F...
[ "Good start! Here are some proposed next steps:\r\n- We want the Class structure to reflect the template - so the parser know what section titles to expect and when something has gone wrong\r\n- As a result, we don't need to parse the table of contents, since it will always be the same\r\n- For each section/subsect...
https://api.github.com/repos/huggingface/datasets/issues/2120
2,120
dataset viewer does not work anymore
Hi I normally use this link to see all datasets and how I can load them https://huggingface.co/datasets/viewer/ Now I am getting 502 Bad Gateway nginx/1.18.0 (Ubuntu) could you bring this webpage back ? this was very helpful @lhoestq thanks for your help
closed
2021-03-26T13:22:13
https://api.github.com/repos/huggingface/datasets/issues/2120/comments
null
false
dataset viewer does not work anymore Hi I normally use this link to see all datasets and how I can load them https://huggingface.co/datasets/viewer/ Now I am getting 502 Bad Gateway nginx/1.18.0 (Ubuntu) could you bring this webpage back ? this was very helpful @lhoestq thanks for your help
[ "Thanks for reporting :) We're looking into it", "Back up. " ]
https://api.github.com/repos/huggingface/datasets/issues/2119
2,119
copy.deepcopy os.environ instead of copy
Fixes: https://github.com/huggingface/datasets/issues/2115 - bug fix: using envrion.copy() returns a dict. - using deepcopy(environ) returns an `_environ` object - Changing the datatype of the _environ object can break code, if subsequent libraries perform operations using apis exclusive to the environ object, lik...
closed
2021-03-26T03:58:38
https://api.github.com/repos/huggingface/datasets/issues/2119/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2119", "html_url": "https://github.com/huggingface/datasets/pull/2119", "diff_url": "https://github.com/huggingface/datasets/pull/2119.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2119.patch", "merged_at": "2021-03-26T15:13...
true
copy.deepcopy os.environ instead of copy Fixes: https://github.com/huggingface/datasets/issues/2115 - bug fix: using envrion.copy() returns a dict. - using deepcopy(environ) returns an `_environ` object - Changing the datatype of the _environ object can break code, if subsequent libraries perform operations using ...
[]
https://api.github.com/repos/huggingface/datasets/issues/2118
2,118
Remove os.environ.copy in Dataset.map
Replace `os.environ.copy` with in-place modification Fixes #2115
closed
2021-03-26T03:48:17
https://api.github.com/repos/huggingface/datasets/issues/2118/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2118", "html_url": "https://github.com/huggingface/datasets/pull/2118", "diff_url": "https://github.com/huggingface/datasets/pull/2118.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2118.patch", "merged_at": null }
true
Remove os.environ.copy in Dataset.map Replace `os.environ.copy` with in-place modification Fixes #2115
[ "I thought deepcopy on `os.environ` is unsafe (see [this](https://stackoverflow.com/questions/13142972/using-copy-deepcopy-on-os-environ-in-python-appears-broken)), but I can't replicate the behavior described in the linked SO thread.\r\n\r\nClosing this one because #2119 has a much cleaner approach." ]
https://api.github.com/repos/huggingface/datasets/issues/2117
2,117
load_metric from local "glue.py" meet error 'NoneType' object is not callable
actual_task = "mnli" if task == "mnli-mm" else task dataset = load_dataset(path='/home/glue.py', name=actual_task) metric = load_metric(path='/home/glue.py', name=actual_task) --------------------------------------------------------------------------- TypeError Traceback (most recent...
closed
2021-03-26T02:35:22
https://api.github.com/repos/huggingface/datasets/issues/2117/comments
null
false
load_metric from local "glue.py" meet error 'NoneType' object is not callable actual_task = "mnli" if task == "mnli-mm" else task dataset = load_dataset(path='/home/glue.py', name=actual_task) metric = load_metric(path='/home/glue.py', name=actual_task) ---------------------------------------------------------------...
[ "@Frankie123421 what was the resolution to this?", "> @Frankie123421 what was the resolution to this?\r\n\r\nuse glue_metric.py instead of glue.py in load_metric", "thank you!" ]
https://api.github.com/repos/huggingface/datasets/issues/2116
2,116
Creating custom dataset results in error while calling the map() function
calling `map()` of `datasets` library results into an error while defining a Custom dataset. Reproducible example: ``` import datasets class MyDataset(datasets.Dataset): def __init__(self, sentences): "Initialization" self.samples = sentences def __len__(self): "Denotes the ...
closed
2021-03-26T00:37:46
https://api.github.com/repos/huggingface/datasets/issues/2116/comments
null
false
Creating custom dataset results in error while calling the map() function calling `map()` of `datasets` library results into an error while defining a Custom dataset. Reproducible example: ``` import datasets class MyDataset(datasets.Dataset): def __init__(self, sentences): "Initialization" ...
[ "Hi,\r\n\r\nthe `_data` attribute is missing due to `MyDataset.__init__` not calling the parent `__init__`. However, I don't think it's a good idea to subclass the `datasets.Dataset` class (e.g. it's kind of dangerous to override `datasets.Dataset.__getitem__`). Instead, it's better to follow the \"association over...
https://api.github.com/repos/huggingface/datasets/issues/2115
2,115
The datasets.map() implementation modifies the datatype of os.environ object
In our testing, we noticed that the datasets.map() implementation is modifying the datatype of python os.environ object from '_Environ' to 'dict'. This causes following function calls to fail as follows: ` x = os.environ.get("TEST_ENV_VARIABLE_AFTER_dataset_map", default=None) TypeError: get() takes...
closed
2021-03-25T20:29:19
https://api.github.com/repos/huggingface/datasets/issues/2115/comments
null
false
The datasets.map() implementation modifies the datatype of os.environ object In our testing, we noticed that the datasets.map() implementation is modifying the datatype of python os.environ object from '_Environ' to 'dict'. This causes following function calls to fail as follows: ` x = os.environ.get("TE...
[]
https://api.github.com/repos/huggingface/datasets/issues/2114
2,114
Support for legal NLP datasets (EURLEX, ECtHR cases and EU-REG-IR)
Add support for two legal NLP datasets: - EURLEX (https://www.aclweb.org/anthology/P19-1636/) - ECtHR cases (https://arxiv.org/abs/2103.13084) - EU-REG-IR (https://arxiv.org/abs/2101.10726)
closed
2021-03-25T18:40:17
https://api.github.com/repos/huggingface/datasets/issues/2114/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2114", "html_url": "https://github.com/huggingface/datasets/pull/2114", "diff_url": "https://github.com/huggingface/datasets/pull/2114.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2114.patch", "merged_at": "2021-03-31T10:38...
true
Support for legal NLP datasets (EURLEX, ECtHR cases and EU-REG-IR) Add support for two legal NLP datasets: - EURLEX (https://www.aclweb.org/anthology/P19-1636/) - ECtHR cases (https://arxiv.org/abs/2103.13084) - EU-REG-IR (https://arxiv.org/abs/2101.10726)
[ "> Awesome thank you :)\r\n> This is really cool\r\n> \r\n> I left a few comments.\r\n> \r\n> Also it looks like the dummy data are quite big (100-200KB each). Can you try to reduce their sizes please ? For example I noticed that all the jsonl files inside the `dummy_data.zip` files have 20 lines. Can you only keep...
https://api.github.com/repos/huggingface/datasets/issues/2113
2,113
Implement Dataset as context manager
When used as context manager, it would be safely deleted if some exception is raised. This will avoid > During handling of the above exception, another exception occurred:
closed
2021-03-25T18:18:30
https://api.github.com/repos/huggingface/datasets/issues/2113/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2113", "html_url": "https://github.com/huggingface/datasets/pull/2113", "diff_url": "https://github.com/huggingface/datasets/pull/2113.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2113.patch", "merged_at": "2021-03-31T08:30...
true
Implement Dataset as context manager When used as context manager, it would be safely deleted if some exception is raised. This will avoid > During handling of the above exception, another exception occurred:
[]
https://api.github.com/repos/huggingface/datasets/issues/2112
2,112
Support for legal NLP datasets (EURLEX and ECtHR cases)
Add support for two legal NLP datasets: - EURLEX (https://www.aclweb.org/anthology/P19-1636/) - ECtHR cases (https://arxiv.org/abs/2103.13084)
closed
2021-03-25T16:24:17
https://api.github.com/repos/huggingface/datasets/issues/2112/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2112", "html_url": "https://github.com/huggingface/datasets/pull/2112", "diff_url": "https://github.com/huggingface/datasets/pull/2112.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2112.patch", "merged_at": null }
true
Support for legal NLP datasets (EURLEX and ECtHR cases) Add support for two legal NLP datasets: - EURLEX (https://www.aclweb.org/anthology/P19-1636/) - ECtHR cases (https://arxiv.org/abs/2103.13084)
[]
https://api.github.com/repos/huggingface/datasets/issues/2111
2,111
Compute WER metric iteratively
Compute WER metric iteratively to avoid MemoryError. Fix #2078.
closed
2021-03-25T16:06:48
https://api.github.com/repos/huggingface/datasets/issues/2111/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2111", "html_url": "https://github.com/huggingface/datasets/pull/2111", "diff_url": "https://github.com/huggingface/datasets/pull/2111.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2111.patch", "merged_at": "2021-04-06T07:20...
true
Compute WER metric iteratively Compute WER metric iteratively to avoid MemoryError. Fix #2078.
[ "I discussed with Patrick and I think we could have a nice addition: have a parameter `concatenate_texts` that, if `True`, uses the old implementation.\r\n\r\nBy default `concatenate_texts` would be `False`, so that sentences are evaluated independently, and to save resources (the WER computation has a quadratic co...
https://api.github.com/repos/huggingface/datasets/issues/2110
2,110
Fix incorrect assertion in builder.py
Fix incorrect num_examples comparison assertion in builder.py
closed
2021-03-25T10:39:20
https://api.github.com/repos/huggingface/datasets/issues/2110/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2110", "html_url": "https://github.com/huggingface/datasets/pull/2110", "diff_url": "https://github.com/huggingface/datasets/pull/2110.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2110.patch", "merged_at": "2021-04-12T13:33...
true
Fix incorrect assertion in builder.py Fix incorrect num_examples comparison assertion in builder.py
[ "Hi ! The SplitInfo is not always available. By default you would get `split_info.num_examples == 0`\r\nSo unfortunately we can't use this assertion you suggested", "> Hi ! The SplitInfo is not always available. By default you would get `split_info.num_examples == 0`\r\n> So unfortunately we can't use this assert...
https://api.github.com/repos/huggingface/datasets/issues/2109
2,109
Add more issue templates and customize issue template chooser
When opening an issue, it is not evident for the users how to choose a blank issue template. There is a link at the bottom of all the other issue templates (`Don’t see your issue here? Open a blank issue.`), but this is not very visible for users. This is the reason why many users finally chose the `add-dataset` templa...
closed
2021-03-25T09:41:53
https://api.github.com/repos/huggingface/datasets/issues/2109/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2109", "html_url": "https://github.com/huggingface/datasets/pull/2109", "diff_url": "https://github.com/huggingface/datasets/pull/2109.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2109.patch", "merged_at": "2021-04-19T06:20...
true
Add more issue templates and customize issue template chooser When opening an issue, it is not evident for the users how to choose a blank issue template. There is a link at the bottom of all the other issue templates (`Don’t see your issue here? Open a blank issue.`), but this is not very visible for users. This is th...
[ "If you agree, I could also add a link to [Discussions](https://github.com/huggingface/datasets/discussions) in order to reinforce the use of Discussion to make Questions (instead of Issues).\r\n\r\nI could also add some other templates: Bug, Feature Request,...", "@theo-m we wrote our same comments at the same t...
https://api.github.com/repos/huggingface/datasets/issues/2108
2,108
Is there a way to use a GPU only when training an Index in the process of add_faisis_index?
Motivation - Some FAISS indexes like IVF consist of the training step that clusters the dataset into a given number of indexes. It would be nice if we can use a GPU to do the training step and covert the index back to CPU as mention in [this faiss example](https://gist.github.com/mdouze/46d6bbbaabca0b9778fca37ed2bcccf6...
open
2021-03-24T21:32:16
https://api.github.com/repos/huggingface/datasets/issues/2108/comments
null
false
Is there a way to use a GPU only when training an Index in the process of add_faisis_index? Motivation - Some FAISS indexes like IVF consist of the training step that clusters the dataset into a given number of indexes. It would be nice if we can use a GPU to do the training step and covert the index back to CPU as me...
[]
https://api.github.com/repos/huggingface/datasets/issues/2107
2,107
Metadata validation
- `pydantic` metadata schema with dedicated validators against our taxonomy - ci script to validate new changes against this schema and start a vertuous loop - soft validation on tasks ids since we expect the taxonomy to undergo some changes in the near future for reference with the current validation we have ~365...
closed
2021-03-24T08:52:41
https://api.github.com/repos/huggingface/datasets/issues/2107/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2107", "html_url": "https://github.com/huggingface/datasets/pull/2107", "diff_url": "https://github.com/huggingface/datasets/pull/2107.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2107.patch", "merged_at": "2021-04-26T08:27...
true
Metadata validation - `pydantic` metadata schema with dedicated validators against our taxonomy - ci script to validate new changes against this schema and start a vertuous loop - soft validation on tasks ids since we expect the taxonomy to undergo some changes in the near future for reference with the current val...
[ "> Also I was wondering this is really needed to have `utils.metadata` as a submodule of `datasets` ? This is only used by the CI so I'm not sure we should have this in the actual `datasets` package.\r\n\r\nI'm unclear on the suggestion, would you rather have a root-level `./metadata.py` file? I think it's well whe...
https://api.github.com/repos/huggingface/datasets/issues/2106
2,106
WMT19 Dataset for Kazakh-English is not formatted correctly
In addition to the bug of languages being switched from Issue @415, there are incorrect translations in the dataset because the English-Kazakh translations have a one off formatting error. The News Commentary v14 parallel data set for kk-en from http://www.statmt.org/wmt19/translation-task.html has a bug here: > ...
open
2021-03-23T20:14:47
https://api.github.com/repos/huggingface/datasets/issues/2106/comments
null
false
WMT19 Dataset for Kazakh-English is not formatted correctly In addition to the bug of languages being switched from Issue @415, there are incorrect translations in the dataset because the English-Kazakh translations have a one off formatting error. The News Commentary v14 parallel data set for kk-en from http://www....
[ "Hi ! Thanks for reporting\r\n\r\nBy looking at the raw `news-commentary-v14.en-kk.tsv` file, it looks like there are at least 17 lines with this issue.\r\nMoreover these issues are not always the same:\r\n- L97 is only `kk` text and must be appended at the end of the `kk` text of the **next** line\r\n- L2897 is on...
https://api.github.com/repos/huggingface/datasets/issues/2105
2,105
Request to remove S2ORC dataset
Hi! I was wondering if it's possible to remove [S2ORC](https://huggingface.co/datasets/s2orc) from hosting on Huggingface's platform? Unfortunately, there are some legal considerations about how we make this data available. Happy to add back to Huggingface's platform once we work out those hurdles! Thanks!
open
2021-03-23T19:43:06
https://api.github.com/repos/huggingface/datasets/issues/2105/comments
null
false
Request to remove S2ORC dataset Hi! I was wondering if it's possible to remove [S2ORC](https://huggingface.co/datasets/s2orc) from hosting on Huggingface's platform? Unfortunately, there are some legal considerations about how we make this data available. Happy to add back to Huggingface's platform once we work out ...
[ "Hello @kyleclo! Currently, we are getting the data from your bucket, so if you remove it the HF script won't work anymore :) \r\n\r\nUntil you solve things on your end, @lhoestq suggested we just return a warning message when people try to load that dataset from HF. What would you like it to say?", "Hi @kyleclo,...
https://api.github.com/repos/huggingface/datasets/issues/2104
2,104
Trouble loading wiki_movies
Hello, I am trying to load_dataset("wiki_movies") and it gives me this error - `FileNotFoundError: Couldn't find file locally at wiki_movies/wiki_movies.py, or remotely at https://raw.githubusercontent.com/huggingface/datasets/1.1.2/datasets/wiki_movies/wiki_movies.py or https://s3.amazonaws.com/datasets.huggingfa...
closed
2021-03-23T18:59:54
https://api.github.com/repos/huggingface/datasets/issues/2104/comments
null
false
Trouble loading wiki_movies Hello, I am trying to load_dataset("wiki_movies") and it gives me this error - `FileNotFoundError: Couldn't find file locally at wiki_movies/wiki_movies.py, or remotely at https://raw.githubusercontent.com/huggingface/datasets/1.1.2/datasets/wiki_movies/wiki_movies.py or https://s3.amaz...
[ "Hi ! `wiki_movies` was added in `datasets==1.2.0`. However it looks like you have `datasets==1.1.2`.\r\n\r\nTo use `wiki_movies`, please update `datasets` with\r\n```\r\npip install --upgrade datasets\r\n```", "Thanks a lot! That solved it and I was able to upload a model trained on it as well :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2103
2,103
citation, homepage, and license fields of `dataset_info.json` are duplicated many times
This happens after a `map` operation when `num_proc` is set to `>1`. I tested this by cleaning up the json before running the `map` op on the dataset so it's unlikely it's coming from an earlier concatenation. Example result: ``` "citation": "@ONLINE {wikidump,\n author = {Wikimedia Foundation},\n title = {...
closed
2021-03-23T17:18:09
https://api.github.com/repos/huggingface/datasets/issues/2103/comments
null
false
citation, homepage, and license fields of `dataset_info.json` are duplicated many times This happens after a `map` operation when `num_proc` is set to `>1`. I tested this by cleaning up the json before running the `map` op on the dataset so it's unlikely it's coming from an earlier concatenation. Example result: ``...
[ "Thanks for reporting :)\r\nMaybe we can concatenate fields only if they are different.\r\n\r\nCurrently this is done here:\r\n\r\nhttps://github.com/huggingface/nlp/blob/349ac4398a3bcae6356f14c5754483383a60e8a4/src/datasets/info.py#L180-L196\r\n\r\nThis can be a good first contribution to the library.\r\nPlease co...
https://api.github.com/repos/huggingface/datasets/issues/2102
2,102
Move Dataset.to_csv to csv module
Move the implementation of `Dataset.to_csv` to module `datasets.io.csv`.
closed
2021-03-23T14:35:46
https://api.github.com/repos/huggingface/datasets/issues/2102/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2102", "html_url": "https://github.com/huggingface/datasets/pull/2102", "diff_url": "https://github.com/huggingface/datasets/pull/2102.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2102.patch", "merged_at": "2021-03-24T14:07...
true
Move Dataset.to_csv to csv module Move the implementation of `Dataset.to_csv` to module `datasets.io.csv`.
[]
https://api.github.com/repos/huggingface/datasets/issues/2101
2,101
MIAM dataset - new citation details
Hi @lhoestq, I have updated the citations to reference an OpenReview preprint.
closed
2021-03-23T10:41:23
https://api.github.com/repos/huggingface/datasets/issues/2101/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2101", "html_url": "https://github.com/huggingface/datasets/pull/2101", "diff_url": "https://github.com/huggingface/datasets/pull/2101.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2101.patch", "merged_at": "2021-03-23T18:08...
true
MIAM dataset - new citation details Hi @lhoestq, I have updated the citations to reference an OpenReview preprint.
[ "Hi !\r\nLooks like there's a unicode error in the new citation in the miam.py file.\r\nCould you try to fix it ? Not sure from which character it comes from though\r\n\r\nYou can test if it works on your side with\r\n```\r\nRUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_con...
https://api.github.com/repos/huggingface/datasets/issues/2100
2,100
Fix deprecated warning message and docstring
Fix deprecated warnings: - Use deprecated Sphinx directive in docstring - Fix format of deprecated message - Raise FutureWarning
closed
2021-03-23T10:27:52
https://api.github.com/repos/huggingface/datasets/issues/2100/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2100", "html_url": "https://github.com/huggingface/datasets/pull/2100", "diff_url": "https://github.com/huggingface/datasets/pull/2100.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2100.patch", "merged_at": "2021-03-23T18:03...
true
Fix deprecated warning message and docstring Fix deprecated warnings: - Use deprecated Sphinx directive in docstring - Fix format of deprecated message - Raise FutureWarning
[ "I have a question: what about `dictionary_encode_column_`?\r\n- It is deprecated in Dataset, but it recommends using a non-existing method instead: `Dataset.dictionary_encode_column` does not exist.\r\n- It is NOT deprecated in DatasetDict.", "`dictionary_encode_column_ ` should be deprecated since it never work...
https://api.github.com/repos/huggingface/datasets/issues/2099
2,099
load_from_disk takes a long time to load local dataset
I have an extremely large tokenized dataset (24M examples) that loads in a few minutes. However, after adding a column similar to `input_ids` (basically a list of integers) and saving the dataset to disk, the load time goes to >1 hour. I've even tried using `np.uint8` after seeing #1985 but it doesn't seem to be helpin...
closed
2021-03-23T09:28:37
https://api.github.com/repos/huggingface/datasets/issues/2099/comments
null
false
load_from_disk takes a long time to load local dataset I have an extremely large tokenized dataset (24M examples) that loads in a few minutes. However, after adding a column similar to `input_ids` (basically a list of integers) and saving the dataset to disk, the load time goes to >1 hour. I've even tried using `np.uin...
[ "Hi !\r\nCan you share more information about the features of your dataset ? You can get them by printing `my_dataset.features`\r\nCan you also share the code of your `map` function ?", "It is actually just the tokenized `wikipedia` dataset with `input_ids`, `attention_mask`, etc, with one extra column which is a...
https://api.github.com/repos/huggingface/datasets/issues/2098
2,098
SQuAD version
Hi~ I want train on squad dataset. What's the version of the squad? Is it 1.1 or 1.0? I'm new in QA, I don't find some descriptions about it.
closed
2021-03-23T07:47:54
https://api.github.com/repos/huggingface/datasets/issues/2098/comments
null
false
SQuAD version Hi~ I want train on squad dataset. What's the version of the squad? Is it 1.1 or 1.0? I'm new in QA, I don't find some descriptions about it.
[ "Hi ! This is 1.1 as specified by the download urls here:\r\n\r\nhttps://github.com/huggingface/nlp/blob/349ac4398a3bcae6356f14c5754483383a60e8a4/datasets/squad/squad.py#L50-L55", "Got it. Thank you~" ]
https://api.github.com/repos/huggingface/datasets/issues/2097
2,097
fixes issue #1110 by descending further if `obj["_type"]` is a dict
Check metrics
closed
2021-03-22T21:00:55
https://api.github.com/repos/huggingface/datasets/issues/2097/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2097", "html_url": "https://github.com/huggingface/datasets/pull/2097", "diff_url": "https://github.com/huggingface/datasets/pull/2097.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2097.patch", "merged_at": null }
true
fixes issue #1110 by descending further if `obj["_type"]` is a dict Check metrics
[]
https://api.github.com/repos/huggingface/datasets/issues/2096
2,096
CoNLL 2003 dataset not including German
Hello, thanks for all the work on developing and maintaining this amazing platform, which I am enjoying working with! I was wondering if there is a reason why the German CoNLL 2003 dataset is not included in the [repository](https://github.com/huggingface/datasets/tree/master/datasets/conll2003), since a copy of it ...
closed
2021-03-22T19:23:56
https://api.github.com/repos/huggingface/datasets/issues/2096/comments
null
false
CoNLL 2003 dataset not including German Hello, thanks for all the work on developing and maintaining this amazing platform, which I am enjoying working with! I was wondering if there is a reason why the German CoNLL 2003 dataset is not included in the [repository](https://github.com/huggingface/datasets/tree/master/...
[ "Hello. I've been looking for information about German Conll2003 and found your question. Official site (https://www.clips.uantwerpen.be/conll2003/ner/) mentions that organizers provide only annotation. German texts (ECI Multilingual Text Corpus) are not freely available and can be ordered from the Linguistic Data ...
https://api.github.com/repos/huggingface/datasets/issues/2093
2,093
Fix: Allows a feature to be named "_type"
This PR tries to fix issue #1110. Sorry for taking so long to come back to this. It's a simple fix, but i am not sure if it works for all possible types of `obj`. Let me know what you think @lhoestq
closed
2021-03-21T23:21:57
https://api.github.com/repos/huggingface/datasets/issues/2093/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2093", "html_url": "https://github.com/huggingface/datasets/pull/2093", "diff_url": "https://github.com/huggingface/datasets/pull/2093.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2093.patch", "merged_at": "2021-03-25T14:35...
true
Fix: Allows a feature to be named "_type" This PR tries to fix issue #1110. Sorry for taking so long to come back to this. It's a simple fix, but i am not sure if it works for all possible types of `obj`. Let me know what you think @lhoestq
[ "Nice thank you !\r\nThis looks like a pretty simple yet effective fix ;)\r\nCould you just add a test in `test_features.py` to make sure that you can create `features` with a `_type` field and that it is possible to convert it as a dict and reload it ?\r\n```python\r\nfrom datasets import Features, Value\r\n\r\n# ...
https://api.github.com/repos/huggingface/datasets/issues/2092
2,092
How to disable making arrow tables in load_dataset ?
Is there a way to disable the construction of arrow tables, or to make them on the fly as the dataset is being used ?
closed
2021-03-21T04:50:07
https://api.github.com/repos/huggingface/datasets/issues/2092/comments
null
false
How to disable making arrow tables in load_dataset ? Is there a way to disable the construction of arrow tables, or to make them on the fly as the dataset is being used ?
[ "Hi ! We plan to add streaming features in the future.\r\n\r\nThis should allow to load a dataset instantaneously without generating the arrow table. The trade-off is that accessing examples from a streaming dataset must be done in an iterative way, and with an additional (but hopefully minor) overhead.\r\nWhat do ...
https://api.github.com/repos/huggingface/datasets/issues/2091
2,091
Fix copy snippet in docs
With this change the lines starting with `...` in the code blocks can be properly copied to clipboard.
closed
2021-03-20T15:08:22
https://api.github.com/repos/huggingface/datasets/issues/2091/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2091", "html_url": "https://github.com/huggingface/datasets/pull/2091", "diff_url": "https://github.com/huggingface/datasets/pull/2091.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2091.patch", "merged_at": "2021-03-23T17:18...
true
Fix copy snippet in docs With this change the lines starting with `...` in the code blocks can be properly copied to clipboard.
[]
https://api.github.com/repos/huggingface/datasets/issues/2090
2,090
Add machine translated multilingual STS benchmark dataset
also see here https://github.com/PhilipMay/stsb-multi-mt
closed
2021-03-20T13:28:07
https://api.github.com/repos/huggingface/datasets/issues/2090/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2090", "html_url": "https://github.com/huggingface/datasets/pull/2090", "diff_url": "https://github.com/huggingface/datasets/pull/2090.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2090.patch", "merged_at": "2021-03-29T13:00...
true
Add machine translated multilingual STS benchmark dataset also see here https://github.com/PhilipMay/stsb-multi-mt
[ "Hello dear maintainer, are there any comments or questions about this PR?", "@iamollas thanks for the feedback. I did not see the template.\r\nI improved it...", "Should be clean for merge IMO.", "@lhoestq CI is green. ;-)", "Thanks again ! this is awesome :)", "Thanks for merging. :-)" ]
https://api.github.com/repos/huggingface/datasets/issues/2089
2,089
Add documentaton for dataset README.md files
Hi, the dataset README files have special headers. Somehow a documenation of the allowed values and tags is missing. Could you add that? Just to give some concrete questions that should be answered imo: - which values can be passted to multilinguality? - what should be passed to language_creators? - which valu...
closed
2021-03-20T11:44:38
https://api.github.com/repos/huggingface/datasets/issues/2089/comments
null
false
Add documentaton for dataset README.md files Hi, the dataset README files have special headers. Somehow a documenation of the allowed values and tags is missing. Could you add that? Just to give some concrete questions that should be answered imo: - which values can be passted to multilinguality? - what should ...
[ "Hi ! We are using the [datasets-tagging app](https://github.com/huggingface/datasets-tagging) to select the tags to add.\r\n\r\nWe are also adding the full list of tags in #2107 \r\nThis covers multilinguality, language_creators, licenses, size_categories and task_categories.\r\n\r\nIn general if you want to add a...
https://api.github.com/repos/huggingface/datasets/issues/2088
2,088
change bibtex template to author instead of authors
Hi, IMO when using BibTex Author should be used instead of Authors. See here: http://www.bibtex.org/Using/de/ Thanks Philip
closed
2021-03-20T09:23:44
https://api.github.com/repos/huggingface/datasets/issues/2088/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2088", "html_url": "https://github.com/huggingface/datasets/pull/2088", "diff_url": "https://github.com/huggingface/datasets/pull/2088.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2088.patch", "merged_at": "2021-03-23T15:40...
true
change bibtex template to author instead of authors Hi, IMO when using BibTex Author should be used instead of Authors. See here: http://www.bibtex.org/Using/de/ Thanks Philip
[ "Trailing whitespace was removed. So more changes in diff than just this fix." ]
https://api.github.com/repos/huggingface/datasets/issues/2087
2,087
Update metadata if dataset features are modified
This PR adds a decorator that updates the dataset metadata if a previously executed transform modifies its features. Fixes #2083
closed
2021-03-20T02:05:23
https://api.github.com/repos/huggingface/datasets/issues/2087/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2087", "html_url": "https://github.com/huggingface/datasets/pull/2087", "diff_url": "https://github.com/huggingface/datasets/pull/2087.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2087.patch", "merged_at": "2021-04-09T09:25...
true
Update metadata if dataset features are modified This PR adds a decorator that updates the dataset metadata if a previously executed transform modifies its features. Fixes #2083
[ "@lhoestq I'll try to add a test later if you think this approach with the wrapper is good.", "Awesome thank you !\r\nYes this approach with a wrapper is good :)", "@lhoestq Added a test. To verify that this change fixes the problem, replace:\r\n```\r\n!pip install datasets==1.5\r\n```\r\nwith:\r\n```\r\n!pip i...
https://api.github.com/repos/huggingface/datasets/issues/2086
2,086
change user permissions to -rw-r--r--
Fix for #2065
closed
2021-03-19T18:14:56
https://api.github.com/repos/huggingface/datasets/issues/2086/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2086", "html_url": "https://github.com/huggingface/datasets/pull/2086", "diff_url": "https://github.com/huggingface/datasets/pull/2086.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2086.patch", "merged_at": "2021-03-24T13:59...
true
change user permissions to -rw-r--r-- Fix for #2065
[ "I tried this with `ade_corpus_v2` dataset. `ade_corpus_v2-train.arrow` (downloaded dataset) and `cache-25d41a4d3c2d8a25.arrow` (ran a mapping function on the dataset) both had file permission with octal value of `0644`. " ]
https://api.github.com/repos/huggingface/datasets/issues/2085
2,085
Fix max_wait_time in requests
it was handled as a min time, not max cc @SBrandeis
closed
2021-03-19T11:22:26
https://api.github.com/repos/huggingface/datasets/issues/2085/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2085", "html_url": "https://github.com/huggingface/datasets/pull/2085", "diff_url": "https://github.com/huggingface/datasets/pull/2085.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2085.patch", "merged_at": "2021-03-23T15:36...
true
Fix max_wait_time in requests it was handled as a min time, not max cc @SBrandeis
[]
https://api.github.com/repos/huggingface/datasets/issues/2084
2,084
CUAD - Contract Understanding Atticus Dataset
## Adding a Dataset - **Name:** CUAD - Contract Understanding Atticus Dataset - **Description:** As one of the only large, specialized NLP benchmarks annotated by experts, CUAD can serve as a challenging research benchmark for the broader NLP community. - **Paper:** https://arxiv.org/abs/2103.06268 - **Data:** http...
closed
2021-03-19T09:27:43
https://api.github.com/repos/huggingface/datasets/issues/2084/comments
null
false
CUAD - Contract Understanding Atticus Dataset ## Adding a Dataset - **Name:** CUAD - Contract Understanding Atticus Dataset - **Description:** As one of the only large, specialized NLP benchmarks annotated by experts, CUAD can serve as a challenging research benchmark for the broader NLP community. - **Paper:** http...
[ "+1 on this request" ]
https://api.github.com/repos/huggingface/datasets/issues/2083
2,083
`concatenate_datasets` throws error when changing the order of datasets to concatenate
Hey, I played around with the `concatenate_datasets(...)` function: https://huggingface.co/docs/datasets/package_reference/main_classes.html?highlight=concatenate_datasets#datasets.concatenate_datasets and noticed that when the order in which the datasets are concatenated changes an error is thrown where it shou...
closed
2021-03-19T08:29:48
https://api.github.com/repos/huggingface/datasets/issues/2083/comments
null
false
`concatenate_datasets` throws error when changing the order of datasets to concatenate Hey, I played around with the `concatenate_datasets(...)` function: https://huggingface.co/docs/datasets/package_reference/main_classes.html?highlight=concatenate_datasets#datasets.concatenate_datasets and noticed that when th...
[ "Hi,\r\n\r\nthis bug is related to `Dataset.{remove_columns, rename_column, flatten}` not propagating the change to the schema metadata when the info features are updated, so this line is the culprit:\r\n```python\r\ncommon_voice_train = common_voice_train.remove_columns(['client_id', 'up_votes', 'down_votes', 'age...
https://api.github.com/repos/huggingface/datasets/issues/2082
2,082
Updated card using information from data statement and datasheet
I updated and clarified the REFreSD [data card](https://github.com/mcmillanmajora/datasets/blob/refresd_card/datasets/refresd/README.md) with information from the Eleftheria's [website](https://elbria.github.io/post/refresd/). I added brief descriptions where the initial card referred to the paper, and I also recreated...
closed
2021-03-19T00:39:38
https://api.github.com/repos/huggingface/datasets/issues/2082/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2082", "html_url": "https://github.com/huggingface/datasets/pull/2082", "diff_url": "https://github.com/huggingface/datasets/pull/2082.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2082.patch", "merged_at": "2021-03-19T14:29...
true
Updated card using information from data statement and datasheet I updated and clarified the REFreSD [data card](https://github.com/mcmillanmajora/datasets/blob/refresd_card/datasets/refresd/README.md) with information from the Eleftheria's [website](https://elbria.github.io/post/refresd/). I added brief descriptions w...
[]
https://api.github.com/repos/huggingface/datasets/issues/2081
2,081
Fix docstrings issues
Fix docstring issues.
closed
2021-03-18T18:11:01
https://api.github.com/repos/huggingface/datasets/issues/2081/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2081", "html_url": "https://github.com/huggingface/datasets/pull/2081", "diff_url": "https://github.com/huggingface/datasets/pull/2081.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2081.patch", "merged_at": "2021-04-07T14:37...
true
Fix docstrings issues Fix docstring issues.
[]
https://api.github.com/repos/huggingface/datasets/issues/2080
2,080
Multidimensional arrays in a Dataset
Hi, I'm trying to put together a `datasets.Dataset` to be used with LayoutLM which is available in `transformers`. This model requires as input the bounding boxes of each of the token of a sequence. This is when I realized that `Dataset` does not support multi-dimensional arrays as a value for a column in a row. ...
closed
2021-03-18T16:29:14
https://api.github.com/repos/huggingface/datasets/issues/2080/comments
null
false
Multidimensional arrays in a Dataset Hi, I'm trying to put together a `datasets.Dataset` to be used with LayoutLM which is available in `transformers`. This model requires as input the bounding boxes of each of the token of a sequence. This is when I realized that `Dataset` does not support multi-dimensional arrays ...
[ "Hi !\r\n\r\nThis is actually supported ! but not yet in `from_pandas`.\r\nYou can use `from_dict` for now instead:\r\n```python\r\nfrom datasets import Dataset, Array2D, Features, Value\r\nimport pandas as pd\r\nimport numpy as np\r\n\r\ndataset = {\r\n 'bbox': [\r\n np.array([[1,2,3,4],[1,2,3,4],[1,2,3,...
https://api.github.com/repos/huggingface/datasets/issues/2079
2,079
Refactorize Metric.compute signature to force keyword arguments only
Minor refactoring of Metric.compute signature to force the use of keyword arguments, by using the single star syntax.
closed
2021-03-18T15:05:50
https://api.github.com/repos/huggingface/datasets/issues/2079/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2079", "html_url": "https://github.com/huggingface/datasets/pull/2079", "diff_url": "https://github.com/huggingface/datasets/pull/2079.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2079.patch", "merged_at": "2021-03-23T15:31...
true
Refactorize Metric.compute signature to force keyword arguments only Minor refactoring of Metric.compute signature to force the use of keyword arguments, by using the single star syntax.
[]
https://api.github.com/repos/huggingface/datasets/issues/2078
2,078
MemoryError when computing WER metric
Hi, I'm trying to follow the ASR example to try Wav2Vec. This is the code that I use for WER calculation: ``` wer = load_metric("wer") print(wer.compute(predictions=result["predicted"], references=result["target"])) ``` However, I receive the following exception: `Traceback (most recent call last): File ...
closed
2021-03-18T11:30:05
https://api.github.com/repos/huggingface/datasets/issues/2078/comments
null
false
MemoryError when computing WER metric Hi, I'm trying to follow the ASR example to try Wav2Vec. This is the code that I use for WER calculation: ``` wer = load_metric("wer") print(wer.compute(predictions=result["predicted"], references=result["target"])) ``` However, I receive the following exception: `Trace...
[ "Hi ! Thanks for reporting.\r\nWe're indeed using `jiwer` to compute the WER.\r\n\r\nMaybe instead of calling `jiwer.wer` once for all the preditions/references we can compute the WER iteratively to avoid memory issues ? I'm not too familial with `jiwer` but this must be possible.\r\n\r\nCurrently the code to compu...
https://api.github.com/repos/huggingface/datasets/issues/2077
2,077
Bump huggingface_hub version
`0.0.2 => 0.0.6`
closed
2021-03-18T10:54:34
https://api.github.com/repos/huggingface/datasets/issues/2077/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2077", "html_url": "https://github.com/huggingface/datasets/pull/2077", "diff_url": "https://github.com/huggingface/datasets/pull/2077.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2077.patch", "merged_at": "2021-03-18T11:33...
true
Bump huggingface_hub version `0.0.2 => 0.0.6`
[ "🔥 " ]
https://api.github.com/repos/huggingface/datasets/issues/2076
2,076
Issue: Dataset download error
The download link in `iwslt2017.py` file does not seem to work anymore. For example, `FileNotFoundError: Couldn't find file at https://wit3.fbk.eu/archive/2017-01-trnted/texts/zh/en/zh-en.tgz` Would be nice if we could modify it script and use the new downloadable link?
open
2021-03-18T06:36:06
https://api.github.com/repos/huggingface/datasets/issues/2076/comments
null
false
Issue: Dataset download error The download link in `iwslt2017.py` file does not seem to work anymore. For example, `FileNotFoundError: Couldn't find file at https://wit3.fbk.eu/archive/2017-01-trnted/texts/zh/en/zh-en.tgz` Would be nice if we could modify it script and use the new downloadable link?
[ "Hi @XuhuiZhou, thanks for reporting this issue. \r\n\r\nIndeed, the old links are no longer valid (404 Not Found error), and the script must be updated with the new links to Google Drive.", "It would be nice to update the urls indeed !\r\n\r\nTo do this, you just need to replace the urls in `iwslt2017.py` and th...
https://api.github.com/repos/huggingface/datasets/issues/2075
2,075
ConnectionError: Couldn't reach common_voice.py
When I run: from datasets import load_dataset, load_metric common_voice_train = load_dataset("common_voice", "zh-CN", split="train+validation") common_voice_test = load_dataset("common_voice", "zh-CN", split="test") Got: ConnectionError: Couldn't reach https://raw.githubusercontent.com/huggingface/datasets/ma...
closed
2021-03-18T01:19:06
https://api.github.com/repos/huggingface/datasets/issues/2075/comments
null
false
ConnectionError: Couldn't reach common_voice.py When I run: from datasets import load_dataset, load_metric common_voice_train = load_dataset("common_voice", "zh-CN", split="train+validation") common_voice_test = load_dataset("common_voice", "zh-CN", split="test") Got: ConnectionError: Couldn't reach https://r...
[ "Hi @LifaSun, thanks for reporting this issue.\r\n\r\nSometimes, GitHub has some connectivity problems. Could you confirm that the problem persists?", "@albertvillanova Thanks! It works well now. " ]
https://api.github.com/repos/huggingface/datasets/issues/2074
2,074
Fix size categories in YAML Tags
This PR fixes several `size_categories` in YAML tags and makes them consistent. Additionally, I have added a few more categories after `1M`, up to `1T`. I would like to add that to the streamlit app also. This PR also adds a couple of infos that I found missing. The code for generating this: ```python for datas...
closed
2021-03-18T00:02:36
https://api.github.com/repos/huggingface/datasets/issues/2074/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2074", "html_url": "https://github.com/huggingface/datasets/pull/2074", "diff_url": "https://github.com/huggingface/datasets/pull/2074.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2074.patch", "merged_at": "2021-03-23T17:11...
true
Fix size categories in YAML Tags This PR fixes several `size_categories` in YAML tags and makes them consistent. Additionally, I have added a few more categories after `1M`, up to `1T`. I would like to add that to the streamlit app also. This PR also adds a couple of infos that I found missing. The code for gener...
[ "> It would be great if there was a way to make the task categories consistent too. For this, the streamlit app can look into all the datasets and check for existing categories and show them in the list. This may add some consistency.\r\n\r\nWe can also update the task lists here: https://github.com/huggingface/dat...
https://api.github.com/repos/huggingface/datasets/issues/2073
2,073
Fixes check of TF_AVAILABLE and TORCH_AVAILABLE
# What is this PR doing This PR implements the checks if `Tensorflow` and `Pytorch` are available the same way as `transformers` does it. I added the additional checks for the different `Tensorflow` and `torch` versions. #2068
closed
2021-03-17T21:28:53
https://api.github.com/repos/huggingface/datasets/issues/2073/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2073", "html_url": "https://github.com/huggingface/datasets/pull/2073", "diff_url": "https://github.com/huggingface/datasets/pull/2073.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2073.patch", "merged_at": "2021-03-18T09:09...
true
Fixes check of TF_AVAILABLE and TORCH_AVAILABLE # What is this PR doing This PR implements the checks if `Tensorflow` and `Pytorch` are available the same way as `transformers` does it. I added the additional checks for the different `Tensorflow` and `torch` versions. #2068
[]
https://api.github.com/repos/huggingface/datasets/issues/2072
2,072
Fix docstring issues
Fix docstring issues.
closed
2021-03-17T18:13:44
https://api.github.com/repos/huggingface/datasets/issues/2072/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2072", "html_url": "https://github.com/huggingface/datasets/pull/2072", "diff_url": "https://github.com/huggingface/datasets/pull/2072.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2072.patch", "merged_at": "2021-03-18T12:41...
true
Fix docstring issues Fix docstring issues.
[ "I think I will stop pushing to this PR, so that it can me merged for today release. \r\n\r\nI will open another PR for further fixing docs.\r\n\r\nDo you agree, @lhoestq ?", "Sounds good thanks !" ]
https://api.github.com/repos/huggingface/datasets/issues/2071
2,071
Multiprocessing is slower than single process
```python # benchmark_filter.py import logging import sys import time from datasets import load_dataset, set_caching_enabled if __name__ == "__main__": set_caching_enabled(False) logging.basicConfig(level=logging.DEBUG) bc = load_dataset("bookcorpus") now = time.time() try: ...
closed
2021-03-17T16:08:58
https://api.github.com/repos/huggingface/datasets/issues/2071/comments
null
false
Multiprocessing is slower than single process ```python # benchmark_filter.py import logging import sys import time from datasets import load_dataset, set_caching_enabled if __name__ == "__main__": set_caching_enabled(False) logging.basicConfig(level=logging.DEBUG) bc = load_dataset("bookco...
[ "dupe of #1992" ]
https://api.github.com/repos/huggingface/datasets/issues/2070
2,070
ArrowInvalid issue for squad v2 dataset
Hello, I am using the huggingface official question answering example notebook (https://colab.research.google.com/github/huggingface/notebooks/blob/master/examples/question_answering.ipynb). In the prepare_validation_features function, I made some modifications to tokenize a new set of quesions with the original co...
closed
2021-03-17T13:51:49
https://api.github.com/repos/huggingface/datasets/issues/2070/comments
null
false
ArrowInvalid issue for squad v2 dataset Hello, I am using the huggingface official question answering example notebook (https://colab.research.google.com/github/huggingface/notebooks/blob/master/examples/question_answering.ipynb). In the prepare_validation_features function, I made some modifications to tokenize a ...
[ "Hi ! This error happens when you use `map` in batched mode and then your function doesn't return the same number of values per column.\r\n\r\nIndeed since you're using `map` in batched mode, `prepare_validation_features` must take a batch as input (i.e. a dictionary of multiple rows of the dataset), and return a b...
https://api.github.com/repos/huggingface/datasets/issues/2069
2,069
Add and fix docstring for NamedSplit
Add and fix docstring for `NamedSplit`, which was missing.
closed
2021-03-17T13:19:28
https://api.github.com/repos/huggingface/datasets/issues/2069/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2069", "html_url": "https://github.com/huggingface/datasets/pull/2069", "diff_url": "https://github.com/huggingface/datasets/pull/2069.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2069.patch", "merged_at": "2021-03-18T10:27...
true
Add and fix docstring for NamedSplit Add and fix docstring for `NamedSplit`, which was missing.
[ "Maybe we should add some other split classes?" ]
https://api.github.com/repos/huggingface/datasets/issues/2068
2,068
PyTorch not available error on SageMaker GPU docker though it is installed
I get en error when running data loading using SageMaker SDK ``` File "main.py", line 34, in <module> run_training() File "main.py", line 25, in run_training dm.setup('fit') File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/core/datamodule.py", line 92, in wrapped_fn return fn(*a...
closed
2021-03-17T10:04:27
https://api.github.com/repos/huggingface/datasets/issues/2068/comments
null
false
PyTorch not available error on SageMaker GPU docker though it is installed I get en error when running data loading using SageMaker SDK ``` File "main.py", line 34, in <module> run_training() File "main.py", line 25, in run_training dm.setup('fit') File "/opt/conda/lib/python3.6/site-packages/pyt...
[ "cc @philschmid ", "Hey @sivakhno,\r\n\r\nhow does your `requirements.txt` look like to install the `datasets` library and which version of it are you running? Can you try to install `datasets>=1.4.0`", "Hi @philschmid - thanks for suggestion. I am using `datasets==1.4.1`. \r\nI have also tried using `torch=1.6...
https://api.github.com/repos/huggingface/datasets/issues/2067
2,067
Multiprocessing windows error
As described here https://huggingface.co/blog/fine-tune-xlsr-wav2vec2 When using the num_proc argument on windows the whole Python environment crashes and hanging in loop. For example at the map_to_array part. An error occures because the cache file already exists and windows throws and error. After this the log c...
closed
2021-03-17T09:12:28
https://api.github.com/repos/huggingface/datasets/issues/2067/comments
null
false
Multiprocessing windows error As described here https://huggingface.co/blog/fine-tune-xlsr-wav2vec2 When using the num_proc argument on windows the whole Python environment crashes and hanging in loop. For example at the map_to_array part. An error occures because the cache file already exists and windows throws a...
[ "Hi ! Thanks for reporting.\r\nThis looks like a bug, could you try to provide a minimal code example that reproduces the issue ? This would be very helpful !\r\n\r\nOtherwise I can try to run the wav2vec2 code above on my side but probably not this week..", "```\r\nfrom datasets import load_dataset\r\n\r\ndatase...
https://api.github.com/repos/huggingface/datasets/issues/2066
2,066
Fix docstring rendering of Dataset/DatasetDict.from_csv args
Fix the docstring rendering of Dataset/DatasetDict.from_csv args.
closed
2021-03-17T07:23:10
https://api.github.com/repos/huggingface/datasets/issues/2066/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2066", "html_url": "https://github.com/huggingface/datasets/pull/2066", "diff_url": "https://github.com/huggingface/datasets/pull/2066.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2066.patch", "merged_at": "2021-03-17T09:21...
true
Fix docstring rendering of Dataset/DatasetDict.from_csv args Fix the docstring rendering of Dataset/DatasetDict.from_csv args.
[]
https://api.github.com/repos/huggingface/datasets/issues/2065
2,065
Only user permission of saved cache files, not group
Hello, It seems when a cached file is saved from calling `dataset.map` for preprocessing, it gets the user permissions and none of the user's group permissions. As we share data files across members of our team, this is causing a bit of an issue as we have to continually reset the permission of the files. Do you kno...
closed
2021-03-17T00:20:22
https://api.github.com/repos/huggingface/datasets/issues/2065/comments
null
false
Only user permission of saved cache files, not group Hello, It seems when a cached file is saved from calling `dataset.map` for preprocessing, it gets the user permissions and none of the user's group permissions. As we share data files across members of our team, this is causing a bit of an issue as we have to cont...
[ "Hi ! Thanks for reporting.\r\n\r\nCurrently there's no way to specify this.\r\n\r\nWhen loading/processing a dataset, the arrow file is written using a temporary file. Then once writing is finished, it's moved to the cache directory (using `shutil.move` [here](https://github.com/huggingface/datasets/blob/f6b8251eb...
https://api.github.com/repos/huggingface/datasets/issues/2064
2,064
Fix ted_talks_iwslt version error
This PR fixes the bug where the version argument would be passed twice if the dataset configuration was created on the fly. Fixes #2059
closed
2021-03-16T16:43:45
https://api.github.com/repos/huggingface/datasets/issues/2064/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2064", "html_url": "https://github.com/huggingface/datasets/pull/2064", "diff_url": "https://github.com/huggingface/datasets/pull/2064.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2064.patch", "merged_at": "2021-03-16T18:00...
true
Fix ted_talks_iwslt version error This PR fixes the bug where the version argument would be passed twice if the dataset configuration was created on the fly. Fixes #2059
[]
https://api.github.com/repos/huggingface/datasets/issues/2063
2,063
[Common Voice] Adapt dataset script so that no manual data download is actually needed
This PR changes the dataset script so that no manual data dir is needed anymore.
closed
2021-03-16T16:33:44
https://api.github.com/repos/huggingface/datasets/issues/2063/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2063", "html_url": "https://github.com/huggingface/datasets/pull/2063", "diff_url": "https://github.com/huggingface/datasets/pull/2063.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2063.patch", "merged_at": "2021-03-17T09:42...
true
[Common Voice] Adapt dataset script so that no manual data download is actually needed This PR changes the dataset script so that no manual data dir is needed anymore.
[]
https://api.github.com/repos/huggingface/datasets/issues/2062
2,062
docs: fix missing quotation
The json code misses a quote
closed
2021-03-16T10:07:54
https://api.github.com/repos/huggingface/datasets/issues/2062/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2062", "html_url": "https://github.com/huggingface/datasets/pull/2062", "diff_url": "https://github.com/huggingface/datasets/pull/2062.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2062.patch", "merged_at": "2021-03-17T09:21...
true
docs: fix missing quotation The json code misses a quote
[]
https://api.github.com/repos/huggingface/datasets/issues/2061
2,061
Cannot load udpos subsets from xtreme dataset using load_dataset()
Hello, I am trying to load the udpos English subset from xtreme dataset, but this faces an error during loading. I am using datasets v1.4.1, pip install. I have tried with other udpos languages which also fail, though loading a different subset altogether (such as XNLI) has no issue. I have also tried on Colab and ...
closed
2021-03-16T09:32:13
https://api.github.com/repos/huggingface/datasets/issues/2061/comments
null
false
Cannot load udpos subsets from xtreme dataset using load_dataset() Hello, I am trying to load the udpos English subset from xtreme dataset, but this faces an error during loading. I am using datasets v1.4.1, pip install. I have tried with other udpos languages which also fail, though loading a different subset alto...
[ "@lhoestq Adding \"_\" to the class labels in the dataset script will fix the issue.\r\n\r\nThe bigger issue IMO is that the data files are in conll format, but the examples are tokens, not sentences.", "Hi ! Thanks for reporting @adzcodez \r\n\r\n\r\n> @lhoestq Adding \"_\" to the class labels in the dataset scr...
https://api.github.com/repos/huggingface/datasets/issues/2060
2,060
Filtering refactor
fix https://github.com/huggingface/datasets/issues/2032 benchmarking is somewhat inconclusive, currently running on `book_corpus` with: ```python bc = load_dataset("bookcorpus") now = time.time() bc.filter(lambda x: len(x["text"]) < 64) elapsed = time.time() - now print(elapsed) ``` t...
closed
2021-03-16T09:23:30
https://api.github.com/repos/huggingface/datasets/issues/2060/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2060", "html_url": "https://github.com/huggingface/datasets/pull/2060", "diff_url": "https://github.com/huggingface/datasets/pull/2060.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2060.patch", "merged_at": null }
true
Filtering refactor fix https://github.com/huggingface/datasets/issues/2032 benchmarking is somewhat inconclusive, currently running on `book_corpus` with: ```python bc = load_dataset("bookcorpus") now = time.time() bc.filter(lambda x: len(x["text"]) < 64) elapsed = time.time() - now print...
[ "I thought at first that the multiproc test was not relevant now that we do stuff only in memory, but I think there's something that's actually broken, my tiny benchmark on bookcorpus runs forever (2hrs+) when I add `num_proc=4` as a kwarg, will investigate 👀 \r\n\r\nI'm not familiar with the caching you describe ...
https://api.github.com/repos/huggingface/datasets/issues/2059
2,059
Error while following docs to load the `ted_talks_iwslt` dataset
I am currently trying to load the `ted_talks_iwslt` dataset into google colab. The [docs](https://huggingface.co/datasets/ted_talks_iwslt) mention the following way of doing so. ```python dataset = load_dataset("ted_talks_iwslt", language_pair=("it", "pl"), year="2014") ``` Executing it results in the error ...
closed
2021-03-16T09:12:19
https://api.github.com/repos/huggingface/datasets/issues/2059/comments
null
false
Error while following docs to load the `ted_talks_iwslt` dataset I am currently trying to load the `ted_talks_iwslt` dataset into google colab. The [docs](https://huggingface.co/datasets/ted_talks_iwslt) mention the following way of doing so. ```python dataset = load_dataset("ted_talks_iwslt", language_pair=("it...
[ "@skyprince999 as you authored the PR for this dataset, any comments?", "This has been fixed in #2064 by @mariosasko (thanks again !)\r\n\r\nThe fix is available on the master branch and we'll do a new release very soon :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2058
2,058
Is it possible to convert a `tfds` to HuggingFace `dataset`?
I was having some weird bugs with `C4`dataset version of HuggingFace, so I decided to try to download `C4`from `tfds`. I would like to know if it is possible to convert a tfds dataset to HuggingFace dataset format :) I can also open a new issue reporting the bug I'm receiving with `datasets.load_dataset('c4','en')` ...
closed
2021-03-15T20:18:47
https://api.github.com/repos/huggingface/datasets/issues/2058/comments
null
false
Is it possible to convert a `tfds` to HuggingFace `dataset`? I was having some weird bugs with `C4`dataset version of HuggingFace, so I decided to try to download `C4`from `tfds`. I would like to know if it is possible to convert a tfds dataset to HuggingFace dataset format :) I can also open a new issue reporting t...
[ "Hi! You can either save the TF dataset to one of the formats supported by datasets (`parquet`, `csv`, `json`, ...) or pass a generator function to `Dataset.from_generator` that yields its examples." ]
https://api.github.com/repos/huggingface/datasets/issues/2057
2,057
update link to ZEST dataset
Updating the link as the original one is no longer working.
closed
2021-03-15T19:22:57
https://api.github.com/repos/huggingface/datasets/issues/2057/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2057", "html_url": "https://github.com/huggingface/datasets/pull/2057", "diff_url": "https://github.com/huggingface/datasets/pull/2057.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2057.patch", "merged_at": "2021-03-16T17:06...
true
update link to ZEST dataset Updating the link as the original one is no longer working.
[]
https://api.github.com/repos/huggingface/datasets/issues/2056
2,056
issue with opus100/en-fr dataset
Hi I am running run_mlm.py code of huggingface repo with opus100/fr-en pair, I am getting this error, note that this error occurs for only this pairs and not the other pairs. Any idea why this is occurring? and how I can solve this? Thanks a lot @lhoestq for your help in advance. ` thread '<unnamed>' panicked...
closed
2021-03-15T11:32:42
https://api.github.com/repos/huggingface/datasets/issues/2056/comments
null
false
issue with opus100/en-fr dataset Hi I am running run_mlm.py code of huggingface repo with opus100/fr-en pair, I am getting this error, note that this error occurs for only this pairs and not the other pairs. Any idea why this is occurring? and how I can solve this? Thanks a lot @lhoestq for your help in advance....
[ "@lhoestq I also deleted the cache and redownload the file and still the same issue, I appreciate any help on this. thanks ", "Here please find the minimal code to reproduce the issue @lhoestq note this only happens with MT5TokenizerFast\r\n\r\n```\r\nfrom datasets import load_dataset\r\nfrom transformers impor...
https://api.github.com/repos/huggingface/datasets/issues/2055
2,055
is there a way to override a dataset object saved with save_to_disk?
At the moment when I use save_to_disk, it uses the arbitrary name for the arrow file. Is there a way to override such an object?
closed
2021-03-15T10:50:53
https://api.github.com/repos/huggingface/datasets/issues/2055/comments
null
false
is there a way to override a dataset object saved with save_to_disk? At the moment when I use save_to_disk, it uses the arbitrary name for the arrow file. Is there a way to override such an object?
[ "Hi\r\nYou can rename the arrow file and update the name in `state.json`", "I tried this way, but when there is a mapping process to the dataset, it again uses a random cache name. atm, I am trying to use the following method by setting an exact cache file,\r\n\r\n```\r\n dataset_with_embedding =csv_da...
https://api.github.com/repos/huggingface/datasets/issues/2054
2,054
Could not find file for ZEST dataset
I am trying to use zest dataset from Allen AI using below code in colab, ``` !pip install -q datasets from datasets import load_dataset dataset = load_dataset("zest") ``` I am getting the following error, ``` Using custom data configuration default Downloading and preparing dataset zest/default (download: ...
closed
2021-03-15T09:11:58
https://api.github.com/repos/huggingface/datasets/issues/2054/comments
null
false
Could not find file for ZEST dataset I am trying to use zest dataset from Allen AI using below code in colab, ``` !pip install -q datasets from datasets import load_dataset dataset = load_dataset("zest") ``` I am getting the following error, ``` Using custom data configuration default Downloading and prepa...
[ "The zest dataset url was changed (allenai/zest#3) and #2057 should resolve this.", "This has been fixed in #2057 by @matt-peters (thanks again !)\r\n\r\nThe fix is available on the master branch and we'll do a new release very soon :)", "Thanks @lhoestq and @matt-peters ", "I am closing this issue since its ...
https://api.github.com/repos/huggingface/datasets/issues/2053
2,053
Add bAbI QA tasks
- **Name:** *The (20) QA bAbI tasks* - **Description:** *The (20) QA bAbI tasks are a set of proxy tasks that evaluate reading comprehension via question answering. Our tasks measure understanding in several ways: whether a system is able to answer questions via chaining facts, simple induction, deduction and many mor...
closed
2021-03-14T13:04:39
https://api.github.com/repos/huggingface/datasets/issues/2053/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2053", "html_url": "https://github.com/huggingface/datasets/pull/2053", "diff_url": "https://github.com/huggingface/datasets/pull/2053.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2053.patch", "merged_at": "2021-03-29T12:41...
true
Add bAbI QA tasks - **Name:** *The (20) QA bAbI tasks* - **Description:** *The (20) QA bAbI tasks are a set of proxy tasks that evaluate reading comprehension via question answering. Our tasks measure understanding in several ways: whether a system is able to answer questions via chaining facts, simple induction, dedu...
[ "Hi @lhoestq,\r\n\r\nShould I remove the 160 configurations? Is it too much?\r\n\r\nEDIT:\r\nCan you also check the task category? I'm not sure if there is an appropriate tag for the same.", "Thanks for the changes !\r\n\r\n> Should I remove the 160 configurations? Is it too much?\r\n\r\nYea 160 configuration is ...
https://api.github.com/repos/huggingface/datasets/issues/2052
2,052
Timit_asr dataset repeats examples
Summary When loading timit_asr dataset on datasets 1.4+, every row in the dataset is the same Steps to reproduce As an example, on this code there is the text from the training part: Code snippet: ``` from datasets import load_dataset, load_metric timit = load_dataset("timit_asr") timit['train']['text']...
closed
2021-03-14T11:43:43
https://api.github.com/repos/huggingface/datasets/issues/2052/comments
null
false
Timit_asr dataset repeats examples Summary When loading timit_asr dataset on datasets 1.4+, every row in the dataset is the same Steps to reproduce As an example, on this code there is the text from the training part: Code snippet: ``` from datasets import load_dataset, load_metric timit = load_dataset("...
[ "Hi,\r\n\r\nthis was fixed by #1995, so you can wait for the next release or install the package directly from the master branch with the following command: \r\n```bash\r\npip install git+https://github.com/huggingface/datasets\r\n```", "Ty!" ]
https://api.github.com/repos/huggingface/datasets/issues/2051
2,051
Add MDD Dataset
- **Name:** *MDD Dataset* - **Description:** The Movie Dialog dataset (MDD) is designed to measure how well models can perform at goal and non-goal orientated dialog centered around the topic of movies (question answering, recommendation and discussion), from various movie reviews sources such as MovieLens and OMDb. ...
closed
2021-03-14T00:01:05
https://api.github.com/repos/huggingface/datasets/issues/2051/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2051", "html_url": "https://github.com/huggingface/datasets/pull/2051", "diff_url": "https://github.com/huggingface/datasets/pull/2051.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2051.patch", "merged_at": "2021-03-19T10:31...
true
Add MDD Dataset - **Name:** *MDD Dataset* - **Description:** The Movie Dialog dataset (MDD) is designed to measure how well models can perform at goal and non-goal orientated dialog centered around the topic of movies (question answering, recommendation and discussion), from various movie reviews sources such as Movie...
[ "Hi @lhoestq,\r\n\r\nI have added changes from review.", "Thanks for approving :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2050
2,050
Build custom dataset to fine-tune Wav2Vec2
Thank you for your recent tutorial on how to finetune Wav2Vec2 on a custom dataset. The example you gave here (https://huggingface.co/blog/fine-tune-xlsr-wav2vec2) was on the CommonVoice dataset. However, what if I want to load my own dataset? I have a manifest (transcript and their audio files) in a JSON file.
closed
2021-03-13T22:01:10
https://api.github.com/repos/huggingface/datasets/issues/2050/comments
null
false
Build custom dataset to fine-tune Wav2Vec2 Thank you for your recent tutorial on how to finetune Wav2Vec2 on a custom dataset. The example you gave here (https://huggingface.co/blog/fine-tune-xlsr-wav2vec2) was on the CommonVoice dataset. However, what if I want to load my own dataset? I have a manifest (transcript an...
[ "@lhoestq - We could simply use the \"general\" json dataset for this no? ", "Sure you can use the json loader\r\n```python\r\ndata_files = {\"train\": \"path/to/your/train_data.json\", \"test\": \"path/to/your/test_data.json\"}\r\ntrain_dataset = load_dataset(\"json\", data_files=data_files, split=\"train\")\r\n...
https://api.github.com/repos/huggingface/datasets/issues/2049
2,049
Fix text-classification tags
There are different tags for text classification right now: `text-classification` and `text_classification`: ![image](https://user-images.githubusercontent.com/29076344/111042457-856bdf00-8463-11eb-93c9-50a30106a1a1.png). This PR fixes it.
closed
2021-03-13T19:51:42
https://api.github.com/repos/huggingface/datasets/issues/2049/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2049", "html_url": "https://github.com/huggingface/datasets/pull/2049", "diff_url": "https://github.com/huggingface/datasets/pull/2049.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2049.patch", "merged_at": "2021-03-16T15:47...
true
Fix text-classification tags There are different tags for text classification right now: `text-classification` and `text_classification`: ![image](https://user-images.githubusercontent.com/29076344/111042457-856bdf00-8463-11eb-93c9-50a30106a1a1.png). This PR fixes it.
[ "LGTM, thanks for fixing." ]
https://api.github.com/repos/huggingface/datasets/issues/2048
2,048
github is not always available - probably need a back up
Yesterday morning github wasn't working: ``` :/tmp$ wget https://raw.githubusercontent.com/huggingface/datasets/1.4.1/metrics/sacrebleu/sacrebleu.py--2021-03-12 18:35:59-- https://raw.githubusercontent.com/huggingface/datasets/1.4.1/metrics/sacrebleu/sacrebleu.py Resolving raw.githubusercontent.com (raw.githubuser...
closed
2021-03-13T18:03:32
https://api.github.com/repos/huggingface/datasets/issues/2048/comments
null
false
github is not always available - probably need a back up Yesterday morning github wasn't working: ``` :/tmp$ wget https://raw.githubusercontent.com/huggingface/datasets/1.4.1/metrics/sacrebleu/sacrebleu.py--2021-03-12 18:35:59-- https://raw.githubusercontent.com/huggingface/datasets/1.4.1/metrics/sacrebleu/sacreble...
[]
https://api.github.com/repos/huggingface/datasets/issues/2047
2,047
Multilingual dIalogAct benchMark (miam)
My collaborators (@EmileChapuis, @PierreColombo) and I within the Affective Computing team at Telecom Paris would like to anonymously publish the miam dataset. It is assocated with a publication currently under review. We will update the dataset with full citations once the review period is over.
closed
2021-03-12T23:02:55
https://api.github.com/repos/huggingface/datasets/issues/2047/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2047", "html_url": "https://github.com/huggingface/datasets/pull/2047", "diff_url": "https://github.com/huggingface/datasets/pull/2047.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2047.patch", "merged_at": "2021-03-19T10:47...
true
Multilingual dIalogAct benchMark (miam) My collaborators (@EmileChapuis, @PierreColombo) and I within the Affective Computing team at Telecom Paris would like to anonymously publish the miam dataset. It is assocated with a publication currently under review. We will update the dataset with full citations once the revie...
[ "Hello. All aforementioned changes have been made. I've also re-run black on miam.py. :-)", "I will run isort again. Hopefully it resolves the current check_code_quality test failure.", "Once the review period is over, feel free to open a PR to add all the missing information ;)", "Hi! I will follow up right ...
https://api.github.com/repos/huggingface/datasets/issues/2046
2,046
add_faisis_index gets very slow when doing it interatively
As the below code suggests, I want to run add_faisis_index in every nth interaction from the training loop. I have 7.2 million documents. Usually, it takes 2.5 hours (if I run an as a separate process similar to the script given in rag/use_own_knowleldge_dataset.py). Now, this takes usually 5hrs. Is this normal? Any ...
closed
2021-03-12T20:27:18
https://api.github.com/repos/huggingface/datasets/issues/2046/comments
null
false
add_faisis_index gets very slow when doing it interatively As the below code suggests, I want to run add_faisis_index in every nth interaction from the training loop. I have 7.2 million documents. Usually, it takes 2.5 hours (if I run an as a separate process similar to the script given in rag/use_own_knowleldge_dat...
[ "I think faiss automatically sets the number of threads to use to build the index.\r\nCan you check how many CPU cores are being used when you build the index in `use_own_knowleldge_dataset` as compared to this script ? Are there other programs running (maybe for rank>0) ?", "Hi,\r\n I am running the add_faiss_in...
https://api.github.com/repos/huggingface/datasets/issues/2045
2,045
Preserve column ordering in Dataset.rename_column
Currently `Dataset.rename_column` doesn't necessarily preserve the order of the columns: ```python >>> from datasets import Dataset >>> d = Dataset.from_dict({'sentences': ["s1", "s2"], 'label': [0, 1]}) >>> d Dataset({ features: ['sentences', 'label'], num_rows: 2 }) >>> d.rename_column('sentences', '...
closed
2021-03-12T18:26:47
https://api.github.com/repos/huggingface/datasets/issues/2045/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2045", "html_url": "https://github.com/huggingface/datasets/pull/2045", "diff_url": "https://github.com/huggingface/datasets/pull/2045.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2045.patch", "merged_at": "2021-03-16T14:35...
true
Preserve column ordering in Dataset.rename_column Currently `Dataset.rename_column` doesn't necessarily preserve the order of the columns: ```python >>> from datasets import Dataset >>> d = Dataset.from_dict({'sentences': ["s1", "s2"], 'label': [0, 1]}) >>> d Dataset({ features: ['sentences', 'label'], n...
[ "Not sure why CI isn't triggered.\r\n\r\n@lhoestq Can you please help me with this? ", "I don't know how to trigger it manually, but an empty commit should do the job" ]
https://api.github.com/repos/huggingface/datasets/issues/2044
2,044
Add CBT dataset
This PR adds the [CBT Dataset](https://arxiv.org/abs/1511.02301). Note that I have also added the `raw` dataset as a separate configuration. I couldn't find a suitable "task" for it in YAML tags. The dummy files have one example each, as the examples are slightly big. For `raw` dataset, I just used top few lines,...
closed
2021-03-12T18:04:19
https://api.github.com/repos/huggingface/datasets/issues/2044/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2044", "html_url": "https://github.com/huggingface/datasets/pull/2044", "diff_url": "https://github.com/huggingface/datasets/pull/2044.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2044.patch", "merged_at": "2021-03-19T10:29...
true
Add CBT dataset This PR adds the [CBT Dataset](https://arxiv.org/abs/1511.02301). Note that I have also added the `raw` dataset as a separate configuration. I couldn't find a suitable "task" for it in YAML tags. The dummy files have one example each, as the examples are slightly big. For `raw` dataset, I just use...
[ "Hi @lhoestq,\r\n\r\nI have added changes from the review.", "Thanks for approving @lhoestq " ]
https://api.github.com/repos/huggingface/datasets/issues/2043
2,043
Support pickle protocol for dataset splits defined as ReadInstruction
Fixes #2022 (+ some style fixes)
closed
2021-03-12T16:35:11
https://api.github.com/repos/huggingface/datasets/issues/2043/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2043", "html_url": "https://github.com/huggingface/datasets/pull/2043", "diff_url": "https://github.com/huggingface/datasets/pull/2043.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2043.patch", "merged_at": "2021-03-16T14:05...
true
Support pickle protocol for dataset splits defined as ReadInstruction Fixes #2022 (+ some style fixes)
[ "@lhoestq But we don't perform conversion to a `NamedSplit` if `_split` is not a string which means it **will** be a `ReadInstruction` after reloading.", "Yes right ! I read it wrong.\r\nPerfect then" ]
https://api.github.com/repos/huggingface/datasets/issues/2042
2,042
Fix arrow memory checks issue in tests
The tests currently fail on `master` because the arrow memory verification doesn't return the expected memory evolution when loading an arrow table in memory. From my experiments, the tests fail only when the full test suite is ran. This made me think that maybe some arrow objects from other tests were not freeing th...
closed
2021-03-12T14:49:52
https://api.github.com/repos/huggingface/datasets/issues/2042/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2042", "html_url": "https://github.com/huggingface/datasets/pull/2042", "diff_url": "https://github.com/huggingface/datasets/pull/2042.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2042.patch", "merged_at": "2021-03-12T15:04...
true
Fix arrow memory checks issue in tests The tests currently fail on `master` because the arrow memory verification doesn't return the expected memory evolution when loading an arrow table in memory. From my experiments, the tests fail only when the full test suite is ran. This made me think that maybe some arrow objec...
[]
https://api.github.com/repos/huggingface/datasets/issues/2041
2,041
Doc2dial update data_infos and data_loaders
closed
2021-03-12T14:39:29
https://api.github.com/repos/huggingface/datasets/issues/2041/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2041", "html_url": "https://github.com/huggingface/datasets/pull/2041", "diff_url": "https://github.com/huggingface/datasets/pull/2041.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2041.patch", "merged_at": "2021-03-16T11:09...
true
Doc2dial update data_infos and data_loaders
[]
https://api.github.com/repos/huggingface/datasets/issues/2040
2,040
ValueError: datasets' indices [1] come from memory and datasets' indices [0] come from disk
Hi there, I am trying to concat two datasets that I've previously saved to disk via `save_to_disk()` like so (note that both are saved as `DataDict`, `PATH_DATA_CLS_*` are `Path`-objects): ```python concatenate_datasets([load_from_disk(PATH_DATA_CLS_A)['train'], load_from_disk(PATH_DATA_CLS_B)['train']]) ``` Yie...
closed
2021-03-12T14:27:00
https://api.github.com/repos/huggingface/datasets/issues/2040/comments
null
false
ValueError: datasets' indices [1] come from memory and datasets' indices [0] come from disk Hi there, I am trying to concat two datasets that I've previously saved to disk via `save_to_disk()` like so (note that both are saved as `DataDict`, `PATH_DATA_CLS_*` are `Path`-objects): ```python concatenate_datasets([lo...
[ "Hi ! To help me understand the situation, can you print the values of `load_from_disk(PATH_DATA_CLS_A)['train']._indices_data_files` and `load_from_disk(PATH_DATA_CLS_B)['train']._indices_data_files` ?\r\nThey should both have a path to an arrow file\r\n\r\nAlso note that from #2025 concatenating datasets will no...