url stringlengths 58 61 | number int64 1 8.23k | title stringlengths 1 290 | body stringlengths 0 228k ⌀ | state stringclasses 2
values | created_at timestamp[s]date 2020-04-14 10:18:02 2026-05-30 09:38:59 | comments_url stringlengths 67 70 | pull_request dict | is_pull_request bool 2
classes | text stringlengths 2 228k | comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/datasets/issues/2349 | 2,349 | Update task_ids for Ascent KB | This "other-other-knowledge-base" task is better suited for the dataset. | closed | 2021-05-11T20:44:33 | https://api.github.com/repos/huggingface/datasets/issues/2349/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2349",
"html_url": "https://github.com/huggingface/datasets/pull/2349",
"diff_url": "https://github.com/huggingface/datasets/pull/2349.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2349.patch",
"merged_at": "2021-05-17T10:48... | true | Update task_ids for Ascent KB
This "other-other-knowledge-base" task is better suited for the dataset. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2348 | 2,348 | Add tests for dataset cards | Adding tests for dataset cards
This PR will potentially remove the scripts being used for dataset tags and readme validation.
Additionally, this will allow testing dataset readmes by providing the name as follows:
```bash
pytest tests/test_dataset_cards.py::test_dataset_tags[fashion_mnist]
```
and
```bas... | closed | 2021-05-11T17:14:27 | https://api.github.com/repos/huggingface/datasets/issues/2348/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2348",
"html_url": "https://github.com/huggingface/datasets/pull/2348",
"diff_url": "https://github.com/huggingface/datasets/pull/2348.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2348.patch",
"merged_at": "2021-05-21T12:10... | true | Add tests for dataset cards
Adding tests for dataset cards
This PR will potentially remove the scripts being used for dataset tags and readme validation.
Additionally, this will allow testing dataset readmes by providing the name as follows:
```bash
pytest tests/test_dataset_cards.py::test_dataset_tags[fashio... | [
"@lhoestq\r\n\r\nShould I remove the scripts? or atleast remove running them from the CircleCI config?\r\n\r\nAlso, I hope it is okay that the combined method (metadata+content) is only a slow test, and for the Circle CI, I assume only non-slow tests are run? If yes, this would mean separate tests for content and m... |
https://api.github.com/repos/huggingface/datasets/issues/2347 | 2,347 | Add an API to access the language and pretty name of a dataset | It would be super nice to have an API to get some metadata of the dataset from the name and args passed to `load_dataset`. This way we could programmatically infer the language and the name of a dataset when creating model cards automatically in the Transformers examples scripts. | closed | 2021-05-11T14:10:08 | https://api.github.com/repos/huggingface/datasets/issues/2347/comments | null | false | Add an API to access the language and pretty name of a dataset
It would be super nice to have an API to get some metadata of the dataset from the name and args passed to `load_dataset`. This way we could programmatically infer the language and the name of a dataset when creating model cards automatically in the Transfo... | [
"Hi ! With @bhavitvyamalik we discussed about having something like\r\n```python\r\nfrom datasets import load_dataset_card\r\n\r\ndataset_card = load_dataset_card(\"squad\")\r\nprint(dataset_card.metadata.pretty_name)\r\n# Stanford Question Answering Dataset (SQuAD)\r\nprint(dataset_card.metadata.languages)\r\n# [\... |
https://api.github.com/repos/huggingface/datasets/issues/2346 | 2,346 | Add Qasper Dataset | [Question Answering on Scientific Research Papers](https://allenai.org/project/qasper/home)
Doing NLP on NLP papers to do NLP ♻️ I had to add it~
- [x] Add README (just gotta fill out some more )
- [x] Dataloader code
- [x] Make dummy dataset
- [x] generate dataset infos
- [x] Tests
| closed | 2021-05-11T09:25:44 | https://api.github.com/repos/huggingface/datasets/issues/2346/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2346",
"html_url": "https://github.com/huggingface/datasets/pull/2346",
"diff_url": "https://github.com/huggingface/datasets/pull/2346.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2346.patch",
"merged_at": "2021-05-18T12:28... | true | Add Qasper Dataset
[Question Answering on Scientific Research Papers](https://allenai.org/project/qasper/home)
Doing NLP on NLP papers to do NLP ♻️ I had to add it~
- [x] Add README (just gotta fill out some more )
- [x] Dataloader code
- [x] Make dummy dataset
- [x] generate dataset infos
- [x] Tests
| [
"I saw that the README [template](https://github.com/huggingface/datasets/blob/master/templates/README.md) changed while I was working on this 😅 Some TOC titles may be different but I filled it to the best of my knowledge & readme quality check passes now.\r\nready for review @lhoestq "
] |
https://api.github.com/repos/huggingface/datasets/issues/2345 | 2,345 | [Question] How to move and reuse preprocessed dataset? | Hi, I am training a gpt-2 from scratch using run_clm.py.
I want to move and reuse the preprocessed dataset (It take 2 hour to preprocess),
I tried to :
copy path_to_cache_dir/datasets to new_cache_dir/datasets
set export HF_DATASETS_CACHE="new_cache_dir/"
but the program still re-preprocess the whole dataset... | closed | 2021-05-11T09:09:17 | https://api.github.com/repos/huggingface/datasets/issues/2345/comments | null | false | [Question] How to move and reuse preprocessed dataset?
Hi, I am training a gpt-2 from scratch using run_clm.py.
I want to move and reuse the preprocessed dataset (It take 2 hour to preprocess),
I tried to :
copy path_to_cache_dir/datasets to new_cache_dir/datasets
set export HF_DATASETS_CACHE="new_cache_dir/... | [
"@lhoestq @LysandreJik",
"<s>Hi :) Can you share with us the code you used ?</s>\r\n\r\nEDIT: from https://github.com/huggingface/transformers/issues/11665#issuecomment-838348291 I understand you're using the run_clm.py script. Can you share your logs ?\r\n",
"Also note that for the caching to work, you must re... |
https://api.github.com/repos/huggingface/datasets/issues/2344 | 2,344 | Is there a way to join multiple datasets in one? | **Is your feature request related to a problem? Please describe.**
I need to join 2 datasets, one that is in the hub and another I've created from my files. Is there an easy way to join these 2?
**Describe the solution you'd like**
Id like to join them with a merge or join method, just like pandas dataframes.
**Add... | open | 2021-05-10T23:16:10 | https://api.github.com/repos/huggingface/datasets/issues/2344/comments | null | false | Is there a way to join multiple datasets in one?
**Is your feature request related to a problem? Please describe.**
I need to join 2 datasets, one that is in the hub and another I've created from my files. Is there an easy way to join these 2?
**Describe the solution you'd like**
Id like to join them with a merge or ... | [
"Hi ! We don't have `join`/`merge` on a certain column as in pandas.\r\nMaybe you can just use the [concatenate_datasets](https://huggingface.co/docs/datasets/package_reference/main_classes.html?highlight=concatenate#datasets.concatenate_datasets) function.\r\n",
"Hi! You can use `datasets_sql` for that now. As o... |
https://api.github.com/repos/huggingface/datasets/issues/2343 | 2,343 | Columns are removed before or after map function applied? | ## Describe the bug
According to the documentation when applying map function the [remove_columns ](https://huggingface.co/docs/datasets/processing.html#removing-columns) will be removed after they are passed to the function, but in the [source code](https://huggingface.co/docs/datasets/package_reference/main_classes.... | open | 2021-05-10T02:36:20 | https://api.github.com/repos/huggingface/datasets/issues/2343/comments | null | false | Columns are removed before or after map function applied?
## Describe the bug
According to the documentation when applying map function the [remove_columns ](https://huggingface.co/docs/datasets/processing.html#removing-columns) will be removed after they are passed to the function, but in the [source code](https://hu... | [
"Hi! Columns are removed **after** applying the function and **before** updating the examples with the function's output (as per the docs [here](https://huggingface.co/docs/datasets/package_reference/main_classes#datasets.Dataset.map.remove_columns)). I agree the docs on this should be more clear."
] |
https://api.github.com/repos/huggingface/datasets/issues/2342 | 2,342 | Docs - CER above 1 | CER can actually be greater than 1. | closed | 2021-05-09T23:41:00 | https://api.github.com/repos/huggingface/datasets/issues/2342/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2342",
"html_url": "https://github.com/huggingface/datasets/pull/2342",
"diff_url": "https://github.com/huggingface/datasets/pull/2342.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2342.patch",
"merged_at": "2021-05-10T13:34... | true | Docs - CER above 1
CER can actually be greater than 1. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2341 | 2,341 | Added the Ascent KB | Added the Ascent Commonsense KB of 8.9M assertions.
- Paper: [Advanced Semantics for Commonsense Knowledge Extraction (WWW'21)](https://arxiv.org/abs/2011.00905)
- Website: https://ascent.mpi-inf.mpg.de/
(I am the author of the dataset) | closed | 2021-05-09T14:17:39 | https://api.github.com/repos/huggingface/datasets/issues/2341/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2341",
"html_url": "https://github.com/huggingface/datasets/pull/2341",
"diff_url": "https://github.com/huggingface/datasets/pull/2341.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2341.patch",
"merged_at": "2021-05-11T09:16... | true | Added the Ascent KB
Added the Ascent Commonsense KB of 8.9M assertions.
- Paper: [Advanced Semantics for Commonsense Knowledge Extraction (WWW'21)](https://arxiv.org/abs/2011.00905)
- Website: https://ascent.mpi-inf.mpg.de/
(I am the author of the dataset) | [
"Thanks for approving it!"
] |
https://api.github.com/repos/huggingface/datasets/issues/2340 | 2,340 | More consistent copy logic | Use `info.copy()` instead of `copy.deepcopy(info)`.
`Features.copy` now creates a deep copy. | closed | 2021-05-09T14:17:33 | https://api.github.com/repos/huggingface/datasets/issues/2340/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2340",
"html_url": "https://github.com/huggingface/datasets/pull/2340",
"diff_url": "https://github.com/huggingface/datasets/pull/2340.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2340.patch",
"merged_at": "2021-05-11T08:58... | true | More consistent copy logic
Use `info.copy()` instead of `copy.deepcopy(info)`.
`Features.copy` now creates a deep copy. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2338 | 2,338 | fixed download link for web_science | Fixes #2337. Should work with:
`dataset = load_dataset("web_of_science", "WOS11967", ignore_verifications=True)` | closed | 2021-05-09T09:12:20 | https://api.github.com/repos/huggingface/datasets/issues/2338/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2338",
"html_url": "https://github.com/huggingface/datasets/pull/2338",
"diff_url": "https://github.com/huggingface/datasets/pull/2338.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2338.patch",
"merged_at": "2021-05-10T13:35... | true | fixed download link for web_science
Fixes #2337. Should work with:
`dataset = load_dataset("web_of_science", "WOS11967", ignore_verifications=True)` | [] |
https://api.github.com/repos/huggingface/datasets/issues/2337 | 2,337 | NonMatchingChecksumError for web_of_science dataset | NonMatchingChecksumError when trying to download the web_of_science dataset.
>NonMatchingChecksumError: Checksums didn't match for dataset source files:
['https://data.mendeley.com/datasets/9rw3vkcfy4/6/files/c9ea673d-5542-44c0-ab7b-f1311f7d61df/WebOfScience.zip?dl=1']
Setting `ignore_verfications=True` results... | closed | 2021-05-09T02:02:02 | https://api.github.com/repos/huggingface/datasets/issues/2337/comments | null | false | NonMatchingChecksumError for web_of_science dataset
NonMatchingChecksumError when trying to download the web_of_science dataset.
>NonMatchingChecksumError: Checksums didn't match for dataset source files:
['https://data.mendeley.com/datasets/9rw3vkcfy4/6/files/c9ea673d-5542-44c0-ab7b-f1311f7d61df/WebOfScience.zip?... | [
"I've raised a PR for this. Should work with `dataset = load_dataset(\"web_of_science\", \"WOS11967\", ignore_verifications=True)`once it gets merged into the main branch. Thanks for reporting this! "
] |
https://api.github.com/repos/huggingface/datasets/issues/2336 | 2,336 | Fix overflow issue in interpolation search | Fixes #2335
More info about this error can be found [here](https://stackoverflow.com/questions/53239890/why-do-i-keep-getting-this-error-runtimewarning-overflow-encountered-in-int-sc/53240100). | closed | 2021-05-08T20:51:36 | https://api.github.com/repos/huggingface/datasets/issues/2336/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2336",
"html_url": "https://github.com/huggingface/datasets/pull/2336",
"diff_url": "https://github.com/huggingface/datasets/pull/2336.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2336.patch",
"merged_at": "2021-05-10T13:26... | true | Fix overflow issue in interpolation search
Fixes #2335
More info about this error can be found [here](https://stackoverflow.com/questions/53239890/why-do-i-keep-getting-this-error-runtimewarning-overflow-encountered-in-int-sc/53240100). | [
"~~Seems like the CI failure is unrelated to this PR~~ (fixed with the merge). \r\n\r\n@lhoestq Can you please verify that everything is OK in terms of speed? Another solution is to change the offsets array dtype to np.int64 (but this doesn't scale in theory compared to Python integer which is unbound). I'm not sur... |
https://api.github.com/repos/huggingface/datasets/issues/2335 | 2,335 | Index error in Dataset.map | The following code, if executed on master, raises an IndexError (due to overflow):
```python
>>> from datasets import *
>>> d = load_dataset("bookcorpus", split="train")
Reusing dataset bookcorpus (C:\Users\Mario\.cache\huggingface\datasets\bookcorpus\plain_text\1.0.0\44662c4a114441c35200992bea923b170e6f13f2f0beb7c... | closed | 2021-05-08T20:44:57 | https://api.github.com/repos/huggingface/datasets/issues/2335/comments | null | false | Index error in Dataset.map
The following code, if executed on master, raises an IndexError (due to overflow):
```python
>>> from datasets import *
>>> d = load_dataset("bookcorpus", split="train")
Reusing dataset bookcorpus (C:\Users\Mario\.cache\huggingface\datasets\bookcorpus\plain_text\1.0.0\44662c4a114441c35200... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2334 | 2,334 | Updating the DART file checksums in GEM | The DART files were just updated on the source GitHub
https://github.com/Yale-LILY/dart/commit/34b3c872da4811523e334f1631e54ca8105dffab | closed | 2021-05-07T21:53:44 | https://api.github.com/repos/huggingface/datasets/issues/2334/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2334",
"html_url": "https://github.com/huggingface/datasets/pull/2334",
"diff_url": "https://github.com/huggingface/datasets/pull/2334.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2334.patch",
"merged_at": "2021-05-07T22:18... | true | Updating the DART file checksums in GEM
The DART files were just updated on the source GitHub
https://github.com/Yale-LILY/dart/commit/34b3c872da4811523e334f1631e54ca8105dffab | [
"@sebastianGehrmann "
] |
https://api.github.com/repos/huggingface/datasets/issues/2333 | 2,333 | Fix duplicate keys | As noticed in https://github.com/huggingface/datasets/pull/2245, many datasets yield duplicate keys.
Most of the time it was because the counter used for ids were reset at each new data file. | closed | 2021-05-07T15:28:08 | https://api.github.com/repos/huggingface/datasets/issues/2333/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2333",
"html_url": "https://github.com/huggingface/datasets/pull/2333",
"diff_url": "https://github.com/huggingface/datasets/pull/2333.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2333.patch",
"merged_at": "2021-05-07T15:57... | true | Fix duplicate keys
As noticed in https://github.com/huggingface/datasets/pull/2245, many datasets yield duplicate keys.
Most of the time it was because the counter used for ids were reset at each new data file. | [
"- @jplu "
] |
https://api.github.com/repos/huggingface/datasets/issues/2332 | 2,332 | Add note about indices mapping in save_to_disk docstring | closed | 2021-05-07T13:49:42 | https://api.github.com/repos/huggingface/datasets/issues/2332/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2332",
"html_url": "https://github.com/huggingface/datasets/pull/2332",
"diff_url": "https://github.com/huggingface/datasets/pull/2332.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2332.patch",
"merged_at": "2021-05-07T17:20... | true | Add note about indices mapping in save_to_disk docstring
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/2331 | 2,331 | Add Topical-Chat | ## Adding a Dataset
- **Name:** Topical-Chat
- **Description:** a knowledge-grounded human-human conversation dataset where the underlying knowledge spans 8 broad topics and conversation partners don’t have explicitly defined roles
- **Paper:** https://www.isca-speech.org/archive/Interspeech_2019/pdfs/3079.pdf
- **... | open | 2021-05-07T13:43:59 | https://api.github.com/repos/huggingface/datasets/issues/2331/comments | null | false | Add Topical-Chat
## Adding a Dataset
- **Name:** Topical-Chat
- **Description:** a knowledge-grounded human-human conversation dataset where the underlying knowledge spans 8 broad topics and conversation partners don’t have explicitly defined roles
- **Paper:** https://www.isca-speech.org/archive/Interspeech_2019/pd... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2330 | 2,330 | Allow passing `desc` to `tqdm` in `Dataset.map()` | It's normal to have many `map()` calls, and some of them can take a few minutes,
it would be nice to have a description on the progress bar.
Alternative solution:
Print the description before/after the `map()` call. | closed | 2021-05-07T05:52:54 | https://api.github.com/repos/huggingface/datasets/issues/2330/comments | null | false | Allow passing `desc` to `tqdm` in `Dataset.map()`
It's normal to have many `map()` calls, and some of them can take a few minutes,
it would be nice to have a description on the progress bar.
Alternative solution:
Print the description before/after the `map()` call. | [
"Hi @lhoestq,\r\nShould we change `desc` in [pbar](https://github.com/huggingface/datasets/blob/81fcf88172ed5e3026ef68aed4c0ec6980372333/src/datasets/arrow_dataset.py#L1860) to something meaningful?",
"I think the user could pass the `desc` parameter to `map` so that it can be displayed in the tqdm progress bar, ... |
https://api.github.com/repos/huggingface/datasets/issues/2329 | 2,329 | Add cache dir for in-memory datasets | Adds the cache dir attribute to DatasetInfo as suggested by @lhoestq.
Should fix #2322 | closed | 2021-05-06T19:35:32 | https://api.github.com/repos/huggingface/datasets/issues/2329/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2329",
"html_url": "https://github.com/huggingface/datasets/pull/2329",
"diff_url": "https://github.com/huggingface/datasets/pull/2329.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2329.patch",
"merged_at": null
} | true | Add cache dir for in-memory datasets
Adds the cache dir attribute to DatasetInfo as suggested by @lhoestq.
Should fix #2322 | [
"Yes, having `cache_dir` as an attribute looks cleaner.\r\n\r\n\r\n\r\n",
"Good job! Looking forward to this new feature! 🥂",
"@lhoestq Sorry for the late reply. Yes, I'll start working on tests. Thanks for the detailed explanation of the current issues with caching (like the idea of adding the `use_caching` p... |
https://api.github.com/repos/huggingface/datasets/issues/2328 | 2,328 | Add Matthews/Pearson/Spearman correlation metrics | Added three metrics:
- The Matthews correlation coefficient (from sklearn)
- The Pearson correlation coefficient (from scipy)
- The Spearman correlation coefficient (from scipy)
cc @sgugger | closed | 2021-05-06T16:09:27 | https://api.github.com/repos/huggingface/datasets/issues/2328/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2328",
"html_url": "https://github.com/huggingface/datasets/pull/2328",
"diff_url": "https://github.com/huggingface/datasets/pull/2328.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2328.patch",
"merged_at": "2021-05-06T16:58... | true | Add Matthews/Pearson/Spearman correlation metrics
Added three metrics:
- The Matthews correlation coefficient (from sklearn)
- The Pearson correlation coefficient (from scipy)
- The Spearman correlation coefficient (from scipy)
cc @sgugger | [] |
https://api.github.com/repos/huggingface/datasets/issues/2327 | 2,327 | A syntax error in example | 
Sorry to report with an image, I can't find the template source code of this snippet. | closed | 2021-05-06T14:34:44 | https://api.github.com/repos/huggingface/datasets/issues/2327/comments | null | false | A syntax error in example
Sorry to report with an image, I can't find the template source code of this snippet. | [
"cc @beurkinger but I think this has been fixed internally and will soon be updated right ?",
"This issue has been fixed."
] |
https://api.github.com/repos/huggingface/datasets/issues/2326 | 2,326 | Enable auto-download for PAN-X / Wikiann domain in XTREME | This PR replaces the manual download of the `PAN-X.lang` domains with an auto-download from a Dropbox link provided by the Wikiann author. We also add the relevant dummy data for these domains.
While re-generating `dataset_infos.json` I ran into a `KeyError` in the `udpos.Arabic` domain so have included a fix for th... | closed | 2021-05-05T20:58:38 | https://api.github.com/repos/huggingface/datasets/issues/2326/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2326",
"html_url": "https://github.com/huggingface/datasets/pull/2326",
"diff_url": "https://github.com/huggingface/datasets/pull/2326.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2326.patch",
"merged_at": "2021-05-07T08:41... | true | Enable auto-download for PAN-X / Wikiann domain in XTREME
This PR replaces the manual download of the `PAN-X.lang` domains with an auto-download from a Dropbox link provided by the Wikiann author. We also add the relevant dummy data for these domains.
While re-generating `dataset_infos.json` I ran into a `KeyError` ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2325 | 2,325 | Added the HLGD dataset | Added the Headline Grouping Dataset (HLGD), from the NAACL2021 paper: News Headline Grouping as a Challenging NLU Task
Dataset Link: https://github.com/tingofurro/headline_grouping
Paper link: https://people.eecs.berkeley.edu/~phillab/pdfs/NAACL2021_HLG.pdf | closed | 2021-05-05T16:53:29 | https://api.github.com/repos/huggingface/datasets/issues/2325/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2325",
"html_url": "https://github.com/huggingface/datasets/pull/2325",
"diff_url": "https://github.com/huggingface/datasets/pull/2325.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2325.patch",
"merged_at": "2021-05-12T14:16... | true | Added the HLGD dataset
Added the Headline Grouping Dataset (HLGD), from the NAACL2021 paper: News Headline Grouping as a Challenging NLU Task
Dataset Link: https://github.com/tingofurro/headline_grouping
Paper link: https://people.eecs.berkeley.edu/~phillab/pdfs/NAACL2021_HLG.pdf | [
"Is there anything else needed from my end?",
"Thanks Bhavitvya and Quentin, this was very streamlined!"
] |
https://api.github.com/repos/huggingface/datasets/issues/2324 | 2,324 | Create Audio feature | Create `Audio` feature to handle raw audio files.
Some decisions to be further discussed:
- I have chosen `soundfile` as the audio library; another interesting library is `librosa`, but this requires `soundfile` (see [here](https://github.com/librosa/librosa/blob/main/setup.cfg#L53)). If we require some more advanc... | closed | 2021-05-05T15:55:22 | https://api.github.com/repos/huggingface/datasets/issues/2324/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2324",
"html_url": "https://github.com/huggingface/datasets/pull/2324",
"diff_url": "https://github.com/huggingface/datasets/pull/2324.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2324.patch",
"merged_at": "2021-10-13T10:26... | true | Create Audio feature
Create `Audio` feature to handle raw audio files.
Some decisions to be further discussed:
- I have chosen `soundfile` as the audio library; another interesting library is `librosa`, but this requires `soundfile` (see [here](https://github.com/librosa/librosa/blob/main/setup.cfg#L53)). If we req... | [
"For optimal storage, it would be better to:\r\n- store only the audio file path in the cache Arrow file\r\n- perform decoding of the audio file (into audio array and sample rate) on the fly, while loading the dataset from cache (or by adding a convenient `load_audio` function)",
"Thanks a lot @lhoestq for your h... |
https://api.github.com/repos/huggingface/datasets/issues/2323 | 2,323 | load_dataset("timit_asr") gives back duplicates of just one sample text | ## Describe the bug
When you look up on key ["train"] and then ['text'], you get back a list with just one sentence duplicated 4620 times. Namely, the sentence "Would such an act of refusal be useful?". Similarly when you look up ['test'] and then ['text'], the list is one sentence repeated "The bungalow was pleasant... | closed | 2021-05-05T13:14:48 | https://api.github.com/repos/huggingface/datasets/issues/2323/comments | null | false | load_dataset("timit_asr") gives back duplicates of just one sample text
## Describe the bug
When you look up on key ["train"] and then ['text'], you get back a list with just one sentence duplicated 4620 times. Namely, the sentence "Would such an act of refusal be useful?". Similarly when you look up ['test'] and the... | [
"Upgrading datasets to version 1.6 fixes the issue",
"This bug was fixed in #1995. Upgrading the `datasets` should work! ",
"Thanks @ekeleshian for having reported.\r\n\r\nI am closing this issue once that you updated `datasets`. Feel free to reopen it if the problem persists."
] |
https://api.github.com/repos/huggingface/datasets/issues/2322 | 2,322 | Calls to map are not cached. | ## Describe the bug
Somehow caching does not work for me anymore. Am I doing something wrong, or is there anything that I missed?
## Steps to reproduce the bug
```python
import datasets
datasets.set_caching_enabled(True)
sst = datasets.load_dataset("sst")
def foo(samples, i):
print("executed", i[:10])... | closed | 2021-05-05T12:11:27 | https://api.github.com/repos/huggingface/datasets/issues/2322/comments | null | false | Calls to map are not cached.
## Describe the bug
Somehow caching does not work for me anymore. Am I doing something wrong, or is there anything that I missed?
## Steps to reproduce the bug
```python
import datasets
datasets.set_caching_enabled(True)
sst = datasets.load_dataset("sst")
def foo(samples, i):
... | [
"I tried upgrading to `datasets==1.6.2` and downgrading to `1.6.0`. Both versions produce the same output.\r\n\r\nDowngrading to `1.5.0` works and produces the following output for me:\r\n\r\n```bash\r\nDownloading: 9.20kB [00:00, 3.94MB/s] \r\nDownloading: 5.99kB [00:00, 3.29MB/s] ... |
https://api.github.com/repos/huggingface/datasets/issues/2321 | 2,321 | Set encoding in OSCAR dataset | Set explicit `utf-8` encoding in OSCAR dataset, to avoid using the system default `cp1252` on Windows platforms.
Fix #2319. | closed | 2021-05-05T10:27:03 | https://api.github.com/repos/huggingface/datasets/issues/2321/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2321",
"html_url": "https://github.com/huggingface/datasets/pull/2321",
"diff_url": "https://github.com/huggingface/datasets/pull/2321.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2321.patch",
"merged_at": "2021-05-05T10:50... | true | Set encoding in OSCAR dataset
Set explicit `utf-8` encoding in OSCAR dataset, to avoid using the system default `cp1252` on Windows platforms.
Fix #2319. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2320 | 2,320 | Set default name in init_dynamic_modules | Set default value for the name of dynamic modules.
Close #2318. | closed | 2021-05-05T09:30:03 | https://api.github.com/repos/huggingface/datasets/issues/2320/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2320",
"html_url": "https://github.com/huggingface/datasets/pull/2320",
"diff_url": "https://github.com/huggingface/datasets/pull/2320.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2320.patch",
"merged_at": "2021-05-06T07:57... | true | Set default name in init_dynamic_modules
Set default value for the name of dynamic modules.
Close #2318. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2319 | 2,319 | UnicodeDecodeError for OSCAR (Afrikaans) | ## Describe the bug
When loading the [OSCAR dataset](https://huggingface.co/datasets/oscar) (specifically `unshuffled_deduplicated_af`), I encounter a `UnicodeDecodeError`.
## Steps to reproduce the bug
```python
from datasets import load_dataset
dataset = load_dataset("oscar", "unshuffled_deduplicated_af")
```... | closed | 2021-05-05T09:22:52 | https://api.github.com/repos/huggingface/datasets/issues/2319/comments | null | false | UnicodeDecodeError for OSCAR (Afrikaans)
## Describe the bug
When loading the [OSCAR dataset](https://huggingface.co/datasets/oscar) (specifically `unshuffled_deduplicated_af`), I encounter a `UnicodeDecodeError`.
## Steps to reproduce the bug
```python
from datasets import load_dataset
dataset = load_dataset("o... | [
"Thanks for reporting, @sgraaf.\r\n\r\nI am going to have a look at it. \r\n\r\nI guess the expected codec is \"UTF-8\". Normally, when no explicitly codec is passed, Python uses one which is platform-dependent. For Linux machines, the default codec is `utf_8`, which is OK. However for Windows machine, the default ... |
https://api.github.com/repos/huggingface/datasets/issues/2318 | 2,318 | [api request] API to obtain "dataset_module" dynamic path? | **Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is.
This is an awesome library.
It seems like the dynamic module path in this library has broken some of hyperparameter tuning functionality: https://discuss.huggingface.co/t/using-hyperparamet... | closed | 2021-05-05T08:40:48 | https://api.github.com/repos/huggingface/datasets/issues/2318/comments | null | false | [api request] API to obtain "dataset_module" dynamic path?
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is.
This is an awesome library.
It seems like the dynamic module path in this library has broken some of hyperparameter tuning functio... | [
"Hi @richardliaw, \r\n\r\nFirst, thanks for the compliments.\r\n\r\nIn relation with your request, currently, the dynamic modules path is obtained this way:\r\n```python\r\nfrom datasets.load import init_dynamic_modules, MODULE_NAME_FOR_DYNAMIC_MODULES\r\n\r\ndynamic_modules_path = init_dynamic_modules(MODULE_NAME_... |
https://api.github.com/repos/huggingface/datasets/issues/2317 | 2,317 | Fix incorrect version specification for the pyarrow package | This PR addresses the bug in the pyarrow version specification, which is detailed in #2316 .
Simply, I put a comma between the version bounds.
Fix #2316. | closed | 2021-05-04T19:30:20 | https://api.github.com/repos/huggingface/datasets/issues/2317/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2317",
"html_url": "https://github.com/huggingface/datasets/pull/2317",
"diff_url": "https://github.com/huggingface/datasets/pull/2317.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2317.patch",
"merged_at": "2021-05-05T09:21... | true | Fix incorrect version specification for the pyarrow package
This PR addresses the bug in the pyarrow version specification, which is detailed in #2316 .
Simply, I put a comma between the version bounds.
Fix #2316. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2316 | 2,316 | Incorrect version specification for pyarrow | ## Describe the bug
The pyarrow dependency is incorrectly specified in setup.py file, in [this line](https://github.com/huggingface/datasets/blob/3a3e5a4da20bfcd75f8b6a6869b240af8feccc12/setup.py#L77).
Also as a snippet:
```python
"pyarrow>=1.0.0<4.0.0",
```
## Steps to reproduce the bug
```bash
pip install... | closed | 2021-05-04T19:15:11 | https://api.github.com/repos/huggingface/datasets/issues/2316/comments | null | false | Incorrect version specification for pyarrow
## Describe the bug
The pyarrow dependency is incorrectly specified in setup.py file, in [this line](https://github.com/huggingface/datasets/blob/3a3e5a4da20bfcd75f8b6a6869b240af8feccc12/setup.py#L77).
Also as a snippet:
```python
"pyarrow>=1.0.0<4.0.0",
```
## Steps... | [
"Fixed by #2317."
] |
https://api.github.com/repos/huggingface/datasets/issues/2315 | 2,315 | Datasets cli improvements | This PR:
* replaces the code from the `bug_report.md` that was used to get relevant system info with a dedicated command (a more elegant approach than copy-pasting the code IMO)
* removes the `download` command (copied from the transformers repo?)
* adds missing help messages to the cli commands
| closed | 2021-05-04T18:55:11 | https://api.github.com/repos/huggingface/datasets/issues/2315/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2315",
"html_url": "https://github.com/huggingface/datasets/pull/2315",
"diff_url": "https://github.com/huggingface/datasets/pull/2315.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2315.patch",
"merged_at": "2021-05-10T16:36... | true | Datasets cli improvements
This PR:
* replaces the code from the `bug_report.md` that was used to get relevant system info with a dedicated command (a more elegant approach than copy-pasting the code IMO)
* removes the `download` command (copied from the transformers repo?)
* adds missing help messages to the cli com... | [
"Additionally, I've deleted the points that are not very relevant for this repo (I guess the deleted points originate from the transformers repo). With this change, running `datasets-cli` is identical to copy-pasting the code from `bug_report.md`, but is more elegant because it doesn't require launching the REPL an... |
https://api.github.com/repos/huggingface/datasets/issues/2314 | 2,314 | Minor refactor prepare_module | Start to refactor `prepare_module` to try to decouple functionality.
This PR does:
- extract function `_initialize_dynamic_modules_namespace_package`
- extract function `_find_module_in_github_or_s3`
- some renaming of variables
- use of f-strings | closed | 2021-05-04T18:37:26 | https://api.github.com/repos/huggingface/datasets/issues/2314/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2314",
"html_url": "https://github.com/huggingface/datasets/pull/2314",
"diff_url": "https://github.com/huggingface/datasets/pull/2314.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2314.patch",
"merged_at": null
} | true | Minor refactor prepare_module
Start to refactor `prepare_module` to try to decouple functionality.
This PR does:
- extract function `_initialize_dynamic_modules_namespace_package`
- extract function `_find_module_in_github_or_s3`
- some renaming of variables
- use of f-strings | [
"@lhoestq this is the PR that I mentioned to you, which can be considered as a first step in refactoring `prepare_module`.",
"closing in favor of #2986 "
] |
https://api.github.com/repos/huggingface/datasets/issues/2313 | 2,313 | Remove unused head_hf_s3 function | Currently, the function `head_hf_s3` is not used:
- neither its returned result is used
- nor it raises any exception, as exceptions are catched and returned (not raised)
This PR removes it. | closed | 2021-05-04T13:42:06 | https://api.github.com/repos/huggingface/datasets/issues/2313/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2313",
"html_url": "https://github.com/huggingface/datasets/pull/2313",
"diff_url": "https://github.com/huggingface/datasets/pull/2313.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2313.patch",
"merged_at": null
} | true | Remove unused head_hf_s3 function
Currently, the function `head_hf_s3` is not used:
- neither its returned result is used
- nor it raises any exception, as exceptions are catched and returned (not raised)
This PR removes it. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2312 | 2,312 | Add rename_columnS method | Cherry-picked from #2255 | closed | 2021-05-04T12:57:53 | https://api.github.com/repos/huggingface/datasets/issues/2312/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2312",
"html_url": "https://github.com/huggingface/datasets/pull/2312",
"diff_url": "https://github.com/huggingface/datasets/pull/2312.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2312.patch",
"merged_at": "2021-05-04T13:43... | true | Add rename_columnS method
Cherry-picked from #2255 | [
"Merging then 😄 "
] |
https://api.github.com/repos/huggingface/datasets/issues/2311 | 2,311 | Add SLR52, SLR53 and SLR54 to OpenSLR | Add large speech datasets for Sinhala, Bengali and Nepali. | closed | 2021-05-04T09:08:03 | https://api.github.com/repos/huggingface/datasets/issues/2311/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2311",
"html_url": "https://github.com/huggingface/datasets/pull/2311",
"diff_url": "https://github.com/huggingface/datasets/pull/2311.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2311.patch",
"merged_at": "2021-05-07T09:50... | true | Add SLR52, SLR53 and SLR54 to OpenSLR
Add large speech datasets for Sinhala, Bengali and Nepali. | [
"Hi @lhoestq , I am not sure about the error message:\r\n```\r\n#!/bin/bash -eo pipefail\r\n./scripts/datasets_metadata_validator.py\r\nWARNING:root:❌ Failed to validate 'datasets/openslr/README.md':\r\n__init__() got an unexpected keyword argument 'SLR32'\r\nINFO:root:❌ Failed on 1 files.\r\n\r\nExited with code e... |
https://api.github.com/repos/huggingface/datasets/issues/2310 | 2,310 | Update README.md | Provides description of data instances and dataset features | closed | 2021-05-04T04:38:01 | https://api.github.com/repos/huggingface/datasets/issues/2310/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2310",
"html_url": "https://github.com/huggingface/datasets/pull/2310",
"diff_url": "https://github.com/huggingface/datasets/pull/2310.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2310.patch",
"merged_at": null
} | true | Update README.md
Provides description of data instances and dataset features | [
"Hi @cryoff, thanks for completing the dataset card.\r\n\r\nNow there is an automatic validation tool to assure that all dataset cards contain all the relevant information. This is the cause of the non-passing test on your Pull Request:\r\n```\r\nFound fields that are not non-empty list of strings: {'annotations_cr... |
https://api.github.com/repos/huggingface/datasets/issues/2309 | 2,309 | Fix conda release | There were a few issues with conda releases (they've been failing for a while now).
To fix this I had to:
- add the --single-version-externally-managed tag to the build stage (suggestion from [here](https://stackoverflow.com/a/64825075))
- set the python version of the conda build stage to 3.8 since 3.9 isn't suppor... | closed | 2021-05-03T14:52:59 | https://api.github.com/repos/huggingface/datasets/issues/2309/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2309",
"html_url": "https://github.com/huggingface/datasets/pull/2309",
"diff_url": "https://github.com/huggingface/datasets/pull/2309.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2309.patch",
"merged_at": "2021-05-03T16:01... | true | Fix conda release
There were a few issues with conda releases (they've been failing for a while now).
To fix this I had to:
- add the --single-version-externally-managed tag to the build stage (suggestion from [here](https://stackoverflow.com/a/64825075))
- set the python version of the conda build stage to 3.8 sinc... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2302 | 2,302 | Add SubjQA dataset | Hello datasetters 🙂!
Here's an interesting dataset about extractive question-answering on _subjective_ product / restaurant reviews. It's quite challenging for models fine-tuned on SQuAD and provides a nice example of domain adaptation (i.e. fine-tuning a SQuAD model on this domain gives better performance).
I f... | closed | 2021-05-02T14:51:20 | https://api.github.com/repos/huggingface/datasets/issues/2302/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2302",
"html_url": "https://github.com/huggingface/datasets/pull/2302",
"diff_url": "https://github.com/huggingface/datasets/pull/2302.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2302.patch",
"merged_at": "2021-05-10T09:21... | true | Add SubjQA dataset
Hello datasetters 🙂!
Here's an interesting dataset about extractive question-answering on _subjective_ product / restaurant reviews. It's quite challenging for models fine-tuned on SQuAD and provides a nice example of domain adaptation (i.e. fine-tuning a SQuAD model on this domain gives better p... | [
"I'm not sure why the windows test fails, but looking at the logs it looks like some caching issue on one of the metrics ... maybe re-run and 🤞 ?",
"Hi @lewtun, thanks for adding this dataset!\r\n\r\nIf the dataset is going to be referenced heavily, I think it's worth spending some time to make the dataset card ... |
https://api.github.com/repos/huggingface/datasets/issues/2301 | 2,301 | Unable to setup dev env on Windows | Hi
I tried installing the `".[dev]"` version on Windows 10 after cloning.
Here is the error I'm facing:
```bat
(env) C:\testing\datasets>pip install -e ".[dev]"
Obtaining file:///C:/testing/datasets
Requirement already satisfied: numpy>=1.17 in c:\programdata\anaconda3\envs\env\lib\site-packages (from datas... | closed | 2021-05-02T13:20:42 | https://api.github.com/repos/huggingface/datasets/issues/2301/comments | null | false | Unable to setup dev env on Windows
Hi
I tried installing the `".[dev]"` version on Windows 10 after cloning.
Here is the error I'm facing:
```bat
(env) C:\testing\datasets>pip install -e ".[dev]"
Obtaining file:///C:/testing/datasets
Requirement already satisfied: numpy>=1.17 in c:\programdata\anaconda3\env... | [
"Hi @gchhablani, \r\n\r\nThere are some 3rd-party dependencies that require to build code in C. In this case, it is the library `python-Levenshtein`.\r\n\r\nOn Windows, in order to be able to build C code, you need to install at least `Microsoft C++ Build Tools` version 14. You can find more info here: https://visu... |
https://api.github.com/repos/huggingface/datasets/issues/2300 | 2,300 | Add VoxPopuli | ## Adding a Dataset
- **Name:** Voxpopuli
- **Description:** VoxPopuli is raw data is collected from 2009-2020 European Parliament event recordings
- **Paper:** https://arxiv.org/abs/2101.00390
- **Data:** https://github.com/facebookresearch/voxpopuli
- **Motivation:** biggest unlabeled speech dataset
**Note**:... | closed | 2021-05-02T12:17:40 | https://api.github.com/repos/huggingface/datasets/issues/2300/comments | null | false | Add VoxPopuli
## Adding a Dataset
- **Name:** Voxpopuli
- **Description:** VoxPopuli is raw data is collected from 2009-2020 European Parliament event recordings
- **Paper:** https://arxiv.org/abs/2101.00390
- **Data:** https://github.com/facebookresearch/voxpopuli
- **Motivation:** biggest unlabeled speech datase... | [
"I'm happy to take this on:) One question: The original unlabelled data is stored unsegmented (see e.g. https://github.com/facebookresearch/voxpopuli/blob/main/voxpopuli/get_unlabelled_data.py#L30), but segmenting the audio in the dataset would require a dependency on something like soundfile or torchaudio. An alte... |
https://api.github.com/repos/huggingface/datasets/issues/2299 | 2,299 | My iPhone | ## Adding a Dataset
- **Name:** *name of the dataset*
- **Description:** *short description of the dataset (or link to social media or blog post)*
- **Paper:** *link to the dataset paper if available*
- **Data:** *link to the Github repository or current dataset location*
- **Motivation:** *what are some good reasons t... | closed | 2021-05-02T11:11:11 | https://api.github.com/repos/huggingface/datasets/issues/2299/comments | null | false | My iPhone
## Adding a Dataset
- **Name:** *name of the dataset*
- **Description:** *short description of the dataset (or link to social media or blog post)*
- **Paper:** *link to the dataset paper if available*
- **Data:** *link to the Github repository or current dataset location*
- **Motivation:** *what are some good... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2298 | 2,298 | Mapping in the distributed setting | The barrier trick for distributed mapping as discussed on Thursday with @lhoestq | closed | 2021-05-01T21:23:05 | https://api.github.com/repos/huggingface/datasets/issues/2298/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2298",
"html_url": "https://github.com/huggingface/datasets/pull/2298",
"diff_url": "https://github.com/huggingface/datasets/pull/2298.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2298.patch",
"merged_at": "2021-05-03T13:54... | true | Mapping in the distributed setting
The barrier trick for distributed mapping as discussed on Thursday with @lhoestq | [] |
https://api.github.com/repos/huggingface/datasets/issues/2296 | 2,296 | 1 | ## Adding a Dataset
- **Name:** *name of the dataset*
- **Description:** *short description of the dataset (or link to social media or blog post)*
- **Paper:** *link to the dataset paper if available*
- **Data:** *link to the Github repository or current dataset location*
- **Motivation:** *what are some good reasons t... | closed | 2021-04-30T17:53:49 | https://api.github.com/repos/huggingface/datasets/issues/2296/comments | null | false | 1
## Adding a Dataset
- **Name:** *name of the dataset*
- **Description:** *short description of the dataset (or link to social media or blog post)*
- **Paper:** *link to the dataset paper if available*
- **Data:** *link to the Github repository or current dataset location*
- **Motivation:** *what are some good reasons... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2295 | 2,295 | Create ExtractManager | Perform refactoring to decouple extract functionality. | closed | 2021-04-30T17:13:34 | https://api.github.com/repos/huggingface/datasets/issues/2295/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2295",
"html_url": "https://github.com/huggingface/datasets/pull/2295",
"diff_url": "https://github.com/huggingface/datasets/pull/2295.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2295.patch",
"merged_at": "2021-07-08T08:11... | true | Create ExtractManager
Perform refactoring to decouple extract functionality. | [
"Hi @lhoestq,\r\n\r\nOnce that #2578 has been merged, I would like to ask you to have a look at this PR: it implements the same logic as the one in #2578 but for all the other file compression formats.\r\n\r\nThanks.",
"I think all is done @lhoestq ;)"
] |
https://api.github.com/repos/huggingface/datasets/issues/2294 | 2,294 | Slow #0 when using map to tokenize. | Hi, _datasets_ is really amazing! I am following [run_mlm_no_trainer.py](url) to pre-train BERT, and it uses `tokenized_datasets = raw_datasets.map(
tokenize_function,
batched=True,
num_proc=args.preprocessing_num_workers,
remove_columns=column_names,
loa... | open | 2021-04-30T08:00:33 | https://api.github.com/repos/huggingface/datasets/issues/2294/comments | null | false | Slow #0 when using map to tokenize.
Hi, _datasets_ is really amazing! I am following [run_mlm_no_trainer.py](url) to pre-train BERT, and it uses `tokenized_datasets = raw_datasets.map(
tokenize_function,
batched=True,
num_proc=args.preprocessing_num_workers,
remove_co... | [
"Hi ! Have you tried other values for `preprocessing_num_workers` ? Is it always process 0 that is slower ?\r\nThere are no difference between process 0 and the others except that it processes the first shard of the dataset.",
"Hi, I have found the reason of it. Before using the map function to tokenize the data,... |
https://api.github.com/repos/huggingface/datasets/issues/2293 | 2,293 | imdb dataset from Don't Stop Pretraining Paper | closed | 2021-04-30T06:40:48 | https://api.github.com/repos/huggingface/datasets/issues/2293/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2293",
"html_url": "https://github.com/huggingface/datasets/pull/2293",
"diff_url": "https://github.com/huggingface/datasets/pull/2293.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2293.patch",
"merged_at": null
} | true | imdb dataset from Don't Stop Pretraining Paper
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/2292 | 2,292 | Fixed typo seperate->separate | closed | 2021-04-29T16:40:53 | https://api.github.com/repos/huggingface/datasets/issues/2292/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2292",
"html_url": "https://github.com/huggingface/datasets/pull/2292",
"diff_url": "https://github.com/huggingface/datasets/pull/2292.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2292.patch",
"merged_at": "2021-04-30T13:03... | true | Fixed typo seperate->separate
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/2291 | 2,291 | Don't copy recordbatches in memory during a table deepcopy | Fix issue #2276 and hopefully #2134
The recordbatches of the `IndexedTableMixin` used to speed up queries to the table were copied in memory during a table deepcopy.
This resulted in `concatenate_datasets`, `load_from_disk` and other methods to always bring the data in memory.
I fixed the copy similarly to #2287... | closed | 2021-04-29T16:26:05 | https://api.github.com/repos/huggingface/datasets/issues/2291/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2291",
"html_url": "https://github.com/huggingface/datasets/pull/2291",
"diff_url": "https://github.com/huggingface/datasets/pull/2291.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2291.patch",
"merged_at": "2021-04-29T16:34... | true | Don't copy recordbatches in memory during a table deepcopy
Fix issue #2276 and hopefully #2134
The recordbatches of the `IndexedTableMixin` used to speed up queries to the table were copied in memory during a table deepcopy.
This resulted in `concatenate_datasets`, `load_from_disk` and other methods to always bring... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2290 | 2,290 | Bbaw egyptian | This is the "hieroglyph corpus" that I could unfortunately not contribute during the marathon. I re-extracted it again now, so that it is in the state as used in my paper (seee documentation). I hope it satiesfies your requirements and wish every scientist out their loads of fun deciphering a 5.000 years old language :... | closed | 2021-04-29T15:27:58 | https://api.github.com/repos/huggingface/datasets/issues/2290/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2290",
"html_url": "https://github.com/huggingface/datasets/pull/2290",
"diff_url": "https://github.com/huggingface/datasets/pull/2290.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2290.patch",
"merged_at": "2021-05-06T17:25... | true | Bbaw egyptian
This is the "hieroglyph corpus" that I could unfortunately not contribute during the marathon. I re-extracted it again now, so that it is in the state as used in my paper (seee documentation). I hope it satiesfies your requirements and wish every scientist out their loads of fun deciphering a 5.000 years ... | [
"Hi @phiwi,\r\n\r\nThanks for contributing this nice dataset. If you have any blocking problem or question, do not hesitate to ask here. We are pleased to help you.\r\n\r\nCould you please first synchronize with our master branch? From your branch `bbaw_egyptian`, type:\r\n```\r\ngit fetch upstream master\r\ngit me... |
https://api.github.com/repos/huggingface/datasets/issues/2289 | 2,289 | Allow collaborators to self-assign issues | Allow collaborators (without write access to the repository) to self-assign issues.
In order to self-assign an issue, they have to comment it with the word: `#take` or `#self-assign`. | closed | 2021-04-29T15:07:06 | https://api.github.com/repos/huggingface/datasets/issues/2289/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2289",
"html_url": "https://github.com/huggingface/datasets/pull/2289",
"diff_url": "https://github.com/huggingface/datasets/pull/2289.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2289.patch",
"merged_at": "2021-04-30T18:28... | true | Allow collaborators to self-assign issues
Allow collaborators (without write access to the repository) to self-assign issues.
In order to self-assign an issue, they have to comment it with the word: `#take` or `#self-assign`. | [
"What do you think, @lhoestq? 😉 \r\n\r\nI think this could be another step to facilitate community contributions.",
"@lhoestq, it doesn't exist in `transformers`... I picked the idea from `scikit-learn`, where I have previously collaborated...\r\n\r\nAnd sure, this must be documented! I just wanted first to know... |
https://api.github.com/repos/huggingface/datasets/issues/2288 | 2,288 | Load_dataset for local CSV files | The method load_dataset fails to correctly load a dataset from csv.
Moreover, I am working on a token-classification task ( POS tagging) , where each row in my CSV contains two columns each of them having a list of strings.
row example:
```tokens | labels
['I' , 'am', 'John'] | ['PRON', 'AUX', 'PROPN' ]
``... | closed | 2021-04-29T15:01:10 | https://api.github.com/repos/huggingface/datasets/issues/2288/comments | null | false | Load_dataset for local CSV files
The method load_dataset fails to correctly load a dataset from csv.
Moreover, I am working on a token-classification task ( POS tagging) , where each row in my CSV contains two columns each of them having a list of strings.
row example:
```tokens | labels
['I' , 'am', 'John'] ... | [
"Hi,\r\n\r\nthis is not a standard CSV file (requires additional preprocessing) so I wouldn't label this as s bug. You could parse the examples with the regex module or the string API to extract the data, but the following approach is probably the easiest (once you load the data):\r\n```python\r\nimport ast\r\n# lo... |
https://api.github.com/repos/huggingface/datasets/issues/2287 | 2,287 | Avoid copying table's record batches | Fixes #2276 | closed | 2021-04-29T14:15:01 | https://api.github.com/repos/huggingface/datasets/issues/2287/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2287",
"html_url": "https://github.com/huggingface/datasets/pull/2287",
"diff_url": "https://github.com/huggingface/datasets/pull/2287.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2287.patch",
"merged_at": null
} | true | Avoid copying table's record batches
Fixes #2276 | [
"Thanks for fixing it. I actually included a similar fix in #2291 along with some updates in tests\r\nI'm closing this one in favor of #2291 if you don't mind.\r\n\r\nThanks again !"
] |
https://api.github.com/repos/huggingface/datasets/issues/2286 | 2,286 | Fix metadata validation with config names | I noticed in https://github.com/huggingface/datasets/pull/2280 that the metadata validator doesn't parse the tags in the readme properly when then contain the tags per config. | closed | 2021-04-29T13:44:32 | https://api.github.com/repos/huggingface/datasets/issues/2286/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2286",
"html_url": "https://github.com/huggingface/datasets/pull/2286",
"diff_url": "https://github.com/huggingface/datasets/pull/2286.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2286.patch",
"merged_at": "2021-04-29T14:07... | true | Fix metadata validation with config names
I noticed in https://github.com/huggingface/datasets/pull/2280 that the metadata validator doesn't parse the tags in the readme properly when then contain the tags per config. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2285 | 2,285 | Help understanding how to build a dataset for language modeling as with the old TextDataset | Hello,
I am trying to load a custom dataset that I will then use for language modeling. The dataset consists of a text file that has a whole document in each line, meaning that each line overpasses the normal 512 tokens limit of most tokenizers.
I would like to understand what is the process to build a text datas... | closed | 2021-04-29T13:16:45 | https://api.github.com/repos/huggingface/datasets/issues/2285/comments | null | false | Help understanding how to build a dataset for language modeling as with the old TextDataset
Hello,
I am trying to load a custom dataset that I will then use for language modeling. The dataset consists of a text file that has a whole document in each line, meaning that each line overpasses the normal 512 tokens limit... | [
"\r\nI received an answer for this question on the HuggingFace Datasets forum by @lhoestq\r\n\r\nHi !\r\n\r\nIf you want to tokenize line by line, you can use this:\r\n\r\n```\r\nmax_seq_length = 512\r\nnum_proc = 4\r\n\r\ndef tokenize_function(examples):\r\n# Remove empty lines\r\nexamples[\"text\"] = [line for li... |
https://api.github.com/repos/huggingface/datasets/issues/2284 | 2,284 | Initialize Imdb dataset as used in Don't Stop Pretraining Paper | closed | 2021-04-29T11:52:38 | https://api.github.com/repos/huggingface/datasets/issues/2284/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2284",
"html_url": "https://github.com/huggingface/datasets/pull/2284",
"diff_url": "https://github.com/huggingface/datasets/pull/2284.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2284.patch",
"merged_at": null
} | true | Initialize Imdb dataset as used in Don't Stop Pretraining Paper
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/2283 | 2,283 | Initialize imdb dataset from don't stop pretraining paper | closed | 2021-04-29T11:44:54 | https://api.github.com/repos/huggingface/datasets/issues/2283/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2283",
"html_url": "https://github.com/huggingface/datasets/pull/2283",
"diff_url": "https://github.com/huggingface/datasets/pull/2283.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2283.patch",
"merged_at": null
} | true | Initialize imdb dataset from don't stop pretraining paper
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/2282 | 2,282 | Initialize imdb dataset from don't stop pretraining paper | closed | 2021-04-29T11:17:56 | https://api.github.com/repos/huggingface/datasets/issues/2282/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2282",
"html_url": "https://github.com/huggingface/datasets/pull/2282",
"diff_url": "https://github.com/huggingface/datasets/pull/2282.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2282.patch",
"merged_at": null
} | true | Initialize imdb dataset from don't stop pretraining paper
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/2281 | 2,281 | Update multi_woz_v22 checksum | Fix issue https://github.com/huggingface/datasets/issues/1876
The files were changed in https://github.com/budzianowski/multiwoz/pull/72 | closed | 2021-04-29T09:09:11 | https://api.github.com/repos/huggingface/datasets/issues/2281/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2281",
"html_url": "https://github.com/huggingface/datasets/pull/2281",
"diff_url": "https://github.com/huggingface/datasets/pull/2281.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2281.patch",
"merged_at": "2021-04-29T13:41... | true | Update multi_woz_v22 checksum
Fix issue https://github.com/huggingface/datasets/issues/1876
The files were changed in https://github.com/budzianowski/multiwoz/pull/72 | [] |
https://api.github.com/repos/huggingface/datasets/issues/2280 | 2,280 | Fixed typo seperate->separate | closed | 2021-04-29T08:55:46 | https://api.github.com/repos/huggingface/datasets/issues/2280/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2280",
"html_url": "https://github.com/huggingface/datasets/pull/2280",
"diff_url": "https://github.com/huggingface/datasets/pull/2280.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2280.patch",
"merged_at": null
} | true | Fixed typo seperate->separate
| [
"Hi ! Thanks for the fix :)\r\nThe CI fail isn't related to your PR. I opened a PR #2286 to fix the CI.\r\nWe'll wait for #2286 to be merged to master first if you don't mind",
"The PR has been merged ! Feel free to merge master into your branch to fix the CI"
] | |
https://api.github.com/repos/huggingface/datasets/issues/2279 | 2,279 | Compatibility with Ubuntu 18 and GLIBC 2.27? | ## Describe the bug
For use on Ubuntu systems, it seems that datasets requires GLIBC 2.29. However, Ubuntu 18 runs with GLIBC 2.27 and it seems [non-trivial to upgrade GLIBC to 2.29 for Ubuntu 18 users](https://www.digitalocean.com/community/questions/how-install-glibc-2-29-or-higher-in-ubuntu-18-04).
I'm not sure... | closed | 2021-04-28T22:08:07 | https://api.github.com/repos/huggingface/datasets/issues/2279/comments | null | false | Compatibility with Ubuntu 18 and GLIBC 2.27?
## Describe the bug
For use on Ubuntu systems, it seems that datasets requires GLIBC 2.29. However, Ubuntu 18 runs with GLIBC 2.27 and it seems [non-trivial to upgrade GLIBC to 2.29 for Ubuntu 18 users](https://www.digitalocean.com/community/questions/how-install-glibc-2-29... | [
"From the trace this seems like an error in the tokenizer library instead.\r\n\r\nDo you mind opening an issue at https://github.com/huggingface/tokenizers instead?",
"Hi @tginart, thanks for reporting.\r\n\r\nI think this issue is already open at `tokenizers` library: https://github.com/huggingface/tokenizers/is... |
https://api.github.com/repos/huggingface/datasets/issues/2278 | 2,278 | Loss result inGptNeoForCasual | Is there any way you give the " loss" and "logits" results in the gpt neo api? | closed | 2021-04-28T15:39:52 | https://api.github.com/repos/huggingface/datasets/issues/2278/comments | null | false | Loss result inGptNeoForCasual
Is there any way you give the " loss" and "logits" results in the gpt neo api? | [
"Hi ! I think you might have to ask on the `transformers` repo on or the forum at https://discuss.huggingface.co/\r\n\r\nClosing since it's not related to this library"
] |
https://api.github.com/repos/huggingface/datasets/issues/2277 | 2,277 | Create CacheManager | Perform refactoring to decouple cache functionality (method `as_dataset`). | open | 2021-04-28T15:23:42 | https://api.github.com/repos/huggingface/datasets/issues/2277/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2277",
"html_url": "https://github.com/huggingface/datasets/pull/2277",
"diff_url": "https://github.com/huggingface/datasets/pull/2277.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2277.patch",
"merged_at": null
} | true | Create CacheManager
Perform refactoring to decouple cache functionality (method `as_dataset`). | [] |
https://api.github.com/repos/huggingface/datasets/issues/2276 | 2,276 | concatenate_datasets loads all the data into memory | ## Describe the bug
When I try to concatenate 2 datasets (10GB each) , the entire data is loaded into memory instead of being written directly to disk.
Interestingly, this happens when trying to save the new dataset to disk or concatenating it again.
 , the entire data is loaded into memory instead of being written directly to disk.
Interestingly, this happens when trying to save the new dataset to disk or concatenating it again.
![image](h... | [
"Therefore, when I try to concatenate larger datasets (5x 35GB data sets) I also get an out of memory error, since over 90GB of swap space was used at the time of the crash:\r\n\r\n```\r\n---------------------------------------------------------------------------\r\nMemoryError Traceba... |
https://api.github.com/repos/huggingface/datasets/issues/2275 | 2,275 | SNLI dataset has labels of -1 | There are a number of rows with a label of -1 in the SNLI dataset. The dataset descriptions [here](https://nlp.stanford.edu/projects/snli/) and [here](https://github.com/huggingface/datasets/tree/master/datasets/snli) don't list -1 as a label possibility, and neither does the dataset viewer. As examples, see index 107... | closed | 2021-04-28T00:32:25 | https://api.github.com/repos/huggingface/datasets/issues/2275/comments | null | false | SNLI dataset has labels of -1
There are a number of rows with a label of -1 in the SNLI dataset. The dataset descriptions [here](https://nlp.stanford.edu/projects/snli/) and [here](https://github.com/huggingface/datasets/tree/master/datasets/snli) don't list -1 as a label possibility, and neither does the dataset vie... | [
"Hi @puzzler10, \r\nThose examples where `gold_label` field was empty, -1 label was alloted to it. In order to remove it you can filter the samples from train/val/test splits. Here's how you can drop those rows from the dataset:\r\n`dataset = load_dataset(\"snli\")`\r\n`dataset_test_filter = dataset['test'].filter(... |
https://api.github.com/repos/huggingface/datasets/issues/2274 | 2,274 | Always update metadata in arrow schema | We store a redundant copy of the features in the metadata of the schema of the arrow table. This is used to recover the features when doing `Dataset.from_file`. These metadata are updated after each transfor, that changes the feature types.
For each function that transforms the feature types of the dataset, I added ... | closed | 2021-04-27T19:21:57 | https://api.github.com/repos/huggingface/datasets/issues/2274/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2274",
"html_url": "https://github.com/huggingface/datasets/pull/2274",
"diff_url": "https://github.com/huggingface/datasets/pull/2274.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2274.patch",
"merged_at": "2021-04-29T09:57... | true | Always update metadata in arrow schema
We store a redundant copy of the features in the metadata of the schema of the arrow table. This is used to recover the features when doing `Dataset.from_file`. These metadata are updated after each transfor, that changes the feature types.
For each function that transforms the... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2273 | 2,273 | Added CUAD metrics | `EM`, `F1`, `AUPR`, `Precision@80%Recall`, and `Precision@90%Recall` metrics supported for CUAD | closed | 2021-04-27T16:49:12 | https://api.github.com/repos/huggingface/datasets/issues/2273/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2273",
"html_url": "https://github.com/huggingface/datasets/pull/2273",
"diff_url": "https://github.com/huggingface/datasets/pull/2273.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2273.patch",
"merged_at": "2021-04-29T13:59... | true | Added CUAD metrics
`EM`, `F1`, `AUPR`, `Precision@80%Recall`, and `Precision@90%Recall` metrics supported for CUAD | [] |
https://api.github.com/repos/huggingface/datasets/issues/2272 | 2,272 | Bug in Dataset.class_encode_column | ## Describe the bug
All the rest of the columns except the one passed to `Dataset.class_encode_column` are discarded.
## Expected results
All the original columns should be kept.
This needs regression tests.
| closed | 2021-04-27T16:13:18 | https://api.github.com/repos/huggingface/datasets/issues/2272/comments | null | false | Bug in Dataset.class_encode_column
## Describe the bug
All the rest of the columns except the one passed to `Dataset.class_encode_column` are discarded.
## Expected results
All the original columns should be kept.
This needs regression tests.
| [
"This has been fixed in this commit: https://github.com/huggingface/datasets/pull/2254/commits/88676c930216cd4cc31741b99827b477d2b46cb6\r\n\r\nIt was introduced in #2246 : using map with `input_columns` doesn't return the other columns anymore"
] |
https://api.github.com/repos/huggingface/datasets/issues/2271 | 2,271 | Synchronize table metadata with features | **Is your feature request related to a problem? Please describe.**
As pointed out in this [comment](https://github.com/huggingface/datasets/pull/2145#discussion_r621326767):
> Metadata stored in the schema is just a redundant information regarding the feature types.
It is used when calling Dataset.from_file to kno... | closed | 2021-04-27T15:55:13 | https://api.github.com/repos/huggingface/datasets/issues/2271/comments | null | false | Synchronize table metadata with features
**Is your feature request related to a problem? Please describe.**
As pointed out in this [comment](https://github.com/huggingface/datasets/pull/2145#discussion_r621326767):
> Metadata stored in the schema is just a redundant information regarding the feature types.
It is u... | [
"See PR #2274 "
] |
https://api.github.com/repos/huggingface/datasets/issues/2270 | 2,270 | Fix iterable interface expected by numpy | Numpy expects the old iterable interface with `__getitem__` instead of `__iter__`. | closed | 2021-04-27T14:35:56 | https://api.github.com/repos/huggingface/datasets/issues/2270/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2270",
"html_url": "https://github.com/huggingface/datasets/pull/2270",
"diff_url": "https://github.com/huggingface/datasets/pull/2270.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2270.patch",
"merged_at": null
} | true | Fix iterable interface expected by numpy
Numpy expects the old iterable interface with `__getitem__` instead of `__iter__`. | [
"It's been fixed in this commit: https://github.com/huggingface/datasets/commit/549110e08238b3716a5904667095fb003acda54e\r\n\r\nBasically #2246 broke querying an index with a simple iterable.\r\nWith the fix, it's again possible to use iterables and we can keep RandIter as it is.\r\n\r\nClosing since the fix is alr... |
https://api.github.com/repos/huggingface/datasets/issues/2269 | 2,269 | Fix query table with iterable | The benchmark runs are failing on master because it tries to use an iterable to query the dataset.
However there's currently an issue caused by the use of `np.array` instead of `np.fromiter` on the iterable.
This PR fixes it | closed | 2021-04-27T13:59:38 | https://api.github.com/repos/huggingface/datasets/issues/2269/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2269",
"html_url": "https://github.com/huggingface/datasets/pull/2269",
"diff_url": "https://github.com/huggingface/datasets/pull/2269.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2269.patch",
"merged_at": "2021-04-27T14:21... | true | Fix query table with iterable
The benchmark runs are failing on master because it tries to use an iterable to query the dataset.
However there's currently an issue caused by the use of `np.array` instead of `np.fromiter` on the iterable.
This PR fixes it | [] |
https://api.github.com/repos/huggingface/datasets/issues/2268 | 2,268 | Don't use pyarrow 4.0.0 since it segfaults when casting a sliced ListArray of integers | This test `tests/test_table.py::test_concatenation_table_cast` segfaults with the latest update of pyarrow 4.0.0.
Setting `pyarrow<4.0.0` for now. I'll open an issue on JIRA once I know more about the origin of the issue | closed | 2021-04-27T11:58:28 | https://api.github.com/repos/huggingface/datasets/issues/2268/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2268",
"html_url": "https://github.com/huggingface/datasets/pull/2268",
"diff_url": "https://github.com/huggingface/datasets/pull/2268.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2268.patch",
"merged_at": "2021-04-27T13:43... | true | Don't use pyarrow 4.0.0 since it segfaults when casting a sliced ListArray of integers
This test `tests/test_table.py::test_concatenation_table_cast` segfaults with the latest update of pyarrow 4.0.0.
Setting `pyarrow<4.0.0` for now. I'll open an issue on JIRA once I know more about the origin of the issue | [
"@lhoestq note that the segfault also occurs on Linux.",
"Created the ticket at\r\nhttps://issues.apache.org/jira/browse/ARROW-12568",
"@lhoestq the ticket you mentioned is now in state resolved. Pyarrow supports AArch64 after version 4.0.0. Because of this restriction `datasets` is not installing in AArch64 sy... |
https://api.github.com/repos/huggingface/datasets/issues/2267 | 2,267 | DatasetDict save load Failing test in 1.6 not in 1.5 | ## Describe the bug
We have a test that saves a DatasetDict to disk and then loads it from disk. In 1.6 there is an incompatibility in the schema.
Downgrading to `>1.6` -- fixes the problem.
## Steps to reproduce the bug
```python
### Load a dataset dict from jsonl
path = '/test/foo'
ds_dict.s... | open | 2021-04-27T00:03:25 | https://api.github.com/repos/huggingface/datasets/issues/2267/comments | null | false | DatasetDict save load Failing test in 1.6 not in 1.5
## Describe the bug
We have a test that saves a DatasetDict to disk and then loads it from disk. In 1.6 there is an incompatibility in the schema.
Downgrading to `>1.6` -- fixes the problem.
## Steps to reproduce the bug
```python
### Load a datase... | [
"Thanks for reporting ! We're looking into it",
"I'm not able to reproduce this, do you think you can provide a code that creates a DatasetDict that has this issue when saving and reloading ?",
"Hi, I just ran into a similar error. Here is the minimal code to reproduce:\r\n```python\r\nfrom datasets import load... |
https://api.github.com/repos/huggingface/datasets/issues/2266 | 2,266 | Make tests run faster | From 7min to 2min to run pytest.
Ideally we should keep the whole CI run time below 10min.
In this PR I removed the remote tests that were never used.
I also replaced nested parametrized tests with unit tests.
This makes me think that we could still add more high level tests to check for a few combinations of par... | closed | 2021-04-26T15:55:40 | https://api.github.com/repos/huggingface/datasets/issues/2266/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2266",
"html_url": "https://github.com/huggingface/datasets/pull/2266",
"diff_url": "https://github.com/huggingface/datasets/pull/2266.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2266.patch",
"merged_at": "2021-04-29T10:00... | true | Make tests run faster
From 7min to 2min to run pytest.
Ideally we should keep the whole CI run time below 10min.
In this PR I removed the remote tests that were never used.
I also replaced nested parametrized tests with unit tests.
This makes me think that we could still add more high level tests to check for a f... | [
"LOL, I was also working on something similar 😅. I'm gonna have a look!!!",
"Sorry I didn't know you were also working on it ^^'\r\nAnd yes I 100% agree with you on the points you mentioned. We should definitely improve the coverage. It would be nice to have a clearer separation to know which tests in the suite ... |
https://api.github.com/repos/huggingface/datasets/issues/2265 | 2,265 | Update black | Latest black version 21.4b0 requires to reformat most dataset scripts and also the core code of the lib.
This makes the CI currently fail on master | closed | 2021-04-26T09:35:09 | https://api.github.com/repos/huggingface/datasets/issues/2265/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2265",
"html_url": "https://github.com/huggingface/datasets/pull/2265",
"diff_url": "https://github.com/huggingface/datasets/pull/2265.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2265.patch",
"merged_at": "2021-04-26T09:47... | true | Update black
Latest black version 21.4b0 requires to reformat most dataset scripts and also the core code of the lib.
This makes the CI currently fail on master | [] |
https://api.github.com/repos/huggingface/datasets/issues/2264 | 2,264 | Fix memory issue in multiprocessing: Don't pickle table index | The table index is currently being pickled when doing multiprocessing, which brings all the record batches of the dataset in memory.
I fixed that by not pickling the index attributes. Therefore each process has to rebuild the index when unpickling the table.
Fix issue #2256
We'll do a patch release asap ! | closed | 2021-04-26T09:21:35 | https://api.github.com/repos/huggingface/datasets/issues/2264/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2264",
"html_url": "https://github.com/huggingface/datasets/pull/2264",
"diff_url": "https://github.com/huggingface/datasets/pull/2264.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2264.patch",
"merged_at": "2021-04-26T10:08... | true | Fix memory issue in multiprocessing: Don't pickle table index
The table index is currently being pickled when doing multiprocessing, which brings all the record batches of the dataset in memory.
I fixed that by not pickling the index attributes. Therefore each process has to rebuild the index when unpickling the tab... | [
"The code quality check is going to be fixed by #2265 ",
"The memory issue didn't come from `self.__dict__.copy()` but from the fact that this dict contains `_batches` which has all the batches of the table in it.\r\nTherefore for a MemoryMappedTable all the data in `_batches` were copied in memory when pickling ... |
https://api.github.com/repos/huggingface/datasets/issues/2263 | 2,263 | test data added, dataset_infos updated | Fixes #2262. Thanks for pointing out issue with dataset @jinmang2! | closed | 2021-04-26T08:27:18 | https://api.github.com/repos/huggingface/datasets/issues/2263/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2263",
"html_url": "https://github.com/huggingface/datasets/pull/2263",
"diff_url": "https://github.com/huggingface/datasets/pull/2263.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2263.patch",
"merged_at": "2021-04-29T09:30... | true | test data added, dataset_infos updated
Fixes #2262. Thanks for pointing out issue with dataset @jinmang2! | [] |
https://api.github.com/repos/huggingface/datasets/issues/2262 | 2,262 | NewsPH NLI dataset script fails to access test data. | In Newsph-NLI Dataset (#1192), it fails to access test data.
According to the script below, the download manager will download the train data when trying to download the test data.
https://github.com/huggingface/datasets/blob/2a2dd6316af2cc7fdf24e4779312e8ee0c7ed98b/datasets/newsph_nli/newsph_nli.py#L71
If yo... | closed | 2021-04-26T06:44:41 | https://api.github.com/repos/huggingface/datasets/issues/2262/comments | null | false | NewsPH NLI dataset script fails to access test data.
In Newsph-NLI Dataset (#1192), it fails to access test data.
According to the script below, the download manager will download the train data when trying to download the test data.
https://github.com/huggingface/datasets/blob/2a2dd6316af2cc7fdf24e4779312e8ee0c... | [
"Thanks @bhavitvyamalik for the fix !\r\nThe fix will be available in the next release.\r\nIt's already available on the `master` branch. For now you can either install `datasets` from source or use `script_version=\"master\"` in `load_dataset` to use the fixed version of this dataset."
] |
https://api.github.com/repos/huggingface/datasets/issues/2261 | 2,261 | Improve ReadInstruction logic and update docs | Improve ReadInstruction logic and docs. | closed | 2021-04-25T19:07:26 | https://api.github.com/repos/huggingface/datasets/issues/2261/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2261",
"html_url": "https://github.com/huggingface/datasets/pull/2261",
"diff_url": "https://github.com/huggingface/datasets/pull/2261.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2261.patch",
"merged_at": "2021-05-17T16:48... | true | Improve ReadInstruction logic and update docs
Improve ReadInstruction logic and docs. | [
"Ready for the final review"
] |
https://api.github.com/repos/huggingface/datasets/issues/2260 | 2,260 | GooAQ dataset added | @lhoestq here the dataset is stored with Git LFS. Should I add option for manual downloading of dataset using `git lfs pull` post repo cloning or can we accommodate this in the current `download_and_extract`? | closed | 2021-04-25T09:26:48 | https://api.github.com/repos/huggingface/datasets/issues/2260/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2260",
"html_url": "https://github.com/huggingface/datasets/pull/2260",
"diff_url": "https://github.com/huggingface/datasets/pull/2260.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2260.patch",
"merged_at": "2021-05-07T08:36... | true | GooAQ dataset added
@lhoestq here the dataset is stored with Git LFS. Should I add option for manual downloading of dataset using `git lfs pull` post repo cloning or can we accommodate this in the current `download_and_extract`? | [
"Thanks for adding this one !\r\nThe download manager does support downloading files on git lfs via their github url. No need for a manual download option ;)"
] |
https://api.github.com/repos/huggingface/datasets/issues/2259 | 2,259 | Add support for Split.ALL | The title says it all. | closed | 2021-04-25T01:45:42 | https://api.github.com/repos/huggingface/datasets/issues/2259/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2259",
"html_url": "https://github.com/huggingface/datasets/pull/2259",
"diff_url": "https://github.com/huggingface/datasets/pull/2259.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2259.patch",
"merged_at": "2021-06-28T08:21... | true | Add support for Split.ALL
The title says it all. | [
"Honestly, I think we should fix some other issues in Split API before this change. E. g. currently the following will not work, even though it should:\r\n```python\r\nimport datasets\r\ndatasets.load_dataset(\"sst\", split=datasets.Split.TRAIN+datasets.Split.TEST) # AssertionError\r\n```\r\n\r\nEDIT:\r\nActually,... |
https://api.github.com/repos/huggingface/datasets/issues/2258 | 2,258 | Fix incorrect update_metadata_with_features calls in ArrowDataset | Fixes bugs in the `unpdate_metadata_with_features` calls (caused by changes in #2151) | closed | 2021-04-25T00:48:38 | https://api.github.com/repos/huggingface/datasets/issues/2258/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2258",
"html_url": "https://github.com/huggingface/datasets/pull/2258",
"diff_url": "https://github.com/huggingface/datasets/pull/2258.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2258.patch",
"merged_at": "2021-04-26T16:54... | true | Fix incorrect update_metadata_with_features calls in ArrowDataset
Fixes bugs in the `unpdate_metadata_with_features` calls (caused by changes in #2151) | [
"@lhoestq Maybe a test that runs the functions that call `update_metadata_with_features` and checks if metadata was updated would be nice to prevent this from happening in the future."
] |
https://api.github.com/repos/huggingface/datasets/issues/2257 | 2,257 | added metrics for CUAD | For now I've added F1, AUPR, Precision at 80% recall, and Precision at 90%. Last 3 metrics were reported in the [paper](https://arxiv.org/pdf/2103.06268.pdf). Please let me know if we require `exact_match` metric too here | closed | 2021-04-24T14:09:54 | https://api.github.com/repos/huggingface/datasets/issues/2257/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2257",
"html_url": "https://github.com/huggingface/datasets/pull/2257",
"diff_url": "https://github.com/huggingface/datasets/pull/2257.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2257.patch",
"merged_at": null
} | true | added metrics for CUAD
For now I've added F1, AUPR, Precision at 80% recall, and Precision at 90%. Last 3 metrics were reported in the [paper](https://arxiv.org/pdf/2103.06268.pdf). Please let me know if we require `exact_match` metric too here | [
"> For now I've added F1, AUPR, Precision at 80% recall, and Precision at 90%. Last 3 metrics were reported in the [paper](https://arxiv.org/pdf/2103.06268.pdf). Please let me know if we require `exact_match` metric too here\r\n\r\n@bhavitvyamalik I guess the mentioned metrics are enough but it would be better if ... |
https://api.github.com/repos/huggingface/datasets/issues/2256 | 2,256 | Running `datase.map` with `num_proc > 1` uses a lot of memory | ## Describe the bug
Running `datase.map` with `num_proc > 1` leads to a tremendous memory usage that requires swapping on disk and it becomes very slow.
## Steps to reproduce the bug
```python
from datasets import load_dataset
dstc8_datset = load_dataset("roskoN/dstc8-reddit-corpus", keep_in_memory=False)
... | closed | 2021-04-24T09:56:20 | https://api.github.com/repos/huggingface/datasets/issues/2256/comments | null | false | Running `datase.map` with `num_proc > 1` uses a lot of memory
## Describe the bug
Running `datase.map` with `num_proc > 1` leads to a tremendous memory usage that requires swapping on disk and it becomes very slow.
## Steps to reproduce the bug
```python
from datasets import load_dataset
dstc8_datset = load_d... | [
"Thanks for reporting ! We are working on this and we'll do a patch release very soon.",
"We did a patch release to fix this issue.\r\nIt should be fixed in the new version 1.6.1\r\n\r\nThanks again for reporting and for the details :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/2255 | 2,255 | Task casting for text classification & question answering | This PR implements task preparation for a given task, in the continuation of #2143
Task taxonomy follows 🤗 Transformers's pipelines taxonomy: https://github.com/huggingface/transformers/tree/master/src/transformers/pipelines
Edit by @lewtun:
This PR implements support for the following tasks:
* `text-clas... | closed | 2021-04-23T16:00:41 | https://api.github.com/repos/huggingface/datasets/issues/2255/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2255",
"html_url": "https://github.com/huggingface/datasets/pull/2255",
"diff_url": "https://github.com/huggingface/datasets/pull/2255.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2255.patch",
"merged_at": "2021-05-18T13:31... | true | Task casting for text classification & question answering
This PR implements task preparation for a given task, in the continuation of #2143
Task taxonomy follows 🤗 Transformers's pipelines taxonomy: https://github.com/huggingface/transformers/tree/master/src/transformers/pipelines
Edit by @lewtun:
This PR i... | [
"cc @abhi1thakur ",
"Looks really nice so far, thanks !\r\nMaybe if a dataset doesn't have a template for a specific task we could try the default template of this task ?",
"hey @SBrandeis @lhoestq,\r\n\r\ni now have a better idea about what you guys are trying to achieve with the task templates and have a few ... |
https://api.github.com/repos/huggingface/datasets/issues/2254 | 2,254 | Update format, fingerprint and indices after add_item | Added fingerprint and format update wrappers + update the indices by adding the index of the newly added item in the table. | closed | 2021-04-23T14:31:49 | https://api.github.com/repos/huggingface/datasets/issues/2254/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2254",
"html_url": "https://github.com/huggingface/datasets/pull/2254",
"diff_url": "https://github.com/huggingface/datasets/pull/2254.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2254.patch",
"merged_at": "2021-04-27T16:30... | true | Update format, fingerprint and indices after add_item
Added fingerprint and format update wrappers + update the indices by adding the index of the newly added item in the table. | [
"I renamed the variable, added a test for dataset._indices and fixed an issue with class_encode_column"
] |
https://api.github.com/repos/huggingface/datasets/issues/2253 | 2,253 | Perform minor refactoring: use config | Perform minor refactoring related to `config`. | closed | 2021-04-23T11:45:47 | https://api.github.com/repos/huggingface/datasets/issues/2253/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2253",
"html_url": "https://github.com/huggingface/datasets/pull/2253",
"diff_url": "https://github.com/huggingface/datasets/pull/2253.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2253.patch",
"merged_at": "2021-04-27T15:02... | true | Perform minor refactoring: use config
Perform minor refactoring related to `config`. | [
"@lhoestq is there a problem in the master branch? I got a segmentation fault...\r\n```\r\ntests/test_table.py::test_concatenation_table_cast[in_memory] Fatal Python error: Segmentation fault\r\n```",
"Oh wow. Let me re-run the CI just to make sure",
"Hmm interesting, the segfault is still there. I'm investigat... |
https://api.github.com/repos/huggingface/datasets/issues/2252 | 2,252 | Slow dataloading with big datasets issue persists | Hi,
I reported too slow data fetching when data is large(#2210) a couple of weeks ago, and @lhoestq referred me to the fix (#2122).
However, the problem seems to persist. Here is the profiled results:
1) Running with 60GB
```
Action | Mean duration (s) |Num calls | Total ... | closed | 2021-04-23T08:18:20 | https://api.github.com/repos/huggingface/datasets/issues/2252/comments | null | false | Slow dataloading with big datasets issue persists
Hi,
I reported too slow data fetching when data is large(#2210) a couple of weeks ago, and @lhoestq referred me to the fix (#2122).
However, the problem seems to persist. Here is the profiled results:
1) Running with 60GB
```
Action ... | [
"Hi ! Sorry to hear that. This may come from another issue then.\r\n\r\nFirst can we check if this latency comes from the dataset itself ?\r\nYou can try to load your dataset and benchmark the speed of querying random examples inside it ?\r\n```python\r\nimport time\r\nimport numpy as np\r\n\r\nfrom datasets import... |
https://api.github.com/repos/huggingface/datasets/issues/2251 | 2,251 | while running run_qa.py, ran into a value error | command:
python3 run_qa.py --model_name_or_path hyunwoongko/kobart --dataset_name squad_kor_v2 --do_train --do_eval --per_device_train_batch_size 8 --learning_rate 3e-5 --num_train_epochs 3 --max_seq_length 512 --doc_stride 128 --output_dir /tmp/debug_squad/
error:
ValueError: External fe... | open | 2021-04-23T07:51:03 | https://api.github.com/repos/huggingface/datasets/issues/2251/comments | null | false | while running run_qa.py, ran into a value error
command:
python3 run_qa.py --model_name_or_path hyunwoongko/kobart --dataset_name squad_kor_v2 --do_train --do_eval --per_device_train_batch_size 8 --learning_rate 3e-5 --num_train_epochs 3 --max_seq_length 512 --doc_stride 128 --output_dir /tmp/de... | [
"Hi! Triaging older issues this week — I couldn't reproduce this on the current `main` (datasets 4.8.6.dev0).\n\nThe error reported here is `ValueError: External features info don't match the dataset` from running `run_qa.py` on `squad_kor_v2`. Two reasons this likely doesn't reproduce today:\n\n- `squad_kor_v2` wa... |
https://api.github.com/repos/huggingface/datasets/issues/2250 | 2,250 | some issue in loading local txt file as Dataset for run_mlm.py | 
first of all, I tried to load 3 .txt files as a dataset (sure that the directory and permission is OK.), I face with the below error.
> FileNotFoundError: [Errno 2] No such file or directory: 'c'
by ... | closed | 2021-04-22T19:39:13 | https://api.github.com/repos/huggingface/datasets/issues/2250/comments | null | false | some issue in loading local txt file as Dataset for run_mlm.py
first of all, I tried to load 3 .txt files as a dataset (sure that the directory and permission is OK.), I face with the below error.
> Fil... | [
"Hi,\r\n\r\n1. try\r\n ```python\r\n dataset = load_dataset(\"text\", data_files={\"train\": [\"a1.txt\", \"b1.txt\"], \"test\": [\"c1.txt\"]})\r\n ```\r\n instead.\r\n\r\n Sadly, I can't reproduce the error on my machine. If the above code doesn't resolve the issue, try to update the library to the ... |
https://api.github.com/repos/huggingface/datasets/issues/2249 | 2,249 | Allow downloading/processing/caching only specific splits | Allow downloading/processing/caching only specific splits without downloading/processing/caching the other splits.
This PR implements two steps to handle only specific splits:
- it allows processing/caching only specific splits into Arrow files
- for some simple cases, it allows downloading only specific splits (w... | open | 2021-04-22T17:51:44 | https://api.github.com/repos/huggingface/datasets/issues/2249/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2249",
"html_url": "https://github.com/huggingface/datasets/pull/2249",
"diff_url": "https://github.com/huggingface/datasets/pull/2249.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2249.patch",
"merged_at": null
} | true | Allow downloading/processing/caching only specific splits
Allow downloading/processing/caching only specific splits without downloading/processing/caching the other splits.
This PR implements two steps to handle only specific splits:
- it allows processing/caching only specific splits into Arrow files
- for some s... | [
"> If you pass a dictionary like this:\r\n> \r\n> ```\r\n> {\"main_metadata\": url_to_main_data,\r\n> \"secondary_metadata\": url_to_sec_data,\r\n> \"train\": url_train_data,\r\n> \"test\": url_test_data}\r\n> ```\r\n> \r\n> then only the train or test keys will be kept, which I feel not intuitive.\r\n> \r\n> For e... |
https://api.github.com/repos/huggingface/datasets/issues/2248 | 2,248 | Implement Dataset to JSON | Implement `Dataset.to_json`. | closed | 2021-04-22T11:46:51 | https://api.github.com/repos/huggingface/datasets/issues/2248/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2248",
"html_url": "https://github.com/huggingface/datasets/pull/2248",
"diff_url": "https://github.com/huggingface/datasets/pull/2248.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2248.patch",
"merged_at": "2021-04-27T15:29... | true | Implement Dataset to JSON
Implement `Dataset.to_json`. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2247 | 2,247 | Implement Dataset from Parquet | Implement instantiation of Dataset from Parquet file. | closed | 2021-04-22T11:01:38 | https://api.github.com/repos/huggingface/datasets/issues/2247/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2247",
"html_url": "https://github.com/huggingface/datasets/pull/2247",
"diff_url": "https://github.com/huggingface/datasets/pull/2247.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2247.patch",
"merged_at": null
} | true | Implement Dataset from Parquet
Implement instantiation of Dataset from Parquet file. | [
"Hi @albertvillanova , I'll implement the parquet builder as an ArrowBasedBuilder if you don't mind",
"closing in favor of #2537 that is already merged"
] |
https://api.github.com/repos/huggingface/datasets/issues/2246 | 2,246 | Faster map w/ input_columns & faster slicing w/ Iterable keys | @lhoestq Fixes #2193
- `map` now uses `with_format` to only load needed columns in memory when `input_columns` is set
- Slicing datasets with Iterables of indices now uses a new `Table.fast_gather` method, implemented with `np.searchsorted`, to find the appropriate batch indices all at once. `pa.concat_tables` is ... | closed | 2021-04-21T19:49:07 | https://api.github.com/repos/huggingface/datasets/issues/2246/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2246",
"html_url": "https://github.com/huggingface/datasets/pull/2246",
"diff_url": "https://github.com/huggingface/datasets/pull/2246.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2246.patch",
"merged_at": "2021-04-26T16:13... | true | Faster map w/ input_columns & faster slicing w/ Iterable keys
@lhoestq Fixes #2193
- `map` now uses `with_format` to only load needed columns in memory when `input_columns` is set
- Slicing datasets with Iterables of indices now uses a new `Table.fast_gather` method, implemented with `np.searchsorted`, to find the... | [
"@lhoestq Just fixed the code style issues— I think it should be good to merge now :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/2245 | 2,245 | Add `key` type and duplicates verification with hashing | Closes #2230
There is currently no verification for the data type and the uniqueness of the keys yielded by the `dataset_builder`.
This PR is currently a work in progress with the following goals:
- [x] Adding `hash_salt` to `ArrowWriter` so that the keys belonging to different splits have different hash
- [x]... | closed | 2021-04-20T20:03:19 | https://api.github.com/repos/huggingface/datasets/issues/2245/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2245",
"html_url": "https://github.com/huggingface/datasets/pull/2245",
"diff_url": "https://github.com/huggingface/datasets/pull/2245.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2245.patch",
"merged_at": "2021-05-10T17:31... | true | Add `key` type and duplicates verification with hashing
Closes #2230
There is currently no verification for the data type and the uniqueness of the keys yielded by the `dataset_builder`.
This PR is currently a work in progress with the following goals:
- [x] Adding `hash_salt` to `ArrowWriter` so that the keys b... | [
"@lhoestq The tests for key type and duplicate keys have been added and verified successfully.\r\nAfter generating with an intentionally faulty `mnist` script, when there is an incompatible key type, it shows:\r\n\r\n```\r\nDownloading and preparing dataset mnist/mnist (download: 11.06 MiB, generated: 60.62 MiB, po... |
https://api.github.com/repos/huggingface/datasets/issues/2244 | 2,244 | Set specific cache directories per test function call | Implement specific cache directories (datasets, metrics and modules) per test function call.
Currently, the cache directories are set within the temporary test directory, but they are shared across all test function calls.
This PR implements specific cache directories for each test function call, so that tests ar... | open | 2021-04-20T17:06:22 | https://api.github.com/repos/huggingface/datasets/issues/2244/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2244",
"html_url": "https://github.com/huggingface/datasets/pull/2244",
"diff_url": "https://github.com/huggingface/datasets/pull/2244.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2244.patch",
"merged_at": null
} | true | Set specific cache directories per test function call
Implement specific cache directories (datasets, metrics and modules) per test function call.
Currently, the cache directories are set within the temporary test directory, but they are shared across all test function calls.
This PR implements specific cache dir... | [
"@lhoestq, I think this reaches some memory limit on Linux instances... (?)",
"It looks like the `comet` metric test fails because it tries to load a model in memory.\r\nIn the tests I think we have `patch_comet` that mocks the model download + inference. Not sure why it didn't work though.\r\nI can take a look t... |
https://api.github.com/repos/huggingface/datasets/issues/2243 | 2,243 | Map is slow and processes batches one after another | ## Describe the bug
I have a somewhat unclear bug to me, where I can't figure out what the problem is. The code works as expected on a small subset of my dataset (2000 samples) on my local machine, but when I execute the same code with a larger dataset (1.4 million samples) this problem occurs. Thats why I can't giv... | closed | 2021-04-20T14:58:20 | https://api.github.com/repos/huggingface/datasets/issues/2243/comments | null | false | Map is slow and processes batches one after another
## Describe the bug
I have a somewhat unclear bug to me, where I can't figure out what the problem is. The code works as expected on a small subset of my dataset (2000 samples) on my local machine, but when I execute the same code with a larger dataset (1.4 million... | [
"Hi @villmow, thanks for reporting.\r\n\r\nCould you please try with the Datasets version 1.6? We released it yesterday and it fixes some issues about the processing speed. You can see the fix implemented by @lhoestq here: #2122.\r\n\r\nOnce you update Datasets, please confirm if the problem persists.",
"Hi @albe... |
https://api.github.com/repos/huggingface/datasets/issues/2242 | 2,242 | Link to datasets viwer on Quick Tour page returns "502 Bad Gateway" | Link to datasets viwer (https://huggingface.co/datasets/viewer/) on Quick Tour page (https://huggingface.co/docs/datasets/quicktour.html) returns "502 Bad Gateway"
The same error with https://huggingface.co/datasets/viewer/?dataset=glue&config=mrpc | closed | 2021-04-20T14:19:51 | https://api.github.com/repos/huggingface/datasets/issues/2242/comments | null | false | Link to datasets viwer on Quick Tour page returns "502 Bad Gateway"
Link to datasets viwer (https://huggingface.co/datasets/viewer/) on Quick Tour page (https://huggingface.co/docs/datasets/quicktour.html) returns "502 Bad Gateway"
The same error with https://huggingface.co/datasets/viewer/?dataset=glue&config=mrp... | [
"This should be fixed now!\r\n\r\ncc @srush "
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.