Search is not available for this dataset
hash string | author int32 | committer_date string | timezone int64 | parents string | message string | changes string | language string |
|---|---|---|---|---|---|---|---|
95a6b61cdc630dff91b9e9368914c04bd2a6a146 | 181 | 2020-09-08 14:14:54-07:00 | -36,000 | ['21b320ef42638f08df54bbcee0aa094cc35f6662'] | nginx: fix server_name case-sensitivity in parser (#8263)
This commit fixes an issue with the nginx parser where it would perform
case-sensitive matching against server_name.
This would cause the authenticator and installer to ignore existing
virtualhosts containing uppercase characters, resulting in duplicate
v... | [{'old_path': 'certbot-nginx/certbot_nginx/_internal/parser.py', 'new_path': 'certbot-nginx/certbot_nginx/_internal/parser.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -496,7 +496,8 @@ def get_best_match(target_name, names):\n \n \n def _exact_match(target_name, name):\n- return name in (target_name, '.' +... | Python |
f85b738e2f3b2bf86708a6d454bfca2b302d4483 | 665 | 2020-09-09 18:01:04+02:00 | -7,200 | ['95a6b61cdc630dff91b9e9368914c04bd2a6a146'] | Fix filename in example (#8275) | [{'old_path': 'certbot-dns-ovh/certbot_dns_ovh/__init__.py', 'new_path': 'certbot-dns-ovh/certbot_dns_ovh/__init__.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -72,7 +72,7 @@ Examples\n \n certbot certonly \\\\\n --dns-ovh \\\\\n- --dns-ovh-credentials ~/.secrets/certbot/ohv.ini \\\\\n+ --dns-... | Python |
c8828dab30ce6055495c4e5466ba02a78e5f8fd5 | 225 | 2020-09-09 15:16:52-07:00 | 25,200 | ['f85b738e2f3b2bf86708a6d454bfca2b302d4483'] | Move compatibility tests off of certbot-auto and Python 2 (#8248)
Fixes https://github.com/certbot/certbot/issues/8162.
I had to update the base of the Dockerfile to get a new enough version of Python 3. I also simplified things a lot and removed a lot of the comments that were essentially just describing how Docke... | [{'old_path': 'certbot-compatibility-test/Dockerfile', 'new_path': 'certbot-compatibility-test/Dockerfile', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,47 +1,18 @@\n-FROM debian:stretch\n+FROM debian:buster\n MAINTAINER Brad Warren <bmw@eff.org>\n \n-# no need to mkdir anything:\n-# https://docs.docker.com/ref... | Python |
e79af1b1de1667daf269806f791ff02d015adb1b | 181 | 2020-09-09 16:16:53-07:00 | -36,000 | ['c8828dab30ce6055495c4e5466ba02a78e5f8fd5'] | changelog: move #8263 to the right section (#8271) | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -14,7 +14,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Fixed\n \n-*\n+* Fixed `server_name` case-sensitivity in the nginx plugin.\n \n More details about these chan... | Python |
3a615176c5edae3a6a891961d0ae577e42b69a16 | 225 | 2020-09-10 09:37:10+02:00 | 25,200 | ['e79af1b1de1667daf269806f791ff02d015adb1b'] | fix Certbot acme dep (#8279) | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,6 +15,10 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n ### Fixed\n \n * Fixed `server_name` case-sensitivity in the nginx plugin.\n+* The minimum version of the `acme` li... | Python |
7ddd327f63260c1258e1149a253897d23fa39349 | 491 | 2020-09-11 00:11:51+02:00 | -7,200 | ['3a615176c5edae3a6a891961d0ae577e42b69a16'] | Removed unneeded chmod-call in a test. (#8244)
* Removed unneeded chmod-call in a test.
* Trigger CI.
Co-authored-by: Adrien Ferrand <ferrand.ad@gmail.com> | [{'old_path': 'certbot/tests/client_test.py', 'new_path': 'certbot/tests/client_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -483,7 +483,6 @@ class ClientTest(ClientTestCommon):\n def test_save_certificate(self, mock_parser):\n certs = ["cert_512.pem", "cert-san_512.pem"]\n tmp_path =... | Python |
55d411f1ebd9a8db5157ecac1c5ce8e1d542088c | 166 | 2020-09-10 15:57:59-07:00 | -7,200 | ['7ddd327f63260c1258e1149a253897d23fa39349'] | Remove deprecated `python setup.py test` call and update packager guide (#8262)
Fixes #7585
This PR removes the specific configuration to configure the test runner included in `setuptools` to use pytest, the deprecated parameters related to setuptools testing in `setup.py`, and update the packaging guide to use `py... | [{'old_path': 'acme/setup.py', 'new_path': 'acme/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,7 +4,6 @@ import sys\n from setuptools import __version__ as setuptools_version\n from setuptools import find_packages\n from setuptools import setup\n-from setuptools.command.test import test as TestCommand... | Python |
2b425110dc1c68110921ae648613a8c25db4d450 | 225 | 2020-09-11 12:16:55-07:00 | 25,200 | ['55d411f1ebd9a8db5157ecac1c5ce8e1d542088c'] | Delete conflicting server_names for random28524. (#8278) | [{'old_path': 'certbot-compatibility-test/nginx/nginx-roundtrip-testdata/79-configs/site-10571', 'new_path': 'certbot-compatibility-test/nginx/nginx-roundtrip-testdata/79-configs/site-10571', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -61,7 +61,6 @@ server {\n server {\n listen 80;\n server_name random14... | Python |
f43fa12fc0befed0437d5709aa63c45f2c2c3c98 | 181 | 2020-09-15 15:45:36-07:00 | -36,000 | ['2b425110dc1c68110921ae648613a8c25db4d450'] | cli: add --preconfigured-renewal packaging flag (#8274)
* cli: add --preconfigured-renewal packaging flag
* fix rst formatting
* snap: make the flag postfixed | [{'old_path': 'certbot.wrapper', 'new_path': 'certbot.wrapper', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -35,4 +35,4 @@ export CERTBOT_AUGEAS_PATH="${SNAP}/usr/lib/${ARCH_TRIPLET}/libaugeas.so.0"\n CERTBOT_PLUGIN_PATH="$(curl -s --unix-socket /run/snapd.socket "http://localhost/v2/connections?snap=certbot&inte... | Python |
6628bc0e9b49b7ab7158e56c20e28111b6afa8f7 | 181 | 2020-09-16 10:00:38-07:00 | -36,000 | ['f43fa12fc0befed0437d5709aa63c45f2c2c3c98'] | certbot-compat: remove dupe random25863 nginx name (#8286)
random25863.example.org appears in multiple port 80 virtualhosts in the
nginx testdata tarball and also is in the nginx-roundtrip-testdata.
Certbot doesn't handle these properly, which results in random test
failures.
This commit ensures that random25863... | [{'old_path': 'certbot-compatibility-test/certbot_compatibility_test/testdata/nginx.tar.gz', 'new_path': 'certbot-compatibility-test/certbot_compatibility_test/testdata/nginx.tar.gz', 'type': <ModificationType.MODIFY: 5>, 'diff': 'Binary files a/certbot-compatibility-test/certbot_compatibility_test/testdata/nginx.tar.g... | Python |
71d9dfa86ee78907b73feb161b304394445f3bbb | 181 | 2020-09-16 12:22:15-07:00 | -36,000 | ['6628bc0e9b49b7ab7158e56c20e28111b6afa8f7'] | nginx: reduced CLI logging when reloading nginx (#8237)
* nginx: reduced CLI logging when reloading nginx
Hides the output of `nginx -s reload` from the CLI, moving it to
debug-level logging.
Additionally, fixes an issue where Certbot did not properly capture the
output of the nginx reload and restart commands... | [{'old_path': 'certbot-nginx/certbot_nginx/_internal/configurator.py', 'new_path': 'certbot-nginx/certbot_nginx/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1175,23 +1175,29 @@ def nginx_restart(nginx_ctl, nginx_conf, sleep_duration):\n \n """\n try:\n+ reload_output = "... | Python |
b551b6ee73632422b7769a6d4a18cb1990307818 | 491 | 2020-09-19 10:38:40+02:00 | -7,200 | ['71d9dfa86ee78907b73feb161b304394445f3bbb'] | Removed unnecessary unittest.TestCase.setUp/tearDown calls. (#8264) | [{'old_path': 'certbot-apache/tests/util.py', 'new_path': 'certbot-apache/tests/util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -26,8 +26,6 @@ class ApacheTest(unittest.TestCase):\n config_root="debian_apache_2_4/multiple_vhosts/apache2",\n vhost_root="debian_apache_2_4/multiple_... | Python |
501df0dc4e289b04e73a9c64ca1ff2fda335536b | 491 | 2020-09-19 11:35:49+02:00 | -7,200 | ['b551b6ee73632422b7769a6d4a18cb1990307818'] | Use in dict rather than "in dict.keys()". Fix linting warnings about "not in". (#8298)
* Fixed a few linting warnings for if not x in y.
These should have been caught by pylint, but weren't.
* Replaced "x in y.keys()" with "x in y".
It's much faster, and more Pythonic. | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -801,7 +801,7 @@ class ClientV2(ClientBase):\n """\n # Can\'t use response.links directly because it drops multiple links\n # of the same relation type, which is possible in ... | Python |
a66f4e1150eaaf2dce6d089e0ca2132a31bcd5b3 | 491 | 2020-09-19 11:39:13+02:00 | -7,200 | ['501df0dc4e289b04e73a9c64ca1ff2fda335536b'] | Added an .editorconfig file. (#8297)
https://editorconfig.org/ is meant as a guideline for editors how to format
files. | [{'old_path': None, 'new_path': '.editorconfig', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,18 @@\n+# https://editorconfig.org/\n+\n+root = true\n+\n+[*]\n+insert_final_newline = true\n+trim_trailing_whitespace = true\n+end_of_line = lf\n+\n+[*.py]\n+indent_style = space\n+indent_size = 4\n+charset = utf-8\... | Python |
b20aaff66160b630acaf496773dabeb1b9eebcda | 181 | 2020-09-21 12:42:00-07:00 | -36,000 | ['a66f4e1150eaaf2dce6d089e0ca2132a31bcd5b3'] | remove unused ssllabs-related code (#8307) | [{'old_path': 'certbot/certbot/display/ops.py', 'new_path': 'certbot/certbot/display/ops.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -275,15 +275,6 @@ def success_revocation(cert_path):\n pause=False)\n \n \n-def _gen_ssl_lab_urls(domains):\n- """Returns a list of urls.\n-\n- :param list domain... | Python |
14cbf67d656618be0d36053265fe9fc3ace5085b | 181 | 2020-09-23 09:42:37-07:00 | -36,000 | ['b20aaff66160b630acaf496773dabeb1b9eebcda'] | tests: remove Ubuntu 19.10 (#8312)
EOL since July 2020. | [{'old_path': 'tests/letstest/apache2_targets.yaml', 'new_path': 'tests/letstest/apache2_targets.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,11 +8,6 @@ targets:\n type: ubuntu\n virt: hvm\n user: ubuntu\n- - ami: ami-0545f7036167eb3aa\n- name: ubuntu19.10\n- type: ubuntu\n- virt: h... | Python |
9a72db5b9b84396423b75cc32d5b137606953956 | 155 | 2020-09-23 19:36:55+02:00 | -36,000 | ['14cbf67d656618be0d36053265fe9fc3ace5085b'] | Convert http links to https (#8287)
* Convert http links to https
* Fix remaining links | [{'old_path': 'CONTRIBUTING.md', 'new_path': 'CONTRIBUTING.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -11,7 +11,7 @@ to the Sphinx generated docs is provided below.\n \n \n [1] https://github.com/blog/1184-contributing-guidelines\n-[2] http://docutils.sourceforge.net/docs/user/rst/quickref.html#hyperlink-ta... | Python |
5ec29ca60bc48938fadc02ab4bcd89db0891d7f8 | 181 | 2020-09-24 14:22:38-07:00 | -36,000 | ['9a72db5b9b84396423b75cc32d5b137606953956'] | suppress tracebacks in ErrorHandler recovery (#8310)
The ErrorHandler context manager could produce very verbose CLI output
when handling long exception chains (PIP 3134 enhanced reporting).
Rather than logging every exception with its traceback to the CLI, this
commit changes ErrorHandler so that only the final ... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -14,6 +14,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n * Update the packaging instructions to promote usage of `python -m pytest` to test Certbot\n instead of the deprec... | Python |
79297ef5cbb39e7d66cfa21039ea4b962e5619a5 | 166 | 2020-09-24 17:12:12-07:00 | -7,200 | ['5ec29ca60bc48938fadc02ab4bcd89db0891d7f8'] | Invoke pipstrap in tox and during the CI (#8316)
Partial fix for #8256
This PR makes tox calls pipstrap before any commands is executed, and Azure Pipelines calls pipstrap when appropriate (when an actual call to pip is done).
* Invoke pipstrap in tox and during the CI
* Set default value for PYTHON_VERSION ... | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,6 +3,8 @@ jobs:\n variables:\n - name: IMAGE_NAME\n value: ubuntu-18.04\n+ - name: PYTHON_VERSION\n+... | Python |
1be005289a4bbac200fef95b355d8dfc7cc315f9 | 225 | 2020-09-25 18:58:04+02:00 | 25,200 | ['79297ef5cbb39e7d66cfa21039ea4b962e5619a5'] | Print more output from snapcraft remote-build (#8321)
* Print more output from snapcraft remote-build.
* Include the build target in the output. | [{'old_path': 'tools/snap/build_remote.py', 'new_path': 'tools/snap/build_remote.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -52,26 +52,24 @@ def _build_snap(target, archs, status, lock):\n sys.stdout.flush()\n \n with lock:\n+ dump_output = exit_code != 0\n failed_arch... | Python |
feca125437ef1d51ed8cd31a70f45ca46b8f46d2 | 166 | 2020-09-25 11:24:29-07:00 | -7,200 | ['1be005289a4bbac200fef95b355d8dfc7cc315f9'] | Disable build isolation during snap dns plugins build (#8319)
Partial fix for #8256
This PR disable the build isolation for snap dns plugins similarly to what is done for the certbot snap. | [{'old_path': 'certbot-dns-cloudflare/snap/snapcraft.yaml', 'new_path': 'certbot-dns-cloudflare/snap/snapcraft.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -17,6 +17,7 @@ parts:\n snapcraftctl set-version `grep ^version $SNAPCRAFT_PART_SRC/setup.py | cut -f2 -d= | tr -d "\'[:space:]"`\n build-en... | Python |
be6c890874df2f9381c745fc18ef15e655d392e7 | 288 | 2020-09-25 15:31:13-07:00 | 25,200 | ['feca125437ef1d51ed8cd31a70f45ca46b8f46d2'] | Retry Snap upload in pipeline (#8300)
* add set -e to all bash instances in deploy-stage.yml
* retry uploading snap if we fail
* Add the rest of the set -e calls for bash in azure while we're here
* use retry based on travis_retry
* add set -e to the script: sections that run on macOS/Linux
* actually d... | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -13,17 +13,18 @@ jobs:\n arm64v8:\n DOCKER_ARCH: arm64v8\n steps:\n- - bash: tools/docker/build.sh $(dock... | Python |
fca7ec896a9b2813ec7cbfefe9251d70d106f61d | 288 | 2020-09-30 12:43:24-07:00 | 25,200 | ['e066766cc97adec395d93f0644ffa20be8cb0e20'] | Improve error message for prepare-plug-plugin hook when certbot isn't installed (#8338)
Provides a partial fix for #8182 by improving the error message. | [{'old_path': 'snap/hooks/prepare-plug-plugin', 'new_path': 'snap/hooks/prepare-plug-plugin', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -5,7 +5,8 @@ if [ "$(snapctl get trust-plugin-with-root)" = "ok" ]; then\n snapctl unset trust-plugin-with-root\n exit 0\n else\n- echo "Only connect this interface ... | Python |
7f0fa18c570942238a7de73ed99945c3710408b4 | 166 | 2020-09-30 13:24:56-07:00 | -7,200 | ['fca7ec896a9b2813ec7cbfefe9251d70d106f61d'] | Refactor certbot snap wrapper (#8313)
Partial fix for #8280
This PR refactors the bash script wrapper for snap (`/certbot.wrapper`) into certbot python codebase. Here are the keypoints of this refactoring:
* the wrapping is applied when `main` function from `certbot._internal.main` is called if environment variabl... | [{'old_path': 'certbot.wrapper', 'new_path': None, 'type': <ModificationType.DELETE: 4>, 'diff': '@@ -1,38 +0,0 @@\n-#!/bin/sh\n-#\n-# TODO: We may want to consider rewriting this script in Python. See\n-# https://github.com/certbot/certbot/issues/8251 for more info.\n-set -e\n-\n-# This code is based on snapcraft\'s o... | Python |
cac9d8f75ee2ffa668d402aecfbc74f038b34d45 | 225 | 2020-09-30 17:03:59-07:00 | 25,200 | ['7f0fa18c570942238a7de73ed99945c3710408b4'] | Deprecate certbot-auto outside of Debian and RHEL (#8324)
Fixes https://github.com/certbot/certbot/issues/8292.
This uses the same approach that worked well for us in https://github.com/certbot/certbot/pull/7926. I'm sure we could delete more code or refactor things here, but I think we should make the most conserv... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -11,6 +11,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Changed\n \n+* certbot-auto was deprecated on all systems except for those based on Debian or RHEL.\n * Updat... | Python |
160b209394059b649542912ea48a793d130fd38d | 225 | 2020-09-30 17:05:52-07:00 | 25,200 | ['cac9d8f75ee2ffa668d402aecfbc74f038b34d45'] | Automatically retry test farm tests (#8325)
Fixes #8317.
* move retry to script
* Retry test farm tests.
* Fix retry path. | [{'old_path': '.azure-pipelines/templates/stages/deploy-stage.yml', 'new_path': '.azure-pipelines/templates/stages/deploy-stage.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -55,24 +55,10 @@ stages:\n secureFile: snapcraft.cfg\n - bash: |\n set -e\n- retry_co... | Python |
e378931eda6ce6bcd9059959c4b3b790f41a203d | 225 | 2020-09-30 17:15:06-07:00 | 25,200 | ['160b209394059b649542912ea48a793d130fd38d'] | Upgrade httplib2 (#8289)
* Upgrade httplib2.
* Add changelog entry. | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,6 +24,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n In the previous release, Certbot said it required `acme>=1.6.0` when it\n actually required `acme>=1.8.0` to pro... | Python |
c12404451dc49dea4277f319d78abe0a5247bc6b | 491 | 2020-10-01 14:42:37+02:00 | -7,200 | ['e378931eda6ce6bcd9059959c4b3b790f41a203d'] | Converted dict comprehensions to use literals. (#8342) | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -448,7 +448,7 @@ class Client(ClientBase):\n heapq.heapify(waiting)\n # mapping between original Authorization Resource and the most\n # recently updated one\n- update... | Python |
ef8c481634b642489c20b29d2a8c30526d5b5adf | 225 | 2020-10-01 14:44:12+02:00 | 25,200 | ['c12404451dc49dea4277f319d78abe0a5247bc6b'] | Add snap log files to gitignore. (#8336) | [{'old_path': '.gitignore', 'new_path': '.gitignore', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -60,3 +60,7 @@ stage\n *.snap\n snap-constraints.txt\n qemu-*\n+certbot-dns*/certbot-dns*_amd64*.txt\n+certbot-dns*/certbot-dns*_arm*.txt\n+/certbot_amd64*.txt\n+/certbot_arm*.txt\n'}] | Python |
cc769067124aae2e5366b9eae1439a7ff5bb7343 | 225 | 2020-10-05 08:37:01-07:00 | 25,200 | ['ef8c481634b642489c20b29d2a8c30526d5b5adf'] | Set Certbot snap version from __init__.py (#8344)
Fixes https://github.com/certbot/certbot/issues/8166 following the feedback in https://github.com/certbot/certbot/pull/8337.
I took the command to get Certbot's version from: https://github.com/certbot/certbot/blob/ef8c481634b642489c20b29d2a8c30526d5b5adf/snap/snapc... | [{'old_path': 'snap/snapcraft.yaml', 'new_path': 'snap/snapcraft.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -80,7 +80,7 @@ parts:\n snapcraftctl pull\n cd $SNAPCRAFT_PART_SRC\n python3 tools/strip_hashes.py letsencrypt-auto-source/pieces/dependency-requirements.txt | grep -v python... | Python |
34694251dd48d5e5d8ee30f0f3a52f7a1893020e | 166 | 2020-10-05 20:50:45+02:00 | -7,200 | ['cc769067124aae2e5366b9eae1439a7ff5bb7343'] | Reuse key renewal params (#8343)
* Ensure key params are stored in renewal config when --reuse-key is set.
* Fix mypy definition
* Add unit test
* Clean code. | [{'old_path': 'certbot/certbot/_internal/renewal.py', 'new_path': 'certbot/certbot/_internal/renewal.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -9,16 +9,21 @@ import sys\n import time\n import traceback\n \n+from cryptography.hazmat.backends import default_backend\n+from cryptography.hazmat.primitives.asymm... | Python |
ac8798e8185699cd2b7ddc904bccd978968e8e2f | 225 | 2020-10-05 15:55:01-07:00 | 25,200 | ['34694251dd48d5e5d8ee30f0f3a52f7a1893020e'] | Give DNS plugin snaps grade stable. (#8350)
With more and more of our wildcard instructions on https://certbot.eff.org telling people to use these plugins, I think we should get ready to move our DNS plugins to the stable channel. This PR removes grade: devel so the snap store doesn't prevent us from doing that when w... | [{'old_path': 'certbot-dns-cloudflare/snap/snapcraft.yaml', 'new_path': 'certbot-dns-cloudflare/snap/snapcraft.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,7 +3,7 @@ name: certbot-dns-cloudflare\n summary: Cloudflare DNS Authenticator plugin for Certbot\n description: Cloudflare DNS Authenticator plugin ... | Python |
448fd9145a6ae6aa21d15492d171c0a0fd7132e5 | 288 | 2020-10-06 11:39:49-07:00 | 25,200 | ['ac8798e8185699cd2b7ddc904bccd978968e8e2f'] | Update changelog for 1.9.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.9.0 - master\n+## 1.9.0 - 2020-10-06\n \n ### Added\n \n'}] | Python |
5f040a8e329717c98a9673728df8033599f37d49 | 288 | 2020-10-06 12:15:29-07:00 | 25,200 | ['5173ab6b90ea6928370157f98718f7f0edc0e7ef'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.10.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
8a3aed04766c00d48325496ab557cdf982f010a5 | 288 | 2020-10-07 08:31:37-07:00 | 25,200 | ['afc5baad4a93ef1b4c43d9b4eb66fde98b43ef7b'] | add status messages to create_github_release script (#8353)
It took long enough to do all the downloading and uploading that I found myself wishing I could be sure things were happening. | [{'old_path': 'tools/create_github_release.py', 'new_path': 'tools/create_github_release.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -43,11 +43,13 @@ def download_azure_artifacts(tempdir):\n \n # Save and unzip files\n for filename in (\'windows-installer\', \'changelog\'):\n+ print("Downloadi... | Python |
aa61e6ad4e5c0e52c4fe14fc389bd9762cfa76b9 | 181 | 2020-10-08 13:27:36-07:00 | -39,600 | ['8a3aed04766c00d48325496ab557cdf982f010a5'] | certbot.util: suppress Popen CLI output (#8341)
* certbot.util: suppress Popen CLI output
Fixes #8326
* can't use subprocess.DEVNULL in py2 | [{'old_path': 'certbot/certbot/util.py', 'new_path': 'certbot/certbot/util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -401,14 +401,14 @@ def get_python_os_info(pretty=False):\n try:\n proc = subprocess.Popen(\n ["/usr/bin/sw_vers", "-productVersion"],\n- st... | Python |
afb07cf50d7f6ddb12861b72ca8ce665f96fd9a1 | 225 | 2020-10-08 15:18:09-07:00 | 25,200 | ['aa61e6ad4e5c0e52c4fe14fc389bd9762cfa76b9'] | Automate publishing snaps to the stable channel (#8351)
Fixes https://github.com/certbot/certbot/issues/8171.
See the comment at the top of the script to learn how to set things up and run this. Running the script between releases will have no effect on our snaps and it should fail when creating the GitHub release.... | [{'old_path': 'tools/create_github_release.py', 'new_path': None, 'type': <ModificationType.DELETE: 4>, 'diff': '@@ -1,92 +0,0 @@\n-#!/usr/bin/env python\n-"""\n-Post-release script to download artifacts from azure pipelines and use them to create\n-a GitHub release.\n-\n-Setup:\n- - Create a github personal access tok... | Python |
6a093bd35ae93112c67165724eab06b39f100fb2 | 225 | 2020-10-08 16:38:05-07:00 | 25,200 | ['afb07cf50d7f6ddb12861b72ca8ce665f96fd9a1'] | Move status message (#8361) | [{'old_path': 'tools/finish_release.py', 'new_path': 'tools/finish_release.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -166,6 +166,9 @@ def promote_snaps(version):\n assert_logged_into_snapcraft()\n for snap in SNAPS:\n revisions = get_snap_revisions(snap, version)\n+ # The loop below ... | Python |
631c88b209cfb33b6147032e7fda9d2a2f2a8d66 | 225 | 2020-10-09 12:44:09-07:00 | 25,200 | ['6a093bd35ae93112c67165724eab06b39f100fb2'] | Remove PPA instructions from docs. (#8364)
We're doing what we can to keep the PPA working in the most basic sense, but it is essentially deprecated and new users should not use it. | [{'old_path': 'certbot/docs/install.rst', 'new_path': 'certbot/docs/install.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -248,18 +248,7 @@ replacing ``certbot`` with the name of the desired package.\n \n **Ubuntu**\n \n-If you run Ubuntu Trusty, Xenial, or Bionic, certbot is available through the official PP... | Python |
725870d5583982d151d6991dd33f847aa8da3af5 | 325 | 2020-10-09 13:13:46-07:00 | -7,200 | ['631c88b209cfb33b6147032e7fda9d2a2f2a8d66'] | Add query timeout for dns-rfc2136 plugin (#8268)
* Add timeout to DNS query function calls
* Modify tests to account for new timeout variable
* Add change to CHANGELOG
* Add `dns.exception.Timeout` to exception handler
* Move changelog to 1.10.0 | [{'old_path': 'certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py', 'new_path': 'certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -18,6 +18,7 @@ from certbot.plugins import dns_common\n \n logger = logging.getLogger(__name__)\n \n+DEFAULT... | Python |
6fc832677e5e5344d1fad5774d1404e6d28bf038 | 57 | 2020-10-13 14:59:51-07:00 | -32,400 | ['725870d5583982d151d6991dd33f847aa8da3af5'] | Add dns-lightsail to third-party plugins (#8372) | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -281,6 +281,7 @@ proxmox_ N Y Install certificates in Proxmox Virtualization serv\n dns-standalone_ Y N Obtain certificates via an integrated DNS server\n dns-ispconfi... | Python |
ff03e34c7025bbede7c418d8000ecab10c0b36f0 | 57 | 2020-10-14 12:31:25-07:00 | -32,400 | ['6fc832677e5e5344d1fad5774d1404e6d28bf038'] | Enable dns-inwx link in third-party plugins (#8374) | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -282,7 +282,7 @@ dns-standalone_ Y N Obtain certificates via an integrated DNS server\n dns-ispconfig_ Y N DNS Authentication using ISPConfig as DNS server\n dns-clouddns_ ... | Python |
fea176449c4985c9e63950842b3cb134bd07dd48 | 325 | 2020-10-16 06:18:01+11:00 | -7,200 | ['ff03e34c7025bbede7c418d8000ecab10c0b36f0'] | Add confirmation before certificate delete (#8349)
* Ask confirmation before deleting cert
* Changelog
* Fix lint and preserve non-interactively deletetion
* Improve English
* Integrate message into yesno() without logger
* Reduce if/else into oneliner
* Expand "certificate(s)" in `get_certnames`
... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -25,6 +25,7 @@ More details about these changes can be found on our GitHub repo.\n \n * `--preconfigured-renewal` flag, for packager use only.\n See the [packaging guide](https://certbot.eff.org... | Python |
a64e1f01291327ae16b412ee921fc6ac6aed8453 | 181 | 2020-10-15 13:23:36-07:00 | -39,600 | ['fea176449c4985c9e63950842b3cb134bd07dd48'] | changelog: move entry to the right section (#8378) | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,6 +7,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n ### Added\n \n * Added timeout to DNS query function calls for dns-rfc2136 plugin.\n+* Confirmation when deleting cert... | Python |
88386e8c826921caf02cb9da468ea0e00c800d97 | 225 | 2020-10-19 15:30:30-07:00 | 25,200 | ['a64e1f01291327ae16b412ee921fc6ac6aed8453'] | Add external snap docs and clean up dev docs (#8356)
* Add external snap docs and clean up dev docs
* Correctly refer to content identifiers
* Expand plugin interface docs and add line breaks | [{'old_path': 'certbot/docs/contributing.rst', 'new_path': 'certbot/docs/contributing.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -303,7 +303,7 @@ configuration checkpoints and rollback.\n .. _dev-plugin:\n \n Writing your own plugin\n-~~~~~~~~~~~~~~~~~~~~~~~\n+-----------------------\n \n .. note:: The Cer... | Python |
cb916a068228e7f2e49d1edac8e096dbde2f59ee | 225 | 2020-10-20 16:25:20-07:00 | 25,200 | ['88386e8c826921caf02cb9da468ea0e00c800d97'] | Deprecate certbot-auto on Debian systems (#8354)
Fixes #8294.
* Deprecate certbot-auto on Debian systems.
* Add changelog entry.
* Remove le_auto_xenial test.
* Update certbot-auto test farm tests.
* Add comments explaining expected behavior. | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -64,8 +64,6 @@ jobs:\n ACME_SERVER: boulder-v2\n nginx-compat:\n TOXENV: nginx_compat\n- le... | Python |
4eb0b560c59cea45a88dc1af5e3a5952e85fc8d0 | 181 | 2020-10-22 12:12:54-07:00 | -39,600 | ['cb916a068228e7f2e49d1edac8e096dbde2f59ee'] | manual: deprecate --manual-public-ip-logging-ok (#8381)
* manual: deprecate --manual-public-ip-logging-ok
* remove unused cli.report_config_interaction code
Co-authored-by: ohemorange <ebportnoy@gmail.com> | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/certbot_call.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/certbot_call.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -92,7 +92,6 @@ def _prepare_args_env(certbot_args, directory_url, http_01_port, tls_alpn_01_por\n '--no-verify-s... | Python |
c250957ab0c456a90be37db1a22b3d1512182b09 | 225 | 2020-10-22 14:01:30-07:00 | 25,200 | ['4eb0b560c59cea45a88dc1af5e3a5952e85fc8d0'] | Add .envrc. (#8382) | [{'old_path': None, 'new_path': '.envrc', 'type': <ModificationType.ADD: 1>, 'diff': "@@ -0,0 +1,12 @@\n+# This file is just a nicety for developers who use direnv. When you cd under\n+# the Certbot repo, Certbot's virtual environment will be automatically\n+# activated and then deactivated when you cd elsewhere. Devel... | Python |
b6e3a3ad020059265c780a6b0854c81927c43f9a | 181 | 2020-10-22 17:33:45-07:00 | -39,600 | ['c250957ab0c456a90be37db1a22b3d1512182b09'] | register: remove report_new_account, use logger (#8393) | [{'old_path': 'certbot/certbot/_internal/account.py', 'new_path': 'certbot/certbot/_internal/account.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -11,7 +11,6 @@ import josepy as jose\n import pyrfc3339\n import pytz\n import six\n-import zope.component\n \n from acme import fields as acme_fields\n from acme i... | Python |
00ed56afd6bd09d86e1ca3ea9fe589a2464bcc08 | 166 | 2020-10-23 11:02:35-07:00 | -7,200 | ['b6e3a3ad020059265c780a6b0854c81927c43f9a'] | Execute basic integration tests against Certbot dockers during CI (#8396)
Fixes #8202
This PR adds an Azure Pipeline job to execute certbot plugins --prepare for each Docker image created during the CI on amd64.
* Prepare basic integration tests for certbot dockers
* Add a displayName for the integration test... | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -31,6 +31,25 @@ jobs:\n path: $(Build.ArtifactStagingDirectory)\n artifact: docker_$(DOCKER_ARCH)\n displayN... | Python |
cfd0a6ff1fd9db9ab359a423d4529b76184c7b98 | 166 | 2020-10-26 15:20:27-07:00 | -3,600 | ['00ed56afd6bd09d86e1ca3ea9fe589a2464bcc08'] | Remove usage of buildkit (#8408)
Fixes #8355
During the troubleshooting of #8355, I came to the conclusion that using buildkit was creating the problem. Without it all docker images are built correctly. Initially buildkit was enabled to avoid a building problem in Azure Pipeline, but I also found in my recent test... | [{'old_path': 'tools/docker/build.sh', 'new_path': 'tools/docker/build.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -12,19 +12,6 @@ IFS=$\'\\n\\t\'\n # given value is only the base of the tag because the things like the CPU\n # architecture are also added to the full tag.\n \n-# As of writing this, runs o... | Python |
4fa1df307573abf79324c1ece3b228b6dba31d74 | 85 | 2020-10-26 17:22:00-07:00 | -3,600 | ['cfd0a6ff1fd9db9ab359a423d4529b76184c7b98'] | Added links for gehirn and sakuracloud DNS plugins (#8406) | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -191,6 +191,7 @@ Once installed, you can find documentation on how to use each plugin at:\n * `certbot-dns-digitalocean <https://certbot-dns-digitalocean.readthedocs.io>`_\n * `certbot-dns-dns... | Python |
fc864543a732e0299964c21bbf89fe000a00bbbe | 288 | 2020-10-27 10:22:40-07:00 | 25,200 | ['4fa1df307573abf79324c1ece3b228b6dba31d74'] | Simplify/document snap creation (#8404)
This PR adds the following documentation improvements to fix https://github.com/certbot/certbot/issues/7958:
- Simplify building external plugins
- Separate out certbot snap instructions from plugin instructions
- Mention that dnsimple is just an example for the plugin inst... | [{'old_path': 'certbot/docs/contributing.rst', 'new_path': 'certbot/docs/contributing.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -375,6 +375,9 @@ The script used to generate the snapcraft.yaml files for our own externally\n snapped plugins can be found at\n https://github.com/certbot/certbot/blob/master/to... | Python |
bf07ec20b0096912fb02759f25923b9091643b63 | 181 | 2020-10-27 12:48:07-07:00 | -39,600 | ['fc864543a732e0299964c21bbf89fe000a00bbbe'] | run: dont report new certs when only re-installing (#8392) | [{'old_path': 'certbot/certbot/_internal/main.py', 'new_path': 'certbot/certbot/_internal/main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1109,6 +1109,8 @@ def run(config, plugins):\n cert_path = new_lineage.cert_path if new_lineage else None\n fullchain_path = new_lineage.fullchain_path if new_lin... | Python |
4c347f5576f264ddfaec9cdaea1b831841fa9d24 | 225 | 2020-10-28 14:12:32-07:00 | 25,200 | ['bf07ec20b0096912fb02759f25923b9091643b63'] | Switch to using python directly (#8413)
Windows installer tests failed last night because they suddenly switched to Python 3.9.
This is happening despite https://github.com/certbot/certbot/blob/bf07ec20b0096912fb02759f25923b9091643b63/.azure-pipelines/templates/jobs/packaging-jobs.yml#L92-L95 just a few lines earli... | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -103,7 +103,7 @@ jobs:\n # a recent version of pip, but we also to disable the isolated feature as described in\n # https://... | Python |
bb45c9aa418ad7a656f9ab3df60b1d14a4389712 | 225 | 2020-10-28 15:08:16-07:00 | 25,200 | ['4c347f5576f264ddfaec9cdaea1b831841fa9d24'] | Add Ubuntu 20.10 test farm tests (#8414)
Fixes https://github.com/certbot/certbot/issues/8400.
I had to switch the package installed in `apacheconftest` to `libapache2-mod-wsgi-py3` because Ubuntu 20.10 removed the Python 2 version of this module.
I didn't add this AMI to `tests/letstest/auto_targets.yaml` becau... | [{'old_path': 'certbot-apache/tests/apache-conf-files/apache-conf-test', 'new_path': 'certbot-apache/tests/apache-conf-files/apache-conf-test', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -52,7 +52,7 @@ function Cleanup() {\n # if our environment asks us to enable modules, do our best!\n if [ "$1" = --debian-modu... | Python |
3673ca77a533826ad7f2d61f78d4ae628bfeff9e | 288 | 2020-10-28 15:51:16-07:00 | 25,200 | ['bb45c9aa418ad7a656f9ab3df60b1d14a4389712'] | Fix LXD setup in snap README (#8416)
Fixes #8409.
Change the line in the README to allow `sudo /snap/bin/lxd.migrate -yes` to fail (for example, if there's nothing to migrate), but the whole command to succeed.
I tested this on a clean Focal install and confirmed it works. | [{'old_path': 'tools/snap/README.md', 'new_path': 'tools/snap/README.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -12,7 +12,7 @@ These steps need to be done once to set up your VM and do not need to be run aga\n 1. Start with a Focal VM. You need a full virtual machine using something like DigitalOcean, EC2,... | Python |
6c7b99f7e0faa60b595b06933f292d476b85799c | 225 | 2020-10-28 15:52:20-07:00 | 25,200 | ['3673ca77a533826ad7f2d61f78d4ae628bfeff9e'] | Remove fedora test farm tests (#8415)
While working on https://github.com/certbot/certbot/issues/8400, I noticed our Fedora AMIs are quite out of date. I considered updating them and what we could do to avoid the AMIs becoming so out-of-date in the future, but I think we don't actually need these tests.
I pulled a ... | [{'old_path': 'tests/letstest/apache2_targets.yaml', 'new_path': 'tests/letstest/apache2_targets.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -42,18 +42,6 @@ targets:\n virt: hvm\n user: admin\n #-----------------------------------------------------------------------------\n- # Fedora\n- - ami: ... | Python |
9567352002fe257b9bfb7d852e6dfbe6c73b17a9 | 225 | 2020-10-30 13:08:57-07:00 | 25,200 | ['6c7b99f7e0faa60b595b06933f292d476b85799c'] | Update tools/snap/generate_* comments. (#8412) | [{'old_path': 'certbot-dns-cloudflare/snap/hooks/post-refresh', 'new_path': 'certbot-dns-cloudflare/snap/hooks/post-refresh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,5 +1,5 @@\n #!/bin/sh -e\n-# This file is generated by tools/generate_dnsplugins_postrefreshhook.sh and should not be edited manually.\n+# Th... | Python |
df138d0027f7ab4a7d510d3c6af1f93d605eef6b | 225 | 2020-10-30 13:15:47-07:00 | 25,200 | ['9567352002fe257b9bfb7d852e6dfbe6c73b17a9'] | Document that logs aren't always created. (#8410) | [{'old_path': 'tools/snap/README.md', 'new_path': 'tools/snap/README.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -63,7 +63,7 @@ These are the steps to build and install the Certbot DNSimple plugin snap. If yo\n 4. Run `sudo snap set certbot trust-plugin-with-root=ok`.\n 5. Install the generated snap with `... | Python |
e570e8ad3230ed5ce24191cde9bbbc6d2a54b630 | 225 | 2020-10-30 14:12:57-07:00 | 25,200 | ['df138d0027f7ab4a7d510d3c6af1f93d605eef6b'] | Generate plugin snap configs as needed (#8411)
While reviewing https://github.com/certbot/certbot/pull/8404, it occurred to me that we're keeping both the generated files and the script used to generate them in `git`. Keeping both around seems unnecessary and is almost asking for the files to get out of sync at some p... | [{'old_path': '.gitignore', 'new_path': '.gitignore', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -64,3 +64,4 @@ certbot-dns*/certbot-dns*_amd64*.txt\n certbot-dns*/certbot-dns*_arm*.txt\n /certbot_amd64*.txt\n /certbot_arm*.txt\n+certbot-dns*/snap\n'}, {'old_path': 'certbot-dns-cloudflare/snap/hooks/post-refresh... | Python |
47c1045f6d467a18a30c2a8482a6bfb373706fb8 | 491 | 2020-11-04 15:16:48+01:00 | -7,200 | ['e570e8ad3230ed5ce24191cde9bbbc6d2a54b630'] | Implements support for ECDSA keys. Fixes #2163.
Thanks to @pahrohfit and @Tomoyuki-GH for previous efforts to implement
suport for this.
Co-Authored-By: Robert Dailey <rob@wargam.es>
Co-Authored-By: Tomoyuki-GH <55397638+Tomoyuki-GH@users.noreply.github.com> | [{'old_path': 'AUTHORS.md', 'new_path': 'AUTHORS.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -154,6 +154,7 @@ Authors\n * [Luca Olivetti](https://github.com/olivluca)\n * [Luke Rogers](https://github.com/lukeroge)\n * [Maarten](https://github.com/mrtndwrd)\n+* [Mads Jensen](https://github.com/atombrella)\n *... | Python |
75365f1d4e92c552f8ec69b97c0534adbd51f1d6 | 225 | 2020-11-05 15:28:35-08:00 | 28,800 | ['e570e8ad3230ed5ce24191cde9bbbc6d2a54b630'] | Remove python_version setting from mypy.ini (#8426)
* Remove python_version from mypy.ini.
* Fix magic_typing
* Ignore msvcrt usage.
* make mypy happier
* clean up changes
* Add type for reporter queue
* More mypy fixes
* Fix pyrfc3339 str.
* Remove unused import.
* Make certbot.util mypy wo... | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -201,7 +201,7 @@ class ClientBase(object):\n when = parsedate_tz(retry_after)\n if when is not None:\n try:\n- tz_secs = datetime.timedelta... | Python |
c102ca66c36ed33b4bd48370e9f8bf45736f1b46 | 225 | 2020-11-06 11:17:41+01:00 | 28,800 | ['75365f1d4e92c552f8ec69b97c0534adbd51f1d6'] | Write a replacement for pipstrap (#8401)
* Add a new, simplified version of pipstrap.
* Use tools/pipstrap.py
* Uncomment code
* Refactor pip_install.py and provide hashes.
* Fix test_sdists.sh.
* Make code work on Python 2.
* Call strip_hashes.py using Python 3.
* Pin the oldest version of httpli... | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -98,13 +98,9 @@ jobs:\n artifact: windows-installer\n path: $(Build.SourcesDirectory)/bin\n displayName: Ret... | Python |
11a4882128c4365c293e48a0ae20f431b2f98c1d | 181 | 2020-11-06 16:47:07-08:00 | -39,600 | ['c102ca66c36ed33b4bd48370e9f8bf45736f1b46'] | certbot.display: add new method to print CLI messages (#8432)
* IDisplay.notification: add `decorate` param.
The flag allows the caller to control whether the message will be
printed in a decorated way (wrapped by hlines) or in an undecorated
way (similar to print).
It is set to true by default, to reflect the... | [{'old_path': 'certbot/certbot/_internal/log.py', 'new_path': 'certbot/certbot/_internal/log.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -11,6 +11,13 @@ configured by the user. Any logged messages before\n Special care is taken by both methods to ensure all errors are logged\n and properly flushed before pro... | Python |
bf20f39ceb7297dfbde8bb1c2f6e9d330c2ceea6 | 181 | 2020-11-09 15:31:27-08:00 | -39,600 | ['11a4882128c4365c293e48a0ae20f431b2f98c1d'] | cli: miscellaneous IReporter removals (#8436)
* certbot delete: use undecorated print
* certbot revoke: use undecorated print
* certbot revoke: remove ireporter usages
* eff: remove IReporter usages
* certbot unregister: remove IReporter usage
* certbot update_account: remove IReporter usages
* certb... | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -544,7 +544,8 @@ def test_revoke_multiple_lineages(context):\n 'revoke', '--cert-path', join(context.c... | Python |
db2ffea351c78af1bf682cda64fc58dd91ab3391 | 181 | 2020-11-10 14:42:51-08:00 | -39,600 | ['bf20f39ceb7297dfbde8bb1c2f6e9d330c2ceea6'] | Fix #8436 & #8432 tests (#8440)
* tests: fix leaking patch in eff_test.py
* tests: PrintTest->NotifyTest in .display.util
The function was renamed during #8432. This change renames the test as
well. | [{'old_path': 'certbot/tests/display/util_test.py', 'new_path': 'certbot/tests/display/util_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -454,11 +454,11 @@ class PlaceParensTest(unittest.TestCase):\n self.assertEqual("(y)es please", self._call("yes please"))\n \n \n-class PrintTest(unittest.TestC... | Python |
8f5787008de288c2cec6e5d3763854703d02f298 | 166 | 2020-11-11 12:36:16-08:00 | -3,600 | ['198f5a99bc4a1a2555c2fb08aa8619f54200bf6a'] | Handle unexpected key type migration. (#8435)
Fixes #8365
This PR adds a control when `certbot certonly` or `certbot run` are called for a certificate that already exists and would eventually be replaced. As described in #8365, this control is here to ensure that the user will not modify the key type of their certi... | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -499,6 +499,16 @@ def test_renew_with_ec_keys(context):\n assert_elliptic_key(key2, SECP384R1)\n asser... | Python |
2a118f3e8331881aaecc132d5095b4941b7c710d | 166 | 2020-11-11 12:54:29-08:00 | -3,600 | ['db2ffea351c78af1bf682cda64fc58dd91ab3391'] | Close the session once snap connections are acquired (#8438)
This PR uses the context manager available for `requests.Session` to close properly the `session` once snap connections have been acquired. | [{'old_path': 'certbot/certbot/_internal/snap_config.py', 'new_path': 'certbot/certbot/_internal/snap_config.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -49,7 +49,7 @@ def prepare_env(cli_args):\n os.environ['CERTBOT_AUGEAS_PATH'] = '{0}/usr/lib/{1}/libaugeas.so.0'.format(\n os.environ.get('SNAP'... | Python |
f15f4f9838c46e015fb4a183aeb415c794418ea9 | 225 | 2020-11-12 00:06:50+01:00 | 28,800 | ['8f5787008de288c2cec6e5d3763854703d02f298'] | Add certbot renew --key-type test (#8447)
* Test certbot renew --key-type
* Fix typo | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/assertions.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/assertions.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,6 +4,7 @@ import os\n \n from cryptography.hazmat.backends import default_backend\n from cryptography.haz... | Python |
2132cf7f043238893c08fc6a103f8c40bba583e4 | 166 | 2020-11-12 12:44:05-08:00 | -3,600 | ['2a118f3e8331881aaecc132d5095b4941b7c710d'] | Use Python 3.8 for Linux integration tests (#8449)
Do we have any specific reason to run the standard Linux integration tests on Python 2.7?
If not, we should move to a more recent version of Python. This PR does it for Python 3.8. | [{'old_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -52,7 +52,7 @@ jobs:\n TOXENV: mypy\n linux-integration:\n IMAGE_NAME: ubuntu-18.04\n- PY... | Python |
b742b60c4d9422e00871555a6db29e9ba27dbf78 | 491 | 2020-11-12 23:33:02+01:00 | -3,600 | ['f15f4f9838c46e015fb4a183aeb415c794418ea9'] | Use better asserts. Added notes to style guide. (#8451) | [{'old_path': 'acme/tests/messages_test.py', 'new_path': 'acme/tests/messages_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -108,11 +108,11 @@ class ConstantTest(unittest.TestCase):\n \n def test_equality(self):\n const_a_prime = self.MockConstant('a')\n- self.assertFalse(self.const_a =... | Python |
553d3279c6b4fde84c7dd82a1c8dec1a8a465fe6 | 166 | 2020-11-12 15:31:32-08:00 | -3,600 | ['2132cf7f043238893c08fc6a103f8c40bba583e4'] | Add --dns-server option in run_acme_server (#7722)
Fixes #7717
This PR adds a `--dns-server` option to the `run_acme_server` test tool, in order to provide an arbitrary DNS server to Pebble or Boulder for the integration tests.
I also take this occasion to make `run_acme_server` a real CLI tool using argparse, a... | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/acme_server.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/acme_server.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,10 +2,12 @@\n """Module to setup an ACME CA server environment able to run multiple tests in parallel"""\n from __futur... | Python |
78edb2889ed4140b6e5c4662b4907f1bd3e89417 | 181 | 2020-11-12 16:09:29-08:00 | -39,600 | ['553d3279c6b4fde84c7dd82a1c8dec1a8a465fe6'] | cli: improve Obtaining/Renewing wording (#8395)
* cli: improve Obtaining/Renewing wording
* dont use logger, and use new phrasing
* .display_util.notify: dont wrap
As this function is supposed to be an analogue for print, we do not want
it to wrap by default. | [{'old_path': 'certbot/certbot/_internal/main.py', 'new_path': 'certbot/certbot/_internal/main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -113,12 +113,24 @@ def _get_and_save_cert(le_client, config, domains=None, certname=None, lineage=N\n if lineage is not None:\n # Renewal, where we al... | Python |
90557921e39cd04caaa255a5923e1d644a14ca25 | 181 | 2020-11-17 09:27:27+01:00 | -39,600 | ['78edb2889ed4140b6e5c4662b4907f1bd3e89417'] | Add certbot-dns-rfc2136 integration testing (#8448)
* tests: add certbot-dns-rfc2136 integration tests
* dont use 'with' form of socket.socket
fixes py2 crash
* address some feedback:
- conftest: make DNS server a global resource
- conftest: add dns_xdist parameter into node config
- conftest: add --dns-... | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -64,6 +64,10 @@ jobs:\n ACME_SERVER: boulder-v2\n nginx-compat:\n TOXENV: nginx_compat\n+ l... | Python |
e8139e80be54fe478fce28321a8d7f15c5182673 | 181 | 2020-11-17 14:58:29-08:00 | -39,600 | ['7ba35b44075579b9274486982b92c93b58f5094d'] | certbot-ci: fix py2 crash in dns_server | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/dns_server.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/dns_server.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -40,6 +40,8 @@ class DNSServer(object):\n \n self.bind_root = tempfile.mkdtemp()\n \n+ self.process = None\n+... | Python |
be3d0d872fabc04c40931f62603b7e40b83fe064 | 491 | 2020-11-17 16:02:35-08:00 | -3,600 | ['5a8582549311ff2863c6a1ff8e1ae66475905ff6'] | Read files as binary in crypto_util for crypto.load_certificate. (#8371) | [{'old_path': 'certbot/certbot/crypto_util.py', 'new_path': 'certbot/certbot/crypto_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -447,9 +447,8 @@ def _notAfterBefore(cert_path, method):\n \n """\n # pylint: disable=redefined-outer-name\n- with open(cert_path) as f:\n- x509 = crypto.load... | Python |
a8cede6ae1f85c32227ccb976b145d971a913f66 | 225 | 2020-11-19 09:10:56+01:00 | 28,800 | ['b742b60c4d9422e00871555a6db29e9ba27dbf78'] | Flesh out ECDSA documentation (#8464)
* Changelog tweaks.
* Add ECDSA documentation
* Fix typo | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -9,8 +9,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n * Added timeout to DNS query function calls for dns-rfc2136 plugin.\n * Confirmation when deleting certificates\n * CL... | Python |
9a4e95e25a542a6a295e2a2800000970afed41e6 | 225 | 2020-11-19 12:48:36-08:00 | 28,800 | ['9ca7f76505b10b2f395ddffc4ddc1cbc8afb516b'] | Add Python 3.9 support and tests (#8460)
Fixes https://github.com/certbot/certbot/issues/8134.
* Test on Python 3.9.
* Mention Python 3.9 support in changelog.
* s/\( *'Pro.*3\.\)8\(',\)/\18\2\n\19\2/
* undo changes to tox.ini
* Move more tests to Python 3.9
* Update PyYAML and packages which pinned ... | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,7 +4,7 @@ jobs:\n - name: IMAGE_NAME\n value: ubuntu-18.04\n - name: PYTHON_VERSION\n- value: 3.... | Python |
aea416f6549d6cb0176bfcb6113ea6b61584e570 | 491 | 2020-11-25 10:11:51+01:00 | -3,600 | ['9a4e95e25a542a6a295e2a2800000970afed41e6'] | Fix link typo in README (#8476) | [{'old_path': 'certbot/README.rst', 'new_path': 'certbot/README.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -106,7 +106,7 @@ Current Features\n * Can get domain-validated (DV) certificates.\n * Can revoke certificates.\n * Adjustable RSA key bit-length (2048 (default), 4096, ...).\n-* Adjustable [EC](https:... | Python |
f5a88ade54cc34ae216959a84a658986324ea69c | 181 | 2020-11-27 18:15:27+01:00 | -39,600 | ['aea416f6549d6cb0176bfcb6113ea6b61584e570'] | nginx: fix Unicode crash on Python 2 (#8480)
* nginx: fix py2 unicode sandwich
The nginx parser would crash when saving configuraitons containing
Unicode, because py2's `str` type does not support Unicode.
This change fixes that crash by ensuring that a string type supporting
Unicode is used in both Python 2 a... | [{'old_path': 'certbot-ci/certbot_integration_tests/nginx_tests/nginx_config.py', 'new_path': 'certbot-ci/certbot_integration_tests/nginx_tests/nginx_config.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,3 +1,4 @@\n+# -*- coding: utf-8 -*-\n """General purpose nginx test configuration generator."""\n import ... | Python |
43ee2993f135218cf1c3318acfa4c01b20a3922b | 224 | 2020-12-01 10:22:39-08:00 | 28,800 | ['f5a88ade54cc34ae216959a84a658986324ea69c'] | Update changelog for 1.10.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.10.0 - master\n+## 1.10.0 - 2020-12-01\n \n ### Added\n \n'}] | Python |
7b687611a4c0a29e7c9005c9f5892c5537ba1747 | 224 | 2020-12-01 10:35:57-08:00 | 28,800 | ['adacc4ab6dc63b024b17f0ec5adeb1adc9f93300'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.11.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
31b5f1310e1fd0331faaa7efbcb8cccdfee93e78 | 225 | 2020-12-02 08:57:04+11:00 | 28,800 | ['faa8d230c7855b8f9e0b7d63f5067091db219ab6'] | Fix changelog typo (#8488)
* fix changelog typo
* remove empty entry | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -26,7 +26,7 @@ More details about these changes can be found on our GitHub repo.\n * Confirmation when deleting certificates\n * CLI flag `--key-type` has been added to specify 'rsa' or 'ecdsa' (d... | Python |
ff3a07dca34350064bf9f8e9fbe93eda7482acc0 | 303 | 2020-12-02 09:48:57-08:00 | -3,600 | ['31b5f1310e1fd0331faaa7efbcb8cccdfee93e78'] | Deprecate certbot-auto and remove tests
* Completely deprecate certbot-auto
* DeaDeactivate centos6/oraclelinux6 tests
* Remove tests assets
* Remove another test
* Revert "Remove tests assets"
This reverts commit e603afe6c4683a25982351557a348d35eba2f65b. | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -79,8 +79,6 @@ jobs:\n IMAGE_NAME: ubuntu-18.04\n PYTHON_VERSION: 3.8\n TOXENV: integration-dns-... | Python |
e5113d5815a1118d0720e29424cb98ea06957b4d | 224 | 2020-12-02 10:22:44-08:00 | 28,800 | ['ff3a07dca34350064bf9f8e9fbe93eda7482acc0'] | Undo certbot-auto changes and remove centos6 tests
* Don't deprecate certbot-auto quite yet
* Remove centos6 test farm tests
* undo changes to test farm test scripts | [{'old_path': 'letsencrypt-auto-source/letsencrypt-auto', 'new_path': 'letsencrypt-auto-source/letsencrypt-auto', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -794,8 +794,110 @@ BootstrapMageiaCommon() {\n }\n \n \n-# Certbot-auto is now fully deprecated\n+# Set Bootstrap to the function that installs OS dependenc... | Python |
1a3c96a9554061a924624b7b30e8e0b9db40a542 | 303 | 2020-12-02 12:37:38-08:00 | -3,600 | ['adacc4ab6dc63b024b17f0ec5adeb1adc9f93300'] | Deprecate certbot-auto and remove tests
* Completely deprecate certbot-auto
* DeaDeactivate centos6/oraclelinux6 tests
* Remove tests assets
* Remove another test
* Revert "Remove tests assets"
This reverts commit e603afe6c4683a25982351557a348d35eba2f65b.
(cherry picked from commit ff3a07dca34350064bf9f8e9fbe93e... | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -79,8 +79,6 @@ jobs:\n IMAGE_NAME: ubuntu-18.04\n PYTHON_VERSION: 3.8\n TOXENV: integration-dns-... | Python |
7497c51f3456517e61465ced9b446794d8075d90 | 224 | 2020-12-02 12:37:43-08:00 | 28,800 | ['1a3c96a9554061a924624b7b30e8e0b9db40a542'] | Undo certbot-auto changes and remove centos6 tests
* Don't deprecate certbot-auto quite yet
* Remove centos6 test farm tests
* undo changes to test farm test scripts
(cherry picked from commit e5113d5815a1118d0720e29424cb98ea06957b4d) | [{'old_path': 'letsencrypt-auto-source/letsencrypt-auto', 'new_path': 'letsencrypt-auto-source/letsencrypt-auto', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -794,8 +794,110 @@ BootstrapMageiaCommon() {\n }\n \n \n-# Certbot-auto is now fully deprecated\n+# Set Bootstrap to the function that installs OS dependenc... | Python |
5f73274390dfc6241e489917f4beb640a72b66a5 | 225 | 2020-12-02 15:08:07-08:00 | 28,800 | ['d1e7404358c05734aaf436ef3c9d709029d62b09'] | Fix add deprecated argument (#8500)
Fixes https://github.com/certbot/certbot/issues/8495.
To further explain the problem here, `modify_kwargs_for_default_detection` as called in `add` is simplistic and doesn't always work. See https://github.com/certbot/certbot/issues/6164 for one other example.
In this case, we... | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/certbot_call.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/certbot_call.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -92,6 +92,7 @@ def _prepare_args_env(certbot_args, directory_url, http_01_port, tls_alpn_01_por\n '--no-verify-s... | Python |
45e48b565d3e20520cabc66f7e58f0db7fd54767 | 491 | 2020-12-02 15:12:27-08:00 | -3,600 | ['87386769f7ee228ae58eb2bb69a880e91a1b4000'] | Fix changelog typo (#8497)
Co-authored-by: Adrien Ferrand <ferrand.ad@gmail.com> | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -10,7 +10,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n * Confirmation when deleting certificates\n * CLI flag `--key-type` has been added to specify 'rsa' or 'ecdsa' (defa... | Python |
a71e22678f72c2b784530c778a84c70c84c3a5ae | 225 | 2020-12-03 09:06:05+01:00 | 28,800 | ['45e48b565d3e20520cabc66f7e58f0db7fd54767'] | Fix add deprecated argument (#8500) (#8501)
Fixes https://github.com/certbot/certbot/issues/8495.
To further explain the problem here, `modify_kwargs_for_default_detection` as called in `add` is simplistic and doesn't always work. See https://github.com/certbot/certbot/issues/6164 for one other example.
In this ... | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/certbot_call.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/certbot_call.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -92,6 +92,7 @@ def _prepare_args_env(certbot_args, directory_url, http_01_port, tls_alpn_01_por\n '--no-verify-s... | Python |
4c896fd87caaa20114bea6180ccaa4d5c9a85c2a | 224 | 2020-12-03 10:20:11-08:00 | 28,800 | ['a71e22678f72c2b784530c778a84c70c84c3a5ae'] | Update changelog for 1.10.1 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.10.1 - master\n+## 1.10.1 - 2020-12-03\n \n ### Fixed\n \n'}] | Python |
38f3d3d185fb7d88f79ce7051be2e3090d7a4201 | 224 | 2020-12-03 10:33:32-08:00 | 28,800 | ['64543d49704be2180668371cdcff3b42521b51b2'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.11.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
22cf94f9308ce683c14e6c4e52ec10c5d22fa8d2 | 179 | 2020-12-03 16:38:59-08:00 | -39,600 | ['d3166d7072a77ad9c3148a4755de4e76a5887e2c'] | cli: clean up `certbot renew` summary (#8503)
* cli: clean up `certbot renew` summary
- Unduplicate output which was being sent to both stdout and stderr
- Don't use IDisplay.notification to buffer output
- Remove big "DRY RUN" guards above and below, instead change language
to "renewal" or "simulated renewal"... | [{'old_path': 'certbot/certbot/_internal/renewal.py', 'new_path': 'certbot/certbot/_internal/renewal.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -19,6 +19,7 @@ import zope.component\n from acme.magic_typing import List\n from acme.magic_typing import Optional # pylint: disable=unused-import\n from certbot i... | Python |
d476aa43899c06320f5cf7c6e40f859a5bf9d1f8 | 166 | 2020-12-04 12:00:32+11:00 | -3,600 | ['22cf94f9308ce683c14e6c4e52ec10c5d22fa8d2'] | Update both main VA and remote VA to use the provided DNS server (#8467) | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/acme_server.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/acme_server.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -149,10 +149,10 @@ class ACMEServer(object):\n [pebble_path, \'-config\', pebble_config_path, \'-dnsserver\', ... | Python |
356e8d84d6963d73ede820299d8d15304ab9be83 | 179 | 2020-12-04 14:09:10+01:00 | -39,600 | ['d476aa43899c06320f5cf7c6e40f859a5bf9d1f8'] | dns-google: improve credentials error message (#8482)
This adds a 'Error parsing credentials file ...' wrapper to any errors
raised inside certbot-dns-google's usage of oauth2client, to make it
obvious to the user where the problem lies. | [{'old_path': 'certbot-dns-google/certbot_dns_google/_internal/dns_google.py', 'new_path': 'certbot-dns-google/certbot_dns_google/_internal/dns_google.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -85,9 +85,13 @@ class _GoogleClient(object):\n \n scopes = [\'https://www.googleapis.com/auth/ndev.clouddn... | Python |
5871de0c07cba22a4556e66dcdd68336ffa76b29 | 491 | 2020-12-04 14:29:58+01:00 | -3,600 | ['356e8d84d6963d73ede820299d8d15304ab9be83'] | Removed some unused imports. (#8424)
These were not annotated as something that should be ignored, and the test-suite
passes with these changes. | [{'old_path': 'acme/acme/__init__.py', 'new_path': 'acme/acme/__init__.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -6,7 +6,6 @@ This module is an implementation of the `ACME protocol`_.\n \n """\n import sys\n-import warnings\n \n # This code exists to keep backwards compatibility with people using acme.jose... | Python |
dc3ac13750de7df2f48b7808fb7ffca2b1335cf8 | 181 | 2020-12-06 09:10:03+01:00 | -39,600 | ['5871de0c07cba22a4556e66dcdd68336ffa76b29'] | snap: disable the "user site-packages directory" (#8509)
Although Certbot is a classic snap, it shouldn't load Python code from
the host system. This change prevents packages being loaded from the
"user site-packages directory" (PEP-370). i.e. Certbot will no longer
load DNS plugins installed via `pip install --use... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -14,7 +14,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Fixed\n \n-*\n+* The Certbot snap no longer loads packages installed via `pip install --user`. This\n+ was u... | Python |
38017473c5f945cbf85744d55ef876fdfcc72b2b | 181 | 2020-12-06 09:23:33+01:00 | -39,600 | ['dc3ac13750de7df2f48b7808fb7ffca2b1335cf8'] | add coverage testing to dns-rfc2136 integration (#8469)
* add coverage testing to dns-rfc2136 integration
* add coverage rule for certbot/* as well | [{'old_path': 'tox.ini', 'new_path': 'tox.ini', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -222,7 +222,11 @@ commands =\n {[base]pip_install} acme certbot certbot-dns-rfc2136 certbot-ci\n pytest certbot-ci/certbot_integration_tests/rfc2136_tests \\\n --acme-server=pebble --dns-server=bind \\\n- ... | Python |
447b6ffaefe0af1cd8b2aefb6e2d1a4a66b08d98 | 166 | 2020-12-07 15:18:00-08:00 | -3,600 | ['38017473c5f945cbf85744d55ef876fdfcc72b2b'] | Completely deprecate certbot-auto (#8489)
Fixes #8296
* Completely deprecate certbot-auto
* Add changelog | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,7 +10,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Changed\n \n-*\n+* certbot-auto was deprecated on all systems.\n \n ### Fixed\n \n'}, {'old_path': 'letsencry... | Python |