Search is not available for this dataset
hash string | author int32 | committer_date string | timezone int64 | parents string | message string | changes string | language string |
|---|---|---|---|---|---|---|---|
9045c03949bd2d690c17fe89518eb743626cfd6b | 166 | 2020-12-08 12:19:42-08:00 | -3,600 | ['447b6ffaefe0af1cd8b2aefb6e2d1a4a66b08d98'] | Deprecate support for Python 2 (#8491)
Fixes #8388
* Deprecate support for Python 2
* Ignore deprecation warning
* Update certbot/CHANGELOG.md
Co-authored-by: Brad Warren <bmw@users.noreply.github.com> | [{'old_path': 'acme/acme/__init__.py', 'new_path': 'acme/acme/__init__.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -6,6 +6,7 @@ This module is an implementation of the `ACME protocol`_.\n \n """\n import sys\n+import warnings\n \n # This code exists to keep backwards compatibility with people using acme.jose... | Python |
148246b85b5b9fd37c91a9beed8318da66987d90 | 225 | 2020-12-09 19:02:53+11:00 | 28,800 | ['9045c03949bd2d690c17fe89518eb743626cfd6b'] | Add reminders to update documentation (#8518)
* Add documentation PR checklist item.
* Update contributing doc | [{'old_path': 'certbot/docs/contributing.rst', 'new_path': 'certbot/docs/contributing.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -516,11 +516,13 @@ Steps:\n 4. Run ``tox --skip-missing-interpreters`` to run the entire test suite\n including coverage. The ``--skip-missing-interpreters`` argument ignores\... | Python |
878c3e396fc42110c8e96351cb4fc71ac0aadf68 | 166 | 2020-12-10 12:05:32-08:00 | -3,600 | ['148246b85b5b9fd37c91a9beed8318da66987d90'] | Avoid --system-site-packages during the snap build by preparing a venv with pipstrap that already includes wheel (#8445)
This PR proposes an alternative configuration for the snap build that avoid the need to use `--system-site-package` when constructing the virtual environment in the snap.
The rationale of `--syst... | [{'old_path': 'snap/snapcraft.yaml', 'new_path': 'snap/snapcraft.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -64,7 +64,6 @@ parts:\n - libpython3.8-stdlib\n - libpython3.8-minimal\n - python3-pip\n- - python3-setuptools\n - python3-wheel\n - python3-venv\n - python3... | Python |
e9a96f5e2aef85016b04e8d1798b855c169caa36 | 166 | 2020-12-10 12:57:13-08:00 | -3,600 | ['878c3e396fc42110c8e96351cb4fc71ac0aadf68'] | Deprecate support of Apache 2.2 in certbot-apache (#8516)
Fixes #8462
* Deprecate support of Apache 2.2 in certbot-apache
* Add a changelog | [{'old_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'new_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -327,6 +327,9 @@ class ApacheConfigurator(common.Installer):\n if self.version < (2, 2):\n raise errors.No... | Python |
6d71378c05fb52018f48633c2d9d992e1550403f | 225 | 2020-12-10 15:13:48-08:00 | 28,800 | ['e9a96f5e2aef85016b04e8d1798b855c169caa36'] | Add finish_release flags and CLI parsing (#8522) | [{'old_path': 'tools/finish_release.py', 'new_path': 'tools/finish_release.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -21,6 +21,7 @@ Run:\n python tools/finish_release.py ~/.ssh/githubpat.txt\n """\n \n+import argparse\n import glob\n import os.path\n import re\n@@ -44,6 +45,34 @@ SNAPS = [\'certbot\'] + DN... | Python |
38893115572ee1bc91fcaf10669a80686795ba0b | 166 | 2020-12-11 12:33:11-08:00 | -3,600 | ['6d71378c05fb52018f48633c2d9d992e1550403f'] | Setup a timeout to the remote snap build process (#8484)
This PR adds a `--timeout` flag to `tools/snap/build_remote.py` in order to fail the process if the time execution reaches the provided timeout. It is set to 5h30 on the relevant Azure job, while the job itself has a timeout of 6h managed on Azure side. This all... | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -144,7 +144,7 @@ jobs:\n git config --global user.name "$(Build.RequestedFor)"\n mkdir -p ~/.local/share/snapcraft/p... | Python |
5151e2afee98adebce061215ecda6a739c4f2ecd | 225 | 2020-12-15 10:36:42+11:00 | 28,800 | ['38893115572ee1bc91fcaf10669a80686795ba0b'] | add OS package warning (#8533) | [{'old_path': 'certbot/docs/install.rst', 'new_path': 'certbot/docs/install.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -207,6 +207,18 @@ of the ``/etc/letsencrypt`` directory, see :ref:`where-certs`.\n Operating System Packages\n -------------------------\n \n+.. warning:: While the Certbot team tries to k... | Python |
7febc18bb02736b3391ef06d37d1ed86a5fe31ba | 225 | 2020-12-15 12:00:00+01:00 | 28,800 | ['5151e2afee98adebce061215ecda6a739c4f2ecd'] | Make our test farm tests instances self-destruct (#8536)
* remove unused user data
* have instance self-destruct in case cleanup fails
* correct kwargs
* fix param order | [{'old_path': 'tests/letstest/auto_targets.yaml', 'new_path': 'tests/letstest/auto_targets.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -31,10 +31,6 @@ targets:\n virt: hvm\n user: admin\n machine_type: a1.medium\n- # userdata: |\n- # #cloud-init\n- # runcmd:\n- # - [ apt-get... | Python |
fcc8b38c02cc10ff320b401ffa242f2253ce9552 | 225 | 2020-12-15 12:00:14+01:00 | 28,800 | ['7febc18bb02736b3391ef06d37d1ed86a5fe31ba'] | remove CentOS 6 cruft from test farm tests (#8534) | [{'old_path': 'tests/letstest/scripts/bootstrap_os_packages.sh', 'new_path': 'tests/letstest/scripts/bootstrap_os_packages.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -98,41 +98,6 @@ BootstrapRpmCommonBase() {\n fi\n }\n \n-# This bootstrap concerns old RedHat-based distributions that do not ship by defaul... | Python |
c5a0b1ae5d49b766cd38e8648a02317290e870dc | 325 | 2020-12-16 15:40:49+11:00 | -3,600 | ['fcc8b38c02cc10ff320b401ffa242f2253ce9552'] | Add path to certbot executable in debug log (#8538) | [{'old_path': 'certbot/certbot/_internal/main.py', 'new_path': 'certbot/certbot/_internal/main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1382,6 +1382,7 @@ def main(cli_args=None):\n \n plugins = plugins_disco.PluginsRegistry.find_all()\n logger.debug("certbot version: %s", certbot.__version__)\n+ ... | Python |
d38766e05c306a81d1bd7798187dfb8f96a66d5d | 166 | 2020-12-16 10:49:31-08:00 | -3,600 | ['c5a0b1ae5d49b766cd38e8648a02317290e870dc'] | Enable again build isolation with proper pinning of build dependencies (#8443)
Fixes #8256
First let's sum up the problem to solve. We disabled the build isolation available in pip>=19 because it could potential break certbot build without a control on our side. Basically builds are not reproductible. Indeed the bu... | [{'old_path': 'snap/snapcraft.yaml', 'new_path': 'snap/snapcraft.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -40,7 +40,6 @@ parts:\n certbot:\n plugin: python\n source: .\n- constraints: [$SNAPCRAFT_PART_SRC/snap-constraints.txt]\n python-packages:\n - git+https://github.com/certbot/... | Python |
96a05d946c73a3f02dc03ed2f8ae0a73e261741c | 491 | 2020-12-16 20:34:12+01:00 | -3,600 | ['d38766e05c306a81d1bd7798187dfb8f96a66d5d'] | Added certbot-ci to lint section. Silenced and fixed linting warnings. (#8450) | [{'old_path': 'acme/acme/crypto_util.py', 'new_path': 'acme/acme/crypto_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -186,6 +186,7 @@ def probe_sni(name, host, port=443, timeout=300, # pylint: disable=too-many-argu\n raise errors.Error(error)\n return client_ssl.get_peer_certificate()\n \... | Python |
fcdfed9c2caa3599608f0cc3b6541f6f11573393 | 225 | 2020-12-16 11:43:32-08:00 | 28,800 | ['96a05d946c73a3f02dc03ed2f8ae0a73e261741c'] | remove reference to letsencrypt(-auto) (#8531) | [{'old_path': 'certbot/README.rst', 'new_path': 'certbot/README.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -18,10 +18,6 @@ systems.\n To see the changes made to Certbot between versions please refer to our\n `changelog <https://github.com/certbot/certbot/blob/master/certbot/CHANGELOG.md>`_.\n \n-Until May ... | Python |
cbf42ffae1da6404a47f9e07c3470218c790135f | 225 | 2020-12-16 12:42:51-08:00 | 28,800 | ['fcdfed9c2caa3599608f0cc3b6541f6f11573393'] | Clean up certbot-auto docs (#8532)
Fixes https://github.com/certbot/certbot/issues/8519.
I left the `certbot-auto` docs in `install.rst` to avoid breaking links and to help propagate information about our changes there. I moved it closer to the bottom of the doc though since I think our documentation about OS packa... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -12,7 +12,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n * We deprecated support for Python 2 in Certbot and its ACME library.\n Support for Python 2 will be removed in... | Python |
0465643d0a225d288c07e526022a3260e7e18359 | 181 | 2020-12-17 09:06:21+01:00 | -39,600 | ['cbf42ffae1da6404a47f9e07c3470218c790135f'] | certbot-ci: fix integration-external tests (#8547)
In 96a05d9, mypy testing was added to certbot-ci, but introduced an
undeclared dependency on acme.magic_typing, resulting in a crash when
run under the integration-external tox environment.
This change uses the typing module in certbot-ci in place of
acme.magic_typin... | [{'old_path': 'certbot-ci/certbot_integration_tests/nginx_tests/test_main.py', 'new_path': 'certbot-ci/certbot_integration_tests/nginx_tests/test_main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,7 @@\n import os\n import ssl\n \n+from typing import List\n import pytest\n \n from certbot_integration_t... | Python |
d714ccec0537c6dd4176f50ee707f0c784c0d5a0 | 431 | 2020-12-17 21:22:12+11:00 | -3,600 | ['0465643d0a225d288c07e526022a3260e7e18359'] | Fix fetch of existing records from Google DNS (#8521)
* Fix fetch of existing records from Google DNS
There has been many complaints regarding `certbot_dns_google` plugin
failing with:
* HTTP 412 - Precondition not met
* HTTP 409 - Conflict
See #6036. This PR fixes that situation. The bug lies on how we
... | [{'old_path': 'AUTHORS.md', 'new_path': 'AUTHORS.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -149,6 +149,7 @@ Authors\n * [Lior Sabag](https://github.com/liorsbg)\n * [Lipis](https://github.com/lipis)\n * [lord63](https://github.com/lord63)\n+* [Lorenzo Fundaró](https://github.com/lfundaro)\n * [Luca Beltram... | Python |
a8b6a1c98dad7b4190e2a663820ac96efeb84fc8 | 181 | 2020-12-19 07:30:17+11:00 | -39,600 | ['d714ccec0537c6dd4176f50ee707f0c784c0d5a0'] | update_account: print correct message for -m "" (#8537)
* update_account: print correct message for -m ""
When -m "" was passed on the CLI, Certbot would print that it updated
the email to '' (an empty string) rather than printing that it removed
the contact details.
This commit also refactors the update_accou... | [{'old_path': 'certbot/certbot/_internal/main.py', 'new_path': 'certbot/certbot/_internal/main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -769,7 +769,7 @@ def update_account(config, unused_plugins):\n acc.regr = acc.regr.update(uri=prev_regr_uri)\n account_storage.update_regr(acc, cb_client.acme)\n ... | Python |
e9bdfcc94bfa09da418fc7ebc2f874cf80d6da1f | 225 | 2020-12-18 15:02:23-08:00 | 28,800 | ['a8b6a1c98dad7b4190e2a663820ac96efeb84fc8'] | Pin DNS plugin snap build dependencies (#8553)
Fixes https://github.com/certbot/certbot/issues/8544 by taking the approach in https://github.com/certbot/certbot/pull/8443. | [{'old_path': 'tools/snap/generate_dnsplugins_all.sh', 'new_path': 'tools/snap/generate_dnsplugins_all.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -11,5 +11,6 @@ for PLUGIN_PATH in "${CERTBOT_DIR}"/certbot-dns-*; do\n # Create constraints file\n "${CERTBOT_DIR}"/tools/merge_requirements.py tools/dev_cons... | Python |
198f7d66e65ea5693f9c2165770bdbf801592ff8 | 107 | 2020-12-19 16:44:31+11:00 | 0 | ['e9bdfcc94bfa09da418fc7ebc2f874cf80d6da1f'] | Flag that DNS plugins are distributed separately from Certbot (#8479)
* Added note to each DNS documentation index page to mention that plugins need to be installed and are not included as standard.
* Resolved issue with white space in doc files
* Changed wording as discussed in PR.
* Changing URL to new wild... | [{'old_path': 'certbot-dns-cloudflare/certbot_dns_cloudflare/__init__.py', 'new_path': 'certbot-dns-cloudflare/certbot_dns_cloudflare/__init__.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,6 +3,10 @@ The `~certbot_dns_cloudflare.dns_cloudflare` plugin automates the process of\n completing a ``dns-01`` chall... | Python |
1146f3551992aeddff9991ef1aeef856d7540ee9 | 431 | 2020-12-21 17:17:29+11:00 | -3,600 | ['198f7d66e65ea5693f9c2165770bdbf801592ff8'] | Fix TTL mismatch leading to HTTP 412 (#8549)
* Fix TTL mismatch leading to HTTP 412
This PR is a follow up from #8521 where we address the
issue of potentially having a mismatch of TTL when executing
a DNS change (transaction = deletion + additions). Let's say
we have a record `foo.org 30 IN TXT foo-content` wit... | [{'old_path': 'certbot-dns-google/certbot_dns_google/_internal/dns_google.py', 'new_path': 'certbot-dns-google/certbot_dns_google/_internal/dns_google.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -118,10 +118,13 @@ class _GoogleClient(object):\n \n record_contents = self.get_existing_txt_rrset(zone_id... | Python |
8e7353900ccacaae015043eae15e7eee0a031e90 | 225 | 2020-12-21 09:02:22-08:00 | 28,800 | ['1146f3551992aeddff9991ef1aeef856d7540ee9'] | Add certbot-auto uninstall docs (#8552)
This is part of #8545.
* add certbot-auto uninstall docs
* add uninstall.rst
* write a more aggressive sed command | [{'old_path': 'certbot/docs/install.rst', 'new_path': 'certbot/docs/install.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -243,6 +243,8 @@ Certbot-Auto\n \n We used to have a shell script named ``certbot-auto`` to help people install\n Certbot on UNIX operating systems, however, this script is no longer suppo... | Python |
421e8b6270aa869f5a6ae91c3504678ad3688bd3 | 225 | 2020-12-21 13:31:37-08:00 | 28,800 | ['8e7353900ccacaae015043eae15e7eee0a031e90'] | fix fix_test_non_systemd_os_info (#8539) | [{'old_path': 'certbot/tests/util_test.py', 'new_path': 'certbot/tests/util_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -547,8 +547,7 @@ class OsInfoTest(unittest.TestCase):\n m_distro.linux_distribution.return_value = ("something", "else")\n self.assertEqual(cbutil.get_os_info()... | Python |
a7c3c0b90c6bb14b3bcff50790034419891d20f9 | 627 | 2020-12-21 15:29:00-08:00 | -39,600 | ['421e8b6270aa869f5a6ae91c3504678ad3688bd3'] | docs: fix simple typo, serveral -> several (#8558)
There is a small typo in certbot/certbot/ocsp.py.
Should read `several` rather than `serveral`. | [{'old_path': 'certbot/certbot/ocsp.py', 'new_path': 'certbot/certbot/ocsp.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -222,7 +222,7 @@ def _check_ocsp_cryptography(cert_path, chain_path, url, timeout):\n \n \n def _check_ocsp_response(response_ocsp, request_ocsp, issuer_cert, cert_path):\n- """Verify tha... | Python |
18faf4f7aba0f1661c5e85e92b7096eb8dcccc3a | 327 | 2020-12-21 16:00:31-08:00 | 28,800 | ['a7c3c0b90c6bb14b3bcff50790034419891d20f9'] | Edit certs -> certificates in user-facing text. (#8541)
* Edit certs -> certificates in user-facing text.
To reduce confusion, we should consistently use the full term.
* Edit certs->certificates in more user-facing text.
* fix failing lint (line too long)
* fix typo
Co-authored-by: Jacob Hoffman-Andrew... | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -629,7 +629,7 @@ def test_revoke_multiple_lineages(context):\n ])\n \n with open(join(context.workspac... | Python |
d3b82a4e8e2fe2ccf7d6bb6ed2d560d94a53eec6 | 225 | 2020-12-22 10:24:20-08:00 | 28,800 | ['18faf4f7aba0f1661c5e85e92b7096eb8dcccc3a'] | Fix test farm tests by using a local Pebble instance (#8561)
[As discussed in Mattermost](https://opensource.eff.org/eff-open-source/pl/yhtp4qu4zpfczm5wxmzxhndrto), our Apache test farm tests are failing because the CA certificate in the old version of boulder we have pinned expired over the weekend. This PR fixes tha... | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/acme_server.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/acme_server.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -35,7 +35,8 @@ class ACMEServer(object):\n ACMEServer is also a context manager, and so can be used to ensure ACME ser... | Python |
32fb89df7e5edf7fe8803d6c75f0b6d6c6cdb89c | 181 | 2020-12-22 15:10:59-08:00 | -39,600 | ['d3b82a4e8e2fe2ccf7d6bb6ed2d560d94a53eec6'] | docs: add missing /directory to ACMEv2 server URL (#8564) | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -912,7 +912,7 @@ Changing the ACME Server\n ========================\n \n By default, Certbot uses Let's Encrypt's production server at\n-https://acme-v02.api.letsencrypt.org/. You can tell Ce... | Python |
98fb9d2d93c58e39613a5b9126f06511b9e7f839 | 166 | 2021-01-05 09:34:12-08:00 | -3,600 | ['32fb89df7e5edf7fe8803d6c75f0b6d6c6cdb89c'] | Forbid os.readlink() (#8472)
The method `os.readlink()` has a significant behavior change with Python 3.8+ on Windows.
Starting with this version, it will return the resolved path in its "extended-style" form unconditionally, a form which allows to use more than 259 characters in a Windows path, and its string rep... | [{'old_path': 'certbot/certbot/_internal/account.py', 'new_path': 'certbot/certbot/_internal/account.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -20,6 +20,7 @@ from certbot import interfaces\n from certbot import util\n from certbot._internal import constants\n from certbot.compat import os\n+from certbot.co... | Python |
02a5d000cb1684619650677a2d3fa4972dfd576f | 224 | 2021-01-05 09:37:05-08:00 | 28,800 | ['32fb89df7e5edf7fe8803d6c75f0b6d6c6cdb89c'] | Update changelog for 1.11.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.11.0 - master\n+## 1.11.0 - 2021-01-05\n \n ### Added\n \n'}] | Python |
a49b84d64ec360b39739e5f641b53e9e249006f8 | 224 | 2021-01-05 09:51:10-08:00 | 28,800 | ['7567e8d8db2be0010fc1d500062a4bb8cbec5272'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.12.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
daf989fc21e2e1a96b84c158e91b5b3854428964 | 225 | 2021-01-06 17:47:25+11:00 | 28,800 | ['5c3fd7d9ee6e35837d070663801a36d9ad92fe8d'] | skip meta creation to speed up tests (#8575) | [{'old_path': 'certbot/tests/account_test.py', 'new_path': 'certbot/tests/account_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -113,11 +113,16 @@ class AccountFileStorageTest(test_util.ConfigTestCase):\n \n from certbot._internal.account import Account\n new_authzr_uri = "hi"\n+ me... | Python |
6e1d042f765e4c0c7a5a6247782dae0aee60d4d4 | 225 | 2021-01-06 18:14:43+11:00 | 28,800 | ['daf989fc21e2e1a96b84c158e91b5b3854428964'] | mock out plugin discovery in test_plugins (#8576) | [{'old_path': 'certbot/tests/main_test.py', 'new_path': 'certbot/tests/main_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -813,8 +813,10 @@ class MainTest(test_util.ConfigTestCase):\n self._call_no_clientmock(['delete'])\n self.assertEqual(1, mock_cert_manager.call_count)\n \n+ @mock.pa... | Python |
c44a5a77014bdebdefc1413d4edaffbf4d7e6d27 | 225 | 2021-01-06 18:26:01+11:00 | 28,800 | ['6e1d042f765e4c0c7a5a6247782dae0aee60d4d4'] | Fix plugin param type (#8578)
* Fix plugin param type in updater
The command used to do this was:
sed -i 's/\(:type .*plugins:\) `list` of `str`/\1 certbot._internal.plugins.disco.PluginsRegistry/g' certbot/certbot/_internal/updater.py
* fix plugin param type in main.py
The command used to do this was:
... | [{'old_path': 'certbot/certbot/_internal/main.py', 'new_path': 'certbot/certbot/_internal/main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -666,7 +666,7 @@ def unregister(config, unused_plugins):\n :type config: interfaces.IConfig\n \n :param unused_plugins: List of plugins (deprecated)\n- :type u... | Python |
ccde1eef64ff98b1957fdd5e1c7991c6e777d4c1 | 166 | 2021-01-06 16:17:34-08:00 | -3,600 | ['c44a5a77014bdebdefc1413d4edaffbf4d7e6d27'] | Enable Python 3.8 for Certbot on Windows (#8465)
Now that we have a new pipstrap script with recent version of pip, dependencies for Windows can be resolved correctly on Python 3.8.
This PR enables tests on Python 3.8, and package Certbot for Windows on Python 3.8 also. I do not move up to Python 3.9 since some dep... | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -56,7 +56,7 @@ jobs:\n steps:\n - task: UsePythonVersion@0\n inputs:\n- versionSpec: 3.7\n+ versionS... | Python |
e602736bdad1e49ddc80f5d431372e3b19b73388 | 225 | 2021-01-07 08:08:15+01:00 | 28,800 | ['ccde1eef64ff98b1957fdd5e1c7991c6e777d4c1'] | remove route53 readme (#8581) | [{'old_path': 'certbot-dns-route53/MANIFEST.in', 'new_path': 'certbot-dns-route53/MANIFEST.in', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,5 +1,4 @@\n include LICENSE.txt\n-include README\n recursive-include docs *\n recursive-include tests *\n global-exclude __pycache__\n'}, {'old_path': 'certbot-dns-route53... | Python |
fb8cd063ebed6263e29dcbee2c7857d0dd069125 | 605 | 2021-01-07 20:26:59+01:00 | 21,600 | ['e602736bdad1e49ddc80f5d431372e3b19b73388'] | Automatically Catch Sphinx Errors (#8530)
* clean up some Sphinx warnings
* first attempt at a doc-test pipeline job
* fix formatting
* fix test name
* set env for bash
* try bash vs script
* maybe it didn't like me setting 'PATH'...derp
* drop use of venv
* sphinx-build isn't a py script
* ... | [{'old_path': '.azure-pipelines/main.yml', 'new_path': '.azure-pipelines/main.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -5,3 +5,4 @@ pr:\n \n jobs:\n - template: templates/jobs/standard-tests-jobs.yml\n+\n'}, {'old_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'new_path': '.azure-pip... | Python |
4a9748ace55cb238d319bdd2a3290fbc814c4b13 | 225 | 2021-01-07 11:30:52-08:00 | 28,800 | ['fb8cd063ebed6263e29dcbee2c7857d0dd069125'] | Add matching route53 readme (#8583)
Building on https://github.com/certbot/certbot/pull/8581, our other DNS plugins have a simple `README.rst` file and this PR adds a matching one for the route53 plugin. | [{'old_path': 'certbot-dns-route53/MANIFEST.in', 'new_path': 'certbot-dns-route53/MANIFEST.in', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,4 +1,5 @@\n include LICENSE.txt\n+include README.rst\n recursive-include docs *\n recursive-include tests *\n global-exclude __pycache__\n'}, {'old_path': None, 'new_path'... | Python |
434ca1985f26b08de18728e70e86813f357f6b65 | 30 | 2021-01-08 09:49:21-08:00 | -3,600 | ['4a9748ace55cb238d319bdd2a3290fbc814c4b13'] | Change the SUSE override to use apachectl (#8592)
For some time, SUSE distributions have had both an apachectl
executable and an apache2ctl compat symlink so both could be used
but apachectl is preferred since that's the official upstream name.
This is currently the case in SLE 15 SP2 and openSUSE Leap 15.2
(and e... | [{'old_path': 'certbot-apache/certbot_apache/_internal/override_suse.py', 'new_path': 'certbot-apache/certbot_apache/_internal/override_suse.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -14,10 +14,10 @@ class OpenSUSEConfigurator(configurator.ApacheConfigurator):\n vhost_root="/etc/apache2/vhosts.d",\... | Python |
42f20455cdde94d49892aec15f78ddbb9867e2a8 | 185 | 2021-01-11 13:40:12-08:00 | 0 | ['434ca1985f26b08de18728e70e86813f357f6b65'] | Fix EC curve name typo in crypto_util (#8598)
* Fix EC curve name typo in crypto_util
Fix typo of secp521r1 in crypto util module.
- secp521r1 is to be supported by certbot, but a typo of "SECP521R1" in the input validation section of the make_key function results in an error being thrown
* Add myself to author... | [{'old_path': 'AUTHORS.md', 'new_path': 'AUTHORS.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -60,6 +60,7 @@ Authors\n * [DanCld](https://github.com/DanCld)\n * [Daniel Albers](https://github.com/AID)\n * [Daniel Aleksandersen](https://github.com/da2x)\n+* [Daniel Almasi](https://github.com/almasen)\n * [Dani... | Python |
7a02deeeba4e823c9b947a311fd85a5497a9dd30 | 225 | 2021-01-11 15:41:55-08:00 | 28,800 | ['42f20455cdde94d49892aec15f78ddbb9867e2a8'] | Modify release script to support yubikey sig (#8574)
Using `tools/offline-sigrequest.sh` is annoying. A while ago I looked into how we could use our yubikeys for our Windows code signing signatures and in the process of doing that learned how to use them for the certbot-auto signature. The certbot-auto signature won't... | [{'old_path': 'tools/_release.sh', 'new_path': 'tools/_release.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -216,8 +216,21 @@ fi\n # ensure we have the latest built version of leauto\n letsencrypt-auto-source/build.py\n \n-# and that it\'s signed correctly\n-tools/offline-sigrequest.sh || true\n+# Now we have... | Python |
b9de48e93ef885d2ce5f3a0ee3083777fc32ab1f | 225 | 2021-01-12 13:45:26-08:00 | 28,800 | ['7a02deeeba4e823c9b947a311fd85a5497a9dd30'] | Always sign certbot-auto with a yubikey (#8600)
* always sign certbot-auto with the yubikey
* remove tools/offline-sigrequest.sh | [{'old_path': 'tools/_release.sh', 'new_path': 'tools/_release.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -216,18 +216,10 @@ fi\n # ensure we have the latest built version of leauto\n letsencrypt-auto-source/build.py\n \n-# Now we have to sign the built version of leauto. If\n-# RELEASE_OPENSSL_WITH_YUBIKEY... | Python |
13d4a992519c52b0771eb5015ce372b298fabc57 | 181 | 2021-01-12 16:08:32-08:00 | -39,600 | ['b9de48e93ef885d2ce5f3a0ee3083777fc32ab1f'] | test: certbot-ci crash due to no p521 on boulder (#8602)
* test: certbot-ci crash due to no p521 on boulder
The bugfix in #8598 added an integration test to request a certificate
for an EC P-521 key, which is unsupported when ACME_SERVER=boulder,
failing our nightly integration tests.
* add an integration test... | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -476,6 +476,28 @@ def test_default_curve_type(context):\n assert_elliptic_key(key1, SECP256R1)\n \n \n+@py... | Python |
c0917a0302d10c9aca35f294b864499616b1af59 | 166 | 2021-01-13 14:38:57-08:00 | -3,600 | ['13d4a992519c52b0771eb5015ce372b298fabc57'] | Use os.path.normcase to have Windows compatible challenge paths on Windows (#8599)
* Use os.path.normcase to have Windows compatible challenge paths on Windows.
* Add integration test and fix lint | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -148,6 +148,17 @@ def test_certonly(context):\n """Test the certonly verb on certbot."""\n context.cer... | Python |
2fca48caaa8529432d003b0fdc880b673f6be1f5 | 158 | 2021-01-14 12:12:48+11:00 | 28,800 | ['c0917a0302d10c9aca35f294b864499616b1af59'] | --preferred-chain: only match root name (#8596)
* --preferred-chain: only match root name
Currently, when certbot is given the `--preferred-chain='Some Name'`
flag, it iterates through all alternate chains offered by the ACME
server until it finds any certificate which has `'Some Name'` as its
Issuer Common Name... | [{'old_path': 'AUTHORS.md', 'new_path': 'AUTHORS.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,6 +1,7 @@\n Authors\n =======\n \n+* [Aaron Gable](https://github.com/aarongable)\n * [Aaron Zirbes](https://github.com/aaronzirbes)\n * Aaron Zuehlke\n * Ada Lovelace\n'}, {'old_path': 'certbot/CHANGELOG.md', 'ne... | Python |
261b5a76d8c000ce1354e0a0437b9c2f846fc6a3 | 489 | 2021-01-14 20:39:42+11:00 | 0 | ['2fca48caaa8529432d003b0fdc880b673f6be1f5'] | Minor fix to logging message (#8605)
* Minor fix to logging message
the `if socket_kwargs` will always evaluate to `true`.
* Update acme/acme/crypto_util.py
Co-authored-by: alexzorin <alex@zor.io> | [{'old_path': 'acme/acme/crypto_util.py', 'new_path': 'acme/acme/crypto_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -166,7 +166,7 @@ def probe_sni(name, host, port=443, timeout=300, # pylint: disable=too-many-argu\n " from {0}:{1}".format(\n source_address[0],\n ... | Python |
adb7e5e62f4c96be678c5af3e55a82ddcc717590 | 225 | 2021-01-16 07:13:59+11:00 | 28,800 | ['261b5a76d8c000ce1354e0a0437b9c2f846fc6a3'] | remove unused pyicu pinning (#8607) | [{'old_path': 'tools/oldest_constraints.txt', 'new_path': 'tools/oldest_constraints.txt', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -29,7 +29,6 @@ zope.interface==4.0.5\n # Debian Jessie has reached end of life. However:\n # When it becomes necessary to upgrade any of these dependencies, you should only update ... | Python |
00235d3807f298c3cee700ed946a2fc6c3bf8145 | 225 | 2021-01-25 12:59:14-08:00 | 28,800 | ['adb7e5e62f4c96be678c5af3e55a82ddcc717590'] | Switch oldest tests to Python 3 (#8590)
Fixes https://github.com/certbot/certbot/issues/8580.
With this PR, it should now be possible to run the oldest tests natively on Linux, at least when using an older version of Python 3, which hasn't been possible in a long time. Unfortunately, this isn't possible on macOS wh... | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,15 +22,19 @@ jobs:\n TOXENV: py37\n CERTBOT_NO_PIN: 1\n linux-boulder-v1-integration-certbot-o... | Python |
7399807ff2b4f8ac1f97e4f037f374610ca88797 | 166 | 2021-01-25 15:07:43-08:00 | -3,600 | ['00235d3807f298c3cee700ed946a2fc6c3bf8145'] | Drop Python 2 support (#8591)
Fixes #8389 #8584.
This PR makes the necessary modifications to officially drop Python 2 support in the Certbot project.
I did not remove the specific Python 2 compatibility branches that has been added in various places in the codebase, to reduce the size of this PR and this will b... | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -37,14 +37,6 @@ jobs:\n PYTHON_VERSION: 3.6\n TOXENV: integration-nginx-oldest\n ACME_SERVER: bo... | Python |
b4e955a60e78c622b03108ba933ddedc2ca236ff | 225 | 2021-01-25 15:20:51-08:00 | 28,800 | ['7399807ff2b4f8ac1f97e4f037f374610ca88797'] | Switch away from ubuntu-latest (#8606)
I noticed warnings on Azure like [this](https://dev.azure.com/certbot/certbot/_build/results?buildId=3311&view=logs&j=d74e04fe-9740-597d-e9fa-1d0400037dfd) which say:
> ##[warning]Ubuntu-latest pipelines will use Ubuntu-20.04 soon. For more details, see https://github.com/acti... | [{'old_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -73,6 +73,6 @@ jobs:\n - template: ../steps/tox-steps.yml\n - job: test_sphinx_builds\n pool:\n- vmImage: ubu... | Python |
bdfb9f19c4086a60ef010d2431768850c26d838a | 288 | 2021-01-28 12:34:50-08:00 | 28,800 | ['b4e955a60e78c622b03108ba933ddedc2ca236ff'] | Remove deprecated options as early as possible using an explicit list (#8617)
* Remove deprecated options as early as possible using an explicit list
* add deprecated options to cli init import list
* use correct dict comprehension syntax for py3
* lint
* add test for renewal reconstitution code
* add t... | [{'old_path': 'certbot/certbot/_internal/cli/__init__.py', 'new_path': 'certbot/certbot/_internal/cli/__init__.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -28,7 +28,8 @@ from certbot._internal.cli.cli_constants import (\n ARGPARSE_PARAMS_TO_REMOVE,\n EXIT_ACTIONS,\n ZERO_ARG_ACTIONS,\n- VAR_MO... | Python |
2e33aec8a849ba56afa6acd2764b4f3b328aa88e | 224 | 2021-01-29 15:31:11-08:00 | 28,800 | ['bdfb9f19c4086a60ef010d2431768850c26d838a'] | add tests with external mock library | [{'old_path': 'tox.ini', 'new_path': 'tox.ini', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -137,6 +137,11 @@ commands =\n setenv =\n {[testenv:oldest]setenv}\n \n+[testenv:external-mock]\n+commands =\n+ python {toxinidir}/tools/pip_install.py mock\n+ {[base]install_and_test} {[base]all_packages}\n+\n [... | Python |
534af33a50c6de9900f7066bf848fe61e4a13f62 | 224 | 2021-01-29 15:32:04-08:00 | 28,800 | ['2e33aec8a849ba56afa6acd2764b4f3b328aa88e'] | add external-mock tests to azure config | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -21,6 +21,8 @@ jobs:\n PYTHON_VERSION: 3.7\n TOXENV: py37\n CERTBOT_NO_PIN: 1\n+ linux-ex... | Python |
f0b32783f01d8e37ce9f68a24af93e003bf30933 | 225 | 2021-02-01 13:11:04-08:00 | 28,800 | ['bdfb9f19c4086a60ef010d2431768850c26d838a'] | Start disabling certbot-auto upgrades (#8623)
* add amazon linux to auto targets
* disable updates outside of debian and rhel
* test certbot-auto with disabled upgrades
* try new approach to testing
* remove bad space
* tweak error text
* add changelog entry
* fix bad certbot-auto commit
* tes... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,6 +15,11 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n every certificate in the chain.\n See [#8577](https://github.com/certbot/certbot/issues/8577).\n * Support for ... | Python |
df866b907b4d5eaecb110d784b858d50a1726c9e | 288 | 2021-02-02 10:58:41-08:00 | 28,800 | ['f0b32783f01d8e37ce9f68a24af93e003bf30933'] | Update changelog for 1.12.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.12.0 - master\n+## 1.12.0 - 2021-02-02\n \n ### Added\n \n'}] | Python |
57cba3690dfce7b324ed46bb544ee75e03f1f7f8 | 288 | 2021-02-02 11:06:47-08:00 | 28,800 | ['786a130b7d821f38fc1873ede5fd5ce4d99bbd28'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.13.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
13af3f7ec21a689a6235006d2f97664bc8789a5f | 225 | 2021-02-03 12:03:09-08:00 | 28,800 | ['5ad0c254cacd58395b888fe23f6046881500b854'] | Cleanup venv scripts (#8629)
Fixes https://github.com/certbot/certbot/issues/8387.
* update _venv_common.py
* delete venv.py scripts
* rename venv script
* update relevant venv3 references
* remove set_python_envvars | [{'old_path': '.dockerignore', 'new_path': '.dockerignore', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,5 +8,4 @@\n .git\n .tox\n venv\n-venv3\n docs\n'}, {'old_path': '.envrc', 'new_path': '.envrc', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -3,7 +3,7 @@\n # activated and then deactivated when you cd e... | Python |
666ee35e29e803e395b9235058ecebe8b5e9b56a | 225 | 2021-02-04 21:04:03+11:00 | 28,800 | ['13af3f7ec21a689a6235006d2f97664bc8789a5f'] | remove crufty pytest warning (#8638) | [{'old_path': 'pytest.ini', 'new_path': 'pytest.ini', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,8 +2,6 @@\n # settings we want to also change there must be added to the release script\n # directly.\n [pytest]\n-# In general, all warnings are treated as errors. Here are the exceptions:\n-# 1- decodestring: ... | Python |
c2ee0d29382d9613cc3a8d4cee6cb4aa3ce239c4 | 225 | 2021-02-05 15:33:45-08:00 | 28,800 | ['c668172ef0844ebd641575aeac865d91c59eaa8e'] | Remove requests[security] dependency (#8626)
Fixes https://github.com/certbot/certbot/issues/7901.
* stop using requests[security]
* add changelog entry
* remove unused import | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -6,7 +6,6 @@ from email.utils import parsedate_tz\n import heapq\n import logging\n import re\n-import sys\n import time\n \n import josepy as jose\n@@ -30,17 +29,6 @@ from acme.mixins import Versio... | Python |
711cc95dc466c569c120bd7fcda8e67c135cb101 | 225 | 2021-02-05 15:51:18-08:00 | 28,800 | ['c2ee0d29382d9613cc3a8d4cee6cb4aa3ce239c4'] | Remove mock dependency (#8630)
Fixes https://github.com/certbot/certbot/issues/7913.
I only added the deprecation warning to `certbot.tests.util` because that's the only place where I think someone could be using the `mock` module through our API.
* remove external mock from acme
* update Certbot's mock usage... | [{'old_path': 'acme/setup.py', 'new_path': 'acme/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,7 +1,5 @@\n-from distutils.version import LooseVersion\n import sys\n \n-from setuptools import __version__ as setuptools_version\n from setuptools import find_packages\n from setuptools import setup\n \n@@ ... | Python |
2a16aa16c37308dd0e357d96b51d2b0ffb36add8 | 146 | 2021-02-07 18:19:49+11:00 | 28,800 | ['711cc95dc466c569c120bd7fcda8e67c135cb101'] | Update cli.ini (#8603)
* Update cli.ini
Sharing back some extended examples I desired, did not find, and derived on my own
* Update cli.ini
Alex,
ok - simplified as requested
Matt
* Update cli.ini
removed trailing quote on line 32
* Update certbot/examples/cli.ini
Co-authored-by: alexzorin <ale... | [{'old_path': 'certbot/examples/cli.ini', 'new_path': 'certbot/examples/cli.ini', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,3 +24,11 @@ rsa-key-size = 4096\n # path to the public_html / webroot folder being served by your web server.\n # authenticator = webroot\n # webroot-path = /usr/share/nginx/html\n+\n+... | Python |
edad9bd82b11e2e6fdc2bfd633e8c790e0da23d7 | 605 | 2021-02-09 11:29:31+01:00 | 21,600 | ['2a16aa16c37308dd0e357d96b51d2b0ffb36add8'] | Fix Sphinx manpage Building (#8646)
* certbot docs: include & orphan 'man/cerbot.rst'; fixes manpage building
* acme docs: include & orphan 'man/jws.rst'; fixes manpage building | [{'old_path': 'acme/docs/conf.py', 'new_path': 'acme/docs/conf.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -87,7 +87,6 @@ language = 'en'\n # directories to ignore when looking for source files.\n exclude_patterns = [\n '_build',\n- 'man/*'\n ]\n \n # The reST default role (used for this markup: `text... | Python |
3d0dad8718e3b1904c1acb7da530a08053ced08f | 225 | 2021-02-09 11:43:15-08:00 | 28,800 | ['edad9bd82b11e2e6fdc2bfd633e8c790e0da23d7'] | Remove dependency on six (#8650)
Fixes https://github.com/certbot/certbot/issues/8494.
I left the `six` dependency pinned in `tests/letstest/requirements.txt` and `tools/oldest_constraints.txt` because `six` is still a transitive dependency with our current pinnings.
The extra moving around of imports is due to ... | [{'old_path': '.pylintrc', 'new_path': '.pylintrc', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -254,7 +254,7 @@ ignore-mixin-members=yes\n # List of module names for which member attributes should not be checked\n # (useful for modules/projects where namespaces are manipulated during runtime\n # and thus existin... | Python |
cf062f4c6dd7642cf124f5e7279fdc3f6ded063b | 600 | 2021-02-09 12:18:29-08:00 | -3,600 | ['3d0dad8718e3b1904c1acb7da530a08053ced08f'] | Fix ubuntu package name (#8654)
Since Ubuntu 18.04 there is python3-certbot-apache which should be the recommended version.
The Debian package names should probably be updated accordingly. | [{'old_path': 'certbot/docs/install.rst', 'new_path': 'certbot/docs/install.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -191,7 +191,7 @@ Optionally to install the Certbot Apache plugin, you can use:\n \n .. code-block:: shell\n \n- sudo apt-get install python-certbot-apache\n+ sudo apt-get install pytho... | Python |
c59775c3c069ce7106eca63e8f16294d99fbb021 | 166 | 2021-02-10 15:17:51-08:00 | -3,600 | ['cf062f4c6dd7642cf124f5e7279fdc3f6ded063b'] | Disable certbot-auto upgrade on RHEL-like systems (#8653)
Fixes #8637
* Disable upgrade for RHEL-like systems
* Remove letstest on Amazon Linux
* Update changelog | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -18,6 +18,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n which was needed to support SNI in TLS requests when using old versions of\n Python 2.\n * Certbot and all of it... | Python |
c0eccdd35845161ced2ba56f77131c05ae2634fd | 166 | 2021-02-12 16:14:46-08:00 | -3,600 | ['c59775c3c069ce7106eca63e8f16294d99fbb021'] | Deprecate certbot-auto specific flags (#8641)
This PR deprecates the certbot-auto specific CLI flags, in the perspective of removing them in a future release as said in #8483.
* Deprecate certbot-auto specific flags
* Update changelog
* Clean tests
Co-authored-by: Brad Warren <bmw@users.noreply.github.com> | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -10,6 +10,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Changed\n \n+* CLI flags `--os-packages-only`, `--no-self-upgrade`, `--no-bootstrap` and `--no-permissions-ch... | Python |
ef265eccaf125a51a8c260d28e2f501e1c3111dc | 440 | 2021-02-22 09:23:42+11:00 | -3,600 | ['c0eccdd35845161ced2ba56f77131c05ae2634fd'] | Remove import fallback for collections.abc (#8674) | [{'old_path': 'acme/acme/messages.py', 'new_path': 'acme/acme/messages.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,5 +1,6 @@\n """ACME protocol messages."""\n import json\n+from collections.abc import Hashable\n \n import josepy as jose\n \n@@ -10,13 +11,6 @@ from acme import jws\n from acme import util\n... | Python |
0f3f07b5cb3bf1d2c3d8834a83022fd11d7566fc | 440 | 2021-02-22 09:34:56+11:00 | -3,600 | ['ef265eccaf125a51a8c260d28e2f501e1c3111dc'] | Removed backport of unittest.assertLogs (#8673)
* Removed backport of unittest.assertLogs
* Update parser_test.py | [{'old_path': 'certbot-nginx/tests/test_log_util.py', 'new_path': None, 'type': <ModificationType.DELETE: 4>, 'diff': '@@ -1,125 +0,0 @@\n-"""Backport for `TestCase.assertLogs()`.\n-\n-Most of the idea and code are from CPython implementation.\n-https://github.com/python/cpython/blob/b76518d43fb82ed9e5d27025d18c90a23d5... | Python |
c43f4fe518b48465b5cb886f2b1df1f3aed17616 | 225 | 2021-02-23 13:20:04-08:00 | 28,800 | ['0f3f07b5cb3bf1d2c3d8834a83022fd11d7566fc'] | upgrade to 3.8.8 (#8682)
Fixes https://github.com/certbot/certbot/issues/8681. https://python-security.readthedocs.io/vuln/ctypes-buffer-overflow-pycarg_repr.html is the best resource I found linking to the original Python bug, when each Python branch was fixed, etc. | [{'old_path': 'windows-installer/construct.py', 'new_path': 'windows-installer/construct.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -9,7 +9,7 @@ import sys\n import tempfile\n import time\n \n-PYTHON_VERSION = (3, 8, 6)\n+PYTHON_VERSION = (3, 8, 8)\n PYTHON_BITNESS = 32\n PYWIN32_VERSION = 300 # do not for... | Python |
c3d6fca3eb1f24616bb784865662adfa048f9bf9 | 166 | 2021-02-23 15:29:52-08:00 | -3,600 | ['c43f4fe518b48465b5cb886f2b1df1f3aed17616'] | Make certbot constraint file independent from certbot-auto + update cryptography (#8649)
* Refactor to not depend on certbot-auto dependencies pinning anymore
* Update constraints
* Replaces references
* Upgrade AWS dependencies pinning
* Fix script
* Fix Windows installer builds
* Fixing sdists lets... | [{'old_path': 'snap/snapcraft.yaml', 'new_path': 'snap/snapcraft.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -85,7 +85,7 @@ parts:\n snapcraftctl build\n override-pull: |\n snapcraftctl pull\n- python3 "${SNAPCRAFT_PART_SRC}/tools/strip_hashes.py" "${SNAPCRAFT_PART_SRC}/letsencrypt-aut... | Python |
ae3ed200c09f2d1913ec69c33a2604ae1fe32eb5 | 288 | 2021-02-24 14:51:57-08:00 | 28,800 | ['c3d6fca3eb1f24616bb784865662adfa048f9bf9'] | Remove check for 'fake' in issuer name when renewing certs (#8685)
Fixes #8680.
We seem to have no existing testing code anywhere in this vicinity, so figured I'd get this up quickly then work on that. Manual tests (renew staging certificate, should allow it; renew non-staging cert as staging, should error) passed.... | [{'old_path': 'certbot/certbot/_internal/renewal.py', 'new_path': 'certbot/certbot/_internal/renewal.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -312,12 +312,9 @@ def _avoid_invalidating_lineage(config, lineage, original_server):\n contents = the_file.read()\n latest_cert = OpenSSL.crypto.load_ce... | Python |
025eb16c7a07b5ed3286a17c7a53bb00020b657c | 181 | 2021-02-25 10:22:40-08:00 | -39,600 | ['ae3ed200c09f2d1913ec69c33a2604ae1fe32eb5'] | docs: rewrite "Revoking certificates" (#8657)
* docs: rewrite "Revoking certificates"
- `--cert-name` is supported since a long time ago
- `--delete-after-revoke` is default
- Mention that non-default `--server` must be specified
- Document difference between acme key/cert key revocation methods
- Reshuffle tex... | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -474,29 +474,37 @@ like\n Revoking certificates\n ---------------------\n \n-If your account key has been compromised or you otherwise need to revoke a certificate,\n-use the ``revoke`` comman... | Python |
f71298f6614078454532f82aeafbe5d06d3a7cdb | 181 | 2021-02-25 11:32:21-08:00 | -39,600 | ['025eb16c7a07b5ed3286a17c7a53bb00020b657c'] | cli: make key_path and cert_path always be a str (#8687)
There is some code in [`_paths_parser`](https://github.com/certbot/certbot/blob/ae3ed200c09f2d1913ec69c33a2604ae1fe32eb5/certbot/certbot/_internal/cli/paths_parser.py#L17-L34) which has the effect of varying the value type of `config.cert_path` and `config.key_p... | [{'old_path': 'certbot/certbot/_internal/cert_manager.py', 'new_path': 'certbot/certbot/_internal/cert_manager.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -223,7 +223,7 @@ def cert_path_to_lineage(cli_config):\n """\n acceptable_matches = _acceptable_matches()\n match = match_and_check_overlaps(c... | Python |
e742cfaa21176f1f5a3e43c8022b9c899bc5c205 | 225 | 2021-02-26 08:39:55+11:00 | 28,800 | ['f71298f6614078454532f82aeafbe5d06d3a7cdb'] | dont set required to False (#8689) | [{'old_path': 'certbot/certbot/_internal/cli/paths_parser.py', 'new_path': 'certbot/certbot/_internal/cli/paths_parser.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -20,8 +20,6 @@ def _paths_parser(helpful):\n }\n if verb == "certonly":\n cpkwargs["default"] = flag_default("auth_cert_path")\n- ... | Python |
135187f03e18eebcb32b05c4ecb76a4552aed883 | 440 | 2021-02-25 14:50:54-08:00 | -3,600 | ['e742cfaa21176f1f5a3e43c8022b9c899bc5c205'] | Python 3 obsoletes explicit __ne__ methods (#8676)
This shouldn't be needed as of Python 3+.
https://stackoverflow.com/questions/4352244/should-ne-be-implemented-as-the-negation-of-eq-in-python#30676267 | [{'old_path': 'acme/acme/messages.py', 'new_path': 'acme/acme/messages.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -150,9 +150,6 @@ class _Constant(jose.JSONDeSerializable, Hashable): # type: ignore\n def __hash__(self):\n return hash((self.__class__, self.name))\n \n- def __ne__(self, other)... | Python |
67c2b27af7d7dc04c246be4f9a1d4cd29a3099ca | 440 | 2021-02-25 14:59:00-08:00 | -3,600 | ['135187f03e18eebcb32b05c4ecb76a4552aed883'] | Stop inheriting from object. It's unneeded on Python 3+. (#8675) | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -33,7 +33,7 @@ DEFAULT_NETWORK_TIMEOUT = 45\n DER_CONTENT_TYPE = \'application/pkix-cert\'\n \n \n-class ClientBase(object):\n+class ClientBase:\n """ACME client base object.\n \n :ivar mess... | Python |
b0e35c694e3741cb7f9c581ec25f2be1c406b53a | 440 | 2021-02-25 14:59:11-08:00 | -3,600 | ['67c2b27af7d7dc04c246be4f9a1d4cd29a3099ca'] | Remove import fallback of urllib2 in tests/modification-check. (#8677) | [{'old_path': 'tests/modification-check.py', 'new_path': 'tests/modification-check.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,11 +7,8 @@ import shutil\n import subprocess\n import sys\n import tempfile\n-\n-try:\n from urllib.request import urlretrieve\n-except ImportError:\n- from urllib import urlre... | Python |
540fd6db93db317ffbeba6d210b92dd830255715 | 440 | 2021-02-25 15:41:05-08:00 | -3,600 | ['b0e35c694e3741cb7f9c581ec25f2be1c406b53a'] | Dictionaries are ordered by insert by default on Python 3.6. (#8678) | [{'old_path': 'certbot/certbot/_internal/plugins/disco.py', 'new_path': 'certbot/certbot/_internal/plugins/disco.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,5 +1,4 @@\n """Utilities for plugins discovery and selection."""\n-import collections\n import itertools\n import logging\n import sys\n@@ -209,7 +20... | Python |
d3ca6af9824d4715f4312724e32a26c270696db8 | 674 | 2021-02-25 16:30:48-08:00 | -32,400 | ['540fd6db93db317ffbeba6d210b92dd830255715'] | Insert new line before "More details about these changes can be found on our GitHub repo." (#8645)
Fixing #8634. It's my first time contributing to this repository, if there's something wrong please let me know.
Before this fix
```
$ python3 extract_changelog.py 1.12.0
...
### Fixed
* Fixed the apache compon... | [{'old_path': 'tools/extract_changelog.py', 'new_path': 'tools/extract_changelog.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -24,7 +24,7 @@ def main():\n i = 0\n while i < len(lines):\n if section_pattern.match(lines[i]):\n- i = i + 1\n+ i = i + 2\n while i <... | Python |
fab9bfd878952baf98c5e3098db5f975399e0479 | 181 | 2021-02-26 13:43:22-08:00 | -39,600 | ['d3ca6af9824d4715f4312724e32a26c270696db8'] | nginx: authenticate all matching vhosts for HTTP01 (#8663)
* nginx: authenticate all matching vhosts for HTTP01
Previously, the nginx authenticator would set up the HTTP-01 challenge
response on a single HTTP vhost which matched the challenge domain.
The nginx authenticator will now set the challenge response o... | [{'old_path': 'certbot-nginx/certbot_nginx/_internal/configurator.py', 'new_path': 'certbot-nginx/certbot_nginx/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,3 +1,4 @@\n+# pylint: disable=too-many-lines\n """Nginx Configuration"""\n from distutils.version import LooseVersion\n import ... | Python |
496a4ced2560686bf5dc6769c90406ea66fea4e5 | 225 | 2021-02-26 16:05:34-08:00 | 28,800 | ['fab9bfd878952baf98c5e3098db5f975399e0479'] | Remove broken test for typing import failure (#8692)
* remove broken test
* fix coverage
* don't worry about getattr test | [{'old_path': 'acme/acme/magic_typing.py', 'new_path': 'acme/acme/magic_typing.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,16 +1,14 @@\n-"""Shim class to not have to depend on typing module in prod."""\n-import sys\n+"""Simple shim around the typing module.\n+\n+This was useful when this code supported Py... | Python |
1e307230038ba0e92dfe06ecfef4e22d135370d4 | 181 | 2021-03-01 12:56:22-08:00 | -39,600 | ['496a4ced2560686bf5dc6769c90406ea66fea4e5'] | revoke: try determine the server automatically (#8691)
* revoke: try determine the server automatically
When revoking via --cert-name, use the server from the lineage (unless
overriden by the CLI).
* RenewableCert.storage might be None
* guard against an empty lineage server | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -21,6 +21,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n Python 2.\n * Certbot and all of its components no longer depend on the library `six`.\n * The update of certbot-a... | Python |
976068b5a09a4856d95dc9e408d5578b6058b963 | 288 | 2021-03-02 13:37:04-08:00 | 28,800 | ['1e307230038ba0e92dfe06ecfef4e22d135370d4'] | Update changelog for 1.13.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.13.0 - master\n+## 1.13.0 - 2021-03-02\n \n ### Added\n \n'}] | Python |
4d6db0eb71eb0efde7a84d91adddb70efc9b7449 | 288 | 2021-03-02 13:50:03-08:00 | 28,800 | ['92a66454b6ece097a987621031b16b1fb2f490fd'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.14.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
a3abcc001a1dff41a6ecd90f779cf038e2f32cc9 | 440 | 2021-03-04 08:10:56+11:00 | -3,600 | ['9643e85b4c65c755afe885914500ff439210f688'] | Removed a Python 2 fallback in certbot.Reverter. (#8694)
* Removed a Python 2 fallback in certbot.Reverter.
* Removed a Python < 3.6 fallback in certbot-apache._internal.parser. | [{'old_path': 'certbot-apache/certbot_apache/_internal/parser.py', 'new_path': 'certbot-apache/certbot_apache/_internal/parser.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,8 +3,6 @@ import copy\n import fnmatch\n import logging\n import re\n-import sys\n-\n \n from acme.magic_typing import Dict\n from acme... | Python |
94dc6936e73114ac4adc5f766d06f6c3cc9f67e8 | 225 | 2021-03-05 14:14:32-08:00 | 28,800 | ['a3abcc001a1dff41a6ecd90f779cf038e2f32cc9'] | Final update to certbot-auto (#8706)
Fixes https://github.com/certbot/certbot/issues/8690.
After this PR, we'll let the release script make its automated changes to certbot-auto as part of the 1.14.0 release and then never make any code changes to certbot-auto ever again!
* disable upgrades on debian
* update... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,7 +10,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Changed\n \n-*\n+* certbot-auto no longer checks for updates on any operating system.\n \n ### Fixed\n \n'}, ... | Python |
c02b2d30f2535a254020184912a94c6ed19b5026 | 440 | 2021-03-05 16:53:20-08:00 | -3,600 | ['94dc6936e73114ac4adc5f766d06f6c3cc9f67e8'] | Removed Python legacy __future__ imports (#8697)
There are still some left, but the `modification_check` test fails. Some are still in `tools`, and they can probably be removed as well. `with_statement` was introduced officially in Python 2.5, so there's really old stuff in the code base. | [{'old_path': 'certbot-ci/certbot_integration_tests/assets/hook.py', 'new_path': 'certbot-ci/certbot_integration_tests/assets/hook.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,5 +1,4 @@\n #!/usr/bin/env python\n-from __future__ import print_function\n import os\n import sys\n \n'}, {'old_path': 'certbot-ci... | Python |
76895457c9f5956ec97ccadc3e0d7e894db17094 | 181 | 2021-03-09 15:56:51-08:00 | -39,600 | ['c02b2d30f2535a254020184912a94c6ed19b5026'] | dns-digitalocean: use a 30 second TTL (#8693)
Fixes an issue with long TTLs and caching behavior on DigitalOcean's
DNS hosting service. | [{'old_path': 'certbot-dns-digitalocean/certbot_dns_digitalocean/_internal/dns_digitalocean.py', 'new_path': 'certbot-dns-digitalocean/certbot_dns_digitalocean/_internal/dns_digitalocean.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -21,6 +21,7 @@ class Authenticator(dns_common.DNSAuthenticator):\n \n desc... | Python |
67b65bb2c0b5fee3b97ae2e94649e8ef28fcbd74 | 166 | 2021-03-09 16:12:32-08:00 | -3,600 | ['76895457c9f5956ec97ccadc3e0d7e894db17094'] | Deprecate acme.typing_magic module, stop using it in certbot (#8643)
* Deprecate acme.magic_typing, stop to use it in certbot
* Isort
* Add a changelog entry
Co-authored-by: Brad Warren <bmw@users.noreply.github.com> | [{'old_path': 'acme/acme/challenges.py', 'new_path': 'acme/acme/challenges.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,14 +8,15 @@ import socket\n \n from cryptography.hazmat.primitives import hashes # type: ignore\n import josepy as jose\n-import requests\n-from OpenSSL import SSL # type: ignore # http... | Python |
f2d8c81e9b8165a37c27641a49b447e55921147e | 225 | 2021-03-09 16:53:44-08:00 | 28,800 | ['67b65bb2c0b5fee3b97ae2e94649e8ef28fcbd74'] | remove reference to acme.magic_typing from docs (#8709) | [{'old_path': 'certbot/docs/contributing.rst', 'new_path': 'certbot/docs/contributing.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -478,13 +478,6 @@ to start contributing to Certbot.\n \n To run mypy on Certbot, use ``tox -e mypy`` on a machine that has Python 3 installed.\n \n-Note that instead of just impo... | Python |
dd6f2f565e8183b69ff3abf5d965d0d1575b2e5e | 166 | 2021-03-10 11:51:27-08:00 | -3,600 | ['f2d8c81e9b8165a37c27641a49b447e55921147e'] | Convert Python 2 type hints to Python 3 types annotations (#8640)
Fixes #8427
This PR converts the Python 2 types hints into Python 3 types annotations. I have used the project https://github.com/ilevkivskyi/com2ann which has been designed for that specific purpose and did that very well.
The only remaining thin... | [{'old_path': 'acme/acme/challenges.py', 'new_path': 'acme/acme/challenges.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,7 +24,7 @@ logger = logging.getLogger(__name__)\n class Challenge(jose.TypedJSONObjectWithFields):\n # _fields_to_partial_json\n """ACME challenge."""\n- TYPES = {} # type: d... | Python |
0962b0fc8346fd948b5a6847fb4f6f0dc90da8a6 | 166 | 2021-03-11 13:08:20-08:00 | -3,600 | ['dd6f2f565e8183b69ff3abf5d965d0d1575b2e5e'] | Kill current snapcraft build when a "Chroot problem" is encountered (#8442)
* Kill snapcraft build when a "Chroot problem" is encountered
* Display specific helper for "Chroot problem" status and cancel retry mechanism in this case.
* Isolate build tmp directories
* Configure XDG_CACHE_HOME
* Kill snapcraf... | [{'old_path': 'tools/snap/build_remote.py', 'new_path': 'tools/snap/build_remote.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -5,6 +5,8 @@ import glob\n from multiprocessing import Manager\n from multiprocessing import Pool\n from multiprocessing import Process\n+from multiprocessing.managers import SyncManag... | Python |
bc892e04c4e05b1b57f59179b7b465f7f981a176 | 166 | 2021-03-11 13:17:41-08:00 | -3,600 | ['0962b0fc8346fd948b5a6847fb4f6f0dc90da8a6'] | Fixing imports in cli module (#8708)
While working on #8640, I realized that there were some hidden circular dependencies in certbot._internal.cli package. Then cerbot could break if the order of these imports changes.
This PR fixes that and apply isort on top of the result. | [{'old_path': 'certbot/certbot/_internal/cli/__init__.py', 'new_path': 'certbot/certbot/_internal/cli/__init__.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,65 +1,51 @@\n """Certbot command line argument & config processing."""\n # pylint: disable=too-many-lines\n+import argparse\n import logging\n import l... | Python |
2324c1bb7ad977bc3525ebef1a3f61410e0e245f | 225 | 2021-03-15 14:10:44-07:00 | 25,200 | ['bc892e04c4e05b1b57f59179b7b465f7f981a176'] | Update installing from source instructions (#8713) | [{'old_path': 'certbot/docs/install.rst', 'new_path': 'certbot/docs/install.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -270,15 +270,10 @@ Disable and remove the swapfile once the virtual environment is constructed::\n user@webserver:~$ sudo swapoff /tmp/swapfile\n user@webserver:~$ sudo rm /tmp/swapfil... | Python |
1b39d3dc478ee8df1e39ec6c8ed1e44edcca7409 | 225 | 2021-03-16 17:53:43-07:00 | 25,200 | ['2324c1bb7ad977bc3525ebef1a3f61410e0e245f'] | switch to wait_until_running (#8715) | [{'old_path': 'tests/letstest/multitester.py', 'new_path': 'tests/letstest/multitester.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -190,18 +190,16 @@ def block_until_ssh_open(ipstring, wait_time=10, timeout=120):\n t_elapsed += wait_time\n sock.close()\n \n-def block_until_instance_ready(boot... | Python |
40ae5d939ee0449ce54b8bf12e75e9311e361d91 | 288 | 2021-03-19 14:27:29-07:00 | 25,200 | ['1b39d3dc478ee8df1e39ec6c8ed1e44edcca7409'] | Fix linux-py39-cover test (#8720)
* update setuptools
* upgrade Markupsafe | [{'old_path': 'tools/dev_constraints.txt', 'new_path': 'tools/dev_constraints.txt', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -56,7 +56,7 @@ jsonschema==2.6.0\n lazy-object-proxy==1.4.3\n logger==1.4\n logilab-common==1.4.1\n-MarkupSafe==1.0\n+MarkupSafe==1.1.1\n mccabe==0.6.1\n more-itertools==5.0.0\n msrest==... | Python |
6bc8b3d2ba9a0f22a6682a46ae4905c462e19388 | 166 | 2021-03-22 08:39:54+11:00 | -3,600 | ['40ae5d939ee0449ce54b8bf12e75e9311e361d91'] | Precise the certificate naming convention mechanism in the compatibility document (#8652)
* Precise the certificate naming convention mechanism in a note.
* Add certificate name convention in user guide, refer to it in compatibility page.
* Update certbot/docs/compatibility.rst
Co-authored-by: alexzorin <alex... | [{'old_path': 'certbot/docs/compatibility.rst', 'new_path': 'certbot/docs/compatibility.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -21,9 +21,9 @@ may change at any time. The second is that Certbot's behavior should only be\n considered stable with certain files but not all. Files with which users should\n ... | Python |
ae2247163e42934c0486c36079bc7ae50bc4d4e2 | 325 | 2021-03-22 08:42:23+11:00 | -3,600 | ['6bc8b3d2ba9a0f22a6682a46ae4905c462e19388'] | Remove empty lines from `certbot certificates` when (#8723)
.. envoked with `--cert-name` or `-d`. | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -17,7 +17,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Fixed\n \n-*\n+* Don't output an empty line for a hidden certificate when `certbot certificates` is being use... | Python |
84178e27737205fe547983b8214894dabba48026 | 166 | 2021-03-22 10:39:09-07:00 | -3,600 | ['ae2247163e42934c0486c36079bc7ae50bc4d4e2'] | Do not reuse existing builds on Launchpad when executing snapcraft remote-build (#8719)
We observed recently several unexpected behavior during the execution of snap jobs in Azure. In particular it seems that `snapcraft remote-build` is tending to reattach to the latest builds on Launchpad triggered by the nightly bui... | [{'old_path': 'tools/snap/build_remote.py', 'new_path': 'tools/snap/build_remote.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -13,6 +13,7 @@ from os.path import exists\n from os.path import join\n from os.path import realpath\n import re\n+import shutil\n import subprocess\n import sys\n import tempfile\n@@ -... | Python |
9fdb24331c463d08666aecfbb694418945c86bc9 | 181 | 2021-03-22 15:05:37-07:00 | -39,600 | ['84178e27737205fe547983b8214894dabba48026'] | docs: rewrite "Automated Renewals" in User Guide (#8717) | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -515,11 +515,8 @@ Renewing certificates\n days). Make sure you renew the certificates at least once in 3\n months.\n \n-.. seealso:: Many of the certbot clients obtained through a\n- d... | Python |
54b0b98988ec3dbc28cefe69bae627eecb347235 | 225 | 2021-03-23 11:29:01-07:00 | 25,200 | ['9fdb24331c463d08666aecfbb694418945c86bc9'] | use worker terminology (#8728)
This will be needed for me to update `pytest-xdist` as part of https://github.com/certbot/certbot/issues/8705 since `pytest-xdist` removed the "slave" terminology. See https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst#deprecations-and-removals. | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/context.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/context.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -12,9 +12,9 @@ class IntegrationTestsContext:\n def __init__(self, request):\n self.request = request\... | Python |
1d7ddb0c0c1b587d56c6cce1d45ae1edceed7254 | 225 | 2021-03-23 13:01:01-07:00 | 25,200 | ['54b0b98988ec3dbc28cefe69bae627eecb347235'] | fix pylint (#8729) | [{'old_path': '.pylintrc', 'new_path': '.pylintrc', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,7 +8,10 @@ jobs=0\n \n # Python code to execute, usually for sys.path manipulation such as\n # pygtk.require().\n-#init-hook=\n+# CERTBOT COMMENT\n+# This is needed for pylint to import linter_plugin.py since\n+# ht... | Python |