Search is not available for this dataset
hash string | author int32 | committer_date string | timezone int64 | parents string | message string | changes string | language string |
|---|---|---|---|---|---|---|---|
a105b587ac042ea2b129bed42cf47586b59818c6 | 181 | 2021-07-15 11:12:14-07:00 | -36,000 | ['8e29063ba7e110ecf8e43372f2bde8fbd1e82afe'] | apache: fix crash when authenticating empty vhosts (#8941)
Fixes #8940. | [{'old_path': 'certbot-apache/certbot_apache/_internal/parser.py', 'new_path': 'certbot-apache/certbot_apache/_internal/parser.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -440,7 +440,11 @@ class ApacheParser:\n :type args: list or str\n """\n first_dir = aug_conf_path + "/directive[1]... | Python |
bebd3994885dc26509e047dbde6b33de8efab26c | 181 | 2021-07-16 08:50:16+10:00 | -36,000 | ['a105b587ac042ea2b129bed42cf47586b59818c6'] | acme: deprecate ACMEv1 client classes (#8931)
* acme: deprecate ACMEv1 client classes
Adds pending deprecations to:
- acme.client.Client
- acme.client.BackwardsCompatibleClientV2
Adds a warning to Certbot when a v1 server is detected.
* move thsi change from 1.17 to 1.18
* revert some whitespace changes | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -14,6 +14,7 @@ from typing import List\n from typing import Set\n from typing import Text\n from typing import Union\n+import warnings\n \n import josepy as jose\n import OpenSSL\n@@ -224,6 +225,9 @... | Python |
10eecf9c978ce909f6965de5d82cea39a720facc | 166 | 2021-07-19 17:09:06-07:00 | -7,200 | ['bebd3994885dc26509e047dbde6b33de8efab26c'] | Deprecate zope.component in favor of an direct calls to functions from `certbot.display.util` module (#8835)
* Implement certbot services
* Various fixes
* Local oldest requirements
* Clean imports
* Add unit tests for certbot.services
* Clean code
* Protect against nullity of global services
* Fi... | [{'old_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'new_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,7 +15,6 @@ from typing import Optional\n from typing import Set\n from typing import Union\n \n-import zope.component\n im... | Python |
08839758bd80015377e8aaf61361f1c091d4c98f | 225 | 2021-07-22 12:00:30-07:00 | 25,200 | ['10eecf9c978ce909f6965de5d82cea39a720facc'] | Finish pinning system rewrite (#8934)
* add oldest pyproject.toml file that works
* make single oldest_constraints.txt file
* remove unused merge_requirements.py
* remove unused import
* make conditional right
* simplify pip_install.py
* fix typo
* bump min dns-lexicon dependency
* fix zope imp... | [{'old_path': 'acme/setup.py', 'new_path': 'acme/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -14,7 +14,7 @@ install_requires = [\n 'PyOpenSSL>=17.3.0',\n 'pyrfc3339',\n 'pytz',\n- 'requests>=2.6.0',\n+ 'requests>=2.14.2',\n 'requests-toolbelt>=0.3.0',\n 'setuptools>=39.0.1',\n... | Python |
8133d3e70a6487c819d69c660620d7f2b754c952 | 166 | 2021-07-29 11:25:25-07:00 | -7,200 | ['08839758bd80015377e8aaf61361f1c091d4c98f'] | Fix python-augeas failure on Windows (v2) (#8951)
This PR is a new approach for fixing #8732 based on the discussions occurred in the first PR #8877.
This PR upgrades python-augeas to the latest version, and avoids tests failure of Windows because of this upgrade. To do so it leverages the [tox multi-platform featu... | [{'old_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,11 +15,11 @@ jobs:\n windows-py36:\n IMAGE_NAME: vs2017-win2016\n PYTHON_VERSION: 3.6\n- ... | Python |
979e21dcbf11665f7839628cfae62e28fd2683df | 166 | 2021-07-29 13:45:29-07:00 | -7,200 | ['8133d3e70a6487c819d69c660620d7f2b754c952'] | Reimplement Certbot zope.interfaces into abstract base classes (#8950)
* Implement certbot services
* Various fixes
* Local oldest requirements
* Clean imports
* Add unit tests for certbot.services
* Clean code
* Protect against nullity of global services
* Fix CLI
* Fix tests
* Consistent t... | [{'old_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'new_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,8 +15,6 @@ from typing import Optional\n from typing import Set\n from typing import Union\n \n-import zope.interface\n-\n... | Python |
f9ef8941419e1f6007b7d0f51dcf3146271d839c | 225 | 2021-08-01 12:15:01+10:00 | 25,200 | ['979e21dcbf11665f7839628cfae62e28fd2683df'] | update snapcraft.cfg comment (#8959) | [{'old_path': '.azure-pipelines/templates/stages/deploy-stage.yml', 'new_path': '.azure-pipelines/templates/stages/deploy-stage.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -19,11 +19,12 @@ stages:\n # Then the file was added as a secure file in Azure pipelines\n # with the name snapcraft.cfg by ... | Python |
1dabddeb85456592746b9c4720645334118cae33 | 225 | 2021-08-02 11:59:07-07:00 | 25,200 | ['f9ef8941419e1f6007b7d0f51dcf3146271d839c'] | make display classes implement IDisplay (#8963) | [{'old_path': 'certbot/certbot/_internal/display/obj.py', 'new_path': 'certbot/certbot/_internal/display/obj.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -33,6 +33,9 @@ class _DisplayService:\n _SERVICE = _DisplayService()\n \n \n+# This use of IDisplay can be removed when this class is no longer accessible\n... | Python |
523f8f5e65486c6c3d90771ed5c1e7d578f12056 | 181 | 2021-08-02 15:39:07-07:00 | -36,000 | ['1dabddeb85456592746b9c4720645334118cae33'] | stop using deprecated distro.linux_distribution (#8961)
`distro.linux_distribution` was deprecated (https://github.com/python-distro/distro/pull/296) in the release of `distro` at the end of last week. The deprecation is causing the `nopin` nightly tests to fail.
This change migrates Certbot off that function.
A... | [{'old_path': 'certbot/certbot/util.py', 'new_path': 'certbot/certbot/util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -390,13 +390,14 @@ def get_python_os_info(pretty=False):\n os_type, os_ver, _ = info\n os_type = os_type.lower()\n if os_type.startswith('linux') and _USE_DISTRO:\n- info ... | Python |
bdc48e6a3243a7dca78720acfba9fdc0582a644e | 181 | 2021-08-02 16:15:46-07:00 | -36,000 | ['523f8f5e65486c6c3d90771ed5c1e7d578f12056'] | snap: workaround for snapctl crash in plugin hook (#8955)
* snap: workaround for snapctl crash in plugin hook
* test functionality, not existence | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -40,6 +40,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n * The Apache authenticator no longer crashes with "Unable to insert label"\n when encountering a completely emp... | Python |
1129d850d3257deae1c5de5b35c35c873d1fca7c | 225 | 2021-08-03 10:35:00+10:00 | 25,200 | ['bdc48e6a3243a7dca78720acfba9fdc0582a644e'] | add chardet dep (#8965) | [{'old_path': 'acme/setup.py', 'new_path': 'acme/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -6,6 +6,10 @@ from setuptools import setup\n version = '1.18.0.dev0'\n \n install_requires = [\n+ # This dependency just exists to ensure that chardet is installed along\n+ # with requests so it will use ... | Python |
5c3c682b6e577087e7a808d235b1fec4b250cb6e | 288 | 2021-08-03 13:12:59-07:00 | 25,200 | ['1129d850d3257deae1c5de5b35c35c873d1fca7c'] | Update changelog for 1.18.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.18.0 - master\n+## 1.18.0 - 2021-08-03\n \n ### Added\n \n'}] | Python |
06698ad95ff4033ca65f619cbe079db17f994513 | 288 | 2021-08-03 13:23:45-07:00 | 25,200 | ['0d76d1f2196b21325bb82f5680c9819240987a21'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.19.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
7b7877001005a7c476f6c04a984528a538496cb3 | 225 | 2021-08-05 07:04:05+10:00 | 25,200 | ['cd2dff2db139cca07954a80d587d76d5d0b94abb'] | fix egg-info cleanup (#8966) | [{'old_path': 'tools/pinning/common/export-pinned-dependencies.sh', 'new_path': 'tools/pinning/common/export-pinned-dependencies.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -29,7 +29,7 @@ fi\n # Old eggs can cause outdated dependency information to be used by poetry so we\n # delete them before generating th... | Python |
3058b6e748d085f53dd5c550be2806b26e7195eb | 225 | 2021-08-05 08:49:20+02:00 | 25,200 | ['7b7877001005a7c476f6c04a984528a538496cb3'] | Fix circular import (#8967)
* add internal display util
* Move display constants internal.
* move other utilities internal
* fix OK and CANCEL documentation | [{'old_path': 'certbot/certbot/_internal/display/obj.py', 'new_path': 'certbot/certbot/_internal/display/obj.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,7 +1,6 @@\n """This modules define the actual display implementations used in Certbot"""\n import logging\n import sys\n-import textwrap\n from typing im... | Python |
693a2a790423540037ddeaeb6b7728b4b76f624e | 225 | 2021-08-12 14:04:22-07:00 | 25,200 | ['3058b6e748d085f53dd5c550be2806b26e7195eb'] | remove outdated example code (#8984)
There are a couple problems with these files.
1. `python -m acme.standalone` from the README hasn't worked since https://github.com/certbot/certbot/pull/7483.
2. The symlinks for the PEM files have been broken since https://github.com/certbot/certbot/pull/7600.
Because of th... | [{'old_path': 'acme/examples/standalone/README', 'new_path': None, 'type': <ModificationType.DELETE: 4>, 'diff': '@@ -1,2 +0,0 @@\n-python -m acme.standalone -p 1234\n-curl -k https://localhost:1234\n'}, {'old_path': 'acme/examples/standalone/localhost/cert.pem', 'new_path': None, 'type': <ModificationType.DELETE: 4>, ... | Python |
5e87aee968082c1eb3f4c8ae2fd1903718e1feb5 | 273 | 2021-08-13 07:57:24+10:00 | 14,400 | ['693a2a790423540037ddeaeb6b7728b4b76f624e'] | BF: apache cfg parsing - relax assumption that value cannot contain = (#8930)
* BF: apache cfg parsing - relax assumption that value cannot contain =
* Remove failing test_update_runtime_vars_bad_output
* Add test Define statements: with = in value, and an empty value
* update CHANGELOG
Co-authored-by: Ale... | [{'old_path': 'certbot-apache/certbot_apache/_internal/apache_util.py', 'new_path': 'certbot-apache/certbot_apache/_internal/apache_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -153,13 +153,10 @@ def parse_defines(apachectl):\n return {}\n \n for match in matches:\n- if match.count("="... | Python |
b4c49cf7815dd4408a2970f674f2554af4d4f724 | 225 | 2021-08-12 15:34:40-07:00 | 25,200 | ['5e87aee968082c1eb3f4c8ae2fd1903718e1feb5'] | Improve snapcraft remote build (#8985)
[Snapcraft 5.0](https://forum.snapcraft.io/t/release-notes-snapcraft-5-0/25751) implemented creating build IDs based on the project's contents instead of the directory path in https://github.com/snapcore/snapcraft/pull/3554. This is a feature we initially wanted, but it broke our... | [{'old_path': 'tools/snap/build_remote.py', 'new_path': 'tools/snap/build_remote.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -13,8 +13,10 @@ from os.path import dirname\n from os.path import exists\n from os.path import join\n from os.path import realpath\n+import random\n import re\n import shutil\n+import ... | Python |
6943cea6b792b825a0b99ded65611123815983f7 | 166 | 2021-08-13 11:00:33+10:00 | -7,200 | ['b4c49cf7815dd4408a2970f674f2554af4d4f724'] | Reimplement zope interfaces into abc in compatibility tests (#8971)
* Reimplement zope interfaces into abc in compatibility tests
* Refactor to fix lint and mypy warnings
* Fix inheritance | [{'old_path': 'certbot-compatibility-test/certbot_compatibility_test/configurators/apache/common.py', 'new_path': 'certbot-compatibility-test/certbot_compatibility_test/configurators/apache/common.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,18 +4,14 @@ import shutil\n import subprocess\n from unittest imp... | Python |
10dc41e83d1c887a90ffc3f2711ab56f3fef7fd7 | 181 | 2021-08-13 14:04:47-07:00 | -36,000 | ['6943cea6b792b825a0b99ded65611123815983f7'] | docs: add "Deleting Certificates" to user guide (#8910)
I want this for #8949.
I think this is quite verbose, but purposefully so as an intervention to try prevent users from hitting this problem. It's more of a "How-To Guide" than a "Reference Guide" (in the lingo of https://documentation.divio.com).
* docs: a... | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -529,6 +529,72 @@ revocation from any ACME account::\n \n certbot revoke --cert-path /etc/letsencrypt/live/example.com/cert.pem --key-path /etc/letsencrypt/live/example.com/privkey.pem\n \n+... | Python |
241a7c32a26dadf0cea95842207f17008abc0edf | 181 | 2021-08-13 17:39:12-07:00 | -36,000 | ['10dc41e83d1c887a90ffc3f2711ab56f3fef7fd7'] | docs: add basic intro to certbot in user guide (#8979)
* docs: add basic intro to certbot in user guide
Co-authored-by: Brad Warren <bmw@users.noreply.github.com> | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -21,25 +21,40 @@ The ``certbot`` script on your web server might be named ``letsencrypt`` if your\n Getting certificates (and choosing plugins)\n ===========================================\n ... | Python |
23e1e07139d1abc3a9ae6338991daba770141a0a | 166 | 2021-08-15 07:06:29+10:00 | -7,200 | ['241a7c32a26dadf0cea95842207f17008abc0edf'] | Emit deprecation warnings for Zope interfaces (#8970)
* Monkeypatch certbot.interfaces module to warn about deprecations
* Ignore our own warning
* Fix type
* Add a changelog entry | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,7 +10,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Changed\n \n-*\n+* `zope` based interfaces in `certbot.interfaces` module are deprecated and will\n+ be remo... | Python |
525c427c60f14f8f4b8604044db4f9d9ff4230e4 | 166 | 2021-08-17 07:43:56+10:00 | -7,200 | ['23e1e07139d1abc3a9ae6338991daba770141a0a'] | Cleanup some useless type ignore directives (#8987)
* Cleanup some useless type ignore directives
* Cleanup one more type ignore directive
Co-authored-by: Adrien Ferrand <aferrand@ecomundo.eu> | [{'old_path': 'acme/acme/challenges.py', 'new_path': 'acme/acme/challenges.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,10 +7,10 @@ import logging\n import socket\n from typing import Type\n \n-from cryptography.hazmat.primitives import hashes # type: ignore\n+from cryptography.hazmat.primitives import ha... | Python |
5b96cc9c37ace516d3a3b656f7081a8c39426351 | 166 | 2021-08-16 15:14:22-07:00 | -7,200 | ['525c427c60f14f8f4b8604044db4f9d9ff4230e4'] | Release pip pinning (#8993)
The bug that was requiring pip to stay on 20.2.4 has been fixed on version 21.2.x. Let's release the pip pinning with this PR. | [{'old_path': 'tools/pinning/current/pyproject.toml', 'new_path': 'tools/pinning/current/pyproject.toml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -64,10 +64,6 @@ mypy = "<0.900"\n # needed. This dependency can be removed here once Certbot\'s support for the\n # 3rd party mock library has been dropped.\n mock ... | Python |
6a9e0ec59d07b64f561c8a8012766ddfdcea1f4c | 166 | 2021-08-17 09:13:54-07:00 | -7,200 | ['5b96cc9c37ace516d3a3b656f7081a8c39426351'] | Add deprecation warnings for deprecated elements in certbot.display.util (#8989)
Fix #8982.
This PR takes essentially the same approach than in #8970 and https://github.com/certbot/certbot/pull/6859/files#diff-e5eaf744409c293203b898ba9896da75689fd04ff5f1566c035940a5b195c257
Co-authored-by: Brad Warren <bmw@users... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,6 +10,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Changed\n \n+* Several attributes in `certbot.display.util` module are deprecated and will\n+ be removed in ... | Python |
acf48df979647034ab2c9c39f6b3b0458f725b30 | 166 | 2021-08-17 10:52:57-07:00 | -7,200 | ['6a9e0ec59d07b64f561c8a8012766ddfdcea1f4c'] | Use latest version of mypy (#8992)
Fixes #8899
This PR removes the pinning upper limit of mypy currently set to <0.900 and adds the required types-* stub packages to make recent versions of mypy work.
* Unpin mypy
* Improve type in TempHandler
* Add types | [{'old_path': 'certbot-ci/certbot_integration_tests/utils/misc.py', 'new_path': 'certbot-ci/certbot_integration_tests/utils/misc.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -232,10 +232,15 @@ def generate_csr(domains, key_path, csr_path, key_type=RSA_KEY_TYPE):\n with warnings.catch_warnings():\n ... | Python |
143ea15253bc8644f20f7882f095a0c9ee8fecac | 166 | 2021-08-17 14:51:26-07:00 | -7,200 | ['acf48df979647034ab2c9c39f6b3b0458f725b30'] | Remove all non essential references to the old Zope interfaces (#8988)
As a follow-up to #8971, this PR removes all references to the old Zope interfaces, except the ones used to deprecate them and prepare for their removal.
In the process, some documentation and tests about the `Display` objects are simply removed... | [{'old_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'new_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -121,7 +121,7 @@ class ApacheConfigurator(common.Installer, interfaces.Authenticator):\n """Apache configurator.\n \n ... | Python |
06c81138630c6155fb37009c075320fca30c361c | 166 | 2021-08-18 08:12:55-07:00 | -7,200 | ['143ea15253bc8644f20f7882f095a0c9ee8fecac'] | Cleanup zope dependencies in plugins and upgrade sphinx (#8997)
This PR removes all zope dependencies from plugins configuration.
It also lets Sphinx upgrade to the next major version by removing the plugin dedicated to zope interfaces documentation. As a consequence, the deprecated zope interfaces are not document... | [{'old_path': 'certbot-apache/setup.py', 'new_path': 'certbot-apache/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -11,8 +11,6 @@ install_requires = [\n f'certbot>={version}',\n 'python-augeas',\n 'setuptools>=39.0.1',\n- 'zope.component',\n- 'zope.interface',\n ]\n \n dev_extras = [\n"... | Python |
435ae075a52072b65c25add70c029728e7a1c3be | 225 | 2021-08-18 09:43:40-07:00 | 25,200 | ['06c81138630c6155fb37009c075320fca30c361c'] | remove zope from plugin example (#8998) | [{'old_path': 'certbot/examples/plugins/setup.py', 'new_path': 'certbot/examples/plugins/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -5,7 +5,6 @@ setup(\n package='certbot_example_plugins.py',\n install_requires=[\n 'certbot',\n- 'zope.interface',\n ],\n entry_points={\n ... | Python |
a8a8a39ff18ee33936d385b5ac403daa81b7ed31 | 225 | 2021-08-19 15:15:31-07:00 | 25,200 | ['435ae075a52072b65c25add70c029728e7a1c3be'] | upgrade pip (#9000)
This is just an oldest tests version of https://github.com/certbot/certbot/pull/8993. | [{'old_path': 'tools/oldest_constraints.txt', 'new_path': 'tools/oldest_constraints.txt', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,9 +2,10 @@\n # that script.\n apacheconfig==0.3.2\n asn1crypto==0.24.0\n-astroid==2.5.6; python_version >= "3.6" and python_version < "4.0"\n+astroid==2.6.6; python_version >= "... | Python |
295dc5a2a95396eb8888031a4c3bf79f9a088c30 | 325 | 2021-08-23 09:38:14+10:00 | -7,200 | ['a8a8a39ff18ee33936d385b5ac403daa81b7ed31'] | certbot-dns-rfc2136: catch error when a hostname is being used for `dns_rfc2136_server` (#8990)
* Raise separate error when a hostname is being used for `dns_rfc2136_server`
* Explicitly say IP address instead of hostname in docs
* Don't catch ValueError, but actually check the server value
* Add tests
* A... | [{'old_path': 'certbot-dns-rfc2136/certbot_dns_rfc2136/__init__.py', 'new_path': 'certbot-dns-rfc2136/certbot_dns_rfc2136/__init__.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -33,7 +33,7 @@ different to HMAC-MD5.\n :name: credentials.ini\n :caption: Example credentials file:\n \n- # Target DNS server... | Python |
058faeadac1d5134ff5899672ecd43b023960945 | 225 | 2021-08-23 10:57:34-07:00 | 25,200 | ['295dc5a2a95396eb8888031a4c3bf79f9a088c30'] | Propagate requirement that ACME responses are UTF-8 (#9001)
I think this fixes https://github.com/certbot/certbot/issues/8968.
The only other calls with `requests` we make in our code outside of our tests that I could find are:
1. [Here](https://github.com/certbot/certbot/blob/a8a8a39ff18ee33936d385b5ac403daa81b... | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1149,13 +1149,23 @@ class ClientNetwork:\n host, path, _err_no, err_msg = m.groups()\n raise ValueError("Requesting {0}{1}:{2}".format(host, path, err_msg))\n \n- # I... | Python |
694c03bd6a47e456103d36bf7f93f264f3784339 | 181 | 2021-08-25 07:40:26-07:00 | -36,000 | ['058faeadac1d5134ff5899672ecd43b023960945'] | lower coverage threshold for rfc2136 integration (#9006) | [{'old_path': 'tox.ini', 'new_path': 'tox.ini', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -221,7 +221,7 @@ commands =\n --cov=acme --cov=certbot --cov=certbot_dns_rfc2136 --cov-report= \\\n --cov-config=certbot-ci/certbot_integration_tests/.coveragerc\n coverage report --include 'certbot/*' ... | Python |
52e207a404ab3600637fc7a24492e2c68512ce2d | 161 | 2021-08-27 06:47:01-07:00 | -32,400 | ['694c03bd6a47e456103d36bf7f93f264f3784339'] | add ip address support to certbot/acme lib (2021 ver) (#8904)
* add ip address support to acme saving
* remove client-site check for ip address
* using right prefix for san parsing
* remove type hint for backward compatibility
* remove bare ip blocking check from main_test
* upppercase
* lint tix
... | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -655,11 +655,15 @@ class ClientV2(ClientBase):\n csr = OpenSSL.crypto.load_certificate_request(OpenSSL.crypto.FILETYPE_PEM, csr_pem)\n # pylint: disable=protected-access\n dn... | Python |
f6d5c8ffbefadd4db8d431e35fa58185874644c1 | 225 | 2021-08-30 15:38:12-07:00 | 25,200 | ['52e207a404ab3600637fc7a24492e2c68512ce2d'] | Make ACMEv1 deprecation warnings scarier (#9015)
Fixes https://github.com/certbot/certbot/issues/6844.
This PR does two things:
1. Changes ACMEv1 deprecation warnings from `PendingDeprecationWarning` to `DeprecationWarning`.
2. Changes the ACMEv1 deprecation warnings to be on references to the class themselves.... | [{'old_path': 'acme/acme/client.py', 'new_path': 'acme/acme/client.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,4 +1,7 @@\n """ACME client API."""\n+# pylint: disable=too-many-lines\n+# This pylint disable can be deleted once the deprecated ACMEv1 code is\n+# removed.\n import base64\n import collections\n... | Python |
1a2d74decc3caf8bce21b5da3cf4d0eb8c058e3d | 225 | 2021-09-03 06:40:18+10:00 | 25,200 | ['f6d5c8ffbefadd4db8d431e35fa58185874644c1'] | Add comment about security alerts. (#9016) | [{'old_path': 'tools/pinning/oldest/pyproject.toml', 'new_path': 'tools/pinning/oldest/pyproject.toml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,3 +1,5 @@\n+# Security alerts about vulnerable packages in this file can be ignored since\n+# they are only used during testing.\n [tool.poetry]\n name = "certbot-... | Python |
0d4f92fa81bc49f626308e558ed9f515011c05ef | 613 | 2021-09-03 06:43:13+10:00 | -7,200 | ['1a2d74decc3caf8bce21b5da3cf4d0eb8c058e3d'] | Fix some typos (found by codespell) (#9017)
* Fix some typos (found by codespell)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
* Remove typo fixes for some files which should not be modified
Signed-off-by: Stefan Weil <sw@weilnetz.de> | [{'old_path': 'certbot-apache/certbot_apache/_internal/http_01.py', 'new_path': 'certbot-apache/certbot_apache/_internal/http_01.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -107,7 +107,7 @@ class ApacheHttp01(common.ChallengePerformer):\n if any(a.is_wildcard() or a.get_port() == http_port for a ... | Python |
8ff71530190ef41b09e6ee716698dc2a083210e8 | 181 | 2021-09-03 07:47:12-07:00 | -36,000 | ['0d4f92fa81bc49f626308e558ed9f515011c05ef'] | snap: revert to checking snapctl file existence (#9018)
While the previous approach of testing the functionality of snapctl
worked, the snapd developers told us they could not guarantee its
reliability.
---
As with #8955, I tested this on Debian 9, 10 and CentOS 7, 8, Stream. | [{'old_path': 'snap/hooks/prepare-plug-plugin', 'new_path': 'snap/hooks/prepare-plug-plugin', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,9 +7,9 @@\n SNAPCTL_CORE="/snap/core/current/usr/bin/snapctl"\n SNAPCTL_SNAPD="/snap/snapd/current/usr/bin/snapctl"\n SNAPCTL="snapctl"\n-if $SNAPCTL_CORE get x 2>/dev/null;... | Python |
b7bde05aee7b43996fe88bc399518b802cc596a7 | 181 | 2021-09-03 07:49:25-07:00 | -36,000 | ['8ff71530190ef41b09e6ee716698dc2a083210e8'] | docs: redirect macOS users to different cron guide (#9013)
Due to macOS having some complications about Certbot from Homebrew being
in the PATH, the instructions we have in the Automated Renewal section
do not work for them. Instead, send those users to the instruction
generator. | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -818,9 +818,14 @@ scheduled task to automatically renew your certificates in the background. If yo\n whether your system has a pre-installed scheduled task for Certbot, it is safe to follow th... | Python |
70a18a94861f4493f595e07395508289efbc4e1d | 181 | 2021-09-07 08:38:27-07:00 | -36,000 | ['b7bde05aee7b43996fe88bc399518b802cc596a7'] | disable donation prompt during --quiet (#9022)
Issuing a certificate with --quiet was crashing during the donation
atexit call because it was trying to use the /dev/null fd after the
displayer context manager had already closed it. | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -27,6 +27,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n ### Fixed\n \n * Fixed parsing of `Define`d values in the Apache plugin to allow for `=` in the value.\n+* Fixed a r... | Python |
dc7524d1d650c4746b35db718e6eb0bfaf0eea55 | 224 | 2021-09-07 10:13:51-07:00 | 25,200 | ['70a18a94861f4493f595e07395508289efbc4e1d'] | Update changelog for 1.19.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.19.0 - master\n+## 1.19.0 - 2021-09-07\n \n ### Added\n \n'}] | Python |
8897a81f7d7b01012697ed6b3843d0d6aa0c6699 | 224 | 2021-09-07 10:15:07-07:00 | 25,200 | ['5d6abc32341993d33d7ca9430ba67ecbbdb4888a'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.20.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
d139e26a1cd16f74502ead02159dd24d94e3eb1d | 181 | 2021-09-09 12:10:27-07:00 | -36,000 | ['dedd0b84a86a5a26877c5ba2d1edd4a56aa6b829'] | fix 'NEXT STEPS' being printed to stdout during -q (#9023)
@osirisinferi noticed [in chat](https://opensource.eff.org/eff-open-source/pl/sa85u4n71tywfpc15c1wu59wae) that "NEXT STEPS:" was ignoring `--quiet` and was being printed unconditionally.
I think it ended up being written this way in #8860 because I was tryi... | [{'old_path': 'certbot/certbot/_internal/main.py', 'new_path': 'certbot/certbot/_internal/main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -526,10 +526,12 @@ def _report_next_steps(config: configuration.NamespaceConfig, installer_err: Opt\n return\n \n # TODO: refactor ANSI escapes during https:/... | Python |
0b63d81f952b41d518716e9134282e458293fb75 | 181 | 2021-09-09 12:13:09-07:00 | -36,000 | ['d139e26a1cd16f74502ead02159dd24d94e3eb1d'] | cli: minor copy changes to `renew` help text (#9025)
Fixes #9009. | [{'old_path': 'certbot/certbot/_internal/cli/verb_help.py', 'new_path': 'certbot/certbot/_internal/cli/verb_help.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -23,14 +23,14 @@ VERB_HELP = [\n }),\n ("renew", {\n "short": "Renew all certificates (or one specified with --cert-name)",\n- "o... | Python |
077d28828acfec5a7b750edc3f75f2955d99a1f6 | 225 | 2021-09-09 13:21:47-07:00 | 25,200 | ['0b63d81f952b41d518716e9134282e458293fb75'] | Add documentation about legacy cb-auto files (#9011)
* Add documentation about legacy cb-auto files
* Apply suggestions from code review
Co-authored-by: ohemorange <erica@eff.org>
Co-authored-by: ohemorange <erica@eff.org> | [{'old_path': None, 'new_path': 'letsencrypt-auto-source/README.md', 'type': <ModificationType.ADD: 1>, 'diff': "@@ -0,0 +1,12 @@\n+# Legacy letsencrypt-auto files\n+\n+`certbot-auto` and `letsencrypt-auto` were two names for the same self-updating\n+shell script that wrapped Certbot. Old versions of the script continu... | Python |
ee190db2350055992dbd4b748e4fd9b36efead2a | 225 | 2021-09-09 14:57:55-07:00 | 25,200 | ['077d28828acfec5a7b750edc3f75f2955d99a1f6'] | Update oldest pyproject.toml comments (#8999)
* update oldest pyproject.toml comments
* Apply suggestions from code review
Co-authored-by: ohemorange <erica@eff.org>
* improve wording
Co-authored-by: ohemorange <erica@eff.org> | [{'old_path': 'tools/pinning/oldest/pyproject.toml', 'new_path': 'tools/pinning/oldest/pyproject.toml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -37,85 +37,60 @@ certbot = {path = "../../../certbot", extras = ["test"]}\n acme = {path = "../../../acme", extras = ["test"]}\n \n # Oldest dependencies\n-# We speci... | Python |
fc02b10560b5f04b661040b9683cda343de17e61 | 166 | 2021-09-10 12:26:07-07:00 | -7,200 | ['ee190db2350055992dbd4b748e4fd9b36efead2a'] | Upgrade pinned versions of certbot dependencies (josepy in particular) (#9027)
This PR upgrades the pinned version of the dependencies. Version `1.9.0` of josepy is used so errors related to JWK serialization with EC keys (see https://github.com/certbot/josepy/issues/109) are fixed for Certbot. | [{'old_path': '.pylintrc', 'new_path': '.pylintrc', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -67,7 +67,12 @@ extension-pkg-whitelist=pywintypes,win32api,win32file,win32security\n # 5) wrong-import-order generates false positives and a pylint developer\n # suggests that people using isort should disable this... | Python |
aea3c7e36374df0079132134541165795418d94d | 181 | 2021-09-10 12:27:53-07:00 | -36,000 | ['fc02b10560b5f04b661040b9683cda343de17e61'] | add --no-reuse-key (#9029)
Fixes #9002. | [{'old_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'new_path': 'certbot-ci/certbot_integration_tests/certbot_tests/test_main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -433,6 +433,21 @@ def test_reuse_key(context):\n privkey3 = file.read()\n assert privkey2 != privk... | Python |
bd5f4f2d8ac3ad9e5afecab28d4806c538b1dc4d | 166 | 2021-09-10 16:08:13-07:00 | -7,200 | ['aea3c7e36374df0079132134541165795418d94d'] | Increase minimum of josepy version to use and update the oldest contraints. (#9032)
As a follow-up to #9027, this PR increases the minimum version of `josepy` to use and updates the oldest constraints accordingly. | [{'old_path': 'acme/setup.py', 'new_path': 'acme/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -7,10 +7,7 @@ version = '1.20.0.dev0'\n \n install_requires = [\n 'cryptography>=2.1.4',\n- # formerly known as acme.jose:\n- # 1.1.0+ is required to avoid the warnings described at\n- # https://gi... | Python |
b0aa0646409eee00056c27ee90ee53c582f64a54 | 181 | 2021-09-14 07:48:15+10:00 | -36,000 | ['bd5f4f2d8ac3ad9e5afecab28d4806c538b1dc4d'] | dns-rfc2136: use certbot's own is_ipaddress func (#9035)
* dns-rfc2136: use certbot's own is_ipaddress func
* oldest: pin dnspython==1.15.0 (epel8 version)
* inhibit deprecationwarning for dnspython==1.15.0
* dns-rfc2136: declare minimum version of dnspython
* add changelog entry | [{'old_path': 'certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py', 'new_path': 'certbot-dns-rfc2136/certbot_dns_rfc2136/_internal/dns_rfc2136.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,7 +3,6 @@ import logging\n from typing import Optional\n \n import dns.flags\n-from dns.inet import is_ad... | Python |
abe23c0e6014a647f58c85aef2edb1c639204fe4 | 181 | 2021-09-22 11:07:30-07:00 | -36,000 | ['b0aa0646409eee00056c27ee90ee53c582f64a54'] | missing trailing '?' in non-interactive checklist (#9043) | [{'old_path': 'certbot/certbot/_internal/display/obj.py', 'new_path': 'certbot/certbot/_internal/display/obj.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -505,7 +505,7 @@ class NoninteractiveDisplay:\n \n """\n if default is None:\n- self._interaction_fail(message, cli_flag, "? ".jo... | Python |
bb2db252a7de77af8f1410ea48548c228baaf10b | 181 | 2021-09-28 10:48:50-07:00 | -36,000 | ['abe23c0e6014a647f58c85aef2edb1c639204fe4'] | stop using deprecated jose abstractclassmethod (#9045)
The josepy 1.10.0 release deprecated this decorator and [caused the nightly `nopin` test to break](https://dev.azure.com/certbot/certbot/_build/results?buildId=4548&view=logs&j=ce03f7c1-1e3f-5d55-28be-f084e7c62a50&t=597fea95-d44e-53a2-5b71-76ed20bd4dde). | [{'old_path': 'certbot/certbot/plugins/common.py', 'new_path': 'certbot/certbot/plugins/common.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,12 +1,12 @@\n """Plugin common functions."""\n from abc import ABCMeta\n+from abc import abstractmethod\n import logging\n import re\n import shutil\n import tempfile\... | Python |
cde3e1fa9774d508159812b96dc56b2f302d16e0 | 225 | 2021-09-29 10:29:49-07:00 | 25,200 | ['bb2db252a7de77af8f1410ea48548c228baaf10b'] | fix typo in error message (#9047) | [{'old_path': 'certbot/certbot/_internal/main.py', 'new_path': 'certbot/certbot/_internal/main.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -158,7 +158,7 @@ def _handle_unexpected_key_type_migration(config: configuration.NamespaceConfig,\n if new_key_type != cur_key_type:\n msg = ('Are you... | Python |
065df4c9a70330b99c162aaf789c54aa8c43b596 | 166 | 2021-10-04 14:20:49-07:00 | -7,200 | ['cde3e1fa9774d508159812b96dc56b2f302d16e0'] | Support Python 3.9 on Windows and package installer on it (#9053)
It seems that all required pre-compiled wheels to install Certbot on Python 3.9 on Windows are present.
This PR upgrades Windows tests on Python 3.9 and repackages the installer on this version of Python. | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -59,7 +59,7 @@ jobs:\n steps:\n - task: UsePythonVersion@0\n inputs:\n- versionSpec: 3.8\n+ versionS... | Python |
54475964bd462dbcecd0da9c1646d8a8cd70bd8a | 224 | 2021-10-05 06:52:55-07:00 | 25,200 | ['065df4c9a70330b99c162aaf789c54aa8c43b596'] | Update changelog for 1.20.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.20.0 - master\n+## 1.20.0 - 2021-10-05\n \n ### Added\n \n'}] | Python |
aa63688450a9f8183827f91bd61be6f8011e2cfb | 224 | 2021-10-05 06:53:59-07:00 | 25,200 | ['93f61887beae380ef547c51fb8f506cfb28569bb'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.21.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
777935c8ed35d5eda84e682aa7f03e0d07a1d3ed | 246 | 2021-10-12 22:56:24+02:00 | -7,200 | ['15c2792036a466f79625bcc4d345f81c0ba82975'] | Remove trailing spaces from docs (#9064) | [] | Python |
d250d341934448e9b4a712f9c7801d655256cbd8 | 225 | 2021-10-14 14:27:15-07:00 | 25,200 | ['777935c8ed35d5eda84e682aa7f03e0d07a1d3ed'] | Change PGP keys (#9046)
* automate determining the key
* update packaging docs
* switch to new keys
* add changelog entry
* put keys in changelog | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,7 +10,13 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Changed\n \n-*\n+* We changed the PGP key used to sign the packages we upload to PyPI. Going\n+ forward, re... | Python |
1a698fa2359e9bcdd9242c4bf77f8ff232cdde61 | 225 | 2021-10-19 12:10:22+11:00 | 25,200 | ['d250d341934448e9b4a712f9c7801d655256cbd8'] | update packaging docs to mention dl.eff.org (#9068) | [{'old_path': 'certbot/docs/packaging.rst', 'new_path': 'certbot/docs/packaging.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -40,9 +40,12 @@ PGP keys:\n - ``86379B4F0AF371B50CD9E5FF3402831161D1D280``\n - ``20F201346BF8F3F455A73F9A780CC99432A28621``\n \n+These keys can be found on major key servers and at\n+h... | Python |
2375d87831d25b03021dfaa117a5eaf2fa44a143 | 181 | 2021-10-20 13:57:48+11:00 | -39,600 | ['1a698fa2359e9bcdd9242c4bf77f8ff232cdde61'] | delete: add a warning about safe deletion (#8949) | [{'old_path': 'certbot/certbot/_internal/cert_manager.py', 'new_path': 'certbot/certbot/_internal/cert_manager.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -93,6 +93,12 @@ def delete(config):\n msg = ["The following certificate(s) are selected for deletion:\\n"]\n for certname in certnames:\n ... | Python |
94af2357130474199d9bd348a8be57a326d17509 | 166 | 2021-10-24 08:37:40+11:00 | -7,200 | ['2375d87831d25b03021dfaa117a5eaf2fa44a143'] | Generate a web.config file for IIS to serve properly the challenge files in webroot plugin (#9054)
* Generate a web.config file to serve properly challenge files with IIS
* Fix cleanup, add test
* FIx lint
* Do not overwrite existing web.config. Delete only web.config when it has been created by Certbot and i... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -6,7 +6,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Added\n \n-*\n+* Certbot will generate a `web.config` file on Windows in the challenge path\n+ when the `webro... | Python |
a0f22d21cec0b8ab29eadd9285bd876205df24c7 | 166 | 2021-10-25 09:43:21+11:00 | -7,200 | ['94af2357130474199d9bd348a8be57a326d17509'] | Add type annotations to the `acme` project (#9036)
* Start more types
* Second run
* Work in progress
* Types in all acme module
* Various fixes
* Various fixes
* Final fixes
* Disallow untyped defs for acme project
* Fix coverage
* Remote unecessary type ignore
* Use Mapping instead of D... | [{'old_path': 'acme/acme/challenges.py', 'new_path': 'acme/acme/challenges.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -5,6 +5,12 @@ import functools\n import hashlib\n import logging\n import socket\n+from typing import cast\n+from typing import Any\n+from typing import Dict\n+from typing import Mapping\n+f... | Python |
cdbc264bb62ddcc1d4810584919f21ef714ad13e | 63 | 2021-10-25 12:20:57-07:00 | -3,600 | ['a0f22d21cec0b8ab29eadd9285bd876205df24c7'] | Fix copyright date s/2015-2015/2015/ (#9070) | [{'old_path': 'acme/docs/conf.py', 'new_path': 'acme/docs/conf.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -58,7 +58,7 @@ master_doc = 'index'\n \n # General information about the project.\n project = u'acme-python'\n-copyright = u'2015-2015, Let\\'s Encrypt Project'\n+copyright = u'2015, Let\\'s Encrypt Pro... | Python |
e501e277b3c07b897b04777af677f1db40fcbaee | 224 | 2021-11-02 14:27:18-07:00 | 25,200 | ['cdbc264bb62ddcc1d4810584919f21ef714ad13e'] | Update changelog for 1.21.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.21.0 - master\n+## 1.21.0 - 2021-11-02\n \n ### Added\n \n'}] | Python |
91c079ab411884df9465a6cd1e52c0a541d23144 | 224 | 2021-11-02 14:28:34-07:00 | 25,200 | ['200e1f1709811bd068f5ba858d7bf523ea6adef9'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.22.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
81d5d2b4211f6530fad07d413ffb825105cadb60 | 225 | 2021-11-04 20:35:44+11:00 | 25,200 | ['8f8dd2824e677fb788eb4c8924e649e91cbc8b3f'] | Pin readthedocs deps (#9083)
* pin readthedocs deps
* fix reqs path | [{'old_path': 'acme/readthedocs.org.requirements.txt', 'new_path': 'acme/readthedocs.org.requirements.txt', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,4 +7,7 @@\n # in --editable mode (-e), just "pip install acme[docs]" does not work as\n # expected and "pip install -e acme[docs]" must be used instead\n \n+# ... | Python |
b1edda8a65cc9d9d143ec67f4d79aafc04670793 | 633 | 2021-11-07 14:18:15+11:00 | -32,400 | ['81d5d2b4211f6530fad07d413ffb825105cadb60'] | fix a typo in gen_ss_cert type hint (#9089) | [{'old_path': 'acme/acme/crypto_util.py', 'new_path': 'acme/acme/crypto_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -348,7 +348,7 @@ def gen_ss_cert(key: crypto.PKey, domains: Optional[List[str]] = None,\n not_before: Optional[int] = None,\n validity: int = (7 * 24 * 60 *... | Python |
e8265dbf9c3aad879d2bcae0e95e71ba9facd8ce | 225 | 2021-11-08 15:55:32-08:00 | 28,800 | ['b1edda8a65cc9d9d143ec67f4d79aafc04670793'] | Add Python 3.10 support and tests (#9077)
Fixes https://github.com/certbot/certbot/issues/9058.
The changes to the CI config are equivalent to the ones made in https://github.com/certbot/certbot/pull/8460.
Other than ignoring some warnings raised by botocore, the main additional work that had to be done here was... | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,7 +4,7 @@ jobs:\n - name: IMAGE_NAME\n value: ubuntu-18.04\n - name: PYTHON_VERSION\n- value: 3.... | Python |
4756b6608946c240469b58604db84d99b55c3105 | 181 | 2021-11-11 09:44:59+01:00 | -39,600 | ['e8265dbf9c3aad879d2bcae0e95e71ba9facd8ce'] | docs: update intersphinx url for certbot project (#9096) | [{'old_path': 'certbot-dns-cloudflare/docs/conf.py', 'new_path': 'certbot-dns-cloudflare/docs/conf.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -177,5 +177,5 @@ texinfo_documents = [\n intersphinx_mapping = {\n 'python': ('https://docs.python.org/', None),\n 'acme': ('https://acme-python.readthedocs.o... | Python |
d20e42562cdb9cfd46fa5cd592a489bc16a5de4c | 166 | 2021-11-12 14:27:46+11:00 | -3,600 | ['4756b6608946c240469b58604db84d99b55c3105'] | Add type annotations to the certbot package (part 1) (#9084)
* Extract from #9084
* Cast/ignore types during the transition
* Fix after review
* Fix lint | [{'old_path': 'acme/acme/py.typed', 'new_path': 'acme/acme/py.typed', 'type': <ModificationType.ADD: 1>, 'diff': ''}, {'old_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'new_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2437,10 ... | Python |
2746fc572fe252b6357bf1454fadf3286124e585 | 181 | 2021-11-15 14:35:18+11:00 | -39,600 | ['d20e42562cdb9cfd46fa5cd592a489bc16a5de4c'] | webroot: unset existing mime type in web.config (#9092) | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -18,7 +18,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Fixed\n \n-*\n+* Fixed an issue on Windows where the `web.config` created by Certbot would sometimes\n+ conf... | Python |
d2578e05e7cfd6e408dc45b6e48d0c42685c014d | 181 | 2021-11-18 12:14:10-08:00 | -39,600 | ['2746fc572fe252b6357bf1454fadf3286124e585'] | docs: describe how to modify renewal config (#9014)
* docs: describe how to modify renewal config
* Apply suggestions from code review
Co-authored-by: ohemorange <ebportnoy@gmail.com>
* reword warning about manual modifications
* explain the flags in the --force-renewal command
Co-authored-by: ohemorang... | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -747,53 +747,50 @@ commands into your individual environment.\n and when renewal is not necessary.\n \n .. _renewal-config-file:\n+.. _Modifying the Renewal Configuration File:\n \n+Modifyin... | Python |
676678604933d85d0d5b52449d3c5d3fccd35392 | 181 | 2021-11-22 19:00:55+01:00 | -39,600 | ['d2578e05e7cfd6e408dc45b6e48d0c42685c014d'] | Fix Windows webroot crash when multiple domains have the same webroot (#9108)
* Certificate issuing on Window while having web.confing and more then one domain in request
* add a test
* update changelog
Co-authored-by: Serghei Trufkin <Serghei.Trufkin@Technosoft.md> | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -20,6 +20,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n * Fixed an issue on Windows where the `web.config` created by Certbot would sometimes\n conflict with preexisti... | Python |
267fb94478f2ff68ec0dcb16a66e5e8d88b229ad | 531 | 2021-11-23 10:18:22-08:00 | -28,800 | ['676678604933d85d0d5b52449d3c5d3fccd35392'] | Remove use of deprecated verifier with cryptography (#9105)
This was deprecated in version 2.1 and cryptography will be
removing it soon. The replacement function is available in all
versions of cryptography that certbot supports (2.1+) | [{'old_path': 'certbot/certbot/crypto_util.py', 'new_path': 'certbot/certbot/crypto_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -363,7 +363,6 @@ def verify_renewable_cert_sig(renewable_cert: interfaces.RenewableCert) -> None:\n with open(renewable_cert.cert_path, \'rb\') as cert_file:\n ... | Python |
d1821b3ad729fb2b7d6f35fda49e93c8d4d92e1f | 225 | 2021-11-23 12:35:49-08:00 | 28,800 | ['267fb94478f2ff68ec0dcb16a66e5e8d88b229ad'] | Pin back setuptools-rust (#9112)
* pin back setuptools-rust
* make pylint happy
This was taken from https://github.com/certbot/certbot/pull/9073.
* pin back josepy
* Apply lint's code style suggestions
* fix lint again
Co-authored-by: Erica Portnoy <ebportnoy@gmail.com> | [{'old_path': '.pylintrc', 'new_path': '.pylintrc', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -72,7 +72,9 @@ extension-pkg-whitelist=pywintypes,win32api,win32file,win32security\n # (unspecified encoding makes the open function use the default encoding of the system)\n # than a clear flaw on which a check ... | Python |
19147e1b8c3bbe6f55799f9d55c2f1027d69c0f4 | 166 | 2021-11-24 18:33:09+11:00 | -3,600 | ['d1821b3ad729fb2b7d6f35fda49e93c8d4d92e1f'] | Add type annotations to the certbot package (part 2) (#9085)
* Extract from #9084
* Cast/ignore types during the transition
* Clean up
* Fix assertion
* Update certbot/certbot/display/ops.py
Co-authored-by: alexzorin <alex@zor.io>
* Use sequence
* Improve documentation of "default" in display
*... | [{'old_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'new_path': 'certbot-apache/certbot_apache/_internal/configurator.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -16,9 +16,8 @@ from typing import Union\n \n from acme import challenges\n from certbot import errors\n-from certbot import in... | Python |
250d7b15420e96a09dbb8d615054530a42b1bf30 | 166 | 2021-11-25 07:47:36+11:00 | -3,600 | ['19147e1b8c3bbe6f55799f9d55c2f1027d69c0f4'] | Add type annotations to the certbot package (part 3) (#9086)
* Extract from #9084
* Cast/ignore types during the transition
* Fix after review
* Fix lint
* Update certbot/certbot/_internal/storage.py
Co-authored-by: alexzorin <alex@zor.io>
* Update certbot/certbot/_internal/storage.py
Co-authored-... | [{'old_path': 'certbot/certbot/_internal/account.py', 'new_path': 'certbot/certbot/_internal/account.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -5,9 +5,13 @@ import hashlib\n import logging\n import shutil\n import socket\n-from typing import cast\n from typing import Any\n+from typing import Callable\n+fro... | Python |
7d3a344d4314a19f49c706f6c82959ba6ce93451 | 158 | 2021-11-24 14:46:11-08:00 | 28,800 | ['250d7b15420e96a09dbb8d615054530a42b1bf30'] | Update py cryptography to >=2.5.0 (#9110)
* Update py cryptography to >=2.5.0
* Review feedback | [{'old_path': 'acme/setup.py', 'new_path': 'acme/setup.py', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -6,7 +6,7 @@ from setuptools import setup\n version = '1.22.0.dev0'\n \n install_requires = [\n- 'cryptography>=2.1.4',\n+ 'cryptography>=2.5.0',\n 'josepy>=1.9.0',\n 'PyOpenSSL>=17.3.0',\n 'p... | Python |
86406ab63aebf463ca4aa0381a55ddeb91231cd2 | 166 | 2021-11-26 09:00:03+11:00 | -3,600 | ['7d3a344d4314a19f49c706f6c82959ba6ce93451'] | Add type annotations to the certbot package (part 4) (#9087)
* Extract from #9084
* Cast/ignore types during the transition
* Remove useless casts and type ignore directives
* Fix lint
* Fix a cast
* Mandatory typing for certbot packages
* Update certbot/certbot/_internal/plugins/disco.py
Co-autho... | [{'old_path': 'acme/acme/messages.py', 'new_path': 'acme/acme/messages.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -335,7 +335,7 @@ class Registration(ResourceBody):\n \n @classmethod\n def from_data(cls, phone: Optional[str] = None, email: Optional[str] = None,\n- external_account_b... | Python |
0d10a44f4bd7a6cbd9dbc59d905876e9b0a6ca1b | 351 | 2021-11-30 08:17:06+11:00 | -32,400 | ['86406ab63aebf463ca4aa0381a55ddeb91231cd2'] | Added --issuance-timeout command line option (#9056)
* Added --issuance-timeout command line option
* clarification of command line option name,docstring and add tests
* fix test case for python36
* improved the command line options | [{'old_path': 'AUTHORS.md', 'new_path': 'AUTHORS.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -138,6 +138,7 @@ Authors\n * [Joubin Jabbari](https://github.com/joubin)\n * [Juho Juopperi](https://github.com/jkjuopperi)\n * [Kane York](https://github.com/riking)\n+* [Katsuyoshi Ozaki](https://github.com/morator... | Python |
aeb7beb1b1d7ef6b520fbcd4a67c44787920aad6 | 166 | 2021-11-30 08:24:39+11:00 | -3,600 | ['0d10a44f4bd7a6cbd9dbc59d905876e9b0a6ca1b'] | Fully type certbot-ci module (#9120)
* Fully type certbot-ci module
* Fix lint, focus lint
* Add trailing comma
* Remove unused private function
* Type properly for future usages
* Update certbot-ci/certbot_integration_tests/utils/acme_server.py
Co-authored-by: alexzorin <alex@zor.io>
* Cleanup fi... | [{'old_path': 'certbot-ci/certbot_integration_tests/assets/hook.py', 'new_path': 'certbot-ci/certbot_integration_tests/assets/hook.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,9 +1,11 @@\n #!/usr/bin/env python\n+"""A Certbot hook for probing."""\n import os\n import sys\n \n hook_script_type = os.path.bas... | Python |
402f18e039ff162afb2015ee3b56088596ba450b | 491 | 2021-12-02 08:45:16-07:00 | -3,600 | ['aeb7beb1b1d7ef6b520fbcd4a67c44787920aad6'] | Apache augeas clean up (#9114)
The `# self.comment = comment` caught my eye while working on #9071 as well as the intermediate variables, which aren't really needed. As a result, I reformatted the code slightly in those places.
* Remove comment in AugeasCommentNode.__init__
* Replace some intermediate varibles w... | [{'old_path': 'certbot-apache/certbot_apache/_internal/apache_util.py', 'new_path': 'certbot-apache/certbot_apache/_internal/apache_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -242,6 +242,7 @@ def _get_runtime_cfg(command):\n \n return stdout\n \n+\n def find_ssl_apache_conf(prefix):\n """\n ... | Python |
d6adc4a2d05a7c1606c6b3a360d8630ec6f91954 | 288 | 2021-12-07 14:02:45-08:00 | 28,800 | ['402f18e039ff162afb2015ee3b56088596ba450b'] | Update changelog for 1.22.0 release | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n-## 1.22.0 - master\n+## 1.22.0 - 2021-12-07\n \n ### Added\n \n'}] | Python |
d5ea9072aff021af62928830bb820ce03c10b290 | 288 | 2021-12-07 14:03:51-08:00 | 28,800 | ['6463a2e22d56bb0584acd8128f091a76cee94f12'] | Add contents to certbot/CHANGELOG.md for next version | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,22 @@\n \n Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n+## 1.23.0 - master\n+\n+### Added\n+\n+*\n+\n+### Changed\n+\n+*\n+\n+### Fixed\n+\n+*\n+\n+More details abou... | Python |
dab78648096cbd9992002a50b8a38e77732c10de | 225 | 2021-12-11 12:28:18+11:00 | 28,800 | ['693c674a7e72a7bba89d00f58430045789440677'] | Add macOS instructions (#9136)
* add macOS instructions
* add integration test warning | [{'old_path': 'certbot/docs/contributing.rst', 'new_path': 'certbot/docs/contributing.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -31,13 +31,11 @@ running:\n \n git clone https://github.com/certbot/certbot\n \n-If you're on macOS, we recommend you skip the rest of this section and instead\n-run Certbot i... | Python |
8799b108c22c33be3c665fed20969dc49af526d4 | 225 | 2021-12-11 12:43:17+11:00 | 28,800 | ['dab78648096cbd9992002a50b8a38e77732c10de'] | fix macos coverage (#9137) | [{'old_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/standard-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,14 +4,14 @@ jobs:\n PYTHON_VERSION: 3.10\n strategy:\n matrix:\n- macos-py36:\n+ macos-py36-c... | Python |
89cefc177aed479f9f68bbb7bdbba14fc4a17857 | 166 | 2021-12-11 12:58:33+11:00 | -3,600 | ['8799b108c22c33be3c665fed20969dc49af526d4'] | Fix --help output (#9130) | [{'old_path': 'certbot/certbot/_internal/cli/helpful.py', 'new_path': 'certbot/certbot/_internal/cli/helpful.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -71,11 +71,11 @@ class HelpfulArgumentParser:\n self.notify = display_obj.NoninteractiveDisplay(sys.stdout).notification\n \n # List of topi... | Python |
97d9e2c97dbb2a57cc9a5d0374376e98b359d11c | 166 | 2021-12-13 14:01:31+11:00 | -3,600 | ['89cefc177aed479f9f68bbb7bdbba14fc4a17857'] | Fully type lock_test.py (#9126)
* Type lock_test.py
* Reconfigure tox
* Fix imports | [{'old_path': 'tests/lock_test.py', 'new_path': 'tests/lock_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -9,6 +9,10 @@ import shutil\n import subprocess\n import sys\n import tempfile\n+from typing import Iterable\n+from typing import List\n+from typing import Sequence\n+from typing import Tuple\n \n fro... | Python |
3353c0df431c71ee9cd15f2e91f41f2220c222eb | 181 | 2021-12-13 10:42:15-08:00 | -39,600 | ['97d9e2c97dbb2a57cc9a5d0374376e98b359d11c'] | tests: remove Boulder v1 endpoint from certbot-ci and azure (#9140) | [{'old_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/extended-tests-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -26,58 +26,30 @@ jobs:\n CERTBOT_NO_PIN: 1\n linux-external-mock:\n TOXENV: external-mock\n- ... | Python |
cb3e1403cdf0b1e00a384c06bdc85b70b2bf0a09 | 166 | 2021-12-14 12:14:11+11:00 | -3,600 | ['3353c0df431c71ee9cd15f2e91f41f2220c222eb'] | Fully type certbot-compatibility-test (#9133)
* Finish typing the module
* Use cast
* Precise type | [{'old_path': 'certbot-compatibility-test/certbot_compatibility_test/configurators/apache/common.py', 'new_path': 'certbot-compatibility-test/certbot_compatibility_test/configurators/apache/common.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,21 +1,26 @@\n """Provides a common base for Apache proxies"""\n+i... | Python |
89ccbccff0582728faf9c48d1e055bd6d1218d1f | 166 | 2021-12-14 12:38:14+11:00 | -3,600 | ['cb3e1403cdf0b1e00a384c06bdc85b70b2bf0a09'] | Fully type all DNS plugins (#9125)
* Add types in all DNS plugins
* Order imports
* Fix type
* Update certbot-dns-route53/certbot_dns_route53/_internal/dns_route53.py
Co-authored-by: alexzorin <alex@zor.io>
* Clean up imports
Co-authored-by: alexzorin <alex@zor.io> | [{'old_path': 'certbot-dns-cloudflare/certbot_dns_cloudflare/_internal/dns_cloudflare.py', 'new_path': 'certbot-dns-cloudflare/certbot_dns_cloudflare/_internal/dns_cloudflare.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,6 +1,7 @@\n """DNS Authenticator for Cloudflare."""\n import logging\n from typing impo... | Python |
1577cd866308f98394278038f6fc95878f3d973e | 225 | 2021-12-21 09:28:31-07:00 | 25,200 | ['89ccbccff0582728faf9c48d1e055bd6d1218d1f'] | write docs on how to test release script (#9142)
Alexis (rightfully) wasn't sure how to test this when working on https://github.com/certbot/certbot/pull/9076. This PR documents it in the script based on what I wrote at https://github.com/certbot/certbot/pull/8351#issue-715227127 which I reverified. | [{'old_path': 'tools/finish_release.py', 'new_path': 'tools/finish_release.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -19,6 +19,14 @@ Setup:\n Run:\n \n python tools/finish_release.py ~/.ssh/githubpat.txt\n+\n+Testing:\n+\n+This script can be safely run between releases. When this is done, the script\n+shou... | Python |
a391a34631059b0b398f90f8ccac22e7054ad5fe | 325 | 2021-12-22 08:20:01+11:00 | 14,400 | ['1577cd866308f98394278038f6fc95878f3d973e'] | Add appending behaviour of `max-log-backups = 0` (#9146) | [{'old_path': 'certbot/docs/using.rst', 'new_path': 'certbot/docs/using.rst', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1151,7 +1151,8 @@ certbot will begin rotating logs once there are 1000 logs in the log directory.\n Meaning that once 1000 files are in ``/var/log/letsencrypt`` Certbot will delete\n the olde... | Python |
93c2852fdba34f14b294b38dcd27a0a8d94fe053 | 325 | 2021-12-27 19:12:52+11:00 | -3,600 | ['a391a34631059b0b398f90f8ccac22e7054ad5fe'] | Add `show_account` subcommand to retrieve account info from ACME server (#9127)
* Fetch and print account contacts from ACME server
* Add tests
* Add changelog entryAdd changelog entry
* Add account URI and thumbprint output
Only show these items when verbosity > 0
* Add test case for account URI and th... | [{'old_path': 'certbot/CHANGELOG.md', 'new_path': 'certbot/CHANGELOG.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -6,7 +6,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).\n \n ### Added\n \n-*\n+* Added `show_account` subcommand, which will fetch the account information\n+ from the ACME se... | Python |
dc66c879283c6c8b27dbcdd5d5faa4fe271e3e8f | 491 | 2022-01-02 00:22:52+01:00 | -3,600 | ['93c2852fdba34f14b294b38dcd27a0a8d94fe053'] | Remove win2016 from Azure devops pipelines. (#9145)
From March 2022, support will be removed.
https://github.com/actions/virtual-environments/issues/4312 | [{'old_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'new_path': '.azure-pipelines/templates/jobs/packaging-jobs.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -54,8 +54,12 @@ jobs:\n done\n displayName: Run integration tests for Docker images\n - job: installer_build\n- p... | Python |
00f98fa9115a1a639fa64bb0e0fcf823ab08a851 | 181 | 2022-01-02 00:23:24+01:00 | -39,600 | ['dc66c879283c6c8b27dbcdd5d5faa4fe271e3e8f'] | letstest: bump ubuntu groovy to impish (#9155) | [{'old_path': 'letstest/targets/apache2_targets.yaml', 'new_path': 'letstest/targets/apache2_targets.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -6,8 +6,8 @@\n targets:\n #-----------------------------------------------------------------------------\n #Ubuntu\n- - ami: ami-0f2e2c076f4c2f941\n- name... | Python |
eeca208c8f57304590ac1af80b496e61021aaa45 | 491 | 2022-01-02 00:27:47+01:00 | -3,600 | ['00f98fa9115a1a639fa64bb0e0fcf823ab08a851'] | Various clean-ups in certbot-apache. Use f-strings. (#9132)
* Various clean-ups in certbot-apache. Use f-strings.
* Smaller tweaks | [{'old_path': 'certbot-apache/certbot_apache/_internal/apache_util.py', 'new_path': 'certbot-apache/certbot_apache/_internal/apache_util.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -172,8 +172,7 @@ def parse_includes(apachectl):\n :rtype: list of str\n """\n \n- inc_cmd = [apachectl, "-t", "-D",\n... | Python |
a0dbe1e85035f12e194d91148836d830871ec554 | 491 | 2022-01-03 22:05:21+01:00 | -3,600 | ['eeca208c8f57304590ac1af80b496e61021aaa45'] | Improve assertions in certbot-apache tests. (#9131)
* Improve assertions in certbot-apache tests.
Replacements inspired by flake8-assertive.
* Fix test failures
* assertEqual is not for None :D
* Pass all tests :) | [{'old_path': 'certbot-apache/tests/augeasnode_test.py', 'new_path': 'certbot-apache/tests/augeasnode_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -25,24 +25,29 @@ def _get_augeasnode_mock(filepath):\n metadata=metadata)\n return augeasnode_mock\n \n+\n class AugeasParserNodeTest(util.Apa... | Python |
ed7964b424345b5d8ad98335be8f98d5c21059a6 | 491 | 2022-01-04 23:59:58+01:00 | -3,600 | ['97a09dee19273a6c43aa71edc04ecfae3e761314'] | Improve assertions in nginx and DNS plugin tests. (#9157)
* Improve assertions in nginx and DNS plugin tests.
* Use assertIs for asserting is True/False. | [{'old_path': 'certbot-dns-google/tests/dns_google_test.py', 'new_path': 'certbot-dns-google/tests/dns_google_test.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -184,9 +184,9 @@ class GoogleClientTest(unittest.TestCase):\n with mock.patch(mock_get_rrs) as mock_rrs:\n mock_rrs.return_value =... | Python |
7e5e51aeff46d5cda0ee92f64b9ba4b5058f5dd7 | 491 | 2022-01-09 22:50:44+01:00 | -3,600 | ['ed7964b424345b5d8ad98335be8f98d5c21059a6'] | Use super().__init__ instead of explicitly calling named super-class. (#9166)
* Use super().__init__ instead of explicitly calling named super-class.
* Fix unittest (typo fix). | [{'old_path': 'acme/acme/standalone.py', 'new_path': 'acme/acme/standalone.py', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -34,10 +34,9 @@ class TLSServer(socketserver.TCPServer):\n else:\n self.address_family = socket.AF_INET\n self.certs = kwargs.pop("certs", {})\n- self.meth... | Python |