instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
Textualize__textual-2532 | [
{
"changes": {
"added_entities": [
"src/textual/app.py:App.validate_title",
"src/textual/app.py:App.validate_sub_title"
],
"added_modules": null,
"edited_entities": [
"src/textual/app.py:App.__init__"
],
"edited_modules": [
"src/textual/app.py:... | Textualize/textual | f19f46bba0e5fa164bbd2abcc02913b0a856203a | App title and sub_title should be converted to strings
I'm thinking that `App.title` and `App.sub_title` should be converted to strings.
Balancing convenience with hiding errors, this is probably the right thing to do 90% of the time. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2e65e54e2..2992a923b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,7 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-2568 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_input.py:Input._on_paste"
],
"edited_modules": [
"src/textual/widgets/_input.py:Input"
]
},
"file": "src/textual/widgets/_input.py"
}
] | Textualize/textual | 83618db642187a77ab13d0585c9ab56d60877dd7 | Pasting in Input with an empty string crashes the program
Pressing middle mouse button to paste causes this error in `Input._on_paste` if the clipboard is empty of text:
```
╭───────────────────────────────────────────────────────────────────────── Traceback (most recent call last) ─────────────────────────────────... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1e7cdebf4..5991f818d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed `TreeNode.collapse` and `TreeNode.collapse_all` not posting a `Tree.NodeCollapsed` message https://github.com... |
Textualize__textual-2580 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/screen.py:Screen.dismiss"
],
"edited_modules": [
"src/textual/screen.py:Screen"
]
},
"file": "src/textual/screen.py"
}
] | Textualize/textual | 6147c28dbf86c0d09a75b179b68fae1aeae1b26c | Screen.dismiss should error if not the top-most screen
At the moment if you call `dismiss` on a screen that is *not* the top-most on the stack, strange things will happen.
I think the only solution here is for that to be an error.
i.e. if I push screens A, B, C on to the stack. Then I call `B.dismiss()` that should r... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5991f818d..bce29efda 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- App `title` and `sub_title` attributes can be set to any type https://github.com/Textualize/textual/issues/2521
... |
Textualize__textual-2621 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_footer.py:Footer._on_leave"
],
"edited_modules": [
"src/textual/widgets/_footer.py:Footer"
]
},
"file": "src/textual/widgets/_footer.py"
}
] | Textualize/textual | 5c1c62edd06741417f7640fbe92d52fffb1a2335 | Pushing a screen should send Leave message
If you have an action that opens a screen, it leaves the footer stuck in the highlight state.
I think we need to call `_set_mouse_over(None)` on the current screen when pushing another screen. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2ba7ec153..d838c46f5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Changed
- `Placeholder` now sets its color cycle per app https://github.com/Textualize/textual/issues/2590
+- ... |
Textualize__textual-2628 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/textual/app.py:App"
]
},
"file": "src/textual/app.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_e... | Textualize/textual | 607939e41d9ecf2b8f84e337a956010acefdc79e | AUTO_FOCUS on App should apply to screen
If you don't define a screen, there is no way to set `AUTO_FOCUS`. We should make `AUTO_FOCUS` on App apply to the default screen. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3085106dd..41bfd46c2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,12 +10,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- `work` decorator accepts `description` parameter to add debug string https://github.com/Textualize/t... |
Textualize__textual-2687 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/_compositor.py:Compositor.reflow"
],
"edited_modules": [
"src/textual/_compositor.py:Compositor"
]
},
"file": "src/textual/_compositor.py"
},
{
"cha... | Textualize/textual | a40300a6f5f78c5b2dd41bf36e282cbea2af7ff1 | It looks like `on_hide` is not called when a widget is hidden in some way
I would expect the following application to crash when the button is pressed:
```python
from textual.app import App, ComposeResult
from textual.containers import Vertical
from textual.widgets import Button, Label
class ShouldCr... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5cc55decb..fe30a9778 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed zero division error https://github.com/Textualize/textual/issues/2673
- Fix `scroll_to_center` when there ... |
Textualize__textual-2692 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/app.py:App.switch_screen"
],
"edited_modules": [
"src/textual/app.py:App"
]
},
"file": "src/textual/app.py"
}
] | Textualize/textual | 3dea4337ace9fd0727d0f1d799f62a7e6a249023 | Report a bug about switch_screen
```python
from textual.app import App, ComposeResult
from textual.screen import Screen
from textual.widgets import Static, Header, Footer
class ScreenA(Screen):
def compose(self) -> ComposeResult:
yield Header()
yield Static("A")
yield Footer()
c... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7de004cfe..03f7142ac 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed zero division error https://github.com/Textualize/textual/issues/2673
- Fix `scroll_to_center` when there ... |
Textualize__textual-2776 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widget.py:Widget.watch_disabled"
],
"edited_modules": [
"src/textual/widget.py:Widget"
]
},
"file": "src/textual/widget.py"
}
] | Textualize/textual | 436b1184a9013295e903ce5d86641b9e57cfb014 | Shouldn't be able to type in to a disabled input
If a widget is *enabled* and has focus, then subsequently *disabled*, you are still able to type.
When an input is disabled, it should ignore all interactions. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2d887f32b..e9c9c2004 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed exceptions in Pilot tests being silently ignored https://github.com/Textualize/textual/pull/2754
- Fixed iss... |
Textualize__textual-2981 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_switch.py:Switch._on_click"
],
"edited_modules": [
"src/textual/widgets/_switch.py:Switch"
]
},
"file": "src/textual/widgets/_switch.py"
}
] | Textualize/textual | 2f055f6234928a37207759bc48876965905dc966 | `Switch` should stop the `Click` event from bubbling
At the moment `Switch` handles `Click` but then lets it bubble; there's no good reason to do that and it also stops the ability to write something like this:
```python
from textual.app import App, ComposeResult
from textual.containers import Horizontal
f... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6d9b2b217..bf9a3b79b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- Fixed a crash when a `SelectionList` had a prompt wider than itself https://github.com/Textualize/text... |
Textualize__textual-2984 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/css/parse.py:substitute_references"
],
"edited_modules": [
"src/textual/css/parse.py:substitute_references"
]
},
"file": "src/textual/css/parse.py"
}
] | Textualize/textual | 42dc3af34725245dca9b43608d0bbe8f636fdd4b | Allow for empty CSS variable definitions
Consider the following CSS snippets:
1.
```sass
$x:
* {
background: red;
}
```
2.
```sass
$x:
* {
background: $x;
}
```
3.
```sass
* {
background: red;
}
$x:
```
All three should work with the following behaviour:
- an empty variable... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index bf9a3b79b..ec1c24b51 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed a crash when a `SelectionList` had a prompt wider than itself https://github.com/Textualize/textual/issues/... |
Textualize__textual-2987 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/textual/events.py:MouseMove"
]
},
"file": "src/textual/events.py"
},
{
"changes": {
"added_entities": [
"src/textual/screen.py:Scree... | Textualize/textual | 49612e3aa5ddf3e16bd959199a8886c3f8d2328d | Send mouse move events to screen
It look like mouse move events never make it to the Screen object. I think they should. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8e9bfe956..5535d3101 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed unintuitive sizing behaviour of TabbedContent https://github.com/Textualize/textual/issues/2411
- Fixed rela... |
Textualize__textual-2988 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_directory_tree.py:DirectoryTree.clear_node",
"src/textual/widgets/_directory_tree.py:DirectoryTree.reset_node",
"src/textual/widgets/_directory_tree.py:DirectoryTree.reload_node"
],
"added_modules": null,
"e... | Textualize/textual | be2ec1daaf1d5c7ce0c8dc3bebcee664ab62bc15 | Add a method to `DirectoryTree` that allows for reloading an individual node
The question cropped up on Discord and seems like a useful thing to have: the ability to say "clear out and reload this specific node" when using `DirectoryTree` -- a developer may know that a specific directory has been modified and they want... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5535d3101..b9078861c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- Added an interface for replacing prompt of an individual option in an `OptionList` https://github.com/... |
Textualize__textual-3001 | [
{
"changes": {
"added_entities": [
"src/textual/app.py:App.action_switch_mode"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/textual/app.py:App"
]
},
"file": "src/textual/app.py"
},
{
"changes": {
"added_enti... | Textualize/textual | cb81b6d7a69e0c769047904d25527d83175f8fe2 | Add `action_switch_mode`
Following on from #2327 it would seem to make sense to add a `switch_mode` `action_` method, much like the various `Screen`-oriented `App` methods also have `action_` wrappers. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d30a40458..faf8499e0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,9 +10,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- Added App.begin_capture_print, App.end_capture_print, Widget.begin_capture_print, Widget.end_capture_p... |
Textualize__textual-3002 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_directory_tree.py:DirectoryTree.render_label"
],
"edited_modules": [
"src/textual/widgets/_directory_tree.py:DirectoryTree"
]
},
"file": "src/textu... | Textualize/textual | baee05a4392ad4e78935222d9f0d2a24192b1b6b | Setting `show_root` to `True` raises a `KeyError`
```py
def compose(self):
dir_tree = DirectoryTree("./src/routes")
dir_tree.show_root = True
yield Header()
with Horizontal():
yield Logo()
with TabbedContent("Config", "Routes", "Server"):
... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 50dc3f19e..3a6040bb6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- Parameter `animate` from `DataTable.move_cursor` was being ignored https://github.com/Textualize/textu... |
Textualize__textual-3050 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/keys.py:_get_key_display"
],
"edited_modules": [
"src/textual/keys.py:_get_key_display"
]
},
"file": "src/textual/keys.py"
}
] | Textualize/textual | 81808d93c9fa122c4b3dd9ab1a6a934869937320 | Binding for `]` renders incorrectly in `Footer`
The binding `Binding("ctrl+right_square_bracket", "toggle_indent_width", "Cycle indent width")` renders like this:
<img width="431" alt="image" src="https://github.com/Textualize/textual/assets/5740731/2c2bd6fa-288b-4205-aba0-48eb1b6c41e0">
It should probably render... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 705eb5dd3..8019a5f1b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Ensuring `TextArea.SelectionChanged` message only sends when the updated selection is different https://github.com/... |
Textualize__textual-3152 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_tabbed_content.py:TabPane._watch_disabled",
"src/textual/widgets/_tabbed_content.py:TabbedContent._on_tab_pane_disabled",
"src/textual/widgets/_tabbed_content.py:TabbedContent._on_tab_pane_enabled"
],
"added_modul... | Textualize/textual | 695e59bd3a08e901e5ad2c63ce09cd9c5307f6fc | The `disabled` parameter for a `TabPane` should disable a tab
Consider this code:
```python
from textual.app import App, ComposeResult
from textual.widgets import TabbedContent, TabPane, Label
class DisableTabApp(App[None]):
def compose(self) -> ComposeResult:
with TabbedContent(id="top-level"):... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f30d0dc33..6626a0b4c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased
+### Added
+
+- Ability to enable/disable tabs via the reactive `disabled` in tab panes https://githu... |
Textualize__textual-3193 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/textual/types.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/wid... | Textualize/textual | 7d4a47b2535f4836d1251e9d06aed23cb3fd05b9 | Validation on blur
Currently validation is done on input change and submit. I think we also need to do it on blur.
Consider a password check. I find it super irritating when validation shows an error before I'm done typing.
It should probably also be configrable. So the dev can decide when the validation happens. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8666691fd..35e4c63ef 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
+- `Input` is now validated when focus moves out of it https://github.com/Textualize/textual/pull/3193
+-... |
Textualize__textual-3202 | [
{
"changes": {
"added_entities": [
"src/textual/app.py:App.return_code"
],
"added_modules": null,
"edited_entities": [
"src/textual/app.py:App.__init__",
"src/textual/app.py:App.exit",
"src/textual/app.py:App.run_test",
"src/textual/app.py:App._han... | Textualize/textual | c133152f58daa6872964ab9cceae77478cececb5 | Revise error codes
We need a way for a Textual app to generate a return code that would be used as the process return code.
- `App.return_code` should be 0 by default
- `App.exit` should accept an optional return code which will set `App.return_code`
- A fatal error should set a return code of 1.
Textual apps ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5c463bd7c..9acc6bd38 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- TCSS styles `layer` and `layers` can be strings https://github.com/Textualize/textual/pull/3169
+- `Ap... |
Textualize__textual-3244 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "examples/markdown.py"
},
{
"changes": {
"added_entities": [
"src/textual/widgets/_markdown.py:Markdown.sanitize_location",
"src/... | Textualize/textual | d31fb82239fc5e1ad345165484285e3b8e9003ee | [MarkdownViewer] opening an anchor link results in a crash
With `MarkdownViewer` clicking on any link that has an anchor link `uri/path.md#-someanchor` will raise `FileNotFoundError`.
Anchor links are pretty common in markdown and it's not always possible to control the content of the file being read as long as it i... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4f55dc7ab..ab6c6d4c2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,12 +23,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- Fixed a crash when removing an option from an `OptionList` while the mouse is hovering over the last... |
Textualize__textual-3274 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_option_list.py:OptionList._remove_option"
],
"edited_modules": [
"src/textual/widgets/_option_list.py:OptionList"
]
},
"file": "src/textual/widgets... | Textualize/textual | 74aa90f5ac3e9cbd5e002cf504241a9b2d257930 | Removing an option from an `OptionList` when the mouse is hovering over the last item causes a crash
Given this code:
```python
from textual import on
from textual.app import App, ComposeResult
from textual.widgets import OptionList
class OptionListRemoveOnDeleteApp(App[None]):
def compose(self) -> Comp... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index aeaecf207..e824df982 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-3334 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_markdown.py:Markdown.goto_anchor"
],
"edited_modules": [
"src/textual/widgets/_markdown.py:Markdown"
]
},
"file": "src/textual/widgets/_markdown.py... | Textualize/textual | 79e9f3bc16cefd9a9b2bece2b11bfa3ce35422b9 | Return boolean from Markdown.goto_anchor
Hey again!
I'm updating my code to work with Textual now that it has fixed going to anchors in a Markdown document.
Textual is working well, however I'm facing an issue while trying to extend its behavior.
Basically, in the Markdown documents I generate (in my API docs te... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8f29d01ec..65b8b69b3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed the command palette crashing with a `TimeoutError` in any Python before 3.11 https://github.com/Textualize/t... |
Textualize__textual-3396 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/pilot.py:Pilot.click",
"src/textual/pilot.py:Pilot.hover"
],
"edited_modules": [
"src/textual/pilot.py:Pilot"
]
},
"file": "src/textual/pilot.py"
... | Textualize/textual | 4d1f057968fcef413e1ec4d4f210440a9b46db8a | Pilot.click can't use `Screen` as selector.
If you try something like `pilot.click(Screen)`, you get a `NoMatches` exception from the query. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 35a0624f8..c401104de 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-3409 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_tree.py:Tree.__init__"
],
"edited_modules": [
"src/textual/widgets/_tree.py:Tree"
]
},
"file": "src/textual/widgets/_tree.py"
}
] | Textualize/textual | d766bb95666e24e52b19e9e475e4f0931f1154d0 | Tree `disabled=True` breaks when setting at initialization
Using the `Tree` example from the docs, if you pass in `disabled=True` during initialization the app break with 2 exceptions.
**Thrown Exceptions:**
1. `AttributeError: 'Tree' object has no attribute '_line_cache'`
2. `ScreenStackError: No screens on stack... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 330dac5bf..6fbc58b44 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- `Pilot.click`/`Pilot.hover` can't use `Screen` as a selector https://github.com/Textualize/textual/iss... |
Textualize__textual-3430 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_input.py:Input.clear"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/textual/widgets/_input.py:Input"
]
},
"file": "src/textual/widgets/_input.py"
}
] | Textualize/textual | dee745929face3336141247d74e4195b479dbacc | [FEAT] Add `Input.clear` method
Following discussions in #3427, it would make sense to add a `Input.clear` method.
I'm happy to a submit a PR, if it helps. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 41d543fc8..a52f8df41 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- `OutOfBounds` exception to be raised by `Pilot` https://github.com/Textualize/textual/pull/3360
+- Add... |
Textualize__textual-3432 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/css/_style_properties.py:FractionalProperty.__set__"
],
"edited_modules": [
"src/textual/css/_style_properties.py:FractionalProperty"
]
},
"file": "src/text... | Textualize/textual | 3aaecd39200c2251cb9af8e450c5291839638b7f | Fractional styles raise exception when set to integers
Although technically correct (the best kind of correct), it's quite awkward that you can't do something like
```py
some_widget.styles.text_opacity = 0
```
This raises an exception because `0` is not a float.
Text opacity – and the other related styles – sh... | diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
index 7eca7607d..e056fa114 100644
--- a/.github/workflows/pythonpackage.yml
+++ b/.github/workflows/pythonpackage.yml
@@ -41,7 +41,7 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ matrix.python-version }}-$... |
Textualize__textual-3459 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_option_list.py:OptionList._duplicate_id_check"
],
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_option_list.py:OptionList._refresh_content_tracking",
"src/textual/widgets/_option_list.py:... | Textualize/textual | 6d79e7782d0d4e50e6e953db7d03da85090831ab | `OptionList` duplicate ID detection not working as expected
Consider the following code:
```python
from textual.app import App, ComposeResult
from textual.widgets import OptionList, Log, Footer
from textual.widgets.option_list import Option
class OptionListAddBug(App[None]):
BINDINGS = [
(str(n... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 75d2eb356..428b546f8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- `Pilot.click`/`Pilot.hover` can't use `Screen` as a selector https://github.com/Textualize/textual/issues/3395
- A... |
Textualize__textual-3495 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/driver.py:Driver.__init__",
"src/textual/driver.py:Driver.process_event"
],
"edited_modules": [
"src/textual/driver.py:Driver"
]
},
"file": "src/tex... | Textualize/textual | ef1aebd4c3fc5757d0fb50f0576a02d9f22dd985 | Border demonstration acts improperly under scrolling
Recipe to reproduce:
Run `textual borders`. Click on `[Heavy`]. Border will change. Scroll down buttons panel to click on `[Wide]`. At top of screen click topmost visible button (in my case `[Heavy]`, but YMMV). _Ensure that only the bottom two rows of the topmost... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c37d8f9f5..074af2235 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- `is_blank`
- Constant `Select.BLANK` to flag an empty selection https://github.com/Textualize/textual/pull/3614
... |
Textualize__textual-3582 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/app.py:App._load_screen_css",
"src/textual/app.py:App._process_messages"
],
"edited_modules": [
"src/textual/app.py:App"
]
},
"file": "src/textual/a... | Textualize/textual | c19ffe3f92b11dc8e1295e59fbc46fd97f6aba93 | CSS errors have a broken path
CSS errors will create an invalid path to the CSS, if the CSS is in code. This is because it adds the widget name to the path.
Here's an example:
If you click the heading it should take yo... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index b3ea067bc..2c6ecb38e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).
+## Unreleased
+
+### Changed
+
+- CSS error... |
Textualize__textual-3659 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/css/tokenizer.py:TokenError._get_snippet",
"src/textual/css/tokenizer.py:Token.start",
"src/textual/css/tokenizer.py:Token.end",
"src/textual/css/tokenizer.py:Tokeniz... | Textualize/textual | 7a25bb19980ba14c4a49e5e70d5fafc21caecd70 | CSS error reporting sometimes off by one
See https://github.com/Textualize/textual/pull/3582#issuecomment-1787507687.
Running the app at the bottom produces the error below, where the error reporting is off by one.
See the line above the panel and the code lines in the code snippet printed.
```
Error in styles... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c2589f911..496739944 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed outline not rendering correctly in some scenarios (e.g. on Button widgets) https://github.com/Textualize/text... |
Textualize__textual-3825 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_collapsible.py:Collapsible._on_collapsible_title_toggle"
],
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_collapsible.py:Collapsible.on_collapsible_title_toggle"
],
"edited_modules": ... | Textualize/textual | 2a67b6d15c9299a86259491b400438dcd5ed009c | Add message `Collapsible.Toggled`
What it says on the tin. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cd28386fd..ddd8fb60d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- Added `get_loading_widget` to Widget and App customize the loading widget. https://github.com/Textuali... |
Textualize__textual-3830 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"docs/examples/guide/workers/weather05.py:WeatherApp.update_weather"
],
"edited_modules": [
"docs/examples/guide/workers/weather05.py:WeatherApp"
]
},
"file": "docs/exam... | Textualize/textual | c6aef4b8b951e7ba4c78433b47a47d8f925c4730 | Make Title of a Collapsible Widget Editable
Can not update title property of the Collapsible widget , looking at CollapsibleTitle class it seems to only set at init
Looks like this was an intentional choice ?
But I think it would be helpful to make the title property editable ,
Eg: changing content in the collapsed ... | diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
index 882da2b35..02e367aa4 100644
--- a/.github/workflows/pythonpackage.yml
+++ b/.github/workflows/pythonpackage.yml
@@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
- ... |
Textualize__textual-3872 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_radio_set.py:RadioSet._move_selected_button"
],
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_radio_set.py:RadioSet._on_mount",
"src/textual/widgets/_radio_set.py:RadioSet.action_previous... | Textualize/textual | 49e71862688a60e5e29f6bb60084e45890a65285 | RadioButton still selectable by keyboard when disabled
It appears that when a `RadioButton` is disabled, click events no longer respond as expected, but you can still navigate to it with the keyboard and select it with `space` or `enter`.
and this project adheres to [Semantic Versioning]... |
Textualize__textual-3896 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widget.py:Widget.move_child"
],
"edited_modules": [
"src/textual/widget.py:Widget"
]
},
"file": "src/textual/widget.py"
}
] | Textualize/textual | 1c8dc5d74e4e791f746cdc8a10c0272c9e1dff97 | Make moving a child before or after itself, a no-op
If we try to use `move_child` to move a widget to after/before itself, should we get an error or is that a no-op?
(Add tests to tests/test_widget_child_moving.py accordingly.)
Context: this arose from writing some functionality in a TODO app that sorts TODO items ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5303ec554..177202444 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-3965 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_data_table.py:DataTable.watch_cursor_coordinate",
"src/textual/widgets/_data_table.py:DataTable.move_cursor"
],
"edited_modules": [
"src/textual/widgets/... | Textualize/textual | cf46d4e70f29cd7e8b7263954e9c7f1d431368eb | DataTable move_cursor animate doesn't do anything?
While working on:
- https://github.com/Textualize/textual/discussions/3606
I wanted to check `animate` for `move_cursor` behaves correctly, but it doesn't seem to do anything?
---
Repro:
```py
from random import randint
from textual.app import App, C... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e901d67b4..50dc3f19e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-3988 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_option_list.py:OptionList.__init__",
"src/textual/widgets/_option_list.py:OptionList._clear_content_tracking",
"src/textual/widgets/_option_list.py:OptionList._refre... | Textualize/textual | 35fe5b82402454c7a80f240d0c784f6d4d062589 | get_option in SelectionList not working
The function `get_option` in `SelectionList` does not work as intended. The following raises `OptionDoesNotExist`
```
from textual.app import App
from textual.widgets import SelectionList
from textual.widgets.selection_list import Selection
class QuickApp(App):
def ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 288a4c420..d3f838be7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Parameter `animate` from `DataTable.move_cursor` was being ignored https://github.com/Textualize/textual/issues/384... |
Textualize__textual-4030 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/textual/_types.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/re... | Textualize/textual | b28ad500a3da98bfcde25a71082303d82270491d | A `watch` on a reactive that is declared `init=False` fires watch method on init
[Stemming from a question on Discord](https://discord.com/channels/1026214085173461072/1033754296224841768/1185161330462838784); consider this code:
```python
from textual.app import App, ComposeResult
from textual.reactive import var... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 302b617c4..a826849fa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-4032 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/dom.py:check_identifiers"
],
"edited_modules": [
"src/textual/dom.py:check_identifiers"
]
},
"file": "src/textual/dom.py"
}
] | Textualize/textual | 2983d6140a3cd15c08359f529c460c9e9f72f715 | It is possible to give a widget an ID that can't be queried back
It is possible to give a widget an ID that can't then be queried back; for example:
```python
from textual.app import App, ComposeResult
from textual.widgets import Label
class BadIDApp(App[None]):
def compose(self) -> ComposeResult:
... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 44a95d744..bc2657ad1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- `SelectionList` option IDs are usable as soon as the widget is instantiated https://github.com/Textualize/textual/i... |
Textualize__textual-4040 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/textual/css/tokenize.py"
}
] | Textualize/textual | b13a215372d0b4aef605e1162faa0581615a09ad | Nesting selectors in a selector list causes a stylesheet error
If you have a stylesheet like this:
```python
from textual.app import App, ComposeResult
from textual.widgets import Label
class NestedCSSTokenErrorApp(App[None]):
CSS = """
Label {
&.foo, &.bar {
border: solid red;... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2bb816e2a..c975d2f84 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Renamed `TextArea.tab_behaviour` to `TextArea.tab_behavior` https://github.com/Textualize/textual/pull/4124
+#... |
Textualize__textual-4079 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/app.py:App._on_css_change"
],
"edited_modules": [
"src/textual/app.py:App"
]
},
"file": "src/textual/app.py"
},
{
"changes": {
"added_entities... | Textualize/textual | f017604cfcc1265f4713808ac6f073d1296a15c9 | Editing CSS with e.g. vim can crash an app
Editing the CSS of a running app (with the `--dev` switch) using e.g. `vim` causes frequent crashes when saving the changed CSS.
The code that causes it is: https://github.com/Textualize/textual/blob/4da008d5cb5d4c8485c57969b6c27b1bedeae0fc/src/textual/file_monitor.py#L32-L... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1844edd8e..8bb59c36a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Ensuring `TextArea.SelectionChanged` message only sends when the updated selection is different https://github.com/... |
Textualize__textual-4103 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_option_list.py:OptionList.add_options"
],
"edited_modules": [
"src/textual/widgets/_option_list.py:OptionList"
]
},
"file": "src/textual/widgets/_o... | Textualize/textual | 8ae0b27bc8a18237e568430fc9f74c3c10f8e0a5 | `Option` indexing appears to break after an `OptionList.clear_options` and `OptionList.add_option(s)`
This looks to be a bug introduced in v0.48 of Textual. Consider this code:
```python
from textual import on
from textual.app import App, ComposeResult
from textual.reactive import var
from textual.widgets import... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d3796faf7..fe0830770 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased
+### Fixed
+
+- Fixed broken `OptionList` `Option.id` mappings https://github.com/Textualize/textual... |
Textualize__textual-4125 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_text_area.py:TextArea._on_key"
],
"edited_modules": [
"src/textual/widgets/_text_area.py:TextArea"
]
},
"file": "src/textual/widgets/_text_area.py"... | Textualize/textual | 5d6c61afa0f4cc225e2c6ecea11163556a7a37ef | `TextArea` still uses `Escape` to move focus on
While "out of the box" `TextArea` now uses <kbd>Tab</kbd> to shift focus, it also still uses <kbd>Escape</kbd>, ideally it would not when in this mode. Pressing <kbd>Escape</kbd> to exit a modal dialog would be common, so having <kbd>Escape</kbd> do something different gi... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 32facd86a..916101fc9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,12 +5,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-4159 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_tabbed_content.py:TabbedContent._on_tabs_tab_activated",
"src/textual/widgets/_tabbed_content.py:TabbedContent._watch_active"
],
"edited_modules": [
"src... | Textualize/textual | fa4f75fd25c625d150e11c476bf468bf506c3400 | TabbedContent active attribute doesn't post message TabActivated + doesn't arrange tabs
Hello,
I noticed that when using `active` reactive attribute, there is no message posted to `TabActivated`. I also noticed that if the tab bar is larger than the terminal, it doesn't correctly adjust the tabs to show what's aroun... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5826989c7..48df1194d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Add some syntax highlighting to TextArea default theme https://github.com/Textualize/textual/pull/4149
- Add undo... |
Textualize__textual-4183 | [
{
"changes": {
"added_entities": [
"src/textual/widget.py:Widget.batch"
],
"added_modules": null,
"edited_entities": [
"src/textual/widget.py:Widget.remove_children"
],
"edited_modules": [
"src/textual/widget.py:Widget"
]
},
"file": "src/... | Textualize/textual | ba17dfb56f16a3f517a16904c7765d08a0df8561 | Add `remove` attribute to `mount` and `mount_all`
It's common to remove some widgets and add some other widgets. To make this easier, I think we should add a `remove` attribute to the mount methods which accepts a selector and removes those widgets prior to mounting.
The remove + mount should be atomic, to avoid flick... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7e02eb239..409cd5e67 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Add attribute `App.animation_level` to control whether animations on that app run or not https://github.com/Textual... |
Textualize__textual-4196 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/renderables/sparkline.py:Sparkline._buckets",
"src/textual/renderables/sparkline.py:Sparkline.__rich_console__"
],
"edited_modules": [
"src/textual/renderables/sp... | Textualize/textual | 5aaa6b539cda123415512bb4b49bf60c007f1e3b | Sparklines do not work with collections.deque
```python
from collections import deque
from textual.app import App, ComposeResult
from textual.widgets import Sparkline
data = deque([1, 2, 2, 1, 1, 4, 3, 1, 1, 8, 8, 2])
class SparklineBasicApp(App[None]):
def compose(self) -> ComposeResult:
yie... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2b6eb7ff0..449eb7581 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- Fixed `TextArea.code_editor` missing recently added attributes https://github.com/Textualize/textual/p... |
Textualize__textual-4210 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_directory_tree.py:DirectoryTree.watch_path"
],
"edited_modules": [
"src/textual/widgets/_directory_tree.py:DirectoryTree"
]
},
"file": "src/textual... | Textualize/textual | 65c4cce2156e062a199f3ef250c403013168c8d0 | DirectoryTree.path no longer reactive
The `DirectoryTree.path` variable changing values no longer reloads the widget when it's changed. This behavior changed on the [0.49.0 release](https://github.com/Textualize/textual/releases/tag/v0.49.0).
I expected the `path` attribute to be reactive, according to the `watch_p... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a3534132a..2df2b1993 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed `Sparkline` not working with data in a `deque` https://github.com/Textualize/textual/issues/3899
- Tooltips ... |
Textualize__textual-4264 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"docs/examples/how-to/render_compose.py:Splash.render"
],
"edited_modules": [
"docs/examples/how-to/render_compose.py:Splash"
]
},
"file": "docs/examples/how-to/render_c... | Textualize/textual | 826ffd40228501a7ea31eb88be073abb45692839 | Tidy the return type of `App.render`
Currently the return type of `App.render` is `RenderableType`; in our docs and in most places we talk about `App.render` returning a `RenderResult`. `RenderResult` is an alias for `RenderableType` and is a top-level value in `textual.app`.
This can cause a lint/type warning in de... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5b3d4909d..882082bab 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,7 +12,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Mapping of ANSI colors to hex codes configurable via `App.ansi_theme_dark` and `App.ansi_theme_light` https://githu... |
Textualize__textual-4266 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_switch.py:Switch.action_toggle_switch"
],
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_switch.py:Switch.action_toggle"
],
"edited_modules": [
"src/textual/widgets/_switch.py:... | Textualize/textual | f7d6dc89edef82ca089f233a58ce61db98d09b7e | `Switch.action_toggle` name clash
Similar to #4214 `Switch` has an `action_toggle` method whose name and form clash with `DOMNode.action_toggle`. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5b3d4909d..3aa2cf3dd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed `RichLog.min_width` not being used https://github.com/Textualize/textual/pull/4223
- Rename `CollapsibleTitl... |
Textualize__textual-4313 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/app.py:App._broker_event"
],
"edited_modules": [
"src/textual/app.py:App"
]
},
"file": "src/textual/app.py"
}
] | Textualize/textual | 154a6315939c302b4f6198426067651144fee685 | Malformed @click links crash Textual application
# Context
I was just trying out the `@click` syntax.
# Expected behaviour
If I create e.g. a Label with incorrect markup, I should get a MarkupError immediately.
# Current behaviour
Some `@click` syntax do not raise a MarkupError and make Textual applicati... | diff --git a/src/textual/app.py b/src/textual/app.py
index aaf799a66..15811232c 100644
--- a/src/textual/app.py
+++ b/src/textual/app.py
@@ -3006,11 +3006,18 @@ class App(Generic[ReturnType], DOMNode):
return False
else:
event.stop()
- if isinstance(action, (str, tuple)):
+ ... |
Textualize__textual-436 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/css/_style_properties.py:ScalarProperty.__set__"
],
"edited_modules": [
"src/textual/css/_style_properties.py:ScalarProperty"
]
},
"file": "src/textual/css/... | Textualize/textual | efafbdfcc16fdd3c7e9b5906fc7d8cc6e354f70e | `display: none` is being ignored in vertical and horizontal layouts
Example app:
```python
from textual.app import App
from textual.widget import Widget
class ButtonsApp(App):
def on_load(self) -> None:
self.bind("q", "quit")
def on_mount(self):
self.mount(
Widget(cl... | diff --git a/src/textual/app.py b/src/textual/app.py
index 6a6e80272..2acc04ffe 100644
--- a/src/textual/app.py
+++ b/src/textual/app.py
@@ -521,6 +521,7 @@ class App(DOMNode):
mount_event = events.Mount(sender=self)
await self.dispatch_message(mount_event)
+ # TODO: d... |
Textualize__textual-441 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/textual/css/tokenize.py"
}
] | Textualize/textual | efafbdfcc16fdd3c7e9b5906fc7d8cc6e354f70e | [textual][bug] CSS rule parsing fails when the name of the colour we pass contains a digit
So while this is working correctly:
```css
#my_widget {
background: dark_cyan;
}
```
...this fails:
```css
#my_widget {
background: turquoise4;
}
```
...with the following error:
```
• failed to parse color '... | diff --git a/src/textual/css/tokenize.py b/src/textual/css/tokenize.py
index 3ccc8166f..7d5dbe3a0 100644
--- a/src/textual/css/tokenize.py
+++ b/src/textual/css/tokenize.py
@@ -11,7 +11,7 @@ DURATION = r"\d+\.?\d*(?:ms|s)"
NUMBER = r"\-?\d+\.?\d*"
COLOR = r"\#[0-9a-fA-F]{8}|\#[0-9a-fA-F]{6}|rgb\(\-?\d+\.?\d*,\-?\d+\.... |
Textualize__textual-4415 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_data_table.py:DataTable._on_click"
],
"edited_modules": [
"src/textual/widgets/_data_table.py:DataTable"
]
},
"file": "src/textual/widgets/_data_ta... | Textualize/textual | bd8f7483814acff93b8bd54427fc3a4b9100c55d | KeyError on DataTable border title link click
1. Run the attached MRE
2. Click on the right bottom table subtitle link
```
╭────────────────────────────────────── Traceback (most recent call last) ───────────────────────────────────────╮
│ /Users/user/.virtualenvs/textual-db/lib/python3.12/site-packages/textual/w... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e60932a11..6df2d6c3d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,9 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-4427 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/document/_document.py:Document.end"
],
"edited_modules": [
"src/textual/document/_document.py:Document"
]
},
"file": "src/textual/document/_document.py"
}... | Textualize/textual | f9b549a4eb03fb078c08a1089e13d55009a7b2b1 | Document.end line number is off by one (1-indexed)
`Document.start` and `Document.end` were introduced in https://github.com/Textualize/textual/pull/4267
`Document.start` maps to `(0, 0)`, but `Document.end` is 1-indexed, with its line number computed from `Document.line_count`. This is confusing, and breaks with th... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cd0139a5e..cd62457fa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-443 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/textual/_color_constants.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/... | Textualize/textual | 5cf061c31cd58e56e904aa0ec0e6e1d9d8ade24d | [colours] Prefix ANSI colours with `ansi_`, and add management of named Web colours (which would then become the main source of named colours in CSS) | diff --git a/src/textual/_color_constants.py b/src/textual/_color_constants.py
index fd0037ea8..cedab5673 100644
--- a/src/textual/_color_constants.py
+++ b/src/textual/_color_constants.py
@@ -1,239 +1,172 @@
from __future__ import annotations
-COLOR_NAME_TO_RGB: dict[str, tuple[int, int, int]] = {
+COLOR_NAME_TO_RG... |
Textualize__textual-4452 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/app.py:App.__init__"
],
"edited_modules": [
"src/textual/app.py:App"
]
},
"file": "src/textual/app.py"
},
{
"changes": {
"added_entities": nul... | Textualize/textual | fd16a0487d4ce2acd5dd180eac255d5c4a032197 | `ListView` initial index is off by one
Setting the `initial_index` of a `ListView` seems to be off by one, introduced somewhere in v0.48.2:
```python
from textual.app import App, ComposeResult
from textual.widgets import Label, ListItem, ListView
class ExampleApp(App):
def compose(self) -> ComposeResult:... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index dfebf364e..88847d849 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,18 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-4464 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_selection_list.py:SelectionList._remove_option"
],
"edited_modules": [
"src/textual/widgets/_selection_list.py:SelectionList"
]
},
"file": "src/tex... | Textualize/textual | 5d974391edacf71adb450a96756634ccee2559da | SelectionList weird behavior when removing options in its own event handler until freeze
When you interact with a SelectionList and remove the option in one of the event handlers one of the following happens:
- Wrong options is removed
- Option just deselects
- Entire component just freezes (not the entire app; ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 88847d849..575e3ee22 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,15 +9,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
+- Fixed `SelectionList` issues after removing an option https://github.com/Textualize/textual/pull/446... |
Textualize__textual-4686 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_markdown.py:MarkdownTableContent.action_link"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/textual/widgets/_markdown.py:MarkdownTableContent"
]
},
"file": "src/text... | Textualize/textual | 341d3453dbce683e7385b517af3cd45f1bc304a0 | MD links inside a MD table in Markdown Widget do not generate Markdown.LinkClicked when clicked
### Problem
When using the Markdown widget, links inside a table are not posting `Markdown.LinkClicked` events when they are clicked. The links are rendered properly, just not firing `Markdown.LinkClicked`.
Other links... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 94f03d027..084829b86 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Fixed grid + keyline when the grid has auto dimensions https://github.com/Textualize/textual/pull/4680
- Fixed m... |
Textualize__textual-4702 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_tabs.py:Tabs._on_underline_clicked"
],
"edited_modules": [
"src/textual/widgets/_tabs.py:Tabs"
]
},
"file": "src/textual/widgets/_tabs.py"
}
] | Textualize/textual | 50b767f73b241c04751714620206d28742e8fc0a | Disabled TabPane can still be Accessed/selected via the underline bar
A Tabpane can be deactivated like this:
```
with TabbedContent():
with TabPane("HELP", id="HELP-tab" ,disabled=True):
pass
```
the Title/Label is not clickable any more, yet the pane can still be accessed by clicking on the underl... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1bdc55f5a..638fdab39 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,14 +7,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased
-### Changed
-
-- "Discover" hits in the command palette are no longer sorted alphabetically https:... |
Textualize__textual-4736 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widget.py:Widget.remove_children"
],
"edited_modules": [
"src/textual/widget.py:Widget"
]
},
"file": "src/textual/widget.py"
},
{
"changes": {
... | Textualize/textual | 142f437a56d94101df5f00e6c4cc6e6e253d5cfc | `ListView.remove_items()` removes all items
Thanks @jkoelker for reporting this in https://github.com/Textualize/textual/pull/4708#discussion_r1677011195!
> I believe this changes the behavior of this functions to removing all `ListItem`s instead of the ones at the specific `indices`.
https://github.com/Textualiz... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2b485020b..c530fcf56 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- `TextArea.line_number_start` reactive attribute https://github.com/Textualize/textual/pull/4471
+- `Wi... |
Textualize__textual-4742 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_data_table.py:DataTable.add_row"
],
"edited_modules": [
"src/textual/widgets/_data_table.py:DataTable"
]
},
"file": "src/textual/widgets/_data_tabl... | Textualize/textual | 66f2e0cf45ba4ee20b2a7d150bc8ab5f034d1f54 | DataTable.add_row gives misleading error with too many arguments.
Create a DataTable with one column. Do a `table.add_row("A", "B")`.
Get `AttributeError: 'NoneType' object has no attribute 'key'`, which is an odd error.
Instead I should get `ValueError: Too many column values provided to add_row`
Caused by ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ed46c3a9f..70011f7fc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- `TextArea.line_number_start` reactive attribute https://github.com/Textualize/textual/pull/4471
+- Rai... |
Textualize__textual-4773 | [
{
"changes": {
"added_entities": [
"src/textual/widgets/_input.py:Input._on_mouse_down",
"src/textual/widgets/_input.py:Input._on_mouse_up",
"src/textual/widgets/_input.py:Input._restart_blink_cycle",
"src/textual/widgets/_input.py:Input._pause_blink_cycle"
],
"... | Textualize/textual | 3fe08c1916a21da92f7d22ceea651862049e4733 | Focusing Input widget should not move cursor to the end
When the Input widget is focused, the cursor currently moves to the end.
This leads to a flickering effect when it's focused via a click, as the cursor jumps to the end (due to the focus handler), and then jumps to the click location (due to the click handler).... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ea1c614dd..c96a8420a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning]... |
Textualize__textual-4894 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"docs/examples/guide/screens/screen01.py:BSODApp"
]
},
"file": "docs/examples/guide/screens/screen01.py"
},
{
"changes": {
"added_entities": [
... | Textualize/textual | 15c3d5755df093822b2ed9543d1961aa6f5ec6d9 | Don't allow screen instances in App.SCREENS
Textual currently allows a screen instance to be specified in the `SCREENS` classvar. This works fine when launching an app, until a second instance of the app runs. Re-using a previous instance breaks the app.
See the example here: https://textual.textualize.io/guide/scre... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f49737fae..486e13963 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased
+- Disallowed `Screen` instances in `App.SCREENS` and `App.MODES`
+- Fixed `App.MODES` being the same... |
Textualize__textual-501 | [
{
"changes": {
"added_entities": [
"sandbox/basic.py:BasicApp.key_q",
"sandbox/basic.py:BasicApp.key_t"
],
"added_modules": null,
"edited_entities": [
"sandbox/basic.py:TweetBody.render"
],
"edited_modules": [
"sandbox/basic.py:TweetBody",
... | Textualize/textual | 73a2dfb3c6b05634feac1191b4d527fa9fc7120f | Scrollbar gutter
We should add a scrollbar gutter to CSS.
https://twitter.com/stackblitz/status/1518924375721873408?s=20&t=xu6iJ6y1WYPbxf_ck9KCoQ | diff --git a/sandbox/basic.css b/sandbox/basic.css
index f9bc0b96d..a8dd22a17 100644
--- a/sandbox/basic.css
+++ b/sandbox/basic.css
@@ -85,7 +85,8 @@ Tweet {
/* border: outer $primary; */
padding: 1;
border: wide $panel-darken-2;
- overflow-y: scroll;
+ overflow-y: auto;
+ scrollbar-gutter: stable;
ali... |
Textualize__textual-5135 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/widgets/_list_view.py:ListView.pop",
"src/textual/widgets/_list_view.py:ListView.remove_items"
],
"edited_modules": [
"src/textual/widgets/_list_view.py:ListView"... | Textualize/textual | 79df474d1407a895420029de061a0bf4e21a3c65 | Calling `remove_items` or `pop` on a ListView does not update index or highlighting
It seems that calling `pop` (or `remove_items`, though that's not what I'm using for my use case) does not correctly update highlighting (presumably because calling `pop` does not update the index).
A small reproduction is as follows... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1c2d544bd..6de8ba68f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,13 +5,19 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning... |
Textualize__textual-5237 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/textual/document/_wrapped_document.py:WrappedDocument.offset_to_location"
],
"edited_modules": [
"src/textual/document/_wrapped_document.py:WrappedDocument"
]
},
"f... | Textualize/textual | 0e9e3205e753388615badd989d7fab1aaba21ad5 | Mouse selection bug with Tab characters in TextArea with soft_wrap disabled
The following code creates 2 TextAreas pre-populated with 20 Tab characters.
```python3
from textual.app import App, ComposeResult
from textual.widgets import TextArea
class MyApp(App):
def compose(self) -> ComposeResult:
... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 76279be25..b82e5c51f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- Fixed duplicated key displays in the help panel https://github.com/Textualize/textual/issues/5037
+- F... |
Textualize__textual-529 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"sandbox/basic.py:BasicApp.on_mount"
],
"edited_modules": [
"sandbox/basic.py:BasicApp"
]
},
"file": "sandbox/basic.py"
},
{
"changes": {
"added_entities":... | Textualize/textual | 2b485cd4cc49791f0ae8ba17196468e2198a25bf | Set scrollbar size in CSS
The scrollbars can be a little hard to click when cells are quite small, particularly a vertical scrollbar.
We should add CSS rules to set the size of scrollbars.
```
scrollbar-size: 2 1;
scrollbar-size-vertical: 2;
scorllbar-size-horizontal: 1;
```
We could make this responsive a... | diff --git a/sandbox/basic.css b/sandbox/basic.css
index cd32cce1b..4ef50c632 100644
--- a/sandbox/basic.css
+++ b/sandbox/basic.css
@@ -74,7 +74,7 @@ App > Screen {
Tweet {
- height: auto;
+ height: 12;
width: 80;
margin: 1 3;
@@ -90,6 +90,15 @@ Tweet {
box-sizing: border-box;
}
+Tweet.scrollbar-... |
TheFriendlyCoder__friendlypins-105 | [
{
"changes": {
"added_entities": [
"src/friendlypins/api.py:API.get_pin_by_id"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/friendlypins/api.py:API"
]
},
"file": "src/friendlypins/api.py"
}
] | TheFriendlyCoder/friendlypins | 781788ee60312c3634bddcd285aac3a0dc62bbb5 | add helper method to retrieve a specific pin based on its ID
In order to use the Pinterest REST API more efficiently I want to add support for loading data for a specific pin directly with just its unique identifier, lazy loading REST API data when needed. | diff --git a/src/friendlypins/api.py b/src/friendlypins/api.py
index 120116c..92b4475 100644
--- a/src/friendlypins/api.py
+++ b/src/friendlypins/api.py
@@ -2,10 +2,11 @@
import logging
from friendlypins.user import User
from friendlypins.board import Board
+from friendlypins.pin import Pin
from friendlypins.utils.... |
TheFriendlyCoder__friendlypins-17 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/board.py:Board.all_pins"
],
"edited_modules": [
"src/friendlypins/board.py:Board"
]
},
"file": "src/friendlypins/board.py"
},
{
"changes": {
... | TheFriendlyCoder/friendlypins | 51374c346ee260e0825f4d83f1bd95469c17d0ae | Add method for deleting pins
To facilitate deletion of pins, we need to add a new `delete()` method to the Pins class to serve this purpose. | diff --git a/src/friendlypins/board.py b/src/friendlypins/board.py
index 7cfd3c2..f541582 100644
--- a/src/friendlypins/board.py
+++ b/src/friendlypins/board.py
@@ -82,7 +82,7 @@ class Board(object):
assert 'data' in raw
for cur_item in raw['data']:
- retval.append(Pin(cur_ite... |
TheFriendlyCoder__friendlypins-25 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/api.py:API.get_user"
],
"edited_modules": [
"src/friendlypins/api.py:API"
]
},
"file": "src/friendlypins/api.py"
},
{
"changes": {
"added... | TheFriendlyCoder/friendlypins | 0517a65d8d98dd15c1de3eca4d804d9b21744aeb | Add accessor to get number of pins on a board
It appears as though there is some optional metadata that can be read from a board API endpoint, one of which contains the total number of pins on that board. We should enhance the Board class to pull down that extra metadata upon instantiation, and provide an accessor that... | diff --git a/src/friendlypins/api.py b/src/friendlypins/api.py
index 01b3d4a..ee3b00a 100644
--- a/src/friendlypins/api.py
+++ b/src/friendlypins/api.py
@@ -37,6 +37,7 @@ class API(object): # pylint: disable=too-few-public-methods
else:
temp_url = "{0}/me".format(self._root_url)
temp_url... |
TheFriendlyCoder__friendlypins-27 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/scripts/fpins.py:_download_thumbnails",
"src/friendlypins/scripts/fpins.py:get_args"
],
"edited_modules": [
"src/friendlypins/scripts/fpins.py:_download_thum... | TheFriendlyCoder/friendlypins | bb21be18fb37d054ecc015d31912e3bfc249fd0c | Add option to delete pins post download
We should add an option to the `fpins dt` command to delete pins once their thumbnails have been successfully downloaded. I'm thinking adding support for an optional '--delete' parameter should do the trick. | diff --git a/src/friendlypins/scripts/fpins.py b/src/friendlypins/scripts/fpins.py
index 0835d2d..2fd8974 100644
--- a/src/friendlypins/scripts/fpins.py
+++ b/src/friendlypins/scripts/fpins.py
@@ -13,7 +13,7 @@ def _download_thumbnails(args):
:returns: zero on success, non-zero on failure
:rtype: :class:`int`... |
TheFriendlyCoder__friendlypins-28 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/scripts/fpins.py:_download_thumbnails",
"src/friendlypins/scripts/fpins.py:get_args",
"src/friendlypins/scripts/fpins.py:configure_logging",
"src/friendlypins/sc... | TheFriendlyCoder/friendlypins | bb21be18fb37d054ecc015d31912e3bfc249fd0c | Fix bug with verbose logging
I just noticed that debug logs are not being redirected to the verbose log file. This needs to be fixed. | diff --git a/src/friendlypins/scripts/fpins.py b/src/friendlypins/scripts/fpins.py
index 0835d2d..26a279b 100644
--- a/src/friendlypins/scripts/fpins.py
+++ b/src/friendlypins/scripts/fpins.py
@@ -13,7 +13,7 @@ def _download_thumbnails(args):
:returns: zero on success, non-zero on failure
:rtype: :class:`int`... |
TheFriendlyCoder__friendlypins-38 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": [
"src/friendlypins/headers.py:Headers.bytes"
],
"added_modules": null,
... | TheFriendlyCoder/friendlypins | b52793c458ee2bc4057c22a233d43cc2b1439f8c | Add progress bar support to fpins console app
To make it easier to track the overall progress of a lengthy download operation, we should add support for showing a progress bar to the fpins console app. | diff --git a/setup.py b/setup.py
index 6604fe6..7c44b31 100755
--- a/setup.py
+++ b/setup.py
@@ -9,7 +9,9 @@ PROJECT_NAME = 'friendlypins'
PROJECT_DEPENDENCIES = [
'requests',
'six',
- 'dateutils']
+ 'dateutils',
+ 'tqdm',
+ 'pillow']
PROJECT_DEV_DEPENDENCIES = [
'wheel<1.0.0',
'twine<... |
TheFriendlyCoder__friendlypins-45 | [
{
"changes": {
"added_entities": [
"src/friendlypins/board.py:Board.pins"
],
"added_modules": null,
"edited_entities": [
"src/friendlypins/board.py:Board.all_pins"
],
"edited_modules": [
"src/friendlypins/board.py:Board"
]
},
"file": "src... | TheFriendlyCoder/friendlypins | 9c0aa4ebcde5ad444e342aaa2b3315339dbc36f6 | lazy load boards and pins
To simplify and optimize the interactions with boards and pins we should lazy-load the data from these two API calls using iterators:
User.boards
Board.all_pins | diff --git a/src/friendlypins/board.py b/src/friendlypins/board.py
index 045655f..7f51a3b 100644
--- a/src/friendlypins/board.py
+++ b/src/friendlypins/board.py
@@ -64,16 +64,12 @@ class Board(object):
return int(self._data['counts']['pins'])
@property
- def all_pins(self):
- """Gets a list of... |
TheFriendlyCoder__friendlypins-56 | [
{
"changes": {
"added_entities": [
"src/friendlypins/api.py:API.user"
],
"added_modules": null,
"edited_entities": [
"src/friendlypins/api.py:API.get_user"
],
"edited_modules": [
"src/friendlypins/api.py:API"
]
},
"file": "src/friendlypin... | TheFriendlyCoder/friendlypins | 671c3a7d0546b2996f4b5c248621cc2899bad727 | rename get_user to current_user
Seeing as how we currently only support retrieving data for the currently authenticated user, we should rename get_user to current_user and make it a property with no method parameters. | diff --git a/src/friendlypins/api.py b/src/friendlypins/api.py
index cff46b6..63b0360 100644
--- a/src/friendlypins/api.py
+++ b/src/friendlypins/api.py
@@ -17,20 +17,13 @@ class API(object): # pylint: disable=too-few-public-methods
self._log = logging.getLogger(__name__)
self._io = RestIO(personal_a... |
TheFriendlyCoder__friendlypins-59 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/api.py:API.user"
],
"edited_modules": [
"src/friendlypins/api.py:API"
]
},
"file": "src/friendlypins/api.py"
},
{
"changes": {
"added_ent... | TheFriendlyCoder/friendlypins | eed1f246c388b9c1c92755d2c6dd77b5133a686c | Add code to create new boards
The next logical progression in the API development is to add code for creating new boards for a particular authenticated user. | diff --git a/src/friendlypins/api.py b/src/friendlypins/api.py
index f8b7255..4b014c9 100644
--- a/src/friendlypins/api.py
+++ b/src/friendlypins/api.py
@@ -25,7 +25,18 @@ class API(object): # pylint: disable=too-few-public-methods
"""
self._log.debug("Getting authenticated user details...")
- ... |
TheFriendlyCoder__friendlypins-63 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/scripts/fpins.py:_download_thumbnails",
"src/friendlypins/scripts/fpins.py:get_args"
],
"edited_modules": [
"src/friendlypins/scripts/fpins.py:_download_thum... | TheFriendlyCoder/friendlypins | 4ce39e5b0d0c774670d08116b730bb7cabfcb8dd | rework dt command to delete boards
Instead of having the '-d' option delete each pin one at a time, we should rework it to delete the board once complete ... either that or remove the option completely and add a new command called "delete_board" to just delete a given board. | diff --git a/src/friendlypins/scripts/fpins.py b/src/friendlypins/scripts/fpins.py
index 1338bec..f9656c7 100644
--- a/src/friendlypins/scripts/fpins.py
+++ b/src/friendlypins/scripts/fpins.py
@@ -14,7 +14,7 @@ def _download_thumbnails(args):
:returns: zero on success, non-zero on failure
:rtype: :class:`int`... |
TheFriendlyCoder__friendlypins-77 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/api.py:API.rate_limit_refresh",
"src/friendlypins/api.py:API.transaction_limit",
"src/friendlypins/api.py:API.transaction_remaining"
],
"edited_modules": [
... | TheFriendlyCoder/friendlypins | 11981f65cd70b9db9c0e39fb608e73800e58dd33 | Update API to auto-load header data
The REST API abstraction layer attempts to auto-load the header data produced by the pinterest API, caching it for future reference, however in certain situations the caching mechanism doesn't 't work. Specifically, only certain method calls on the restio class are configured to popu... | diff --git a/src/friendlypins/api.py b/src/friendlypins/api.py
index 4b014c9..03a92f2 100644
--- a/src/friendlypins/api.py
+++ b/src/friendlypins/api.py
@@ -48,11 +48,7 @@ class API(object): # pylint: disable=too-few-public-methods
:rtype: :class:`datetime.datetime`
"""
- try:
- i... |
TheFriendlyCoder__friendlypins-93 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/friendlypins/api.py:API.user"
],
"edited_modules": [
"src/friendlypins/api.py:API"
]
},
"file": "src/friendlypins/api.py"
},
{
"changes": {
"added_ent... | TheFriendlyCoder/friendlypins | 3f1f566c647299f9da73db11a98cc142b565072e | lazy load user data from api
Currently, all API calls in our library are funnelled through the "current user" object (ie: api.user()) and this property pre-caches the user profile data for the current user prior to generating the user object returned to the caller. For cases where the user profile data is unnecessary, ... | diff --git a/.gitignore b/.gitignore
index adb9ca9..917bbc2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -10,7 +10,7 @@ build/
# Temporary unit test files
htmlcov/
.tox/
-.coverage
+.coverage*
docs/_*
docs/api/*
htmldocs/*
diff --git a/src/friendlypins/api.py b/src/friendlypins/api.py
index 3d382cc..81bc8b0 100644... |
TheFriendlyCoder__friendlypins-99 | [
{
"changes": {
"added_entities": [
"docs/conf.py:add_intersphinx_aliases_to_inv",
"docs/conf.py:setup"
],
"added_modules": [
"docs/conf.py:add_intersphinx_aliases_to_inv",
"docs/conf.py:setup"
],
"edited_entities": null,
"edited_modules": null
... | TheFriendlyCoder/friendlypins | 181c8b6a62921a7e836ca049d080a23083310407 | add a find board by id method to api
In another effort to minimize the hits to the pinterest api we should add a helper method that returns a Board object given an ID number. Further, we should optimize this getter so that it lazy-loads the response data describing the board only when necessary. | diff --git a/.travis.yml b/.travis.yml
index 19aa694..5d4debb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -11,7 +11,7 @@ python:
install:
# pinning coverage package until bugs with coveralls plugin is fixed
# https://github.com/z4r/python-coveralls/issues/73
- - pip install tox wheel python-coveralls "coverag... |
TheFriendlyCoder__pyjen-136 | [
{
"changes": {
"added_entities": [
"src/pyjen/build.py:Build.abort"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/pyjen/build.py:Build"
]
},
"file": "src/pyjen/build.py"
},
{
"changes": {
"added_entities": [
... | TheFriendlyCoder/pyjen | c4c268c0e359691f8fc034982a40cbaa6fae46f6 | Write tests for build blocker plugin
The build blocker plugin has very little code coverage atm. This needs to be improved. | diff --git a/src/pyjen/build.py b/src/pyjen/build.py
index d0c902e..aba3a36 100644
--- a/src/pyjen/build.py
+++ b/src/pyjen/build.py
@@ -82,7 +82,6 @@ class Build(object):
:rtype: :class:`bool`
"""
data = self._api.get_api_data()
-
return data['building']
@property
@@ -105,10 ... |
TheFriendlyCoder__pyjen-137 | [
{
"changes": {
"added_entities": [
"src/pyjen/build.py:Build.abort"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/pyjen/build.py:Build"
]
},
"file": "src/pyjen/build.py"
},
{
"changes": {
"added_entities": nu... | TheFriendlyCoder/pyjen | c4c268c0e359691f8fc034982a40cbaa6fae46f6 | Fix SSL cert handling logic
The PyJen APIs should be restructured to properly handle SSL certificate validation. By default, SSL verification should be enabled. Also, we should add the ability to customize the SSL certificate authorities in some sensible way. | diff --git a/src/pyjen/build.py b/src/pyjen/build.py
index d0c902e..aba3a36 100644
--- a/src/pyjen/build.py
+++ b/src/pyjen/build.py
@@ -82,7 +82,6 @@ class Build(object):
:rtype: :class:`bool`
"""
data = self._api.get_api_data()
-
return data['building']
@property
@@ -105,10 ... |
TheFriendlyCoder__pyjen-38 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/pyjen/jenkins.py:Jenkins.connected",
"src/pyjen/jenkins.py:Jenkins.plugin_manager"
],
"edited_modules": [
"src/pyjen/jenkins.py:Jenkins"
]
},
"file": "src/p... | TheFriendlyCoder/pyjen | 5adc3153fe62af0691f7751cdf97b7f52e00cf77 | Add more test coverage for jenkins.py
We need to improve the unit test coverage on jenkins.py module. In the process, we need to add more tests that leverage the new Docker service, and make sure all tests for this module are compliant with py.test conventions. | diff --git a/.gitignore b/.gitignore
index a5cda0c..a4dd3e7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -100,4 +100,5 @@ logs/
py?/
.idea
-.vscode
\ No newline at end of file
+.vscode
+container_id.txt
\ No newline at end of file
diff --git a/src/pyjen/jenkins.py b/src/pyjen/jenkins.py
index 1be4364..435f20b 100644... |
TheUncleKai__bbutils-20 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "bbutil/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules"... | TheUncleKai/bbutils | 79e59c76c09b1f76cc67a3d2b1bcad484ce0029b | Fix appname bug in logging
Fix appname bug in logging, it uses the same width as the tags. Thats stupid. | diff --git a/bbutil/__init__.py b/bbutil/__init__.py
index d289f07..f758209 100644
--- a/bbutil/__init__.py
+++ b/bbutil/__init__.py
@@ -59,7 +59,7 @@ __major__ = 4
__minor__ = 0
#: version patch
-__patch__ = 5
+__patch__ = 6
#: package version
__version__ = "{0:d}.{1:d}.{2:d}.{3:d}".format(__milestone__, __maj... |
Tinche__aiofiles-82 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "aiofiles/threadpool/binary.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edit... | Tinche/aiofiles | 72f88e50e48802fec8f988be5cc6c2d80c09a8de | Missing .name and .mode attributes
The [FileIO attributes](https://docs.python.org/3/library/io.html#io.FileIO) `.name` and `.mode` are missing from the wrappers.
So this works:
```python
with open(filename) as f:
print(f.name, f.mode)
```
This doesn't, resulting in attribute errors.
```python
async... | diff --git a/aiofiles/threadpool/binary.py b/aiofiles/threadpool/binary.py
index fc5fc33..3568ed0 100644
--- a/aiofiles/threadpool/binary.py
+++ b/aiofiles/threadpool/binary.py
@@ -24,7 +24,7 @@ from .utils import (
"writelines",
)
@proxy_method_directly("detach", "fileno", "readable")
-@proxy_property_directly(... |
Tinche__cattrs-117 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/cattr/converters.py:GenConverter.unstructure_attrs_asdict",
"src/cattr/converters.py:GenConverter.structure_attrs_fromdict"
],
"edited_modules": [
"src/cattr/converters.p... | Tinche/cattrs | 61c944584b3a5472b5733beac79134c77580274d | GenConverter doesn't support inheritance
* cattrs version: 1.1.1
* Python version: 3.7
* Operating System: Mac
### Description
The old converter supports attrs classes which inherit from each other because it doesn't use MRO-based singledispatch per type to dispatch its attrs classes - therefore, when a subclas... | diff --git a/HISTORY.rst b/HISTORY.rst
index 6f59b9b..9883525 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -7,6 +7,8 @@ History
* ``converter.unstructure`` now supports an optional parameter, `unstructure_as`, which can be used to unstructure something as a different type. Useful for unions.
* Improve support for un... |
Toblerity__keytree-6 | [
{
"changes": {
"added_entities": [
"keytree/factory.py:geometry_Track"
],
"added_modules": [
"keytree/factory.py:geometry_Track"
],
"edited_entities": [
"keytree/factory.py:feature",
"keytree/factory.py:geometry",
"keytree/factory.py:geometry... | Toblerity/keytree | 4820183ea6f10c8332b960e99d88e12a6e69092d | Feature request: support Google extension feature types
Some pro-bono work I'm doing has me converting features like [`gx:Track`](https://developers.google.com/kml/documentation/kmlreference#gx:track) into LineStrings for geojson output. I'm already writing the code to do so and would be happy to make it into a PR for ... | diff --git a/.gitignore b/.gitignore
index dbf3f82..bb11b69 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,5 @@
dist
__pycache__
*.egg-info
+.vscode/
+.pytest_cache/
\ No newline at end of file
diff --git a/keytree/factory.py b/keytree/factory.py
index 86f9275..2ab28ec 100644
--- a/keytree/factory.py
+++ b/keyt... |
Toblerity__rtree-141 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"rtree/index.py:Index.nearest"
],
"edited_modules": [
"rtree/index.py:Index"
]
},
"file": "rtree/index.py"
}
] | Toblerity/rtree | bc6ccc0ed3e6d7a32719e3c6f3ba002b66bb1909 | nearest picking just first item
I ran into a case where my index had a large rectangle with a smaller rectangle inside. When I run `nearest` with `num_results=1` on a point inside the smaller rectangle, only 1 result is returned. Since the point is within both (verified by running `intersection`) I would expect that th... | diff --git a/rtree/index.py b/rtree/index.py
index 69af61b..b90c88d 100644
--- a/rtree/index.py
+++ b/rtree/index.py
@@ -846,6 +846,12 @@ class Index(object):
return self._nearest_obj(coordinates, num_results, objects)
p_mins, p_maxs = self.get_coordinate_pointers(coordinates)
+ # p_num_r... |
Toloka__crowd-kit-109 | [
{
"changes": {
"added_entities": [
"crowdkit/aggregation/classification/dawid_skene.py:DawidSkene._correct_probas_with_golden"
],
"added_modules": null,
"edited_entities": [
"crowdkit/aggregation/classification/dawid_skene.py:DawidSkene.fit",
"crowdkit/aggregation... | Toloka/crowd-kit | 380db1badd7705c43ae5f523ebebb6223abf5e53 | [FEATURE] Make DS algorithm takes the information from gold standard questions
### Problem description
In the real world, when doing truth inference, we have a small set of gold standard questions mixed in with other unlabeled questions. I thought it would help if we could use the true labels of these gold standard ... | diff --git a/crowdkit/aggregation/classification/dawid_skene.py b/crowdkit/aggregation/classification/dawid_skene.py
index 50b6c2c..2382545 100644
--- a/crowdkit/aggregation/classification/dawid_skene.py
+++ b/crowdkit/aggregation/classification/dawid_skene.py
@@ -146,11 +146,15 @@ class DawidSkene(BaseClassificationAg... |
Toloka__crowd-kit-114 | [
{
"changes": {
"added_entities": [
"crowdkit/aggregation/classification/dawid_skene.py:initial_error_apply"
],
"added_modules": [
"crowdkit/aggregation/classification/dawid_skene.py:initial_error_apply"
],
"edited_entities": [
"crowdkit/aggregation/classific... | Toloka/crowd-kit | 582ff25fad992fe9d8fd4d448d9b30dc9e3cf15b | [FEATURE] Improve ds algorithm to use worker's history error matrix info
### Problem description
The current implementation of ds algorithm doesn't take worker's history error matrix into consideration, which is a useful priori information that can help the truth inference process.
### Feature description
Impr... | diff --git a/README.md b/README.md
index 467a837..e258116 100644
--- a/README.md
+++ b/README.md
@@ -37,7 +37,8 @@ If you are interested in contributing to Crowd-Kit, use [uv](https://github.com/
```shell
uv venv
-uv pip install -e '.[dev,docs,learning]
+uv pip install -e '.[dev,docs,learning]'
+uv tool run pre-com... |
Toloka__crowd-kit-128 | [
{
"changes": {
"added_entities": [
"crowdkit/aggregation/classification/dawid_skene.py:OneCoinDawidSkene.fit_predict_proba",
"crowdkit/aggregation/classification/dawid_skene.py:OneCoinDawidSkene.fit_predict"
],
"added_modules": null,
"edited_entities": null,
"edited... | Toloka/crowd-kit | a90bdca30aeb1974adb3dd3230a45975f5df45fb | [BUG] `OneCoinDawidSkene` is broken after vesion `1.4.0`.
### Observed behavior
In crowd-kit 1.4.0 and later, the following error occurs when running `fit_predict()` on `OneCoinDawidSkene`.
Code (Same as the example in docs):
```
from crowdkit.aggregation import OneCoinDawidSkene
from crowdkit.datasets import l... | diff --git a/crowdkit/aggregation/classification/dawid_skene.py b/crowdkit/aggregation/classification/dawid_skene.py
index 65bca6b..07fe1f5 100644
--- a/crowdkit/aggregation/classification/dawid_skene.py
+++ b/crowdkit/aggregation/classification/dawid_skene.py
@@ -578,3 +578,31 @@ class OneCoinDawidSkene(DawidSkene):
... |
TorchJD__torchjd-202 | [
{
"changes": {
"added_entities": [
"src/torchjd/autojac/mtl_backward.py:_check_no_overlap"
],
"added_modules": [
"src/torchjd/autojac/mtl_backward.py:_check_no_overlap"
],
"edited_entities": [
"src/torchjd/autojac/mtl_backward.py:mtl_backward"
],
... | TorchJD/torchjd | 8ec5dcb3eaa84a49c72af7eae0121e491201be08 | `mtl_backward` should raise an error when shared and task params overlap
To solve this, we need to:
- Add a check in `mtl_backward`.
- Add a test to verify that such a call raises an error.
- Changelog entry about potentially breaking bug fix | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3fb5add..07e4713 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,11 @@ changes that do not affect the user.
`pyproject.toml` (from a `[tool.pdm.dev-dependencies]` to a `[dependency-groups]` section). This
should only affect development dependencies.
+### ... |
Turbo87__utm-110 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"utm/conversion.py:latlon_to_zone_number"
],
"edited_modules": [
"utm/conversion.py:latlon_to_zone_number"
]
},
"file": "utm/conversion.py"
}
] | Turbo87/utm | e45377c40c36b729618230a9320e441062c94e6a | `utm.from_latlon` returns bogus zone 61 for `(0, 180)`
Using `utm==0.7.0`:
```python
utm.from_latlon(0, 180)
(166021.4431793313, 0.0, 61, 'N')
```
UTM Zone numbers are in range `[1, 60]`.
Notably, `check_valid_zone` still works:
```python
utm.check_valid_zone(61, 'N')
Traceback (most recent call last):... | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 745e365..5e5dc90 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -28,11 +28,11 @@ jobs:
- false
name: "Tests (Python v${{ matrix.python-version }}, NumPy: ${{ matrix.numpy }})"
- runs-on: ubuntu-22.04
+ ... |
Turbo87__utm-12 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "utm/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"utm/conversion.py:to... | Turbo87/utm | a8b2496e534671e5f07a19371f2c80813d7f2f50 | Zone letter problem
Zone letter return 'None' for latitude 84 | diff --git a/utm/__init__.py b/utm/__init__.py
index 4c844d2..3dece60 100644
--- a/utm/__init__.py
+++ b/utm/__init__.py
@@ -1,2 +1,2 @@
-from utm.conversion import to_latlon, from_latlon
+from utm.conversion import to_latlon, from_latlon, latlon_to_zone_number, latitude_to_zone_letter
from utm.error import OutOfRange... |
Turbo87__utm-16 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"utm/conversion.py:latlon_to_zone_number"
],
"edited_modules": [
"utm/conversion.py:latlon_to_zone_number"
]
},
"file": "utm/conversion.py"
}
] | Turbo87/utm | a121973a02f2e24cfc9d45a24cd37b7c0bef3af9 | Borders of zones 31V and 32V
In `latlon_to_zone_number` you handle the zones 31V and 32V different from all the other zones.
Usually, you compute the zone number `[left..right)` and the zone letter `[bottom..top)`. But for the corrections of 31V and 32V you use `[left..right]` and `[bottom..top]`.
This leads to ... | diff --git a/utm/conversion.py b/utm/conversion.py
index ec30333..33fbfe9 100644
--- a/utm/conversion.py
+++ b/utm/conversion.py
@@ -176,7 +176,7 @@ def latitude_to_zone_letter(latitude):
def latlon_to_zone_number(latitude, longitude):
- if 56 <= latitude <= 64 and 3 <= longitude <= 12:
+ if 56 <= latitude <... |
Turbo87__utm-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"utm/conversion.py:latlon_to_zone_number"
],
"edited_modules": [
"utm/conversion.py:latlon_to_zone_number"
]
},
"file": "utm/conversion.py"
}
] | Turbo87/utm | 4c7c13f2b2b9c01a8581392641aeb8bbda6aba6f | UTM zone exceptions error
By definition zones are left-closed, right-open intervals, e.g. zone 31: 0 <= latitude < 6.
In function latlon_to_zone_number:
```
if 72 <= latitude <= 84 and longitude >= 0:
if longitude <= 9:
return 31
elif longitude <= 21:
return 33
elif longitude <= 33:
... | diff --git a/utm/conversion.py b/utm/conversion.py
old mode 100755
new mode 100644
index d21742a..449f3d1
--- a/utm/conversion.py
+++ b/utm/conversion.py
@@ -216,13 +216,13 @@ def latlon_to_zone_number(latitude, longitude):
return 32
if 72 <= latitude <= 84 and longitude >= 0:
- if longitude <= 9... |
TurboGears__Ming-19 | [
{
"changes": {
"added_entities": [
"ming/mim.py:Cursor.close"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"ming/mim.py:Cursor"
]
},
"file": "ming/mim.py"
}
] | TurboGears/Ming | 4311d0d2a1c8cce83b6fe83c7d36ccd74a0432b4 | mim Cursor needs close() method
A couple errors like this from the Allura test suite, when going from pymongo 3.7.2 to pymongo 3.8 (on ming master):
```
File "/Users/brondsem/sf/allura/Allura/allura/ext/admin/admin_main.py", line 412, in update
c.project.save_icon(icon.filename, icon.file, content_type=icon.ty... | diff --git a/ming/mim.py b/ming/mim.py
index ef553f6..2c4aaa8 100644
--- a/ming/mim.py
+++ b/ming/mim.py
@@ -822,6 +822,9 @@ class Cursor(object):
# Adding options to MIM does nothing.
pass
+ def close(self):
+ self._iterator_gen = lambda: iter(())
+
def cursor_comparator(keys):
de... |
TurboGears__Ming-38 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ming/declarative.py:_DocumentMeta.__new__"
],
"edited_modules": [
"ming/declarative.py:_DocumentMeta"
]
},
"file": "ming/declarative.py"
},
{
"changes": {
... | TurboGears/Ming | 19883fa47dd51644cef596e3a4138054f3ade1c7 | MappedClass metaclass ignores __init_subclass__ arguments
Next code works with `M` but fails with `MappedClass`:
```python
#!/usr/bin/env python
from ming.odm import MappedClass
# class M:
# pass
# class A(M):
class A(MappedClass):
def __init_subclass__(cls, constant=1, **kwargs):
sup... | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index b63e91b..fb5a450 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -21,7 +21,6 @@ jobs:
strategy:
matrix:
python-version:
- - 2.7
# - 3.4 not in github x64
- 3.5
... |
TurboGears__Ming-8 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ming/base.py:Object.make_safe",
"ming/base.py:_safe_bson"
],
"edited_modules": [
"ming/base.py:Object",
"ming/base.py:_safe_bson"
]
},
"file": "ming/bas... | TurboGears/Ming | aa0fdaea7e02f41324d77a56c7b9692adbfeed24 | Support for Decimal128 type in Ming
MongoDB 3.4 introduced support for the Decimal type (https://docs.mongodb.com/manual/tutorial/model-monetary-data/#numeric-decimal). Pymongo supports it from v3.7, I think Ming should be able to use it as well.
The main issue I see with this is the `ming.base._safe_bson` function, ... | diff --git a/.travis.yml b/.travis.yml
index 401150e..8b15975 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,7 +6,7 @@ python:
- "3.5"
- "3.6"
- "3.7-dev"
- - "pypy"
+ - "pypy2.7-6.0"
install:
- "travis_retry pip install --upgrade pip"
diff --git a/docs/news.rst b/docs/news.rst
index ead9713..b0bd3cd... |
UBC-MDS__PyPunisher-72 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pypunisher/_checks.py:input_checks"
],
"edited_modules": [
"pypunisher/_checks.py:input_checks"
]
},
"file": "pypunisher/_checks.py"
},
{
"changes": {
"ad... | UBC-MDS/PyPunisher | 859c2f19db06c3bb7b488645f65dd286a1ba2a65 | Feedback on Milestone 2
Hi All,
Nice work for milestone 2. I like your comprehensive designs for the entire package. Here is my comments:
1. Good Practice to state out installation requires python 3.6
2. I like your coverage part to detail your test coverage, excellent
3. For __init__.py, line 4 and 5, why ... | diff --git a/pypunisher/__init__.py b/pypunisher/__init__.py
index 97d4631..0730e06 100644
--- a/pypunisher/__init__.py
+++ b/pypunisher/__init__.py
@@ -1,3 +1,5 @@
+#!/usr/bin/env python
+
"""
PyPunisher
==========
diff --git a/pypunisher/_checks.py b/pypunisher/_checks.py
index a268a99..ad8a08f 100644
--- a/pypuni... |
UC-Davis-molecular-computing__scadnano-python-package-269 | [
{
"changes": {
"added_entities": [
"scadnano/scadnano.py:Helix.crossover_addresses"
],
"added_modules": null,
"edited_entities": [
"scadnano/scadnano.py:Helix.crossovers",
"scadnano/scadnano.py:Helix.compute_relaxed_roll"
],
"edited_modules": [
... | UC-Davis-molecular-computing/scadnano-python-package | e832e532199bcd8d727a813aa3a4562007483031 | ignore loopouts when relaxing helix rolls
The feature implemented from issue #257 has a bug, because it treats any two consecutive domains on a strand as though they have a crossover between them, even if they actually have a loopout between them. Re-write the algorithm for finding crossovers (https://scadnano-python-p... | diff --git a/scadnano/scadnano.py b/scadnano/scadnano.py
index 08a8953..f51f6de 100644
--- a/scadnano/scadnano.py
+++ b/scadnano/scadnano.py
@@ -1763,35 +1763,44 @@ class Helix(_JSONSerializable):
angle %= 360
return angle
- def crossovers(self) -> List[Tuple[int, int, bool]]:
+ def crossover_... |
UC-Davis-molecular-computing__scadnano-python-package-274 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"scadnano/scadnano.py:Helix.crossover_addresses",
"scadnano/scadnano.py:Helix.compute_relaxed_roll_delta"
],
"edited_modules": [
"scadnano/scadnano.py:Helix"
]
},
... | UC-Davis-molecular-computing/scadnano-python-package | d3a6d7d79196f39a6097e40ee4d73d17bd4643e8 | deal with inter-helix-group crossovers when relaxing helix rolls
Currently, when relaxing helix rolls, all inter-helix crossovers are accounted for, but actually the calculation of the relative angle from one helix to another (based on the position of their 0 offset) only makes sense if the helices are in the same heli... | diff --git a/scadnano/scadnano.py b/scadnano/scadnano.py
index 14b96ac..6cc4a22 100644
--- a/scadnano/scadnano.py
+++ b/scadnano/scadnano.py
@@ -1764,15 +1764,32 @@ class Helix(_JSONSerializable):
angle %= 360
return angle
- def crossover_addresses(self, allow_intrahelix=True) -> List[Tuple[int, ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.