instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
lace__polliwog-182 | [
{
"changes": {
"added_entities": [
"polliwog/plane/_plane_object.py:Plane.points_on_or_in_front"
],
"added_modules": null,
"edited_entities": [
"polliwog/plane/_plane_object.py:Plane.points_in_front"
],
"edited_modules": [
"polliwog/plane/_plane_object... | lace/polliwog | dcd092dd3084da689029f2cb6bf48a1c38858959 | Consider renaming Plane `points_in_front()` method to `points_on_or_in_front()` | diff --git a/polliwog/plane/_plane_object.py b/polliwog/plane/_plane_object.py
index 60eb7cc..3c67e1d 100644
--- a/polliwog/plane/_plane_object.py
+++ b/polliwog/plane/_plane_object.py
@@ -148,6 +148,34 @@ class Plane(object):
return np.sign(self.signed_distance(points))
def points_in_front(self, points... |
lace__polliwog-183 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "polliwog/pointcloud/__init__.py"
},
{
"changes": {
"added_entities": [
"polliwog/pointcloud/_pointcloud_functions.py:extent"
],
... | lace/polliwog | dcd092dd3084da689029f2cb6bf48a1c38858959 | Rework `create_rectangle()`
This function should be parameterized. | diff --git a/polliwog/pointcloud/__init__.py b/polliwog/pointcloud/__init__.py
index 7b816e6..d9ea056 100644
--- a/polliwog/pointcloud/__init__.py
+++ b/polliwog/pointcloud/__init__.py
@@ -2,6 +2,6 @@
Functions for working with point clouds (i.e. unstructured sets of 3D points).
"""
-from ._pointcloud_functions imp... |
lace__vg-103 | [
{
"changes": {
"added_entities": [
"vg/core.py:average"
],
"added_modules": [
"vg/core.py:average"
],
"edited_entities": null,
"edited_modules": null
},
"file": "vg/core.py"
}
] | lace/vg | eb29bab81fe17b0a66b262ae6f2b2d78d9186482 | Add `vg.mean` method
To replace code removed in lace/polliwog#96. | diff --git a/vg/core.py b/vg/core.py
index a0be949..0c3867b 100644
--- a/vg/core.py
+++ b/vg/core.py
@@ -28,6 +28,7 @@ __all__ = [
"farthest",
"basis",
"within",
+ "average",
"cross",
"dot",
]
@@ -601,6 +602,33 @@ def within(points, radius, of_point, atol=1e-08, ret_indices=False):
... |
lace__vg-105 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"vg/core.py:apex"
],
"edited_modules": [
"vg/core.py:apex"
]
},
"file": "vg/core.py"
}
] | lace/vg | 4bbfb179da51a24f23bcb48c57f22b19154b3fe1 | `vg.apex()` should copy instead of returning a view | diff --git a/vg/core.py b/vg/core.py
index 0c3867b..273ddc9 100644
--- a/vg/core.py
+++ b/vg/core.py
@@ -503,14 +503,14 @@ def apex(points, along):
interest.
Returns:
- np.ndarray: A `3x1` point taken from `points`.
+ np.ndarray: A copy of a point taken from `points`.
"""
if ... |
lace__vg-110 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"vg/core.py:apex",
"vg/core.py:farthest",
"vg/core.py:within"
],
"edited_modules": [
"vg/core.py:apex",
"vg/core.py:farthest",
"vg/core.py:within"
... | lace/vg | 2c35fa53761c354d2758996af9e0f32a2af5a083 | Error using signed_angle with vector array
Hello!
I am calling
```python
angles = vg.signed_angle(vec1_array.T, points.T, look, units='rad')
```
with shapes
```
('points', (3, 8))
('vec1_array', (3, 8))
('look', (3, 1))
```
However, I get the error:
```
Traceback (most recent call last):
File "./ext... | diff --git a/vg/core.py b/vg/core.py
index 9b81c34..df58395 100644
--- a/vg/core.py
+++ b/vg/core.py
@@ -62,8 +62,8 @@ def perpendicular(v1, v2, normalized=True):
are both stacked, `result[k]` is perpendicular to `v1[k]` and `v2[k]`.)
Args:
- v1 (np.arraylike): A `3x1` vector or a `kx3` stack of vect... |
lace__vg-163 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"vg/matrix.py:pad_with_ones"... | lace/vg | 24684a3923ccf4d9f939e18c3cdc1e381a1f4a1a | Clarify what goes in `vg` vs `polliwog`
Since there is a closely related library, [polliwog](https://github.com/lace/polliwog) which does a lot of computational geometry, it's useful to clarify what belongs here vs. there.
Accordingly, the idea is to clarify this library's purpose:
> A vector-geometry toolbelt fo... | diff --git a/README.md b/README.md
index ecfc146..37a6e9c 100644
--- a/README.md
+++ b/README.md
@@ -9,9 +9,9 @@ vg
[][docs build]
[][black]
-A **v**e... |
lamenezes__simple-model-28 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_model/fields.py:ModelField.convert_to_type"
],
"edited_modules": [
"simple_model/fields.py:ModelField"
]
},
"file": "simple_model/fields.py"
}
] | lamenezes/simple-model | 95eaacb0da70364c1ee3aaf5e0d205f8e3255dfe | Support fields with type typing.Union | diff --git a/README.rst b/README.rst
index b61c4bd..39fd900 100644
--- a/README.rst
+++ b/README.rst
@@ -138,10 +138,14 @@ followed by the attribute name, e.g.
def validate_age(self, age):
if age < 0 or age > 150:
raise ValidationError('Invalid value for age {!r}'.format(age))
+ ... |
lamenezes__simple-model-7 | [
{
"changes": {
"added_entities": [
"simple_model/models.py:BaseModel.build_many"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"simple_model/models.py:BaseModel"
]
},
"file": "simple_model/models.py"
}
] | lamenezes/simple-model | f811032749a8c0f5b3415d7b25e2b76fcc16b877 | Allow model creation from list
In order to create models from a list currently we have to do the following:
```python
my_list = [{'foo': 1, 'bar': 2}, {'foo': 0, 'bar': -10}]
models = [MyModel(**data) for data in my_list]
```
It would be nice to have a SimpleModel classmethod that did it for us in order to avo... | diff --git a/.gitignore b/.gitignore
index 0ad2f42..ce23a29 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,3 +14,4 @@ coverage.xml
*~
[._]*.s[a-w][a-z]
.mypy_cache
+.idea
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 9947a37..3705fe3 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-conf... |
lanl__scico-521 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "scico/linop/__init__.py"
},
{
"changes": {
"added_entities": [
"scico/linop/_stack.py:DiagonalReplicated.__init__"
],
"added... | lanl/scico | 81806fcffc95ef6eb98386d66d8c3c7ea26afec4 | Construct a linop that implements a stacked version of another linop
It would be useful to have a general linop that can implement a stacked version of another linop using `jax.vmap`. An example application would be in constructing a 3D Abel transform from slices of a 2D transform, as in #242. | diff --git a/scico/linop/__init__.py b/scico/linop/__init__.py
index 2e91e00..f88422a 100644
--- a/scico/linop/__init__.py
+++ b/scico/linop/__init__.py
@@ -17,7 +17,7 @@ from ._diff import FiniteDifference, SingleAxisFiniteDifference
from ._func import Crop, Pad, Reshape, Slice, Sum, Transpose, linop_from_function
f... |
lanl__scico-537 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "examples/scripts/ct_multi_cs_tv_admm.py"
},
{
"changes": {
"added_entities": [
"scico/linop/xray/_xray.py:Parallel2dProjector.back_proje... | lanl/scico | aaedb6a823e1e83a3fdccca3540b81e31bfe5d6b | Apparent regression in `linop.Parallel2dProjector`
The projection accuracy of `linop.Parallel2dProjector` seems to have significantly degraded since the notebook `ct_multi_cs_tv_admm.ipynb` currently in scico-data was built. Compare the performance of the scico projector reported in [that notebook](https://github.com/... | diff --git a/examples/scripts/ct_multi_cs_tv_admm.py b/examples/scripts/ct_multi_cs_tv_admm.py
index 214098d..cb8ddc6 100644
--- a/examples/scripts/ct_multi_cs_tv_admm.py
+++ b/examples/scripts/ct_multi_cs_tv_admm.py
@@ -38,6 +38,9 @@ N = 512 # phantom size
np.random.seed(1234)
x_gt = snp.array(discrete_phantom(Foam... |
lanl__scico-561 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"scico/linop/xray/_xray.py:XRayTransform2D._project",
"scico/linop/xray/_xray.py:XRayTransform2D._back_project",
"scico/linop/xray/_xray.py:XRayTransform3D._calc_weights"
],
"... | lanl/scico | 008697c5b5a27ea3ea2bd3d6e43d2581089e6df5 | `XRayTransform2D` fails adjoint test
This example demonstrates a case in which `scico.linop.xray.XRayTransform2D` does not have a properly matched adjoint:
```python
import numpy as np
from scico.linop import valid_adjoint
from scico.linop.xray import XRayTransform2D
N = 256
det_count = int(N * 1.05 / np.sqrt(2... | diff --git a/scico/linop/xray/_xray.py b/scico/linop/xray/_xray.py
index 4fe4089..f3067e9 100644
--- a/scico/linop/xray/_xray.py
+++ b/scico/linop/xray/_xray.py
@@ -158,20 +158,20 @@ class XRayTransform2D(LinearOperator):
"""
nx = im.shape
inds, weights = XRayTransform2D._calc_weights(x0, dx,... |
lapix-ufsc__lapixdl-43 | [
{
"changes": {
"added_entities": [
"lapixdl/formats/annotation.py:BBox.__post_init__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"lapixdl/formats/annotation.py:BBox"
]
},
"file": "lapixdl/formats/annotation.py"
}
] | lapix-ufsc/lapixdl | 354ad05a93680744e0c0d3a9345fc05d23ca6f79 | Division by zero at calculate_bbox_iou
I can't reproduce the error with tests, but, some moments at https://github.com/lapix-ufsc/lapixdl/blob/ee3faf20b2beab7bbb794328f724b7b8044ac1b1/lapixdl/evaluation/evaluate.py#L211
The union it's equals zero and raise the error. To solve just need:
```python
if union_area == ... | diff --git a/lapixdl/formats/annotation.py b/lapixdl/formats/annotation.py
index 919f70a..a0e2eb1 100644
--- a/lapixdl/formats/annotation.py
+++ b/lapixdl/formats/annotation.py
@@ -26,6 +26,16 @@ class BBox:
cls: int
score: float | None = None
+ def __post_init__(self):
+ if self.upper_left_x < 0 ... |
lark-parser__lark-1013 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/visitors.py:Transformer_NonRecursive.transform"
],
"edited_modules": [
"lark/visitors.py:Transformer_NonRecursive"
]
},
"file": "lark/visitors.py"
}
] | lark-parser/lark | 1f56497de8d90c6136dcda0ce71f4de3b298a07e | Transformer_NonRecursive fails on Discard
**Describe the bug**
As documented, `Transformer` catches any `Discard` exceptions and removes the node from the tree.
I expected `Transformer_NonRecursive` to behave the same way - instead it lets the exception propagate eventually crashing the program.
**To Reproduc... | diff --git a/lark/visitors.py b/lark/visitors.py
index 03dc740..ae7930c 100644
--- a/lark/visitors.py
+++ b/lark/visitors.py
@@ -277,9 +277,15 @@ class Transformer_NonRecursive(Transformer):
del stack[-size:]
else:
args = []
- stack.append(self._... |
lark-parser__lark-1120 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/utils.py:get_regexp_width"
],
"edited_modules": [
"lark/utils.py:get_regexp_width"
]
},
"file": "lark/utils.py"
}
] | lark-parser/lark | 5772e1878729fe07d50fe3b80b8f360ac8f8d050 | Caching does not work with recursive pattern
**Describe the bug**
I tried to leverage caching to speed up the loading time of my grammar, but it didn't work, so I started to dig into the code and found that it can't load the pickled file
```shell
Traceback (most recent call last):
...
File ".../lark/lark.p... | diff --git a/lark/utils.py b/lark/utils.py
index 77252b6..d7bab6f 100644
--- a/lark/utils.py
+++ b/lark/utils.py
@@ -137,9 +137,10 @@ def get_regexp_width(expr):
# we manually test for the most important info (whether the empty string is matched)
c = regex.compile(regexp_final)
if... |
lark-parser__lark-1216 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/parse_tree_builder.py:AmbiguousExpander.__call__"
],
"edited_modules": [
"lark/parse_tree_builder.py:AmbiguousExpander"
]
},
"file": "lark/parse_tree_builder.py"
... | lark-parser/lark | 7ef5c98d10638dbeaf038aef8bf86cc278a9f45a | Missing ambiguities when using inline rules
**Describe the bug**
With some grammars, Earley parser does not return all ambiguities with `ambiguity='explicit'`.
However, when removing the inlining underscore, all ambiguities are returned.
Potentially related to #536.
**To Reproduce**
```
start: _field+
... | diff --git a/lark/parse_tree_builder.py b/lark/parse_tree_builder.py
index a6003a9..bb907a2 100644
--- a/lark/parse_tree_builder.py
+++ b/lark/parse_tree_builder.py
@@ -8,7 +8,7 @@ from .visitors import _vargs_meta, _vargs_meta_inline
###{standalone
from functools import partial, wraps
-from itertools import repeat... |
lark-parser__lark-1252 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"lark/lexer.py:PatternStr",
"lark/lexer.py:PatternRE"
]
},
"file": "lark/lexer.py"
}
] | lark-parser/lark | c9b697ec4546f247f4b3f22bcac4760215caff43 | exception str() failed in `UnexpectedCharacters` because of 'PatternRE' has no attribute 'raw'
**Describe the bug**
Lark v1.1.2
The standalone parser generated with `python -m lark.tools.standalone` appears to have an issue with the `PatternRE`/`PatternStr` subclasses because when I get an `UnexpectedCharacters` ... | diff --git a/lark/lexer.py b/lark/lexer.py
index 1f1bb75..4291f2d 100644
--- a/lark/lexer.py
+++ b/lark/lexer.py
@@ -63,7 +63,7 @@ class Pattern(Serialize, ABC):
class PatternStr(Pattern):
- __serialize_fields__ = 'value', 'flags'
+ __serialize_fields__ = 'value', 'flags', 'raw'
type: ClassVar[str] = ... |
lark-parser__lark-1432 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/parsers/earley_forest.py:SymbolNode.__init__",
"lark/parsers/earley_forest.py:SymbolNode.__eq__",
"lark/parsers/earley_forest.py:SymbolNode.__hash__"
],
"edited_modules"... | lark-parser/lark | c1dbe0c49701cd37c595492d1461a97c0597215c | Dynamic Earley: Incorrect value for SymbolNode.end
Consider the following:
```python
grammar = r"""
start: "ABC"
"""
print(Lark(grammar, ambiguity="forest").parse("ABC"))
```
Output: `(start, 0, 2, -inf)`
The end index is 2 which suggests that the substring "AB" was parsed. However, we know that the ful... | diff --git a/lark/parsers/earley_forest.py b/lark/parsers/earley_forest.py
index 301f4d1..cdc613a 100644
--- a/lark/parsers/earley_forest.py
+++ b/lark/parsers/earley_forest.py
@@ -38,15 +38,15 @@ class SymbolNode(ForestNode):
Parameters:
s: A Symbol, or a tuple of (rule, ptr) for an intermediate node.
... |
lark-parser__lark-1433 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/parsers/earley.py:Parser.parse"
],
"edited_modules": [
"lark/parsers/earley.py:Parser"
]
},
"file": "lark/parsers/earley.py"
},
{
"changes": {
"added... | lark-parser/lark | 33136b32963d131580217b479cad3a09f3657dae | Earley parser produces wrong parse Tree
Over on SO someone asked this question: https://stackoverflow.com/questions/76366280/parsing-formulas-using-lark-ebnf/76381256
As far as I can tell, it shows a bug in the earley parser where it duplicates some Tokens because of enormous amounts of ambiguities. I don't have the... | diff --git a/lark/parsers/earley.py b/lark/parsers/earley.py
index 2153a0c..8deaa2f 100644
--- a/lark/parsers/earley.py
+++ b/lark/parsers/earley.py
@@ -300,7 +300,10 @@ class Parser:
if self.Tree is not None:
# Perform our SPPF -> AST conversion
- transformer = ForestToParseTree(self... |
lark-parser__lark-1435 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/parsers/grammar_analysis.py:GrammarAnalyzer.expand_rule"
],
"edited_modules": [
"lark/parsers/grammar_analysis.py:GrammarAnalyzer"
]
},
"file": "lark/parsers/gramm... | lark-parser/lark | 501689455b00ff643b7901994dcb6d2a92d4412e | Inconsistent parse results from simple ambiguous grammar
**Describe the bug**
I have a small grammar that is a starting point to parse regular expressions. When run repeatedly on the same input Lark produces two different parse trees.
There is an ambiguity in my toy grammar because a RE `quantifier` (`*`, `+`, `?... | diff --git a/lark/parsers/grammar_analysis.py b/lark/parsers/grammar_analysis.py
index b52e50d..28d3cb6 100644
--- a/lark/parsers/grammar_analysis.py
+++ b/lark/parsers/grammar_analysis.py
@@ -3,7 +3,7 @@
from collections import Counter, defaultdict
from typing import List, Dict, Iterator, FrozenSet, Set
-from ..ut... |
lark-parser__lark-1467 | [
{
"changes": {
"added_entities": [
"lark/tree.py:Tree.find_token"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"lark/tree.py:Tree"
]
},
"file": "lark/tree.py"
}
] | lark-parser/lark | 5faea9223cc54d1dbd0985cf830d05a10a7729ec | Syntactic sugar: Tree.find_token()
**Suggestion**
Add new method `Tree.find_type(typ: str) -> Iterator[Token]` as a companion for `Tree.find_data()`:
```python
for term in tree.find_type('TERM'):
...
```
**Describe alternatives you've considered**
Right now this can be achieved by
```python
for term in t... | diff --git a/.gitignore b/.gitignore
index 26275e4..d4e6418 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,7 @@
*.pyc
*.pyo
/.tox
+/lark.egg-info/**
/lark_parser.egg-info/**
tags
.vscode
diff --git a/lark/tree.py b/lark/tree.py
index 76f8738..9dccadd 100644
--- a/lark/tree.py
+++ b/lark/tree.py
@@ -3,8 +3,10... |
lark-parser__lark-1481 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/grammar.py:Symbol.__eq__"
],
"edited_modules": [
"lark/grammar.py:Symbol"
]
},
"file": "lark/grammar.py"
}
] | lark-parser/lark | 24d0cf7b5b56db77203dbbe794e50958433130ea | `lark.grammar.Symbol.__eq__` raises an `AssertionError` when checking if `None == Symbol(...)`
**Describe the bug**
When attempting to compare a variable set to `None` with a Symbol, Lark's implementation of `__eq__` within the `Symbol` class raises an `AssertionError`.
**To Reproduce**
```python
from lark.gr... | diff --git a/lark/grammar.py b/lark/grammar.py
index 1d226d9..016496b 100644
--- a/lark/grammar.py
+++ b/lark/grammar.py
@@ -16,7 +16,8 @@ class Symbol(Serialize):
self.name = name
def __eq__(self, other):
- assert isinstance(other, Symbol), other
+ if not isinstance(other, Symbol):
+ ... |
lark-parser__lark-636 | [
{
"changes": {
"added_entities": [
"lark/parser_frontends.py:LALR_CustomLexerWrapper.__init__",
"lark/parser_frontends.py:LALR_CustomLexerWrapper.init_lexer"
],
"added_modules": [
"lark/parser_frontends.py:LALR_CustomLexerWrapper"
],
"edited_entities": [
... | lark-parser/lark | 1ec02ff5cf55da485db02bdea4c51803d243d80f | Lark cache fails when custom lexers are used
**Describe the bug**
In parser_frontends.py, the passed lexer is wrapped using functools.partial:
```
return partial(LALR_CustomLexer, lexer)
```
but this results in a functools.partial object, not a lexer object, so when deserialize is called later, it fails with
... | diff --git a/lark/parser_frontends.py b/lark/parser_frontends.py
index 08f4756..c05f235 100644
--- a/lark/parser_frontends.py
+++ b/lark/parser_frontends.py
@@ -1,5 +1,3 @@
-from functools import partial
-
from .utils import get_regexp_width, Serialize
from .parsers.grammar_analysis import GrammarAnalyzer
from .lexe... |
lark-parser__lark-650 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/common.py:LexerConf._deserialize"
],
"edited_modules": [
"lark/common.py:LexerConf"
]
},
"file": "lark/common.py"
},
{
"changes": {
"added_entities":... | lark-parser/lark | c9ca287e9e2ae2a3f5ad7cf028fdabf408f053a1 | Transformer is not applied for tokens in standalone parser
**Describe the bug**
Standalone parser doesn't invoke methods on tokens defined in supplied transformer
**To Reproduce**
Given:
- grammar `example.lark`:
```
start: IDENTIFIER "(" text ")"
IDENTIFIER: /[A-Za-z_][A-Za-z0-9_]*/
text: IDENTIFIER
```
- ... | diff --git a/lark/common.py b/lark/common.py
index cc8c73c..714399a 100644
--- a/lark/common.py
+++ b/lark/common.py
@@ -17,9 +17,6 @@ class LexerConf(Serialize):
self.skip_validation = skip_validation
self.use_bytes = use_bytes
- def _deserialize(self):
- self.callbacks = {} # TODO
-
###... |
lark-parser__lark-661 | [
{
"changes": {
"added_entities": [
"lark/parse_tree_builder.py:AmbiguousIntermediateExpander.__init__",
"lark/parse_tree_builder.py:AmbiguousIntermediateExpander.__call__"
],
"added_modules": [
"lark/parse_tree_builder.py:AmbiguousIntermediateExpander"
],
"e... | lark-parser/lark | c4423910ff725819c6a1f992791e99b1b8a0ca8d | Ambiguity error for simple grammar
Hi,
I recently stumbled upon an error, where ``lark`` is missing some ambiguous solutions. I tried to create a minimal example to make the problem easier to understand. The code is the following:
#### Code
```python
import lark
simple_string = 'aaab'
simple_grammar = '''... | diff --git a/lark/parse_tree_builder.py b/lark/parse_tree_builder.py
index 5a7c5d7..8b81d29 100644
--- a/lark/parse_tree_builder.py
+++ b/lark/parse_tree_builder.py
@@ -195,6 +195,86 @@ def maybe_create_ambiguous_expander(tree_class, expansion, keep_all_tokens):
if to_expand:
return partial(AmbiguousExpan... |
lark-parser__lark-707 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "lark/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/lark.py:Lark._... | lark-parser/lark | 809b0308a4bbc99a786a2ff29cce7f560656c08b | maybe_placeholders and anonymous terminal omits the None
Doc says [here](https://lark-parser.readthedocs.io/en/latest/grammar.html#rules) that `maybe_placeholders=True` makes ` rule : some1 [item] some2` to produce a `None` if item is not found, but anonymous token seems to not produce `None`.
Minimal reproduction: ... | diff --git a/lark/__init__.py b/lark/__init__.py
index 0e0ba4d..33a68cb 100644
--- a/lark/__init__.py
+++ b/lark/__init__.py
@@ -7,4 +7,4 @@ from .exceptions import (ParseError, LexError, GrammarError, UnexpectedToken,
from .lexer import Token
from .lark import Lark
-__version__ = "0.10.1"
+__version__ = "0.10.0"
d... |
lark-parser__lark-708 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/lark.py:Lark.__init__"
],
"edited_modules": [
"lark/lark.py:Lark"
]
},
"file": "lark/lark.py"
},
{
"changes": {
"added_entities": null,
"added_... | lark-parser/lark | 809b0308a4bbc99a786a2ff29cce7f560656c08b | "Unused" terminals are filtered out before post-lexer can handle them
Over a year ago, I implemented parsing for a custom language with significant whitespace. I used a custom post-lexer (written by me) to transform certain tokens (e.g. newline and following whitespace) into new tokens (e.g. indent, unindent) that are... | diff --git a/lark-stubs/__init__.pyi b/lark-stubs/__init__.pyi
index 7545f2d..c010a93 100644
--- a/lark-stubs/__init__.pyi
+++ b/lark-stubs/__init__.pyi
@@ -5,5 +5,7 @@ from .visitors import *
from .exceptions import *
from .lexer import *
from .lark import *
+from logging import Logger as _Logger
+logger: _Logger... |
lark-parser__lark-745 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/parsers/earley.py:Parser.parse"
],
"edited_modules": [
"lark/parsers/earley.py:Parser"
]
},
"file": "lark/parsers/earley.py"
},
{
"changes": {
"added... | lark-parser/lark | 0aac2760c86cc69ea499266bc9036af18e6b195e | Bug in Earley parser when there is ambiguity in empty rules
**Describe the bug**
The Earley parser creates an incorrect tree
**To Reproduce**
```python
from lark import Lark
grammar = """
a: _x
_x: _x? b
b:
"""
p = Lark(grammar, start='a', ambiguity='explicit')
```
This will throw an `IndexError` ... | diff --git a/lark/parsers/earley.py b/lark/parsers/earley.py
index 3ccba01..d6afa71 100644
--- a/lark/parsers/earley.py
+++ b/lark/parsers/earley.py
@@ -315,7 +315,7 @@ class Parser:
if self.tree_class is not None:
# Perform our SPPF -> AST conversion
- transformer = ForestToParseTree... |
lark-parser__lark-755 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/parsers/earley_forest.py:PackedData.__init__",
"lark/parsers/earley_forest.py:ForestToParseTree.transform_packed_node"
],
"edited_modules": [
"lark/parsers/earley_forest... | lark-parser/lark | 5149d38e259a226e31c9aa2e7692296bc0c2be76 | Working grammar on Lark 0.9.0 throws IndexError on post-0.9.0
**Describe the bug**
My parser runs on Lark 0.9.0, but throws IndexError on both Lark 0.10.1 and master branch. The parser is Earley and uses the same custom indenter as for Python examples.
I reported this bug earlier in Gitter, sharing a stack dump a... | diff --git a/lark/parsers/earley_forest.py b/lark/parsers/earley_forest.py
index 1a71379..03c4573 100644
--- a/lark/parsers/earley_forest.py
+++ b/lark/parsers/earley_forest.py
@@ -459,15 +459,20 @@ class PackedData():
that comes from the left child and the right child.
"""
+ class _NoData():
+ pa... |
lark-parser__lark-866 | [
{
"changes": {
"added_entities": [
"lark/lexer.py:LineCounter.__eq__",
"lark/lexer.py:LexerState.__eq__",
"lark/lexer.py:LexerThread.__copy__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"lark/lexer.py:LexerState",
... | lark-parser/lark | 811a4eb4925679fb62640f56e3bec4acada42fb9 | ParserPuppet.copy does not copy LexerState
**Describe the bug**
`ParserPuppet.copy` does not copy the lexer state. Instead it makes a shallow copy of `LexerThread`.
**To Reproduce**
```python3
# make a copy
puppet_copy = puppet.copy()
# advance LineCounter of copy
puppet_copy.lexer_state.state.line_ctr.f... | diff --git a/lark/lexer.py b/lark/lexer.py
index 5a8d21a..64dc33e 100644
--- a/lark/lexer.py
+++ b/lark/lexer.py
@@ -186,6 +186,13 @@ class LineCounter:
self.column = 1
self.line_start_pos = 0
+ def __eq__(self, other):
+ if not isinstance(other, LineCounter):
+ return NotImplem... |
lark-parser__lark-869 | [
{
"changes": {
"added_entities": [
"lark/lark.py:Lark.get_puppet"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"lark/lark.py:Lark"
]
},
"file": "lark/lark.py"
},
{
"changes": {
"added_entities": [
"lark/p... | lark-parser/lark | 5b8c04ca83b98f8887a5967f8260d44dec2f7422 | Obtain ParserPuppet directly?
**Suggestion**
I'm writing a language server with Lark, and I'm using a recursion-based approach for error handling and inference. For this I make use of `ParserPuppet` extensively, as a helper to store copies of states and try other branches. However, right now `ParserPuppet` can only be... | diff --git a/lark-stubs/lark.pyi b/lark-stubs/lark.pyi
index fba567b..6fd3139 100644
--- a/lark-stubs/lark.pyi
+++ b/lark-stubs/lark.pyi
@@ -2,8 +2,10 @@
from typing import (
TypeVar, Type, List, Dict, IO, Iterator, Callable, Union, Optional,
- Literal, Protocol, Tuple, Iterable,
+ Literal, Protocol, Tup... |
lark-parser__lark-878 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/utils.py:get_regexp_width"
],
"edited_modules": [
"lark/utils.py:get_regexp_width"
]
},
"file": "lark/utils.py"
}
] | lark-parser/lark | 672dfed7cee48137c30c549eaea6eeb688a5f8ce | More complete support of regex package
At present, the features of the `regex` package for extended regexes is not supported. For example, for conditional expressions. This example
```
import lark
g = lark.Lark(
r"""?start: NAME
NAME: /(?(?=\d)\d+|\w+)/""", regex=True)
g.parse('123aaa')
```
results ... | diff --git a/lark/utils.py b/lark/utils.py
index f3bd957..3e70a13 100644
--- a/lark/utils.py
+++ b/lark/utils.py
@@ -175,8 +175,17 @@ def get_regexp_width(expr):
try:
return [int(x) for x in sre_parse.parse(regexp_final).getwidth()]
except sre_constants.error:
- raise ValueError(expr)
-
+ ... |
lark-parser__lark-922 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lark/load_grammar.py:EBNF_to_BNF.maybe"
],
"edited_modules": [
"lark/load_grammar.py:EBNF_to_BNF"
]
},
"file": "lark/load_grammar.py"
}
] | lark-parser/lark | 887457859e5cc87ad2766d087a408819664bc081 | Incorrect behaviour for maybe_placeholders
**Describe the bug**
When maybe constructs are nested, maybe_placeholders gets confused.
**To Reproduce**
```
from lark import Lark
parser = Lark("""
start: [A [B]]
A: "a"
B: "b"
""", maybe_placeholders=True)
print(parser.parse(""))
print(parser.parse("a")... | diff --git a/lark/load_grammar.py b/lark/load_grammar.py
index 309826b..d425c72 100644
--- a/lark/load_grammar.py
+++ b/lark/load_grammar.py
@@ -344,12 +344,11 @@ class EBNF_to_BNF(Transformer_InPlace):
return not sym.name.startswith('_')
if isinstance(sym, Terminal):
retu... |
larq__zookeeper-114 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/core/component.py:component",
"zookeeper/core/component.py:configure"
],
"edited_modules": [
"zookeeper/core/component.py:component",
"zookeeper/core/compon... | larq/zookeeper | c48fa65d42f040c0134318e4393facb5a0941a33 | Include some sort of post-configure hook
We got rid of `validate_configuration`; maybe it can be replaced with `__component_configured__` or something similar. | diff --git a/zookeeper/core/component.py b/zookeeper/core/component.py
index 6180ab1..ebf57a5 100644
--- a/zookeeper/core/component.py
+++ b/zookeeper/core/component.py
@@ -385,6 +385,20 @@ def component(cls: Type):
raise TypeError("Component classes must not define a custom `__init__` method.")
cls.__ini... |
larq__zookeeper-122 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/core/component.py:_wrap_getattribute"
],
"edited_modules": [
"zookeeper/core/component.py:_wrap_getattribute"
]
},
"file": "zookeeper/core/component.py"
}
] | larq/zookeeper | c8eaab4bff5aaff6781617c7ec5b7eb9f04fb6d0 | `__getattribute__` can incorrectly call `build()` on factory instances
Implicit calling of `build()` is desired behaviour when accessing a field, but the current behaviour is for this to happen always, including e.g. when accessing `instance.__component_parent__`, as is frequently done internally. This is incorrect beh... | diff --git a/zookeeper/core/component.py b/zookeeper/core/component.py
index aa248b9..8ce0517 100644
--- a/zookeeper/core/component.py
+++ b/zookeeper/core/component.py
@@ -215,7 +215,9 @@ def _wrap_getattribute(component_cls: Type) -> None:
@functools.wraps(base_wrapped_fn)
def wrapped_fn(instance, name):
... |
larq__zookeeper-124 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/core/component.py:_type_check_and_cache",
"zookeeper/core/component.py:_wrap_getattribute",
"zookeeper/core/component.py:configure"
],
"edited_modules": [
"... | larq/zookeeper | f29443225770ab3582bfb9d461f5b77c303b3d84 | Error when configuring components with values inherited from factories
The following fails:
```python
@factory
class IntFactory:
def build(self) -> int:
return 5
@component
class Child:
x: int = ComponentField()
@component
class Parent:
child:... | diff --git a/zookeeper/core/component.py b/zookeeper/core/component.py
index 8ce0517..7944fa6 100644
--- a/zookeeper/core/component.py
+++ b/zookeeper/core/component.py
@@ -106,7 +106,7 @@ def _type_check_and_cache(instance, field: Field, result: Any) -> None:
raise TypeError(
f"Field '{field.name... |
larq__zookeeper-131 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/core/component.py:configure"
],
"edited_modules": [
"zookeeper/core/component.py:configure"
]
},
"file": "zookeeper/core/component.py"
}
] | larq/zookeeper | e41661a9a067cd5b684a60b67c49175536f22371 | Non-components should raise an error when being configured
### Describe the bug
A subclass of a component that itself does not have an `@component` decorator can be initialized with `configure` without any errors. It will then not act as expected, since it is not a component.
### To Reproduce
```python
@compone... | diff --git a/zookeeper/core/component.py b/zookeeper/core/component.py
index 7944fa6..d5f0f7a 100644
--- a/zookeeper/core/component.py
+++ b/zookeeper/core/component.py
@@ -474,6 +474,13 @@ def configure(
overwrite any values already set on the instance - either class defaults
or those set in `__init__`.
... |
larq__zookeeper-228 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/core/component.py:configure_component_instance"
],
"edited_modules": [
"zookeeper/core/component.py:configure_component_instance"
]
},
"file": "zookeeper/core... | larq/zookeeper | 52b97b05f09cf8f29d65cc82f1be1ce2fd6dfdc4 | ComponentFields passed through the CLI don't get their Fields resolved
### Describe the bug
In the code below, let's say it's called `script.py`, `child.some_attribute` should be inherited from the `Parent` class. This works just fine if you execute this with `python script.py`, but if you instead excute `python scrip... | diff --git a/zookeeper/core/component.py b/zookeeper/core/component.py
index e3fde1f..63b0ee6 100644
--- a/zookeeper/core/component.py
+++ b/zookeeper/core/component.py
@@ -484,6 +484,14 @@ def configure_component_instance(
conf_field_value = subclass()
break
... |
larq__zookeeper-241 | [
{
"changes": {
"added_entities": [
"zookeeper/core/component.py:__component_len__",
"zookeeper/core/component.py:__component_contains__",
"zookeeper/core/component.py:__component_iter__"
],
"added_modules": [
"zookeeper/core/component.py:__component_len__",
... | larq/zookeeper | 60ee7890ca7d8af30e480ef35096b96911265b80 | Expose a method to get component values after configuration
It might be good idea to have a method that returns a dictionary of configured values for all components. This is needed for instance when one wants to pass the config to experiment tracking libraries such as wandb or polyaxon.
This can currently be done by... | diff --git a/zookeeper/core/component.py b/zookeeper/core/component.py
index 9d5d455..b16b97e 100644
--- a/zookeeper/core/component.py
+++ b/zookeeper/core/component.py
@@ -78,7 +78,7 @@ print(c)
import functools
import inspect
-from typing import AbstractSet, Any, Dict, Iterator, List, Optional, Type
+from typing ... |
larq__zookeeper-275 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/core/component.py:configure_component_instance",
"zookeeper/core/component.py:configure"
],
"edited_modules": [
"zookeeper/core/component.py:configure_component_ins... | larq/zookeeper | f9a2c19d429bf61a3bc64dc51ba942872b22c5a1 | `__pre_configure__` doesn't work with nested components
### Describe the bug
When `__pre_configure__` is used to modify the configuration dict of a component, the modified config is (incorrectly) _not_ passed to `configure` when called on its sub-components.
### To Reproduce
```python
@component
clas... | diff --git a/zookeeper/core/component.py b/zookeeper/core/component.py
index b16b97e..dccfa79 100644
--- a/zookeeper/core/component.py
+++ b/zookeeper/core/component.py
@@ -694,6 +694,8 @@ def configure_component_instance(
if hasattr(instance.__class__, "__post_configure__"):
instance.__post_configure__()... |
larq__zookeeper-48 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/hparam.py:str_key_val",
"zookeeper/hparam.py:HParams.__str__",
"zookeeper/hparam.py:HParams.__repr__"
],
"edited_modules": [
"zookeeper/hparam.py:str_key_va... | larq/zookeeper | eb5f593db0922bde8a2a49cad35b8dbf11be390a | Support nested HParams
If we have a model with multiple independent components, e.g. an encoder and a decoder, or a base network and some auxilliary structure, it would be nice if the `HParams` class could nest other `HParams` classes, one for each of the components.
This would facilitate easy model modularity, e.g.... | diff --git a/zookeeper/hparam.py b/zookeeper/hparam.py
index 709f2ba..5416e0e 100644
--- a/zookeeper/hparam.py
+++ b/zookeeper/hparam.py
@@ -11,14 +11,21 @@ except ImportError: # pragma: no cover
SPLIT_REGEX = re.compile(r",?(\w+)=")
+INDENT = " "
+
def group(sequence):
return zip(*[iter(sequence)] * 2... |
larq__zookeeper-96 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zookeeper/core/cli.py:ConfigParam.convert"
],
"edited_modules": [
"zookeeper/core/cli.py:ConfigParam"
]
},
"file": "zookeeper/core/cli.py"
},
{
"changes": {
... | larq/zookeeper | e4770f13416e160cb5a3fa6122668bf014d567ee | Flag syntax for boolean params
At the moment, CLI params are passed with arguments of the form `key=value`, meaning that boolean parameters are set with e.g. `use_bias=True` or `use_bias=False`.
It would be nice if we could have the option of passing boolean arguments with `--use-bias` or `--no-use-bias` to set that... | diff --git a/zookeeper/core/cli.py b/zookeeper/core/cli.py
index 5769b13..f2ab714 100644
--- a/zookeeper/core/cli.py
+++ b/zookeeper/core/cli.py
@@ -7,6 +7,14 @@ from zookeeper.core.utils import convert_to_snake_case, parse_value_from_string
class ConfigParam(click.ParamType):
def convert(self, str_value, param... |
larsoner__flake8-array-spacing-3 | [
{
"changes": {
"added_entities": [
"flake8_array_spacing/__init__.py:ArraySpacing.ignoring"
],
"added_modules": null,
"edited_entities": [
"flake8_array_spacing/__init__.py:ArraySpacing.__init__",
"flake8_array_spacing/__init__.py:ArraySpacing.__iter__"
],
... | larsoner/flake8-array-spacing | 772e3f1ea84eee89068cc8a775d74cd059e353e3 | BUG: Installing for one repo breaks others
I installed this to make things work for SciPy, now in MNE-Python I get a bunch of A241's even though we have E241 disabled for MNE-Python. I wonder if we need an explicit `--array-spacing` or so. It's trivial to add but seems like a bit of a hack... | diff --git a/README.rst b/README.rst
index fa55f59..3487b30 100644
--- a/README.rst
+++ b/README.rst
@@ -1,2 +1,4 @@
-# flake8-array-spacing
+flake8-array-spacing
+====================
+
Recast some E2XX errors as A2XX with exceptions for array-like variables
diff --git a/flake8_array_spacing/__init__.py b/flake8_arra... |
larsoner__flake8-array-spacing-4 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flake8_array_spacing/__init__.py:ArraySpacing.in_array_like"
],
"edited_modules": [
"flake8_array_spacing/__init__.py:ArraySpacing"
]
},
"file": "flake8_array_spacing/_... | larsoner/flake8-array-spacing | 7dd499e8413ca4a354aed926e337e05434b9b6fb | BUG: Regex should be more complete/selective
It should be more selective (matching `[` and maybe ensuring any `i/j` are immediately preceded by numbers, currently it's pretty basic:
```
ARRAY_LIKE_REGEX = re.compile(
r'[\[(][0-9 ij,+\-*^\/&|\[\]]*[\]),;]'
)
```
@jnothman I know you work on sklearn, @agramfo... | diff --git a/flake8_array_spacing/__init__.py b/flake8_array_spacing/__init__.py
index 052b4b0..b19694d 100644
--- a/flake8_array_spacing/__init__.py
+++ b/flake8_array_spacing/__init__.py
@@ -9,9 +9,50 @@ __version__ = '0.1.dev0'
# This could almost certainly be better, it just checks for [...]
# (no pairing withi... |
laterpay__laterpay-client-python-103 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"laterpay/__init__.py:LaterPayClient.get_access_params"
],
"edited_modules": [
"laterpay/__init__.py:LaterPayClient"
]
},
"file": "laterpay/__init__.py"
}
] | laterpay/laterpay-client-python | 397afe02a9ddec00096da24febb8f37d60658f26 | We must only pass lptoken or muid to /access
Only one of `lptoken` and `muid` is allowed to the API's `/access` calls. Not both. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0ba7c00..5ad4dde 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
## 5.3.1 (under development)
+* Only passed one of `lptoken` and `muid` to `/access` calls. Passing both is
+ not supported.
+
## 5.3.0
* Added explicit support for the `muid` argument ... |
laterpay__laterpay-client-python-108 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"laterpay/__init__.py:LaterPayClient.__init__",
"laterpay/__init__.py:LaterPayClient.get_access_data"
],
"edited_modules": [
"laterpay/__init__.py:LaterPayClient"
]
... | laterpay/laterpay-client-python | 87100aa64f880f61f9cdda81f1675c7650fc7c2e | Added support for `requests.Session`
Sometimes it's desirable to use [`requests.Session()`](http://docs.python-requests.org/en/master/user/advanced/#session-objects) over `requests.get()`. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9257c1d..5da76e2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
## 5.4.0 (under development)
+* Added the `connection_handler` to `LaterPayClient` to simplify connection
+ pooling.
+
## 5.3.1
* Only passed one of `lptoken` and `muid` to `/access` ca... |
laterpay__laterpay-client-python-82 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"laterpay/__init__.py:LaterPayClient._make_request",
"laterpay/__init__.py:LaterPayClient.get_request_headers"
],
"edited_modules": [
"laterpay/__init__.py:LaterPayClient"
... | laterpay/laterpay-client-python | 3744237922be5c422568b701a6bf930418581be8 | python-requests requires string only headers
As of python-requests 2.11 headers that are neither string not bytes are not accepted anymore. See kennethreitz/requests#3477 | diff --git a/laterpay/__init__.py b/laterpay/__init__.py
index c92f556..f2df4a4 100644
--- a/laterpay/__init__.py
+++ b/laterpay/__init__.py
@@ -421,10 +421,7 @@ class LaterPayClient(object):
"""
params = self._sign_and_encode(params=params, url=url, method=method)
- headers = {
- ... |
laterpay__laterpay-client-python-85 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"laterpay/signing.py:sort_params",
"laterpay/signing.py:create_base_message"
],
"edited_modules": [
"laterpay/signing.py:sort_params",
"laterpay/signing.py:create_base... | laterpay/laterpay-client-python | a4738be03b9cc0680d24466b7eefe5fdde6b7d2d | Decode byte strings before using them during signing
On Python 3, when singing a request containing a byte string (`b'foo'`) the value is casted into a string, resulting in `"b'foo'"`, instead of properly decoding the string to `'foo'`.
| diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8484c44..532fd0e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,7 +1,11 @@
# Changelog
-## Unreleased
+## 4.6.0 (under development)
+
+* Fixed encoding issues when passing byte string parameters on Python 3
+ ([#84](https://github.com/laterpay/laterpay-client-pyt... |
laterpay__laterpay-client-python-87 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"laterpay/__init__.py:ItemDefinition.__init__",
"laterpay/__init__.py:LaterPayClient.get_identify_url",
"laterpay/__init__.py:LaterPayClient.get_iframeapi_links_url",
"laterpay/__... | laterpay/laterpay-client-python | 67ebeb9dac24e5fe59d65ca4986c97aa38cfe6b4 | Actually remove deprecated code
We raise a couple of deprecation warnings for a long time now. We should actually clean up the code base and get rid of those function.
| diff --git a/CHANGELOG.md b/CHANGELOG.md
index ee7351b..55bab53 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,30 @@
# Changelog
+## 5.0.0 (under development)
+
+* Removed the following long deprecated methods from the
+ `laterpay.LaterPayClient`:
+
+ * `get_access()`, use `get_access_data()` instead
+ *... |
laterpay__laterpay-client-python-94 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"laterpay/signing.py:time_independent_HMAC_compare"
],
"edited_modules": [
"laterpay/signing.py:time_independent_HMAC_compare"
]
},
"file": "laterpay/signing.py"
}
] | laterpay/laterpay-client-python | efe5ec2ff1a6b4020ae081c7491c7f9eca22cc4e | Ignore capitalization when checking HMACs
`laterpay.signing.time_independent_HMAC_compare()` treats hashes `12ab3` and `12AB3` as different. Let's not do that. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index edb66fd..2e263cb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
## 5.1.0 (under development)
+* Ignored HMAC character capitalization
+ ([#93](https://github.com/laterpay/laterpay-client-python/issues/93))
+
## 5.0.0
* Removed the following long dep... |
laughingman7743__BigQuery-DatasetManager-3 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "bqdm/cli.py"
},
{
"changes": {
"added_entities": [
"bqdm/model.py:BigQueryAccessEntry.from_dict",
"bqdm/model.py:BigQueryAccessE... | laughingman7743/BigQuery-DatasetManager | 555792046ce2e7664229a54cce1f3a6bb516980a | Migrating to Python Client Library v0.28
https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/bigquery-0.28.0 | diff --git a/README.rst b/README.rst
index 3559c85..a4799df 100644
--- a/README.rst
+++ b/README.rst
@@ -44,7 +44,7 @@ The resource representation of the dataset is described in `YAML format`_.
description: null
default_table_expiration_ms: null
location: US
- access_grants:
+ access_entries:
... |
laughingman7743__BigQuery-DatasetManager-6 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bqdm/action.py:DatasetAction.get_add_datasets",
"bqdm/action.py:DatasetAction.get_destroy_datasets",
"bqdm/action.py:DatasetAction.get_intersection_datasets",
"bqdm/action.py:Dat... | laughingman7743/BigQuery-DatasetManager | 60e6ebe169f5e1be06b98cf878fee11702cf2ec7 | Migrating to Python Client Library v0.28
https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/bigquery-0.28.0 | diff --git a/README.rst b/README.rst
index 3559c85..ef9cbc1 100644
--- a/README.rst
+++ b/README.rst
@@ -44,7 +44,7 @@ The resource representation of the dataset is described in `YAML format`_.
description: null
default_table_expiration_ms: null
location: US
- access_grants:
+ access_entries:
... |
laughingman7743__BigQuery-DatasetManager-7 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bqdm/action.py:DatasetAction.change"
],
"edited_modules": [
"bqdm/action.py:DatasetAction"
]
},
"file": "bqdm/action.py"
},
{
"changes": {
"added_entities... | laughingman7743/BigQuery-DatasetManager | f0a7640c34dcb591b5a0d39148384e257c9a20ac | Manage labels field
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4245/files#diff-bafa3d472438f0a46853cc9879265cadR399 | diff --git a/README.rst b/README.rst
index ef9cbc1..1b2503f 100644
--- a/README.rst
+++ b/README.rst
@@ -44,6 +44,8 @@ The resource representation of the dataset is described in `YAML format`_.
description: null
default_table_expiration_ms: null
location: US
+ labels:
+ foo: bar
access_ent... |
lavr__python-emails-151 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"emails/backend/smtp/backend.py:SMTPBackend.__init__",
"emails/backend/smtp/backend.py:SMTPBackend.sendmail"
],
"edited_modules": [
"emails/backend/smtp/backend.py:SMTPBackend... | lavr/python-emails | eecc9ed30b3130e6675c9d9df5046312d97cd12f | Library does not support RFC 6532 (non ascii characters in local part of the email address)
The `sanitize_address` function in the utils file imports and makes use of the `formataddr` function from the stdlib.
According to [this thread ](https://bugs.python.org/issue25955), the `formataddr` should no longer be used:... | diff --git a/emails/backend/smtp/backend.py b/emails/backend/smtp/backend.py
index 558e75d..56ed3e6 100644
--- a/emails/backend/smtp/backend.py
+++ b/emails/backend/smtp/backend.py
@@ -26,7 +26,7 @@ class SMTPBackend(object):
connection_ssl_cls = SMTPClientWithResponse_SSL
response_cls = SMTPResponse
- d... |
lbl-anp__becquerel-199 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"becquerel/core/spectrum.py:Spectrum.find_bin_index"
],
"edited_modules": [
"becquerel/core/spectrum.py:Spectrum"
]
},
"file": "becquerel/core/spectrum.py"
}
] | lbl-anp/becquerel | 3e56c2465c48f1a712d1788ddd31a8355d97264e | Spectrum `find_bin_index` should be able to accept multiple x-values
Spectrum `find_bin_index` should be able to accept multiple x-values and return their bin indices. This should be pretty simple to implement. | diff --git a/becquerel/core/spectrum.py b/becquerel/core/spectrum.py
index b638b9b..88e9398 100644
--- a/becquerel/core/spectrum.py
+++ b/becquerel/core/spectrum.py
@@ -948,7 +948,7 @@ class Spectrum(object):
return True
def find_bin_index(self, x, use_kev=True):
- """Find the Spectrum bin index ... |
lbl-anp__becquerel-235 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"becquerel/core/utils.py:handle_datetime"
],
"edited_modules": [
"becquerel/core/utils.py:handle_datetime"
]
},
"file": "becquerel/core/utils.py"
},
{
"changes":... | lbl-anp/becquerel | aff117393daecb99e59e4d9b7b86141d48becae9 | IsotopeQuantity has a kwarg `date` that cannot be a `datetime.date` object
The kwarg `date` in IsotopeQuantity (and its docstring) suggest that a `datetime.date` object should work, but it won't:
(note for posterity that the actual calibration date of this source is Apr 1, 2019)
```
>>> bq.IsotopeQuantity('Cs-137', ... | diff --git a/becquerel/core/utils.py b/becquerel/core/utils.py
index 94395b2..e175407 100644
--- a/becquerel/core/utils.py
+++ b/becquerel/core/utils.py
@@ -5,6 +5,7 @@ import sys
import datetime
from dateutil.parser import parse as dateutil_parse
from uncertainties import UFloat, unumpy
+import warnings
import num... |
lbl-anp__becquerel-274 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"becquerel/core/fitting.py:Fitter.y_unc",
"becquerel/core/fitting.py:Fitter._set_likelihood_residual",
"becquerel/core/fitting.py:Fitter.param_dataframe"
],
"edited_modules": ... | lbl-anp/becquerel | d503da099f91ac25368429eca91d0b3cdc279942 | np.float is deprecated
I get a lot of these now:
```
DeprecationWarning: `np.float` is a deprecated alias for the builtin `float`. To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
Deprecated... | diff --git a/becquerel/core/fitting.py b/becquerel/core/fitting.py
index 3b2fb5c..31a018e 100644
--- a/becquerel/core/fitting.py
+++ b/becquerel/core/fitting.py
@@ -429,7 +429,7 @@ class Fitter(object):
@y_unc.setter
def y_unc(self, y_unc):
if y_unc is not None:
- self._y_unc = np.asarray(... |
lbl-anp__becquerel-275 | [
{
"changes": {
"added_entities": [
"becquerel/core/plotting.py:SpectrumPlotter.linthresh"
],
"added_modules": null,
"edited_entities": [
"becquerel/core/plotting.py:SpectrumPlotter.__init__",
"becquerel/core/plotting.py:SpectrumPlotter._prepare_plot",
"bec... | lbl-anp/becquerel | 9de1003b3ccdbcb6b14a0c38d4251f0caa295444 | linthreshy has been renamed to linthresh
Shows up during the tests:
```
becquerel/core/plotting.py:289: MatplotlibDeprecationWarning: The 'linthreshy' parameter of __init__() has been renamed 'linthresh' since Matplotlib 3.3; support for the old name will be dropped two minor releases later.
self.ax.set_yscale(s... | diff --git a/becquerel/core/plotting.py b/becquerel/core/plotting.py
index 3200def..1b9c699 100644
--- a/becquerel/core/plotting.py
+++ b/becquerel/core/plotting.py
@@ -3,6 +3,7 @@
import matplotlib.pyplot as plt
import numpy as np
from uncertainties import unumpy
+import warnings
class PlottingError(Exception)... |
lbl-anp__becquerel-328 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"becquerel/tools/materials_compendium.py:fetch_compendium_data"
],
"edited_modules": [
"becquerel/tools/materials_compendium.py:fetch_compendium_data"
]
},
"file": "becq... | lbl-anp/becquerel | 479a264362d4127f339292f4f8d21a6335a6903b | Latest Compendium materials JSON causes errors
The latest version of the materials data from the [PNNL Compendium](https://compendium.cwmd.pnnl.gov) cannot be parsed by the current version of `becquerel`.
Downloading the latest JSON and placing it into `becquerel/tools` and calling `bq.tools.force_load_and_write_mat... | diff --git a/becquerel/tools/materials_compendium.py b/becquerel/tools/materials_compendium.py
index af5988b..0e2af69 100644
--- a/becquerel/tools/materials_compendium.py
+++ b/becquerel/tools/materials_compendium.py
@@ -18,7 +18,7 @@ import os
import warnings
import numpy as np
import pandas as pd
-from .materials_... |
lbl-anp__becquerel-341 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"becquerel/core/rebin.py:rebin"
],
"edited_modules": [
"becquerel/core/rebin.py:rebin"
]
},
"file": "becquerel/core/rebin.py"
},
{
"changes": {
"added_enti... | lbl-anp/becquerel | 211ada700a5e27c9b923f9b041608b55c20e642b | Rebinning uses first and last bin as overflow bins
When using `bq.rebin` or `bq.Spectrum.rebin`, the default behavior is to silently include all data outside the new binning scheme in the leftmost bin (if less than the leftmost bin edge) or in the rightmost bin (if greater than the rightmost bin edge). This behavior is... | diff --git a/becquerel/core/rebin.py b/becquerel/core/rebin.py
index ea39c99..2622c80 100644
--- a/becquerel/core/rebin.py
+++ b/becquerel/core/rebin.py
@@ -164,7 +164,7 @@ def _rebin_interpolation(
in_spectrum: iterable of input spectrum counts in each bin
in_edges: iterable of input bin edges (len = len... |
lbl-anp__becquerel-356 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"becquerel/core/fitting.py:Fitter._guess_param_defaults",
"becquerel/core/fitting.py:Fitter.param_val",
"becquerel/core/fitting.py:Fitter.param_unc"
],
"edited_modules": [
... | lbl-anp/becquerel | e0c52f1593e1908a04c14891393121d146862a6f | iminuit parameter lookup does not error on bad parameter names
This feels like a bug in iminuit, not becquerel, but we could certainly check the parameter name first.
| diff --git a/becquerel/core/fitting.py b/becquerel/core/fitting.py
index c5c594f..2ffdaf4 100644
--- a/becquerel/core/fitting.py
+++ b/becquerel/core/fitting.py
@@ -734,6 +734,8 @@ class Fitter:
p = comp.guess(self.y_roi, x=self.x_roi, dx=self.dx_roi)
if isinstance(p, Parameters):
... |
lbl-anp__becquerel-408 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"becquerel/core/spectrum.py:Spectrum.__add__",
"becquerel/core/spectrum.py:Spectrum.__sub__",
"becquerel/core/spectrum.py:Spectrum._mul_div",
"becquerel/core/spectrum.py:Spectrum.... | lbl-anp/becquerel | 1580ab4bebbf6bccac8a7e16ef045f68a5d497c0 | replace calls to Spectrum() with self.__class__() etc.
Throughout `Spectrum` (and probably other classes) there are many points where a `Spectrum` method returns a new `Spectrum` object by doing `return Spectrum(...)`. However this is kind of bad practice as downstream users may derive their own classes from `Spectrum`... | diff --git a/becquerel/core/spectrum.py b/becquerel/core/spectrum.py
index feff92a..a343c78 100644
--- a/becquerel/core/spectrum.py
+++ b/becquerel/core/spectrum.py
@@ -811,9 +811,9 @@ class Spectrum:
kwargs = {"cps": self.cps + other.cps}
if self.is_calibrated and other.is_calibrated:
- ... |
lbl-srg__BuildingsPy-156 | [
{
"changes": {
"added_entities": [
"buildingspy/development/validator.py:Validator._validate_experiment_setup",
"buildingspy/development/validator.py:Validator.validateExperimentSetup"
],
"added_modules": null,
"edited_entities": [
"buildingspy/development/validat... | lbl-srg/BuildingsPy | ef15ad34246ac1d4cddf7a45feb1bfeac69936bf | change function names that validate experiment setup
The newly introduced functions are called `validateModelParameters` but in fact they validate the experiment setup which are not a Modelica parameter. This branch is to refactor the names. | diff --git a/buildingspy/development/validator.py b/buildingspy/development/validator.py
index 2e9cf30..f34224a 100644
--- a/buildingspy/development/validator.py
+++ b/buildingspy/development/validator.py
@@ -184,14 +184,14 @@ Modelica package. Expected file '%s'."
return (document, errors)
def _recursi... |
lbl-srg__BuildingsPy-181 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"buildingspy/development/error_dictionary.py:ErrorDictionary.__init__"
],
"edited_modules": [
"buildingspy/development/error_dictionary.py:ErrorDictionary"
]
},
"file": ... | lbl-srg/BuildingsPy | ad2f3e7ffb0a01117e5f09ac498a87b5c02ca158 | add test for Mismatched displayUnit
Add a test for `Mismatched displayUnit` to the regression testing | diff --git a/buildingspy/development/error_dictionary.py b/buildingspy/development/error_dictionary.py
index 2304f63..4a3c8d3 100644
--- a/buildingspy/development/error_dictionary.py
+++ b/buildingspy/development/error_dictionary.py
@@ -138,6 +138,13 @@ class ErrorDictionary(object):
'model_message': "\"in... |
lbl-srg__BuildingsPy-183 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"buildingspy/development/error_dictionary.py:ErrorDictionary.__init__"
],
"edited_modules": [
"buildingspy/development/error_dictionary.py:ErrorDictionary"
]
},
"file": ... | lbl-srg/BuildingsPy | ad2f3e7ffb0a01117e5f09ac498a87b5c02ca158 | In reference results, exclude CPUtime and EventCounter in FMI dependencies
These are only written based on the configuration of Dymola. As they are only output of the solver, they should be excluded from the reference results. | diff --git a/buildingspy/development/error_dictionary.py b/buildingspy/development/error_dictionary.py
index 2304f63..4a3c8d3 100644
--- a/buildingspy/development/error_dictionary.py
+++ b/buildingspy/development/error_dictionary.py
@@ -138,6 +138,13 @@ class ErrorDictionary(object):
'model_message': "\"in... |
lbl-srg__BuildingsPy-249 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"buildingspy/development/error_dictionary_dymola.py:ErrorDictionary.__init__"
],
"edited_modules": [
"buildingspy/development/error_dictionary_dymola.py:ErrorDictionary"
]
}... | lbl-srg/BuildingsPy | 22db44ff2a3b4d4bf6e2233c50d1cbf186bc8db4 | slow parsing using Modelica.Utilities.Strings.Count
BuildingsPy relies on the use of `Modelica.Utilities.Strings.Count` for counting the number of occurrences of specific substrings in the translation log. This implementation seems quite inefficient, which is a problem for large models that have a translation log of ~1... | diff --git a/buildingspy/development/error_dictionary_dymola.py b/buildingspy/development/error_dictionary_dymola.py
index c163591..6e24d20 100644
--- a/buildingspy/development/error_dictionary_dymola.py
+++ b/buildingspy/development/error_dictionary_dymola.py
@@ -26,7 +26,8 @@ class ErrorDictionary(ed.ErrorDictionary)... |
lbl-srg__BuildingsPy-260 | [
{
"changes": {
"added_entities": [
"buildingspy/development/merger.py:IBPSA.remove_library_specific_documentation"
],
"added_modules": null,
"edited_entities": [
"buildingspy/development/merger.py:IBPSA._copy_rename"
],
"edited_modules": [
"buildingspy... | lbl-srg/BuildingsPy | 9ff3adb370d0be61710cd556cb9b0bc7c274941a | add handling of library-specific comments
This issue is to handle library specific comments of the form
```
<!-- @include_Buildings @include_IDEAS
some documentation to be used for Buildings and IDEAS library only, but
remain in comments for other libraries.
-->
```
This is to support https://github.com/i... | diff --git a/buildingspy/CHANGES.txt b/buildingspy/CHANGES.txt
index 5902251..48feed5 100644
--- a/buildingspy/CHANGES.txt
+++ b/buildingspy/CHANGES.txt
@@ -3,6 +3,7 @@ BuildingsPy Changelog
Version 2.0.0, xxx
^^^^^^^^^^^^^^^^^^
+- Added handling of library specific comments in buildingspy.development.merger
- Imp... |
lbl-srg__BuildingsPy-377 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"buildingspy/development/error_dictionary_dymola.py:ErrorDictionary.__init__"
],
"edited_modules": [
"buildingspy/development/error_dictionary_dymola.py:ErrorDictionary"
]
}... | lbl-srg/BuildingsPy | a27e52fd0339a57d87290abef8878300b1e74931 | check for wrong derivative implementation
Dymola 2021x beta2 issues warnings such as
```
Warning: function Buildings.Utilities.Psychrometrics.Functions.saturationPressureLiquid specified derivative Buildings.Utilities.Psychrometrics.Functions.BaseClasses.der_saturationPressureLiquid, but
argument TSat function did n... | diff --git a/buildingspy/CHANGES.txt b/buildingspy/CHANGES.txt
index ebf666b..32cc572 100644
--- a/buildingspy/CHANGES.txt
+++ b/buildingspy/CHANGES.txt
@@ -3,7 +3,7 @@ BuildingsPy Changelog
Version 2.2.0, xxx, 2020 -- Release 2.2
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-- xxx
+- Added check for wrong derivative im... |
lbl-srg__BuildingsPy-383 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"buildingspy/development/refactor.py:replace_text_in_file",
"buildingspy/development/refactor.py:_getShortName",
"buildingspy/development/refactor.py:_updateFile"
],
"edited_m... | lbl-srg/BuildingsPy | 1a1967f51e19cd0ae88e766b28681ecfbf5ac263 | Bug in development.refactor.move_class when updating class path
The function `_getShortName` converts the class reference `A.B.C.X.Y` in the file `A/B/C/D/E.mo` into `X.Y`.
This is incorrect in the case where a subpackage `X` also exists under `D` (typically `BaseClasses`).
In that case the function should return `C.... | diff --git a/buildingspy/development/refactor.py b/buildingspy/development/refactor.py
index a4cb721..216d16c 100644
--- a/buildingspy/development/refactor.py
+++ b/buildingspy/development/refactor.py
@@ -16,6 +16,7 @@
"""
import os
+import re
__all__ = ["create_modelica_package", "move_class", "write_package_or... |
lbl-srg__BuildingsPy-388 | [
{
"changes": {
"added_entities": [
"buildingspy/development/refactor.py:_get_constants"
],
"added_modules": [
"buildingspy/development/refactor.py:_get_constants"
],
"edited_entities": [
"buildingspy/development/refactor.py:_get_package_list_for_file"
... | lbl-srg/BuildingsPy | c047e118c177d637f1729c2fa8240ac7e649154a | Package.order is misses to include constants that are arrays
This issue is to correct the generation of `package.order` for packages that have constant arrays, such as
```modelica
final constant Real A[:] = {-1.721781e2, 2.381558e-1, -4.329207e-4, -6.241072e-7}
"Coefficients A for Martin-Hou equation of state"... | diff --git a/buildingspy/CHANGES.txt b/buildingspy/CHANGES.txt
index ac2406f..e4bb144 100644
--- a/buildingspy/CHANGES.txt
+++ b/buildingspy/CHANGES.txt
@@ -4,6 +4,7 @@ BuildingsPy Changelog
Version 2.2.0, xxx, 2020 -- Release 2.2
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- xxx
+- Corrected generation of package.order... |
lbl-srg__BuildingsPy-545 | [
{
"changes": {
"added_entities": [
"buildingspy/development/validator.py:Validator.validateHyperlinks"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"buildingspy/development/validator.py:Validator"
]
},
"file": "buildingspy/dev... | lbl-srg/BuildingsPy | 8f63e915125d263a3f609dac153390507bfdaea5 | Search Modelica html for broken links to images
When exporting the html documentation for Modelica libraries, Dymola does not check for broken links to image files.
This issue is to add a test that reports an error if any broken link is detected.
The test should search for strings of the form
```
\"modelica://s... | diff --git a/buildingspy/CHANGES.txt b/buildingspy/CHANGES.txt
index 0a9e001..f6497ba 100644
--- a/buildingspy/CHANGES.txt
+++ b/buildingspy/CHANGES.txt
@@ -1,8 +1,12 @@
BuildingsPy Changelog
---------------------
-Version 5.1.1, xxxx
+Version 5.2.0, xxxx
^^^^^^^^^^^^^^^^^^^
+
+- In buildingspy/development/validat... |
lbl-srg__BuildingsPy-567 | [
{
"changes": {
"added_entities": [
"buildingspy/development/merger.py:IBPSA.remove_library_specific_modelica_code"
],
"added_modules": null,
"edited_entities": [
"buildingspy/development/merger.py:IBPSA._copy_rename"
],
"edited_modules": [
"buildingspy... | lbl-srg/BuildingsPy | 1c5779d86a68993ca453654e58d1202179aca53d | Add mechanism to exclude or leave certain Modelica code when merging IBPSA to other libraries
The heat pump model `PartialReversibleRefrigerantMachine` has code that need to be removed for `AixLib`, but left in place for `Buildings`, `BuildingSystems` and `IDEAS`.
The current mechanism with `<!-- ....` was designed ... | diff --git a/buildingspy/CHANGES.txt b/buildingspy/CHANGES.txt
index 97b17b2..49f0630 100644
--- a/buildingspy/CHANGES.txt
+++ b/buildingspy/CHANGES.txt
@@ -4,6 +4,9 @@ BuildingsPy Changelog
Version 5.2.0, xxxx
^^^^^^^^^^^^^^^^^^^
+- In buildingspy/development/merger.py, added new comment form to allow excluding
+ ... |
learningequality__kolibri-13178 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kolibri/core/content/management/commands/exportchannel.py:Command.handle_async"
],
"edited_modules": [
"kolibri/core/content/management/commands/exportchannel.py:Command"
]
... | learningequality/kolibri | 03ed7295b3f800c49f4e87ec686d2232dc4e0aef | `exportchannel` command is migrated and all associated tasks updated
move [this logic](https://github.com/learningequality/kolibri/blob/develop/kolibri/core/content/management/commands/exportchannel.py#L25) to a separate util function copy_channel/export_channel | diff --git a/kolibri/core/content/management/commands/exportchannel.py b/kolibri/core/content/management/commands/exportchannel.py
index ed2384a1ea..d624ae6cb6 100644
--- a/kolibri/core/content/management/commands/exportchannel.py
+++ b/kolibri/core/content/management/commands/exportchannel.py
@@ -1,9 +1,7 @@
import l... |
learningequality__kolibri-5637 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "kolibri/deployment/default/settings/base.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
... | learningequality/kolibri | fcf8528e35e66ae7693778655312f9cbc35e4428 | add 'disabled' list of plugins alongside 'enabled' in kolibri_settings.json
### Observed behavior
Currently we have no way of distinguishing disabled plugins from newly created plugins.
### Expected behavior
* disabled plugins should remain disabled across upgrades
* newly created default plugins should aut... | diff --git a/kolibri/deployment/default/settings/base.py b/kolibri/deployment/default/settings/base.py
index 30d876985e..72b4f926e2 100644
--- a/kolibri/deployment/default/settings/base.py
+++ b/kolibri/deployment/default/settings/base.py
@@ -74,7 +74,7 @@ INSTALLED_APPS = [
"django_js_reverse",
"jsonfield",
... |
learningequality__kolibri-5951 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kolibri/utils/cli.py:update"
],
"edited_modules": [
"kolibri/utils/cli.py:update"
]
},
"file": "kolibri/utils/cli.py"
}
] | learningequality/kolibri | 99ba95d7b0e26095292bbe1bcd382ea634927967 | Migrations / Initialization happens without checking if another instance is running
### Observed behavior
Kolibri 0.13.0.dev runs migrations even though another instance is running, which can potentially lead to database corruption.
CC: @rtibbles
### Expected behavior
Kolibri should immediately quit.
##... | diff --git a/kolibri/utils/cli.py b/kolibri/utils/cli.py
index 43743384c9..6c1a9098e2 100644
--- a/kolibri/utils/cli.py
+++ b/kolibri/utils/cli.py
@@ -334,6 +334,20 @@ def update(old_version, new_version):
logger.info("Running update routines for new version...")
+ try:
+ # Check if there are other k... |
learningequality__kolibri-8208 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kolibri/core/webpack/hooks.py:WebpackError.__init__",
"kolibri/core/webpack/hooks.py:WebpackBundleHook._stats_file_content",
"kolibri/core/webpack/hooks.py:WebpackBundleHook.frontend_mes... | learningequality/kolibri | 07d1a71efc536740439b1b86e9929190bf2659d5 | support for options aliases and deprecation
## Observed behavior
Follow-up from #8050 which fixed #5754
* In https://github.com/learningequality/kolibri/pull/8050/files#r626688907 there was discussion about adding better warnings for the deprecated `CHERRYPY_START` option
* the `CENTRAL_CONTENT_DOWNLOAD_BASE_U... | diff --git a/kolibri/core/webpack/hooks.py b/kolibri/core/webpack/hooks.py
index 5eb34a6405..8b4e01fd44 100644
--- a/kolibri/core/webpack/hooks.py
+++ b/kolibri/core/webpack/hooks.py
@@ -22,7 +22,6 @@ from functools import partial
from django.conf import settings
from django.contrib.staticfiles.finders import find as... |
learningequality__kolibri-8950 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kolibri/core/tasks/job.py:Job.update_progress",
"kolibri/core/tasks/job.py:Job.save_as_cancellable"
],
"edited_modules": [
"kolibri/core/tasks/job.py:Job"
]
},
... | learningequality/kolibri | 121a67267c35023bfc3350d411a3a06356bb8bd5 | Wrong progress on channel update
### Observed behavior
While trying to update ASB channel on kolibridemo, I went through the wizard that showed me the version "changelog" then when I started update task I saw it jump to 100% progress right away:
<img width="786" alt="shows as 100pct right away" src="https://user-... | diff --git a/kolibri/core/tasks/job.py b/kolibri/core/tasks/job.py
index 766601a856..233c17094a 100644
--- a/kolibri/core/tasks/job.py
+++ b/kolibri/core/tasks/job.py
@@ -249,6 +249,8 @@ class Job(object):
raise ReferenceError(
"storage is not defined on this job, cannot update pro... |
learningequality__kolibri-9291 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kolibri/utils/cli.py:start",
"kolibri/utils/cli.py:services"
],
"edited_modules": [
"kolibri/utils/cli.py:start",
"kolibri/utils/cli.py:services"
]
},
"... | learningequality/kolibri | 2094a043ade31bd8abf8b5c5e2d1a441e4b8394b | Refactor the KolibriProcessBus to allow for easier subclassing and selective inclusion of different architectural features
Currently the KolibriProcessBus is a monolith that includes a range of different functionality with conditional flags for enabling and disabling.
This means that running a slightly different arc... | diff --git a/kolibri/utils/cli.py b/kolibri/utils/cli.py
index 7db49a23db..426152b70b 100644
--- a/kolibri/utils/cli.py
+++ b/kolibri/utils/cli.py
@@ -255,12 +255,15 @@ def start(port, zip_port, background):
zip_port = (
OPTIONS["Deployment"]["ZIP_CONTENT_PORT"] if zip_port is None else zip_port
)
- ... |
learningequality__kolibri-9582 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kolibri/utils/server.py:installation_type"
],
"edited_modules": [
"kolibri/utils/server.py:installation_type"
]
},
"file": "kolibri/utils/server.py"
}
] | learningequality/kolibri | 3802d332015a029a6b3bf6b5c130927921323748 | In analytics payload, the "installer" field should indicate when a user is running Kolibri locally for dev purposes
<!--
Instructions:
* Fill out the sections below, replace …'s with information about your issue
* Use the 'preview' function above this text box to verify formatting before submitting
-->
### Obs... | diff --git a/kolibri/utils/server.py b/kolibri/utils/server.py
index b4c56c5e2b..01a7499cde 100644
--- a/kolibri/utils/server.py
+++ b/kolibri/utils/server.py
@@ -1030,12 +1030,12 @@ def installation_type(cmd_line=None): # noqa:C901
if install_type == "Unknown":
if on_android():
install_type... |
learningequality__kolibri-9722 | [
{
"changes": {
"added_entities": [
"kolibri/core/tasks/scheduler.py:Scheduler.test_table_readable"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"kolibri/core/tasks/scheduler.py:Scheduler"
]
},
"file": "kolibri/core/tasks/sched... | learningequality/kolibri | 4393460febbd7cd8fd3803a52f7640afe61ecb55 | Add sanity check to ensure that Job Storage tables are ready
## Observed behavior
In 0.15 the deletion and recreation of Job Storage tables at every restart was removed. This means that there are some possible scenarios where Kolibri could attempt to start, but the storage tables do not exist.
## Errors and logs
`... | diff --git a/kolibri/core/tasks/scheduler.py b/kolibri/core/tasks/scheduler.py
index d106ee5890..c0b05d7954 100644
--- a/kolibri/core/tasks/scheduler.py
+++ b/kolibri/core/tasks/scheduler.py
@@ -182,6 +182,13 @@ class Scheduler(StorageMixin):
scheduled_jobs = self._ns_query(s).all()
return [Jo... |
learningequality__kolibri-9740 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "kolibri/__init__.py"
},
{
"changes": {
"added_entities": [
"kolibri/utils/version.py:get_version_from_file"
],
"added_module... | learningequality/kolibri | 49a91e90574745975b352ae8405cb49947cb0d0f | make __init__.py's version a 3-tuple
### Observed behavior
Currently, `__init__.py` looks like this:
```python
#: This may not be the exact version as it's subject to modification with
#: get_version() - use ``kolibri.__version__`` for the exact version string.
VERSION = (0, 8, 0, 'alpha', 0)
```
The fact ... | diff --git a/kolibri/__init__.py b/kolibri/__init__.py
index 0055c6f923..60e3ff9eda 100755
--- a/kolibri/__init__.py
+++ b/kolibri/__init__.py
@@ -15,13 +15,12 @@ env.set_env()
#: This may not be the exact version as it's subject to modification with
#: get_version() - use ``kolibri.__version__`` for the exact vers... |
learningequality__le-utils-123 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "le_utils/constants/embed_content_request.py"
}
] | learningequality/le-utils | ce8adcff88cb671b20e29f6ffa49a0eda9ca6b74 | Update `embed_content_request.json` schema
## Overview
This task involves updating the `embed_content_request.json` schema to accept a list of files.
## Description and outcomes
- Modify the [embed_content_request.json](https://github.com/learningequality/le-utils/blob/main/spec/schema-embed_content_request.json) ... | diff --git a/js/EmbedContentRequest.js b/js/EmbedContentRequest.js
index 88176c6..c6ae021 100644
--- a/js/EmbedContentRequest.js
+++ b/js/EmbedContentRequest.js
@@ -15,6 +15,65 @@ export const SCHEMA = {
"description": "Language code from https://github.com/learningequality/le-utils/blob/main/le_utils/resources/... |
learningequality__ricecooker-329 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ricecooker/classes/nodes.py:CustomNavigationNode.__init__",
"ricecooker/classes/nodes.py:CustomNavigationChannelNode.__init__"
],
"edited_modules": [
"ricecooker/classes/node... | learningequality/ricecooker | 6b68dccffbc7dba1d5172347ebebe1f06719acb8 | Ensure topic/channel extra fields are added as 'options' in their extra_fields property to make sure options for topics are set during publishing
It appears that currently extra fields on topics are not annotated onto the exported topics during publishing.
This is required in order to properly export the modality extr... | diff --git a/ricecooker/classes/nodes.py b/ricecooker/classes/nodes.py
index 4b5e49f..0a7efe6 100644
--- a/ricecooker/classes/nodes.py
+++ b/ricecooker/classes/nodes.py
@@ -1069,7 +1069,9 @@ class CustomNavigationNode(ContentNode):
required_file_format = file_formats.HTML5
def __init__(self, *args, **kwargs... |
learningequality__ricecooker-394 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ricecooker/classes/nodes.py:TreeNode.__init__",
"ricecooker/classes/nodes.py:TreeNode.to_dict",
"ricecooker/classes/nodes.py:ContentNode.__init__",
"ricecooker/classes/nodes.py:C... | learningequality/ricecooker | ecea76069def01bae2aff9a3656d5715d85144e2 | TreeNode to_dict is incompatible with Studio unstable branch
* ricecooker version: v0.7.0-beta6
* Python version: 3.7
* Operating System: Fedora Silverblue 36
### Description
I am creating a ricecooker script which makes use of the new structured metadata fields in the `develop` branch. This script creates a tr... | diff --git a/Makefile b/Makefile
index aabbbbd..4a0a854 100644
--- a/Makefile
+++ b/Makefile
@@ -59,6 +59,14 @@ test: clean-test ## run tests quickly with the default Python
test-all: clean-test ## run tests on every Python version with tox
tox
+integration-test:
+ echo "Testing against hotfixes"
+ CONTENTWORKSHOP... |
lebedov__msgpack-numpy-43 | [
{
"changes": {
"added_entities": [
"msgpack_numpy.py:_unpack_dtype"
],
"added_modules": [
"msgpack_numpy.py:_unpack_dtype"
],
"edited_entities": [
"msgpack_numpy.py:decode"
],
"edited_modules": [
"msgpack_numpy.py:decode"
]
},
... | lebedov/msgpack-numpy | aa480f65fdbfb006b86622f40748e60977fa104d | Failures unpacking nested, structured dtypes.
`msgpack_numpy` fails when unpacking nested, structured dtypes.
See https://numpy.org/doc/stable/user/basics.rec.html for description.
Example:
```python
structured_dtype = np.dtype([("a", float), ("b", int)])
nested_dtype = np.dtype([("foo", structured_dtype), ... | diff --git a/msgpack_numpy.py b/msgpack_numpy.py
index 48e6df5..38d89a2 100644
--- a/msgpack_numpy.py
+++ b/msgpack_numpy.py
@@ -88,11 +88,11 @@ def decode(obj, chain=None):
else:
descr = obj[b'type']
return np.frombuffer(obj[b'data'],
- ... |
lebrice__SimpleParsing-140 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/parsing.py:ArgumentParser.parse_known_args",
"simple_parsing/parsing.py:ArgumentParser._set_instances_in_namespace"
],
"edited_modules": [
"simple_parsing/pars... | lebrice/SimpleParsing | 821f302d09511079de9225de109d380048a071c8 | Bug when mixing subgroups and "regular" dataclasses
When mixing both, e.g.
```python
@dataclass
class Config:
person: Person = subgroups({
"bob": Bob, "alice": Alice,
}, default=Bob)
parser = ArgumentParser()
parser.add_arguments(Config, dest="config")
parser.add_arguments(Foo, dest="foo")
args = par... | diff --git a/simple_parsing/parsing.py b/simple_parsing/parsing.py
index bb0dee1..4af37e0 100644
--- a/simple_parsing/parsing.py
+++ b/simple_parsing/parsing.py
@@ -2,12 +2,24 @@
@author: Fabrice Normandin
"""
import argparse
+import dataclasses
import sys
from argparse import SUPPRESS, Action, HelpFormatter, Name... |
lebrice__SimpleParsing-146 | [
{
"changes": {
"added_entities": [
"simple_parsing/annotation_utils/get_field_annotations.py:evaluate_string_annotation"
],
"added_modules": [
"simple_parsing/annotation_utils/get_field_annotations.py:evaluate_string_annotation"
],
"edited_entities": null,
"ed... | lebrice/SimpleParsing | 121bc50c7a44b34cc2b1c79741fc232607f5473c | Decoding dataclass with old-style type annotations (e.g. Optional[int]) fails when postponed annotations
**Describe the bug**
When postponed evaluation of type annotations is enabled, and the dataclass uses "old-style" type annotations, the decoding function for fields aren't found properly.
**To Reproduce**
```py... | diff --git a/simple_parsing/annotation_utils/get_field_annotations.py b/simple_parsing/annotation_utils/get_field_annotations.py
index 0977d9b..7586b39 100644
--- a/simple_parsing/annotation_utils/get_field_annotations.py
+++ b/simple_parsing/annotation_utils/get_field_annotations.py
@@ -19,6 +19,29 @@ import inspect
... |
lebrice__SimpleParsing-151 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/wrappers/dataclass_wrapper.py:DataclassWrapper.__init__",
"simple_parsing/wrappers/dataclass_wrapper.py:DataclassWrapper.add_arguments",
"simple_parsing/wrappers/dataclass... | lebrice/SimpleParsing | ed8170a32e7765bd98ed42831a428f0cdb645b67 | Allow optional params to be checked with default=None, in addition to using the Optional type hint
**Is your feature request related to a problem? Please describe.**
It's common to have args in a dataclass that are optional but aren't explicitly typed as such via the `Optional` type hint. For example:
```python
... | diff --git a/simple_parsing/wrappers/dataclass_wrapper.py b/simple_parsing/wrappers/dataclass_wrapper.py
index 86866a9..bcb4589 100644
--- a/simple_parsing/wrappers/dataclass_wrapper.py
+++ b/simple_parsing/wrappers/dataclass_wrapper.py
@@ -1,6 +1,6 @@
import argparse
import dataclasses
-from dataclasses import _MISS... |
lebrice__SimpleParsing-164 | [
{
"changes": {
"added_entities": [
"simple_parsing/docstring.py:_get_attribute_docstring",
"simple_parsing/docstring.py:_contains_field_definition",
"simple_parsing/docstring.py:_line_contains_definition_for"
],
"added_modules": [
"simple_parsing/docstring.py:_g... | lebrice/SimpleParsing | 6fca2e9322f73af7fca0e39978619b1286438def | Missing descriptions with multiple inheritance
**Describe the bug**
Some argument descriptions are missing when using multiple inheritance.
**To Reproduce**
```python
from simple_parsing import ArgumentParser
from dataclasses import dataclass
@dataclass
class Foo:
bar: int = 123 #: The bar property
... | diff --git a/simple_parsing/docstring.py b/simple_parsing/docstring.py
index 81fb1c2..81105c1 100644
--- a/simple_parsing/docstring.py
+++ b/simple_parsing/docstring.py
@@ -1,10 +1,11 @@
"""Utility for retrieveing the docstring of a dataclass's attributes
@author: Fabrice Normandin
"""
+from __future__ import annota... |
lebrice__SimpleParsing-172 | [
{
"changes": {
"added_entities": [
"simple_parsing/docstring.py:AttributeDocString.help_string"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"simple_parsing/docstring.py:AttributeDocString"
]
},
"file": "simple_parsing/docstri... | lebrice/SimpleParsing | 545aa469defecba6d30da02199a1ea206740ad23 | Interop with HuggingFace: Use `help` entry from field metadata dict
The dataclasses used by the HfArgumentParser have a `metatada={"help": "help string"}`, for example, here:
https://github.com/huggingface/transformers/blob/main/examples/pytorch/text-classification/run_glue.py#L80-L83
It would be good to support ... | diff --git a/simple_parsing/docstring.py b/simple_parsing/docstring.py
index 1686fdf..fa66351 100644
--- a/simple_parsing/docstring.py
+++ b/simple_parsing/docstring.py
@@ -24,6 +24,16 @@ class AttributeDocString:
desc_from_cls_docstring: str = ""
""" The description of this field from the class docstring. ""... |
lebrice__SimpleParsing-190 | [
{
"changes": {
"added_entities": [
"simple_parsing/wrappers/field_wrapper.py:_BooleanOptionalAction.__init__",
"simple_parsing/wrappers/field_wrapper.py:_BooleanOptionalAction.__call__",
"simple_parsing/wrappers/field_wrapper.py:_BooleanOptionalAction.format_usage"
],
"... | lebrice/SimpleParsing | b8753dc76fae40c75c0503161635218190eb00ac | Confusing command line options for bool's with `default=True`
Having a boolean option with a default value of `True`:
```
from dataclasses import dataclass
from simple_parsing import ArgumentParser
@dataclass
class Args:
enable_water: bool = True # Do you want water?
parser = ArgumentParser()
par... | diff --git a/examples/nesting/README.md b/examples/nesting/README.md
index f1ae397..2150500 100644
--- a/examples/nesting/README.md
+++ b/examples/nesting/README.md
@@ -119,40 +119,40 @@ usage: nesting_example.py [-h] [--batch_size int] [--optimizer str]
[--gender_loss_weight float]
... |
lebrice__SimpleParsing-217 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/helpers/serialization/decoding.py:decode_field",
"simple_parsing/helpers/serialization/decoding.py:get_decoding_fn",
"simple_parsing/helpers/serialization/decoding.py:_reg... | lebrice/SimpleParsing | 404f7f3183308ba180918f42c236de1dd733e964 | The deserialization failed on nested dataclasses.
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
```python
from __future__ import annotations
from simple_parsing import Serializable
from simple_parsing.helpers.serialization import from_dict, to_dict
from dataclasses i... | diff --git a/simple_parsing/helpers/serialization/decoding.py b/simple_parsing/helpers/serialization/decoding.py
index 2526491..f40ee84 100644
--- a/simple_parsing/helpers/serialization/decoding.py
+++ b/simple_parsing/helpers/serialization/decoding.py
@@ -1,5 +1,7 @@
""" Functions for decoding dataclass fields from "... |
lebrice__SimpleParsing-224 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/conflicts.py... | lebrice/SimpleParsing | 165fa9e1f2e6e29c9b163cc12b40e84a90525ed6 | Support frozen dataclass instances as subgroup values
**Is your feature request related to a problem? Please describe.**
I removed support for dataclass instances in subgroups dict. It would be nice to re-add support for them, as long as they are frozen.
| diff --git a/requirements.txt b/requirements.txt
index 758575a..0465575 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,2 +1,2 @@
-typing_extensions
docstring-parser~=0.15
+typing_extensions>=4.3.0
diff --git a/setup.py b/setup.py
index 8752e1a..65ad470 100644
--- a/setup.py
+++ b/setup.py
@@ -16,7 +16,11 @... |
lebrice__SimpleParsing-233 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/helpers/fields.py:subparsers"
],
"edited_modules": [
"simple_parsing/helpers/fields.py:subparsers"
]
},
"file": "simple_parsing/helpers/fields.py"
},
... | lebrice/SimpleParsing | 0059dd7f8a0bd663479e62b58cdd27d8a0331355 | Subgroups choice isn't serialized in yaml file
**Describe the bug**
When there is a subgroup, `parse` API fails.
**To Reproduce**
```python
from dataclasses import dataclass
from tempfile import NamedTemporaryFile
from simple_parsing import ArgumentParser, parse, subgroups, Serializable
@dataclass
class... | diff --git a/simple_parsing/helpers/fields.py b/simple_parsing/helpers/fields.py
index 8129108..1a0ab9e 100644
--- a/simple_parsing/helpers/fields.py
+++ b/simple_parsing/helpers/fields.py
@@ -18,7 +18,7 @@ from simple_parsing.helpers.custom_actions import (
DEFAULT_NEGATIVE_PREFIX,
BooleanOptionalAction,
)
... |
lebrice__SimpleParsing-50 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/wrappers/dataclass_wrapper.py:DataclassWrapper.__init__"
],
"edited_modules": [
"simple_parsing/wrappers/dataclass_wrapper.py:DataclassWrapper"
]
},
"fil... | lebrice/SimpleParsing | 5aa7bb01e12308ddfa68f306c25fb20dfe7ac972 | Nested parameter name with dataclass
Hi, great library, thanks !
I have an issue with nested parser from dataclass.
When trying to create a parser from a dataclass
```
@dataclass
class JBuildRelease:
id: int
url: str
docker_image: str
parser = simple_parsing.ArgumentParser()
p... | diff --git a/simple_parsing/conflicts.py b/simple_parsing/conflicts.py
index 3d7af91..8efd80c 100644
--- a/simple_parsing/conflicts.py
+++ b/simple_parsing/conflicts.py
@@ -119,6 +119,8 @@ class ConflictResolver:
else:
field_wrappers.extend(w.fields)
+ # TODO: #49: Also consider t... |
lebrice__SimpleParsing-51 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/docstring.py:_contains_attribute_definition"
],
"edited_modules": [
"simple_parsing/docstring.py:_contains_attribute_definition"
]
},
"file": "simple_par... | lebrice/SimpleParsing | 5aa7bb01e12308ddfa68f306c25fb20dfe7ac972 | Help does not appear if using metadata in fields
**Describe the bug**
Hi, it seems, that when the dataclass has metadata defined through `field` (from `simple_parsing`, of course), the help in form of comments does not get picked up.
**To Reproduce**
```python
from simple_parsing import ArgumentParser, field
fro... | diff --git a/simple_parsing/conflicts.py b/simple_parsing/conflicts.py
index 3d7af91..8efd80c 100644
--- a/simple_parsing/conflicts.py
+++ b/simple_parsing/conflicts.py
@@ -119,6 +119,8 @@ class ConflictResolver:
else:
field_wrappers.extend(w.fields)
+ # TODO: #49: Also consider t... |
lebrice__SimpleParsing-57 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"examples/dataclasses/dataclass_example.py:Point.distance"
],
"edited_modules": [
"examples/dataclasses/dataclass_example.py:Point"
]
},
"file": "examples/dataclasses/da... | lebrice/SimpleParsing | 599d79715d802e4672dadc68bda233773c4eb56a | SimpleParsing has unlisted numpy dependency since 0.0.14
**Describe the bug**
SimpleParsing 0.0.14 added (among others) the module `simple_parsing.helpers.hdparams.hdparam` which imports `numpy`. Unfortunately, `numpy` is not listed as a dependency in `setup.py`, which causes all code that uses SimpleParsing to fail w... | diff --git a/.travis.yml b/.travis.yml
index a703838..c9810f1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,7 +4,7 @@ python:
- '3.7'
- '3.8'
install:
-- pip install --no-cache --ignore-installed -e .[test]
+- pip install --no-cache --ignore-installed -e .
- pip install pyyaml
script:
- pytest
diff --git a/exa... |
lebrice__SimpleParsing-70 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "examples/simple/basic.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_mo... | lebrice/SimpleParsing | f5356c7af368d5481f8093cc415c8796ca34b16c | Default not displayed in the help text when no description comment exists
This example:
```
from dataclasses import dataclass
from simple_parsing import ArgumentParser
parser = ArgumentParser()
@dataclass
class Options:
"""These are the options"""
foo: str = "aaa" # Description
bar: str ... | diff --git a/examples/simple/basic.py b/examples/simple/basic.py
index 401c415..c2c06e4 100644
--- a/examples/simple/basic.py
+++ b/examples/simple/basic.py
@@ -34,22 +34,23 @@ optional arguments:
HParams ['hparams']:
Set of options for the training of a Model.
- --num_layers int
- --num_units int
- --optimiz... |
lebrice__SimpleParsing-99 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"simple_parsing/utils.py:get_argparse_type_for_container"
],
"edited_modules": [
"simple_parsing/utils.py:get_argparse_type_for_container"
]
},
"file": "simple_parsing/u... | lebrice/SimpleParsing | 9d4e4c89991a0dc3220723a203a8a8ae3ede9cca | Lists of enums are parsed by value on the command line
**Describe the bug**
While enums seem to be parsed by member name, a list of them seems to be parsed by member value, but only if the value is a string, not an integer
**To Reproduce**
```python
import enum
from typing import *
from dataclasses import dat... | diff --git a/simple_parsing/utils.py b/simple_parsing/utils.py
index 56f41da..88b14ff 100644
--- a/simple_parsing/utils.py
+++ b/simple_parsing/utils.py
@@ -187,8 +187,8 @@ def get_item_type(container_type: Type[Container[T]]) -> T:
def get_argparse_type_for_container(
- container_type: Type,
-) -> Union[Type, ... |
lektor__lektor-1048 | [
{
"changes": {
"added_entities": [
"lektor/admin/modules/serve.py:HiddenRecordException.__init__"
],
"added_modules": [
"lektor/admin/modules/serve.py:HiddenRecordException"
],
"edited_entities": [
"lektor/admin/modules/serve.py:ArtifactServer.resolve_url_pa... | lektor/lektor | 7eff923133ced682a5658d18ef579564589b8bfe | overriding parent _hidden field in content does not have desired effect
Per docs [here](https://www.getlektor.com/docs/api/db/system-fields/hidden/) on the `_hidden` system field:
> This also automatically applies to all children of a page unless they forcefully override this setting.
I'm trying to use this in a webs... | diff --git a/frontend/js/widgets/BooleanInputWidget.tsx b/frontend/js/widgets/BooleanInputWidget.tsx
index be38b38..e27c388 100644
--- a/frontend/js/widgets/BooleanInputWidget.tsx
+++ b/frontend/js/widgets/BooleanInputWidget.tsx
@@ -1,38 +1,53 @@
-import React from "react";
+import React, { KeyboardEvent } from "react"... |
lektor__lektor-1086 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"lektor/pluginsystem.py:PluginController.emit"
],
"edited_modules": [
"lektor/pluginsystem.py:PluginController"
]
},
"file": "lektor/pluginsystem.py"
}
] | lektor/lektor | 259f0265055142451648c28741d7cb307196b2de | TypeErrors raised by plugin hooks are sometimes silently ignored
Hi, it took a while to identify the culprit of this bug. And I honestly cannot imagine what might cause it.
But this simple plugin example shows what is going wrong:
```py
from lektor.pluginsystem import Plugin
class TrashPlugin(Plugin):
def ... | diff --git a/lektor/pluginsystem.py b/lektor/pluginsystem.py
index 4258870..22058ca 100644
--- a/lektor/pluginsystem.py
+++ b/lektor/pluginsystem.py
@@ -1,5 +1,6 @@
from __future__ import annotations
+import inspect
import os
import sys
import warnings
@@ -188,24 +189,31 @@ class PluginController:
return... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.