text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -83,6 +131,100 @@ internal sealed class TextFormatterImpl : TextFormatter } } + /// <summary> + /// Formats a line from cached shaped runs, skipping shaping and bidi processing. + /// </summary> + private static TextLine FormatLineFromCache(CachedShapingResult cach...
bad
review
csharp
AvaloniaUI/Avalonia
a077fec6f30d9811f77feed2414768a9f006d460
diff --git a/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs b/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs index fb6777c659a..8af3470dd19 100644 --- a/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs +++ b/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs @@ -17,9 +17,18...
good
review_fixed
csharp
AvaloniaUI/Avalonia
a077fec6f30d9811f77feed2414768a9f006d460
@@ -62,7 +62,7 @@ public abstract class Page : TemplatedControl, IHeadered public static readonly RoutedEvent<RoutedEventArgs> PageNavigationSystemBackButtonPressedEvent = RoutedEvent.Register<Page, RoutedEventArgs>( nameof(PageNavigationSystemBackButtonPressed), - ...
bad
review
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
diff --git a/src/Avalonia.Controls/Page/Page.cs b/src/Avalonia.Controls/Page/Page.cs index 4dcb84312d5..f40840caed8 100644 --- a/src/Avalonia.Controls/Page/Page.cs +++ b/src/Avalonia.Controls/Page/Page.cs @@ -62,7 +62,7 @@ public abstract class Page : TemplatedControl, IHeadered public static readonly RoutedEv...
good
review_fixed
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
@@ -295,13 +295,31 @@ static DrawerPage() { PageNavigationSystemBackButtonPressedEvent.AddClassHandler<DrawerPage>((sender, eventArgs) => { + if (eventArgs.Handled) + return; + if (sender.IsOpen && sender.DrawerBe...
bad
review
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
diff --git a/src/Avalonia.Controls/Page/DrawerPage.cs b/src/Avalonia.Controls/Page/DrawerPage.cs index 3494e3a069c..065a5df410b 100644 --- a/src/Avalonia.Controls/Page/DrawerPage.cs +++ b/src/Avalonia.Controls/Page/DrawerPage.cs @@ -295,6 +295,9 @@ static DrawerPage() { PageNavigationSystemBackBut...
good
review_fixed
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
@@ -87,6 +88,26 @@ public static void SetIsTabEnabled(Page page, bool value) => static TabbedPage() { FocusableProperty.OverrideDefaultValue<TabbedPage>(true); + PageNavigationSystemBackButtonPressedEvent.AddClassHandler<TabbedPage>((sender, eventArgs) => + { + ...
bad
review
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
diff --git a/src/Avalonia.Controls/Page/TabbedPage.cs b/src/Avalonia.Controls/Page/TabbedPage.cs index 89e926dc3ce..81e30819b73 100644 --- a/src/Avalonia.Controls/Page/TabbedPage.cs +++ b/src/Avalonia.Controls/Page/TabbedPage.cs @@ -9,6 +9,7 @@ using Avalonia.Controls.Templates; using Avalonia.Input; using Avalonia....
good
review_fixed
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
@@ -55,6 +55,26 @@ static CarouselPage() { ItemsPanelProperty.OverrideDefaultValue<CarouselPage>(DefaultPanel); FocusableProperty.OverrideDefaultValue<CarouselPage>(true); + PageNavigationSystemBackButtonPressedEvent.AddClassHandler<CarouselPage>((sender, eventArgs) => + ...
bad
review
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
diff --git a/src/Avalonia.Controls/Page/CarouselPage.cs b/src/Avalonia.Controls/Page/CarouselPage.cs index 22bee65871c..1cf67c603f8 100644 --- a/src/Avalonia.Controls/Page/CarouselPage.cs +++ b/src/Avalonia.Controls/Page/CarouselPage.cs @@ -55,6 +55,19 @@ static CarouselPage() { ItemsPanelProperty...
good
review_fixed
csharp
AvaloniaUI/Avalonia
e07ec52a9b555c8117a242a9b72e1680f050200b
@@ -129,7 +130,20 @@ public void Dispose() return; _disposed = true; // Fire and forget - _ = _registrar?.UnregisterWindowAsync(_xid); + _ = _registrar?.UnregisterWindowAsync(_xid)?.ContinueWith(t => + { + ...
bad
review
csharp
AvaloniaUI/Avalonia
764e8148747a863f679195c78bb427bae5ea091c
diff --git a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs index 586f566e1c4..74e5157bc1d 100644 --- a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs +++ b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs @@ -10,6 +10,7 @@ using Avalonia.Input; using Avalonia.Platform; using A...
good
review_fixed
csharp
AvaloniaUI/Avalonia
764e8148747a863f679195c78bb427bae5ea091c
@@ -129,7 +130,20 @@ public void Dispose() return; _disposed = true; // Fire and forget - _ = _registrar?.UnregisterWindowAsync(_xid); + _ = _registrar?.UnregisterWindowAsync(_xid)?.ContinueWith(t => + { + ...
bad
review
csharp
AvaloniaUI/Avalonia
764e8148747a863f679195c78bb427bae5ea091c
diff --git a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs index 586f566e1c4..74e5157bc1d 100644 --- a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs +++ b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs @@ -10,6 +10,7 @@ using Avalonia.Input; using Avalonia.Platform; using A...
good
review_fixed
csharp
AvaloniaUI/Avalonia
764e8148747a863f679195c78bb427bae5ea091c
@@ -66,7 +66,7 @@ public Task<TResult> Dispatch<TResult>(Func<TResult> action, CancellationToken c /// <inheritdoc cref="DispatchCore{TResult}"/> public Task<TResult> Dispatch<TResult>(Func<Task<TResult>> action, CancellationToken cancellationToken) { - return DispatchCore(action, false, cancellat...
bad
review
csharp
AvaloniaUI/Avalonia
48092708cafe55d16cde694c86d6f4972888fd1e
diff --git a/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs b/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs index 0d48dd6919b..645812cefbb 100644 --- a/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs +++ b/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs @@ -54,19 +54,19 @@ pub...
good
review_fixed
csharp
AvaloniaUI/Avalonia
48092708cafe55d16cde694c86d6f4972888fd1e
@@ -360,25 +360,20 @@ private bool TryGetFontCollection(Uri source, [NotNullWhen(true)] out IFontColle source = SystemFontsKey; } - if (!_fontCollections.TryGetValue(source, out fontCollection)) + fontCollection = _fontCollections.GetOrAdd(source, static (key, platf...
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/src/Avalonia.Base/Media/FontManager.cs b/src/Avalonia.Base/Media/FontManager.cs index 1f15820b9a6..60200dea851 100644 --- a/src/Avalonia.Base/Media/FontManager.cs +++ b/src/Avalonia.Base/Media/FontManager.cs @@ -351,36 +351,58 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily) ...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -86,5 +91,59 @@ public void Should_Return_First_Installed_Font_Family_Name_When_Default_Family_N Assert.Equal("DejaVu", FontManager.Current.DefaultFontFamily.Name); } } + + [Fact] + public async Task TryGetGlyphTypeface_Should_Be_Thread_Safe_For_Embedded_Fonts() +...
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs index ed95773630f..d63f238dc16 100644 --- a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs +++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs @@ -1,4 +1,6 @@ using System;...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -86,5 +91,59 @@ public void Should_Return_First_Installed_Font_Family_Name_When_Default_Family_N Assert.Equal("DejaVu", FontManager.Current.DefaultFontFamily.Name); } } + + [Fact] + public async Task TryGetGlyphTypeface_Should_Be_Thread_Safe_For_Embedded_Fonts() +...
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs index ed95773630f..d63f238dc16 100644 --- a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs +++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs @@ -1,4 +1,6 @@ using System;...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -351,36 +351,34 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily) return []; } - private bool TryGetFontCollection(Uri source, [NotNullWhen(true)] out IFontCollection? fontCollection) + internal bool TryGetFontCollection(Uri source, [NotNullWhen(true)...
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/src/Avalonia.Base/Media/FontManager.cs b/src/Avalonia.Base/Media/FontManager.cs index 1f15820b9a6..60200dea851 100644 --- a/src/Avalonia.Base/Media/FontManager.cs +++ b/src/Avalonia.Base/Media/FontManager.cs @@ -351,36 +351,58 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily) ...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -351,36 +351,34 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily) return []; } - private bool TryGetFontCollection(Uri source, [NotNullWhen(true)] out IFontCollection? fontCollection) + internal bool TryGetFontCollection(Uri source, [NotNullWhen(true)...
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/src/Avalonia.Base/Media/FontManager.cs b/src/Avalonia.Base/Media/FontManager.cs index 1f15820b9a6..60200dea851 100644 --- a/src/Avalonia.Base/Media/FontManager.cs +++ b/src/Avalonia.Base/Media/FontManager.cs @@ -351,36 +351,58 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily) ...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -1,4 +1,8 @@ using System; +using System.Collections.Concurrent; +using System.Reflection;
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs index ed95773630f..d63f238dc16 100644 --- a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs +++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs @@ -1,4 +1,6 @@ using System;...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -0,0 +1,263 @@ +using System; +using Avalonia.Media; +using Avalonia.Media.Fonts; +using Avalonia.UnitTests; +using Xunit; + +namespace Avalonia.Base.UnitTests.Media +{ + public class FontManagerTryGetFontCollectionTests + { + [Fact] + public void TryGetFontCollection_SystemFontScheme_ReturnsTru...
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs new file mode 100644 index 00000000000..2f85f0b63fc --- /dev/null +++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs @@ -0...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -0,0 +1,263 @@ +using System; +using Avalonia.Media; +using Avalonia.Media.Fonts; +using Avalonia.UnitTests; +using Xunit; + +namespace Avalonia.Base.UnitTests.Media +{ + public class FontManagerTryGetFontCollectionTests + { + [Fact] + public void TryGetFontCollection_SystemFontScheme_ReturnsTru...
bad
review
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs new file mode 100644 index 00000000000..2f85f0b63fc --- /dev/null +++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs @@ -0...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3652f1f1e0d9256469bebbb43e7838191ad85777
@@ -555,4 +604,135 @@ public IEnumerable<MyType> MyProp } } + + public class XamlIlCompiledBindingRootControl : UserControl
bad
review
csharp
AvaloniaUI/Avalonia
30c64b920f32284a26e9bb6f521487c159f1e788
diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs index 9118378dbd1..e921ad54617 100644 --- a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs +++ b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs @@ -4,6 +4,7 @@ using Syst...
good
review_fixed
csharp
AvaloniaUI/Avalonia
30c64b920f32284a26e9bb6f521487c159f1e788
@@ -14,7 +14,7 @@ const GlobalStyle = createGlobalStyle` font-weight: 400; font-size: 16px; font-family: ${monaSans.style.fontFamily}; - background: #141517; + background: #F1F1F1 !important;
bad
review
typescript
AykutSarac/jsoncrack.com
7a60d0018117c6e93ca1694b04b797ecb8553c1c
diff --git a/src/constants/globalStyle.ts b/src/constants/globalStyle.ts index 833029a9788..cd26f943b78 100644 --- a/src/constants/globalStyle.ts +++ b/src/constants/globalStyle.ts @@ -14,7 +14,7 @@ const GlobalStyle = createGlobalStyle` font-weight: 400; font-size: 16px; font-family: ${monaSans.style.fo...
good
review_fixed
typescript
AykutSarac/jsoncrack.com
7a60d0018117c6e93ca1694b04b797ecb8553c1c
@@ -74,6 +74,7 @@ export function parser(jsonStr: string): Graph { path: getNodePath(states.graph.nodes, states.graph.edges, node.id), })); + console.log(states.graph);
bad
review
typescript
AykutSarac/jsoncrack.com
7a60d0018117c6e93ca1694b04b797ecb8553c1c
diff --git a/src/utils/json/jsonParser.ts b/src/utils/json/jsonParser.ts index d526eb01024..906ddc9e9d9 100644 --- a/src/utils/json/jsonParser.ts +++ b/src/utils/json/jsonParser.ts @@ -74,6 +74,7 @@ export function parser(jsonStr: string): Graph { path: getNodePath(states.graph.nodes, states.graph.edges, node.id...
good
review_fixed
typescript
AykutSarac/jsoncrack.com
7a60d0018117c6e93ca1694b04b797ecb8553c1c
@@ -10,7 +10,7 @@ "rollForward": false }, "b2r2.fslint": { - "version": "1.1.0", + "version": "1.1.1",
bad
review
B2R2-org/B2R2
64991d86c860ebefc18850948d3a37e1589a79fb
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 4f9931194..1356cc4a6 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -10,7 +10,7 @@ "rollForward": false }, "b2r2.fslint": { - "version": "1.1.0", + "version": "1.1.1", "commands": [ ...
good
review_fixed
B2R2-org/B2R2
64991d86c860ebefc18850948d3a37e1589a79fb
@@ -36,2851 +35,5105 @@ type Opcode = | AAM = 2 /// ASCII Adjust AL After Subtraction. | AAS = 3 - /// Add with Carry. + /// Add With Carry. | ADC = 4 - /// Unsigned integer add with carry. + /// Unsigned Integer Addition of Two Operands With Carry Flag. | ADCX = 5 /// Add. | ADD = 6 - /// Add...
bad
review
fsharp
B2R2-org/B2R2
a85183e629350096feab440a111179e092391914
diff --git a/src/FrontEnd/Intel/Opcode.fs b/src/FrontEnd/Intel/Opcode.fs index 9a5270ebf..4e678d12d 100644 --- a/src/FrontEnd/Intel/Opcode.fs +++ b/src/FrontEnd/Intel/Opcode.fs @@ -24,8 +24,7 @@ namespace B2R2.FrontEnd.Intel /// <summary> -/// Represents an Intel opcode. This type should be generated using -/// <c>...
good
review_fixed
fsharp
B2R2-org/B2R2
a85183e629350096feab440a111179e092391914
@@ -48,7 +48,11 @@ type Assembler(isa: ISA, baseAddr: Addr) = let addLabeldef lbl = updateUserState (fun us -> - { us with LabelMap = Map.add lbl us.CurIndex us.LabelMap }) + if Map.containsKey lbl us.LabelMap then + let eMsg = sprintf "Label '%s' already defined" lbl
bad
review
fsharp
B2R2-org/B2R2
65c693aad708a5d1e4dad1f63b2e6ad2e387d06c
diff --git a/src/Assembly/Intel/Assembler.fs b/src/Assembly/Intel/Assembler.fs index ee0171aa0..680af3e43 100644 --- a/src/Assembly/Intel/Assembler.fs +++ b/src/Assembly/Intel/Assembler.fs @@ -48,7 +48,10 @@ type Assembler(isa: ISA, baseAddr: Addr) = let addLabeldef lbl = updateUserState (fun us -> - { u...
good
review_fixed
fsharp
B2R2-org/B2R2
65c693aad708a5d1e4dad1f63b2e6ad2e387d06c
@@ -89,192 +90,584 @@ Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "B2R2.RearEnd.Utils", "Utils EndProject Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "B2R2.RearEnd.Visualization", "Visualization\B2R2.RearEnd.Visualization.fsproj", "{E03A7D88-EE4D-436A-A5C8-51B57FB71883}" EndProject +Project("{F2A71F9...
bad
review
B2R2-org/B2R2
1a20a2c801115d85b785250222e0f4831edd54e5
diff --git a/src/RearEnd/RearEnd.sln b/src/RearEnd/RearEnd.sln index 2d744a328..a9a562baa 100644 --- a/src/RearEnd/RearEnd.sln +++ b/src/RearEnd/RearEnd.sln @@ -1,3 +1,4 @@ + Microsoft Visual Studio Solution File, Format Version 12.00 Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "B2R2.RearEnd.Assembler", "Asse...
good
review_fixed
B2R2-org/B2R2
1a20a2c801115d85b785250222e0f4831edd54e5
@@ -22,10 +22,31 @@ SOFTWARE. *) -module B2R2.RearEnd.BinExplorer.CmdUtils +namespace B2R2.RearEnd.BinExplorer.Commands -open System +open B2R2.RearEnd.Utils +open B2R2.RearEnd.BinExplorer -let convHexString (str: string) = - try Convert.ToUInt64(str, 16) |> Some - with _ -> None +type Show() = + interface...
bad
review
fsharp
B2R2-org/B2R2
1a20a2c801115d85b785250222e0f4831edd54e5
diff --git a/src/RearEnd/BinExplorer/CmdUtils.fs b/src/RearEnd/BinExplorer/Commands/Show.fs similarity index 60% rename from src/RearEnd/BinExplorer/CmdUtils.fs rename to src/RearEnd/BinExplorer/Commands/Show.fs index 4e154982f..c88acf5c0 100644 --- a/src/RearEnd/BinExplorer/CmdUtils.fs +++ b/src/RearEnd/BinExplorer/Co...
good
review_fixed
fsharp
B2R2-org/B2R2
1a20a2c801115d85b785250222e0f4831edd54e5
@@ -0,0 +1,174 @@ +(* + B2R2 - the Next-Generation Reversing Platform + + Copyright (c) SoftSec Lab. @ KAIST, since 2016 + + Permission is hereby granted, free of charge, to any person obtaining a copy + of this software and associated documentation files (the "Software"), to deal + in the Software without restric...
bad
review
fsharp
B2R2-org/B2R2
1a20a2c801115d85b785250222e0f4831edd54e5
diff --git a/src/RearEnd/BiHexLang/Parser.fs b/src/RearEnd/BiHexLang/Parser.fs new file mode 100644 index 000000000..9eb916202 --- /dev/null +++ b/src/RearEnd/BiHexLang/Parser.fs @@ -0,0 +1,170 @@ +(* + B2R2 - the Next-Generation Reversing Platform + + Copyright (c) SoftSec Lab. @ KAIST, since 2016 + + Permission is...
good
review_fixed
fsharp
B2R2-org/B2R2
1a20a2c801115d85b785250222e0f4831edd54e5
@@ -38,17 +52,24 @@ rem --- AnyCPU -------------------------------------------------- set target=%CD%\bin\publish-AnyCPU-%netVer% -rmdir /q /s "%target%" -if errorlevel 1 (pause) +if exist "%target%" ( + rmdir /q /s "%target%" + if errorlevel 1 (pause & exit /b 1) +) + +set platform=Any CPU +set selfContained=Fals...
bad
review
BCUninstaller/Bulk-Crap-Uninstaller
7a9e79bbe38c9987f468b0b2897a91f49a1e5b4e
diff --git a/publish.bat b/publish.bat index 2a336922..3119dc60 100644 --- a/publish.bat +++ b/publish.bat @@ -5,31 +5,45 @@ rem Release Debug set config=Release set msbuild="D:\Applications\VS2022\MSBuild\Current\Bin\amd64\MSBuild.exe" +if not exist %msbuild% call :findMsbuild +if not exist %msbuild% ( + echo Fail...
good
review_fixed
BCUninstaller/Bulk-Crap-Uninstaller
7a9e79bbe38c9987f468b0b2897a91f49a1e5b4e
@@ -29,7 +29,8 @@ public static IEnumerable<RegistryKey> GetSubKeys(this RegistryKey obj, bool wri if (obj == null) throw new NullReferenceException(); - return obj.GetValueNames().Select(x => obj.OpenSubKey(x, writable)); + // Enumerate subkey names here; using val...
bad
review
csharp
BCUninstaller/Bulk-Crap-Uninstaller
45f5a83869ccd9655315de5eefbc92b2c698c661
diff --git a/source/KlocTools/Extensions/RegistryKeyExtensions.cs b/source/KlocTools/Extensions/RegistryKeyExtensions.cs index 54c23b177..b6ce51f0c 100644 --- a/source/KlocTools/Extensions/RegistryKeyExtensions.cs +++ b/source/KlocTools/Extensions/RegistryKeyExtensions.cs @@ -29,7 +29,7 @@ public static IEnumerable<Reg...
good
review_fixed
csharp
BCUninstaller/Bulk-Crap-Uninstaller
45f5a83869ccd9655315de5eefbc92b2c698c661
@@ -40,7 +40,8 @@ public static DirectoryInfo AssemblyLocation { var location = Assembly.GetAssembly(typeof(Program))?.Location; if (location == null) throw new InvalidOperationException("Failed to get entry assembly location"); - if (loca...
bad
review
csharp
BCUninstaller/Bulk-Crap-Uninstaller
baf9eced5933467dd7507caa3ef323fe39d2540f
diff --git a/source/BulkCrapUninstaller/Program.cs b/source/BulkCrapUninstaller/Program.cs index a489d269..76eb98c9 100644 --- a/source/BulkCrapUninstaller/Program.cs +++ b/source/BulkCrapUninstaller/Program.cs @@ -40,7 +40,7 @@ public static DirectoryInfo AssemblyLocation { var l...
good
review_fixed
csharp
BCUninstaller/Bulk-Crap-Uninstaller
baf9eced5933467dd7507caa3ef323fe39d2540f
@@ -63,7 +63,8 @@ public bool StillExists(StartupEntry startupEntry) if (startupEntry.IsRegKey) { using (var key = RegistryTools.OpenRegistryKey(startupEntry.ParentLongName)) - return !string.IsNullOrEmpty(key.GetStringSafe(startupEntry.EntryLongName)); ...
bad
review
csharp
BCUninstaller/Bulk-Crap-Uninstaller
d9c75d87cb2a4995c317d977db314f8a075925b7
diff --git a/source/UninstallTools/Startup/Normal/NewStartupDisable.cs b/source/UninstallTools/Startup/Normal/NewStartupDisable.cs index b171391be..abc1d70f1 100644 --- a/source/UninstallTools/Startup/Normal/NewStartupDisable.cs +++ b/source/UninstallTools/Startup/Normal/NewStartupDisable.cs @@ -63,7 +63,7 @@ public bo...
good
review_fixed
csharp
BCUninstaller/Bulk-Crap-Uninstaller
d9c75d87cb2a4995c317d977db314f8a075925b7
@@ -131,7 +131,8 @@ public override bool StillExists() if (!IsRegKey) return File.Exists(FullLongName); using (var key = RegistryTools.OpenRegistryKey(ParentLongName)) - return !string.IsNullOrEmpty(key.GetStringSafe(EntryLongName)); + // Ope...
bad
review
csharp
BCUninstaller/Bulk-Crap-Uninstaller
d9c75d87cb2a4995c317d977db314f8a075925b7
diff --git a/source/UninstallTools/Startup/Normal/StartupEntry.cs b/source/UninstallTools/Startup/Normal/StartupEntry.cs index 20c740365..8aec3f2fa 100644 --- a/source/UninstallTools/Startup/Normal/StartupEntry.cs +++ b/source/UninstallTools/Startup/Normal/StartupEntry.cs @@ -131,7 +131,7 @@ public override bool StillE...
good
review_fixed
csharp
BCUninstaller/Bulk-Crap-Uninstaller
d9c75d87cb2a4995c317d977db314f8a075925b7
@@ -166,7 +166,8 @@ private static object CleanupUninstallString(string uninstallString) { var trimmed = uninstallString.Substring(UninstallStringTrimString.Length); var closingQuote = trimmed.IndexOf('"'); - if (closingQuote > 0) + // Han...
bad
review
csharp
BCUninstaller/Bulk-Crap-Uninstaller
939b4eee0161954dc0ba73fdf70424d13090a225
diff --git a/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs b/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs index ba24d276..74d57547 100644 --- a/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs +++ b/source/BulkCrapUninstaller/Functions/Ap...
good
review_fixed
csharp
BCUninstaller/Bulk-Crap-Uninstaller
939b4eee0161954dc0ba73fdf70424d13090a225
@@ -37,6 +37,44 @@ module BetterErrors expect(response).to have_tag('.exception h2', /ZeroDivisionError/) end + context 'when ActiveSupport::ActionableError is available' do + before do + skip "ActiveSupport missing on this platform" unless Object.constants.include?(:ActiveSupport) + ...
bad
review
ruby
BetterErrors/better_errors
87cc62d7dfeef345a28cee3e68a867fffe41af1f
diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb index ef13e6a5..0e75af51 100644 --- a/spec/better_errors/error_page_spec.rb +++ b/spec/better_errors/error_page_spec.rb @@ -37,6 +37,44 @@ module BetterErrors expect(response).to have_tag('.exception h2', /ZeroDivisionErro...
good
review_fixed
ruby
BetterErrors/better_errors
87cc62d7dfeef345a28cee3e68a867fffe41af1f
@@ -33,4 +33,10 @@ Gem::Specification.new do |s| # optional dependencies: # s.add_dependency "binding_of_caller" # s.add_dependency "pry" + + if s.respond_to?(:metadata)
bad
review
BetterErrors/better_errors
51bd42a9df48e073d3cf9932969627ad4bc6898b
diff --git a/better_errors.gemspec b/better_errors.gemspec index 74093c25..2863b787 100644 --- a/better_errors.gemspec +++ b/better_errors.gemspec @@ -33,4 +33,12 @@ Gem::Specification.new do |s| # optional dependencies: # s.add_dependency "binding_of_caller" # s.add_dependency "pry" + + if s.respond_to?(:m...
good
review_fixed
BetterErrors/better_errors
51bd42a9df48e073d3cf9932969627ad4bc6898b
@@ -505,9 +527,11 @@ impl LocalContainerService { // Some coding agent processes do not automatically exit after processing the user request; instead the executor // signals when processing has finished to gracefully kill the process. exit_result = &mut exit_signal_fut...
bad
review
rust
BloopAI/vibe-kanban
4f63f215f7e1cd74ea461fac52d23b06353f1914
diff --git a/crates/local-deployment/src/container.rs b/crates/local-deployment/src/container.rs index 05af5ef575b..d3fe28c7234 100644 --- a/crates/local-deployment/src/container.rs +++ b/crates/local-deployment/src/container.rs @@ -801,7 +801,13 @@ impl LocalContainerService { let _ = tokio::time::tim...
good
review_fixed
rust
BloopAI/vibe-kanban
4f63f215f7e1cd74ea461fac52d23b06353f1914
@@ -1,37 +1,24 @@ use command_group::AsyncGroupChild; #[cfg(unix)] -use nix::{ - sys::signal::{Signal, killpg}, - unistd::{Pid, getpgid}, -}; -#[cfg(unix)] use tokio::time::Duration; pub async fn kill_process_group(child: &mut AsyncGroupChild) -> std::io::Result<()> { - // hit the whole process group, no...
bad
review
rust
BloopAI/vibe-kanban
4f63f215f7e1cd74ea461fac52d23b06353f1914
diff --git a/crates/utils/src/process.rs b/crates/utils/src/process.rs index 2f43acb5516..32cb82418b0 100644 --- a/crates/utils/src/process.rs +++ b/crates/utils/src/process.rs @@ -1,36 +1,26 @@ use command_group::AsyncGroupChild; #[cfg(unix)] -use nix::{ - sys::signal::{Signal, killpg}, - unistd::{Pid, getpgid...
good
review_fixed
rust
BloopAI/vibe-kanban
4f63f215f7e1cd74ea461fac52d23b06353f1914
@@ -1,36 +1,25 @@ use command_group::AsyncGroupChild; #[cfg(unix)] -use nix::{ - sys::signal::{Signal, killpg}, - unistd::{Pid, getpgid}, -}; -#[cfg(unix)] use tokio::time::Duration; pub async fn kill_process_group(child: &mut AsyncGroupChild) -> std::io::Result<()> { - // hit the whole process group, no...
bad
review
rust
BloopAI/vibe-kanban
4f63f215f7e1cd74ea461fac52d23b06353f1914
diff --git a/crates/utils/src/process.rs b/crates/utils/src/process.rs index 2f43acb5516..32cb82418b0 100644 --- a/crates/utils/src/process.rs +++ b/crates/utils/src/process.rs @@ -1,36 +1,26 @@ use command_group::AsyncGroupChild; #[cfg(unix)] -use nix::{ - sys::signal::{Signal, killpg}, - unistd::{Pid, getpgid...
good
review_fixed
rust
BloopAI/vibe-kanban
4f63f215f7e1cd74ea461fac52d23b06353f1914
@@ -0,0 +1,231 @@ +//! macOS-native notification system using `UNUserNotificationCenter`. +//! +//! Bypasses `tauri-plugin-notification` (which has no desktop click handling) +//! and uses the native UserNotifications framework directly. A +//! `UNUserNotificationCenterDelegate` receives click callbacks with the +//! `...
bad
review
rust
BloopAI/vibe-kanban
07b42a2300b3491ff6c20c706fea5b3ba84a0a5c
diff --git a/crates/tauri-app/src/macos_notifications.rs b/crates/tauri-app/src/macos_notifications.rs new file mode 100644 index 00000000000..b439c7de225 --- /dev/null +++ b/crates/tauri-app/src/macos_notifications.rs @@ -0,0 +1,232 @@ +//! macOS-native notification system using `UNUserNotificationCenter`. +//! +//! B...
good
review_fixed
rust
BloopAI/vibe-kanban
07b42a2300b3491ff6c20c706fea5b3ba84a0a5c
@@ -735,14 +745,34 @@ export function PreviewBrowserContainer({ // The proxy extracts the target port from the subdomain and forwards to the dev server. // _refresh query param forces iframe reload on refresh button click. // Construct proxy URL for iframe to enable security isolation via separate origin -...
bad
review
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
good
review_fixed
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
@@ -696,18 +722,26 @@ export function PreviewBrowserContainer({ resetNavigation(); - if (showIframe && iframeRef.current?.contentWindow && previewProxyPort) { + if (showIframe && iframeRef.current?.contentWindow) { if (devServerPort != null && normalizedInputDevPort === devServerPort) { - c...
bad
review
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
good
review_fixed
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
@@ -696,17 +722,31 @@ export function PreviewBrowserContainer({ resetNavigation(); - if (showIframe && iframeRef.current?.contentWindow && previewProxyPort) { - if (devServerPort != null && normalizedInputDevPort === devServerPort) { - const proxyPath = - normalizedInputDevParsed.pathna...
bad
review
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
good
review_fixed
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
@@ -241,15 +241,35 @@ export function PreviewBrowserContainer({ ); }, [hasOverride, urlInfo?.port, effectiveParsedUrl]); - // Builds the subdomain-based proxy URL loaded by the iframe. - // Dev server at localhost:4000 → iframe loads http://4000.localhost:{proxyPort}/path - // The proxy extracts the ta...
bad
review
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
good
review_fixed
typescript
BloopAI/vibe-kanban
b83039993d8c0185ac67b30b6363ce3c2f96b204
@@ -484,6 +482,12 @@ impl IntoResponse for ApiError { "ContainerError", format!("Executor error: {e}"), ), + ContainerError::Worktree(WorktreeError::GitService(err)) => git_service_error(err), + ContainerError::Worktree(err) => Err...
bad
review
rust
BloopAI/vibe-kanban
89658cd3818a301d6cb2a0edbd9e1e9f31b3e985
diff --git a/crates/server/src/error.rs b/crates/server/src/error.rs index e734190f449..b026d074f21 100644 --- a/crates/server/src/error.rs +++ b/crates/server/src/error.rs @@ -51,13 +51,13 @@ pub enum ApiError { #[error(transparent)] Deployment(#[from] DeploymentError), #[error(transparent)] - Contai...
good
review_fixed
rust
BloopAI/vibe-kanban
89658cd3818a301d6cb2a0edbd9e1e9f31b3e985
@@ -356,51 +398,55 @@ impl DiffStreamManager { let worktree = self.args.worktree_path.clone(); let base = self.current_base_commit.clone(); let cumulative = self.cumulative.clone(); - let full_sent = self.full_sent.clone(); let known_paths = self.known_paths.clone(); + ...
bad
review
rust
BloopAI/vibe-kanban
ece9c26abd00a9282f00f95e8d66b71f601b9c88
diff --git a/crates/services/src/services/diff_stream.rs b/crates/services/src/services/diff_stream.rs index 121a341d8db..9d9527cf510 100644 --- a/crates/services/src/services/diff_stream.rs +++ b/crates/services/src/services/diff_stream.rs @@ -1,21 +1,22 @@ use std::{ - collections::HashSet, + collections::{Has...
good
review_fixed
rust
BloopAI/vibe-kanban
ece9c26abd00a9282f00f95e8d66b71f601b9c88
@@ -102,6 +94,75 @@ export function WorkspaceProvider({ children }: WorkspaceProviderProps) { [diffs] ); + const rafRef = useRef<number | null>(null); + const batchCountRef = useRef(0); + const flushCountRef = useRef(0); + + const latestDiffDataRef = useRef({ + diffs, + diffPaths, + diffStats, + ...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -102,6 +94,75 @@ export function WorkspaceProvider({ children }: WorkspaceProviderProps) { [diffs] ); + const rafRef = useRef<number | null>(null); + const batchCountRef = useRef(0); + const flushCountRef = useRef(0); + + const latestDiffDataRef = useRef({ + diffs, + diffPaths, + diffStats, + ...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -3,29 +3,33 @@ import { useUiPreferencesStore, RIGHT_MAIN_PANEL_MODES, } from '@/shared/stores/useUiPreferencesStore'; -import { useWorkspaceDiffContext } from '@/shared/hooks/useWorkspaceContext'; +import { useDiffPaths } from '@/shared/stores/useWorkspaceDiffStore'; import { ChangesViewContext, Chang...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx index 1cc645209d0..8a4b2e6f728 100644 --- a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx +++ b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx @@ -3,25 +3,27 @@ i...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -223,61 +206,147 @@ export function ChangesPanelContainer({ [onRangeChanged] ); + const shouldSuppressSizeAdjustment = useCallback(() => { + return ( + revealRequestIdRef.current > 0 && + performance.now() - (revealStartTimeRef.current ?? 0) < + MAX_REVEAL_DURATION_MS + ); + }, [])...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -1,106 +1,608 @@ -import { memo, useRef, useEffect, useCallback, useState, useMemo } from 'react'; +import { memo, useEffect, useCallback, useRef, useState, useMemo } from 'react'; +import { useTranslation } from 'react-i18next'; import { - ChangesPanel, - type ChangesPanelHandle, - type RenderDiffItemProps, -} ...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -1,106 +1,608 @@ -import { memo, useRef, useEffect, useCallback, useState, useMemo } from 'react'; +import { memo, useEffect, useCallback, useRef, useState, useMemo } from 'react'; +import { useTranslation } from 'react-i18next'; import { - ChangesPanel, - type ChangesPanelHandle, - type RenderDiffItemProps, -} ...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -113,208 +615,262 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44