Datasets:
PotatoHD
/
code-edit-negatives-cls

Dataset card Data Studio Files
xet
 Community
1
text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -198,9 +197,9 @@ class ColumnDynamic final : public COWHelper<IColumnHelper<ColumnDynamic>, Colum /// variant vs the shared variant). void updateHashWithValueRange(size_t begin, size_t end, SipHash & hash) const override; - WeakHash32 getWeakHash32() const override + void computeHashInto(size_t row...
bad
review
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnDynamic.h b/src/Columns/ColumnDynamic.h index 8b3db42e821f..2c2e526b6216 100644 --- a/src/Columns/ColumnDynamic.h +++ b/src/Columns/ColumnDynamic.h @@ -5,7 +5,6 @@ #include <Columns/ColumnVector.h> #include <Columns/IColumn.h> #include <DataTypes/IDataType.h> -#include <Common/WeakHash...
good
review_fixed
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -1159,15 +1161,43 @@ void ColumnObject::updateHashWithValueRange(size_t begin, size_t end, SipHash & shared_data->updateHashWithValueRange(begin, end, hash); } -WeakHash32 ColumnObject::getWeakHash32() const +void ColumnObject::computeHashInto(size_t row_begin, size_t row_end, uint32_t * hash_out, bool initi...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnObject.cpp b/src/Columns/ColumnObject.cpp index 9821e65348dc..d97434b4b0c5 100644 --- a/src/Columns/ColumnObject.cpp +++ b/src/Columns/ColumnObject.cpp @@ -5,6 +5,8 @@ #include <IO/Operators.h> #include <IO/WriteBufferFromString.h> #include <Common/Arena.h> +#include <Common/HashTable/...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -0,0 +1,833 @@ +#include <gtest/gtest.h> + +#include <Columns/ColumnArray.h> +#include <Columns/ColumnConst.h> +#include <Columns/ColumnDecimal.h> +#include <Columns/ColumnFixedString.h> +#include <Columns/ColumnMap.h> +#include <Columns/ColumnNullable.h> +#include <Columns/ColumnSparse.h> +#include <Columns/ColumnS...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/tests/gtest_compute_hash_into.cpp b/src/Columns/tests/gtest_compute_hash_into.cpp new file mode 100644 index 000000000000..6e7cb6dae0dc --- /dev/null +++ b/src/Columns/tests/gtest_compute_hash_into.cpp @@ -0,0 +1,1123 @@ +#include <gtest/gtest.h> + +#include <Columns/ColumnArray.h> +#include <C...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -0,0 +1,833 @@ +#include <gtest/gtest.h> + +#include <Columns/ColumnArray.h> +#include <Columns/ColumnConst.h> +#include <Columns/ColumnDecimal.h> +#include <Columns/ColumnFixedString.h> +#include <Columns/ColumnMap.h> +#include <Columns/ColumnNullable.h> +#include <Columns/ColumnSparse.h> +#include <Columns/ColumnS...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/tests/gtest_compute_hash_into.cpp b/src/Columns/tests/gtest_compute_hash_into.cpp new file mode 100644 index 000000000000..6e7cb6dae0dc --- /dev/null +++ b/src/Columns/tests/gtest_compute_hash_into.cpp @@ -0,0 +1,1123 @@ +#include <gtest/gtest.h> + +#include <Columns/ColumnArray.h> +#include <C...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -316,12 +316,22 @@ void ColumnFunction::updateHashWithValue(size_t n, SipHash & hash) const column.column->updateHashWithValue(n, hash); } -WeakHash32 ColumnFunction::getWeakHash32() const +void ColumnFunction::computeHashInto(size_t row_begin, size_t row_end, uint32_t * hash_out, bool initial) const { ...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnFunction.cpp b/src/Columns/ColumnFunction.cpp index 0ecc7aa779a0..1ebd50be6e1e 100644 --- a/src/Columns/ColumnFunction.cpp +++ b/src/Columns/ColumnFunction.cpp @@ -2,6 +2,7 @@ #include <Columns/ColumnFunction.h> #include <Columns/ColumnsCommon.h> #include <Columns/validateColumnType.h>...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -78,24 +78,108 @@ void ColumnVector<T>::updateHashWithValueRange(size_t begin, size_t end, SipHash hash.update(reinterpret_cast<const char *>(&data[begin]), (end - begin) * sizeof(T)); } +/// Extract the raw uint32 input for fmix32/fmix32Combined from a value of type T. +/// +/// Shared by both the initial a...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnVector.cpp b/src/Columns/ColumnVector.cpp index a6d489642ec6..1911ed54f95a 100644 --- a/src/Columns/ColumnVector.cpp +++ b/src/Columns/ColumnVector.cpp @@ -19,7 +19,6 @@ #include <Common/RadixSort.h> #include <Common/SipHash.h> #include <Common/TargetSpecific.h> -#include <Common/WeakH...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -0,0 +1,836 @@ +#include <gtest/gtest.h> + +#include <Columns/ColumnArray.h> +#include <Columns/ColumnConst.h> +#include <Columns/ColumnDecimal.h> +#include <Columns/ColumnFixedString.h> +#include <Columns/ColumnMap.h> +#include <Columns/ColumnNullable.h> +#include <Columns/ColumnSparse.h> +#include <Columns/ColumnS...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/tests/gtest_compute_hash_into.cpp b/src/Columns/tests/gtest_compute_hash_into.cpp new file mode 100644 index 000000000000..6e7cb6dae0dc --- /dev/null +++ b/src/Columns/tests/gtest_compute_hash_into.cpp @@ -0,0 +1,1123 @@ +#include <gtest/gtest.h> + +#include <Columns/ColumnArray.h> +#include <C...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -65,9 +63,11 @@ class IColumnDummy : public IColumnHelper<IColumnDummy> { } - WeakHash32 getWeakHash32() const override + void computeHashInto(size_t row_begin, size_t row_end, uint32_t * hash_out, bool initial) const override { - return WeakHash32(s); + if (initial)
bad
review
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/IColumnDummy.h b/src/Columns/IColumnDummy.h index 5842ef1959e9..763d4c1c1b30 100644 --- a/src/Columns/IColumnDummy.h +++ b/src/Columns/IColumnDummy.h @@ -1,8 +1,7 @@ #pragma once #include <Columns/IColumn.h> -#include <Common/WeakHash.h> - +#include <Common/HashTable/Hash.h> namespace DB...
good
review_fixed
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -117,14 +116,13 @@ void splitAdditionalColumns(const Names & key_names, const Block & sample_block, void changeLowCardinalityInplace(ColumnWithTypeAndName & column); template <Fn<size_t(size_t)> Sharder> -IColumn::Selector hashToSelector(const WeakHash32 & hash, Sharder sharder) +IColumn::Selector hashToSelector...
bad
review
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Interpreters/JoinUtils.h b/src/Interpreters/JoinUtils.h index ae9dd9b90171..e271e0808c5c 100644 --- a/src/Interpreters/JoinUtils.h +++ b/src/Interpreters/JoinUtils.h @@ -3,7 +3,7 @@ #include <Columns/ColumnsNumber.h> #include <Columns/IColumn.h> #include <Common/HashTable/Hash.h> -#include <Common/W...
good
review_fixed
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -132,20 +132,24 @@ void BufferedShardByHashTransform::generateOutputChunks() chassert(!columns.empty()); - /// Compute cheap weak hash for each row for routing - WeakHash32 hash(num_rows); + /// Compute a composite 32-bit hash over all key columns into a reusable buffer. + /// No allocations: ea...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Processors/Transforms/BufferedShardByHashTransform.cpp b/src/Processors/Transforms/BufferedShardByHashTransform.cpp index 18070958d51a..7353ca912d18 100644 --- a/src/Processors/Transforms/BufferedShardByHashTransform.cpp +++ b/src/Processors/Transforms/BufferedShardByHashTransform.cpp @@ -1,7 +1,8 @@ ...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -0,0 +1,237 @@ +/// Microbenchmark for IColumn::computeHashInto. +/// +/// Measures per-row throughput for the hash-production step used by +/// hash-partitioning operators (e.g. BufferedShardByHashTransform). +/// +/// Each benchmark name encodes: <ColumnType>_K<K>_B<batch> +/// K = number of key columns chained ...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/benchmarks/benchmark_compute_hash_into.cpp b/src/Columns/benchmarks/benchmark_compute_hash_into.cpp new file mode 100644 index 000000000000..af281c577820 --- /dev/null +++ b/src/Columns/benchmarks/benchmark_compute_hash_into.cpp @@ -0,0 +1,236 @@ +/// Microbenchmark for IColumn::computeHashInto...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -0,0 +1,29 @@ +#pragma once + +#include <base/types.h> + +#include <cstddef> + +namespace DB +{ + +/// Map each 32-bit hash uniformly to [0, range_size) using the multiply-and-shift method: +/// +/// result[i] = (uint64_t{hashes[i]} * range_size) >> 32 +/// +/// This is strictly more uniform than `h % n` (no bia...
bad
review
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Common/MapToRange.h b/src/Common/MapToRange.h new file mode 100644 index 000000000000..e2ed0e8081bc --- /dev/null +++ b/src/Common/MapToRange.h @@ -0,0 +1,14 @@ +#pragma once + +#include <base/types.h> + +#include <cstddef> + +namespace DB +{ + +/// Map each 32-bit hash uniformly to [0, range_size) via...
good
review_fixed
c
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -132,20 +135,21 @@ void BufferedShardByHashTransform::generateOutputChunks() chassert(!columns.empty()); - /// Compute cheap weak hash for each row for routing - WeakHash32 hash(num_rows); + /// Compute a composite 32-bit hash over all key columns into a reusable buffer. + /// No allocations: ea...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Processors/Transforms/BufferedShardByHashTransform.cpp b/src/Processors/Transforms/BufferedShardByHashTransform.cpp index 18070958d51a..7353ca912d18 100644 --- a/src/Processors/Transforms/BufferedShardByHashTransform.cpp +++ b/src/Processors/Transforms/BufferedShardByHashTransform.cpp @@ -1,7 +1,8 @@ ...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -132,20 +135,21 @@ void BufferedShardByHashTransform::generateOutputChunks() chassert(!columns.empty()); - /// Compute cheap weak hash for each row for routing - WeakHash32 hash(num_rows); + /// Compute a composite 32-bit hash over all key columns into a reusable buffer. + /// No allocations: ea...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Processors/Transforms/BufferedShardByHashTransform.cpp b/src/Processors/Transforms/BufferedShardByHashTransform.cpp index 18070958d51a..7353ca912d18 100644 --- a/src/Processors/Transforms/BufferedShardByHashTransform.cpp +++ b/src/Processors/Transforms/BufferedShardByHashTransform.cpp @@ -1,7 +1,8 @@ ...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -135,16 +137,16 @@ void ScatterByPartitionTransform::generateOutputChunks() chassert(!columns.empty()); - hash.reset(num_rows); + hash.resize(num_rows);
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Processors/Transforms/ScatterByPartitionTransform.cpp b/src/Processors/Transforms/ScatterByPartitionTransform.cpp index ecae587c637d..d7c0491bdbb6 100644 --- a/src/Processors/Transforms/ScatterByPartitionTransform.cpp +++ b/src/Processors/Transforms/ScatterByPartitionTransform.cpp @@ -2,6 +2,8 @@ #inc...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -135,16 +137,16 @@ void ScatterByPartitionTransform::generateOutputChunks() chassert(!columns.empty()); - hash.reset(num_rows); + hash.resize(num_rows); + std::fill(hash.begin(), hash.end(), WEAK_HASH32_INITIAL_VALUE); for (const auto & column_number : key_columns) - hash.update(colum...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Processors/Transforms/ScatterByPartitionTransform.cpp b/src/Processors/Transforms/ScatterByPartitionTransform.cpp index ecae587c637d..d7c0491bdbb6 100644 --- a/src/Processors/Transforms/ScatterByPartitionTransform.cpp +++ b/src/Processors/Transforms/ScatterByPartitionTransform.cpp @@ -2,6 +2,8 @@ #inc...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -135,16 +137,16 @@ void ScatterByPartitionTransform::generateOutputChunks() chassert(!columns.empty()); - hash.reset(num_rows); + hash.resize(num_rows); + std::fill(hash.begin(), hash.end(), WEAK_HASH32_INITIAL_VALUE); for (const auto & column_number : key_columns) - hash.update(colum...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Processors/Transforms/ScatterByPartitionTransform.cpp b/src/Processors/Transforms/ScatterByPartitionTransform.cpp index ecae587c637d..d7c0491bdbb6 100644 --- a/src/Processors/Transforms/ScatterByPartitionTransform.cpp +++ b/src/Processors/Transforms/ScatterByPartitionTransform.cpp @@ -2,6 +2,8 @@ #inc...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -167,24 +167,48 @@ void ColumnDecimal<T>::updateHashWithValueRange(size_t begin, size_t end, SipHas hash.update(reinterpret_cast<const char *>(&data[begin]), (end - begin) * sizeof(T)); } +/// Finalized per-row CRC32C hash of a decimal value (seeded with `WEAK_HASH32_INITIAL_VALUE`). +/// Accesses .value dir...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnDecimal.cpp b/src/Columns/ColumnDecimal.cpp index 2301d4b6b435..253efd21141d 100644 --- a/src/Columns/ColumnDecimal.cpp +++ b/src/Columns/ColumnDecimal.cpp @@ -4,7 +4,6 @@ #include <Common/HashTable/Hash.h> #include <Common/RadixSort.h> #include <Common/SipHash.h> -#include <Common/Wea...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -245,9 +270,11 @@ void ColumnDecimal<T>::getPermutation(IColumn::PermutationSortDirection directio if (direction == IColumn::PermutationSortDirection::Ascending && stability == IColumn::PermutationSortStability::Unstable) try_sort = trySort(res.begin(), res.end(), comparator_a...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnDecimal.cpp b/src/Columns/ColumnDecimal.cpp index 2301d4b6b435..253efd21141d 100644 --- a/src/Columns/ColumnDecimal.cpp +++ b/src/Columns/ColumnDecimal.cpp @@ -4,7 +4,6 @@ #include <Common/HashTable/Hash.h> #include <Common/RadixSort.h> #include <Common/SipHash.h> -#include <Common/Wea...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -78,24 +77,30 @@ void ColumnVector<T>::updateHashWithValueRange(size_t begin, size_t end, SipHash hash.update(reinterpret_cast<const char *>(&data[begin]), (end - begin) * sizeof(T)); } +/// Finalized per-row CRC32C hash of a value of type T (seeded with `WEAK_HASH32_INITIAL_VALUE`). template <typename T> -...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnVector.cpp b/src/Columns/ColumnVector.cpp index a6d489642ec6..1911ed54f95a 100644 --- a/src/Columns/ColumnVector.cpp +++ b/src/Columns/ColumnVector.cpp @@ -19,7 +19,6 @@ #include <Common/RadixSort.h> #include <Common/SipHash.h> #include <Common/TargetSpecific.h> -#include <Common/WeakH...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -167,24 +166,28 @@ void ColumnDecimal<T>::updateHashWithValueRange(size_t begin, size_t end, SipHas hash.update(reinterpret_cast<const char *>(&data[begin]), (end - begin) * sizeof(T)); } +/// Finalized per-row CRC32C hash of a decimal value (seeded with `WEAK_HASH32_INITIAL_VALUE`). +/// Accesses `.value` d...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnDecimal.cpp b/src/Columns/ColumnDecimal.cpp index 2301d4b6b435..253efd21141d 100644 --- a/src/Columns/ColumnDecimal.cpp +++ b/src/Columns/ColumnDecimal.cpp @@ -4,7 +4,6 @@ #include <Common/HashTable/Hash.h> #include <Common/RadixSort.h> #include <Common/SipHash.h> -#include <Common/Wea...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -957,38 +956,37 @@ void ColumnVariant::updateHashWithValueRange(size_t begin, size_t end, SipHash & } } -WeakHash32 ColumnVariant::getWeakHash32() const +void ColumnVariant::computeHashInto(size_t row_begin, size_t row_end, UInt32 * hash_out, bool initial) const { - auto s = size(); - - /// If we have...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnVariant.cpp b/src/Columns/ColumnVariant.cpp index d79d0e58d8b0..7e2dee7d231d 100644 --- a/src/Columns/ColumnVariant.cpp +++ b/src/Columns/ColumnVariant.cpp @@ -7,7 +7,6 @@ #include <Processors/Transforms/ColumnGathererTransform.h> #include <IO/Operators.h> #include <IO/WriteBufferFromS...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -957,38 +956,37 @@ void ColumnVariant::updateHashWithValueRange(size_t begin, size_t end, SipHash & } } -WeakHash32 ColumnVariant::getWeakHash32() const +void ColumnVariant::computeHashInto(size_t row_begin, size_t row_end, UInt32 * hash_out, bool initial) const { - auto s = size(); - - /// If we have...
bad
review
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
diff --git a/src/Columns/ColumnVariant.cpp b/src/Columns/ColumnVariant.cpp index d79d0e58d8b0..7e2dee7d231d 100644 --- a/src/Columns/ColumnVariant.cpp +++ b/src/Columns/ColumnVariant.cpp @@ -7,7 +7,6 @@ #include <Processors/Transforms/ColumnGathererTransform.h> #include <IO/Operators.h> #include <IO/WriteBufferFromS...
good
review_fixed
cpp
ClickHouse/ClickHouse
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
@@ -376,6 +389,35 @@ void applyPatchesToBlockCombined( if (!updated_header.has(result_column.name)) continue; + /// Check that all patch blocks have compatible column structure before applying. + /// Schema evolution may change column types, making patches incompatible. + bo...
bad
review
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp index 6b8c2fcdcc70..447f51853eff 100644 --- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp +++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp @@ -8,6 +8,7 @@ #include <DataTypes/DataTypesNum...
good
review_fixed
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
@@ -332,10 +333,24 @@ void applyPatchesToBlockRaw( if (!patch_block.has(result_column.name)) continue; - const auto & patch_column = patch_block.getByName(result_column.name).column; - if (!patch_column) + const auto & patch_col_with_type = patch_block.ge...
bad
review
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp index 6b8c2fcdcc70..447f51853eff 100644 --- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp +++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp @@ -8,6 +8,7 @@ #include <DataTypes/DataTypesNum...
good
review_fixed
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
@@ -376,6 +391,37 @@ void applyPatchesToBlockCombined( if (!updated_header.has(result_column.name)) continue; + /// Check that all patch blocks have compatible column types before applying. + /// Schema evolution may change column types, making patches incompatible. + /// Ap...
bad
review
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp index 6b8c2fcdcc70..447f51853eff 100644 --- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp +++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp @@ -8,6 +8,7 @@ #include <DataTypes/DataTypesNum...
good
review_fixed
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
@@ -0,0 +1,114 @@ +#include <gtest/gtest.h> + +#include <Storages/MergeTree/PatchParts/applyPatches.h> +#include <Storages/MergeTree/MergeTreeVirtualColumns.h> +#include <Columns/ColumnsNumber.h> +#include <Columns/ColumnString.h> +#include <DataTypes/DataTypesNumber.h> +#include <DataTypes/DataTypeString.h> + +using n...
bad
review
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
diff --git a/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp b/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp new file mode 100644 index 000000000000..867f2d38448d --- /dev/null +++ b/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.c...
good
review_fixed
cpp
ClickHouse/ClickHouse
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
@@ -1,10 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> - <TargetFramework>net6.0</TargetFramework> + <TargetFramework>net8.0</TargetFramework> </PropertyGroup> <ItemGroup> <Compile Include="Shared.fs" /> + <None Include="paket.references" /> ...
bad
review
CompositionalIT/SAFE-Dojo
a4009198c0cb767616b509b0be584362fecd48dc
diff --git a/src/Shared/Shared.fsproj b/src/Shared/Shared.fsproj index 8fee1db..83a61a2 100644 --- a/src/Shared/Shared.fsproj +++ b/src/Shared/Shared.fsproj @@ -1,10 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> - <TargetFramework>net6.0</TargetFramework> + ...
good
review_fixed
CompositionalIT/SAFE-Dojo
a4009198c0cb767616b509b0be584362fecd48dc
@@ -2,7 +2,7 @@ <Project Sdk="Microsoft.NET.Sdk.Web"> <PropertyGroup> <OutputType>Exe</OutputType> - <TargetFramework>net6.0</TargetFramework>
bad
review
CompositionalIT/SAFE-Dojo
a4009198c0cb767616b509b0be584362fecd48dc
diff --git a/src/Server/Server.fsproj b/src/Server/Server.fsproj index 000648b..c9c22c0 100644 --- a/src/Server/Server.fsproj +++ b/src/Server/Server.fsproj @@ -2,7 +2,8 @@ <Project Sdk="Microsoft.NET.Sdk.Web"> <PropertyGroup> <OutputType>Exe</OutputType> - <TargetFramework>net6.0</TargetFramework> + <Ta...
good
review_fixed
CompositionalIT/SAFE-Dojo
a4009198c0cb767616b509b0be584362fecd48dc
@@ -5,7 +5,7 @@ open Farmer.Builders open Helpers
bad
review
fsharp
CompositionalIT/SAFE-Dojo
a4009198c0cb767616b509b0be584362fecd48dc
diff --git a/Build.fs b/Build.fs index f6c3897..31b5ce9 100644 --- a/Build.fs +++ b/Build.fs @@ -5,7 +5,7 @@ open Farmer.Builders open Helpers -initializeContext() +initializeContext () let sharedPath = Path.getFullName "src/Shared" let serverPath = Path.getFullName "src/Server" @@ -14,54 +14,48 @@ let deployP...
good
review_fixed
fsharp
CompositionalIT/SAFE-Dojo
a4009198c0cb767616b509b0be584362fecd48dc
@@ -9,7 +9,7 @@ ]
bad
review
CompositionalIT/SAFE-Dojo
f5ede36786017cef0bb2da108d9fac6d33ba95bb
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 66218b2..b63ef6a 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -3,13 +3,13 @@ "isRoot": true, "tools": { "paket": { - "version": "6.0.0-rc002", + "version": "7.2.0", "commands": [ "p...
good
review_fixed
CompositionalIT/SAFE-Dojo
f5ede36786017cef0bb2da108d9fac6d33ba95bb
@@ -29,14 +29,9 @@ let getCrimeReport postcode = async { return crimes } -let private asWeatherResponse (weather: Weather.MetaWeatherLocation.Root) = - { WeatherType = - weather.ConsolidatedWeather - |> Array.countBy(fun w -> w.WeatherStateName) - |> Array.maxBy snd - |> fst - ...
bad
review
fsharp
CompositionalIT/SAFE-Dojo
f45fd41ec5ddbd3b67530502866f01cdcfe6479e
diff --git a/src/Server/Api.fs b/src/Server/Api.fs index 86885c7..53645cb 100644 --- a/src/Server/Api.fs +++ b/src/Server/Api.fs @@ -29,14 +29,9 @@ let getCrimeReport postcode = async { return crimes } -let private asWeatherResponse (weather: Weather.MetaWeatherLocation.Root) = - { WeatherType = - wea...
good
review_fixed
fsharp
CompositionalIT/SAFE-Dojo
f45fd41ec5ddbd3b67530502866f01cdcfe6479e
@@ -4142,6 +4142,50 @@ module ContainerApp = /// Mounts an Azure File Share in the same resource group, performing a key lookup. | AzureFileShare of ShareName: ResourceName * StorageAccountName: Storage.StorageAccountName * StorageAccessMode + /// Defines valid resource allocations for containers...
bad
review
fsharp
CompositionalIT/farmer
6094d98e1e3ed892345e0c44da06a2e5119cf18f
diff --git a/src/Farmer/Common.fs b/src/Farmer/Common.fs index d82be4ae8..7efa18aae 100644 --- a/src/Farmer/Common.fs +++ b/src/Farmer/Common.fs @@ -4142,6 +4142,82 @@ module ContainerApp = /// Mounts an Azure File Share in the same resource group, performing a key lookup. | AzureFileShare of ShareNam...
good
review_fixed
fsharp
CompositionalIT/farmer
6094d98e1e3ed892345e0c44da06a2e5119cf18f
@@ -0,0 +1,509 @@ +[<AutoOpen>] +module Farmer.Builders.NetworkManager + +open Farmer +open Farmer.Arm.NetworkManager + +/// Configuration for a security admin rule +type SecurityAdminRuleConfig = { + Name: ResourceName + Description: string option + Access: SecurityAdmin.Access + Direction: SecurityAdmin.D...
bad
review
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
diff --git a/src/Farmer/Builders/Builders.NetworkManager.fs b/src/Farmer/Builders/Builders.NetworkManager.fs new file mode 100644 index 000000000..448571289 --- /dev/null +++ b/src/Farmer/Builders/Builders.NetworkManager.fs @@ -0,0 +1,549 @@ +[<AutoOpen>] +module Farmer.Builders.NetworkManager + +open Farmer +open Farm...
good
review_fixed
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
@@ -0,0 +1,272 @@ +[<AutoOpen>] +module Farmer.Arm.NetworkManager + +open Farmer + +// https://learn.microsoft.com/en-us/azure/templates/microsoft.network/networkmanagers +let networkManagers = + ResourceType("Microsoft.Network/networkManagers", "2025-05-01") + +// https://learn.microsoft.com/en-us/azure/templates/m...
bad
review
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
diff --git a/src/Farmer/Arm/NetworkManager.fs b/src/Farmer/Arm/NetworkManager.fs new file mode 100644 index 000000000..da22f7ac6 --- /dev/null +++ b/src/Farmer/Arm/NetworkManager.fs @@ -0,0 +1,272 @@ +[<AutoOpen>] +module Farmer.Arm.NetworkManager + +open Farmer + +// https://learn.microsoft.com/en-us/azure/templates/m...
good
review_fixed
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
@@ -0,0 +1,516 @@ +[<AutoOpen>] +module Farmer.Builders.NetworkManager + +open Farmer +open Farmer.Arm.NetworkManager + +/// Configuration for a security admin rule +type SecurityAdminRuleConfig = { + Name: ResourceName + Description: string option + Access: SecurityAdmin.Access + Direction: SecurityAdmin.D...
bad
review
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
diff --git a/src/Farmer/Builders/Builders.NetworkManager.fs b/src/Farmer/Builders/Builders.NetworkManager.fs new file mode 100644 index 000000000..448571289 --- /dev/null +++ b/src/Farmer/Builders/Builders.NetworkManager.fs @@ -0,0 +1,549 @@ +[<AutoOpen>] +module Farmer.Builders.NetworkManager + +open Farmer +open Farm...
good
review_fixed
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
@@ -0,0 +1,533 @@ +[<AutoOpen>] +module Farmer.Builders.NetworkManager + +open Farmer +open Farmer.Arm.NetworkManager + +/// Configuration for a security admin rule +type SecurityAdminRuleConfig = { + Name: ResourceName + Description: string option + Access: SecurityAdmin.Access + Direction: SecurityAdmin.D...
bad
review
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
diff --git a/src/Farmer/Builders/Builders.NetworkManager.fs b/src/Farmer/Builders/Builders.NetworkManager.fs new file mode 100644 index 000000000..448571289 --- /dev/null +++ b/src/Farmer/Builders/Builders.NetworkManager.fs @@ -0,0 +1,549 @@ +[<AutoOpen>] +module Farmer.Builders.NetworkManager + +open Farmer +open Farm...
good
review_fixed
fsharp
CompositionalIT/farmer
81e96813680bd5fc5f6bd9cb217ab408b48535a0
@@ -43,4 +43,4 @@ Yes. You can use some adapters that Farmer provides to generate resources using Create an issue on our [github repository](https://github.com/CompositionalIT/farmer/issues), ideally with a sample ARM template and a link to the official Microsoft documentation on the resource. We can't promise we'll l...
bad
review
CompositionalIT/farmer
67432f68f71231e147a02aa129709344a40bff3c
diff --git a/docs/content/faq/_index.md b/docs/content/faq/_index.md index 402e4ee4b..56555c282 100644 --- a/docs/content/faq/_index.md +++ b/docs/content/faq/_index.md @@ -42,5 +42,3 @@ Yes. You can use some adapters that Farmer provides to generate resources using #### The resource I need isn't included! Create an ...
good
review_fixed
CompositionalIT/farmer
67432f68f71231e147a02aa129709344a40bff3c
@@ -4,12 +4,12 @@ date: 2020-06-27T17:57:05+02:00 weight: 7 --- -The creators of Farmer, [Compositional IT](https://compositional-it.com), offer a professional [fully managed support package](https://www.compositional-it.com/consultancy/farmer/) which we strongly recommend for any organisations using Farmer on a co...
bad
review
CompositionalIT/farmer
67432f68f71231e147a02aa129709344a40bff3c
diff --git a/docs/content/support/_index.md b/docs/content/support/_index.md index 5e467de8e..91e97235c 100644 --- a/docs/content/support/_index.md +++ b/docs/content/support/_index.md @@ -4,12 +4,10 @@ date: 2020-06-27T17:57:05+02:00 weight: 7 --- -The creators of Farmer, [Compositional IT](https://compositional-i...
good
review_fixed
CompositionalIT/farmer
67432f68f71231e147a02aa129709344a40bff3c
@@ -2005,7 +2005,7 @@ module Sql = | Gen5_32 | Gen5_40 | Gen5_80 - | S_Gen5 of CapacityMin: int * CapacityMax: int + | S_Gen5 of CapacityMin: float * CapacityMax: float
bad
review
fsharp
CompositionalIT/farmer
23e65eadc573f5f0640037b1e7092225b9210dbb
diff --git a/src/Farmer/Common.fs b/src/Farmer/Common.fs index 3ad44478a..760e3e692 100644 --- a/src/Farmer/Common.fs +++ b/src/Farmer/Common.fs @@ -2022,7 +2022,7 @@ module Sql = | Gen5_32 | Gen5_40 | Gen5_80 - | S_Gen5 of CapacityMin: int * CapacityMax: int + | S_Gen5 of Capac...
good
review_fixed
fsharp
CompositionalIT/farmer
23e65eadc573f5f0640037b1e7092225b9210dbb
@@ -160,7 +160,6 @@ type ContainerApp = { | KeyValue(name, Volume.AzureFileShare(_)) -> storages.resourceId (this.Environment.Name, ResourceName name) |> Some | _ -> None) - yield! this.Identity.Dependencies
bad
review
fsharp
CompositionalIT/farmer
96202e18fa9185381517119fb0b506528e7ca0df
diff --git a/src/Farmer/Arm/App.fs b/src/Farmer/Arm/App.fs index 20bb1b9c2..dcb613cc6 100644 --- a/src/Farmer/Arm/App.fs +++ b/src/Farmer/Arm/App.fs @@ -215,13 +215,7 @@ type ContainerApp = { ) .Eval() ...
good
review_fixed
fsharp
CompositionalIT/farmer
96202e18fa9185381517119fb0b506528e7ca0df
@@ -1,13 +1,12 @@ [<AutoOpen>] module Farmer.Arm.Network -open System.Net.Mail open Farmer -open Farmer.Arm open Farmer.ExpressRoute open Farmer.Network open Farmer.Route open Farmer.RouteServer +open Farmer.Storage
bad
review
fsharp
CompositionalIT/farmer
3d9c0ef959ef88f4d889f940bf42a356ed99c440
diff --git a/src/Farmer/Arm/Network.fs b/src/Farmer/Arm/Network.fs index 9e5f54c06..a14ddb4b4 100644 --- a/src/Farmer/Arm/Network.fs +++ b/src/Farmer/Arm/Network.fs @@ -1,9 +1,7 @@ [<AutoOpen>] module Farmer.Arm.Network -open System.Net.Mail open Farmer -open Farmer.Arm open Farmer.ExpressRoute open Farmer.Netwo...
good
review_fixed
fsharp
CompositionalIT/farmer
3d9c0ef959ef88f4d889f940bf42a356ed99c440
@@ -0,0 +1,175 @@ +[<AutoOpen>] +module Farmer.Arm.Monitor + +open Farmer + +let dataCollectionEndpoints = + ResourceType("Microsoft.Insights/dataCollectionEndpoints", "2023-03-11") + +type DataCollectionEndpoint = { + Name: ResourceName + OsType: OS + Location: Location + Tags: Map<string, string> +} wi...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/Monitor.fs b/src/Farmer/Arm/Monitor.fs new file mode 100644 index 000000000..26e0cc101 --- /dev/null +++ b/src/Farmer/Arm/Monitor.fs @@ -0,0 +1,175 @@ +[<AutoOpen>] +module Farmer.Arm.Monitor + +open Farmer + +let dataCollectionEndpoints = + ResourceType("Microsoft.Insights/dataCollection...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
@@ -0,0 +1,237 @@ +[<AutoOpen>] +module Farmer.Builders.AzureMonitor + +open Farmer +open Farmer.Arm +open Farmer.Arm.Monitor +open Farmer.Arm.Monitor.DataSources +open Farmer.Arm.Monitor.Destinations + +type DataCollectionEndpointConfig = { + Name: ResourceName + OsType: OS + Tags: Map<string, string> +} with...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Builders/Builders.AzureMonitor.fs b/src/Farmer/Builders/Builders.AzureMonitor.fs new file mode 100644 index 000000000..3cc8cea49 --- /dev/null +++ b/src/Farmer/Builders/Builders.AzureMonitor.fs @@ -0,0 +1,237 @@ +[<AutoOpen>] +module Farmer.Builders.AzureMonitor + +open Farmer +open Farmer.Arm +...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
@@ -222,6 +222,28 @@ type WebhookReceiver = { useCommonAlertSchema = useCommonAlertSchema } +type IncidentServiceConnection = { Id: Guid; Name: string } + +type IncidentManagementService = | Icm + +type IncidentReceiver = { + /// The name of the incident receiver. Names must be unique across all rece...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs index f8ba11da5..0dd1d22c3 100644 --- a/src/Farmer/Arm/ActionGroup.fs +++ b/src/Farmer/Arm/ActionGroup.fs @@ -222,6 +222,28 @@ type WebhookReceiver = { useCommonAlertSchema = useCommonAlertSchema } +type IncidentServiceConnection...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
@@ -0,0 +1,128 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("Microsoft.AlertsManagement/prometheusRuleGroups", "2023-03-01") + +type Action = { + ActionGroupId: ResourceId + ActionProperties: Map<string, string> option +} with + + member in...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
@@ -0,0 +1,128 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("Microsoft.AlertsManagement/prometheusRuleGroups", "2023-03-01") + +type Action = { + ActionGroupId: ResourceId + ActionProperties: Map<string, string> option +} with + + member in...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
@@ -0,0 +1,128 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("Microsoft.AlertsManagement/prometheusRuleGroups", "2023-03-01") + +type Action = { + ActionGroupId: ResourceId + ActionProperties: Map<string, string> option +} with + + member in...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
@@ -0,0 +1,128 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("Microsoft.AlertsManagement/prometheusRuleGroups", "2023-03-01") + +type Action = { + ActionGroupId: ResourceId + ActionProperties: Map<string, string> option +} with + + member in...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
@@ -0,0 +1,128 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("Microsoft.AlertsManagement/prometheusRuleGroups", "2023-03-01") + +type Action = { + ActionGroupId: ResourceId + ActionProperties: Map<string, string> option +} with + + member in...
bad
review
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
good
review_fixed
fsharp
CompositionalIT/farmer
73506b86256f26f3547ef6243684eedb2eb2bd38