text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -30,8 +30,41 @@ on: - .github/workflows/unity-tests.yml jobs: + matrix: + name: Compute Unity version matrix + runs-on: ubuntu-latest + permissions: + contents: read + outputs: + versions: ${{ steps.set.outputs.versions }} + steps: + - name: Checkout version manifest + ...
bad
review
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
diff --git a/.github/workflows/unity-tests.yml b/.github/workflows/unity-tests.yml index e4fbed4f3..411f12684 100644 --- a/.github/workflows/unity-tests.yml +++ b/.github/workflows/unity-tests.yml @@ -30,15 +30,78 @@ on: - .github/workflows/unity-tests.yml jobs: + matrix: + name: Compute Unity version mat...
good
review_fixed
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
@@ -0,0 +1,237 @@ +#requires -Version 5 +<# +.SYNOPSIS + Local parity check for the CI Unity-version matrix (Windows companion to check-unity-versions.sh). + +.DESCRIPTION + Reads tools\unity-versions.json (the shared source of truth used by .github\workflows\unity-tests.yml) + and runs a compile-only batchmode pass...
bad
review
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
diff --git a/tools/check-unity-versions.ps1 b/tools/check-unity-versions.ps1 new file mode 100644 index 000000000..c99f10967 --- /dev/null +++ b/tools/check-unity-versions.ps1 @@ -0,0 +1,239 @@ +#requires -Version 5 +<# +.SYNOPSIS + Local parity check for the CI Unity-version matrix (Windows companion to check-unity-v...
good
review_fixed
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
@@ -0,0 +1,273 @@ +#!/usr/bin/env bash +# Local parity check for the CI Unity-version matrix. +# +# Usage: +# tools/check-unity-versions.sh # compile-only, all installed versions from tools/unity-versions.json +# tools/check-unity-versions.sh --full # full EditMode test run (matches CI beha...
bad
review
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
diff --git a/tools/check-unity-versions.sh b/tools/check-unity-versions.sh new file mode 100755 index 000000000..69fefb506 --- /dev/null +++ b/tools/check-unity-versions.sh @@ -0,0 +1,285 @@ +#!/usr/bin/env bash +# Local parity check for the CI Unity-version matrix. +# +# Usage: +# tools/check-unity-versions.sh ...
good
review_fixed
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
@@ -0,0 +1,43 @@ +#!/usr/bin/env bash +# Pre-push hook: runs the local Unity-version parity check in compile-only mode. +# Installed by tools/install-hooks.sh; opt-in (devs without the hook see no behavior change). +# To bypass for a single push: git push --no-verify + +set -e + +REPO_ROOT="$(git rev-parse --show-tople...
bad
review
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
diff --git a/tools/hooks/pre-push b/tools/hooks/pre-push new file mode 100755 index 000000000..1c6bb1c9a --- /dev/null +++ b/tools/hooks/pre-push @@ -0,0 +1,50 @@ +#!/usr/bin/env bash +# Pre-push hook: runs the local Unity-version parity check in compile-only mode. +# Installed by tools/install-hooks.sh; opt-in (devs w...
good
review_fixed
CoplayDev/unity-mcp
cf1b4a09bc3f2faa55645942f35386ea9b926298
@@ -0,0 +1,164 @@ +using System; +using System.Collections.Generic; +using System.Reflection; +using NUnit.Framework; +using MCPForUnity.Editor.Services; + +namespace MCPForUnityTests.Editor.Services +{ + /// <summary> + /// Tests for TestJobManager's per-job InitTimeoutMs feature. + /// Uses reflection to man...
bad
review
csharp
CoplayDev/unity-mcp
233e88e8acce47058cec18fb7716fcfeaa4d27c5
diff --git a/TestProjects/UnityMCPTests/Assets/Tests/EditMode/Services/TestJobManagerInitTimeoutTests.cs b/TestProjects/UnityMCPTests/Assets/Tests/EditMode/Services/TestJobManagerInitTimeoutTests.cs new file mode 100644 index 000000000..0e7bb8fcc --- /dev/null +++ b/TestProjects/UnityMCPTests/Assets/Tests/EditMode/Serv...
good
review_fixed
csharp
CoplayDev/unity-mcp
233e88e8acce47058cec18fb7716fcfeaa4d27c5
@@ -0,0 +1,164 @@ +using System; +using System.Collections.Generic; +using System.Reflection; +using NUnit.Framework; +using MCPForUnity.Editor.Services; + +namespace MCPForUnityTests.Editor.Services +{ + /// <summary> + /// Tests for TestJobManager's per-job InitTimeoutMs feature. + /// Uses reflection to man...
bad
review
csharp
CoplayDev/unity-mcp
233e88e8acce47058cec18fb7716fcfeaa4d27c5
diff --git a/TestProjects/UnityMCPTests/Assets/Tests/EditMode/Services/TestJobManagerInitTimeoutTests.cs b/TestProjects/UnityMCPTests/Assets/Tests/EditMode/Services/TestJobManagerInitTimeoutTests.cs new file mode 100644 index 000000000..0e7bb8fcc --- /dev/null +++ b/TestProjects/UnityMCPTests/Assets/Tests/EditMode/Serv...
good
review_fixed
csharp
CoplayDev/unity-mcp
233e88e8acce47058cec18fb7716fcfeaa4d27c5
@@ -35,10 +35,10 @@ jobs: with: ref: ${{ needs.update-packagejson.outputs.sha }} - uses: Cysharp/Actions/.github/actions/setup-dotnet@main - # build and pack + # build and pack nuget (.nupkg and .symbols.nupkg will be created)
bad
review
Cysharp/UniTask
b0d26bebea48a861a1449cdf169a90e1e80d1ef3
diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml index 94d8d7ef..74b69951 100644 --- a/.github/workflows/build-release.yaml +++ b/.github/workflows/build-release.yaml @@ -35,10 +35,10 @@ jobs: with: ref: ${{ needs.update-packagejson.outputs.sha }} - use...
good
review_fixed
Cysharp/UniTask
b0d26bebea48a861a1449cdf169a90e1e80d1ef3
@@ -96,9 +96,32 @@ jobs: path: ./src/UniTask/UniTask.${{ inputs.tag }}.unitypackage retention-days: 1 + # publish + publish: + name: "Publish NuGet packages" + needs: [build-dotnet, build-unity] + permissions: + contents: read + id-token: write # required for NuGet Trusted P...
bad
review
Cysharp/UniTask
b0d26bebea48a861a1449cdf169a90e1e80d1ef3
diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml index 94d8d7ef..74b69951 100644 --- a/.github/workflows/build-release.yaml +++ b/.github/workflows/build-release.yaml @@ -35,10 +35,10 @@ jobs: with: ref: ${{ needs.update-packagejson.outputs.sha }} - use...
good
review_fixed
Cysharp/UniTask
b0d26bebea48a861a1449cdf169a90e1e80d1ef3
@@ -96,9 +96,32 @@ jobs: path: ./src/UniTask/UniTask.${{ inputs.tag }}.unitypackage retention-days: 1 + # publish + publish: + name: "Publish NuGet packages" + needs: [build-dotnet, build-unity] + permissions:
bad
review
Cysharp/UniTask
b0d26bebea48a861a1449cdf169a90e1e80d1ef3
diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml index 94d8d7ef..74b69951 100644 --- a/.github/workflows/build-release.yaml +++ b/.github/workflows/build-release.yaml @@ -35,10 +35,10 @@ jobs: with: ref: ${{ needs.update-packagejson.outputs.sha }} - use...
good
review_fixed
Cysharp/UniTask
b0d26bebea48a861a1449cdf169a90e1e80d1ef3
@@ -0,0 +1,243 @@ +"""Tests for `LinkExtractor`.""" + +import re + +import pytest + +from scrapling.engines.toolbelt.custom import Response +from scrapling.spiders.links import IGNORED_EXTENSIONS, LinkExtractor + + +def _make_response(html: str, url: str = "https://example.com/page") -> Response: + """Build a minima...
bad
review
python
D4Vinci/Scrapling
66d891701376ca67e07e0aa81f914f7b94347812
diff --git a/tests/spiders/test_links.py b/tests/spiders/test_links.py new file mode 100644 index 00000000..24139925 --- /dev/null +++ b/tests/spiders/test_links.py @@ -0,0 +1,243 @@ +"""Tests for `LinkExtractor`.""" + +import re + +import pytest + +from scrapling.engines.toolbelt.custom import Response +from scrapling...
good
review_fixed
python
D4Vinci/Scrapling
66d891701376ca67e07e0aa81f914f7b94347812
@@ -47,7 +47,7 @@ def _general_selection(self: Any, selection: str = "css", full_path: bool = Fals if counter[target.tag] > 1: part += f":nth-of-type({counter[target.tag]})" if css else f"[{counter[target.tag]}]" - selectorPath.append(part) + ...
bad
review
python
D4Vinci/Scrapling
3c234364487535c67e83b41863b4223181dcd9fa
diff --git a/scrapling/core/mixins.py b/scrapling/core/mixins.py index c2e74202..868d620d 100644 --- a/scrapling/core/mixins.py +++ b/scrapling/core/mixins.py @@ -26,7 +26,12 @@ def _general_selection(self: Any, selection: str = "css", full_path: bool = Fals if target.parent: if target.att...
good
review_fixed
python
D4Vinci/Scrapling
3c234364487535c67e83b41863b4223181dcd9fa
@@ -321,6 +321,45 @@ def _traverse(element: Selector): _traverse(page) +def test_full_path_selector_no_duplicate_ids(): + """Test that full path selectors don't duplicate id segments (regression test)""" + html = '<html><body><div id="main"><p id="target">Hello</p></div></body></html>' + page = Select...
bad
review
python
D4Vinci/Scrapling
3c234364487535c67e83b41863b4223181dcd9fa
diff --git a/tests/parser/test_general.py b/tests/parser/test_general.py index 26f6e6c2..293e93ed 100644 --- a/tests/parser/test_general.py +++ b/tests/parser/test_general.py @@ -321,6 +321,50 @@ def _traverse(element: Selector): _traverse(page) +def test_full_path_selector_no_duplicate_ids(): + """Test tha...
good
review_fixed
python
D4Vinci/Scrapling
3c234364487535c67e83b41863b4223181dcd9fa
@@ -411,3 +396,90 @@ route = _AsyncMockRoute("https://notexample.com/page") await handler(route) assert route.continued + + +class TestIsDomainBlocked: + """Test the frozenset-based domain matching helper.""" + + def test_exact_match(self): + domains = frozenset({"doubleclick.net...
bad
review
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py index bebb5fd8..942835f1 100644 --- a/tests/fetchers/test_utils.py +++ b/tests/fetchers/test_utils.py @@ -5,11 +5,9 @@ construct_proxy_dict, create_intercept_handler, create_async_intercept_handler, + _is_domain_blocked, ) -from...
good
review_fixed
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
@@ -411,3 +396,90 @@ route = _AsyncMockRoute("https://notexample.com/page") await handler(route) assert route.continued + + +class TestIsDomainBlocked: + """Test the frozenset-based domain matching helper.""" + + def test_exact_match(self): + domains = frozenset({"doubleclick.net...
bad
review
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py index bebb5fd8..942835f1 100644 --- a/tests/fetchers/test_utils.py +++ b/tests/fetchers/test_utils.py @@ -5,11 +5,9 @@ construct_proxy_dict, create_intercept_handler, create_async_intercept_handler, + _is_domain_blocked, ) -from...
good
review_fixed
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
@@ -411,3 +396,90 @@ route = _AsyncMockRoute("https://notexample.com/page") await handler(route) assert route.continued + + +class TestIsDomainBlocked: + """Test the frozenset-based domain matching helper.""" + + def test_exact_match(self): + domains = frozenset({"doubleclick.net...
bad
review
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py index bebb5fd8..942835f1 100644 --- a/tests/fetchers/test_utils.py +++ b/tests/fetchers/test_utils.py @@ -5,11 +5,9 @@ construct_proxy_dict, create_intercept_handler, create_async_intercept_handler, + _is_domain_blocked, ) -from...
good
review_fixed
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
@@ -411,3 +396,90 @@ route = _AsyncMockRoute("https://notexample.com/page") await handler(route) assert route.continued + + +class TestIsDomainBlocked: + """Test the frozenset-based domain matching helper.""" + + def test_exact_match(self): + domains = frozenset({"doubleclick.net...
bad
review
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py index bebb5fd8..942835f1 100644 --- a/tests/fetchers/test_utils.py +++ b/tests/fetchers/test_utils.py @@ -5,11 +5,9 @@ construct_proxy_dict, create_intercept_handler, create_async_intercept_handler, + _is_domain_blocked, ) -from...
good
review_fixed
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
@@ -411,3 +396,90 @@ route = _AsyncMockRoute("https://notexample.com/page") await handler(route) assert route.continued + + +class TestIsDomainBlocked: + """Test the frozenset-based domain matching helper.""" + + def test_exact_match(self): + domains = frozenset({"doubleclick.net...
bad
review
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py index bebb5fd8..942835f1 100644 --- a/tests/fetchers/test_utils.py +++ b/tests/fetchers/test_utils.py @@ -5,11 +5,9 @@ construct_proxy_dict, create_intercept_handler, create_async_intercept_handler, + _is_domain_blocked, ) -from...
good
review_fixed
python
D4Vinci/Scrapling
65c54f3b91582696b52f3b0a1402eb6d8af0578d
@@ -67,6 +67,7 @@ dependencies = [ "tld>=0.13.2", "w3lib>=2.4.1", "typing_extensions", + "protego>=0.4.0",
bad
review
D4Vinci/Scrapling
a134fdb8cce853f66713e115b81d195ec6e7b0c3
diff --git a/pyproject.toml b/pyproject.toml index a8058188..4333d7ea 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -66,7 +66,7 @@ dependencies = [ "orjson>=3.11.8", "tld>=0.13.2", "w3lib>=2.4.1", - "typing_extensions", + "typing_extensions" ] [project.optional-dependencies] @@ -78,7 +78,...
good
review_fixed
D4Vinci/Scrapling
a134fdb8cce853f66713e115b81d195ec6e7b0c3
@@ -24,18 +83,210 @@ def test_sqlite_storage_with_file(self): assert storage is not None assert os.path.exists(db_path) finally: - # Close the database connection before deleting (required on Windows) if storage is not None: storage.close() ...
bad
review
python
D4Vinci/Scrapling
30ffe76cfabea565e4bc5f8c173902615392126e
diff --git a/tests/core/test_storage_core.py b/tests/core/test_storage_core.py index 18272942..21de243c 100644 --- a/tests/core/test_storage_core.py +++ b/tests/core/test_storage_core.py @@ -1,18 +1,77 @@ import tempfile import os +import threading -from scrapling.core.storage import SQLiteStorageSystem +from lxml....
good
review_fixed
python
D4Vinci/Scrapling
30ffe76cfabea565e4bc5f8c173902615392126e
@@ -24,18 +83,210 @@ def test_sqlite_storage_with_file(self): assert storage is not None assert os.path.exists(db_path) finally: - # Close the database connection before deleting (required on Windows) if storage is not None: storage.close() ...
bad
review
python
D4Vinci/Scrapling
30ffe76cfabea565e4bc5f8c173902615392126e
diff --git a/tests/core/test_storage_core.py b/tests/core/test_storage_core.py index 18272942..21de243c 100644 --- a/tests/core/test_storage_core.py +++ b/tests/core/test_storage_core.py @@ -1,18 +1,77 @@ import tempfile import os +import threading -from scrapling.core.storage import SQLiteStorageSystem +from lxml....
good
review_fixed
python
D4Vinci/Scrapling
30ffe76cfabea565e4bc5f8c173902615392126e
@@ -266,6 +328,37 @@ def test_text_handlers_operations(self): assert handlers.get("default") == "First" assert TextHandlers([]).get("default") == "default" + def test_text_handlers_re(self): + """Test TextHandlers.re() flattens results across all elements""" + handlers = TextHandler...
bad
review
python
D4Vinci/Scrapling
5123590a1508988e3dba27f5c873a302bdf26fc9
diff --git a/tests/parser/test_parser_advanced.py b/tests/parser/test_parser_advanced.py index f34ba5c7..969ccc31 100644 --- a/tests/parser/test_parser_advanced.py +++ b/tests/parser/test_parser_advanced.py @@ -250,6 +250,68 @@ def test_text_handler_regex(self): matches = text3.re(r"He l lo", clean_match=True,...
good
review_fixed
python
D4Vinci/Scrapling
5123590a1508988e3dba27f5c873a302bdf26fc9
@@ -1660,6 +1660,11 @@ static cJSON_bool parse_object(cJSON * const item, parse_buffer * const input_bu current_item = new_item; } + if (input_buffer->offset+1 >= input_buffer->length)
bad
review
c
DaveGamble/cJSON
c39043866aaef2e599045b2c04936b247f84d82d
diff --git a/cJSON.c b/cJSON.c index 4f5b38dc9..97564bb0a 100644 --- a/cJSON.c +++ b/cJSON.c @@ -1660,6 +1660,11 @@ static cJSON_bool parse_object(cJSON * const item, parse_buffer * const input_bu current_item = new_item; } + if (cannot_access_at_index(input_buffer, 1)) + { + ...
good
review_fixed
c
DaveGamble/cJSON
c39043866aaef2e599045b2c04936b247f84d82d
@@ -2726,7 +2726,14 @@ CJSON_PUBLIC(cJSON *) cJSON_CreateStringArray(const char *const *strings, int co } /* Duplication */ +cJSON * cJSON_Duplicate_rec(const cJSON *item, size_t depth, cJSON_bool recurse); + CJSON_PUBLIC(cJSON *) cJSON_Duplicate(const cJSON *item, cJSON_bool recurse) +{ + return cJSON_Duplicat...
bad
review
c
DaveGamble/cJSON
45254798a63610837c2352e9c4ac93d4d09cc299
diff --git a/cJSON.c b/cJSON.c index cac1164b..f17a68dd 100644 --- a/cJSON.c +++ b/cJSON.c @@ -2726,7 +2726,14 @@ CJSON_PUBLIC(cJSON *) cJSON_CreateStringArray(const char *const *strings, int co } /* Duplication */ +cJSON * cJSON_Duplicate_rec(const cJSON *item, size_t depth, cJSON_bool recurse); + CJSON_PUBLIC(cJ...
good
review_fixed
c
DaveGamble/cJSON
45254798a63610837c2352e9c4ac93d4d09cc299
@@ -2204,7 +2204,7 @@ CJSON_PUBLIC(cJSON*) cJSON_AddArrayToObject(cJSON * const object, const char * c CJSON_PUBLIC(cJSON *) cJSON_DetachItemViaPointer(cJSON *parent, cJSON * const item) { - if ((parent == NULL) || (item == NULL)) + if ((parent == NULL) || (parent->child == NULL) || (item == NULL) || (item->p...
bad
review
c
DaveGamble/cJSON
81b36279faf0143f99150974fca7cfc534e1798b
diff --git a/cJSON.c b/cJSON.c index cac1164b8..fe22bd83c 100644 --- a/cJSON.c +++ b/cJSON.c @@ -2204,7 +2204,7 @@ CJSON_PUBLIC(cJSON*) cJSON_AddArrayToObject(cJSON * const object, const char * c CJSON_PUBLIC(cJSON *) cJSON_DetachItemViaPointer(cJSON *parent, cJSON * const item) { - if ((parent == NULL) || (item...
good
review_fixed
c
DaveGamble/cJSON
81b36279faf0143f99150974fca7cfc534e1798b
@@ -650,6 +650,63 @@ static void cjson_set_valuestring_to_object_should_not_leak_memory(void) cJSON_Delete(root); } +static void cjson_set_bool_value_must_not_break_objects(void) +{ + cJSON *bobj, *sobj,*oobj,*refobj=NULL; + + TEST_ASSERT_TRUE((cJSON_SetBoolValue(refobj,1)==cJSON_Invalid)); + + bobj=cJ...
bad
review
c
DaveGamble/cJSON
674ab26d3eacb4a3072f17283463b8e401b59b75
diff --git a/tests/misc_tests.c b/tests/misc_tests.c index 3bf0a1cc1..19b7c8533 100644 --- a/tests/misc_tests.c +++ b/tests/misc_tests.c @@ -28,7 +28,6 @@ #include "unity/src/unity.h" #include "common.h" - static void cjson_array_foreach_should_loop_over_arrays(void) { cJSON array[1]; @@ -77,7 +76,6 @@ stati...
good
review_fixed
c
DaveGamble/cJSON
674ab26d3eacb4a3072f17283463b8e401b59b75
@@ -198,7 +198,7 @@ The type can be one of the following: * `cJSON_NULL` (check with `cJSON_IsNull`): Represents a `null` value. * `cJSON_Number` (check with `cJSON_IsNumber`): Represents a number value. The value is stored as a double in `valuedouble` and also in `valueint`. If the number is outside of the range of ...
bad
review
DaveGamble/cJSON
f1494a85204a09d39492440d63b358f4bdf51bd4
diff --git a/README.md b/README.md index 0ea89da57..ebd32c4b9 100644 --- a/README.md +++ b/README.md @@ -407,7 +407,7 @@ end: } ``` -Alternatively we can use the `cJSON_Add...ToObject` helper functions to make our lifes a little easier: +Alternatively we can use the `cJSON_Add...ToObject` helper functions to make o...
good
review_fixed
DaveGamble/cJSON
f1494a85204a09d39492440d63b358f4bdf51bd4
@@ -0,0 +1,59 @@ +name: Bug Report +description: File a bug report to help us improve +title: "[Bug]: " +labels: ["bug"] +body: + - type: textarea + id: description + attributes: + label: Describe the bug + description: A clear and concise description of what the bug is + placeholder: Tell us what...
bad
review
DenverCoder1/readme-typing-svg
2394d779099e9c36e37112d0e7a4d74551e92628
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 00000000..6b5ca102 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,68 @@ +name: Bug Report +description: File a bug report to help us improve +title: "[Bug]: " +labels: ["bug"] +bod...
good
review_fixed
DenverCoder1/readme-typing-svg
2394d779099e9c36e37112d0e7a4d74551e92628
@@ -0,0 +1,59 @@ +name: Bug Report +description: File a bug report to help us improve +title: "[Bug]: " +labels: ["bug"] +body: + - type: textarea + id: description + attributes: + label: Describe the bug + description: A clear and concise description of what the bug is + placeholder: Tell us what...
bad
review
DenverCoder1/readme-typing-svg
2394d779099e9c36e37112d0e7a4d74551e92628
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 00000000..6b5ca102 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,68 @@ +name: Bug Report +description: File a bug report to help us improve +title: "[Bug]: " +labels: ["bug"] +bod...
good
review_fixed
DenverCoder1/readme-typing-svg
2394d779099e9c36e37112d0e7a4d74551e92628
@@ -70,6 +70,9 @@ function gtag() { <label for="size">Font size</label> <input class="param" type="number" id="size" name="size" alt="Font size" placeholder="20" value="20"> + <label for="letterSpacing">Font letter spacing</label>
bad
review
php
DenverCoder1/readme-typing-svg
9b2659b49add3d11827dae74dd5e41a2642f06c7
diff --git a/src/demo/index.php b/src/demo/index.php index 5c9184ca..657e03e4 100644 --- a/src/demo/index.php +++ b/src/demo/index.php @@ -70,6 +70,17 @@ function gtag() { <label for="size">Font size</label> <input class="param" type="number" id="size" name="size" alt="Font size" place...
good
review_fixed
php
DenverCoder1/readme-typing-svg
9b2659b49add3d11827dae74dd5e41a2642f06c7
@@ -207,3 +208,5 @@ Made with ❤️ and PHP <!-- markdownlint-enable MD033 --> This project uses [Twemoji](https://github.com/twitter/twemoji), published under the [CC-BY 4.0 License](https://creativecommons.org/licenses/by/4.0/) + +
bad
review
DenverCoder1/readme-typing-svg
f6b386e2ce374fcb27a4cea051f4f8bea508b43e
diff --git a/README.md b/README.md index 3de96a2f..a729164e 100644 --- a/README.md +++ b/README.md @@ -131,6 +131,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Rohit](https://github.com/EngineerRohit01.png?size=60)](https://github.com/EngineerRohit01 "Rohit on GitHub") [![Sandeep...
good
review_fixed
DenverCoder1/readme-typing-svg
f6b386e2ce374fcb27a4cea051f4f8bea508b43e
@@ -131,6 +131,8 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Rohit](https://github.com/EngineerRohit01.png?size=60)](https://github.com/EngineerRohit01 "Rohit on GitHub") [![Sandeep Prasad](https://github.com/Sandeep-Petwal.png?size=60)](https://github.com/sandeep-Petwal "Sandeep...
bad
review
DenverCoder1/readme-typing-svg
58a567b7cb3fed35d9a4dfd80df7e027ca676c3e
diff --git a/README.md b/README.md index c3f039ae..fe1d2eb3 100644 --- a/README.md +++ b/README.md @@ -131,6 +131,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Rohit](https://github.com/EngineerRohit01.png?size=60)](https://github.com/EngineerRohit01 "Rohit on GitHub") [![Sandeep...
good
review_fixed
DenverCoder1/readme-typing-svg
58a567b7cb3fed35d9a4dfd80df7e027ca676c3e
@@ -129,6 +129,8 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Sarthak Krishak](https://github.com/SarthakKrishak.png?size=60)](https://github.com/SarthakKrishak "Sarthak Krishak on GitHub") [![Austin Musuya](https://github.com/AustinMusuya.png?size=60)](https://github.com/AustinMu...
bad
review
DenverCoder1/readme-typing-svg
92c94f0d29fad1fd52f4d615ac5b1c7b46b633a2
diff --git a/README.md b/README.md index 4b49c137..6a9901c0 100644 --- a/README.md +++ b/README.md @@ -129,6 +129,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Sarthak Krishak](https://github.com/SarthakKrishak.png?size=60)](https://github.com/SarthakKrishak "Sarthak Krishak on Gi...
good
review_fixed
DenverCoder1/readme-typing-svg
92c94f0d29fad1fd52f4d615ac5b1c7b46b633a2
@@ -126,6 +126,8 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 "Soham More on GitHub") [![Yogi Hariyani](https://github.com/yobro7292.png?size=60)](https://github.com/Yobro7292 "Yogi Hariyani ...
bad
review
DenverCoder1/readme-typing-svg
1d513bdb2333b26597e70a0409dc9bc68f60330c
diff --git a/README.md b/README.md index b1ece5f9..21faf8e4 100644 --- a/README.md +++ b/README.md @@ -126,6 +126,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 "Soham More on GitHub") [![Yog...
good
review_fixed
DenverCoder1/readme-typing-svg
1d513bdb2333b26597e70a0409dc9bc68f60330c
@@ -39,6 +39,7 @@ Here you can easily customize your Typing SVG with a live preview. Below are links to profiles where you can see Readme Typing SVGs in action! +
bad
review
DenverCoder1/readme-typing-svg
5ec1c15965fe369f973f8cdaf85c7adea470d7b7
diff --git a/README.md b/README.md index 72a6c0b1..c9f73419 100644 --- a/README.md +++ b/README.md @@ -123,6 +123,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![amir78729](https://github.com/amir78729.png?size=60)](https://github.com/amir78729 "Amir on Github") [![AJsuper007](http...
good
review_fixed
DenverCoder1/readme-typing-svg
5ec1c15965fe369f973f8cdaf85c7adea470d7b7
@@ -123,6 +124,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![amir78729](https://github.com/amir78729.png?size=60)](https://github.com/amir78729 "Amir on Github") [![AJsuper007](https://github.com/AJsuper007.png?size=60)](https://github.com/AJsuper007 "AJsuper007 on Github") [![A...
bad
review
DenverCoder1/readme-typing-svg
5ec1c15965fe369f973f8cdaf85c7adea470d7b7
diff --git a/README.md b/README.md index 72a6c0b1..c9f73419 100644 --- a/README.md +++ b/README.md @@ -123,6 +123,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![amir78729](https://github.com/amir78729.png?size=60)](https://github.com/amir78729 "Amir on Github") [![AJsuper007](http...
good
review_fixed
DenverCoder1/readme-typing-svg
5ec1c15965fe369f973f8cdaf85c7adea470d7b7
@@ -7,6 +7,11 @@ internal sealed class BlazorWebView : WebView { private readonly BlazorWebViewBridge _bridge; + static BlazorWebView() + { + WebKit.Module.Initialize();
bad
review
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs index 95b8707655..20a76b6c60 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs +++ b...
good
review_fixed
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
@@ -6,7 +8,7 @@ internal record BlazorWebViewOptions internal string HostPath { get; init; } = Path.Combine("wwwroot", "index.html"); - internal string ContentRoot => Path.GetDirectoryName(Path.GetFullPath(HostPath))!; + internal string ContentRoot { get; init; } = Path.GetDirectoryName(Assembly.GetEntry...
bad
review
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebViewOptions.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebViewOptions.cs index 4cabf579c2..91c59c51ef 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWe...
good
review_fixed
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
@@ -6,16 +6,8 @@ namespace DevToys.Linux.Core; [Export(typeof(IFileStorage))] -internal sealed class FileStorage : GObject.Object, IFileStorage +internal sealed class FileStorage : IFileStorage { - [ImportingConstructor] - public FileStorage() - : base( - Gtk.Internal.FileDialog.New(),
bad
review
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs index 8240f755d5..155d744c79 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs +++ b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs @...
good
review_fixed
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
@@ -69,47 +61,39 @@ public FileStream OpenWriteFile(string relativeOrAbsoluteFilePath, bool replaceI public async ValueTask<string?> PickFolderAsync() { Guard.IsNotNull(MainWindow); - var tcs = new TaskCompletionSource<Gio.File?>(); - var callbackHandler = new Gio.Internal.AsyncReadyC...
bad
review
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs index 8240f755d5..155d744c79 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs +++ b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs @...
good
review_fixed
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
@@ -126,20 +140,14 @@ private bool GetBestValueForCompactMode() private void UpdateSystemSettingsAndApplyTheme() { - IsHighContrast = false; // TODO: Detect high contrast + IsHighContrast = _adwStyleManager.HighContrast;
bad
review
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs index 37a3f50521..6254d54c96 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs +++ b/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListe...
good
review_fixed
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
@@ -10,49 +10,48 @@ namespace DevToys.MacOS.Controls.BlazorWebView; // TODO: Credit MAUI repository internal sealed partial class BlazorWkWebView : IDisposable { + private const string DevToysInteropName = "devtoyswebinterop";
bad
review
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs b/src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs index b7ca9e3d2f..0327387231 100644 --- a/src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs +++ b...
good
review_fixed
csharp
DevToys-app/DevToys
1b0d121267ca092135ab63956974acbe322ae365
@@ -178,6 +180,54 @@ private Task OnMonacoEditorInitializedAsync() return Task.CompletedTask; } + private async Task OnMonacoEditorPositionChanged(CursorPositionChangedEvent cursorPosition) + { + if (UIMultiLineTextInput.Tooltips.Count == 0) + { + return; + } + + ...
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs b/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs index cd3f1df02e..d4b3a02f2d 100644 --- a/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -0,0 +1,14 @@ +namespace DevToys.Api; + +public record UIHoverTooltip +{ + public string Word { get; }
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Api/Tool/GUI/Components/UIHoverTooltip.cs b/src/app/dev/DevToys.Api/Tool/GUI/Components/UIHoverTooltip.cs new file mode 100644 index 0000000000..c0030d5127 --- /dev/null +++ b/src/app/dev/DevToys.Api/Tool/GUI/Components/UIHoverTooltip.cs @@ -0,0 +1,26 @@ +namespace DevToys.Api; + +/// ...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -122,6 +134,7 @@ internal set } } + public event EventHandler? HoverTooltipChanged;
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIMultiLineTextInput.cs b/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIMultiLineTextInput.cs index b0e7a866a3..af901b647d 100644 --- a/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIMultiLineTextInput.cs +++ b/src/app/dev/DevToys.Api/Tool/GUI/Components/IUIMul...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -178,6 +180,54 @@ private Task OnMonacoEditorInitializedAsync() return Task.CompletedTask; } + private async Task OnMonacoEditorPositionChanged(CursorPositionChangedEvent cursorPosition) + { + if (UIMultiLineTextInput.Tooltips.Count == 0) + { + return; + } + + ...
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs b/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs index cd3f1df02e..d4b3a02f2d 100644 --- a/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -398,6 +407,9 @@ </ItemGroup> <ItemGroup> + <PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" /> + <PackageReference Include="Newtonsoft.Json" />
bad
review
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Tools/DevToys.Tools.csproj b/src/app/dev/DevToys.Tools/DevToys.Tools.csproj index a04aae9f2c..4d25145f90 100644 --- a/src/app/dev/DevToys.Tools/DevToys.Tools.csproj +++ b/src/app/dev/DevToys.Tools/DevToys.Tools.csproj @@ -53,6 +53,11 @@ <AutoGen>True</AutoGen> <DependentUp...
good
review_fixed
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -0,0 +1,14 @@ +namespace DevToys.Api; + +public record UIHoverTooltip
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Api/Tool/GUI/Components/UIHoverTooltip.cs b/src/app/dev/DevToys.Api/Tool/GUI/Components/UIHoverTooltip.cs new file mode 100644 index 0000000000..c0030d5127 --- /dev/null +++ b/src/app/dev/DevToys.Api/Tool/GUI/Components/UIHoverTooltip.cs @@ -0,0 +1,26 @@ +namespace DevToys.Api; + +/// ...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -1,18 +1,89 @@ -namespace DevToys.Api; +using static System.Runtime.InteropServices.JavaScript.JSType; + +namespace DevToys.Api; /// <summary> /// Record to contain both whether the task was a success and the resulting data /// </summary> /// <typeparam name="T">Type of the result</typeparam> -/// <param nam...
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Api/Core/ResultInfo.cs b/src/app/dev/DevToys.Api/Core/ResultInfo.cs index a6e02d45e6..88ca765d56 100644 --- a/src/app/dev/DevToys.Api/Core/ResultInfo.cs +++ b/src/app/dev/DevToys.Api/Core/ResultInfo.cs @@ -1,18 +1,107 @@ -namespace DevToys.Api; +using static System.Runtime.InteropServ...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -0,0 +1,605 @@ +using DevToys.Tools.Helpers; +using DevToys.Tools.Helpers.JsonWebToken; +using DevToys.Tools.Models; +using Microsoft.Extensions.Logging; + +namespace DevToys.Tools.Tools.EncodersDecoders.JsonWebToken; + +internal sealed partial class JsonWebTokenEncoderGuiTool +{ + /// <summary> + /// Define ...
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/JsonWebToken/JsonWebTokenEncoderGuiTool.cs b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/JsonWebToken/JsonWebTokenEncoderGuiTool.cs new file mode 100644 index 0000000000..88c2f1781e --- /dev/null +++ b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/Js...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
@@ -0,0 +1,593 @@ +using DevToys.Tools.Helpers.JsonWebToken; +using DevToys.Tools.Models; +using Microsoft.Extensions.Logging; + +namespace DevToys.Tools.Tools.EncodersDecoders.JsonWebToken; + +internal sealed partial class JsonWebTokenDecoderGuiTool +{ + /// <summary> + /// Define if we want to validate the tok...
bad
review
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/JsonWebToken/JsonWebTokenDecoderGuiTool.cs b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/JsonWebToken/JsonWebTokenDecoderGuiTool.cs new file mode 100644 index 0000000000..d57b4d6116 --- /dev/null +++ b/src/app/dev/DevToys.Tools/Tools/EncodersDecoders/Js...
good
review_fixed
csharp
DevToys-app/DevToys
15a7b7f4a9dc709a680c03a7be268b87e1079214