text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -0,0 +1,97 @@ +# SPO 🤖 | Self-Supervised Prompt Optimizer + +An automated prompt engineering tool for Large Language Models (LLMs), designed for universal domain adaptation. + +A next-generation prompt engineering system implementing **Self-Supervised Prompt Optimization (SPO)**. Achieves state-of-the-art performan...
bad
review
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
diff --git a/examples/spo/README.md b/examples/spo/README.md new file mode 100644 index 0000000000..08ed6f804d --- /dev/null +++ b/examples/spo/README.md @@ -0,0 +1,184 @@ +# SPO | Self-Supervised Prompt Optimization <img src="../../docs/resources/spo/SPO-logo.png" width="60" height="60" style="vertical-align: middle; ...
good
review_fixed
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
@@ -0,0 +1,180 @@ +# SPO | Self-Supervised Prompt Optimization <img src="../../docs/resources/spo/SPO-logo.png" width="60" height="60" style="vertical-align: middle; margin-left: 10px; position: relative; top: -5px;"> + + +An automated prompt engineering tool for Large Language Models (LLMs), designed for universal dom...
bad
review
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
diff --git a/examples/spo/README.md b/examples/spo/README.md new file mode 100644 index 0000000000..08ed6f804d --- /dev/null +++ b/examples/spo/README.md @@ -0,0 +1,184 @@ +# SPO | Self-Supervised Prompt Optimization <img src="../../docs/resources/spo/SPO-logo.png" width="60" height="60" style="vertical-align: middle; ...
good
review_fixed
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
@@ -0,0 +1,233 @@ +import sys +from pathlib import Path + +import streamlit as st +import yaml +from loguru import logger as _logger + +sys.path.append(str(Path(__file__).parents[3]))
bad
review
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
diff --git a/metagpt/ext/spo/app.py b/metagpt/ext/spo/app.py new file mode 100644 index 0000000000..963775be4e --- /dev/null +++ b/metagpt/ext/spo/app.py @@ -0,0 +1,283 @@ +import asyncio +from pathlib import Path +from typing import Dict + +import streamlit as st +import yaml +from loguru import logger as _logger + +f...
good
review_fixed
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
@@ -0,0 +1,233 @@ +import sys +from pathlib import Path + +import streamlit as st +import yaml +from loguru import logger as _logger + +sys.path.append(str(Path(__file__).parents[3])) + +from metagpt.const import METAGPT_ROOT # noqa: E402 +from metagpt.ext.spo.components.optimizer import PromptOptimizer # noqa: E402 ...
bad
review
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
diff --git a/metagpt/ext/spo/app.py b/metagpt/ext/spo/app.py new file mode 100644 index 0000000000..963775be4e --- /dev/null +++ b/metagpt/ext/spo/app.py @@ -0,0 +1,283 @@ +import asyncio +from pathlib import Path +from typing import Dict + +import streamlit as st +import yaml +from loguru import logger as _logger + +f...
good
review_fixed
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
@@ -0,0 +1,82 @@ +# -*- coding: utf-8 -*- +# @Date : 8/23/2024 10:00 AM +# @Author : all +# @Desc : Evaluation for different datasets +import asyncio +import random +from typing import Any, Dict + +from metagpt.ext.spo.prompts.evaluate_prompt import EVALUATE_PROMPT +from metagpt.ext.spo.utils import load +from m...
bad
review
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
diff --git a/metagpt/ext/spo/components/evaluator.py b/metagpt/ext/spo/components/evaluator.py new file mode 100644 index 0000000000..952ef211ba --- /dev/null +++ b/metagpt/ext/spo/components/evaluator.py @@ -0,0 +1,75 @@ +# -*- coding: utf-8 -*- +# @Date : 8/23/2024 10:00 AM +# @Author : all +# @Desc : Evaluati...
good
review_fixed
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
@@ -0,0 +1,48 @@ +import os
bad
review
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
diff --git a/metagpt/ext/spo/utils/load.py b/metagpt/ext/spo/utils/load.py new file mode 100644 index 0000000000..f8c4f53fce --- /dev/null +++ b/metagpt/ext/spo/utils/load.py @@ -0,0 +1,48 @@ +import random +from pathlib import Path + +import yaml + +FILE_NAME = "" +SAMPLE_K = 3 + + +def set_file_name(name: str): + ...
good
review_fixed
python
FoundationAgents/MetaGPT
62dda60c126481ff8e0ea35ddbbd90eb6046179f
@@ -92,27 +91,33 @@ def add_output_to_cell(self, cell: NotebookNode, output: str): else: cell["outputs"].append(new_output(output_type="stream", name="stdout", text=str(output))) - def parse_outputs(self, outputs: list[str]) -> str: + def parse_outputs(self, outputs: list[str], keep_len: i...
bad
review
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
diff --git a/metagpt/actions/mi/execute_nb_code.py b/metagpt/actions/mi/execute_nb_code.py index 3a64a8bec1..f6a8defbde 100644 --- a/metagpt/actions/mi/execute_nb_code.py +++ b/metagpt/actions/mi/execute_nb_code.py @@ -9,7 +9,6 @@ import asyncio import base64 import re -import traceback from typing import Literal, ...
good
review_fixed
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
@@ -92,27 +91,33 @@ def add_output_to_cell(self, cell: NotebookNode, output: str): else: cell["outputs"].append(new_output(output_type="stream", name="stdout", text=str(output))) - def parse_outputs(self, outputs: list[str]) -> str: + def parse_outputs(self, outputs: list[str], keep_len: i...
bad
review
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
diff --git a/metagpt/actions/mi/execute_nb_code.py b/metagpt/actions/mi/execute_nb_code.py index 3a64a8bec1..f6a8defbde 100644 --- a/metagpt/actions/mi/execute_nb_code.py +++ b/metagpt/actions/mi/execute_nb_code.py @@ -9,7 +9,6 @@ import asyncio import base64 import re -import traceback from typing import Literal, ...
good
review_fixed
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
@@ -92,27 +91,46 @@ def add_output_to_cell(self, cell: NotebookNode, output: str): else: cell["outputs"].append(new_output(output_type="stream", name="stdout", text=str(output))) - def parse_outputs(self, outputs: list[str]) -> str: + def parse_outputs(self, outputs: list[str], keep_len: i...
bad
review
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
diff --git a/metagpt/actions/mi/execute_nb_code.py b/metagpt/actions/mi/execute_nb_code.py index 3a64a8bec1..f6a8defbde 100644 --- a/metagpt/actions/mi/execute_nb_code.py +++ b/metagpt/actions/mi/execute_nb_code.py @@ -9,7 +9,6 @@ import asyncio import base64 import re -import traceback from typing import Literal, ...
good
review_fixed
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
@@ -92,27 +91,46 @@ def add_output_to_cell(self, cell: NotebookNode, output: str): else: cell["outputs"].append(new_output(output_type="stream", name="stdout", text=str(output))) - def parse_outputs(self, outputs: list[str]) -> str: + def parse_outputs(self, outputs: list[str], keep_len: i...
bad
review
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
diff --git a/metagpt/actions/mi/execute_nb_code.py b/metagpt/actions/mi/execute_nb_code.py index 3a64a8bec1..f6a8defbde 100644 --- a/metagpt/actions/mi/execute_nb_code.py +++ b/metagpt/actions/mi/execute_nb_code.py @@ -9,7 +9,6 @@ import asyncio import base64 import re -import traceback from typing import Literal, ...
good
review_fixed
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
@@ -92,27 +91,46 @@ def add_output_to_cell(self, cell: NotebookNode, output: str): else: cell["outputs"].append(new_output(output_type="stream", name="stdout", text=str(output))) - def parse_outputs(self, outputs: list[str]) -> str: + def parse_outputs(self, outputs: list[str], keep_len: i...
bad
review
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
diff --git a/metagpt/actions/mi/execute_nb_code.py b/metagpt/actions/mi/execute_nb_code.py index 3a64a8bec1..f6a8defbde 100644 --- a/metagpt/actions/mi/execute_nb_code.py +++ b/metagpt/actions/mi/execute_nb_code.py @@ -9,7 +9,6 @@ import asyncio import base64 import re -import traceback from typing import Literal, ...
good
review_fixed
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
@@ -157,7 +175,7 @@ async def run_cell(self, cell: NotebookNode, cell_index: int) -> Tuple[bool, str await self.reset() return False, "DeadKernelError" except Exception: - return False, f"{traceback.format_exc()}" + return False, ""
bad
review
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
diff --git a/metagpt/actions/mi/execute_nb_code.py b/metagpt/actions/mi/execute_nb_code.py index 3a64a8bec1..f6a8defbde 100644 --- a/metagpt/actions/mi/execute_nb_code.py +++ b/metagpt/actions/mi/execute_nb_code.py @@ -9,7 +9,6 @@ import asyncio import base64 import re -import traceback from typing import Literal, ...
good
review_fixed
python
FoundationAgents/MetaGPT
980851136fb1e63dc6bd04c33046f68f167b4b6f
@@ -3,10 +3,36 @@ from metagpt.roles.mi.interpreter import Interpreter -async def main(auto_run: bool = True): - requirement = "Run data analysis on sklearn Wine recognition dataset, include a plot, and train a model to predict wine class (20% as validation), and show validation accuracy." +DATA_DIR = "examples...
bad
review
python
FoundationAgents/MetaGPT
041a2d61097bad45b5b7e28a880b37268a285c5a
diff --git a/examples/mi/machine_learning.py b/examples/mi/machine_learning.py index a8ab5051e0..56c68f69ee 100644 --- a/examples/mi/machine_learning.py +++ b/examples/mi/machine_learning.py @@ -2,10 +2,20 @@ from metagpt.roles.mi.interpreter import Interpreter +WINE_REQ = "Run data analysis on sklearn Wine recogn...
good
review_fixed
python
FoundationAgents/MetaGPT
041a2d61097bad45b5b7e28a880b37268a285c5a
@@ -2,11 +2,37 @@ from metagpt.roles.mi.interpreter import Interpreter +DATA_DIR = "examples/mi/data" +WINE_REQ = "Run data analysis on sklearn Wine recognition dataset, include a plot, and train a model to predict wine class (20% as validation), and show validation accuracy." -async def main(auto_run: bool = Tr...
bad
review
python
FoundationAgents/MetaGPT
041a2d61097bad45b5b7e28a880b37268a285c5a
diff --git a/examples/mi/machine_learning.py b/examples/mi/machine_learning.py index a8ab5051e0..56c68f69ee 100644 --- a/examples/mi/machine_learning.py +++ b/examples/mi/machine_learning.py @@ -2,10 +2,20 @@ from metagpt.roles.mi.interpreter import Interpreter +WINE_REQ = "Run data analysis on sklearn Wine recogn...
good
review_fixed
python
FoundationAgents/MetaGPT
041a2d61097bad45b5b7e28a880b37268a285c5a
@@ -226,22 +226,24 @@ def display_markdown(content: str): matches = re.finditer(r"```(.+?)```", content, re.DOTALL) start_index = 0 content_panels = [] + # 文本背景色和文字颜色设置
bad
review
python
FoundationAgents/MetaGPT
e1eb69b07d4cec1b3714279d3fe866f397f7109a
diff --git a/metagpt/actions/mi/execute_nb_code.py b/metagpt/actions/mi/execute_nb_code.py index a8c9c30859..8e8e997b83 100644 --- a/metagpt/actions/mi/execute_nb_code.py +++ b/metagpt/actions/mi/execute_nb_code.py @@ -215,35 +215,38 @@ def truncate(result: str, keep_len: int = 2000, is_success: bool = True): def ...
good
review_fixed
python
FoundationAgents/MetaGPT
e1eb69b07d4cec1b3714279d3fe866f397f7109a
@@ -192,3 +192,6 @@ cov.xml *.csv metagpt/ext/sela/results/* .chainlit/ + +metagpt/ext/aflow/data +metagpt/ext/aflow/scripts
bad
review
FoundationAgents/MetaGPT
5eb6098e08d81ef9292eef48f0e192d5dd9ffe23
diff --git a/.gitignore b/.gitignore index e3f7c5e868..8413064296 100644 --- a/.gitignore +++ b/.gitignore @@ -192,3 +192,6 @@ cov.xml *.csv metagpt/ext/sela/results/* .chainlit/ + +metagpt/ext/aflow/data +metagpt/ext/aflow/scripts/optimized
good
review_fixed
FoundationAgents/MetaGPT
5eb6098e08d81ef9292eef48f0e192d5dd9ffe23
@@ -0,0 +1,118 @@ +import httpx + +from a2a.server.apps import A2AStarletteApplication +from a2a.server.request_handlers import DefaultRequestHandler +from a2a.server.tasks import InMemoryTaskStore, InMemoryPushNotifier +from a2a.types import ( + AgentCapabilities, + AgentCard, + AgentSkill, +) + +from .agent_...
bad
review
python
FoundationAgents/OpenManus
c37a145edccb1fd8e440378c3eef6b0da5773d90
diff --git a/protocol/a2a/app/main.py b/protocol/a2a/app/main.py new file mode 100644 index 000000000..dd09f23d3 --- /dev/null +++ b/protocol/a2a/app/main.py @@ -0,0 +1,134 @@ +import httpx +import argparse + +from a2a.server.apps import A2AStarletteApplication +from a2a.server.request_handlers import DefaultRequestHan...
good
review_fixed
python
FoundationAgents/OpenManus
c37a145edccb1fd8e440378c3eef6b0da5773d90
@@ -0,0 +1,230 @@ +import subprocess +import json +import threading +import base64 +import pandas as pd +import aiofiles +import os +from typing import Any, Dict, Hashable +from app.tool.base import BaseTool +from app.config import config + + +def extract_executable_code(code_str: str) -> str: + """ + Extract exe...
bad
review
python
FoundationAgents/OpenManus
14bf016134c47d696263966597e450f93e781cb3
diff --git a/app/tool/chart_visualization/chart_visualization.py b/app/tool/chart_visualization/chart_visualization.py new file mode 100644 index 000000000..8905c0580 --- /dev/null +++ b/app/tool/chart_visualization/chart_visualization.py @@ -0,0 +1,117 @@ +import subprocess +import json +import base64 +import pandas a...
good
review_fixed
python
FoundationAgents/OpenManus
14bf016134c47d696263966597e450f93e781cb3
@@ -0,0 +1,230 @@ +import subprocess +import json +import threading +import base64 +import pandas as pd +import aiofiles +import os +from typing import Any, Dict, Hashable +from app.tool.base import BaseTool +from app.config import config + + +def extract_executable_code(code_str: str) -> str: + """ + Extract exe...
bad
review
python
FoundationAgents/OpenManus
14bf016134c47d696263966597e450f93e781cb3
diff --git a/app/tool/chart_visualization/chart_visualization.py b/app/tool/chart_visualization/chart_visualization.py new file mode 100644 index 000000000..8905c0580 --- /dev/null +++ b/app/tool/chart_visualization/chart_visualization.py @@ -0,0 +1,117 @@ +import subprocess +import json +import base64 +import pandas a...
good
review_fixed
python
FoundationAgents/OpenManus
14bf016134c47d696263966597e450f93e781cb3
@@ -0,0 +1,230 @@ +import subprocess +import json +import threading +import base64 +import pandas as pd +import aiofiles +import os +from typing import Any, Dict, Hashable +from app.tool.base import BaseTool +from app.config import config + + +def extract_executable_code(code_str: str) -> str: + """ + Extract exe...
bad
review
python
FoundationAgents/OpenManus
14bf016134c47d696263966597e450f93e781cb3
diff --git a/app/tool/chart_visualization/chart_visualization.py b/app/tool/chart_visualization/chart_visualization.py new file mode 100644 index 000000000..8905c0580 --- /dev/null +++ b/app/tool/chart_visualization/chart_visualization.py @@ -0,0 +1,117 @@ +import subprocess +import json +import base64 +import pandas a...
good
review_fixed
python
FoundationAgents/OpenManus
14bf016134c47d696263966597e450f93e781cb3
@@ -32,11 +32,15 @@ * * @return 0 on success, otherwise a Win32 error code */ -UINT rdpgfx_read_header(wLog* log, wStream* s, RDPGFX_HEADER* header) +UINT rdpgfx_read_header(wLog* log, wStream* s, RDPGFX_HEADER* header, + size_t* pRemainingHeaderLength)
bad
review
c
FreeRDP/FreeRDP
2b81c4663f43914a82cce56dd91ab9ebfbecc653
diff --git a/channels/rdpgfx/rdpgfx_common.c b/channels/rdpgfx/rdpgfx_common.c index 12a4e42cf3ec..480d0419ecbc 100644 --- a/channels/rdpgfx/rdpgfx_common.c +++ b/channels/rdpgfx/rdpgfx_common.c @@ -32,11 +32,14 @@ * * @return 0 on success, otherwise a Win32 error code */ -UINT rdpgfx_read_header(wLog* log, wStre...
good
review_fixed
c
FreeRDP/FreeRDP
2b81c4663f43914a82cce56dd91ab9ebfbecc653
@@ -2071,14 +2071,14 @@ static UINT rdpgfx_recv_pdu(GENERIC_CHANNEL_CALLBACK* callback, wStream* s) WINPR_ASSERT(gfx); - UINT error = rdpgfx_read_header(gfx->base.log, s, &header); + size_t rheaderlen = 0;
bad
review
c
FreeRDP/FreeRDP
2b81c4663f43914a82cce56dd91ab9ebfbecc653
diff --git a/channels/rdpgfx/client/rdpgfx_main.c b/channels/rdpgfx/client/rdpgfx_main.c index 642f7baddb5c..bb2c145bfea7 100644 --- a/channels/rdpgfx/client/rdpgfx_main.c +++ b/channels/rdpgfx/client/rdpgfx_main.c @@ -2071,14 +2071,14 @@ static UINT rdpgfx_recv_pdu(GENERIC_CHANNEL_CALLBACK* callback, wStream* s) W...
good
review_fixed
c
FreeRDP/FreeRDP
2b81c4663f43914a82cce56dd91ab9ebfbecc653
@@ -237,6 +250,34 @@ static BOOL wf_pre_connect(freerdp* instance) rdpContext* context = instance->context; wfContext* wfc = (wfContext*)instance->context; rdpSettings* settings = context->settings; + + /* Runs after freerdp_client_settings_parse_command_line: when /from-stdin + * is set, route auth through the ...
bad
review
c
FreeRDP/FreeRDP
9e409d199023813a89f317e717b8ae43783a6298
diff --git a/client/Windows/wf_client.c b/client/Windows/wf_client.c index 346fea56c568..97f69175fdf7 100644 --- a/client/Windows/wf_client.c +++ b/client/Windows/wf_client.c @@ -52,6 +52,7 @@ #include <freerdp/locale/locale.h> #include <freerdp/locale/keyboard.h> #include <freerdp/codec/region.h> +#include <freerdp...
good
review_fixed
c
FreeRDP/FreeRDP
9e409d199023813a89f317e717b8ae43783a6298
@@ -982,6 +993,11 @@ static DWORD wf_verify_changed_certificate_ex(freerdp* instance, const char* hos WCHAR* caption; int what = IDCANCEL; + if (freerdp_settings_get_bool(instance->context->settings, FreeRDP_CredentialsFromStdin))
bad
review
c
FreeRDP/FreeRDP
9e409d199023813a89f317e717b8ae43783a6298
diff --git a/client/Windows/wf_client.c b/client/Windows/wf_client.c index 346fea56c568..97f69175fdf7 100644 --- a/client/Windows/wf_client.c +++ b/client/Windows/wf_client.c @@ -52,6 +52,7 @@ #include <freerdp/locale/locale.h> #include <freerdp/locale/keyboard.h> #include <freerdp/codec/region.h> +#include <freerdp...
good
review_fixed
c
FreeRDP/FreeRDP
9e409d199023813a89f317e717b8ae43783a6298
@@ -1030,6 +1046,10 @@ static DWORD wf_verify_changed_certificate_ex(freerdp* instance, const char* hos static BOOL wf_present_gateway_message(freerdp* instance, UINT32 type, BOOL isDisplayMandatory, BOOL isConsentMandatory, size_t length, const WCHAR* message) { + if (freerdp_...
bad
review
c
FreeRDP/FreeRDP
9e409d199023813a89f317e717b8ae43783a6298
diff --git a/client/Windows/wf_client.c b/client/Windows/wf_client.c index 346fea56c568..97f69175fdf7 100644 --- a/client/Windows/wf_client.c +++ b/client/Windows/wf_client.c @@ -52,6 +52,7 @@ #include <freerdp/locale/locale.h> #include <freerdp/locale/keyboard.h> #include <freerdp/codec/region.h> +#include <freerdp...
good
review_fixed
c
FreeRDP/FreeRDP
9e409d199023813a89f317e717b8ae43783a6298
@@ -297,8 +297,10 @@ private void hideSystemBars() { super.onWindowFocusChanged(hasFocus); if (hasFocus) + { hideSystemBars(); - mClipboardManager.getPrimaryClipManually(); + mClipboardManager.getPrimaryClipManually();
bad
review
java
FreeRDP/FreeRDP
ee004a0733c898ebbca35148bc2a306052ea99d4
diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java index 80353e9c1972..479b52a80c1f 100644 --- a/client/Android/Studio/freeRDPCore/src/main/java...
good
review_fixed
java
FreeRDP/FreeRDP
ee004a0733c898ebbca35148bc2a306052ea99d4
@@ -0,0 +1,281 @@ +/** + * FreeRDP: A Remote Desktop Protocol Implementation + * Print Virtual Channel - Android backend + * + * Copyright 2026 Ibrahim Sevinc <ibrahim.sevinc.mail@gmail.com> + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with t...
bad
review
c
FreeRDP/FreeRDP
c23d971462ac53f78cc50cd53d366060aec92e27
diff --git a/channels/printer/client/android/printer_android.c b/channels/printer/client/android/printer_android.c new file mode 100644 index 000000000000..c6fb6f4f862c --- /dev/null +++ b/channels/printer/client/android/printer_android.c @@ -0,0 +1,282 @@ +/** + * FreeRDP: A Remote Desktop Protocol Implementation + * ...
good
review_fixed
c
FreeRDP/FreeRDP
c23d971462ac53f78cc50cd53d366060aec92e27
@@ -404,6 +404,9 @@ public static boolean setConnectionInfo(Context context, long inst, BookmarkBase args.add("/clipboard"); args.add("/disp"); + if (advanced.getRedirectPrinter()) + args.add("/printer:aFreeRDP Print,Microsoft Print to PDF:android,default");
bad
review
java
FreeRDP/FreeRDP
c23d971462ac53f78cc50cd53d366060aec92e27
diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/services/LibFreeRDP.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/services/LibFreeRDP.java index 0fbb91460fdd..a651e46845b1 100644 --- a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freer...
good
review_fixed
java
FreeRDP/FreeRDP
c23d971462ac53f78cc50cd53d366060aec92e27
@@ -52,10 +52,10 @@ <data android:scheme="content" /> <data android:host="*" /> - <!-- Ugly hack to match all files with a dot in its name. - Remove if a better way is found / supported. - https://stackoverflow.com/questions/3400072/pathpa...
bad
review
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
diff --git a/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml b/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml index 3cf9650abe7f..d7e9c2513454 100644 --- a/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml +++ b/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml @@ -52,10 +52...
good
review_fixed
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
@@ -121,20 +122,23 @@ else if (ConnectionReference.isHostnameReference(refStr)) } else if (ConnectionReference.isFileReference(refStr)) { - String file = ConnectionReference.getFile(refStr); + String fileRef = ConnectionReference.getFile(refStr); bookmark = new BookmarkBase(); - bookmar...
bad
review
java
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/BookmarkViewModel.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/BookmarkViewModel.java index f96573d43455..aff96a871fe2 100644 --- a/client/Android/Studio/freeRDPCore/src/main/...
good
review_fixed
java
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
@@ -0,0 +1,257 @@ +package com.freerdp.freerdpcore.utils; + +import android.util.Log; + +import com.freerdp.freerdpcore.domain.BookmarkBase; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.StringReader; +import java.nio.charset.StandardCharsets; + +publ...
bad
review
java
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java new file mode 100644 index 000000000000..c10732b91c2b --- /dev/null +++ b/client/Android/Studio/freeRDPCore/src...
good
review_fixed
java
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
@@ -0,0 +1,257 @@ +package com.freerdp.freerdpcore.utils; + +import android.util.Log; + +import com.freerdp.freerdpcore.domain.BookmarkBase; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.StringReader; +import java.nio.charset.StandardCharsets; + +publ...
bad
review
java
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java new file mode 100644 index 000000000000..c10732b91c2b --- /dev/null +++ b/client/Android/Studio/freeRDPCore/src...
good
review_fixed
java
FreeRDP/FreeRDP
73aed8cc21c098141f83afbea00782b74da3fae6
@@ -599,11 +599,15 @@ static TlsTransportStatus_t tlsHandshake( NetworkContext_t * pNetworkContext, if( returnStatus == TLS_TRANSPORT_SUCCESS ) { /* Perform the TLS handshake. */ + TickType_t handshakeTimeoutTicks = pdMS_TO_TICKS(ipconfigSOCK_DEFAULT_RECEIVE_BLOCK_TIME); + TimeOut_t handshakeStart...
bad
review
c
FreeRTOS/FreeRTOS
9648805000215ede1f6660799dd11359d5707aef
diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c index b668ea11dce..e6350e56d7b 100644 --- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c +++ b/FreeRTOS-Plu...
good
review_fixed
c
FreeRTOS/FreeRTOS
9648805000215ede1f6660799dd11359d5707aef
@@ -599,11 +599,16 @@ static TlsTransportStatus_t tlsHandshake( NetworkContext_t * pNetworkContext, if( returnStatus == TLS_TRANSPORT_SUCCESS ) { /* Perform the TLS handshake. */ + TickType_t handshakeTimeoutTicks = pdMS_TO_TICKS( 10000 ); + TimeOut_t handshakeStart; + vTaskSetTi...
bad
review
c
FreeRTOS/FreeRTOS
9648805000215ede1f6660799dd11359d5707aef
diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c index b668ea11dce..e6350e56d7b 100644 --- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c +++ b/FreeRTOS-Plu...
good
review_fixed
c
FreeRTOS/FreeRTOS
9648805000215ede1f6660799dd11359d5707aef
@@ -104,7 +104,7 @@ /** * @brief Timeout for receiving CONNACK packet in milliseconds. */ -#define mqttexampleCONNACK_RECV_TIMEOUT_MS ( 1000U ) +#define mqttexampleCONNACK_RECV_TIMEOUT_MS ( 10000U )
bad
review
c
FreeRTOS/FreeRTOS
33c6547825e26bc49fcfe489168119bbfe6e19e7
diff --git a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c index 144d180a96e..5b2bb88f6eb 100644 --- a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c +++ b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c @@ -104,7 +...
good
review_fixed
c
FreeRTOS/FreeRTOS
33c6547825e26bc49fcfe489168119bbfe6e19e7
@@ -98,7 +98,7 @@ /** * @brief Timeout for receiving CONNACK packet in milliseconds. */ -#define mqttexampleCONNACK_RECV_TIMEOUT_MS ( 1000U ) +#define mqttexampleCONNACK_RECV_TIMEOUT_MS ( 10000U )
bad
review
c
FreeRTOS/FreeRTOS
33c6547825e26bc49fcfe489168119bbfe6e19e7
diff --git a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c index 170e35758ef..617f0e916ce 100644 --- a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c +++ b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs1...
good
review_fixed
c
FreeRTOS/FreeRTOS
33c6547825e26bc49fcfe489168119bbfe6e19e7
@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle() void test_vTaskPriorityDisinheritAfterTimeout_success() { TaskHandle_t mutex_holder; + UBaseType_t inheritedPriority = 5U; + /* Tasks at priority 1-3 are ready */ + UBaseType_t lowPriorityTasksReady = 0xEU;
bad
review
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c index 529224ad3de..19a9fb92ce2 100644 --- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c +++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c @@ -50,7 +50,6 @@ #include <string.h> #include <stdlib.h> - /* ===================...
good
review_fixed
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle() void test_vTaskPriorityDisinheritAfterTimeout_success() { TaskHandle_t mutex_holder; + UBaseType_t inheritedPriority = 5U; + /* Tasks at priority 1-3 are ready */ + UBaseType_t lowPriorityTasksReady = 0xEU; /...
bad
review
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c index 529224ad3de..19a9fb92ce2 100644 --- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c +++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c @@ -50,7 +50,6 @@ #include <string.h> #include <stdlib.h> - /* ===================...
good
review_fixed
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle() void test_vTaskPriorityDisinheritAfterTimeout_success() { TaskHandle_t mutex_holder; + UBaseType_t inheritedPriority = 5U; + /* Tasks at priority 1-3 are ready */ + UBaseType_t lowPriorityTasksReady = 0xEU; /...
bad
review
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c index 529224ad3de..19a9fb92ce2 100644 --- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c +++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c @@ -50,7 +50,6 @@ #include <string.h> #include <stdlib.h> - /* ===================...
good
review_fixed
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle() void test_vTaskPriorityDisinheritAfterTimeout_success() { TaskHandle_t mutex_holder; + UBaseType_t inheritedPriority = 5U; + /* Tasks at priority 1-3 are ready */ + UBaseType_t lowPriorityTasksReady = 0xEU; /...
bad
review
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c index 529224ad3de..19a9fb92ce2 100644 --- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c +++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c @@ -50,7 +50,6 @@ #include <string.h> #include <stdlib.h> - /* ===================...
good
review_fixed
c
FreeRTOS/FreeRTOS
b89c8003f3a62ad2e0dd6b17f3a39920b59a3610
@@ -95,7 +95,7 @@ FreeRTOS/Source/tasks.c for limitations. */ #define configKERNEL_INTERRUPT_PRIORITY ( 255 ) /* All eight bits as QEMU doesn't model the priority bits. */ /* !!!! configMAX_SYSCALL_INTERRUPT_PRIORITY must not be set to zero !!!! See http://www.FreeRTOS.org/RTOS-Cortex-M3-M4.html. */ -#define confi...
bad
review
c
FreeRTOS/FreeRTOS
39be190e3f530a748f69fda6835680a6abd15696
diff --git a/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h b/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h index ab1923b6c60..3267b6de0a9 100644 --- a/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h +++ b/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h @@ -95,7 +95,7 @@ FreeRTOS/Sour...
good
review_fixed
c
FreeRTOS/FreeRTOS
39be190e3f530a748f69fda6835680a6abd15696
@@ -16,53 +16,12 @@ how to run the proofs on your local clone of a:FR. Bulding and running proofs
bad
review
FreeRTOS/FreeRTOS
e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5
diff --git a/FreeRTOS/Test/CBMC/README.md b/FreeRTOS/Test/CBMC/README.md index 09d5e14810b..00baa4423a4 100644 --- a/FreeRTOS/Test/CBMC/README.md +++ b/FreeRTOS/Test/CBMC/README.md @@ -10,118 +10,73 @@ The proofs are checked using the [C Bounded Model Checker](http://www.cprover.org/cbmc/), an open-source static anal...
good
review_fixed
FreeRTOS/FreeRTOS
e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5
@@ -16,53 +16,12 @@ how to run the proofs on your local clone of a:FR. Bulding and running proofs -------------------------- -For historical reasons, some of the proofs are built and run using CMake -and CTest. Others use a custom python-based build system. New proofs -should use CMake. This README describes how to...
bad
review
FreeRTOS/FreeRTOS
e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5
diff --git a/FreeRTOS/Test/CBMC/README.md b/FreeRTOS/Test/CBMC/README.md index 09d5e14810b..00baa4423a4 100644 --- a/FreeRTOS/Test/CBMC/README.md +++ b/FreeRTOS/Test/CBMC/README.md @@ -10,118 +10,73 @@ The proofs are checked using the [C Bounded Model Checker](http://www.cprover.org/cbmc/), an open-source static anal...
good
review_fixed
FreeRTOS/FreeRTOS
e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5
@@ -46,7 +46,7 @@ #define configUSE_TICK_HOOK 1 #define configCPU_CLOCK_HZ ( ( unsigned long ) 25000000 ) #define configTICK_RATE_HZ ( ( TickType_t ) 1000 ) -#define configMINIMAL_STACK_SIZE ( ( unsigned short ) 88 ) +#define configMINI...
bad
review
c
FreeRTOS/FreeRTOS
884070a871df133c35e124ac65dcf5d3dee27f0c
diff --git a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h index 3c67e2edde2..b6c0130becd 100644 --- a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h +++ b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h @@ -46,8 +46,8 @@ #define conf...
good
review_fixed
c
FreeRTOS/FreeRTOS
884070a871df133c35e124ac65dcf5d3dee27f0c
@@ -337,19 +335,3 @@ int __write( int iFile, return iStringLength; } -/*-----------------------------------------------------------*/ - -void * malloc( size_t size )
bad
review
c
FreeRTOS/FreeRTOS
884070a871df133c35e124ac65dcf5d3dee27f0c
diff --git a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c index 3798c9d5978..3dbfbd48db4 100644 --- a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c +++ b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c @@ -210,8 +210,6 @@ void vApplicationTickHook( void ) #if ( main...
good
review_fixed
c
FreeRTOS/FreeRTOS
884070a871df133c35e124ac65dcf5d3dee27f0c
@@ -462,13 +462,19 @@ static void setOptionalConfigurations( SSLContext_t * pSslContext, { mbedtlsError = mbedtls_ssl_set_hostname( &( pSslContext->context ), pHostName ); + } + /* MbedTLS-3.6.3 requires calling the mbedtls_ssl_set_hostname() before ...
bad
review
c
FreeRTOS/FreeRTOS
0a97f9956fccffe47abfa00ab60ac7651f527c03
diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c index a0798e9e444..b668ea11dce 100644 --- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c +++ b/FreeRTOS-Plu...
good
review_fixed
c
FreeRTOS/FreeRTOS
0a97f9956fccffe47abfa00ab60ac7651f527c03
@@ -28,14 +28,14 @@ #include <task.h> #include <FreeRTOSConfig.h> +#include <FreeRTOSIPConfig.h> #include <string.h> #include <stdarg.h> #include <stdio.h> void vApplicationStackOverflowHook( TaskHandle_t pxTask, char * pcTaskName ); -void vApplicationMallocFailedHook( v...
bad
review
c
FreeRTOS/FreeRTOS
4f6e73fd43f9b09286b21063d618169f9464a227
diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c index ec5f5650c85..53a05d6a2df 100644 --- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c +++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c @@ -28,15 +28,16 @@...
good
review_fixed
c
FreeRTOS/FreeRTOS
4f6e73fd43f9b09286b21063d618169f9464a227
@@ -28,14 +28,14 @@ #include <task.h> #include <FreeRTOSConfig.h> +#include <FreeRTOSIPConfig.h>
bad
review
c
FreeRTOS/FreeRTOS
4f6e73fd43f9b09286b21063d618169f9464a227
diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c index ec5f5650c85..53a05d6a2df 100644 --- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c +++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c @@ -28,15 +28,16 @@...
good
review_fixed
c
FreeRTOS/FreeRTOS
4f6e73fd43f9b09286b21063d618169f9464a227
@@ -63,7 +63,7 @@ For the RVA23 build: ``` $ qemu-system-riscv64 -nographic -machine virt -net none -chardev stdio,id=con,mux=on \ -serial chardev:con -mon chardev=con,mode=readline -bios none -smp 4 \ - -s --kernel build/gcc/output/RTOSDemo.elf + -cpu rv64,zba=true,zbb=true,v=true,vlen=256,vext_spec=v1.0,...
bad
review
FreeRTOS/FreeRTOS
4694a84ce1541975c57a441799dca68d10f53b26
diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md index 045d60eaba3..fd9fe5abead 100644 --- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md +++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md @@ -63,7 +63,7 @@ For the RVA23 build: ``` $ qemu-sys...
good
review_fixed
FreeRTOS/FreeRTOS
4694a84ce1541975c57a441799dca68d10f53b26
@@ -14,11 +14,10 @@ GCC_VERSION = $(shell $(CC) --version | grep ^$(CC) | sed 's/^.* //g' | awk -F. GCC_VERSION_NEED_ZICSR = "110100" ifeq ($(RVA23),1) - # For the time being, we don't include the vector extensions. - MARCH = rv64imafdc_zicsr_zicntr_zihpm_ziccif_ziccrse_ziccamoa_zicclsm_za64rs_zihintpause_zic64b_...
bad
review
FreeRTOS/FreeRTOS
4694a84ce1541975c57a441799dca68d10f53b26
diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile index d23da92603c..d8be9f7e4e7 100644 --- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile +++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile @@ -14,11 +14,10 @@...
good
review_fixed
FreeRTOS/FreeRTOS
4694a84ce1541975c57a441799dca68d10f53b26