text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -531,26 +534,30 @@ private async Task OpenResultAsync(string index) // For query mode, we execute the result else { - var hideWindow = await result.ExecuteAsync(new ActionContext + hideWindow = await result.ExecuteAsync(new ActionContext ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
654026e66308bf833b0a152abc0ebe3527f963c7
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index 333ac3652f4..6a4d54f27ab 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -515,8 +515,11 @@ private async Task OpenResultAsync(string index) retu...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
654026e66308bf833b0a152abc0ebe3527f963c7
@@ -1349,7 +1349,9 @@ private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyI Localize.executeQuery(h.Query) : h.Title, SubTitle = Localize.lastExecuteTime(h.ExecutedDateTime), - IcoPath = ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -59,6 +59,8 @@ public void Add(Result result) PluginID = result.PluginID, Query = result.OriginQuery.RawQuery, RecordKey = result.RecordKey, + IcoPath = result.IcoPath,
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1320,78 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems) { var results = new List<R...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -4,11 +4,13 @@ using System.Threading.Tasks; using System.Windows.Controls; using System.Windows.Media; +using System.Text.Json.Serialization; namespace Flow.Launcher.Plugin { /// <summary> - /// Describes a result of a <see cref="Query"/> executed by a plugin + /// Describes a result of a <see cre...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher.Plugin/Result.cs b/Flow.Launcher.Plugin/Result.cs index 2c9b8d4fdbc..9404d110705 100644 --- a/Flow.Launcher.Plugin/Result.cs +++ b/Flow.Launcher.Plugin/Result.cs @@ -4,11 +4,13 @@ using System.Threading.Tasks; using System.Windows.Controls; using System.Windows.Media; +using System.Text.Js...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -0,0 +1,121 @@ +using System; +using System.DirectoryServices.ActiveDirectory; +using Flow.Launcher.Helper; +using Flow.Launcher.Plugin; + +namespace Flow.Launcher.Storage; + +/// <summary> +/// A serializable result used to record the last opened history for reopening results. +/// Inherits common result fields fr...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs new file mode 100644 index 00000000000..7f571b76862 --- /dev/null +++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs @@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Lau...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -0,0 +1,121 @@ +using System; +using System.DirectoryServices.ActiveDirectory; +using Flow.Launcher.Helper; +using Flow.Launcher.Plugin; + +namespace Flow.Launcher.Storage; + +/// <summary> +/// A serializable result used to record the last opened history for reopening results. +/// Inherits common result fields fr...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs new file mode 100644 index 00000000000..7f571b76862 --- /dev/null +++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs @@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Lau...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -0,0 +1,121 @@ +using System; +using System.DirectoryServices.ActiveDirectory; +using Flow.Launcher.Helper; +using Flow.Launcher.Plugin; + +namespace Flow.Launcher.Storage; + +/// <summary> +/// A serializable result used to record the last opened history for reopening results. +/// Inherits common result fields fr...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs new file mode 100644 index 00000000000..7f571b76862 --- /dev/null +++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs @@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Lau...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -14,28 +16,52 @@ public class History #pragma warning restore CS0618 // Type or member is obsolete [JsonInclude] - public List<LastOpenedHistoryItem> LastOpenedHistoryItems { get; private set; } = []; + public List<LastOpenedHistoryResult> LastOpenedHistoryItems { get; private set; } = []; ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -355,7 +355,9 @@ private void LoadHistory() if (QueryResultsSelected()) { SelectedResults = History; - History.SelectedIndex = _history.LastOpenedHistoryItems.Count - 1; + + SelectedResults.SelectedIndex = 0; + SelectedResults.Se...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1,4 +1,5 @@ using System; +using System.Collections;
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1323,77 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems) { var results = new List<R...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -0,0 +1,117 @@ +using System; +using Flow.Launcher.Plugin; + +namespace Flow.Launcher.Storage; + +/// <summary> +/// A serializable result used to record the last opened history for reopening results. +/// Inherits common result fields from <see cref="Result"/> and adds the original query and execution time. +/// <...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs new file mode 100644 index 00000000000..7f571b76862 --- /dev/null +++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs @@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Lau...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -259,6 +259,8 @@ await API.StopwatchLogInfoAsync(ClassName, "Startup cost", async () => await PluginManager.InitializePluginsAsync(_mainVM); + _mainVM.RefreshLastOpenedHistoryResults();
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/App.xaml.cs b/Flow.Launcher/App.xaml.cs index b45bbc5494a..da11380b861 100644 --- a/Flow.Launcher/App.xaml.cs +++ b/Flow.Launcher/App.xaml.cs @@ -259,6 +259,9 @@ await API.StopwatchLogInfoAsync(ClassName, "Startup cost", async () => await PluginManager.InitializePlugins...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -152,11 +153,10 @@ public MainViewModel() }; _historyItemsStorage = new FlowLauncherJsonStorage<History>(); - _userSelectedRecordStorage = new FlowLauncherJsonStorage<UserSelectedRecord>(); - _topMostRecord = new FlowLauncherJsonStorageTopMostRecord(); _...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -355,7 +355,11 @@ private void LoadHistory() if (QueryResultsSelected()) { SelectedResults = History; - History.SelectedIndex = _history.LastOpenedHistoryItems.Count - 1; + if (History.Results.Count > 0) + { + ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1322,82 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems) { var results = new List<R...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1322,82 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems) { var results = new List<R...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -355,7 +355,11 @@ private void LoadHistory() if (QueryResultsSelected()) { SelectedResults = History; - History.SelectedIndex = _history.LastOpenedHistoryItems.Count - 1; + if (History.Results.Count > 0) + { + ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -0,0 +1,117 @@ +using System; +using Flow.Launcher.Plugin; + +namespace Flow.Launcher.Storage; + +/// <summary> +/// A serializable result used to record the last opened history for reopening results. +/// Inherits common result fields from <see cref="Result"/> and adds the original query and execution time. +/// <...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs new file mode 100644 index 00000000000..7f571b76862 --- /dev/null +++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs @@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Lau...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -0,0 +1,117 @@ +using System; +using Flow.Launcher.Plugin; + +namespace Flow.Launcher.Storage; + +/// <summary> +/// A serializable result used to record the last opened history for reopening results. +/// Inherits common result fields from <see cref="Result"/> and adds the original query and execution time. +/// <...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs new file mode 100644 index 00000000000..7f571b76862 --- /dev/null +++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs @@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Lau...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -44,23 +88,50 @@ public void Add(Result result) LastOpenedHistoryItems.RemoveAt(0); } - // If the last item is the same as the current result, just update the timestamp - if (LastOpenedHistoryItems.Count > 0 && - LastOpenedHistoryItems.Last().Equa...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1352,6 +1352,18 @@ private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> histor if (Settings.HistoryStyle == HistoryStyle.Query) { copiedItem.Title = Localize.executeQuery(copiedItem.Query); + copiedItem.IcoPath = Constant...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -24,7 +24,7 @@ public static class ResultHelper if (query == null) return null; try { - var freshResults = await plugin.Plugin.QueryAsync(query, CancellationToken.None); + var freshResults = await PluginManager.QueryForPluginAsync(plugin, query, CancellationToken.None...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Helper/ResultHelper.cs b/Flow.Launcher/Helper/ResultHelper.cs index b8b7ff98ec5..017651fdf93 100644 --- a/Flow.Launcher/Helper/ResultHelper.cs +++ b/Flow.Launcher/Helper/ResultHelper.cs @@ -11,7 +11,7 @@ namespace Flow.Launcher.Helper; public static class ResultHelper { - public static...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -44,23 +70,72 @@ public void Add(Result result) LastOpenedHistoryItems.RemoveAt(0); } - // If the last item is the same as the current result, just update the timestamp - if (LastOpenedHistoryItems.Count > 0 && - LastOpenedHistoryItems.Last().Equa...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1317,106 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems, int? selectLast = null) { ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -44,23 +70,73 @@ public void Add(Result result) LastOpenedHistoryItems.RemoveAt(0); } - // If the last item is the same as the current result, just update the timestamp - if (LastOpenedHistoryItems.Count > 0 && - LastOpenedHistoryItems.Last().Equa...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -44,23 +70,50 @@ public void Add(Result result) LastOpenedHistoryItems.RemoveAt(0); } - // If the last item is the same as the current result, just update the timestamp - if (LastOpenedHistoryItems.Count > 0 && - LastOpenedHistoryItems.Last().Equa...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -14,28 +16,52 @@ public class History #pragma warning restore CS0618 // Type or member is obsolete [JsonInclude] - public List<LastOpenedHistoryItem> LastOpenedHistoryItems { get; private set; } = []; + public List<LastOpenedHistoryResult> LastOpenedHistoryItems { get; private set; } = []; ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -431,14 +435,17 @@ private void LoadContextMenu() { // When switch to ContextMenu from QueryResults, but no item being chosen, should do nothing // i.e. Shift+Enter/Ctrl+O right after Alt + Space should do nothing - if (SelectedResults.SelectedItem != nul...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -431,14 +435,17 @@ private void LoadContextMenu() { // When switch to ContextMenu from QueryResults, but no item being chosen, should do nothing // i.e. Shift+Enter/Ctrl+O right after Alt + Space should do nothing - if (SelectedResults.SelectedItem != nul...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -642,6 +649,8 @@ private void Esc() if (!QueryResultsSelected()) { SelectedResults = Results; + PreviewSelectedItem = Results.SelectedItem;
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1252,22 +1261,12 @@ private void QueryContextMenu() var selected = Results.SelectedItem?.Result; - if (selected != null) // SelectedItem returns null if selection is empty. + if (selected != null && // SelectedItem returns null if selection is empty. + !string.I...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1317,100 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems, int? selectLast = null)
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1317,100 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems, int? selectLast = null) { ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1317,100 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems, int? selectLast = null) { ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1318,68 +1317,100 @@ private void QueryHistory() } } - private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems) + private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> historyItems, int? selectLast = null) { ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -1617,10 +1648,8 @@ await PluginManager.QueryHomeForPluginAsync(plugin, query, token) : void QueryHistoryTask(CancellationToken token) { - // Select last history results and revert its order to make sure last history results are on top - var historyItems = _h...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Launcher.Plugin; + +namespace Flow.Launcher.Storage; + +/// <summary> +/// A serializable result used to record the last opened history for reopening results. +/// Inherits common result fields from <see cref="Result"/> and adds the orig...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs new file mode 100644 index 00000000000..7f571b76862 --- /dev/null +++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs @@ -0,0 +1,146 @@ +using System; +using Flow.Launcher.Infrastructure; +using Flow.Lau...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -44,23 +68,53 @@ public void Add(Result result) LastOpenedHistoryItems.RemoveAt(0); } - // If the last item is the same as the current result, just update the timestamp - if (LastOpenedHistoryItems.Count > 0 && - LastOpenedHistoryItems.Last().Equa...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs index 6998a4ae3f0..7bf94839925 100644 --- a/Flow.Launcher/Storage/QueryHistory.cs +++ b/Flow.Launcher/Storage/QueryHistory.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Text.Json.Serializ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -426,19 +429,23 @@ private void LoadContextMenu() return; } + // Do not show context menu for history results, they will have no PluginID set. + if (string.IsNullOrEmpty(SelectedResults.SelectedItem?.Result?.PluginID)) + return; + // F...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs index a28b2b33e93..ba170feb0be 100644 --- a/Flow.Launcher/ViewModel/MainViewModel.cs +++ b/Flow.Launcher/ViewModel/MainViewModel.cs @@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -131,17 +155,19 @@ public string BadgeIcoPath /// <summary> /// Delegate to load an icon for this result. /// </summary> + [JsonIgnore] public IconDelegate Icon = null; /// <summary> /// Delegate to load an icon for the badge of this result. ///...
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher.Plugin/Result.cs b/Flow.Launcher.Plugin/Result.cs index 2c9b8d4fdbc..9404d110705 100644 --- a/Flow.Launcher.Plugin/Result.cs +++ b/Flow.Launcher.Plugin/Result.cs @@ -4,11 +4,13 @@ using System.Threading.Tasks; using System.Windows.Controls; using System.Windows.Media; +using System.Text.Js...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -64,15 +68,27 @@ public string CopyText public string AutoCompleteText { get; set; } /// <summary> - /// The image to be displayed for the result. + /// Path or URI to the icon image for this result. + /// Updates <IcoPathAbsolute/> appropriately when set.
bad
review
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
diff --git a/Flow.Launcher.Plugin/Result.cs b/Flow.Launcher.Plugin/Result.cs index 2c9b8d4fdbc..9404d110705 100644 --- a/Flow.Launcher.Plugin/Result.cs +++ b/Flow.Launcher.Plugin/Result.cs @@ -4,11 +4,13 @@ using System.Threading.Tasks; using System.Windows.Controls; using System.Windows.Media; +using System.Text.Js...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
248da93d05120dbe8b99db9afca35eff893f3d9b
@@ -48,13 +54,14 @@ internal IEnumerable<PluginPair> Setup() return new List<PluginPair>(); } - if (!string.IsNullOrEmpty(PluginsSettingsFilePath) && FilesFolders.FileExists(PluginsSettingsFilePath)) + var resolvedPath = ResolvedPluginsSettingsFilePath; + ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs index 1a324a9930a..91f3c09c4ee 100644 --- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs +++ b/Flow.Launcher.Core/Exter...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
@@ -40,6 +40,12 @@ internal AbstractPluginEnvironment(List<PluginMetadata> pluginMetadataList, Plug PluginSettings = pluginSettings; } + /// <summary> + /// Resolves the configured plugin settings file path to an absolute path.
bad
review
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs index 1a324a9930a..91f3c09c4ee 100644 --- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs +++ b/Flow.Launcher.Core/Exter...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
@@ -48,13 +54,16 @@ internal IEnumerable<PluginPair> Setup() return new List<PluginPair>(); } - if (!string.IsNullOrEmpty(PluginsSettingsFilePath) && FilesFolders.FileExists(PluginsSettingsFilePath)) + var resolvedPath = ResolvedPluginsSettingsFilePath; + ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs index 1a324a9930a..91f3c09c4ee 100644 --- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs +++ b/Flow.Launcher.Core/Exter...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
@@ -48,13 +54,16 @@ internal IEnumerable<PluginPair> Setup() return new List<PluginPair>(); } - if (!string.IsNullOrEmpty(PluginsSettingsFilePath) && FilesFolders.FileExists(PluginsSettingsFilePath)) + var resolvedPath = ResolvedPluginsSettingsFilePath; + ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs index 1a324a9930a..91f3c09c4ee 100644 --- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs +++ b/Flow.Launcher.Core/Exter...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
8b6f9f4367d059a1758bfbf3f6607b1bb86156be
@@ -667,11 +667,11 @@ private void SetBlurForWindow(string theme, BackdropTypes backdropType) if (mainWindow == null) return; // Check if the theme supports blur - bool hasBlur = dict.Contains("ThemeBlurEnabled") && dict["ThemeBlurEnabled"] is bool b && b; + var hasBlur...
bad
review
csharp
Flow-Launcher/Flow.Launcher
dad8f3e6951f21f1387274b1bb4adf0c9bfcb6c4
diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs index 4d15857e6fa..fb463b4d4c0 100644 --- a/Flow.Launcher.Core/Resource/Theme.cs +++ b/Flow.Launcher.Core/Resource/Theme.cs @@ -124,8 +124,8 @@ public void UpdateFonts() try { // Load a Re...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
dad8f3e6951f21f1387274b1bb4adf0c9bfcb6c4
@@ -477,76 +477,113 @@ public bool ChangeTheme(string theme = null) public void AddDropShadowEffectToCurrentTheme() { - var dict = GetCurrentResourceDictionary(); + // Get current theme's WindowBorderStyle + var theme = _settings.Theme; + var dict = GetThe...
bad
review
csharp
Flow-Launcher/Flow.Launcher
3c8266126268f4e0aa6144cbcb6f331d6412bfb8
diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs index fb463b4d4c0..a32a59b486e 100644 --- a/Flow.Launcher.Core/Resource/Theme.cs +++ b/Flow.Launcher.Core/Resource/Theme.cs @@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null) public void AddDropShadowEff...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
3c8266126268f4e0aa6144cbcb6f331d6412bfb8
@@ -477,76 +477,113 @@ public bool ChangeTheme(string theme = null) public void AddDropShadowEffectToCurrentTheme() { - var dict = GetCurrentResourceDictionary(); + // Get current theme's WindowBorderStyle + var theme = _settings.Theme; + var dict = GetThe...
bad
review
csharp
Flow-Launcher/Flow.Launcher
3c8266126268f4e0aa6144cbcb6f331d6412bfb8
diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs index fb463b4d4c0..a32a59b486e 100644 --- a/Flow.Launcher.Core/Resource/Theme.cs +++ b/Flow.Launcher.Core/Resource/Theme.cs @@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null) public void AddDropShadowEff...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
3c8266126268f4e0aa6144cbcb6f331d6412bfb8